From owner-cvs-src@FreeBSD.ORG Sun Dec 12 14:25:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CD5A516A4CE; Sun, 12 Dec 2004 14:25:32 +0000 (GMT) Received: from mta05-winn.mailhost.ntl.com (mailhost.ntl.com [212.250.162.8]) by mx1.FreeBSD.org (Postfix) with ESMTP id 53A2643D4C; Sun, 12 Dec 2004 14:25:31 +0000 (GMT) (envelope-from scott@fishballoon.org) Received: from aamta06-winn.mailhost.ntl.com ([212.250.162.8]) by mta05-winn.mailhost.ntl.com with ESMTP <20041212142530.MZTI7776.mta05-winn.mailhost.ntl.com@aamta06-winn.mailhost.ntl.com>; Sun, 12 Dec 2004 14:25:30 +0000 Received: from llama.fishballoon.org ([82.4.146.133]) by aamta06-winn.mailhost.ntl.com with ESMTP <20041212142530.IQMO1456.aamta06-winn.mailhost.ntl.com@llama.fishballoon.org>; Sun, 12 Dec 2004 14:25:30 +0000 Received: from tuatara.fishballoon.org ([192.168.1.6]) by llama.fishballoon.org with esmtp (Exim 4.43 (FreeBSD)) id 1CdUfH-0008ig-AK; Sun, 12 Dec 2004 14:25:35 +0000 Received: (from scott@localhost) by tuatara.fishballoon.org (8.13.1/8.13.1/Submit) id iBCEQeUN092921; Sun, 12 Dec 2004 14:26:40 GMT (envelope-from scott) Date: Sun, 12 Dec 2004 14:26:40 +0000 From: Scott Mitchell To: Ian Dowse Message-ID: <20041212142640.GF68019@tuatara.fishballoon.org> References: <20041212133752.GE68019@tuatara.fishballoon.org> <200412121411.aa89799@salmon.maths.tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200412121411.aa89799@salmon.maths.tcd.ie> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 4.10-STABLE i386 cc: src-committers@freebsd.org cc: cvs-src@freebsd.org cc: Scott Long cc: cvs-all@freebsd.org cc: Ceri Davies cc: Julian Elischer Subject: Re: cvs commit: src/sys/sys mouse.h src/sys/dev/usb ums.c usbhid.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Dec 2004 14:25:33 -0000 On Sun, Dec 12, 2004 at 02:11:22PM +0000, Ian Dowse wrote: > In message <20041212133752.GE68019@tuatara.fishballoon.org>, Scott Mitchell wri > tes: > >On Sun, Dec 12, 2004 at 12:23:05PM +0000, Ceri Davies wrote: > >> On Sat, Dec 11, 2004 at 10:39:10PM -0700, Scott Long wrote: > >> > Julian Elischer wrote: > >> > > Add support for USB Microsoft Intellimouse > >> > > > >> > > PR: kern/70607 > >> > > Submitted by: Matt Wright > >> > > MFC after: 1 week > >> > > >> > What 'support' does this add? > >> > >> They have another axis on the wheel: you can tilt it from left to right. > >> > >> Ceri > > > >Apart from that, the device in question (wireless Intellimouse 2.0) didn't > >work as any kind of mouse without this patch. > > > > Scott > > As pointed out in the PR though, it doesn't seem necessary to change > struct mousestatus and the MOUSE_GETSTATUS ioctl API just to make > the device work. All other mouse drivers in the tree will need to > be updated to initialise the new `dt' field. There's also one part > of the patch that looks as if it could easily break other devices: Ahhh, my bad. I'd read the PR and thought it was the last version mentioned by marko@ (without the mousestatus change) that had been committed. Although now that I look a bit closer I can't actually find that version anywhere. I'll shut up now. Scott -- =========================================================================== Scott Mitchell | PGP Key ID | "Eagles may soar, but weasels Cambridge, England | 0x54B171B9 | don't get sucked into jet engines" scott at fishballoon.org | 0xAA775B8B | -- Anon