From owner-freebsd-doc@FreeBSD.ORG Mon Aug 28 20:19:49 2006 Return-Path: X-Original-To: doc@freebsd.org Delivered-To: freebsd-doc@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10D4916A4DA; Mon, 28 Aug 2006 20:19:49 +0000 (UTC) (envelope-from simon@zaphod.nitro.dk) Received: from mx.nitro.dk (zarniwoop.nitro.dk [83.92.207.38]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9788643D45; Mon, 28 Aug 2006 20:19:46 +0000 (GMT) (envelope-from simon@zaphod.nitro.dk) Received: from zaphod.nitro.dk (unknown [192.168.3.39]) by mx.nitro.dk (Postfix) with ESMTP id B5BE732E449; Mon, 28 Aug 2006 20:19:45 +0000 (UTC) Received: by zaphod.nitro.dk (Postfix, from userid 3000) id A71131141D; Mon, 28 Aug 2006 22:19:45 +0200 (CEST) Date: Mon, 28 Aug 2006 22:19:45 +0200 From: "Simon L. Nielsen" To: Daniel Gerzo Message-ID: <20060828201944.GE1033@zaphod.nitro.dk> References: <1418203821.20060822110342@rulez.sk> <20060827130122.GB1149@zaphod.nitro.dk> <51457742.20060827154106@rulez.sk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51457742.20060827154106@rulez.sk> User-Agent: Mutt/1.5.11 Cc: doc@freebsd.org Subject: Re: merge query-pr.cgi and query-pr-summary.cgi, fix -T mode with new perl X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Aug 2006 20:19:49 -0000 On 2006.08.27 15:41:06 +0200, Daniel Gerzo wrote: > Sunday, August 27, 2006, 3:01:23 PM, you wrote: > > > On 2006.08.22 11:03:42 +0200, Daniel Gerzo wrote: > > >> I have produced a patch [1] which combines two cgi scripts -- > >> query-pr.cgi and query-pr-summary.cgi. It merges functionality of > >> query-pr.cgi into -summary.cgi, but if we want to commit this I > >> would recommend to rename query-pr-summary.cgi to query-pr.cgi > >> (maybe symlink would be even better?) once commited. > > > What exactly is the advantage of combining the two into one CGI > > script? > > It's not big deal... > > http://www.freebsd.org/cgi/query-pr.cgi?pr=35647 Hey, Ah, I did seem to recall the suggestion from somewhere. I generally like keeping the CGI scripts as simple as possible - it makes them easier to read and modify. Especially scripts which do multiple tasks based on how they are called have a tendency to get more complicated than needed (at least that's my experience). >From my reading of the PR the problem is mainly that we have two different HTML pages to look up a PR by number and to search. A much simpler way to solve this would IMO be to have one HTML page with both forms which then simply submits to the right CGI script. This could either be a seperate HTML page or the form could just included in query-pr-summery.cgi. How does that sound instead of completely merging the scripts? -- Simon L. Nielsen