From owner-svn-src-all@FreeBSD.ORG  Wed Jan 28 15:27:16 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 70430529;
 Wed, 28 Jan 2015 15:27:16 +0000 (UTC)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id EF49D1CD;
 Wed, 28 Jan 2015 15:27:15 +0000 (UTC)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t0SFR5WR098228
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Wed, 28 Jan 2015 17:27:05 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t0SFR5WR098228
Received: (from kostik@localhost)
 by tom.home (8.14.9/8.14.9/Submit) id t0SFR5SP098226;
 Wed, 28 Jan 2015 17:27:05 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Wed, 28 Jan 2015 17:27:05 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: Andriy Gapon <avg@FreeBSD.org>
Subject: Re: svn commit: r277796 - in head/sys: dev/acpica dev/syscons dev/vt
 sys
Message-ID: <20150128152705.GM42409@kib.kiev.ua>
References: <201501271733.t0RHXJ3M058422@svn.freebsd.org>
 <20150127174742.GI42409@kib.kiev.ua> <54C8E9DE.4080709@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54C8E9DE.4080709@FreeBSD.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.0
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Jan 2015 15:27:16 -0000

On Wed, Jan 28, 2015 at 03:53:34PM +0200, Andriy Gapon wrote:
> On 27/01/2015 19:47, Konstantin Belousov wrote:
> > On Tue, Jan 27, 2015 at 05:33:19PM +0000, Andriy Gapon wrote:
> >>  
> >> +    EVENTHANDLER_INVOKE(power_suspend_early);
> >> +    stop_all_proc();
> > It also makes sense to call syncer_suspend() after stop_all_proc(),
> > I suppose.  It would ensure that a failed resume still ends with the
> > consistent filesystem metadata.
> 
> Probably yes.  I can make that change if you endorse it.  Or you can make it if
> that'll be faster.  Thanks!

I prefer that the change is made by somebody who uses and tests the suspension
code, i.e. you.