From owner-freebsd-current Sat Apr 27 17: 8:39 2002 Delivered-To: freebsd-current@freebsd.org Received: from fw.wemm.org (12-232-135-171.client.attbi.com [12.232.135.171]) by hub.freebsd.org (Postfix) with ESMTP id 74D5937B41B; Sat, 27 Apr 2002 17:08:36 -0700 (PDT) Received: from overcee.wemm.org (overcee.wemm.org [10.0.0.3]) by fw.wemm.org (8.11.6/8.11.6) with ESMTP id g3S08ae50773; Sat, 27 Apr 2002 17:08:36 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (Postfix) with ESMTP id 0808E3810; Sat, 27 Apr 2002 17:08:36 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Maxime Henrion Cc: current@freebsd.org Subject: Re: Recent commit to sys/kern/kern_environment.c broke reading tunables In-Reply-To: <20020428000146.GB63621@elvis.mu.org> Date: Sat, 27 Apr 2002 17:08:36 -0700 From: Peter Wemm Message-Id: <20020428000836.0808E3810@overcee.wemm.org> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Maxime Henrion wrote: > Peter Wemm wrote: > > This turned out to be part of the problem. I committed your patch and > > another followup that got the rest of it. The outstanding problems were: > > 1) checkmethod caused use_kenv to be set only once and the next time it > > was called, use_kenv would stay at zero and static hints only got used. > > 2) the termination of the kenvp[] loop could do a null deref. > > > > Anyway, I've committed both your and my changes, it should be working now. > > If anybody else sees problems still, please yell. > > Thanks for taking the time to fix this. I was unavailable the whole day > and tried to see what was causing the problem quickly this morning, but > I expected this to not be sufficient, and it indeed wasn't :-). I think a lot of this was hidden on i386 because of the acpi/pnpbios support, and the fact that a bunch of devices are hard coded in (clock etc). Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message