From owner-svn-src-head@freebsd.org Sun Jan 24 14:13:38 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B24849C2C51 for ; Sun, 24 Jan 2016 14:13:38 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qg0-x22f.google.com (mail-qg0-x22f.google.com [IPv6:2607:f8b0:400d:c04::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 68C25FA4 for ; Sun, 24 Jan 2016 14:13:38 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qg0-x22f.google.com with SMTP id 6so91281306qgy.1 for ; Sun, 24 Jan 2016 06:13:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=nVeM28EElP2c57G60j+MRwWZxy4xcqW7nvIcFM2rQxk=; b=uzzdDEqdFvGLMjJesICihw7J3XSCXtseZFpiCCnitZ6CYN6ZfmhnnIufO4YcH35t6a +dyle2DT6IPgk5x/VgS6HyByXX7LEmEi4SEPdjVfno9CEDI8JDpkzr1nPcnrVmHsQ5V6 +B+5Zg0cbVuY8J5iyvQWDyd0RFTWYNa+GKo5/WYAFeGj/YL/+GTf9MFjbDt0PRTWQwpv x1DraaY5RctgoMtApMlQ2xeWT3WeNzYi62NocEByM8xpseNpFVNkebPrGVprK0zTya4Z f0PlrD/s8UN1PhGWP5c/9aiF339gOuDAyWN8DHRX5I7npFcKzFabSG4vQew8akDh45kd p1yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=nVeM28EElP2c57G60j+MRwWZxy4xcqW7nvIcFM2rQxk=; b=ZVbEssD+IpI9oFrtnRiSncLtxaYxZY2mn0ayDE5AAihEW9zlqYY5f21twjHqJc+1G0 6Mx+8z1Yl6PRZqNtEr1wS1ZX1+Yyn7gormt9DXkmEzbtBrpfGrVJNFPG6qOY0iLXWL1Y Kv53puijOfrZOx77pKr79L/NzQahGhBAffQO9jTpZqU8lFuSBjUe56/xVKIZNNmxtlnA 7lu7QhyoX5LvAnE8YGDTyFPC//EQ2aQQ1PoqV+DQX0e1vhKYUzc7jFenf6/mwdkwFhsi xxVV2dU5RwJzmrvO+d42ZAeu6FEEacsLFfPiKgvuDmLScWhd5GjIHxL87xGo6fHSTfQu KVpg== X-Gm-Message-State: AG10YORUlwMSPT5s5svr9v+2inP4fTwQc1Gy45i0o3lKdGroH/qiZYfdeR99+qy+LCRdy6RX X-Received: by 10.140.171.5 with SMTP id r5mr16812202qhr.51.1453644817449; Sun, 24 Jan 2016 06:13:37 -0800 (PST) Received: from mutt-hardenedbsd (c-73-135-80-144.hsd1.md.comcast.net. [73.135.80.144]) by smtp.gmail.com with ESMTPSA id l139sm6874931qhc.24.2016.01.24.06.13.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Jan 2016 06:13:35 -0800 (PST) Date: Sun, 24 Jan 2016 09:13:33 -0500 From: Shawn Webb To: Alan Somers Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r294329 - in head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs: . sys Message-ID: <20160124141333.GA19117@mutt-hardenedbsd> References: <201601191700.u0JH0P6k061610@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2oS5YaxWCcQjTEyO" Content-Disposition: inline In-Reply-To: <201601191700.u0JH0P6k061610@repo.freebsd.org> X-Operating-System: FreeBSD mutt-hardenedbsd 11.0-CURRENT-HBSD FreeBSD 11.0-CURRENT-HBSD X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jan 2016 14:13:38 -0000 --2oS5YaxWCcQjTEyO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 19, 2016 at 05:00:25PM +0000, Alan Somers wrote: > Author: asomers > Date: Tue Jan 19 17:00:25 2016 > New Revision: 294329 > URL: https://svnweb.freebsd.org/changeset/base/294329 >=20 > Log: > Disallow zvol-backed ZFS pools > =20 > Using zvols as backing devices for ZFS pools is fraught with panics and > deadlocks. For example, attempting to online a missing device in the > presence of a zvol can cause a panic when vdev_geom tastes the zvol. B= etter > to completely disable vdev_geom from ever opening a zvol. The solution > relies on setting a thread-local variable during vdev_geom_open, and > returning EOPNOTSUPP during zvol_open if that thread-local variable is = set. > =20 > Remove the check for MUTEX_HELD(&zfsdev_state_lock) in zvol_open. Its i= ntent > was to prevent a recursive mutex acquisition panic. However, the new ch= eck > for the thread-local variable also fixes that problem. > =20 > Also, fix a panic in vdev_geom_taste_orphan. For an unknown reason, this > function was set to panic. But it can occur that a device disappears du= ring > tasting, and it causes no problems to ignore this departure. > =20 > Reviewed by: delphij > MFC after: 1 week > Relnotes: yes > Sponsored by: Spectra Logic Corp > Differential Revision: https://reviews.freebsd.org/D4986 I've just been bit by this pretty hard. I have a bhyve VM that's backed by a zvol. The VM is running root-on-zfs. I wrote some experimental code that's now preventing the VM from booting (kernel panic due to userland change). Since I can't import the pool, I have no way of fixing the problem. I'm probably just going to go revert this commit locally on my box so I can get some work done. Thanks, --=20 Shawn Webb HardenedBSD GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --2oS5YaxWCcQjTEyO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWpNwKAAoJEGqEZY9SRW7u0MUP/i7mAOrXGAWq9LUGWbZ2Khiq CIfq9DUKtwDvfEMSqk8tpvyMyqXll68BcFcZBT7lPOOX4DUhkKyYsvhllzu9Yq/a UHA+tXO/64WEXwTCMKBp3pPARr/wD7BRHturAQMgfsBmjWS3LbNXlle3fSMDfq5f X83wsvmU7AbYfmLS3twr9dP4kgp+LFcgGLC8zLHE7HkESXq/rEblLxrTUJCkdZuZ kT79/PkHrr0E8nhyOojCadLHfg1V0toc4Gj03ADHi17G3Bh5P8AZyniZa6fOdXtO Moc8+yMqqAmwh7J/R1QxNtGATs8oEhjgz+55jRUFVml+qlExC7aXh0PrOHSPkPc7 6890Z3HFSahDYbIfBQcku/O41i4DTOticyaAJ82O2Gc8VI4SZLagziai8RIGyETR qhqxJP3jP+g3KoF+QIQu72Ea6p/ww67Edweq80oHfSYsKKSRMP/lFrulIc4E1eP9 QHORBECiFnRvU0FQCNSuSeQ9W0IA5/Rl0Du7NNjaGpd+xsNlHKrjy50FmzgG/GWu HItpdZzQ6QhBbno2mr8AcyL4XoTi9sEWXHeKOWLx9VWqiYCfUKgkFAKh4VoJ+79r LbtMDbjDYstdnSTL7LUerRSz7iSPs/jI4Esoku4LZoCbV22ao0YiXWysR6BwSl0a L8pQ/dPnyR8VtAn7QnAb =1JIc -----END PGP SIGNATURE----- --2oS5YaxWCcQjTEyO--