From owner-freebsd-doc@FreeBSD.ORG Mon Aug 28 21:13:39 2006 Return-Path: X-Original-To: doc@freebsd.org Delivered-To: freebsd-doc@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7775D16A4DE; Mon, 28 Aug 2006 21:13:39 +0000 (UTC) (envelope-from danger@FreeBSD.org) Received: from virtual.micronet.sk (smtp.micronet.sk [84.16.32.237]) by mx1.FreeBSD.org (Postfix) with ESMTP id EE9F343D45; Mon, 28 Aug 2006 21:13:38 +0000 (GMT) (envelope-from danger@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by virtual.micronet.sk (Postfix) with ESMTP id 985F810E6D5; Mon, 28 Aug 2006 23:13:25 +0200 (CEST) X-Virus-Scanned: by amavisd-new at virtual.micronet.sk Received: from virtual.micronet.sk ([127.0.0.1]) by localhost (virtual.micronet.sk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PNi9sFFSkKc9; Mon, 28 Aug 2006 23:13:23 +0200 (CEST) Received: from danger.mcrn.sk (danger.mcrn.sk [84.16.37.254]) by virtual.micronet.sk (Postfix) with ESMTP id BA81610E6D1; Mon, 28 Aug 2006 23:13:23 +0200 (CEST) Date: Mon, 28 Aug 2006 23:13:30 +0200 From: Daniel Gerzo Organization: The FreeBSD Project X-Priority: 3 (Normal) Message-ID: <1404701031.20060828231330@rulez.sk> To: "Simon L. Nielsen" In-Reply-To: <20060828201944.GE1033@zaphod.nitro.dk> References: <1418203821.20060822110342@rulez.sk> <20060827130122.GB1149@zaphod.nitro.dk> <51457742.20060827154106@rulez.sk> <20060828201944.GE1033@zaphod.nitro.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Daniel Gerzo , doc@freebsd.org Subject: Re[2]: merge query-pr.cgi and query-pr-summary.cgi, fix -T mode with new perl X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Gerzo List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Aug 2006 21:13:39 -0000 Hello Simon, Monday, August 28, 2006, 10:19:45 PM, you wrote: > On 2006.08.27 15:41:06 +0200, Daniel Gerzo wrote: >> Sunday, August 27, 2006, 3:01:23 PM, you wrote: >> > What exactly is the advantage of combining the two into one CGI >> > script? >> >> It's not big deal... >> >> http://www.freebsd.org/cgi/query-pr.cgi?pr=35647 > Hey, > Ah, I did seem to recall the suggestion from somewhere. Yeah, that PR is there for a long time, I wanted to get rid of it. > I generally like keeping the CGI scripts as simple as possible - it > makes them easier to read and modify. Especially scripts which do > multiple tasks based on how they are called have a tendency to get > more complicated than needed (at least that's my experience). I see your point and I basically agree with you. On the other hand, I can say that the merge didn't really made the the script complicatged. There is only one condition which decides if we are looking for exact PR or we are querying GNATS for PRs with specified conditions. > From my reading of the PR the problem is mainly that we have two > different HTML pages to look up a PR by number and to search. A much > simpler way to solve this would IMO be to have one HTML page with both > forms which then simply submits to the right CGI script. This could > either be a seperate HTML page or the form could just included in > query-pr-summery.cgi. > How does that sound instead of completely merging the scripts? I can't say it sounds bad to me, after all it's pretty good idea. - where would we place that form? - do we want to seek for referencies of these scripts in our docs and update them to refer to the new form? It would be not problem for me to do it this way, but as far as I have merged these scripts, I'm going to stand by my work :-) Of course, I'm open for discussions and if we prefer this or the other way, just let me know and I will undergo the steps needed, and get this worked out. So people, please tell me your suggestions and let me work the way that will be efficient! :) Anyway, the working cgi is available now at the url posted in the first email (the security review was required first). I have also implemented the query-pr-summary.cgi?www/12345 queries to have the merge complete. -- Best regards, Daniel mailto:danger@FreeBSD.org