From owner-svn-src-head@FreeBSD.ORG  Thu Jul 22 20:43:29 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id CCCF91065678;
	Thu, 22 Jul 2010 20:43:27 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: Dimitry Andric <dimitry@andric.com>
Date: Thu, 22 Jul 2010 16:43:14 -0400
User-Agent: KMail/1.6.2
References: <201007221847.o6MIlfxH030805@svn.freebsd.org>
	<201007221614.11334.jkim@FreeBSD.org> <4C48AB65.1030207@andric.com>
In-Reply-To: <4C48AB65.1030207@andric.com>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201007221643.20257.jkim@FreeBSD.org>
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, Rui Paulo <rpaulo@FreeBSD.org>
Subject: Re: svn commit: r210384 - head/sys/conf
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Jul 2010 20:43:29 -0000

On Thursday 22 July 2010 04:34 pm, Dimitry Andric wrote:
> On 2010-07-22 22:13, Jung-uk Kim wrote:
> >>  CFLAGS=	${COPTFLAGS} ${C_DIALECT} ${DEBUG} ${CWARNFLAGS}
> >>  CFLAGS+= ${INCLUDES} -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS
> >> -include opt_global.h -.if ${CC} != "icc"
> >> +.if ${CC} != "icc" && ${CC} != "clang"
> >>  CFLAGS+= -fno-common -finline-limit=${INLINE_LIMIT}
> >>  .if ${MACHINE_CPUARCH} != "mips"
> >>  CFLAGS+= --param inline-unit-growth=100
> >
> > Isn't it little premature to remove -Werror from clang?
>
> Yes, probably.  Please consider the attached patch, which only rubs
> out the compilation options that clang does not support.

Looks good to me.  Please commit.

Thanks!

Jung-uk Kim