From owner-svn-src-all@FreeBSD.ORG Fri Sep 10 03:00:51 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4842C1065673; Fri, 10 Sep 2010 03:00:51 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 163878FC15; Fri, 10 Sep 2010 03:00:51 +0000 (UTC) Received: from bigwig.baldwin.cx (unknown [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 97BDD46C22; Thu, 9 Sep 2010 16:25:49 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 5E35A8A04E; Thu, 9 Sep 2010 16:24:43 -0400 (EDT) From: John Baldwin To: mdf@freebsd.org Date: Thu, 9 Sep 2010 16:24:16 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <201009091819.o89IJGLr015797@svn.freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201009091624.17060.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Thu, 09 Sep 2010 16:24:43 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212368 - head/sys/dev/pci X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Sep 2010 03:00:51 -0000 On Thursday, September 09, 2010 4:10:55 pm mdf@freebsd.org wrote: > On Thu, Sep 9, 2010 at 11:19 AM, John Baldwin wrote: > > Author: jhb > > Date: Thu Sep 9 18:19:15 2010 > > New Revision: 212368 > > URL: http://svn.freebsd.org/changeset/base/212368 > > > > Log: > > - Rename the constant for the Master Data Parity Error flag in the > > PCI status register to map its current name. > > - Use PCIM_* rather than PCIR_* for constants for fields in various AER > > registers. I got about half of them right in the previous commit. > > > > MFC after: 1 week > > > > Modified: > > head/sys/dev/pci/pcireg.h > > This seems to break building CURRENT with this error: > > /data/sb/bsd.git/sys/dev/msk/if_msk.c: In function 'mskc_reset': > /data/sb/bsd.git/sys/dev/msk/if_msk.c:1337: error: > 'PCIM_STATUS_PERRREPORT' undeclared (first use in this function) > /data/sb/bsd.git/sys/dev/msk/if_msk.c:1337: error: (Each undeclared > identifier is reported only once > /data/sb/bsd.git/sys/dev/msk/if_msk.c:1337: error: for each function > it appears in.) > /data/sb/bsd.git/sys/dev/msk/if_msk.c: In function 'msk_intr_hwerr': > /data/sb/bsd.git/sys/dev/msk/if_msk.c:3408: error: > 'PCIM_STATUS_PERRREPORT' undeclared (first use in this function) My bad, I will fix. Surprised a driver is even messing with this bit as only the PCI bus driver should really be doing so (if it grows error handling ability). -- John Baldwin