From owner-cvs-all@FreeBSD.ORG Thu Sep 20 04:06:10 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2A22916A421; Thu, 20 Sep 2007 04:06:10 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0CDD913C48A; Thu, 20 Sep 2007 04:06:10 +0000 (UTC) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l8K4692Z066699; Thu, 20 Sep 2007 04:06:09 GMT (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l8K45xmp066692; Thu, 20 Sep 2007 04:05:59 GMT (envelope-from simokawa) Message-Id: <200709200405.l8K45xmp066692@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Thu, 20 Sep 2007 04:05:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/syscons syscons.c syscons.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2007 04:06:10 -0000 simokawa 2007-09-20 04:05:59 UTC FreeBSD src repository Modified files: sys/dev/syscons syscons.c syscons.h Log: Serialize output routine of terminal emulator (te_puts()) by a lock. - The output routine of low level console is not protected by any lock by default. - Increment and decrement of sc->write_in_progress are not atomic and this may cause console hang. - We also have many other states used by emulator that should be protected by the lock. - This change does not fix interspersed messages which PRINTF_BUFR_SIZE kernel option should fix. Approved by: re (bmah) MFC after: 1 week Revision Changes Path 1.453 +13 -1 src/sys/dev/syscons/syscons.c 1.88 +1 -0 src/sys/dev/syscons/syscons.h