From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Dec 30 10:10:09 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 875CD1065697 for ; Thu, 30 Dec 2010 10:10:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5B8B88FC12 for ; Thu, 30 Dec 2010 10:10:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oBUAA9mV084247 for ; Thu, 30 Dec 2010 10:10:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oBUAA957084246; Thu, 30 Dec 2010 10:10:09 GMT (envelope-from gnats) Resent-Date: Thu, 30 Dec 2010 10:10:09 GMT Resent-Message-Id: <201012301010.oBUAA957084246@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Anonymous Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2BEA61065670 for ; Thu, 30 Dec 2010 10:03:02 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id B4E508FC12 for ; Thu, 30 Dec 2010 10:03:01 +0000 (UTC) Received: by wwf26 with SMTP id 26so10591292wwf.31 for ; Thu, 30 Dec 2010 02:03:00 -0800 (PST) Received: by 10.216.186.82 with SMTP id v60mr10778422wem.56.1293703380733; Thu, 30 Dec 2010 02:03:00 -0800 (PST) Received: from localhost (server51262.uk2net.com [83.170.92.9]) by mx.google.com with ESMTPS id f52sm7591934wes.11.2010.12.30.02.02.58 (version=SSLv3 cipher=RC4-MD5); Thu, 30 Dec 2010 02:02:59 -0800 (PST) Message-Id: <86zkrnd1dh.fsf@gmail.com> Date: Thu, 30 Dec 2010 13:02:50 +0300 From: Anonymous To: FreeBSD-gnats-submit@FreeBSD.org Cc: Subject: ports/153540: [patch] multimedia/ffmpeg: respect STRIP X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Dec 2010 10:10:09 -0000 >Number: 153540 >Category: ports >Synopsis: [patch] multimedia/ffmpeg: respect STRIP >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Dec 30 10:10:08 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Anonymous >Release: FreeBSD 9.0-CURRENT amd64 >Organization: >Environment: cf. ports/150689 >Description: - don't strip debug binaries[1] - use yasm debug flags for WITH_DEBUG [1] unless ports/153539 is fixed WITH_DEBUG needs either STRIP explicitly re-defined or DEBUG_FLAGS defined >How-To-Repeat: $ make install WITH_DEBUG= $ STRIP= make install $ file PREFIX/lib/libavcodec.so.*.*.* /usr/local/lib/libavcodec.so.52.72.2: ELF 64-bit LSB shared object, x86-64, version 1 (FreeBSD), dynamically linked, stripped >Fix: --- a.diff begins here --- Index: multimedia/ffmpeg/Makefile =================================================================== RCS file: /a/.cvsup/ports/multimedia/ffmpeg/Makefile,v retrieving revision 1.121 diff -u -p -r1.121 Makefile --- multimedia/ffmpeg/Makefile 29 Dec 2010 21:41:36 -0000 1.121 +++ multimedia/ffmpeg/Makefile 30 Dec 2010 09:50:52 -0000 @@ -91,8 +91,7 @@ CONFIGURE_ARGS+=--prefix="${PREFIX}" \ --cc="${CC}" \ --extra-cflags="${FFMPEG_CFLAGS} -I${LOCALBASE}/include" \ --extra-ldflags="-L${LOCALBASE}/lib ${FFMPEG_LDFLAGS}" \ - --extra-libs="${PTHREAD_LIBS}" \ - --disable-debug + --extra-libs="${PTHREAD_LIBS}" SHLIB_VER= 1 PLIST_SUB= SHLIB_VER=${SHLIB_VER} USE_LDCONFIG= yes @@ -109,6 +108,14 @@ DOC_DOCFILES= APIchanges TODO avutil.txt snow.txt soc.txt swscale.txt tablegen.txt viterbi.txt PORTDOCS= * +.if !defined(WITH_DEBUG) +CONFIGURE_ARGS+= --disable-debug +.endif + +.if !defined(STRIP) || ${STRIP} == "" +CONFIGURE_ARGS+= --disable-stripping +.endif + .if !defined(WITHOUT_CPUDETECT) CONFIGURE_ARGS+= --enable-runtime-cpudetect .endif --- a.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: