From owner-freebsd-current@FreeBSD.ORG Thu Feb 21 10:15:45 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DAA4816A401 for ; Thu, 21 Feb 2008 10:15:45 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from anti-4.kiev.sovam.com (anti-4.kiev.sovam.com [62.64.120.202]) by mx1.freebsd.org (Postfix) with ESMTP id 82C4F13C46A for ; Thu, 21 Feb 2008 10:15:45 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [212.82.216.226] (helo=skuns.kiev.zoral.com.ua) by anti-4.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1JS8Sr-000BSx-Ow; Thu, 21 Feb 2008 12:15:44 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by skuns.kiev.zoral.com.ua (8.14.1/8.14.1) with ESMTP id m1KBEMAO079394 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 20 Feb 2008 13:14:22 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m1KBEifa026674; Wed, 20 Feb 2008 13:14:44 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2/Submit) id m1KBEiTH026673; Wed, 20 Feb 2008 13:14:44 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 20 Feb 2008 13:14:44 +0200 From: Kostik Belousov To: d@delphij.net Message-ID: <20080220111444.GH57756@deviant.kiev.zoral.com.ua> References: <47BBD864.3070905@delphij.net> <20080220105614.eydtkfap4gogk0cw@webmail.leidinger.net> <47BBF9CC.4030404@delphij.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CzROh2enfuzgPXpq" Content-Disposition: inline In-Reply-To: <47BBF9CC.4030404@delphij.net> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.3 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on skuns.kiev.zoral.com.ua X-Scanner-Signature: 1118cf21f7425d415ed61e91afc5cb63 X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 2271 [Feb 20 2008] X-SpamTest-Info: helo_type=3 X-SpamTest-Method: none X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release Cc: freebsd-fs@freebsd.org, Alexander Leidinger , FreeBSD Current Subject: Re: [PATCH FOR REVIEW] fsck_ffs: Recover from catastrophic damage X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Feb 2008 10:15:45 -0000 --CzROh2enfuzgPXpq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 20, 2008 at 01:58:36AM -0800, Xin LI wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 >=20 > Alexander Leidinger wrote: > > Quoting Xin LI (from Tue, 19 Feb 2008 23:36:04 > > -0800): > >=20 > >> Change summary: > >> > >> fsutil.c: > >> - Really update standard superblock. fsck_ffs -b used to update the > >> backup superblock which does not recover file systems which have bad > >> master superblocks. > >> - Instead of coredump, zero out whole cg if its signature is bad. > >> > >> inode.c: > >> - Instead of coredump, zero out whole cg if its signature is bad. > >=20 > > Does this modify (zero out) on-disk blocks? If yes, shouldn't this ask > > for confirmation? >=20 > My assumption is that if a cylinder group's magic number is damaged, > then the whole stuff can not be trusted at all, but yes, I think this > should come with a prompt, will add tomorrow. I have some uneasy feeling about automatically zeroing a cg. I think it would be safer to show the message there, and add the same functionality to fsdb, something like clrcg command, analogous to clri. --CzROh2enfuzgPXpq Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEARECAAYFAke8C6MACgkQC3+MBN1Mb4hvnACeLqs9DokpnnsjAcFSWXrxLYDq 1iIAnjNMukCTe1AzihTKlCP1jAi+zLvG =ltem -----END PGP SIGNATURE----- --CzROh2enfuzgPXpq--