From owner-svn-src-all@FreeBSD.ORG  Wed Oct 13 19:46:19 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id B07121065675;
	Wed, 13 Oct 2010 19:46:18 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: src-committers@FreeBSD.org
Date: Wed, 13 Oct 2010 15:46:08 -0400
User-Agent: KMail/1.6.2
References: <201010131439.o9DEdssc090571@svn.freebsd.org>
In-Reply-To: <201010131439.o9DEdssc090571@svn.freebsd.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201010131546.10130.jkim@FreeBSD.org>
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	Rui Paulo <rpaulo@freebsd.org>
Subject: Re: svn commit: r213779 - head/sys/dev/sound/pci
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Oct 2010 19:46:19 -0000

On Wednesday 13 October 2010 10:39 am, Rui Paulo wrote:
> Author: rpaulo
> Date: Wed Oct 13 14:39:54 2010
> New Revision: 213779
> URL: http://svn.freebsd.org/changeset/base/213779
>
> Log:
>   Fix a brain-o: wrong case statement semantics.
>
>   Found with:	clang
>
> Modified:
>   head/sys/dev/sound/pci/envy24ht.c
>   head/sys/dev/sound/pci/spicds.c
>
> Modified: head/sys/dev/sound/pci/envy24ht.c
> ===================================================================
>=========== --- head/sys/dev/sound/pci/envy24ht.c	Wed Oct 13
> 14:37:52 2010	(r213778) +++ head/sys/dev/sound/pci/envy24ht.c	Wed
> Oct 13 14:39:54 2010	(r213779) @@ -2236,7 +2236,8 @@
> envy24ht_putcfg(struct sc_info *sc)
>  	else
>  		printf("not implemented\n");
>          switch (sc->adcn) {
> -        case 0x01 || 0x02:
> +        case 0x01:
> +	case 0x02:
>                  printf("  ADC #: ");
>                  printf("%d\n", sc->adcn);
>                  break;
>
> Modified: head/sys/dev/sound/pci/spicds.c
> ===================================================================
>=========== --- head/sys/dev/sound/pci/spicds.c	Wed Oct 13 14:37:52
> 2010	(r213778) +++ head/sys/dev/sound/pci/spicds.c	Wed Oct 13
> 14:39:54 2010	(r213779) @@ -283,7 +283,8 @@ spicds_set(struct
> spicds_info *codec, in case SPICDS_TYPE_WM8770:
>  			left = left + 27;
>  			break;
> -		case SPICDS_TYPE_AK4381 || SPICDS_TYPE_AK4396:
> +		case SPICDS_TYPE_AK4381:
> +		case SPICDS_TYPE_AK4396:
>  			left = left * 255 / 100;
>  			break;
>  		default:

Although it was rediscovered by clang, spicds.c patch actually known 
to fix a problem.  Please see kern/146758.

Jung-uk Kim