From owner-svn-ports-all@FreeBSD.ORG  Tue Mar  5 19:01:48 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id CE3345D2;
 Tue,  5 Mar 2013 19:01:48 +0000 (UTC)
 (envelope-from utisoft@gmail.com)
Received: from mail-ia0-x234.google.com (mail-ia0-x234.google.com
 [IPv6:2607:f8b0:4001:c02::234])
 by mx1.freebsd.org (Postfix) with ESMTP id 72F0A7CC;
 Tue,  5 Mar 2013 19:01:48 +0000 (UTC)
Received: by mail-ia0-f180.google.com with SMTP id f27so6591170iae.11
 for <multiple recipients>; Tue, 05 Mar 2013 11:01:48 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=x-received:mime-version:sender:in-reply-to:references:from:date
 :x-google-sender-auth:message-id:subject:to:cc:content-type;
 bh=4u8lHNm3aM1ZTadOP0zA4xoQX6aT7oLugU3VAOlucSo=;
 b=XxWEOF2yPUnbA6aoKOV3ZaCoTq+Sv9Qxuq6JctL7xHMKsOnki8C4OdiMpHq88li770
 XIAHG8jbY4er/KiRteiOdrI4/9Ge/+xfFLV+unRz97DAJXJcEntvvlh9aTL0EAy6VKbl
 bRDfX4txxv1ACZJbnMj1eibwnl6E+DOmjBExwzO2xUCnwveK3kp2JFVCrX/rXtSoG2rI
 61t9ePF67HSfl+1/2D8+HdAfPk3kTtIWA2XwAJ1VE9bA346xe1ptpjO5BdqfSf7YUQ48
 Sy+I0fqzMb2jenX+reE5x7/21MioIKensQ8pcZuIK/snjcyCcVPWSWjD25ob4+ZK/4oH
 A5Dg==
X-Received: by 10.50.152.169 with SMTP id uz9mr7469620igb.15.1362510108138;
 Tue, 05 Mar 2013 11:01:48 -0800 (PST)
MIME-Version: 1.0
Sender: utisoft@gmail.com
Received: by 10.64.63.12 with HTTP; Tue, 5 Mar 2013 11:01:18 -0800 (PST)
In-Reply-To: <201303031812.r23IC6D3033581@svn.freebsd.org>
References: <201303031812.r23IC6D3033581@svn.freebsd.org>
From: Chris Rees <crees@FreeBSD.org>
Date: Tue, 5 Mar 2013 19:01:18 +0000
X-Google-Sender-Auth: LWAZLqg9KcOozdvE4I-wpdndM8A
Message-ID: <CADLo839kiLsUtC8-_Uwwu=BDcvvom8VhL2PHmposWGEOmeiQ5w@mail.gmail.com>
Subject: Re: svn commit: r313372 - in head: devel/pecl-spread net/spread4
 net/spread4/files
To: Olli Hauer <ohauer@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Mar 2013 19:01:48 -0000

On 3 March 2013 18:12, Olli Hauer <ohauer@freebsd.org> wrote:

<snip>

> +spread_cleanup() {
> +       [ -f ${pidfile} ] && rm -f ${pidfile}


Isn't checking a file exists rather redundant if you're going to use
rm -f on it?

Chris