From owner-cvs-all  Wed Dec 18 16:25: 3 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 55CFB37B401; Wed, 18 Dec 2002 16:25:02 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8B61643EC5; Wed, 18 Dec 2002 16:25:00 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id LAA15838;
	Thu, 19 Dec 2002 11:24:52 +1100
Date: Thu, 19 Dec 2002 11:25:59 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Robert Watson <rwatson@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/bin/ls ls.c
In-Reply-To: <200212182105.gBIL5F1Z012938@repoman.freebsd.org>
Message-ID: <20021219105457.U28005-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Wed, 18 Dec 2002, Robert Watson wrote:

> rwatson     2002/12/18 13:05:15 PST
>
>   Modified files:
>     bin/ls               ls.c
>   Log:
>   Improve handling of symlink targets when listing MAC labels: don't
>   do the wrong thing when the symlink doesn't have a target, by
>   considering !f_label in the construction of ch_options.

ls still seems to do the wrong thing for symlinks without targets:

    $ ls -l /etc/malloc.conf
    ls: /etc/malloc.conf: No such file or directory
    lrwxrwxrwx  1 root  wheel  2 Jun 29 00:36 /etc/malloc.conf -> aj

The RELENG_4 ls run on -current works like I expect:

    $ /d/tmp/ls/ls -l /etc/malloc.conf
    lrwxrwxrwx  1 root  wheel  2 Jun 29 00:36 /etc/malloc.conf -> aj

The spurious warning is printed by aclmode() after pathconf() fails.
pathconf() follows symlinks so it cannot work correctly here unless
ls is following symlinks.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message