From owner-freebsd-virtualization@FreeBSD.ORG Sat Jul 27 06:31:49 2013 Return-Path: Delivered-To: freebsd-virtualization@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 282E9731; Sat, 27 Jul 2013 06:31:49 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: from mail-oa0-x236.google.com (mail-oa0-x236.google.com [IPv6:2607:f8b0:4003:c02::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BCA312987; Sat, 27 Jul 2013 06:31:48 +0000 (UTC) Received: by mail-oa0-f54.google.com with SMTP id o17so117514oag.27 for ; Fri, 26 Jul 2013 23:31:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; bh=ygTXVXI0hjEfzZRs3AT9CaENC0D/NWlXPfgfvbXM8Xg=; b=Q8r2gHvBpWT9AdlvhDwJG8yOZgNC0QzKjKYRmw18Yh3ThKhWhA12HnfA4QcbKM9TRi aZrQbAbjd9DzEW52OfygKr+O03ZOnsWDXR5VlqU0KqpWVlQ1OqOliaonhbYuP73KQjQz EImkP/KIgq7wlfVhMW2F4RvHZHgp9DkoxEcxNDnIfyhJIqDNdNp8J/r+Ey4M1tjqPziA bQQROyqOezljQCBua3PyirfFL297ZW+a+c/N4whn/9QGju58cLIjlTbMlIAxr9pniYnX U7sKEKi/zfTq5A5LpKFQLAfWnyIewTopWb1Q2+8Qewgch0G6cw9Hi2V56mLuuPZsiGVf 0k/w== MIME-Version: 1.0 X-Received: by 10.60.133.14 with SMTP id oy14mr51312606oeb.84.1374906708080; Fri, 26 Jul 2013 23:31:48 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.60.132.243 with HTTP; Fri, 26 Jul 2013 23:31:48 -0700 (PDT) Date: Fri, 26 Jul 2013 23:31:48 -0700 X-Google-Sender-Auth: Nrh4OGGgAcLC7znvcg2Jor9gp_U Message-ID: Subject: De-virtualize V_pf_mtag_z to eliminate kernel panics. From: Craig Rodrigues To: Gleb Smirnoff Content-Type: multipart/mixed; boundary=047d7b472746ef40e904e278696f X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: Adrian Chadd , Marko Zec , "freebsd-virtualization@freebsd.org" , freebsd-pf@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jul 2013 06:31:49 -0000 --047d7b472746ef40e904e278696f Content-Type: text/plain; charset=ISO-8859-1 Gleb, Since you did a lot of work in GRN 240233 to fix PF issues, especially for VIMAGE, I thought I would ask your opinion on the attached patch. In this post: http://lists.freebsd.org/pipermail/freebsd-virtualization/2013-July/001405.html I reported multiple PF-related panics when VIMAGE was enabled in my kernel config. In these posts: http://lists.freebsd.org/pipermail/freebsd-virtualization/2013-July/001413.html http://lists.freebsd.org/pipermail/freebsd-virtualization/2013-July/001420.html Marko Zec seemed to think that de-virtualizing V_pf_mtag_z would be a valid solution to this problem, and that keeping V_pf_mtag_z as a per-vnet variable is not necessary. What do you think of Marko's comments, and this patch? Thanks. -- Craig --047d7b472746ef40e904e278696f Content-Type: text/plain; charset=US-ASCII; name="diff.txt" Content-Disposition: attachment; filename="diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hjmfwbmu0 SW5kZXg6IHN5cy9uZXRwZmlsL3BmL3BmLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL25ldHBmaWwvcGYv cGYuYwkocmV2aXNpb24gMjUzMzQ2KQorKysgc3lzL25ldHBmaWwvcGYvcGYuYwkod29ya2luZyBj b3B5KQpAQCAtMTg3LDggKzE4Nyw3IEBACiAKIHN0YXRpYyBWTkVUX0RFRklORSh1bWFfem9uZV90 LAlwZl9zb3VyY2VzX3opOwogI2RlZmluZQlWX3BmX3NvdXJjZXNfeglWTkVUKHBmX3NvdXJjZXNf eikKLXN0YXRpYyBWTkVUX0RFRklORSh1bWFfem9uZV90LAlwZl9tdGFnX3opOwotI2RlZmluZQlW X3BmX210YWdfeglWTkVUKHBmX210YWdfeikKK3VtYV96b25lX3QgcGZfbXRhZ196OwogVk5FVF9E RUZJTkUodW1hX3pvbmVfdCwJIHBmX3N0YXRlX3opOwogVk5FVF9ERUZJTkUodW1hX3pvbmVfdCwJ IHBmX3N0YXRlX2tleV96KTsKIApAQCAtNzQ5LDcgKzc0OCw3IEBACiAJVl9wZl9hbHRxc19pbmFj dGl2ZSA9ICZWX3BmX2FsdHFzWzFdOwogCiAJLyogTWJ1ZiB0YWdzICovCi0JVl9wZl9tdGFnX3og PSB1bWFfemNyZWF0ZSgicGYgbXRhZ3MiLCBzaXplb2Yoc3RydWN0IG1fdGFnKSArCisJcGZfbXRh Z196ID0gdW1hX3pjcmVhdGUoInBmIG10YWdzIiwgc2l6ZW9mKHN0cnVjdCBtX3RhZykgKwogCSAg ICBzaXplb2Yoc3RydWN0IHBmX210YWcpLCBOVUxMLCBOVUxMLCBwZl9tdGFnX2luaXQsIE5VTEws CiAJICAgIFVNQV9BTElHTl9QVFIsIDApOwogCkBAIC04MDMsNyArODAyLDcgQEAKIAltdHhfZGVz dHJveSgmcGZfb3ZlcmxvYWRxdWV1ZV9tdHgpOwogCW10eF9kZXN0cm95KCZwZl91bmxua2RydWxl c19tdHgpOwogCi0JdW1hX3pkZXN0cm95KFZfcGZfbXRhZ196KTsKKwl1bWFfemRlc3Ryb3kocGZf bXRhZ196KTsKIAl1bWFfemRlc3Ryb3koVl9wZl9zb3VyY2VzX3opOwogCXVtYV96ZGVzdHJveShW X3BmX3N0YXRlX3opOwogCXVtYV96ZGVzdHJveShWX3BmX3N0YXRlX2tleV96KTsKQEAgLTgyNyw3 ICs4MjYsNyBAQAogcGZfbXRhZ19mcmVlKHN0cnVjdCBtX3RhZyAqdCkKIHsKIAotCXVtYV96ZnJl ZShWX3BmX210YWdfeiwgdCk7CisJdW1hX3pmcmVlKHBmX210YWdfeiwgdCk7CiB9CiAKIHN0cnVj dCBwZl9tdGFnICoKQEAgLTgzOCw3ICs4MzcsNyBAQAogCWlmICgobXRhZyA9IG1fdGFnX2ZpbmQo bSwgUEFDS0VUX1RBR19QRiwgTlVMTCkpICE9IE5VTEwpCiAJCXJldHVybiAoKHN0cnVjdCBwZl9t dGFnICopKG10YWcgKyAxKSk7CiAKLQltdGFnID0gdW1hX3phbGxvYyhWX3BmX210YWdfeiwgTV9O T1dBSVQpOworCW10YWcgPSB1bWFfemFsbG9jKHBmX210YWdfeiwgTV9OT1dBSVQpOwogCWlmICht dGFnID09IE5VTEwpCiAJCXJldHVybiAoTlVMTCk7CiAJYnplcm8obXRhZyArIDEsIHNpemVvZihz dHJ1Y3QgcGZfbXRhZykpOwo= --047d7b472746ef40e904e278696f--