From owner-freebsd-bluetooth@FreeBSD.ORG  Tue Dec  1 18:28:41 2009
Return-Path: <owner-freebsd-bluetooth@FreeBSD.ORG>
Delivered-To: freebsd-bluetooth@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 666441065670
	for <freebsd-bluetooth@freebsd.org>;
	Tue,  1 Dec 2009 18:28:41 +0000 (UTC)
	(envelope-from maksim.yevmenkin@gmail.com)
Received: from mail-pz0-f185.google.com (mail-pz0-f185.google.com
	[209.85.222.185])
	by mx1.freebsd.org (Postfix) with ESMTP id 3DD0E8FC12
	for <freebsd-bluetooth@freebsd.org>;
	Tue,  1 Dec 2009 18:28:41 +0000 (UTC)
Received: by pzk15 with SMTP id 15so3722868pzk.3
	for <freebsd-bluetooth@freebsd.org>;
	Tue, 01 Dec 2009 10:28:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:in-reply-to:references
	:date:message-id:subject:from:to:cc:content-type;
	bh=cK9iMqIbO/f9y6TYTjsx90jMURM4LP+H+C3xgtrrIU0=;
	b=q3DLUCfGNzJO668fypw0tT+ueQTVsU9ujB7Akk3jpXR9fR5aZYECgFSGPPPQ45AwKF
	GaXT8iKlcr7OizA0Y1v1cdrf7ygW0IVxGu4A0O1a3VcRd/oesygYK22LOKNHV5mXlmr7
	lUUsaf9W6J20ga6zcV3fIXEMqHJtWgpuJp1jc=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	b=iTV7lDbkQu18IXhS3rgqtevLtCDQEzriBMEL0qIypsTafx6zqi2XHKGwETwuQ3zuE+
	gHH1QV8os3hOFamAAoc8OzgpBsJRjF62dZZUTvfxl0++Ukadnmm1QdlWVzbNEkjP+2zN
	t8dM7d7mW0hPDmWn4fn9U3chPEOgsx46IvMs8=
MIME-Version: 1.0
Received: by 10.114.252.14 with SMTP id z14mr11706649wah.84.1259692120596; 
	Tue, 01 Dec 2009 10:28:40 -0800 (PST)
In-Reply-To: <20091201125054.44a00147@zelz27>
References: <20091201125054.44a00147@zelz27>
Date: Tue, 1 Dec 2009 10:28:40 -0800
Message-ID: <bb4a86c70912011028m1c595d03r6d04ce29f7aca632@mail.gmail.com>
From: Maksim Yevmenkin <maksim.yevmenkin@gmail.com>
To: Matthias Drochner <m.drochner@googlemail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-bluetooth@freebsd.org, plunky@netbsd.org
Subject: Re: patch to make obexapp work with BSD iconv(3)
X-BeenThere: freebsd-bluetooth@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Using Bluetooth in FreeBSD environments
	<freebsd-bluetooth.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bluetooth>, 
	<mailto:freebsd-bluetooth-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bluetooth>
List-Post: <mailto:freebsd-bluetooth@freebsd.org>
List-Help: <mailto:freebsd-bluetooth-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bluetooth>, 
	<mailto:freebsd-bluetooth-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Dec 2009 18:28:41 -0000

Matthias,

> Here is a patch which removes the GNU iconv dependency from obexapp.
> I've successfully tested it by sending vcards with strange names;
> the resulting files were identical.

thanks for the patch!

could you please tell me which bsd flavor you tested this on?

> The relevant changes are:
> -just use the result of nl_langinfo(CODESET) as input of
>  iconv_open(3), this is more robust than trying to interpret
>  the locale string
> -remove iconvctl(ICONV_SET_DISCARD_ILSEQ) -- BSD doesn't
>  have this and it should be unneeded because it only
>  compensates for some non-standard behaviour of GNU iconv.
> (The bsdxml->expat part is unrelated.)

i dont really have any objections to those, just wanted to get some
clarification.

thanks
max