From owner-cvs-all Sun Sep 9 15:34:21 2001 Delivered-To: cvs-all@freebsd.org Received: from tao.org.uk (genius.tao.org.uk [212.135.162.51]) by hub.freebsd.org (Postfix) with ESMTP id BAA1B37B406; Sun, 9 Sep 2001 15:34:12 -0700 (PDT) Received: by tao.org.uk (Postfix, from userid 100) id AD9443FA; Sun, 9 Sep 2001 23:34:07 +0100 (BST) Date: Sun, 9 Sep 2001 23:34:07 +0100 From: Josef Karthauser To: Peter Wemm Cc: Josef Karthauser , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: CVSROOT cfg.pm commit_prep.pl Message-ID: <20010909233407.A846@tao.org.uk> References: <200109080211.f882BZt86733@freefall.freebsd.org> <20010908215254.D8BCD380A@overcee.netplex.com.au> <20010909151006.C69728@tao.org.uk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="zhXaljGHf11kAtnf" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010909151006.C69728@tao.org.uk>; from joe@tao.org.uk on Sun, Sep 09, 2001 at 03:10:06PM +0100 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --zhXaljGHf11kAtnf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 09, 2001 at 03:10:06PM +0100, Josef Karthauser wrote: > On Sat, Sep 08, 2001 at 02:52:54PM -0700, Peter Wemm wrote: > > This is broken, it happens before the $Id$ spamming checks. You only > > want this to be run after all the sanity checks are done. Of course th= en > > you have to fix all the return's from the function. :-) >=20 > You mean that it happens before the spamming checks have had a > chance to complain? I was so worried about making sure that this > worked for remote commits I forgot that it probably modifies the > file directly when committing locally. I'll fix this. Hmm, looks like there's no clean way to do this. For a local commit the local file (in the committers's working directory) is modified. Unfortunately this all happens before the commit message is entered. If they abort the commit at this time the file will have already had it's $Id$ unexpanded. :( Is this acceptable? Joe --zhXaljGHf11kAtnf Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iEYEARECAAYFAjub7lEACgkQXVIcjOaxUBbvwACgrygrCpxHeAJxT6ld6JcuP5xw SckAn2ny1ge9Dcod4Q5BLtox2yAaajNK =kVwZ -----END PGP SIGNATURE----- --zhXaljGHf11kAtnf-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message