From owner-freebsd-tcltk@FreeBSD.ORG Sun Jun 2 15:38:29 2013 Return-Path: Delivered-To: tcltk@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 00C76E2A; Sun, 2 Jun 2013 15:38:28 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-ie0-x236.google.com (mail-ie0-x236.google.com [IPv6:2607:f8b0:4001:c03::236]) by mx1.freebsd.org (Postfix) with ESMTP id BE09A1E0F; Sun, 2 Jun 2013 15:38:28 +0000 (UTC) Received: by mail-ie0-f182.google.com with SMTP id 9so2777593iec.13 for ; Sun, 02 Jun 2013 08:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=g84FdypQIY8/tNafVtLTJkeoPp6uBcQCT8wI6MEIryI=; b=rKp3klmsokwik+k0bJR72ec/AOdYcyV8rQ5zULCjm80YOMX9f9A2ZyN6PxwMxaWDKj repVgz6qCoh5OEsu50x2wYYZw0jc7eo6hTb6sMzuOo/V/gIcEc6qqFla9eV2s87zcSH+ 6GjCPhv8/TorV3sOvTU88murVWeQwf4XhpImHhDviJSpgBM3TsWboPwtUeeRJlxxYZBr 0Fvzirnu2ieBsFXsxhHb6xY0ZfAH9ZmRaMbiaKA2WPs8wE0ajYavf/+JimtqrpJc6AVZ 1tAelrrwWvYpgs2ZiPaBckF+nPcBqLEuAk5ArEwD73CPhjBZZ+/nZ1AbxSwbA+9lb091 5/Hw== X-Received: by 10.50.98.3 with SMTP id ee3mr5833394igb.101.1370187507800; Sun, 02 Jun 2013 08:38:27 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.64.71.101 with HTTP; Sun, 2 Jun 2013 08:37:57 -0700 (PDT) In-Reply-To: References: From: Chris Rees Date: Sun, 2 Jun 2013 16:37:57 +0100 X-Google-Sender-Auth: EayWQQGw5vNrJ5yV1r3meu-DfQY Message-ID: Subject: Re: patch: increase tcl86 regular expression depth limit to help dejagnu To: Dimitry Andric Content-Type: text/plain; charset=ISO-8859-1 Cc: tcltk@freebsd.org X-BeenThere: freebsd-tcltk@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: FreeBSD-specific Tcl/Tk discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Jun 2013 15:38:29 -0000 On 1 June 2013 18:01, Chris Rees wrote: > On 1 June 2013 17:35, Dimitry Andric wrote: >> Hi, >> >> When running the libffi test suite using dejagnu, I ran into the >> following tcl86 error: >> >> ... >> Running target unix >> Using /usr/local/share/dejagnu/baseboards/unix.exp as board description file for target. >> Using /usr/local/share/dejagnu/config/unix.exp as generic interface file for target. >> Using ../../testsuite/config/default.exp as tool-and-target-specific interface file. >> Running ../../testsuite/libffi.call/call.exp ... >> ERROR: tcl error sourcing ../../testsuite/libffi.call/call.exp. >> ERROR: couldn't compile regular expression pattern: out of memory >> while executing >> "regexp $texttmp ${output}" >> (procedure "saved-dg-test" line 247) >> invoked from within >> "saved-dg-test ../../testsuite/libffi.call/huge_struct.c {-O0 -W -Wall} {}" >> ("eval" body line 1) >> invoked from within >> "eval saved-dg-test $args " >> (procedure "dg-test" line 6) >> invoked from within >> "dg-test $testcase $flags ${default-extra-flags}" >> (procedure "dg-runtest" line 10) >> invoked from within >> "dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\[cS\]]] "-O0 -W -Wall" """ >> (file "../../testsuite/libffi.call/call.exp" line 24) >> invoked from within >> "source ../../testsuite/libffi.call/call.exp" >> ("uplevel" body line 1) >> invoked from within >> "uplevel #0 source ../../testsuite/libffi.call/call.exp" >> invoked from within >> "catch "uplevel #0 source $test_file_name"" >> Running ../../testsuite/libffi.special/special.exp ... >> >> After some searching, I found this similar bug on Tcl's tracker: >> >> >> The change that introduced the limit is here: >> >> >> To make tcl86 work for the libffi tests, I simply doubled the limit from >> 500 to 1000, as in the attached diff. Can you please consider adding >> this to the tcl86 port? > > The attached diff that I missed, and made by hand >.< > > Pietro, Mikhail, I see no reason not to commit this? > > I'll do so tomorrow if neither of you object. > Committed, thanks! Chris