From owner-svn-src-releng@freebsd.org Mon Dec 7 21:06:11 2020 Return-Path: Delivered-To: svn-src-releng@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 05ED54B7429 for ; Mon, 7 Dec 2020 21:06:11 +0000 (UTC) (envelope-from 3SpfOXwsJDrcmXZhXo.hXkbdjXfi.Zljpsk-poZ-obibkdcobbYpa.lod@trix.bounces.google.com) Received: from mail-ua1-x946.google.com (mail-ua1-x946.google.com [IPv6:2607:f8b0:4864:20::946]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CqbSy2tVlz3rZ9 for ; Mon, 7 Dec 2020 21:06:10 +0000 (UTC) (envelope-from 3SpfOXwsJDrcmXZhXo.hXkbdjXfi.Zljpsk-poZ-obibkdcobbYpa.lod@trix.bounces.google.com) Received: by mail-ua1-x946.google.com with SMTP id o5so3541108uad.18 for ; Mon, 07 Dec 2020 13:06:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:reply-to:message-id:date:subject:from:to; bh=Fqy9wusVtCtyv9Vj73xlX7aqQ+nnZqYJ/mQKMKic4lo=; b=dRxdbMFxMYqBFZngaQOhE8Cv7YFFnnBXpKy//0/wfSi6FWi8rJvMhVe+u0BYzzv2Kx hInW9XPqJaVDPNehonhGmMqvARtysmewEmwH83kSVP3JTk+52MQlGb+NeN6xFFfErfim 0u2+72P8kPjqX5vql7VzphG5LNQxnljjrY4ObRWopoyGyigVs0TqrB6ViWLj16e9ikA+ F+wwqbWLCiMBszzxFf9y0k7JLRwFfxj4i2vyicLtqK7HlM9rjDsQUh8cbH+8W5bWx+Qk +8FcJIbtZK/JKn2zhR5wlvMDnVfE1c53xi3Cy9ZkrxSG224Bfmw/aAxyQHAwXgu1yoEC qQcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:message-id:date:subject :from:to; bh=Fqy9wusVtCtyv9Vj73xlX7aqQ+nnZqYJ/mQKMKic4lo=; b=p5a8+mrGBQ9KIE5kz/h1z2KW0eqpcUgCoT8Ws6o5y496SXHx4DMmMB7Piy/oA6HYK4 Z+6N/tP5HKwdDw/mjDuic0nHlg1Yu6soYdQjsWpWHXz+KuZApGItwUUICs1+++5QTsGl ZyQfkfxS/xpI0gRW94W2ORiREKDcu4zIkfp92NNn2ZPd3uDbzqZTq8UALs8xhdlDZWpa 7loQ5jgmBM3nbFH3gKjZXlrDLBwKpZ21vTZkRUawL4FNtEDXRH/n8y+exhxft3n2hOxp CyBGwPCsK1iKvRcNdAgFuTtlvw5bBgwUhnUTthjHWx+8J9aJXjnXAn6mApO3IMzZZ/SA p7Xg== X-Gm-Message-State: AOAM532vJnIERMR1jrpIwal3UDAkxkXlpx8tvblsw13uwLrg1V+FQV6a OS3VCfAiCIcWMoedO1/FfEqAE6MvI6HUPz4zCOIN MIME-Version: 1.0 X-Received: by 2002:a67:6686:: with SMTP id a128mt14851380vsc.11.1607374666198; Mon, 07 Dec 2020 12:57:46 -0800 (PST) Reply-To: packar.kane@gmail.com X-No-Auto-Attachment: 1 Message-ID: <0000000000000014c905b5e6143d@google.com> Date: Mon, 07 Dec 2020 21:06:10 +0000 Subject: You get my email From: packar.kane@gmail.com To: svn-src-releng@freebsd.org X-Rspamd-Queue-Id: 4CqbSy2tVlz3rZ9 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=dRxdbMFx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of 3SpfOXwsJDrcmXZhXo.hXkbdjXfi.Zljpsk-poZ-obibkdcobbYpa.lod@trix.bounces.google.com designates 2607:f8b0:4864:20::946 as permitted sender) smtp.mailfrom=3SpfOXwsJDrcmXZhXo.hXkbdjXfi.Zljpsk-poZ-obibkdcobbYpa.lod@trix.bounces.google.com X-Spamd-Result: default: False [-3.70 / 15.00]; HAS_REPLYTO(0.00)[packar.kane@gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_NONE(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[packarkane@gmail.com,3SpfOXwsJDrcmXZhXo.hXkbdjXfi.Zljpsk-poZ-obibkdcobbYpa.lod@trix.bounces.google.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::946:from]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[packarkane@gmail.com,3SpfOXwsJDrcmXZhXo.hXkbdjXfi.Zljpsk-poZ-obibkdcobbYpa.lod@trix.bounces.google.com]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; REPLYTO_EQ_FROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; FREEMAIL_REPLYTO(0.00)[gmail.com]; PREVIOUSLY_DELIVERED(0.00)[svn-src-releng@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::946:from:127.0.2.255]; FROM_NO_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::946:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[svn-src-releng] Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: svn-src-releng@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the release engineering / security commits to the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2020 21:06:11 -0000 I've invited you to fill out the following form: Untitled form To fill it out, visit: https://docs.google.com/forms/d/e/1FAIpQLSfnEHD2_CNTJYIVH7sDpLJ-xXgrkXb-MenDNrMni0actgeXhQ/viewform?vc=0&c=0&w=1&flr=0&usp=mail_form_link Hello, I contacted you because I want to invest in your country,if you confirm your interest that you can handle the fund in a good investment. reply on this email only: reem.alhashimi@kakao.com Regards, Ms. Reem Al-hashimi Google Forms: Create and analyze surveys. From owner-svn-src-releng@freebsd.org Tue Dec 8 19:10:44 2020 Return-Path: Delivered-To: svn-src-releng@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 772964A9AE6; Tue, 8 Dec 2020 19:10:44 +0000 (UTC) (envelope-from gordon@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cr8sJ2wRLz4ncq; Tue, 8 Dec 2020 19:10:44 +0000 (UTC) (envelope-from gordon@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4D18B19587; Tue, 8 Dec 2020 19:10:44 +0000 (UTC) (envelope-from gordon@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 0B8JAifW028280; Tue, 8 Dec 2020 19:10:44 GMT (envelope-from gordon@FreeBSD.org) Received: (from gordon@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 0B8JAeOP028259; Tue, 8 Dec 2020 19:10:40 GMT (envelope-from gordon@FreeBSD.org) Message-Id: <202012081910.0B8JAeOP028259@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: gordon set sender to gordon@FreeBSD.org using -f From: Gordon Tetlow Date: Tue, 8 Dec 2020 19:10:40 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-releng@freebsd.org Subject: svn commit: r368463 - in releng: 12.1 12.1/crypto/openssl/crypto/asn1 12.1/crypto/openssl/crypto/err 12.1/crypto/openssl/crypto/x509v3 12.1/crypto/openssl/include/openssl 12.1/sys/conf 12.2 12.2/cr... X-SVN-Group: releng X-SVN-Commit-Author: gordon X-SVN-Commit-Paths: in releng: 12.1 12.1/crypto/openssl/crypto/asn1 12.1/crypto/openssl/crypto/err 12.1/crypto/openssl/crypto/x509v3 12.1/crypto/openssl/include/openssl 12.1/sys/conf 12.2 12.2/crypto/openssl/crypto/asn1 ... X-SVN-Commit-Revision: 368463 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-releng@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the release engineering / security commits to the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2020 19:10:44 -0000 Author: gordon Date: Tue Dec 8 19:10:40 2020 New Revision: 368463 URL: https://svnweb.freebsd.org/changeset/base/368463 Log: Fix OpenSSL NULL pointer de-reference. Approved by: so Security: FreeBSD-SA-20:33.openssl Security: CVE-2020-1971 Modified: releng/12.1/UPDATING releng/12.1/crypto/openssl/crypto/asn1/asn1_err.c releng/12.1/crypto/openssl/crypto/asn1/tasn_dec.c releng/12.1/crypto/openssl/crypto/asn1/tasn_enc.c releng/12.1/crypto/openssl/crypto/err/openssl.txt releng/12.1/crypto/openssl/crypto/x509v3/v3_genn.c releng/12.1/crypto/openssl/include/openssl/asn1err.h releng/12.1/sys/conf/newvers.sh releng/12.2/UPDATING releng/12.2/crypto/openssl/crypto/asn1/asn1_err.c releng/12.2/crypto/openssl/crypto/asn1/tasn_dec.c releng/12.2/crypto/openssl/crypto/asn1/tasn_enc.c releng/12.2/crypto/openssl/crypto/err/openssl.txt releng/12.2/crypto/openssl/crypto/x509v3/v3_genn.c releng/12.2/crypto/openssl/include/openssl/asn1err.h releng/12.2/sys/conf/newvers.sh Modified: releng/12.1/UPDATING ============================================================================== --- releng/12.1/UPDATING Tue Dec 8 18:47:22 2020 (r368462) +++ releng/12.1/UPDATING Tue Dec 8 19:10:40 2020 (r368463) @@ -16,6 +16,10 @@ from older versions of FreeBSD, try WITHOUT_CLANG and the tip of head, and then rebuild without this option. The bootstrap process from older version of current across the gcc/clang cutover is a bit fragile. +20201208: p12 FreeBSD-SA-20:33.openssl + + Fix OpenSSL NULL pointer de-reference. [SA-20:33.openssl] + 20201201: p11 FreeBSD-EN-20:20.tzdata FreeBSD-SA-20:31.icmp6 FreeBSD-SA-20:32.rtsold Modified: releng/12.1/crypto/openssl/crypto/asn1/asn1_err.c ============================================================================== --- releng/12.1/crypto/openssl/crypto/asn1/asn1_err.c Tue Dec 8 18:47:22 2020 (r368462) +++ releng/12.1/crypto/openssl/crypto/asn1/asn1_err.c Tue Dec 8 19:10:40 2020 (r368463) @@ -1,6 +1,6 @@ /* * Generated by util/mkerr.pl DO NOT EDIT - * Copyright 1995-2018 The OpenSSL Project Authors. All Rights Reserved. + * Copyright 1995-2020 The OpenSSL Project Authors. All Rights Reserved. * * Licensed under the OpenSSL license (the "License"). You may not use * this file except in compliance with the License. You can obtain a copy @@ -49,6 +49,7 @@ static const ERR_STRING_DATA ASN1_str_functs[] = { "asn1_item_embed_d2i"}, {ERR_PACK(ERR_LIB_ASN1, ASN1_F_ASN1_ITEM_EMBED_NEW, 0), "asn1_item_embed_new"}, + {ERR_PACK(ERR_LIB_ASN1, ASN1_F_ASN1_ITEM_EX_I2D, 0), "ASN1_item_ex_i2d"}, {ERR_PACK(ERR_LIB_ASN1, ASN1_F_ASN1_ITEM_FLAGS_I2D, 0), "asn1_item_flags_i2d"}, {ERR_PACK(ERR_LIB_ASN1, ASN1_F_ASN1_ITEM_I2D_BIO, 0), "ASN1_item_i2d_bio"}, @@ -160,6 +161,7 @@ static const ERR_STRING_DATA ASN1_str_reasons[] = { "asn1 sig parse error"}, {ERR_PACK(ERR_LIB_ASN1, 0, ASN1_R_AUX_ERROR), "aux error"}, {ERR_PACK(ERR_LIB_ASN1, 0, ASN1_R_BAD_OBJECT_HEADER), "bad object header"}, + {ERR_PACK(ERR_LIB_ASN1, 0, ASN1_R_BAD_TEMPLATE), "bad template"}, {ERR_PACK(ERR_LIB_ASN1, 0, ASN1_R_BMPSTRING_IS_WRONG_LENGTH), "bmpstring is wrong length"}, {ERR_PACK(ERR_LIB_ASN1, 0, ASN1_R_BN_LIB), "bn lib"}, Modified: releng/12.1/crypto/openssl/crypto/asn1/tasn_dec.c ============================================================================== --- releng/12.1/crypto/openssl/crypto/asn1/tasn_dec.c Tue Dec 8 18:47:22 2020 (r368462) +++ releng/12.1/crypto/openssl/crypto/asn1/tasn_dec.c Tue Dec 8 19:10:40 2020 (r368463) @@ -182,6 +182,15 @@ static int asn1_item_embed_d2i(ASN1_VALUE **pval, cons tag, aclass, opt, ctx); case ASN1_ITYPE_MSTRING: + /* + * It never makes sense for multi-strings to have implicit tagging, so + * if tag != -1, then this looks like an error in the template. + */ + if (tag != -1) { + ASN1err(ASN1_F_ASN1_ITEM_EMBED_D2I, ASN1_R_BAD_TEMPLATE); + goto err; + } + p = *in; /* Just read in tag and class */ ret = asn1_check_tlen(NULL, &otag, &oclass, NULL, NULL, @@ -199,6 +208,7 @@ static int asn1_item_embed_d2i(ASN1_VALUE **pval, cons ASN1err(ASN1_F_ASN1_ITEM_EMBED_D2I, ASN1_R_MSTRING_NOT_UNIVERSAL); goto err; } + /* Check tag matches bit map */ if (!(ASN1_tag2bit(otag) & it->utype)) { /* If OPTIONAL, assume this is OK */ @@ -215,6 +225,15 @@ static int asn1_item_embed_d2i(ASN1_VALUE **pval, cons return ef->asn1_ex_d2i(pval, in, len, it, tag, aclass, opt, ctx); case ASN1_ITYPE_CHOICE: + /* + * It never makes sense for CHOICE types to have implicit tagging, so + * if tag != -1, then this looks like an error in the template. + */ + if (tag != -1) { + ASN1err(ASN1_F_ASN1_ITEM_EMBED_D2I, ASN1_R_BAD_TEMPLATE); + goto err; + } + if (asn1_cb && !asn1_cb(ASN1_OP_D2I_PRE, pval, it, NULL)) goto auxerr; if (*pval) { Modified: releng/12.1/crypto/openssl/crypto/asn1/tasn_enc.c ============================================================================== --- releng/12.1/crypto/openssl/crypto/asn1/tasn_enc.c Tue Dec 8 18:47:22 2020 (r368462) +++ releng/12.1/crypto/openssl/crypto/asn1/tasn_enc.c Tue Dec 8 19:10:40 2020 (r368463) @@ -103,9 +103,25 @@ int ASN1_item_ex_i2d(ASN1_VALUE **pval, unsigned char return asn1_i2d_ex_primitive(pval, out, it, tag, aclass); case ASN1_ITYPE_MSTRING: + /* + * It never makes sense for multi-strings to have implicit tagging, so + * if tag != -1, then this looks like an error in the template. + */ + if (tag != -1) { + ASN1err(ASN1_F_ASN1_ITEM_EX_I2D, ASN1_R_BAD_TEMPLATE); + return -1; + } return asn1_i2d_ex_primitive(pval, out, it, -1, aclass); case ASN1_ITYPE_CHOICE: + /* + * It never makes sense for CHOICE types to have implicit tagging, so + * if tag != -1, then this looks like an error in the template. + */ + if (tag != -1) { + ASN1err(ASN1_F_ASN1_ITEM_EX_I2D, ASN1_R_BAD_TEMPLATE); + return -1; + } if (asn1_cb && !asn1_cb(ASN1_OP_I2D_PRE, pval, it, NULL)) return 0; i = asn1_get_choice_selector(pval, it); Modified: releng/12.1/crypto/openssl/crypto/err/openssl.txt ============================================================================== --- releng/12.1/crypto/openssl/crypto/err/openssl.txt Tue Dec 8 18:47:22 2020 (r368462) +++ releng/12.1/crypto/openssl/crypto/err/openssl.txt Tue Dec 8 19:10:40 2020 (r368463) @@ -36,6 +36,7 @@ ASN1_F_ASN1_ITEM_D2I_FP:206:ASN1_item_d2i_fp ASN1_F_ASN1_ITEM_DUP:191:ASN1_item_dup ASN1_F_ASN1_ITEM_EMBED_D2I:120:asn1_item_embed_d2i ASN1_F_ASN1_ITEM_EMBED_NEW:121:asn1_item_embed_new +ASN1_F_ASN1_ITEM_EX_I2D:144:ASN1_item_ex_i2d ASN1_F_ASN1_ITEM_FLAGS_I2D:118:asn1_item_flags_i2d ASN1_F_ASN1_ITEM_I2D_BIO:192:ASN1_item_i2d_bio ASN1_F_ASN1_ITEM_I2D_FP:193:ASN1_item_i2d_fp @@ -1765,6 +1766,7 @@ ASN1_R_ASN1_PARSE_ERROR:203:asn1 parse error ASN1_R_ASN1_SIG_PARSE_ERROR:204:asn1 sig parse error ASN1_R_AUX_ERROR:100:aux error ASN1_R_BAD_OBJECT_HEADER:102:bad object header +ASN1_R_BAD_TEMPLATE:230:bad template ASN1_R_BMPSTRING_IS_WRONG_LENGTH:214:bmpstring is wrong length ASN1_R_BN_LIB:105:bn lib ASN1_R_BOOLEAN_IS_WRONG_LENGTH:106:boolean is wrong length Modified: releng/12.1/crypto/openssl/crypto/x509v3/v3_genn.c ============================================================================== --- releng/12.1/crypto/openssl/crypto/x509v3/v3_genn.c Tue Dec 8 18:47:22 2020 (r368462) +++ releng/12.1/crypto/openssl/crypto/x509v3/v3_genn.c Tue Dec 8 19:10:40 2020 (r368463) @@ -22,8 +22,9 @@ ASN1_SEQUENCE(OTHERNAME) = { IMPLEMENT_ASN1_FUNCTIONS(OTHERNAME) ASN1_SEQUENCE(EDIPARTYNAME) = { - ASN1_IMP_OPT(EDIPARTYNAME, nameAssigner, DIRECTORYSTRING, 0), - ASN1_IMP_OPT(EDIPARTYNAME, partyName, DIRECTORYSTRING, 1) + /* DirectoryString is a CHOICE type so use explicit tagging */ + ASN1_EXP_OPT(EDIPARTYNAME, nameAssigner, DIRECTORYSTRING, 0), + ASN1_EXP(EDIPARTYNAME, partyName, DIRECTORYSTRING, 1) } ASN1_SEQUENCE_END(EDIPARTYNAME) IMPLEMENT_ASN1_FUNCTIONS(EDIPARTYNAME) @@ -57,6 +58,37 @@ GENERAL_NAME *GENERAL_NAME_dup(GENERAL_NAME *a) (char *)a); } +static int edipartyname_cmp(const EDIPARTYNAME *a, const EDIPARTYNAME *b) +{ + int res; + + if (a == NULL || b == NULL) { + /* + * Shouldn't be possible in a valid GENERAL_NAME, but we handle it + * anyway. OTHERNAME_cmp treats NULL != NULL so we do the same here + */ + return -1; + } + if (a->nameAssigner == NULL && b->nameAssigner != NULL) + return -1; + if (a->nameAssigner != NULL && b->nameAssigner == NULL) + return 1; + /* If we get here then both have nameAssigner set, or both unset */ + if (a->nameAssigner != NULL) { + res = ASN1_STRING_cmp(a->nameAssigner, b->nameAssigner); + if (res != 0) + return res; + } + /* + * partyName is required, so these should never be NULL. We treat it in + * the same way as the a == NULL || b == NULL case above + */ + if (a->partyName == NULL || b->partyName == NULL) + return -1; + + return ASN1_STRING_cmp(a->partyName, b->partyName); +} + /* Returns 0 if they are equal, != 0 otherwise. */ int GENERAL_NAME_cmp(GENERAL_NAME *a, GENERAL_NAME *b) { @@ -66,8 +98,11 @@ int GENERAL_NAME_cmp(GENERAL_NAME *a, GENERAL_NAME *b) return -1; switch (a->type) { case GEN_X400: + result = ASN1_TYPE_cmp(a->d.x400Address, b->d.x400Address); + break; + case GEN_EDIPARTY: - result = ASN1_TYPE_cmp(a->d.other, b->d.other); + result = edipartyname_cmp(a->d.ediPartyName, b->d.ediPartyName); break; case GEN_OTHERNAME: @@ -114,8 +149,11 @@ void GENERAL_NAME_set0_value(GENERAL_NAME *a, int type { switch (type) { case GEN_X400: + a->d.x400Address = value; + break; + case GEN_EDIPARTY: - a->d.other = value; + a->d.ediPartyName = value; break; case GEN_OTHERNAME: @@ -149,8 +187,10 @@ void *GENERAL_NAME_get0_value(const GENERAL_NAME *a, i *ptype = a->type; switch (a->type) { case GEN_X400: + return a->d.x400Address; + case GEN_EDIPARTY: - return a->d.other; + return a->d.ediPartyName; case GEN_OTHERNAME: return a->d.otherName; Modified: releng/12.1/crypto/openssl/include/openssl/asn1err.h ============================================================================== --- releng/12.1/crypto/openssl/include/openssl/asn1err.h Tue Dec 8 18:47:22 2020 (r368462) +++ releng/12.1/crypto/openssl/include/openssl/asn1err.h Tue Dec 8 19:10:40 2020 (r368463) @@ -1,6 +1,6 @@ /* * Generated by util/mkerr.pl DO NOT EDIT - * Copyright 1995-2019 The OpenSSL Project Authors. All Rights Reserved. + * Copyright 1995-2020 The OpenSSL Project Authors. All Rights Reserved. * * Licensed under the OpenSSL license (the "License"). You may not use * this file except in compliance with the License. You can obtain a copy @@ -11,9 +11,7 @@ #ifndef HEADER_ASN1ERR_H # define HEADER_ASN1ERR_H -# ifndef HEADER_SYMHACKS_H -# include -# endif +# include # ifdef __cplusplus extern "C" @@ -53,6 +51,7 @@ int ERR_load_ASN1_strings(void); # define ASN1_F_ASN1_ITEM_DUP 191 # define ASN1_F_ASN1_ITEM_EMBED_D2I 120 # define ASN1_F_ASN1_ITEM_EMBED_NEW 121 +# define ASN1_F_ASN1_ITEM_EX_I2D 144 # define ASN1_F_ASN1_ITEM_FLAGS_I2D 118 # define ASN1_F_ASN1_ITEM_I2D_BIO 192 # define ASN1_F_ASN1_ITEM_I2D_FP 193 @@ -145,6 +144,7 @@ int ERR_load_ASN1_strings(void); # define ASN1_R_ASN1_SIG_PARSE_ERROR 204 # define ASN1_R_AUX_ERROR 100 # define ASN1_R_BAD_OBJECT_HEADER 102 +# define ASN1_R_BAD_TEMPLATE 230 # define ASN1_R_BMPSTRING_IS_WRONG_LENGTH 214 # define ASN1_R_BN_LIB 105 # define ASN1_R_BOOLEAN_IS_WRONG_LENGTH 106 Modified: releng/12.1/sys/conf/newvers.sh ============================================================================== --- releng/12.1/sys/conf/newvers.sh Tue Dec 8 18:47:22 2020 (r368462) +++ releng/12.1/sys/conf/newvers.sh Tue Dec 8 19:10:40 2020 (r368463) @@ -46,7 +46,7 @@ TYPE="FreeBSD" REVISION="12.1" -BRANCH="RELEASE-p11" +BRANCH="RELEASE-p12" if [ -n "${BRANCH_OVERRIDE}" ]; then BRANCH=${BRANCH_OVERRIDE} fi Modified: releng/12.2/UPDATING ============================================================================== --- releng/12.2/UPDATING Tue Dec 8 18:47:22 2020 (r368462) +++ releng/12.2/UPDATING Tue Dec 8 19:10:40 2020 (r368463) @@ -16,6 +16,10 @@ from older versions of FreeBSD, try WITHOUT_CLANG and the tip of head, and then rebuild without this option. The bootstrap process from older version of current across the gcc/clang cutover is a bit fragile. +20201208: p2 FreeBSD-SA-20:33.openssl + + Fix OpenSSL NULL pointer de-reference. [SA-20:33.openssl] + 20201201: p1 FreeBSD-EN-20:19.audit FreeBSD-EN-20:20.tzdata FreeBSD-EN-20:21.ipfw Modified: releng/12.2/crypto/openssl/crypto/asn1/asn1_err.c ============================================================================== --- releng/12.2/crypto/openssl/crypto/asn1/asn1_err.c Tue Dec 8 18:47:22 2020 (r368462) +++ releng/12.2/crypto/openssl/crypto/asn1/asn1_err.c Tue Dec 8 19:10:40 2020 (r368463) @@ -1,6 +1,6 @@ /* * Generated by util/mkerr.pl DO NOT EDIT - * Copyright 1995-2018 The OpenSSL Project Authors. All Rights Reserved. + * Copyright 1995-2020 The OpenSSL Project Authors. All Rights Reserved. * * Licensed under the OpenSSL license (the "License"). You may not use * this file except in compliance with the License. You can obtain a copy @@ -49,6 +49,7 @@ static const ERR_STRING_DATA ASN1_str_functs[] = { "asn1_item_embed_d2i"}, {ERR_PACK(ERR_LIB_ASN1, ASN1_F_ASN1_ITEM_EMBED_NEW, 0), "asn1_item_embed_new"}, + {ERR_PACK(ERR_LIB_ASN1, ASN1_F_ASN1_ITEM_EX_I2D, 0), "ASN1_item_ex_i2d"}, {ERR_PACK(ERR_LIB_ASN1, ASN1_F_ASN1_ITEM_FLAGS_I2D, 0), "asn1_item_flags_i2d"}, {ERR_PACK(ERR_LIB_ASN1, ASN1_F_ASN1_ITEM_I2D_BIO, 0), "ASN1_item_i2d_bio"}, @@ -160,6 +161,7 @@ static const ERR_STRING_DATA ASN1_str_reasons[] = { "asn1 sig parse error"}, {ERR_PACK(ERR_LIB_ASN1, 0, ASN1_R_AUX_ERROR), "aux error"}, {ERR_PACK(ERR_LIB_ASN1, 0, ASN1_R_BAD_OBJECT_HEADER), "bad object header"}, + {ERR_PACK(ERR_LIB_ASN1, 0, ASN1_R_BAD_TEMPLATE), "bad template"}, {ERR_PACK(ERR_LIB_ASN1, 0, ASN1_R_BMPSTRING_IS_WRONG_LENGTH), "bmpstring is wrong length"}, {ERR_PACK(ERR_LIB_ASN1, 0, ASN1_R_BN_LIB), "bn lib"}, Modified: releng/12.2/crypto/openssl/crypto/asn1/tasn_dec.c ============================================================================== --- releng/12.2/crypto/openssl/crypto/asn1/tasn_dec.c Tue Dec 8 18:47:22 2020 (r368462) +++ releng/12.2/crypto/openssl/crypto/asn1/tasn_dec.c Tue Dec 8 19:10:40 2020 (r368463) @@ -182,6 +182,15 @@ static int asn1_item_embed_d2i(ASN1_VALUE **pval, cons tag, aclass, opt, ctx); case ASN1_ITYPE_MSTRING: + /* + * It never makes sense for multi-strings to have implicit tagging, so + * if tag != -1, then this looks like an error in the template. + */ + if (tag != -1) { + ASN1err(ASN1_F_ASN1_ITEM_EMBED_D2I, ASN1_R_BAD_TEMPLATE); + goto err; + } + p = *in; /* Just read in tag and class */ ret = asn1_check_tlen(NULL, &otag, &oclass, NULL, NULL, @@ -199,6 +208,7 @@ static int asn1_item_embed_d2i(ASN1_VALUE **pval, cons ASN1err(ASN1_F_ASN1_ITEM_EMBED_D2I, ASN1_R_MSTRING_NOT_UNIVERSAL); goto err; } + /* Check tag matches bit map */ if (!(ASN1_tag2bit(otag) & it->utype)) { /* If OPTIONAL, assume this is OK */ @@ -215,6 +225,15 @@ static int asn1_item_embed_d2i(ASN1_VALUE **pval, cons return ef->asn1_ex_d2i(pval, in, len, it, tag, aclass, opt, ctx); case ASN1_ITYPE_CHOICE: + /* + * It never makes sense for CHOICE types to have implicit tagging, so + * if tag != -1, then this looks like an error in the template. + */ + if (tag != -1) { + ASN1err(ASN1_F_ASN1_ITEM_EMBED_D2I, ASN1_R_BAD_TEMPLATE); + goto err; + } + if (asn1_cb && !asn1_cb(ASN1_OP_D2I_PRE, pval, it, NULL)) goto auxerr; if (*pval) { Modified: releng/12.2/crypto/openssl/crypto/asn1/tasn_enc.c ============================================================================== --- releng/12.2/crypto/openssl/crypto/asn1/tasn_enc.c Tue Dec 8 18:47:22 2020 (r368462) +++ releng/12.2/crypto/openssl/crypto/asn1/tasn_enc.c Tue Dec 8 19:10:40 2020 (r368463) @@ -103,9 +103,25 @@ int ASN1_item_ex_i2d(ASN1_VALUE **pval, unsigned char return asn1_i2d_ex_primitive(pval, out, it, tag, aclass); case ASN1_ITYPE_MSTRING: + /* + * It never makes sense for multi-strings to have implicit tagging, so + * if tag != -1, then this looks like an error in the template. + */ + if (tag != -1) { + ASN1err(ASN1_F_ASN1_ITEM_EX_I2D, ASN1_R_BAD_TEMPLATE); + return -1; + } return asn1_i2d_ex_primitive(pval, out, it, -1, aclass); case ASN1_ITYPE_CHOICE: + /* + * It never makes sense for CHOICE types to have implicit tagging, so + * if tag != -1, then this looks like an error in the template. + */ + if (tag != -1) { + ASN1err(ASN1_F_ASN1_ITEM_EX_I2D, ASN1_R_BAD_TEMPLATE); + return -1; + } if (asn1_cb && !asn1_cb(ASN1_OP_I2D_PRE, pval, it, NULL)) return 0; i = asn1_get_choice_selector(pval, it); Modified: releng/12.2/crypto/openssl/crypto/err/openssl.txt ============================================================================== --- releng/12.2/crypto/openssl/crypto/err/openssl.txt Tue Dec 8 18:47:22 2020 (r368462) +++ releng/12.2/crypto/openssl/crypto/err/openssl.txt Tue Dec 8 19:10:40 2020 (r368463) @@ -36,6 +36,7 @@ ASN1_F_ASN1_ITEM_D2I_FP:206:ASN1_item_d2i_fp ASN1_F_ASN1_ITEM_DUP:191:ASN1_item_dup ASN1_F_ASN1_ITEM_EMBED_D2I:120:asn1_item_embed_d2i ASN1_F_ASN1_ITEM_EMBED_NEW:121:asn1_item_embed_new +ASN1_F_ASN1_ITEM_EX_I2D:144:ASN1_item_ex_i2d ASN1_F_ASN1_ITEM_FLAGS_I2D:118:asn1_item_flags_i2d ASN1_F_ASN1_ITEM_I2D_BIO:192:ASN1_item_i2d_bio ASN1_F_ASN1_ITEM_I2D_FP:193:ASN1_item_i2d_fp @@ -1771,6 +1772,7 @@ ASN1_R_ASN1_PARSE_ERROR:203:asn1 parse error ASN1_R_ASN1_SIG_PARSE_ERROR:204:asn1 sig parse error ASN1_R_AUX_ERROR:100:aux error ASN1_R_BAD_OBJECT_HEADER:102:bad object header +ASN1_R_BAD_TEMPLATE:230:bad template ASN1_R_BMPSTRING_IS_WRONG_LENGTH:214:bmpstring is wrong length ASN1_R_BN_LIB:105:bn lib ASN1_R_BOOLEAN_IS_WRONG_LENGTH:106:boolean is wrong length Modified: releng/12.2/crypto/openssl/crypto/x509v3/v3_genn.c ============================================================================== --- releng/12.2/crypto/openssl/crypto/x509v3/v3_genn.c Tue Dec 8 18:47:22 2020 (r368462) +++ releng/12.2/crypto/openssl/crypto/x509v3/v3_genn.c Tue Dec 8 19:10:40 2020 (r368463) @@ -22,8 +22,9 @@ ASN1_SEQUENCE(OTHERNAME) = { IMPLEMENT_ASN1_FUNCTIONS(OTHERNAME) ASN1_SEQUENCE(EDIPARTYNAME) = { - ASN1_IMP_OPT(EDIPARTYNAME, nameAssigner, DIRECTORYSTRING, 0), - ASN1_IMP_OPT(EDIPARTYNAME, partyName, DIRECTORYSTRING, 1) + /* DirectoryString is a CHOICE type so use explicit tagging */ + ASN1_EXP_OPT(EDIPARTYNAME, nameAssigner, DIRECTORYSTRING, 0), + ASN1_EXP(EDIPARTYNAME, partyName, DIRECTORYSTRING, 1) } ASN1_SEQUENCE_END(EDIPARTYNAME) IMPLEMENT_ASN1_FUNCTIONS(EDIPARTYNAME) @@ -57,6 +58,37 @@ GENERAL_NAME *GENERAL_NAME_dup(GENERAL_NAME *a) (char *)a); } +static int edipartyname_cmp(const EDIPARTYNAME *a, const EDIPARTYNAME *b) +{ + int res; + + if (a == NULL || b == NULL) { + /* + * Shouldn't be possible in a valid GENERAL_NAME, but we handle it + * anyway. OTHERNAME_cmp treats NULL != NULL so we do the same here + */ + return -1; + } + if (a->nameAssigner == NULL && b->nameAssigner != NULL) + return -1; + if (a->nameAssigner != NULL && b->nameAssigner == NULL) + return 1; + /* If we get here then both have nameAssigner set, or both unset */ + if (a->nameAssigner != NULL) { + res = ASN1_STRING_cmp(a->nameAssigner, b->nameAssigner); + if (res != 0) + return res; + } + /* + * partyName is required, so these should never be NULL. We treat it in + * the same way as the a == NULL || b == NULL case above + */ + if (a->partyName == NULL || b->partyName == NULL) + return -1; + + return ASN1_STRING_cmp(a->partyName, b->partyName); +} + /* Returns 0 if they are equal, != 0 otherwise. */ int GENERAL_NAME_cmp(GENERAL_NAME *a, GENERAL_NAME *b) { @@ -66,8 +98,11 @@ int GENERAL_NAME_cmp(GENERAL_NAME *a, GENERAL_NAME *b) return -1; switch (a->type) { case GEN_X400: + result = ASN1_TYPE_cmp(a->d.x400Address, b->d.x400Address); + break; + case GEN_EDIPARTY: - result = ASN1_TYPE_cmp(a->d.other, b->d.other); + result = edipartyname_cmp(a->d.ediPartyName, b->d.ediPartyName); break; case GEN_OTHERNAME: @@ -114,8 +149,11 @@ void GENERAL_NAME_set0_value(GENERAL_NAME *a, int type { switch (type) { case GEN_X400: + a->d.x400Address = value; + break; + case GEN_EDIPARTY: - a->d.other = value; + a->d.ediPartyName = value; break; case GEN_OTHERNAME: @@ -149,8 +187,10 @@ void *GENERAL_NAME_get0_value(const GENERAL_NAME *a, i *ptype = a->type; switch (a->type) { case GEN_X400: + return a->d.x400Address; + case GEN_EDIPARTY: - return a->d.other; + return a->d.ediPartyName; case GEN_OTHERNAME: return a->d.otherName; Modified: releng/12.2/crypto/openssl/include/openssl/asn1err.h ============================================================================== --- releng/12.2/crypto/openssl/include/openssl/asn1err.h Tue Dec 8 18:47:22 2020 (r368462) +++ releng/12.2/crypto/openssl/include/openssl/asn1err.h Tue Dec 8 19:10:40 2020 (r368463) @@ -1,6 +1,6 @@ /* * Generated by util/mkerr.pl DO NOT EDIT - * Copyright 1995-2019 The OpenSSL Project Authors. All Rights Reserved. + * Copyright 1995-2020 The OpenSSL Project Authors. All Rights Reserved. * * Licensed under the OpenSSL license (the "License"). You may not use * this file except in compliance with the License. You can obtain a copy @@ -11,9 +11,7 @@ #ifndef HEADER_ASN1ERR_H # define HEADER_ASN1ERR_H -# ifndef HEADER_SYMHACKS_H -# include -# endif +# include # ifdef __cplusplus extern "C" @@ -53,6 +51,7 @@ int ERR_load_ASN1_strings(void); # define ASN1_F_ASN1_ITEM_DUP 191 # define ASN1_F_ASN1_ITEM_EMBED_D2I 120 # define ASN1_F_ASN1_ITEM_EMBED_NEW 121 +# define ASN1_F_ASN1_ITEM_EX_I2D 144 # define ASN1_F_ASN1_ITEM_FLAGS_I2D 118 # define ASN1_F_ASN1_ITEM_I2D_BIO 192 # define ASN1_F_ASN1_ITEM_I2D_FP 193 @@ -145,6 +144,7 @@ int ERR_load_ASN1_strings(void); # define ASN1_R_ASN1_SIG_PARSE_ERROR 204 # define ASN1_R_AUX_ERROR 100 # define ASN1_R_BAD_OBJECT_HEADER 102 +# define ASN1_R_BAD_TEMPLATE 230 # define ASN1_R_BMPSTRING_IS_WRONG_LENGTH 214 # define ASN1_R_BN_LIB 105 # define ASN1_R_BOOLEAN_IS_WRONG_LENGTH 106 Modified: releng/12.2/sys/conf/newvers.sh ============================================================================== --- releng/12.2/sys/conf/newvers.sh Tue Dec 8 18:47:22 2020 (r368462) +++ releng/12.2/sys/conf/newvers.sh Tue Dec 8 19:10:40 2020 (r368463) @@ -49,7 +49,7 @@ TYPE="FreeBSD" REVISION="12.2" -BRANCH="RELEASE-p1" +BRANCH="RELEASE-p2" if [ -n "${BRANCH_OVERRIDE}" ]; then BRANCH=${BRANCH_OVERRIDE} fi From owner-svn-src-releng@freebsd.org Thu Dec 10 17:23:22 2020 Return-Path: Delivered-To: svn-src-releng@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BC1BE4B139C for ; Thu, 10 Dec 2020 17:23:22 +0000 (UTC) (envelope-from ameya.181co205@nitk.edu.in) Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CsLNS2MTWz4k7v for ; Thu, 10 Dec 2020 17:23:18 +0000 (UTC) (envelope-from ameya.181co205@nitk.edu.in) Received: by mail-ot1-x32f.google.com with SMTP id 11so5586559oty.9 for ; Thu, 10 Dec 2020 09:23:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=cOGynsjS3/PCAgWhIFDrJBm1JFxUDa4HcZCYMcTYP7I=; b=bHfOQL0awwa3dr4/utBviNEqFBZigNAoKsR1KgjXNeqFOVcxzdmiXiRziG4Sm35usl xi2ne0rlwT3WnlPkFQFslTT0ra3et6Dmkn5MlRBXgyYsv91iX8QYCqWl/c8ne7vsQP2S lbGaEk5FH4Z0nwBeNa4O7i9DwDYbinfnUwuLB+8i0FqlmGTMBTXxVhPp6+BXWAVSWb01 fXRpQWdfzlUlyIxnjMopMMHT3PWPoKFByVd26FL2BQMWM5p9vEhgL6AbHcpu14Tt1ugq 3JjcDfmz8trLYPE8imrcfUpINVXoO6mi/1iKibjtqeK6ZCT9p14r+xmpJGM7GEjfWrC+ lRPA== X-Gm-Message-State: AOAM531aDeq5/CHEEQGFPpC+g2wq045R9QGDCoNsvSmZWa5Ik4CWppGm 3i1xwR0C0Y9IMY0QLGQuVPp/cDMMusRqV/Pnzhh6Pmch7WS6AA== X-Google-Smtp-Source: ABdhPJz3cRB1z/1a4si/LYHolRYl7yqSV2LTPQOEMPGVf5+PWRPCFwpQsz6S+c6stlJi5maFSfIwKnxWPPnJFAHQII0= X-Received: by 2002:a9d:d8a:: with SMTP id 10mr6486024ots.11.1607620997087; Thu, 10 Dec 2020 09:23:17 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:6830:2331:0:0:0:0 with HTTP; Thu, 10 Dec 2020 09:23:16 -0800 (PST) From: "Ameya Deshpande." Date: Thu, 10 Dec 2020 22:53:16 +0530 Message-ID: Subject: Build issues in releng/11.0 To: svn-src-releng@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4CsLNS2MTWz4k7v X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.58 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[nitk.edu.in:s=google]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-releng@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::32f:from:127.0.2.255]; DKIM_TRACE(0.00)[nitk.edu.in:+]; DMARC_POLICY_ALLOW(-0.50)[nitk.edu.in,reject]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::32f:from]; NEURAL_HAM_SHORT(-0.58)[-0.577]; NEURAL_HAM_LONG(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::32f:from]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[svn-src-releng] X-BeenThere: svn-src-releng@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the release engineering / security commits to the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Dec 2020 17:23:22 -0000 Hello to the mail recipients, I am a student and new to FreeBSD Development. My work is specific to FreeBSD 11.0-RELEASE. According to this document [1], branch "releng/11.0" corresponds 11.0-RELEASE. When I build the kernel by fetching "releng/11.0", I am getting some errors. Initially, I got the error: ``` cc: error: unknown argument: '-fformat-extensions' ``` Unfortunately, I did not get a solution for this. But I found an option in "tools/build/options" and tried building the kernel using "make buildkernel WITHOUT_FORMAT_EXTENSIONS=yes". This helped me to bypass the above error but I got another error: ``` In file included from /usr/src/sys/cam/cam.c:45: In file included from /usr/src/sys/cam/cam_ccb.h:44: In file included from /usr/src/sys/cam/nvme/nvme_all.h:32: /usr/src/sys/dev/nvme/nvme.h:922:16: error: taking address of packed member 'cdw10' of class or structure 'nvme_command' may result in an unaligned pointer value [-Werror,-Waddress-of-packed-member] *(uint64_t *)&cmd->cdw10 = lba; ^~~~~~~~~~ 1 error generated. *** Error code 1 ``` I am not facing any issues building other kernels versions like 'stable/11' or 'head'. Ideally, I assumed a similar build process for 'releng/11.0'. Please let me know how can I build a FreeBSD 11.0-RELEASE kernel. Thanks, Ameya Deshpande [1]: https://www.freebsd.org/security/unsupported.html