From owner-freebsd-hackers Sun May 14 01:40:26 1995 Return-Path: hackers-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id BAA00481 for hackers-outgoing; Sun, 14 May 1995 01:40:26 -0700 Received: from zibbi.mikom.csir.co.za (some.schmuck.lame.delegated.to.RAIN.PSG.COM [146.64.24.58]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id BAA00474 for ; Sun, 14 May 1995 01:40:11 -0700 Received: (from jhay@localhost) by zibbi.mikom.csir.co.za (8.6.11/8.6.6) id KAA20547; Sun, 14 May 1995 10:41:50 +0200 From: John Hay Message-Id: <199505140841.KAA20547@zibbi.mikom.csir.co.za> Subject: Re: Questions/comments on ed driver To: davidg@Root.COM Date: Sun, 14 May 1995 10:41:50 +0200 (SAT) Cc: seki@sysrap.cs.fujitsu.co.jp, FreeBSD-Hackers@FreeBSD.org In-Reply-To: <199505121920.MAA00152@corbin.Root.COM> from "David Greenman" at May 12, 95 12:20:49 pm X-Mailer: ELM [version 2.4 PL23] Content-Type: text Content-Length: 1117 Sender: hackers-owner@FreeBSD.org Precedence: bulk > > >I examined the ed driver (of 950412 SNAP.) I found some (essentially > >2) strangeness in it. I'm not sure I found bugs or just > >misunderstood. > > > >It is appreciated if you hackers give me comments. > > > >1. If_ed.c defines ETHER_MAX be 1518 and ETHER_MIN 64. The length > >includes 4 bytes for CRC. However, it looks like the program compares > >them against packet lengths *without* CRC. > > Actually, the other 4 bytes is for the DS8390 packet header. The comparison > is correct. > I'm not sure that ETHER_MIN is correct. During December I hacked the NETNS code to do IPX, so that I could use a FreeBSD box to do IPX routing. I worked fine with DOS machines and packet drivers. When I used a client with the Novell ODI drivers it did not work until I changed ETHER_MIN to 60. Now I know that the ODI driver probably have a bug because they shouldn't care what the size of the packet is, but that led me to believe that the minimum packet size was too big. (64 bytes plus 4 for the CRC) One of my standard patches now is to change ETHER_MIN_LEN to 60. -- John Hay -- jhay@mikom.csir.co.za