From owner-freebsd-sparc Sun Feb 10 0:59:31 2002 Delivered-To: freebsd-sparc@freebsd.org Received: from k6.locore.ca (k6.locore.ca [198.96.117.170]) by hub.freebsd.org (Postfix) with ESMTP id 637CB37B400; Sun, 10 Feb 2002 00:59:29 -0800 (PST) Received: (from jake@localhost) by k6.locore.ca (8.11.6/8.11.6) id g1A9EdK53494; Sun, 10 Feb 2002 04:14:39 -0500 (EST) (envelope-from jake) Date: Sun, 10 Feb 2002 04:14:39 -0500 From: Jake Burkholder To: "David O'Brien" Cc: sparc64@FreeBSD.ORG Subject: Re: need to change the macro names in asmacros.h Message-ID: <20020210041439.C36713@locore.ca> References: <20020209221008.A44308@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020209221008.A44308@dragon.nuxi.com>; from obrien@FreeBSD.ORG on Sat, Feb 09, 2002 at 10:10:08PM -0800 Sender: owner-freebsd-sparc@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Apparently, On Sat, Feb 09, 2002 at 10:10:08PM -0800, David O'Brien said words to the effect of; > "DATA" etc al. is too easy to clash with other macros, and in fact > already does with existing kernel code. Can we change these macros to > _DATA, _ENTRY, etc.; or maybe ASMDATA, ASMENTRY, etc.? > > > In file included from ../../../dev/sym/sym_hipd.c:150: > ../../../dev/sym/sym_defs.h:869:1: warning: "DATA" redefined > In file included from machine/pcpu.h:35, > from ../../../sys/pcpu.h:38, > from ../../../sys/proc.h:56, > from ../../../dev/sym/sym_hipd.c:96: > machine/asmacros.h:123:1: warning: this is the location of the previous definition The ifdef LOCORE protection in asmacros.h is wrong. I think I intended to use these macros in libc, which is why they're exposed to the whole world, but that turned out not be necessary. I'll fix it. Thanks. Jake > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-sparc" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-sparc" in the body of the message