From owner-freebsd-bugs@FreeBSD.ORG Sun Dec 7 00:40:15 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C1F7D16A5A3; Sun, 7 Dec 2003 00:40:15 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 26C6C43FF7; Sun, 7 Dec 2003 00:40:13 -0800 (PST) (envelope-from tjr@FreeBSD.org) Received: from freefall.freebsd.org (tjr@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id hB78eDFY012779; Sun, 7 Dec 2003 00:40:13 -0800 (PST) (envelope-from tjr@freefall.freebsd.org) Received: (from tjr@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id hB78eCkS012775; Sun, 7 Dec 2003 00:40:12 -0800 (PST) (envelope-from tjr) Date: Sun, 7 Dec 2003 00:40:12 -0800 (PST) From: "Tim J. Robbins" Message-Id: <200312070840.hB78eCkS012775@freefall.freebsd.org> To: tim@robbins.dropbear.id.au, tjr@FreeBSD.org, freebsd-bugs@FreeBSD.org Subject: Re: bin/59369: pppctl does not work with IPV6 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Dec 2003 08:40:15 -0000 Synopsis: pppctl does not work with IPV6 State-Changed-From-To: open->closed State-Changed-By: tjr State-Changed-When: Sun Dec 7 00:39:51 PST 2003 State-Changed-Why: Fixed, will not MFC. http://www.freebsd.org/cgi/query-pr.cgi?pr=59369 From owner-freebsd-bugs@FreeBSD.ORG Sun Dec 7 14:00:46 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1C0DF16A4CE for ; Sun, 7 Dec 2003 14:00:46 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id F359543FCB for ; Sun, 7 Dec 2003 14:00:37 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id hB7M0bFY071603 for ; Sun, 7 Dec 2003 14:00:37 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id hB7M0bXW071602; Sun, 7 Dec 2003 14:00:37 -0800 (PST) (envelope-from gnats) Resent-Date: Sun, 7 Dec 2003 14:00:37 -0800 (PST) Resent-Message-Id: <200312072200.hB7M0bXW071602@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Stefan Farfeleder Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 22B4B16A4FC for ; Sun, 7 Dec 2003 13:59:59 -0800 (PST) Received: from fafoe.narf.at (chello212186121237.14.vie.surfer.at [212.186.121.237]) by mx1.FreeBSD.org (Postfix) with ESMTP id A872A43F85 for ; Sun, 7 Dec 2003 13:59:57 -0800 (PST) (envelope-from stefan@fafoe.narf.at) Received: from wombat.fafoe.narf.at (wombat.fafoe.narf.at [192.168.1.42]) by fafoe.narf.at (Postfix) with ESMTP id 7BB7740ED; Sun, 7 Dec 2003 22:59:45 +0100 (CET) Received: by wombat.fafoe.narf.at (Postfix, from userid 1001) id 5204C1AC; Sun, 7 Dec 2003 22:59:42 +0100 (CET) Message-Id: <20031207215942.5204C1AC@wombat.fafoe.narf.at> Date: Sun, 7 Dec 2003 22:59:42 +0100 (CET) From: Stefan Farfeleder To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: stefan@fafoe.narf.at Subject: bin/60026: [patch] Fix typo in malloc() size computation in fdformat.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Stefan Farfeleder List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Dec 2003 22:00:46 -0000 >Number: 60026 >Category: bin >Synopsis: [patch] Fix typo in malloc() size computation in fdformat.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Dec 07 14:00:37 PST 2003 >Closed-Date: >Last-Modified: >Originator: Stefan Farfeleder >Release: FreeBSD 5.2-BETA i386 >Organization: >Environment: System: FreeBSD wombat.fafoe.narf.at 5.2-BETA FreeBSD 5.2-BETA #8: Sat Dec 6 18:47:24 CET 2003 stefan@wombat.fafoe.narf.at:/usr/home/stefan/freebsd/obj/usr/home/stefan/freebsd/src/sys/WOMBAT i386 >Description: In fdformat.c a closing parenthesis is at the wrong place. Instead of adding sizeof _PATH_DEV + 1 to the length of argv[optind], the length of the string starting (sizeof _PATH_DEV + 1) characters after argv[optind]'s beginning (accessing junk memory if we jump over the terminating null character) is passed to malloc(). >How-To-Repeat: n/a >Fix: --- fdformat.c.diff begins here --- Index: src/usr.sbin/fdformat/fdformat.c =================================================================== RCS file: /usr/home/ncvs/src/usr.sbin/fdformat/fdformat.c,v retrieving revision 1.20 diff -u -r1.20 fdformat.c --- src/usr.sbin/fdformat/fdformat.c 1 Apr 2002 21:13:17 -0000 1.20 +++ src/usr.sbin/fdformat/fdformat.c 19 Nov 2003 17:19:55 -0000 @@ -205,7 +205,7 @@ if (stat(argv[optind], &sb) == -1 && errno == ENOENT) { /* try prepending _PATH_DEV */ - device = malloc(strlen(argv[optind] + sizeof _PATH_DEV + 1)); + device = malloc(strlen(argv[optind]) + sizeof _PATH_DEV + 1); if (device == 0) errx(EX_UNAVAILABLE, "out of memory"); strcpy(device, _PATH_DEV); --- fdformat.c.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: From owner-freebsd-bugs@FreeBSD.ORG Sun Dec 7 15:20:18 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D79216A4CE for ; Sun, 7 Dec 2003 15:20:18 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 96D4D43FDD for ; Sun, 7 Dec 2003 15:20:12 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id hB7NKCFY083120 for ; Sun, 7 Dec 2003 15:20:12 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id hB7NKC8j083119; Sun, 7 Dec 2003 15:20:12 -0800 (PST) (envelope-from gnats) Resent-Date: Sun, 7 Dec 2003 15:20:12 -0800 (PST) Resent-Message-Id: <200312072320.hB7NKC8j083119@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Mark Dixon" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A4EB216A4CF for ; Sun, 7 Dec 2003 15:15:14 -0800 (PST) Received: from anchor-post-34.mail.demon.net (anchor-post-34.mail.demon.net [194.217.242.92]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B2AB43FA3 for ; Sun, 7 Dec 2003 15:15:07 -0800 (PST) (envelope-from ) Received: from lizacnet.demon.co.uk ([80.177.208.105]) by anchor-post-34.mail.demon.net with esmtp (Exim 3.35 #1) id 1AT87F-0008kI-0Y for FreeBSD-gnats-submit@freebsd.org; Sun, 07 Dec 2003 23:15:05 +0000 Message-Id: <1070838931@lizacnet.demon.co.uk> Date: Sun, 7 Dec 2003 23:15:31 -0000 From: "Mark Dixon" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: gtk-send-pr 0.2 Subject: kern/60029: 5.2-RC will not boot with empty LS-120 drive and atapicam X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Dec 2003 23:20:18 -0000 >Number: 60029 >Category: kern >Synopsis: 5.2-RC will not boot with empty LS-120 drive and atapicam >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Dec 07 15:20:12 PST 2003 >Closed-Date: >Last-Modified: >Originator: Mark Dixon >Release: FreeBSD 5.2-RC i386 >Organization: >Environment: System: FreeBSD lizacnet.demon.co.uk 5.2-RC FreeBSD 5.2-RC #12: Sun Dec 7 17:50:18 GMT 2003 root@lizacnet.demon.co.uk:/usr/obj/usr/src/sys/MARKS i386 machine i386 cpu I686_CPU ident MARKS options SCHED_4BSD #4BSD scheduler options INET #InterNETworking options INET6 #IPv6 communications protocols options FFS #Berkeley Fast Filesystem options SOFTUPDATES #Enable FFS soft updates support options UFS_ACL #Support for access control lists options UFS_DIRHASH #Improve performance on big directories options MD_ROOT #MD is a potential root device options NFSCLIENT #Network Filesystem Client options NFSSERVER #Network Filesystem Server options NFS_ROOT #NFS usable as root device, requires NFSCLIENT options MSDOSFS #MSDOS Filesystem options CD9660 #ISO 9660 Filesystem options COMPAT_43 #Compatible with BSD 4.3 [KEEP THIS!] options COMPAT_FREEBSD4 #Compatible with FreeBSD4 options SCSI_DELAY=15000 #Delay (in ms) before probing SCSI options KTRACE #ktrace(1) support options SYSVSHM #SYSV-style shared memory options SYSVMSG #SYSV-style message queues options SYSVSEM #SYSV-style semaphores options _KPOSIX_PRIORITY_SCHEDULING #Posix P1003_1B real-time extensions options KBD_INSTALL_CDEV # install a CDEV entry in /dev options AHC_REG_PRETTY_PRINT # Print register bitfields in debug # output. Adds ~128k to driver. options AHD_REG_PRETTY_PRINT # Print register bitfields in debug # output. Adds ~215k to driver. options INVARIANT_SUPPORT #Extra sanity checks of internal structures, required by INVARIANTS device isa device eisa device pci # Floppy drives device fdc # ATA and ATAPI devices device ata device atadisk # ATA disk drives device atapicd # ATAPI CDROM drives device atapifd # ATAPI floppy drives options ATA_STATIC_ID #Static device numbering device ahc # AHA2940 and onboard AIC7xxx devices device ahd # AHA39320/29320 and onboard AIC79xx devices # SCSI peripherals device scbus # SCSI bus (required) device ch # SCSI media changers device da # Direct Access (disks) device sa # Sequential Access (tape etc) device cd # CD device pass # Passthrough device (direct SCSI access) device ses # SCSI Environmental Services (and SAF-TE) # atkbdc0 controls both the keyboard and the PS/2 mouse device atkbdc # AT keyboard controller device atkbd # AT keyboard device psm # PS/2 mouse device vga # VGA video card driver device splash # Splash screen and screen saver support # syscons is the default console driver, resembling an SCO console device sc device agp # support several AGP chipsets # Floating point support - do not disable. device npx # Add suspend/resume support for the i8254. device pmtimer # Serial (COM) ports device sio # 8250, 16[45]50 based serial ports # Parallel port device ppc device ppbus # Parallel port bus (required) device lpt # Printer device ppi # Parallel port interface device # PCI Ethernet NICs that use the common MII bus controller code. # NOTE: Be sure to keep the 'device miibus' line in order to use these NICs! device miibus # MII bus support device fxp # Intel EtherExpress PRO/100B (82557, 82558) # Wireless NIC cards device wlan # 802.11 support device an # Aironet 4500/4800 802.11 wireless NICs. device awi # BayStack 660 and others device wi # WaveLAN/Intersil/Symbol 802.11 wireless NICs. # Pseudo devices - the number indicates how many units to allocate. device random # Entropy device device loop # Network loopback device ether # Ethernet support device ppp # Kernel PPP device tun # Packet tunnel. device pty # Pseudo-ttys (telnet etc) device md # Memory "disks" device gif # IPv6 and IPv4 tunneling device faith # IPv6-to-IPv4 relaying (translation) # The `bpf' device enables the Berkeley Packet Filter. # Be aware of the administrative consequences of enabling this! device bpf # Berkeley packet filter # USB support device uhci # UHCI PCI->USB interface device ohci # OHCI PCI->USB interface device usb # USB Bus (required) device ugen # Generic device uhid # "Human Interface Devices" device ukbd # Keyboard device ulpt # Printer device umass # Disks/Mass storage - Requires scbus and da device ums # Mouse device uscanner # Scanners # atapicam for CD burnin' device atapicam # Allow use of natd options IPDIVERT Copyright (c) 1992-2003 The FreeBSD Project. Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994 The Regents of the University of California. All rights reserved. FreeBSD 5.2-RC #12: Sun Dec 7 17:50:18 GMT 2003 root@lizacnet.demon.co.uk:/usr/obj/usr/src/sys/MARKS Preloaded elf kernel "/boot/kernel/kernel" at 0xc08ac000. Preloaded elf module "/boot/kernel/snd_emu10k1.ko" at 0xc08ac21c. Preloaded elf module "/boot/kernel/snd_pcm.ko" at 0xc08ac2cc. Preloaded elf module "/boot/kernel/bktr.ko" at 0xc08ac378. Preloaded elf module "/boot/kernel/bktr_mem.ko" at 0xc08ac424. Preloaded elf module "/boot/kernel/iicbus.ko" at 0xc08ac4d4. Preloaded elf module "/boot/kernel/iicbb.ko" at 0xc08ac580. Preloaded elf module "/boot/kernel/smbus.ko" at 0xc08ac62c. Preloaded elf module "/boot/kernel/if_ath.ko" at 0xc08ac6d8. Preloaded elf module "/boot/kernel/ath_hal.ko" at 0xc08ac784. Preloaded elf module "/boot/kernel/acpi.ko" at 0xc08ac830. Timecounter "i8254" frequency 1193182 Hz quality 0 CPU: AMD Athlon(tm) Processor (1002.28-MHz 686-class CPU) Origin = "AuthenticAMD" Id = 0x642 Stepping = 2 Features=0x183f9ff AMD Features=0xc0440000 real memory = 402587648 (383 MB) avail memory = 381362176 (363 MB) bktr_mem: memory holder loaded Pentium Pro MTRR support enabled npx0: [FAST] npx0: on motherboard npx0: INT 16 interface acpi0: on motherboard pcibios: BIOS version 2.10 acpi0: Power Button (fixed) Timecounter "ACPI-fast" frequency 3579545 Hz quality 1000 acpi_timer0: <24-bit timer at 3.579545MHz> port 0x808-0x80b on acpi0 acpi_cpu0: on acpi0 acpi_button0: on acpi0 pcib0: port 0xcf8-0xcff on acpi0 pci0: on pcib0 pcib0: slot 7 INTD is routed to irq 10 pcib0: slot 7 INTD is routed to irq 10 pcib0: slot 10 INTA is routed to irq 5 pcib0: slot 12 INTA is routed to irq 11 pcib0: slot 13 INTA is routed to irq 9 pcib0: slot 15 INTA is routed to irq 10 pcib0: slot 16 INTA is routed to irq 10 agp0: mem 0xe0000000-0xe3ffffff at device 0.0 on pci0 pcib1: at device 1.0 on pci0 pci1: on pcib1 pcib0: slot 1 INTA is routed to irq 11 pcib1: slot 0 INTA is routed to irq 11 pci1: at device 0.0 (no driver attached) isab0: at device 7.0 on pci0 isa0: on isab0 atapci0: port 0xffa0-0xffaf at device 7.1 on pci0 ata0: at 0x1f0 irq 14 on atapci0 ata0: [MPSAFE] ata1: at 0x170 irq 15 on atapci0 ata1: [MPSAFE] uhci0: port 0xb800-0xb81f irq 10 at device 7.2 on pci0 usb0: on uhci0 usb0: USB revision 1.0 uhub0: VIA UHCI root hub, class 9/0, rev 1.00/1.00, addr 1 uhub0: 2 ports with 2 removable, self powered ugen0: WINBOND W9967CF, rev 1.10/1.10, addr 2 uhci1: port 0xbc00-0xbc1f irq 10 at device 7.3 on pci0 usb1: on uhci1 usb1: USB revision 1.0 uhub1: VIA UHCI root hub, class 9/0, rev 1.00/1.00, addr 1 uhub1: 2 ports with 2 removable, self powered ugen1: ALCATEL Speed Touch 330, rev 1.10/2.00, addr 2 pci0: at device 7.4 (no driver attached) fxp0: port 0xc000-0xc03f mem 0xdfe00000-0xdfefffff,0xdffbf000-0xdffbffff irq 5 at device 10.0 on pci0 fxp0: Ethernet address 00:90:27:be:59:fc miibus0: on fxp0 inphy0: on miibus0 inphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto pcm0: port 0xc400-0xc41f irq 11 at device 12.0 on pci0 pcm0: ath0: mem 0xdffc0000-0xdffcffff irq 9 at device 13.0 on pci0 ath0: mac 5.6 phy 4.1 5ghz radio 1.7 2ghz radio 2.3 ath0: 11b rates: 1Mbps 2Mbps 5.5Mbps 11Mbps ath0: 11g rates: 1Mbps 2Mbps 5.5Mbps 11Mbps 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps ath0: 802.11 address: 00:09:5b:89:c0:05 bktr0: mem 0xdd9ff000-0xdd9fffff irq 10 at device 15.0 on pci0 bktr0: Pinnacle/Miro TV, Temic PAL I tuner. atapci1: port 0xc800-0xc83f,0xcc00-0xcc03,0xd000-0xd007,0xd400-0xd403,0xd800-0xd807 mem 0xdffe0000-0xdfffffff irq 10 at device 16.0 on pci0 atapci1: [MPSAFE] ata2: at 0xd800 on atapci1 ata2: [MPSAFE] ata3: at 0xd000 on atapci1 ata3: [MPSAFE] acpi_button1: on acpi0 atkbdc0: port 0x64,0x60 irq 1 on acpi0 atkbd0: flags 0x1 irq 1 on atkbdc0 kbd0 at atkbd0 psm0: irq 12 on atkbdc0 psm0: model IntelliMouse, device ID 3 fdc0: port 0x3f7,0x3f2-0x3f5 irq 6 drq 2 on acpi0 sio0 port 0x3f8-0x3ff irq 4 on acpi0 sio0: type 16550A ppc0 port 0x778-0x77b,0x378-0x37f irq 7 drq 3 on acpi0 ppc0: SMC-like chipset (ECP/EPP/PS2/NIBBLE) in COMPATIBLE mode ppc0: FIFO with 16/16/8 bytes threshold ppbus0: on ppc0 lpt0: on ppbus0 lpt0: Interrupt-driven port ppi0: on ppbus0 orm0: