From owner-cvs-all@FreeBSD.ORG Sun Oct 10 00:46:39 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 83FFE16A4CE; Sun, 10 Oct 2004 00:46:39 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4BCE543D1D; Sun, 10 Oct 2004 00:46:39 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.5.51] (adsl-64-171-187-209.dsl.snfc21.pacbell.net [64.171.187.209]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id i9A0kV1d027340 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 9 Oct 2004 17:46:32 -0700 Message-ID: <41688662.80000@root.org> Date: Sat, 09 Oct 2004 17:46:26 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7.3 (Windows/20040803) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Takanori Watanabe References: <200410070510.i975AsrS029949@sana.init-main.com> In-Reply-To: <200410070510.i975AsrS029949@sana.init-main.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: src-committers@freebsd.org cc: robert.moore@intel.com cc: jhb@freebsd.org Subject: Re: cvs commit: src/usr.sbin/acpi/acpidump acpi.c acpidump.c acpidump.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Oct 2004 00:46:39 -0000 Takanori Watanabe wrote: > In message <41644415.3030402@root.org>, Nate Lawson wrote: > >>>I think ACPI-CA itself can override any SSDT by checking existing >>>SSDT header passed to AcpiOsTableOverride. >> >>I'm not sure what you mean here but I agree that AcpiOsTableOverride() >>should be able to decide whether to override an SSDT or not. All I'm >>asking for is a special return code from AcpiOsTableOverride() that >>means "ignore this table completely" so I don't have to provide a fake >>empty table to get this effect. > > The thing I want to say is like this. > In this code, I intended to be able to override arbitaly table > on a system, though I have never run it. And if iASL can accept > ASL file with multiple DefinitionBlock, you don't need to compound > all SSDT's into DSDT: all you have to do is concatinate SSDT > with DefinitionBlock to the tail of DSDT dump. > I think this approach is far more extensive, though I don't > deny current approach as a workaround. Ah, I understand. I think this approach is fine since acpidump would maintain the ordering from the XSDT, and the order in the ASL file of the DefinitionBlocks would determine which tables are overridden. This is definitely cleaner than our current approach and similar in that if you want to override one DSDT/SSDT table, you have to override them all (even if it's with the original contents for unmodified tables.) The only tough modification for this is for iasl(8) to be able to handle multiple DefinitionBlock entries in a single file. On the acpidump side, we can just run iasl -d multiple times and concatenate the results. -- Nate