From owner-freebsd-rc@FreeBSD.ORG Sun Dec 18 17:23:22 2005 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 94DB616A41F; Sun, 18 Dec 2005 17:23:22 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4096043D5F; Sun, 18 Dec 2005 17:23:21 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id A4C4E11B6F; Sun, 18 Dec 2005 18:23:19 +0100 (CET) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 89193-01; Sun, 18 Dec 2005 18:23:12 +0100 (CET) Received: from cream.xbsd.org (cream.xbsd.org [192.168.42.6]) by smtp.xbsd.org (Postfix) with ESMTP id 3731311B6B; Sun, 18 Dec 2005 18:23:12 +0100 (CET) From: Florent Thoumie To: Doug Barton In-Reply-To: <43A37617.2030406@FreeBSD.org> References: <43A33C0E.9050100@FreeBSD.org> <20051217000418.GC851@zaphod.nitro.dk> <43A35FA5.4050202@FreeBSD.org> <20051217031024.60912c94@it.buh.tecnik93.com> <43A36C4F.4010005@FreeBSD.org> <20051217034304.5ed69ef1@it.buh.tecnik93.com> <43A36F14.1050804@FreeBSD.org> <20051217040348.087f1248@it.buh.tecnik93.com> <43A37617.2030406@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-sRaF1mfhnYRQC1xjXagN" Date: Sun, 18 Dec 2005 18:23:11 +0100 Message-Id: <1134926591.744.4.camel@cream.xbsd.org> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port X-Virus-Scanned: amavisd-new at xbsd.org Cc: freebsd-rc@FreeBSD.org, "Simon L. Nielsen" Subject: Re: Should etc/rc.d/ike move to ports? X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Dec 2005 17:23:22 -0000 --=-sRaF1mfhnYRQC1xjXagN Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Fri, 2005-12-16 at 18:21 -0800, Doug Barton wrote: > Ion-Mihai Tetcu wrote: >=20 > > Yes, that's what I (wanted to) say. ("my" then =3D post-MFC, post-fix_p= orts). > > Pav's PR will get us support for this in bsd.port.mk, the rest is > > fixing the ports to be rc.d compatible and repo-copies. >=20 > That's great, although ironically I _just_ ran into a situation where tha= t=20 > is not the ideal way to do it. :) I am working on updating misc/compat5x= to=20 > use an rc.d-style script, and tried doing it the way that you suggested,=20 > with compat5x.in. When bsd.port.mk tried to create the boot script howeve= r,=20 > I got an error because work/compat5x already existed, it was the director= y=20 > in work where the tarball unpacked itself. Most of the time this is not=20 > going to be a problem, as the source directory will be versioned (like=20 > foopkg-1.2.3), but this is a corner case that should be kept in mind. >=20 > For now I'm going to suggest using compat5x.sh for this particular case, = it=20 > can be adjusted down the road if needed. FWIW, I like having .sh.in instead of .in because you=20 immediately know that it's a startup script, and it's not that=20 hard to remove a .sh suffix in shell. --=20 Florent Thoumie flz@FreeBSD.org FreeBSD committer --=-sRaF1mfhnYRQC1xjXagN Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBDpZr/MxEkbVFH3PQRAlNdAJ42zhDCjfQrDDm7DYjePbL9nqx/hACfX5he SpdETdJ1/hjwysaNzsIiJnI= =QiNz -----END PGP SIGNATURE----- --=-sRaF1mfhnYRQC1xjXagN-- From owner-freebsd-rc@FreeBSD.ORG Sun Dec 18 17:31:40 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 16A1016A41F for ; Sun, 18 Dec 2005 17:31:40 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id B59CC43D55 for ; Sun, 18 Dec 2005 17:31:29 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 9AA8911B6B for ; Sun, 18 Dec 2005 18:31:27 +0100 (CET) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 89193-02 for ; Sun, 18 Dec 2005 18:31:21 +0100 (CET) Received: from cream.xbsd.org (cream.xbsd.org [192.168.42.6]) by smtp.xbsd.org (Postfix) with ESMTP id 0A35E115A6 for ; Sun, 18 Dec 2005 18:31:20 +0100 (CET) From: Florent Thoumie To: freebsd-rc@freebsd.org Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-k0mVgAXXXmwpJ+v8+3BE" Date: Sun, 18 Dec 2005 18:31:20 +0100 Message-Id: <1134927080.744.14.camel@cream.xbsd.org> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port X-Virus-Scanned: amavisd-new at xbsd.org Subject: rc.d/ldconfig change X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Dec 2005 17:31:40 -0000 --=-k0mVgAXXXmwpJ+v8+3BE Content-Type: multipart/mixed; boundary="=-1GjBD8cX6QnALPryDrMH" --=-1GjBD8cX6QnALPryDrMH Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Since we have some ports that want to ldconfig directories early in the boot process (actually, early in localpkg sequence), I=20 think it would be a good idee to support=20 ${PREFIX}/etc/ld.so.conf.d/ directories (or whatever the name). Here's what I was thinking about (see attached patch). This way, I can imagine a USE_LDCONFIG variable containing=20 directories and bsd.port.mk would just : .if defined(USE_LDCONFIG) echo ${USE_LDCONFIG} > ${PREFIX}/etc/ld.so.conf.d/${UNIQUENAME} .endif [...] instead of installing 000.${UNIQUENAME}.sh in=20 ${PREFIX}/etc/rc.d. I guess it should be ok since /etc/rc.d/ldconfig is launched=20 after /etc/rc.d/mountcritremote. We can assume that local=20 directories will be available (by default local_ldconfig=3D""). Note: That's a simple patch to src/etc/rc.d/ldconfig, I'll work=20 on a more polished one (with updated configuration). --=20 Florent Thoumie flz@FreeBSD.org FreeBSD committer --=-1GjBD8cX6QnALPryDrMH Content-Disposition: attachment; filename=ldconfig.diff Content-Type: text/x-patch; name=ldconfig.diff; charset=us-ascii Content-Transfer-Encoding: base64 SW5kZXg6IHJjLmQvbGRjb25maWcNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvaG9tZS9uY3ZzL3Ny Yy9ldGMvcmMuZC9sZGNvbmZpZyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTQNCmRpZmYgLXUg LXIxLjE0IGxkY29uZmlnDQotLS0gcmMuZC9sZGNvbmZpZwkxNiBKYW4gMjAwNSAwODozNDozMCAt MDAwMAkxLjE0DQorKysgcmMuZC9sZGNvbmZpZwkxOCBEZWMgMjAwNSAxNzoxODoyOCAtMDAwMA0K QEAgLTIyLDYgKzIyLDExIEBADQogCWNoZWNreWVzbm8gbGRjb25maWdfaW5zZWN1cmUgJiYgX2lu cz0iLWkiDQogCWlmIFsgLXggIiR7bGRjb25maWdfY29tbWFuZH0iIF07IHRoZW4NCiAJCV9MREM9 Ii9saWIgL3Vzci9saWIiDQorCQlmb3IgaSBpbiAke2xvY2FsX2xkY29uZmlnfTsgZG8NCisJCQlp ZiBbIC1kICIke2l9IiBdOyB0aGVuDQorCQkJCWxkY29uZmlnX3BhdGhzPSIke2xkY29uZmlnX3Bh dGhzfSBgbHMgJHtpfWAiDQorCQkJZmkNCisJCWRvbmUNCiAJCWZvciBpIGluICR7bGRjb25maWdf cGF0aHN9IC9ldGMvbGQtZWxmLnNvLmNvbmY7IGRvDQogCQkJaWYgWyAtciAiJHtpfSIgXTsgdGhl bg0KIAkJCQlfTERDPSIke19MREN9ICR7aX0iDQo= --=-1GjBD8cX6QnALPryDrMH-- --=-k0mVgAXXXmwpJ+v8+3BE Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBDpZznMxEkbVFH3PQRAqJwAJwOjukB+LuKvBZSD8n2FKS7R47zZACeKyPH DsAhxJWhSswqItbx5RjetFE= =WbXZ -----END PGP SIGNATURE----- --=-k0mVgAXXXmwpJ+v8+3BE-- From owner-freebsd-rc@FreeBSD.ORG Mon Dec 19 11:02:56 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A322A16A427 for ; Mon, 19 Dec 2005 11:02:56 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0886D43D7D for ; Mon, 19 Dec 2005 11:02:33 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (peter@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id jBJB2U8K011336 for ; Mon, 19 Dec 2005 11:02:30 GMT (envelope-from owner-bugmaster@freebsd.org) Received: (from peter@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id jBJB2SjY011330 for freebsd-rc@freebsd.org; Mon, 19 Dec 2005 11:02:28 GMT (envelope-from owner-bugmaster@freebsd.org) Date: Mon, 19 Dec 2005 11:02:28 GMT Message-Id: <200512191102.jBJB2SjY011330@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: peter set sender to owner-bugmaster@freebsd.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to you X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2005 11:02:56 -0000 Current FreeBSD problem reports Critical problems Serious problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2005/02/10] conf/77340 rc awk used in /etc/rc.d/nsswitch when not a 1 problem total. Non-critical problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2004/06/30] conf/68525 rc Loader's verbose boot mode has rc.d/local o [2004/11/11] conf/73834 rc Bad dependencies for /etc/rc.d/savecore o [2004/11/13] conf/73909 rc [patch] rc.d/sshd does not work with port o [2005/02/18] conf/77663 rc Suggestion: add /etc/rc.d/addnetswap afte o [2005/05/14] kern/81006 rc ipnat not working with tunnel interfaces o [2005/08/27] conf/85363 rc syntax error in /etc/rc.d/devfs o [2005/11/02] conf/88383 rc [PATCH]: etc/rc.d/ldconfig:does not prope o [2005/11/14] conf/88974 rc autoconfigured vlans confuse rc.d/netif 8 problems total. From owner-freebsd-rc@FreeBSD.ORG Mon Dec 19 11:30:12 2005 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D197016A41F for ; Mon, 19 Dec 2005 11:30:12 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9CA7A43D45 for ; Mon, 19 Dec 2005 11:30:12 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id jBJBU7s7016371 for ; Mon, 19 Dec 2005 11:30:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id jBJBU7IS016370; Mon, 19 Dec 2005 11:30:07 GMT (envelope-from gnats) Date: Mon, 19 Dec 2005 11:30:07 GMT Message-Id: <200512191130.jBJBU7IS016370@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Florent Thoumie Cc: Subject: Re: conf/88383 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Florent Thoumie List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2005 11:30:12 -0000 The following reply was made to PR conf/88383; it has been noted by GNATS. From: Florent Thoumie To: bug-followup@freebsd.org Cc: Frank Laszlo Subject: Re: conf/88383 Date: Mon, 19 Dec 2005 12:24:45 +0100 --=-1a1EXwkAs1HStI9vuMwo Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I'm quite sure the current version of rc.d/ldconfig does what=20 you want. Try this and you'll see : # cat >> /root/foo.so.conf /lib /usr/lib ^D # ldconfig /var/empty # ldconfig -r # ldconfig /root/foo.so.conf # ldconfig -r Look at src/sbin/ldconfig/ldconfig.c and you'll see : if (S_ISREG(stbuf.st_mode)) rval |=3D dofile(argv[i], 0); else add_search_path(argv[i]); --=20 Florent Thoumie flz@FreeBSD.org FreeBSD committer --=-1a1EXwkAs1HStI9vuMwo Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBDpph8MxEkbVFH3PQRAj6fAJ9Tg7HZ833FhRlpB15N6UVF5ZgO9gCfThyJ unm3kW/Av8qV7PX8NKEfSIU= =0ipU -----END PGP SIGNATURE----- --=-1a1EXwkAs1HStI9vuMwo-- From owner-freebsd-rc@FreeBSD.ORG Mon Dec 19 20:33:24 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A1F916A43D for ; Mon, 19 Dec 2005 20:33:24 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A91243D5A for ; Mon, 19 Dec 2005 20:33:23 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id jBJKXMZv011776; Mon, 19 Dec 2005 12:33:22 -0800 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id jBJKXMec011775; Mon, 19 Dec 2005 12:33:22 -0800 Date: Mon, 19 Dec 2005 12:33:22 -0800 From: Brooks Davis To: Florent Thoumie Message-ID: <20051219203322.GC1103@odin.ac.hmc.edu> References: <1134927080.744.14.camel@cream.xbsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+nBD6E3TurpgldQp" Content-Disposition: inline In-Reply-To: <1134927080.744.14.camel@cream.xbsd.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-rc@freebsd.org Subject: Re: rc.d/ldconfig change X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2005 20:33:24 -0000 --+nBD6E3TurpgldQp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 18, 2005 at 06:31:20PM +0100, Florent Thoumie wrote: > Since we have some ports that want to ldconfig directories early > in the boot process (actually, early in localpkg sequence), I=20 > think it would be a good idee to support=20 > ${PREFIX}/etc/ld.so.conf.d/ directories (or whatever the name). >=20 > Here's what I was thinking about (see attached patch). >=20 > This way, I can imagine a USE_LDCONFIG variable containing=20 > directories and bsd.port.mk would just : >=20 > .if defined(USE_LDCONFIG) > echo ${USE_LDCONFIG} > ${PREFIX}/etc/ld.so.conf.d/${UNIQUENAME} > .endif >=20 > [...] instead of installing 000.${UNIQUENAME}.sh in=20 > ${PREFIX}/etc/rc.d. >=20 > I guess it should be ok since /etc/rc.d/ldconfig is launched=20 > after /etc/rc.d/mountcritremote. We can assume that local=20 > directories will be available (by default local_ldconfig=3D""). Sounds good to me. I'd been thinking we could use something like this since all those scripts are ugly. This nice thing about this is that we could use a compatibility port that just installs a 000.ldconfig-compat.sh script to shim old versions to allow the hack script to die in ports almost immediately. -- Brooks --+nBD6E3TurpgldQp Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFDpxkEXY6L6fI4GtQRArlbAKCF8GVBNJAu8/WkdlMakFa3U7nFDQCgu1sX /LvV7qlXZg93kNWaYTkih4I= =zVNV -----END PGP SIGNATURE----- --+nBD6E3TurpgldQp-- From owner-freebsd-rc@FreeBSD.ORG Mon Dec 19 21:31:17 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 53E9216A41F for ; Mon, 19 Dec 2005 21:31:17 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id D498843D70 for ; Mon, 19 Dec 2005 21:30:59 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id D76D211A92; Mon, 19 Dec 2005 22:30:57 +0100 (CET) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 15988-06; Mon, 19 Dec 2005 22:30:51 +0100 (CET) Received: from cream.xbsd.org (cream.xbsd.org [192.168.42.6]) by smtp.xbsd.org (Postfix) with ESMTP id C5227115A6; Mon, 19 Dec 2005 22:30:50 +0100 (CET) From: Florent Thoumie To: Brooks Davis In-Reply-To: <20051219203322.GC1103@odin.ac.hmc.edu> References: <1134927080.744.14.camel@cream.xbsd.org> <20051219203322.GC1103@odin.ac.hmc.edu> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-A1CWHiAkZ/L/xtjLWx3o" Date: Mon, 19 Dec 2005 22:30:49 +0100 Message-Id: <1135027849.744.28.camel@cream.xbsd.org> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port X-Virus-Scanned: amavisd-new at xbsd.org Cc: freebsd-rc@freebsd.org Subject: Re: rc.d/ldconfig change X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2005 21:31:17 -0000 --=-A1CWHiAkZ/L/xtjLWx3o Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon, 2005-12-19 at 12:33 -0800, Brooks Davis wrote: > On Sun, Dec 18, 2005 at 06:31:20PM +0100, Florent Thoumie wrote: > > Since we have some ports that want to ldconfig directories early > > in the boot process (actually, early in localpkg sequence), I=20 > > think it would be a good idee to support=20 > > ${PREFIX}/etc/ld.so.conf.d/ directories (or whatever the name). > >=20 > > Here's what I was thinking about (see attached patch). > >=20 > > This way, I can imagine a USE_LDCONFIG variable containing=20 > > directories and bsd.port.mk would just : > >=20 > > .if defined(USE_LDCONFIG) > > echo ${USE_LDCONFIG} > ${PREFIX}/etc/ld.so.conf.d/${UNIQUENAME} > > .endif > >=20 > > [...] instead of installing 000.${UNIQUENAME}.sh in=20 > > ${PREFIX}/etc/rc.d. > >=20 > > I guess it should be ok since /etc/rc.d/ldconfig is launched=20 > > after /etc/rc.d/mountcritremote. We can assume that local=20 > > directories will be available (by default local_ldconfig=3D""). >=20 > Sounds good to me. I'd been thinking we could use something like > this since all those scripts are ugly. This nice thing about this > is that we could use a compatibility port that just installs a > 000.ldconfig-compat.sh script to shim old versions to allow the hack > script to die in ports almost immediately. Yes, that's the idea. --=20 Florent Thoumie flz@FreeBSD.org FreeBSD committer --=-A1CWHiAkZ/L/xtjLWx3o Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBDpyaJMxEkbVFH3PQRAswiAJ4sApTCZTh4cB68NXEH8WqCReLQLwCfd0zZ /f2OpuocCVzP5AqDfhhQfzw= =ua/+ -----END PGP SIGNATURE----- --=-A1CWHiAkZ/L/xtjLWx3o-- From owner-freebsd-rc@FreeBSD.ORG Tue Dec 20 00:22:09 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 90A1B16A41F for ; Tue, 20 Dec 2005 00:22:09 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id A63B043D45 for ; Tue, 20 Dec 2005 00:22:05 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id A5E6F11B7A; Tue, 20 Dec 2005 01:22:04 +0100 (CET) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 17827-04; Tue, 20 Dec 2005 01:21:55 +0100 (CET) Received: from cream.xbsd.org (cream.xbsd.org [192.168.42.6]) by smtp.xbsd.org (Postfix) with ESMTP id C24B71171F; Tue, 20 Dec 2005 01:21:54 +0100 (CET) From: Florent Thoumie To: Brooks Davis In-Reply-To: <20051219203322.GC1103@odin.ac.hmc.edu> References: <1134927080.744.14.camel@cream.xbsd.org> <20051219203322.GC1103@odin.ac.hmc.edu> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-gHg4RMnzCEg3tNumaH3R" Date: Tue, 20 Dec 2005 01:21:53 +0100 Message-Id: <1135038113.744.51.camel@cream.xbsd.org> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port X-Virus-Scanned: amavisd-new at xbsd.org Cc: freebsd-rc@freebsd.org Subject: Re: rc.d/ldconfig change X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2005 00:22:09 -0000 --=-gHg4RMnzCEg3tNumaH3R Content-Type: multipart/mixed; boundary="=-hHJru6bcd39vPbNwC1pO" --=-hHJru6bcd39vPbNwC1pO Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon, 2005-12-19 at 12:33 -0800, Brooks Davis wrote: > On Sun, Dec 18, 2005 at 06:31:20PM +0100, Florent Thoumie wrote: > > Since we have some ports that want to ldconfig directories early > > in the boot process (actually, early in localpkg sequence), I=20 > > think it would be a good idee to support=20 > > ${PREFIX}/etc/ld.so.conf.d/ directories (or whatever the name). > >=20 > > Here's what I was thinking about (see attached patch). > >=20 > > This way, I can imagine a USE_LDCONFIG variable containing=20 > > directories and bsd.port.mk would just : > >=20 > > .if defined(USE_LDCONFIG) > > echo ${USE_LDCONFIG} > ${PREFIX}/etc/ld.so.conf.d/${UNIQUENAME} > > .endif > >=20 > > [...] instead of installing 000.${UNIQUENAME}.sh in=20 > > ${PREFIX}/etc/rc.d. > >=20 > > I guess it should be ok since /etc/rc.d/ldconfig is launched=20 > > after /etc/rc.d/mountcritremote. We can assume that local=20 > > directories will be available (by default local_ldconfig=3D""). >=20 > Sounds good to me. I'd been thinking we could use something like > this since all those scripts are ugly. This nice thing about this > is that we could use a compatibility port that just installs a > 000.ldconfig-compat.sh script to shim old versions to allow the hack > script to die in ports almost immediately. Here's the (almost) complete patch. I'll take care of the ports=20 part once we get this in the tree. I finally set local_ldconfig to "/usr/local/etc/ld.so.conf.d /usr/X11R6/etc/ld.so.conf.d" because we already have=20 local_startup and local_periodic (in etc/defaults/periodic.conf) using such directories (and that's one thing less the user has=20 to do). I've added an entry in the local mtree file and bumped=20 __FreeBSD_version. Someone could argue the directory's name (ld.so.conf.d), I=20 really don't care, I figured it was simple enough so that anyone would know what it is for. --=20 Florent Thoumie flz@FreeBSD.org FreeBSD committer --=-hHJru6bcd39vPbNwC1pO Content-Disposition: attachment; filename=ldconfig.diff Content-Type: text/x-patch; name=ldconfig.diff; charset=us-ascii Content-Transfer-Encoding: base64 SW5kZXg6IGV0Yy9kZWZhdWx0cy9yYy5jb25mDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2hvbWUv bmN2cy9zcmMvZXRjL2RlZmF1bHRzL3JjLmNvbmYsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjI2 Nw0KZGlmZiAtdSAtcjEuMjY3IHJjLmNvbmYNCi0tLSBldGMvZGVmYXVsdHMvcmMuY29uZgkxNSBE ZWMgMjAwNSAwMTowNDo0OCAtMDAwMAkxLjI2Nw0KKysrIGV0Yy9kZWZhdWx0cy9yYy5jb25mCTIw IERlYyAyMDA1IDAwOjE4OjIxIC0wMDAwDQpAQCAtNDkzLDYgKzQ5Myw4IEBADQogCQkJIyBzaGFy ZWQgbGlicmFyeSBzZWFyY2ggcGF0aHMNCiBsZGNvbmZpZ19wYXRoc19hb3V0PSIvdXNyL2xpYi9j b21wYXQvYW91dCAvdXNyL1gxMVI2L2xpYi9hb3V0IC91c3IvbG9jYWwvbGliL2FvdXQiDQogCQkJ IyBhLm91dCBzaGFyZWQgbGlicmFyeSBzZWFyY2ggcGF0aHMNCitsb2NhbF9sZGNvbmZpZz0iL3Vz ci9sb2NhbC9ldGMvbGQuc28uY29uZi5kIC91c3IvWDExUjYvZXRjL2xkLnNvLmNvbmYuZCINCisJ CQkjIExvY2FsIGRpcmVjdG9yaWVzIHdpdGggbGRjb25maWcgY29uZmlndXJhdGlvbiBmaWxlcy4N CiBrZXJuX3NlY3VyZWxldmVsX2VuYWJsZT0iTk8iCSMga2VybmVsIHNlY3VyaXR5IGxldmVsIChz ZWUgaW5pdCg4KSksDQoga2Vybl9zZWN1cmVsZXZlbD0iLTEiCSMgcmFuZ2U6IC0xLi4zIDsgYC0x JyBpcyB0aGUgbW9zdCBpbnNlY3VyZQ0KIAkJCSMgTm90ZSB0aGF0IHNldHRpbmcgc2VjdXJlbGV2 ZWwgdG8gMCB3aWxsIHJlc3VsdA0KSW5kZXg6IGV0Yy9yYy5kL2xkY29uZmlnDQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 DQpSQ1MgZmlsZTogL2hvbWUvbmN2cy9zcmMvZXRjL3JjLmQvbGRjb25maWcsdg0KcmV0cmlldmlu ZyByZXZpc2lvbiAxLjE0DQpkaWZmIC11IC1yMS4xNCBsZGNvbmZpZw0KLS0tIGV0Yy9yYy5kL2xk Y29uZmlnCTE2IEphbiAyMDA1IDA4OjM0OjMwIC0wMDAwCTEuMTQNCisrKyBldGMvcmMuZC9sZGNv bmZpZwkyMCBEZWMgMjAwNSAwMDoxODoyMSAtMDAwMA0KQEAgLTIyLDYgKzIyLDExIEBADQogCWNo ZWNreWVzbm8gbGRjb25maWdfaW5zZWN1cmUgJiYgX2lucz0iLWkiDQogCWlmIFsgLXggIiR7bGRj b25maWdfY29tbWFuZH0iIF07IHRoZW4NCiAJCV9MREM9Ii9saWIgL3Vzci9saWIiDQorCQlmb3Ig aSBpbiAke2xvY2FsX2xkY29uZmlnfTsgZG8NCisJCQlpZiBbIC1kICIke2l9IiBdOyB0aGVuDQor CQkJCWxkY29uZmlnX3BhdGhzPSIke2xkY29uZmlnX3BhdGhzfSBgbHMgJHtpfWAiDQorCQkJZmkN CisJCWRvbmUNCiAJCWZvciBpIGluICR7bGRjb25maWdfcGF0aHN9IC9ldGMvbGQtZWxmLnNvLmNv bmY7IGRvDQogCQkJaWYgWyAtciAiJHtpfSIgXTsgdGhlbg0KIAkJCQlfTERDPSIke19MREN9ICR7 aX0iDQpJbmRleDogc2hhcmUvbWFuL21hbjUvcmMuY29uZi41DQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmls ZTogL2hvbWUvbmN2cy9zcmMvc2hhcmUvbWFuL21hbjUvcmMuY29uZi41LHYNCnJldHJpZXZpbmcg cmV2aXNpb24gMS4yNzQNCmRpZmYgLXUgLXIxLjI3NCByYy5jb25mLjUNCi0tLSBzaGFyZS9tYW4v bWFuNS9yYy5jb25mLjUJMTkgRGVjIDIwMDUgMTA6NTc6MDAgLTAwMDAJMS4yNzQNCisrKyBzaGFy ZS9tYW4vbWFuNS9yYy5jb25mLjUJMjAgRGVjIDIwMDUgMDA6MTg6MjIgLTAwMDANCkBAIC0yODIy LDYgKzI4MjIsMTMgQEANCiBTZXQgdGhpcyB2YXJpYWJsZSB0bw0KIC5EcSBMaSBZRVMNCiB0byBk aXNhYmxlIHRoYXQgc2VjdXJpdHkgY2hlY2sgZHVyaW5nIHN5c3RlbSBzdGFydHVwLg0KKy5JdCBW YSBsb2NhbF9sZGNvbmZpZw0KKy5QcSBWdCBzdHINCitTZXQgdG8gdGhlIGxpc3Qgb2YgbG9jYWwN CisuWHIgbGRjb25maWcgOA0KK2RpcmVjdG9yaWVzLg0KK0VhY2ggZmlsZSBpbiB0aG9zZSBkaXJl Y3RvcmllcyB3aWxsIGJlIHBhc3NlZCBhcyBhcmd1bWVudHMgdG8NCisuWHIgbGRjb25maWcgOCAu DQogLkl0IFZhIGtlcm5fc2VjdXJlbGV2ZWxfZW5hYmxlDQogLlBxIFZ0IGJvb2wNCiBTZXQgdG8N CkluZGV4OiBzeXMvc3lzL3BhcmFtLmgNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvaG9tZS9uY3Zz L3NyYy9zeXMvc3lzL3BhcmFtLmgsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjI1Nw0KZGlmZiAt dSAtcjEuMjU3IHBhcmFtLmgNCi0tLSBzeXMvc3lzL3BhcmFtLmgJMTkgRGVjIDIwMDUgMDA6MTM6 MTEgLTAwMDAJMS4yNTcNCisrKyBzeXMvc3lzL3BhcmFtLmgJMjAgRGVjIDIwMDUgMDA6MTg6MjIg LTAwMDANCkBAIC01Nyw3ICs1Nyw3IEBADQogICoJCWlzIGNyZWF0ZWQsIG90aGVyd2lzZSAxLg0K ICAqLw0KICN1bmRlZiBfX0ZyZWVCU0RfdmVyc2lvbg0KLSNkZWZpbmUgX19GcmVlQlNEX3ZlcnNp b24gNzAwMDA5CS8qIE1hc3RlciwgcHJvcGFnYXRlZCB0byBuZXd2ZXJzICovDQorI2RlZmluZSBf X0ZyZWVCU0RfdmVyc2lvbiA3MDAwMTAJLyogTWFzdGVyLCBwcm9wYWdhdGVkIHRvIG5ld3ZlcnMg Ki8NCiANCiAjaWZuZGVmIExPQ09SRQ0KICNpbmNsdWRlIDxzeXMvdHlwZXMuaD4NCkluZGV4OiBl dGMvbXRyZWUvQlNELmxvY2FsLmRpc3QNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvaG9tZS9uY3Zz L3NyYy9ldGMvbXRyZWUvQlNELmxvY2FsLmRpc3Qsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjEx Nw0KZGlmZiAtdSAtcjEuMTE3IEJTRC5sb2NhbC5kaXN0DQotLS0gZXRjL210cmVlL0JTRC5sb2Nh bC5kaXN0CTEwIEp1biAyMDA1IDIwOjE0OjM4IC0wMDAwCTEuMTE3DQorKysgZXRjL210cmVlL0JT RC5sb2NhbC5kaXN0CTIwIERlYyAyMDA1IDAwOjE4OjIyIC0wMDAwDQpAQCAtOCw2ICs4LDggQEAN CiAgICAgYmluDQogICAgIC4uDQogICAgIGV0Yw0KKyAgICAgICAgbGQuc28uY29uZi5kDQorICAg ICAgICAuLg0KICAgICAgICAgcGFtLmQNCiAgICAgICAgIC4uDQogICAgICAgICByYy5kDQo= --=-hHJru6bcd39vPbNwC1pO-- --=-gHg4RMnzCEg3tNumaH3R Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBDp06hMxEkbVFH3PQRAkZSAJ40J7k2kIYp9bXdpVTQ5VgN+mXVHACgje4O aykmp2ESaevyyLl5+qW0rRk= =tY+o -----END PGP SIGNATURE----- --=-gHg4RMnzCEg3tNumaH3R-- From owner-freebsd-rc@FreeBSD.ORG Tue Dec 20 17:26:25 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B4B8916A420 for ; Tue, 20 Dec 2005 17:26:25 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id A356F43D58 for ; Tue, 20 Dec 2005 17:26:12 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id jBKHPx5i088424; Tue, 20 Dec 2005 20:25:59 +0300 (MSK) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id jBKHPrbM088419; Tue, 20 Dec 2005 20:25:53 +0300 (MSK) (envelope-from yar) Date: Tue, 20 Dec 2005 20:25:53 +0300 From: Yar Tikhiy To: Florent Thoumie Message-ID: <20051220172552.GB78478@comp.chem.msu.su> References: <1134927080.744.14.camel@cream.xbsd.org> <20051219203322.GC1103@odin.ac.hmc.edu> <1135038113.744.51.camel@cream.xbsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1135038113.744.51.camel@cream.xbsd.org> User-Agent: Mutt/1.5.9i Cc: freebsd-rc@freebsd.org Subject: Re: rc.d/ldconfig change X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2005 17:26:25 -0000 On Tue, Dec 20, 2005 at 01:21:53AM +0100, Florent Thoumie wrote: > Index: share/man/man5/rc.conf.5 > =================================================================== > RCS file: /home/ncvs/src/share/man/man5/rc.conf.5,v > retrieving revision 1.274 > diff -u -r1.274 rc.conf.5 > --- share/man/man5/rc.conf.5 19 Dec 2005 10:57:00 -0000 1.274 > +++ share/man/man5/rc.conf.5 20 Dec 2005 00:18:22 -0000 > @@ -2822,6 +2822,13 @@ > Set this variable to > .Dq Li YES > to disable that security check during system startup. > +.It Va local_ldconfig > +.Pq Vt str > +Set to the list of local > +.Xr ldconfig 8 > +directories. > +Each file in those directories will be passed as arguments to > +.Xr ldconfig 8 . What do you think about the following, slightly different wording? The names of all files in the directories listed will be passed as arguments to .Xr ldconfig 8 . This should fix the singular vs. plural usage and also tell the sweet truth that there will be a single run of ldconfig(8) irrespective of the number of the files. -- Yar From owner-freebsd-rc@FreeBSD.ORG Tue Dec 20 17:31:20 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 886B716A41F for ; Tue, 20 Dec 2005 17:31:20 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id BE92243D81 for ; Tue, 20 Dec 2005 17:31:11 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 1F3BE1165E; Tue, 20 Dec 2005 18:31:07 +0100 (CET) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 32654-05; Tue, 20 Dec 2005 18:30:58 +0100 (CET) Received: from cream.xbsd.org (cream.xbsd.org [192.168.42.6]) by smtp.xbsd.org (Postfix) with ESMTP id AAAC9115A6; Tue, 20 Dec 2005 18:30:57 +0100 (CET) From: Florent Thoumie To: Yar Tikhiy In-Reply-To: <20051220172552.GB78478@comp.chem.msu.su> References: <1134927080.744.14.camel@cream.xbsd.org> <20051219203322.GC1103@odin.ac.hmc.edu> <1135038113.744.51.camel@cream.xbsd.org> <20051220172552.GB78478@comp.chem.msu.su> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-EtF88UNi7jIUcJTe7oEe" Date: Tue, 20 Dec 2005 18:30:56 +0100 Message-Id: <1135099856.744.62.camel@cream.xbsd.org> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port X-Virus-Scanned: amavisd-new at xbsd.org Cc: freebsd-rc@freebsd.org Subject: Re: rc.d/ldconfig change X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2005 17:31:20 -0000 --=-EtF88UNi7jIUcJTe7oEe Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2005-12-20 at 20:25 +0300, Yar Tikhiy wrote: > On Tue, Dec 20, 2005 at 01:21:53AM +0100, Florent Thoumie wrote: > > Index: share/man/man5/rc.conf.5 > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > RCS file: /home/ncvs/src/share/man/man5/rc.conf.5,v > > retrieving revision 1.274 > > diff -u -r1.274 rc.conf.5 > > --- share/man/man5/rc.conf.5 19 Dec 2005 10:57:00 -0000 1.274 > > +++ share/man/man5/rc.conf.5 20 Dec 2005 00:18:22 -0000 > > @@ -2822,6 +2822,13 @@ > > Set this variable to > > .Dq Li YES > > to disable that security check during system startup. > > +.It Va local_ldconfig > > +.Pq Vt str > > +Set to the list of local > > +.Xr ldconfig 8 > > +directories. > > +Each file in those directories will be passed as arguments to > > +.Xr ldconfig 8 . >=20 > What do you think about the following, slightly different wording? >=20 > The names of all files in the directories listed > will be passed as arguments to > .Xr ldconfig 8 . >=20 > This should fix the singular vs. plural usage and also tell the > sweet truth that there will be a single run of ldconfig(8) irrespective > of the number of the files. Sounds ok to me. Anything else ? --=20 Florent Thoumie flz@FreeBSD.org FreeBSD committer --=-EtF88UNi7jIUcJTe7oEe Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBDqD/QMxEkbVFH3PQRAvjTAJ9L6VQt42hzZNrX1lkcVtTxBfrnCQCcDFeM zMsoU6SGgqJ8oXv+UjmS6io= =Eh82 -----END PGP SIGNATURE----- --=-EtF88UNi7jIUcJTe7oEe-- From owner-freebsd-rc@FreeBSD.ORG Fri Dec 23 06:09:25 2005 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5859716A41F for ; Fri, 23 Dec 2005 06:09:25 +0000 (GMT) (envelope-from darren.pilgrim@bitfreak.org) Received: from mail.bitfreak.org (mail.bitfreak.org [65.75.198.146]) by mx1.FreeBSD.org (Postfix) with ESMTP id D1C4843D55 for ; Fri, 23 Dec 2005 06:09:24 +0000 (GMT) (envelope-from darren.pilgrim@bitfreak.org) Received: from smiley (mail.bitfreak.org [65.75.198.146]) by mail.bitfreak.org (Postfix) with ESMTP id D94B019F3F for ; Thu, 22 Dec 2005 22:09:23 -0800 (PST) From: "Darren Pilgrim" To: Date: Thu, 22 Dec 2005 22:09:15 -0800 Message-ID: <000d01c60787$6a431b40$652a15ac@smiley> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_000E_01C60744.5C1FDB40" X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook, Build 10.0.6626 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2180 Importance: Normal Subject: /etc/rc.d/devfs modification to allow wildcard device names in /etc/devfs.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2005 06:09:25 -0000 This is a multi-part message in MIME format. ------=_NextPart_000_000E_01C60744.5C1FDB40 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I recently needed to change the default permissions of some of the "dial out" serial devices on a system for use with NUT (sysutils/nut port). = For the sake of efficiency, I wanted to use a wildcard expression only to = find out that /etc/rc.d/devfs doesn't grok sh-style filename globbing. So I modified the script. I wrapped each sub-procedure in the case structure with a for...done that expands the device string into a list for = iteration. The result is that I can put lines like the following in = /etc/devfs.conf: own cuad[1,2]* nut:nut perm cuad[1,2]* 0660 The non-wildcard equivalent would be: own cuad1 nut:nut own cuad1.init nut:nut own cuad1.lock nut:nut own cuad2 nut:nut own cuad2.init nut:nut own cuad2.lock nut:nut perm cuad1 0660 perm cuad1.init 0660 perm cuad1.lock 0660 perm cuad2 0660 perm cuad2.init 0660 perm cuad2.lock 0660 I wrote two versions of the modification, one takes the device = expression literally (the _literal.patch file), the other explicitly expands it = with ls (the _backticked_ls.patch file). Both appear to work fine, but IMO the latter seems a safer approach. The modifications and testing were done = on a current RELENG_6_0 box where /etc/rc.d/devfs is v1.10. The v1.11 in = -HEAD is effectively identical, so it should apply cleanly to that version as well. ------=_NextPart_000_000E_01C60744.5C1FDB40 Content-Type: application/octet-stream; name="etc_rc.d_devfs_literal.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="etc_rc.d_devfs_literal.patch" --- /usr/src/etc/rc.d/devfs Fri Oct 22 23:50:50 2004=0A= +++ /etc/rc.d/devfs Wed Dec 21 01:16:24 2005=0A= @@ -41,19 +41,25 @@=0A= {=0A= if [ -r /etc/devfs.conf ]; then=0A= cd /dev=0A= - while read action device parameter; do=0A= + while read action devicelist parameter; do=0A= case "${action}" in=0A= - l*) if [ -c ${device} -a ! -e ${parameter} ]; then=0A= - ln -fs ${device} ${parameter}=0A= - fi=0A= + l*) for device in ${devicelist}; do=0A= + if [ -c ${device} -a ! -e ${parameter} ]; then=0A= + ln -fs ${device} ${parameter}=0A= + fi=0A= + done=0A= ;;=0A= - o*) if [ -c ${device} ]; then=0A= - chown ${parameter} ${device}=0A= - fi=0A= + o*) for device in ${devicelist}; do=0A= + if [ -c ${device} ]; then=0A= + chown ${parameter} ${device}=0A= + fi=0A= + done=0A= ;;=0A= - p*) if [ -c ${device} ]; then=0A= - chmod ${parameter} ${device}=0A= - fi=0A= + p*) for device in ${devicelist}; do=0A= + if [ -c ${device} ]; then=0A= + chmod ${parameter} ${device}=0A= + fi=0A= + done=0A= ;;=0A= esac=0A= done < /etc/devfs.conf=0A= ------=_NextPart_000_000E_01C60744.5C1FDB40 Content-Type: application/octet-stream; name="etc_rc.d_devfs_backticked_ls.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="etc_rc.d_devfs_backticked_ls.patch" --- /usr/src/etc/rc.d/devfs Fri Oct 22 23:50:50 2004=0A= +++ /etc/rc.d/devfs Thu Dec 22 21:33:50 2005=0A= @@ -41,19 +41,25 @@=0A= {=0A= if [ -r /etc/devfs.conf ]; then=0A= cd /dev=0A= - while read action device parameter; do=0A= + while read action devicelist parameter; do=0A= case "${action}" in=0A= - l*) if [ -c ${device} -a ! -e ${parameter} ]; then=0A= - ln -fs ${device} ${parameter}=0A= - fi=0A= + l*) for device in `ls ${devicelist}`; do=0A= + if [ -c ${device} -a ! -e ${parameter} ]; then=0A= + ln -fs ${device} ${parameter}=0A= + fi=0A= + done=0A= ;;=0A= - o*) if [ -c ${device} ]; then=0A= - chown ${parameter} ${device}=0A= - fi=0A= + o*) for device in `ls ${devicelist}`; do=0A= + if [ -c ${device} ]; then=0A= + chown ${parameter} ${device}=0A= + fi=0A= + done=0A= ;;=0A= - p*) if [ -c ${device} ]; then=0A= - chmod ${parameter} ${device}=0A= - fi=0A= + p*) for device in `ls ${devicelist}`; do=0A= + if [ -c ${device} ]; then=0A= + chmod ${parameter} ${device}=0A= + fi=0A= + done=0A= ;;=0A= esac=0A= done < /etc/devfs.conf=0A= ------=_NextPart_000_000E_01C60744.5C1FDB40-- From owner-freebsd-rc@FreeBSD.ORG Sat Dec 24 23:20:06 2005 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5240D16A41F for ; Sat, 24 Dec 2005 23:20:06 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B570843D53 for ; Sat, 24 Dec 2005 23:20:05 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id jBONK5nZ087251 for ; Sat, 24 Dec 2005 23:20:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id jBONK5W2087250; Sat, 24 Dec 2005 23:20:05 GMT (envelope-from gnats) Date: Sat, 24 Dec 2005 23:20:05 GMT Message-Id: <200512242320.jBONK5W2087250@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Peter Much Cc: Subject: Re: conf/85363: syntax error in /etc/rc.d/devfs X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Peter Much List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2005 23:20:06 -0000 The following reply was made to PR conf/85363; it has been noted by GNATS. From: Peter Much To: bug-followup@FreeBSD.org Cc: Subject: Re: conf/85363: syntax error in /etc/rc.d/devfs Date: Sat, 24 Dec 2005 23:58:10 +0100 Now I found time to analyze this thoroughly. I found that I have made a mistake. It just does not work to name a ruleset by its NUMBER in rc.conf, instead one must always name it by its NAME. (And, btw, that name must not begin with a number!) Now, ideally, if one mentions the number instead of the name in rc.conf, the code should behave as if a nonexistent ruleset was mentioned - i.e. do nothing or raise an error. Practically it does behave undefined, that is, wrong rulesets will silently be applied. But, overall, this is one of the implicit weaknesses of shell scripting, when strings that are to be freely defined by the installer are used as variable names. And as the thing is designed as it is, there is no easy solution to make it better. An improvement will be the usage of {} delimiters. A construct like "eval rs=\$$1" will behave less undefined if it is written as "eval rs=\${$1}". There is a couple of places in rc.subr where this would be argueable. PMc