From owner-freebsd-rc@FreeBSD.ORG Sun Mar 19 02:43:00 2006 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F041016A41F for ; Sun, 19 Mar 2006 02:43:00 +0000 (UTC) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7ACC443D45 for ; Sun, 19 Mar 2006 02:43:00 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 3576B115BC for ; Sun, 19 Mar 2006 03:42:56 +0100 (CET) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 84394-09 for ; Sun, 19 Mar 2006 03:42:50 +0100 (CET) Received: from [192.168.1.102] (unknown [83.141.123.158]) by smtp.xbsd.org (Postfix) with ESMTP id EC2A511424 for ; Sun, 19 Mar 2006 03:42:48 +0100 (CET) Mime-Version: 1.0 (Apple Message framework v746.3) In-Reply-To: <200603141130.k2EBUJkv055830@freefall.freebsd.org> References: <200603141130.k2EBUJkv055830@freefall.freebsd.org> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Florent Thoumie Date: Sun, 19 Mar 2006 02:42:44 +0000 To: freebsd-rc@FreeBSD.org X-Mailer: Apple Mail (2.746.3) X-Virus-Scanned: amavisd-new at xbsd.org Cc: Subject: Re: conf/77340 - awk used in /etc/rc.d/nsswitch when not available X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Mar 2006 02:43:01 -0000 On Mar 14, 2006, at 10:30 AM, Florent Thoumie wrote: > The following reply was made to PR conf/77340; it has been noted by > GNATS. > > From: Florent Thoumie > To: Brooks Davis > Cc: bug-followup@FreeBSD.org > Subject: Re: conf/77340 - awk used in /etc/rc.d/nsswitch when not > available > Date: Tue, 14 Mar 2006 11:29:33 +0000 > > On Mon, 2006-03-13 at 19:40 +0000, Brooks Davis > >> I haven't tested it, but it looks fine to me. > > I did test a few things: > - with no /etc/host.conf and no /etc/nsswitch.conf > - with default /etc/host.conf > - with default /etc/nsswitch.conf > - with /etc/nsswitch.conf looking like : > > ,------ > | hosts: files [foo=test bar=test baz=test] \ > | dns > `------ > > Does "fine with me" means "go ahead" ? > > I guess a MFC after 1 week is ok. Any volunteer to commit/approve this patch? -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer From owner-freebsd-rc@FreeBSD.ORG Mon Mar 20 11:03:03 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0122E16A420 for ; Mon, 20 Mar 2006 11:03:03 +0000 (UTC) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA5AB43D45 for ; Mon, 20 Mar 2006 11:03:02 +0000 (GMT) (envelope-from owner-bugmaster@freebsd.org) Received: from freefall.freebsd.org (peter@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2KB32OZ082634 for ; Mon, 20 Mar 2006 11:03:02 GMT (envelope-from owner-bugmaster@freebsd.org) Received: (from peter@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k2KB300m082628 for freebsd-rc@freebsd.org; Mon, 20 Mar 2006 11:03:00 GMT (envelope-from owner-bugmaster@freebsd.org) Date: Mon, 20 Mar 2006 11:03:00 GMT Message-Id: <200603201103.k2KB300m082628@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: peter set sender to owner-bugmaster@freebsd.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to you X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Mar 2006 11:03:03 -0000 Current FreeBSD problem reports Critical problems Serious problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2005/02/10] conf/77340 rc awk used in /etc/rc.d/nsswitch when not a o [2006/02/13] conf/93287 rc [patch] Make rc.subr jail-aware o [2006/03/12] conf/94377 rc [patch] /etc/rc.d/sshd improperly tests r 3 problems total. Non-critical problems S Submitted Tracker Resp. Description ------------------------------------------------------------------------------- o [2002/11/12] conf/45226 rc Fix for rc.network, ppp-user annoyance o [2004/11/13] conf/73909 rc [patch] rc.d/sshd does not work with port o [2005/02/18] conf/77663 rc Suggestion: add /etc/rc.d/addnetswap afte o [2005/03/16] conf/78906 rc [patch] Allow mixer_enable="NO" in rc.con o [2005/05/14] kern/81006 rc ipnat not working with tunnel interfaces o [2005/06/28] conf/82738 rc [patch] add amd_program line to defaults/ o [2005/08/27] conf/85363 rc syntax error in /etc/rc.d/devfs o [2005/11/13] conf/88913 rc [patch] wrapper support for rc.subr o [2005/11/14] conf/88974 rc autoconfigured vlans confuse rc.d/netif o [2005/12/03] conf/89870 rc [patch] feature request to make netif ver o [2006/01/30] conf/92523 rc [patch] allow rc scripts to kill process o [2006/02/25] conf/93815 rc [patch] Adds in the ability to save ipfw 12 problems total. From owner-freebsd-rc@FreeBSD.ORG Mon Mar 20 17:41:38 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BBC9816A400 for ; Mon, 20 Mar 2006 17:41:38 +0000 (UTC) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 67F4943D45 for ; Mon, 20 Mar 2006 17:41:38 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id k2KHfbAm031435; Mon, 20 Mar 2006 09:41:37 -0800 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id k2KHfbw5031434; Mon, 20 Mar 2006 09:41:37 -0800 Date: Mon, 20 Mar 2006 09:41:37 -0800 From: Brooks Davis To: Florent Thoumie Message-ID: <20060320174137.GB18306@odin.ac.hmc.edu> References: <200603141130.k2EBUJkv055830@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="aVD9QWMuhilNxW9f" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-rc@freebsd.org Subject: Re: conf/77340 - awk used in /etc/rc.d/nsswitch when not available X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Mar 2006 17:41:38 -0000 --aVD9QWMuhilNxW9f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 19, 2006 at 02:42:44AM +0000, Florent Thoumie wrote: >=20 > On Mar 14, 2006, at 10:30 AM, Florent Thoumie wrote: >=20 > >The following reply was made to PR conf/77340; it has been noted by =20 > >GNATS. > > > >From: Florent Thoumie > >To: Brooks Davis > >Cc: bug-followup@FreeBSD.org > >Subject: Re: conf/77340 - awk used in /etc/rc.d/nsswitch when not =20 > >available > >Date: Tue, 14 Mar 2006 11:29:33 +0000 > > > > On Mon, 2006-03-13 at 19:40 +0000, Brooks Davis > > > >> I haven't tested it, but it looks fine to me. > > > > I did test a few things: > > - with no /etc/host.conf and no /etc/nsswitch.conf > > - with default /etc/host.conf > > - with default /etc/nsswitch.conf > > - with /etc/nsswitch.conf looking like : > > > > ,------ > > | hosts: files [foo=3Dtest bar=3Dtest baz=3Dtest] \ > > | dns > > `------ > > > > Does "fine with me" means "go ahead" ? > > > > I guess a MFC after 1 week is ok. >=20 > Any volunteer to commit/approve this patch? Please commit. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --aVD9QWMuhilNxW9f Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFEHulQXY6L6fI4GtQRApBwAJ4tyfU8AZwE0XvjrWaiSHnzAUygrQCdEFM8 eTLn6DJfhxZg4izmH1wvsdU= =+pd/ -----END PGP SIGNATURE----- --aVD9QWMuhilNxW9f-- From owner-freebsd-rc@FreeBSD.ORG Mon Mar 20 18:01:57 2006 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0567616A4A7; Mon, 20 Mar 2006 18:01:57 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B598743D4C; Mon, 20 Mar 2006 18:01:56 +0000 (GMT) (envelope-from flz@FreeBSD.org) Received: from freefall.freebsd.org (flz@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2KI1uvq015151; Mon, 20 Mar 2006 18:01:56 GMT (envelope-from flz@freefall.freebsd.org) Received: (from flz@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k2KI1tBS015146; Mon, 20 Mar 2006 18:01:55 GMT (envelope-from flz) Date: Mon, 20 Mar 2006 18:01:55 GMT From: Florent Thoumie Message-Id: <200603201801.k2KI1tBS015146@freefall.freebsd.org> To: RZ-FreeBSD1004@fh-karlsruhe.de, flz@FreeBSD.org, freebsd-rc@FreeBSD.org, flz@FreeBSD.org Cc: Subject: Re: conf/77340: awk used in /etc/rc.d/nsswitch when not availiable (diskless boot) X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Mar 2006 18:01:57 -0000 Synopsis: awk used in /etc/rc.d/nsswitch when not availiable (diskless boot) State-Changed-From-To: open->patched State-Changed-By: flz State-Changed-When: Mon Mar 20 18:01:03 UTC 2006 State-Changed-Why: I've committed a fix to HEAD. Will MFC to RELENG_[56] in two weeks. Responsible-Changed-From-To: freebsd-rc->flz Responsible-Changed-By: flz Responsible-Changed-When: Mon Mar 20 18:01:03 UTC 2006 Responsible-Changed-Why: Grab. http://www.freebsd.org/cgi/query-pr.cgi?pr=77340 From owner-freebsd-rc@FreeBSD.ORG Mon Mar 20 21:00:33 2006 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3B26916A425 for ; Mon, 20 Mar 2006 21:00:33 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA25543D46 for ; Mon, 20 Mar 2006 21:00:32 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2KL0Wdw027056 for ; Mon, 20 Mar 2006 21:00:32 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k2KL0Wwm027055; Mon, 20 Mar 2006 21:00:32 GMT (envelope-from gnats) Date: Mon, 20 Mar 2006 21:00:32 GMT Message-Id: <200603202100.k2KL0Wwm027055@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Florent Thoumie Cc: Subject: Re: conf/73909 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Florent Thoumie List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Mar 2006 21:00:33 -0000 The following reply was made to PR conf/73909; it has been noted by GNATS. From: Florent Thoumie To: bug-followup@FreeBSD.org Cc: dougb@FreeBSD.org, brooks@FreeBSD.org Subject: Re: conf/73909 Date: Mon, 20 Mar 2006 20:52:24 +0100 Sounds correct to me, and that way we could remove sshd.sh installed from security/openssh*. dougb/brooks cc'ed since they're my usual candidates when seeking approval :) Florent From owner-freebsd-rc@FreeBSD.ORG Tue Mar 21 01:07:43 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D70D16A424 for ; Tue, 21 Mar 2006 01:07:43 +0000 (UTC) (envelope-from jofsama@yahoo.com) Received: from smtp001.mail.ukl.yahoo.com (smtp001.mail.ukl.yahoo.com [217.12.11.32]) by mx1.FreeBSD.org (Postfix) with SMTP id A654F43D64 for ; Tue, 21 Mar 2006 01:07:29 +0000 (GMT) (envelope-from jofsama@yahoo.com) Received: (qmail 33359 invoked from network); 21 Mar 2006 01:07:28 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Received:Message-ID:Date:From:User-Agent:X-Accept-Language:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=ljr2T8N/zVzbYeC6abfmRqwyC+f4f/dtr3qNJ2f7XSYCBOQF0GLZE0HL8XN1FWE3PTW2KEJkPD/SrOHlmDWM5kUJvmpWHGc8eBbxkdvdgCJzkdihmBmFDj6DiZNKA304tyPyyCXReB7JehgCBF7VR1YrWlfGvLqSzzT29Mrzp1M= ; Received: from unknown (HELO ?192.168.11.4?) (jofsama@220.99.2.201 with plain) by smtp001.mail.ukl.yahoo.com with SMTP; 21 Mar 2006 01:07:27 -0000 Message-ID: <441F5232.9060701@yahoo.com> Date: Tue, 21 Mar 2006 10:09:06 +0900 From: Jarrod User-Agent: Mozilla Thunderbird 1.0.7 (X11/20060107) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Yar Tikhiy References: <43EAFDB9.9040106@yahoo.com> <20060210085607.GF66940@comp.chem.msu.su> <43F1401F.30102@yahoo.com> <20060218011020.GD90689@comp.chem.msu.su> In-Reply-To: <20060218011020.GD90689@comp.chem.msu.su> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org Subject: Re: EKPD daemon in /usr/local/etc/rc.d getting killed before login X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2006 01:07:43 -0000 Hi Yar, Thanks for your help with the EKPD problem. I have (finally!) managed to find time to raise a PR on the issue. Please have a look at PR ports/94690. Have a good one. Kind Regards, Jarrod. Yar Tikhiy wrote: >On Tue, Feb 14, 2006 at 11:27:43AM +0900, Jarrod wrote: > > >>Hi Yar, >> >>Thanks a lot for you comments. I've inserted some responses below. >> >>Yar Tikhiy wrote: >> >> >> >>>On Thu, Feb 09, 2006 at 05:30:49PM +0900, Jarrod wrote: >>> >>> >>> >>> >>>>Looking around at some of the system daemons I ended up taking a leaf >>>>out of lpd.c and changing the daemon's startup code from doing a regular >>>>"fork()" to doing a "daemon(0, 0)" call instead. >>>> >>>>At this stage it looks like the problem is solved. >>>> >>>>My question is: Is there some documentation or warning somewhere which >>>>would have aided me in resolving this problem? >>>> >>>> >>>> >>>> >>>Perhaps the ekpd daemon hits some configuration/communication problems >>>and chooses to terminate? Most daemons can log their activity, so you >>>may want to investigate if it is possible by means of a configuration >>>file or command-line arguments to tell ekpd to log its actions to a file >>>or to a syslog facility. In the latter case (syslog) you'll need to >>>make sure that the facility used really gets logged to a file -- see >>>syslog(8) and syslog.conf(5). >>> >>> >>> >>> >>The code for the ekpd daemon does not appear to do much in the way of >>logging. I put a liberal amount of trace statements in using the syslog >>command to try and determine where and why it was shutting down, but >>without much success. >> >> >> >>>>I read all the material I could find on the rc.d system and but I didn't >>>>see anything that suggested just doing a regular fork() would get you in >>>>trouble. I assume the problem has something to do with why the >>>>"daemon()" function exists in the first place? >>>> >>>>Is there any possibility that there could be a check somewhere in the rc >>>>system or ports system to prevent programs that don't call "daemon()" to >>>>initialize from being installed in rc.d? >>>> >>>> >>>> >>>> >>>This is hardly possible. The only case I can think of is when a >>>program forks into background and then tries to do terminal IO -- >>>it will receive a signal. The daemon() function closes standard >>>IO descriptors and thus prevents the program from doing any IO on >>>them later. If this is the case, ekpd will die if started manually >>>by running "/usr/local/etc/rc.d/ekpd start", too. >>> >>> >>> >>> >>Thanks for the help here. I went and had a look at the daemon() function >>itself: >>http://www.freebsd.org/cgi/cvsweb.cgi/src/lib/libc/gen/daemon.c >> >>in the CVS repository. It seems to do three main things as far as I can >>tell: >> >>1. Catches a signal that (possibly?) gets thrown when the parent exits. >>2. Calls the setsid() function. >>3. Closes the stdio file descriptors. >> >>Since I couldn't see the EKPD daemon doing much IO I decided to play >>around with the setsid() function. I let EKPD do the usual fork() >>(taking out my daemon() call) and then did a setsid() straight after. >> >>Voila! This seems to work. The daemon no longer bails at the end of startup. >> >>I'm not much of an expert on UNIX processes, but is it possible that >>when the parent shell process running all the scripts in rc.d/ finishes, >>any child processes that haven't detached, using setsid() or similar, >>are killed off? >> >> > >While I don't fully understand this particular case, killing off such >child processes is possible. It is documented in _exit(2): > > o If the process is a controlling process (see intro(2)), the SIGHUP > signal is sent to the foreground process group of the controlling > terminal, and all current access to the controlling terminal is > revoked. > >Some cases with daemons are considered in PR bin/25462. > > > >>From a useability perspective is it worth raising a PR? I just wonder >>if it might not be nice to have a warning printed up somewhere when you >>installed a script into the rc.d directory to save newbies (like me) >>getting unnecessarily frustrated! :) >> >> > >I think that the solution is to add a trivial patch substituting >daemon() for fork() in the port. Depending on your free time etc, >you may either suggest this in the PR or include the patch in it. >A PR is a good idea in any case. > > > From owner-freebsd-rc@FreeBSD.ORG Tue Mar 21 01:30:27 2006 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6469216A420 for ; Tue, 21 Mar 2006 01:30:27 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 33DB343D45 for ; Tue, 21 Mar 2006 01:30:27 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2L1UQhM047220 for ; Tue, 21 Mar 2006 01:30:26 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k2L1UQe7047219; Tue, 21 Mar 2006 01:30:26 GMT (envelope-from gnats) Date: Tue, 21 Mar 2006 01:30:26 GMT Message-Id: <200603210130.k2L1UQe7047219@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Brooks Davis Cc: Subject: Re: conf/73909 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Brooks Davis List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2006 01:30:27 -0000 The following reply was made to PR conf/73909; it has been noted by GNATS. From: Brooks Davis To: Florent Thoumie Cc: bug-followup@FreeBSD.org, dougb@FreeBSD.org, brooks@FreeBSD.org Subject: Re: conf/73909 Date: Mon, 20 Mar 2006 17:29:45 -0800 --bp/iNruPH9dso1Pn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 20, 2006 at 08:52:24PM +0100, Florent Thoumie wrote: > Sounds correct to me, and that way we could remove sshd.sh installed > from security/openssh*. >=20 > dougb/brooks cc'ed since they're my usual candidates when seeking > approval :) It's OK as far as it goes. I'd be tempted to have the script create symlinks to /etc/ssh/XXX when it exists and ETCDIR/ssh/XXX does not, but I don't think that's absolutly necessicary. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --bp/iNruPH9dso1Pn Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFEH1cHXY6L6fI4GtQRAiQHAJ9g0x9HvJ41k33ZA76Ezg8IQpmYXwCgifhR C7FPVideTHZtW53/QmL2U8Q= =EeZG -----END PGP SIGNATURE----- --bp/iNruPH9dso1Pn-- From owner-freebsd-rc@FreeBSD.ORG Tue Mar 21 07:21:05 2006 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 59FC216A401; Tue, 21 Mar 2006 07:21:05 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1100643D45; Tue, 21 Mar 2006 07:21:05 +0000 (GMT) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (linimon@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2L7L4Oc075481; Tue, 21 Mar 2006 07:21:04 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k2L7L4DB075477; Tue, 21 Mar 2006 07:21:04 GMT (envelope-from linimon) Date: Tue, 21 Mar 2006 07:21:04 GMT From: Mark Linimon Message-Id: <200603210721.k2L7L4DB075477@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-rc@FreeBSD.org Cc: Subject: Re: bin/94767: [patch] rcorder(8) dumps core when does not use a proper RCng script (dansguardian) X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2006 07:21:05 -0000 Old Synopsis: rcorder dumps core when does not use a proper RCng script (dansguardian) New Synopsis: [patch] rcorder(8) dumps core when does not use a proper RCng script (dansguardian) Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: linimon Responsible-Changed-When: Tue Mar 21 07:20:43 UTC 2006 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=94767 From owner-freebsd-rc@FreeBSD.ORG Fri Mar 24 12:16:08 2006 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 44BCE16A422 for ; Fri, 24 Mar 2006 12:16:08 +0000 (UTC) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9EC8E43D75 for ; Fri, 24 Mar 2006 12:16:03 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id C47B3116CC for ; Fri, 24 Mar 2006 13:15:58 +0100 (CET) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 13153-05 for ; Fri, 24 Mar 2006 13:15:50 +0100 (CET) Received: from mayday.esat.net (mayday.esat.net [193.95.134.156]) by smtp.xbsd.org (Postfix) with ESMTP id 5842311483 for ; Fri, 24 Mar 2006 13:15:50 +0100 (CET) From: Florent Thoumie To: freebsd-rc@FreeBSD.org Content-Type: text/plain Date: Fri, 24 Mar 2006 12:15:49 +0000 Message-Id: <1143202549.16053.145.camel@mayday.esat.net> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Virus-Scanned: amavisd-new at xbsd.org Cc: Subject: rc.subr / rc.d/sshd patch for review X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2006 12:16:08 -0000 This is based on Oliver's patch for rc.d/sshd that can be found in Gnats. In load_rc_config, I'm extracting prefix from ${command} (or ${name}_program, which part is moved from run_rc_command), and setting etcdir accordingly. The point is that some scripts (like rc.d/sshd) can be used for base sshd as well as ports sshd, and makes possible to source ${prefix}/etc/rc.conf.d/${name}. This patch also documents ${name}_program above run_rc_command (though it's actually used in load_rc_config). The patch can be found at http://people.freebsd.org/~flz/local/rc.d-sshd.diff. -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer From owner-freebsd-rc@FreeBSD.ORG Fri Mar 24 20:56:29 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DEABC16A420 for ; Fri, 24 Mar 2006 20:56:29 +0000 (UTC) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id DD16443D53 for ; Fri, 24 Mar 2006 20:56:28 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id k2OKuRom019124; Fri, 24 Mar 2006 12:56:27 -0800 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id k2OKuRUM019123; Fri, 24 Mar 2006 12:56:27 -0800 Date: Fri, 24 Mar 2006 12:56:27 -0800 From: Brooks Davis To: Florent Thoumie Message-ID: <20060324205627.GA18100@odin.ac.hmc.edu> References: <1143202549.16053.145.camel@mayday.esat.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6TrnltStXW4iwmi0" Content-Disposition: inline In-Reply-To: <1143202549.16053.145.camel@mayday.esat.net> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-rc@freebsd.org Subject: Re: rc.subr / rc.d/sshd patch for review X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2006 20:56:30 -0000 --6TrnltStXW4iwmi0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 24, 2006 at 12:15:49PM +0000, Florent Thoumie wrote: > This is based on Oliver's patch for rc.d/sshd that can be found in > Gnats. >=20 > In load_rc_config, I'm extracting prefix from ${command} (or > ${name}_program, which part is moved from run_rc_command), and setting > etcdir accordingly. >=20 > The point is that some scripts (like rc.d/sshd) can be used for base > sshd as well as ports sshd, and makes possible to source > ${prefix}/etc/rc.conf.d/${name}. >=20 > This patch also documents ${name}_program above run_rc_command (though > it's actually used in load_rc_config). Is command always set? I'm pretty sure it isn't so this may not be entierly safe. If it's not set, should we try to guess prefix from $0? The other issue I see is that instead of: if [ -f ${etcdir}/rc.conf.d/"$_command" ]; then debug "Sourcing ${etcdir}/rc.conf.d/${_command}" . ${etcdir}/rc.conf.d/"$_command" fi I think we should do: if [ -f /etc/rc.conf.d/"$_command" ]; then debug "Sourcing /etc/rc.conf.d/${_command}" . /etc/rc.conf.d/"$_command" fi if [ "${etcdir}" !=3D "/etc" -a -f ${etcdir}/rc.conf.d/"$_command" ]; then debug "Sourcing ${etcdir}/rc.conf.d/${_command}" . ${etcdir}/rc.conf.d/"$_command" fi That preserves the old behavior while adding support for ${prefix}/etc/rc.conf.d. -- Brooks -- Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --6TrnltStXW4iwmi0 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFEJFz6XY6L6fI4GtQRAgZzAJ9V+VA2SSxnufdXoOot+XM/7Yk75ACgvyzT DtvudLi5ZuXgr1E9qBFjKFc= =ZpeL -----END PGP SIGNATURE----- --6TrnltStXW4iwmi0-- From owner-freebsd-rc@FreeBSD.ORG Sat Mar 25 11:07:22 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3BE1316A538 for ; Sat, 25 Mar 2006 11:07:22 +0000 (UTC) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id B31C343D45 for ; Sat, 25 Mar 2006 11:07:21 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 3A45811796; Sat, 25 Mar 2006 12:07:14 +0100 (CET) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 38723-02; Sat, 25 Mar 2006 12:07:08 +0100 (CET) Received: from [192.168.1.102] (unknown [83.141.123.158]) by smtp.xbsd.org (Postfix) with ESMTP id A7F9011604; Sat, 25 Mar 2006 12:07:06 +0100 (CET) In-Reply-To: <20060324205627.GA18100@odin.ac.hmc.edu> References: <1143202549.16053.145.camel@mayday.esat.net> <20060324205627.GA18100@odin.ac.hmc.edu> Mime-Version: 1.0 (Apple Message framework v746.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <00E087F1-81E4-4580-A655-50F3DD8A471F@xbsd.org> Content-Transfer-Encoding: 7bit From: Florent Thoumie Date: Sat, 25 Mar 2006 11:06:46 +0000 To: Brooks Davis X-Mailer: Apple Mail (2.746.3) X-Virus-Scanned: amavisd-new at xbsd.org Cc: freebsd-rc@freebsd.org Subject: Re: rc.subr / rc.d/sshd patch for review X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Mar 2006 11:07:22 -0000 On Mar 24, 2006, at 8:56 PM, Brooks Davis wrote: > On Fri, Mar 24, 2006 at 12:15:49PM +0000, Florent Thoumie wrote: >> This is based on Oliver's patch for rc.d/sshd that can be found in >> Gnats. >> >> In load_rc_config, I'm extracting prefix from ${command} (or >> ${name}_program, which part is moved from run_rc_command), and >> setting >> etcdir accordingly. >> >> The point is that some scripts (like rc.d/sshd) can be used for base >> sshd as well as ports sshd, and makes possible to source >> ${prefix}/etc/rc.conf.d/${name}. >> >> This patch also documents ${name}_program above run_rc_command >> (though >> it's actually used in load_rc_config). > > Is command always set? I'm pretty sure it isn't so this may not be > entierly > safe. If it's not set, should we try to guess prefix from $0? Somehow, command gets set to the right value, but you're right, I'm missing a bit here. > The other issue I see is that instead of: > > if [ -f ${etcdir}/rc.conf.d/"$_command" ]; then > debug "Sourcing ${etcdir}/rc.conf.d/${_command}" > . ${etcdir}/rc.conf.d/"$_command" > fi > > I think we should do: > > if [ -f /etc/rc.conf.d/"$_command" ]; then > debug "Sourcing /etc/rc.conf.d/${_command}" > . /etc/rc.conf.d/"$_command" > fi > if [ "${etcdir}" != "/etc" -a -f ${etcdir}/ > rc.conf.d/"$_command" ]; then > debug "Sourcing ${etcdir}/rc.conf.d/${_command}" > . ${etcdir}/rc.conf.d/"$_command" > fi > > That preserves the old behavior while adding support for > ${prefix}/etc/rc.conf.d. Fair enough, but I'd like to add a note saying that /etc/rc.conf.d/$ {name} is deprecated for ${etcdir} != "/etc". I'll write a new patch this week end. Thanks Brooks. -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer From owner-freebsd-rc@FreeBSD.ORG Sat Mar 25 17:20:34 2006 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7AF3E16A426 for ; Sat, 25 Mar 2006 17:20:34 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E00B43D45 for ; Sat, 25 Mar 2006 17:20:22 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2PHKHLW091529 for ; Sat, 25 Mar 2006 17:20:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k2PHKHNM091528; Sat, 25 Mar 2006 17:20:17 GMT (envelope-from gnats) Date: Sat, 25 Mar 2006 17:20:17 GMT Message-Id: <200603251720.k2PHKHNM091528@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Adrian Steinmann Cc: Subject: Re: bin/94767: [patch] rcorder(8) dumps core when does not use a proper RCng script (dansguardian) X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Adrian Steinmann List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Mar 2006 17:20:34 -0000 The following reply was made to PR bin/94767; it has been noted by GNATS. From: Adrian Steinmann To: bug-followup@FreeBSD.org Cc: ganbold@micom.mng.net Subject: Re: bin/94767: [patch] rcorder(8) dumps core when does not use a proper RCng script (dansguardian) Date: Sat, 25 Mar 2006 18:13:54 +0100 (CET) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-674585855-1143306834=:31295 Content-Type: TEXT/PLAIN; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT I've run into this problem on -current too and have created three test cases which dump core. With the mentioned patch two of the cases are fixed, but one remains: It seems the "don't nuke unless last node" patch works when no third "stub dependancy" interferes. On 6.1-PRERELEASE all three test cases pass. Adrian Details: #!/bin/sh try() { [ $# -lt 2 ] && return echo "=============== TEST rcorder $@" files=$@ cmd="rcorder $files" for f in $files do echo === cat $f: cat $f done rm -f rcorder.core echo === $cmd: eval $cmd [ -e rcorder.core ] && echo "DUMPED CORE - ^C to stop" && read a rm -f rcorder.core $@ echo } { echo "# PROVIDE: A"; echo "# REQUIRE: B"; } >A { echo "# PROVIDE: B"; echo "# REQUIRE: A"; } >B try A B { echo "# PROVIDE: A"; echo "# REQUIRE: B C"; } >A { echo "# PROVIDE: B"; echo "# REQUIRE: A C"; } >B { echo "# PROVIDE: C"; } > C try A B C { echo "# PROVIDE: A"; echo "# REQUIRE: B"; } >A { echo "# PROVIDE: B"; echo "# REQUIRE: C"; } >B { echo "# PROVIDE: C"; echo "# REQUIRE: A"; } >C try A B C exit 0 Index: rcorder.c =================================================================== RCS file: /usr/cvs/src/sbin/rcorder/rcorder.c,v retrieving revision 1.2 diff -u -r1.2 rcorder.c --- rcorder.c 17 Jan 2006 08:01:00 -0000 1.2 +++ rcorder.c 25 Mar 2006 16:40:33 -0000 @@ -51,8 +51,9 @@ #include "sprite.h" #include "hash.h" +#define DEBUG 1 #ifdef DEBUG -int debug = 0; +int debug = 1; # define DPRINTF(args) if (debug) { fflush(stdout); fprintf args; } #else # define DPRINTF(args) here, all three test cases dump core, apparently the stack is being hit in the first and third case: =============== TEST1 rcorder A B ... generate on ZZZZZZZZZZZZZZZZZZZZ do_file on ZZZZZZZZZZZZZZZZZZZZ. Segmentation fault (core dumped) DUMPED CORE - ^C to stop Core was generated by `rcorder'. Program terminated with signal 11, Segmentation fault. #0 0x080493ac in satisfy_req (rnode=0x5a5a5a5a, filename=0xbfbfe7b0 "?㿿\003\001") at /usr/src/sbin/rcorder/rcorder.c:655 655 entry = rnode->entry; (gdb) where #0 0x080493ac in satisfy_req (rnode=0x5a5a5a5a, filename=0xbfbfe7b0 "?㿿\003\001") at /usr/src/sbin/rcorder/rcorder.c:655 #1 0x08048fa3 in do_file (fnode=0xa000110) at /usr/src/sbin/rcorder/rcorder.c:759 #2 0x0804917b in generate_ordering () at /usr/src/sbin/rcorder/rcorder.c:827 #3 0x08049369 in main (argc=2, argv=0x1) at /usr/src/sbin/rcorder/rcorder.c:193 =============== TEST2 rcorder A B C Program terminated with signal 11, Segmentation fault. #0 satisfy_req (rnode=0xa000374, filename=0xa0001a0 "B") at /usr/src/sbin/rcorder/rcorder.c:666 666 if (head->next == NULL) (gdb) where #0 satisfy_req (rnode=0xa000374, filename=0xa0001a0 "B") at /usr/src/sbin/rcorder/rcorder.c:666 #1 0x08048fa3 in do_file (fnode=0xa0003e0) at /usr/src/sbin/rcorder/rcorder.c:759 #2 0x080493d7 in satisfy_req (rnode=0xa000374, filename=0xa0001a0 "B") at /usr/src/sbin/rcorder/rcorder.c:687 #3 0x08048fa3 in do_file (fnode=0xa000110) at /usr/src/sbin/rcorder/rcorder.c:759 #4 0x080493d7 in satisfy_req (rnode=0xa000374, filename=0xa0001a0 "B") at /usr/src/sbin/rcorder/rcorder.c:687 #5 0x08048fa3 in do_file (fnode=0xa0003e0) at /usr/src/sbin/rcorder/rcorder.c:759 #6 0x0804917b in generate_ordering () at /usr/src/sbin/rcorder/rcorder.c:827 #7 0x08049369 in main (argc=3, argv=0x1) at /usr/src/sbin/rcorder/rcorder.c:193 =============== TEST3 rcorder A B C Program terminated with signal 11, Segmentation fault. #0 0x080493ac in satisfy_req (rnode=0x5a5a5a5a, filename=0xbfbfe7b0 "?㿿???\n") at /usr/src/sbin/rcorder/rcorder.c:655 655 entry = rnode->entry; (gdb) where #0 0x080493ac in satisfy_req (rnode=0x5a5a5a5a, filename=0xbfbfe7b0 "?㿿???\n") at /usr/src/sbin/rcorder/rcorder.c:655 #1 0x08048fa3 in do_file (fnode=0xa000360) at /usr/src/sbin/rcorder/rcorder.c:759 #2 0x0804917b in generate_ordering () at /usr/src/sbin/rcorder/rcorder.c:827 #3 0x08049369 in main (argc=3, argv=0x1) at /usr/src/sbin/rcorder/rcorder.c:193 with the patch proposed earlier (skip nuking) Index: rcorder.c =================================================================== RCS file: /usr/cvs/src/sbin/rcorder/rcorder.c,v retrieving revision 1.2 diff -u -r1.2 rcorder.c --- rcorder.c 17 Jan 2006 08:01:00 -0000 1.2 +++ rcorder.c 25 Mar 2006 16:45:38 -0000 @@ -51,8 +51,9 @@ #include "sprite.h" #include "hash.h" +#define DEBUG 1 #ifdef DEBUG -int debug = 0; +int debug = 1; # define DPRINTF(args) if (debug) { fflush(stdout); fprintf args; } #else # define DPRINTF(args) @@ -796,10 +797,14 @@ fnode->last->next = fnode->next; } - DPRINTF((stderr, "nuking %s\n", fnode->filename)); if (was_set == 0) { + DPRINTF((stderr, "nuking %s\n", fnode->filename)); +#if 0 free(fnode->filename); free(fnode); +#else + DPRINTF((stderr, "but skipping it for now\n")); +#endif } } only TEST2 dumps core: =============== TEST2 rcorder A B C === cat A: # PROVIDE: A # REQUIRE: B C === cat B: # PROVIDE: B # REQUIRE: A C === cat C: # PROVIDE: C === rcorder A B C: parse_args initialize crunch_all_files generate on C do_file on C. next do: C nuking C but skipping it for now generate on B do_file on B. do_file on A. do_file on B. rcorder: Circular dependency on file `B'. Segmentation fault (core dumped) Program terminated with signal 11, Segmentation fault. #0 0x080493d0 in satisfy_req () (gdb) where #0 0x080493d0 in satisfy_req () #1 0x08048fa3 in do_file () #2 0x080493ef in satisfy_req () #3 0x08048fa3 in do_file () #4 0x080493ef in satisfy_req () #5 0x08048fa3 in do_file () #6 0x08049193 in generate_ordering () #7 0x08049381 in main () --0-674585855-1143306834=:31295--