From owner-cvs-src@FreeBSD.ORG Sun Aug 26 00:27:49 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 952C016A418; Sun, 26 Aug 2007 00:27:49 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 72EC913C46E; Sun, 26 Aug 2007 00:27:49 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7Q0RnGG044341; Sun, 26 Aug 2007 00:27:49 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7Q0RnYr044337; Sun, 26 Aug 2007 00:27:49 GMT (envelope-from alc) Message-Id: <200708260027.l7Q0RnYr044337@repoman.freebsd.org> From: Alan Cox Date: Sun, 26 Aug 2007 00:27:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/vm vm_pageout.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Aug 2007 00:27:49 -0000 alc 2007-08-26 00:27:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/vm vm_pageout.c Log: MFC revisions 1.288 and 1.289 Eliminate the use of Giant from vm_daemon(). Replace the unconditional use of Giant in vm_pageout_scan() with VFS_LOCK_GIANT(). Revision Changes Path 1.268.2.4 +36 -31 src/sys/vm/vm_pageout.c From owner-cvs-src@FreeBSD.ORG Sun Aug 26 02:35:50 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AB03416A417; Sun, 26 Aug 2007 02:35:50 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8ABD813C468; Sun, 26 Aug 2007 02:35:50 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7Q2Zo77077193; Sun, 26 Aug 2007 02:35:50 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7Q2ZoCu077192; Sun, 26 Aug 2007 02:35:50 GMT (envelope-from scottl) Message-Id: <200708260235.l7Q2ZoCu077192@repoman.freebsd.org> From: Scott Long Date: Sun, 26 Aug 2007 02:35:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/mfi mfi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Aug 2007 02:35:50 -0000 scottl 2007-08-26 02:35:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/mfi mfi.c Log: Fix the build. Revision Changes Path 1.3.2.9 +1 -1 src/sys/dev/mfi/mfi.c From owner-cvs-src@FreeBSD.ORG Sun Aug 26 02:36:32 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4CC9016A418; Sun, 26 Aug 2007 02:36:32 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2C00713C458; Sun, 26 Aug 2007 02:36:31 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7Q2aVU0077256; Sun, 26 Aug 2007 02:36:31 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7Q2aVoQ077255; Sun, 26 Aug 2007 02:36:31 GMT (envelope-from scottl) Message-Id: <200708260236.l7Q2aVoQ077255@repoman.freebsd.org> From: Scott Long Date: Sun, 26 Aug 2007 02:36:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/mfi mfi.c mfi_pci.c mfireg.h mfivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Aug 2007 02:36:32 -0000 scottl 2007-08-26 02:36:31 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/mfi mfi.c mfi_pci.c mfireg.h mfivar.h Log: MFC LSI 1078/PERC6 update. Submitted by: LSI Revision Changes Path 1.3.2.10 +120 -21 src/sys/dev/mfi/mfi.c 1.1.2.7 +30 -3 src/sys/dev/mfi/mfi_pci.c 1.1.2.8 +37 -0 src/sys/dev/mfi/mfireg.h 1.1.2.8 +34 -0 src/sys/dev/mfi/mfivar.h From owner-cvs-src@FreeBSD.ORG Sun Aug 26 07:35:52 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5B9FE16A41A; Sun, 26 Aug 2007 07:35:52 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id 49E8F13C45A; Sun, 26 Aug 2007 07:35:51 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7Q7ZbhX038414; Sun, 26 Aug 2007 11:35:37 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7Q7ZaSs038408; Sun, 26 Aug 2007 11:35:36 +0400 (MSD) (envelope-from yar) Date: Sun, 26 Aug 2007 11:35:35 +0400 From: Yar Tikhiy To: Daniel Eischen Message-ID: <20070826073535.GD21352@comp.chem.msu.su> References: <20070824.172212.74696955.imp@bsdimp.com> <20070825053302.GG99474@comp.chem.msu.su> <20070825.093925.43008968.imp@bsdimp.com> <1188071752.1853.44.camel@neo.cse.buffalo.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Cc: src-committers@FreeBSD.org, peterjeremy@optushome.com.au, alfred@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, Ken Smith , "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Aug 2007 07:35:52 -0000 On Sat, Aug 25, 2007 at 05:06:08PM -0400, Daniel Eischen wrote: > > No offense, but some things have been going in without being discussed > an -arch or -current. Approval for committing still has to go through > re@, but that doesn't mean that changes shouldn't be vetted elsewhere > prior to being sent to re@ approval. Pardon me, but how could I know that symbol versioning was a sacred cow and my intention to use it should have been discussed on -arch? I asked explicitly on -developers if we had a policy regarding symbol versioning and got no definite replies but those on the purely technical side of the issue. Therefore I concluded that symbol versioning is just a tool available to developers at their discretion. I don't have to post each my change to -arch beforehand just because I use the highly dangerous C language, do I? Second, no offense intended from my side, either, but have you realized what arguments did you use against my change in this thread? They are more or less as follows: - Please don't commit it, or it will make me unhappy. - Symbol versioning is there to help release engineers, not to work around silly bugs elsewhere. - I'd disapprove it if I knew about it. These are not valid arguments for a technical discussion in an open source project unless they can be supported by references to a well-known document. You obviously have something to tell us in technical terms, so please do so, we are all ears. It would be a great thread for -arch. That said, I'm not going to commit the change until, and unless, the issue has been settled. In the meanwhile, I've started an experiment to see if the dependence of the build system on ABI compatibility can be addressed in src/Makefile.inc1 cleanly, without temporary hacks. I'll be glad to go that way if it proved possible. But, anyway, there are at least three people in the project who misundertood the intended role of symbol versioning. Besides yours truly, a humble developer, there are a core team member and a release engineer among them. This may be a sign that some decisions regarding symbol versioning, which is a rather central feature for developers and code contributors, haven't had enough exposure. Perhaps we've just missed some important discussions on the lists, but symbol versioning is a long-term feature and as such it deserves a document describing in detail how to use it in our project. The technical side of symbol versioning puts few limitations on how one can use it, the rest being a matter of policy. Of course, the choice of the policy is important and can have far-reaching consequences, such as getting us into a complete mess or making us technology champs like Linux and Sun. :-) Now all our symbols still are at FBSD_1.0, and it isn't late yet to work out such a policy. Again, it will make an excellent thread on -arch. -- Yar From owner-cvs-src@FreeBSD.ORG Sun Aug 26 11:32:58 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5CFCC16A46B; Sun, 26 Aug 2007 11:32:58 +0000 (UTC) (envelope-from sephe@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3849613C45D; Sun, 26 Aug 2007 11:32:58 +0000 (UTC) (envelope-from sephe@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7QBWwr0044072; Sun, 26 Aug 2007 11:32:58 GMT (envelope-from sephe@repoman.freebsd.org) Received: (from sephe@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7QBWvep044071; Sun, 26 Aug 2007 11:32:57 GMT (envelope-from sephe) Message-Id: <200708261132.l7QBWvep044071@repoman.freebsd.org> From: Sepherosa Ziehau Date: Sun, 26 Aug 2007 11:32:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net80211 ieee80211_freebsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Aug 2007 11:32:58 -0000 sephe 2007-08-26 11:32:57 UTC FreeBSD src repository Modified files: sys/net80211 ieee80211_freebsd.c Log: Fix following nits: - Per ieee80211com sysctl ctx leakage on detach - getmgtframe incorrectly adjusts mbuf.m_data Reviewed by: sam Approved by: re (bmah), sam (mentor) Revision Changes Path 1.16 +2 -1 src/sys/net80211/ieee80211_freebsd.c From owner-cvs-src@FreeBSD.ORG Sun Aug 26 11:34:52 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 91B4E16A419; Sun, 26 Aug 2007 11:34:52 +0000 (UTC) (envelope-from sephe@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6D01F13C442; Sun, 26 Aug 2007 11:34:52 +0000 (UTC) (envelope-from sephe@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7QBYqC8044175; Sun, 26 Aug 2007 11:34:52 GMT (envelope-from sephe@repoman.freebsd.org) Received: (from sephe@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7QBYqs6044174; Sun, 26 Aug 2007 11:34:52 GMT (envelope-from sephe) Message-Id: <200708261134.l7QBYqs6044174@repoman.freebsd.org> From: Sepherosa Ziehau Date: Sun, 26 Aug 2007 11:34:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net80211 ieee80211_regdomain.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Aug 2007 11:34:52 -0000 sephe 2007-08-26 11:34:52 UTC FreeBSD src repository Modified files: sys/net80211 ieee80211_regdomain.c Log: Off-by-one bug in country ie construction, which will make HOSTAP send out malformatted beacons. Reviewed by: sam Approved by: re (bmah), sam (mentor) Revision Changes Path 1.2 +3 -1 src/sys/net80211/ieee80211_regdomain.c From owner-cvs-src@FreeBSD.ORG Sun Aug 26 12:36:07 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DAB5116A418; Sun, 26 Aug 2007 12:36:07 +0000 (UTC) (envelope-from jhein@timing.com) Received: from Daffy.timing.com (daffy.timing.com [206.168.13.218]) by mx1.freebsd.org (Postfix) with ESMTP id 8840113C428; Sun, 26 Aug 2007 12:36:07 +0000 (UTC) (envelope-from jhein@timing.com) Received: from gromit.timing.com (gromit.timing.com [206.168.13.209]) by Daffy.timing.com (8.13.1/8.13.1) with ESMTP id l7QBd9RB048395; Sun, 26 Aug 2007 05:39:09 -0600 (MDT) (envelope-from jhein@timing.com) Received: from gromit.timing.com (localhost [127.0.0.1]) by gromit.timing.com (8.14.1/8.14.1) with ESMTP id l7QBd9PS040480; Sun, 26 Aug 2007 05:39:09 -0600 (MDT) (envelope-from jhein@gromit.timing.com) Received: (from jhein@localhost) by gromit.timing.com (8.14.1/8.14.1/Submit) id l7QBd2QC040476; Sun, 26 Aug 2007 05:39:02 -0600 (MDT) (envelope-from jhein) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18129.26198.138161.387852@gromit.timing.com> Date: Sun, 26 Aug 2007 05:39:02 -0600 From: John E Hein To: Yar Tikhiy In-Reply-To: <20070825053302.GG99474@comp.chem.msu.su> References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <20070824220244.GH87451@elvis.mu.org> <20070824.172212.74696955.imp@bsdimp.com> <20070825053302.GG99474@comp.chem.msu.su> X-Mailer: VM 7.19 under Emacs 22.0.99.1 Cc: src-committers@freebsd.org, cvs-src@freebsd.org, alfred@freebsd.org, cvs-all@freebsd.org, Daniel Eischen , Warner Losh Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Aug 2007 12:36:08 -0000 Yar Tikhiy wrote at 09:33 +0400 on Aug 25, 2007: > On Fri, Aug 24, 2007 at 11:08:01PM -0400, Daniel Eischen wrote: > > > > It should be easy to say FBSD_1.0 is RELEASE_7.0, FBBSD_1.1 is RELEASE_7.1, > > etc. The versioned symbol namespace is mostly to aid the release > > engineers. If you start to have FBSD_1.2, FBSD_1.3, and FBSD_1.4 > > are interim versions and FBSD_1.5 is release 7.1, that isn't good. > > In addition, symbol versions are mere text labels with no special > meaning to ld(1), so we can format them to allow for version changes > between major releases. By way of precedent, this reminds me of how __FreeBSD_version is used for miscellaneous intra-release changes (changes that aren't necessarily ABI changes, but perhaps disappearance or emergence of new tools or tool changes). For instance, this has been known to happen when the pkg* tools change and the ports infrastructure is tweaked to behave differently based on the fine-grained FreeBSD version (aka OSVERSION). Can the symbol versioning labels be standardized to make similar accomodations for ABI changes in between releases? Even in stable branches, now that I think about it. I almost removed that controversial thought from this email to avoid a flame war. But on the other hand, used conservatively, I could foresee a security fix being made much easier if an ABI change was allowed. This would be quite rare, I'm sure. From owner-cvs-src@FreeBSD.ORG Sun Aug 26 14:57:09 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5379D16A421; Sun, 26 Aug 2007 14:57:09 +0000 (UTC) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2F05E13C46C; Sun, 26 Aug 2007 14:57:09 +0000 (UTC) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7QEv9FW070097; Sun, 26 Aug 2007 14:57:09 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7QEv99Y070096; Sun, 26 Aug 2007 14:57:09 GMT (envelope-from phk) Message-Id: <200708261457.l7QEv99Y070096@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sun, 26 Aug 2007 14:57:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/tools/nanobsd nanobsd.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Aug 2007 14:57:09 -0000 phk 2007-08-26 14:57:08 UTC FreeBSD src repository Modified files: tools/tools/nanobsd nanobsd.sh Log: Add option to not fill second code image, this makes the full disk image compress much better. Respect pkg_add's internal 200 package limitation. Approved by: re (bmah) Spelling fixes by: bmah Revision Changes Path 1.28 +10 -3 src/tools/tools/nanobsd/nanobsd.sh From owner-cvs-src@FreeBSD.ORG Sun Aug 26 15:57:07 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6084116A421; Sun, 26 Aug 2007 15:57:07 +0000 (UTC) (envelope-from remko@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 54DCF13C46C; Sun, 26 Aug 2007 15:57:07 +0000 (UTC) (envelope-from remko@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7QFv7G4075065; Sun, 26 Aug 2007 15:57:07 GMT (envelope-from remko@repoman.freebsd.org) Received: (from remko@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7QFv7gA075064; Sun, 26 Aug 2007 15:57:07 GMT (envelope-from remko) Message-Id: <200708261557.l7QFv7gA075064@repoman.freebsd.org> From: Remko Lodder Date: Sun, 26 Aug 2007 15:57:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Aug 2007 15:57:07 -0000 remko 2007-08-26 15:57:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share Makefile Log: Semi-MFC Makefile v 1.37 (changed in order to reflect 6.X behaviour) Make zoneinfo optional so that a filesystem upgrade/update does not overwrite possibly installed thirdparte zoneinfo databases (from ports for example). Submitted by: Mark Andrews (original patch rewritten by me to be more consistent with the new practise). Approved by: re (kensmith) Approved by: imp (mentor) Reviewed by: ru (some time ago already) Approved by: imp (mentor, implicit MFC) Revision Changes Path 1.33.2.1 +5 -1 src/share/Makefile From owner-cvs-src@FreeBSD.ORG Sun Aug 26 16:01:07 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 99E1516A419; Sun, 26 Aug 2007 16:01:07 +0000 (UTC) (envelope-from remko@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8E78013C4CC; Sun, 26 Aug 2007 16:01:07 +0000 (UTC) (envelope-from remko@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7QG17o0075236; Sun, 26 Aug 2007 16:01:07 GMT (envelope-from remko@repoman.freebsd.org) Received: (from remko@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7QG17fS075235; Sun, 26 Aug 2007 16:01:07 GMT (envelope-from remko) Message-Id: <200708261601.l7QG17fS075235@repoman.freebsd.org> From: Remko Lodder Date: Sun, 26 Aug 2007 16:01:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/share Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Aug 2007 16:01:07 -0000 remko 2007-08-26 16:01:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) share Makefile Log: Semi-MFC Makefile v 1.37 (changed in order to reflect 5.X behaviour) Make zoneinfo optional so that a filesystem upgrade/update does not overwrite possibly installed thirdparte zoneinfo databases (from ports for example). Submitted by: Mark Andrews (original patch rewritten by me to be more consistent with the new practise). Approved by: re (kensmith) Approved by: imp (mentor) Reviewed by: ru (some time ago already) Approved by: imp (mentor, implicit MFC) Revision Changes Path 1.32.2.1 +5 -1 src/share/Makefile From owner-cvs-src@FreeBSD.ORG Sun Aug 26 18:38:31 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8B00B16A419; Sun, 26 Aug 2007 18:38:31 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6608413C474; Sun, 26 Aug 2007 18:38:31 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7QIcVOD097753; Sun, 26 Aug 2007 18:38:31 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7QIcVFZ097752; Sun, 26 Aug 2007 18:38:31 GMT (envelope-from maxim) Message-Id: <200708261838.l7QIcVFZ097752@repoman.freebsd.org> From: Maxim Konovalov Date: Sun, 26 Aug 2007 18:38:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet ip_fw2.c src/sbin/ipfw ipfw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Aug 2007 18:38:31 -0000 maxim 2007-08-26 18:38:31 UTC FreeBSD src repository Modified files: sys/netinet ip_fw2.c sbin/ipfw ipfw2.c Log: o Fix bug I introduced in the previous commit (ipfw set extention): pack a set number correctly. Submitted by: oleg o Plug a memory leak. Submitted by: oleg and Andrey V. Elsukov Approved by: re (kensmith) MFC after: 1 week Revision Changes Path 1.107 +3 -3 src/sbin/ipfw/ipfw2.c 1.172 +4 -1 src/sys/netinet/ip_fw2.c From owner-cvs-src@FreeBSD.ORG Sun Aug 26 19:41:35 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D639F16A41A; Sun, 26 Aug 2007 19:41:35 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc3-cdif2-0-0-cust64.cdif.cable.ntl.com [81.106.128.65]) by mx1.freebsd.org (Postfix) with ESMTP id 8EA3613C48E; Sun, 26 Aug 2007 19:41:35 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.67 (FreeBSD)) (envelope-from ) id 1IPNjc-000HSU-DG; Sun, 26 Aug 2007 20:25:20 +0100 Date: Sun, 26 Aug 2007 20:25:20 +0100 From: Ceri Davies To: "M. Warner Losh" Message-ID: <20070826192520.GH76132@submonkey.net> References: <20070824.172212.74696955.imp@bsdimp.com> <20070825053302.GG99474@comp.chem.msu.su> <20070825.093925.43008968.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ghzN8eJ9Qlbqn3iT" Content-Disposition: inline In-Reply-To: <20070825.093925.43008968.imp@bsdimp.com> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.16 (2007-06-09) Sender: Ceri Davies Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, yar@comp.chem.msu.su, alfred@freebsd.org, cvs-all@freebsd.org, deischen@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Aug 2007 19:41:35 -0000 --ghzN8eJ9Qlbqn3iT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 25, 2007 at 09:39:25AM -0600, M. Warner Losh wrote: > Also agreed. We're FreeBSD. We are tool users. We should use tools > in a way that makes sense for us. Solaris' and Linux's experiences > with versioning should inform our policies, there is no doubt, but > since I don't think I've seen either written down in exacting detail > that we can just import FYI, the "Linker and Libraries Manual", http://docs.sun.com/app/docs/doc/817-1984, is the definitive reference. Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --ghzN8eJ9Qlbqn3iT Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFG0dOgocfcwTS3JF8RApGyAKC68DEk6tKDYM0ZDlCt4rOkJiW9NwCgm7q9 rShQDpjZGkrNK9j9gNwbIrY= =EPG0 -----END PGP SIGNATURE----- --ghzN8eJ9Qlbqn3iT-- From owner-cvs-src@FreeBSD.ORG Mon Aug 27 04:13:52 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 050DA16A417; Mon, 27 Aug 2007 04:13:52 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id 58BDA13C457; Mon, 27 Aug 2007 04:13:51 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7R4DeMp054696; Mon, 27 Aug 2007 08:13:40 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7R4DdMp054694; Mon, 27 Aug 2007 08:13:39 +0400 (MSD) (envelope-from yar) Date: Mon, 27 Aug 2007 08:13:38 +0400 From: Yar Tikhiy To: Ceri Davies Message-ID: <20070827041338.GF21352@comp.chem.msu.su> References: <20070824.172212.74696955.imp@bsdimp.com> <20070825053302.GG99474@comp.chem.msu.su> <20070825.093925.43008968.imp@bsdimp.com> <20070826192520.GH76132@submonkey.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070826192520.GH76132@submonkey.net> User-Agent: Mutt/1.5.9i Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, deischen@freebsd.org, cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 04:13:52 -0000 On Sun, Aug 26, 2007 at 08:25:20PM +0100, Ceri Davies wrote: > On Sat, Aug 25, 2007 at 09:39:25AM -0600, M. Warner Losh wrote: > > Also agreed. We're FreeBSD. We are tool users. We should use tools > > in a way that makes sense for us. Solaris' and Linux's experiences > > with versioning should inform our policies, there is no doubt, but > > since I don't think I've seen either written down in exacting detail > > that we can just import > > FYI, the "Linker and Libraries Manual", > http://docs.sun.com/app/docs/doc/817-1984, is the definitive reference. >From my reading of the document I can only say that it's the reference on Sun's way of things in symbol versioning, which isn't quite the same as that suggested by GNU ld(1); and the latter makes much more sense to me. Namely Sun's ideology is to record version labels in a shared object so that other binaries linked against a particular version(s) of the object can verify if they get the right shared object at runtime. Sun offers no way to have multiple versions of the same symbol and so Sun makes the whole thing library-centric, just a slight improvement over the good old major and minor versions encoded in library file names. Unlike Sun's linker, GNU ld(1) allows for versioning each symbol independently, and I believe it's the reason we've bought symbol versioning for. -- Yar From owner-cvs-src@FreeBSD.ORG Mon Aug 27 05:19:49 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5827016A468; Mon, 27 Aug 2007 05:19:49 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 451C513C458; Mon, 27 Aug 2007 05:19:49 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7R5JnTg022733; Mon, 27 Aug 2007 05:19:49 GMT (envelope-from rrs@repoman.freebsd.org) Received: (from rrs@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7R5JnGn022732; Mon, 27 Aug 2007 05:19:49 GMT (envelope-from rrs) Message-Id: <200708270519.l7R5JnGn022732@repoman.freebsd.org> From: Randall Stewart Date: Mon, 27 Aug 2007 05:19:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern uipc_syscalls.c src/sys/netinet sctp.h sctp_asconf.c sctp_asconf.h sctp_auth.c sctp_constants.h sctp_indata.c sctp_input.c sctp_output.c sctp_output.h sctp_pcb.c sctp_pcb.h sctp_peeloff.c sctp_structs.h sctp_sysctl.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 05:19:49 -0000 rrs 2007-08-27 05:19:48 UTC FreeBSD src repository Modified files: sys/kern uipc_syscalls.c sys/netinet sctp.h sctp_asconf.c sctp_asconf.h sctp_auth.c sctp_constants.h sctp_indata.c sctp_input.c sctp_output.c sctp_output.h sctp_pcb.c sctp_pcb.h sctp_peeloff.c sctp_structs.h sctp_sysctl.c sctp_sysctl.h sctp_uio.h sctp_usrreq.c sctp_var.h sctputil.c sys/netinet6 sctp6_usrreq.c Log: - During shutdown pending, when the last sack came in and the last message on the send stream was "null" but still there, a state we allow, we could get hung and not clean it up and wait for the shutdown guard timer to clear the association without a graceful close. Fix this so that that we properly clean up. - Added support for Multiple ASCONF per new RFC. We only (so far) accept input of these and cannot yet generate a multi-asconf. - Sysctl'd support for experimental Fast Handover feature. Always disabled unless sysctl or socket option changes to enable. - Error case in add-ip where the peer supports AUTH and ADD-IP but does NOT require AUTH of ASCONF/ASCONF-ACK. We need to ABORT in this case. - According to the Kyoto summit of socket api developers (Solaris, Linux, BSD). We need to have: o non-eeor mode messages be atomic - Fixed o Allow implicit setup of an assoc in 1-2-1 model if using the sctp_**() send calls - Fixed o Get rid of HAVE_XXX declarations - Done o add a sctp_pr_policy in hole in sndrcvinfo structure - Done o add a PR_SCTP_POLICY_VALID type flag - yet to-do in a future patch! - Optimize sctp6 calls to reuse code in sctp_usrreq. Also optimize when we close sending out the data and disabling Nagle. - Change key concatenation order to match the auth RFC - When sending OOTB shutdown_complete always do csum. - Don't send PKT-DROP to a PKT-DROP - For abort chunks just always checksums same for shutdown-complete. - inpcb_free front state had a bug where in queue data could wedge an assoc. We need to just abandon ones in front states (free_assoc). - If a peer sends us a 64k abort, we would try to assemble a response packet which may be larger than 64k. This then would be dropped by IP. Instead make a "minimum" size for us 64k-2k (we want at least 2k for our initack). If we receive such an init discard it early without all the processing. - When we peel off we must increment the tcb ref count to keep it from being freed from underneath us. - handling fwd-tsn had bugs that caused memory overwrites when given faulty data, fixed so can't happen and we also stop at the first bad stream no. - Fixed so comm-up generates the adaption indication. - peeloff did not get the hmac params copied. - fix it so we lock the addr list when doing src-addr selection (in future we need to use a multi-reader/one writer lock here) - During lowlevel output, we could end up with a _l_addr set to null if the iterator is calling the output routine. This means we would possibly crash when we gather the MTU info. Fix so we only do the gather where we have a src address cached. - we need to be sure to set abort flag on conn state when we receive an abort. - peeloff could leak a socket. Moved code so the close will find the socket if the peeloff fails (uipc_syscalls.c) Approved by: re@freebsd.org(Ken Smith) Revision Changes Path 1.259 +5 -8 src/sys/kern/uipc_syscalls.c 1.19 +12 -13 src/sys/netinet/sctp.h 1.26 +158 -13 src/sys/netinet/sctp_asconf.c 1.8 +1 -1 src/sys/netinet/sctp_asconf.h 1.17 +64 -2 src/sys/netinet/sctp_auth.c 1.27 +23 -3 src/sys/netinet/sctp_constants.h 1.41 +85 -83 src/sys/netinet/sctp_indata.c 1.58 +81 -43 src/sys/netinet/sctp_input.c 1.51 +207 -94 src/sys/netinet/sctp_output.c 1.10 +5 -2 src/sys/netinet/sctp_output.h 1.54 +60 -17 src/sys/netinet/sctp_pcb.c 1.29 +2 -0 src/sys/netinet/sctp_pcb.h 1.15 +13 -1 src/sys/netinet/sctp_peeloff.c 1.24 +14 -2 src/sys/netinet/sctp_structs.h 1.14 +12 -0 src/sys/netinet/sctp_sysctl.c 1.10 +23 -3 src/sys/netinet/sctp_sysctl.h 1.26 +4 -0 src/sys/netinet/sctp_uio.h 1.44 +6 -2 src/sys/netinet/sctp_usrreq.c 1.18 +26 -19 src/sys/netinet/sctp_var.h 1.57 +5 -16 src/sys/netinet/sctputil.c 1.38 +25 -196 src/sys/netinet6/sctp6_usrreq.c From owner-cvs-src@FreeBSD.ORG Mon Aug 27 12:50:45 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BAE8D16A469; Mon, 27 Aug 2007 12:50:45 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 2B3D113C442; Mon, 27 Aug 2007 12:50:44 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k2) with ESMTP id 205565251-1834499 for multiple; Mon, 27 Aug 2007 08:50:56 -0400 Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l7RCoWat026083; Mon, 27 Aug 2007 08:50:34 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Warner Losh Date: Mon, 27 Aug 2007 08:50:19 -0400 User-Agent: KMail/1.9.7 References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <20070824.172212.74696955.imp@bsdimp.com> In-Reply-To: <20070824.172212.74696955.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708270850.20904.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]); Mon, 27 Aug 2007 08:50:35 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4071/Sun Aug 26 20:27:44 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, deischen@freebsd.org, cvs-src@freebsd.org, yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 12:50:45 -0000 On Friday 24 August 2007 07:22:12 pm Warner Losh wrote: > What's the overhead of having the transition crutch around for a > while? The benefit is that people are less likely to screw up their > systems at a time when we want to encourage people to upgrade so they > can test the latest/greatest version. If it were 9 months after > RELENG_6 was branched, and a long time to a release, then I'd be much > more inclined to agree with the 'current is hard, so why spend > engineering effort on making it easy' crowd than I would now that more > of the world is watching and using it since we're in the glide path to > beta1. > > I don't see why we can't put the versioned symbols in, let everybody > upgrade and then remove the old symbols after a big enough window has > passed. It isn't like they are hurting anything by being there, is > it? Then why didn't we bump libc multiple times in a branch? It's the same exact thing except more fine-grained. If it's ok to bump symbol versions multiple times (remember, we've already done 1 bump by adding versioning and going to libc.so.7) in a branch, then it should have been ok to bump libc major numbers multiple times. I agree with Dan that we are trying to build releases, and folks running -current are expected to tolerate change during the current branch. I wouldn't expect more users until we actually do release BETA1, so I would go ahead and commit the new fts(3) soon so it is in BETA1 and the RELENG_7 branch when it is branched. > If there is some actual harm here, it hasn't been clearly articulated > and needs to be if that's the case. I'm certainly open to this > possibility. I think it will be confusing to have missing symbols just as folks would have thought it confusing to have 6.x ship with libc.so.8 if we had bumped libc multiple times. I also think that just managing the interfaces that show up in releases and -stable branches will be enough extra bookkeeping to keep track of as it is. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Aug 27 13:38:28 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 758) id 5161F16A418; Mon, 27 Aug 2007 13:38:28 +0000 (UTC) Date: Mon, 27 Aug 2007 13:38:28 +0000 From: Kris Kennaway To: Matteo Riondato Message-ID: <20070827133828.GA70070@hub.freebsd.org> References: <200708250019.l7P0JHxK057929@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200708250019.l7P0JHxK057929@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d mdconfig X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 13:38:28 -0000 On Sat, Aug 25, 2007 at 12:19:17AM +0000, Matteo Riondato wrote: > matteo 2007-08-25 00:19:17 UTC > > FreeBSD src repository > > Modified files: > etc/rc.d mdconfig > Log: > sleep 2 seconds after having loaded g_uzip.ko. We need this because > otherwise the /dev/mdX.uzip won't be created immediately, which is > needed because we issue a mount right afterwards. Wouldn't it be better to loop & retry (with a small sleep) until it appears? "Sleeping N seconds" is a way to just shuffle a race into some other case. Kris From owner-cvs-src@FreeBSD.ORG Mon Aug 27 13:45:35 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8888816A418; Mon, 27 Aug 2007 13:45:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6166A13C467; Mon, 27 Aug 2007 13:45:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7RDjZM0089529; Mon, 27 Aug 2007 13:45:35 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7RDjZ18089528; Mon, 27 Aug 2007 13:45:35 GMT (envelope-from jhb) Message-Id: <200708271345.l7RDjZ18089528@repoman.freebsd.org> From: John Baldwin Date: Mon, 27 Aug 2007 13:45:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/sys sx.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 13:45:35 -0000 jhb 2007-08-27 13:45:35 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/sys sx.h Log: MFC: Add SA_* constants for sx_assert() flags to make it easier to keep drivers in sync between HEAD and 6.x. Revision Changes Path 1.21.2.5 +6 -0 src/sys/sys/sx.h From owner-cvs-src@FreeBSD.ORG Mon Aug 27 13:54:26 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B4ED016A419; Mon, 27 Aug 2007 13:54:26 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 336BE13C474; Mon, 27 Aug 2007 13:54:26 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k2) with ESMTP id 205598048-1834499 for multiple; Mon, 27 Aug 2007 09:54:43 -0400 Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l7RDsH9S027472; Mon, 27 Aug 2007 09:54:24 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Scott Long Date: Mon, 27 Aug 2007 09:27:36 -0400 User-Agent: KMail/1.9.7 References: <200708260235.l7Q2ZoCu077192@repoman.freebsd.org> In-Reply-To: <200708260235.l7Q2ZoCu077192@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708270927.37110.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]); Mon, 27 Aug 2007 09:54:24 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4075/Mon Aug 27 08:49:55 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/mfi mfi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 13:54:26 -0000 On Saturday 25 August 2007 10:35:50 pm Scott Long wrote: > scottl 2007-08-26 02:35:50 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/dev/mfi mfi.c > Log: > Fix the build. Gah, I'll fix sx.h to include compat macros as I know cxgb(4) ran into this as well. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Aug 27 13:54:31 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9786416A56B; Mon, 27 Aug 2007 13:54:31 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id DA5DF13C48D; Mon, 27 Aug 2007 13:54:30 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k2) with ESMTP id 205598062-1834499 for multiple; Mon, 27 Aug 2007 09:54:47 -0400 Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l7RDsH9U027472; Mon, 27 Aug 2007 09:54:27 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: "M. Warner Losh" Date: Mon, 27 Aug 2007 09:33:22 -0400 User-Agent: KMail/1.9.7 References: <20070825.093925.43008968.imp@bsdimp.com> <20070825.155138.-1548240116.imp@bsdimp.com> In-Reply-To: <20070825.155138.-1548240116.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708270933.23751.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]); Mon, 27 Aug 2007 09:54:27 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4075/Mon Aug 27 08:49:55 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, yar@comp.chem.msu.su, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, eischen@vigrid.com, kensmith@cse.buffalo.edu Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 13:54:31 -0000 On Saturday 25 August 2007 05:51:38 pm M. Warner Losh wrote: > In message: > Daniel Eischen writes: > : On Sat, 25 Aug 2007, Ken Smith wrote: > : > : > > : > [ Not bothering to include references for the entire thread, go back and > : > read them if you really want to... ] > : > > : > I want Yar's work to proceed as planned please. My reasons are: > : > : No offense, but some things have been going in without being discussed > : an -arch or -current. Approval for committing still has to go through > : re@, but that doesn't mean that changes shouldn't be vetted elsewhere > : prior to being sent to re@ approval. > > Can you be specific? > > Also, we shouldn't be making it this hard to use versioned symbols. > The last thing we want is for it to be perceived as a fight to get one > into the tree. If that's the perception, then people are less likely > to do the right thing in the future. We should instead embrace the > change, document the right thing to do and use it as a dry-run to work > out the kinks in the process. > > Yar's change fell into a grey area. Reasonable people could differ as > to the time that the ABI became 'official'. Is it with the release? > Or is it when symbol versioning was turned on? Or maybe when the code > freeze happened. Clearly it wasn't before symbol versioning was > enabled, and it can't be after the release. Why not now? Why not let > the RE@ make the call when he reasonably believes the right time is? > We delegated the release process to him and his team so the whole > community doesn't micromanage it to death, introduce changes at a bad > time, etc, etc, etc. Why can't we let him decide the exact boundaries > and make this grey area less grey? It has been the release in the past, never really grey. I could see making it when RELENG_x is branched, but we haven't reached that point either. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Aug 27 13:54:43 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6D0EA16A46B; Mon, 27 Aug 2007 13:54:43 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id E042313C4B0; Mon, 27 Aug 2007 13:54:42 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k2) with ESMTP id 205598055-1834499 for multiple; Mon, 27 Aug 2007 09:54:45 -0400 Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l7RDsH9T027472; Mon, 27 Aug 2007 09:54:25 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Ken Smith Date: Mon, 27 Aug 2007 09:32:29 -0400 User-Agent: KMail/1.9.7 References: <20070824.172212.74696955.imp@bsdimp.com> <1188077596.1853.55.camel@neo.cse.buffalo.edu> In-Reply-To: <1188077596.1853.55.camel@neo.cse.buffalo.edu> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708270932.31208.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]); Mon, 27 Aug 2007 09:54:25 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4075/Mon Aug 27 08:49:55 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, yar@comp.chem.msu.su, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, Daniel Eischen , "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 13:54:43 -0000 On Saturday 25 August 2007 05:33:16 pm Ken Smith wrote: > On Sat, 2007-08-25 at 17:06 -0400, Daniel Eischen wrote: > > On Sat, 25 Aug 2007, Ken Smith wrote: > > > > > > > > [ Not bothering to include references for the entire thread, go back and > > > read them if you really want to... ] > > > > > > I want Yar's work to proceed as planned please. My reasons are: > > > > No offense, but some things have been going in without being discussed > > an -arch or -current. Approval for committing still has to go through > > re@, but that doesn't mean that changes shouldn't be vetted elsewhere > > prior to being sent to re@ approval. > > > > If that's the case then it's been my negligence and I apologize. I'll > try to be more mindful of that moving forward. The issue is that a plethora of symbol versions breaks our prior practice of limiting major bumps of shared libraries to 1 per release. Just as with shared libraries, we version the ABIs in releases and stable branches. We have _never_ versioned ABI changes in HEAD because HEAD is a tumultuous place and having the ABIs change multiple times in a branch w/o having multiple version bumps is just part of running HEAD. It should only affect developers because the vast majority of users are not running HEAD, so they just see 1 version bump and 1 ABI change when the new X.0 release is cut. Yar's changes should go in and before BETA1, but we don't need any compat hacks because the compat would be for users that we don't provide compat for. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Aug 27 13:55:18 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0059516A420; Mon, 27 Aug 2007 13:55:17 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 623D513C45A; Mon, 27 Aug 2007 13:55:17 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k2) with ESMTP id 205598072-1834499 for multiple; Mon, 27 Aug 2007 09:54:52 -0400 Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l7RDsH9V027472; Mon, 27 Aug 2007 09:54:28 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Yar Tikhiy Date: Mon, 27 Aug 2007 09:39:47 -0400 User-Agent: KMail/1.9.7 References: <200708230509.l7N59VCi048341@repoman.freebsd.org> <20070825050637.GF99474@comp.chem.msu.su> In-Reply-To: <20070825050637.GF99474@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708270939.48788.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]); Mon, 27 Aug 2007 09:54:29 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4075/Mon Aug 27 08:49:55 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: src-committers@freebsd.org, Peter Jeremy , Alfred Perlstein , cvs-all@freebsd.org, Daniel Eischen , cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 13:55:18 -0000 On Saturday 25 August 2007 01:06:37 am Yar Tikhiy wrote: > On Fri, Aug 24, 2007 at 06:25:17PM -0400, Daniel Eischen wrote: > > I never added symbol versioning to libc in order to solve > > -current upgrade problems. Sure, you're free to use it that > > way, but it would not make me very happy ;-) > > You put it as though symbol versioning is your area of interest and > you just don't want any intruders to tamper with it. It wouldn't > have seemed so if there had been a well-defined policy on symbol > versioning usage somewhere on www.freebsd.org. No, there isn't a well-defined policy currently, feel free to write it down. :) What Dan is saying is that symbol versioning should follow the same de facto policy used prior to symbol versioning for managing shared library major numbers which is: only bump once during HEAD even if you have multiple ABI changes. Otherwise you can stifle work on HEAD as people will have to provide compat every time they change an ABI in HEAD even if they change it 3 or 4 times before the X.0 release. HEAD only needs to retain compat for earlier RELENG_x, it has never and should not contain compat for older HEAD except as temporary hacks. You also have the issue of adding a lot more compat clutter to the libraries if we support compat for every ABI change that ever happens in HEAD. In this case using a fbsd.hack symbol version for the old fts(3) symbols won't work, the existing binaries are already linked against fbsd-1.0, but the new fts(3) routines should be fbsd-1.0 as fbsd-1.0 is already a version bump from RELENG_6 (libc.so.6 and no symbol versions). -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Aug 27 13:57:39 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 832D816A417; Mon, 27 Aug 2007 13:57:39 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id 880F913C465; Mon, 27 Aug 2007 13:57:38 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id A9A8F456AB; Mon, 27 Aug 2007 15:57:36 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 5EB1545685; Mon, 27 Aug 2007 15:57:31 +0200 (CEST) Date: Mon, 27 Aug 2007 15:56:25 +0200 From: Pawel Jakub Dawidek To: John Baldwin Message-ID: <20070827135625.GF29854@garage.freebsd.pl> References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <20070824.172212.74696955.imp@bsdimp.com> <200708270850.20904.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Q6STzHxy03qt/hK9" Content-Disposition: inline In-Reply-To: <200708270850.20904.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, deischen@freebsd.org, cvs-src@freebsd.org, Warner Losh , yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 13:57:39 -0000 --Q6STzHxy03qt/hK9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 27, 2007 at 08:50:19AM -0400, John Baldwin wrote: > On Friday 24 August 2007 07:22:12 pm Warner Losh wrote: > > What's the overhead of having the transition crutch around for a > > while? The benefit is that people are less likely to screw up their > > systems at a time when we want to encourage people to upgrade so they > > can test the latest/greatest version. If it were 9 months after > > RELENG_6 was branched, and a long time to a release, then I'd be much > > more inclined to agree with the 'current is hard, so why spend > > engineering effort on making it easy' crowd than I would now that more > > of the world is watching and using it since we're in the glide path to > > beta1. > >=20 > > I don't see why we can't put the versioned symbols in, let everybody > > upgrade and then remove the old symbols after a big enough window has > > passed. It isn't like they are hurting anything by being there, is > > it? >=20 > Then why didn't we bump libc multiple times in a branch? It's the same > exact thing except more fine-grained. If it's ok to bump symbol > versions multiple times (remember, we've already done 1 bump by adding > versioning and going to libc.so.7) in a branch, then it should have been > ok to bump libc major numbers multiple times. >=20 > I agree with Dan that we are trying to build releases, and folks running > -current are expected to tolerate change during the current branch. Folks running -current are also committers that use -current to test as much as they can, but also to use it for day-to-day work. Isn't it why we have perforce and other policies, so that -current can be stable and usable? If we have tools that can help -current users to use the system smoothly, I'm all for using them. I can't imagine taking yet another two days and reinstalling all ports, just because -current users are not important. Of course -current users know how to deal with things like this, but that doesn't mean they have to if there is another way. The more surprises like that one, the less -current users we will have, which means the less testing. If there will be a need for me to reinstall all the ports I'll choose not to upgrade or downgrade to 6.x... --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --Q6STzHxy03qt/hK9 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFG0tgJForvXbEpPzQRArPQAJ9SA0/bhD1+XXXYKIW6BRclOgeAnQCgpWhF t6SpM7AIWRNnrWuKfbecO30= =I3B1 -----END PGP SIGNATURE----- --Q6STzHxy03qt/hK9-- From owner-cvs-src@FreeBSD.ORG Mon Aug 27 14:50:28 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 439F216A41A; Mon, 27 Aug 2007 14:50:28 +0000 (UTC) Date: Mon, 27 Aug 2007 14:50:28 +0000 From: Alexey Dokuchaev To: Jeremie Le Hen Message-ID: <20070827145028.GA93736@FreeBSD.org> References: <200708012048.l71KmKjg080201@repoman.freebsd.org> <20070802084423.GA93647@FreeBSD.org> <20070802084755.GA2797@tirith.brixandersen.dk> <20070803152914.GB33159@FreeBSD.org> <20070823215108.GB50852@obiwan.tataz.chchile.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20070823215108.GB50852@obiwan.tataz.chchile.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src UPDATING src/contrib/bind9/bin/named client.c src/contrib/bind9/lib/dns dispatch.c src/contrib/bind9/lib/dns/include/dns dispatch.h src/contrib/tcpdump print-bgp.c src/etc/rc.d jail src/sys/conf newvers.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 14:50:28 -0000 On Thu, Aug 23, 2007 at 11:51:08PM +0200, Jeremie Le Hen wrote: > Hi Alexey, Hello, > > On Fri, Aug 03, 2007 at 03:29:14PM +0000, Alexey Dokuchaev wrote: > > On Thu, Aug 02, 2007 at 10:47:56AM +0200, Henrik Brix Andersen wrote: > > > On Thu, Aug 02, 2007 at 08:44:23AM +0000, Alexey Dokuchaev wrote: > > > > What about RELENG_4, is it going to be fixed, or these bugs are not > > > > applicable to it? It was not quite clear from the SA. > > > > > > RELENG_4 reached EOL on January 31st, 2007. > > > > It is still very popular branch. Given my recent experience with > > RELENG_6, it's still the best one either. :-( > > FWIW, freebsd-eol@FreeBSD.org mailing-list aims to provide a peer to > peer support for branches that reached their EOL. There hasn't been > much traffic for now, but this thread might be a good opportunity to > stir it up a bit :). Thanks, didn't know about that one! ./danfe From owner-cvs-src@FreeBSD.ORG Mon Aug 27 14:46:34 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EC9AE16A417; Mon, 27 Aug 2007 14:46:34 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 7463113C442; Mon, 27 Aug 2007 14:46:34 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (p54A555D1.dip.t-dialin.net [84.165.85.209]) by redbull.bpaserver.net (Postfix) with ESMTP id 6506D2E2B0; Mon, 27 Aug 2007 16:26:59 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 92CE05B4D81; Mon, 27 Aug 2007 16:26:56 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.13.8/8.13.8/Submit) id l7REQt2n012545; Mon, 27 Aug 2007 16:26:55 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Mon, 27 Aug 2007 16:26:55 +0200 Message-ID: <20070827162655.3e3x0cse8w44o4o4@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Mon, 27 Aug 2007 16:26:55 +0200 From: Alexander Leidinger To: Pawel Jakub Dawidek References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <20070824.172212.74696955.imp@bsdimp.com> <200708270850.20904.jhb@freebsd.org> <20070827135625.GF29854@garage.freebsd.pl> In-Reply-To: <20070827135625.GF29854@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.9, required 8, BAYES_00 -15.00, RDNS_DYNAMIC 0.10) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No X-Mailman-Approved-At: Mon, 27 Aug 2007 14:56:49 +0000 Cc: src-committers@FreeBSD.org, John Baldwin , peterjeremy@optushome.com.au, alfred@FreeBSD.org, cvs-all@FreeBSD.org, deischen@FreeBSD.org, cvs-src@FreeBSD.org, yar@comp.chem.msu.su, Warner Losh Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 14:46:35 -0000 Quoting Pawel Jakub Dawidek (from Mon, 27 Aug 2007 =20 15:56:25 +0200): > On Mon, Aug 27, 2007 at 08:50:19AM -0400, John Baldwin wrote: > Folks running -current are also committers that use -current to test as > much as they can, but also to use it for day-to-day work. Isn't it why > we have perforce and other policies, so that -current can be stable and > usable? If we have tools that can help -current users to use the system > smoothly, I'm all for using them. I can't imagine taking yet another two > days and reinstalling all ports, just because -current users are not Only 2 days? Lucky you, I'm just through a complete recompile of every =20 port after the gcc 4.2.1 import (unluckily 4.2.1 doesn't fix all known =20 bugs) just to be on the safe side, and a complete recompile after the =20 gcc 4.2.0 import... and it takes nearly a week on my machine. > important. Of course -current users know how to deal with things like > this, but that doesn't mean they have to if there is another way. > The more surprises like that one, the less -current users we will have, > which means the less testing. > If there will be a need for me to reinstall all the ports I'll choose > not to upgrade or downgrade to 6.x... So the really important thing for you is: How many ports are affected =20 by this change? Does anyone have an estimate for this? If not, does someone has an exhaustive list of affected symbols? I can =20 write a short script which has a look into each installed port to =20 determine if it is affected or not (based upon the assumption that you =20 don't mind if we overlook a few things... I'm not sure if statically =20 linked binaries contain enough information). Bye, Alexander. --=20 The very remembrance of my former misfortune proves a new one to me. =09=09-- Miguel de Cervantes http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 From owner-cvs-src@FreeBSD.ORG Mon Aug 27 15:01:45 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5D86416A418; Mon, 27 Aug 2007 15:01:45 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 050CE13C428; Mon, 27 Aug 2007 15:01:44 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l7REwxWB001729; Mon, 27 Aug 2007 08:58:59 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 27 Aug 2007 08:59:06 -0600 (MDT) Message-Id: <20070827.085906.-332187760.imp@bsdimp.com> To: jhb@freebsd.org From: "M. Warner Losh" In-Reply-To: <200708270932.31208.jhb@freebsd.org> References: <1188077596.1853.55.camel@neo.cse.buffalo.edu> <200708270932.31208.jhb@freebsd.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 27 Aug 2007 08:59:00 -0600 (MDT) Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, yar@comp.chem.msu.su, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, eischen@vigrid.com, kensmith@cse.buffalo.edu Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 15:01:45 -0000 In message: <200708270932.31208.jhb@freebsd.org> John Baldwin writes: : On Saturday 25 August 2007 05:33:16 pm Ken Smith wrote: : > On Sat, 2007-08-25 at 17:06 -0400, Daniel Eischen wrote: : > > On Sat, 25 Aug 2007, Ken Smith wrote: : > > : > > > : > > > [ Not bothering to include references for the entire thread, go back and : > > > read them if you really want to... ] : > > > : > > > I want Yar's work to proceed as planned please. My reasons are: : > > : > > No offense, but some things have been going in without being discussed : > > an -arch or -current. Approval for committing still has to go through : > > re@, but that doesn't mean that changes shouldn't be vetted elsewhere : > > prior to being sent to re@ approval. : > > : > : > If that's the case then it's been my negligence and I apologize. I'll : > try to be more mindful of that moving forward. : : The issue is that a plethora of symbol versions breaks our prior practice : of limiting major bumps of shared libraries to 1 per release. We're not talking plethora here. We're talking a couple. We're not talking every change, but rather just the last one. We're in exactly the same position we'd be in after the release: bumping the symbol version the first time a change is made to that symbol. : Just as with : shared libraries, we version the ABIs in releases and stable branches. : We have _never_ versioned ABI changes in HEAD because HEAD is a tumultuous : place and having the ABIs change multiple times in a branch w/o having : multiple version bumps is just part of running HEAD. We've never versioned ABIs in head because we've never had the ability to do so in a non-disruptive way. Also, this isn't the "wild west" head of our forefathers. We're not at some arbitrary point in the evolution of FreeBSD, but in a code freeze getting ready to do a release. : It should only affect : developers because the vast majority of users are not running HEAD, so they : just see 1 version bump and 1 ABI change when the new X.0 release is cut. More folks than developers are running head these days. Since we're in the glide path to the release, lots of helpful users are testing current towards that end. Since it isn't just developers running current at this stage, because we've asked a lot of people to try current to see if their issues are corrected there, I think we should use those tools that are easy to use to make their life less bumpy. : Yar's changes should go in and before BETA1, but we don't need any compat : hacks because the compat would be for users that we don't provide compat : for. ALL of Yar's changes should go in, including the versioned symbols. Since the consequences of this ABI breakage are trivial to mitigate with symbol versioning, we should do so. We need a dry-run at it to make sure there are no problems in the process. We also should not force all our testers right now to go through significant pain and suffering. They are much less likely to upgrade and continue to test out new versions of current. Rebuilding all the ports (since it is hard to know which ones use fts) is hard and time-consuming (even on my fast machines it takes days to rebuild everything exclusive of ooo). In short, I think this is the easiest solution to the build problems that the change will cause given the set of users that are presently using the head of the tree. Hacking the build system to make the incompatible change is dangerous and may break other upgrade paths that are working. Giving users explicit instructions for jumping the gap would fix the intallworld case, but would still force users to rebuild all their ports. Adding the versioned symbols introduces a tiny bit of cruft in the purity of the ABI, but solves the installworld problem AND the rebuilding the ports problem. Are there other REAL solutions to the problem I've not considered? Warner From owner-cvs-src@FreeBSD.ORG Mon Aug 27 15:18:42 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 89F1216A421; Mon, 27 Aug 2007 15:18:42 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 5201713C45D; Mon, 27 Aug 2007 15:18:42 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by elvis.mu.org (Postfix) with ESMTP id 6F1291A3C1A; Mon, 27 Aug 2007 07:56:18 -0700 (PDT) From: John Baldwin To: Pawel Jakub Dawidek Date: Mon, 27 Aug 2007 10:41:21 -0400 User-Agent: KMail/1.9.7 References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <200708270850.20904.jhb@freebsd.org> <20070827135625.GF29854@garage.freebsd.pl> In-Reply-To: <20070827135625.GF29854@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708271041.23205.jhb@freebsd.org> Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, deischen@freebsd.org, cvs-src@freebsd.org, Warner Losh , yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 15:18:42 -0000 On Monday 27 August 2007 09:56:25 am Pawel Jakub Dawidek wrote: > On Mon, Aug 27, 2007 at 08:50:19AM -0400, John Baldwin wrote: > > On Friday 24 August 2007 07:22:12 pm Warner Losh wrote: > > > What's the overhead of having the transition crutch around for a > > > while? The benefit is that people are less likely to screw up their > > > systems at a time when we want to encourage people to upgrade so they > > > can test the latest/greatest version. If it were 9 months after > > > RELENG_6 was branched, and a long time to a release, then I'd be much > > > more inclined to agree with the 'current is hard, so why spend > > > engineering effort on making it easy' crowd than I would now that more > > > of the world is watching and using it since we're in the glide path to > > > beta1. > > > > > > I don't see why we can't put the versioned symbols in, let everybody > > > upgrade and then remove the old symbols after a big enough window has > > > passed. It isn't like they are hurting anything by being there, is > > > it? > > > > Then why didn't we bump libc multiple times in a branch? It's the same > > exact thing except more fine-grained. If it's ok to bump symbol > > versions multiple times (remember, we've already done 1 bump by adding > > versioning and going to libc.so.7) in a branch, then it should have been > > ok to bump libc major numbers multiple times. > > > > I agree with Dan that we are trying to build releases, and folks running > > -current are expected to tolerate change during the current branch. > > Folks running -current are also committers that use -current to test as > much as they can, but also to use it for day-to-day work. Isn't it why > we have perforce and other policies, so that -current can be stable and > usable? If we have tools that can help -current users to use the system > smoothly, I'm all for using them. I can't imagine taking yet another two > days and reinstalling all ports, just because -current users are not > important. Of course -current users know how to deal with things like > this, but that doesn't mean they have to if there is another way. > The more surprises like that one, the less -current users we will have, > which means the less testing. > If there will be a need for me to reinstall all the ports I'll choose > not to upgrade or downgrade to 6.x... My desktop and server at home run 6.x. Only my laptop and test machines run -current, and of those, only my laptop has a lot of ports and I just rebuild all the ports when I upgrade it over an ABI change. Test boxes for things like mysql, etc. don't necessarily need all of X or KDE, etc. installed, so rebuilding the ports on a test box generally shouldn't have but so much overhead. Perhaps a more useful discussion would be how can we use symbol versioning sanely to support this in the future? The fbsd.hack idea could work, but it doesn't work in this case because the existing binaries are already linked. One suggestion that could start with 8.0 could be this: - when bumping the version for a symbol in HEAD, instead of going from fbsd-X.Y to fbsd-X+1.0, put the new symbol as fbsd-current-X+1.0. You can keep bumping the symbol as fbsd-current-X+1.whatever for subsequent changes - when it's time to branch HEAD to RELENG_X+1, you then add fbsd-X+1.0 symbol versions for the current versions of all the bumped symbols, and remove all the fbsd-current-* versions and compat shims before the release (before the RELENG_X+1_0 branch in fact). The rule there being that no release should ever ship with visible fbsd-current-* symbol versions. You could even proactively drop older fbsd-current-* compat shims in HEAD after having them around for a while. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Aug 27 15:08:39 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8B52716A418; Mon, 27 Aug 2007 15:08:39 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay02.kiev.sovam.com (relay02.kiev.sovam.com [62.64.120.197]) by mx1.freebsd.org (Postfix) with ESMTP id 19B5F13C461; Mon, 27 Aug 2007 15:08:38 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [212.82.216.226] (helo=deviant.kiev.zoral.com.ua) by relay02.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1IPgCa-000FL6-JN; Mon, 27 Aug 2007 18:08:37 +0300 Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1) with ESMTP id l7RF8N6R000216; Mon, 27 Aug 2007 18:08:24 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1/Submit) id l7RF8Nc2000215; Mon, 27 Aug 2007 18:08:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 27 Aug 2007 18:08:23 +0300 From: Kostik Belousov To: Alexander Leidinger Message-ID: <20070827150823.GO2332@deviant.kiev.zoral.com.ua> References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <20070824.172212.74696955.imp@bsdimp.com> <200708270850.20904.jhb@freebsd.org> <20070827135625.GF29854@garage.freebsd.pl> <20070827162655.3e3x0cse8w44o4o4@webmail.leidinger.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ShzQXCswyqjgWi6k" Content-Disposition: inline In-Reply-To: <20070827162655.3e3x0cse8w44o4o4@webmail.leidinger.net> User-Agent: Mutt/1.4.2.3i X-Scanner-Signature: 3b10ce253585130f5293a5b36593fd37 X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Info: Profiles 1409 [August 27 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {received from trusted relay: not dialup} X-SpamTest-Method: none X-SpamTest-Method: Local Lists X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release X-Mailman-Approved-At: Mon, 27 Aug 2007 15:46:15 +0000 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Pawel Jakub Dawidek , John Baldwin , peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, deischen@freebsd.org, yar@comp.chem.msu.su, Warner Losh Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 15:08:39 -0000 --ShzQXCswyqjgWi6k Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 27, 2007 at 04:26:55PM +0200, Alexander Leidinger wrote: > Quoting Pawel Jakub Dawidek (from Mon, 27 Aug 2007 =20 > 15:56:25 +0200): >=20 > >On Mon, Aug 27, 2007 at 08:50:19AM -0400, John Baldwin wrote: >=20 > >Folks running -current are also committers that use -current to test as > >much as they can, but also to use it for day-to-day work. Isn't it why > >we have perforce and other policies, so that -current can be stable and > >usable? If we have tools that can help -current users to use the system > >smoothly, I'm all for using them. I can't imagine taking yet another two > >days and reinstalling all ports, just because -current users are not >=20 > Only 2 days? Lucky you, I'm just through a complete recompile of every = =20 > port after the gcc 4.2.1 import (unluckily 4.2.1 doesn't fix all known = =20 > bugs) just to be on the safe side, and a complete recompile after the =20 > gcc 4.2.0 import... and it takes nearly a week on my machine. >=20 > >important. Of course -current users know how to deal with things like > >this, but that doesn't mean they have to if there is another way. > >The more surprises like that one, the less -current users we will have, > >which means the less testing. > >If there will be a need for me to reinstall all the ports I'll choose > >not to upgrade or downgrade to 6.x... >=20 > So the really important thing for you is: How many ports are affected =20 > by this change? >=20 > Does anyone have an estimate for this? >=20 > If not, does someone has an exhaustive list of affected symbols? I can = =20 > write a short script which has a look into each installed port to =20 > determine if it is affected or not (based upon the assumption that you = =20 > don't mind if we overlook a few things... I'm not sure if statically =20 > linked binaries contain enough information). Statically linked binaries should be not affected. I think that the symbols has names starting with fts_, see fts(3). The proposed script would be very handy, I muttered myself about writing such thing, depending on the outcome on the discussion. Anyway, I mostly keep the RELENG_6-built ports in the chroot and use them, instead of HEAD-built. --ShzQXCswyqjgWi6k Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFG0ujlC3+MBN1Mb4gRAqSTAJ4tkamky5F6g79aPDu8F0EphGtsxwCg7P0T 5xFr++qI7VUC+L0JedqIepI= =VgOi -----END PGP SIGNATURE----- --ShzQXCswyqjgWi6k-- From owner-cvs-src@FreeBSD.ORG Mon Aug 27 15:10:49 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8450816A418; Mon, 27 Aug 2007 15:10:49 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id C8D4113C459; Mon, 27 Aug 2007 15:10:48 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7RFAYDJ070665; Mon, 27 Aug 2007 19:10:34 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7RFAYu9070664; Mon, 27 Aug 2007 19:10:34 +0400 (MSD) (envelope-from yar) Date: Mon, 27 Aug 2007 19:10:34 +0400 From: Yar Tikhiy To: Alexander Leidinger Message-ID: <20070827151033.GM21352@comp.chem.msu.su> References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <20070824.172212.74696955.imp@bsdimp.com> <200708270850.20904.jhb@freebsd.org> <20070827135625.GF29854@garage.freebsd.pl> <20070827162655.3e3x0cse8w44o4o4@webmail.leidinger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070827162655.3e3x0cse8w44o4o4@webmail.leidinger.net> User-Agent: Mutt/1.5.9i X-Mailman-Approved-At: Mon, 27 Aug 2007 15:46:15 +0000 Cc: src-committers@FreeBSD.org, Pawel Jakub Dawidek , John Baldwin , peterjeremy@optushome.com.au, alfred@FreeBSD.org, cvs-all@FreeBSD.org, deischen@FreeBSD.org, cvs-src@FreeBSD.org, Warner Losh Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 15:10:49 -0000 On Mon, Aug 27, 2007 at 04:26:55PM +0200, Alexander Leidinger wrote: > > So the really important thing for you is: How many ports are affected > by this change? > > Does anyone have an estimate for this? > > If not, does someone has an exhaustive list of affected symbols? I can > write a short script which has a look into each installed port to > determine if it is affected or not (based upon the assumption that you > don't mind if we overlook a few things... I'm not sure if statically > linked binaries contain enough information). With the resolution approaching to avoid compatibility in fts(3) now and my experiment on improving src/Makefile.inc1 going on really well, I think I should estimate which ports are going to be affected. I'll do so by searching binary packages for CURRENT, so some ports can slip through my sieve. The symbols to look for match the simple pattern: fts_* (or regexp: ^fts_.*). I don't think there are a lot of ports using those functions. Here's the exact list of symbols to be affected: fts_open fts_close fts_read fts_set fts_children fts_get_clientptr fts_get_stream fts_set_clientptr -- Yar From owner-cvs-src@FreeBSD.ORG Mon Aug 27 16:09:29 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 48AAB16A421; Mon, 27 Aug 2007 16:09:29 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id 82ABC13C478; Mon, 27 Aug 2007 16:09:27 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7RG9HI8072325; Mon, 27 Aug 2007 20:09:17 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7RG9Hu0072324; Mon, 27 Aug 2007 20:09:17 +0400 (MSD) (envelope-from yar) Date: Mon, 27 Aug 2007 20:09:16 +0400 From: Yar Tikhiy To: "M. Warner Losh" Message-ID: <20070827160916.GN21352@comp.chem.msu.su> References: <1188077596.1853.55.camel@neo.cse.buffalo.edu> <200708270932.31208.jhb@freebsd.org> <20070827.085906.-332187760.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070827.085906.-332187760.imp@bsdimp.com> User-Agent: Mutt/1.5.9i Cc: src-committers@freebsd.org, jhb@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, eischen@vigrid.com, kensmith@cse.buffalo.edu Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 16:09:29 -0000 On Mon, Aug 27, 2007 at 08:59:06AM -0600, M. Warner Losh wrote: > In message: <200708270932.31208.jhb@freebsd.org> > John Baldwin writes: > > : Yar's changes should go in and before BETA1, but we don't need any compat > : hacks because the compat would be for users that we don't provide compat > : for. > > ALL of Yar's changes should go in, including the versioned symbols. > Since the consequences of this ABI breakage are trivial to mitigate > with symbol versioning, we should do so. We need a dry-run at it to > make sure there are no problems in the process. We also should not > force all our testers right now to go through significant pain and > suffering. They are much less likely to upgrade and continue to test > out new versions of current. Rebuilding all the ports (since it is > hard to know which ones use fts) is hard and time-consuming (even on > my fast machines it takes days to rebuild everything exclusive of > ooo). Although I can appreciate the arguments of Daniel and John now, [thank you John! :-)], this is also a very valid point to consider. I hate to mention it, but symbol versioning appeared literally non-functional due to a bug in the map-generating script when I tried to use it for the first time in the course of the fts(3) hustle. > In short, I think this is the easiest solution to the build problems > that the change will cause given the set of users that are presently > using the head of the tree. Hacking the build system to make the > incompatible change is dangerous and may break other upgrade paths > that are working. Giving users explicit instructions for jumping the > gap would fix the intallworld case, but would still force users to > rebuild all their ports. Adding the versioned symbols introduces a > tiny bit of cruft in the purity of the ABI, but solves the > installworld problem AND the rebuilding the ports problem. Are there > other REAL solutions to the problem I've not considered? I hope I've found a clean way to overcome the problem in our build system. The problem stemmed from using basic tools from the old, pre-installworld system during installworld. The tools were copied just in case to a scratch directory, so it isn't hard to install the newly built versions of the same tools there instead and make them load the new shared libraries available under ${WORLDTMP}. The trick depends on the running kernel being able to run both old and new code, but it's a well-known requirement for installworld over the live system. I'm going to post the patch for review soon. -- Yar From owner-cvs-src@FreeBSD.ORG Mon Aug 27 16:10:05 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 62A4C16A418; Mon, 27 Aug 2007 16:10:05 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id BAEC313C461; Mon, 27 Aug 2007 16:10:04 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7RGA3nP072372; Mon, 27 Aug 2007 20:10:03 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7RGA2FV072371; Mon, 27 Aug 2007 20:10:02 +0400 (MSD) (envelope-from yar) Date: Mon, 27 Aug 2007 20:10:02 +0400 From: Yar Tikhiy To: John Baldwin Message-ID: <20070827161002.GO21352@comp.chem.msu.su> References: <200708230509.l7N59VCi048341@repoman.freebsd.org> <20070825050637.GF99474@comp.chem.msu.su> <200708270939.48788.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200708270939.48788.jhb@freebsd.org> User-Agent: Mutt/1.5.9i Cc: src-committers@freebsd.org, Peter Jeremy , Alfred Perlstein , cvs-all@freebsd.org, Daniel Eischen , cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 16:10:05 -0000 On Mon, Aug 27, 2007 at 09:39:47AM -0400, John Baldwin wrote: > On Saturday 25 August 2007 01:06:37 am Yar Tikhiy wrote: > > On Fri, Aug 24, 2007 at 06:25:17PM -0400, Daniel Eischen wrote: > > > I never added symbol versioning to libc in order to solve > > > -current upgrade problems. Sure, you're free to use it that > > > way, but it would not make me very happy ;-) > > > > You put it as though symbol versioning is your area of interest and > > you just don't want any intruders to tamper with it. It wouldn't > > have seemed so if there had been a well-defined policy on symbol > > versioning usage somewhere on www.freebsd.org. > > No, there isn't a well-defined policy currently, feel free to write it > down. :) I think I'll write it down when this issue has been settled and I have enough input data. I like writing docs as I have rather poor long-term memory and often consult my own texts. :-) -- Yar From owner-cvs-src@FreeBSD.ORG Mon Aug 27 16:56:29 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4A4B216A419; Mon, 27 Aug 2007 16:56:29 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 22A1013C459; Mon, 27 Aug 2007 16:56:29 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7RGuTg3023822; Mon, 27 Aug 2007 16:56:29 GMT (envelope-from jkim@repoman.freebsd.org) Received: (from jkim@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7RGuS3G023821; Mon, 27 Aug 2007 16:56:28 GMT (envelope-from jkim) Message-Id: <200708271656.l7RGuS3G023821@repoman.freebsd.org> From: Jung-uk Kim Date: Mon, 27 Aug 2007 16:56:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/isp isp_freebsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 16:56:29 -0000 jkim 2007-08-27 16:56:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/isp isp_freebsd.c Log: MFC: 1.146 Export 4Gbps Fibre Channel link speed correctly with inquiry commands. Revision Changes Path 1.105.2.11 +8 -9 src/sys/dev/isp/isp_freebsd.c From owner-cvs-src@FreeBSD.ORG Mon Aug 27 17:10:32 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3074716A421; Mon, 27 Aug 2007 17:10:32 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id C434413C48E; Mon, 27 Aug 2007 17:10:31 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7RHAFDT025447; Mon, 27 Aug 2007 13:10:15 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Mon, 27 Aug 2007 13:10:15 -0400 (EDT) Date: Mon, 27 Aug 2007 13:10:14 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: John Baldwin In-Reply-To: <200708271041.23205.jhb@freebsd.org> Message-ID: References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <200708270850.20904.jhb@freebsd.org> <20070827135625.GF29854@garage.freebsd.pl> <200708271041.23205.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, Pawel Jakub Dawidek , peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, Warner Losh , yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 17:10:32 -0000 On Mon, 27 Aug 2007, John Baldwin wrote: > > Perhaps a more useful discussion would be how can we use symbol versioning > sanely to support this in the future? The fbsd.hack idea could work, but > it doesn't work in this case because the existing binaries are already > linked. One suggestion that could start with 8.0 could be this: > > - when bumping the version for a symbol in HEAD, instead of going from > fbsd-X.Y to fbsd-X+1.0, put the new symbol as fbsd-current-X+1.0. You > can keep bumping the symbol as fbsd-current-X+1.whatever for subsequent > changes > - when it's time to branch HEAD to RELENG_X+1, you then add fbsd-X+1.0 > symbol versions for the current versions of all the bumped symbols, and > remove all the fbsd-current-* versions and compat shims before the > release (before the RELENG_X+1_0 branch in fact). The rule there being > that no release should ever ship with visible fbsd-current-* symbol > versions. I don't think you need intermediate symbol versions, one should be sufficient. The problem would only arise if you make an ABI change to a function or set of functions that have already had an ABI change in the current version. For example, if there were a function ftsfwrite(FTS, FILE *, ...), and you make the version bump from FBSD_1.0 to FBSD_1.1 when FTS changes, then if FILE changes, you need to bump FBSD_1.1 to FBSD_1.2. If there are no overlapping changes in the ABI, you can continue to add newly changed symbols to the current version (in this case FBSD_1.1). How may times have we ever had overlapping ABI changes in the past? Have we ever? It's not worth fiddling with intermediate symbols, because with that method you're still forcing -current users to rebuild everything just before or after RELEASE to get the final symbols (when the intermediates are removed). If there are no overlapping ABI changes, then no one has to rebuild any ports. -- DE From owner-cvs-src@FreeBSD.ORG Mon Aug 27 17:11:53 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C489316A419; Mon, 27 Aug 2007 17:11:53 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 7BD4813C474; Mon, 27 Aug 2007 17:11:53 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7RHBjt3026707; Mon, 27 Aug 2007 13:11:45 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Mon, 27 Aug 2007 13:11:45 -0400 (EDT) Date: Mon, 27 Aug 2007 13:11:45 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Yar Tikhiy In-Reply-To: <20070827161002.GO21352@comp.chem.msu.su> Message-ID: References: <200708230509.l7N59VCi048341@repoman.freebsd.org> <20070825050637.GF99474@comp.chem.msu.su> <200708270939.48788.jhb@freebsd.org> <20070827161002.GO21352@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, John Baldwin , Peter Jeremy , Alfred Perlstein , cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 17:11:53 -0000 On Mon, 27 Aug 2007, Yar Tikhiy wrote: > On Mon, Aug 27, 2007 at 09:39:47AM -0400, John Baldwin wrote: >> On Saturday 25 August 2007 01:06:37 am Yar Tikhiy wrote: >>> On Fri, Aug 24, 2007 at 06:25:17PM -0400, Daniel Eischen wrote: >>>> I never added symbol versioning to libc in order to solve >>>> -current upgrade problems. Sure, you're free to use it that >>>> way, but it would not make me very happy ;-) >>> >>> You put it as though symbol versioning is your area of interest and >>> you just don't want any intruders to tamper with it. It wouldn't >>> have seemed so if there had been a well-defined policy on symbol >>> versioning usage somewhere on www.freebsd.org. >> >> No, there isn't a well-defined policy currently, feel free to write it >> down. :) > > I think I'll write it down when this issue has been settled and I have > enough input data. I like writing docs as I have rather poor long-term > memory and often consult my own texts. :-) I started a thread on -current for this with a link to my thoughts. -- DE From owner-cvs-src@FreeBSD.ORG Mon Aug 27 17:23:42 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6143316A417; Mon, 27 Aug 2007 17:23:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 39C3913C45D; Mon, 27 Aug 2007 17:23:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7RHNgJu026757; Mon, 27 Aug 2007 17:23:42 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7RHNg7e026756; Mon, 27 Aug 2007 17:23:42 GMT (envelope-from jhb) Message-Id: <200708271723.l7RHNg7e026756@repoman.freebsd.org> From: John Baldwin Date: Mon, 27 Aug 2007 17:23:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/gnu/usr.bin/gdb/kgdb trgt_amd64.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 17:23:42 -0000 jhb 2007-08-27 17:23:41 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) gnu/usr.bin/gdb/kgdb trgt_amd64.c Log: MFC: Treat the frame under 'nmi_calltrap' as a trapframe. Revision Changes Path 1.2.2.4 +1 -0 src/gnu/usr.bin/gdb/kgdb/trgt_amd64.c From owner-cvs-src@FreeBSD.ORG Mon Aug 27 17:36:28 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4F55616A417; Mon, 27 Aug 2007 17:36:28 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id A702E13C483; Mon, 27 Aug 2007 17:36:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k2) with ESMTP id 205636794-1834499 for multiple; Mon, 27 Aug 2007 13:36:33 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l7RHaBsF028954; Mon, 27 Aug 2007 13:36:12 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Daniel Eischen Date: Mon, 27 Aug 2007 13:21:06 -0400 User-Agent: KMail/1.9.6 References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <200708271041.23205.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708271321.08014.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 27 Aug 2007 13:36:12 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4076/Mon Aug 27 10:15:54 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: src-committers@freebsd.org, Pawel Jakub Dawidek , peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, Warner Losh , yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 17:36:28 -0000 On Monday 27 August 2007 01:10:14 pm Daniel Eischen wrote: > On Mon, 27 Aug 2007, John Baldwin wrote: > > > > Perhaps a more useful discussion would be how can we use symbol versioning > > sanely to support this in the future? The fbsd.hack idea could work, but > > it doesn't work in this case because the existing binaries are already > > linked. One suggestion that could start with 8.0 could be this: > > > > - when bumping the version for a symbol in HEAD, instead of going from > > fbsd-X.Y to fbsd-X+1.0, put the new symbol as fbsd-current-X+1.0. You > > can keep bumping the symbol as fbsd-current-X+1.whatever for subsequent > > changes > > - when it's time to branch HEAD to RELENG_X+1, you then add fbsd-X+1.0 > > symbol versions for the current versions of all the bumped symbols, and > > remove all the fbsd-current-* versions and compat shims before the > > release (before the RELENG_X+1_0 branch in fact). The rule there being > > that no release should ever ship with visible fbsd-current-* symbol > > versions. > > I don't think you need intermediate symbol versions, one should be > sufficient. The problem would only arise if you make an ABI change > to a function or set of functions that have already had an ABI change > in the current version. For example, if there were a function > ftsfwrite(FTS, FILE *, ...), and you make the version bump from > FBSD_1.0 to FBSD_1.1 when FTS changes, then if FILE changes, you > need to bump FBSD_1.1 to FBSD_1.2. If there are no overlapping > changes in the ABI, you can continue to add newly changed symbols > to the current version (in this case FBSD_1.1). Actually, what we have now with fts(3) is exactly this: two versions of the symbols that wish to be called fbsd_1.0. By using a late binding of the "official" fbsd_X.0 version we can avoid that. It also provides a way to delineate ABI changes that aren't visible to releases and -stable branches. They will exist in HEAD with only having a fbsd-current symbol, so they can be axed from HEAD safely. > How may times have we ever had overlapping ABI changes in the past? > Have we ever? It's not worth fiddling with intermediate symbols, > because with that method you're still forcing -current users to > rebuild everything just before or after RELEASE to get the final > symbols (when the intermediates are removed). If there are no > overlapping ABI changes, then no one has to rebuild any ports. You don't have to remove the compat shims from HEAD right away. Remember, release is on a _branch_: RELENG_X. You remove the compat shims from the branch before the release, but you can use discretion as to when you actually remove them from HEAD. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Aug 27 17:46:51 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 69DDB16A418; Mon, 27 Aug 2007 17:46:51 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 220F513C494; Mon, 27 Aug 2007 17:46:50 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7RHkVlc023550; Mon, 27 Aug 2007 13:46:31 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Mon, 27 Aug 2007 13:46:31 -0400 (EDT) Date: Mon, 27 Aug 2007 13:46:31 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: "M. Warner Losh" In-Reply-To: <20070827.085906.-332187760.imp@bsdimp.com> Message-ID: References: <1188077596.1853.55.camel@neo.cse.buffalo.edu> <200708270932.31208.jhb@freebsd.org> <20070827.085906.-332187760.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, jhb@freebsd.org, yar@comp.chem.msu.su, alfred@freebsd.org, peterjeremy@optushome.com.au, cvs-all@freebsd.org, cvs-src@freebsd.org, kensmith@cse.buffalo.edu Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 17:46:51 -0000 On Mon, 27 Aug 2007, M. Warner Losh wrote: > In message: <200708270932.31208.jhb@freebsd.org> > John Baldwin writes: > > : Just as with > : shared libraries, we version the ABIs in releases and stable branches. > : We have _never_ versioned ABI changes in HEAD because HEAD is a tumultuous > : place and having the ABIs change multiple times in a branch w/o having > : multiple version bumps is just part of running HEAD. > > We've never versioned ABIs in head because we've never had the ability > to do so in a non-disruptive way. Also, this isn't the "wild west" > head of our forefathers. We're not at some arbitrary point in the > evolution of FreeBSD, but in a code freeze getting ready to do a release. And the fact that we're in a code freeze should prohibit changes like this from going in. The rule has been that we only bump libraries once between releases. The same thing will hold true for versions; they'll only be bumped at most once between releases, and in fact will probably be bumped _much_ less often that libraries. There is no overwhelming reason to break the rules that we've held in the past. It's easy to say, "but it's less painful", but after you've gone through it, you're done. I think we're taking a very short-sighted view of things and don't agree with breaking or bending the rules without a _very_ good reason. -- DE From owner-cvs-src@FreeBSD.ORG Mon Aug 27 18:13:39 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ECE3016A420; Mon, 27 Aug 2007 18:13:38 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id ABC0E13C46C; Mon, 27 Aug 2007 18:13:38 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l7RIAToT003217; Mon, 27 Aug 2007 12:10:29 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 27 Aug 2007 12:10:33 -0600 (MDT) Message-Id: <20070827.121033.1102529566.imp@bsdimp.com> To: deischen@freebsd.org From: "M. Warner Losh" In-Reply-To: References: <200708270932.31208.jhb@freebsd.org> <20070827.085906.-332187760.imp@bsdimp.com> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 27 Aug 2007 12:10:30 -0600 (MDT) Cc: src-committers@freebsd.org, jhb@freebsd.org, yar@comp.chem.msu.su, alfred@freebsd.org, peterjeremy@optushome.com.au, cvs-all@freebsd.org, cvs-src@freebsd.org, kensmith@cse.buffalo.edu Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 18:13:39 -0000 In message: Daniel Eischen writes: : On Mon, 27 Aug 2007, M. Warner Losh wrote: : : > In message: <200708270932.31208.jhb@freebsd.org> : > John Baldwin writes: : > : > : Just as with : > : shared libraries, we version the ABIs in releases and stable branches. : > : We have _never_ versioned ABI changes in HEAD because HEAD is a tumultuous : > : place and having the ABIs change multiple times in a branch w/o having : > : multiple version bumps is just part of running HEAD. : > : > We've never versioned ABIs in head because we've never had the ability : > to do so in a non-disruptive way. Also, this isn't the "wild west" : > head of our forefathers. We're not at some arbitrary point in the : > evolution of FreeBSD, but in a code freeze getting ready to do a release. : : And the fact that we're in a code freeze should prohibit changes : like this from going in. But the rules have changed with symbol versioning. They give us the ability to do things we've never done before. They are a powerful tool that can be used to make current a less bumpy place, and that potential shouldn't be dismissed out of hand because we've never done that before. The reason we've never done it before is that we didn't have the tools to make it easy to do it before. : The rule has been that we only bump libraries once between releases. : The same thing will hold true for versions; they'll only be bumped : at most once between releases, and in fact will probably be bumped : _much_ less often that libraries. Libraries with version symbols should never be bumped again, unless there is a real binary compat issue. Typically, I'd guess that we'd need to bump versions of symbols only every couple of releases. FreeBSD only recently started bumping all the shared libraries major number as a precaution because we couldn't maintain binary compatibility. Symbol versions will give us tools to help with that, but we do still need to be careful. : There is no overwhelming reason to break the rules that we've held : in the past. It's easy to say, "but it's less painful", but after : you've gone through it, you're done. I think we're taking a very : short-sighted view of things and don't agree with breaking or bending : the rules without a _very_ good reason. I think the reasons have been well presented so far. However, there's a way we can cope without having to break the world or our rules. BTW, we never agreed what to do about symbol versions in current, so there's really no rules to break. Consensus never was reached on what to do there, although you keep asserting that we can only bump them once, but that has never been agreed to and codified. There is strong agreement that we only have user visible changes once per release, but a divergence of views on what to do in current. However, there's a strong desire to use it to make -current a less bumpy place. This thread is clear evidence of that. However, there's a forth option that I'd not considered. It goes like so. Thanks to John Baldwin, Brooks Davis, Ken Smith and kan for hammering out the details on IRC. This is just a proposal, but we think a good one that will solve the problems. FBSD-1.0 is the 'current' branch. We put the new fts symbols in as FBSD-1.1. If there are other things that require binary bumps between now and "the release" we do the same for them. chances are good there won't be any, but you never know when a security issue will come up that needs to do a ABI change. This will give us both a dry-run for having multiple versions of symbols, as well as practical experience for how to make -current less bumpy in the future. Somewhere around RC1, we change all the symbols to be FBSD-7.0. There's no reason why we have to start at 1.0, and the disconnect between major release and ABI version seems artificial to me. Changing all the symbols near RC1 time would give all the ports builders a chance to shake out that process. Portmgr has stated that they want an RC1 from re@ about a month before the final release so they can do all the builds and work out whatever issues come up. It would give people a good point where packages are available to cope with the requirement to rebuild everything. It would also let us remove the compat hacks after the release in HEAD and before the release in RELENG_7. We can also keep the FBSD-1.x symbols around long enough for people to do the upgrades. I put "the release" in quotes because the release engineer gets to make the call when he wants to finally freeze things for the release. If that's RC1 great. If that's BETA1, great. If it is later, that's good too. We should allow him to make the call on the timing, since he has to coordinate the release with a lot of different people. Warner From owner-cvs-src@FreeBSD.ORG Mon Aug 27 18:39:45 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C8FDC16A419; Mon, 27 Aug 2007 18:39:45 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 93CD413C4D9; Mon, 27 Aug 2007 18:39:45 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7RIdQc9006407; Mon, 27 Aug 2007 14:39:26 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Mon, 27 Aug 2007 14:39:27 -0400 (EDT) Date: Mon, 27 Aug 2007 14:39:26 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: "M. Warner Losh" In-Reply-To: <20070827.121033.1102529566.imp@bsdimp.com> Message-ID: References: <200708270932.31208.jhb@freebsd.org> <20070827.085906.-332187760.imp@bsdimp.com> <20070827.121033.1102529566.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, jhb@freebsd.org, yar@comp.chem.msu.su, alfred@freebsd.org, peterjeremy@optushome.com.au, cvs-all@freebsd.org, cvs-src@freebsd.org, kensmith@cse.buffalo.edu Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 18:39:45 -0000 On Mon, 27 Aug 2007, M. Warner Losh wrote: > In message: > Daniel Eischen writes: > > : The rule has been that we only bump libraries once between releases. > : The same thing will hold true for versions; they'll only be bumped > : at most once between releases, and in fact will probably be bumped > : _much_ less often that libraries. > > Libraries with version symbols should never be bumped again, unless > there is a real binary compat issue. I was talking about the _symbol_ versions being bumped in the latter part of that, not the _library_ version. When I said "less often than libraries", I meant before symbol versioning. I agree that after symbol versioning we ought not to be bumping library versions. > Typically, I'd guess that we'd > need to bump versions of symbols only every couple of releases. > FreeBSD only recently started bumping all the shared libraries major > number as a precaution because we couldn't maintain binary > compatibility. Symbol versions will give us tools to help with that, > but we do still need to be careful. You only need to bump symbol versions once when the first ABI change occurs, and after that, only again when an ABI from the second version changes. There's no need to bump for the sake of bumping, and it doesn't really buy us anything except confusing us with more version namespaces. I think we need to separate the version namespace from releases, with the caveat we only care about the symbols that we export from a release, not intermediate steps. If we want a way to list the symbols from a release, we can do that with other tools or autogenerate a file that is committed everytime we add symbols to a version. Having versions tied to releases will just make it harder for us to maintain, especially when you think about maintaining 2 or 3 branches at once (RELENG_7, RELENG_8, and RELENG_9). > : There is no overwhelming reason to break the rules that we've held > : in the past. It's easy to say, "but it's less painful", but after > : you've gone through it, you're done. I think we're taking a very > : short-sighted view of things and don't agree with breaking or bending > : the rules without a _very_ good reason. > > I think the reasons have been well presented so far. However, there's > a way we can cope without having to break the world or our rules. > BTW, we never agreed what to do about symbol versions in current, so > there's really no rules to break. Consensus never was reached on what > to do there, although you keep asserting that we can only bump them > once, but that has never been agreed to and codified. There is strong > agreement that we only have user visible changes once per release, but > a divergence of views on what to do in current. However, there's a > strong desire to use it to make -current a less bumpy place. This > thread is clear evidence of that. > > However, there's a forth option that I'd not considered. It goes like > so. Thanks to John Baldwin, Brooks Davis, Ken Smith and kan for > hammering out the details on IRC. This is just a proposal, but we > think a good one that will solve the problems. > > FBSD-1.0 is the 'current' branch. We put the new fts symbols in as > FBSD-1.1. If there are other things that require binary bumps between > now and "the release" we do the same for them. chances are good there > won't be any, but you never know when a security issue will come up > that needs to do a ABI change. This will give us both a dry-run for > having multiple versions of symbols, as well as practical experience > for how to make -current less bumpy in the future. > > Somewhere around RC1, we change all the symbols to be FBSD-7.0. I have to disagree pretty heavily here. Symbols shouldn't be tied to a release. Especially when you start to backport changes to previous branches. When you backport changes to previous branches, now you are going to have FBSD_8.0 symbols in FBSD_7.0. Thinking about the symbol namespace this way isn't what you want, and if you think off in to the future, you'll see that you'll start having the same set of functions (with same ABI) appearing in multiple versions. It is much easier to change the ABI version once when the first ABI change occurs, and only ever change it again when an ABI from the current (ABI) version changes. -- DE From owner-cvs-src@FreeBSD.ORG Mon Aug 27 19:00:01 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9C53316A41B; Mon, 27 Aug 2007 19:00:01 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 8119013C48A; Mon, 27 Aug 2007 19:00:01 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 261131A4D94; Mon, 27 Aug 2007 11:57:41 -0700 (PDT) Date: Mon, 27 Aug 2007 11:57:41 -0700 From: Alfred Perlstein To: "M. Warner Losh" Message-ID: <20070827185741.GX87451@elvis.mu.org> References: <1188077596.1853.55.camel@neo.cse.buffalo.edu> <200708270932.31208.jhb@freebsd.org> <20070827.085906.-332187760.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070827.085906.-332187760.imp@bsdimp.com> User-Agent: Mutt/1.4.2.3i Cc: src-committers@freebsd.org, jhb@freebsd.org, peterjeremy@optushome.com.au, yar@comp.chem.msu.su, eischen@vigrid.com, cvs-all@freebsd.org, cvs-src@freebsd.org, kensmith@cse.buffalo.edu Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 19:00:01 -0000 Sorry for top posting, but... I agree very strongly with Warner, in short, if possible, reducing the number of major gotchas of running current will make our developer and early adopters a lot happier. It will help FreeBSD. One of the things that turns me off to FreeBSD is the feeling that I get that certain people take some kind of pride in forcing users to go through dangerous and complex hoops in order to run current. It shouldn't be so if the overhead of making it easier is so small. -Alfred * M. Warner Losh [070827 07:59] wrote: > In message: <200708270932.31208.jhb@freebsd.org> > John Baldwin writes: > : On Saturday 25 August 2007 05:33:16 pm Ken Smith wrote: > : > On Sat, 2007-08-25 at 17:06 -0400, Daniel Eischen wrote: > : > > On Sat, 25 Aug 2007, Ken Smith wrote: > : > > > : > > > > : > > > [ Not bothering to include references for the entire thread, go back and > : > > > read them if you really want to... ] > : > > > > : > > > I want Yar's work to proceed as planned please. My reasons are: > : > > > : > > No offense, but some things have been going in without being discussed > : > > an -arch or -current. Approval for committing still has to go through > : > > re@, but that doesn't mean that changes shouldn't be vetted elsewhere > : > > prior to being sent to re@ approval. > : > > > : > > : > If that's the case then it's been my negligence and I apologize. I'll > : > try to be more mindful of that moving forward. > : > : The issue is that a plethora of symbol versions breaks our prior practice > : of limiting major bumps of shared libraries to 1 per release. > > We're not talking plethora here. We're talking a couple. We're not > talking every change, but rather just the last one. We're in exactly > the same position we'd be in after the release: bumping the symbol > version the first time a change is made to that symbol. > > : Just as with > : shared libraries, we version the ABIs in releases and stable branches. > : We have _never_ versioned ABI changes in HEAD because HEAD is a tumultuous > : place and having the ABIs change multiple times in a branch w/o having > : multiple version bumps is just part of running HEAD. > > We've never versioned ABIs in head because we've never had the ability > to do so in a non-disruptive way. Also, this isn't the "wild west" > head of our forefathers. We're not at some arbitrary point in the > evolution of FreeBSD, but in a code freeze getting ready to do a release. > > : It should only affect > : developers because the vast majority of users are not running HEAD, so they > : just see 1 version bump and 1 ABI change when the new X.0 release is cut. > > More folks than developers are running head these days. Since we're > in the glide path to the release, lots of helpful users are testing > current towards that end. Since it isn't just developers running > current at this stage, because we've asked a lot of people to try > current to see if their issues are corrected there, I think we should > use those tools that are easy to use to make their life less bumpy. > > : Yar's changes should go in and before BETA1, but we don't need any compat > : hacks because the compat would be for users that we don't provide compat > : for. > > ALL of Yar's changes should go in, including the versioned symbols. > Since the consequences of this ABI breakage are trivial to mitigate > with symbol versioning, we should do so. We need a dry-run at it to > make sure there are no problems in the process. We also should not > force all our testers right now to go through significant pain and > suffering. They are much less likely to upgrade and continue to test > out new versions of current. Rebuilding all the ports (since it is > hard to know which ones use fts) is hard and time-consuming (even on > my fast machines it takes days to rebuild everything exclusive of > ooo). > > In short, I think this is the easiest solution to the build problems > that the change will cause given the set of users that are presently > using the head of the tree. Hacking the build system to make the > incompatible change is dangerous and may break other upgrade paths > that are working. Giving users explicit instructions for jumping the > gap would fix the intallworld case, but would still force users to > rebuild all their ports. Adding the versioned symbols introduces a > tiny bit of cruft in the purity of the ABI, but solves the > installworld problem AND the rebuilding the ports problem. Are there > other REAL solutions to the problem I've not considered? > > Warner -- - Alfred Perlstein From owner-cvs-src@FreeBSD.ORG Mon Aug 27 19:03:20 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 76D7216A46D; Mon, 27 Aug 2007 19:03:20 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 5D1EB13C4A6; Mon, 27 Aug 2007 19:03:20 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 1BD6B1A4D89; Mon, 27 Aug 2007 12:01:00 -0700 (PDT) Date: Mon, 27 Aug 2007 12:01:00 -0700 From: Alfred Perlstein To: John Baldwin Message-ID: <20070827190100.GY87451@elvis.mu.org> References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <20070824.172212.74696955.imp@bsdimp.com> <200708270850.20904.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200708270850.20904.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, cvs-all@freebsd.org, deischen@freebsd.org, cvs-src@freebsd.org, Warner Losh , yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 19:03:20 -0000 * John Baldwin [070827 05:48] wrote: > > I think it will be confusing to have missing symbols just as folks would > have thought it confusing to have 6.x ship with libc.so.8 if we had > bumped libc multiple times. I also think that just managing the > interfaces that show up in releases and -stable branches will be enough > extra bookkeeping to keep track of as it is. This is something I just don't understand, why is some psuedo-arbitrary number somehow MORE confusing/damaging than some convoluted upgrade path? The only negative (which is bs) of doing so is keeping around multiple compat libraries for the same release, which we can simply decide not to do. (meaning, for your example there does not need to be a libc.so.7 shipped in some compat package unless someone really wants to) -Alfred From owner-cvs-src@FreeBSD.ORG Mon Aug 27 19:40:00 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5D1E616A419; Mon, 27 Aug 2007 19:40:00 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id BE0FC13C457; Mon, 27 Aug 2007 19:39:59 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k2) with ESMTP id 205656361-1834499 for multiple; Mon, 27 Aug 2007 15:40:15 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l7RJdr71029715; Mon, 27 Aug 2007 15:39:54 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Alfred Perlstein Date: Mon, 27 Aug 2007 15:29:41 -0400 User-Agent: KMail/1.9.6 References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <200708270850.20904.jhb@freebsd.org> <20070827190100.GY87451@elvis.mu.org> In-Reply-To: <20070827190100.GY87451@elvis.mu.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708271529.42264.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 27 Aug 2007 15:39:54 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4077/Mon Aug 27 14:40:44 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, cvs-all@freebsd.org, deischen@freebsd.org, cvs-src@freebsd.org, Warner Losh , yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 19:40:00 -0000 On Monday 27 August 2007 03:01:00 pm Alfred Perlstein wrote: > * John Baldwin [070827 05:48] wrote: > > > > I think it will be confusing to have missing symbols just as folks would > > have thought it confusing to have 6.x ship with libc.so.8 if we had > > bumped libc multiple times. I also think that just managing the > > interfaces that show up in releases and -stable branches will be enough > > extra bookkeeping to keep track of as it is. > > This is something I just don't understand, why is some psuedo-arbitrary > number somehow MORE confusing/damaging than some convoluted upgrade > path? > > The only negative (which is bs) of doing so is keeping around multiple > compat libraries for the same release, which we can simply decide not > to do. > > (meaning, for your example there does not need to be a libc.so.7 > shipped in some compat package unless someone really wants to) User questions. "I just upgraded via make world from 6.x to 7.0 and now I have a libc.so.6 and a libc.so.8, what happened to libc.so.7, did something go wrong??? please help!!!!" etc. And yes, I do think it's ok for -current to have rougher edges. After all, we aren't really trying to get people running -current on production systems. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Aug 27 19:40:06 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2A75316A473; Mon, 27 Aug 2007 19:40:06 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 9C19613C467; Mon, 27 Aug 2007 19:40:05 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k2) with ESMTP id 205656368-1834499 for multiple; Mon, 27 Aug 2007 15:40:21 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l7RJdr72029715; Mon, 27 Aug 2007 15:39:55 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Alfred Perlstein Date: Mon, 27 Aug 2007 15:30:44 -0400 User-Agent: KMail/1.9.6 References: <20070827.085906.-332187760.imp@bsdimp.com> <20070827185741.GX87451@elvis.mu.org> In-Reply-To: <20070827185741.GX87451@elvis.mu.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708271530.45290.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 27 Aug 2007 15:39:56 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4077/Mon Aug 27 14:40:44 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, yar@comp.chem.msu.su, eischen@vigrid.com, cvs-all@freebsd.org, cvs-src@freebsd.org, kensmith@cse.buffalo.edu, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 19:40:06 -0000 On Monday 27 August 2007 02:57:41 pm Alfred Perlstein wrote: > Sorry for top posting, but... > > I agree very strongly with Warner, in short, if possible, reducing the > number of major gotchas of running current will make our developer > and early adopters a lot happier. > > It will help FreeBSD. > > One of the things that turns me off to FreeBSD is the feeling that > I get that certain people take some kind of pride in forcing users > to go through dangerous and complex hoops in order to run current. > > It shouldn't be so if the overhead of making it easier is so small. It has zero to do with pride, but it does have a lot to do with allowing HEAD to be a branch for development as opposed to the stable branches that are more intended with deployment. Those are quite different feature sets. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Aug 27 19:40:14 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 01A0816A49A; Mon, 27 Aug 2007 19:40:13 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 86FA113C494; Mon, 27 Aug 2007 19:40:11 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k2) with ESMTP id 205656391-1834499 for multiple; Mon, 27 Aug 2007 15:40:27 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l7RJdr73029715; Mon, 27 Aug 2007 15:39:59 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Daniel Eischen Date: Mon, 27 Aug 2007 15:39:48 -0400 User-Agent: KMail/1.9.6 References: <200708270932.31208.jhb@freebsd.org> <20070827.121033.1102529566.imp@bsdimp.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708271539.49455.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 27 Aug 2007 15:39:59 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4077/Mon Aug 27 14:40:44 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, yar@comp.chem.msu.su, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, kensmith@cse.buffalo.edu, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 19:40:14 -0000 On Monday 27 August 2007 02:39:26 pm Daniel Eischen wrote: > > Typically, I'd guess that we'd > > need to bump versions of symbols only every couple of releases. > > FreeBSD only recently started bumping all the shared libraries major > > number as a precaution because we couldn't maintain binary > > compatibility. Symbol versions will give us tools to help with that, > > but we do still need to be careful. > > You only need to bump symbol versions once when the first ABI change > occurs, and after that, only again when an ABI from the second > version changes. There's no need to bump for the sake of bumping, > and it doesn't really buy us anything except confusing us with more > version namespaces. > > I think we need to separate the version namespace from releases, > with the caveat we only care about the symbols that we export from > a release, not intermediate steps. If we want a way to list the > symbols from a release, we can do that with other tools or autogenerate > a file that is committed everytime we add symbols to a version. > Having versions tied to releases will just make it harder for us > to maintain, especially when you think about maintaining 2 or 3 > branches at once (RELENG_7, RELENG_8, and RELENG_9). I agree, but I see fbsd-current for non-released symbols (changes in HEAD that aren't in a release yet) as a compromise that let's the "real" symbols follow this path. > > FBSD-1.0 is the 'current' branch. We put the new fts symbols in as > > FBSD-1.1. If there are other things that require binary bumps between > > now and "the release" we do the same for them. chances are good there > > won't be any, but you never know when a security issue will come up > > that needs to do a ABI change. This will give us both a dry-run for > > having multiple versions of symbols, as well as practical experience > > for how to make -current less bumpy in the future. > > > > Somewhere around RC1, we change all the symbols to be FBSD-7.0. > > I have to disagree pretty heavily here. Symbols shouldn't be tied > to a release. Especially when you start to backport changes to > previous branches. When you backport changes to previous branches, > now you are going to have FBSD_8.0 symbols in FBSD_7.0. Thinking > about the symbol namespace this way isn't what you want, and if > you think off in to the future, you'll see that you'll start > having the same set of functions (with same ABI) appearing in > multiple versions. Ok, I can live with tossing the 7.0 renumber. However, what about the larger picture (ignoring specific numbers) of allowing for the future by using a separate namespace (fbsd-current) for ABI changes that happen in HEAD and only promoting those symbols into the "real" fbsd namespace when a RELENG_X branch is branched? This preserves the desired behavior of the "real" symbols and allows us to not keep a lot of compat gunk around for versions of symbols that were never released (at least not in the releases) while still giving other folks a slightly less rough-edged -current when navigating the various ABI breakages. > It is much easier to change the ABI version once when the first > ABI change occurs, and only ever change it again when an ABI > from the current (ABI) version changes. The key thing I think is ease-of-use for developer vs ease-of-use for for users on the branch. AFAIK, ELF major numbers for shared libs didn't allow us a way to provide a private version space for unreleased ABI changes in HEAD, so we just lived with the pain of a single bump per HEAD cycle in the past. Now that there is a more fine-grained tool that does allow for things like a private version space for HEAD, there are folks who want to take advantage of it to help out with the ease-of-use for running -current on systems. My primary concern is that we find a way to minimize the amount of compat shims in the releases to the bare minimum needed to reduce future maintenance, etc. costs. I think having a private namespace for unreleased symbols in HEAD can give us that (in RELENG_X branches we only have "released" symbols, and in HEAD we phase out private compat symbols on whatever schedule seems suitable) while still letting folks use symbol versioning to make HEAD a little less rough-edged. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Aug 27 19:58:54 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E5B2E16A417; Mon, 27 Aug 2007 19:58:54 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id CB2FC13C442; Mon, 27 Aug 2007 19:58:54 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 4E1251A4D97; Mon, 27 Aug 2007 12:56:34 -0700 (PDT) Date: Mon, 27 Aug 2007 12:56:34 -0700 From: Alfred Perlstein To: John Baldwin Message-ID: <20070827195634.GZ87451@elvis.mu.org> References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <200708270850.20904.jhb@freebsd.org> <20070827190100.GY87451@elvis.mu.org> <200708271529.42264.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200708271529.42264.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, cvs-all@freebsd.org, deischen@freebsd.org, cvs-src@freebsd.org, Warner Losh , yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 19:58:55 -0000 * John Baldwin [070827 12:37] wrote: > On Monday 27 August 2007 03:01:00 pm Alfred Perlstein wrote: > > * John Baldwin [070827 05:48] wrote: > > > > > > I think it will be confusing to have missing symbols just as folks would > > > have thought it confusing to have 6.x ship with libc.so.8 if we had > > > bumped libc multiple times. I also think that just managing the > > > interfaces that show up in releases and -stable branches will be enough > > > extra bookkeeping to keep track of as it is. > > > > This is something I just don't understand, why is some psuedo-arbitrary > > number somehow MORE confusing/damaging than some convoluted upgrade > > path? > > > > The only negative (which is bs) of doing so is keeping around multiple > > compat libraries for the same release, which we can simply decide not > > to do. > > > > (meaning, for your example there does not need to be a libc.so.7 > > shipped in some compat package unless someone really wants to) > > User questions. "I just upgraded via make world from 6.x to 7.0 and now I > have a libc.so.6 and a libc.so.8, what happened to libc.so.7, did something > go wrong??? please help!!!!" In the grand scheme of things, telling a user "that's expected" is a lot less overhead than actually performing triage on a "real problem". > etc. > > And yes, I do think it's ok for -current to have rougher edges. After all, we > aren't really trying to get people running -current on production systems. I don't know if we should be in effect punishing "power users", sure they can be annoying, but they really, really, really, really... do help with preventing regressions. Seriously, if only the extremely clued and brave can run current we are severely limiting our base of users who can test. I think this is more of a disservice to the project than the occasional power user whom we might actually have to strum up the *cough*balls*cough* to tell, "you know, maybe -current isn't right for you at the moment." -Alfred -- - Alfred Perlstein From owner-cvs-src@FreeBSD.ORG Mon Aug 27 20:01:08 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7A4FE16A418; Mon, 27 Aug 2007 20:01:08 +0000 (UTC) (envelope-from remko@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 529E313C46C; Mon, 27 Aug 2007 20:01:08 +0000 (UTC) (envelope-from remko@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7RK18sL043925; Mon, 27 Aug 2007 20:01:08 GMT (envelope-from remko@repoman.freebsd.org) Received: (from remko@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7RK18a9043924; Mon, 27 Aug 2007 20:01:08 GMT (envelope-from remko) Message-Id: <200708272001.l7RK18a9043924@repoman.freebsd.org> From: Remko Lodder Date: Mon, 27 Aug 2007 20:01:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man5 src.conf.5 src/tools/build/options WITHOUT_ZONEINFO X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 20:01:08 -0000 remko 2007-08-27 20:01:08 UTC FreeBSD src repository Modified files: share/man/man5 src.conf.5 Added files: tools/build/options WITHOUT_ZONEINFO Log: Add WITHOUT_ZONEINFO to the build options and regenerate src.conf.5 Reminded by: ceri Approved by: re (bmah) Approved by: imp (mentor) Revision Changes Path 1.14 +4 -1 src/share/man/man5/src.conf.5 1.1 +2 -0 src/tools/build/options/WITHOUT_ZONEINFO (new) From owner-cvs-src@FreeBSD.ORG Mon Aug 27 20:10:51 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1C05916A418; Mon, 27 Aug 2007 20:10:51 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id B676813C4CC; Mon, 27 Aug 2007 20:10:50 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l7RK9XDm004457; Mon, 27 Aug 2007 14:09:33 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 27 Aug 2007 14:09:37 -0600 (MDT) Message-Id: <20070827.140937.1102530446.imp@bsdimp.com> To: deischen@FreeBSD.ORG From: "M. Warner Losh" In-Reply-To: References: <20070827.121033.1102529566.imp@bsdimp.com> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 27 Aug 2007 14:09:34 -0600 (MDT) Cc: src-committers@FreeBSD.ORG, jhb@FreeBSD.ORG, peterjeremy@optushome.com.au, yar@comp.chem.msu.su, alfred@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-src@FreeBSD.ORG, kensmith@cse.buffalo.edu Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 20:10:51 -0000 In message: Daniel Eischen writes: : > Typically, I'd guess that we'd : > need to bump versions of symbols only every couple of releases. : > FreeBSD only recently started bumping all the shared libraries major : > number as a precaution because we couldn't maintain binary : > compatibility. Symbol versions will give us tools to help with that, : > but we do still need to be careful. : : You only need to bump symbol versions once when the first ABI change : occurs, and after that, only again when an ABI from the second : version changes. There's no need to bump for the sake of bumping, : and it doesn't really buy us anything except confusing us with more : version namespaces. I must disagree. Smoothing out the bumps in current is a very tangible benefit. And I don't see what the confusion would be. It would be very clearly defined that these are 'bridges' that we remove after so long, use for so long ,etc. : I think we need to separate the version namespace from releases, : with the caveat we only care about the symbols that we export from : a release, not intermediate steps. If we want a way to list the : symbols from a release, we can do that with other tools or autogenerate : a file that is committed everytime we add symbols to a version. : Having versions tied to releases will just make it harder for us : to maintain, especially when you think about maintaining 2 or 3 : branches at once (RELENG_7, RELENG_8, and RELENG_9). That's fine. s/7.0/2.0/g in all my stuff. And if people notice, and chances are they will not, a simple explanation will suffice. We'll have to explain anyway if they notice that we're at revision 1.0 for FreeBSD 7.0. : > : There is no overwhelming reason to break the rules that we've held : > : in the past. It's easy to say, "but it's less painful", but after : > : you've gone through it, you're done. I think we're taking a very : > : short-sighted view of things and don't agree with breaking or bending : > : the rules without a _very_ good reason. : > : > I think the reasons have been well presented so far. However, there's : > a way we can cope without having to break the world or our rules. : > BTW, we never agreed what to do about symbol versions in current, so : > there's really no rules to break. Consensus never was reached on what : > to do there, although you keep asserting that we can only bump them : > once, but that has never been agreed to and codified. There is strong : > agreement that we only have user visible changes once per release, but : > a divergence of views on what to do in current. However, there's a : > strong desire to use it to make -current a less bumpy place. This : > thread is clear evidence of that. : > : > However, there's a forth option that I'd not considered. It goes like : > so. Thanks to John Baldwin, Brooks Davis, Ken Smith and kan for : > hammering out the details on IRC. This is just a proposal, but we : > think a good one that will solve the problems. : > : > FBSD-1.0 is the 'current' branch. We put the new fts symbols in as : > FBSD-1.1. If there are other things that require binary bumps between : > now and "the release" we do the same for them. chances are good there : > won't be any, but you never know when a security issue will come up : > that needs to do a ABI change. This will give us both a dry-run for : > having multiple versions of symbols, as well as practical experience : > for how to make -current less bumpy in the future. : > : > Somewhere around RC1, we change all the symbols to be FBSD-7.0. : : I have to disagree pretty heavily here. Symbols shouldn't be tied : to a release. Especially when you start to backport changes to : previous branches. When you backport changes to previous branches, : now you are going to have FBSD_8.0 symbols in FBSD_7.0. Thinking : about the symbol namespace this way isn't what you want, and if : you think off in to the future, you'll see that you'll start : having the same set of functions (with same ABI) appearing in : multiple versions. Is your disagreement with 7.0 or with the whole concept? If it is just 7.0, s/7.0/2.0/g. We could then tell people the 1.x revisions were for testing purposes only and were removed before the release... Since it is just an arbitrary string, it can be anything we want it to be. : It is much easier to change the ABI version once when the first : ABI change occurs, and only ever change it again when an ABI : from the current (ABI) version changes. Easier for the developer making the change. Harder for everybody else. We need a balance here so that we can smooth out the bumps in -current because ports/packages have become so complex and difficult to build/rebuild that some aid is needed. Developers are going to have to do the bump anyway when they make an incompatible change, so why not make them do it for all incompatible changes? Its not like we're going to be changing exported symbols that many times between releases. But since we have the means to remain compatible to ease the bumpiness of current, why can't we at least consider the possibility? Warner From owner-cvs-src@FreeBSD.ORG Mon Aug 27 20:13:46 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E262716A418; Mon, 27 Aug 2007 20:13:46 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id A07AE13C442; Mon, 27 Aug 2007 20:13:46 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l7RKBLdG004483; Mon, 27 Aug 2007 14:11:21 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 27 Aug 2007 14:11:25 -0600 (MDT) Message-Id: <20070827.141125.-1573947069.imp@bsdimp.com> To: jhb@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <200708271529.42264.jhb@freebsd.org> References: <200708270850.20904.jhb@freebsd.org> <20070827190100.GY87451@elvis.mu.org> <200708271529.42264.jhb@freebsd.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 27 Aug 2007 14:11:22 -0600 (MDT) Cc: src-committers@FreeBSD.org, peterjeremy@optushome.com.au, alfred@FreeBSD.org, cvs-all@FreeBSD.org, deischen@FreeBSD.org, cvs-src@FreeBSD.org, yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 20:13:47 -0000 In message: <200708271529.42264.jhb@freebsd.org> John Baldwin writes: : And yes, I do think it's ok for -current to have rougher edges. After all, we : aren't really trying to get people running -current on production systems. I think it is OK for -current to have rougher edges. I don't think it is OK to require -current to have rougher edges. Warner From owner-cvs-src@FreeBSD.ORG Mon Aug 27 20:23:00 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7B18316A46C; Mon, 27 Aug 2007 20:23:00 +0000 (UTC) (envelope-from remko@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5420313C459; Mon, 27 Aug 2007 20:23:00 +0000 (UTC) (envelope-from remko@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7RKN0g7046841; Mon, 27 Aug 2007 20:23:00 GMT (envelope-from remko@repoman.freebsd.org) Received: (from remko@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7RKN0Nt046840; Mon, 27 Aug 2007 20:23:00 GMT (envelope-from remko) Message-Id: <200708272023.l7RKN0Nt046840@repoman.freebsd.org> From: Remko Lodder Date: Mon, 27 Aug 2007 20:22:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man5 src.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 20:23:00 -0000 remko 2007-08-27 20:22:59 UTC FreeBSD src repository Modified files: share/man/man5 src.conf.5 Log: Regenerate src.conf.5 -after- the addition of WITHOUT_ZONEINFO, the way I did this in the previous commit, leaves out the parsing of $FreeBSD$ which is actually required to be parsed. Kindly reminded by: bmah Approved by: re (bmah) Approved by: imp (mentor, implicit) Revision Changes Path 1.15 +1 -1 src/share/man/man5/src.conf.5 From owner-cvs-src@FreeBSD.ORG Mon Aug 27 20:48:33 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7399716A417; Mon, 27 Aug 2007 20:48:33 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 2829B13C428; Mon, 27 Aug 2007 20:48:33 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7RKmFH1011917; Mon, 27 Aug 2007 16:48:15 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Mon, 27 Aug 2007 16:48:16 -0400 (EDT) Date: Mon, 27 Aug 2007 16:48:15 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: "M. Warner Losh" In-Reply-To: <20070827.140937.1102530446.imp@bsdimp.com> Message-ID: References: <20070827.121033.1102529566.imp@bsdimp.com> <20070827.140937.1102530446.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, jhb@freebsd.org, yar@comp.chem.msu.su, alfred@freebsd.org, peterjeremy@optushome.com.au, cvs-all@freebsd.org, cvs-src@freebsd.org, kensmith@cse.buffalo.edu Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 20:48:33 -0000 On Mon, 27 Aug 2007, M. Warner Losh wrote: > In message: > Daniel Eischen writes: > : > Typically, I'd guess that we'd > : > need to bump versions of symbols only every couple of releases. > : > FreeBSD only recently started bumping all the shared libraries major > : > number as a precaution because we couldn't maintain binary > : > compatibility. Symbol versions will give us tools to help with that, > : > but we do still need to be careful. > : > : You only need to bump symbol versions once when the first ABI change > : occurs, and after that, only again when an ABI from the second > : version changes. There's no need to bump for the sake of bumping, > : and it doesn't really buy us anything except confusing us with more > : version namespaces. > > I must disagree. Smoothing out the bumps in current is a very > tangible benefit. And I don't see what the confusion would be. It > would be very clearly defined that these are 'bridges' that we remove > after so long, use for so long ,etc. You have to keep in mind that you probably won't ever have a problem between releases. How many times in the past have we had incompatible ABI changes between releases? I don't think we ever have. I think you're trying to solve a problem that has never existed. > : I have to disagree pretty heavily here. Symbols shouldn't be tied > : to a release. Especially when you start to backport changes to > : previous branches. When you backport changes to previous branches, > : now you are going to have FBSD_8.0 symbols in FBSD_7.0. Thinking > : about the symbol namespace this way isn't what you want, and if > : you think off in to the future, you'll see that you'll start > : having the same set of functions (with same ABI) appearing in > : multiple versions. > > Is your disagreement with 7.0 or with the whole concept? If it is > just 7.0, s/7.0/2.0/g. We could then tell people the 1.x revisions > were for testing purposes only and were removed before the release... > Since it is just an arbitrary string, it can be anything we want it to > be. It should stay at 1.0. If you really really want to have a different version for FTS, then you can have 1.1. It's no different than 2.0 and 1.0 - you can say 1.0 was for testing. > : It is much easier to change the ABI version once when the first > : ABI change occurs, and only ever change it again when an ABI > : from the current (ABI) version changes. > > Easier for the developer making the change. Harder for everybody > else. We need a balance here so that we can smooth out the bumps in > -current because ports/packages have become so complex and difficult > to build/rebuild that some aid is needed. Developers are going to > have to do the bump anyway when they make an incompatible change, so > why not make them do it for all incompatible changes? Its not like > we're going to be changing exported symbols that many times between > releases. But since we have the means to remain compatible to ease > the bumpiness of current, why can't we at least consider the > possibility? Because you'll end up with versions FBSD_1.1, FBSD_1.5, and FBSD_2.0 in RELENG_7, only because the ABI changes for 1.2, 1.3, 1.4, and any in between 1.5 and 2.0, were not deemed MFC'able. And you could still have a partial set of symbols from 1.1, 1.5, or 2.0 existing in RELENG_7 because some of those symbols were not MFC'able either. Please think about what symbol versioning does. You can have a lot of ABI changes added to one symbol version without impacting anyone. The only time you will have an impact is if you change the _same_ ABI more than once between versions, and like I said, I doubt that has ever happened before. If it ever does, I guess you could think about bumping twice between releases, or, God forbid, make -current users rebuild everything once every 10 years (or however often the situation arises). If you really want to have a separate version namespace for -current, you could use FBSDcurrent_1.x bumping when needed. And whenever you branched -current again, could bump the mainline version (e.g., FBSD_1.3 -> FBSD_1.4) once for the branch and reset FBSDcurrent_1.x back to 0 again. I don't know the details of how you would hide these temporary or development versions. The other thing to remember is that you have to keep a lot of different versions in the Symbol.map files and MFC'ing them may be difficult since the numbering scheme is different. Plus whenever you MFC something, you have make sure that the symbol maps in -current are properly adjusted to match because applications from prior releases have to continue to work on -current. I just think using more versions than we need is just going to make it harder on us to maintain and not help anyone running releases since they aren't going to see the internal numbering scheme anyway. -- DE From owner-cvs-src@FreeBSD.ORG Mon Aug 27 20:55:42 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AB93B16A417; Mon, 27 Aug 2007 20:55:42 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 6784F13C481; Mon, 27 Aug 2007 20:55:42 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7RKtVnI016686; Mon, 27 Aug 2007 16:55:31 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Mon, 27 Aug 2007 16:55:32 -0400 (EDT) Date: Mon, 27 Aug 2007 16:55:31 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: "M. Warner Losh" In-Reply-To: <20070827.141125.-1573947069.imp@bsdimp.com> Message-ID: References: <200708270850.20904.jhb@freebsd.org> <20070827190100.GY87451@elvis.mu.org> <200708271529.42264.jhb@freebsd.org> <20070827.141125.-1573947069.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, jhb@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 20:55:42 -0000 On Mon, 27 Aug 2007, M. Warner Losh wrote: > In message: <200708271529.42264.jhb@freebsd.org> > John Baldwin writes: > : And yes, I do think it's ok for -current to have rougher edges. After all, we > : aren't really trying to get people running -current on production systems. > > I think it is OK for -current to have rougher edges. I don't think it > is OK to require -current to have rougher edges. I think we can agree on that! I also think there is some confusion over whether adding ABI changes to an existing symbol version would force us to rebuild ports. It doesn't. Once symbol versioning is released in 7.0, we can create a new version (FBSD_1.1, or add to the existing FBSD_1.1 depending on how the FTS stuff goes) and add all the (non-overlapping) ABI changes we want to it _without_ having to rebuild ports. This is a tremendous advantage over -current as it is today. -- DE From owner-cvs-src@FreeBSD.ORG Mon Aug 27 21:15:32 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C603416A46B; Mon, 27 Aug 2007 21:15:32 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 3251813C45B; Mon, 27 Aug 2007 21:15:31 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k2) with ESMTP id 205672099-1834499 for multiple; Mon, 27 Aug 2007 17:15:50 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l7RLFT67030319; Mon, 27 Aug 2007 17:15:29 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Daniel Eischen Date: Mon, 27 Aug 2007 17:15:20 -0400 User-Agent: KMail/1.9.6 References: <200708270850.20904.jhb@freebsd.org> <20070827.141125.-1573947069.imp@bsdimp.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708271715.21462.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 27 Aug 2007 17:15:29 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4078/Mon Aug 27 16:37:54 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, "M. Warner Losh" , yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 21:15:32 -0000 On Monday 27 August 2007 04:55:31 pm Daniel Eischen wrote: > On Mon, 27 Aug 2007, M. Warner Losh wrote: > > > In message: <200708271529.42264.jhb@freebsd.org> > > John Baldwin writes: > > : And yes, I do think it's ok for -current to have rougher edges. After all, we > > : aren't really trying to get people running -current on production systems. > > > > I think it is OK for -current to have rougher edges. I don't think it > > is OK to require -current to have rougher edges. > > I think we can agree on that! I also think there is some confusion > over whether adding ABI changes to an existing symbol version would > force us to rebuild ports. It doesn't. Once symbol versioning is > released in 7.0, we can create a new version (FBSD_1.1, or add to > the existing FBSD_1.1 depending on how the FTS stuff goes) and add > all the (non-overlapping) ABI changes we want to it _without_ having > to rebuild ports. This is a tremendous advantage over -current as > it is today. So you want to just bump the version everytime a change happens in HEAD? That seems to contradict your earlier changes as you are now saying use 1.1 for fts(3), etc. Also since you mentioned MFC'ing one ABI (say 1.5) but not others (1.2-1.4), that implies each change in HEAD has its own first-level version? -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Aug 27 21:38:20 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0E66716A46B; Mon, 27 Aug 2007 21:38:20 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id CF08313C49D; Mon, 27 Aug 2007 21:38:19 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7RLc8QX014673; Mon, 27 Aug 2007 17:38:08 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Mon, 27 Aug 2007 17:38:08 -0400 (EDT) Date: Mon, 27 Aug 2007 17:38:08 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: John Baldwin In-Reply-To: <200708271715.21462.jhb@freebsd.org> Message-ID: References: <200708270850.20904.jhb@freebsd.org> <20070827.141125.-1573947069.imp@bsdimp.com> <200708271715.21462.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, "M. Warner Losh" , yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 21:38:20 -0000 On Mon, 27 Aug 2007, John Baldwin wrote: > On Monday 27 August 2007 04:55:31 pm Daniel Eischen wrote: >> On Mon, 27 Aug 2007, M. Warner Losh wrote: >> >>> In message: <200708271529.42264.jhb@freebsd.org> >>> John Baldwin writes: >>> : And yes, I do think it's ok for -current to have rougher edges. After > all, we >>> : aren't really trying to get people running -current on production > systems. >>> >>> I think it is OK for -current to have rougher edges. I don't think it >>> is OK to require -current to have rougher edges. >> >> I think we can agree on that! I also think there is some confusion >> over whether adding ABI changes to an existing symbol version would >> force us to rebuild ports. It doesn't. Once symbol versioning is >> released in 7.0, we can create a new version (FBSD_1.1, or add to >> the existing FBSD_1.1 depending on how the FTS stuff goes) and add >> all the (non-overlapping) ABI changes we want to it _without_ having >> to rebuild ports. This is a tremendous advantage over -current as >> it is today. > > So you want to just bump the version everytime a change happens in HEAD? No, I don't see how you get that from what I said... > That > seems to contradict your earlier changes as you are now saying use 1.1 for > fts(3), etc. Also since you mentioned MFC'ing one ABI (say 1.5) but not > others (1.2-1.4), that implies each change in HEAD has its own first-level > version? FBSD_1.1 should get us out a few years. Unless you have an ABI change that is _already_ in FBSD_1.1, you don't have to create a new version. An example (for the sake of this example, let's assume that all non-fts symbols are in FBSD_1.0, and fts_* are in FBSD_1.1): FILE changes in -current, the new symbol map would add the FILE-related APIs. FBSD_1.1 { fts_open; <- existing fts_read; <- existing ... fts_close; <- existing fopen; <- new fread; <- new ... fclose; <- new } FBSD_1.0; A week later, pthread_mutex_t changes in -current. You add the pthread_mutex_t-related APIs: FBSD_1.1 { fts_open; <- existing fts_read; <- existing ... fts_close; <- existing fopen; <- existing fread; <- existing ... fclose; <- existing pthread_mutex_init; <- new pthread_mutex_lock; <- new ... pthread_mutex_destroy; <- new } FBSD_1.0; You are not forced to rebuild any ports by adding symbols to FBSD_1.1. Everything that was built before the pthread_mutex_t change will work after the change. You can keep adding to FBSD_1.1 and only need to go to FBSD_1.2 if one of the APIs in FBSD_1.1 undergoes yet another ABI change. If the fts_* stuff goes in now as FBSD_1.0, I guess you don't need to go to FBSD_1.1. You can stay at FBSD_1.0 until you have the next ABI change. If fts_* goes in now as FBSD_1.1 (and assuming all the other symbols stay at FBSD_1.0), then you can just keep adding to FBSD_1.1 after the branch/release. If all the symbols along with fts get pushed to FBSD_1.1, then you have to go to FBSD_1.2 at the next ABI change. -- DE From owner-cvs-src@FreeBSD.ORG Mon Aug 27 21:56:44 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 36D8A16A418; Mon, 27 Aug 2007 21:56:44 +0000 (UTC) (envelope-from murray@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0F72613C45D; Mon, 27 Aug 2007 21:56:44 +0000 (UTC) (envelope-from murray@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7RLuhcG062432; Mon, 27 Aug 2007 21:56:43 GMT (envelope-from murray@repoman.freebsd.org) Received: (from murray@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7RLuhIm062431; Mon, 27 Aug 2007 21:56:43 GMT (envelope-from murray) Message-Id: <200708272156.l7RLuhIm062431@repoman.freebsd.org> From: Murray Stokely Date: Mon, 27 Aug 2007 21:56:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/kbdmap kbdmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 21:56:44 -0000 murray 2007-08-27 21:56:43 UTC FreeBSD src repository Modified files: usr.sbin/kbdmap kbdmap.c Log: Output keymap choice to stderr so it is easier to parse for apps chained to this curses based app. Submitted by: ivoras Approved by: re@ (bmah@) Revision Changes Path 1.6 +1 -1 src/usr.sbin/kbdmap/kbdmap.c From owner-cvs-src@FreeBSD.ORG Mon Aug 27 21:57:13 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4167F16A420; Mon, 27 Aug 2007 21:57:13 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id A3E2913C483; Mon, 27 Aug 2007 21:57:12 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k2) with ESMTP id 205677843-1834499 for multiple; Mon, 27 Aug 2007 17:57:29 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l7RLv8RP030598; Mon, 27 Aug 2007 17:57:08 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Daniel Eischen Date: Mon, 27 Aug 2007 17:57:00 -0400 User-Agent: KMail/1.9.6 References: <200708270850.20904.jhb@freebsd.org> <200708271715.21462.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708271757.01674.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 27 Aug 2007 17:57:08 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4078/Mon Aug 27 16:37:54 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, "M. Warner Losh" , yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 21:57:13 -0000 On Monday 27 August 2007 05:38:08 pm Daniel Eischen wrote: > On Mon, 27 Aug 2007, John Baldwin wrote: > > > On Monday 27 August 2007 04:55:31 pm Daniel Eischen wrote: > >> On Mon, 27 Aug 2007, M. Warner Losh wrote: > >> > >>> In message: <200708271529.42264.jhb@freebsd.org> > >>> John Baldwin writes: > >>> : And yes, I do think it's ok for -current to have rougher edges. After > > all, we > >>> : aren't really trying to get people running -current on production > > systems. > >>> > >>> I think it is OK for -current to have rougher edges. I don't think it > >>> is OK to require -current to have rougher edges. > >> > >> I think we can agree on that! I also think there is some confusion > >> over whether adding ABI changes to an existing symbol version would > >> force us to rebuild ports. It doesn't. Once symbol versioning is > >> released in 7.0, we can create a new version (FBSD_1.1, or add to > >> the existing FBSD_1.1 depending on how the FTS stuff goes) and add > >> all the (non-overlapping) ABI changes we want to it _without_ having > >> to rebuild ports. This is a tremendous advantage over -current as > >> it is today. > > > > So you want to just bump the version everytime a change happens in HEAD? > > No, I don't see how you get that from what I said... You originally objected to having fts compat symbols as 1.0 and wanted the new fts to be 1.0. Now you are saying that the new fts can be 1.1 and the old ones (only used in old current) can remain 1.0. That is, now you are saying to do what Yar originally wanted to do before you objected. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Aug 27 22:01:34 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2D04016A417; Mon, 27 Aug 2007 22:01:34 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id DB8D113C4D3; Mon, 27 Aug 2007 22:01:33 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7RM1MMX028305; Mon, 27 Aug 2007 18:01:22 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Mon, 27 Aug 2007 18:01:22 -0400 (EDT) Date: Mon, 27 Aug 2007 18:01:22 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: John Baldwin In-Reply-To: <200708271757.01674.jhb@freebsd.org> Message-ID: References: <200708270850.20904.jhb@freebsd.org> <200708271715.21462.jhb@freebsd.org> <200708271757.01674.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, "M. Warner Losh" , yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 22:01:34 -0000 On Mon, 27 Aug 2007, John Baldwin wrote: > On Monday 27 August 2007 05:38:08 pm Daniel Eischen wrote: >>>> it is today. >>> >>> So you want to just bump the version everytime a change happens in HEAD? >> >> No, I don't see how you get that from what I said... > > You originally objected to having fts compat symbols as 1.0 and wanted the new > fts to be 1.0. Now you are saying that the new fts can be 1.1 and the old > ones (only used in old current) can remain 1.0. > > That is, now you are saying to do what Yar originally wanted to do before you > objected. No, I still think they should be 1.0 or wait till after the release. I just made some assumption for the sake of giving an example. -- DE From owner-cvs-src@FreeBSD.ORG Mon Aug 27 22:10:23 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 193B916A418; Mon, 27 Aug 2007 22:10:23 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id 2870A13C46C; Mon, 27 Aug 2007 22:10:21 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7RMA3QB079129; Tue, 28 Aug 2007 02:10:03 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7RMA27L079128; Tue, 28 Aug 2007 02:10:02 +0400 (MSD) (envelope-from yar) Date: Tue, 28 Aug 2007 02:10:02 +0400 From: Yar Tikhiy To: Daniel Eischen Message-ID: <20070827221002.GS21352@comp.chem.msu.su> References: <200708270850.20904.jhb@freebsd.org> <20070827.141125.-1573947069.imp@bsdimp.com> <200708271715.21462.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Cc: src-committers@freebsd.org, John Baldwin , peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 22:10:23 -0000 On Mon, Aug 27, 2007 at 05:38:08PM -0400, Daniel Eischen wrote: > On Mon, 27 Aug 2007, John Baldwin wrote: > >That > >seems to contradict your earlier changes as you are now saying use 1.1 for > >fts(3), etc. Also since you mentioned MFC'ing one ABI (say 1.5) but not > >others (1.2-1.4), that implies each change in HEAD has its own first-level > >version? > > FBSD_1.1 should get us out a few years. Unless you have an ABI change > that is _already_ in FBSD_1.1, you don't have to create a new version. > > An example (for the sake of this example, let's assume that all > non-fts symbols are in FBSD_1.0, and fts_* are in FBSD_1.1): > > FILE changes in -current, the new symbol map would add the FILE-related > APIs. > > FBSD_1.1 { > fts_open; <- existing > fts_read; <- existing > ... > fts_close; <- existing > fopen; <- new > fread; <- new > ... > fclose; <- new > } FBSD_1.0; > > A week later, pthread_mutex_t changes in -current. You add the > pthread_mutex_t-related APIs: > > FBSD_1.1 { > fts_open; <- existing > fts_read; <- existing > ... > fts_close; <- existing > fopen; <- existing > fread; <- existing > ... > fclose; <- existing > pthread_mutex_init; <- new > pthread_mutex_lock; <- new > ... > pthread_mutex_destroy; <- new > } FBSD_1.0; > > You are not forced to rebuild any ports by adding symbols to FBSD_1.1. > Everything that was built before the pthread_mutex_t change will work > after the change. You can keep adding to FBSD_1.1 and only need to > go to FBSD_1.2 if one of the APIs in FBSD_1.1 undergoes yet another > ABI change. I guess everything will work after changing pthread_mutex_t if either nothing calls pthread_mutex functions or compatibility shims for them are provided under FBSD_1.0. Is it correct? > If the fts_* stuff goes in now as FBSD_1.0, I guess you don't > need to go to FBSD_1.1. You can stay at FBSD_1.0 until you > have the next ABI change. If fts_* goes in now as FBSD_1.1 (and > assuming all the other symbols stay at FBSD_1.0), then you can > just keep adding to FBSD_1.1 after the branch/release. If all > the symbols along with fts get pushed to FBSD_1.1, then you > have to go to FBSD_1.2 at the next ABI change. Just to make things clear: if FBSD_1.0, FBSD_1.1, and FBSD_1.2 are already populated with some symbols and a symbol from FBSD_1.0 undergoes an incompatible change, which version it should be promoted to, FBSD_1.1 or FBSD_1.2? AFAIK, technically either is possible. -- Yar From owner-cvs-src@FreeBSD.ORG Mon Aug 27 22:24:29 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AAEF916A41B; Mon, 27 Aug 2007 22:24:29 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 5FF1313C45E; Mon, 27 Aug 2007 22:24:29 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7RMOIon012393; Mon, 27 Aug 2007 18:24:18 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Mon, 27 Aug 2007 18:24:18 -0400 (EDT) Date: Mon, 27 Aug 2007 18:24:18 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Yar Tikhiy In-Reply-To: <20070827221002.GS21352@comp.chem.msu.su> Message-ID: References: <200708270850.20904.jhb@freebsd.org> <20070827.141125.-1573947069.imp@bsdimp.com> <200708271715.21462.jhb@freebsd.org> <20070827221002.GS21352@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, John Baldwin , peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2007 22:24:29 -0000 On Tue, 28 Aug 2007, Yar Tikhiy wrote: > On Mon, Aug 27, 2007 at 05:38:08PM -0400, Daniel Eischen wrote: >> >> An example (for the sake of this example, let's assume that all >> non-fts symbols are in FBSD_1.0, and fts_* are in FBSD_1.1): >> >> FILE changes in -current, the new symbol map would add the FILE-related >> APIs. >> >> FBSD_1.1 { >> fts_open; <- existing >> fts_read; <- existing >> ... >> fts_close; <- existing >> fopen; <- new >> fread; <- new >> ... >> fclose; <- new >> } FBSD_1.0; >> >> A week later, pthread_mutex_t changes in -current. You add the >> pthread_mutex_t-related APIs: >> >> FBSD_1.1 { >> fts_open; <- existing >> fts_read; <- existing >> ... >> fts_close; <- existing >> fopen; <- existing >> fread; <- existing >> ... >> fclose; <- existing >> pthread_mutex_init; <- new >> pthread_mutex_lock; <- new >> ... >> pthread_mutex_destroy; <- new >> } FBSD_1.0; >> >> You are not forced to rebuild any ports by adding symbols to FBSD_1.1. >> Everything that was built before the pthread_mutex_t change will work >> after the change. You can keep adding to FBSD_1.1 and only need to >> go to FBSD_1.2 if one of the APIs in FBSD_1.1 undergoes yet another >> ABI change. > > I guess everything will work after changing pthread_mutex_t if either > nothing calls pthread_mutex functions or compatibility shims for them > are provided under FBSD_1.0. Is it correct? Yes, though I was assuming that compat shims are added whenever you change the ABI. For this example, we know that there are a lot of applications that use pthread_mutex-related APIs, so the appropriate compat shims would definitely be needed. >> If the fts_* stuff goes in now as FBSD_1.0, I guess you don't >> need to go to FBSD_1.1. You can stay at FBSD_1.0 until you >> have the next ABI change. If fts_* goes in now as FBSD_1.1 (and >> assuming all the other symbols stay at FBSD_1.0), then you can >> just keep adding to FBSD_1.1 after the branch/release. If all >> the symbols along with fts get pushed to FBSD_1.1, then you >> have to go to FBSD_1.2 at the next ABI change. > > Just to make things clear: if FBSD_1.0, FBSD_1.1, and FBSD_1.2 are > already populated with some symbols and a symbol from FBSD_1.0 > undergoes an incompatible change, which version it should be promoted > to, FBSD_1.1 or FBSD_1.2? AFAIK, technically either is possible. Correct, you can add the new APIs to either FBSD_1.1 or FBSD_1.2, and I do raise this question (as a TBD) in: http://people.freebsd.org/~deischen/symver/freebsd_versioning.txt I would think that we would always use the latest version when adding new ABI changes to -current. In release branches, MFCs have to go the the same version from which they came in -current (to maintain forward compatibility). -- DE From owner-cvs-src@FreeBSD.ORG Tue Aug 28 00:09:13 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 185A516A417; Tue, 28 Aug 2007 00:09:13 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E3D5C13C442; Tue, 28 Aug 2007 00:09:12 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7S09C3C074743; Tue, 28 Aug 2007 00:09:12 GMT (envelope-from jkim@repoman.freebsd.org) Received: (from jkim@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7S09Cf3074742; Tue, 28 Aug 2007 00:09:12 GMT (envelope-from jkim) Message-Id: <200708280009.l7S09Cf3074742@repoman.freebsd.org> From: Jung-uk Kim Date: Tue, 28 Aug 2007 00:09:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/isp isp_freebsd.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 00:09:13 -0000 jkim 2007-08-28 00:09:12 UTC FreeBSD src repository Modified files: sys/dev/isp isp_freebsd.h Log: Fix off-by-two errors. Both WWNN and WWPN are 64-bit unsigned integers and they are prefixed with "0x", which requires two more bytes each. Submitted by: Danny Braniss (danny at cs dot huji dot ac dot il) via Matthew Jacob (lydianconcepts at gmail dot com) Approved by: re (bmah) MFC after: 3 days Revision Changes Path 1.107 +2 -2 src/sys/dev/isp/isp_freebsd.h From owner-cvs-src@FreeBSD.ORG Tue Aug 28 00:49:03 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7B33216A417; Tue, 28 Aug 2007 00:49:03 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id 8F72913C46B; Tue, 28 Aug 2007 00:49:01 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7S0mhbS082825; Tue, 28 Aug 2007 04:48:43 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7S0mgQA082824; Tue, 28 Aug 2007 04:48:43 +0400 (MSD) (envelope-from yar) Date: Tue, 28 Aug 2007 04:48:42 +0400 From: Yar Tikhiy To: Daniel Eischen Message-ID: <20070828004842.GT21352@comp.chem.msu.su> References: <200708270850.20904.jhb@freebsd.org> <200708271715.21462.jhb@freebsd.org> <200708271757.01674.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Cc: src-committers@freebsd.org, John Baldwin , peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 00:49:03 -0000 On Mon, Aug 27, 2007 at 06:01:22PM -0400, Daniel Eischen wrote: > On Mon, 27 Aug 2007, John Baldwin wrote: > > >On Monday 27 August 2007 05:38:08 pm Daniel Eischen wrote: > >>>>it is today. > >>> > >>>So you want to just bump the version everytime a change happens in HEAD? > >> > >>No, I don't see how you get that from what I said... > > > >You originally objected to having fts compat symbols as 1.0 and wanted the > >new > >fts to be 1.0. Now you are saying that the new fts can be 1.1 and the old > >ones (only used in old current) can remain 1.0. > > > >That is, now you are saying to do what Yar originally wanted to do before > >you > >objected. > > No, I still think they should be 1.0 or wait till after the > release. I just made some assumption for the sake of giving > an example. It's time to summarize previous discussion to prevent further misunderstanding. :-) Let's recall the point all sides of this discussion seem to share: symbol versions can give us ability to run binaries from a former _release_ in a later _release_ without installing compat libraries. Obviously, it will be available only after 7.0-RELEASE, the first release with symbol versioning. _If this ability is the only goal_, Daniel's position makes sense as it implies a minimal number of distinct version labels and compatibility shims to support later. I.e., we allow new version labels only after 7.0-RELEASE and we allow at most one new version label for each successive major release. That's how we make sure that every old version of a symbol appeared in at least one former release, so that we don't have to support old versions without release history. I say "version label" to emphasize the fact that the same version strings of different symbols can correspond to totally unrelated changes in them, which Daniel pointed out already. I.e., each symbol can travel along the version axis independently. Moreover, it's technically possible to have a separate version axis for as little as each symbol, but it would be gross. Example: Assume we released 7.0-R with all symbols at FBSD_1.0. Before the 8.0 release cycle starts, struct FTS and struct FILE change, perhaps a few times each, thus affecting the fts(3) and stdio(3) global symbols. At the very first change to a symbol or their group, its 7.0-R variant is preserved at FBSD_1.0 and its default version becomes FBSD_1.1. Later changes to the current variant of that symbol don't affect its version. Consequently, 8.0-R is released with the new fts(3) and stdio(3) symbols at FBSD_1.1, their 7.0-R variants at FBSD_1.0, and the rest of symbols still at FBSD_1.0 because they are unchanged. Let's note that CURRENT users had to rebuild ports depending on fts(3) or stdio(3) _each time_ an ABI component changed. Now let's see if we can help CURRENT users without putting too much burden on our own back. That's where John's idea comes into play. When a symbol changes in 8-CURRENT for the first time, it gets promoted from FBSD_1.0 to, say, FBSD-current_1.0.1 while its 7.0-R variant is preserved at FBSD_1.0. If the same symbol or group of symbols has to change again and providing compatibility isn't too expensive, there appear 2 compat versions for it, FBSD_1.0 and FBSD-current_1.0.1, and 1 default version, FBSD_current-1.0.2. So CURRENT users can keep older ports dependent on the intermediate symbol(s). Just before the RELENG_8 branch, all default FBSD-current_1.0.* symbol versions, if any, are flattened into a single version, FBSD_1.1, while any compatibility shims at FBSD-current_* are dropped. So we end up with exactly the same 8.0-R library as in the previous example and from now on we have to support only one old variant (7.0-R) of each symbol changed since 7.0-R. The flattening of FBSD-current_* versions will be a flag day for port users, but they'll have to rebuild affected ports only once. Unfortunately, even those who built a dependent port a moment before the flag day will have to rebuild it after the flag day. Therefore we should recall how often multiple changes to the same ABI component happened between a pair of successive major releases to justify this approach. We can keep the last FBSD-current_1.0.* symbols as aliases for FBSD_1.1 symbols in HEAD for a while, but it means greater support burden and dependent ports still need to be eventually rebuilt. Perhaps this is a way to go only in case multiple changes to the same ABI component are really likely to happen. As for committing new FBSD_1.1 versions of the fts(3) symbols right now, there's nothing wrong with it technically, but it would set a poor example of having old symbols around that have never been in a release. Note that releases prior to 7.0 don't count here because "fts_open" != "fts_open@FBSD_1.0". I hope I didn't misinterpret any ideas. :-) -- Yar From owner-cvs-src@FreeBSD.ORG Tue Aug 28 00:57:43 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 693E316A419; Tue, 28 Aug 2007 00:57:43 +0000 (UTC) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id 3F09613C465; Tue, 28 Aug 2007 00:57:43 +0000 (UTC) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.1/8.14.1) with ESMTP id l7S0v0xP053804; Mon, 27 Aug 2007 17:57:00 -0700 (PDT) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.1/8.14.1/Submit) id l7S0uspm053795; Mon, 27 Aug 2007 17:56:54 -0700 (PDT) (envelope-from obrien) Date: Mon, 27 Aug 2007 17:56:54 -0700 From: "David O'Brien" To: "M. Warner Losh" Message-ID: <20070828005654.GA50401@dragon.NUXI.org> References: <20070824.172212.74696955.imp@bsdimp.com> <20070824.213615.146406398.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070824.213615.146406398.imp@bsdimp.com> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.11 Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, deischen@freebsd.org, cvs-src@freebsd.org, yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 00:57:43 -0000 On Fri, Aug 24, 2007 at 09:36:15PM -0600, M. Warner Losh wrote: > In message: > Daniel Eischen writes: > : I guess the build system should be more tolerant of this, but > : there are bound to be problems regardless. I don't see why > : the install tools can't also either have their own set of > : libraries (utilizing LD_LIBRARY_PATH) or be built static. > > There's much resistance to building everything that the build system > might be used being build static. It adds too much time and > complexity to the build system, the opponents say. I've never heard an argument against building these bits static. What's the issue? -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Tue Aug 28 01:31:01 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4125A16A418; Tue, 28 Aug 2007 01:31:01 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id EB66913C45A; Tue, 28 Aug 2007 01:31:00 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7S1UmHf018963; Mon, 27 Aug 2007 21:30:48 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Mon, 27 Aug 2007 21:30:48 -0400 (EDT) Date: Mon, 27 Aug 2007 21:30:48 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Yar Tikhiy In-Reply-To: <20070828004842.GT21352@comp.chem.msu.su> Message-ID: References: <200708270850.20904.jhb@freebsd.org> <200708271715.21462.jhb@freebsd.org> <200708271757.01674.jhb@freebsd.org> <20070828004842.GT21352@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, John Baldwin , peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 01:31:01 -0000 On Tue, 28 Aug 2007, Yar Tikhiy wrote: > > Example: Assume we released 7.0-R with all symbols at FBSD_1.0. > Before the 8.0 release cycle starts, struct FTS and struct FILE > change, perhaps a few times each, thus affecting the fts(3) and > stdio(3) global symbols. At the very first change to a symbol or > their group, its 7.0-R variant is preserved at FBSD_1.0 and its > default version becomes FBSD_1.1. Later changes to the current > variant of that symbol don't affect its version. Consequently, > 8.0-R is released with the new fts(3) and stdio(3) symbols at > FBSD_1.1, their 7.0-R variants at FBSD_1.0, and the rest of symbols > still at FBSD_1.0 because they are unchanged. Let's note that > CURRENT users had to rebuild ports depending on fts(3) or stdio(3) > _each time_ an ABI component changed. I think you're a little confused here. CURRENT users did NOT have to rebuild ports when fts(3) or stdio(3) ABIs changed. They would only have to rebuild if one of these ABIs changed _more than once between releases_. That hasn't ever happened to my knowledge in the past, and it really shouldn't happen as long as things are tested and reviewed properly. -- DE From owner-cvs-src@FreeBSD.ORG Tue Aug 28 02:32:03 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F37416A419; Tue, 28 Aug 2007 02:32:03 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 5941713C457; Tue, 28 Aug 2007 02:32:03 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l7S2UPIc007172; Mon, 27 Aug 2007 20:30:25 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 27 Aug 2007 20:30:29 -0600 (MDT) Message-Id: <20070827.203029.-432838018.imp@bsdimp.com> To: obrien@freebsd.org From: "M. Warner Losh" In-Reply-To: <20070828005654.GA50401@dragon.NUXI.org> References: <20070824.213615.146406398.imp@bsdimp.com> <20070828005654.GA50401@dragon.NUXI.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 27 Aug 2007 20:30:26 -0600 (MDT) Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, deischen@freebsd.org, cvs-src@freebsd.org, yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 02:32:03 -0000 In message: <20070828005654.GA50401@dragon.NUXI.org> "David O'Brien" writes: : On Fri, Aug 24, 2007 at 09:36:15PM -0600, M. Warner Losh wrote: : > In message: : > Daniel Eischen writes: : > : I guess the build system should be more tolerant of this, but : > : there are bound to be problems regardless. I don't see why : > : the install tools can't also either have their own set of : > : libraries (utilizing LD_LIBRARY_PATH) or be built static. : > : > There's much resistance to building everything that the build system : > might be used being build static. It adds too much time and : > complexity to the build system, the opponents say. : : I've never heard an argument against building these bits static. : What's the issue? I thought you were one of the folks making this argument when we last changed the FILE structure and related hangers on. None of the binaries is built static by default, so we'd need to build new versions of them static to make this scheme work. We cannot count on them being static in the release that we're upgrading from. However, if we do build new versions static, then they would depend on the new version of the kernel rather than the current version of the kernel. Warner From owner-cvs-src@FreeBSD.ORG Tue Aug 28 02:39:13 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7907916A420; Tue, 28 Aug 2007 02:39:13 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id 7469E13C457; Tue, 28 Aug 2007 02:39:11 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7S2cvmb085139; Tue, 28 Aug 2007 06:38:57 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7S2cv7J085138; Tue, 28 Aug 2007 06:38:57 +0400 (MSD) (envelope-from yar) Date: Tue, 28 Aug 2007 06:38:57 +0400 From: Yar Tikhiy To: Daniel Eischen Message-ID: <20070828023857.GW21352@comp.chem.msu.su> References: <200708270850.20904.jhb@freebsd.org> <200708271715.21462.jhb@freebsd.org> <200708271757.01674.jhb@freebsd.org> <20070828004842.GT21352@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Cc: src-committers@freebsd.org, John Baldwin , peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 02:39:13 -0000 On Mon, Aug 27, 2007 at 09:30:48PM -0400, Daniel Eischen wrote: > On Tue, 28 Aug 2007, Yar Tikhiy wrote: > > > >Example: Assume we released 7.0-R with all symbols at FBSD_1.0. > >Before the 8.0 release cycle starts, struct FTS and struct FILE > >change, perhaps a few times each, thus affecting the fts(3) and > >stdio(3) global symbols. At the very first change to a symbol or > >their group, its 7.0-R variant is preserved at FBSD_1.0 and its > >default version becomes FBSD_1.1. Later changes to the current > >variant of that symbol don't affect its version. Consequently, > >8.0-R is released with the new fts(3) and stdio(3) symbols at > >FBSD_1.1, their 7.0-R variants at FBSD_1.0, and the rest of symbols > >still at FBSD_1.0 because they are unchanged. Let's note that > >CURRENT users had to rebuild ports depending on fts(3) or stdio(3) > >_each time_ an ABI component changed. > > I think you're a little confused here. CURRENT users did NOT have > to rebuild ports when fts(3) or stdio(3) ABIs changed. They > would only have to rebuild if one of these ABIs changed _more > than once between releases_. That hasn't ever happened to my > knowledge in the past, and it really shouldn't happen as long > as things are tested and reviewed properly. Oh, indeed! If a user builds an ABI-dependent port before the change, the port will record dependence on say fwrite@FBSD_1.0. In our example, the default version of fwrite() and friends will change to FBSD_1.1 later, after 7.0-RELEASE is out, but fwrite@FBSD_1.0 will also stay as a compatibility version because it appeared in the previous release. Moreover, the port will still work even if the ABI component changes once more after 8.0-RELEASE and proceeds to FBSD_1.2, because fwrite@FBSD_1.0 will be there. Similarly, a port built between 7.0-R and 8.0-R will work after the 2nd change as fwrite@FBSD_1.1 will be there, too. I can't but remark that this is not a natural effect of symbol versioning, but a consequence from the following policy: - At most one new version is introduced between major releases. - Symbol modifications during the period are assigned to the new version. - There is exactly one change per symbol per version. - All old symbol versions created so far are preserved. Now we have at least one policy with known behavior. :-) -- Yar From owner-cvs-src@FreeBSD.ORG Tue Aug 28 02:46:29 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 96A2F16A46B; Tue, 28 Aug 2007 02:46:29 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 264DE13C4A5; Tue, 28 Aug 2007 02:46:29 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l7S2kDne007322; Mon, 27 Aug 2007 20:46:13 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 27 Aug 2007 20:46:18 -0600 (MDT) Message-Id: <20070827.204618.-1350500405.imp@bsdimp.com> To: deischen@freebsd.org From: "M. Warner Losh" In-Reply-To: References: <20070828004842.GT21352@comp.chem.msu.su> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 27 Aug 2007 20:46:13 -0600 (MDT) Cc: src-committers@freebsd.org, jhb@freebsd.org, yar@comp.chem.msu.su, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, peterjeremy@optushome.com.au Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 02:46:29 -0000 In message: Daniel Eischen writes: : On Tue, 28 Aug 2007, Yar Tikhiy wrote: : > : > Example: Assume we released 7.0-R with all symbols at FBSD_1.0. : > Before the 8.0 release cycle starts, struct FTS and struct FILE : > change, perhaps a few times each, thus affecting the fts(3) and : > stdio(3) global symbols. At the very first change to a symbol or : > their group, its 7.0-R variant is preserved at FBSD_1.0 and its : > default version becomes FBSD_1.1. Later changes to the current : > variant of that symbol don't affect its version. Consequently, : > 8.0-R is released with the new fts(3) and stdio(3) symbols at : > FBSD_1.1, their 7.0-R variants at FBSD_1.0, and the rest of symbols : > still at FBSD_1.0 because they are unchanged. Let's note that : > CURRENT users had to rebuild ports depending on fts(3) or stdio(3) : > _each time_ an ABI component changed. : : I think you're a little confused here. CURRENT users did NOT have : to rebuild ports when fts(3) or stdio(3) ABIs changed. They : would only have to rebuild if one of these ABIs changed _more : than once between releases_. That hasn't ever happened to my : knowledge in the past, and it really shouldn't happen as long : as things are tested and reviewed properly. One of the reasons that it hasn't happened before is that we forced people who tried to make, or proposed making, such changes to make them in a compatible sort of way. We have all kinds of ugliness in and around FILE to try, alas in vain, to be compatible. One of the reasons people would like to see symbol versioning is to make it easier to change the size of different structures because we have stood on our heads in the past to not change sizes. I'm concerned that the empirical evidence from the past might not be a good thing to base our future plans upon. We knew we had sucky tools to deal with binary incompatibility in the past, so we stood on our heads to not make too many binary incompatible changes. With that limitation gone, I think the likelihood is large we will see multiple ABI changes between major releases on something. Especially since it happens when structures change size and there are many functions that take pointers to multiple structures... Warner From owner-cvs-src@FreeBSD.ORG Tue Aug 28 03:34:28 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C682916A41A; Tue, 28 Aug 2007 03:34:28 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 6388A13C46B; Tue, 28 Aug 2007 03:34:28 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l7S3YJuR007616; Mon, 27 Aug 2007 21:34:19 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 27 Aug 2007 21:34:24 -0600 (MDT) Message-Id: <20070827.213424.1678771352.imp@bsdimp.com> To: yar@comp.chem.msu.su From: "M. Warner Losh" In-Reply-To: <20070828023857.GW21352@comp.chem.msu.su> References: <20070828004842.GT21352@comp.chem.msu.su> <20070828023857.GW21352@comp.chem.msu.su> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 27 Aug 2007 21:34:20 -0600 (MDT) Cc: src-committers@freebsd.org, jhb@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, deischen@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 03:34:28 -0000 In message: <20070828023857.GW21352@comp.chem.msu.su> Yar Tikhiy writes: : On Mon, Aug 27, 2007 at 09:30:48PM -0400, Daniel Eischen wrote: : > On Tue, 28 Aug 2007, Yar Tikhiy wrote: : > > : > >Example: Assume we released 7.0-R with all symbols at FBSD_1.0. : > >Before the 8.0 release cycle starts, struct FTS and struct FILE : > >change, perhaps a few times each, thus affecting the fts(3) and : > >stdio(3) global symbols. At the very first change to a symbol or : > >their group, its 7.0-R variant is preserved at FBSD_1.0 and its : > >default version becomes FBSD_1.1. Later changes to the current : > >variant of that symbol don't affect its version. Consequently, : > >8.0-R is released with the new fts(3) and stdio(3) symbols at : > >FBSD_1.1, their 7.0-R variants at FBSD_1.0, and the rest of symbols : > >still at FBSD_1.0 because they are unchanged. Let's note that : > >CURRENT users had to rebuild ports depending on fts(3) or stdio(3) : > >_each time_ an ABI component changed. : > : > I think you're a little confused here. CURRENT users did NOT have : > to rebuild ports when fts(3) or stdio(3) ABIs changed. They : > would only have to rebuild if one of these ABIs changed _more : > than once between releases_. That hasn't ever happened to my : > knowledge in the past, and it really shouldn't happen as long : > as things are tested and reviewed properly. : : Oh, indeed! If a user builds an ABI-dependent port before the : change, the port will record dependence on say fwrite@FBSD_1.0. In : our example, the default version of fwrite() and friends will change : to FBSD_1.1 later, after 7.0-RELEASE is out, but fwrite@FBSD_1.0 : will also stay as a compatibility version because it appeared in : the previous release. Moreover, the port will still work even if : the ABI component changes once more after 8.0-RELEASE and proceeds : to FBSD_1.2, because fwrite@FBSD_1.0 will be there. Similarly, a : port built between 7.0-R and 8.0-R will work after the 2nd change : as fwrite@FBSD_1.1 will be there, too. : : I can't but remark that this is not a natural effect of symbol : versioning, but a consequence from the following policy: : : - At most one new version is introduced between major releases. : - Symbol modifications during the period are assigned to the new version. : - There is exactly one change per symbol per version. : - All old symbol versions created so far are preserved. : : Now we have at least one policy with known behavior. :-) How is this a natural consequence of this policy? If one were to bump twice, how would that break it? Warner From owner-cvs-src@FreeBSD.ORG Tue Aug 28 03:49:36 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 886DE16A417; Tue, 28 Aug 2007 03:49:36 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 2618913C45A; Tue, 28 Aug 2007 03:49:36 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l7S3lR9s007679; Mon, 27 Aug 2007 21:47:27 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 27 Aug 2007 21:47:31 -0600 (MDT) Message-Id: <20070827.214731.635732686.imp@bsdimp.com> To: yar@comp.chem.msu.su From: "M. Warner Losh" In-Reply-To: <20070828023857.GW21352@comp.chem.msu.su> References: <20070828004842.GT21352@comp.chem.msu.su> <20070828023857.GW21352@comp.chem.msu.su> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 27 Aug 2007 21:47:27 -0600 (MDT) Cc: src-committers@freebsd.org, jhb@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, deischen@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 03:49:36 -0000 In message: <20070828023857.GW21352@comp.chem.msu.su> Yar Tikhiy writes: : On Mon, Aug 27, 2007 at 09:30:48PM -0400, Daniel Eischen wrote: : > On Tue, 28 Aug 2007, Yar Tikhiy wrote: : > > : > >Example: Assume we released 7.0-R with all symbols at FBSD_1.0. : > >Before the 8.0 release cycle starts, struct FTS and struct FILE : > >change, perhaps a few times each, thus affecting the fts(3) and : > >stdio(3) global symbols. At the very first change to a symbol or : > >their group, its 7.0-R variant is preserved at FBSD_1.0 and its : > >default version becomes FBSD_1.1. Later changes to the current : > >variant of that symbol don't affect its version. Consequently, : > >8.0-R is released with the new fts(3) and stdio(3) symbols at : > >FBSD_1.1, their 7.0-R variants at FBSD_1.0, and the rest of symbols : > >still at FBSD_1.0 because they are unchanged. Let's note that : > >CURRENT users had to rebuild ports depending on fts(3) or stdio(3) : > >_each time_ an ABI component changed. : > : > I think you're a little confused here. CURRENT users did NOT have : > to rebuild ports when fts(3) or stdio(3) ABIs changed. They : > would only have to rebuild if one of these ABIs changed _more : > than once between releases_. That hasn't ever happened to my : > knowledge in the past, and it really shouldn't happen as long : > as things are tested and reviewed properly. : : Oh, indeed! If a user builds an ABI-dependent port before the : change, the port will record dependence on say fwrite@FBSD_1.0. In : our example, the default version of fwrite() and friends will change : to FBSD_1.1 later, after 7.0-RELEASE is out, but fwrite@FBSD_1.0 : will also stay as a compatibility version because it appeared in : the previous release. Moreover, the port will still work even if : the ABI component changes once more after 8.0-RELEASE and proceeds : to FBSD_1.2, because fwrite@FBSD_1.0 will be there. Similarly, a : port built between 7.0-R and 8.0-R will work after the 2nd change : as fwrite@FBSD_1.1 will be there, too. : : I can't but remark that this is not a natural effect of symbol : versioning, but a consequence from the following policy: : : - At most one new version is introduced between major releases. : - Symbol modifications during the period are assigned to the new version. : - There is exactly one change per symbol per version. : - All old symbol versions created so far are preserved. : : Now we have at least one policy with known behavior. :-) Or rather, isn't this just the consequences of the way the script that generates things works? Warner From owner-cvs-src@FreeBSD.ORG Tue Aug 28 04:27:36 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B3E2016A419; Tue, 28 Aug 2007 04:27:36 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay02.kiev.sovam.com (relay02.kiev.sovam.com [62.64.120.197]) by mx1.freebsd.org (Postfix) with ESMTP id 545C613C45A; Tue, 28 Aug 2007 04:27:36 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [212.82.216.226] (helo=deviant.kiev.zoral.com.ua) by relay02.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1IPsfm-000LDX-Kr; Tue, 28 Aug 2007 07:27:35 +0300 Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1) with ESMTP id l7S4RNwq022731; Tue, 28 Aug 2007 07:27:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1/Submit) id l7S4RNaH022728; Tue, 28 Aug 2007 07:27:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 28 Aug 2007 07:27:22 +0300 From: Kostik Belousov To: "M. Warner Losh" Message-ID: <20070828042722.GQ2332@deviant.kiev.zoral.com.ua> References: <20070824.213615.146406398.imp@bsdimp.com> <20070828005654.GA50401@dragon.NUXI.org> <20070827.203029.-432838018.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6wUvnnXCCq76soZt" Content-Disposition: inline In-Reply-To: <20070827.203029.-432838018.imp@bsdimp.com> User-Agent: Mutt/1.4.2.3i X-Scanner-Signature: fa718887f43e9e3967a9d10f43843ba4 X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Info: Profiles 1410 [August 27 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {received from trusted relay: not dialup} X-SpamTest-Method: none X-SpamTest-Method: Local Lists X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 04:27:36 -0000 --6wUvnnXCCq76soZt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 27, 2007 at 08:30:29PM -0600, M. Warner Losh wrote: > In message: <20070828005654.GA50401@dragon.NUXI.org> > "David O'Brien" writes: > : On Fri, Aug 24, 2007 at 09:36:15PM -0600, M. Warner Losh wrote: > : > In message: > : > Daniel Eischen writes: > : > : I guess the build system should be more tolerant of this, but > : > : there are bound to be problems regardless. I don't see why > : > : the install tools can't also either have their own set of > : > : libraries (utilizing LD_LIBRARY_PATH) or be built static. > : >=20 > : > There's much resistance to building everything that the build system > : > might be used being build static. It adds too much time and > : > complexity to the build system, the opponents say. > :=20 > : I've never heard an argument against building these bits static. > : What's the issue? >=20 > I thought you were one of the folks making this argument when we last > changed the FILE structure and related hangers on. >=20 > None of the binaries is built static by default, so we'd need to build It seems that toolchain is built static. Even binaries that go into the DESTDIR are static: % file /usr/bin/ld /usr/bin/ld: ELF 32-bit LSB executable, Intel 80386, version 1 (FreeBSD), s= tatically linked, stripped The same is true for as, cc, libexec/cc1, make. The list is definitely not exhaustive. > new versions of them static to make this scheme work. We cannot count > on them being static in the release that we're upgrading from. > However, if we do build new versions static, then they would depend on > the new version of the kernel rather than the current version of the > kernel. >=20 > Warner --6wUvnnXCCq76soZt Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFG06QqC3+MBN1Mb4gRAplCAJwLH5ElJZZxM50H5KnDAbu3LlPMHACgrIuo VglV+Bp3oHxuaykEWtj6GxU= =Jz6Z -----END PGP SIGNATURE----- --6wUvnnXCCq76soZt-- From owner-cvs-src@FreeBSD.ORG Tue Aug 28 04:31:44 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5C8A116A419; Tue, 28 Aug 2007 04:31:44 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 0D4D413C46A; Tue, 28 Aug 2007 04:31:43 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7S4VWK4025780; Tue, 28 Aug 2007 00:31:32 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Tue, 28 Aug 2007 00:31:33 -0400 (EDT) Date: Tue, 28 Aug 2007 00:31:32 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: "M. Warner Losh" In-Reply-To: <20070827.204618.-1350500405.imp@bsdimp.com> Message-ID: References: <20070828004842.GT21352@comp.chem.msu.su> <20070827.204618.-1350500405.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, jhb@freebsd.org, yar@comp.chem.msu.su, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, peterjeremy@optushome.com.au Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 04:31:44 -0000 On Mon, 27 Aug 2007, M. Warner Losh wrote: > In message: > Daniel Eischen writes: > : I think you're a little confused here. CURRENT users did NOT have > : to rebuild ports when fts(3) or stdio(3) ABIs changed. They > : would only have to rebuild if one of these ABIs changed _more > : than once between releases_. That hasn't ever happened to my > : knowledge in the past, and it really shouldn't happen as long > : as things are tested and reviewed properly. > > One of the reasons that it hasn't happened before is that we forced > people who tried to make, or proposed making, such changes to make > them in a compatible sort of way. We have all kinds of ugliness in > and around FILE to try, alas in vain, to be compatible. One of the > reasons people would like to see symbol versioning is to make it > easier to change the size of different structures because we have > stood on our heads in the past to not change sizes. > > I'm concerned that the empirical evidence from the past might not be a > good thing to base our future plans upon. We knew we had sucky tools > to deal with binary incompatibility in the past, so we stood on our > heads to not make too many binary incompatible changes. With that > limitation gone, I think the likelihood is large we will see multiple > ABI changes between major releases on something. Especially since it > happens when structures change size and there are many functions that > take pointers to multiple structures... The emphasis should be on trying to get things right, tested, and reviewed the first time ;-) But also to keep compat shims to a minimum too. It may be easier to create different versions and keep compatibility, but the SV'd libraries are going to grow with compat shims if we don't try to reduce ABI changes like we've done in the past. I think we need an ABI review board monitored by -standards ;-) If you are really concerned about it (I'm not!), then you can always add another version in between releases, or just bump the version every time you break an ABI in -current. I'm not advocating this because I don't think it's necessary. I don't think you need to have both private and public versions in -current, just use 1.x and bump x for every ABI change. -current will always have all versions 1.0 - 1.x, and prior branches will have some of them. Whenever -current is branched, both the branch and -current will once again have all versions until the ABI in -current changes again. -- DE From owner-cvs-src@FreeBSD.ORG Tue Aug 28 08:38:09 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 61FBC16A473; Tue, 28 Aug 2007 08:38:09 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id F284B13C468; Tue, 28 Aug 2007 08:38:07 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7S8bdSu090878; Tue, 28 Aug 2007 12:37:39 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7S8baS2090875; Tue, 28 Aug 2007 12:37:37 +0400 (MSD) (envelope-from yar) Date: Tue, 28 Aug 2007 12:37:36 +0400 From: Yar Tikhiy To: "M. Warner Losh" Message-ID: <20070828083736.GX21352@comp.chem.msu.su> References: <20070828004842.GT21352@comp.chem.msu.su> <20070828023857.GW21352@comp.chem.msu.su> <20070827.213424.1678771352.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070827.213424.1678771352.imp@bsdimp.com> User-Agent: Mutt/1.5.9i Cc: src-committers@freebsd.org, jhb@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, deischen@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 08:38:09 -0000 On Mon, Aug 27, 2007 at 09:34:24PM -0600, M. Warner Losh wrote: > In message: <20070828023857.GW21352@comp.chem.msu.su> > Yar Tikhiy writes: > : On Mon, Aug 27, 2007 at 09:30:48PM -0400, Daniel Eischen wrote: > : > On Tue, 28 Aug 2007, Yar Tikhiy wrote: > : > > > : > >Example: Assume we released 7.0-R with all symbols at FBSD_1.0. > : > >Before the 8.0 release cycle starts, struct FTS and struct FILE > : > >change, perhaps a few times each, thus affecting the fts(3) and > : > >stdio(3) global symbols. At the very first change to a symbol or > : > >their group, its 7.0-R variant is preserved at FBSD_1.0 and its > : > >default version becomes FBSD_1.1. Later changes to the current > : > >variant of that symbol don't affect its version. Consequently, > : > >8.0-R is released with the new fts(3) and stdio(3) symbols at > : > >FBSD_1.1, their 7.0-R variants at FBSD_1.0, and the rest of symbols > : > >still at FBSD_1.0 because they are unchanged. Let's note that > : > >CURRENT users had to rebuild ports depending on fts(3) or stdio(3) > : > >_each time_ an ABI component changed. > : > > : > I think you're a little confused here. CURRENT users did NOT have > : > to rebuild ports when fts(3) or stdio(3) ABIs changed. They > : > would only have to rebuild if one of these ABIs changed _more > : > than once between releases_. That hasn't ever happened to my > : > knowledge in the past, and it really shouldn't happen as long > : > as things are tested and reviewed properly. > : > : Oh, indeed! If a user builds an ABI-dependent port before the > : change, the port will record dependence on say fwrite@FBSD_1.0. In > : our example, the default version of fwrite() and friends will change > : to FBSD_1.1 later, after 7.0-RELEASE is out, but fwrite@FBSD_1.0 > : will also stay as a compatibility version because it appeared in > : the previous release. Moreover, the port will still work even if > : the ABI component changes once more after 8.0-RELEASE and proceeds > : to FBSD_1.2, because fwrite@FBSD_1.0 will be there. Similarly, a > : port built between 7.0-R and 8.0-R will work after the 2nd change > : as fwrite@FBSD_1.1 will be there, too. > : > : I can't but remark that this is not a natural effect of symbol > : versioning, but a consequence from the following policy: > : > : - At most one new version is introduced between major releases. > : - Symbol modifications during the period are assigned to the new version. > : - There is exactly one change per symbol per version. > : - All old symbol versions created so far are preserved. > : > : Now we have at least one policy with known behavior. :-) > > How is this a natural consequence of this policy? If one were to > bump twice, how would that break it? If we bump a symbol twice or more times between a pair of major releases while preserving its older versions for compatibility, we'll have to decide what to do with the intermediate versions later. If we keep them forever in the same manner as released versions are going to be kept, CURRENT users will be able to use ports built any time, exactly as in the above case. But, with a lot of such unreleased versions accumulated in the library, their support can need considerable efforts, e.g., if a security hole in all versions of the symbol is found. Perhaps we'll have to prune away the oldest unreleased versions periodically, but then some people will have to rebuild their old ports. Not a big deal, but the smoothness is lost to some extent. OTOH, if we bump a symbol twice or more times but preserve only its last released version, some people will have to rebuild some ports after the second and later bumps, namely ports built against an old intermediate version of the symbol, which we chose not to preserve. BTW, here are three more policies and their properties. :-) -- Yar From owner-cvs-src@FreeBSD.ORG Tue Aug 28 08:44:00 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 30A2216A41B; Tue, 28 Aug 2007 08:44:00 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id 5D2AD13C461; Tue, 28 Aug 2007 08:43:58 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7S8hYqQ091009; Tue, 28 Aug 2007 12:43:34 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7S8hX5Q091007; Tue, 28 Aug 2007 12:43:34 +0400 (MSD) (envelope-from yar) Date: Tue, 28 Aug 2007 12:43:33 +0400 From: Yar Tikhiy To: "M. Warner Losh" Message-ID: <20070828084333.GY21352@comp.chem.msu.su> References: <20070828004842.GT21352@comp.chem.msu.su> <20070828023857.GW21352@comp.chem.msu.su> <20070827.214731.635732686.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070827.214731.635732686.imp@bsdimp.com> User-Agent: Mutt/1.5.9i Cc: src-committers@freebsd.org, jhb@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, deischen@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 08:44:00 -0000 On Mon, Aug 27, 2007 at 09:47:31PM -0600, M. Warner Losh wrote: > In message: <20070828023857.GW21352@comp.chem.msu.su> > Yar Tikhiy writes: > : On Mon, Aug 27, 2007 at 09:30:48PM -0400, Daniel Eischen wrote: > : > On Tue, 28 Aug 2007, Yar Tikhiy wrote: > : > > > : > >Example: Assume we released 7.0-R with all symbols at FBSD_1.0. > : > >Before the 8.0 release cycle starts, struct FTS and struct FILE > : > >change, perhaps a few times each, thus affecting the fts(3) and > : > >stdio(3) global symbols. At the very first change to a symbol or > : > >their group, its 7.0-R variant is preserved at FBSD_1.0 and its > : > >default version becomes FBSD_1.1. Later changes to the current > : > >variant of that symbol don't affect its version. Consequently, > : > >8.0-R is released with the new fts(3) and stdio(3) symbols at > : > >FBSD_1.1, their 7.0-R variants at FBSD_1.0, and the rest of symbols > : > >still at FBSD_1.0 because they are unchanged. Let's note that > : > >CURRENT users had to rebuild ports depending on fts(3) or stdio(3) > : > >_each time_ an ABI component changed. > : > > : > I think you're a little confused here. CURRENT users did NOT have > : > to rebuild ports when fts(3) or stdio(3) ABIs changed. They > : > would only have to rebuild if one of these ABIs changed _more > : > than once between releases_. That hasn't ever happened to my > : > knowledge in the past, and it really shouldn't happen as long > : > as things are tested and reviewed properly. > : > : Oh, indeed! If a user builds an ABI-dependent port before the > : change, the port will record dependence on say fwrite@FBSD_1.0. In > : our example, the default version of fwrite() and friends will change > : to FBSD_1.1 later, after 7.0-RELEASE is out, but fwrite@FBSD_1.0 > : will also stay as a compatibility version because it appeared in > : the previous release. Moreover, the port will still work even if > : the ABI component changes once more after 8.0-RELEASE and proceeds > : to FBSD_1.2, because fwrite@FBSD_1.0 will be there. Similarly, a > : port built between 7.0-R and 8.0-R will work after the 2nd change > : as fwrite@FBSD_1.1 will be there, too. > : > : I can't but remark that this is not a natural effect of symbol > : versioning, but a consequence from the following policy: > : > : - At most one new version is introduced between major releases. > : - Symbol modifications during the period are assigned to the new version. > : - There is exactly one change per symbol per version. > : - All old symbol versions created so far are preserved. > : > : Now we have at least one policy with known behavior. :-) > > Or rather, isn't this just the consequences of the way the script that > generates things works? AFAIK, no. The script isn't that restrictive although it's Daniel who wrote it. :-) I think the script allows us to do almost anything we can do with a plain vanilla version map. It even supports multiple version axes, which is used now to separate standard functions from FreeBSD-specific functions. -- Yar From owner-cvs-src@FreeBSD.ORG Tue Aug 28 08:56:30 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6AD6C16A419; Tue, 28 Aug 2007 08:56:30 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (c220-239-20-82.belrs4.nsw.optusnet.com.au [220.239.20.82]) by mx1.freebsd.org (Postfix) with ESMTP id DC25A13C46E; Tue, 28 Aug 2007 08:56:29 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by turion.vk2pj.dyndns.org (8.14.1/8.14.1) with ESMTP id l7S8u8FZ002365; Tue, 28 Aug 2007 18:56:08 +1000 (EST) (envelope-from peter@turion.vk2pj.dyndns.org) Received: (from peter@localhost) by turion.vk2pj.dyndns.org (8.14.1/8.14.1/Submit) id l7S8u8d4002364; Tue, 28 Aug 2007 18:56:08 +1000 (EST) (envelope-from peter) Date: Tue, 28 Aug 2007 18:56:08 +1000 From: Peter Jeremy To: John Baldwin Message-ID: <20070828085608.GI1576@turion.vk2pj.dyndns.org> References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <200708270850.20904.jhb@freebsd.org> <20070827190100.GY87451@elvis.mu.org> <200708271529.42264.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CE+1k2dSO48ffgeK" Content-Disposition: inline In-Reply-To: <200708271529.42264.jhb@freebsd.org> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.16 (2007-06-09) Cc: src-committers@freebsd.org, yar@comp.chem.msu.su, Alfred Perlstein , cvs-all@freebsd.org, deischen@freebsd.org, cvs-src@freebsd.org, Warner Losh Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 08:56:30 -0000 --CE+1k2dSO48ffgeK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2007-Aug-27 15:29:41 -0400, John Baldwin wrote: >User questions. "I just upgraded via make world from 6.x to 7.0 and now I= =20 >have a libc.so.6 and a libc.so.8, what happened to libc.so.7, did somethin= g=20 >go wrong??? please help!!!!" One major difference is that the symbol versions are not immediately obvious from outside. A typical user is not going to see that lib.so.7 includes foo@FBSD1.0, bar@FBSD1.5, snafu@FBSD1.1 and snafu@FBSD1.2. Someone who notices this is probably going to be able to understand the explanation. We will, of course, get the 'I just upgraded to 8.0-RELEASE and I still have libc.so.7' questions in a few years. --=20 Peter Jeremy --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFG0+Mo/opHv/APuIcRAl0qAKC060PPDODjBjkGRxfQJUblQpkN5wCeL2Le cS5MDjz84EXprrMvrcjBTRk= =FzKj -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK-- From owner-cvs-src@FreeBSD.ORG Tue Aug 28 09:12:11 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 91A7A16A41B; Tue, 28 Aug 2007 09:12:11 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id D670813C4DE; Tue, 28 Aug 2007 09:12:10 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7S9BtX4091678; Tue, 28 Aug 2007 13:11:55 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7S9BsoC091677; Tue, 28 Aug 2007 13:11:54 +0400 (MSD) (envelope-from yar) Date: Tue, 28 Aug 2007 13:11:54 +0400 From: Yar Tikhiy To: "M. Warner Losh" Message-ID: <20070828091153.GZ21352@comp.chem.msu.su> References: <20070828004842.GT21352@comp.chem.msu.su> <20070828023857.GW21352@comp.chem.msu.su> <20070827.213424.1678771352.imp@bsdimp.com> <20070828083736.GX21352@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070828083736.GX21352@comp.chem.msu.su> User-Agent: Mutt/1.5.9i Cc: src-committers@freebsd.org, jhb@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, deischen@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 09:12:11 -0000 On Tue, Aug 28, 2007 at 12:37:36PM +0400, Yar Tikhiy wrote: > On Mon, Aug 27, 2007 at 09:34:24PM -0600, M. Warner Losh wrote: > > In message: <20070828023857.GW21352@comp.chem.msu.su> > > Yar Tikhiy writes: > > : > > : Oh, indeed! If a user builds an ABI-dependent port before the > > : change, the port will record dependence on say fwrite@FBSD_1.0. In > > : our example, the default version of fwrite() and friends will change > > : to FBSD_1.1 later, after 7.0-RELEASE is out, but fwrite@FBSD_1.0 > > : will also stay as a compatibility version because it appeared in > > : the previous release. Moreover, the port will still work even if > > : the ABI component changes once more after 8.0-RELEASE and proceeds > > : to FBSD_1.2, because fwrite@FBSD_1.0 will be there. Similarly, a > > : port built between 7.0-R and 8.0-R will work after the 2nd change > > : as fwrite@FBSD_1.1 will be there, too. > > : > > : I can't but remark that this is not a natural effect of symbol > > : versioning, but a consequence from the following policy: > > : > > : - At most one new version is introduced between major releases. > > : - Symbol modifications during the period are assigned to the new version. > > : - There is exactly one change per symbol per version. > > : - All old symbol versions created so far are preserved. > > : > > : Now we have at least one policy with known behavior. :-) > > > > How is this a natural consequence of this policy? If one were to > > bump twice, how would that break it? > > If we bump a symbol twice or more times between a pair of major > releases while preserving its older versions for compatibility, > we'll have to decide what to do with the intermediate versions > later. If we keep them forever in the same manner as released > versions are going to be kept, CURRENT users will be able to use > ports built any time, exactly as in the above case. But, with a > lot of such unreleased versions accumulated in the library, their > support can need considerable efforts, e.g., if a security hole in > all versions of the symbol is found. Perhaps we'll have to prune > away the oldest unreleased versions periodically, but then some > people will have to rebuild their old ports. Not a big deal, but > the smoothness is lost to some extent. Another caveat of these two policies came to my mind. What to do with the old intermediate versions of symbols when the next RELENG_X is branched? For pure STABLE and RELEASE users they are nothing but dead code, so it would make sense to remove them from the branch. OTOH, dropping them will create a pain for those who gets tired of CURRENT and decides to take a turn to the new STABLE branch because ports linked against the dropped versions will need a rebuild. But, upon a second thought, so we'll bind such people to CURRENT forever and prevent their desertion. :-) -- Yar From owner-cvs-src@FreeBSD.ORG Tue Aug 28 10:22:36 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CC39916A417; Tue, 28 Aug 2007 10:22:36 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from optimus.centralmiss.com (ns.centralmiss.com [206.156.254.79]) by mx1.freebsd.org (Postfix) with ESMTP id 992C213C461; Tue, 28 Aug 2007 10:22:36 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from draco.over-yonder.net (adsl-072-148-013-213.sip.jan.bellsouth.net [72.148.13.213]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by optimus.centralmiss.com (Postfix) with ESMTP id D4A4028B42; Tue, 28 Aug 2007 04:51:50 -0500 (CDT) Received: by draco.over-yonder.net (Postfix, from userid 100) id 566AB61C42; Tue, 28 Aug 2007 04:51:50 -0500 (CDT) Date: Tue, 28 Aug 2007 04:51:50 -0500 From: "Matthew D. Fuller" To: Yar Tikhiy Message-ID: <20070828095150.GL96011@over-yonder.net> References: <20070828004842.GT21352@comp.chem.msu.su> <20070828023857.GW21352@comp.chem.msu.su> <20070827.213424.1678771352.imp@bsdimp.com> <20070828083736.GX21352@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070828083736.GX21352@comp.chem.msu.su> X-Editor: vi X-OS: FreeBSD User-Agent: Mutt/1.5.16-fullermd.4 (2007-06-09) Cc: src-committers@freebsd.org, jhb@freebsd.org, cvs-src@freebsd.org, alfred@freebsd.org, cvs-all@freebsd.org, deischen@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 10:22:36 -0000 On Tue, Aug 28, 2007 at 12:37:36PM +0400 I heard the voice of Yar Tikhiy, and lo! it spake thus: > > Perhaps we'll have to prune away the oldest unreleased versions > periodically, but then some people will have to rebuild their old > ports. Well, but you can rebuild the ports before the fact. That's smooth. >From a how-miserable-life-is standpoint, and given the two cases: 1) We have a new version of XYZ ABI that new compiles will build against. The old one will be removed in 6 months. At that time, anything built before today will break. 2) We're putting in a new version of the XYZ ABI. Anything built even momentarily before you installworld will break instantly after that. One of the choices is much, much, _much_ nicer than the other. A good percentage of programs on a given server will probably get rebuilt over 6 months as a matter of course, as new versions come out. The only disruption (1) will cause is that stuff that wouldn't otherwise will need to be rebuilt "sometime in the next few months" to keep working after the flag. It can be handled smoothly (not 'automatically', perhaps, but a passingly attentive sysadmin can easily jump the river without any visible issues). (2) can't. It'll disrupt everything, and there's no way to prepare for it in advance. Of course, it'd be nice to have "3) Everything always works forever". But (1) is in practice very close to that, and likely a leetle bit less work :) -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Systems/Network Administrator | http://www.over-yonder.net/~fullermd/ On the Internet, nobody can hear you scream. From owner-cvs-src@FreeBSD.ORG Tue Aug 28 12:26:35 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D913016A41A; Tue, 28 Aug 2007 12:26:35 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id CA37613C48E; Tue, 28 Aug 2007 12:26:35 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7SCQZ7L063106; Tue, 28 Aug 2007 12:26:35 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7SCQZOE063105; Tue, 28 Aug 2007 12:26:35 GMT (envelope-from kib) Message-Id: <200708281226.l7SCQZOE063105@repoman.freebsd.org> From: Konstantin Belousov Date: Tue, 28 Aug 2007 12:26:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/linux32 syscalls.master src/sys/compat/linux linux_misc.c src/sys/i386/linux syscalls.master X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 12:26:36 -0000 kib 2007-08-28 12:26:35 UTC FreeBSD src repository Modified files: sys/amd64/linux32 syscalls.master sys/compat/linux linux_misc.c sys/i386/linux syscalls.master Log: Implement fake linux sched_getaffinity() syscall to enable java to work with Linux 2.6 emulation. This shall be reimplemented once FreeBSD gets native scheduler affinity syscalls. Submitted by: rdivacky Reviewed by: jkim Sponsored by: Google Summer of Code 2007 Approved by: re (kensmith) Revision Changes Path 1.29 +2 -1 src/sys/amd64/linux32/syscalls.master 1.214 +21 -0 src/sys/compat/linux/linux_misc.c 1.88 +2 -1 src/sys/i386/linux/syscalls.master From owner-cvs-src@FreeBSD.ORG Tue Aug 28 12:32:02 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2F2C316A420; Tue, 28 Aug 2007 12:32:02 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 099A913C478; Tue, 28 Aug 2007 12:32:02 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7SCW1KM063576; Tue, 28 Aug 2007 12:32:01 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7SCW156063575; Tue, 28 Aug 2007 12:32:01 GMT (envelope-from kib) Message-Id: <200708281232.l7SCW156063575@repoman.freebsd.org> From: Konstantin Belousov Date: Tue, 28 Aug 2007 12:32:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/linux linux_proto.h linux_syscall.h linux_sysent.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 12:32:02 -0000 kib 2007-08-28 12:32:01 UTC FreeBSD src repository Modified files: sys/i386/linux linux_proto.h linux_syscall.h linux_sysent.c Log: Regenerate. Approved by: re (kensmith) Revision Changes Path 1.93 +15 -1 src/sys/i386/linux/linux_proto.h 1.86 +2 -1 src/sys/i386/linux/linux_syscall.h 1.93 +2 -2 src/sys/i386/linux/linux_sysent.c From owner-cvs-src@FreeBSD.ORG Tue Aug 28 12:36:24 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 35E5D16A419; Tue, 28 Aug 2007 12:36:24 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 1086E13C459; Tue, 28 Aug 2007 12:36:24 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7SCaNEl063861; Tue, 28 Aug 2007 12:36:23 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7SCaNYX063860; Tue, 28 Aug 2007 12:36:23 GMT (envelope-from kib) Message-Id: <200708281236.l7SCaNYX063860@repoman.freebsd.org> From: Konstantin Belousov Date: Tue, 28 Aug 2007 12:36:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/linux32 linux32_proto.h linux32_syscall.h linux32_sysent.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 12:36:24 -0000 kib 2007-08-28 12:36:23 UTC FreeBSD src repository Modified files: sys/amd64/linux32 linux32_proto.h linux32_syscall.h linux32_sysent.c Log: Regenerate. Approved by: re (kensmith) Revision Changes Path 1.32 +15 -1 src/sys/amd64/linux32/linux32_proto.h 1.32 +2 -1 src/sys/amd64/linux32/linux32_syscall.h 1.32 +2 -2 src/sys/amd64/linux32/linux32_sysent.c From owner-cvs-src@FreeBSD.ORG Tue Aug 28 15:47:42 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C0D9716A417; Tue, 28 Aug 2007 15:47:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9845513C459; Tue, 28 Aug 2007 15:47:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7SFlgLj090179; Tue, 28 Aug 2007 15:47:42 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7SFlgrl090178; Tue, 28 Aug 2007 15:47:42 GMT (envelope-from jhb) Message-Id: <200708281547.l7SFlgrl090178@repoman.freebsd.org> From: John Baldwin Date: Tue, 28 Aug 2007 15:47:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/amd64/amd64 io_apic.c src/sys/i386/i386 io_apic.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 15:47:42 -0000 jhb 2007-08-28 15:47:41 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/amd64/amd64 io_apic.c sys/i386/i386 io_apic.c Log: MFC: Move 'intbase != expected base' warning under boot verbose. Requested by: delphij Revision Changes Path 1.15.2.9 +1 -1 src/sys/amd64/amd64/io_apic.c 1.20.2.9 +1 -1 src/sys/i386/i386/io_apic.c From owner-cvs-src@FreeBSD.ORG Tue Aug 28 16:19:21 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 04E9016A417; Tue, 28 Aug 2007 16:19:21 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 7583113C465; Tue, 28 Aug 2007 16:19:20 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k2) with ESMTP id 205811547-1834499 for multiple; Tue, 28 Aug 2007 12:19:32 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l7SGJ4YU039259; Tue, 28 Aug 2007 12:19:06 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Yar Tikhiy Date: Tue, 28 Aug 2007 11:42:06 -0400 User-Agent: KMail/1.9.6 References: <200708270850.20904.jhb@freebsd.org> <20070828004842.GT21352@comp.chem.msu.su> In-Reply-To: <20070828004842.GT21352@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708281142.07941.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 28 Aug 2007 12:19:08 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4088/Tue Aug 28 07:51:32 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, Daniel Eischen , cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 16:19:21 -0000 On Monday 27 August 2007 08:48:42 pm Yar Tikhiy wrote: > On Mon, Aug 27, 2007 at 06:01:22PM -0400, Daniel Eischen wrote: > > On Mon, 27 Aug 2007, John Baldwin wrote: > > > > >On Monday 27 August 2007 05:38:08 pm Daniel Eischen wrote: > > >>>>it is today. > > >>> > > >>>So you want to just bump the version everytime a change happens in HEAD? > > >> > > >>No, I don't see how you get that from what I said... > > > > > >You originally objected to having fts compat symbols as 1.0 and wanted the > > >new > > >fts to be 1.0. Now you are saying that the new fts can be 1.1 and the old > > >ones (only used in old current) can remain 1.0. > > > > > >That is, now you are saying to do what Yar originally wanted to do before > > >you > > >objected. > > > > No, I still think they should be 1.0 or wait till after the > > release. I just made some assumption for the sake of giving > > an example. > > It's time to summarize previous discussion to prevent further > misunderstanding. :-) > > Let's recall the point all sides of this discussion seem to share: > symbol versions can give us ability to run binaries from a former > _release_ in a later _release_ without installing compat libraries. > Obviously, it will be available only after 7.0-RELEASE, the first > release with symbol versioning. _If this ability is the only goal_, > Daniel's position makes sense as it implies a minimal number of > distinct version labels and compatibility shims to support later. > I.e., we allow new version labels only after 7.0-RELEASE and we > allow at most one new version label for each successive major > release. That's how we make sure that every old version of a symbol > appeared in at least one former release, so that we don't have to > support old versions without release history. > > I say "version label" to emphasize the fact that the same version > strings of different symbols can correspond to totally unrelated > changes in them, which Daniel pointed out already. I.e., each > symbol can travel along the version axis independently. Moreover, > it's technically possible to have a separate version axis for as > little as each symbol, but it would be gross. > > Example: Assume we released 7.0-R with all symbols at FBSD_1.0. > Before the 8.0 release cycle starts, struct FTS and struct FILE > change, perhaps a few times each, thus affecting the fts(3) and > stdio(3) global symbols. At the very first change to a symbol or > their group, its 7.0-R variant is preserved at FBSD_1.0 and its > default version becomes FBSD_1.1. Later changes to the current > variant of that symbol don't affect its version. Consequently, > 8.0-R is released with the new fts(3) and stdio(3) symbols at > FBSD_1.1, their 7.0-R variants at FBSD_1.0, and the rest of symbols > still at FBSD_1.0 because they are unchanged. Let's note that > CURRENT users had to rebuild ports depending on fts(3) or stdio(3) > _each time_ an ABI component changed. > > Now let's see if we can help CURRENT users without putting too much > burden on our own back. That's where John's idea comes into play. > When a symbol changes in 8-CURRENT for the first time, it gets > promoted from FBSD_1.0 to, say, FBSD-current_1.0.1 while its 7.0-R > variant is preserved at FBSD_1.0. If the same symbol or group of > symbols has to change again and providing compatibility isn't too > expensive, there appear 2 compat versions for it, FBSD_1.0 and > FBSD-current_1.0.1, and 1 default version, FBSD_current-1.0.2. So > CURRENT users can keep older ports dependent on the intermediate > symbol(s). Just before the RELENG_8 branch, all default > FBSD-current_1.0.* symbol versions, if any, are flattened into a > single version, FBSD_1.1, while any compatibility shims at > FBSD-current_* are dropped. So we end up with exactly the same > 8.0-R library as in the previous example and from now on we have > to support only one old variant (7.0-R) of each symbol changed since > 7.0-R. The flattening of FBSD-current_* versions will be a flag > day for port users, but they'll have to rebuild affected ports only > once. Unfortunately, even those who built a dependent port a moment > before the flag day will have to rebuild it after the flag day. > Therefore we should recall how often multiple changes to the same > ABI component happened between a pair of successive major releases > to justify this approach. We can keep the last FBSD-current_1.0.* > symbols as aliases for FBSD_1.1 symbols in HEAD for a while, but > it means greater support burden and dependent ports still need > to be eventually rebuilt. Perhaps this is a way to go only in > case multiple changes to the same ABI component are really likely > to happen. > > As for committing new FBSD_1.1 versions of the fts(3) symbols right > now, there's nothing wrong with it technically, but it would set a > poor example of having old symbols around that have never been in > a release. Note that releases prior to 7.0 don't count here because > "fts_open" != "fts_open@FBSD_1.0". > > I hope I didn't misinterpret any ideas. :-) I think this is dead on, yes. Only comment I would add is that I think the "flag days" should be when a new RELENG_X is branched and that all the FBSD-current shims get tossed in the RELENG_X branch. The FBSD-current shims can be dropped from HEAD on a separate schedule, maybe where they get dropped after they've been around for 6 months or so. This does mean that stepping off -CURRENT onto RELENG_X requires a rebuild of your ports for any symbols that changed since RELENG_X-1, but I think that is tolerable. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Tue Aug 28 16:19:26 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2CF3216A56D; Tue, 28 Aug 2007 16:19:25 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 32BC313C46B; Tue, 28 Aug 2007 16:19:24 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k2) with ESMTP id 205811552-1834499 for multiple; Tue, 28 Aug 2007 12:19:34 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l7SGJ4YV039259; Tue, 28 Aug 2007 12:19:10 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Daniel Eischen Date: Tue, 28 Aug 2007 11:44:43 -0400 User-Agent: KMail/1.9.6 References: <20070827.204618.-1350500405.imp@bsdimp.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708281144.45019.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 28 Aug 2007 12:19:10 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4088/Tue Aug 28 07:51:32 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, yar@comp.chem.msu.su, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 16:19:26 -0000 On Tuesday 28 August 2007 12:31:32 am Daniel Eischen wrote: > On Mon, 27 Aug 2007, M. Warner Losh wrote: > > > In message: > > Daniel Eischen writes: > > : I think you're a little confused here. CURRENT users did NOT have > > : to rebuild ports when fts(3) or stdio(3) ABIs changed. They > > : would only have to rebuild if one of these ABIs changed _more > > : than once between releases_. That hasn't ever happened to my > > : knowledge in the past, and it really shouldn't happen as long > > : as things are tested and reviewed properly. > > > > One of the reasons that it hasn't happened before is that we forced > > people who tried to make, or proposed making, such changes to make > > them in a compatible sort of way. We have all kinds of ugliness in > > and around FILE to try, alas in vain, to be compatible. One of the > > reasons people would like to see symbol versioning is to make it > > easier to change the size of different structures because we have > > stood on our heads in the past to not change sizes. > > > > I'm concerned that the empirical evidence from the past might not be a > > good thing to base our future plans upon. We knew we had sucky tools > > to deal with binary incompatibility in the past, so we stood on our > > heads to not make too many binary incompatible changes. With that > > limitation gone, I think the likelihood is large we will see multiple > > ABI changes between major releases on something. Especially since it > > happens when structures change size and there are many functions that > > take pointers to multiple structures... > > The emphasis should be on trying to get things right, tested, and > reviewed the first time ;-) But also to keep compat shims to a > minimum too. It may be easier to create different versions and > keep compatibility, but the SV'd libraries are going to grow with > compat shims if we don't try to reduce ABI changes like we've > done in the past. I think we need an ABI review board monitored > by -standards ;-) > > If you are really concerned about it (I'm not!), then you can > always add another version in between releases, or just bump > the version every time you break an ABI in -current. I'm not > advocating this because I don't think it's necessary. I don't > think you need to have both private and public versions in > -current, just use 1.x and bump x for every ABI change. -current > will always have all versions 1.0 - 1.x, and prior branches > will have some of them. Whenever -current is branched, both > the branch and -current will once again have all versions > until the ABI in -current changes again. See, I'd like to minimize the number of symbols in RELENG_x branches to actually be the symbols used only in prior RELENG_x branches as a way to cap the bloat some. Things don't get always get done right in -HEAD on the first try, but the FBSD-current thing gives us a strategy to allow HEAD to be fluid to eventually get things right while not bloating RELENG_x branches with unneeded compat shims. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Tue Aug 28 17:07:50 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 03DF916A41A; Tue, 28 Aug 2007 17:07:50 +0000 (UTC) (envelope-from emax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id CDDAE13C4D5; Tue, 28 Aug 2007 17:07:49 +0000 (UTC) (envelope-from emax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7SH7nXK006576; Tue, 28 Aug 2007 17:07:49 GMT (envelope-from emax@repoman.freebsd.org) Received: (from emax@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7SH7nNt006575; Tue, 28 Aug 2007 17:07:49 GMT (envelope-from emax) Message-Id: <200708281707.l7SH7nNt006575@repoman.freebsd.org> From: Maksim Yevmenkin Date: Tue, 28 Aug 2007 17:07:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/netgraph/bluetooth/socket ng_btsocket_l2cap.c ng_btsocket_rfcomm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 17:07:50 -0000 emax 2007-08-28 17:07:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netgraph/bluetooth/socket ng_btsocket_l2cap.c ng_btsocket_rfcomm.c Log: MFC: Return EADDRNOTAVAIL instead of EDESTADDRREQ error when listen(2) is called on improperly bound socket. Revision Changes Path 1.16.2.1 +1 -1 src/sys/netgraph/bluetooth/socket/ng_btsocket_l2cap.c 1.17.2.2 +1 -1 src/sys/netgraph/bluetooth/socket/ng_btsocket_rfcomm.c From owner-cvs-src@FreeBSD.ORG Tue Aug 28 17:18:52 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8D2CF16A468; Tue, 28 Aug 2007 17:18:52 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id BBF8C13C4B4; Tue, 28 Aug 2007 17:18:51 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7SHIcOx012508; Tue, 28 Aug 2007 13:18:38 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Tue, 28 Aug 2007 13:18:39 -0400 (EDT) Date: Tue, 28 Aug 2007 13:18:38 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: John Baldwin In-Reply-To: <200708281142.07941.jhb@freebsd.org> Message-ID: References: <200708270850.20904.jhb@freebsd.org> <20070828004842.GT21352@comp.chem.msu.su> <200708281142.07941.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, Yar Tikhiy , alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 17:18:52 -0000 On Tue, 28 Aug 2007, John Baldwin wrote: > > I think this is dead on, yes. Only comment I would add is that I think > the "flag days" should be when a new RELENG_X is branched and that all the > FBSD-current shims get tossed in the RELENG_X branch. The FBSD-current shims > can be dropped from HEAD on a separate schedule, maybe where they get dropped > after they've been around for 6 months or so. This does mean that stepping > off -CURRENT onto RELENG_X requires a rebuild of your ports for any symbols > that changed since RELENG_X-1, but I think that is tolerable. The only thing I would add is that we can do this by using the real public versions in -current instead of private ones only seen in current. By using the public versions, -current users will never have to rebuild any of their ports _unless_ the same ABI changed more than once in -current, and that has never happened in the past. If it does happen, you can remove interim versions from RELENG_X at the branch, and then remove the interim version from -current some time later. This is the same approach as using a "private in current" version namespace. The only disadvantage is that you might be missing a version or two in RELENG_X if you remove an interim FBSD_1.4 for instance. The other problem with the private version namespace thing is that it doesn't allow for MFC'ing an ABI change to RELENG_X. It also causes you to change a lot of files (Symbol.map files, source files with compat shims) whenever you have the flag day and move from FBSDcurrent_1.x to FBSD_1.1. It is so much more simpler to use the same versioning in -current as for releases. It is easier to MFC, doesn't cause unneeded changes to Symbol.map files and compat shims, doesn't cause -current users to rebuild ports after flag day (unless there are overlapping ABI changes), and still provides everything that using the private version namespace provides. -- DE From owner-cvs-src@FreeBSD.ORG Tue Aug 28 18:03:41 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B361416A418; Tue, 28 Aug 2007 18:03:41 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 22B7C13C4CB; Tue, 28 Aug 2007 18:03:40 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k2) with ESMTP id 205829202-1834499 for multiple; Tue, 28 Aug 2007 14:03:48 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l7SI3MSc040032; Tue, 28 Aug 2007 14:03:24 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Daniel Eischen Date: Tue, 28 Aug 2007 14:03:04 -0400 User-Agent: KMail/1.9.6 References: <200708270850.20904.jhb@freebsd.org> <200708281142.07941.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708281403.05931.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 28 Aug 2007 14:03:24 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4088/Tue Aug 28 07:51:32 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, Yar Tikhiy , alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 18:03:41 -0000 On Tuesday 28 August 2007 01:18:38 pm Daniel Eischen wrote: > On Tue, 28 Aug 2007, John Baldwin wrote: > > > > I think this is dead on, yes. Only comment I would add is that I think > > the "flag days" should be when a new RELENG_X is branched and that all the > > FBSD-current shims get tossed in the RELENG_X branch. The FBSD-current shims > > can be dropped from HEAD on a separate schedule, maybe where they get dropped > > after they've been around for 6 months or so. This does mean that stepping > > off -CURRENT onto RELENG_X requires a rebuild of your ports for any symbols > > that changed since RELENG_X-1, but I think that is tolerable. > > The only thing I would add is that we can do this by using the > real public versions in -current instead of private ones only > seen in current. By using the public versions, -current users > will never have to rebuild any of their ports _unless_ the > same ABI changed more than once in -current, and that has > never happened in the past. If it does happen, you can > remove interim versions from RELENG_X at the branch, and > then remove the interim version from -current some time later. > This is the same approach as using a "private in current" > version namespace. The only disadvantage is that you might > be missing a version or two in RELENG_X if you remove an > interim FBSD_1.4 for instance. Yes, but how do you know which ones are interim versions that are safe to be removed? Having separate namespaces makes this clear. > The other problem with the private version namespace thing > is that it doesn't allow for MFC'ing an ABI change to RELENG_X. > It also causes you to change a lot of files (Symbol.map files, > source files with compat shims) whenever you have the flag > day and move from FBSDcurrent_1.x to FBSD_1.1. You can manage the MFC by making the symbol a "public" symbol and then MFC'ing it into the public namespace. Changing a lot of files is a true point. > It is so much more simpler to use the same versioning in > -current as for releases. It is easier to MFC, doesn't > cause unneeded changes to Symbol.map files and compat shims, > doesn't cause -current users to rebuild ports after flag > day (unless there are overlapping ABI changes), and still > provides everything that using the private version namespace > provides. Note that if you stick on HEAD you won't have a flag day, the flag change is on the RELENG_x branch, so only if you are following HEAD and decide to follow the new RELENG_x branch rather than staying on HEAD do you have a flag day. That is, if one did a bump to foo@fbsd-current-1.0.1 a week before RELENG_12 was branched, then at the time of the branch, foo@fbsd-current-1.0.1 gets "tagged" as foo@fbsd-1.1, then in the branch foo@fbsd-current-1.0.1 label gets dropped, but in HEAD the foo@fbsd-current-1.0.1 label might stick around for 4 months. The one thing that the simpler case doesn't provide is a clear delineation between "extra" versions in the case that one does multiple ABI bumps in HEAD. This really hinges on how often we expect that to happen I guess. If we (collectively) don't expect it to be often, perhaps then the simple policy (just use the real versions always, and bump for everything, including this fts(3) change) can be used for now, and if we find at some point that we do have a lot of extra versions we can then revisit the policy. Also, one variation based on what Yar said earlier that I hadn't thought of, is that we could use fbsd-X.Y.Z as the "private" versions for HEAD if one did use the more complicated scheme. Anyways. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Tue Aug 28 18:15:53 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CE67716A418; Tue, 28 Aug 2007 18:15:53 +0000 (UTC) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id A160413C4E1; Tue, 28 Aug 2007 18:15:53 +0000 (UTC) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.1/8.14.1) with ESMTP id l7SIErjV086130; Tue, 28 Aug 2007 11:14:53 -0700 (PDT) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.1/8.14.1/Submit) id l7SIEqhS086129; Tue, 28 Aug 2007 11:14:52 -0700 (PDT) (envelope-from obrien) Date: Tue, 28 Aug 2007 11:14:52 -0700 From: "David O'Brien" To: "M. Warner Losh" Message-ID: <20070828181452.GA78587@dragon.NUXI.org> References: <20070824.213615.146406398.imp@bsdimp.com> <20070828005654.GA50401@dragon.NUXI.org> <20070827.203029.-432838018.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070827.203029.-432838018.imp@bsdimp.com> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.11 Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, deischen@freebsd.org, cvs-src@freebsd.org, yar@comp.chem.msu.su Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 18:15:53 -0000 On Mon, Aug 27, 2007 at 08:30:29PM -0600, M. Warner Losh wrote: > In message: <20070828005654.GA50401@dragon.NUXI.org> > "David O'Brien" writes: > : On Fri, Aug 24, 2007 at 09:36:15PM -0600, M. Warner Losh wrote: > : > In message: > : > Daniel Eischen writes: > : > : I guess the build system should be more tolerant of this, but > : > : there are bound to be problems regardless. I don't see why > : > : the install tools can't also either have their own set of > : > : libraries (utilizing LD_LIBRARY_PATH) or be built static. > : > > : > There's much resistance to building everything that the build system > : > might be used being build static. It adds too much time and > : > complexity to the build system, the opponents say. > : > : I've never heard an argument against building these bits static. > : What's the issue? > > I thought you were one of the folks making this argument when we last > changed the FILE structure and related hangers on. Hum, I don't recall having that position against static binaries. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Tue Aug 28 18:49:33 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7DE8F16A419; Tue, 28 Aug 2007 18:49:33 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5345E13C465; Tue, 28 Aug 2007 18:49:33 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7SInXL2018740; Tue, 28 Aug 2007 18:49:33 GMT (envelope-from mav@repoman.freebsd.org) Received: (from mav@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7SInXaf018739; Tue, 28 Aug 2007 18:49:33 GMT (envelope-from mav) Message-Id: <200708281849.l7SInXaf018739@repoman.freebsd.org> From: Alexander Motin Date: Tue, 28 Aug 2007 18:49:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/man/man4 ng_ppp.4 src/sys/netgraph ng_ppp.c ng_ppp.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 18:49:33 -0000 mav 2007-08-28 18:49:33 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man4 ng_ppp.4 sys/netgraph ng_ppp.c ng_ppp.h Log: MFC ng_ppp.c rev. 1.68, 1.69. Add proper fine-grained node locking. Add 64bit statistic counters. Revision Changes Path 1.24.2.2 +8 -0 src/share/man/man4/ng_ppp.4 1.57.2.3 +192 -74 src/sys/netgraph/ng_ppp.c 1.12.2.2 +30 -0 src/sys/netgraph/ng_ppp.h From owner-cvs-src@FreeBSD.ORG Tue Aug 28 20:15:30 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F3B4916A417; Tue, 28 Aug 2007 20:15:29 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 8E1D313C46E; Tue, 28 Aug 2007 20:15:29 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7SKFHlv026662; Tue, 28 Aug 2007 16:15:17 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Tue, 28 Aug 2007 16:15:18 -0400 (EDT) Date: Tue, 28 Aug 2007 16:15:16 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: John Baldwin In-Reply-To: <200708281403.05931.jhb@freebsd.org> Message-ID: References: <200708270850.20904.jhb@freebsd.org> <200708281142.07941.jhb@freebsd.org> <200708281403.05931.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, peterjeremy@optushome.com.au, Yar Tikhiy , alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 20:15:30 -0000 On Tue, 28 Aug 2007, John Baldwin wrote: > On Tuesday 28 August 2007 01:18:38 pm Daniel Eischen wrote: >> >> The only thing I would add is that we can do this by using the >> real public versions in -current instead of private ones only >> seen in current. By using the public versions, -current users >> will never have to rebuild any of their ports _unless_ the >> same ABI changed more than once in -current, and that has >> never happened in the past. If it does happen, you can >> remove interim versions from RELENG_X at the branch, and >> then remove the interim version from -current some time later. >> This is the same approach as using a "private in current" >> version namespace. The only disadvantage is that you might >> be missing a version or two in RELENG_X if you remove an >> interim FBSD_1.4 for instance. > > Yes, but how do you know which ones are interim versions that are safe to be > removed? Having separate namespaces makes this clear. Any symbol in the Symbol.map files (or the generated Version.map) that is duplicated from the point at which -current was last branched. If you go with my approach and only create one new version in -current, then it will be more obvious because the symbol(s) will already exist in -current's one and only version. That will force us to decide whether we should force a rebuild or just make a new version - it could be on a case by case basis if it ever happened. But even with the other approach (each ABI change creates a new version), you could write a script to find all the versions with duplicate symbols. I suppose you could even have it generate an ObsoleteVersions file that gets committed along with the most recent ABI change. -- DE From owner-cvs-src@FreeBSD.ORG Tue Aug 28 20:28:13 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7031616A419; Tue, 28 Aug 2007 20:28:13 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5B28313C45B; Tue, 28 Aug 2007 20:28:13 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7SKSDQg028066; Tue, 28 Aug 2007 20:28:13 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7SKSD4u028065; Tue, 28 Aug 2007 20:28:13 GMT (envelope-from jhb) Message-Id: <200708282028.l7SKSD4u028065@repoman.freebsd.org> From: John Baldwin Date: Tue, 28 Aug 2007 20:28:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/compat/freebsd32 freebsd32_misc.c src/sys/kern vfs_syscalls.c src/sys/sys mount.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 20:28:13 -0000 jhb 2007-08-28 20:28:12 UTC FreeBSD src repository Modified files: sys/compat/freebsd32 freebsd32_misc.c sys/kern vfs_syscalls.c sys/sys mount.h Log: Rework the routines to convert a 5.x+ statfs structure (with fixed-size 64-bit counters) to a 4.x statfs structure (with long-sized counters). - For block counters, we scale up the block size sufficiently large so that the resulting block counts fit into a the long-sized (long for the ABI, so 32-bit in freebsd32) counters. In 4.x the NFS client's statfs VOP did this already. This can lie about the block size to 4.x binaries, but it presents a more accurate picture of the ratios of free and available space. - For non-block counters, fix the freebsd32 stats converter to cap the values at INT32_MAX rather than losing the upper 32-bits to match the behavior of the 4.x statfs conversion routine in vfs_syscalls.c Approved by: re (kensmith) Revision Changes Path 1.67 +9 -9 src/sys/compat/freebsd32/freebsd32_misc.c 1.442 +46 -4 src/sys/kern/vfs_syscalls.c 1.227 +1 -0 src/sys/sys/mount.h From owner-cvs-src@FreeBSD.ORG Tue Aug 28 20:50:41 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EE6EA16A41A; Tue, 28 Aug 2007 20:50:41 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 7BB7A13C467; Tue, 28 Aug 2007 20:50:41 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k2) with ESMTP id 205854564-1834499 for multiple; Tue, 28 Aug 2007 16:50:10 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l7SKoP1o041231; Tue, 28 Aug 2007 16:50:25 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: src-committers@freebsd.org Date: Tue, 28 Aug 2007 16:50:20 -0400 User-Agent: KMail/1.9.6 References: <200708282028.l7SKSD4u028065@repoman.freebsd.org> In-Reply-To: <200708282028.l7SKSD4u028065@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708281650.20825.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 28 Aug 2007 16:50:25 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4088/Tue Aug 28 07:51:32 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/compat/freebsd32 freebsd32_misc.c src/sys/kern vfs_syscalls.c src/sys/sys mount.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2007 20:50:42 -0000 On Tuesday 28 August 2007 04:28:12 pm John Baldwin wrote: > jhb 2007-08-28 20:28:12 UTC > > FreeBSD src repository > > Modified files: > sys/compat/freebsd32 freebsd32_misc.c > sys/kern vfs_syscalls.c > sys/sys mount.h > Log: > Rework the routines to convert a 5.x+ statfs structure (with fixed-size > 64-bit counters) to a 4.x statfs structure (with long-sized counters). > - For block counters, we scale up the block size sufficiently large so > that the resulting block counts fit into a the long-sized (long for the > ABI, so 32-bit in freebsd32) counters. In 4.x the NFS client's statfs > VOP did this already. This can lie about the block size to 4.x > binaries, but it presents a more accurate picture of the ratios of free > and available space. > - For non-block counters, fix the freebsd32 stats converter to cap the > values at INT32_MAX rather than losing the upper 32-bits to match the > behavior of the 4.x statfs conversion routine in vfs_syscalls.c I'm open to suggestion on this point. I can see that for the true counters (like read/write operation counters) it might be more correct for them to wrap and just lose the upper 32-bits than to cap them. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Wed Aug 29 07:30:38 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8423616A41B; Wed, 29 Aug 2007 07:30:38 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id A891E13C442; Wed, 29 Aug 2007 07:30:36 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7T7UEuo022911; Wed, 29 Aug 2007 11:30:14 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7T7UBAO022909; Wed, 29 Aug 2007 11:30:11 +0400 (MSD) (envelope-from yar) Date: Wed, 29 Aug 2007 11:30:11 +0400 From: Yar Tikhiy To: Daniel Eischen Message-ID: <20070829073011.GD598@comp.chem.msu.su> References: <200708270850.20904.jhb@freebsd.org> <200708281142.07941.jhb@freebsd.org> <200708281403.05931.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Cc: src-committers@freebsd.org, John Baldwin , peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2007 07:30:38 -0000 On Tue, Aug 28, 2007 at 04:15:16PM -0400, Daniel Eischen wrote: > On Tue, 28 Aug 2007, John Baldwin wrote: > > >On Tuesday 28 August 2007 01:18:38 pm Daniel Eischen wrote: > >> > >>The only thing I would add is that we can do this by using the > >>real public versions in -current instead of private ones only > >>seen in current. By using the public versions, -current users > >>will never have to rebuild any of their ports _unless_ the > >>same ABI changed more than once in -current, and that has > >>never happened in the past. If it does happen, you can > >>remove interim versions from RELENG_X at the branch, and > >>then remove the interim version from -current some time later. > >>This is the same approach as using a "private in current" > >>version namespace. The only disadvantage is that you might > >>be missing a version or two in RELENG_X if you remove an > >>interim FBSD_1.4 for instance. > > > >Yes, but how do you know which ones are interim versions that are safe to > >be > >removed? Having separate namespaces makes this clear. > > Any symbol in the Symbol.map files (or the generated Version.map) > that is duplicated from the point at which -current was last > branched. > > If you go with my approach and only create one new version in > -current, then it will be more obvious because the symbol(s) > will already exist in -current's one and only version. That > will force us to decide whether we should force a rebuild or > just make a new version - it could be on a case by case basis > if it ever happened. > > But even with the other approach (each ABI change creates a > new version), you could write a script to find all the versions > with duplicate symbols. I suppose you could even have it > generate an ObsoleteVersions file that gets committed along > with the most recent ABI change. At this point we should consider technical limitations as well. I think I found a couple, unfortunately. On the one hand, John's approach depends on alias symbols in HEAD so, e.g., both foo@FBSD-1.9 (public) and foo@FBSD-current-1.8.5 (interim) can point to the same implementation for the "foo" interface after STABLE with foo@FBSD-1.9 was branched. However, the GNU build tools don't seem to provide a straight way to that, they return an error if multiple versions reference the same function, so more stub code will be needed in the library, which will add to complexity of the approach. On the other hand, Symbol.map files should not contain duplicate symbol names as it seems to violate ld(1) semantics. Therefore, if following Daniel's way, we'll need to track which symbols moved by more than one version since the last STABLE branch to find interim versions. This shouldn't be too hard, but the implementation details are somewhat different. -- Yar From owner-cvs-src@FreeBSD.ORG Wed Aug 29 13:30:24 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6ADF316A419; Wed, 29 Aug 2007 13:30:24 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id E781A13C459; Wed, 29 Aug 2007 13:30:23 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (p54A5718D.dip.t-dialin.net [84.165.113.141]) by redbull.bpaserver.net (Postfix) with ESMTP id 0BA3E2E302; Wed, 29 Aug 2007 15:30:00 +0200 (CEST) Received: from deskjail (deskjail.Leidinger.net [192.168.1.109]) by outgoing.leidinger.net (Postfix) with ESMTP id 8EF605B4996; Wed, 29 Aug 2007 15:29:57 +0200 (CEST) Date: Wed, 29 Aug 2007 15:29:57 +0200 From: Alexander Leidinger To: Yar Tikhiy Message-ID: <20070829152957.01a71f01@deskjail> In-Reply-To: <20070827151033.GM21352@comp.chem.msu.su> References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <20070824.172212.74696955.imp@bsdimp.com> <200708270850.20904.jhb@freebsd.org> <20070827135625.GF29854@garage.freebsd.pl> <20070827162655.3e3x0cse8w44o4o4@webmail.leidinger.net> <20070827151033.GM21352@comp.chem.msu.su> X-Mailer: Claws Mail 2.10.0 (GTK+ 2.10.14; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_bz.6H.ohFUk2cWgoLyAGY/_" X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.9, required 8, BAYES_00 -15.00, RDNS_DYNAMIC 0.10) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No X-Mailman-Approved-At: Wed, 29 Aug 2007 13:33:23 +0000 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: src-committers@FreeBSD.org, Pawel Jakub Dawidek , John Baldwin , peterjeremy@optushome.com.au, alfred@FreeBSD.org, cvs-all@FreeBSD.org, deischen@FreeBSD.org, cvs-src@FreeBSD.org, Warner Losh Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2007 13:30:24 -0000 --MP_bz.6H.ohFUk2cWgoLyAGY/_ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Quoting Yar Tikhiy (Mon, 27 Aug 2007 19:10:34 +0400): > On Mon, Aug 27, 2007 at 04:26:55PM +0200, Alexander Leidinger wrote: > > > > So the really important thing for you is: How many ports are affected > > by this change? > > > > Does anyone have an estimate for this? > > > > If not, does someone has an exhaustive list of affected symbols? I can > > write a short script which has a look into each installed port to > > determine if it is affected or not (based upon the assumption that you > > don't mind if we overlook a few things... I'm not sure if statically > > linked binaries contain enough information). > > With the resolution approaching to avoid compatibility in fts(3) > now and my experiment on improving src/Makefile.inc1 going on really > well, I think I should estimate which ports are going to be affected. > I'll do so by searching binary packages for CURRENT, so some ports > can slip through my sieve. The symbols to look for match the simple > pattern: fts_* (or regexp: ^fts_.*). I don't think there are a lot > of ports using those functions. > > Here's the exact list of symbols to be affected: > > fts_open > fts_close > fts_read > fts_set > fts_children > fts_get_clientptr > fts_get_stream > fts_set_clientptr > Attached are two scripts. find_fts.sh has to be in the PATH. It returns the files specified at the command line, which contain unresolved references to fts_* (e.g. "find_fts.sh /bin/*"). The other script parses a +CONTENTS file of an installed port and hands over the executables and libraries to find_fts.sh. If it finds a match, it prints the port origin. I let it run on my >800 installed ports via for i in /var/db/pkg/*;do; ./analyse_ports_for_fts_abi_change.sh $i;done It didn't find a match. I hope this is not because of a bug in my script... Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 --MP_bz.6H.ohFUk2cWgoLyAGY/_-- From owner-cvs-src@FreeBSD.ORG Wed Aug 29 14:04:04 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5BD6D16A46E; Wed, 29 Aug 2007 14:04:04 +0000 (UTC) (envelope-from eischen@vigrid.com) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 13C0E13C494; Wed, 29 Aug 2007 14:04:03 +0000 (UTC) (envelope-from eischen@vigrid.com) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7TE3fgJ001051; Wed, 29 Aug 2007 10:03:41 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Wed, 29 Aug 2007 10:03:41 -0400 (EDT) Date: Wed, 29 Aug 2007 10:03:41 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Yar Tikhiy In-Reply-To: <20070829073011.GD598@comp.chem.msu.su> Message-ID: References: <200708270850.20904.jhb@freebsd.org> <200708281142.07941.jhb@freebsd.org> <200708281403.05931.jhb@freebsd.org> <20070829073011.GD598@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, John Baldwin , peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2007 14:04:04 -0000 On Wed, 29 Aug 2007, Yar Tikhiy wrote: > On Tue, Aug 28, 2007 at 04:15:16PM -0400, Daniel Eischen wrote: >> On Tue, 28 Aug 2007, John Baldwin wrote: >> >> Any symbol in the Symbol.map files (or the generated Version.map) >> that is duplicated from the point at which -current was last >> branched. >> >> If you go with my approach and only create one new version in >> -current, then it will be more obvious because the symbol(s) >> will already exist in -current's one and only version. That >> will force us to decide whether we should force a rebuild or >> just make a new version - it could be on a case by case basis >> if it ever happened. >> >> But even with the other approach (each ABI change creates a >> new version), you could write a script to find all the versions >> with duplicate symbols. I suppose you could even have it >> generate an ObsoleteVersions file that gets committed along >> with the most recent ABI change. > > At this point we should consider technical limitations as well. > I think I found a couple, unfortunately. > > On the one hand, John's approach depends on alias symbols in HEAD > so, e.g., both foo@FBSD-1.9 (public) and foo@FBSD-current-1.8.5 > (interim) can point to the same implementation for the "foo" interface > after STABLE with foo@FBSD-1.9 was branched. However, the GNU build > tools don't seem to provide a straight way to that, they return an > error if multiple versions reference the same function, so more > stub code will be needed in the library, which will add to complexity > of the approach. I think you can use -z muldefs or --allow-multiple-definition as a linker argument to work around that. libpthread once did that (or something like it) so it could be compatible with libpthread.so.1 which used LIBPTHREAD_1_0 instead of FBSD_1_0. > On the other hand, Symbol.map files should not contain duplicate > symbol names as it seems to violate ld(1) semantics. Therefore, > if following Daniel's way, we'll need to track which symbols moved > by more than one version since the last STABLE branch to find interim > versions. This shouldn't be too hard, but the implementation details > are somewhat different. When someone changes the ABI, he's going to add a new set of symbols to a Symbol.map file. At this point before he commits he should notice that there are duplicated symbols. If he does, then he removes them and updates ObsoleteVersions. If he doesn't, then you have duplicate symbols ;-) Or you just have a script that does this for you (version_gen.awk might be a good starting point!). -- DE From owner-cvs-src@FreeBSD.ORG Wed Aug 29 15:04:27 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 37AA116A417; Wed, 29 Aug 2007 15:04:27 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 25E8F13C457; Wed, 29 Aug 2007 15:04:27 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7TF4Rqw073738; Wed, 29 Aug 2007 15:04:27 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7TF4Rdd073737; Wed, 29 Aug 2007 15:04:27 GMT (envelope-from netchild) Message-Id: <200708291504.l7TF4Rdd073737@repoman.freebsd.org> From: Alexander Leidinger Date: Wed, 29 Aug 2007 15:04:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/amd64/linux32 linux32_dummy.c linux32_machdep.c syscalls.master src/sys/compat/linux linux_file.c linux_ioctl.c linux_misc.c linux_stats.c linux_time.c src/sys/conf files.amd64 files.i386 files.pc98 src/sys/i386/linux linux_dummy.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2007 15:04:27 -0000 netchild 2007-08-29 15:04:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/amd64/linux32 linux32_dummy.c linux32_machdep.c syscalls.master sys/compat/linux linux_file.c linux_ioctl.c linux_misc.c linux_stats.c sys/conf files.amd64 files.i386 files.pc98 sys/i386/linux linux_dummy.c syscalls.master sys/modules/linux Makefile Added files: (Branch: RELENG_6) sys/compat/linux linux_time.c Log: MFC: - sync linuxulator: * add syscalls: + stat (i386, amd64) + iopl (i386, amd64) + mprotect (i386) + rt_sigpending (i386) + rt_sigtimedwait (i386) + statfs64 (i386, amd64) + utimes (i386, amd64) + settimeofday (amd64) + clock_* (i386, amd64) * de-COMPAT_43-ify: + sethostname + lstat + ftruncate + nanosleep (i386) * add more dummy syscalls so that we know what is needed Tested by: bsam (on i386/amd64 with LTP 20070630) Revision Changes Path 1.1.8.1 +40 -1 src/sys/amd64/linux32/linux32_dummy.c 1.10.2.3 +23 -17 src/sys/amd64/linux32/linux32_machdep.c 1.4.2.3 +62 -10 src/sys/amd64/linux32/syscalls.master 1.91.2.4 +15 -0 src/sys/compat/linux/linux_file.c 1.127.2.5 +31 -4 src/sys/compat/linux/linux_ioctl.c 1.170.2.7 +49 -0 src/sys/compat/linux/linux_misc.c 1.72.2.5 +113 -1 src/sys/compat/linux/linux_stats.c 1.2.2.1 +246 -0 src/sys/compat/linux/linux_time.c (new) 1.71.2.14 +1 -0 src/sys/conf/files.amd64 1.538.2.14 +1 -0 src/sys/conf/files.i386 1.327.2.8 +1 -0 src/sys/conf/files.pc98 1.38.8.1 +50 -1 src/sys/i386/linux/linux_dummy.c 1.61.2.3 +92 -27 src/sys/i386/linux/syscalls.master 1.63.2.3 +1 -1 src/sys/modules/linux/Makefile From owner-cvs-src@FreeBSD.ORG Wed Aug 29 15:05:38 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 409FB16A417; Wed, 29 Aug 2007 15:05:38 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 28DAD13C491; Wed, 29 Aug 2007 15:05:37 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7TF5aRC073883; Wed, 29 Aug 2007 15:05:36 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7TF5atX073882; Wed, 29 Aug 2007 15:05:36 GMT (envelope-from netchild) Message-Id: <200708291505.l7TF5atX073882@repoman.freebsd.org> From: Alexander Leidinger Date: Wed, 29 Aug 2007 15:05:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/i386/linux linux_proto.h linux_syscall.h linux_sysent.c src/sys/amd64/linux32 linux32_proto.h linux32_syscall.h linux32_sysent.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2007 15:05:38 -0000 netchild 2007-08-29 15:05:36 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/i386/linux linux_proto.h linux_syscall.h linux_sysent.c sys/amd64/linux32 linux32_proto.h linux32_syscall.h linux32_sysent.c Log: regen Revision Changes Path 1.5.2.3 +214 -1 src/sys/amd64/linux32/linux32_proto.h 1.5.2.3 +51 -4 src/sys/amd64/linux32/linux32_syscall.h 1.5.2.3 +52 -9 src/sys/amd64/linux32/linux32_sysent.c 1.64.2.3 +285 -5 src/sys/i386/linux/linux_proto.h 1.58.2.3 +62 -6 src/sys/i386/linux/linux_syscall.h 1.65.2.3 +65 -22 src/sys/i386/linux/linux_sysent.c From owner-cvs-src@FreeBSD.ORG Wed Aug 29 15:36:32 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 839AE16A417; Wed, 29 Aug 2007 15:36:32 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id 9478A13C459; Wed, 29 Aug 2007 15:36:31 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7TFaSwR035212; Wed, 29 Aug 2007 19:36:29 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7TFaSbB035211; Wed, 29 Aug 2007 19:36:28 +0400 (MSD) (envelope-from yar) Date: Wed, 29 Aug 2007 19:36:28 +0400 From: Yar Tikhiy To: Alexander Leidinger Message-ID: <20070829153628.GC31948@comp.chem.msu.su> References: <20070824215515.GF16131@turion.vk2pj.dyndns.org> <20070824.172212.74696955.imp@bsdimp.com> <200708270850.20904.jhb@freebsd.org> <20070827135625.GF29854@garage.freebsd.pl> <20070827162655.3e3x0cse8w44o4o4@webmail.leidinger.net> <20070827151033.GM21352@comp.chem.msu.su> <20070829152957.01a71f01@deskjail> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070829152957.01a71f01@deskjail> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2007 15:36:32 -0000 [Cc: list trimmed] On Wed, Aug 29, 2007 at 03:29:57PM +0200, Alexander Leidinger wrote: > Quoting Yar Tikhiy (Mon, 27 Aug 2007 19:10:34 +0400): > > > On Mon, Aug 27, 2007 at 04:26:55PM +0200, Alexander Leidinger wrote: > > > > > > So the really important thing for you is: How many ports are affected > > > by this change? > > > > > > Does anyone have an estimate for this? > > > > > > If not, does someone has an exhaustive list of affected symbols? I can > > > write a short script which has a look into each installed port to > > > determine if it is affected or not (based upon the assumption that you > > > don't mind if we overlook a few things... I'm not sure if statically > > > linked binaries contain enough information). > > > > With the resolution approaching to avoid compatibility in fts(3) > > now and my experiment on improving src/Makefile.inc1 going on really > > well, I think I should estimate which ports are going to be affected. > > I'll do so by searching binary packages for CURRENT, so some ports > > can slip through my sieve. The symbols to look for match the simple > > pattern: fts_* (or regexp: ^fts_.*). I don't think there are a lot > > of ports using those functions. > > > > Here's the exact list of symbols to be affected: > > > > fts_open > > fts_close > > fts_read > > fts_set > > fts_children > > fts_get_clientptr > > fts_get_stream > > fts_set_clientptr > > > > Attached are two scripts. find_fts.sh has to be in the PATH. It returns > the files specified at the command line, which contain unresolved > references to fts_* (e.g. "find_fts.sh /bin/*"). The other script > parses a +CONTENTS file of an installed port and hands over the > executables and libraries to find_fts.sh. If it finds a match, it > prints the port origin. > > I let it run on my >800 installed ports via > for i in /var/db/pkg/*;do; ./analyse_ports_for_fts_abi_change.sh $i;done > > It didn't find a match. I hope this is not because of a bug in my > script... Here's the list of ports that are likely to use fts(3) because binaries in their CURRENT packages reference fts_ symbols. Note, however, that it isn't 100% certain yet whether the ABI should be broken, so it may be a bit too early to worry about them. :-) archivers/xar audio/ifp-line cad/brlcad chinese/xmms deskutils/fusenshi ftp/ftpd-tls ftp/tnftpd japanese/jls mail/mboxgrep mail/qmail-remove multimedia/audacious multimedia/beep-media-player multimedia/xmms net-mgmt/nfdump-devel net/coda6_client net/coda6_server net/kissd news/husky-fidoconf news/husky-fidoconf-devel news/husky-hpt news/husky-hpt-devel news/husky-hptkill ports-mgmt/pkg_install ports-mgmt/pkg_install-devel russian/xmms security/amavisd-milter security/destroy security/rdigest security/srm sysutils/vcp textproc/bsdgrep textproc/freegrep www/polipo -- Yar From owner-cvs-src@FreeBSD.ORG Wed Aug 29 19:34:28 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9BFD016A41A; Wed, 29 Aug 2007 19:34:28 +0000 (UTC) (envelope-from green@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 74D2313C45D; Wed, 29 Aug 2007 19:34:28 +0000 (UTC) (envelope-from green@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7TJYSoR005707; Wed, 29 Aug 2007 19:34:28 GMT (envelope-from green@repoman.freebsd.org) Received: (from green@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7TJYSOa005706; Wed, 29 Aug 2007 19:34:28 GMT (envelope-from green) Message-Id: <200708291934.l7TJYSOa005706@repoman.freebsd.org> From: Brian Feldman Date: Wed, 29 Aug 2007 19:34:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet ip_fw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2007 19:34:28 -0000 green 2007-08-29 19:34:28 UTC FreeBSD src repository Modified files: sys/netinet ip_fw2.c Log: Repair ALTQ-tagging rules in IPFW which got broken in the last PF import. The PF mbuf-tagging support routines changed to link the allocated tags into the provided mbuf themselves, so the left-over m_tag_prepend() was trying to add a bogus (usually NULL) tag. Reviewed by: mlaier Approved by: re Revision Changes Path 1.173 +0 -1 src/sys/netinet/ip_fw2.c From owner-cvs-src@FreeBSD.ORG Wed Aug 29 21:00:58 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 15FF616A46B; Wed, 29 Aug 2007 21:00:58 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E284F13C46C; Wed, 29 Aug 2007 21:00:57 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7TL0vrB021189; Wed, 29 Aug 2007 21:00:57 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7TL0v7N021185; Wed, 29 Aug 2007 21:00:57 GMT (envelope-from imp) Message-Id: <200708292100.l7TL0v7N021185@repoman.freebsd.org> From: Warner Losh Date: Wed, 29 Aug 2007 21:00:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb usbdevs X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2007 21:00:58 -0000 imp 2007-08-29 21:00:57 UTC FreeBSD src repository Modified files: sys/dev/usb usbdevs Log: Add devices for the forthcoming zyd driver, ported from NetBSD, by Weongyo Jeong. Submitted by: Weongyo Jeong Approved by: re@ Revision Changes Path 1.327 +45 -0 src/sys/dev/usb/usbdevs From owner-cvs-src@FreeBSD.ORG Wed Aug 29 21:04:26 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4ECA16A41B; Wed, 29 Aug 2007 21:04:26 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9CA4613C459; Wed, 29 Aug 2007 21:04:26 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7TL4Qrx022766; Wed, 29 Aug 2007 21:04:26 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7TL4QVI022765; Wed, 29 Aug 2007 21:04:26 GMT (envelope-from imp) Message-Id: <200708292104.l7TL4QVI022765@repoman.freebsd.org> From: Warner Losh Date: Wed, 29 Aug 2007 21:04:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/modules/zyd Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2007 21:04:26 -0000 imp 2007-08-29 21:04:26 UTC FreeBSD src repository Added files: sys/modules/zyd Makefile Log: Makefile for building zyd kernel module. Submitted by: Weongyo Jeong Approved by: re@ (kensmith) Revision Changes Path 1.1 +10 -0 src/sys/modules/zyd/Makefile (new) From owner-cvs-src@FreeBSD.ORG Wed Aug 29 21:08:15 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4930316A469; Wed, 29 Aug 2007 21:08:15 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 20FAF13C46B; Wed, 29 Aug 2007 21:08:15 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7TL8F13023390; Wed, 29 Aug 2007 21:08:15 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7TL8EMk023389; Wed, 29 Aug 2007 21:08:14 GMT (envelope-from imp) Message-Id: <200708292108.l7TL8EMk023389@repoman.freebsd.org> From: Warner Losh Date: Wed, 29 Aug 2007 21:08:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 zyd.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2007 21:08:15 -0000 imp 2007-08-29 21:08:14 UTC FreeBSD src repository Added files: share/man/man4 zyd.4 Log: Bring in the man page for zyd, ported from NetBSD, complete with bogus Bill Paul copyright. Not sure what the right copyright is, but this file has been through 22 reversions on OpenBSD and 1 on NetBSD. This isn't (yet) connected to the build, just in case I've done something wrong (test builds worked, but better safe than sorry). Submitted by: Weongyo Jeong Approved by: re@ Revision Changes Path 1.1 +393 -0 src/share/man/man4/zyd.4 (new) From owner-cvs-src@FreeBSD.ORG Wed Aug 29 21:16:50 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC60B16A420; Wed, 29 Aug 2007 21:16:50 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 943FE13C459; Wed, 29 Aug 2007 21:16:50 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7TLGoP9025276; Wed, 29 Aug 2007 21:16:50 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7TLGo81025275; Wed, 29 Aug 2007 21:16:50 GMT (envelope-from imp) Message-Id: <200708292116.l7TLGo81025275@repoman.freebsd.org> From: Warner Losh Date: Wed, 29 Aug 2007 21:16:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb if_zyd.c if_zydfw.h if_zydreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2007 21:16:50 -0000 imp 2007-08-29 21:16:50 UTC FreeBSD src repository Added files: sys/dev/usb if_zyd.c if_zydfw.h if_zydreg.h Log: A port of the zyd driver from NetBSD by . This supports the ZyDAS ZD1211/ZD1211B USB IEEE 802.11b/g wireless network devices. Not (yet) connected to the build process (next batch of commits once I've looped the current back back). Submitted by: Weongyo Jeong Reviewed by: sam@ Approved by: re@ Revision Changes Path 1.1 +2694 -0 src/sys/dev/usb/if_zyd.c (new) 1.1 +1185 -0 src/sys/dev/usb/if_zydfw.h (new) 1.1 +1246 -0 src/sys/dev/usb/if_zydreg.h (new) From owner-cvs-src@FreeBSD.ORG Wed Aug 29 21:17:11 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BA83C16A41B; Wed, 29 Aug 2007 21:17:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8FE1D13C481; Wed, 29 Aug 2007 21:17:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7TLHB01025312; Wed, 29 Aug 2007 21:17:11 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7TLHBIi025311; Wed, 29 Aug 2007 21:17:11 GMT (envelope-from jhb) Message-Id: <200708292117.l7TLHBIi025311@repoman.freebsd.org> From: John Baldwin Date: Wed, 29 Aug 2007 21:17:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_ktrace.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2007 21:17:11 -0000 jhb 2007-08-29 21:17:11 UTC FreeBSD src repository Modified files: sys/kern kern_ktrace.c Log: Partially revert the previous change. I failed to notice that where ktruserret() is invoked, an unlocked check of the per-process queue is performed inline, thus, we don't lock the ktrace_sx on every userret(). Pointy hat to: jhb Approved by: re (kensmith) Pointy hat recovered from: rwatson Revision Changes Path 1.121 +0 -2 src/sys/kern/kern_ktrace.c From owner-cvs-src@FreeBSD.ORG Wed Aug 29 21:52:04 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7825916A418; Wed, 29 Aug 2007 21:52:04 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5005913C459; Wed, 29 Aug 2007 21:52:04 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7TLq4tD027605; Wed, 29 Aug 2007 21:52:04 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7TLq4F9027604; Wed, 29 Aug 2007 21:52:04 GMT (envelope-from thompsa) Message-Id: <200708292152.l7TLq4F9027604@repoman.freebsd.org> From: Andrew Thompson Date: Wed, 29 Aug 2007 21:52:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/iwi if_iwi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2007 21:52:04 -0000 thompsa 2007-08-29 21:52:03 UTC FreeBSD src repository Modified files: sys/dev/iwi if_iwi.c Log: Remove the lock assert from iwi_newstate, this function does not need the lock to be held and this will falsely trigger if called from net80211. Reported by: Munehiro (haro) Matsuda Reviewed by: sam Approved by: re (kensmith) Revision Changes Path 1.56 +0 -1 src/sys/dev/iwi/if_iwi.c From owner-cvs-src@FreeBSD.ORG Wed Aug 29 22:00:41 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 36BD716A418; Wed, 29 Aug 2007 22:00:41 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0E22C13C442; Wed, 29 Aug 2007 22:00:41 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7TM0e0L028073; Wed, 29 Aug 2007 22:00:40 GMT (envelope-from gabor@repoman.freebsd.org) Received: (from gabor@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7TM0e4Z028072; Wed, 29 Aug 2007 22:00:40 GMT (envelope-from gabor) Message-Id: <200708292200.l7TM0e4Z028072@repoman.freebsd.org> From: Gabor Kovesdan Date: Wed, 29 Aug 2007 22:00:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/man/man5 msdosfs.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2007 22:00:41 -0000 gabor 2007-08-29 22:00:40 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6) share/man/man5 msdosfs.5 Log: MFC rev 1.6 Approved by: keramida (mentor) Revision Changes Path 1.4.12.2 +2 -2 src/share/man/man5/msdosfs.5 From owner-cvs-src@FreeBSD.ORG Wed Aug 29 23:26:35 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4234716A417; Wed, 29 Aug 2007 23:26:35 +0000 (UTC) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 189D213C442; Wed, 29 Aug 2007 23:26:35 +0000 (UTC) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7TNQYGq035883; Wed, 29 Aug 2007 23:26:34 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7TNQY6V035882; Wed, 29 Aug 2007 23:26:34 GMT (envelope-from peter) Message-Id: <200708292326.l7TNQY6V035882@repoman.freebsd.org> From: Peter Wemm Date: Wed, 29 Aug 2007 23:26:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/amd64/amd64 mp_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2007 23:26:35 -0000 peter 2007-08-29 23:26:34 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/amd64/amd64 mp_machdep.c Log: MFC: rev 1.261. Set a stack for interrupt stack 1 (double fault) on AP cpus. This changes a guaranteed triple-fault (silent reset) into something that has a chance to work. Apparently, the NMI handler uses this stack too. Revision Changes Path 1.260.2.12 +6 -1 src/sys/amd64/amd64/mp_machdep.c From owner-cvs-src@FreeBSD.ORG Thu Aug 30 00:28:46 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 018F716A418; Thu, 30 Aug 2007 00:28:46 +0000 (UTC) (envelope-from dwhite@gumbysoft.com) Received: from carver.gumbysoft.com (carver.gumbysoft.com [66.220.23.50]) by mx1.freebsd.org (Postfix) with ESMTP id DA25D13C45D; Thu, 30 Aug 2007 00:28:45 +0000 (UTC) (envelope-from dwhite@gumbysoft.com) Received: by carver.gumbysoft.com (Postfix, from userid 1000) id 905C172DD9; Wed, 29 Aug 2007 17:01:06 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by carver.gumbysoft.com (Postfix) with ESMTP id 8E1E372DD7; Wed, 29 Aug 2007 17:01:06 -0700 (PDT) Date: Wed, 29 Aug 2007 17:01:06 -0700 (PDT) From: Doug White To: Alexander Leidinger In-Reply-To: <200708291504.l7TF4Rdd073737@repoman.freebsd.org> Message-ID: <20070829170005.G49868@carver.gumbysoft.com> References: <200708291504.l7TF4Rdd073737@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/linux32 linux32_dummy.c linux32_machdep.c syscalls.master src/sys/compat/linux linux_file.c linux_ioctl.c linux_misc.c linux_stats.c linux_time.c src/sys/conf files.amd64 files.i386 files.pc98 src/sys/i386/linux linux_dummy.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2007 00:28:46 -0000 This does not compile. the tgkill dummy syscall is declared twice in linux32_dummy.c. > Tested by: bsam (on i386/amd64 with LTP 20070630) -- Doug White | FreeBSD: The Power to Serve dwhite@gumbysoft.com | www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Thu Aug 30 00:45:42 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A795516A420; Thu, 30 Aug 2007 00:45:42 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.freebsd.org (Postfix) with ESMTP id 2D42013C46B; Thu, 30 Aug 2007 00:45:40 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.6/8.13.6) with ESMTP id l7U09clo022441; Wed, 29 Aug 2007 20:09:38 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: Warner Losh Date: Wed, 29 Aug 2007 20:09:33 -0400 User-Agent: KMail/1.6.2 References: <200708292108.l7TL8EMk023389@repoman.freebsd.org> In-Reply-To: <200708292108.l7TL8EMk023389@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200708292009.35386.jkim@FreeBSD.org> X-Virus-Scanned: ClamAV 0.90.2/4107/Wed Aug 29 12:16:42 2007 on anuket.mj.niksun.com X-Virus-Status: Clean Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man4 zyd.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2007 00:45:42 -0000 On Wednesday 29 August 2007 05:08 pm, Warner Losh wrote: > imp 2007-08-29 21:08:14 UTC > > FreeBSD src repository > > Added files: > share/man/man4 zyd.4 > Log: > Bring in the man page for zyd, ported from NetBSD, complete with > bogus Bill Paul copyright. Not sure what the right copyright is, > but this file has been through 22 reversions on OpenBSD and 1 on > NetBSD. This isn't (yet) connected to the build, just in case I've > done something wrong (test builds worked, but better safe than > sorry). According to OpenBSD CVS logs, zyd(4) was based on atu(4) and atu(4) was based on wi(4) in turn. Originally wi(4) was written by Bill Paul for FreeBSD and then it was ported to OpenBSD. So, the copyright is still valid for the manual page. Welcome back home! ;-) Jung-uk Kim From owner-cvs-src@FreeBSD.ORG Thu Aug 30 02:11:34 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 717B316A418; Thu, 30 Aug 2007 02:11:34 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 471A313C491; Thu, 30 Aug 2007 02:11:34 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7U2BYPw058927; Thu, 30 Aug 2007 02:11:34 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7U2BYbd058926; Thu, 30 Aug 2007 02:11:34 GMT (envelope-from alc) Message-Id: <200708300211.l7U2BYbd058926@repoman.freebsd.org> From: Alan Cox Date: Thu, 30 Aug 2007 02:11:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/powerpc/powerpc pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2007 02:11:34 -0000 alc 2007-08-30 02:11:33 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/powerpc/powerpc pmap.c Log: MFC revision 1.104 of powerpc/powerpc/mmu_oea.c Introduce the function pmap_enter_object(). Revision Changes Path 1.99.2.4 +60 -15 src/sys/powerpc/powerpc/pmap.c From owner-cvs-src@FreeBSD.ORG Thu Aug 30 02:32:05 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CA8A016A41B; Thu, 30 Aug 2007 02:32:05 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9F7E413C458; Thu, 30 Aug 2007 02:32:05 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7U2W56g060584; Thu, 30 Aug 2007 02:32:05 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7U2W5Te060583; Thu, 30 Aug 2007 02:32:05 GMT (envelope-from alc) Message-Id: <200708300232.l7U2W5Te060583@repoman.freebsd.org> From: Alan Cox Date: Thu, 30 Aug 2007 02:32:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/vm vm_map.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2007 02:32:05 -0000 alc 2007-08-30 02:32:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/vm vm_map.c Log: MFC revisions 1.375-1.377 Use pmap_enter_object() in vm_map_pmap_enter() to reduce the locking overhead of premapping objects. Note: It was later discovered that this change addresses a race condition that is discussed by vm/vm_fault.c revision 1.216. Specifically, replacing pmap_enter_quick() by pmap_enter_object() addresses the race. Revision Changes Path 1.366.2.4 +18 -8 src/sys/vm/vm_map.c From owner-cvs-src@FreeBSD.ORG Wed Aug 29 21:10:57 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AC0D816A418; Wed, 29 Aug 2007 21:10:57 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.freebsd.org (Postfix) with ESMTP id 500C513C4A7; Wed, 29 Aug 2007 21:10:57 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (g9f7sku88v0iqpmp@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.6/8.13.3) with ESMTP id l7TKtl8g039353; Wed, 29 Aug 2007 13:55:47 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.6/8.13.3/Submit) id l7TKtb9J039352; Wed, 29 Aug 2007 13:55:37 -0700 (PDT) (envelope-from jmg) Date: Wed, 29 Aug 2007 13:55:37 -0700 From: John-Mark Gurney To: John Baldwin Message-ID: <20070829205537.GB977@funkthat.com> References: <20070827.085906.-332187760.imp@bsdimp.com> <20070827185741.GX87451@elvis.mu.org> <200708271530.45290.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200708271530.45290.jhb@freebsd.org> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-Mailman-Approved-At: Thu, 30 Aug 2007 04:11:27 +0000 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, peterjeremy@optushome.com.au, Alfred Perlstein , cvs-all@freebsd.org, yar@comp.chem.msu.su, eischen@vigrid.com, kensmith@cse.buffalo.edu, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2007 21:10:57 -0000 John Baldwin wrote this message on Mon, Aug 27, 2007 at 15:30 -0400: > On Monday 27 August 2007 02:57:41 pm Alfred Perlstein wrote: > > Sorry for top posting, but... > > > > I agree very strongly with Warner, in short, if possible, reducing the > > number of major gotchas of running current will make our developer > > and early adopters a lot happier. > > > > It will help FreeBSD. > > > > One of the things that turns me off to FreeBSD is the feeling that > > I get that certain people take some kind of pride in forcing users > > to go through dangerous and complex hoops in order to run current. > > > > It shouldn't be so if the overhead of making it easier is so small. > > It has zero to do with pride, but it does have a lot to do with allowing HEAD > to be a branch for development as opposed to the stable branches that are > more intended with deployment. Those are quite different feature sets. Isn't that what perforce is for? Also, we NEED users to be running -current... How many times has a release happened and people complained that it didn't get the testing it needed to find bug xyz? If we take the attitude that only developers should be running -current we'll continue w/ unhappy -stable releases like we have in the past... Not that Kris doesn't do a great job finding bugs, but other people are good at finding bugs too, and we shouldn't lock them out... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-cvs-src@FreeBSD.ORG Thu Aug 30 06:20:16 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4E1E16A417; Thu, 30 Aug 2007 06:20:16 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id 84CC113C45B; Thu, 30 Aug 2007 06:20:14 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id l7U6JcEM059399; Thu, 30 Aug 2007 10:19:38 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id l7U6JaMT059394; Thu, 30 Aug 2007 10:19:36 +0400 (MSD) (envelope-from yar) Date: Thu, 30 Aug 2007 10:19:36 +0400 From: Yar Tikhiy To: Daniel Eischen Message-ID: <20070830061935.GF31948@comp.chem.msu.su> References: <200708270850.20904.jhb@freebsd.org> <200708281142.07941.jhb@freebsd.org> <200708281403.05931.jhb@freebsd.org> <20070829073011.GD598@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Cc: src-committers@freebsd.org, John Baldwin , peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2007 06:20:16 -0000 On Wed, Aug 29, 2007 at 10:03:41AM -0400, Daniel Eischen wrote: > On Wed, 29 Aug 2007, Yar Tikhiy wrote: > > >On Tue, Aug 28, 2007 at 04:15:16PM -0400, Daniel Eischen wrote: > >>On Tue, 28 Aug 2007, John Baldwin wrote: > >> > >>Any symbol in the Symbol.map files (or the generated Version.map) > >>that is duplicated from the point at which -current was last > >>branched. > >> > >>If you go with my approach and only create one new version in > >>-current, then it will be more obvious because the symbol(s) > >>will already exist in -current's one and only version. That > >>will force us to decide whether we should force a rebuild or > >>just make a new version - it could be on a case by case basis > >>if it ever happened. > >> > >>But even with the other approach (each ABI change creates a > >>new version), you could write a script to find all the versions > >>with duplicate symbols. I suppose you could even have it > >>generate an ObsoleteVersions file that gets committed along > >>with the most recent ABI change. > > > >At this point we should consider technical limitations as well. > >I think I found a couple, unfortunately. > > > >On the one hand, John's approach depends on alias symbols in HEAD > >so, e.g., both foo@FBSD-1.9 (public) and foo@FBSD-current-1.8.5 > >(interim) can point to the same implementation for the "foo" interface > >after STABLE with foo@FBSD-1.9 was branched. However, the GNU build > >tools don't seem to provide a straight way to that, they return an > >error if multiple versions reference the same function, so more > >stub code will be needed in the library, which will add to complexity > >of the approach. > > I think you can use -z muldefs or --allow-multiple-definition as a > linker argument to work around that. libpthread once did that (or > something like it) so it could be compatible with libpthread.so.1 > which used LIBPTHREAD_1_0 instead of FBSD_1_0. I'm afraid the ld trick won't work because the error is from as(1), e.g.: : $ make : cc -O2 -fno-strict-aliasing -pipe -c foo.c : {standard input}: Assembler messages: : {standard input}:4: Error: multiple versions [`foo@FBSD_1.1'|`foo@FBSD_1.0'] for symbol `foo0' : *** Error code 1 : $ cat foo.c : #include : : int : foo0(int n) : { : return (n + 1); : } : : __sym_compat(foo, foo0, FBSD_1.0); : __sym_compat(foo, foo0, FBSD_1.1); : : int : foo(int n) : { : return (n + 3); : } Did I do anything wrong? > >On the other hand, Symbol.map files should not contain duplicate > >symbol names as it seems to violate ld(1) semantics. Therefore, > >if following Daniel's way, we'll need to track which symbols moved > >by more than one version since the last STABLE branch to find interim > >versions. This shouldn't be too hard, but the implementation details > >are somewhat different. > > When someone changes the ABI, he's going to add a new set of symbols > to a Symbol.map file. At this point before he commits he should > notice that there are duplicated symbols. If he does, then he > removes them and updates ObsoleteVersions. If he doesn't, then > you have duplicate symbols ;-) Or you just have a script that > does this for you (version_gen.awk might be a good starting > point!). For the beginning, version_gen.awk could just complain about duplicated symbols and suggest adding them to ObsoleteVersions as there shouldn't be any duplicates in the whole version map generated. Is that reasonable? BTW, what is a good place for ObsoleteVersions? src/lib/${libname}, along with Versions.def? Or next to Symbol.map? -- Yar From owner-cvs-src@FreeBSD.ORG Thu Aug 30 07:16:59 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1E71116A417; Thu, 30 Aug 2007 07:16:59 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id EB6A913C459; Thu, 30 Aug 2007 07:16:58 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7U7GwA5092147; Thu, 30 Aug 2007 07:16:58 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7U7Gwnb092146; Thu, 30 Aug 2007 07:16:58 GMT (envelope-from netchild) Message-Id: <200708300716.l7U7Gwnb092146@repoman.freebsd.org> From: Alexander Leidinger Date: Thu, 30 Aug 2007 07:16:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/amd64/linux32 linux32_dummy.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2007 07:16:59 -0000 netchild 2007-08-30 07:16:58 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/amd64/linux32 linux32_dummy.c Log: Remove second entry for tgkill. Noticed by: dwhite Revision Changes Path 1.1.8.2 +0 -1 src/sys/amd64/linux32/linux32_dummy.c From owner-cvs-src@FreeBSD.ORG Thu Aug 30 07:22:21 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E489216A41B; Thu, 30 Aug 2007 07:22:21 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id BD95213C442; Thu, 30 Aug 2007 07:22:21 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7U7MLm8092573; Thu, 30 Aug 2007 07:22:21 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7U7MLDR092572; Thu, 30 Aug 2007 07:22:21 GMT (envelope-from netchild) Message-Id: <200708300722.l7U7MLDR092572@repoman.freebsd.org> From: Alexander Leidinger Date: Thu, 30 Aug 2007 07:22:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/i386/linux linux.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2007 07:22:22 -0000 netchild 2007-08-30 07:22:21 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/i386/linux linux.h Log: Add 2 missing typedefs. Noticed by: Christian Hiris <4711@chello.at> Revision Changes Path 1.64.2.4 +3 -0 src/sys/i386/linux/linux.h From owner-cvs-src@FreeBSD.ORG Thu Aug 30 07:37:07 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A968D16A419; Thu, 30 Aug 2007 07:37:07 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 630E413C45B; Thu, 30 Aug 2007 07:37:07 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A564DF.dip.t-dialin.net [84.165.100.223]) by redbull.bpaserver.net (Postfix) with ESMTP id 704802E151; Thu, 30 Aug 2007 09:17:43 +0200 (CEST) Received: from deskjail (deskjail.Leidinger.net [192.168.1.109]) by outgoing.leidinger.net (Postfix) with ESMTP id EF2D85B4996; Thu, 30 Aug 2007 09:17:40 +0200 (CEST) Date: Thu, 30 Aug 2007 09:17:40 +0200 From: Alexander Leidinger To: Doug White Message-ID: <20070830091740.314971be@deskjail> In-Reply-To: <20070829170005.G49868@carver.gumbysoft.com> References: <200708291504.l7TF4Rdd073737@repoman.freebsd.org> <20070829170005.G49868@carver.gumbysoft.com> Organization: FreeBSD X-Mailer: Claws Mail 2.10.0 (GTK+ 2.10.14; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.723, required 8, BAYES_00 -15.00, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10, TW_TG 0.08) X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/linux32 linux32_dummy.c linux32_machdep.c syscalls.master src/sys/compat/linux linux_file.c linux_ioctl.c linux_misc.c linux_stats.c linux_time.c src/sys/conf files.amd64 files.i386 files.pc98 src/sys/i386/linux linux_dummy.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2007 07:37:07 -0000 Quoting Doug White (Wed, 29 Aug 2007 17:01:06 -0700 (PDT)): > This does not compile. the tgkill dummy syscall is declared twice in > linux32_dummy.c. > > > Tested by: bsam (on i386/amd64 with LTP 20070630) Fixed. Thanks, Alexander. -- ...and that is how we know the Earth to be banana-shaped. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 From owner-cvs-src@FreeBSD.ORG Thu Aug 30 08:39:10 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AD15916A417; Thu, 30 Aug 2007 08:39:10 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 5FD3D13C45A; Thu, 30 Aug 2007 08:39:10 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l7U8cv8f014530; Thu, 30 Aug 2007 04:38:57 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Thu, 30 Aug 2007 04:38:58 -0400 (EDT) Date: Thu, 30 Aug 2007 04:38:57 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Yar Tikhiy In-Reply-To: <20070830061935.GF31948@comp.chem.msu.su> Message-ID: References: <200708270850.20904.jhb@freebsd.org> <200708281142.07941.jhb@freebsd.org> <200708281403.05931.jhb@freebsd.org> <20070829073011.GD598@comp.chem.msu.su> <20070830061935.GF31948@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, John Baldwin , peterjeremy@optushome.com.au, alfred@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2007 08:39:10 -0000 On Thu, 30 Aug 2007, Yar Tikhiy wrote: > On Wed, Aug 29, 2007 at 10:03:41AM -0400, Daniel Eischen wrote: >> On Wed, 29 Aug 2007, Yar Tikhiy wrote: >> >>> On the one hand, John's approach depends on alias symbols in HEAD >>> so, e.g., both foo@FBSD-1.9 (public) and foo@FBSD-current-1.8.5 >>> (interim) can point to the same implementation for the "foo" interface >>> after STABLE with foo@FBSD-1.9 was branched. However, the GNU build >>> tools don't seem to provide a straight way to that, they return an >>> error if multiple versions reference the same function, so more >>> stub code will be needed in the library, which will add to complexity >>> of the approach. >> >> I think you can use -z muldefs or --allow-multiple-definition as a >> linker argument to work around that. libpthread once did that (or >> something like it) so it could be compatible with libpthread.so.1 >> which used LIBPTHREAD_1_0 instead of FBSD_1_0. > > I'm afraid the ld trick won't work because the error is from as(1), > e.g.: > > : $ make > : cc -O2 -fno-strict-aliasing -pipe -c foo.c > : {standard input}: Assembler messages: > : {standard input}:4: Error: multiple versions [`foo@FBSD_1.1'|`foo@FBSD_1.0'] for symbol `foo0' > : *** Error code 1 > > : $ cat foo.c > : #include > : > : int > : foo0(int n) > : { > : return (n + 1); > : } > : > : __sym_compat(foo, foo0, FBSD_1.0); > : __sym_compat(foo, foo0, FBSD_1.1); > : > : int > : foo(int n) > : { > : return (n + 3); > : } > > Did I do anything wrong? Hmm, I guess it's not that simple. Take a look at the hack I had to make in libpthread/thread/thr_private.h (line ~67). I had to create weak references to the functions, so for your example, you'd need something like: __weak_reference(foo0, foo0_10); __weak_refefence(foo0, foo0_11); __sym_compat(foo, foo0_10, FBSD_1.0); __sym_compat(foo, foo0_11, FBSD_1.1); I think I also needed to make the latest symbol the default, changing the last line above to __sym_compat_default(foo, foo0_11, FBSD_1.1), but I seem to recall earlier email from you saying this shouldn't be needed. I _think_ I needed to for libpthread, but perhaps that is because I had the symbols (e.g. foo) listed in both sections of the map file: LIBPTHREAD_1_0 { pthread_foo; }; FBSD_1_0 { pthread_foo; }; See r.19 of libpthread/pthread.map. But this hackery isn't very pretty and is a little confusing, so perhaps that is an argument against taking this approach? Or maybe not, if you can come up with a set of macros that can be easily changed to do one thing in -current and a different thing in release brannches - you might be able to avoid changing the compat shims when branching -current to a release or MFC'ing. >>> On the other hand, Symbol.map files should not contain duplicate >>> symbol names as it seems to violate ld(1) semantics. Therefore, >>> if following Daniel's way, we'll need to track which symbols moved >>> by more than one version since the last STABLE branch to find interim >>> versions. This shouldn't be too hard, but the implementation details >>> are somewhat different. >> >> When someone changes the ABI, he's going to add a new set of symbols >> to a Symbol.map file. At this point before he commits he should >> notice that there are duplicated symbols. If he does, then he >> removes them and updates ObsoleteVersions. If he doesn't, then >> you have duplicate symbols ;-) Or you just have a script that >> does this for you (version_gen.awk might be a good starting >> point!). > > For the beginning, version_gen.awk could just complain about > duplicated symbols and suggest adding them to ObsoleteVersions as > there shouldn't be any duplicates in the whole version map generated. > Is that reasonable? BTW, what is a good place for ObsoleteVersions? > src/lib/${libname}, along with Versions.def? Or next to Symbol.map? Since duplicates might not ever occur, you would probably have an empty ObsoleteVersions file, so I'd recommend just one of them in src/lib/${libname}. Yes, I think having version_gen.awk complain and abort if it encounters duplicates might be good enough for now. Before a branch from -current, we can also manually check the libraries to make sure there are no duplicate symbols from the last branch (readelf -sW | awk ' {print $8}' | sort | some other magic). -- DE From owner-cvs-src@FreeBSD.ORG Thu Aug 30 15:03:22 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0F7B416A474; Thu, 30 Aug 2007 15:03:22 +0000 (UTC) (envelope-from danger@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DCDF813C480; Thu, 30 Aug 2007 15:03:21 +0000 (UTC) (envelope-from danger@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7UF3LOh051260; Thu, 30 Aug 2007 15:03:21 GMT (envelope-from danger@repoman.freebsd.org) Received: (from danger@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7UF3LDv051259; Thu, 30 Aug 2007 15:03:21 GMT (envelope-from danger) Message-Id: <200708301503.l7UF3LDv051259@repoman.freebsd.org> From: Daniel Gerzo Date: Thu, 30 Aug 2007 15:03:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man9 suser.9 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2007 15:03:22 -0000 danger 2007-08-30 15:03:21 UTC FreeBSD src repository (doc committer) Modified files: share/man/man9 suser.9 Log: - Fix include path, these functions were moved to sys/priv.h. Approved by: re (bmah) Submitted by: sbahra@hpcl.seas.gwu.edu (via #bsddocs@EFnet) Pointy hat to: rwatson Revision Changes Path 1.34 +2 -3 src/share/man/man9/suser.9 From owner-cvs-src@FreeBSD.ORG Thu Aug 30 19:12:10 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D104D16A418; Thu, 30 Aug 2007 19:12:10 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A78B713C457; Thu, 30 Aug 2007 19:12:10 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7UJCAo1083332; Thu, 30 Aug 2007 19:12:10 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7UJCAwL083331; Thu, 30 Aug 2007 19:12:10 GMT (envelope-from thompsa) Message-Id: <200708301912.l7UJCAwL083331@repoman.freebsd.org> From: Andrew Thompson Date: Thu, 30 Aug 2007 19:12:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_lagg.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2007 19:12:10 -0000 thompsa 2007-08-30 19:12:10 UTC FreeBSD src repository Modified files: sys/net if_lagg.c Log: Show the ACTIVE flag in ifconfig for the single interface that is actaully active in failover mode rather than all interfaces with a link. This makes it clear if the master interface is in use or one of the backup links. Found by: Writing the Handbook section Approved by: re (kensmith) Revision Changes Path 1.19 +5 -1 src/sys/net/if_lagg.c From owner-cvs-src@FreeBSD.ORG Thu Aug 30 20:29:01 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BDFF416A41A; Thu, 30 Aug 2007 20:29:01 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 94DD613C467; Thu, 30 Aug 2007 20:29:01 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7UKT1V1089161; Thu, 30 Aug 2007 20:29:01 GMT (envelope-from sobomax@repoman.freebsd.org) Received: (from sobomax@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7UKT1Xt089160; Thu, 30 Aug 2007 20:29:01 GMT (envelope-from sobomax) Message-Id: <200708302029.l7UKT1Xt089160@repoman.freebsd.org> From: Maxim Sobolev Date: Thu, 30 Aug 2007 20:29:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/conf files.amd64 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2007 20:29:01 -0000 sobomax 2007-08-30 20:29:01 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/conf files.amd64 Log: MFC: Build p4tcc and est cpu frequency modules on amd64 to match modules/cpufreq. Revision Changes Path 1.71.2.15 +2 -0 src/sys/conf/files.amd64 From owner-cvs-src@FreeBSD.ORG Thu Aug 30 20:40:49 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F37B16A527; Thu, 30 Aug 2007 20:40:46 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id BD7D313C428; Thu, 30 Aug 2007 20:40:45 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l7UKcbb1051996; Thu, 30 Aug 2007 14:38:38 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 30 Aug 2007 14:38:37 -0600 (MDT) Message-Id: <20070830.143837.-399283222.imp@bsdimp.com> To: jkim@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <200708292009.35386.jkim@FreeBSD.org> References: <200708292108.l7TL8EMk023389@repoman.freebsd.org> <200708292009.35386.jkim@FreeBSD.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Thu, 30 Aug 2007 14:38:38 -0600 (MDT) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man4 zyd.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2007 20:40:49 -0000 In message: <200708292009.35386.jkim@FreeBSD.org> Jung-uk Kim writes: : On Wednesday 29 August 2007 05:08 pm, Warner Losh wrote: : > imp 2007-08-29 21:08:14 UTC : > : > FreeBSD src repository : > : > Added files: : > share/man/man4 zyd.4 : > Log: : > Bring in the man page for zyd, ported from NetBSD, complete with : > bogus Bill Paul copyright. Not sure what the right copyright is, : > but this file has been through 22 reversions on OpenBSD and 1 on : > NetBSD. This isn't (yet) connected to the build, just in case I've : > done something wrong (test builds worked, but better safe than : > sorry). : : According to OpenBSD CVS logs, zyd(4) was based on atu(4) and atu(4) : was based on wi(4) in turn. Originally wi(4) was written by Bill : Paul for FreeBSD and then it was ported to OpenBSD. So, the : copyright is still valid for the manual page. Well, maybe not. With so many transitive things the only commonality between wi.4 and zyd.4 is the license. I doubt that's enough to retain the copyright notice. Warner From owner-cvs-src@FreeBSD.ORG Thu Aug 30 21:18:42 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F146916A417; Thu, 30 Aug 2007 21:18:42 +0000 (UTC) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C8C2113C468; Thu, 30 Aug 2007 21:18:42 +0000 (UTC) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7ULIgn6001940; Thu, 30 Aug 2007 21:18:42 GMT (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7ULIgpd001939; Thu, 30 Aug 2007 21:18:42 GMT (envelope-from njl) Message-Id: <200708302118.l7ULIgpd001939@repoman.freebsd.org> From: Nate Lawson Date: Thu, 30 Aug 2007 21:18:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/acpica acpi_cpu.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2007 21:18:43 -0000 njl 2007-08-30 21:18:42 UTC FreeBSD src repository Modified files: sys/dev/acpica acpi_cpu.c Log: Evaluate _OSC on boot to indicate our OS capabilities to ACPI. This is needed at least to convince the BIOS to give us access to CPU freq control on MacBooks. Submitted by: Rui Paulo Approved by: re MFC after: 5 days Revision Changes Path 1.67 +32 -7 src/sys/dev/acpica/acpi_cpu.c From owner-cvs-src@FreeBSD.ORG Thu Aug 30 22:08:53 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 24B0C16A41A; Thu, 30 Aug 2007 22:08:53 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 90B2013C474; Thu, 30 Aug 2007 22:08:52 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8k2) with ESMTP id 206264228-1834499 for multiple; Thu, 30 Aug 2007 18:06:47 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l7UM8eMS063542; Thu, 30 Aug 2007 18:08:40 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: John-Mark Gurney Date: Thu, 30 Aug 2007 18:05:08 -0400 User-Agent: KMail/1.9.6 References: <200708271530.45290.jhb@freebsd.org> <20070829205537.GB977@funkthat.com> In-Reply-To: <20070829205537.GB977@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200708301805.10011.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 30 Aug 2007 18:08:41 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4109/Thu Aug 30 13:18:52 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx X-Mailman-Approved-At: Fri, 31 Aug 2007 03:14:48 +0000 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, peterjeremy@optushome.com.au, Alfred Perlstein , cvs-all@freebsd.org, yar@comp.chem.msu.su, eischen@vigrid.com, kensmith@cse.buffalo.edu, "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/gen fts-compat.c fts-compat.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2007 22:08:53 -0000 On Wednesday 29 August 2007 04:55:37 pm John-Mark Gurney wrote: > John Baldwin wrote this message on Mon, Aug 27, 2007 at 15:30 -0400: > > On Monday 27 August 2007 02:57:41 pm Alfred Perlstein wrote: > > > Sorry for top posting, but... > > > > > > I agree very strongly with Warner, in short, if possible, reducing the > > > number of major gotchas of running current will make our developer > > > and early adopters a lot happier. > > > > > > It will help FreeBSD. > > > > > > One of the things that turns me off to FreeBSD is the feeling that > > > I get that certain people take some kind of pride in forcing users > > > to go through dangerous and complex hoops in order to run current. > > > > > > It shouldn't be so if the overhead of making it easier is so small. > > > > It has zero to do with pride, but it does have a lot to do with allowing HEAD > > to be a branch for development as opposed to the stable branches that are > > more intended with deployment. Those are quite different feature sets. > > Isn't that what perforce is for? > > Also, we NEED users to be running -current... How many times has a release > happened and people complained that it didn't get the testing it needed > to find bug xyz? If we take the attitude that only developers should > be running -current we'll continue w/ unhappy -stable releases like we > have in the past... > > Not that Kris doesn't do a great job finding bugs, but other people > are good at finding bugs too, and we shouldn't lock them out... How many custom kernels from p4 do you run from other people's branches? Putting stuff into HEAD is how we get wider exposure for stuff beyond a developer's own boxes (or a few other people who will test it). We can't restrict change so much in HEAD that we can't do development there. Also, for better or for worse, a lot of the peer review kicks in when stuff is committed to CVS, so churn in HEAD is quite common and it's going to continue to be there in the future. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Fri Aug 31 03:25:23 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2780216A417 for ; Fri, 31 Aug 2007 03:25:22 +0000 (UTC) (envelope-from jkoshy.freebsd@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.183]) by mx1.freebsd.org (Postfix) with ESMTP id B0FC813C461 for ; Fri, 31 Aug 2007 03:25:22 +0000 (UTC) (envelope-from jkoshy.freebsd@gmail.com) Received: by wa-out-1112.google.com with SMTP id k17so825372waf for ; Thu, 30 Aug 2007 20:24:36 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:date:message-id:to:cc:subject:in-reply-to:references:user-agent:mime-version:content-type:from:sender; b=AbQVVd4m6sIQLIkhbqM5eck+ACBnLqTmeM+O3N1VRCyVu0V7nDllJ/FgXrcLZbtS/Vgw5jye+sbOf1ipUopU01BbGhH0n2x51qnyXHxqndKBzv/5CWyStOKSaeGYhQr4VqljEhG13qsUwvreknCgmgTOSR9N7pOyfdOHko9T0KY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:message-id:to:cc:subject:in-reply-to:references:user-agent:mime-version:content-type:from:sender; b=AW35Rbp/656BHZbvh7qH2OaFwF3l0H0vxRSO8aA4TUdmJyL4kb2da0QGl12wo1q88LFSZB8Zw4lMsuU6d+dWfOiuJNSNSTywPo7OEdrMy2KI5ywHHf3h8ZSWj3gMItW1fSC5l7gXVSPqiY8HjgntiR3Py/MSHp82FDTr/iKkMSs= Received: by 10.114.56.1 with SMTP id e1mr361642waa.1188527587161; Thu, 30 Aug 2007 19:33:07 -0700 (PDT) Received: from moria.unixconsulting.co.in ( [202.134.204.146]) by mx.google.com with ESMTPS id v9sm1223210wah.2007.08.30.19.32.58 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 30 Aug 2007 19:33:06 -0700 (PDT) Date: Thu, 30 Aug 2007 09:43:01 +0000 Message-ID: <86zm098ije.wl%koshy@unixconsulting.co.in> To: Peter Wemm In-Reply-To: <200708292326.l7TNQY6V035882@repoman.freebsd.org> References: <200708292326.l7TNQY6V035882@repoman.freebsd.org> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.7 Emacs/21.3 (amd64--freebsd) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII From: Joseph Koshy Sender: Joseph Koshy Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 mp_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2007 03:25:23 -0000 > MFC: rev 1.261. Set a stack for interrupt stack 1 (double fault) on > AP cpus. This changes a guaranteed triple-fault (silent reset) into > something that has a chance to work. Apparently, the NMI handler uses > this stack too. Thanks! Regards, Koshy From owner-cvs-src@FreeBSD.ORG Fri Aug 31 13:36:59 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 105C516A419; Fri, 31 Aug 2007 13:36:59 +0000 (UTC) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DCA0613C4A8; Fri, 31 Aug 2007 13:36:58 +0000 (UTC) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7VDawQx029343; Fri, 31 Aug 2007 13:36:58 GMT (envelope-from dds@repoman.freebsd.org) Received: (from dds@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7VDawoA029333; Fri, 31 Aug 2007 13:36:58 GMT (envelope-from dds) Message-Id: <200708311336.l7VDawoA029333@repoman.freebsd.org> From: Diomidis Spinellis Date: Fri, 31 Aug 2007 13:36:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_acct.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2007 13:36:59 -0000 dds 2007-08-31 13:36:58 UTC FreeBSD src repository Modified files: sys/kern kern_acct.c Log: Don't panic. When encountering a negative value call log(LOG_NOTICE, ...) and record LONG_MAX, instead of calling KASSERT(...). Reported by: rwatson Approved by: re (kensmith) Revision Changes Path 1.94 +7 -1 src/sys/kern/kern_acct.c From owner-cvs-src@FreeBSD.ORG Fri Aug 31 13:56:26 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D488416A417; Fri, 31 Aug 2007 13:56:26 +0000 (UTC) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id ACB2913C459; Fri, 31 Aug 2007 13:56:26 +0000 (UTC) (envelope-from dds@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7VDuQtS032138; Fri, 31 Aug 2007 13:56:26 GMT (envelope-from dds@repoman.freebsd.org) Received: (from dds@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7VDuQFf032137; Fri, 31 Aug 2007 13:56:26 GMT (envelope-from dds) Message-Id: <200708311356.l7VDuQFf032137@repoman.freebsd.org> From: Diomidis Spinellis Date: Fri, 31 Aug 2007 13:56:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_acct.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2007 13:56:26 -0000 dds 2007-08-31 13:56:26 UTC FreeBSD src repository Modified files: sys/kern kern_acct.c Log: Add missing newline in the log message of the previous commit. Approved by: re (kensmith) - implied Revision Changes Path 1.95 +1 -1 src/sys/kern/kern_acct.c From owner-cvs-src@FreeBSD.ORG Fri Aug 31 19:01:31 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8204C16A41A; Fri, 31 Aug 2007 19:01:31 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6B4C813C45E; Fri, 31 Aug 2007 19:01:31 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7VJ1Vdm077706; Fri, 31 Aug 2007 19:01:31 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7VJ1VUx077705; Fri, 31 Aug 2007 19:01:31 GMT (envelope-from jhb) Message-Id: <200708311901.l7VJ1VUx077705@repoman.freebsd.org> From: John Baldwin Date: Fri, 31 Aug 2007 19:01:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_timeout.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2007 19:01:31 -0000 jhb 2007-08-31 19:01:30 UTC FreeBSD src repository Modified files: sys/kern kern_timeout.c Log: Close a race that snuck in with the recent changes to fix a LOR between the callout_lock spin lock and the sleepqueue spin locks. In the fix, callout_drain() has to drop the callout_lock so it can acquire the sleepqueue lock. The state of the callout can change while the callout_lock is held however (for example, it can be rescheduled via callout_reset()). The previous code assumed that the only state change that could happen is that the callout could finish executing. This change alters callout_drain() to effectively restart and recheck everything after it acquires the sleepqueue lock thus handling all the possible states that the callout could be in after any changes while callout_lock was dropped. Approved by: re (kensmith) Tested by: kris Revision Changes Path 1.105 +27 -13 src/sys/kern/kern_timeout.c From owner-cvs-src@FreeBSD.ORG Fri Aug 31 19:41:28 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF4C916A41A; Fri, 31 Aug 2007 19:41:28 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 867C313C45B; Fri, 31 Aug 2007 19:41:28 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7VJfS6T082134; Fri, 31 Aug 2007 19:41:28 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7VJfSw8082133; Fri, 31 Aug 2007 19:41:28 GMT (envelope-from yar) Message-Id: <200708311941.l7VJfSw8082133@repoman.freebsd.org> From: Yar Tikhiy Date: Fri, 31 Aug 2007 19:41:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src ObsoleteFiles.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2007 19:41:28 -0000 yar 2007-08-31 19:41:28 UTC FreeBSD src repository Modified files: . ObsoleteFiles.inc Log: Found some obsolete files in /rescue. The ipf related stuff was removed in rescue/Makefile rev. 1.43, and vinum in rev. 1.30. Approved by: re (bmah) Revision Changes Path 1.110 +5 -0 src/ObsoleteFiles.inc From owner-cvs-src@FreeBSD.ORG Fri Aug 31 22:29:55 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ED1F716A41A; Fri, 31 Aug 2007 22:29:55 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DE6BE13C461; Fri, 31 Aug 2007 22:29:55 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7VMTtWw005340; Fri, 31 Aug 2007 22:29:55 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7VMTtW6005339; Fri, 31 Aug 2007 22:29:55 GMT (envelope-from bde) Message-Id: <200708312229.l7VMTtW6005339@repoman.freebsd.org> From: Bruce Evans Date: Fri, 31 Aug 2007 22:29:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/msdosfs direntry.h msdosfs_conv.c msdosfs_lookup.c msdosfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2007 22:29:56 -0000 bde 2007-08-31 22:29:55 UTC FreeBSD src repository Modified files: sys/fs/msdosfs direntry.h msdosfs_conv.c msdosfs_lookup.c msdosfs_vnops.c Log: Fix races in msdosfs_lookup() and msdosfs_readdir(). These functions can easily block in bread(), and then there was nothing to prevent the static buffer (nambuf_{ptr,len,last_id}) being clobbered by another thread. The effects of the bug seem to have been limited to failed lookups and mangled names in readdir(), since Giant locking provides enough serialization to prevent concurrent calls to the functions that access the buffer. They were very obvious for multiple concurrent tree walks, especially with a small cluster size. The bug was introduced in msdosfs_conv.c 1.34 and associated changes, and is in all releases starting with 5.2. The fix is to allocate the buffer as a local variable and pass around pointers to it like "_r" functions in libc do. Stack use from this is large but not too large. This also fixes a memory leak on module unload. Reviewed by: kib Approved by: re (kensmith) Revision Changes Path 1.24 +12 -5 src/sys/fs/msdosfs/direntry.h 1.53 +35 -41 src/sys/fs/msdosfs/msdosfs_conv.c 1.51 +9 -9 src/sys/fs/msdosfs/msdosfs_lookup.c 1.179 +8 -7 src/sys/fs/msdosfs/msdosfs_vnops.c From owner-cvs-src@FreeBSD.ORG Sat Sep 1 05:52:40 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 68F8A16A417; Sat, 1 Sep 2007 05:52:40 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3C04813C457; Sat, 1 Sep 2007 05:52:40 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l815qe6K064268; Sat, 1 Sep 2007 05:52:40 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l815qedE064267; Sat, 1 Sep 2007 05:52:40 GMT (envelope-from ru) Message-Id: <200709010552.l815qedE064267@repoman.freebsd.org> From: Ruslan Ermilov Date: Sat, 1 Sep 2007 05:52:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/top top.local.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Sep 2007 05:52:40 -0000 ru 2007-09-01 05:52:40 UTC FreeBSD src repository Modified files: usr.bin/top top.local.1 Log: Fix the description of the "Cache" memory and clarify the description of the "Inact" memory. (They count pages in the cache/inactive page queues, respectively.) Approved by: re (kensmith) Revision Changes Path 1.4 +2 -2 src/usr.bin/top/top.local.1 From owner-cvs-src@FreeBSD.ORG Sat Sep 1 06:19:12 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3D8E516A417; Sat, 1 Sep 2007 06:19:12 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2907913C459; Sat, 1 Sep 2007 06:19:12 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l816JCmE066839; Sat, 1 Sep 2007 06:19:12 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l816JClw066838; Sat, 1 Sep 2007 06:19:12 GMT (envelope-from pjd) Message-Id: <200709010619.l816JClw066838@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 1 Sep 2007 06:19:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libutil Makefile expand_number.3 expand_number.c libutil.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Sep 2007 06:19:12 -0000 pjd 2007-09-01 06:19:11 UTC FreeBSD src repository Modified files: lib/libutil Makefile libutil.h Added files: lib/libutil expand_number.3 expand_number.c Log: Implement expand_number(3), which is the opposite of humanize_number(3), ie. a number in human-readable form is converted to int64_t, for example: 123b -> 123 10k -> 10240 16G -> 17179869184 First version submitted by: Eric Anderson Approved by: re (bmah) Revision Changes Path 1.66 +3 -3 src/lib/libutil/Makefile 1.1 +84 -0 src/lib/libutil/expand_number.3 (new) 1.1 +89 -0 src/lib/libutil/expand_number.c (new) 1.45 +1 -0 src/lib/libutil/libutil.h From owner-cvs-src@FreeBSD.ORG Sat Sep 1 06:23:42 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E856F16A41A; Sat, 1 Sep 2007 06:23:42 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id BBB8013C465; Sat, 1 Sep 2007 06:23:42 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l816NgOE067269; Sat, 1 Sep 2007 06:23:42 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l816Ngmb067268; Sat, 1 Sep 2007 06:23:42 GMT (envelope-from pjd) Message-Id: <200709010623.l816Ngmb067268@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 1 Sep 2007 06:23:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs arc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Sep 2007 06:23:43 -0000 pjd 2007-09-01 06:23:42 UTC FreeBSD src repository Modified files: sys/contrib/opensolaris/uts/common/fs/zfs arc.c Log: Use CTLFLAG_RDTUN for tunable sysctls. Approved by: re (bmah) Revision Changes Path 1.10 +2 -2 src/sys/contrib/opensolaris/uts/common/fs/zfs/arc.c From owner-cvs-src@FreeBSD.ORG Sat Sep 1 06:33:02 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F35416A417; Sat, 1 Sep 2007 06:33:02 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8831713C45B; Sat, 1 Sep 2007 06:33:02 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l816X2Bv067982; Sat, 1 Sep 2007 06:33:02 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l816X211067981; Sat, 1 Sep 2007 06:33:02 GMT (envelope-from pjd) Message-Id: <200709010633.l816X211067981@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 1 Sep 2007 06:33:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/geom/class/eli geli.8 src/sys/geom/eli g_eli.h g_eli_crypto.c src/tools/regression/geom_eli init-a.t init.t integrity-copy.t integrity-data.t integrity-hmac.t onetime-a.t onetime.t X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Sep 2007 06:33:02 -0000 pjd 2007-09-01 06:33:02 UTC FreeBSD src repository Modified files: sbin/geom/class/eli geli.8 sys/geom/eli g_eli.h g_eli_crypto.c tools/regression/geom_eli init-a.t init.t integrity-copy.t integrity-data.t integrity-hmac.t onetime-a.t onetime.t Log: Add support for Camellia encryption algorithm. PR: kern/113790 Submitted by: Yoshisato YANAGISAWA Approved by: re (bmah) Revision Changes Path 1.22 +11 -3 src/sbin/geom/class/eli/geli.8 1.13 +6 -1 src/sys/geom/eli/g_eli.h 1.5 +15 -0 src/sys/geom/eli/g_eli_crypto.c 1.2 +3 -2 src/tools/regression/geom_eli/init-a.t 1.3 +3 -2 src/tools/regression/geom_eli/init.t 1.2 +3 -2 src/tools/regression/geom_eli/integrity-copy.t 1.2 +3 -2 src/tools/regression/geom_eli/integrity-data.t 1.2 +3 -2 src/tools/regression/geom_eli/integrity-hmac.t 1.2 +3 -2 src/tools/regression/geom_eli/onetime-a.t 1.3 +3 -2 src/tools/regression/geom_eli/onetime.t From owner-cvs-src@FreeBSD.ORG Sat Sep 1 12:18:29 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4440A16A418; Sat, 1 Sep 2007 12:18:29 +0000 (UTC) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 1E48A13C483; Sat, 1 Sep 2007 12:18:29 +0000 (UTC) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l81CITr5012853; Sat, 1 Sep 2007 12:18:29 GMT (envelope-from nyan@repoman.freebsd.org) Received: (from nyan@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l81CISPB012852; Sat, 1 Sep 2007 12:18:28 GMT (envelope-from nyan) Message-Id: <200709011218.l81CISPB012852@repoman.freebsd.org> From: Takahashi Yoshihiro Date: Sat, 1 Sep 2007 12:18:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/isa isa.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Sep 2007 12:18:29 -0000 nyan 2007-09-01 12:18:28 UTC FreeBSD src repository Modified files: sys/i386/isa isa.c Log: Fix a kernel panic due to a NULL pointer access on pc98. When any PnP device exists, isa_release_resource() is called with no activated resource. So a bushandle is not allocated yet. Approved by: re (kensmith) Revision Changes Path 1.151 +7 -5 src/sys/i386/isa/isa.c From owner-cvs-src@FreeBSD.ORG Sat Sep 1 17:50:27 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4EFDD16A41B; Sat, 1 Sep 2007 17:50:27 +0000 (UTC) (envelope-from matteo@FreeBSD.org) Received: from vsmtp1.tin.it (vsmtp1.tin.it [212.216.176.141]) by mx1.freebsd.org (Postfix) with ESMTP id 0962C13C45B; Sat, 1 Sep 2007 17:50:27 +0000 (UTC) (envelope-from matteo@FreeBSD.org) Received: from rionda.dyndns.org (87.8.174.211) by vsmtp1.tin.it (7.3.122) id 469A4E99053FCA33; Sat, 1 Sep 2007 19:26:00 +0200 Received: from rionda.dyndns.org (rionda@localhost [127.0.0.1]) by rionda.dyndns.org (8.14.1/8.14.1) with ESMTP id l81HQ00D002405; Sat, 1 Sep 2007 19:26:00 +0200 (CEST) (envelope-from matteo@FreeBSD.org) Received: (from rionda@localhost) by rionda.dyndns.org (8.14.1/8.14.1/Submit) id l81HPx0Q002404; Sat, 1 Sep 2007 19:25:59 +0200 (CEST) (envelope-from matteo@FreeBSD.org) X-Authentication-Warning: rionda.dyndns.org: rionda set sender to matteo@FreeBSD.org using -f Date: Sat, 1 Sep 2007 19:25:59 +0200 From: Matteo Riondato To: Kris Kennaway Message-ID: <20070901172559.GB1823@kaiser.sig11.org> Mail-Followup-To: Matteo Riondato , Kris Kennaway , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200708250019.l7P0JHxK057929@repoman.freebsd.org> <20070827133828.GA70070@hub.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="K8nIJk4ghYZn606h" Content-Disposition: inline In-Reply-To: <20070827133828.GA70070@hub.freebsd.org> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d mdconfig X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Sep 2007 17:50:27 -0000 --K8nIJk4ghYZn606h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 27, 2007 at 01:38:28PM +0000, Kris Kennaway wrote: > On Sat, Aug 25, 2007 at 12:19:17AM +0000, Matteo Riondato wrote: > > matteo 2007-08-25 00:19:17 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > etc/rc.d mdconfig=20 > > Log: > > sleep 2 seconds after having loaded g_uzip.ko. We need this because > > otherwise the /dev/mdX.uzip won't be created immediately, which is > > needed because we issue a mount right afterwards. >=20 > Wouldn't it be better to loop & retry (with a small sleep) until it > appears? "Sleeping N seconds" is a way to just shuffle a race into > some other case. Yes, it will be better. I'll commit a patch soon. Thanks for the suggestion. Best Regards --=20 Matteo Riondato FreeBSD Committer (http://www.FreeBSD.org) FreeSBIE Developer (http://www.FreeSBIE.org) GUFI Staff Member (http://www.GUFI.org) --K8nIJk4ghYZn606h Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFG2aCn2Mp4pR7Fa+wRArkUAJ97LOro6kjxIs7nxze+FAGkOhSzogCg2CTe 0CUkIhZQIQh1a3lLS3WhtmE= =xu8m -----END PGP SIGNATURE----- --K8nIJk4ghYZn606h--