From owner-cvs-src@FreeBSD.ORG Sun Sep 30 02:40:45 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5DBD716A418; Sun, 30 Sep 2007 02:40:45 +0000 (UTC) (envelope-from gad@FreeBSD.org) Received: from smtp8.server.rpi.edu (smtp8.server.rpi.edu [128.113.2.228]) by mx1.freebsd.org (Postfix) with ESMTP id 0EFED13C465; Sun, 30 Sep 2007 02:40:44 +0000 (UTC) (envelope-from gad@FreeBSD.org) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp8.server.rpi.edu (8.13.1/8.13.1) with ESMTP id l8U1bXuT023954; Sat, 29 Sep 2007 21:37:34 -0400 Mime-Version: 1.0 Message-Id: In-Reply-To: <200709271639.l8RGdREd032105@repoman.freebsd.org> References: <200709271639.l8RGdREd032105@repoman.freebsd.org> Date: Sat, 29 Sep 2007 21:37:32 -0400 To: Jeff Roberson , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org From: Garance A Drosehn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-RPI-SA-Score: undef - spam scanning disabled X-CanItPRO-Stream: default X-Canit-Stats-ID: Bayes signature not available X-Scanned-By: CanIt (www . roaringpenguin . com) on 128.113.2.228 Cc: Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Sep 2007 02:40:45 -0000 At 4:39 PM +0000 9/27/07, Jeff Roberson wrote: > > Modified files: > sys/kern sched_ule.c > Log: > - ... > - Assert that we're not trying to compile ULE on an unsupported > architecture. To date, I believe only i386 and amd64 have > implemented the third cpu switch argument required. > > Approved by: re Does this mean that I should not switch to ULE on my single-CPU PowerPC mini-Mac? -- Garance Alistair Drosehn = drosehn@rpi.edu Senior Systems Programmer or gad@FreeBSD.org Rensselaer Polytechnic Institute; Troy, NY; USA From owner-cvs-src@FreeBSD.ORG Sun Sep 30 03:51:17 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 08A9916A46E for ; Sun, 30 Sep 2007 03:51:17 +0000 (UTC) (envelope-from minimarmot@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.177]) by mx1.freebsd.org (Postfix) with ESMTP id DBFC513C46E for ; Sun, 30 Sep 2007 03:51:16 +0000 (UTC) (envelope-from minimarmot@gmail.com) Received: by wa-out-1112.google.com with SMTP id k17so4181451waf for ; Sat, 29 Sep 2007 20:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=r0jyjmz1pMqKm7VeTaeLrQLvS/iVPJDRo1OUEVcMH9c=; b=Gr//FwvqsDaFR9SiAvxjYxzzsK1+l4RrsQ9/RclHtxRffQGLO5r0RXZnw4FWsfguYf/Uw/o/ZomxkAgmxCfL57FpFA/LsV6d5G1pYjn3WW5F7izDtEwKLJhVg2yToE4Z9mftpYMmN/gWI8TVaJ9gd0iUCVPasaKcagpDacfLJo4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=oEYkaGulL0fMidzQl6exdfbZq60rA0KAaPrSDzLxd+6C7SdGnlSxynRW8DBH1+TkonS6htdC1StBD5FqeRn1EWCtJoXEt0B57IyjG+gLK72sYVPzJHDGwwErVfajHM8QtHCbCt02lu5LfD3niCXZZKqpbb26RBsg0FL3a5f7l9U= Received: by 10.115.14.1 with SMTP id r1mr2320333wai.1191122708510; Sat, 29 Sep 2007 20:25:08 -0700 (PDT) Received: by 10.143.14.9 with HTTP; Sat, 29 Sep 2007 20:25:08 -0700 (PDT) Message-ID: <47d0403c0709292025o430e000dl6ccb20b417858db@mail.gmail.com> Date: Sat, 29 Sep 2007 23:25:08 -0400 From: "Ben Kaduk" To: "Garance A Drosehn" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200709271639.l8RGdREd032105@repoman.freebsd.org> Cc: cvs-src@freebsd.org, Jeff Roberson , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Sep 2007 03:51:17 -0000 On 9/29/07, Garance A Drosehn wrote: > At 4:39 PM +0000 9/27/07, Jeff Roberson wrote: > > > > Modified files: > > sys/kern sched_ule.c > > Log: > > - ... > > - Assert that we're not trying to compile ULE on an unsupported > > architecture. To date, I believe only i386 and amd64 have > > implemented the third cpu switch argument required. > > > > Approved by: re > > Does this mean that I should not switch to ULE on my single-CPU PowerPC > mini-Mac? > I was under the impression that BSD is preferred to ULE for single-processor systems, irregardless of the processor architecture. -Ben Kaduk From owner-cvs-src@FreeBSD.ORG Sun Sep 30 04:03:23 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6092216A46D; Sun, 30 Sep 2007 04:03:23 +0000 (UTC) (envelope-from SRS0=56961485cf8831bee0d55c39f379c590260a189a=473=es.net=oberman@es.net) Received: from postal1.es.net (postal4.es.net [IPv6:2001:400:6000:1::66]) by mx1.freebsd.org (Postfix) with ESMTP id C876C13C4B5; Sun, 30 Sep 2007 04:03:21 +0000 (UTC) (envelope-from SRS0=56961485cf8831bee0d55c39f379c590260a189a=473=es.net=oberman@es.net) Received: from ptavv.es.net (ptavv.es.net [198.128.4.29]) by postal4.es.net (Postal Node 4) with ESMTP (SSL) id JNH77919; Sat, 29 Sep 2007 21:03:19 -0700 Received: from ptavv.es.net (ptavv.es.net [127.0.0.1]) by ptavv.es.net (Tachyon Server) with ESMTP id 094E345018; Sat, 29 Sep 2007 21:03:18 -0700 (PDT) To: "Ben Kaduk" In-Reply-To: Your message of "Sat, 29 Sep 2007 23:25:08 EDT." <47d0403c0709292025o430e000dl6ccb20b417858db@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1191124998_93909P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Sat, 29 Sep 2007 21:03:18 -0700 From: "Kevin Oberman" Message-Id: <20070930040318.094E345018@ptavv.es.net> X-Sender-IP: 198.128.4.29 X-Sender-Domain: es.net X-Recipent: ; ; ; ; ; ; X-Sender: X-To_Name: Ben Kaduk X-To_Domain: gmail.com X-To: "Ben Kaduk" X-To_Email: minimarmot@gmail.com X-To_Alias: minimarmot Cc: cvs-src@freebsd.org, Jeff Roberson , src-committers@freebsd.org, cvs-all@freebsd.org, Garance A Drosehn Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Sep 2007 04:03:23 -0000 --==_Exmh_1191124998_93909P Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > Date: Sat, 29 Sep 2007 23:25:08 -0400 > From: "Ben Kaduk" > Sender: owner-cvs-all@freebsd.org > > On 9/29/07, Garance A Drosehn wrote: > > At 4:39 PM +0000 9/27/07, Jeff Roberson wrote: > > > > > > Modified files: > > > sys/kern sched_ule.c > > > Log: > > > - ... > > > - Assert that we're not trying to compile ULE on an unsupported > > > architecture. To date, I believe only i386 and amd64 have > > > implemented the third cpu switch argument required. > > > > > > Approved by: re > > > > Does this mean that I should not switch to ULE on my single-CPU PowerPC > > mini-Mac? > > > > I was under the impression that BSD is preferred to ULE for single-processor > systems, irregardless of the processor architecture. YMMV, but ULE seems to generally work better then 4BSD for interactive uniprocessor systems. The preferred scheduler for uniprocessor servers is less clear, but many test have shown ULE does better for those systems in the majority of cases. While I believe the plan is that 4BSD be in GENERIC in 7.0, but I suspect ULE (which may still need optimizing to do in a few areas) will soon be the standard scheduler for all 386 and amd64 systems. Jeff has done quite a job on ULE. -- R. Kevin Oberman, Network Engineer Energy Sciences Network (ESnet) Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab) E-mail: oberman@es.net Phone: +1 510 486-8634 Key fingerprint:059B 2DDF 031C 9BA3 14A4 EADA 927D EBB3 987B 3751 --==_Exmh_1191124998_93909P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) Comment: Exmh version 2.5 06/03/2002 iD8DBQFG/yAFkn3rs5h7N1ERAtN4AKCoY0ciJzdIBpnfCwTGchHXKXt8LACfal1M QjQ+2bx8trCVr8G/UgqEKo0= =txQv -----END PGP SIGNATURE----- --==_Exmh_1191124998_93909P-- From owner-cvs-src@FreeBSD.ORG Sun Sep 30 06:16:21 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B5A9816A418; Sun, 30 Sep 2007 06:16:21 +0000 (UTC) (envelope-from marcus@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9DC5713C458; Sun, 30 Sep 2007 06:16:21 +0000 (UTC) (envelope-from marcus@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l8U6GLjU024928; Sun, 30 Sep 2007 06:16:21 GMT (envelope-from marcus@repoman.freebsd.org) Received: (from marcus@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l8U6GLGL024927; Sun, 30 Sep 2007 06:16:21 GMT (envelope-from marcus) Message-Id: <200709300616.l8U6GLGL024927@repoman.freebsd.org> From: Joe Marcus Clarke Date: Sun, 30 Sep 2007 06:16:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/syscons syscons.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Sep 2007 06:16:21 -0000 marcus 2007-09-30 06:16:20 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6) sys/dev/syscons syscons.c Log: MFC: rev 1.452 Fix a bug that will cause a process that calls the VT_WAITACTIVE ioctl to become unkillable when that process is sent a termination signal. The process will sit in waitvt looping in the kernel, and chewing up all available CPU until the system is rebooted. Submitted by: Jilles Tjoelker Reviewed by: bde Revision Changes Path 1.436.2.9 +1 -2 src/sys/dev/syscons/syscons.c From owner-cvs-src@FreeBSD.ORG Sun Sep 30 06:22:17 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4F0516A419; Sun, 30 Sep 2007 06:22:17 +0000 (UTC) (envelope-from marcus@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id ACF2013C447; Sun, 30 Sep 2007 06:22:17 +0000 (UTC) (envelope-from marcus@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l8U6MHCR025344; Sun, 30 Sep 2007 06:22:17 GMT (envelope-from marcus@repoman.freebsd.org) Received: (from marcus@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l8U6MHQX025343; Sun, 30 Sep 2007 06:22:17 GMT (envelope-from marcus) Message-Id: <200709300622.l8U6MHQX025343@repoman.freebsd.org> From: Joe Marcus Clarke Date: Sun, 30 Sep 2007 06:22:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/i386/isa/pcvt pcvt_ext.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Sep 2007 06:22:17 -0000 marcus 2007-09-30 06:22:13 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6) sys/i386/isa/pcvt pcvt_ext.c Log: Fix a bug that will cause a process that calls the VT_WAITACTIVE ioctl to become unkillable when that process is sent a termination signal. The process will sit in waitvt looping in the kernel, and chewing up all available CPU until the system is rebooted. Note: this is not an MFC as this code no longer exists in HEAD. However, this is based on the same syscons fix which was just MFC'd after one week in HEAD. Reviewed by: bde Revision Changes Path 1.35.2.1 +8 -14 src/sys/i386/isa/pcvt/pcvt_ext.c From owner-cvs-src@FreeBSD.ORG Sun Sep 30 11:05:18 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B611216A418; Sun, 30 Sep 2007 11:05:18 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B42E513C480; Sun, 30 Sep 2007 11:05:18 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l8UB5IHk071614; Sun, 30 Sep 2007 11:05:18 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l8UB5I2u071613; Sun, 30 Sep 2007 11:05:18 GMT (envelope-from marius) Message-Id: <200709301105.l8UB5I2u071613@repoman.freebsd.org> From: Marius Strobl Date: Sun, 30 Sep 2007 11:05:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src UPDATING src/share/man/man4 pci.4 src/share/man/man9 pci.9 src/sys/amd64/include legacyvar.h src/sys/amd64/amd64 legacy.c src/sys/amd64/pci pci_bus.c src/sys/arm/xscale/i80321 i80321_pci.c src/sys/arm/xscale/ixp425 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Sep 2007 11:05:18 -0000 marius 2007-09-30 11:05:18 UTC FreeBSD src repository Modified files: . UPDATING share/man/man4 pci.4 share/man/man9 pci.9 sys/amd64/include legacyvar.h sys/amd64/amd64 legacy.c sys/amd64/pci pci_bus.c sys/arm/xscale/i80321 i80321_pci.c sys/arm/xscale/ixp425 ixp425_pci.c sys/arm/xscale/i8134x i81342_pci.c sys/dev/acpica acpi_pci.c acpi_pcib_acpi.c sys/dev/bge if_bge.c sys/dev/cardbus cardbus.c sys/dev/pccbb pccbb.c pccbb_pci.c pccbbvar.h sys/dev/pci pci.c pci_pci.c pci_private.h pci_user.c pcib_private.h pcivar.h sys/i386/include legacyvar.h sys/i386/i386 legacy.c sys/i386/pci pci_bus.c sys/powerpc/powermac grackle.c uninorth.c sys/sparc64/pci ofw_pcibus.c apb.c psycho.c sys/sun4v/sun4v hv_pci.c sys/sys pciio.h param.h usr.sbin/pciconf pciconf.8 pciconf.c tools/tools/pciroms pciroms.c Log: Make the PCI code aware of PCI domains (aka PCI segments) so we can support machines having multiple independently numbered PCI domains and don't support reenumeration without ambiguity amongst the devices as seen by the OS and represented by PCI location strings. This includes introducing a function pci_find_dbsf(9) which works like pci_find_bsf(9) but additionally takes a domain number argument and limiting pci_find_bsf(9) to only search devices in domain 0 (the only domain in single-domain systems). Bge(4) and ofw_pcibus(4) are changed to use pci_find_dbsf(9) instead of pci_find_bsf(9) in order to no longer report false positives when searching for siblings and dupe devices in the same domain respectively. Along with this change the sole host-PCI bridge driver converted to actually make use of PCI domain support is uninorth(4), the others continue to use domain 0 only for now and need to be converted as appropriate later on. Note that this means that the format of the location strings as used by pciconf(8) has been changed and that consumers of potentially need to be recompiled. Suggested by: jhb Reviewed by: grehan, jhb, marcel Approved by: re (kensmith), jhb (PCI maintainer hat) Revision Changes Path 1.505 +7 -0 src/UPDATING 1.19 +7 -6 src/share/man/man4/pci.4 1.10 +28 -1 src/share/man/man9/pci.9 1.61 +5 -0 src/sys/amd64/amd64/legacy.c 1.8 +2 -0 src/sys/amd64/include/legacyvar.h 1.122 +5 -0 src/sys/amd64/pci/pci_bus.c 1.12 +5 -1 src/sys/arm/xscale/i80321/i80321_pci.c 1.2 +5 -1 src/sys/arm/xscale/i8134x/i81342_pci.c 1.5 +5 -0 src/sys/arm/xscale/ixp425/ixp425_pci.c 1.31 +6 -4 src/sys/dev/acpica/acpi_pci.c 1.55 +5 -0 src/sys/dev/acpica/acpi_pcib_acpi.c 1.198 +3 -2 src/sys/dev/bge/if_bge.c 1.66 +3 -2 src/sys/dev/cardbus/cardbus.c 1.165 +5 -0 src/sys/dev/pccbb/pccbb.c 1.26 +3 -0 src/sys/dev/pccbb/pccbb_pci.c 1.32 +1 -0 src/sys/dev/pccbb/pccbbvar.h 1.355 +62 -36 src/sys/dev/pci/pci.c 1.50 +8 -1 src/sys/dev/pci/pci_pci.c 1.25 +3 -2 src/sys/dev/pci/pci_private.h 1.22 +8 -2 src/sys/dev/pci/pci_user.c 1.13 +1 -0 src/sys/dev/pci/pcib_private.h 1.80 +7 -0 src/sys/dev/pci/pcivar.h 1.63 +5 -0 src/sys/i386/i386/legacy.c 1.8 +2 -0 src/sys/i386/include/legacyvar.h 1.128 +5 -0 src/sys/i386/pci/pci_bus.c 1.9 +3 -1 src/sys/powerpc/powermac/grackle.c 1.16 +3 -1 src/sys/powerpc/powermac/uninorth.c 1.14 +2 -0 src/sys/sparc64/pci/apb.c 1.16 +7 -4 src/sys/sparc64/pci/ofw_pcibus.c 1.70 +3 -0 src/sys/sparc64/pci/psycho.c 1.4 +5 -0 src/sys/sun4v/sun4v/hv_pci.c 1.308 +1 -1 src/sys/sys/param.h 1.7 +14 -13 src/sys/sys/pciio.h 1.2 +4 -3 src/tools/tools/pciroms/pciroms.c 1.29 +8 -5 src/usr.sbin/pciconf/pciconf.8 1.28 +5 -3 src/usr.sbin/pciconf/pciconf.c From owner-cvs-src@FreeBSD.ORG Sun Sep 30 19:33:20 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1321216A417; Sun, 30 Sep 2007 19:33:20 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id EBCB313C45B; Sun, 30 Sep 2007 19:33:19 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l8UJXJet034903; Sun, 30 Sep 2007 19:33:19 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l8UJXJeG034902; Sun, 30 Sep 2007 19:33:19 GMT (envelope-from marius) Message-Id: <200709301933.l8UJXJeG034902@repoman.freebsd.org> From: Marius Strobl Date: Sun, 30 Sep 2007 19:33:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/conf files.sparc64 options.sparc64 src/sys/dev/uart uart_kbd_sun.c uart_kbd_sun.h src/sys/sparc64/conf NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Sep 2007 19:33:20 -0000 marius 2007-09-30 19:33:19 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/conf files.sparc64 options.sparc64 sys/dev/uart uart_kbd_sun.c uart_kbd_sun.h sys/sparc64/conf NOTES Log: MFC: sys/conf/files.sparc64 1.83; sys/conf/options.sparc64 1.24; sys/dev/uart/uart_kbd_sun.c 1.10, 1.11 (partial), 1.13; sys/dev/uart/uart_kbd_sun.h 1.3; sys/sparc64/conf/NOTES 1.30 - In sunkbd_probe_keyboard() don't bother to determine the keyboard layout as we have no use for that info. Instead let this function return the keyboard ID and verify at its invocation in sunkbd_configure() that we're talking to a Sun type 4/5/6 keyboard, i.e. a keyboard supported by this driver. - Add an option SUNKBD_EMULATE_ATKBD whose code is based on the respective code in ukbd(4) and like UKBD_EMULATE_ATSCANCODE causes this driver to emit AT keyboard/KB_101 compatible scan codes in K_RAW mode as assumed by kbdmux(4). Unlike UKBD_EMULATE_ATSCANCODE, SUNKBD_EMULATE_ATKBD also triggers the use of AT keyboard maps and thus allows to use the map files in share/syscons/keymaps with this driver at the cost of an additional translation (in ukbd(4) this just is the way of operation). - Implement an option SUNKBD_DFLT_KEYMAP, which like the equivalent options of the other keyboard drivers allows to specify the default in-kernel keyboard map. For obvious reasons this made to only work when also using SUNKBD_EMULATE_ATKBD. - Implement sunkbd_check(), sunkbd_check_char() and sunkbd_clear_state(), which are also required for interoperability with kbdmux(4). - Implement K_CODE mode and FreeBSD keypad compose. - As a minor hack define KBD_DFLT_KEYMAP also in the !SUNKBD_EMULATE_ATKBD case so we can obtain fkey_tab from rather than having to duplicate it and #ifdef some more code. - Don't use the TX-buffer for writing the two command bytes for setting the keyboard LEDs as this consequently requires a hardware FIFO that is at least two bytes in depth, which the NMOS-variant of the Zilog SCCs doesn't have. Thus use an inlined version of uart_putc() to consecutively write the command bytes (a cleaner approach would be to do this via the soft interrupt handler but that variant wouldn't work while in ddb(4)). [1] - Fix some minor style(9) bugs. PR: 90316 [1] Revision Changes Path 1.73.2.4 +5 -0 src/sys/conf/files.sparc64 1.13.2.1 +2 -0 src/sys/conf/options.sparc64 1.5.2.4 +382 -86 src/sys/dev/uart/uart_kbd_sun.c 1.2.2.1 +3 -0 src/sys/dev/uart/uart_kbd_sun.h 1.19.2.3 +10 -0 src/sys/sparc64/conf/NOTES From owner-cvs-src@FreeBSD.ORG Sun Sep 30 22:05:30 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B339516A41B for ; Sun, 30 Sep 2007 22:05:30 +0000 (UTC) (envelope-from tom@tomjudge.com) Received: from smtp812.mail.ird.yahoo.com (smtp812.mail.ird.yahoo.com [217.146.188.72]) by mx1.freebsd.org (Postfix) with SMTP id DC35013C468 for ; Sun, 30 Sep 2007 22:05:29 +0000 (UTC) (envelope-from tom@tomjudge.com) Received: (qmail 26918 invoked from network); 30 Sep 2007 21:38:49 -0000 Received: from unknown (HELO ?192.168.1.2?) (thomasjudge@btinternet.com@217.44.142.35 with plain) by smtp812.mail.ird.yahoo.com with SMTP; 30 Sep 2007 21:38:49 -0000 X-YMail-OSG: erorlkAVM1lGaNWIXPvbKrr9sQZ3n9PVAwihn3G76ZFk_Cp_ Message-ID: <47002674.8050707@tomjudge.com> Date: Sun, 30 Sep 2007 23:43:00 +0100 From: Tom Judge User-Agent: Thunderbird 1.5.0.13 (X11/20070824) MIME-Version: 1.0 To: "Bjoern A. Zeeb" References: <200709241339.l8ODd6k6059694@repoman.freebsd.org> In-Reply-To: <200709241339.l8ODd6k6059694@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Sep 2007 22:05:30 -0000 Bjoern A. Zeeb wrote: > bz 2007-09-24 13:39:06 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/ufs/ffs ffs_alloc.c > Log: > MFC rev. 1.147 > Fix a DIV0 in case a large value for fs_avgfilesize or fs_avgfpdir > is given (with newfs or tunefs) and dirsize overflows. > > In case dirsize is <= 0 because of an overflow set maxcontigdirs > to 0 so it will be 1 later. This is what would happen for large > fs_avgfilesize. [1] > > Submitted by: pjd [1] > > Revision Changes Path > 1.132.2.7 +4 -1 src/sys/ufs/ffs/ffs_alloc.c Does this by any chance fis this PR: kern/111352? Tom From owner-cvs-src@FreeBSD.ORG Sun Sep 30 22:11:50 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6858E16A41A for ; Sun, 30 Sep 2007 22:11:50 +0000 (UTC) (envelope-from tom@tomjudge.com) Received: from smtp808.mail.ird.yahoo.com (smtp808.mail.ird.yahoo.com [217.146.188.68]) by mx1.freebsd.org (Postfix) with SMTP id 9A26513C46A for ; Sun, 30 Sep 2007 22:11:49 +0000 (UTC) (envelope-from tom@tomjudge.com) Received: (qmail 61527 invoked from network); 30 Sep 2007 22:11:48 -0000 Received: from unknown (HELO ?192.168.1.2?) (thomasjudge@btinternet.com@217.44.142.35 with plain) by smtp808.mail.ird.yahoo.com with SMTP; 30 Sep 2007 22:11:48 -0000 X-YMail-OSG: vmen8PcVM1nghGkniho0poBE2dfpx7hWxhJLpe8CWnOqruD_ Message-ID: <47002E2F.3030306@tomjudge.com> Date: Mon, 01 Oct 2007 00:15:59 +0100 From: Tom Judge User-Agent: Thunderbird 1.5.0.13 (X11/20070824) MIME-Version: 1.0 To: Tom Judge References: <200709241339.l8ODd6k6059694@repoman.freebsd.org> <47002674.8050707@tomjudge.com> In-Reply-To: <47002674.8050707@tomjudge.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, "Bjoern A. Zeeb" , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Sep 2007 22:11:50 -0000 Tom Judge wrote: > Bjoern A. Zeeb wrote: >> bz 2007-09-24 13:39:06 UTC >> >> FreeBSD src repository >> >> Modified files: (Branch: RELENG_6) >> sys/ufs/ffs ffs_alloc.c Log: >> MFC rev. 1.147 >> Fix a DIV0 in case a large value for fs_avgfilesize or fs_avgfpdir >> is given (with newfs or tunefs) and dirsize overflows. >> In case dirsize is <= 0 because of an overflow set maxcontigdirs >> to 0 so it will be 1 later. This is what would happen for large >> fs_avgfilesize. [1] >> Submitted by: pjd [1] >> Revision Changes Path >> 1.132.2.7 +4 -1 src/sys/ufs/ffs/ffs_alloc.c > > > Does this by any chance fis this PR: kern/111352? s/fis/fix/ Tom From owner-cvs-src@FreeBSD.ORG Sun Sep 30 22:30:49 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 43FBB16A419; Sun, 30 Sep 2007 22:30:49 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com [216.240.101.25]) by mx1.freebsd.org (Postfix) with ESMTP id E2D6C13C461; Sun, 30 Sep 2007 22:30:48 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from [192.168.1.103] (c-67-160-44-208.hsd1.wa.comcast.net [67.160.44.208]) (authenticated bits=0) by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id l8UMUf5v053147 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO); Sun, 30 Sep 2007 18:30:42 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Sun, 30 Sep 2007 15:33:27 -0700 (PDT) From: Jeff Roberson X-X-Sender: jroberson@10.0.0.1 To: Peter Grehan In-Reply-To: <46FBDFE8.9050909@freebsd.org> Message-ID: <20070930153101.T583@10.0.0.1> References: <200709271639.l8RGdREd032105@repoman.freebsd.org> <46FBDFE8.9050909@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, Jeff Roberson , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Sep 2007 22:30:49 -0000 On Thu, 27 Sep 2007, Peter Grehan wrote: >> - Assert that we're not trying to compile ULE on an unsupported >> architecture. To date, I believe only i386 and amd64 have implemented >> the third cpu switch argument required. > > ARM has it: > > http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/arm/arm/swtch.S?r1=1.20#rev1.20 Oh excellent Peter. I hadn't seen that. Did you verify that it works? Does arm support SMP? It looks like it does not? > > PPC doesn't, though I think you told me that it was only required when > running MP. Is that still the case ? For UP it doesn't need to wait for blocked lock to clear but it does need to set td_lock. On UP there are no special synchronization requirements so it can happen as the very first instruction in cpu_switch. Jeff > > later, > > Peter. > From owner-cvs-src@FreeBSD.ORG Sun Sep 30 22:33:15 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6106116A418; Sun, 30 Sep 2007 22:33:15 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com [216.240.101.25]) by mx1.freebsd.org (Postfix) with ESMTP id E70C013C481; Sun, 30 Sep 2007 22:33:14 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from [192.168.1.103] (c-67-160-44-208.hsd1.wa.comcast.net [67.160.44.208]) (authenticated bits=0) by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id l8UMXCof053657 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO); Sun, 30 Sep 2007 18:33:13 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Sun, 30 Sep 2007 15:35:58 -0700 (PDT) From: Jeff Roberson X-X-Sender: jroberson@10.0.0.1 To: Kevin Oberman In-Reply-To: <20070930040318.094E345018@ptavv.es.net> Message-ID: <20070930153430.U583@10.0.0.1> References: <20070930040318.094E345018@ptavv.es.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, cvs-src@freebsd.org, Jeff Roberson , cvs-all@freebsd.org, Ben Kaduk , Garance A Drosehn Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Sep 2007 22:33:15 -0000 On Sat, 29 Sep 2007, Kevin Oberman wrote: >> Date: Sat, 29 Sep 2007 23:25:08 -0400 >> From: "Ben Kaduk" >> Sender: owner-cvs-all@freebsd.org >> >> On 9/29/07, Garance A Drosehn wrote: >>> At 4:39 PM +0000 9/27/07, Jeff Roberson wrote: >>>> >>>> Modified files: >>>> sys/kern sched_ule.c >>>> Log: >>>> - ... >>>> - Assert that we're not trying to compile ULE on an unsupported >>>> architecture. To date, I believe only i386 and amd64 have >>>> implemented the third cpu switch argument required. >>>> >>>> Approved by: re >>> >>> Does this mean that I should not switch to ULE on my single-CPU PowerPC >>> mini-Mac? >>> >> >> I was under the impression that BSD is preferred to ULE for single-processor >> systems, irregardless of the processor architecture. > > YMMV, but ULE seems to generally work better then 4BSD for interactive > uniprocessor systems. The preferred scheduler for uniprocessor servers > is less clear, but many test have shown ULE does better for those > systems in the majority of cases. I feel it's safe to say desktop behavior on UP is definitely superior. I think there is no significant difference on UP between 4BSD and ULE except perhaps in context switching microbenchmarks where ULE falls behind. > > While I believe the plan is that 4BSD be in GENERIC in 7.0, but I > suspect ULE (which may still need optimizing to do in a few areas) will > soon be the standard scheduler for all 386 and amd64 systems. I'm not sure if the plan is settled yet, however you're probably right. > > Jeff has done quite a job on ULE. Thanks, Jeff > -- > R. Kevin Oberman, Network Engineer > Energy Sciences Network (ESnet) > Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab) > E-mail: oberman@es.net Phone: +1 510 486-8634 > Key fingerprint:059B 2DDF 031C 9BA3 14A4 EADA 927D EBB3 987B 3751 > From owner-cvs-src@FreeBSD.ORG Sun Sep 30 22:45:00 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3242B16A420 for ; Sun, 30 Sep 2007 22:45:00 +0000 (UTC) (envelope-from minimarmot@gmail.com) Received: from nz-out-0506.google.com (nz-out-0506.google.com [64.233.162.238]) by mx1.freebsd.org (Postfix) with ESMTP id BF00013C458 for ; Sun, 30 Sep 2007 22:44:59 +0000 (UTC) (envelope-from minimarmot@gmail.com) Received: by nz-out-0506.google.com with SMTP id l8so2144628nzf for ; Sun, 30 Sep 2007 15:44:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=2aq6X+gwCbPJLHnIxlWAzfKjJuUyV2mNQlXlLlJVg3U=; b=VUMGythnTVUD9CuxJ72SMYBSHiv1fFAyjySI9RvHJfOShJbyng66eGuwPjiJDiKf1qrapgsHzQ4z3o4C786cnTYqdhgwTFEKZSedaU0MfmDWDFDGVFZgpbWZOKhCPdW6ZaNd5feCnvEcCVcLx2lBmkuCNQ5Md+RQ4DCZ1xnDcxs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Vanqr0IrHf1+YUBz+r+4lpe6oAkYB3wcaurTUnqG25jEK9gDsH1IcQpLoQigtNqHKxX14YzvC21vZLC+FRmLUI+HigYemBSLTh8MUtMY52d1NplxRVVlgwyVBpQBbAoT3qwgpyyAeko1TC1NacEMFvDDnRr7gvPv/+ircBGk0fE= Received: by 10.64.142.10 with SMTP id p10mr3878072qbd.1191192298883; Sun, 30 Sep 2007 15:44:58 -0700 (PDT) Received: by 10.143.14.9 with HTTP; Sun, 30 Sep 2007 15:44:58 -0700 (PDT) Message-ID: <47d0403c0709301544u1df182a7vcf30062b0b92c645@mail.gmail.com> Date: Sun, 30 Sep 2007 18:44:58 -0400 From: "Ben Kaduk" To: "Jeff Roberson" In-Reply-To: <20070930153430.U583@10.0.0.1> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070930040318.094E345018@ptavv.es.net> <20070930153430.U583@10.0.0.1> Cc: cvs-src@freebsd.org, Jeff Roberson , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Sep 2007 22:45:00 -0000 On 9/30/07, Jeff Roberson wrote: > On Sat, 29 Sep 2007, Kevin Oberman wrote: > > >> Date: Sat, 29 Sep 2007 23:25:08 -0400 > >> From: "Ben Kaduk" > >> Sender: owner-cvs-all@freebsd.org > >> > >> On 9/29/07, Garance A Drosehn wrote: [snip] > >>> > >>> Does this mean that I should not switch to ULE on my single-CPU PowerPC > >>> mini-Mac? > >>> > >> > >> I was under the impression that BSD is preferred to ULE for single-processor > >> systems, irregardless of the processor architecture. > > > > YMMV, but ULE seems to generally work better then 4BSD for interactive > > uniprocessor systems. The preferred scheduler for uniprocessor servers > > is less clear, but many test have shown ULE does better for those > > systems in the majority of cases. > > I feel it's safe to say desktop behavior on UP is definitely superior. I > think there is no significant difference on UP between 4BSD and ULE except > perhaps in context switching microbenchmarks where ULE falls behind. > I'm glad to be corrected. Thanks for all the great work, Jeff! -Ben Kaduk From owner-cvs-src@FreeBSD.ORG Mon Oct 1 01:18:36 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6D5EF16A41A; Mon, 1 Oct 2007 01:18:36 +0000 (UTC) (envelope-from grehan@freebsd.org) Received: from dommail.onthenet.com.au (dommail.OntheNet.com.au [203.13.70.57]) by mx1.freebsd.org (Postfix) with ESMTP id 1663B13C468; Mon, 1 Oct 2007 01:18:34 +0000 (UTC) (envelope-from grehan@freebsd.org) Received: from excfreebsd.hq.netapp.com (nat-198-95-226-228.netapp.com [198.95.226.228]) by dommail.onthenet.com.au (MOS 3.7.5a-GA) with ESMTP id DEB04111 (AUTH peterg@ptree32.com.au); Mon, 1 Oct 2007 11:18:20 +1000 (EST) Message-ID: <47004ACF.5020901@freebsd.org> Date: Sun, 30 Sep 2007 18:18:07 -0700 From: Peter Grehan User-Agent: Thunderbird 2.0.0.0 (X11/20070525) MIME-Version: 1.0 To: Jeff Roberson References: <200709271639.l8RGdREd032105@repoman.freebsd.org> <46FBDFE8.9050909@freebsd.org> <20070930153101.T583@10.0.0.1> In-Reply-To: <20070930153101.T583@10.0.0.1> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, Jeff Roberson , src-committers@FreeBSD.org, cognet@freebsd.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: grehan@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 01:18:36 -0000 Hi Jeff, >> ARM has it: .. >Did you verify that it works? No. Olivier would be able to answer though. > Does arm support SMP? It looks like it does not? Don't think so. > For UP it doesn't need to wait for blocked lock to clear but it does > need to set td_lock. On UP there are no special synchronization > requirements so it can happen as the very first instruction in cpu_switch. OK, I'll give it a whirl. later, Peter. From owner-cvs-src@FreeBSD.ORG Mon Oct 1 01:44:21 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4964116A417; Mon, 1 Oct 2007 01:44:21 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com [216.240.101.25]) by mx1.freebsd.org (Postfix) with ESMTP id 0D4F913C461; Mon, 1 Oct 2007 01:44:20 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from [192.168.1.103] (c-67-160-44-208.hsd1.wa.comcast.net [67.160.44.208]) (authenticated bits=0) by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id l911iIDW090166 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO); Sun, 30 Sep 2007 21:44:19 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Sun, 30 Sep 2007 18:47:04 -0700 (PDT) From: Jeff Roberson X-X-Sender: jroberson@10.0.0.1 To: Peter Grehan In-Reply-To: <47004ACF.5020901@freebsd.org> Message-ID: <20070930184601.R583@10.0.0.1> References: <200709271639.l8RGdREd032105@repoman.freebsd.org> <46FBDFE8.9050909@freebsd.org> <20070930153101.T583@10.0.0.1> <47004ACF.5020901@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, Jeff Roberson , src-committers@FreeBSD.org, cognet@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 01:44:21 -0000 On Sun, 30 Sep 2007, Peter Grehan wrote: > Hi Jeff, > >>> ARM has it: > .. >> Did you verify that it works? > > No. Olivier would be able to answer though. If you can test ULE on UP arm/powerpc I'd appreciate it. Then we could add them to the set of supported architectures in ULE. > >> Does arm support SMP? It looks like it does not? > > Don't think so. > >> For UP it doesn't need to wait for blocked lock to clear but it does need >> to set td_lock. On UP there are no special synchronization requirements so >> it can happen as the very first instruction in cpu_switch. > > OK, I'll give it a whirl. > > later, > > Peter. > Thanks, Jeff From owner-cvs-src@FreeBSD.ORG Mon Oct 1 03:22:29 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E4ED716A418; Mon, 1 Oct 2007 03:22:29 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id CF9B213C467; Mon, 1 Oct 2007 03:22:29 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l913MT61086692; Mon, 1 Oct 2007 03:22:29 GMT (envelope-from rrs@repoman.freebsd.org) Received: (from rrs@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l913MTu4086691; Mon, 1 Oct 2007 03:22:29 GMT (envelope-from rrs) Message-Id: <200710010322.l913MTu4086691@repoman.freebsd.org> From: Randall Stewart Date: Mon, 1 Oct 2007 03:22:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet sctp_asconf.c sctp_constants.h sctp_indata.c sctp_input.c sctp_output.c sctp_output.h sctp_pcb.c sctp_timer.c sctp_usrreq.c sctp_var.h sctputil.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 03:22:30 -0000 rrs 2007-10-01 03:22:29 UTC FreeBSD src repository Modified files: sys/netinet sctp_asconf.c sctp_constants.h sctp_indata.c sctp_input.c sctp_output.c sctp_output.h sctp_pcb.c sctp_timer.c sctp_usrreq.c sctp_var.h sctputil.c Log: - Bug fix managing congestion parameter on immediate retransmittion by handover event (fast mobility code) - Fixed problem of mobility code which is caused by remaining parameters in the deleted primary destination. - Add a missing lock. When a peer sends an INIT, and while we are processing it to send an INIT-ACK the socket is closed, we did not hold a lock to keep the socket from going away. Add protection for this case. - Fix so that arwnd is alway uses the minimal rwnd if the user has set the socket buffer smaller. Found this when the test org decided to see what happens when you set in a rwnd of 10 bytes (which is not allowed per RFC .. 4k is minimum). - Fixes so a cookie-echo ootb will NOT cause an abort to be sent. This was happening in a MPI collision case. - Examined all panics and unless there was no recovery, moved any that were not already to INVARANTS. Approved by: re@freebsd.org (gnn) Revision Changes Path 1.34 +10 -3 src/sys/netinet/sctp_asconf.c 1.32 +3 -0 src/sys/netinet/sctp_constants.h 1.45 +7 -2 src/sys/netinet/sctp_indata.c 1.65 +54 -32 src/sys/netinet/sctp_input.c 1.58 +34 -7 src/sys/netinet/sctp_output.c 1.13 +1 -1 src/sys/netinet/sctp_output.h 1.61 +9 -0 src/sys/netinet/sctp_pcb.c 1.32 +3 -0 src/sys/netinet/sctp_timer.c 1.48 +10 -0 src/sys/netinet/sctp_usrreq.c 1.20 +4 -2 src/sys/netinet/sctp_var.h 1.64 +12 -3 src/sys/netinet/sctputil.c From owner-cvs-src@FreeBSD.ORG Mon Oct 1 07:37:46 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E1D3F16A41A; Mon, 1 Oct 2007 07:37:46 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail11.syd.optusnet.com.au (mail11.syd.optusnet.com.au [211.29.132.192]) by mx1.freebsd.org (Postfix) with ESMTP id 56BFE13C4B7; Mon, 1 Oct 2007 07:37:46 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from besplex.bde.org (c220-239-235-248.carlnfd3.nsw.optusnet.com.au [220.239.235.248]) by mail11.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id l917bBc5031771 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 1 Oct 2007 17:37:11 +1000 Date: Mon, 1 Oct 2007 17:37:10 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Jeff Roberson In-Reply-To: <20070930153430.U583@10.0.0.1> Message-ID: <20071001172620.X1839@besplex.bde.org> References: <20070930040318.094E345018@ptavv.es.net> <20070930153430.U583@10.0.0.1> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, Kevin Oberman , cvs-src@freebsd.org, Jeff Roberson , Garance A Drosehn , Ben Kaduk , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 07:37:47 -0000 On Sun, 30 Sep 2007, Jeff Roberson wrote: > On Sat, 29 Sep 2007, Kevin Oberman wrote: >> YMMV, but ULE seems to generally work better then 4BSD for interactive >> uniprocessor systems. The preferred scheduler for uniprocessor servers >> is less clear, but many test have shown ULE does better for those >> systems in the majority of cases. > > I feel it's safe to say desktop behavior on UP is definitely superior. This is unsafe to say. > I > think there is no significant difference on UP between 4BSD and ULE This may be safe to say, but is inconsistent with the above. > except > perhaps in context switching microbenchmarks where ULE falls behind. It is safe to say that interactive users cannot notice insignificant differences. It takes a micro-benchmark to notice possibly-significant differences of hundreds or even thousands of nanonseconds for context switching. ULE may give higher priority to interactive processes, but most loss of interactivity is caused by blocking on I/O, and there is nothing nothing a scheduler can do to speed up slow or overloaded devices. Bruce From owner-cvs-src@FreeBSD.ORG Mon Oct 1 09:11:25 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4AE0316A41B; Mon, 1 Oct 2007 09:11:25 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com [216.240.101.25]) by mx1.freebsd.org (Postfix) with ESMTP id DB74C13C494; Mon, 1 Oct 2007 09:11:24 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from [192.168.1.103] (c-67-160-44-208.hsd1.wa.comcast.net [67.160.44.208]) (authenticated bits=0) by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id l919BC6K030089 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO); Mon, 1 Oct 2007 05:11:14 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Mon, 1 Oct 2007 02:13:57 -0700 (PDT) From: Jeff Roberson X-X-Sender: jroberson@10.0.0.1 To: Bruce Evans In-Reply-To: <20071001172620.X1839@besplex.bde.org> Message-ID: <20071001020835.B583@10.0.0.1> References: <20070930040318.094E345018@ptavv.es.net> <20070930153430.U583@10.0.0.1> <20071001172620.X1839@besplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, Kevin Oberman , cvs-src@freebsd.org, Jeff Roberson , Garance A Drosehn , Ben Kaduk , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 09:11:25 -0000 On Mon, 1 Oct 2007, Bruce Evans wrote: > On Sun, 30 Sep 2007, Jeff Roberson wrote: > >> On Sat, 29 Sep 2007, Kevin Oberman wrote: > >>> YMMV, but ULE seems to generally work better then 4BSD for interactive >>> uniprocessor systems. The preferred scheduler for uniprocessor servers >>> is less clear, but many test have shown ULE does better for those >>> systems in the majority of cases. >> >> I feel it's safe to say desktop behavior on UP is definitely superior. > > This is unsafe to say. Given that the overwhelming amount of feedback by qualified poeple, I think it's fair to say that ULE gives a more responsive system under load. > >> I think there is no significant difference on UP between 4BSD and ULE > > This may be safe to say, but is inconsistent with the above. I meant no significant difference in performance. I'm sure there are corner case workloads in favor of one or the other. > >> except perhaps in context switching microbenchmarks where ULE falls behind. > > It is safe to say that interactive users cannot notice insignificant > differences. It takes a micro-benchmark to notice possibly-significant > differences of hundreds or even thousands of nanonseconds for context > switching. > > ULE may give higher priority to interactive processes, but most loss of > interactivity is caused by blocking on I/O, and there is nothing nothing > a scheduler can do to speed up slow or overloaded devices. There is a significant enough class of problems that benefit from the improved interactive priorities that people notice it. I have heard reports from a number of laptop users who can run at lower power levels using ULE. I am trivially able to create workloads where 4bsd falls over well before ULE. It is true that io behavior dominates in many cases but that's really a seperate issue. Jeff > > Bruce > From owner-cvs-src@FreeBSD.ORG Mon Oct 1 09:28:09 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 394A216A41B; Mon, 1 Oct 2007 09:28:09 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id DB3EE13C467; Mon, 1 Oct 2007 09:28:08 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 4B80A41C749; Mon, 1 Oct 2007 11:10:08 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id UQuRNOUD-4KL; Mon, 1 Oct 2007 11:10:05 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id C584441C751; Mon, 1 Oct 2007 11:10:05 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 42F87444885; Mon, 1 Oct 2007 09:06:20 +0000 (UTC) Date: Mon, 1 Oct 2007 09:06:19 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Tom Judge In-Reply-To: <47002E2F.3030306@tomjudge.com> Message-ID: <20071001090547.H85753@maildrop.int.zabbadoz.net> References: <200709241339.l8ODd6k6059694@repoman.freebsd.org> <47002674.8050707@tomjudge.com> <47002E2F.3030306@tomjudge.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 09:28:09 -0000 On Mon, 1 Oct 2007, Tom Judge wrote: > Tom Judge wrote: >> Bjoern A. Zeeb wrote: >>> bz 2007-09-24 13:39:06 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: (Branch: RELENG_6) >>> sys/ufs/ffs ffs_alloc.c Log: >>> MFC rev. 1.147 >>> Fix a DIV0 in case a large value for fs_avgfilesize or fs_avgfpdir >>> is given (with newfs or tunefs) and dirsize overflows. >>> In case dirsize is <= 0 because of an overflow set maxcontigdirs >>> to 0 so it will be 1 later. This is what would happen for large >>> fs_avgfilesize. [1] >>> Submitted by: pjd [1] >>> Revision Changes Path >>> 1.132.2.7 +4 -1 src/sys/ufs/ffs/ffs_alloc.c >> >> >> Does this by any chance fis this PR: kern/111352? > > s/fis/fix/ yes it should. I closed the PR, See the comment there. Thanks for pointing me at the PR. -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT Software is harder than hardware so better get it right the first time. From owner-cvs-src@FreeBSD.ORG Mon Oct 1 10:45:33 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5688016A418; Mon, 1 Oct 2007 10:45:33 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail03.syd.optusnet.com.au (mail03.syd.optusnet.com.au [211.29.132.184]) by mx1.freebsd.org (Postfix) with ESMTP id D7FCF13C457; Mon, 1 Oct 2007 10:45:32 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from besplex.bde.org (c220-239-235-248.carlnfd3.nsw.optusnet.com.au [220.239.235.248]) by mail03.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id l91AjSBP006034 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 1 Oct 2007 20:45:29 +1000 Date: Mon, 1 Oct 2007 20:45:27 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: "Bjoern A. Zeeb" In-Reply-To: <20071001090547.H85753@maildrop.int.zabbadoz.net> Message-ID: <20071001201359.M2557@besplex.bde.org> References: <200709241339.l8ODd6k6059694@repoman.freebsd.org> <47002674.8050707@tomjudge.com> <47002E2F.3030306@tomjudge.com> <20071001090547.H85753@maildrop.int.zabbadoz.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Tom Judge , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 10:45:33 -0000 On Mon, 1 Oct 2007, Bjoern A. Zeeb wrote: > On Mon, 1 Oct 2007, Tom Judge wrote: > >> Tom Judge wrote: >>> Bjoern A. Zeeb wrote: >>>> bz 2007-09-24 13:39:06 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: (Branch: RELENG_6) >>>> sys/ufs/ffs ffs_alloc.c Log: >>>> MFC rev. 1.147 >>>> Fix a DIV0 in case a large value for fs_avgfilesize or fs_avgfpdir >>>> is given (with newfs or tunefs) and dirsize overflows. >>>> In case dirsize is <= 0 because of an overflow set maxcontigdirs >>>> to 0 so it will be 1 later. This is what would happen for large >>>> fs_avgfilesize. [1] >>>> Submitted by: pjd [1] >>>> Revision Changes Path >>>> 1.132.2.7 +4 -1 src/sys/ufs/ffs/ffs_alloc.c >>> >>> >>> Does this by any chance fis this PR: kern/111352? >> >> s/fis/fix/ > > yes it should. I closed the PR, See the comment there. s/fix/work around/ The bug is in newfs and tunefs permitting garbage parameters, so it cannot be fixed in ffs_alloc.c. It can also be worked around better in ffs_vfsops.c: fix the garbage parameters at mount time, instead of letting them cause undefined behaviour on every directory allocation later and recovering from the overflow in some cases. ffs_vfsops.c already adjusts the parameters for file systems created by old versions of newfs which don't support them. Then they have the garbage value 0, while versions of newfs and tunefs that support them enforce them being > 0. Enforcing them being <= a maximum value belongs mext to the code that enforces them being > 0, and fixing up garbage large values belongs next to the code that fixes up garbage values of <= 0. Fixups belong in fsck_ffs too, but fsck_ffs doesn't even reference the 5-yar old avgfpdir and avgfilesize parameters. History shows that fixups at mount time take a long time to get moved to fsck_ffs. It's just easier to do runtime fixups. Fixups at mount time used to be marked with /* XXX [move to fsck] */, but now there are many more of them than there used to be, and most aren't marked. Bruce From owner-cvs-src@FreeBSD.ORG Mon Oct 1 11:10:07 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 445CF16A47B; Mon, 1 Oct 2007 11:10:07 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id E211413C4B9; Mon, 1 Oct 2007 11:10:06 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 8FA3E41C757; Mon, 1 Oct 2007 13:10:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id wwrhcyEudYSB; Mon, 1 Oct 2007 13:10:05 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id 35C1D41C75C; Mon, 1 Oct 2007 13:10:05 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id DAE82444885; Mon, 1 Oct 2007 11:06:58 +0000 (UTC) Date: Mon, 1 Oct 2007 11:06:58 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Bruce Evans In-Reply-To: <20071001201359.M2557@besplex.bde.org> Message-ID: <20071001110057.V85753@maildrop.int.zabbadoz.net> References: <200709241339.l8ODd6k6059694@repoman.freebsd.org> <47002674.8050707@tomjudge.com> <47002E2F.3030306@tomjudge.com> <20071001090547.H85753@maildrop.int.zabbadoz.net> <20071001201359.M2557@besplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 11:10:07 -0000 On Mon, 1 Oct 2007, Bruce Evans wrote: > On Mon, 1 Oct 2007, Bjoern A. Zeeb wrote: > >> On Mon, 1 Oct 2007, Tom Judge wrote: >> >>> Tom Judge wrote: >>>> Bjoern A. Zeeb wrote: >>>>> bz 2007-09-24 13:39:06 UTC >>>>> >>>>> FreeBSD src repository >>>>> >>>>> Modified files: (Branch: RELENG_6) >>>>> sys/ufs/ffs ffs_alloc.c Log: >>>>> MFC rev. 1.147 >>>>> Fix a DIV0 in case a large value for fs_avgfilesize or fs_avgfpdir >>>>> is given (with newfs or tunefs) and dirsize overflows. >>>>> In case dirsize is <= 0 because of an overflow set maxcontigdirs >>>>> to 0 so it will be 1 later. This is what would happen for large >>>>> fs_avgfilesize. [1] >>>>> Submitted by: pjd [1] >>>>> Revision Changes Path >>>>> 1.132.2.7 +4 -1 src/sys/ufs/ffs/ffs_alloc.c >>>> >>>> >>>> Does this by any chance fis this PR: kern/111352? >>> >>> s/fis/fix/ >> >> yes it should. I closed the PR, See the comment there. > > s/fix/work around/ > > The bug is in newfs and tunefs permitting garbage parameters, so it cannot > be fixed in ffs_alloc.c. No matter what iput the kernel gets and from where, it MUST NOT (or at least SHOULD not;) panic unless explicitly request by KASSERT/panic/.. So this commit fixes a DIV0 bug in the kernel. Of course you are right, that the values should be checked by the tools that we have in the tree so that this problem would not occur. We could even check if the values given make sense at all, but that still is a different story to a kernel panic. -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT Software is harder than hardware so better get it right the first time. From owner-cvs-src@FreeBSD.ORG Mon Oct 1 11:27:18 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D777516A468; Mon, 1 Oct 2007 11:27:18 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail35.syd.optusnet.com.au (mail35.syd.optusnet.com.au [211.29.133.51]) by mx1.freebsd.org (Postfix) with ESMTP id 1BA0513C455; Mon, 1 Oct 2007 11:27:17 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from besplex.bde.org (c220-239-235-248.carlnfd3.nsw.optusnet.com.au [220.239.235.248]) by mail35.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id l91BQdkB026034 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 1 Oct 2007 21:26:46 +1000 Date: Mon, 1 Oct 2007 21:26:39 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Jeff Roberson In-Reply-To: <20071001020835.B583@10.0.0.1> Message-ID: <20071001205923.U2657@besplex.bde.org> References: <20070930040318.094E345018@ptavv.es.net> <20070930153430.U583@10.0.0.1> <20071001172620.X1839@besplex.bde.org> <20071001020835.B583@10.0.0.1> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-all@freebsd.org, src-committers@freebsd.org, Kevin Oberman , cvs-src@freebsd.org, Jeff Roberson , Garance A Drosehn , Ben Kaduk , Bruce Evans Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 11:27:19 -0000 On Mon, 1 Oct 2007, Jeff Roberson wrote: > On Mon, 1 Oct 2007, Bruce Evans wrote: > >> On Sun, 30 Sep 2007, Jeff Roberson wrote: >> >>> On Sat, 29 Sep 2007, Kevin Oberman wrote: >> >>>> YMMV, but ULE seems to generally work better then 4BSD for interactive >>>> uniprocessor systems. The preferred scheduler for uniprocessor servers >>>> is less clear, but many test have shown ULE does better for those >>>> systems in the majority of cases. >>> >>> I feel it's safe to say desktop behavior on UP is definitely superior. >> >> This is unsafe to say. > > Given that the overwhelming amount of feedback by qualified poeple, I think > it's fair to say that ULE gives a more responsive system under load. This is not my experience. Maybe I don't run enough interactive bloatware to have a large enough interactive load for the scheduler to make a difference. Bruce From owner-cvs-src@FreeBSD.ORG Mon Oct 1 12:10:47 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6C58316A41B; Mon, 1 Oct 2007 12:10:47 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail06.syd.optusnet.com.au (mail06.syd.optusnet.com.au [211.29.132.187]) by mx1.freebsd.org (Postfix) with ESMTP id EED5313C4BF; Mon, 1 Oct 2007 12:10:46 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from besplex.bde.org (c220-239-235-248.carlnfd3.nsw.optusnet.com.au [220.239.235.248]) by mail06.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id l91CAamG022347 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 1 Oct 2007 22:10:43 +1000 Date: Mon, 1 Oct 2007 22:10:36 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: "Bjoern A. Zeeb" In-Reply-To: <20071001110057.V85753@maildrop.int.zabbadoz.net> Message-ID: <20071001212813.X2796@besplex.bde.org> References: <200709241339.l8ODd6k6059694@repoman.freebsd.org> <47002674.8050707@tomjudge.com> <47002E2F.3030306@tomjudge.com> <20071001090547.H85753@maildrop.int.zabbadoz.net> <20071001201359.M2557@besplex.bde.org> <20071001110057.V85753@maildrop.int.zabbadoz.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Bruce Evans Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 12:10:47 -0000 On Mon, 1 Oct 2007, Bjoern A. Zeeb wrote: > On Mon, 1 Oct 2007, Bruce Evans wrote: > >> On Mon, 1 Oct 2007, Bjoern A. Zeeb wrote: >>>> s/fis/fix/ >>> >>> yes it should. I closed the PR, See the comment there. >> >> s/fix/work around/ >> >> The bug is in newfs and tunefs permitting garbage parameters, so it cannot >> be fixed in ffs_alloc.c. > > No matter what iput the kernel gets and from where, it MUST NOT (or at > least SHOULD not;) panic unless explicitly request by KASSERT/panic/.. Not quite true. There are hundreds or thousands of sysctls that can be used to set critical parameters to garbage which will cause a panic. Bounds checking for sysctl parameters is almost completely absent, and this is sometimes useful for investigating the limits of useful parameters without rebuilding the kernel. Also, a division by zero trap is preferable to a panic since it is restartable. > So this commit fixes a DIV0 bug in the kernel. > > Of course you are right, that the values should be checked by the tools > that we have in the tree so that this problem would not occur. > We could even check if the values given make sense at all, but that still > is a different story to a kernel panic. You deleted the part where I said where the fix belongs in the kernel (next to related fixups). ffs does almost no runtime checking by design. It depends on fsck or mount-time fixups doing all the necessary checking and fixups, so that the main code can be simpler and faster. New code shouldn't do things differently. Bruce From owner-cvs-src@FreeBSD.ORG Mon Oct 1 14:53:03 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8B02416A41A; Mon, 1 Oct 2007 14:53:03 +0000 (UTC) (envelope-from SRS0=e7ebb3db3349f9294f350cd1f0e8c13e6ad8abaf=475=es.net=oberman@es.net) Received: from postal1.es.net (postal4.es.net [IPv6:2001:400:6000:1::66]) by mx1.freebsd.org (Postfix) with ESMTP id 109DC13C43E; Mon, 1 Oct 2007 14:53:01 +0000 (UTC) (envelope-from SRS0=e7ebb3db3349f9294f350cd1f0e8c13e6ad8abaf=475=es.net=oberman@es.net) Received: from ptavv.es.net (ptavv.es.net [198.128.4.29]) by postal4.es.net (Postal Node 4) with ESMTP (SSL) id GYB89059; Mon, 01 Oct 2007 07:52:59 -0700 Received: from ptavv.es.net (ptavv.es.net [127.0.0.1]) by ptavv.es.net (Tachyon Server) with ESMTP id EC9FC4500F; Mon, 1 Oct 2007 07:52:57 -0700 (PDT) To: Bruce Evans In-Reply-To: Your message of "Mon, 01 Oct 2007 21:26:39 +1000." <20071001205923.U2657@besplex.bde.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1191250377_25579P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Mon, 01 Oct 2007 07:52:57 -0700 From: "Kevin Oberman" Message-Id: <20071001145257.EC9FC4500F@ptavv.es.net> X-Sender-IP: 198.128.4.29 X-Sender-Domain: es.net X-Recipent: ; ; ; ; ; ; ; ; X-Sender: X-To_Name: Bruce Evans X-To_Domain: optusnet.com.au X-To: Bruce Evans X-To_Email: brde@optusnet.com.au X-To_Alias: brde Cc: src-committers@freebsd.org, cvs-src@freebsd.org, Jeff Roberson , Garance A Drosehn , Ben Kaduk , cvs-all@freebsd.org, Jeff Roberson Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 14:53:03 -0000 --==_Exmh_1191250377_25579P Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > Date: Mon, 1 Oct 2007 21:26:39 +1000 (EST) > From: Bruce Evans > > On Mon, 1 Oct 2007, Jeff Roberson wrote: > > > On Mon, 1 Oct 2007, Bruce Evans wrote: > > > >> On Sun, 30 Sep 2007, Jeff Roberson wrote: > >> > >>> On Sat, 29 Sep 2007, Kevin Oberman wrote: > >> > >>>> YMMV, but ULE seems to generally work better then 4BSD for interactive > >>>> uniprocessor systems. The preferred scheduler for uniprocessor servers > >>>> is less clear, but many test have shown ULE does better for those > >>>> systems in the majority of cases. > >>> > >>> I feel it's safe to say desktop behavior on UP is definitely superior. > >> > >> This is unsafe to say. > > > > Given that the overwhelming amount of feedback by qualified poeple, I think > > it's fair to say that ULE gives a more responsive system under load. > > This is not my experience. Maybe I don't run enough interactive bloatware > to have a large enough interactive load for the scheduler to make a > difference. That, or you don't run interactive on older systems with slow CPUs and limited memory. (This does NOT imply that ULE is going to help when experiencing heavy swapfile activity. I don't think anything helps that except more RAM.) The place it seem most evident to me is X responsiveness when the system (1GHz X 256MB PIII) is busy with large builds. Performance is terrible with 4BSD and only bad with ULE. Note that I am running Gnome (speaking of bloatware). The difference when running ULE is pretty dramatic. -- R. Kevin Oberman, Network Engineer Energy Sciences Network (ESnet) Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab) E-mail: oberman@es.net Phone: +1 510 486-8634 Key fingerprint:059B 2DDF 031C 9BA3 14A4 EADA 927D EBB3 987B 3751 --==_Exmh_1191250377_25579P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) Comment: Exmh version 2.5 06/03/2002 iD8DBQFHAQnJkn3rs5h7N1ERAhk4AKCHHT4trxVXK+hGymhy03BV8ZwplgCfRDXs V+lJ5AEGZKl0Nl1XwQd8Fhw= =UTNe -----END PGP SIGNATURE----- --==_Exmh_1191250377_25579P-- From owner-cvs-src@FreeBSD.ORG Mon Oct 1 18:07:30 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B1C9616A41A; Mon, 1 Oct 2007 18:07:30 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9AF5213C461; Mon, 1 Oct 2007 18:07:30 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l91I7UaQ015513; Mon, 1 Oct 2007 18:07:30 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l91I7UK8015512; Mon, 1 Oct 2007 18:07:30 GMT (envelope-from ru) Message-Id: <200710011807.l91I7UK8015512@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 1 Oct 2007 18:07:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/include Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 18:07:30 -0000 ru 2007-10-01 18:07:29 UTC FreeBSD src repository Modified files: include Makefile Log: Install the forgotten /usr/include/geom/multipath/ header. Approved by: re (kensmith) Revision Changes Path 1.276 +4 -2 src/include/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 1 18:08:11 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6BAE116A417; Mon, 1 Oct 2007 18:08:11 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5514C13C44B; Mon, 1 Oct 2007 18:08:11 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l91I8BnD015589; Mon, 1 Oct 2007 18:08:11 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l91I8BtJ015588; Mon, 1 Oct 2007 18:08:11 GMT (envelope-from ru) Message-Id: <200710011808.l91I8BtJ015588@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 1 Oct 2007 18:08:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/build/mk OptionalObsoleteFiles.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 18:08:11 -0000 ru 2007-10-01 18:08:11 UTC FreeBSD src repository Modified files: tools/build/mk OptionalObsoleteFiles.inc Log: MK_LIBTHR was misspelled. Approved by: re (kensmith) Revision Changes Path 1.10 +1 -1 src/tools/build/mk/OptionalObsoleteFiles.inc From owner-cvs-src@FreeBSD.ORG Mon Oct 1 18:09:43 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 194B116A419; Mon, 1 Oct 2007 18:09:43 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 01DEB13C4A6; Mon, 1 Oct 2007 18:09:43 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l91I9ggc015632; Mon, 1 Oct 2007 18:09:42 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l91I9gZi015631; Mon, 1 Oct 2007 18:09:42 GMT (envelope-from ru) Message-Id: <200710011809.l91I9gZi015631@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 1 Oct 2007 18:09:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/build/make_check Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 18:09:43 -0000 ru 2007-10-01 18:09:42 UTC FreeBSD src repository Modified files: tools/build/make_check Makefile Log: The shell_1_sh test was failing with "make -jX". Approved by: re (kensmith) Revision Changes Path 1.29 +1 -1 src/tools/build/make_check/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 1 18:11:44 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0806F16A419; Mon, 1 Oct 2007 18:11:44 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E60C413C45D; Mon, 1 Oct 2007 18:11:43 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l91IBhLi015955; Mon, 1 Oct 2007 18:11:43 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l91IBh8W015954; Mon, 1 Oct 2007 18:11:43 GMT (envelope-from ru) Message-Id: <200710011811.l91IBh8W015954@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 1 Oct 2007 18:11:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools make_libdeps.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 18:11:44 -0000 ru 2007-10-01 18:11:43 UTC FreeBSD src repository Modified files: tools make_libdeps.sh Log: - Add cddl/lib to the list of library directories. - Add /bin to PATH to suppress a harmless warning from a makefile that sets a variable using cat(1). Approved by: re (kensmith) Revision Changes Path 1.9 +2 -1 src/tools/make_libdeps.sh From owner-cvs-src@FreeBSD.ORG Mon Oct 1 18:15:12 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0E5F016A417; Mon, 1 Oct 2007 18:15:12 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0DF7B13C46A; Mon, 1 Oct 2007 18:15:12 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l91IFBMi016159; Mon, 1 Oct 2007 18:15:11 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l91IFBsn016158; Mon, 1 Oct 2007 18:15:11 GMT (envelope-from ru) Message-Id: <200710011815.l91IFBsn016158@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 1 Oct 2007 18:15:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc Makefile src/usr.sbin/bluetooth/bthidd Makefile src/usr.sbin/config Makefile src/usr.sbin/pmcstat Makefile src/share/mk bsd.libnames.mk bsd.prog.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 18:15:12 -0000 ru 2007-10-01 18:15:11 UTC FreeBSD src repository Modified files: lib/libc Makefile usr.sbin/bluetooth/bthidd Makefile usr.sbin/config Makefile usr.sbin/pmcstat Makefile share/mk bsd.libnames.mk bsd.prog.mk Log: Fixed "make checkdpadd" (missing library dependencies). Approved by: re (kensmith) Revision Changes Path 1.73 +1 -0 src/lib/libc/Makefile 1.105 +1 -5 src/share/mk/bsd.libnames.mk 1.150 +5 -1 src/share/mk/bsd.prog.mk 1.7 +1 -1 src/usr.sbin/bluetooth/bthidd/Makefile 1.38 +1 -1 src/usr.sbin/config/Makefile 1.5 +1 -1 src/usr.sbin/pmcstat/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 1 18:17:24 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8215816A46B; Mon, 1 Oct 2007 18:17:24 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 81A8113C469; Mon, 1 Oct 2007 18:17:24 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l91IHOGT016325; Mon, 1 Oct 2007 18:17:24 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l91IHOVm016324; Mon, 1 Oct 2007 18:17:24 GMT (envelope-from ru) Message-Id: <200710011817.l91IHOVm016324@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 1 Oct 2007 18:17:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/cddl/sbin/zfs Makefile src/cddl/sbin/zpool Makefile src/cddl/usr.bin/ztest Makefile src/cddl/usr.sbin/zdb Makefile src/libexec/atrun Makefile src/usr.sbin/cron/cron Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 18:17:24 -0000 ru 2007-10-01 18:17:24 UTC FreeBSD src repository Modified files: cddl/sbin/zfs Makefile cddl/sbin/zpool Makefile cddl/usr.bin/ztest Makefile cddl/usr.sbin/zdb Makefile libexec/atrun Makefile usr.sbin/cron/cron Makefile Log: Fixed static linkage (build with -DNO_SHARED). Approved by: re (kensmith) Revision Changes Path 1.3 +4 -2 src/cddl/sbin/zfs/Makefile 1.3 +4 -2 src/cddl/sbin/zpool/Makefile 1.4 +3 -2 src/cddl/usr.bin/ztest/Makefile 1.4 +3 -2 src/cddl/usr.sbin/zdb/Makefile 1.15 +1 -1 src/libexec/atrun/Makefile 1.17 +1 -1 src/usr.sbin/cron/cron/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 1 18:22:33 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A247D16A419; Mon, 1 Oct 2007 18:22:33 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A2D7A13C45A; Mon, 1 Oct 2007 18:22:33 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l91IMXPQ016818; Mon, 1 Oct 2007 18:22:33 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l91IMXou016817; Mon, 1 Oct 2007 18:22:33 GMT (envelope-from ru) Message-Id: <200710011822.l91IMXou016817@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 1 Oct 2007 18:22:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src Makefile.inc1 src/lib/libpthread Makefile src/sbin/ggate Makefile src/usr.bin Makefile src/usr.sbin Makefile src/usr.sbin/ngctl Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 18:22:33 -0000 ru 2007-10-01 18:22:32 UTC FreeBSD src repository Modified files: . Makefile.inc1 lib/libpthread Makefile sbin/ggate Makefile usr.bin Makefile usr.sbin Makefile usr.sbin/ngctl Makefile Log: Always install libpthread.* symlinks if at least one of the threading libraries is built. This simplifies the logic in makefiles that need to check if the pthreads support is present. It also fixes a bug where we would build a threading library that we shouldn't have built: for example, building with WITHOUT_LIBTHR and the default value of DEFAULT_THREADING_LIB (libthr) would mistakenly build the libthr library, but not install it. Approved by: re (kensmith) Revision Changes Path 1.585 +9 -1 src/Makefile.inc1 1.64 +3 -2 src/lib/libpthread/Makefile 1.8 +1 -2 src/sbin/ggate/Makefile 1.301 +1 -2 src/usr.bin/Makefile 1.373 +5 -14 src/usr.sbin/Makefile 1.20 +1 -2 src/usr.sbin/ngctl/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 1 18:23:25 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8E64716A417; Mon, 1 Oct 2007 18:23:25 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7735D13C43E; Mon, 1 Oct 2007 18:23:25 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l91INPTM016926; Mon, 1 Oct 2007 18:23:25 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l91INPHd016921; Mon, 1 Oct 2007 18:23:25 GMT (envelope-from ru) Message-Id: <200710011823.l91INPHd016921@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 1 Oct 2007 18:23:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/cddl/lib Makefile src/cddl/usr.bin Makefile src/cddl/usr.sbin Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 18:23:25 -0000 ru 2007-10-01 18:23:24 UTC FreeBSD src repository Modified files: cddl/lib Makefile cddl/usr.bin Makefile cddl/usr.sbin Makefile Log: Don't build bits that depend on the pthreads support if a system was configured without such support. Approved by: re (kensmith) Revision Changes Path 1.5 +2 -0 src/cddl/lib/Makefile 1.5 +2 -0 src/cddl/usr.bin/Makefile 1.5 +2 -0 src/cddl/usr.sbin/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 1 18:24:47 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0086516A41A; Mon, 1 Oct 2007 18:24:47 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DEC3113C4A8; Mon, 1 Oct 2007 18:24:46 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l91IOkUI016974; Mon, 1 Oct 2007 18:24:46 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l91IOkEO016973; Mon, 1 Oct 2007 18:24:46 GMT (envelope-from ru) Message-Id: <200710011824.l91IOkEO016973@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 1 Oct 2007 18:24:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src Makefile.inc1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 18:24:47 -0000 ru 2007-10-01 18:24:46 UTC FreeBSD src repository Modified files: . Makefile.inc1 Log: Revise the list of directories we manually create under ${WORLDTMP} and ${LIB32TMP}; some of them are no longer needed, and some were never needed. Approved by: re (kensmith) Revision Changes Path 1.586 +2 -5 src/Makefile.inc1 From owner-cvs-src@FreeBSD.ORG Mon Oct 1 18:29:56 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6C65E16A469; Mon, 1 Oct 2007 18:29:56 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 46E9213C481; Mon, 1 Oct 2007 18:29:56 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l91ITuqN017169; Mon, 1 Oct 2007 18:29:56 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l91ITuAl017168; Mon, 1 Oct 2007 18:29:56 GMT (envelope-from ru) Message-Id: <200710011829.l91ITuAl017168@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 1 Oct 2007 18:29:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libthr Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 18:29:56 -0000 ru 2007-10-01 18:29:55 UTC FreeBSD src repository Modified files: lib/libthr Makefile Log: Always install libpthread.* symlinks if at least one of the threading libraries is built. This simplifies the logic in makefiles that need to check if the pthreads support is present. It also fixes a bug where we would build a threading library that we shouldn't have built: for example, building with WITHOUT_LIBTHR and the default value of DEFAULT_THREADING_LIB (libthr) would mistakenly build the libthr library, but not install it. Approved by: re (kensmith) Revision Changes Path 1.27 +3 -2 src/lib/libthr/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 1 20:13:50 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 39EE316A418; Mon, 1 Oct 2007 20:13:50 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2676913C46E; Mon, 1 Oct 2007 20:13:50 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l91KDnUJ030334; Mon, 1 Oct 2007 20:13:49 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l91KDnuq030333; Mon, 1 Oct 2007 20:13:49 GMT (envelope-from jhb) Message-Id: <200710012013.l91KDnuq030333@repoman.freebsd.org> From: John Baldwin Date: Mon, 1 Oct 2007 20:13:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/compat/ia32 ia32_sysvec.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 20:13:50 -0000 jhb 2007-10-01 20:13:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/compat/ia32 ia32_sysvec.c Log: MFC: Allow the ia32 resource limits to be set via loader tunables. Revision Changes Path 1.20.2.2 +3 -0 src/sys/compat/ia32/ia32_sysvec.c From owner-cvs-src@FreeBSD.ORG Mon Oct 1 23:37:41 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 05DE616A419; Mon, 1 Oct 2007 23:37:41 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id EA0E613C43E; Mon, 1 Oct 2007 23:37:40 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l91Nbe5Y053500; Mon, 1 Oct 2007 23:37:40 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l91NbeXq053499; Mon, 1 Oct 2007 23:37:40 GMT (envelope-from mtm) Message-Id: <200710012337.l91NbeXq053499@repoman.freebsd.org> From: Mike Makonnen Date: Mon, 1 Oct 2007 23:37:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/etc/rc.d kerberos X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 23:37:41 -0000 mtm 2007-10-01 23:37:39 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) etc/rc.d kerberos Log: Partial MFC: rev. 1.6 o Use the --detach option to kdc(8) instead of using the shell background operator '&'. PR: conf/102722 Revision Changes Path 1.4.2.2 +1 -1 src/etc/rc.d/kerberos From owner-cvs-src@FreeBSD.ORG Tue Oct 2 00:36:06 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC39A16A418; Tue, 2 Oct 2007 00:36:06 +0000 (UTC) (envelope-from jeff@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id AC9A013C4A3; Tue, 2 Oct 2007 00:36:06 +0000 (UTC) (envelope-from jeff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l920a6qn057652; Tue, 2 Oct 2007 00:36:06 GMT (envelope-from jeff@repoman.freebsd.org) Received: (from jeff@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l920a61f057651; Tue, 2 Oct 2007 00:36:06 GMT (envelope-from jeff) Message-Id: <200710020036.l920a61f057651@repoman.freebsd.org> From: Jeff Roberson Date: Tue, 2 Oct 2007 00:36:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 00:36:06 -0000 jeff 2007-10-02 00:36:06 UTC FreeBSD src repository Modified files: sys/kern sched_ule.c Log: - Move the rebalancer back into hardclock to prevent potential softclock starvation caused by unbalanced interrupt loads. - Change the rebalancer to work on stathz ticks but retain randomization. - Simplify locking in tdq_idled() to use the tdq_lock_pair() rather than complex sequences of locks to avoid deadlock. Reported by: kris Approved by: re Revision Changes Path 1.211 +86 -55 src/sys/kern/sched_ule.c From owner-cvs-src@FreeBSD.ORG Tue Oct 2 01:22:15 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 54E3F16A46B; Tue, 2 Oct 2007 01:22:15 +0000 (UTC) (envelope-from kevlo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 4339D13C494; Tue, 2 Oct 2007 01:22:15 +0000 (UTC) (envelope-from kevlo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l921MFfK070164; Tue, 2 Oct 2007 01:22:15 GMT (envelope-from kevlo@repoman.freebsd.org) Received: (from kevlo@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l921MF84070163; Tue, 2 Oct 2007 01:22:15 GMT (envelope-from kevlo) Message-Id: <200710020122.l921MF84070163@repoman.freebsd.org> From: Kevin Lo Date: Tue, 2 Oct 2007 01:22:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/wpa/wpa_supplicant wpa_supplicant.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 01:22:15 -0000 kevlo 2007-10-02 01:22:14 UTC FreeBSD src repository Modified files: usr.sbin/wpa/wpa_supplicant wpa_supplicant.8 Log: Remove a -N flag. Reviewed by: sam Approved by: re (kensmith) Revision Changes Path 1.3 +0 -6 src/usr.sbin/wpa/wpa_supplicant/wpa_supplicant.8 From owner-cvs-src@FreeBSD.ORG Tue Oct 2 01:30:18 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C33D716A41A; Tue, 2 Oct 2007 01:30:18 +0000 (UTC) (envelope-from jeff@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B04A213C447; Tue, 2 Oct 2007 01:30:18 +0000 (UTC) (envelope-from jeff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l921UIn4070522; Tue, 2 Oct 2007 01:30:18 GMT (envelope-from jeff@repoman.freebsd.org) Received: (from jeff@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l921UIfM070521; Tue, 2 Oct 2007 01:30:18 GMT (envelope-from jeff) Message-Id: <200710020130.l921UIfM070521@repoman.freebsd.org> From: Jeff Roberson Date: Tue, 2 Oct 2007 01:30:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 01:30:18 -0000 jeff 2007-10-02 01:30:18 UTC FreeBSD src repository Modified files: sys/kern sched_ule.c Log: - Reassign the thread queue lock to newtd prior to switching. Assigning after the switch leads to a race where the outgoing thread still owns the local queue lock while another cpu may switch it in. This race is only possible on machines where cpu_switch can take significantly longer on different cpus which in practice means HTT machines with unfair thread scheduling algorithms. Found by: kris (of course) Approved by: re Revision Changes Path 1.212 +6 -4 src/sys/kern/sched_ule.c From owner-cvs-src@FreeBSD.ORG Tue Oct 2 01:35:04 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7562A16A419; Tue, 2 Oct 2007 01:35:04 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com [216.240.101.25]) by mx1.freebsd.org (Postfix) with ESMTP id 4CE3113C455; Tue, 2 Oct 2007 01:35:04 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from [192.168.1.103] (c-67-160-44-208.hsd1.wa.comcast.net [67.160.44.208]) (authenticated bits=0) by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id l921YrJd013143 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO); Mon, 1 Oct 2007 21:34:54 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Mon, 1 Oct 2007 18:37:36 -0700 (PDT) From: Jeff Roberson X-X-Sender: jroberson@10.0.0.1 To: Bruce Evans In-Reply-To: <20071001205923.U2657@besplex.bde.org> Message-ID: <20071001183337.J583@10.0.0.1> References: <20070930040318.094E345018@ptavv.es.net> <20070930153430.U583@10.0.0.1> <20071001172620.X1839@besplex.bde.org> <20071001020835.B583@10.0.0.1> <20071001205923.U2657@besplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@freebsd.org, Kevin Oberman , cvs-src@freebsd.org, Jeff Roberson , Garance A Drosehn , Ben Kaduk , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 01:35:04 -0000 On Mon, 1 Oct 2007, Bruce Evans wrote: > On Mon, 1 Oct 2007, Jeff Roberson wrote: > >> On Mon, 1 Oct 2007, Bruce Evans wrote: >> >>> On Sun, 30 Sep 2007, Jeff Roberson wrote: >>> >>>> On Sat, 29 Sep 2007, Kevin Oberman wrote: >>> >>>>> YMMV, but ULE seems to generally work better then 4BSD for interactive >>>>> uniprocessor systems. The preferred scheduler for uniprocessor servers >>>>> is less clear, but many test have shown ULE does better for those >>>>> systems in the majority of cases. >>>> >>>> I feel it's safe to say desktop behavior on UP is definitely superior. >>> >>> This is unsafe to say. >> >> Given that the overwhelming amount of feedback by qualified poeple, I think >> it's fair to say that ULE gives a more responsive system under load. > > This is not my experience. Maybe I don't run enough interactive bloatware > to have a large enough interactive load for the scheduler to make a > difference. Yes it's unfortunate but our users want to run multimedia applications, play games, and use graphical web browsers. If we could just convince them to only use xterms, play 'fortune', and use lynx we could solve a lot of these issues with less effort. Jeff > > Bruce > From owner-cvs-src@FreeBSD.ORG Tue Oct 2 05:27:01 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C507416A41B; Tue, 2 Oct 2007 05:27:01 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail07.syd.optusnet.com.au (mail07.syd.optusnet.com.au [211.29.132.188]) by mx1.freebsd.org (Postfix) with ESMTP id 3C29713C458; Tue, 2 Oct 2007 05:27:00 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from besplex.bde.org (c220-239-235-248.carlnfd3.nsw.optusnet.com.au [220.239.235.248]) by mail07.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id l925QhWg010271 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 2 Oct 2007 15:26:46 +1000 Date: Tue, 2 Oct 2007 15:26:43 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Kevin Oberman In-Reply-To: <20071001145257.EC9FC4500F@ptavv.es.net> Message-ID: <20071002133623.X40629@besplex.bde.org> References: <20071001145257.EC9FC4500F@ptavv.es.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-all@freebsd.org, src-committers@freebsd.org, cvs-src@freebsd.org, Jeff Roberson , Garance A Drosehn , Ben Kaduk , Bruce Evans , Jeff Roberson Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 05:27:01 -0000 On Mon, 1 Oct 2007, Kevin Oberman wrote: >> Date: Mon, 1 Oct 2007 21:26:39 +1000 (EST) >> From: Bruce Evans >> >> On Mon, 1 Oct 2007, Jeff Roberson wrote: >>> Given that the overwhelming amount of feedback by qualified poeple, I think >>> it's fair to say that ULE gives a more responsive system under load. >> >> This is not my experience. Maybe I don't run enough interactive bloatware >> to have a large enough interactive load for the scheduler to make a >> difference. > > That, or you don't run interactive on older systems with slow CPUs and > limited memory. (This does NOT imply that ULE is going to help when > experiencing heavy swapfile activity. I don't think anything helps > that except more RAM.) Not recently. I used a P5/133 which was new in 1996 as an X client until Y2K since it was fast enough to be an X client, but I stopped running builds in it in 1998. > The place it seem most evident to me is X responsiveness when the system > (1GHz X 256MB PIII) is busy with large builds. Performance is terrible > with 4BSD and only bad with ULE. Note that I am running Gnome (speaking > of bloatware). > > The difference when running ULE is pretty dramatic. Again, this is not my experience. I don't run gnome, but occasionally run X, and often run kernel builds and network benchmarks. A quick test now showed good interactivity for light browsing and editing at a load average of 32 generated by a pessimized makeworld (-j16) on both an A64 2.2GHz UP and a Celeron 366MHz UP. The light interactive use just doesn't need to run long enough for its priority to become as low (numerically high) as the build. Maybe heavy X use with streaming video is what you count as interactive. I count that as not very hard realtime. Further testing of my ~4BSD scheduler in ~5.2 indicates that when a process wants less than about 1/loadavg of the CPU on average, it usually just gets it, with no scheduling delays, since it usually has higher priority than all other user processes. Otherwise, the worst-case scheduling delays increase from ~10 msec to ~2 seconds. It is easy to reduce the scheduling quantum from its default of 100 msec by a factor of 100, but this doesn't seem to work right. So the behaviour is very dependent on the load and on the amount of CPU wanted by the interactive process. ... I now have more experience with ULE. A version built today gave dramatically worse interactivity, so much so that I think it must have been broken recently. A simple shell loop hangs the rest of the system in some cases, and a background build has similar bad effects, probably limited mainly by useful loops not being endless. First I tried an old regression test for nice[1-2]: %%% for i in 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 do nice -$i sh -c "while :; do echo -n;done" & done top -o time %%% This hung after starting only about one of the shell processes. After cutting the list down to just one process with nice -20, it still hung. Shells on other syscons terminals running at rtprio 0 could not compete with the nice -20 process: - they could not start top to look at what was happening - an already-running could not display anything new - they could not start killall. With the list cut down to about 6 processes, ps in ddb showed evidence of all the processes starting, and I was able to kill them all using kill in ddb. The above was with HZ = 100. After changing HZ to 1000, one nice -20 process could be started with no problems, but similar problems occur with a few more processes. With a nice list of "for i in 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20", one of the shells apparently runs for about a minute before its priority is reduced at all. During this time, the symptoms were the same as above. The shell that uses extra time initially is not usually the first one in the list. After starting all the shells, the behaviour was normal, including niceness having too little effect. On a later run, all the shells started in a couple of seconds (still slow) even with the full nice list restored. Running makeworld with just -j4 n the background gives similar symptoms. When a new process is started, it sometimes gets too many cycles to begin with, and apparently completely stops all processes in the makeworld (but not the top displaying things) for several seconds. After a while (I guess when the interactivity score descreases), this behaviour changes to giving the new process very few cycles even if it is semi-interactive (a foreground process started from a shell). In at least this phase, ^C to kill processes doesn't work, but ^Z to suspend them and then kill from the shell works normally, and interactivity in not-very-bloated mail programs and editors is very bad. A non-interactive utility to measure the scheduling delay reports a max delay of about 2 seconds for most runs, while with other schedulers and kernels it only reports 2 seconds occasionally even at much higher loads. Other behaviour with 4BSD schedulers and various kernels: - the max scheduling delay is almost independent of the CPU speed. - the max scheduling delay is slightly worse for -current with 4BSD than with my ~5.2. - -current has anomalous behaviour relative to ~5.2 for background makeworld -j16: many fewer runnable processes, a much smaller max load average, and many more zombies visible when top looks. - in ~5.2, removing the hack that puts threads back on the head of the queue instead of the tail significantly reduces the max scheduling delay. (This is a non-hack with related changes in -current, but I just used s/TAIL/HEAD/.) This hack reduced makeworld time significantly. I think removing it improves interactivity only by accident. Removing it restores the old bogus scheduler behaviour of rescheduling on every "slow" interrupt, which gives essentially roundrobin scheduling under loads that generate lots of interrupts. Interactivity is still poor because makeworld sometimes generates a few hundred processes per second and cycling through that many takes a long time even with a tiny quantum. - reducing kern.sched.quantum never had much effect. Same for increasing HZ in -current with 4BSD. Bruce From owner-cvs-src@FreeBSD.ORG Tue Oct 2 05:44:54 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A7E5F16A419; Tue, 2 Oct 2007 05:44:54 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8021313C458; Tue, 2 Oct 2007 05:44:54 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l925ispM099431; Tue, 2 Oct 2007 05:44:54 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l925isfl099430; Tue, 2 Oct 2007 05:44:54 GMT (envelope-from ru) Message-Id: <200710020544.l925isfl099430@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 2 Oct 2007 05:44:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sbin/adjkerntz adjkerntz.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 05:44:54 -0000 ru 2007-10-02 05:44:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sbin/adjkerntz adjkerntz.c Log: MFC: 1.32: If not compiled for debugging, redirect std{in,out,err} to /dev/null before becoming a daemon. Revision Changes Path 1.29.8.1 +7 -1 src/sbin/adjkerntz/adjkerntz.c From owner-cvs-src@FreeBSD.ORG Tue Oct 2 06:41:54 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC95A16A418; Tue, 2 Oct 2007 06:41:52 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com [216.240.101.25]) by mx1.freebsd.org (Postfix) with ESMTP id A9D9613C461; Tue, 2 Oct 2007 06:41:52 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from [192.168.1.103] (c-67-160-44-208.hsd1.wa.comcast.net [67.160.44.208]) (authenticated bits=0) by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id l926fZSV054770 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO); Tue, 2 Oct 2007 02:41:41 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Mon, 1 Oct 2007 23:44:25 -0700 (PDT) From: Jeff Roberson X-X-Sender: jroberson@10.0.0.1 To: Bruce Evans In-Reply-To: <20071002133623.X40629@besplex.bde.org> Message-ID: <20071001232743.Q539@10.0.0.1> References: <20071001145257.EC9FC4500F@ptavv.es.net> <20071002133623.X40629@besplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-all@FreeBSD.org, src-committers@FreeBSD.org, Kevin Oberman , cvs-src@FreeBSD.org, Jeff Roberson , Garance A Drosehn , Ben Kaduk Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 06:41:54 -0000 On Tue, 2 Oct 2007, Bruce Evans wrote: > On Mon, 1 Oct 2007, Kevin Oberman wrote: > >>> Date: Mon, 1 Oct 2007 21:26:39 +1000 (EST) >>> From: Bruce Evans >>> >>> On Mon, 1 Oct 2007, Jeff Roberson wrote: > >>>> Given that the overwhelming amount of feedback by qualified poeple, I >>>> think >>>> it's fair to say that ULE gives a more responsive system under load. >>> >>> This is not my experience. Maybe I don't run enough interactive bloatware >>> to have a large enough interactive load for the scheduler to make a >>> difference. >> >> That, or you don't run interactive on older systems with slow CPUs and >> limited memory. (This does NOT imply that ULE is going to help when >> experiencing heavy swapfile activity. I don't think anything helps >> that except more RAM.) > > Not recently. I used a P5/133 which was new in 1996 as an X client until > Y2K since it was fast enough to be an X client, but I stopped running > builds in it in 1998. > >> The place it seem most evident to me is X responsiveness when the system >> (1GHz X 256MB PIII) is busy with large builds. Performance is terrible >> with 4BSD and only bad with ULE. Note that I am running Gnome (speaking >> of bloatware). >> >> The difference when running ULE is pretty dramatic. > > Again, this is not my experience. I don't run gnome, but occasionally > run X, and often run kernel builds and network benchmarks. A quick > test now showed good interactivity for light browsing and editing at > a load average of 32 generated by a pessimized makeworld (-j16) on > both an A64 2.2GHz UP and a Celeron 366MHz UP. The light interactive > use just doesn't need to run long enough for its priority to become > as low (numerically high) as the build. > > Maybe heavy X use with streaming video is what you count as interactive. > I count that as not very hard realtime. > > Further testing of my ~4BSD scheduler in ~5.2 indicates that when a > process wants less than about 1/loadavg of the CPU on average, it > usually just gets it, with no scheduling delays, since it usually has > higher priority than all other user processes. Otherwise, the worst-case > scheduling delays increase from ~10 msec to ~2 seconds. It is easy > to reduce the scheduling quantum from its default of 100 msec by a > factor of 100, but this doesn't seem to work right. So the behaviour > is very dependent on the load and on the amount of CPU wanted by the > interactive process. > > ... > > I now have more experience with ULE. A version built today gave > dramatically worse interactivity, so much so that I think it must have > been broken recently. A simple shell loop hangs the rest of the system > in some cases, and a background build has similar bad effects, probably > limited mainly by useful loops not being endless. > I'm not able to reproduce this and no one else has reported it. This may be the result of some incompatibility between bdebsd and ULE. Is this a SMP machine? Do you have PREEMPTION enabled? ULE recently started honoring preemption. Try setting: kern.sched.preempt_thresh: 64 if it is not already. I know you deal with hardclock differently. Without PREEMPTION it may not work correctly. > First I tried an old regression test for nice[1-2]: > > %%% > for i in 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 > do > nice -$i sh -c "while :; do echo -n;done" & > done > top -o time > %%% I use this: for i in -20 -16 -12 -8 -4 0 4 8 12 16 20 do nice -$i sh -c "while :; do echo -n;done" & done top -o time I like to verify that the distribution doesn't get out of whack. It takes some time to settle before the higher nice threads get enough runtime to sort properly. My results are as so: 868 root 1 81 -20 3492K 1404K RUN 0:28 23.58% sh 869 root 1 83 -16 3492K 1404K RUN 0:20 15.09% sh 870 root 1 86 -12 3492K 1404K RUN 0:16 12.16% sh 871 root 1 90 -8 3492K 1404K RUN 0:12 8.89% sh 872 root 1 93 -4 3492K 1404K RUN 0:11 7.96% sh 873 root 1 97 0 3492K 1404K RUN 0:09 6.59% sh 874 root 1 101 4 3492K 1404K RUN 0:08 4.88% sh 875 root 1 105 8 3492K 1404K RUN 0:07 5.37% sh 876 root 1 109 12 3492K 1404K RUN 0:06 3.37% sh 877 root 1 113 16 3492K 1404K RUN 0:06 4.05% sh 878 root 1 116 20 3492K 1404K RUN 0:05 3.96% sh Really might not be enough difference with positive nice values. I've never really had a good feeling about how nice should really behave but this mostly seems reasonable. It would be possible to tweak the algorithm to further penalize nice. Jeff > > This hung after starting only about one of the shell processes. After > cutting the list down to just one process with nice -20, it still hung. > Shells on other syscons terminals running at rtprio 0 could not compete > with the nice -20 process: > - they could not start top to look at what was happening > - an already-running could not display anything new > - they could not start killall. > With the list cut down to about 6 processes, ps in ddb showed evidence of all > the processes starting, and I was able to kill them all using > kill in ddb. > > The above was with HZ = 100. After changing HZ to 1000, one nice -20 > process could be started with no problems, but similar problems occur > with a few more processes. With a nice list of > "for i in 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20", one of the > shells apparently runs for about a minute before its priority is > reduced at all. During this time, the symptoms were the same as above. > The shell that uses extra time initially is not usually the first > one in the list. After starting all the shells, the behaviour was > normal, including niceness having too little effect. > > On a later run, all the shells started in a couple of seconds (still > slow) even with the full nice list restored. > > Running makeworld with just -j4 n the background gives similar symptoms. > When a new process is started, it sometimes gets too many cycles to > begin with, and apparently completely stops all processes in the > makeworld (but not the top displaying things) for several seconds. > After a while (I guess when the interactivity score descreases), this > behaviour changes to giving the new process very few cycles even if > it is semi-interactive (a foreground process started from a shell). > In at least this phase, ^C to kill processes doesn't work, but ^Z to > suspend them and then kill from the shell works normally, and interactivity > in not-very-bloated mail programs and editors is very bad. A > non-interactive utility to measure the scheduling delay reports a max > delay of about 2 seconds for most runs, while with other schedulers > and kernels it only reports 2 seconds occasionally even at much higher > loads. > > Other behaviour with 4BSD schedulers and various kernels: > - the max scheduling delay is almost independent of the CPU speed. > - the max scheduling delay is slightly worse for -current with 4BSD > than with my ~5.2. > - -current has anomalous behaviour relative to ~5.2 for background > makeworld -j16: many fewer runnable processes, a much smaller max > load average, and many more zombies visible when top looks. > - in ~5.2, removing the hack that puts threads back on the head of > the queue instead of the tail significantly reduces the max > scheduling delay. (This is a non-hack with related changes in > -current, but I just used s/TAIL/HEAD/.) This hack reduced makeworld > time significantly. I think removing it improves interactivity > only by accident. Removing it restores the old bogus scheduler > behaviour of rescheduling on every "slow" interrupt, which gives > essentially roundrobin scheduling under loads that generate lots > of interrupts. Interactivity is still poor because makeworld > sometimes generates a few hundred processes per second and cycling > through that many takes a long time even with a tiny quantum. > > - reducing kern.sched.quantum never had much effect. Same for > increasing HZ in -current with 4BSD. > > Bruce > From owner-cvs-src@FreeBSD.ORG Tue Oct 2 06:54:40 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0E0CB16A46B; Tue, 2 Oct 2007 06:54:40 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com [216.240.101.25]) by mx1.freebsd.org (Postfix) with ESMTP id CDAD213C4AC; Tue, 2 Oct 2007 06:54:39 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from [192.168.1.103] (c-67-160-44-208.hsd1.wa.comcast.net [67.160.44.208]) (authenticated bits=0) by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id l926sUa5055729 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO); Tue, 2 Oct 2007 02:54:31 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Mon, 1 Oct 2007 23:57:20 -0700 (PDT) From: Jeff Roberson X-X-Sender: jroberson@10.0.0.1 To: Bruce Evans In-Reply-To: <20071001172620.X1839@besplex.bde.org> Message-ID: <20071001234448.A539@10.0.0.1> References: <20070930040318.094E345018@ptavv.es.net> <20070930153430.U583@10.0.0.1> <20071001172620.X1839@besplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-all@FreeBSD.org, src-committers@FreeBSD.org, Kevin Oberman , cvs-src@FreeBSD.org, Jeff Roberson , Garance A Drosehn , Ben Kaduk Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 06:54:40 -0000 On Mon, 1 Oct 2007, Bruce Evans wrote: > On Sun, 30 Sep 2007, Jeff Roberson wrote: > >> On Sat, 29 Sep 2007, Kevin Oberman wrote: > >>> YMMV, but ULE seems to generally work better then 4BSD for interactive >>> uniprocessor systems. The preferred scheduler for uniprocessor servers >>> is less clear, but many test have shown ULE does better for those >>> systems in the majority of cases. >> >> I feel it's safe to say desktop behavior on UP is definitely superior. > > This is unsafe to say. > >> I think there is no significant difference on UP between 4BSD and ULE > > This may be safe to say, but is inconsistent with the above. > >> except perhaps in context switching microbenchmarks where ULE falls behind. > > It is safe to say that interactive users cannot notice insignificant > differences. It takes a micro-benchmark to notice possibly-significant > differences of hundreds or even thousands of nanonseconds for context > switching. Well speaking of context switch microbenchmarks... I recently looked at lmbench but was disatisfied with the way it measures. Specifically, I want to see how context switch times scale as you add lots of threads that are running concurrently. The #procs argument to lat_ctx does not run these processes concurrently. They each are woken in turn as a token passes through a chain of pipes. I wrote a simple tool that does a given number of switches with a given number of processes. I then simply time to the total execution with 'time'. This avoids the overhead of pipes, sleep/wakeup, and other complexities. Instead, it uses sched_yield(). The tool is available at: http://people.freebsd.org/~jeff/yield.c and yield.sh is what I have been using to measure. I found that ule on UP was 10% slower than 4BSD at 1 and 10 concurrent threads and 5% slower at 100. It broke even at 1000 and was about 22% faster at 5,000. Then I wrote: http://people.freebsd.org/~jeff/ulefaster.diff This is indistinguishable from 4bsd at 1, 10, 100, and 1000 threads while being 24% faster at 5,000. The 5,000 case is anomolous. I think after 100 we must no longer fit in cache. At 5,000 the time to fork() and wait() actually shows up significantly. Here's output for 4BSD on UP: 5.69 real 1.17 user 4.48 sys 7.66 real 1.60 user 6.02 sys 8.37 real 1.90 user 6.43 sys 37.96 real 14.28 user 23.26 sys 68.50 real 14.16 user 45.20 sys And ULE with the above patch: 5.62 real 1.23 user 4.36 sys 7.73 real 1.97 user 5.74 sys 8.34 real 2.01 user 6.30 sys 38.00 real 13.60 user 24.20 sys 52.42 real 13.84 user 38.32 sys I did multiple runs but didn't average them. They always ended up in the same ballpark and the patch made such a significant change that I didn't bother to record and analyze multiple runs. On SMP ULE pays a price for the per-cpu run queue locks. How well does that pay off? Here's ULE on an 8 core opteron: 3.91 real 0.35 user 3.55 sys 1.70 real 0.44 user 6.63 sys 1.25 real 1.77 user 8.10 sys 4.49 real 14.46 user 21.43 sys 14.32 real 25.58 user 88.07 sys And 4BSD on the same: 39.38 real 0.59 user 38.77 sys 62.47 real 0.84 user 493.07 sys 66.42 real 12.23 user 517.77 sys 69.38 real 25.13 user 523.52 sys 131.33 real 33.33 user 930.52 sys The combination of reduced scheduler locking and improved cache affinity pays off at about 10x the switch throughput of 4BSD. The actual cost of the extra synchronization in ULE is about a 5% penalty as measured with smp.disabled = 1, however, I lost that data and am not interested in rebooting 3 more times to reclaim it. Cheers, Jeff > > ULE may give higher priority to interactive processes, but most loss of > interactivity is caused by blocking on I/O, and there is nothing nothing > a scheduler can do to speed up slow or overloaded devices. > > Bruce > From owner-cvs-src@FreeBSD.ORG Tue Oct 2 07:51:44 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5DC2916A421; Tue, 2 Oct 2007 07:51:44 +0000 (UTC) (envelope-from bushman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 4677913C447; Tue, 2 Oct 2007 07:51:44 +0000 (UTC) (envelope-from bushman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l927piER008765; Tue, 2 Oct 2007 07:51:44 GMT (envelope-from bushman@repoman.freebsd.org) Received: (from bushman@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l927piMm008764; Tue, 2 Oct 2007 07:51:44 GMT (envelope-from bushman) Message-Id: <200710020751.l927piMm008764@repoman.freebsd.org> From: Michael Bushkov Date: Tue, 2 Oct 2007 07:51:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/rc.d cached src/usr.sbin/cached Makefile agent.c agent.h cached.8 cached.c cached.conf.5 cachedcli.c cachedcli.h cachelib.c cachelib.h cacheplcs.c cacheplcs.h config.c config.h debug.c debug.h hashtable.h log.c log.h mp_rs_query.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 07:51:44 -0000 bushman 2007-10-02 07:51:44 UTC FreeBSD src repository Removed files: etc/rc.d cached usr.sbin/cached Makefile agent.c agent.h cached.8 cached.c cached.conf.5 cachedcli.c cachedcli.h cachelib.c cachelib.h cacheplcs.c cacheplcs.h config.c config.h debug.c debug.h hashtable.h log.c log.h mp_rs_query.c mp_rs_query.h mp_ws_query.c mp_ws_query.h parser.c parser.h protocol.c protocol.h query.c query.h singletons.c singletons.h usr.sbin/cached/agents Makefile.inc group.c group.h passwd.c passwd.h services.c services.h Log: Removing obsolete cached files after cached->nscd renaming. Approved by: re (kensmith), brooks (mentor) Revision Changes Path 1.4 +0 -32 src/etc/rc.d/cached (dead) 1.3 +0 -16 src/usr.sbin/cached/Makefile (dead) 1.2 +0 -127 src/usr.sbin/cached/agent.c (dead) 1.2 +0 -72 src/usr.sbin/cached/agent.h (dead) 1.2 +0 -3 src/usr.sbin/cached/agents/Makefile.inc (dead) 1.2 +0 -262 src/usr.sbin/cached/agents/group.c (dead) 1.2 +0 -32 src/usr.sbin/cached/agents/group.h (dead) 1.2 +0 -269 src/usr.sbin/cached/agents/passwd.c (dead) 1.2 +0 -32 src/usr.sbin/cached/agents/passwd.h (dead) 1.3 +0 -284 src/usr.sbin/cached/agents/services.c (dead) 1.2 +0 -32 src/usr.sbin/cached/agents/services.h (dead) 1.9 +0 -165 src/usr.sbin/cached/cached.8 (dead) 1.3 +0 -885 src/usr.sbin/cached/cached.c (dead) 1.5 +0 -148 src/usr.sbin/cached/cached.conf.5 (dead) 1.2 +0 -284 src/usr.sbin/cached/cachedcli.c (dead) 1.2 +0 -57 src/usr.sbin/cached/cachedcli.h (dead) 1.2 +0 -1234 src/usr.sbin/cached/cachelib.c (dead) 1.2 +0 -281 src/usr.sbin/cached/cachelib.h (dead) 1.2 +0 -590 src/usr.sbin/cached/cacheplcs.c (dead) 1.2 +0 -137 src/usr.sbin/cached/cacheplcs.h (dead) 1.2 +0 -588 src/usr.sbin/cached/config.c (dead) 1.2 +0 -156 src/usr.sbin/cached/config.h (dead) 1.2 +0 -149 src/usr.sbin/cached/debug.c (dead) 1.2 +0 -67 src/usr.sbin/cached/debug.h (dead) 1.2 +0 -218 src/usr.sbin/cached/hashtable.h (dead) 1.2 +0 -78 src/usr.sbin/cached/log.c (dead) 1.2 +0 -43 src/usr.sbin/cached/log.h (dead) 1.2 +0 -537 src/usr.sbin/cached/mp_rs_query.c (dead) 1.2 +0 -34 src/usr.sbin/cached/mp_rs_query.h (dead) 1.2 +0 -548 src/usr.sbin/cached/mp_ws_query.c (dead) 1.2 +0 -36 src/usr.sbin/cached/mp_ws_query.h (dead) 1.2 +0 -474 src/usr.sbin/cached/parser.c (dead) 1.2 +0 -35 src/usr.sbin/cached/parser.h (dead) 1.2 +0 -550 src/usr.sbin/cached/protocol.c (dead) 1.2 +0 -265 src/usr.sbin/cached/protocol.h (dead) 1.3 +0 -1280 src/usr.sbin/cached/query.c (dead) 1.2 +0 -110 src/usr.sbin/cached/query.h (dead) 1.2 +0 -36 src/usr.sbin/cached/singletons.c (dead) 1.2 +0 -47 src/usr.sbin/cached/singletons.h (dead) From owner-cvs-src@FreeBSD.ORG Tue Oct 2 08:14:21 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 700C016A417; Tue, 2 Oct 2007 08:14:21 +0000 (UTC) (envelope-from bushman@freebsd.org) Received: from mail.r61.net (mail.r61.net [195.208.245.249]) by mx1.freebsd.org (Postfix) with ESMTP id D2F8E13C447; Tue, 2 Oct 2007 08:14:20 +0000 (UTC) (envelope-from bushman@freebsd.org) Received: from [127.0.0.1] (shogun.cc.rsu.ru [195.208.252.84]) (authenticated bits=0) by mail.r61.net (8.14.1/8.14.1) with ESMTP id l927vnnO090089; Tue, 2 Oct 2007 11:57:54 +0400 (MSD) (envelope-from bushman@freebsd.org) Message-ID: <4701F9DE.7090503@freebsd.org> Date: Tue, 02 Oct 2007 11:57:18 +0400 From: Michael Bushkov User-Agent: Thunderbird 2.0.0.5 (Windows/20070716) MIME-Version: 1.0 To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= References: <200709271230.l8RCUCWN003489@repoman.freebsd.org> <861wckqj81.fsf@ds4.des.no> In-Reply-To: <861wckqj81.fsf@ds4.des.no> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/nscd/agents Makefile.inc group.c group.h passwd.c passwd.h services.c services.h src/usr.sbin/nscd Makefile agent.c agent.h cachelib.c cachelib.h cacheplcs.c cacheplcs.h config.c config.h debug.c hashtable.h log.c log.h mp_rs_query. ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 08:14:21 -0000 Hi, Thanks for pointing this out. Actually, I didn't do a forced commit right after the repocopy, but committed the changes to most number of repocopied files in commit from 2007/08/09. As not all files were mentioned there, I've made a forced commit later to follow the usual scheme. That forced commit noted all repocopied files. Sorry for the mess, anyway - I'll be more accurate next time. The renaming of cached->nscd is finished. All cached references are currently eliminated and old cached files are removed from the tree. Dag-Erling Smørgrav wrote: > Michael Bushkov writes: >> Log: >> Forced commit to note repocopy: >> >> The files were copied in order to rename cached to nscd. > > The repocopy was already noted on 2007/08/09: > > ---------------------------- > revision 1.3 > date: 2007/08/09 13:06:11; author: bushman; state: Exp; lines: +4 -4 > - Renaming repocopied cached to nscd > > Approved by: re (kensmith), brooks (mentor) > ---------------------------- > > However, cached is still in the tree and usr.sbin/Makefile still refers > to it. > > DES -- With best regards, Michael Bushkov Southern Federal University From owner-cvs-src@FreeBSD.ORG Tue Oct 2 08:17:29 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A0EA216A421; Tue, 2 Oct 2007 08:17:29 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 74CAD13C458; Tue, 2 Oct 2007 08:17:29 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l928HT9c011641; Tue, 2 Oct 2007 08:17:29 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l928HTT5011640; Tue, 2 Oct 2007 08:17:29 GMT (envelope-from ru) Message-Id: <200710020817.l928HTT5011640@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 2 Oct 2007 08:17:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/contrib/groff/tmac doc-common doc-syms groff_mdoc.man X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 08:17:29 -0000 ru 2007-10-02 08:17:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) contrib/groff/tmac doc-common doc-syms groff_mdoc.man Log: MFC: - New Darwin, FreeBSD, and NetBSD versions. - DragonFly support including the new .Dx macro. - New .St strings: -isoC-amd1, -isoC-tcor1, -isoC-tcor2, and -ieee1275-94. Revision Changes Path 1.68.2.3 +13 -0 src/contrib/groff/tmac/doc-common 1.48.2.2 +72 -0 src/contrib/groff/tmac/doc-syms 1.1.1.18.2.3 +23 -1 src/contrib/groff/tmac/groff_mdoc.man From owner-cvs-src@FreeBSD.ORG Tue Oct 2 08:38:34 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 913C816A417; Tue, 2 Oct 2007 08:38:34 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 64DD613C45B; Tue, 2 Oct 2007 08:38:34 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l928cYJx012868; Tue, 2 Oct 2007 08:38:34 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l928cYux012867; Tue, 2 Oct 2007 08:38:34 GMT (envelope-from ru) Message-Id: <200710020838.l928cYux012867@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 2 Oct 2007 08:38:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/gnu/usr.bin/groff/tmac mdoc.local X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 08:38:34 -0000 ru 2007-10-02 08:38:34 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) gnu/usr.bin/groff/tmac mdoc.local Log: MFC: Added FreeBSD/arm and FreeBSD 6.3. FreeBSD 5.5 and 7.0 are official. Revision Changes Path 1.48.2.10 +4 -2 src/gnu/usr.bin/groff/tmac/mdoc.local From owner-cvs-src@FreeBSD.ORG Tue Oct 2 11:52:11 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 14B9316A419; Tue, 2 Oct 2007 11:52:11 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 9263D13C465; Tue, 2 Oct 2007 11:52:10 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (p54A56234.dip.t-dialin.net [84.165.98.52]) by redbull.bpaserver.net (Postfix) with ESMTP id BD5DC2E2AC; Tue, 2 Oct 2007 13:51:55 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 5B1205B4800; Tue, 2 Oct 2007 13:51:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1191325887; bh=h/qqI0sppmPauX0YQ5jG8GmKKZTrvaW4h 5HGd8l6a78=; h=Message-ID:X-Priority:Date:From:To:Cc:Subject: References:In-Reply-To:MIME-Version:Content-Type: Content-Disposition:Content-Transfer-Encoding:User-Agent; b=bF5/eW sxRNYFTFkNk5X44fhgN32ilIZQug8IwNpI/uH8qzTcyYVGDBRNrhEYTR4QuWn901LzB oW+1BN7J7sfgxgnJ0ZbfLDvBE5frGt7MtHy4506qvTkxxdIoVPcPB9jNoWEiPS23DoQ JiAtBiszCuR3Ont5oxS20cnIwziWhzqhEW1AZdAPV+4O/SSIleftwZ4SZi9H1VIjXfS zoWhCHijGVsbgCT9GgRlhwbXlGIL/wvXmACYzg3Wj7kT20+JTbFVkIo/cpgCZ5DexnC WGH9hLQ/b9g1wNTu2FXUSi0aDiZ++8g7RJJZS9PRSjI2Dscs74fOWQcGdeY8VbJ2tO+ A== Received: (from www@localhost) by webmail.leidinger.net (8.14.1/8.13.8/Submit) id l92BpRrf043032; Tue, 2 Oct 2007 13:51:27 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Tue, 02 Oct 2007 13:51:27 +0200 Message-ID: <20071002135127.wls5pvpz2ocwck8g@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Tue, 02 Oct 2007 13:51:27 +0200 From: Alexander Leidinger To: Michael Bushkov References: <200709271230.l8RCUCWN003489@repoman.freebsd.org> <861wckqj81.fsf@ds4.des.no> <4701F9DE.7090503@freebsd.org> In-Reply-To: <4701F9DE.7090503@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.9, required 8, BAYES_00 -15.00, RDNS_DYNAMIC 0.10) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No Cc: Dag-Erling =?utf-8?b?U23Dg8K4cmdyYXY=?= , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.sbin/nscd/agents Makefile.inc group.c group.h passwd.c passwd.h services.c services.h src/usr.sbin/nscd Makefile agent.c agent.h cachelib.c cachelib.h cacheplcs.c cacheplcs.h config.c config.h debug.c hashtable.h log.c log.h mp_rs_query. ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 11:52:11 -0000 Quoting Michael Bushkov (from Tue, 02 Oct 2007 11:57:18 +0400): > The renaming of cached->nscd is finished. All cached references are > currently eliminated and old cached files are removed from the tree. What about the known bug with the caching of negative answers? Is it scheduled to get committed (if the fix is already written...)? Bye, Alexander. -- Seeing is believing. You wouldn't have seen it if you hadn't believed it. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 From owner-cvs-src@FreeBSD.ORG Tue Oct 2 13:50:10 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2CC9F16A41B; Tue, 2 Oct 2007 13:50:10 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail08.syd.optusnet.com.au (mail08.syd.optusnet.com.au [211.29.132.189]) by mx1.freebsd.org (Postfix) with ESMTP id 6A04613C458; Tue, 2 Oct 2007 13:50:09 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from c220-239-235-248.carlnfd3.nsw.optusnet.com.au (c220-239-235-248.carlnfd3.nsw.optusnet.com.au [220.239.235.248]) by mail08.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id l92DnY2b023467 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 2 Oct 2007 23:49:46 +1000 Date: Tue, 2 Oct 2007 23:49:34 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Jeff Roberson In-Reply-To: <20071001232743.Q539@10.0.0.1> Message-ID: <20071002213829.F12287@delplex.bde.org> References: <20071001145257.EC9FC4500F@ptavv.es.net> <20071002133623.X40629@besplex.bde.org> <20071001232743.Q539@10.0.0.1> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-all@freebsd.org, src-committers@freebsd.org, Kevin Oberman , cvs-src@freebsd.org, Jeff Roberson , Garance A Drosehn , Ben Kaduk , Bruce Evans Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 13:50:10 -0000 On Mon, 1 Oct 2007, Jeff Roberson wrote: > On Tue, 2 Oct 2007, Bruce Evans wrote: >> Further testing of my ~4BSD scheduler in ~5.2 indicates that when a >> process wants less than about 1/loadavg of the CPU on average, it >> usually just gets it, with no scheduling delays, since it usually has >> higher priority than all other user processes. Otherwise, the worst-case >> scheduling delays increase from ~10 msec to ~2 seconds. It is easy >> to reduce the scheduling quantum from its default of 100 msec by a >> factor of 100, but this doesn't seem to work right. So the behaviour >> is very dependent on the load and on the amount of CPU wanted by the >> interactive process. [Read the middle of this bloated mail, about debugging ULE, first.] This is only for my ~5.2 etc. with the queuing hacked backed out. I think real 5.2 and 4.x act similarly, except at least 4.x has a bad policy for priority inheritance on fork/exit which can cause the priority to grow exponentially in the number of descendants (except it is clamped to a maximum, so the growth is just nonlinear and breaks various things when the limit is reached. I tested a 4.10 kernel a bit today but didn't have enough 4.x utilities in my userland to see what it is doing. -current with 4BSD is much worse than this. I observed a worst-case scheduling delay of > 26 seconds. Mouse movements are jerky. -current with ULE, after debugging the configuration, is slightly worse than this. Mouse movements aren't jerky. But ULE seems to often mispredict when a process is interactive, and it sometimes gets into a state where one process (not an interactive one) is given 100% CPU for too long while many other processes are runnable. >> ... >> >> I now have more experience with ULE. A version built today gave >> dramatically worse interactivity, so much so that I think it must have >> been broken recently. A simple shell loop hangs the rest of the system >> in some cases, and a background build has similar bad effects, probably >> limited mainly by useful loops not being endless. > > I'm not able to reproduce this and no one else has reported it. This always happens with hz = 100. Reducing preempt_thresh to below about 50 mostly fixes the problem, and reducing the threshold to 0 fixes the problem a bit more. The shell loop processes still take too long to start up (often several seconds for just 20), but the second process starts within a second, instead of showing signs of taking forever to start up. Apparently, in the broken case, an IPI to stop the first process is never delivered. ^Z works to stop the whole process group, and then two %'s to usually result in proceeding to the next process. Having to use two %'s is strange but may be just a shell bug. -current with 4BSD also takes too long to start all the processes, while ~5.2 restarts them all apparently-instantly. In fact it starts them too fast and runs into the old exec resource shortage bug after 16 processes and 3 or 4 or the starts fail in exec. With hz = 1000 and ULE, the default preempt_thresh of 64 works but reducing it to 0 works better. Startup is still too slow. Apparently, there is a scaling bug for hz or extra interrupts for the larger hz help, and the default preempt_thresh is not best. I saw this behaviour for 2 different kernels: - SMP kernel (all this is running on an A64 UP in i386 mode) built on Aug 5. Timer interrupts were via the APIC. hz was set to 100 at boot time. stathz was always 100 and in perfect sync with hz. (Plain current with APIC timer interrupts gives a broken stathz of 13 when hz is 100, and stathz in bogus sync with hz.) - UP kernel built today. Timer interrupts were via the i8254 and the RTC. hz was set to 100 or 1000 at boot time. stathz was always 128. The different interrupt configuration and timing (except for increasing hz for ULE) made little difference. The SMP kernel got a bit further in the shell loop startup when hz = 100 but otherwise behaved similarly. > This may be > the result of some incompatibility between bdebsd and ULE. Nah, I don't use ULE in bdebsd (except all userland is bdebsd), and I don't touch schedulers in -current (I mainly touch filesystems and network drivers). Current kernels are remarkably compatible with old userlands. > Is this a SMP > machine? Do you have PREEMPTION enabled? ULE recently started honoring > preemption. Try setting: See above. Always PREEMPTION for UP, since without it problems like the above are almost to be expected. I think 5.2 has them. ~5.2 preempts a lot as a side effect of switching context for clock interrupt handlers and then (without the queueing hack) rescheduling on switching back. > kern.sched.preempt_thresh: 64 But this setting is part of the problem. > if it is not already. I know you deal with hardclock differently. Without > PREEMPTION it may not work correctly. No, the difference for hardclock is not in ULE kernels. >> First I tried an old regression test for nice[1-2]: >> >> %%% >> for i in 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 >> do >> nice -$i sh -c "while :; do echo -n;done" & >> done >> top -o time >> %%% > > I use this: > for i in -20 -16 -12 -8 -4 0 4 8 12 16 20 > do > nice -$i sh -c "while :; do echo -n;done" & > done > top -o time > > I like to verify that the distribution doesn't get out of whack. It takes Then non-multiple-of-4 entries in my list are almost useless. I mostly use the [0-20] list because it is in the first file in a test directory and doesn't have any negative values so it doesn't need privilege to run. > some time to settle before the higher nice threads get enough runtime to sort > properly. My results are as so: The settling time/inertia is both a bug and a feature. It's good to have inertia for long-running processes, but makeworld can start several hundred processes per second and finish many of them so there is nowhere near enough settling time for these processes so their behaviour is hard to predict. > 868 root 1 81 -20 3492K 1404K RUN 0:28 23.58% sh > 869 root 1 83 -16 3492K 1404K RUN 0:20 15.09% sh > 870 root 1 86 -12 3492K 1404K RUN 0:16 12.16% sh > 871 root 1 90 -8 3492K 1404K RUN 0:12 8.89% sh > 872 root 1 93 -4 3492K 1404K RUN 0:11 7.96% sh > 873 root 1 97 0 3492K 1404K RUN 0:09 6.59% sh > 874 root 1 101 4 3492K 1404K RUN 0:08 4.88% sh > 875 root 1 105 8 3492K 1404K RUN 0:07 5.37% sh > 876 root 1 109 12 3492K 1404K RUN 0:06 3.37% sh > 877 root 1 113 16 3492K 1404K RUN 0:06 4.05% sh > 878 root 1 116 20 3492K 1404K RUN 0:05 3.96% sh > > Really might not be enough difference with positive nice values. I've never > really had a good feeling about how nice should really behave but this mostly > seems reasonable. It would be possible to tweak the algorithm to further > penalize nice. I still use a table-driven algorithm with weights 2**(nice_value/4). This gives a dynamic range of a factor 1024. >> This hung after starting only about one of the shell processes. After >> cutting the list down to just one process with nice -20, it still hung. >> Shells on other syscons terminals running at rtprio 0 could not compete >> with the nice -20 process: >> - they could not start top to look at what was happening >> - an already-running could not display anything new >> - they could not start killall. >> With the list cut down to about 6 processes, ps in ddb showed evidence of >> all the processes starting, and I was able to kill them all using >> kill in ddb. Fixed using larger hz and/or smaller preempt_thresh; ddb wasn't necessary since ^Z worked (if hit it before ^C?) -- see above. >> [hz = 100 case not so bad] Other stange behaviour with preempt_thresh = 64, at least with hz = 100: start two identical CPU hogs, each with a runtime of 2.5 seconds, on separate consoles. Then one is given 100% of the CPU until it completes, and it is always the second one started that gets 100% CPU first. Thus the first one started takes about 5.0 seconds to complete and the second one started takes about 2.5 seconds to complete. >> Running makeworld with just -j4 n the background gives similar symptoms. >> When a new process is started, it sometimes gets too many cycles to >> begin with, and apparently completely stops all processes in the >> makeworld (but not the top displaying things) for several seconds. >> After a while (I guess when the interactivity score descreases), this >> behaviour changes to giving the new process very few cycles even if >> it is semi-interactive (a foreground process started from a shell). ~5.2 behaves similarly, but I think a little better. In ~5.2 (and maybe in all schedulers), the initial priority is just a function of the parent's priority (I use a simple function that might be slightly different from 5.2. I forget what it is). If neither the parent nor the child runs for long, then new processes tend to get almost all the CPU until they run for too long. When the children exit, the parent inherits some priority according to another simple function. ~5.2 works best here since it uses better functions than 5.2 does (much better than the exponential functions in 4.x), and it keeps track of history better than ULE can. I tested this mainly using: time /tmp/q1 & time /tmp/q1 & acroread *pdf # type ^q to exit acroread where /tmp/q1 measures latency by calling clock_gettime() in a loop and there are 12 pdf files of total size 4.75MB. acroread is sufficiently bloated and hoggish to have very bad behaviour here. The results when this is run on an xterm that has initially been idle for some time (or is in some more magic state for ULE interactivity?) at loadavg 20 are approximately: all: acroread starts fast for the first few runs (would be ~ 1 seconds with no load; this only increases by a second or two) /tmp/q1 runs for ~2.5 seconds self time and shows low max latency (would be ~ 200 usec with no load; this increases to ~10 msec; both high variance) ~5.2-4BSD: after a few runs, the parent priority becomes near the max so further runs take 5-10 seconds to start. 20 seconds at a load avg of 20 would be fairer, but the parent priority doesn't get as near the max as background hog's priorities. After a few runs, max latency is usually 100-500 msec and was once 2 seconds. Latency in mouse movements is not noticable current-4BSD: further runs don't take much longer to start. Apparently the parent doesn't inherit enough priority. (In 4.2 it inherited far too much.) After a few runs, max latency is usually 1-2 seconds and was once 27 seconds. The latency of 1-2 is often noticeable for mouse movements and even for echo in xterms. current-ULE: further runs sometimes take _much_ longer, a minute or so, and there is a high variance in the length. After a few runs, max latency is usually a few hundred msec larger than for ~5.2. Latency in mouse movements is not noticable >> In at least this phase, ^C to kill processes doesn't work, but ^Z to >> suspend them and then kill from the shell works normally, and interactivity >> in not-very-bloated mail programs and editors is very bad. A ^C fails only in the phase where hz is small, preempt_thresh is larger, and (?) the parent hasn't gained much priority and/or (negative?) interactivity. >> Other behaviour with 4BSD schedulers and various kernels: >> - the max scheduling delay is almost independent of the CPU speed. This may be because it is just a function of the priorities which are mainly a function of the algorithm. >> - the max scheduling delay is slightly worse for -current with 4BSD >> than with my ~5.2. Acually, it is much worse. >> - -current has anomalous behaviour relative to ~5.2 for background >> makeworld -j16: many fewer runnable processes, a much smaller max >> load average, and many more zombies visible when top looks. This may be related to the slow startup of the shell loops and caused by the priority inheritance for fork/exit. >> - [queue hack] >> ... >> essentially roundrobin scheduling under loads that generate lots >> of interrupts. Interactivity is still poor because makeworld >> sometimes generates a few hundred processes per second and cycling >> through that many takes a long time even with a tiny quantum. makeworld actually generates remarkably few interrupts when run on disk file systems (an average of only about 30 non-clock interrupts per second in my config). >> - reducing kern.sched.quantum never had much effect. Same for >> increasing HZ in -current with 4BSD. Bruce From owner-cvs-src@FreeBSD.ORG Tue Oct 2 14:48:49 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 404D116A417; Tue, 2 Oct 2007 14:48:49 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B8B4B13C45D; Tue, 2 Oct 2007 14:48:48 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l92EmmsO065064; Tue, 2 Oct 2007 14:48:48 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l92EmmEw065063; Tue, 2 Oct 2007 14:48:48 GMT (envelope-from pjd) Message-Id: <200710021448.l92EmmEw065063@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Tue, 2 Oct 2007 14:48:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_sx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 14:48:49 -0000 pjd 2007-10-02 14:48:48 UTC FreeBSD src repository Modified files: sys/kern kern_sx.c Log: Fix sx_try_slock(), so it only fails when there is an exclusive owner. Before that fix, it was possible for the function to fail if number of sharers changes between 'x = sx->sx_lock' step and atomic_cmpset_acq_ptr() call. This fixes ZFS problem when ZFS returns strange EIO errors under load. In ZFS there is a code that depends on the fact that sx_try_slock() can only fail if there is an exclusive owner. Discussed with: attilio Reviewed by: jhb Approved by: re (kensmith) Revision Changes Path 1.55 +12 -9 src/sys/kern/kern_sx.c From owner-cvs-src@FreeBSD.ORG Tue Oct 2 15:21:24 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 48D2416A418; Tue, 2 Oct 2007 15:21:24 +0000 (UTC) (envelope-from bushman@freebsd.org) Received: from mail.r61.net (mail.r61.net [195.208.245.249]) by mx1.freebsd.org (Postfix) with ESMTP id A171313C461; Tue, 2 Oct 2007 15:21:23 +0000 (UTC) (envelope-from bushman@freebsd.org) Received: from [127.0.0.1] ([195.161.235.42]) (authenticated bits=0) by mail.r61.net (8.14.1/8.14.1) with ESMTP id l92FL9fP078260; Tue, 2 Oct 2007 19:21:16 +0400 (MSD) (envelope-from bushman@freebsd.org) Message-ID: <470261C5.4090400@freebsd.org> Date: Tue, 02 Oct 2007 19:20:37 +0400 From: Michael Bushkov User-Agent: Thunderbird 2.0.0.5 (Windows/20070716) MIME-Version: 1.0 To: Alexander Leidinger References: <200709271230.l8RCUCWN003489@repoman.freebsd.org> <861wckqj81.fsf@ds4.des.no> <4701F9DE.7090503@freebsd.org> <20071002135127.wls5pvpz2ocwck8g@webmail.leidinger.net> In-Reply-To: <20071002135127.wls5pvpz2ocwck8g@webmail.leidinger.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: =?UTF-8?B?RGFnLUVybGluZyBTbcODwrhyZ3Jhdg==?= , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.sbin/nscd/agents Makefile.inc group.c group.h passwd.c passwd.h services.c services.h src/usr.sbin/nscd Makefile agent.c agent.h cachelib.c cachelib.h cacheplcs.c cacheplcs.h config.c config.h debug.c hashtable.h log.c log.h mp_rs_query. ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 15:21:24 -0000 Fix is in my perforce branch since the last summer, actually... Will send it to re@ asap. Alexander Leidinger wrote: > Quoting Michael Bushkov (from Tue, 02 Oct 2007 > 11:57:18 +0400): > >> The renaming of cached->nscd is finished. All cached references are >> currently eliminated and old cached files are removed from the tree. > > What about the known bug with the caching of negative answers? Is it > scheduled to get committed (if the fix is already written...)? > > Bye, > Alexander. > -- With best regards, Michael Bushkov Southern Federal University From owner-cvs-src@FreeBSD.ORG Tue Oct 2 15:26:57 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F290916A417; Tue, 2 Oct 2007 15:26:56 +0000 (UTC) (envelope-from kevlo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id BA60E13C447; Tue, 2 Oct 2007 15:26:56 +0000 (UTC) (envelope-from kevlo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l92FQusX068511; Tue, 2 Oct 2007 15:26:56 GMT (envelope-from kevlo@repoman.freebsd.org) Received: (from kevlo@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l92FQudd068510; Tue, 2 Oct 2007 15:26:56 GMT (envelope-from kevlo) Message-Id: <200710021526.l92FQudd068510@repoman.freebsd.org> From: Kevin Lo Date: Tue, 2 Oct 2007 15:26:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: CVSROOT exclude X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 15:26:57 -0000 kevlo 2007-10-02 15:26:56 UTC FreeBSD src repository Modified files: . exclude Log: Temporarily exclude contrib/wpa_supplicant from $FreeBSD$ tag checking while I do some commits. Revision Changes Path 1.144 +1 -0 CVSROOT/exclude From owner-cvs-src@FreeBSD.ORG Tue Oct 2 15:30:28 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4C1216A418; Tue, 2 Oct 2007 15:30:28 +0000 (UTC) (envelope-from kevlo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8D40E13C45B; Tue, 2 Oct 2007 15:30:28 +0000 (UTC) (envelope-from kevlo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l92FUSJl068662; Tue, 2 Oct 2007 15:30:28 GMT (envelope-from kevlo@repoman.freebsd.org) Received: (from kevlo@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l92FUS2D068661; Tue, 2 Oct 2007 15:30:28 GMT (envelope-from kevlo) Message-Id: <200710021530.l92FUS2D068661@repoman.freebsd.org> From: Kevin Lo Date: Tue, 2 Oct 2007 15:30:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/contrib/wpa_supplicant main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 15:30:28 -0000 kevlo 2007-10-02 15:30:28 UTC FreeBSD src repository Modified files: contrib/wpa_supplicant main.c Log: Fix usage example since we don't have wext driver. Reviewed by: sam Approved by: re (kensmith) Revision Changes Path 1.2 +67 -45 src/contrib/wpa_supplicant/main.c From owner-cvs-src@FreeBSD.ORG Tue Oct 2 15:32:03 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 12F4716A418; Tue, 2 Oct 2007 15:32:03 +0000 (UTC) (envelope-from kevlo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id CF4F313C478; Tue, 2 Oct 2007 15:32:02 +0000 (UTC) (envelope-from kevlo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l92FW2C5068892; Tue, 2 Oct 2007 15:32:02 GMT (envelope-from kevlo@repoman.freebsd.org) Received: (from kevlo@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l92FW2S6068891; Tue, 2 Oct 2007 15:32:02 GMT (envelope-from kevlo) Message-Id: <200710021532.l92FW2S6068891@repoman.freebsd.org> From: Kevin Lo Date: Tue, 2 Oct 2007 15:32:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: CVSROOT exclude X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 15:32:03 -0000 kevlo 2007-10-02 15:32:02 UTC FreeBSD src repository Modified files: . exclude Log: Remove wpa_supplicant; I'm finished with my commit. Revision Changes Path 1.145 +0 -1 CVSROOT/exclude From owner-cvs-src@FreeBSD.ORG Tue Oct 2 15:59:55 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0DB7916A475; Tue, 2 Oct 2007 15:59:55 +0000 (UTC) (envelope-from gallatin@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id D7C9F13C480; Tue, 2 Oct 2007 15:59:54 +0000 (UTC) (envelope-from gallatin@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l92Fxslc071086; Tue, 2 Oct 2007 15:59:54 GMT (envelope-from gallatin@repoman.freebsd.org) Received: (from gallatin@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l92Fxsb6071085; Tue, 2 Oct 2007 15:59:54 GMT (envelope-from gallatin) Message-Id: <200710021559.l92Fxsb6071085@repoman.freebsd.org> From: Andrew Gallatin Date: Tue, 2 Oct 2007 15:59:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/amd64/conf NOTES src/sys/i386/conf NOTES src/sys/conf files.amd64 files.i386 src/sys/dev/mxge eth_z8e.dat.gz.uu eth_z8e.h ethp_z8e.dat.gz.uu ethp_z8e.h if_mxge.c if_mxge_var.h mcp_gen_header.h mxge_eth_z8e.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 15:59:55 -0000 gallatin 2007-10-02 15:59:54 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/amd64/conf NOTES sys/i386/conf NOTES sys/conf files.amd64 files.i386 sys/dev/mxge if_mxge.c if_mxge_var.h mcp_gen_header.h mxge_lro.c mxge_mcp.h sys/modules/mxge/mxge_eth_z8e Makefile sys/modules/mxge/mxge_ethp_z8e Makefile Added files: (Branch: RELENG_6) sys/dev/mxge eth_z8e.h ethp_z8e.h mxge_eth_z8e.c mxge_ethp_z8e.c Removed files: (Branch: RELENG_6) sys/dev/mxge eth_z8e.dat.gz.uu ethp_z8e.dat.gz.uu Log: MFC: sync the mxge driver with HEAD, modulo some slight differences due to RELENG_6 limitations. (no TSO in RELENG_6, no VLAN tag insertion/removal due to vlan differences, etc). Revision Changes Path 1.36.2.13 +2 -0 src/sys/amd64/conf/NOTES 1.71.2.17 +5 -0 src/sys/conf/files.amd64 1.538.2.16 +5 -0 src/sys/conf/files.i386 1.6.2.2 +0 -1083 src/sys/dev/mxge/eth_z8e.dat.gz.uu (dead) 1.2.2.1 +12779 -0 src/sys/dev/mxge/eth_z8e.h (new) 1.6.2.2 +0 -1089 src/sys/dev/mxge/ethp_z8e.dat.gz.uu (dead) 1.2.2.1 +12863 -0 src/sys/dev/mxge/ethp_z8e.h (new) 1.33.2.2 +315 -55 src/sys/dev/mxge/if_mxge.c 1.13.2.2 +27 -7 src/sys/dev/mxge/if_mxge_var.h 1.1.2.2 +2 -6 src/sys/dev/mxge/mcp_gen_header.h 1.1.2.1 +47 -0 src/sys/dev/mxge/mxge_eth_z8e.c (new) 1.1.2.1 +47 -0 src/sys/dev/mxge/mxge_ethp_z8e.c (new) 1.1.2.2 +2 -6 src/sys/dev/mxge/mxge_lro.c 1.6.2.2 +93 -9 src/sys/dev/mxge/mxge_mcp.h 1.1202.2.15 +2 -0 src/sys/i386/conf/NOTES 1.2.2.2 +2 -8 src/sys/modules/mxge/mxge_eth_z8e/Makefile 1.2.2.2 +2 -8 src/sys/modules/mxge/mxge_ethp_z8e/Makefile From owner-cvs-src@FreeBSD.ORG Tue Oct 2 18:53:50 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6BECD16A54F; Tue, 2 Oct 2007 18:53:50 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id B2FD913C474; Tue, 2 Oct 2007 18:53:49 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 212557712-1834499 for multiple; Tue, 02 Oct 2007 14:53:43 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l92IrT8l013068; Tue, 2 Oct 2007 14:53:33 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Bruce Evans Date: Tue, 2 Oct 2007 14:43:38 -0400 User-Agent: KMail/1.9.6 References: <20071001145257.EC9FC4500F@ptavv.es.net> <20071001232743.Q539@10.0.0.1> <20071002213829.F12287@delplex.bde.org> In-Reply-To: <20071002213829.F12287@delplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200710021443.40264.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 02 Oct 2007 14:53:34 -0400 (EDT) X-Virus-Scanned: ClamAV version 0.88.3, clamav-milter version 0.88.3 on server.baldwin.cx X-Virus-Status: Clean Cc: src-committers@freebsd.org, Kevin Oberman , cvs-src@freebsd.org, Jeff Roberson , Garance A Drosehn , Ben Kaduk , cvs-all@freebsd.org, Jeff Roberson Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 18:53:50 -0000 On Tuesday 02 October 2007 09:49:34 am Bruce Evans wrote: > Apparently, there is a scaling bug for hz or extra interrupts for > the larger hz help, and the default preempt_thresh is not best. -current on i386 and amd64 does a very poor job of scaling stathz and profhz with hz, so this may explain problems at hz=100. I have an attempt to make stathz and profhz more sane while also trying to not always drive the lapic timer at hz * 2. I used to have a test program that would display all the frequencies for different 'hz' values but have misplaced it. :( --- //depot/vendor/freebsd/src/sys/amd64/amd64/local_apic.c 2007/09/11 22:57:37 +++ //depot/user/jhb/acpipci/amd64/amd64/local_apic.c 2007/09/24 17:24:13 @@ -72,8 +72,6 @@ CTASSERT(IPI_STOP < APIC_SPURIOUS_INT); #define LAPIC_TIMER_HZ_DIVIDER 2 -#define LAPIC_TIMER_STATHZ_DIVIDER 15 -#define LAPIC_TIMER_PROFHZ_DIVIDER 3 /* Magic IRQ values for the timer and syscalls. */ #define IRQ_TIMER (NUM_IO_INTS + 1) @@ -383,13 +381,24 @@ lapic_timer_divisor, value); /* - * We will drive the timer at a small multiple of hz and drive - * both of the other timers with similarly small but relatively - * prime divisors. + * We want to run stathz in the neighborhood of 128hz. We would + * like profhz to run as often as possible, so we let it run on + * each clock tick. We try to honor the requested 'hz' value as + * much as possible. + * + * If 'hz' is above 1500, then we just let the lapic timer + * (and profhz) run at hz. If 'hz' is below 1500 but above + * 750, then we let the lapic timer run at 2 * 'hz'. If 'hz' + * is below 750 then we let the lapic timer run at 4 * 'hz'. */ - lapic_timer_hz = hz * LAPIC_TIMER_HZ_DIVIDER; - stathz = lapic_timer_hz / LAPIC_TIMER_STATHZ_DIVIDER; - profhz = lapic_timer_hz / LAPIC_TIMER_PROFHZ_DIVIDER; + if (hz >= 1500) + lapic_timer_hz = hz; + else if (hz >= 750) + lapic_timer_hz = hz * 2; + else + lapic_timer_hz = hz * 4; + stathz = lapic_timer_hz / (lapic_timer_hz * 128); + profhz = lapic_timer_hz; lapic_timer_period = value / lapic_timer_hz; /* --- //depot/vendor/freebsd/src/sys/i386/i386/local_apic.c 2007/09/11 22:57:37 +++ //depot/user/jhb/acpipci/i386/i386/local_apic.c 2007/09/24 17:24:13 @@ -72,8 +72,6 @@ CTASSERT(IPI_STOP < APIC_SPURIOUS_INT); #define LAPIC_TIMER_HZ_DIVIDER 2 -#define LAPIC_TIMER_STATHZ_DIVIDER 15 -#define LAPIC_TIMER_PROFHZ_DIVIDER 3 /* Magic IRQ values for the timer and syscalls. */ #define IRQ_TIMER (NUM_IO_INTS + 1) @@ -385,13 +383,24 @@ lapic_timer_divisor, value); /* - * We will drive the timer at a small multiple of hz and drive - * both of the other timers with similarly small but relatively - * prime divisors. + * We want to run stathz in the neighborhood of 128hz. We would + * like profhz to run as often as possible, so we let it run on + * each clock tick. We try to honor the requested 'hz' value as + * much as possible. + * + * If 'hz' is above 1500, then we just let the lapic timer + * (and profhz) run at hz. If 'hz' is below 1500 but above + * 750, then we let the lapic timer run at 2 * 'hz'. If 'hz' + * is below 750 then we let the lapic timer run at 4 * 'hz'. */ - lapic_timer_hz = hz * LAPIC_TIMER_HZ_DIVIDER; - stathz = lapic_timer_hz / LAPIC_TIMER_STATHZ_DIVIDER; - profhz = lapic_timer_hz / LAPIC_TIMER_PROFHZ_DIVIDER; + if (hz >= 1500) + lapic_timer_hz = hz; + else if (hz >= 750) + lapic_timer_hz = hz * 2; + else + lapic_timer_hz = hz * 4; + stathz = lapic_timer_hz / (lapic_timer_hz * 128); + profhz = lapic_timer_hz; lapic_timer_period = value / lapic_timer_hz; /* -- John Baldwin From owner-cvs-src@FreeBSD.ORG Tue Oct 2 20:06:14 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B04BA16A418; Tue, 2 Oct 2007 20:06:14 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7A9C013C448; Tue, 2 Oct 2007 20:06:14 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l92K6En0004894; Tue, 2 Oct 2007 20:06:14 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l92K6EQG004893; Tue, 2 Oct 2007 20:06:14 GMT (envelope-from obrien) Message-Id: <200710022006.l92K6EQG004893@repoman.freebsd.org> From: "David E. O'Brien" Date: Tue, 2 Oct 2007 20:06:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/contrib/gcc opts.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 20:06:14 -0000 obrien 2007-10-02 20:06:14 UTC FreeBSD src repository Modified files: contrib/gcc opts.c Log: Do not imply -ftree-vrp with -O2 and above. One must implicitly specify '-ftree-vrp' if one wants it. Some bad code generation has been tracked to -ftree-vrp. jdk1{5,6} are notable examples. Approved by: re(kensmith) Revision Changes Path 1.4 +5 -2 src/contrib/gcc/opts.c From owner-cvs-src@FreeBSD.ORG Tue Oct 2 20:30:37 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7176516A41A for ; Tue, 2 Oct 2007 20:30:37 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id 2752F13C45D for ; Tue, 2 Oct 2007 20:30:37 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 75270 invoked from network); 2 Oct 2007 20:30:38 -0000 Received: from ppp-71-139-1-224.dsl.snfc21.pacbell.net (HELO ?10.0.5.18?) (nate-mail@71.139.1.224) by root.org with ESMTPA; 2 Oct 2007 20:30:38 -0000 Message-ID: <4702AA6C.60208@root.org> Date: Tue, 02 Oct 2007 13:30:36 -0700 From: Nate Lawson User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: "David E. O'Brien" , cvs-src@freebsd.org, src-committers@FreeBSD.org, cvs-all@freebsd.org References: <20071002200619.0CB0F16A555@hub.freebsd.org> In-Reply-To: <20071002200619.0CB0F16A555@hub.freebsd.org> X-Enigmail-Version: 0.95.3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Subject: Re: cvs commit: src/contrib/gcc opts.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 20:30:37 -0000 David E. O'Brien wrote: > obrien 2007-10-02 20:06:14 UTC > > FreeBSD src repository > > Modified files: > contrib/gcc opts.c > Log: > Do not imply -ftree-vrp with -O2 and above. One must implicitly specify > '-ftree-vrp' if one wants it. > Some bad code generation has been tracked to -ftree-vrp. jdk1{5,6} are > notable examples. > > Approved by: re(kensmith) Great! Maybe should add... Submitted by: se -- Nate From owner-cvs-src@FreeBSD.ORG Tue Oct 2 20:36:32 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6D6A516A418; Tue, 2 Oct 2007 20:36:32 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id 41A5413C457; Tue, 2 Oct 2007 20:36:31 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.1/8.14.1) with ESMTP id l92KaVTv052006; Tue, 2 Oct 2007 13:36:31 -0700 (PDT) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.1/8.14.1/Submit) id l92KaVGv052005; Tue, 2 Oct 2007 13:36:31 -0700 (PDT) (envelope-from obrien) Date: Tue, 2 Oct 2007 13:36:31 -0700 From: "David O'Brien" To: Nate Lawson Message-ID: <20071002203631.GA51547@dragon.NUXI.org> References: <20071002200619.0CB0F16A555@hub.freebsd.org> <4702AA6C.60208@root.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4702AA6C.60208@root.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/contrib/gcc opts.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 20:36:32 -0000 On Tue, Oct 02, 2007 at 01:30:36PM -0700, Nate Lawson wrote: > David E. O'Brien wrote: > > Modified files: > > contrib/gcc opts.c > > Log: > > Do not imply -ftree-vrp with -O2 and above. One must implicitly specify > > '-ftree-vrp' if one wants it. > > Some bad code generation has been tracked to -ftree-vrp. jdk1{5,6} are > > notable examples. > > Great! Maybe should add... > Submitted by: se I didn't get this from se. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Tue Oct 2 20:37:15 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 550E616A417; Tue, 2 Oct 2007 20:37:15 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com [216.240.101.25]) by mx1.freebsd.org (Postfix) with ESMTP id E5F4713C44B; Tue, 2 Oct 2007 20:37:14 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from [192.168.1.103] (c-67-160-44-208.hsd1.wa.comcast.net [67.160.44.208]) (authenticated bits=0) by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id l92Kaxj2069252 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO); Tue, 2 Oct 2007 16:37:00 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Tue, 2 Oct 2007 13:39:47 -0700 (PDT) From: Jeff Roberson X-X-Sender: jroberson@10.0.0.1 To: Bruce Evans In-Reply-To: <20071002213829.F12287@delplex.bde.org> Message-ID: <20071002133334.W594@10.0.0.1> References: <20071001145257.EC9FC4500F@ptavv.es.net> <20071002133623.X40629@besplex.bde.org> <20071001232743.Q539@10.0.0.1> <20071002213829.F12287@delplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-all@FreeBSD.org, src-committers@FreeBSD.org, Kevin Oberman , cvs-src@FreeBSD.org, Jeff Roberson , Garance A Drosehn , Ben Kaduk Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 20:37:15 -0000 On Tue, 2 Oct 2007, Bruce Evans wrote: > On Mon, 1 Oct 2007, Jeff Roberson wrote: > >> On Tue, 2 Oct 2007, Bruce Evans wrote: > >>> Further testing of my ~4BSD scheduler in ~5.2 indicates that when a >>> process wants less than about 1/loadavg of the CPU on average, it >>> usually just gets it, with no scheduling delays, since it usually has >>> higher priority than all other user processes. Otherwise, the worst-case >>> scheduling delays increase from ~10 msec to ~2 seconds. It is easy >>> to reduce the scheduling quantum from its default of 100 msec by a >>> factor of 100, but this doesn't seem to work right. So the behaviour >>> is very dependent on the load and on the amount of CPU wanted by the >>> interactive process. > > [Read the middle of this bloated mail, about debugging ULE, first.] > > This is only for my ~5.2 etc. with the queuing hacked backed out. I > think real 5.2 and 4.x act similarly, except at least 4.x has a bad > policy for priority inheritance on fork/exit which can cause the > priority to grow exponentially in the number of descendants (except > it is clamped to a maximum, so the growth is just nonlinear and breaks > various things when the limit is reached. I tested a 4.10 kernel a bit > today but didn't have enough 4.x utilities in my userland to see what > it is doing. > > -current with 4BSD is much worse than this. I observed a worst-case > scheduling delay of > 26 seconds. Mouse movements are jerky. > > -current with ULE, after debugging the configuration, is slightly worse > than this. Mouse movements aren't jerky. But ULE seems to often > mispredict when a process is interactive, and it sometimes gets into > a state where one process (not an interactive one) is given 100% CPU > for too long while many other processes are runnable. Bruce, Sorry I don't have time for a point by point on this one. Thank you for your interesting analysis. From this I'm taking away a couple of things: 1) I've noticed that ULE relied on PREEMPTION for a long time and lost the NEEDRESCHED setting in cases where it doesn't set owepreempt. Restoring this should improve some of the !PREEMPTION behavior and perhaps even responsiveness in your nice tests. 2) I need to try running with hz = 100 and see if there are some scaling problems. I have heard reports that ULE scales better than 4BSD up to higher hz values but I haven't investigated this much. It should work with lower as well. Everything important to relative priorites and time slice allotment runs off of stathz. 3) The code which adjusts priorities for fork may need some more fine tuning. ULE agressively penalizes parents for forking expensive children. This helps us learn that make should not create interactive children for example. 4) I don't think you're losing interrupts when you ctrl+c. It's just taking too long for the interrupted task to run. ctrl+z takes effect immediately when the signal is delivered. This may be related to hz = 100 or running without preemption. I am not able to reproduce this problem with a standard GENERIC kernel + ULE. I will look into these issues soon. Thanks, Jeff > >>> ... >>> >>> I now have more experience with ULE. A version built today gave >>> dramatically worse interactivity, so much so that I think it must have >>> been broken recently. A simple shell loop hangs the rest of the system >>> in some cases, and a background build has similar bad effects, probably >>> limited mainly by useful loops not being endless. >> >> I'm not able to reproduce this and no one else has reported it. > > This always happens with hz = 100. Reducing preempt_thresh to below > about 50 mostly fixes the problem, and reducing the threshold to 0 > fixes the problem a bit more. The shell loop processes still take too > long to start up (often several seconds for just 20), but the second > process starts within a second, instead of showing signs of taking > forever to start up. Apparently, in the broken case, an IPI to stop > the first process is never delivered. ^Z works to stop the whole > process group, and then two %'s to usually result in proceeding to > the next process. Having to use two %'s is strange but may be just > a shell bug. > > -current with 4BSD also takes too long to start all the processes, > while ~5.2 restarts them all apparently-instantly. In fact it starts > them too fast and runs into the old exec resource shortage bug after > 16 processes and 3 or 4 or the starts fail in exec. > > With hz = 1000 and ULE, the default preempt_thresh of 64 works but > reducing it to 0 works better. Startup is still too slow. > > Apparently, there is a scaling bug for hz or extra interrupts for > the larger hz help, and the default preempt_thresh is not best. > > I saw this behaviour for 2 different kernels: > - SMP kernel (all this is running on an A64 UP in i386 mode) built on > Aug 5. Timer interrupts were via the APIC. hz was set to 100 at > boot time. stathz was always 100 and in perfect sync with hz. > (Plain current with APIC timer interrupts gives a broken stathz of > 13 when hz is 100, and stathz in bogus sync with hz.) > - UP kernel built today. Timer interrupts were via the i8254 and the > RTC. hz was set to 100 or 1000 at boot time. stathz was always > 128. The different interrupt configuration and timing (except for > increasing hz for ULE) made little difference. > > The SMP kernel got a bit further in the shell loop startup when hz = 100 > but otherwise behaved similarly. > >> This may be the result of some incompatibility between bdebsd and ULE. > > Nah, I don't use ULE in bdebsd (except all userland is bdebsd), and > I don't touch schedulers in -current (I mainly touch filesystems and > network drivers). Current kernels are remarkably compatible with > old userlands. > >> Is this a SMP machine? Do you have PREEMPTION enabled? ULE recently >> started honoring preemption. Try setting: > > See above. Always PREEMPTION for UP, since without it problems like the > above are almost to be expected. I think 5.2 has them. ~5.2 preempts > a lot as a side effect of switching context for clock interrupt handlers > and then (without the queueing hack) rescheduling on switching back. > >> kern.sched.preempt_thresh: 64 > > But this setting is part of the problem. > >> if it is not already. I know you deal with hardclock differently. Without >> PREEMPTION it may not work correctly. > > No, the difference for hardclock is not in ULE kernels. > >>> First I tried an old regression test for nice[1-2]: >>> >>> %%% >>> for i in 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 >>> do >>> nice -$i sh -c "while :; do echo -n;done" & >>> done >>> top -o time >>> %%% >> >> I use this: >> for i in -20 -16 -12 -8 -4 0 4 8 12 16 20 >> do >> nice -$i sh -c "while :; do echo -n;done" & >> done >> top -o time >> >> I like to verify that the distribution doesn't get out of whack. It takes > > Then non-multiple-of-4 entries in my list are almost useless. I mostly > use the [0-20] list because it is in the first file in a test directory > and doesn't have any negative values so it doesn't need privilege to run. > >> some time to settle before the higher nice threads get enough runtime to >> sort properly. My results are as so: > > The settling time/inertia is both a bug and a feature. It's good to have > inertia for long-running processes, but makeworld can start several hundred > processes per second and finish many of them so there is nowhere near > enough settling time for these processes so their behaviour is hard to > predict. > >> 868 root 1 81 -20 3492K 1404K RUN 0:28 23.58% sh >> 869 root 1 83 -16 3492K 1404K RUN 0:20 15.09% sh >> 870 root 1 86 -12 3492K 1404K RUN 0:16 12.16% sh >> 871 root 1 90 -8 3492K 1404K RUN 0:12 8.89% sh >> 872 root 1 93 -4 3492K 1404K RUN 0:11 7.96% sh >> 873 root 1 97 0 3492K 1404K RUN 0:09 6.59% sh >> 874 root 1 101 4 3492K 1404K RUN 0:08 4.88% sh >> 875 root 1 105 8 3492K 1404K RUN 0:07 5.37% sh >> 876 root 1 109 12 3492K 1404K RUN 0:06 3.37% sh >> 877 root 1 113 16 3492K 1404K RUN 0:06 4.05% sh >> 878 root 1 116 20 3492K 1404K RUN 0:05 3.96% sh >> >> Really might not be enough difference with positive nice values. I've >> never really had a good feeling about how nice should really behave but >> this mostly seems reasonable. It would be possible to tweak the algorithm >> to further penalize nice. > > I still use a table-driven algorithm with weights 2**(nice_value/4). This > gives a dynamic range of a factor 1024. > >>> This hung after starting only about one of the shell processes. After >>> cutting the list down to just one process with nice -20, it still hung. >>> Shells on other syscons terminals running at rtprio 0 could not compete >>> with the nice -20 process: >>> - they could not start top to look at what was happening >>> - an already-running could not display anything new >>> - they could not start killall. >>> With the list cut down to about 6 processes, ps in ddb showed evidence of >>> all the processes starting, and I was able to kill them all using >>> kill in ddb. > > Fixed using larger hz and/or smaller preempt_thresh; ddb wasn't necessary > since ^Z worked (if hit it before ^C?) -- see above. > >>> [hz = 100 case not so bad] > > Other stange behaviour with preempt_thresh = 64, at least with hz = 100: > start two identical CPU hogs, each with a runtime of 2.5 seconds, on > separate consoles. Then one is given 100% of the CPU until it completes, > and it is always the second one started that gets 100% CPU first. Thus > the first one started takes about 5.0 seconds to complete and the second > one started takes about 2.5 seconds to complete. > >>> Running makeworld with just -j4 n the background gives similar symptoms. >>> When a new process is started, it sometimes gets too many cycles to >>> begin with, and apparently completely stops all processes in the >>> makeworld (but not the top displaying things) for several seconds. >>> After a while (I guess when the interactivity score descreases), this >>> behaviour changes to giving the new process very few cycles even if >>> it is semi-interactive (a foreground process started from a shell). > > ~5.2 behaves similarly, but I think a little better. In ~5.2 (and > maybe in all schedulers), the initial priority is just a function of > the parent's priority (I use a simple function that might be slightly > different from 5.2. I forget what it is). If neither the parent nor > the child runs for long, then new processes tend to get almost all the > CPU until they run for too long. When the children exit, the parent > inherits some priority according to another simple function. ~5.2 > works best here since it uses better functions than 5.2 does (much > better than the exponential functions in 4.x), and it keeps track of > history better than ULE can. > > I tested this mainly using: > > time /tmp/q1 & time /tmp/q1 & acroread *pdf # type ^q to exit > acroread > > where /tmp/q1 measures latency by calling clock_gettime() in a loop and > there are 12 pdf files of total size 4.75MB. acroread is sufficiently > bloated and hoggish to have very bad behaviour here. The results when > this is run on an xterm that has initially been idle for some time (or > is in some more magic state for ULE interactivity?) at loadavg 20 are > approximately: > > all: acroread starts fast for the first few runs (would be ~ 1 > seconds with no load; this only increases by a second or two) > > /tmp/q1 runs for ~2.5 seconds self time and shows low max > latency (would be ~ 200 usec with no load; this increases to > ~10 msec; both high variance) > ~5.2-4BSD: after a few runs, the parent priority becomes near the > max so further runs take 5-10 seconds to start. 20 seconds at > a load avg of 20 would be fairer, but the parent priority > doesn't get as near the max as background hog's priorities. > > After a few runs, max latency is usually 100-500 msec and was > once 2 seconds. > > Latency in mouse movements is not noticable > current-4BSD: further runs don't take much longer to start. > Apparently the parent doesn't inherit enough priority. > (In 4.2 it inherited far too much.) > > After a few runs, max latency is usually 1-2 seconds and was > once 27 seconds. > > The latency of 1-2 is often noticeable for mouse movements and > even for echo in xterms. > current-ULE: further runs sometimes take _much_ longer, a minute > or so, and there is a high variance in the length. > > After a few runs, max latency is usually a few hundred msec > larger than for ~5.2. > > Latency in mouse movements is not noticable > > >>> In at least this phase, ^C to kill processes doesn't work, but ^Z to >>> suspend them and then kill from the shell works normally, and >>> interactivity >>> in not-very-bloated mail programs and editors is very bad. A > > ^C fails only in the phase where hz is small, preempt_thresh is larger, > and (?) the parent hasn't gained much priority and/or (negative?) > interactivity. > >>> Other behaviour with 4BSD schedulers and various kernels: >>> - the max scheduling delay is almost independent of the CPU speed. > > This may be because it is just a function of the priorities which are > mainly a function of the algorithm. > >>> - the max scheduling delay is slightly worse for -current with 4BSD >>> than with my ~5.2. > > Acually, it is much worse. > >>> - -current has anomalous behaviour relative to ~5.2 for background >>> makeworld -j16: many fewer runnable processes, a much smaller max >>> load average, and many more zombies visible when top looks. > > This may be related to the slow startup of the shell loops and caused by > the priority inheritance for fork/exit. > >>> - [queue hack] >>> ... >>> essentially roundrobin scheduling under loads that generate lots >>> of interrupts. Interactivity is still poor because makeworld >>> sometimes generates a few hundred processes per second and cycling >>> through that many takes a long time even with a tiny quantum. > > makeworld actually generates remarkably few interrupts when run on > disk file systems (an average of only about 30 non-clock interrupts per > second in my config). > >>> - reducing kern.sched.quantum never had much effect. Same for >>> increasing HZ in -current with 4BSD. > > Bruce > From owner-cvs-src@FreeBSD.ORG Tue Oct 2 21:44:23 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 50FB816A419; Tue, 2 Oct 2007 21:44:23 +0000 (UTC) (envelope-from glewis@eyesbeyond.com) Received: from misty.eyesbeyond.com (gerbercreations.com [71.39.140.16]) by mx1.freebsd.org (Postfix) with ESMTP id 1333013C474; Tue, 2 Oct 2007 21:44:22 +0000 (UTC) (envelope-from glewis@eyesbeyond.com) Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1]) by misty.eyesbeyond.com (8.13.1/8.13.3) with ESMTP id l92LY7Ku048993; Tue, 2 Oct 2007 14:34:07 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) Received: (from glewis@localhost) by misty.eyesbeyond.com (8.13.1/8.13.3/Submit) id l92LY6eU048992; Tue, 2 Oct 2007 14:34:06 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) X-Authentication-Warning: misty.eyesbeyond.com: glewis set sender to glewis@eyesbeyond.com using -f Date: Tue, 2 Oct 2007 14:34:06 -0700 From: Greg Lewis To: "David E. O'Brien" Message-ID: <20071002213406.GA48893@misty.eyesbeyond.com> References: <200710022006.l92K6EQG004893@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200710022006.l92K6EQG004893@repoman.freebsd.org> User-Agent: Mutt/1.4.2.2i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/contrib/gcc opts.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 21:44:23 -0000 On Tue, Oct 02, 2007 at 08:06:14PM +0000, David E. O'Brien wrote: > obrien 2007-10-02 20:06:14 UTC > > FreeBSD src repository > > Modified files: > contrib/gcc opts.c > Log: > Do not imply -ftree-vrp with -O2 and above. One must implicitly specify > '-ftree-vrp' if one wants it. > Some bad code generation has been tracked to -ftree-vrp. jdk1{5,6} are > notable examples. Thanks David! -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Tue Oct 2 21:53:04 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 146A516A468; Tue, 2 Oct 2007 21:53:04 +0000 (UTC) (envelope-from scf@FreeBSD.org) Received: from mail.farley.org (farley.org [67.64.95.201]) by mx1.freebsd.org (Postfix) with ESMTP id B2BBB13C4A7; Tue, 2 Oct 2007 21:53:03 +0000 (UTC) (envelope-from scf@FreeBSD.org) Received: from thor.farley.org (thor.farley.org [192.168.1.5]) by mail.farley.org (8.14.1/8.14.1) with ESMTP id l92LqWcI027828; Tue, 2 Oct 2007 16:52:32 -0500 (CDT) (envelope-from scf@FreeBSD.org) Date: Tue, 2 Oct 2007 16:52:32 -0500 (CDT) From: "Sean C. Farley" To: "David E. O'Brien" In-Reply-To: <200710022006.l92K6EQG004893@repoman.freebsd.org> Message-ID: References: <200710022006.l92K6EQG004893@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=unavailable version=3.2.3 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on mail.farley.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/gcc opts.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 21:53:04 -0000 On Tue, 2 Oct 2007, David E. O'Brien wrote: > obrien 2007-10-02 20:06:14 UTC > > FreeBSD src repository > > Modified files: > contrib/gcc opts.c > Log: > Do not imply -ftree-vrp with -O2 and above. One must implicitly specify > '-ftree-vrp' if one wants it. > Some bad code generation has been tracked to -ftree-vrp. jdk1{5,6} are > notable examples. I hope you meant explicitly. :) Thank you for the patch. Sean -- scf@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Tue Oct 2 21:54:26 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7194716A418; Tue, 2 Oct 2007 21:54:26 +0000 (UTC) (envelope-from scf@FreeBSD.org) Received: from mail.farley.org (farley.org [67.64.95.201]) by mx1.freebsd.org (Postfix) with ESMTP id 1C9FC13C447; Tue, 2 Oct 2007 21:54:25 +0000 (UTC) (envelope-from scf@FreeBSD.org) Received: from thor.farley.org (thor.farley.org [192.168.1.5]) by mail.farley.org (8.14.1/8.14.1) with ESMTP id l92LpHBL027802; Tue, 2 Oct 2007 16:51:17 -0500 (CDT) (envelope-from scf@FreeBSD.org) Date: Tue, 2 Oct 2007 16:51:17 -0500 (CDT) From: "Sean C. Farley" To: "David E. O'Brien" In-Reply-To: <200710022006.l92K6EQG004893@repoman.freebsd.org> Message-ID: References: <200710022006.l92K6EQG004893@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.3 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on mail.farley.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/gcc opts.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 21:54:26 -0000 On Tue, 2 Oct 2007, David E. O'Brien wrote: > obrien 2007-10-02 20:06:14 UTC > > FreeBSD src repository > > Modified files: > contrib/gcc opts.c > Log: > Do not imply -ftree-vrp with -O2 and above. One must implicitly specify > '-ftree-vrp' if one wants it. > Some bad code generation has been tracked to -ftree-vrp. jdk1{5,6} are > notable examples. I hope you meant explicitly. :) Thank you for the patch. Sean -- scf@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Wed Oct 3 01:26:25 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 65C3B16A41B; Wed, 3 Oct 2007 01:26:25 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 49F0D13C49D; Wed, 3 Oct 2007 01:26:25 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l931QPXF045347; Wed, 3 Oct 2007 01:26:25 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l931QPPO045346; Wed, 3 Oct 2007 01:26:25 GMT (envelope-from obrien) Message-Id: <200710030126.l931QPPO045346@repoman.freebsd.org> From: "David E. O'Brien" Date: Wed, 3 Oct 2007 01:26:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/contrib/gcc opts.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 01:26:25 -0000 obrien 2007-10-03 01:26:24 UTC FreeBSD src repository Modified files: contrib/gcc opts.c Log: Correction to the log for rev. 1.4: "One must now explicitly specify -ftree-vrp if one wants it". Approved by: re(KenSmith) Revision Changes Path 1.5 +1 -1 src/contrib/gcc/opts.c From owner-cvs-src@FreeBSD.ORG Wed Oct 3 01:58:12 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C491C16A417; Wed, 3 Oct 2007 01:58:12 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail35.syd.optusnet.com.au (mail35.syd.optusnet.com.au [211.29.133.51]) by mx1.freebsd.org (Postfix) with ESMTP id 4A16D13C458; Wed, 3 Oct 2007 01:58:12 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from c220-239-235-248.carlnfd3.nsw.optusnet.com.au (c220-239-235-248.carlnfd3.nsw.optusnet.com.au [220.239.235.248]) by mail35.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id l931vqI4021798 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 3 Oct 2007 11:57:54 +1000 Date: Wed, 3 Oct 2007 11:57:52 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: John Baldwin In-Reply-To: <200710021443.40264.jhb@freebsd.org> Message-ID: <20071003115323.Q14348@delplex.bde.org> References: <20071001145257.EC9FC4500F@ptavv.es.net> <20071001232743.Q539@10.0.0.1> <20071002213829.F12287@delplex.bde.org> <200710021443.40264.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Mailman-Approved-At: Wed, 03 Oct 2007 02:11:42 +0000 Cc: cvs-all@FreeBSD.org, src-committers@FreeBSD.org, Kevin Oberman , cvs-src@FreeBSD.org, Jeff Roberson , Garance A Drosehn , Ben Kaduk , Bruce Evans , Jeff Roberson Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 01:58:12 -0000 On Tue, 2 Oct 2007, John Baldwin wrote: > On Tuesday 02 October 2007 09:49:34 am Bruce Evans wrote: >> Apparently, there is a scaling bug for hz or extra interrupts for >> the larger hz help, and the default preempt_thresh is not best. > > -current on i386 and amd64 does a very poor job of scaling stathz and profhz > with hz, so this may explain problems at hz=100. I have an attempt to make > stathz and profhz more sane while also trying to not always drive the lapic > timer at hz * 2. I used to have a test program that would display all the > frequencies for different 'hz' values but have misplaced it. :( I fixed that about a year ago in my version of -current, and may have sent you the patch, and mentioned the need to fix it before using hz = 100 in a previous reply to this thread. Neverthless, most things including schedulers barely noticed when stahz is completely broken -- stathz needs to be about 100 to work as intended, but most things didn't notice when old bugs made it 1024 and most things don't notice when current bugs make it 13. [Patch deleted]. [My patch sent in private mail]. Bruce From owner-cvs-src@FreeBSD.ORG Wed Oct 3 03:11:17 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A2E3816A419; Wed, 3 Oct 2007 03:11:17 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail34.syd.optusnet.com.au (mail34.syd.optusnet.com.au [211.29.133.218]) by mx1.freebsd.org (Postfix) with ESMTP id 3F95613C474; Wed, 3 Oct 2007 03:11:17 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from c220-239-235-248.carlnfd3.nsw.optusnet.com.au (c220-239-235-248.carlnfd3.nsw.optusnet.com.au [220.239.235.248]) by mail34.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id l933B1od015295 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 3 Oct 2007 13:11:01 +1000 Date: Wed, 3 Oct 2007 13:11:01 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Jeff Roberson In-Reply-To: <20071002133334.W594@10.0.0.1> Message-ID: <20071003123512.W14348@delplex.bde.org> References: <20071001145257.EC9FC4500F@ptavv.es.net> <20071002133623.X40629@besplex.bde.org> <20071001232743.Q539@10.0.0.1> <20071002213829.F12287@delplex.bde.org> <20071002133334.W594@10.0.0.1> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-all@FreeBSD.org, src-committers@FreeBSD.org, Kevin Oberman , cvs-src@FreeBSD.org, Jeff Roberson , Garance A Drosehn , Ben Kaduk , Bruce Evans Subject: Re: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 03:11:17 -0000 On Tue, 2 Oct 2007, Jeff Roberson wrote: > On Tue, 2 Oct 2007, Bruce Evans wrote: > Sorry I don't have time for a point by point on this one. Thank you for your > interesting analysis. From this I'm taking away a couple of things: > > 1) I've noticed that ULE relied on PREEMPTION for a long time and lost the > NEEDRESCHED setting in cases where it doesn't set owepreempt. Restoring this > should improve some of the !PREEMPTION behavior and perhaps even > responsiveness in your nice tests. Not the problem here, since I always use PREEMPTION for UP. > 2) I need to try running with hz = 100 and see if there are some scaling > problems. I have heard reports that ULE scales better than 4BSD up to higher > hz values but I haven't investigated this much. It should work with lower as > well. Everything important to relative priorites and time slice allotment > runs off of stathz. Again, not the problem here, since I tested with both hz = 100 and hz = 1000. Also stathz = 100 and stathz = 128. I haven't tried huge hz lately. > 3) The code which adjusts priorities for fork may need some more fine > tuning. ULE agressively penalizes parents for forking expensive children. > This helps us learn that make should not create interactive children for > example. I checked what 5.2 and ~5.2 are doing: - fork: both just keep the parent's estcpu - exit: 5.2 adds the child's estcpu to the parent's, same as in 4.x (?), so that the parent's priority wants to be exponential in the number of children even of the children don't do anything (except when the initial estcpu is 0, doubling it makes no difference). So I don't understand why 5.2 seems to be able to repeatedly run acroread with no penalty. - exit: ~5.2 sets the parent's estcpu to the minimum of the parent and the child estcpu, so that parents are only penalized for expensive children. Parents aren't penalized enough if they have lots of not-so-expensive children, but with the estcpu clamp in 5.2 there is probably nothing better. However, ~5.2 doesn't clamp estcpu, so it could do better. ~5.2 has to do something better than add the estcpu's, since with true exponential growth the estcpu quicky reaches "infinity", and ~5.2 has dynamic scaling of estcpu to priorities which would give an infinite penalty for infinite estcpu, and with infinite estcpu taking infinitely long to decay, the infinitely penalized perant would never run. Note that 4BSD was broken by the infinities in most versions of FreeBSD-2 and FreeBSD-3. The bug was introduced early in FreeBSD-2 and later picked up by NetBSD. There were mysterious hangs, and only the infinities being not quite infinite allowed parents to run again. estcpu is an int[32_t] variable, so repeated doublings starting at value 1 eventually overflow to -0x80000000 and then to 0. Usually the priority becomes too high to run before 31 or 32 doublings cause overflow, so the overflow bugs don't help. Instead, estcpu reaches a huge value which takes only seconds or minutes to decay to a value which gives a small enough priority to run, or the runq becomes empty except for processes with infinite estcpu so those processes can run. > 4) I don't think you're losing interrupts when you ctrl+c. It's just taking > too long for the interrupted task to run. ctrl+z takes effect immediately > when the signal is delivered. This may be related to hz = 100 or running > without preemption. I am not able to reproduce this problem with a standard > GENERIC kernel + ULE. ^C is printed by the tty driver, so tty (keyboard) interrupts certainly work. IPIs probably work too. Oops, this is UP so there are no IPIs. So the problem is just the ^C signal never being delivered to the looping process, and it is surpising that ^Z is delivered. The interrupted task _is_ running (it is looping) and delivery would consist mainly of killing it (I forget if the shell sees the ^C before the child is killed). This is not related to PREEMPTION since I always use PREEMPTION for UP. It seems to be related to hz = 100. My kernel is similar to GENERIC in this area except for HZ and leaving out ADAPTIVE_GIANT. Bruce From owner-cvs-src@FreeBSD.ORG Wed Oct 3 05:44:28 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 628F516A417; Wed, 3 Oct 2007 05:44:28 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 43CFB13C459; Wed, 3 Oct 2007 05:44:28 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l935iSCx087747; Wed, 3 Oct 2007 05:44:28 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l935iSaF087746; Wed, 3 Oct 2007 05:44:28 GMT (envelope-from ru) Message-Id: <200710030544.l935iSaF087746@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 3 Oct 2007 05:44:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/mtree README X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 05:44:28 -0000 ru 2007-10-03 05:44:27 UTC FreeBSD src repository Modified files: etc/mtree README Log: Removed "tail +5" from the command used to sanity check changes to mtree files -- the 5-line header is no longer printed when mtree(8) is run with -n (as of mtree/create.c,v 1.34). Approved by: re (kensmith) Revision Changes Path 1.8 +2 -2 src/etc/mtree/README From owner-cvs-src@FreeBSD.ORG Wed Oct 3 05:51:21 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D23116A417; Wed, 3 Oct 2007 05:51:21 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2A71913C481; Wed, 3 Oct 2007 05:51:21 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l935pL2n088190; Wed, 3 Oct 2007 05:51:21 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l935pKZG088188; Wed, 3 Oct 2007 05:51:20 GMT (envelope-from ru) Message-Id: <200710030551.l935pKZG088188@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 3 Oct 2007 05:51:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/mtree BSD.include.dist BSD.local.dist BSD.x11-4.dist X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 05:51:21 -0000 ru 2007-10-03 05:51:20 UTC FreeBSD src repository Modified files: etc/mtree BSD.include.dist BSD.local.dist BSD.x11-4.dist Log: Sort as per README. Approved by: re (kensmith) Revision Changes Path 1.120 +24 -24 src/etc/mtree/BSD.include.dist 1.126 +2 -2 src/etc/mtree/BSD.local.dist 1.32 +2 -2 src/etc/mtree/BSD.x11-4.dist From owner-cvs-src@FreeBSD.ORG Wed Oct 3 06:04:41 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7DC1F16A41A; Wed, 3 Oct 2007 06:04:41 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 42E0813C4A7; Wed, 3 Oct 2007 06:04:41 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9364eIe090104; Wed, 3 Oct 2007 06:04:40 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9364eC1090103; Wed, 3 Oct 2007 06:04:40 GMT (envelope-from ru) Message-Id: <200710030604.l9364eC1090103@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 3 Oct 2007 06:04:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: FSF Cc: Subject: cvs commit: src/contrib/groff/tmac doc-common doc-syms groff_mdoc.man X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 06:04:41 -0000 ru 2007-10-03 06:04:40 UTC FreeBSD src repository Modified files: (Branch: FSF) contrib/groff/tmac doc-common doc-syms groff_mdoc.man Log: Pull up current -mdoc version from vendor. This includes the following changes: : 2007-10-02 Ruslan Ermilov : : * tmac/doc-common, tmac/groff_doc.man: Add FreeBSD 6.2, document : FreeBSD 5.5 and 7.0. : : * tmac/doc-syms: Give better names for System V releases. : 2007-05-30 Werner LEMBERG : : * tmac/groff_mdoc.man: Convert `-' to `\-' where appropriate. : Recommend `tbl' instead of `-column' lists for more complicated : cases. Revision Changes Path 1.1.1.22 +1 -0 src/contrib/groff/tmac/doc-common 1.1.1.11 +4 -4 src/contrib/groff/tmac/doc-syms 1.1.1.22 +88 -82 src/contrib/groff/tmac/groff_mdoc.man From owner-cvs-src@FreeBSD.ORG Wed Oct 3 06:55:04 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6A06216A417; Wed, 3 Oct 2007 06:55:04 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 1D8F813C468; Wed, 3 Oct 2007 06:55:04 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (p54A56234.dip.t-dialin.net [84.165.98.52]) by redbull.bpaserver.net (Postfix) with ESMTP id 4166F2E2AC; Wed, 3 Oct 2007 08:54:57 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 416495B4800; Wed, 3 Oct 2007 08:54:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1191394469; bh=UWnyp5zfoI/epHKi22qKo5T6YC14VuXzO +xpJUwYTnE=; h=Message-ID:X-Priority:Date:From:To:Cc:Subject: References:In-Reply-To:MIME-Version:Content-Type: Content-Disposition:Content-Transfer-Encoding:User-Agent; b=pF1D9U 1nEdKUZ6smTVpBgsabTpcKrKv3uGi+Kb12b12a4B7TAszo30QW+fuJOQEfVK8TTY3WQ q1ZktBoZA85ZhNIEzldSoNgpQpKhvmEz8wBvH8HQF6EhbSwZR8ew/uA1ZRyvwlqnYJi pAIRU7O63oCZnz4kgDCUehlYzw8bJg5gqDyFJyf+jBsBT/Rj+LVovkVQfWfrDVasySF FHqwZMHWyanfmRWUqHM3z31WZmccC3Z8T4hrwaiHmt+PMKRXygBzJNWRbiJSRYAkf3o w20HX6/6ZpIiCvRHR+d3NxCH7NJo5bDRV217vkWUPMP62gOr4vCxHZEgky7UkyLvANC g== Received: (from www@localhost) by webmail.leidinger.net (8.14.1/8.13.8/Submit) id l936sTgO042066; Wed, 3 Oct 2007 08:54:29 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Wed, 03 Oct 2007 08:54:29 +0200 Message-ID: <20071003085429.014s3lbkro4c0g4k@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Wed, 03 Oct 2007 08:54:29 +0200 From: Alexander Leidinger To: "David E. O'Brien" References: <200710022006.l92K6EQG004893@repoman.freebsd.org> In-Reply-To: <200710022006.l92K6EQG004893@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.9, required 8, BAYES_00 -15.00, RDNS_DYNAMIC 0.10) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/gcc opts.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 06:55:04 -0000 Quoting "David E. O'Brien" (from Tue, 2 Oct 2007 20:06:14 +0000 (UTC)): > obrien 2007-10-02 20:06:14 UTC > > FreeBSD src repository > > Modified files: > contrib/gcc opts.c > Log: > Do not imply -ftree-vrp with -O2 and above. One must implicitly specify > '-ftree-vrp' if one wants it. Thanks! Bye, Alexander. -- Not all men who drink are poets. Some of us drink because we aren't poets. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 From owner-cvs-src@FreeBSD.ORG Wed Oct 3 19:28:58 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0CFC216A469; Wed, 3 Oct 2007 19:28:58 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id CCFDE13C48E; Wed, 3 Oct 2007 19:28:57 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l93JSv2s078578; Wed, 3 Oct 2007 19:28:57 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l93JSvUp078577; Wed, 3 Oct 2007 19:28:57 GMT (envelope-from obrien) Message-Id: <200710031928.l93JSvUp078577@repoman.freebsd.org> From: "David E. O'Brien" Date: Wed, 3 Oct 2007 19:28:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/netstat bpf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 19:28:58 -0000 obrien 2007-10-03 19:28:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/netstat bpf.c Log: MFC: rev. 1.8's layout changes. Revision Changes Path 1.5.2.3 +2 -2 src/usr.bin/netstat/bpf.c From owner-cvs-src@FreeBSD.ORG Wed Oct 3 19:55:37 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 437BB16A417; Wed, 3 Oct 2007 19:55:37 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0CE9B13C4B5; Wed, 3 Oct 2007 19:55:37 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l93JtaY9080096; Wed, 3 Oct 2007 19:55:36 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l93Jta1R080095; Wed, 3 Oct 2007 19:55:36 GMT (envelope-from obrien) Message-Id: <200710031955.l93Jta1R080095@repoman.freebsd.org> From: "David E. O'Brien" Date: Wed, 3 Oct 2007 19:55:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/netstat netgraph.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 19:55:37 -0000 obrien 2007-10-03 19:55:36 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/netstat netgraph.c Log: MFC: 2006/07/28 commit achieving WARNS=3 Also fix nlist 'nl' should be terminated by a NULL entry. Revision Changes Path 1.10.8.2 +2 -1 src/usr.bin/netstat/netgraph.c From owner-cvs-src@FreeBSD.ORG Wed Oct 3 19:56:18 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 39F1F16A46E; Wed, 3 Oct 2007 19:56:18 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id D49C113C4B5; Wed, 3 Oct 2007 19:56:17 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l93JuHrw080216; Wed, 3 Oct 2007 19:56:17 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l93JuH6t080215; Wed, 3 Oct 2007 19:56:17 GMT (envelope-from obrien) Message-Id: <200710031956.l93JuH6t080215@repoman.freebsd.org> From: "David E. O'Brien" Date: Wed, 3 Oct 2007 19:56:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/netstat Makefile inet.c ipx.c main.c route.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 19:56:18 -0000 obrien 2007-10-03 19:56:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/netstat Makefile inet.c ipx.c main.c route.c Log: MFC: 2006/07/28 commit achieving WARNS=3 Also fix nlist 'nl' should be terminated by a NULL entry. Revision Changes Path 1.26.2.4 +1 -2 src/usr.bin/netstat/Makefile 1.70.2.3 +2 -2 src/usr.bin/netstat/inet.c 1.23.2.2 +1 -1 src/usr.bin/netstat/ipx.c 1.72.2.9 +85 -85 src/usr.bin/netstat/main.c 1.76.2.3 +3 -1 src/usr.bin/netstat/route.c From owner-cvs-src@FreeBSD.ORG Wed Oct 3 20:41:36 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 34B4416A41A; Wed, 3 Oct 2007 20:41:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 1079B13C4CC; Wed, 3 Oct 2007 20:41:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l93KfZwh084261; Wed, 3 Oct 2007 20:41:35 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l93KfZjL084260; Wed, 3 Oct 2007 20:41:35 GMT (envelope-from jhb) Message-Id: <200710032041.l93KfZjL084260@repoman.freebsd.org> From: John Baldwin Date: Wed, 3 Oct 2007 20:41:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/alpha/isa isa.c src/sys/alpha/pci apecs_pci.c lca_pci.c pcibus.c src/sys/amd64/amd64 nexus.c src/sys/arm/arm nexus.c src/sys/arm/xscale/i80321 i80321_pci.c obio.c src/sys/i386/i386 nexus.c src/sys/ia64/ia64 nexus.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 20:41:36 -0000 jhb 2007-10-03 20:41:35 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/alpha/isa isa.c sys/alpha/pci apecs_pci.c lca_pci.c pcibus.c sys/amd64/amd64 nexus.c sys/arm/arm nexus.c sys/arm/xscale/i80321 i80321_pci.c obio.c sys/i386/i386 nexus.c sys/ia64/ia64 nexus.c sys/powerpc/powermac grackle.c hrowpic.c macio.c uninorth.c sys/powerpc/powerpc openpic.c sys/powerpc/psim iobus.c sys/sparc64/ebus ebus.c sys/sparc64/pci psycho.c sys/sparc64/sbus sbus.c sys/sparc64/sparc64 nexus.c Log: MFC: Use rman_set_rid() to save the rid in new resources when they are allocated. This makes 'bus_free_resource()' safe to use in 6.x and also fixes an issue with the recent PCI MSI code MFCs that caused them to never update the MSI config registers. Reported by: gallatin (MSI breakage) Revision Changes Path 1.36.8.2 +1 -0 src/sys/alpha/isa/isa.c 1.15.10.1 +8 -3 src/sys/alpha/pci/apecs_pci.c 1.17.10.1 +8 -3 src/sys/alpha/pci/lca_pci.c 1.36.2.1 +12 -4 src/sys/alpha/pci/pcibus.c 1.66.2.5 +1 -1 src/sys/amd64/amd64/nexus.c 1.5.2.1 +1 -0 src/sys/arm/arm/nexus.c 1.4.2.3 +1 -0 src/sys/arm/xscale/i80321/i80321_pci.c 1.2.2.1 +1 -0 src/sys/arm/xscale/i80321/obio.c 1.62.2.5 +1 -1 src/sys/i386/i386/nexus.c 1.11.2.2 +1 -0 src/sys/ia64/ia64/nexus.c 1.7.2.1 +1 -0 src/sys/powerpc/powermac/grackle.c 1.10.2.1 +1 -0 src/sys/powerpc/powermac/hrowpic.c 1.18.2.1 +1 -0 src/sys/powerpc/powermac/macio.c 1.13.2.2 +1 -0 src/sys/powerpc/powermac/uninorth.c 1.13.2.1 +1 -1 src/sys/powerpc/powerpc/openpic.c 1.8.2.1 +1 -0 src/sys/powerpc/psim/iobus.c 1.23.2.2 +1 -0 src/sys/sparc64/ebus/ebus.c 1.53.2.4 +1 -1 src/sys/sparc64/pci/psycho.c 1.35.2.4 +1 -0 src/sys/sparc64/sbus/sbus.c 1.17.2.1 +1 -0 src/sys/sparc64/sparc64/nexus.c From owner-cvs-src@FreeBSD.ORG Wed Oct 3 21:06:06 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3D39416A41B; Wed, 3 Oct 2007 21:06:06 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 18B0613C47E; Wed, 3 Oct 2007 21:06:06 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l93L65qA095726; Wed, 3 Oct 2007 21:06:05 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l93L65bv095725; Wed, 3 Oct 2007 21:06:05 GMT (envelope-from jhb) Message-Id: <200710032106.l93L65bv095725@repoman.freebsd.org> From: John Baldwin Date: Wed, 3 Oct 2007 21:06:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/fs/devfs devfs_vnops.c src/sys/fs/fifofs fifo_vnops.c src/sys/kern uipc_usrreq.c vfs_vnops.c src/sys/vm vnode_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 21:06:06 -0000 jhb 2007-10-03 21:06:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/devfs devfs_vnops.c sys/fs/fifofs fifo_vnops.c sys/kern uipc_usrreq.c vfs_vnops.c sys/vm vnode_pager.c Log: MFC: Always use an exclusive lock on the leaf vnode during an open() when shared lookups are enabled. This closes a few races including a race where concurrent opens of a fifo could result in different v_fifoinfo structures in different threads. Revision Changes Path 1.114.2.15 +1 -0 src/sys/fs/devfs/devfs_vnops.c 1.113.2.20 +1 -1 src/sys/fs/fifofs/fifo_vnops.c 1.155.2.23 +1 -1 src/sys/kern/uipc_usrreq.c 1.233.2.7 +2 -2 src/sys/kern/vfs_vnops.c 1.221.2.9 +3 -3 src/sys/vm/vnode_pager.c From owner-cvs-src@FreeBSD.ORG Wed Oct 3 21:38:58 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1FA8B16A47A; Wed, 3 Oct 2007 21:38:58 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id D5F5C13C45B; Wed, 3 Oct 2007 21:38:57 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l93Lcv3D097780; Wed, 3 Oct 2007 21:38:57 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l93Lcvbf097779; Wed, 3 Oct 2007 21:38:57 GMT (envelope-from simon) Message-Id: <200710032138.l93Lcvbf097779@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Wed, 3 Oct 2007 21:38:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/crypto/openssl/ssl ssl_lib.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 21:38:58 -0000 simon 2007-10-03 21:38:57 UTC FreeBSD src repository Modified files: crypto/openssl/ssl ssl_lib.c Log: Correct a buffer overflow in OpenSSL SSL_get_shared_ciphers(). Security: FreeBSD-SA-07:08.openssl Approved by: re (security blanket) Revision Changes Path 1.2 +841 -198 src/crypto/openssl/ssl/ssl_lib.c From owner-cvs-src@FreeBSD.ORG Wed Oct 3 21:39:43 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9206E16A41A; Wed, 3 Oct 2007 21:39:43 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5274713C4AC; Wed, 3 Oct 2007 21:39:43 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l93LdhML097815; Wed, 3 Oct 2007 21:39:43 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l93LdhGG097814; Wed, 3 Oct 2007 21:39:43 GMT (envelope-from simon) Message-Id: <200710032139.l93LdhGG097814@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Wed, 3 Oct 2007 21:39:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/crypto/openssl/ssl ssl_lib.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 21:39:43 -0000 simon 2007-10-03 21:39:43 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) crypto/openssl/ssl ssl_lib.c Log: Correct a buffer overflow in OpenSSL SSL_get_shared_ciphers(). Revision Changes Path 1.1.1.12.2.2 +11 -11 src/crypto/openssl/ssl/ssl_lib.c From owner-cvs-src@FreeBSD.ORG Wed Oct 3 21:40:36 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E776316A41A; Wed, 3 Oct 2007 21:40:36 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A882513C459; Wed, 3 Oct 2007 21:40:36 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l93Leaeq097966; Wed, 3 Oct 2007 21:40:36 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l93LeaVt097965; Wed, 3 Oct 2007 21:40:36 GMT (envelope-from simon) Message-Id: <200710032140.l93LeaVt097965@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Wed, 3 Oct 2007 21:40:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_2 Cc: Subject: cvs commit: src UPDATING src/crypto/openssl/ssl ssl_lib.c src/sys/conf newvers.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 21:40:37 -0000 simon 2007-10-03 21:40:35 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_2) . UPDATING crypto/openssl/ssl ssl_lib.c sys/conf newvers.sh Log: Correct a buffer overflow in OpenSSL SSL_get_shared_ciphers(). Security: FreeBSD-SA-07:08.openssl Approved by: so (simon) Revision Changes Path 1.416.2.29.2.11 +3 -0 src/UPDATING 1.1.1.12.2.1.2.1 +11 -11 src/crypto/openssl/ssl/ssl_lib.c 1.69.2.13.2.11 +1 -1 src/sys/conf/newvers.sh From owner-cvs-src@FreeBSD.ORG Wed Oct 3 21:41:22 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8226116A417; Wed, 3 Oct 2007 21:41:22 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 4099E13C458; Wed, 3 Oct 2007 21:41:22 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l93LfMFt098155; Wed, 3 Oct 2007 21:41:22 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l93LfMMK098154; Wed, 3 Oct 2007 21:41:22 GMT (envelope-from simon) Message-Id: <200710032141.l93LfMMK098154@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Wed, 3 Oct 2007 21:41:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6_1 Cc: Subject: cvs commit: src UPDATING src/crypto/openssl/ssl ssl_lib.c src/sys/conf newvers.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 21:41:22 -0000 simon 2007-10-03 21:41:22 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_1) . UPDATING crypto/openssl/ssl ssl_lib.c sys/conf newvers.sh Log: Correct a buffer overflow in OpenSSL SSL_get_shared_ciphers(). Security: FreeBSD-SA-07:08.openssl Approved by: so (simon) Revision Changes Path 1.416.2.22.2.22 +3 -0 src/UPDATING 1.1.1.12.6.2 +11 -11 src/crypto/openssl/ssl/ssl_lib.c 1.69.2.11.2.22 +1 -1 src/sys/conf/newvers.sh From owner-cvs-src@FreeBSD.ORG Wed Oct 3 21:42:01 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 29CBC16A419; Wed, 3 Oct 2007 21:42:01 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DFBBD13C447; Wed, 3 Oct 2007 21:42:00 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l93Lg08T098265; Wed, 3 Oct 2007 21:42:00 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l93Lg0w9098264; Wed, 3 Oct 2007 21:42:00 GMT (envelope-from simon) Message-Id: <200710032142.l93Lg0w9098264@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Wed, 3 Oct 2007 21:42:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/crypto/openssl/ssl ssl_lib.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 21:42:01 -0000 simon 2007-10-03 21:42:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) crypto/openssl/ssl ssl_lib.c Log: Correct a buffer overflow in OpenSSL SSL_get_shared_ciphers(). Security: FreeBSD-SA-07:08.openssl Revision Changes Path 1.1.1.11.2.3 +11 -11 src/crypto/openssl/ssl/ssl_lib.c From owner-cvs-src@FreeBSD.ORG Wed Oct 3 21:42:33 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A892816A418; Wed, 3 Oct 2007 21:42:33 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6984B13C4A5; Wed, 3 Oct 2007 21:42:33 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l93LgXOQ098337; Wed, 3 Oct 2007 21:42:33 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l93LgXCa098336; Wed, 3 Oct 2007 21:42:33 GMT (envelope-from simon) Message-Id: <200710032142.l93LgXCa098336@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Wed, 3 Oct 2007 21:42:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_5 Cc: Subject: cvs commit: src UPDATING src/crypto/openssl/ssl ssl_lib.c src/sys/conf newvers.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 21:42:33 -0000 simon 2007-10-03 21:42:32 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_5) . UPDATING crypto/openssl/ssl ssl_lib.c sys/conf newvers.sh Log: Correct a buffer overflow in OpenSSL SSL_get_shared_ciphers(). Security: FreeBSD-SA-07:08.openssl Approved by: so (simon) Revision Changes Path 1.342.2.35.2.16 +3 -0 src/UPDATING 1.1.1.11.2.1.4.2 +11 -11 src/crypto/openssl/ssl/ssl_lib.c 1.62.2.21.2.18 +1 -1 src/sys/conf/newvers.sh From owner-cvs-src@FreeBSD.ORG Wed Oct 3 23:45:15 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EEAC316A417; Wed, 3 Oct 2007 23:45:15 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com [216.240.101.25]) by mx1.freebsd.org (Postfix) with ESMTP id 950E813C45A; Wed, 3 Oct 2007 23:45:15 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from [192.168.1.103] (c-67-160-44-208.hsd1.wa.comcast.net [67.160.44.208]) (authenticated bits=0) by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id l93NjDoX047099 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO); Wed, 3 Oct 2007 19:45:14 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Wed, 3 Oct 2007 16:48:00 -0700 (PDT) From: Jeff Roberson X-X-Sender: jroberson@10.0.0.1 To: John Baldwin In-Reply-To: <200710032106.l93L65bv095725@repoman.freebsd.org> Message-ID: <20071003164642.B615@10.0.0.1> References: <200710032106.l93L65bv095725@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/devfs devfs_vnops.c src/sys/fs/fifofs fifo_vnops.c src/sys/kern uipc_usrreq.c vfs_vnops.c src/sys/vm vnode_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2007 23:45:16 -0000 On Wed, 3 Oct 2007, John Baldwin wrote: > jhb 2007-10-03 21:06:05 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/fs/devfs devfs_vnops.c > sys/fs/fifofs fifo_vnops.c > sys/kern uipc_usrreq.c vfs_vnops.c > sys/vm vnode_pager.c > Log: > MFC: Always use an exclusive lock on the leaf vnode during an open() when > shared lookups are enabled. This closes a few races including a race where > concurrent opens of a fifo could result in different v_fifoinfo structures > in different threads. Long term we should really look for a better solution to this problem. There are a number of was to improve snapshots in ffs by fixing shared locking. > > Revision Changes Path > 1.114.2.15 +1 -0 src/sys/fs/devfs/devfs_vnops.c > 1.113.2.20 +1 -1 src/sys/fs/fifofs/fifo_vnops.c > 1.155.2.23 +1 -1 src/sys/kern/uipc_usrreq.c > 1.233.2.7 +2 -2 src/sys/kern/vfs_vnops.c > 1.221.2.9 +3 -3 src/sys/vm/vnode_pager.c > From owner-cvs-src@FreeBSD.ORG Thu Oct 4 04:38:24 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CEE0016A41A; Thu, 4 Oct 2007 04:38:24 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A0ACB13C47E; Thu, 4 Oct 2007 04:38:24 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l944cOqR048542; Thu, 4 Oct 2007 04:38:24 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l944cO5q048541; Thu, 4 Oct 2007 04:38:24 GMT (envelope-from ru) Message-Id: <200710040438.l944cO5q048541@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 4 Oct 2007 04:38:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/contrib/groff/tmac doc-common doc-syms X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 04:38:24 -0000 ru 2007-10-04 04:38:24 UTC FreeBSD src repository Modified files: contrib/groff/tmac doc-common doc-syms Log: MFV: recent mdoc(7) changes. Approved by: re (kensmith) Revision Changes Path 1.72 +1 -0 src/contrib/groff/tmac/doc-common 1.51 +4 -4 src/contrib/groff/tmac/doc-syms From owner-cvs-src@FreeBSD.ORG Thu Oct 4 04:39:07 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E16A16A41B; Thu, 4 Oct 2007 04:39:07 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 1FCAB13C44B; Thu, 4 Oct 2007 04:39:07 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l944d6vg048595; Thu, 4 Oct 2007 04:39:06 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l944d6Vc048594; Thu, 4 Oct 2007 04:39:06 GMT (envelope-from ru) Message-Id: <200710040439.l944d6Vc048594@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 4 Oct 2007 04:39:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/gnu/usr.bin/groff/tmac mdoc.local X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 04:39:07 -0000 ru 2007-10-04 04:39:06 UTC FreeBSD src repository Modified files: gnu/usr.bin/groff/tmac mdoc.local Log: FreeBSD 6.2 is now known to mdoc. Approved by: re (kensmith) Revision Changes Path 1.59 +0 -1 src/gnu/usr.bin/groff/tmac/mdoc.local From owner-cvs-src@FreeBSD.ORG Thu Oct 4 04:56:41 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CEAAC16A41A; Thu, 4 Oct 2007 04:56:41 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9F51613C44B; Thu, 4 Oct 2007 04:56:41 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l944ufjO058239; Thu, 4 Oct 2007 04:56:41 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l944ufXs058238; Thu, 4 Oct 2007 04:56:41 GMT (envelope-from ru) Message-Id: <200710040456.l944ufXs058238@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 4 Oct 2007 04:56:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/contrib/groff/tmac doc-common doc-syms groff_mdoc.man src/gnu/usr.bin/groff/tmac mdoc.local X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 04:56:41 -0000 ru 2007-10-04 04:56:41 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) contrib/groff/tmac doc-common doc-syms groff_mdoc.man gnu/usr.bin/groff/tmac mdoc.local Log: MFC: Updated mdoc (FreeBSD 6.2 added, FreeBSD 5.5 and 7.0 documented, better names for System V releases [1]). PR: docs/68845 [1] Revision Changes Path 1.68.2.4 +1 -0 src/contrib/groff/tmac/doc-common 1.48.2.3 +4 -4 src/contrib/groff/tmac/doc-syms 1.1.1.18.2.4 +88 -82 src/contrib/groff/tmac/groff_mdoc.man 1.48.2.11 +0 -1 src/gnu/usr.bin/groff/tmac/mdoc.local From owner-cvs-src@FreeBSD.ORG Thu Oct 4 06:21:55 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC3BC16A419; Thu, 4 Oct 2007 06:21:55 +0000 (UTC) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8E0E513C468; Thu, 4 Oct 2007 06:21:55 +0000 (UTC) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l946LtrK066980; Thu, 4 Oct 2007 06:21:55 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l946LtGG066979; Thu, 4 Oct 2007 06:21:55 GMT (envelope-from phk) Message-Id: <200710040621.l946LtGG066979@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 4 Oct 2007 06:21:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ata ata-chipset.c ata-pci.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 06:21:55 -0000 phk 2007-10-04 06:21:55 UTC FreeBSD src repository Modified files: sys/dev/ata ata-chipset.c ata-pci.h Log: Recognize the CS5536 support chip for the AMD Geode LX CPU to enable UDMA modes. Please notice that Soekris NET5501 bios versions before 1.32f has a bug that prevents this from working. Approved by: re (gnn) MFC: 2 weeks Revision Changes Path 1.200 +1 -0 src/sys/dev/ata/ata-chipset.c 1.79 +1 -0 src/sys/dev/ata/ata-pci.h From owner-cvs-src@FreeBSD.ORG Thu Oct 4 09:29:34 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 862E116A417; Thu, 4 Oct 2007 09:29:34 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5A24013C448; Thu, 4 Oct 2007 09:29:34 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l949TYOn093521; Thu, 4 Oct 2007 09:29:34 GMT (envelope-from rrs@repoman.freebsd.org) Received: (from rrs@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l949TYrO093520; Thu, 4 Oct 2007 09:29:34 GMT (envelope-from rrs) Message-Id: <200710040929.l949TYrO093520@repoman.freebsd.org> From: Randall Stewart Date: Thu, 4 Oct 2007 09:29:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet sctputil.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 09:29:34 -0000 rrs 2007-10-04 09:29:34 UTC FreeBSD src repository Modified files: sys/netinet sctputil.c Log: - We should return error = 0 and the upper processing would return a zero length read. Otherwise we don't return the right error indication. Approved by: re@freebsd.org (gnn) Revision Changes Path 1.65 +2 -1 src/sys/netinet/sctputil.c From owner-cvs-src@FreeBSD.ORG Thu Oct 4 09:45:42 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 80CD916A419; Thu, 4 Oct 2007 09:45:42 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5440D13C457; Thu, 4 Oct 2007 09:45:42 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l949jgwB094472; Thu, 4 Oct 2007 09:45:42 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l949jg1W094471; Thu, 4 Oct 2007 09:45:42 GMT (envelope-from thompsa) Message-Id: <200710040945.l949jg1W094471@repoman.freebsd.org> From: Andrew Thompson Date: Thu, 4 Oct 2007 09:45:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/ifconfig ifconfig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 09:45:42 -0000 thompsa 2007-10-04 09:45:41 UTC FreeBSD src repository Modified files: sbin/ifconfig ifconfig.c Log: Fix the module name matching to the drivers present in the kernel. Previously it would return true on a partial match where it would think the edsc module was already present by having a positive match on 'ed'. This changes it so that it compares the full string including the nul terminators. This also fixes a buffer overflow in the ifkind variable where the length of the interface name in *argv wasnt checked for size. Reviewed by: brooks Approved by: re (gnn) Revision Changes Path 1.134 +14 -7 src/sbin/ifconfig/ifconfig.c From owner-cvs-src@FreeBSD.ORG Thu Oct 4 11:28:26 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1B13516A420; Thu, 4 Oct 2007 11:28:26 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 05AED13C46A; Thu, 4 Oct 2007 11:28:26 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l94BSPCJ002668; Thu, 4 Oct 2007 11:28:25 GMT (envelope-from yongari@repoman.freebsd.org) Received: (from yongari@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l94BSP5B002667; Thu, 4 Oct 2007 11:28:25 GMT (envelope-from yongari) Message-Id: <200710041128.l94BSP5B002667@repoman.freebsd.org> From: Pyun YongHyeon Date: Thu, 4 Oct 2007 11:28:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/re if_re.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 11:28:26 -0000 yongari 2007-10-04 11:28:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/re if_re.c Log: MFC if_re.c rev. 1.95 to RELENG_6. Make sure to take PHY out of power down mode in device attach. Without this the PHY wouldn't work as expected. This should fix dual-boot Windows XP machine where RealTek Windows drivers put the PHY in power down mode during shutdown. The magic PHY register accesses come from RealTek driver. No datasheets mention the magic PHY registers. In general, the PHY wakeup code should go into PHY driver. However it seems that it only apply to RTL8169S single chip and it would be another hack if we have rgephy(4) check what parent driver/chip model is attached. Revision Changes Path 1.46.2.34 +22 -0 src/sys/dev/re/if_re.c From owner-cvs-src@FreeBSD.ORG Thu Oct 4 16:14:49 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 88B5116A417; Thu, 4 Oct 2007 16:14:49 +0000 (UTC) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 67D8F13C459; Thu, 4 Oct 2007 16:14:49 +0000 (UTC) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l94GEnQV034016; Thu, 4 Oct 2007 16:14:49 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l94GEnBH034015; Thu, 4 Oct 2007 16:14:49 GMT (envelope-from stefanf) Message-Id: <200710041614.l94GEnBH034015@repoman.freebsd.org> From: Stefan Farfeleder Date: Thu, 4 Oct 2007 16:14:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/bin/sh eval.c sh.1 src/tools/regression/bin/sh/builtins case1.0 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 16:14:49 -0000 stefanf 2007-10-04 16:14:49 UTC FreeBSD src repository Modified files: bin/sh eval.c sh.1 Added files: tools/regression/bin/sh/builtins case1.0 Log: The exit status of a case statement where none of the patterns is matched is supposed to be 0, not the status of the previous command. Reported by: Eygene Ryabinkin PR: 116559 Approved by: re (gnn) Revision Changes Path 1.54 +1 -0 src/bin/sh/eval.c 1.125 +4 -0 src/bin/sh/sh.1 1.1 +13 -0 src/tools/regression/bin/sh/builtins/case1.0 (new) From owner-cvs-src@FreeBSD.ORG Thu Oct 4 17:08:46 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 99C6116A417; Thu, 4 Oct 2007 17:08:46 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7A24F13C4AA; Thu, 4 Oct 2007 17:08:46 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l94H8kGP047149; Thu, 4 Oct 2007 17:08:46 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l94H8k5S047148; Thu, 4 Oct 2007 17:08:46 GMT (envelope-from delphij) Message-Id: <200710041708.l94H8k5S047148@repoman.freebsd.org> From: Xin LI Date: Thu, 4 Oct 2007 17:08:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/tmpfs tmpfs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 17:08:46 -0000 delphij 2007-10-04 17:08:46 UTC FreeBSD src repository Modified files: sys/fs/tmpfs tmpfs_vfsops.c Log: Additional work is still needed before we can claim that tmpfs is stable enough for production usage. Warn user upon mount. Approved by: re (tmpfs blanket) Revision Changes Path 1.10 +3 -0 src/sys/fs/tmpfs/tmpfs_vfsops.c From owner-cvs-src@FreeBSD.ORG Thu Oct 4 17:11:48 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B1E6416A50D; Thu, 4 Oct 2007 17:11:48 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9316113C45A; Thu, 4 Oct 2007 17:11:48 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l94HBmcH047468; Thu, 4 Oct 2007 17:11:48 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l94HBmL6047467; Thu, 4 Oct 2007 17:11:48 GMT (envelope-from delphij) Message-Id: <200710041711.l94HBmL6047467@repoman.freebsd.org> From: Xin LI Date: Thu, 4 Oct 2007 17:11:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/tmpfs tmpfs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 17:11:48 -0000 delphij 2007-10-04 17:11:48 UTC FreeBSD src repository Modified files: sys/fs/tmpfs tmpfs_vfsops.c Log: MFp4: Provide a dummy verb "export" to shut up the message showed up at start when NFS is enabled. Reported by: rafan Approved by: re (tmpfs blanket) Revision Changes Path 1.11 +1 -1 src/sys/fs/tmpfs/tmpfs_vfsops.c From owner-cvs-src@FreeBSD.ORG Thu Oct 4 17:51:59 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 964B316A420; Thu, 4 Oct 2007 17:51:59 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 77EDF13C469; Thu, 4 Oct 2007 17:51:59 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l94Hpx43049593; Thu, 4 Oct 2007 17:51:59 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l94HpxNU049592; Thu, 4 Oct 2007 17:51:59 GMT (envelope-from pjd) Message-Id: <200710041751.l94HpxNU049592@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Thu, 4 Oct 2007 17:51:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs zap_micro.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 17:51:59 -0000 pjd 2007-10-04 17:51:59 UTC FreeBSD src repository Modified files: sys/contrib/opensolaris/uts/common/fs/zfs zap_micro.c Log: Fix lock leak leading to the 'System call returning with 1 locks held' panic. Reported by: kris Approved by: re (kensmith) Revision Changes Path 1.2 +2 -0 src/sys/contrib/opensolaris/uts/common/fs/zfs/zap_micro.c From owner-cvs-src@FreeBSD.ORG Thu Oct 4 18:04:58 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D52ED16A417; Thu, 4 Oct 2007 18:04:58 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.171]) by mx1.freebsd.org (Postfix) with ESMTP id 6B3CF13C43E; Thu, 4 Oct 2007 18:04:58 +0000 (UTC) (envelope-from max@love2party.net) Received: from [88.66.43.62] (helo=amd64.laiers.local) by mrelayeu.kundenserver.de (node=mrelayeu3) with ESMTP (Nemesis) id 0MKxQS-1IdUs30qOt-0007xa; Thu, 04 Oct 2007 19:52:23 +0200 From: Max Laier Organization: FreeBSD To: "David E. O'Brien" Date: Thu, 4 Oct 2007 19:52:15 +0200 User-Agent: KMail/1.9.7 References: <200710031956.l93JuH6t080215@repoman.freebsd.org> In-Reply-To: <200710031956.l93JuH6t080215@repoman.freebsd.org> X-Face: ,,8R(x[kmU]tKN@>gtH1yQE4aslGdu+2]; R]*pL,U>^H?)gW@49@wdJ`H<=?utf-8?q?=25=7D*=5FBD=0A=09U=5For=3D=5CmOZf764=26nYj=3DJYbR1PW0ud?=>|!~,,CPC.1-D$FG@0h3#'5"k{V]a~.<=?utf-8?q?mZ=7D44=23Se=7Em=0A=09Fe=7E=5C=5DX5B=5D=5Fxj?=(ykz9QKMw_l0C2AQ]}Ym8)fU MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4082227.phsWqFjiF8"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200710041952.22362.max@love2party.net> X-Provags-ID: V01U2FsdGVkX18nhYBKJ5jO6z9gJlJNja6pPriakIRrnggUa/L f+vsoOjh3j6FdQZKoMIV387eDtSA/T1jAvlIjMh/C1YeXI89ay khzZ2BHgL4oE0egNA+jxaObMQ8sS1AxsI8WRpSXYQ4= Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/netstat Makefile inet.c ipx.c main.c route.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 18:04:58 -0000 --nextPart4082227.phsWqFjiF8 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wednesday 03 October 2007, David E. O'Brien wrote: > obrien 2007-10-03 19:56:17 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > usr.bin/netstat Makefile inet.c ipx.c main.c route.c > Log: > MFC: 2006/07/28 commit achieving WARNS=3D3 > Also fix nlist 'nl' should be terminated by a NULL entry. It seems the previous commit to WARNS=3D2 is missing/was lost: http://www.freebsd.org/cgi/cvsweb.cgi/src/usr.bin/netstat/inet.c#rev1.71 Tinderbox: > >>> stage 4.4: building everything > > [...] > /src/usr.bin/netstat/inet.c:1035: warning: long long unsigned int > format, u_quad_t arg (arg 2) /src/usr.bin/netstat/inet.c:1036: warning: > long long unsigned int format, u_quad_t arg (arg 2) > /src/usr.bin/netstat/inet.c:1037: warning: long long unsigned int > format, u_quad_t arg (arg 2) /src/usr.bin/netstat/inet.c:1038: warning: > long long unsigned int format, u_quad_t arg (arg 2) > /src/usr.bin/netstat/inet.c:1039: warning: long long unsigned int > format, u_quad_t arg (arg 2) /src/usr.bin/netstat/inet.c:1040: warning: > long long unsigned int format, u_quad_t arg (arg 2) > /src/usr.bin/netstat/inet.c:1041: warning: long long unsigned int > format, u_quad_t arg (arg 2) /src/usr.bin/netstat/inet.c:1042: warning: > long long unsigned int format, u_quad_t arg (arg 2) *** Error code 1 > > Stop in /src/usr.bin/netstat. > Revision Changes Path > 1.26.2.4 +1 -2 src/usr.bin/netstat/Makefile > 1.70.2.3 +2 -2 src/usr.bin/netstat/inet.c > 1.23.2.2 +1 -1 src/usr.bin/netstat/ipx.c > 1.72.2.9 +85 -85 src/usr.bin/netstat/main.c > 1.76.2.3 +3 -1 src/usr.bin/netstat/route.c =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart4082227.phsWqFjiF8 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQBHBShWXyyEoT62BG0RAiuPAJ426tJ5dp6ygKWFj4ELTPoFSS8IXgCeL6NO KCQXjpo7sF7CzHLmlrzMkTg= =iDMF -----END PGP SIGNATURE----- --nextPart4082227.phsWqFjiF8-- From owner-cvs-src@FreeBSD.ORG Thu Oct 4 18:27:46 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 30A0316A417; Thu, 4 Oct 2007 18:27:46 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2996613C478; Thu, 4 Oct 2007 18:27:46 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l94IRkH4052813; Thu, 4 Oct 2007 18:27:46 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l94IRkpi052812; Thu, 4 Oct 2007 18:27:46 GMT (envelope-from obrien) Message-Id: <200710041827.l94IRkpi052812@repoman.freebsd.org> From: "David E. O'Brien" Date: Thu, 4 Oct 2007 18:27:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.bin/netstat atalk.c bpf.c inet.c inet6.c ipsec.c ipx.c main.c mbuf.c mroute.c mroute6.c netgraph.c netstat.h pfkey.c route.c unix.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 18:27:46 -0000 obrien 2007-10-04 18:27:45 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/netstat atalk.c bpf.c inet.c inet6.c ipsec.c ipx.c main.c mbuf.c mroute.c mroute6.c netgraph.c netstat.h pfkey.c route.c unix.c Log: MFC: Use uintmax_t to pass around 64-bit quantities, including to printf(). Using uintmax_t is also robust to further extensions in both the C language and the bitwidth of kernel counters. Revision Changes Path 1.24.8.2 +1 -0 src/usr.bin/netstat/atalk.c 1.5.2.4 +1 -0 src/usr.bin/netstat/bpf.c 1.70.2.4 +29 -28 src/usr.bin/netstat/inet.c 1.25.8.3 +161 -160 src/usr.bin/netstat/inet6.c 1.12.8.3 +27 -26 src/usr.bin/netstat/ipsec.c 1.23.2.3 +1 -0 src/usr.bin/netstat/ipx.c 1.72.2.10 +4 -4 src/usr.bin/netstat/main.c 1.42.8.8 +24 -23 src/usr.bin/netstat/mbuf.c 1.22.8.3 +15 -10 src/usr.bin/netstat/mroute.c 1.15.8.1 +19 -18 src/usr.bin/netstat/mroute6.c 1.10.8.3 +1 -0 src/usr.bin/netstat/netgraph.c 1.41.2.7 +3 -3 src/usr.bin/netstat/netstat.h 1.1.2.3 +23 -22 src/usr.bin/netstat/pfkey.c 1.76.2.4 +1 -0 src/usr.bin/netstat/route.c 1.18.8.2 +1 -0 src/usr.bin/netstat/unix.c From owner-cvs-src@FreeBSD.ORG Thu Oct 4 18:29:53 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 828D116A418; Thu, 4 Oct 2007 18:29:53 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6571F13C469; Thu, 4 Oct 2007 18:29:53 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l94ITrsR052966; Thu, 4 Oct 2007 18:29:53 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l94ITr6x052965; Thu, 4 Oct 2007 18:29:53 GMT (envelope-from obrien) Message-Id: <200710041829.l94ITr6x052965@repoman.freebsd.org> From: "David E. O'Brien" Date: Thu, 4 Oct 2007 18:29:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/boot/common module.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 18:29:53 -0000 obrien 2007-10-04 18:29:53 UTC FreeBSD src repository Modified files: sys/boot/common module.c Log: Also boot *.debug if everything else fails. Approved by: re(gnn) Revision Changes Path 1.27 +1 -0 src/sys/boot/common/module.c From owner-cvs-src@FreeBSD.ORG Thu Oct 4 19:17:16 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9273616A419; Thu, 4 Oct 2007 19:17:16 +0000 (UTC) (envelope-from sos@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7551C13C4B5; Thu, 4 Oct 2007 19:17:16 +0000 (UTC) (envelope-from sos@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l94JHGBp057466; Thu, 4 Oct 2007 19:17:16 GMT (envelope-from sos@repoman.freebsd.org) Received: (from sos@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l94JHGPe057465; Thu, 4 Oct 2007 19:17:16 GMT (envelope-from sos) Message-Id: <200710041917.l94JHGPe057465@repoman.freebsd.org> From: Søren Schmidt Date: Thu, 4 Oct 2007 19:17:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/ata ata-all.c ata-chipset.c ata-pci.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 19:17:16 -0000 sos 2007-10-04 19:17:16 UTC FreeBSD src repository Modified files: sys/dev/ata ata-all.c ata-chipset.c ata-pci.h Log: Add support for the VIA 8237S Fix the LBA28/LBA48 crossover bug. Approved by: re@ Revision Changes Path 1.280 +1 -1 src/sys/dev/ata/ata-all.c 1.201 +2 -0 src/sys/dev/ata/ata-chipset.c 1.80 +1 -0 src/sys/dev/ata/ata-pci.h From owner-cvs-src@FreeBSD.ORG Thu Oct 4 21:47:11 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D84A316A469; Thu, 4 Oct 2007 21:47:11 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 5F7E213C465; Thu, 4 Oct 2007 21:47:11 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 212944590-1834499 for multiple; Thu, 04 Oct 2007 17:46:54 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l94Lkcmo045765; Thu, 4 Oct 2007 17:46:42 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Jeff Roberson Date: Thu, 4 Oct 2007 12:19:12 -0400 User-Agent: KMail/1.9.6 References: <200710032106.l93L65bv095725@repoman.freebsd.org> <20071003164642.B615@10.0.0.1> In-Reply-To: <20071003164642.B615@10.0.0.1> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200710041219.13202.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 04 Oct 2007 17:46:42 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4472/Thu Oct 4 10:45:39 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-3.7 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00, DATE_IN_PAST_03_06,SUBJ_HAS_SPACES autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/fs/devfs devfs_vnops.c src/sys/fs/fifofs fifo_vnops.c src/sys/kern uipc_usrreq.c vfs_vnops.c src/sys/vm vnode_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 21:47:11 -0000 On Wednesday 03 October 2007 07:48:00 pm Jeff Roberson wrote: > On Wed, 3 Oct 2007, John Baldwin wrote: > > > jhb 2007-10-03 21:06:05 UTC > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_6) > > sys/fs/devfs devfs_vnops.c > > sys/fs/fifofs fifo_vnops.c > > sys/kern uipc_usrreq.c vfs_vnops.c > > sys/vm vnode_pager.c > > Log: > > MFC: Always use an exclusive lock on the leaf vnode during an open() when > > shared lookups are enabled. This closes a few races including a race where > > concurrent opens of a fifo could result in different v_fifoinfo structures > > in different threads. > > Long term we should really look for a better solution to this problem. > There are a number of was to improve snapshots in ffs by fixing shared > locking. I don't disagree. The fifo case can be fixed easily enough in the fifo code by using fifo_mtx to protect v_fifoinfo perhaps (or doing an upgrade on the vnode lock?), but for the MFC I didn't want to have to fix each of the races with open(2). Probably better to fix it more properly in HEAD first. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Thu Oct 4 22:18:53 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E15DD16A41A; Thu, 4 Oct 2007 22:18:53 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DBBD013C48D; Thu, 4 Oct 2007 22:18:53 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l94MIrUw000114; Thu, 4 Oct 2007 22:18:53 GMT (envelope-from se@repoman.freebsd.org) Received: (from se@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l94MIr8P000113; Thu, 4 Oct 2007 22:18:53 GMT (envelope-from se) Message-Id: <200710042218.l94MIr8P000113@repoman.freebsd.org> From: Stefan Esser Date: Thu, 4 Oct 2007 22:18:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/pciconf pciconf.8 pciconf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 22:18:54 -0000 se 2007-10-04 22:18:53 UTC FreeBSD src repository Modified files: usr.sbin/pciconf pciconf.8 pciconf.c Log: Restore compatibility with version before introduction of PCI domains. PCI selectors with 2 or 3 elements behave exactly as before (i.e. the domain is 0 and in the 2 element case, the function is also 0). The form with 4 selector elements works as in the previous revision and provides the PCI domain number as the left-most selector element. This change allows old scripts (which used the 2 or 3 selector element formats) to be kept. Without this patch, the 3 element form was parsed as starting with a domain number (and the function was assumed to be 0), with this patch, the domain is assumed to be 0 (and the last value is used as the function number). The man page is updated to describe the new selector semantics. Approved by: re (Ken Smith) Revision Changes Path 1.30 +6 -4 src/usr.sbin/pciconf/pciconf.8 1.29 +16 -14 src/usr.sbin/pciconf/pciconf.c From owner-cvs-src@FreeBSD.ORG Thu Oct 4 22:27:09 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0F85D16A468; Thu, 4 Oct 2007 22:27:09 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E4E7513C4A7; Thu, 4 Oct 2007 22:27:08 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l94MR8io000744; Thu, 4 Oct 2007 22:27:08 GMT (envelope-from se@repoman.freebsd.org) Received: (from se@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l94MR8m2000743; Thu, 4 Oct 2007 22:27:08 GMT (envelope-from se) Message-Id: <200710042227.l94MR8m2000743@repoman.freebsd.org> From: Stefan Esser Date: Thu, 4 Oct 2007 22:27:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/pciconf pciconf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2007 22:27:09 -0000 se 2007-10-04 22:27:08 UTC FreeBSD src repository Modified files: usr.sbin/pciconf pciconf.c Log: Make selector parsing accept the dot "." as an alternative selector with identical meaning as the colon ":". This is to support a syntax that is more similar to a PCI device specification in the device hints file. The selector is not fully compatible with the specification in the hints file, since entries in that file use a different prefix, which needs to be added to the getsel() routine, if full support of that syntax is found to be desirable. Approved by: re (Ken Smith) Revision Changes Path 1.30 +1 -1 src/usr.sbin/pciconf/pciconf.c From owner-cvs-src@FreeBSD.ORG Fri Oct 5 01:26:39 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0638316A420; Fri, 5 Oct 2007 01:26:39 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com [216.240.101.25]) by mx1.freebsd.org (Postfix) with ESMTP id C514E13C507; Fri, 5 Oct 2007 01:26:38 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from [192.168.1.103] (c-67-160-44-208.hsd1.wa.comcast.net [67.160.44.208]) (authenticated bits=0) by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id l951QaQs090135 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO); Thu, 4 Oct 2007 21:26:37 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Thu, 4 Oct 2007 18:29:25 -0700 (PDT) From: Jeff Roberson X-X-Sender: jroberson@10.0.0.1 To: John Baldwin In-Reply-To: <200710041219.13202.jhb@freebsd.org> Message-ID: <20071004182759.U912@10.0.0.1> References: <200710032106.l93L65bv095725@repoman.freebsd.org> <20071003164642.B615@10.0.0.1> <200710041219.13202.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/devfs devfs_vnops.c src/sys/fs/fifofs fifo_vnops.c src/sys/kern uipc_usrreq.c vfs_vnops.c src/sys/vm vnode_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2007 01:26:39 -0000 On Thu, 4 Oct 2007, John Baldwin wrote: > On Wednesday 03 October 2007 07:48:00 pm Jeff Roberson wrote: >> On Wed, 3 Oct 2007, John Baldwin wrote: >> >>> jhb 2007-10-03 21:06:05 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: (Branch: RELENG_6) >>> sys/fs/devfs devfs_vnops.c >>> sys/fs/fifofs fifo_vnops.c >>> sys/kern uipc_usrreq.c vfs_vnops.c >>> sys/vm vnode_pager.c >>> Log: >>> MFC: Always use an exclusive lock on the leaf vnode during an open() when >>> shared lookups are enabled. This closes a few races including a race > where >>> concurrent opens of a fifo could result in different v_fifoinfo > structures >>> in different threads. >> >> Long term we should really look for a better solution to this problem. >> There are a number of was to improve snapshots in ffs by fixing shared >> locking. > > I don't disagree. The fifo case can be fixed easily enough in the fifo code > by using fifo_mtx to protect v_fifoinfo perhaps (or doing an upgrade on the > vnode lock?), but for the MFC I didn't want to have to fix each of the races > with open(2). Probably better to fix it more properly in HEAD first. Definitely someting for head. Were there any others that you ran into besides v_fifoinfo? We should audit this more closely anyhow. I have been reluctant to push too much shared locking into VFS because it's not been so carefully studied. Jeff > > -- > John Baldwin > From owner-cvs-src@FreeBSD.ORG Fri Oct 5 07:06:52 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BE05616A46D; Fri, 5 Oct 2007 07:06:52 +0000 (UTC) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8A38813C44B; Fri, 5 Oct 2007 07:06:52 +0000 (UTC) (envelope-from brueffer@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9576qo0058364; Fri, 5 Oct 2007 07:06:52 GMT (envelope-from brueffer@repoman.freebsd.org) Received: (from brueffer@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9576qhp058363; Fri, 5 Oct 2007 07:06:52 GMT (envelope-from brueffer) Message-Id: <200710050706.l9576qhp058363@repoman.freebsd.org> From: Christian Brueffer Date: Fri, 5 Oct 2007 07:06:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 ata.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2007 07:06:52 -0000 brueffer 2007-10-05 07:06:52 UTC FreeBSD src repository Modified files: share/man/man4 ata.4 Log: AMD CS5536 and VIA 8237S support. Approved by: re (blanket) Revision Changes Path 1.74 +3 -3 src/share/man/man4/ata.4 From owner-cvs-src@FreeBSD.ORG Fri Oct 5 07:26:41 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1FCCB16A468; Fri, 5 Oct 2007 07:26:41 +0000 (UTC) (envelope-from luigi@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 03B7413C4A7; Fri, 5 Oct 2007 07:26:41 +0000 (UTC) (envelope-from luigi@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l957Qefo059384; Fri, 5 Oct 2007 07:26:40 GMT (envelope-from luigi@repoman.freebsd.org) Received: (from luigi@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l957QeMI059383; Fri, 5 Oct 2007 07:26:40 GMT (envelope-from luigi) Message-Id: <200710050726.l957QeMI059383@repoman.freebsd.org> From: Luigi Rizzo Date: Fri, 5 Oct 2007 07:26:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb usbdevs uscanner.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2007 07:26:41 -0000 luigi 2007-10-05 07:26:40 UTC FreeBSD src repository Modified files: sys/dev/usb usbdevs uscanner.c Log: Add entries for Epson multifunction scanner/printer/card readers, with all functions supported. This is done adding usb device IDs to the table of recognised devices (because there is no standard 'scanner' class, so no other way to recognise them), and with a small change to the uscanner attach routine that prevents reconfiguring the whole USB device while we are dealing only with one of its USB interfaces. The latter part has been suggested by Steinar Hamre in http://www.freebsd.org/cgi/query-pr.cgi?pr=107665 , i have only added a bit of explaination to the code. I have personally tried this on the Epson DX-5050 and DX-6000 devices (on the US market they have different names, CX-something). I have good reasons to think that, possibly with the mere addition of more USB ids to the table in uscanner.c, this should work with all Epson multifunction devices in that family (from DX-3800 to DX-7000 - these units are in the 50-120$ price range). More details on related topics (SANE configuration, OCR, etc.) at http://info.iet.unipi.it/~luigi/FreeBSD/dx5050.html Manpage updates coming soon. Approved by: re, imp MFC after: 3 days Revision Changes Path 1.328 +2 -0 src/sys/dev/usb/usbdevs 1.89 +36 -6 src/sys/dev/usb/uscanner.c From owner-cvs-src@FreeBSD.ORG Fri Oct 5 07:54:09 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A76C116A418; Fri, 5 Oct 2007 07:54:09 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id F100913C459; Fri, 5 Oct 2007 07:54:08 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 71D8045F57; Fri, 5 Oct 2007 09:32:18 +0200 (CEST) Received: from localhost (154.81.datacomsa.pl [195.34.81.154]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 1F3DB45F42; Fri, 5 Oct 2007 09:32:14 +0200 (CEST) Date: Fri, 5 Oct 2007 09:32:02 +0200 From: Pawel Jakub Dawidek To: Jeff Roberson Message-ID: <20071005073202.GA94586@garage.freebsd.pl> References: <200710032106.l93L65bv095725@repoman.freebsd.org> <20071003164642.B615@10.0.0.1> <200710041219.13202.jhb@freebsd.org> <20071004182759.U912@10.0.0.1> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Q68bSM7Ycu6FN28Q" Content-Disposition: inline In-Reply-To: <20071004182759.U912@10.0.0.1> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00 autolearn=ham version=3.0.4 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, John Baldwin Subject: Re: cvs commit: src/sys/fs/devfs devfs_vnops.c src/sys/fs/fifofs fifo_vnops.c src/sys/kern uipc_usrreq.c vfs_vnops.c src/sys/vm vnode_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2007 07:54:09 -0000 --Q68bSM7Ycu6FN28Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 04, 2007 at 06:29:25PM -0700, Jeff Roberson wrote: > On Thu, 4 Oct 2007, John Baldwin wrote: >=20 > >On Wednesday 03 October 2007 07:48:00 pm Jeff Roberson wrote: > >>On Wed, 3 Oct 2007, John Baldwin wrote: > >> > >>>jhb 2007-10-03 21:06:05 UTC > >>> > >>> FreeBSD src repository > >>> > >>> Modified files: (Branch: RELENG_6) > >>> sys/fs/devfs devfs_vnops.c > >>> sys/fs/fifofs fifo_vnops.c > >>> sys/kern uipc_usrreq.c vfs_vnops.c > >>> sys/vm vnode_pager.c > >>> Log: > >>> MFC: Always use an exclusive lock on the leaf vnode during an open()= =20 > >>> when > >>> shared lookups are enabled. This closes a few races including a race > >where > >>> concurrent opens of a fifo could result in different v_fifoinfo > >structures > >>> in different threads. > >> > >>Long term we should really look for a better solution to this problem. > >>There are a number of was to improve snapshots in ffs by fixing shared > >>locking. > > > >I don't disagree. The fifo case can be fixed easily enough in the fifo= =20 > >code > >by using fifo_mtx to protect v_fifoinfo perhaps (or doing an upgrade on = the > >vnode lock?), but for the MFC I didn't want to have to fix each of the= =20 > >races > >with open(2). Probably better to fix it more properly in HEAD first. >=20 > Definitely someting for head. Were there any others that you ran into=20 > besides v_fifoinfo? We should audit this more closely anyhow. I have=20 > been reluctant to push too much shared locking into VFS because it's not= =20 > been so carefully studied. You probably talking about my patch. I agree, but there are many inconsistencies. People tend to use exclusive locking everywhere. We could start from converting places where sometimes we use shared locking and sometimes exclusive, eg. VOP_READ(), VOP_GETATTR(), etc. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --Q68bSM7Ycu6FN28Q Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHBehyForvXbEpPzQRAi/UAKDZ8XfXJoG2A5iDl7tGaNCsnqKkWACgwez7 E6TTVa+ymrZg74FHnX7DBCk= =dh7V -----END PGP SIGNATURE----- --Q68bSM7Ycu6FN28Q-- From owner-cvs-src@FreeBSD.ORG Fri Oct 5 15:17:15 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 98F8816A4D7; Fri, 5 Oct 2007 15:17:15 +0000 (UTC) (envelope-from luigi@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 68B0513C467; Fri, 5 Oct 2007 15:17:15 +0000 (UTC) (envelope-from luigi@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l95FHFZc017984; Fri, 5 Oct 2007 15:17:15 GMT (envelope-from luigi@repoman.freebsd.org) Received: (from luigi@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l95FHFvF017983; Fri, 5 Oct 2007 15:17:15 GMT (envelope-from luigi) Message-Id: <200710051517.l95FHFvF017983@repoman.freebsd.org> From: Luigi Rizzo Date: Fri, 5 Oct 2007 15:17:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 uscanner.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2007 15:17:15 -0000 luigi 2007-10-05 15:17:14 UTC FreeBSD src repository Modified files: share/man/man4 uscanner.4 Log: manpage update for the recent commit to uscanner.c I also took the chance to make the list of supported devices a bit more compact, as it was really long to read. Even though re@ and Warner only saw the diffs for the code, i expect their approval also covered the manpage update. Approved by: re, imp (implicitly i hope) MFC after: 3 days Revision Changes Path 1.31 +52 -194 src/share/man/man4/uscanner.4 From owner-cvs-src@FreeBSD.ORG Fri Oct 5 15:22:37 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 77D9E16A421; Fri, 5 Oct 2007 15:22:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5D31C13C4C5; Fri, 5 Oct 2007 15:22:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l95FMb70018526; Fri, 5 Oct 2007 15:22:37 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l95FMbtZ018525; Fri, 5 Oct 2007 15:22:37 GMT (envelope-from jhb) Message-Id: <200710051522.l95FMbtZ018525@repoman.freebsd.org> From: John Baldwin Date: Fri, 5 Oct 2007 15:22:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/amd64/acpica madt.c src/sys/amd64/amd64 local_apic.c mp_machdep.c mptable.c src/sys/amd64/include apicvar.h src/sys/i386/acpica madt.c src/sys/i386/i386 local_apic.c mp_machdep.c mptable.c src/sys/i386/include apicvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2007 15:22:37 -0000 jhb 2007-10-05 15:22:37 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/amd64/acpica madt.c sys/amd64/amd64 local_apic.c mp_machdep.c mptable.c sys/amd64/include apicvar.h sys/i386/acpica madt.c sys/i386/i386 local_apic.c mp_machdep.c mptable.c sys/i386/include apicvar.h Log: MFC: Handle CPUs with APIC IDs higher than 32. Revision Changes Path 1.16.2.4 +7 -10 src/sys/amd64/acpica/madt.c 1.17.2.14 +2 -9 src/sys/amd64/amd64/local_apic.c 1.260.2.13 +57 -30 src/sys/amd64/amd64/mp_machdep.c 1.236.2.1 +15 -13 src/sys/amd64/amd64/mptable.c 1.13.2.6 +1 -0 src/sys/amd64/include/apicvar.h 1.19.2.4 +7 -10 src/sys/i386/acpica/madt.c 1.17.2.14 +2 -9 src/sys/i386/i386/local_apic.c 1.252.2.12 +55 -27 src/sys/i386/i386/mp_machdep.c 1.241.2.1 +10 -8 src/sys/i386/i386/mptable.c 1.13.2.6 +1 -0 src/sys/i386/include/apicvar.h From owner-cvs-src@FreeBSD.ORG Fri Oct 5 17:37:26 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1C82216A41A; Fri, 5 Oct 2007 17:37:26 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E1F5D13C48E; Fri, 5 Oct 2007 17:37:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l95HbP0I038862; Fri, 5 Oct 2007 17:37:25 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l95HbPFa038861; Fri, 5 Oct 2007 17:37:25 GMT (envelope-from jhb) Message-Id: <200710051737.l95HbPFa038861@repoman.freebsd.org> From: John Baldwin Date: Fri, 5 Oct 2007 17:37:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/pseudofs pseudofs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2007 17:37:26 -0000 jhb 2007-10-05 17:37:25 UTC FreeBSD src repository Modified files: sys/fs/pseudofs pseudofs_vnops.c Log: Use the correct pid when checking to see whether or not the /proc/ directory itself (rather than any of its contents) is visible to the current thread. MFC after: 1 week PR: kern/90063 Submitted by: john of 8192.net Approved by: re (kensmith) Revision Changes Path 1.65 +1 -1 src/sys/fs/pseudofs/pseudofs_vnops.c From owner-cvs-src@FreeBSD.ORG Fri Oct 5 19:00:29 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EF2B716A468; Fri, 5 Oct 2007 19:00:29 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 77C9913C46A; Fri, 5 Oct 2007 19:00:29 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 213082160-1834499 for multiple; Fri, 05 Oct 2007 15:00:18 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l95J03Il056520; Fri, 5 Oct 2007 15:00:03 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Jeff Roberson Date: Fri, 5 Oct 2007 13:50:39 -0400 User-Agent: KMail/1.9.6 References: <200710032106.l93L65bv095725@repoman.freebsd.org> <200710041219.13202.jhb@freebsd.org> <20071004182759.U912@10.0.0.1> In-Reply-To: <20071004182759.U912@10.0.0.1> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200710051350.39581.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 05 Oct 2007 15:00:03 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4480/Fri Oct 5 10:51:39 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-3.9 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00, SUBJ_HAS_SPACES autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/fs/devfs devfs_vnops.c src/sys/fs/fifofs fifo_vnops.c src/sys/kern uipc_usrreq.c vfs_vnops.c src/sys/vm vnode_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2007 19:00:30 -0000 On Thursday 04 October 2007 09:29:25 pm Jeff Roberson wrote: > On Thu, 4 Oct 2007, John Baldwin wrote: > > > On Wednesday 03 October 2007 07:48:00 pm Jeff Roberson wrote: > >> On Wed, 3 Oct 2007, John Baldwin wrote: > >> > >>> jhb 2007-10-03 21:06:05 UTC > >>> > >>> FreeBSD src repository > >>> > >>> Modified files: (Branch: RELENG_6) > >>> sys/fs/devfs devfs_vnops.c > >>> sys/fs/fifofs fifo_vnops.c > >>> sys/kern uipc_usrreq.c vfs_vnops.c > >>> sys/vm vnode_pager.c > >>> Log: > >>> MFC: Always use an exclusive lock on the leaf vnode during an open() when > >>> shared lookups are enabled. This closes a few races including a race > > where > >>> concurrent opens of a fifo could result in different v_fifoinfo > > structures > >>> in different threads. > >> > >> Long term we should really look for a better solution to this problem. > >> There are a number of was to improve snapshots in ffs by fixing shared > >> locking. > > > > I don't disagree. The fifo case can be fixed easily enough in the fifo code > > by using fifo_mtx to protect v_fifoinfo perhaps (or doing an upgrade on the > > vnode lock?), but for the MFC I didn't want to have to fix each of the races > > with open(2). Probably better to fix it more properly in HEAD first. > > Definitely someting for head. Were there any others that you ran into > besides v_fifoinfo? We should audit this more closely anyhow. I have > been reluctant to push too much shared locking into VFS because it's not > been so carefully studied. I just saw v_fifoinfo, but Pawel's original commit referenced updates to v_writecount, etc. The v_writecount one is in vn_open() itself: if ((error = VOP_OPEN(vp, fmode, cred, td, fp)) != 0) goto bad; if (fmode & FWRITE) vp->v_writecount++; *flagp = fmode; ASSERT_VOP_ELOCKED(vp, "vn_open_cred"); if (!mpsafe) VFS_UNLOCK_GIANT(vfslocked); return (0); If you just held a shared lock there, you could use atomic ops for vp->v_writecount (and still hold at least a shared vnode lock everywhere v_writecount is updated) and still be able to read vp->v_writecount safely while holding an exclusive lock on the vnode. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Fri Oct 5 19:11:42 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 315A916A417; Fri, 5 Oct 2007 19:11:42 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from gnome.kiev.sovam.com (gnome.kiev.sovam.com [212.109.32.24]) by mx1.freebsd.org (Postfix) with ESMTP id C184A13C43E; Fri, 5 Oct 2007 19:11:41 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay02.kiev.sovam.com ([62.64.120.197]) by gnome.kiev.sovam.com with esmtp (Exim 4.67 (FreeBSD)) (envelope-from ) id 1IdsaK-000OI9-2H; Fri, 05 Oct 2007 22:11:40 +0300 Received: from [212.82.216.226] (helo=deviant.kiev.zoral.com.ua) by relay02.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1IdsaI-000PTD-Kf; Fri, 05 Oct 2007 22:11:39 +0300 Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1) with ESMTP id l95JBYgT007826; Fri, 5 Oct 2007 22:11:34 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1/Submit) id l95JBYUu007825; Fri, 5 Oct 2007 22:11:34 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 5 Oct 2007 22:11:34 +0300 From: Kostik Belousov To: John Baldwin Message-ID: <20071005191134.GA2180@deviant.kiev.zoral.com.ua> References: <200710032106.l93L65bv095725@repoman.freebsd.org> <200710041219.13202.jhb@freebsd.org> <20071004182759.U912@10.0.0.1> <200710051350.39581.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="azLHFNyN32YCQGCU" Content-Disposition: inline In-Reply-To: <200710051350.39581.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i X-Scanner-Signature: 9596209fecb99bc4db4bd854cc333b75 X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Info: Profiles 1563 [Oct 05 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {TO: local part of email appears in body} X-SpamTest-Info: {received from trusted relay: not dialup} X-SpamTest-Method: none X-SpamTest-Method: Local Lists X-SpamTest-Rate: 10 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release Cc: Jeff Roberson , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/fs/devfs devfs_vnops.c src/sys/fs/fifofs fifo_vnops.c src/sys/kern uipc_usrreq.c vfs_vnops.c src/sys/vm vnode_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2007 19:11:42 -0000 --azLHFNyN32YCQGCU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 05, 2007 at 01:50:39PM -0400, John Baldwin wrote: > On Thursday 04 October 2007 09:29:25 pm Jeff Roberson wrote: > > On Thu, 4 Oct 2007, John Baldwin wrote: > >=20 > > > On Wednesday 03 October 2007 07:48:00 pm Jeff Roberson wrote: > > >> On Wed, 3 Oct 2007, John Baldwin wrote: > > >> > > >>> jhb 2007-10-03 21:06:05 UTC > > >>> > > >>> FreeBSD src repository > > >>> > > >>> Modified files: (Branch: RELENG_6) > > >>> sys/fs/devfs devfs_vnops.c > > >>> sys/fs/fifofs fifo_vnops.c > > >>> sys/kern uipc_usrreq.c vfs_vnops.c > > >>> sys/vm vnode_pager.c > > >>> Log: > > >>> MFC: Always use an exclusive lock on the leaf vnode during an open= ()=20 > when > > >>> shared lookups are enabled. This closes a few races including a r= ace > > > where > > >>> concurrent opens of a fifo could result in different v_fifoinfo > > > structures > > >>> in different threads. > > >> > > >> Long term we should really look for a better solution to this proble= m. > > >> There are a number of was to improve snapshots in ffs by fixing shar= ed > > >> locking. > > > > > > I don't disagree. The fifo case can be fixed easily enough in the fi= fo=20 > code > > > by using fifo_mtx to protect v_fifoinfo perhaps (or doing an upgrade = on=20 > the > > > vnode lock?), but for the MFC I didn't want to have to fix each of th= e=20 > races > > > with open(2). Probably better to fix it more properly in HEAD first. > >=20 > > Definitely someting for head. Were there any others that you ran into= =20 > > besides v_fifoinfo? We should audit this more closely anyhow. I have= =20 > > been reluctant to push too much shared locking into VFS because it's no= t=20 > > been so carefully studied. >=20 > I just saw v_fifoinfo, but Pawel's original commit referenced updates to > v_writecount, etc. The v_writecount one is in vn_open() itself: >=20 > if ((error =3D VOP_OPEN(vp, fmode, cred, td, fp)) !=3D 0) > goto bad; >=20 > if (fmode & FWRITE) > vp->v_writecount++; > *flagp =3D fmode; > ASSERT_VOP_ELOCKED(vp, "vn_open_cred"); > if (!mpsafe) > VFS_UNLOCK_GIANT(vfslocked); > return (0); >=20 > If you just held a shared lock there, you could use atomic ops for=20 > vp->v_writecount (and still hold at least a shared vnode lock everywhere= =20 > v_writecount is updated) and still be able to read vp->v_writecount safel= y=20 > while holding an exclusive lock on the vnode. Another is the vm/vnode_pager.c handling of the v_object. --azLHFNyN32YCQGCU Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHBoxlC3+MBN1Mb4gRAqH2AJ9niEBYlR9SKGUgmIDChfVlhg9RnQCePY+k ww4Jedi/GQ4M2FxzZ5abWqY= =8UIa -----END PGP SIGNATURE----- --azLHFNyN32YCQGCU-- From owner-cvs-src@FreeBSD.ORG Fri Oct 5 22:39:45 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 16A0416A41A; Fri, 5 Oct 2007 22:39:45 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E30B313C4A5; Fri, 5 Oct 2007 22:39:44 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l95Mdido071165; Fri, 5 Oct 2007 22:39:44 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l95MdiVW071164; Fri, 5 Oct 2007 22:39:44 GMT (envelope-from rwatson) Message-Id: <200710052239.l95MdiVW071164@repoman.freebsd.org> From: Robert Watson Date: Fri, 5 Oct 2007 22:39:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet tcp_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2007 22:39:45 -0000 rwatson 2007-10-05 22:39:44 UTC FreeBSD src repository Modified files: sys/netinet tcp_subr.c Log: Disable TCP syncache debug logging by default. While useful in debugging problems with the syncache, it produces a lot of console noise and has led to quite a few false positive bug reports. It can be selectively re-enabled when debugging specific problems by frobbing the same sysctl. Discussed with: silby Approved by: re (gnn) Revision Changes Path 1.299 +1 -1 src/sys/netinet/tcp_subr.c From owner-cvs-src@FreeBSD.ORG Fri Oct 5 22:49:09 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3BE3316A41A; Fri, 5 Oct 2007 22:49:09 +0000 (UTC) (envelope-from jfv@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2892513C469; Fri, 5 Oct 2007 22:49:09 +0000 (UTC) (envelope-from jfv@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l95Mn9FO071853; Fri, 5 Oct 2007 22:49:09 GMT (envelope-from jfv@repoman.freebsd.org) Received: (from jfv@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l95Mn9Nb071852; Fri, 5 Oct 2007 22:49:09 GMT (envelope-from jfv) Message-Id: <200710052249.l95Mn9Nb071852@repoman.freebsd.org> From: Jack F Vogel Date: Fri, 5 Oct 2007 22:49:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/em LICENSE e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2007 22:49:09 -0000 jfv 2007-10-05 22:49:09 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/conf files kern.pre.mk sys/dev/em LICENSE if_em.c if_em.h sys/modules/em Makefile Added files: (Branch: RELENG_6) sys/dev/em e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c e1000_82575.h e1000_api.c e1000_api.h e1000_defines.h e1000_hw.h e1000_ich8lan.c e1000_ich8lan.h e1000_mac.c e1000_mac.h e1000_manage.c e1000_manage.h e1000_nvm.c e1000_nvm.h e1000_osdep.h e1000_phy.c e1000_phy.h e1000_regs.h Removed files: (Branch: RELENG_6) sys/dev/em if_em_hw.c if_em_hw.h if_em_osdep.h Log: MFC of Intel driver version 6.6.6 This adds our new modular shared code, support for MSI/MSIX, hardware support for newer adapters, and a variety of bug fixes. Revision Changes Path 1.1031.2.69 +28 -2 src/sys/conf/files 1.65.2.5 +6 -0 src/sys/conf/kern.pre.mk 1.3.2.2 +1 -1 src/sys/dev/em/LICENSE 1.3.2.1 +1347 -0 src/sys/dev/em/e1000_80003es2lan.c (new) 1.3.2.1 +102 -0 src/sys/dev/em/e1000_80003es2lan.h (new) 1.3.2.1 +670 -0 src/sys/dev/em/e1000_82540.c (new) 1.3.2.1 +1318 -0 src/sys/dev/em/e1000_82541.c (new) 1.3.2.1 +91 -0 src/sys/dev/em/e1000_82541.h (new) 1.3.2.1 +552 -0 src/sys/dev/em/e1000_82542.c (new) 1.3.2.1 +1660 -0 src/sys/dev/em/e1000_82543.c (new) 1.3.2.1 +51 -0 src/sys/dev/em/e1000_82543.h (new) 1.3.2.1 +1414 -0 src/sys/dev/em/e1000_82571.c (new) 1.3.2.1 +47 -0 src/sys/dev/em/e1000_82571.h (new) 1.3.2.1 +1421 -0 src/sys/dev/em/e1000_82575.c (new) 1.3.2.1 +314 -0 src/sys/dev/em/e1000_82575.h (new) 1.3.2.1 +1162 -0 src/sys/dev/em/e1000_api.c (new) 1.3.2.1 +165 -0 src/sys/dev/em/e1000_api.h (new) 1.3.2.1 +1405 -0 src/sys/dev/em/e1000_defines.h (new) 1.3.2.1 +724 -0 src/sys/dev/em/e1000_hw.h (new) 1.3.2.1 +2522 -0 src/sys/dev/em/e1000_ich8lan.c (new) 1.3.2.1 +116 -0 src/sys/dev/em/e1000_ich8lan.h (new) 1.3.2.1 +2060 -0 src/sys/dev/em/e1000_mac.c (new) 1.3.2.1 +93 -0 src/sys/dev/em/e1000_mac.h (new) 1.3.2.1 +391 -0 src/sys/dev/em/e1000_manage.c (new) 1.3.2.1 +88 -0 src/sys/dev/em/e1000_manage.h (new) 1.3.2.1 +900 -0 src/sys/dev/em/e1000_nvm.c (new) 1.3.2.1 +66 -0 src/sys/dev/em/e1000_nvm.h (new) 1.3.2.1 +189 -0 src/sys/dev/em/e1000_osdep.h (new) 1.3.2.1 +2079 -0 src/sys/dev/em/e1000_phy.c (new) 1.3.2.1 +177 -0 src/sys/dev/em/e1000_phy.h (new) 1.3.2.1 +306 -0 src/sys/dev/em/e1000_regs.h (new) 1.65.2.24 +1827 -836 src/sys/dev/em/if_em.c 1.32.2.7 +103 -113 src/sys/dev/em/if_em.h 1.16.2.5 +0 -9147 src/sys/dev/em/if_em_hw.c (dead) 1.15.2.6 +0 -3378 src/sys/dev/em/if_em_hw.h (dead) 1.14.2.4 +0 -171 src/sys/dev/em/if_em_osdep.h (dead) 1.4.6.1 +17 -5 src/sys/modules/em/Makefile From owner-cvs-src@FreeBSD.ORG Fri Oct 5 22:50:47 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4ABFA16A46D; Fri, 5 Oct 2007 22:50:47 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id CC79613C480; Fri, 5 Oct 2007 22:50:46 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l95MokO5071990; Fri, 5 Oct 2007 22:50:46 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l95Mok8i071989; Fri, 5 Oct 2007 22:50:46 GMT (envelope-from marius) Message-Id: <200710052250.l95Mok8i071989@repoman.freebsd.org> From: Marius Strobl Date: Fri, 5 Oct 2007 22:50:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man9 Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2007 22:50:47 -0000 marius 2007-10-05 22:50:45 UTC FreeBSD src repository Modified files: share/man/man9 Makefile Log: Add an MLINKS for pci_find_dbsf.9. Submitted by: ru Approved by: re (gnn) Revision Changes Path 1.310 +1 -0 src/share/man/man9/Makefile From owner-cvs-src@FreeBSD.ORG Fri Oct 5 23:30:44 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A0D6816A418 for ; Fri, 5 Oct 2007 23:30:44 +0000 (UTC) (envelope-from erikt@midgard.homeip.net) Received: from ch-smtp02.sth.basefarm.net (ch-smtp02.sth.basefarm.net [80.76.149.213]) by mx1.freebsd.org (Postfix) with ESMTP id 2569E13C4A7 for ; Fri, 5 Oct 2007 23:30:43 +0000 (UTC) (envelope-from erikt@midgard.homeip.net) Received: from c83-253-31-60.bredband.comhem.se ([83.253.31.60]:59658 helo=falcon.midgard.homeip.net) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.66) (envelope-from ) id 1IdwOS-0005Vt-8A for cvs-src@FreeBSD.org; Sat, 06 Oct 2007 01:15:40 +0200 Received: (qmail 11530 invoked from network); 6 Oct 2007 01:15:38 +0200 Received: from owl.midgard.homeip.net (10.1.5.7) by falcon.midgard.homeip.net with ESMTP; 6 Oct 2007 01:15:38 +0200 Received: (qmail 24140 invoked by uid 1001); 6 Oct 2007 01:15:38 +0200 Date: Sat, 6 Oct 2007 01:15:38 +0200 From: Erik Trulsson To: Jack F Vogel Message-ID: <20071005231538.GA24016@owl.midgard.homeip.net> Mail-Followup-To: Jack F Vogel , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200710052249.l95Mn9Nb071852@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200710052249.l95Mn9Nb071852@repoman.freebsd.org> User-Agent: Mutt/1.5.16 (2007-06-09) X-Originating-IP: 83.253.31.60 X-Scan-Result: No virus found in message 1IdwOS-0005Vt-8A. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1IdwOS-0005Vt-8A 68b7f4518578a30b9663a82de1d22a58 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/em LICENSE e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2007 23:30:44 -0000 On Fri, Oct 05, 2007 at 10:49:09PM +0000, Jack F Vogel wrote: > jfv 2007-10-05 22:49:09 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/conf files kern.pre.mk > sys/dev/em LICENSE if_em.c if_em.h > sys/modules/em Makefile > Added files: (Branch: RELENG_6) > sys/dev/em e1000_80003es2lan.c e1000_80003es2lan.h > e1000_82540.c e1000_82541.c e1000_82541.h > e1000_82542.c e1000_82543.c e1000_82543.h > e1000_82571.c e1000_82571.h e1000_82575.c > e1000_82575.h e1000_api.c e1000_api.h > e1000_defines.h e1000_hw.h > e1000_ich8lan.c e1000_ich8lan.h > e1000_mac.c e1000_mac.h e1000_manage.c > e1000_manage.h e1000_nvm.c e1000_nvm.h > e1000_osdep.h e1000_phy.c e1000_phy.h > e1000_regs.h > Removed files: (Branch: RELENG_6) > sys/dev/em if_em_hw.c if_em_hw.h if_em_osdep.h > Log: > MFC of Intel driver version 6.6.6 > This adds our new modular shared code, support for MSI/MSIX, hardware > support for newer adapters, and a variety of bug fixes. Am I right in thinking that this code is actually newer than the code in -CURRENT (which seems to be version 6.5.3) ? If this is indeed the case, then shouldn't this code have gone into -CURRENT first? -- Erik Trulsson ertr1013@student.uu.se From owner-cvs-src@FreeBSD.ORG Sat Oct 6 00:34:01 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7F5F616A419 for ; Sat, 6 Oct 2007 00:34:01 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mu-out-0910.google.com (mu-out-0910.google.com [209.85.134.186]) by mx1.freebsd.org (Postfix) with ESMTP id E9CA513C467 for ; Sat, 6 Oct 2007 00:34:00 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by mu-out-0910.google.com with SMTP id w9so767141mue for ; Fri, 05 Oct 2007 17:33:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=g36qp+6s2kH3XSNm9DGkgPlVT5ohERyZC4TybG4HzwY=; b=pMDk1+0CNYZREgWdPZOSILgsGjjT1rV8GgQJOq/pw0NxYCPt1iUIoH1oNoq2lCp7Un1BoVOCTUL9jYOvmhZR6cODzp7mJ6eaCcCGX0XLagnDy3oVniVK48pEZu5e1CI78pI5Mqt83JSiBp7BuxvhS+Pyx15ecMOIGGvL9ipvKuI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=lFdOTY9geTO+4UQQULEwH6jcWn03XSvaQ8OXnpXPIgnbeCrARBm0NeBTwk+kAHunjJGC16ysRfkBdMtbofVy8VOnie86qMBDtavsQEy6tTMPi7xHcsbIaeFfgUWAPTTB36n80yAZOILXtll7g6s3J1rEsD2EGK8kwT6etfbepww= Received: by 10.86.98.18 with SMTP id v18mr2879911fgb.1191629105108; Fri, 05 Oct 2007 17:05:05 -0700 (PDT) Received: by 10.86.100.19 with HTTP; Fri, 5 Oct 2007 17:05:05 -0700 (PDT) Message-ID: <2a41acea0710051705l217224b6vc705dc6139b94e3b@mail.gmail.com> Date: Fri, 5 Oct 2007 17:05:05 -0700 From: "Jack Vogel" To: "Jack F Vogel" , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org In-Reply-To: <20071005231538.GA24016@owl.midgard.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200710052249.l95Mn9Nb071852@repoman.freebsd.org> <20071005231538.GA24016@owl.midgard.homeip.net> Cc: Subject: Re: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/em LICENSE e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 00:34:01 -0000 On 10/5/07, Erik Trulsson wrote: > On Fri, Oct 05, 2007 at 10:49:09PM +0000, Jack F Vogel wrote: > > jfv 2007-10-05 22:49:09 UTC > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_6) > > sys/conf files kern.pre.mk > > sys/dev/em LICENSE if_em.c if_em.h > > sys/modules/em Makefile > > Added files: (Branch: RELENG_6) > > sys/dev/em e1000_80003es2lan.c e1000_80003es2lan.h > > e1000_82540.c e1000_82541.c e1000_82541.h > > e1000_82542.c e1000_82543.c e1000_82543.h > > e1000_82571.c e1000_82571.h e1000_82575.c > > e1000_82575.h e1000_api.c e1000_api.h > > e1000_defines.h e1000_hw.h > > e1000_ich8lan.c e1000_ich8lan.h > > e1000_mac.c e1000_mac.h e1000_manage.c > > e1000_manage.h e1000_nvm.c e1000_nvm.h > > e1000_osdep.h e1000_phy.c e1000_phy.h > > e1000_regs.h > > Removed files: (Branch: RELENG_6) > > sys/dev/em if_em_hw.c if_em_hw.h if_em_osdep.h > > Log: > > MFC of Intel driver version 6.6.6 > > This adds our new modular shared code, support for MSI/MSIX, hardware > > support for newer adapters, and a variety of bug fixes. > > Am I right in thinking that this code is actually newer than the code > in -CURRENT (which seems to be version 6.5.3) ? If this is indeed the > case, then shouldn't this code have gone into -CURRENT first? Yes, it is newer, the reason for this is the delta between what CURRENT has and this is small, and I did not want to impact CURRENT while its frozen getting ready for release. That delta between CURRENT and this is also not just some hacking of mine, its from my Intel release that has gone thru a whole test/validation and bug fix period of months. I would actually have liked to update BOTH CURRENT and STABLE with this but I was holding off on CURRENT because there are no critical bug fixes it doesnt have, and its about to be made into a release. Cheers, Jack From owner-cvs-src@FreeBSD.ORG Sat Oct 6 00:46:45 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8BCDD16A418 for ; Sat, 6 Oct 2007 00:46:45 +0000 (UTC) (envelope-from erikt@midgard.homeip.net) Received: from ch-smtp01.sth.basefarm.net (ch-smtp01.sth.basefarm.net [80.76.149.212]) by mx1.freebsd.org (Postfix) with ESMTP id 1554813C457 for ; Sat, 6 Oct 2007 00:46:45 +0000 (UTC) (envelope-from erikt@midgard.homeip.net) Received: from c83-253-31-60.bredband.comhem.se ([83.253.31.60]:53548 helo=falcon.midgard.homeip.net) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.66) (envelope-from ) id 1IdxoV-00050Q-3X for cvs-src@freebsd.org; Sat, 06 Oct 2007 02:46:39 +0200 Received: (qmail 11996 invoked from network); 6 Oct 2007 02:46:34 +0200 Received: from owl.midgard.homeip.net (10.1.5.7) by falcon.midgard.homeip.net with ESMTP; 6 Oct 2007 02:46:34 +0200 Received: (qmail 25020 invoked by uid 1001); 6 Oct 2007 02:46:34 +0200 Date: Sat, 6 Oct 2007 02:46:34 +0200 From: Erik Trulsson To: Jack Vogel Message-ID: <20071006004634.GA24962@owl.midgard.homeip.net> Mail-Followup-To: Jack Vogel , Jack F Vogel , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200710052249.l95Mn9Nb071852@repoman.freebsd.org> <20071005231538.GA24016@owl.midgard.homeip.net> <2a41acea0710051705l217224b6vc705dc6139b94e3b@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2a41acea0710051705l217224b6vc705dc6139b94e3b@mail.gmail.com> User-Agent: Mutt/1.5.16 (2007-06-09) X-Originating-IP: 83.253.31.60 X-Scan-Result: No virus found in message 1IdxoV-00050Q-3X. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1IdxoV-00050Q-3X a26161bee83d9e0e95e58e304fc194a4 Cc: Jack F Vogel , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/em LICENSE e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 00:46:45 -0000 On Fri, Oct 05, 2007 at 05:05:05PM -0700, Jack Vogel wrote: > On 10/5/07, Erik Trulsson wrote: > > On Fri, Oct 05, 2007 at 10:49:09PM +0000, Jack F Vogel wrote: > > > jfv 2007-10-05 22:49:09 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: (Branch: RELENG_6) > > > sys/conf files kern.pre.mk > > > sys/dev/em LICENSE if_em.c if_em.h > > > sys/modules/em Makefile > > > Added files: (Branch: RELENG_6) > > > sys/dev/em e1000_80003es2lan.c e1000_80003es2lan.h > > > e1000_82540.c e1000_82541.c e1000_82541.h > > > e1000_82542.c e1000_82543.c e1000_82543.h > > > e1000_82571.c e1000_82571.h e1000_82575.c > > > e1000_82575.h e1000_api.c e1000_api.h > > > e1000_defines.h e1000_hw.h > > > e1000_ich8lan.c e1000_ich8lan.h > > > e1000_mac.c e1000_mac.h e1000_manage.c > > > e1000_manage.h e1000_nvm.c e1000_nvm.h > > > e1000_osdep.h e1000_phy.c e1000_phy.h > > > e1000_regs.h > > > Removed files: (Branch: RELENG_6) > > > sys/dev/em if_em_hw.c if_em_hw.h if_em_osdep.h > > > Log: > > > MFC of Intel driver version 6.6.6 > > > This adds our new modular shared code, support for MSI/MSIX, hardware > > > support for newer adapters, and a variety of bug fixes. > > > > Am I right in thinking that this code is actually newer than the code > > in -CURRENT (which seems to be version 6.5.3) ? If this is indeed the > > case, then shouldn't this code have gone into -CURRENT first? > > Yes, it is newer, the reason for this is the delta between what CURRENT > has and this is small, and I did not want to impact CURRENT while its > frozen getting ready for release. > > That delta between CURRENT and this is also not just some hacking of > mine, its from my Intel release that has gone thru a whole test/validation > and bug fix period of months. > > I would actually have liked to update BOTH CURRENT and STABLE with > this but I was holding off on CURRENT because there are no critical > bug fixes it doesnt have, and its about to be made into a release. As I understand it the policy of FreeBSD is that new stuff *always* should go into -CURRENT first before it is allowed to go into any -STABLE branch. Please see http://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/rules.html -- Erik Trulsson ertr1013@student.uu.se From owner-cvs-src@FreeBSD.ORG Sat Oct 6 03:15:16 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4816616A418; Sat, 6 Oct 2007 03:15:16 +0000 (UTC) (envelope-from scf@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2841913C481; Sat, 6 Oct 2007 03:15:16 +0000 (UTC) (envelope-from scf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l963FGTr001451; Sat, 6 Oct 2007 03:15:16 GMT (envelope-from scf@repoman.freebsd.org) Received: (from scf@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l963FFPJ001450; Sat, 6 Oct 2007 03:15:15 GMT (envelope-from scf) Message-Id: <200710060315.l963FFPJ001450@repoman.freebsd.org> From: Sean Farley Date: Sat, 6 Oct 2007 03:15:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/lib/libc/gen Makefile.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 03:15:16 -0000 scf 2007-10-06 03:15:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libc/gen Makefile.inc Log: MFC: Add fts_set_clientptr(3), fts_get_clientptr(3) and fts_get_stream(3) man page links to fts(3). src/lib/libc/gen/Makefile.inc: rev 1.127 -> 1.128 Approved by: wes Revision Changes Path 1.121.2.2 +2 -1 src/lib/libc/gen/Makefile.inc From owner-cvs-src@FreeBSD.ORG Sat Oct 6 06:15:29 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1E4A616A41B; Sat, 6 Oct 2007 06:15:29 +0000 (UTC) (envelope-from doconnor@gsoft.com.au) Received: from cain.gsoft.com.au (cain.gsoft.com.au [203.31.81.10]) by mx1.freebsd.org (Postfix) with ESMTP id 23C9C13C467; Sat, 6 Oct 2007 06:15:27 +0000 (UTC) (envelope-from doconnor@gsoft.com.au) Received: from inchoate.gsoft.com.au (tjb142812-2.gw.connect.com.au [210.11.105.25]) (authenticated bits=0) by cain.gsoft.com.au (8.13.8/8.13.8) with ESMTP id l96652tN032576 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 6 Oct 2007 15:35:03 +0930 (CST) (envelope-from doconnor@gsoft.com.au) From: "Daniel O'Connor" To: cvs-all@freebsd.org Date: Sat, 6 Oct 2007 15:34:54 +0930 User-Agent: KMail/1.9.7 References: <200710052249.l95Mn9Nb071852@repoman.freebsd.org> <2a41acea0710051705l217224b6vc705dc6139b94e3b@mail.gmail.com> <20071006004634.GA24962@owl.midgard.homeip.net> In-Reply-To: <20071006004634.GA24962@owl.midgard.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3104754.H2O26U3ONf"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200710061535.02201.doconnor@gsoft.com.au> X-Spam-Score: -2.312 () BAYES_00 X-Scanned-By: MIMEDefang 2.58 on 203.31.81.10 Cc: Jack F Vogel , Erik Trulsson , src-committers@freebsd.org, Jack Vogel , cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/em LICENSE e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 06:15:29 -0000 --nextPart3104754.H2O26U3ONf Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sat, 6 Oct 2007, Erik Trulsson wrote: > As I understand it the policy of FreeBSD is that new stuff *always* > should go into -CURRENT first before it is allowed to go into any > -STABLE branch. > > Please see > http://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ >rules.html The rules don't actually say that.. It looks like a good reason to me but only re@ & core@'s opinions really=20 count here :) =2D-=20 Daniel O'Connor software and network engineer for Genesis Software - http://www.gsoft.com.au "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C --nextPart3104754.H2O26U3ONf Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQBHByWO5ZPcIHs/zowRAuUuAKCqc28MctBqwoAJLsb0pMOmRfRAxgCfRP7X TChSTgqKQ/qYLb/eAgNfugA= =z3QO -----END PGP SIGNATURE----- --nextPart3104754.H2O26U3ONf-- From owner-cvs-src@FreeBSD.ORG Sat Oct 6 07:36:45 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7770016A419; Sat, 6 Oct 2007 07:36:45 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 27DED13C45D; Sat, 6 Oct 2007 07:36:45 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l967abZR080779; Sat, 6 Oct 2007 01:36:38 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <47073AF5.1010109@samsco.org> Date: Sat, 06 Oct 2007 01:36:21 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: Jack Vogel , Jack F Vogel , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200710052249.l95Mn9Nb071852@repoman.freebsd.org> <20071005231538.GA24016@owl.midgard.homeip.net> <2a41acea0710051705l217224b6vc705dc6139b94e3b@mail.gmail.com> <20071006004634.GA24962@owl.midgard.homeip.net> In-Reply-To: <20071006004634.GA24962@owl.midgard.homeip.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Sat, 06 Oct 2007 01:36:38 -0600 (MDT) X-Spam-Status: No, score=-1.2 required=5.5 tests=ALL_TRUSTED, MAILTO_TO_SPAM_ADDR autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: Subject: Re: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/em LICENSE e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 07:36:45 -0000 Erik Trulsson wrote: > On Fri, Oct 05, 2007 at 05:05:05PM -0700, Jack Vogel wrote: >> On 10/5/07, Erik Trulsson wrote: >>> On Fri, Oct 05, 2007 at 10:49:09PM +0000, Jack F Vogel wrote: >>>> jfv 2007-10-05 22:49:09 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: (Branch: RELENG_6) >>>> sys/conf files kern.pre.mk >>>> sys/dev/em LICENSE if_em.c if_em.h >>>> sys/modules/em Makefile >>>> Added files: (Branch: RELENG_6) >>>> sys/dev/em e1000_80003es2lan.c e1000_80003es2lan.h >>>> e1000_82540.c e1000_82541.c e1000_82541.h >>>> e1000_82542.c e1000_82543.c e1000_82543.h >>>> e1000_82571.c e1000_82571.h e1000_82575.c >>>> e1000_82575.h e1000_api.c e1000_api.h >>>> e1000_defines.h e1000_hw.h >>>> e1000_ich8lan.c e1000_ich8lan.h >>>> e1000_mac.c e1000_mac.h e1000_manage.c >>>> e1000_manage.h e1000_nvm.c e1000_nvm.h >>>> e1000_osdep.h e1000_phy.c e1000_phy.h >>>> e1000_regs.h >>>> Removed files: (Branch: RELENG_6) >>>> sys/dev/em if_em_hw.c if_em_hw.h if_em_osdep.h >>>> Log: >>>> MFC of Intel driver version 6.6.6 >>>> This adds our new modular shared code, support for MSI/MSIX, hardware >>>> support for newer adapters, and a variety of bug fixes. >>> Am I right in thinking that this code is actually newer than the code >>> in -CURRENT (which seems to be version 6.5.3) ? If this is indeed the >>> case, then shouldn't this code have gone into -CURRENT first? >> Yes, it is newer, the reason for this is the delta between what CURRENT >> has and this is small, and I did not want to impact CURRENT while its >> frozen getting ready for release. >> >> That delta between CURRENT and this is also not just some hacking of >> mine, its from my Intel release that has gone thru a whole test/validation >> and bug fix period of months. >> >> I would actually have liked to update BOTH CURRENT and STABLE with >> this but I was holding off on CURRENT because there are no critical >> bug fixes it doesnt have, and its about to be made into a release. > > As I understand it the policy of FreeBSD is that new stuff *always* should > go into -CURRENT first before it is allowed to go into any -STABLE branch. > > Please see > http://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/rules.html > What do you expect to accomplish by lecturing a vendor who has shown very good faith over the years in supporting FreeBSD? Maybe we should tell Intel to piss off since you obviously know how to support their hardware much better than they do. Scott From owner-cvs-src@FreeBSD.ORG Sat Oct 6 11:15:32 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C2B3116A419; Sat, 6 Oct 2007 11:15:32 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 7211913C45B; Sat, 6 Oct 2007 11:15:32 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id F3CF020C1; Sat, 6 Oct 2007 13:15:24 +0200 (CEST) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: -0.0/3.0 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on tim.des.no Received: from ds4.des.no (des.no [80.203.243.180]) by smtp.des.no (Postfix) with ESMTP id E0EAC20CC; Sat, 6 Oct 2007 13:15:24 +0200 (CEST) Received: by ds4.des.no (Postfix, from userid 1001) id C8B8884488; Sat, 6 Oct 2007 13:15:24 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Scott Long References: <200710052249.l95Mn9Nb071852@repoman.freebsd.org> <20071005231538.GA24016@owl.midgard.homeip.net> <2a41acea0710051705l217224b6vc705dc6139b94e3b@mail.gmail.com> <20071006004634.GA24962@owl.midgard.homeip.net> <47073AF5.1010109@samsco.org> Date: Sat, 06 Oct 2007 13:15:24 +0200 In-Reply-To: <47073AF5.1010109@samsco.org> (Scott Long's message of "Sat\, 06 Oct 2007 01\:36\:21 -0600") Message-ID: <86d4vspk8j.fsf@ds4.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Jack F Vogel , cvs-src@freebsd.org, src-committers@freebsd.org, Jack Vogel , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/em LICENSE e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 11:15:32 -0000 Scott Long writes: > What do you expect to accomplish by lecturing a vendor who has shown > very good faith over the years in supporting FreeBSD? Maybe we should > tell Intel to piss off since you obviously know how to support their > hardware much better than they do. We used to have a principle that commit bits were granted to individuals on their individual merit, not simply because they represented a vendor and were paid to work on drivers for that vendor's hardware. We also used to have a principle that changes should be tested before being committed, especially to -STABLE. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Sat Oct 6 13:23:43 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 463C816A418; Sat, 6 Oct 2007 13:23:43 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 1AE5213C455; Sat, 6 Oct 2007 13:23:43 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l96DNgcG078832; Sat, 6 Oct 2007 13:23:42 GMT (envelope-from rrs@repoman.freebsd.org) Received: (from rrs@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l96DNgOp078831; Sat, 6 Oct 2007 13:23:42 GMT (envelope-from rrs) Message-Id: <200710061323.l96DNgOp078831@repoman.freebsd.org> From: Randall Stewart Date: Sat, 6 Oct 2007 13:23:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet sctp_pcb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 13:23:43 -0000 rrs 2007-10-06 13:23:42 UTC FreeBSD src repository Modified files: sys/netinet sctp_pcb.c Log: - Fix the one-2-one model to properly do a socantrecv() Approved by: re@freeBSD.org (Ken Smith) Revision Changes Path 1.62 +1 -0 src/sys/netinet/sctp_pcb.c From owner-cvs-src@FreeBSD.ORG Sat Oct 6 14:23:34 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C758716A418; Sat, 6 Oct 2007 14:23:34 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 6DA0913C455; Sat, 6 Oct 2007 14:23:34 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from [192.168.254.15] (ydesk.samsco.home [192.168.254.15]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l96ENOKj083550; Sat, 6 Oct 2007 08:23:24 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <47079A5C.3090109@samsco.org> Date: Sat, 06 Oct 2007 08:23:24 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.7) Gecko/20050416 X-Accept-Language: en-us, en MIME-Version: 1.0 To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= References: <200710052249.l95Mn9Nb071852@repoman.freebsd.org> <20071005231538.GA24016@owl.midgard.homeip.net> <2a41acea0710051705l217224b6vc705dc6139b94e3b@mail.gmail.com> <20071006004634.GA24962@owl.midgard.homeip.net> <47073AF5.1010109@samsco.org> <86d4vspk8j.fsf@ds4.des.no> In-Reply-To: <86d4vspk8j.fsf@ds4.des.no> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [192.168.254.1]); Sat, 06 Oct 2007 08:23:24 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: Jack F Vogel , cvs-src@freebsd.org, src-committers@freebsd.org, Jack Vogel , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/em LICENSE e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 14:23:34 -0000 Dag-Erling Smørgrav wrote: > Scott Long writes: > >>What do you expect to accomplish by lecturing a vendor who has shown >>very good faith over the years in supporting FreeBSD? Maybe we should >>tell Intel to piss off since you obviously know how to support their >>hardware much better than they do. > > > We used to have a principle that commit bits were granted to individuals > on their individual merit, not simply because they represented a vendor > and were paid to work on drivers for that vendor's hardware. > Are you implying that Jack has no merit? That's an unfortunate assertion. What evidence do you have to support that? > We also used to have a principle that changes should be tested before > being committed, especially to -STABLE. I guess you missed that part where Jack said that the changes had undergone extensive testing. Scott From owner-cvs-src@FreeBSD.ORG Sat Oct 6 19:36:49 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2A96916A419; Sat, 6 Oct 2007 19:36:49 +0000 (UTC) (envelope-from jfv@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id EFBE713C474; Sat, 6 Oct 2007 19:36:48 +0000 (UTC) (envelope-from jfv@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l96Jam8F019719; Sat, 6 Oct 2007 19:36:48 GMT (envelope-from jfv@repoman.freebsd.org) Received: (from jfv@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l96JaadU019680; Sat, 6 Oct 2007 19:36:36 GMT (envelope-from jfv) Message-Id: <200710061936.l96JaadU019680@repoman.freebsd.org> From: Jack F Vogel Date: Sat, 6 Oct 2007 19:36:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 19:36:49 -0000 jfv 2007-10-06 19:36:35 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/em if_em.c Log: Couple corrections on the MFC, first POLLING had a 7.0 interface left in, thanks to those that caught this. Second, there was a 82571 fix in the last delta that got missed, it has now been converted and added. Revision Changes Path 1.65.2.25 +16 -8 src/sys/dev/em/if_em.c From owner-cvs-src@FreeBSD.ORG Sat Oct 6 19:45:29 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D94D016A420 for ; Sat, 6 Oct 2007 19:45:29 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mu-out-0910.google.com (mu-out-0910.google.com [209.85.134.191]) by mx1.freebsd.org (Postfix) with ESMTP id 6091F13C468 for ; Sat, 6 Oct 2007 19:45:28 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by mu-out-0910.google.com with SMTP id w9so1032599mue for ; Sat, 06 Oct 2007 12:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=GalrPEV1DuEfyXDJc7TD/JccZv4x34VAHK3RPCgJogw=; b=RRLOlI0EZZ6OFUYRJ1S5c9ZjrQ/VV/uNEyHni6M5QOH4Ig4JlwpTKl6wrxTJHiQ6O3txr+CGKrG5wWB3TlimGgCYXVZAYYMRqYov6BsNoe8RrbeWFPjm+KW96FLHlDsTHQ8OHkO6eIwDtNOom8CiyMiEyaA286ht2cAI+FZ+k1c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=kby5+EJ2G8dj4SZLJ4YtldyafAnfQ+3jbCllbg335Svfg769ZnaVGB6GO0CFm4TcMvXTd2ALuSdyEjM+dxQVw9Cd0AVGzY01j4/o/tId5oBnwIbEXoUvqupEzzk5LZhi0Dg8tGDbXQ0rmBcM/5QS5rcb9Qqs3O+MQD2bVPAOi8U= Received: by 10.86.96.18 with SMTP id t18mr401026fgb.1191699927654; Sat, 06 Oct 2007 12:45:27 -0700 (PDT) Received: by 10.86.100.19 with HTTP; Sat, 6 Oct 2007 12:45:27 -0700 (PDT) Message-ID: <2a41acea0710061245y2710330fs230a9d545b087d3b@mail.gmail.com> Date: Sat, 6 Oct 2007 12:45:27 -0700 From: "Jack Vogel" To: "Jack F Vogel" In-Reply-To: <200710061936.l96JaadU019680@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200710061936.l96JaadU019680@repoman.freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 19:45:29 -0000 On 10/6/07, Jack F Vogel wrote: > jfv 2007-10-06 19:36:35 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/dev/em if_em.c > Log: > Couple corrections on the MFC, first POLLING had a 7.0 > interface left in, thanks to those that caught this. > > Second, there was a 82571 fix in the last delta that > got missed, it has now been converted and added. > > Revision Changes Path > 1.65.2.25 +16 -8 src/sys/dev/em/if_em.c > In case this wasnt clear to anyone, this fixes bug 116975. Cheers, Jack From owner-cvs-src@FreeBSD.ORG Sat Oct 6 19:53:14 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7F48416A417; Sat, 6 Oct 2007 19:53:14 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 27B9713C480; Sat, 6 Oct 2007 19:53:14 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 00B3D20BB; Sat, 6 Oct 2007 21:53:06 +0200 (CEST) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: -0.0/3.0 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on tim.des.no Received: from ds4.des.no (des.no [80.203.243.180]) by smtp.des.no (Postfix) with ESMTP id 5D44F20AE; Sat, 6 Oct 2007 21:53:06 +0200 (CEST) Received: by ds4.des.no (Postfix, from userid 1001) id 45006844C2; Sat, 6 Oct 2007 21:53:06 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Scott Long References: <200710052249.l95Mn9Nb071852@repoman.freebsd.org> <20071005231538.GA24016@owl.midgard.homeip.net> <2a41acea0710051705l217224b6vc705dc6139b94e3b@mail.gmail.com> <20071006004634.GA24962@owl.midgard.homeip.net> <47073AF5.1010109@samsco.org> <86d4vspk8j.fsf@ds4.des.no> <47079A5C.3090109@samsco.org> Date: Sat, 06 Oct 2007 21:53:06 +0200 In-Reply-To: <47079A5C.3090109@samsco.org> (Scott Long's message of "Sat\, 06 Oct 2007 08\:23\:24 -0600") Message-ID: <86odfcvx3x.fsf@ds4.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Jack F Vogel , cvs-src@freebsd.org, src-committers@freebsd.org, Jack Vogel , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/em LICENSE e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 19:53:14 -0000 Scott Long writes: > Dag-Erling Sm=C3=B8rgrav writes: > > We used to have a principle that commit bits were granted to individuals > > on their individual merit, not simply because they represented a vendor > > and were paid to work on drivers for that vendor's hardware. > Are you implying that Jack has no merit? That's an unfortunate > assertion. What evidence do you have to support that? It is you who implied rather strongly that Jack is neither more nor less than an Intel representative. You spoke of "lecturing a vendor" when all Erik did was point out or own rules to a *committer*. > > We also used to have a principle that changes should be tested > > before being committed, especially to -STABLE. > I guess you missed that part where Jack said that the changes had > undergone extensive testing. I guess you missed the part where his commit broke the tinderbox, because he clearly did not test the DEVICE_POLLING case. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Sat Oct 6 19:59:25 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A561616A417 for ; Sat, 6 Oct 2007 19:59:25 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.188]) by mx1.freebsd.org (Postfix) with ESMTP id 2BC5913C4A3 for ; Sat, 6 Oct 2007 19:59:24 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by nf-out-0910.google.com with SMTP id b2so692903nfb for ; Sat, 06 Oct 2007 12:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=9iTPZFcRd5M/yJm+EZX0XbUJ5Qu4i5y/UUV6x29d4+A=; b=EeOtqmupSW//c1Sq/QonGmgMez7j1piEzUqpIeMQXCsSK/6nmpy5dkZZj+Y6FMM163GAMDN5A0XrjwqOq8WpeXZrgVW2ZumM6nBMye9guHTtU9XIJPcTl+MOprVOoQa+w+5ztb/snfHMEGJBX2vL8lJEw96JvT4BP/oKMlMJkR4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Pk9fPHpjwW7N3xvIAAyXV2XVJ5C5no/n4vdiOoYkqFExE/Vbd/wD/GeT/ZTl+TNcKQvE8M/YtWOxUrm1EG8s8ehVz5YTkuYlssxhzgRCKIyothCLEl/sadqCO6fHUqg740QjMAyIzaHgFSpJBgHlxX6Xki38wS0yH3wRA9wvJOI= Received: by 10.86.86.12 with SMTP id j12mr3600628fgb.1191700764633; Sat, 06 Oct 2007 12:59:24 -0700 (PDT) Received: by 10.86.100.19 with HTTP; Sat, 6 Oct 2007 12:59:24 -0700 (PDT) Message-ID: <2a41acea0710061259n23c19747tea9f210d1ce709fc@mail.gmail.com> Date: Sat, 6 Oct 2007 12:59:24 -0700 From: "Jack Vogel" To: "=?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?=" In-Reply-To: <86odfcvx3x.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <200710052249.l95Mn9Nb071852@repoman.freebsd.org> <20071005231538.GA24016@owl.midgard.homeip.net> <2a41acea0710051705l217224b6vc705dc6139b94e3b@mail.gmail.com> <20071006004634.GA24962@owl.midgard.homeip.net> <47073AF5.1010109@samsco.org> <86d4vspk8j.fsf@ds4.des.no> <47079A5C.3090109@samsco.org> <86odfcvx3x.fsf@ds4.des.no> Cc: Jack F Vogel , cvs-src@freebsd.org, Scott Long , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/em LICENSE e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 19:59:25 -0000 On 10/6/07, Dag-Erling Sm=F8rgrav wrote: > Scott Long writes: > > Dag-Erling Sm=F8rgrav writes: > > > We used to have a principle that commit bits were granted to individu= als > > > on their individual merit, not simply because they represented a vend= or > > > and were paid to work on drivers for that vendor's hardware. > > Are you implying that Jack has no merit? That's an unfortunate > > assertion. What evidence do you have to support that? > > It is you who implied rather strongly that Jack is neither more nor less > than an Intel representative. You spoke of "lecturing a vendor" when > all Erik did was point out or own rules to a *committer*. > > > > We also used to have a principle that changes should be tested > > > before being committed, especially to -STABLE. > > I guess you missed that part where Jack said that the changes had > > undergone extensive testing. > > I guess you missed the part where his commit broke the tinderbox, > because he clearly did not test the DEVICE_POLLING case. > No one is perfect, and YUP, we don't test POLLING, so here I am on my weekend fixing it, I don't get paid for that, and I also don't get paid for all the advocation I do for this community to Intel management. Jack From owner-cvs-src@FreeBSD.ORG Sat Oct 6 20:14:31 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7CD7716A561 for ; Sat, 6 Oct 2007 20:14:31 +0000 (UTC) (envelope-from erikt@midgard.homeip.net) Received: from ch-smtp02.sth.basefarm.net (ch-smtp02.sth.basefarm.net [80.76.149.213]) by mx1.freebsd.org (Postfix) with ESMTP id D3EA113C584 for ; Sat, 6 Oct 2007 20:14:28 +0000 (UTC) (envelope-from erikt@midgard.homeip.net) Received: from c83-253-31-60.bredband.comhem.se ([83.253.31.60]:50587 helo=falcon.midgard.homeip.net) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.66) (envelope-from ) id 1IeG2d-0005Ep-7F for cvs-src@freebsd.org; Sat, 06 Oct 2007 22:14:27 +0200 Received: (qmail 3694 invoked from network); 6 Oct 2007 22:07:43 +0200 Received: from owl.midgard.homeip.net (10.1.5.7) by falcon.midgard.homeip.net with ESMTP; 6 Oct 2007 22:07:43 +0200 Received: (qmail 36428 invoked by uid 1001); 6 Oct 2007 22:07:43 +0200 Date: Sat, 6 Oct 2007 22:07:43 +0200 From: Erik Trulsson To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= Message-ID: <20071006200743.GA24686@owl.midgard.homeip.net> Mail-Followup-To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= , Scott Long , Jack F Vogel , cvs-src@freebsd.org, src-committers@freebsd.org, Jack Vogel , cvs-all@freebsd.org References: <200710052249.l95Mn9Nb071852@repoman.freebsd.org> <20071005231538.GA24016@owl.midgard.homeip.net> <2a41acea0710051705l217224b6vc705dc6139b94e3b@mail.gmail.com> <20071006004634.GA24962@owl.midgard.homeip.net> <47073AF5.1010109@samsco.org> <86d4vspk8j.fsf@ds4.des.no> <47079A5C.3090109@samsco.org> <86odfcvx3x.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <86odfcvx3x.fsf@ds4.des.no> User-Agent: Mutt/1.5.16 (2007-06-09) X-Originating-IP: 83.253.31.60 X-Scan-Result: No virus found in message 1IeG2d-0005Ep-7F. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1IeG2d-0005Ep-7F 122c7a6eebc08b4fe1ef7cdebe484666 Cc: Scott Long , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Jack Vogel , Jack F Vogel Subject: Re: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/em LICENSE e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 20:14:31 -0000 On Sat, Oct 06, 2007 at 09:53:06PM +0200, Dag-Erling Sm=F8rgrav wrote: > Scott Long writes: > > Dag-Erling Sm=F8rgrav writes: > > > We used to have a principle that commit bits were granted to individu= als > > > on their individual merit, not simply because they represented a vend= or > > > and were paid to work on drivers for that vendor's hardware. > > Are you implying that Jack has no merit? That's an unfortunate > > assertion. What evidence do you have to support that? >=20 > It is you who implied rather strongly that Jack is neither more nor less > than an Intel representative. You spoke of "lecturing a vendor" when > all Erik did was point out or own rules to a *committer*. >=20 > > > We also used to have a principle that changes should be tested > > > before being committed, especially to -STABLE. > > I guess you missed that part where Jack said that the changes had > > undergone extensive testing. >=20 > I guess you missed the part where his commit broke the tinderbox, > because he clearly did not test the DEVICE_POLLING case. In Jack's defense that particular problem was apparently beacuse a 7.x interface was left in the code (bus_setup_intr(9) takes one more argument in 7.x than it does in 6.x.) That would not have been caught by having the code go into -CURRENT first. --=20 Erik Trulsson ertr1013@student.uu.se From owner-cvs-src@FreeBSD.ORG Sat Oct 6 20:34:15 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0BF0B16A468; Sat, 6 Oct 2007 20:34:15 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id EBAE813C4AC; Sat, 6 Oct 2007 20:34:14 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l96KYEXm024994; Sat, 6 Oct 2007 20:34:14 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l96KYEuI024993; Sat, 6 Oct 2007 20:34:14 GMT (envelope-from marius) Message-Id: <200710062034.l96KYEuI024993@repoman.freebsd.org> From: Marius Strobl Date: Sat, 6 Oct 2007 20:34:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/sparc64/isa ofw_isa.c src/sys/sparc64/pci apb.c ofw_pci.c ofw_pcib_subr.c ofw_pcibus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 20:34:15 -0000 marius 2007-10-06 20:34:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/sparc64/isa ofw_isa.c sys/sparc64/pci apb.c ofw_pci.c ofw_pcib_subr.c ofw_pcibus.c Log: - Adhere style(9) (don't use function calls in initializers, use uintXX_t instead of u_intXX_t). - Use FBSDID. Revision Changes Path 1.9.2.1 +5 -4 src/sys/sparc64/isa/ofw_isa.c 1.11.2.2 +7 -6 src/sys/sparc64/pci/apb.c 1.15.2.1 +6 -5 src/sys/sparc64/pci/ofw_pci.c 1.4.8.1 +19 -13 src/sys/sparc64/pci/ofw_pcib_subr.c 1.6.2.4 +9 -7 src/sys/sparc64/pci/ofw_pcibus.c From owner-cvs-src@FreeBSD.ORG Sat Oct 6 20:50:18 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B143016A418; Sat, 6 Oct 2007 20:50:18 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9EDBB13C45A; Sat, 6 Oct 2007 20:50:18 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l96KoIhC034425; Sat, 6 Oct 2007 20:50:18 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l96KoIBY034424; Sat, 6 Oct 2007 20:50:18 GMT (envelope-from marius) Message-Id: <200710062050.l96KoIBY034424@repoman.freebsd.org> From: Marius Strobl Date: Sat, 6 Oct 2007 20:50:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/sparc64/pci ofw_pcibus.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 20:50:18 -0000 marius 2007-10-06 20:50:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/sparc64/pci ofw_pcibus.c Log: MFC: 1.15; 1.16 - Remove unused softc. - Use the actual clock frequency of the PCI bus instead of assuming 33MHz for calculating the latency timer values for its children. Inspired by NetBSD doing the same and Linux as well as OpenSolaris using a similar approach. While at it rename a variable and change its type to be more appropriate fuer values of PCI properties so the variable can be more easily reused. - Initialize the cache line size register of PCI devices to a legal value; the cache line size is limited to 64 bytes by the Fireplane/Safari, JBus and UPA interconnection busses. Setting it to an unsupported value caused bad performance at least with GEM as it causes them to not do cache line bursts and to not issue cache line commands on the PCI bus. Revision Changes Path 1.6.2.5 +17 -20 src/sys/sparc64/pci/ofw_pcibus.c From owner-cvs-src@FreeBSD.ORG Sat Oct 6 21:13:55 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 85C9516A41B; Sat, 6 Oct 2007 21:13:55 +0000 (UTC) (envelope-from wb@freebie.xs4all.nl) Received: from smtp-vbr16.xs4all.nl (smtp-vbr16.xs4all.nl [194.109.24.36]) by mx1.freebsd.org (Postfix) with ESMTP id 1310713C45A; Sat, 6 Oct 2007 21:13:54 +0000 (UTC) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (obsolete.xs4all.nl [82.95.250.254]) by smtp-vbr16.xs4all.nl (8.13.8/8.13.8) with ESMTP id l96Ks5tR014873; Sat, 6 Oct 2007 22:54:05 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.13.8/8.13.3) with ESMTP id l96Ks5O6061051; Sat, 6 Oct 2007 22:54:05 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: (from wb@localhost) by freebie.xs4all.nl (8.13.8/8.13.6/Submit) id l96Ks4RF061050; Sat, 6 Oct 2007 22:54:04 +0200 (CEST) (envelope-from wb) Date: Sat, 6 Oct 2007 22:54:04 +0200 From: Wilko Bulte To: Jack Vogel Message-ID: <20071006205404.GA61023@freebie.xs4all.nl> References: <200710052249.l95Mn9Nb071852@repoman.freebsd.org> <20071005231538.GA24016@owl.midgard.homeip.net> <2a41acea0710051705l217224b6vc705dc6139b94e3b@mail.gmail.com> <20071006004634.GA24962@owl.midgard.homeip.net> <47073AF5.1010109@samsco.org> <86d4vspk8j.fsf@ds4.des.no> <47079A5C.3090109@samsco.org> <86odfcvx3x.fsf@ds4.des.no> <2a41acea0710061259n23c19747tea9f210d1ce709fc@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2a41acea0710061259n23c19747tea9f210d1ce709fc@mail.gmail.com> User-Agent: Mutt/1.5.11 X-Virus-Scanned: by XS4ALL Virus Scanner Cc: Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Jack F Vogel , Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= Subject: Re: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/em LICENSE e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 21:13:55 -0000 Quoting Jack Vogel, who wrote on Sat, Oct 06, 2007 at 12:59:24PM -0700 .. > On 10/6/07, Dag-Erling Smørgrav wrote: > > Scott Long writes: > > > Dag-Erling Smørgrav writes: > > > > We used to have a principle that commit bits were granted to individuals > > > > on their individual merit, not simply because they represented a vendor > > > > and were paid to work on drivers for that vendor's hardware. > > > Are you implying that Jack has no merit? That's an unfortunate > > > assertion. What evidence do you have to support that? > > > > It is you who implied rather strongly that Jack is neither more nor less > > than an Intel representative. You spoke of "lecturing a vendor" when > > all Erik did was point out or own rules to a *committer*. > > > > > > We also used to have a principle that changes should be tested > > > > before being committed, especially to -STABLE. > > > I guess you missed that part where Jack said that the changes had > > > undergone extensive testing. > > > > I guess you missed the part where his commit broke the tinderbox, > > because he clearly did not test the DEVICE_POLLING case. > > > > No one is perfect, and YUP, we don't test POLLING, so here I am > on my weekend fixing it, I don't get paid for that, and I also don't > get paid for all the advocation I do for this community to Intel > management. Thankless job, all this. But I hope you know that your work is well appreciated by the crowd 'out there'. cheers, Wilko -- Wilko Bulte wilko@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Sat Oct 6 21:13:57 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 69A2316A418; Sat, 6 Oct 2007 21:13:57 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3F10813C45B; Sat, 6 Oct 2007 21:13:57 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l96LDvIt039786; Sat, 6 Oct 2007 21:13:57 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l96LDvdL039785; Sat, 6 Oct 2007 21:13:57 GMT (envelope-from kmacy) Message-Id: <200710062113.l96LDvdL039785@repoman.freebsd.org> From: Kip Macy Date: Sat, 6 Oct 2007 21:13:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_mbuf.c src/sys/sys mbuf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 21:13:57 -0000 kmacy 2007-10-06 21:13:56 UTC FreeBSD src repository Modified files: sys/kern kern_mbuf.c sys/sys mbuf.h Log: Allow drivers to free an mbuf without having the mbuf be touched if the driver has already freed any attached tags Approved by: re(gnn) Revision Changes Path 1.31 +5 -2 src/sys/kern/kern_mbuf.c 1.216 +10 -0 src/sys/sys/mbuf.h From owner-cvs-src@FreeBSD.ORG Sat Oct 6 21:42:39 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D53F916A41A; Sat, 6 Oct 2007 21:42:39 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C51B313C45B; Sat, 6 Oct 2007 21:42:39 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l96LgdXH041437; Sat, 6 Oct 2007 21:42:39 GMT (envelope-from kmacy@repoman.freebsd.org) Received: (from kmacy@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l96Lgdth041436; Sat, 6 Oct 2007 21:42:39 GMT (envelope-from kmacy) Message-Id: <200710062142.l96Lgdth041436@repoman.freebsd.org> From: Kip Macy Date: Sat, 6 Oct 2007 21:42:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys mbuf.h src/sys/kern kern_mbuf.c uipc_mbuf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 21:42:39 -0000 kmacy 2007-10-06 21:42:39 UTC FreeBSD src repository Modified files: sys/sys mbuf.h sys/kern kern_mbuf.c uipc_mbuf.c Log: This patch adds an M_NOFREE flag which allows one to mark an mbuf as not being independently freeable. This allows one to embed an mbuf in the cluster itself. This confers the benefits of the packet zone on all cluster sizes. Embedded mbufs currently suffer from the same limitation that packet zone mbufs do in that one cannot disconnect them and pass them around independently of the cluster. It would likely be possible to eliminate this limitation in the future by adding a second reference for the mbuf itself. Approved by: re(gnn) Revision Changes Path 1.32 +1 -0 src/sys/kern/kern_mbuf.c 1.174 +11 -0 src/sys/kern/uipc_mbuf.c 1.217 +2 -1 src/sys/sys/mbuf.h From owner-cvs-src@FreeBSD.ORG Sat Oct 6 22:14:45 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1EE1716A417; Sat, 6 Oct 2007 22:14:45 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id BD8FE13C457; Sat, 6 Oct 2007 22:14:44 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from [192.168.254.15] (ydesk.samsco.home [192.168.254.15]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l96MEZE8085558; Sat, 6 Oct 2007 16:14:36 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <470808CB.50307@samsco.org> Date: Sat, 06 Oct 2007 16:14:35 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.7) Gecko/20050416 X-Accept-Language: en-us, en MIME-Version: 1.0 To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= References: <200710052249.l95Mn9Nb071852@repoman.freebsd.org> <20071005231538.GA24016@owl.midgard.homeip.net> <2a41acea0710051705l217224b6vc705dc6139b94e3b@mail.gmail.com> <20071006004634.GA24962@owl.midgard.homeip.net> <47073AF5.1010109@samsco.org> <86d4vspk8j.fsf@ds4.des.no> <47079A5C.3090109@samsco.org> <86odfcvx3x.fsf@ds4.des.no> In-Reply-To: <86odfcvx3x.fsf@ds4.des.no> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [192.168.254.1]); Sat, 06 Oct 2007 16:14:36 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: Jack F Vogel , cvs-src@freebsd.org, src-committers@freebsd.org, Jack Vogel , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf files kern.pre.mk src/sys/dev/em LICENSE e1000_80003es2lan.c e1000_80003es2lan.h e1000_82540.c e1000_82541.c e1000_82541.h e1000_82542.c e1000_82543.c e1000_82543.h e1000_82571.c e1000_82571.h e1000_82575.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2007 22:14:45 -0000 Dag-Erling Smørgrav wrote: > Scott Long writes: > >>Dag-Erling Smørgrav writes: >> >>>We used to have a principle that commit bits were granted to individuals >>>on their individual merit, not simply because they represented a vendor >>>and were paid to work on drivers for that vendor's hardware. >> >>Are you implying that Jack has no merit? That's an unfortunate >>assertion. What evidence do you have to support that? > > > It is you who implied rather strongly that Jack is neither more nor less > than an Intel representative. You spoke of "lecturing a vendor" when > all Erik did was point out or own rules to a *committer*. > Hmm, that's not how I read this at all. Guess we'll have to agree to disagree, won't we. Scott