From owner-cvs-src@FreeBSD.ORG Sun Oct 14 00:52:31 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D11A316A46D; Sun, 14 Oct 2007 00:52:31 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8763213C478; Sun, 14 Oct 2007 00:52:30 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9E0qUs6096694; Sun, 14 Oct 2007 00:52:30 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9E0qUxx096693; Sun, 14 Oct 2007 00:52:30 GMT (envelope-from csjp) Message-Id: <200710140052.l9E0qUxx096693@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Sun, 14 Oct 2007 00:52:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/id id.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 00:52:31 -0000 csjp 2007-10-14 00:52:30 UTC FreeBSD src repository Modified files: usr.bin/id id.c Log: Fix id -A when the subject has an extended subject token associated with them (for example when they have logged in from an ip6 source). - Stick with the initial call to getaudit(2), if it returns E2BIG, use getaudit_addr(2) instead and set the "extended" flag to indicate that we the calling credential has an extended subject state. - Additionally, add the printing of the machine/at_addr (the ip/ip6 addresses) MFC after: 1 week Obtained from: TrustedBSD Project Revision Changes Path 1.34 +38 -6 src/usr.bin/id/id.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 02:18:53 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2237216A418; Sun, 14 Oct 2007 02:18:53 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E404F13C480; Sun, 14 Oct 2007 02:18:52 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9E2IqE2003661; Sun, 14 Oct 2007 02:18:52 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9E2IqSX003660; Sun, 14 Oct 2007 02:18:52 GMT (envelope-from ache) Message-Id: <200710140218.l9E2IqSX003660@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Sun, 14 Oct 2007 02:18:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/mklocale UTF-8.src X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 02:18:53 -0000 ache 2007-10-14 02:18:52 UTC FreeBSD src repository Modified files: share/mklocale UTF-8.src Log: Add comment stating that UCS-4 really used here, not UTF-8 Revision Changes Path 1.3 +3 -0 src/share/mklocale/UTF-8.src From owner-cvs-src@FreeBSD.ORG Sun Oct 14 07:46:50 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AFFB316A473; Sun, 14 Oct 2007 07:46:50 +0000 (UTC) (envelope-from mpp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8224513C45B; Sun, 14 Oct 2007 07:46:50 +0000 (UTC) (envelope-from mpp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9E7koPO034815; Sun, 14 Oct 2007 07:46:50 GMT (envelope-from mpp@repoman.freebsd.org) Received: (from mpp@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9E7ko6l034814; Sun, 14 Oct 2007 07:46:50 GMT (envelope-from mpp) Message-Id: <200710140746.l9E7ko6l034814@repoman.freebsd.org> From: Mike Pritchard Date: Sun, 14 Oct 2007 07:46:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man5 fstab.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 07:46:50 -0000 mpp 2007-10-14 07:46:50 UTC FreeBSD src repository Modified files: share/man/man5 fstab.5 Log: Document quotachecks use of the passno field. Revision Changes Path 1.27 +5 -1 src/share/man/man5/fstab.5 From owner-cvs-src@FreeBSD.ORG Sun Oct 14 07:58:50 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B382F16A417; Sun, 14 Oct 2007 07:58:50 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8548013C455; Sun, 14 Oct 2007 07:58:50 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9E7woVu035416; Sun, 14 Oct 2007 07:58:50 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9E7wo4Y035415; Sun, 14 Oct 2007 07:58:50 GMT (envelope-from thompsa) Message-Id: <200710140758.l9E7wo4Y035415@repoman.freebsd.org> From: Andrew Thompson Date: Sun, 14 Oct 2007 07:58:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs zfs_fm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 07:58:50 -0000 thompsa 2007-10-14 07:58:50 UTC FreeBSD src repository Modified files: sys/contrib/opensolaris/uts/common/fs/zfs zfs_fm.c Log: Print the ZFS ereport to the console if vfs.zfs.debug is set to help diagnose problems with zfs-on-root since devd isnt running yet. Reviewed by: pjd Revision Changes Path 1.3 +1 -0 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_fm.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 08:52:30 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7FC4116A420; Sun, 14 Oct 2007 08:52:30 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 509A513C465; Sun, 14 Oct 2007 08:52:30 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9E8qUq8048457; Sun, 14 Oct 2007 08:52:30 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9E8qUhI048456; Sun, 14 Oct 2007 08:52:30 GMT (envelope-from maxim) Message-Id: <200710140852.l9E8qUhI048456@repoman.freebsd.org> From: Maxim Konovalov Date: Sun, 14 Oct 2007 08:52:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/calendar/calendars calendar.birthday X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 08:52:30 -0000 maxim 2007-10-14 08:52:30 UTC FreeBSD src repository Modified files: usr.bin/calendar/calendars calendar.birthday Log: o Pablo Picasso's birthday is October 25 not October 5. PR: conf/116952 Submitted by: Pablo Picasso Revision Changes Path 1.35 +1 -1 src/usr.bin/calendar/calendars/calendar.birthday From owner-cvs-src@FreeBSD.ORG Sun Oct 14 08:58:02 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 431A816A418; Sun, 14 Oct 2007 08:58:02 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 14FFC13C45B; Sun, 14 Oct 2007 08:58:02 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9E8w2Ik048629; Sun, 14 Oct 2007 08:58:02 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9E8w1cA048628; Sun, 14 Oct 2007 08:58:01 GMT (envelope-from maxim) Message-Id: <200710140858.l9E8w1cA048628@repoman.freebsd.org> From: Maxim Konovalov Date: Sun, 14 Oct 2007 08:58:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sbin/ipfw ipfw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 08:58:02 -0000 maxim 2007-10-14 08:58:01 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sbin/ipfw ipfw2.c Log: MFC rev.1.108: fix the issue when "ipfw(8) show" produces "not" twice. Revision Changes Path 1.76.2.20 +2 -2 src/sbin/ipfw/ipfw2.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 09:12:46 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E7B4216A420; Sun, 14 Oct 2007 09:12:46 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B64AA13C447; Sun, 14 Oct 2007 09:12:46 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9E9Ck6a050721; Sun, 14 Oct 2007 09:12:46 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9E9Ck1a050720; Sun, 14 Oct 2007 09:12:46 GMT (envelope-from maxim) Message-Id: <200710140912.l9E9Ck1a050720@repoman.freebsd.org> From: Maxim Konovalov Date: Sun, 14 Oct 2007 09:12:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/ipfw ipfw.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 09:12:47 -0000 maxim 2007-10-14 09:12:46 UTC FreeBSD src repository Modified files: sbin/ipfw ipfw.8 Log: o Fix a typo in ipfw table usage example. PR: docs/117172 Submitted by: novel MFC after: 1 week Revision Changes Path 1.204 +1 -1 src/sbin/ipfw/ipfw.8 From owner-cvs-src@FreeBSD.ORG Sun Oct 14 09:51:21 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 32C5616A420; Sun, 14 Oct 2007 09:51:21 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id F2CDC13C465; Sun, 14 Oct 2007 09:51:20 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9E9pKeC052944; Sun, 14 Oct 2007 09:51:20 GMT (envelope-from mav@repoman.freebsd.org) Received: (from mav@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9E9pKWo052940; Sun, 14 Oct 2007 09:51:20 GMT (envelope-from mav) Message-Id: <200710140951.l9E9pKWo052940@repoman.freebsd.org> From: Alexander Motin Date: Sun, 14 Oct 2007 09:51:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netgraph ng_pppoe.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 09:51:21 -0000 mav 2007-10-14 09:51:20 UTC FreeBSD src repository Modified files: sys/netgraph ng_pppoe.c Log: Remove ng_pppoe_sendpacket() function to simplify code as it is called as much times as it has cases inside of it. Revision Changes Path 1.85 +39 -79 src/sys/netgraph/ng_pppoe.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 09:58:22 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EEC1E16A41B; Sun, 14 Oct 2007 09:58:22 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B817F13C458; Sun, 14 Oct 2007 09:58:22 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9E9wMF2053431; Sun, 14 Oct 2007 09:58:22 GMT (envelope-from mav@repoman.freebsd.org) Received: (from mav@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9E9wMWB053407; Sun, 14 Oct 2007 09:58:22 GMT (envelope-from mav) Message-Id: <200710140958.l9E9wMWB053407@repoman.freebsd.org> From: Alexander Motin Date: Sun, 14 Oct 2007 09:58:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netgraph ng_pppoe.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 09:58:23 -0000 mav 2007-10-14 09:58:22 UTC FreeBSD src repository Modified files: sys/netgraph ng_pppoe.c Log: Split ng_pppoe_rcvdata() function into three hook-specific ones to simplify code and reduce stack usage. Revision Changes Path 1.86 +466 -465 src/sys/netgraph/ng_pppoe.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 10:23:55 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AFBC516A41B; Sun, 14 Oct 2007 10:23:55 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7319E13C48A; Sun, 14 Oct 2007 10:23:55 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EANtUl057355; Sun, 14 Oct 2007 10:23:55 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EANtv9057354; Sun, 14 Oct 2007 10:23:55 GMT (envelope-from ache) Message-Id: <200710141023.l9EANtv9057354@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Sun, 14 Oct 2007 10:23:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/include wctype.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 10:23:55 -0000 ache 2007-10-14 10:23:54 UTC FreeBSD src repository Modified files: include wctype.h Log: Back out iswascii change from prev. commit, iswascii was right, some overlook from me. Revision Changes Path 1.15 +1 -1 src/include/wctype.h From owner-cvs-src@FreeBSD.ORG Sun Oct 14 10:45:32 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6969016A419; Sun, 14 Oct 2007 10:45:32 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3E2CE13C448; Sun, 14 Oct 2007 10:45:32 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EAjWjs058733; Sun, 14 Oct 2007 10:45:32 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EAjW4m058732; Sun, 14 Oct 2007 10:45:32 GMT (envelope-from netchild) Message-Id: <200710141045.l9EAjW4m058732@repoman.freebsd.org> From: Alexander Leidinger Date: Sun, 14 Oct 2007 10:45:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 10:45:32 -0000 netchild 2007-10-14 10:45:31 UTC FreeBSD src repository Modified files: etc Makefile etc/defaults rc.conf etc/rc.d Makefile lib/libc/gen sysctl.3 sbin/sysctl sysctl.8 sysctl.c share/man/man5 rc.conf.5 share/man/man9 Makefile sys/conf files sys/sys sysctl.h usr.bin/systat Makefile cmdtab.c extern.h systat.1 usr.sbin Makefile Added files: etc sensorsd.conf etc/rc.d sensorsd share/man/man9 sensor_attach.9 sys/kern kern_sensors.c sys/sys sensors.h usr.bin/systat sensors.c usr.sbin/sensorsd Makefile sensorsd.8 sensorsd.c sensorsd.conf.5 Log: Import OpenBSD's sysctl hardware sensors framework. This commit includes the following core components: * sample configuration file for sensorsd * rc(8) script and glue code for sensorsd(8) * sysctl(3) doc fixes for CTL_HW tree * sysctl(3) documentation for hardware sensors * sysctl(8) documentation for hardware sensors * support for the sensor structure for sysctl(8) * rc.conf(5) documentation for starting sensorsd(8) * sensor_attach(9) et al documentation * /sys/kern/kern_sensors.c o sensor_attach(9) API for drivers to register ksensors o sensor_task_register(9) API for the update task o sysctl(3) glue code o hw.sensors shadow tree for sysctl(8) internal magic * * HW_SENSORS definition for * sensors display for systat(1), including documentation * sensorsd(8) and all applicable documentation The userland part of the framework is entirely source-code compatible with OpenBSD 4.1, 4.2 and -current as of today. All sensor readings can be viewed with `sysctl hw.sensors`, monitored in semi-realtime with `systat -sensors` and also logged with `sensorsd`. Submitted by: Constantine A. Murenin Sponsored by: Google Summer of Code 2007 (GSoC2007/cnst-sensors) Mentored by: syrinx Tested by: many OKed by: kensmith Obtained from: OpenBSD (parts) Revision Changes Path 1.361 +1 -1 src/etc/Makefile 1.320 +2 -0 src/etc/defaults/rc.conf 1.85 +1 -1 src/etc/rc.d/Makefile 1.1 +17 -0 src/etc/rc.d/sensorsd (new) 1.1 +50 -0 src/etc/sensorsd.conf (new) 1.70 +34 -6 src/lib/libc/gen/sysctl.3 1.62 +1 -0 src/sbin/sysctl/sysctl.8 1.87 +140 -0 src/sbin/sysctl/sysctl.c 1.328 +18 -1 src/share/man/man5/rc.conf.5 1.311 +8 -0 src/share/man/man9/Makefile 1.1 +155 -0 src/share/man/man9/sensor_attach.9 (new) 1.1244 +1 -0 src/sys/conf/files 1.1 +421 -0 src/sys/kern/kern_sensors.c (new) 1.1 +168 -0 src/sys/sys/sensors.h (new) 1.149 +4 -1 src/sys/sys/sysctl.h 1.19 +1 -1 src/usr.bin/systat/Makefile 1.11 +3 -0 src/usr.bin/systat/cmdtab.c 1.15 +6 -0 src/usr.bin/systat/extern.h 1.1 +261 -0 src/usr.bin/systat/sensors.c (new) 1.54 +7 -0 src/usr.bin/systat/systat.1 1.376 +1 -0 src/usr.sbin/Makefile 1.1 +9 -0 src/usr.sbin/sensorsd/Makefile (new) 1.1 +93 -0 src/usr.sbin/sensorsd/sensorsd.8 (new) 1.1 +644 -0 src/usr.sbin/sensorsd/sensorsd.c (new) 1.1 +186 -0 src/usr.sbin/sensorsd/sensorsd.conf.5 (new) From owner-cvs-src@FreeBSD.ORG Sun Oct 14 10:55:51 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 46BE616A420; Sun, 14 Oct 2007 10:55:51 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 198BF13C448; Sun, 14 Oct 2007 10:55:51 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EAtpC9059507; Sun, 14 Oct 2007 10:55:51 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EAtoLK059506; Sun, 14 Oct 2007 10:55:50 GMT (envelope-from netchild) Message-Id: <200710141055.l9EAtoLK059506@repoman.freebsd.org> From: Alexander Leidinger Date: Sun, 14 Oct 2007 10:55:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 Makefile it.4 lm.4 src/sys/amd64/conf GENERIC.hints src/sys/conf files files.amd64 files.i386 src/sys/dev/it it.c itvar.h src/sys/dev/lm lm78.c lm78_isa.c lm78var.h src/sys/i386/conf GENERIC.hints ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 10:55:51 -0000 netchild 2007-10-14 10:55:50 UTC FreeBSD src repository Modified files: share/man/man4 Makefile sys/amd64/conf GENERIC.hints sys/conf files files.amd64 files.i386 sys/i386/conf GENERIC.hints sys/modules Makefile Added files: share/man/man4 it.4 lm.4 sys/dev/it it.c itvar.h sys/dev/lm lm78.c lm78_isa.c lm78var.h sys/modules/it Makefile sys/modules/lm Makefile Log: Import it(4) and lm(4), supporting most popular Super I/O Hardware Monitors. Submitted by: Constantine A. Murenin Sponsored by: Google Summer of Code 2007 (GSoC2007/cnst-sensors) Mentored by: syrinx Tested by: many OKed by: kensmith Obtained from: OpenBSD (parts) Revision Changes Path 1.394 +3 -0 src/share/man/man4/Makefile 1.1 +104 -0 src/share/man/man4/it.4 (new) 1.1 +138 -0 src/share/man/man4/lm.4 (new) 1.17 +8 -0 src/sys/amd64/conf/GENERIC.hints 1.1245 +2 -0 src/sys/conf/files 1.108 +1 -0 src/sys/conf/files.amd64 1.581 +1 -0 src/sys/conf/files.i386 1.1 +346 -0 src/sys/dev/it/it.c (new) 1.1 +95 -0 src/sys/dev/it/itvar.h (new) 1.1 +909 -0 src/sys/dev/lm/lm78.c (new) 1.1 +251 -0 src/sys/dev/lm/lm78_isa.c (new) 1.1 +158 -0 src/sys/dev/lm/lm78var.h (new) 1.17 +8 -0 src/sys/i386/conf/GENERIC.hints 1.541 +6 -0 src/sys/modules/Makefile 1.1 +9 -0 src/sys/modules/it/Makefile (new) 1.1 +9 -0 src/sys/modules/lm/Makefile (new) From owner-cvs-src@FreeBSD.ORG Sun Oct 14 10:59:44 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8AAE116A420; Sun, 14 Oct 2007 10:59:44 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 48CF913C46E; Sun, 14 Oct 2007 10:59:44 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EAxi3X059662; Sun, 14 Oct 2007 10:59:44 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EAxivf059661; Sun, 14 Oct 2007 10:59:44 GMT (envelope-from netchild) Message-Id: <200710141059.l9EAxivf059661@repoman.freebsd.org> From: Alexander Leidinger Date: Sun, 14 Oct 2007 10:59:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 coretemp.4 src/sys/dev/coretemp coretemp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 10:59:44 -0000 netchild 2007-10-14 10:59:44 UTC FreeBSD src repository Modified files: share/man/man4 coretemp.4 sys/dev/coretemp coretemp.c Log: Convert coretemp(4) to the hardware sensors framework and make sure to never call sched_bind() for uninitialised CPUs. Submitted by: Constantine A. Murenin Sponsored by: Google Summer of Code 2007 (GSoC2007/cnst-sensors) Mentored by: syrinx Tested by: many OKed by: kensmith Revision Changes Path 1.2 +14 -6 src/share/man/man4/coretemp.4 1.3 +46 -35 src/sys/dev/coretemp/coretemp.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 11:35:52 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B878916A418 for ; Sun, 14 Oct 2007 11:35:52 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.172]) by mx1.freebsd.org (Postfix) with ESMTP id 29FCD13C43E for ; Sun, 14 Oct 2007 11:35:51 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: by ug-out-1314.google.com with SMTP id y2so227632uge for ; Sun, 14 Oct 2007 04:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer:sender; bh=5B9GVcCjyy9tIFTO+JJF84I2ca2EkGzY7DT5BVndVmo=; b=MdeX6HCyv3a3KcNdhVMYvWAxQh26ZC4yaKjFu4Atr7D9YFBSk2i9H0sW1EGumoWKGtu4sk1iZSuLG0UndSum3yLBgmsiiNMghFqMENAZGQTkNiIFK9V5vx2Jfy+GCFbrxSznNuL0S6jRJgBF+780zJwFin1iTWnOeHj+mC8TNZk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer:sender; b=jJh1v2eFTz+fsQJdTJvatdOm72K65et7O9r3D6qwFX9B6V+FZoQyLHGplsNfjuYunVe3y8GYBBrne7F7kMiiSLBgB3ucBczUNfJlWSYh2to3pze/rB9JPuXjXg4or0M0AmHX75YskrrOQ4CCsGiHtDD9734ZZG1UGRfEZzmrXrs= Received: by 10.66.219.20 with SMTP id r20mr6625061ugg.1192361750398; Sun, 14 Oct 2007 04:35:50 -0700 (PDT) Received: from ?10.0.0.13? ( [83.144.140.145]) by mx.google.com with ESMTPS id c22sm1781274ika.2007.10.14.04.35.48 (version=SSLv3 cipher=OTHER); Sun, 14 Oct 2007 04:35:49 -0700 (PDT) In-Reply-To: <200710141059.l9EAxivf059661@repoman.freebsd.org> References: <200710141059.l9EAxivf059661@repoman.freebsd.org> Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Rui Paulo Date: Sun, 14 Oct 2007 12:35:42 +0100 To: Alexander Leidinger X-Mailer: Apple Mail (2.752.3) Sender: Rui Paulo Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man4 coretemp.4 src/sys/dev/coretemp coretemp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 11:35:52 -0000 On 14 Oct 2007, at 11:59, Alexander Leidinger wrote: > netchild 2007-10-14 10:59:44 UTC > > FreeBSD src repository > > Modified files: > share/man/man4 coretemp.4 > sys/dev/coretemp coretemp.c > Log: > Convert coretemp(4) to the hardware sensors framework and > make sure to never call sched_bind() for uninitialised CPUs. > > Submitted by: Constantine A. Murenin > Sponsored by: Google Summer of Code 2007 (GSoC2007/cnst-sensors) > Mentored by: syrinx > Tested by: many > OKed by: kensmith > Just for the record, I've been working on a better way to do sched_bind() mumbo jumbo. I hope I can commit it in the near future. Regards. -- Rui Paulo From owner-cvs-src@FreeBSD.ORG Sun Oct 14 12:39:32 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4E0716A469 for ; Sun, 14 Oct 2007 12:39:32 +0000 (UTC) (envelope-from grafan@gmail.com) Received: from qb-out-0506.google.com (qb-out-0506.google.com [72.14.204.237]) by mx1.freebsd.org (Postfix) with ESMTP id 4D5DC13C4B9 for ; Sun, 14 Oct 2007 12:39:32 +0000 (UTC) (envelope-from grafan@gmail.com) Received: by qb-out-0506.google.com with SMTP id a10so1667450qbd for ; Sun, 14 Oct 2007 05:39:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; bh=KXtBdBuXlbgg6EXn77eIGVri0e4KfFvfB/FK+5aWdaQ=; b=eJ6YeHBuZIU6OxzZrdFNSuT+Y6mFp9FS3C9+jVt9GUBotW/11ZWYX/vezKGZcmtCcW1cDBBHQbTG6/ftQsxXRvTg26hZnUFFZxxBGgy5Fx6LcqMsVhLo6auf0fh2PVsDitBDfoU/luvwyJk+KxJ8tVNPmsK1jCni7a7+KyKhs6w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; b=EoxvqWlgWSCwvMyFh+xQi7BK/m/JNSbUlkPBaV/9CbWgzRfbmEkWP0RHalf7rCWJrmP5n+MjWG6HOHtlDNrN8iEA5vSQeUADHZ5NcZIbpC8prbHeQHH++PLMciVBg/jiobMiYiel0Lek/SsKTby4C3/Kod0zNNUroEXS+hf00Pg= Received: by 10.64.242.5 with SMTP id p5mr10286186qbh.1192364650565; Sun, 14 Oct 2007 05:24:10 -0700 (PDT) Received: by 10.64.196.4 with HTTP; Sun, 14 Oct 2007 05:24:10 -0700 (PDT) Message-ID: <6eb82e0710140524w4f4abb7fjaed35fae7625afec@mail.gmail.com> Date: Sun, 14 Oct 2007 20:24:10 +0800 From: "Rong-en Fan" To: "Alexander Leidinger" , cnst@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 12:39:32 -0000 On 10/14/07, Alexander Leidinger wrote: > netchild 2007-10-14 10:45:31 UTC > > FreeBSD src repository > > Modified files: > etc Makefile > etc/defaults rc.conf > etc/rc.d Makefile > lib/libc/gen sysctl.3 > sbin/sysctl sysctl.8 sysctl.c > share/man/man5 rc.conf.5 > share/man/man9 Makefile > sys/conf files > sys/sys sysctl.h > usr.bin/systat Makefile cmdtab.c extern.h systat.1 > usr.sbin Makefile > Added files: > etc sensorsd.conf > etc/rc.d sensorsd > share/man/man9 sensor_attach.9 > sys/kern kern_sensors.c > sys/sys sensors.h > usr.bin/systat sensors.c > usr.sbin/sensorsd Makefile sensorsd.8 sensorsd.c > sensorsd.conf.5 > Log: > Import OpenBSD's sysctl hardware sensors framework. > [...] > Submitted by: Constantine A. Murenin > Sponsored by: Google Summer of Code 2007 (GSoC2007/cnst-sensors) > Mentored by: syrinx > Tested by: many > OKed by: kensmith > Obtained from: OpenBSD (parts) Great work, thanks Constantine! I think it won't be in 7.0-R, but will it be merged back to 7-STABLE (or even 6-STABLE) ? Regards, Rong-En Fan > > Revision Changes Path > 1.361 +1 -1 src/etc/Makefile > 1.320 +2 -0 src/etc/defaults/rc.conf > 1.85 +1 -1 src/etc/rc.d/Makefile > 1.1 +17 -0 src/etc/rc.d/sensorsd (new) > 1.1 +50 -0 src/etc/sensorsd.conf (new) > 1.70 +34 -6 src/lib/libc/gen/sysctl.3 > 1.62 +1 -0 src/sbin/sysctl/sysctl.8 > 1.87 +140 -0 src/sbin/sysctl/sysctl.c > 1.328 +18 -1 src/share/man/man5/rc.conf.5 > 1.311 +8 -0 src/share/man/man9/Makefile > 1.1 +155 -0 src/share/man/man9/sensor_attach.9 (new) > 1.1244 +1 -0 src/sys/conf/files > 1.1 +421 -0 src/sys/kern/kern_sensors.c (new) > 1.1 +168 -0 src/sys/sys/sensors.h (new) > 1.149 +4 -1 src/sys/sys/sysctl.h > 1.19 +1 -1 src/usr.bin/systat/Makefile > 1.11 +3 -0 src/usr.bin/systat/cmdtab.c > 1.15 +6 -0 src/usr.bin/systat/extern.h > 1.1 +261 -0 src/usr.bin/systat/sensors.c (new) > 1.54 +7 -0 src/usr.bin/systat/systat.1 > 1.376 +1 -0 src/usr.sbin/Makefile > 1.1 +9 -0 src/usr.sbin/sensorsd/Makefile (new) > 1.1 +93 -0 src/usr.sbin/sensorsd/sensorsd.8 (new) > 1.1 +644 -0 src/usr.sbin/sensorsd/sensorsd.c (new) > 1.1 +186 -0 src/usr.sbin/sensorsd/sensorsd.conf.5 (new) > _______________________________________________ > cvs-src@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-src > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" > From owner-cvs-src@FreeBSD.ORG Sun Oct 14 13:37:53 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ED3D016A41A; Sun, 14 Oct 2007 13:37:53 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A9D2213C465; Sun, 14 Oct 2007 13:37:53 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EDbrrU080320; Sun, 14 Oct 2007 13:37:53 GMT (envelope-from daichi@repoman.freebsd.org) Received: (from daichi@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EDbrV0080319; Sun, 14 Oct 2007 13:37:53 GMT (envelope-from daichi) Message-Id: <200710141337.l9EDbrV0080319@repoman.freebsd.org> From: Daichi GOTO Date: Sun, 14 Oct 2007 13:37:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/unionfs union_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 13:37:54 -0000 daichi 2007-10-14 13:37:52 UTC FreeBSD src repository Modified files: sys/fs/unionfs union_subr.c Log: Log: Improved access permission check treatments. Submitted by: Masanori Ozawa (unionfs developer) Reviewed by: jeff, kensmith Approved by: re (kensmith) MFC after: 1 week Revision Changes Path 1.93 +6 -0 src/sys/fs/unionfs/union_subr.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 13:42:05 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F00DD16A417; Sun, 14 Oct 2007 13:42:05 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id AD6B313C447; Sun, 14 Oct 2007 13:42:05 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EDg5rL080649; Sun, 14 Oct 2007 13:42:05 GMT (envelope-from daichi@repoman.freebsd.org) Received: (from daichi@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EDg5Vd080648; Sun, 14 Oct 2007 13:42:05 GMT (envelope-from daichi) Message-Id: <200710141342.l9EDg5Vd080648@repoman.freebsd.org> From: Daichi GOTO Date: Sun, 14 Oct 2007 13:42:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/unionfs union_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 13:42:06 -0000 daichi 2007-10-14 13:42:05 UTC FreeBSD src repository Modified files: sys/fs/unionfs union_vnops.c Log: Changed it frees unneeded memory ASAP. Submitted by: Masanori Ozawa (unionfs developer) Reviewed by: jeff, kensmith Approved by: re (kensmith) MFC after: 1 week Revision Changes Path 1.143 +5 -1 src/sys/fs/unionfs/union_vnops.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 13:44:06 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A665E16A469; Sun, 14 Oct 2007 13:44:06 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 4FD8D13C447; Sun, 14 Oct 2007 13:44:06 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EDi6O8080789; Sun, 14 Oct 2007 13:44:06 GMT (envelope-from daichi@repoman.freebsd.org) Received: (from daichi@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EDi6tL080788; Sun, 14 Oct 2007 13:44:06 GMT (envelope-from daichi) Message-Id: <200710141344.l9EDi6tL080788@repoman.freebsd.org> From: Daichi GOTO Date: Sun, 14 Oct 2007 13:44:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/unionfs union_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 13:44:06 -0000 daichi 2007-10-14 13:44:06 UTC FreeBSD src repository Modified files: sys/fs/unionfs union_vnops.c Log: Added treatments to prevent readdir infinity loop using with Linux binary compatibility feature. Submitted by: Masanori Ozawa (unionfs developer) Reviewed by: jeff, kensmith Approved by: re (kensmith) MFC after: 1 week Revision Changes Path 1.144 +23 -29 src/sys/fs/unionfs/union_vnops.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 13:46:12 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 377A116A421; Sun, 14 Oct 2007 13:46:12 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0DD2013C46A; Sun, 14 Oct 2007 13:46:12 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EDkCPY080962; Sun, 14 Oct 2007 13:46:12 GMT (envelope-from daichi@repoman.freebsd.org) Received: (from daichi@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EDkCxO080961; Sun, 14 Oct 2007 13:46:12 GMT (envelope-from daichi) Message-Id: <200710141346.l9EDkCxO080961@repoman.freebsd.org> From: Daichi GOTO Date: Sun, 14 Oct 2007 13:46:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/unionfs union.h union_subr.c union_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 13:46:12 -0000 daichi 2007-10-14 13:46:11 UTC FreeBSD src repository Modified files: sys/fs/unionfs union.h union_subr.c union_vnops.c Log: - Added support for vfs_cache on unionfs. As a result, you can use applications that use procfs on unionfs. - Removed unionfs internal cache mechanism because it has vfs_cache support instead. As a result, it just simplified code of unionfs. - Fixed kern/111262 issue. Submitted by: Masanori Ozawa (unionfs developer) Reviewed by: jeff, kensmith Approved by: re (kensmith) MFC after: 1 week Revision Changes Path 1.35 +7 -6 src/sys/fs/unionfs/union.h 1.94 +9 -154 src/sys/fs/unionfs/union_subr.c 1.145 +27 -11 src/sys/fs/unionfs/union_vnops.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 13:47:45 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 937E216A418; Sun, 14 Oct 2007 13:47:45 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5145013C474; Sun, 14 Oct 2007 13:47:45 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EDljmf081029; Sun, 14 Oct 2007 13:47:45 GMT (envelope-from daichi@repoman.freebsd.org) Received: (from daichi@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EDljOB081028; Sun, 14 Oct 2007 13:47:45 GMT (envelope-from daichi) Message-Id: <200710141347.l9EDljOB081028@repoman.freebsd.org> From: Daichi GOTO Date: Sun, 14 Oct 2007 13:47:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/unionfs union_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 13:47:45 -0000 daichi 2007-10-14 13:47:44 UTC FreeBSD src repository Modified files: sys/fs/unionfs union_vnops.c Log: Fixed vnode unlock/vrele untreated issues whenever errors have occurred during some treatments. Submitted by: Masanori Ozawa (unionfs developer) Reviewed by: jeff, kensmith Approved by: re (kensmith) MFC after: 1 week Revision Changes Path 1.146 +4 -4 src/sys/fs/unionfs/union_vnops.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 13:49:31 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 646FE16A418; Sun, 14 Oct 2007 13:49:31 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 22AD413C46B; Sun, 14 Oct 2007 13:49:31 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EDnVAN081155; Sun, 14 Oct 2007 13:49:31 GMT (envelope-from daichi@repoman.freebsd.org) Received: (from daichi@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EDnV16081154; Sun, 14 Oct 2007 13:49:31 GMT (envelope-from daichi) Message-Id: <200710141349.l9EDnV16081154@repoman.freebsd.org> From: Daichi GOTO Date: Sun, 14 Oct 2007 13:49:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/unionfs union_vfsops.c union_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 13:49:31 -0000 daichi 2007-10-14 13:49:30 UTC FreeBSD src repository Modified files: sys/fs/unionfs union_vfsops.c union_vnops.c Log: - It has been become MPSAFE. - Fixed lock panic issue under MPSAFE. - Fixed panic issue whenever it locks vnode with reclaim. - Fixed lock implementations not conforming to vnode_if.src style. Submitted by: Masanori Ozawa (unionfs developer) Reviewed by: jeff, kensmith Approved by: re (kensmith) MFC after: 1 week Revision Changes Path 1.83 +5 -0 src/sys/fs/unionfs/union_vfsops.c 1.147 +46 -22 src/sys/fs/unionfs/union_vnops.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 13:50:59 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6330916A418; Sun, 14 Oct 2007 13:50:59 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id EDC2813C447; Sun, 14 Oct 2007 13:50:58 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EDow0o081405; Sun, 14 Oct 2007 13:50:58 GMT (envelope-from daichi@repoman.freebsd.org) Received: (from daichi@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EDowxp081404; Sun, 14 Oct 2007 13:50:58 GMT (envelope-from daichi) Message-Id: <200710141350.l9EDowxp081404@repoman.freebsd.org> From: Daichi GOTO Date: Sun, 14 Oct 2007 13:50:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/unionfs union_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 13:50:59 -0000 daichi 2007-10-14 13:50:58 UTC FreeBSD src repository Modified files: sys/fs/unionfs union_vnops.c Log: Added NULL check code pointed out by Coverity. (via Stanislav Sedov. Thanks) Submitted by: Masanori Ozawa (unionfs developer) Reviewed by: jeff, kensmith Approved by: re (kensmith) MFC after: 1 week Revision Changes Path 1.148 +2 -0 src/sys/fs/unionfs/union_vnops.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 13:52:02 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 997F316A41A; Sun, 14 Oct 2007 13:52:02 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 37A4A13C457; Sun, 14 Oct 2007 13:52:02 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EDq2Du081917; Sun, 14 Oct 2007 13:52:02 GMT (envelope-from daichi@repoman.freebsd.org) Received: (from daichi@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EDq2tY081916; Sun, 14 Oct 2007 13:52:02 GMT (envelope-from daichi) Message-Id: <200710141352.l9EDq2tY081916@repoman.freebsd.org> From: Daichi GOTO Date: Sun, 14 Oct 2007 13:52:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/unionfs union_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 13:52:02 -0000 daichi 2007-10-14 13:52:02 UTC FreeBSD src repository Modified files: sys/fs/unionfs union_vfsops.c Log: Fixed un-vrele issue of upper layer root vnode of unionfs. Submitted by: Masanori Ozawa (unionfs developer) Reviewed by: jeff, kensmith Approved by: re (kensmith) MFC after: 1 week Revision Changes Path 1.84 +1 -1 src/sys/fs/unionfs/union_vfsops.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 13:53:38 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C743D16A417; Sun, 14 Oct 2007 13:53:38 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 80D3513C447; Sun, 14 Oct 2007 13:53:38 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EDrcA8084276; Sun, 14 Oct 2007 13:53:38 GMT (envelope-from daichi@repoman.freebsd.org) Received: (from daichi@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EDrcam084275; Sun, 14 Oct 2007 13:53:38 GMT (envelope-from daichi) Message-Id: <200710141353.l9EDrcam084275@repoman.freebsd.org> From: Daichi GOTO Date: Sun, 14 Oct 2007 13:53:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/unionfs union_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 13:53:38 -0000 daichi 2007-10-14 13:53:38 UTC FreeBSD src repository Modified files: sys/fs/unionfs union_vfsops.c Log: Default copy mode has been changed from traditional-mode to transparent-mode. Some folks who have reported some issues have solved with transparent mode. We guess it is time to change the default copy mode. The transparent-mode is the best in most situations. Submitted by: Masanori Ozawa (unionfs developer) Reviewed by: jeff, kensmith Approved by: re (kensmith) MFC after: 1 week Revision Changes Path 1.85 +1 -1 src/sys/fs/unionfs/union_vfsops.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 13:55:38 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E70B116A468; Sun, 14 Oct 2007 13:55:38 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id BC0D413C44B; Sun, 14 Oct 2007 13:55:38 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EDtcNN085514; Sun, 14 Oct 2007 13:55:38 GMT (envelope-from daichi@repoman.freebsd.org) Received: (from daichi@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EDtcF6085513; Sun, 14 Oct 2007 13:55:38 GMT (envelope-from daichi) Message-Id: <200710141355.l9EDtcF6085513@repoman.freebsd.org> From: Daichi GOTO Date: Sun, 14 Oct 2007 13:55:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/mount_unionfs mount_unionfs.8 src/sys/fs/unionfs union.h union_vfsops.c union_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 13:55:39 -0000 daichi 2007-10-14 13:55:38 UTC FreeBSD src repository Modified files: sbin/mount_unionfs mount_unionfs.8 sys/fs/unionfs union.h union_vfsops.c union_vnops.c Log: Added whiteout behavior option. ``-o whiteout=always'' is default mode (it is established practice) and ``-o whiteout=whenneeded'' is less disk-space using mode especially for resource restricted environments like embedded environments. (Contributed by Ed Schouten. Thanks) Submitted by: Masanori Ozawa (unionfs developer) Reviewed by: jeff, kensmith Approved by: re (kensmith) MFC after: 1 week Revision Changes Path 1.23 +4 -0 src/sbin/mount_unionfs/mount_unionfs.8 1.36 +7 -0 src/sys/fs/unionfs/union.h 1.86 +17 -0 src/sys/fs/unionfs/union_vfsops.c 1.149 +8 -2 src/sys/fs/unionfs/union_vnops.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 13:57:12 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2BA6316A46D; Sun, 14 Oct 2007 13:57:12 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DC05E13C457; Sun, 14 Oct 2007 13:57:11 +0000 (UTC) (envelope-from daichi@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EDvBnQ087188; Sun, 14 Oct 2007 13:57:11 GMT (envelope-from daichi@repoman.freebsd.org) Received: (from daichi@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EDvBtO087187; Sun, 14 Oct 2007 13:57:11 GMT (envelope-from daichi) Message-Id: <200710141357.l9EDvBtO087187@repoman.freebsd.org> From: Daichi GOTO Date: Sun, 14 Oct 2007 13:57:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/nullfs null_subr.c null_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 13:57:12 -0000 daichi 2007-10-14 13:57:11 UTC FreeBSD src repository Modified files: sys/fs/nullfs null_subr.c null_vnops.c Log: This changes give nullfs correctly work with latest unionfs. Submitted by: Masanori Ozawa (unionfs developer) Reviewed by: jeff, kensmith Approved by: re (kensmith) MFC after: 1 week Revision Changes Path 1.52 +7 -0 src/sys/fs/nullfs/null_subr.c 1.96 +18 -5 src/sys/fs/nullfs/null_vnops.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 15:52:21 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 29A2E16A46B; Sun, 14 Oct 2007 15:52:21 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id D422A13C45A; Sun, 14 Oct 2007 15:52:20 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A5780E.dip.t-dialin.net [84.165.120.14]) by redbull.bpaserver.net (Postfix) with ESMTP id 4C2BC2E2AB; Sun, 14 Oct 2007 17:34:27 +0200 (CEST) Received: from deskjail (deskjail.Leidinger.net [192.168.1.109]) by outgoing.leidinger.net (Postfix) with ESMTP id 2F1395B480D; Sun, 14 Oct 2007 17:33:22 +0200 (CEST) Date: Sun, 14 Oct 2007 17:32:49 +0200 From: Alexander Leidinger To: "Rong-en Fan" Message-ID: <20071014173249.3c230033@deskjail> In-Reply-To: <6eb82e0710140524w4f4abb7fjaed35fae7625afec@mail.gmail.com> References: <6eb82e0710140524w4f4abb7fjaed35fae7625afec@mail.gmail.com> Organization: FreeBSD X-Mailer: Claws Mail 3.0.1 (GTK+ 2.10.14; i686-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-15.3, required 8, autolearn=not spam, BAYES_00 -15.00, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10, SMILEY -0.50) X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, cnst@freebsd.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 15:52:21 -0000 Quoting "Rong-en Fan" (Sun, 14 Oct 2007 20:24:10 +0800): > > Log: > > Import OpenBSD's sysctl hardware sensors framework. > > > [...] > > Submitted by: Constantine A. Murenin > > Sponsored by: Google Summer of Code 2007 (GSoC2007/cnst-sensors) > > Mentored by: syrinx > > Tested by: many > > OKed by: kensmith > > Obtained from: OpenBSD (parts) > > Great work, thanks Constantine! > I think it won't be in 7.0-R, but will it be merged back to 7-STABLE > (or even 6-STABLE) ? We discussed adding it for 7.0 with re@. The outcome is, that we commit it to HEAD and have a look how it works there. Theoretically it may be possible that it will see the light in 7.0. I expect it to show up in 7.1 (but if I get proven wrong, I don't mind ;-) ). Bye, Alexander. -- ...and that is how we know the Earth to be banana-shaped. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 From owner-cvs-src@FreeBSD.ORG Sun Oct 14 16:14:08 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 61B1B16A419; Sun, 14 Oct 2007 16:14:08 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id 96D5013C467; Sun, 14 Oct 2007 16:14:07 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id E48B317104; Sun, 14 Oct 2007 16:14:05 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id l9EGE5mx066401; Sun, 14 Oct 2007 16:14:05 GMT (envelope-from phk@critter.freebsd.dk) To: Alexander Leidinger From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sun, 14 Oct 2007 10:45:31 GMT." <200710141045.l9EAjW4m058732@repoman.freebsd.org> Date: Sun, 14 Oct 2007 16:14:05 +0000 Message-ID: <66400.1192378445@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 16:14:08 -0000 In message <200710141045.l9EAjW4m058732@repoman.freebsd.org>, Alexander Leiding er writes: > Log: > Import OpenBSD's sysctl hardware sensors framework. I would like to register a complaint about this commit. When this was discussed I objected that this entire pile of crap does not belong in the kernel. I still think this is a festering junkpile that does not belong in the kernel, and that his should be backed out, until a proper architectural solution has been found. Adding a new bogus type of device tree just because on cannot be bothered to do things right, is the road that leads to things like SYSV IPC and away from a sustainable architecture for an operating system which is here for the long term. Please back this out. Poul-Henning -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Sun Oct 14 16:14:32 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB31F16A47A; Sun, 14 Oct 2007 16:14:32 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A163213C4B0; Sun, 14 Oct 2007 16:14:32 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EGEWXa099927; Sun, 14 Oct 2007 16:14:32 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EGEW45099926; Sun, 14 Oct 2007 16:14:32 GMT (envelope-from thompsa) Message-Id: <200710141614.l9EGEW45099926@repoman.freebsd.org> From: Andrew Thompson Date: Sun, 14 Oct 2007 16:14:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs zfs_fm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 16:14:32 -0000 thompsa 2007-10-14 16:14:32 UTC FreeBSD src repository Modified files: sys/contrib/opensolaris/uts/common/fs/zfs zfs_fm.c Log: ZFS_LOG adds a newline by itself. Pointed out by: pjd Revision Changes Path 1.4 +1 -1 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_fm.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 16:19:12 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0D48816A46C for ; Sun, 14 Oct 2007 16:19:12 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.170]) by mx1.freebsd.org (Postfix) with ESMTP id 6948B13C459 for ; Sun, 14 Oct 2007 16:19:11 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: by ug-out-1314.google.com with SMTP id y2so246717uge for ; Sun, 14 Oct 2007 09:19:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer:sender; bh=EFyIZ22DJXCd5mVEBZ2SwmDdpqR8oEsiFv7xteBKZOU=; b=EpcfzDuFkYHp0/M5vZx1THzSv0hB/jSWkAupOxZpjEg1UCqdKpbt8Jf92DpKR6uVEOrm+DVlqrfCgMHDh87zIoOdc7WpuGHmeeCIKSerQ9Hb7VDuGoCghDQghv4nowhND8f8T97GhrUePCwuWv5cYCqiKPlort5QTVAQfJ6N6qY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer:sender; b=p9yqZQUsK7Dt7glg1N91LaRVGJMWb+qqleLFm8TrTIqGIwbcpqv0sDkSZP08+K+vZRNYRAmEvgkbWHeCFcmWGqRcIMEyfOi792+so+0tQdPuL0PHMLOqSVSWQ0YRSR2aHFGov7h6hDpKeXK1qm7txc+QTT3OVHIApfLpj5tAr9c= Received: by 10.66.216.8 with SMTP id o8mr6840260ugg.1192378750006; Sun, 14 Oct 2007 09:19:10 -0700 (PDT) Received: from ?10.0.0.13? ( [83.144.140.145]) by mx.google.com with ESMTPS id b36sm2072101ika.2007.10.14.09.19.05 (version=SSLv3 cipher=OTHER); Sun, 14 Oct 2007 09:19:09 -0700 (PDT) In-Reply-To: <66400.1192378445@critter.freebsd.dk> References: <66400.1192378445@critter.freebsd.dk> Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Rui Paulo Date: Sun, 14 Oct 2007 17:18:57 +0100 To: Poul-Henning Kamp X-Mailer: Apple Mail (2.752.3) Sender: Rui Paulo Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Alexander Leidinger , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 16:19:12 -0000 On 14 Oct 2007, at 17:14, Poul-Henning Kamp wrote: > In message <200710141045.l9EAjW4m058732@repoman.freebsd.org>, > Alexander Leiding > er writes: > >> Log: >> Import OpenBSD's sysctl hardware sensors framework. > > I would like to register a complaint about this commit. > > When this was discussed I objected that this entire pile of crap does > not belong in the kernel. > > I still think this is a festering junkpile that does not belong in > the kernel, and that his should be backed out, until a proper > architectural solution has been found. > > Adding a new bogus type of device tree just because on cannot be > bothered to do things right, is the road that leads to things like > SYSV IPC and away from a sustainable architecture for an operating > system which is here for the long term. What is your proposed solution? I read the discussion on perforce@ when it happened but from where I stand no consensus has been reached and no other solutions have been discussed. Regards. -- Rui Paulo From owner-cvs-src@FreeBSD.ORG Sun Oct 14 17:14:42 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2625016A418; Sun, 14 Oct 2007 17:14:42 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id CF22E13C469; Sun, 14 Oct 2007 17:14:41 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id 53E8917104; Sun, 14 Oct 2007 17:14:40 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id l9EHEcwK089546; Sun, 14 Oct 2007 17:14:39 GMT (envelope-from phk@critter.freebsd.dk) To: Rui Paulo From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sun, 14 Oct 2007 17:18:57 +0100." Date: Sun, 14 Oct 2007 17:14:38 +0000 Message-ID: <89545.1192382078@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Alexander Leidinger , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 17:14:42 -0000 In message , Rui Paulo writes: >>> Log: >>> Import OpenBSD's sysctl hardware sensors framework. >> >> I would like to register a complaint about this commit. >> >> When this was discussed I objected that this entire pile of crap does >> not belong in the kernel. >What is your proposed solution? To write som new code that works inside a sensible architectural framework that doesn't needlessly push tons of crap into the kernel. "Just because the code is available" is no reason to stick it in the FreeBSD kernel. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Sun Oct 14 17:19:22 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 991) id 2439716A421; Sun, 14 Oct 2007 17:19:22 +0000 (UTC) Date: Sun, 14 Oct 2007 17:19:22 +0000 From: Mark Linimon To: Poul-Henning Kamp Message-ID: <20071014171922.GA61934@hub.freebsd.org> References: <89545.1192382078@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <89545.1192382078@critter.freebsd.dk> User-Agent: Mutt/1.4.2.1i Cc: Rui Paulo , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Alexander Leidinger , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 17:19:22 -0000 On Sun, Oct 14, 2007 at 05:14:38PM +0000, Poul-Henning Kamp wrote: > To write some new code that works inside a sensible architectural > framework that doesn't needlessly push tons of crap into the kernel. I have already written a protest to core about the tone, timing, and public nature of your email. Since this is a) an architectural issue, and b) has already been made inflammatory, I strongly suggest that the issue be handled by core@ and not further argued on this mailing list. I will not be following this discussion further, pending their intervention. mcl From owner-cvs-src@FreeBSD.ORG Sun Oct 14 17:21:20 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 08E1A16A419; Sun, 14 Oct 2007 17:21:20 +0000 (UTC) (envelope-from wb@freebie.xs4all.nl) Received: from smtp-vbr6.xs4all.nl (smtp-vbr6.xs4all.nl [194.109.24.26]) by mx1.freebsd.org (Postfix) with ESMTP id 8C7AD13C459; Sun, 14 Oct 2007 17:21:19 +0000 (UTC) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (obsolete.xs4all.nl [82.95.250.254]) by smtp-vbr6.xs4all.nl (8.13.8/8.13.8) with ESMTP id l9EHLGgD020650; Sun, 14 Oct 2007 19:21:16 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.13.8/8.13.3) with ESMTP id l9EHLFPV024335; Sun, 14 Oct 2007 19:21:15 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: (from wb@localhost) by freebie.xs4all.nl (8.13.8/8.13.6/Submit) id l9EHLFpT024334; Sun, 14 Oct 2007 19:21:15 +0200 (CEST) (envelope-from wb) Date: Sun, 14 Oct 2007 19:21:15 +0200 From: Wilko Bulte To: Poul-Henning Kamp Message-ID: <20071014172115.GA24318@freebie.xs4all.nl> References: <89545.1192382078@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <89545.1192382078@critter.freebsd.dk> User-Agent: Mutt/1.5.11 X-Virus-Scanned: by XS4ALL Virus Scanner Cc: Rui Paulo , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Alexander Leidinger , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 17:21:20 -0000 Quoting Poul-Henning Kamp, who wrote on Sun, Oct 14, 2007 at 05:14:38PM +0000 .. > In message , Rui Paulo writes: > > >>> Log: > >>> Import OpenBSD's sysctl hardware sensors framework. > >> > >> I would like to register a complaint about this commit. > >> > >> When this was discussed I objected that this entire pile of crap does > >> not belong in the kernel. > > >What is your proposed solution? > > To write som new code that works inside a sensible architectural > framework that doesn't needlessly push tons of crap into the kernel. > > "Just because the code is available" is no reason to stick it in > the FreeBSD kernel. Poul, any chance you can make your comments sound a bit less like a personal attack and a bit more focused on the technical side of things? Much appreciated! Wilko (core hat) -- Wilko Bulte wilko@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Sun Oct 14 17:24:25 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BDFBB16A421 for ; Sun, 14 Oct 2007 17:24:25 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.190]) by mx1.freebsd.org (Postfix) with ESMTP id 43EE413C45A for ; Sun, 14 Oct 2007 17:24:25 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: by nf-out-0910.google.com with SMTP id b2so1078481nfb for ; Sun, 14 Oct 2007 10:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; bh=v35xbV4l9O2bVo3HRNTFb4yiVEUc3r6yexzDiJgFoPQ=; b=Qc9EivHBGyMQFtOgOWojykdcc52ukZZ0IgdoJNqJ1Xswbnqdd0897IYvw0BE0zOue9gyxbPZI7n499dEAXA9t6vnZXEhOConmDIbcY2HxMmjqoI5hPN0KO/ijZ99Z6GC+4eay0S0w4QMqkwS8ImCgIXOKz7DVGxe5vdHykywFKw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=dTtnVuPyL7TVK2ZzOwMosF8AGueAI9xDr3Y/Qgl/jCMqjntnwnYc9BGUM6Wv3szIl6vDrXId42hGHR6oZPiVKhKaw1jBcA4i8+RhL8xxsG5PC7hBDSZBBvF2TVfsemufQHLPWJ9vIPHfttw/w28gpJLovfsAOjzDPI/Pg6+OVhY= Received: by 10.86.98.18 with SMTP id v18mr4261644fgb.1192381189685; Sun, 14 Oct 2007 09:59:49 -0700 (PDT) Received: from roadrunner.spoerlein.net ( [85.180.138.72]) by mx.google.com with ESMTPS id w5sm5412461mue.2007.10.14.09.59.48 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 14 Oct 2007 09:59:49 -0700 (PDT) Received: from roadrunner.spoerlein.net (localhost [127.0.0.1]) by roadrunner.spoerlein.net (8.14.1/8.14.1) with ESMTP id l9EGxh5o003759; Sun, 14 Oct 2007 18:59:43 +0200 (CEST) (envelope-from uspoerlein@gmail.com) Received: (from q@localhost) by roadrunner.spoerlein.net (8.14.1/8.14.1/Submit) id l9EGxgRY003758; Sun, 14 Oct 2007 18:59:42 +0200 (CEST) (envelope-from uspoerlein@gmail.com) Date: Sun, 14 Oct 2007 18:59:42 +0200 From: Ulrich Spoerlein To: "Bjoern A. Zeeb" Message-ID: <20071014165942.GA1478@roadrunner.spoerlein.net> References: <200710120803.l9C83pLM093240@repoman.freebsd.org> <20071012081105.C6043@maildrop.int.zabbadoz.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071012081105.C6043@maildrop.int.zabbadoz.net> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Ruslan Ermilov , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.own.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 17:24:25 -0000 On Fri, 12.10.2007 at 08:27:47 +0000, Bjoern A. Zeeb wrote: > Is there any chance to get bind back w/o threading support? I guess > the question is more to Doug than to you. > > I found it usefull especially for (CF) installations where I > neither needed pppctl nor any other thing that depended on a threading > library but a caching nameserver. Going with a port for this > means supporting the ports infrastructure respectively an extra > installation procedure. Nothing that can't be done just extra pain;-) > So far it was easier to go with just base and live with the size of > named. Can't nscd aka cached be used for this now? Or is it not caching DNS lookups yet? Cheers, Ulrich Spoerlein -- It is better to remain silent and be thought a fool, than to speak, and remove all doubt. From owner-cvs-src@FreeBSD.ORG Sun Oct 14 17:32:46 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7466116A41B; Sun, 14 Oct 2007 17:32:46 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 2CA6A13C45A; Sun, 14 Oct 2007 17:32:46 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.1/8.14.1) with ESMTP id l9EHVjuW013777; Sun, 14 Oct 2007 11:31:45 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sun, 14 Oct 2007 11:32:07 -0600 (MDT) Message-Id: <20071014.113207.-432833794.imp@bsdimp.com> To: phk@phk.freebsd.dk From: "M. Warner Losh" In-Reply-To: <66400.1192378445@critter.freebsd.dk> References: <200710141045.l9EAjW4m058732@repoman.freebsd.org> <66400.1192378445@critter.freebsd.dk> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, netchild@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 17:32:46 -0000 In message: <66400.1192378445@critter.freebsd.dk> "Poul-Henning Kamp" writes: : In message <200710141045.l9EAjW4m058732@repoman.freebsd.org>, Alexander Leiding : er writes: : : > Log: : > Import OpenBSD's sysctl hardware sensors framework. : : I would like to register a complaint about this commit. : : When this was discussed I objected that this entire pile of crap does : not belong in the kernel. : : I still think this is a festering junkpile that does not belong in : the kernel, and that his should be backed out, until a proper : architectural solution has been found. : : Adding a new bogus type of device tree just because on cannot be : bothered to do things right, is the road that leads to things like : SYSV IPC and away from a sustainable architecture for an operating : system which is here for the long term. : : Please back this out. Seconded. I had a number of objects as well that seem to have been ignored. This is very bad form for a project that tries to work together by consensus. Warner From owner-cvs-src@FreeBSD.ORG Sun Oct 14 17:35:50 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A155F16A417; Sun, 14 Oct 2007 17:35:50 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 56FE913C455; Sun, 14 Oct 2007 17:35:50 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.1/8.14.1) with ESMTP id l9EHY6cv013843; Sun, 14 Oct 2007 11:34:06 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sun, 14 Oct 2007 11:34:29 -0600 (MDT) Message-Id: <20071014.113429.1649777355.imp@bsdimp.com> To: linimon@hub.freebsd.org From: "M. Warner Losh" In-Reply-To: <20071014171922.GA61934@hub.freebsd.org> References: <89545.1192382078@critter.freebsd.dk> <20071014171922.GA61934@hub.freebsd.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: rpaulo@fnop.net, src-committers@FreeBSD.org, netchild@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, phk@phk.freebsd.dk Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 17:35:50 -0000 In message: <20071014171922.GA61934@hub.freebsd.org> Mark Linimon writes: : On Sun, Oct 14, 2007 at 05:14:38PM +0000, Poul-Henning Kamp wrote: : > To write some new code that works inside a sensible architectural : > framework that doesn't needlessly push tons of crap into the kernel. : : I have already written a protest to core about the tone, timing, and : public nature of your email. : : Since this is a) an architectural issue, and b) has already been made : inflammatory, I strongly suggest that the issue be handled by core@ and : not further argued on this mailing list. I didn't find phk's tone all that objectionable, and I also objected to the framework going in. We've certainly had much worse in the past. : I will not be following this discussion further, pending their intervention. I'll not be participating in that discussion, since I have very strong objections to the commit that were totally blown off. Now I have to go and look closely to see if any of them were silently corrected based on my feedback. Warner From owner-cvs-src@FreeBSD.ORG Sun Oct 14 17:54:25 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3B85B16A51E; Sun, 14 Oct 2007 17:54:25 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id DFE0A13C45B; Sun, 14 Oct 2007 17:54:24 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id 69F0617104; Sun, 14 Oct 2007 17:54:22 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id l9EHsLDs024713; Sun, 14 Oct 2007 17:54:22 GMT (envelope-from phk@critter.freebsd.dk) To: Wilko Bulte , Alexander Leidinger , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sun, 14 Oct 2007 19:21:15 +0200." <20071014172115.GA24318@freebie.xs4all.nl> Date: Sun, 14 Oct 2007 17:54:21 +0000 Message-ID: <24712.1192384461@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 17:54:25 -0000 In message <20071014172115.GA24318@freebie.xs4all.nl>, Wilko Bulte writes: >Poul, any chance you can make your comments sound a bit less like a >personal attack and a bit more focused on the technical side of things? There is nothing personal in my complaint, and to underscore that, I will state for the record here that I have no complaint against with any of the persons involved. My only beef is with the architecture of the sensors framework, and as a consequence thereof, with the actual code as well. I think porting the sensors framework from OpenBSD to FreeBSD was a very worthwhile SoC task, since it allows people to see, running under FreeBSD what a mess it is architecturally. And as far as I know the porting has been carried out competently and well, fully living up to the SoC charter and rules. I have absolutely no problem with that part of the equation. But being successfull in a SoC sense of the task does not, and should not, imply that we will uncritically import the resulting code in FreeBSD without architectural review. In OpenBSD the sensors framework has already turned into a dumping ground, and I have all reason to belive that we will see the same under FreeBSD. See for instance Marc Balmers presentation from EuroBSDcon2007 about putting radio-timecode receivers under the sensors framework, or listen to the various mumblings about putting RAID-controller status under sensors framework. IFF we want to have a general catch-all framework for representing any oddball state, LED or measurement in the computer, then we want it to be much better structured than the code we are discussing now. But it is not even clear to me that we want such a framework, it makes much more sense to keep the various indicators, measurements and other input in their respective subsystems. And IFF we add such an amount of code to FreeBSD, we want to have it properly integrate into our kernel, using our device discovery and registration (newbus) and not probing random (i2c) busses willy nilly. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Sun Oct 14 17:58:59 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7313516A41A; Sun, 14 Oct 2007 17:58:59 +0000 (UTC) (envelope-from wb@freebie.xs4all.nl) Received: from smtp-vbr12.xs4all.nl (smtp-vbr12.xs4all.nl [194.109.24.32]) by mx1.freebsd.org (Postfix) with ESMTP id 0215213C44B; Sun, 14 Oct 2007 17:58:58 +0000 (UTC) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (obsolete.xs4all.nl [82.95.250.254]) by smtp-vbr12.xs4all.nl (8.13.8/8.13.8) with ESMTP id l9EHwvYq049695; Sun, 14 Oct 2007 19:58:57 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.13.8/8.13.3) with ESMTP id l9EHwud2024733; Sun, 14 Oct 2007 19:58:56 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: (from wb@localhost) by freebie.xs4all.nl (8.13.8/8.13.6/Submit) id l9EHwuvh024732; Sun, 14 Oct 2007 19:58:56 +0200 (CEST) (envelope-from wb) Date: Sun, 14 Oct 2007 19:58:56 +0200 From: Wilko Bulte To: Poul-Henning Kamp Message-ID: <20071014175856.GA24719@freebie.xs4all.nl> References: <20071014172115.GA24318@freebie.xs4all.nl> <24712.1192384461@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24712.1192384461@critter.freebsd.dk> User-Agent: Mutt/1.5.11 X-Virus-Scanned: by XS4ALL Virus Scanner Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, Alexander Leidinger , cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 17:58:59 -0000 Quoting Poul-Henning Kamp, who wrote on Sun, Oct 14, 2007 at 05:54:21PM +0000 .. > In message <20071014172115.GA24318@freebie.xs4all.nl>, Wilko Bulte writes: > > >Poul, any chance you can make your comments sound a bit less like a > >personal attack and a bit more focused on the technical side of things? > > There is nothing personal in my complaint, and to underscore that, > I will state for the record here that I have no complaint against > with any of the persons involved. > > My only beef is with the architecture of the sensors framework, and > as a consequence thereof, with the actual code as well. Sorry, the "pile of crap" did sound rather unpleasant (and personal) to my ears. But apparantly I misinterpreted the intent of your mail. Wilko -- Wilko Bulte wilko@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Sun Oct 14 18:16:49 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5D31C16A419; Sun, 14 Oct 2007 18:16:49 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 24C3E13C461; Sun, 14 Oct 2007 18:16:49 +0000 (UTC) (envelope-from sam@errno.com) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id l9EIGmFJ049921 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 14 Oct 2007 11:16:48 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <47125D10.4080704@errno.com> Date: Sun, 14 Oct 2007 11:16:48 -0700 From: Sam Leffler User-Agent: Thunderbird 2.0.0.6 (X11/20070814) MIME-Version: 1.0 To: Poul-Henning Kamp References: <66400.1192378445@critter.freebsd.dk> In-Reply-To: <66400.1192378445@critter.freebsd.dk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC-dcc.uncw.edu-Metrics: m; whitelist Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Alexander Leidinger , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 18:16:49 -0000 Poul-Henning Kamp wrote: > In message <200710141045.l9EAjW4m058732@repoman.freebsd.org>, Alexander Leiding > er writes: > > >> Log: >> Import OpenBSD's sysctl hardware sensors framework. >> > > I would like to register a complaint about this commit. > > When this was discussed I objected that this entire pile of crap does > not belong in the kernel. > > I still think this is a festering junkpile that does not belong in > the kernel, and that his should be backed out, until a proper > architectural solution has been found. > > Adding a new bogus type of device tree just because on cannot be > bothered to do things right, is the road that leads to things like > SYSV IPC and away from a sustainable architecture for an operating > system which is here for the long term. > > Please back this out. > I'd have to agree that these changes need more buy in and review. I recall many folks voiced complaints when the work was submitted to p4. There are basic design issues that need to be resolved such as whether code that's been added to the kernel is needed (instead of doing user-space drivers). Having kernel support is usually dependent on whether it's infeasible to do the work in user space and/or using the results within the kernel. I also took a quick glance at the 2 drivers that were added and see multiple issues that indicate this code needs more review (possible div-by-zero, lack of newbus integration, probing i2c devices, etc). I was very happy to see this SoC project happen and I think users could benefit from a common sensor framework but I'd like to see one that is a better fit to freebsd. Sam From owner-cvs-src@FreeBSD.ORG Sun Oct 14 18:48:27 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0A7F416A46B for ; Sun, 14 Oct 2007 18:48:27 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id BECA713C46A for ; Sun, 14 Oct 2007 18:48:26 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 24227 invoked from network); 14 Oct 2007 18:48:27 -0000 Received: from ppp-71-139-1-224.dsl.snfc21.pacbell.net (HELO ?10.0.5.18?) (nate-mail@71.139.1.224) by root.org with ESMTPA; 14 Oct 2007 18:48:27 -0000 Message-ID: <47126474.9010108@root.org> Date: Sun, 14 Oct 2007 11:48:20 -0700 From: Nate Lawson User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Alexander Leidinger References: <20071014105947.D096C16A57E@hub.freebsd.org> In-Reply-To: <20071014105947.D096C16A57E@hub.freebsd.org> X-Enigmail-Version: 0.95.3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@FreeBSD.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/share/man/man4 coretemp.4 src/sys/dev/coretemp coretemp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 18:48:27 -0000 Alexander Leidinger wrote: > netchild 2007-10-14 10:59:44 UTC > > FreeBSD src repository > > Modified files: > share/man/man4 coretemp.4 > sys/dev/coretemp coretemp.c > Log: > Convert coretemp(4) to the hardware sensors framework and > make sure to never call sched_bind() for uninitialised CPUs. > > Submitted by: Constantine A. Murenin > Sponsored by: Google Summer of Code 2007 (GSoC2007/cnst-sensors) > Mentored by: syrinx > Tested by: many > OKed by: kensmith > > Revision Changes Path > 1.2 +14 -6 src/share/man/man4/coretemp.4 > 1.3 +46 -35 src/sys/dev/coretemp/coretemp.c > - thread_lock(curthread); > - sched_unbind(curthread); > - thread_unlock(curthread); > + * Bind to specific CPU to read the correct temperature. > + * If not all CPUs are initialised, then only read from > + * cpu0, returning -1 on all other CPUs. > + */ > + if (smp_cpus > 1) { > + thread_lock(curthread); > + sched_bind(curthread, cpu); > + msr = rdmsr(MSR_THERM_STATUS); > + sched_unbind(curthread); > + thread_unlock(curthread); > + } else if (cpu != 0) > + return (-1); > + else > + msr = rdmsr(MSR_THERM_STATUS); I reviewed this part of the patch for Rui Paulo and told him to use smp_active instead of smp_cpus > 1. -- Nate From owner-cvs-src@FreeBSD.ORG Sun Oct 14 18:55:08 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4B9C916A420; Sun, 14 Oct 2007 18:55:08 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id EF93213C4A5; Sun, 14 Oct 2007 18:55:07 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 0422A41C707; Sun, 14 Oct 2007 20:55:06 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id xb6Ba7scQ+SO; Sun, 14 Oct 2007 20:55:05 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id 79CCB41C736; Sun, 14 Oct 2007 20:55:05 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 5DBBA444885; Sun, 14 Oct 2007 18:53:39 +0000 (UTC) Date: Sun, 14 Oct 2007 18:53:38 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: src-committers@FreeBSD.org In-Reply-To: <200710141045.l9EAjW4m058732@repoman.freebsd.org> Message-ID: <20071014183307.U6043@maildrop.int.zabbadoz.net> References: <200710141045.l9EAjW4m058732@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 18:55:08 -0000 On Sun, 14 Oct 2007, Alexander Leidinger wrote: > netchild 2007-10-14 10:45:31 UTC > > FreeBSD src repository > > Log: > Import OpenBSD's sysctl hardware sensors framework. .. > Submitted by: Constantine A. Murenin > Sponsored by: Google Summer of Code 2007 (GSoC2007/cnst-sensors) > Mentored by: syrinx Just for the archives... I am not going to talk about the code just a comment on the Mentored by: as this might be misleading and not be fully obvious to everyone, especially to a non-committer in 5 years. Not netchild was mentored by syrinx but cnst was mentored by syrinx for GSoC 2007 under our "terms and thinking" for GSoC which is not the same as "being mentored as a new src committer" and doesn't reflect the same duties, etc... -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT Software is harder than hardware so better get it right the first time. From owner-cvs-src@FreeBSD.ORG Sun Oct 14 18:57:33 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E24D016A41B; Sun, 14 Oct 2007 18:57:33 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B3AAF13C467; Sun, 14 Oct 2007 18:57:33 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EIvXBN021854; Sun, 14 Oct 2007 18:57:33 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EIvXg8021853; Sun, 14 Oct 2007 18:57:33 GMT (envelope-from ru) Message-Id: <200710141857.l9EIvXg8021853@repoman.freebsd.org> From: Ruslan Ermilov Date: Sun, 14 Oct 2007 18:57:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/gen sysctl.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 18:57:34 -0000 ru 2007-10-14 18:57:33 UTC FreeBSD src repository Modified files: lib/libc/gen sysctl.3 Log: Fix mdoc in last commit. Revision Changes Path 1.71 +15 -13 src/lib/libc/gen/sysctl.3 From owner-cvs-src@FreeBSD.ORG Sun Oct 14 19:01:29 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D6D5B16A419; Sun, 14 Oct 2007 19:01:29 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A8C5F13C447; Sun, 14 Oct 2007 19:01:29 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EJ1TCA022201; Sun, 14 Oct 2007 19:01:29 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EJ1T69022200; Sun, 14 Oct 2007 19:01:29 GMT (envelope-from ru) Message-Id: <200710141901.l9EJ1T69022200@repoman.freebsd.org> From: Ruslan Ermilov Date: Sun, 14 Oct 2007 19:01:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man5 rc.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 19:01:29 -0000 ru 2007-10-14 19:01:28 UTC FreeBSD src repository Modified files: share/man/man5 rc.conf.5 Log: Remove trailing whitespace. Revision Changes Path 1.329 +2 -2 src/share/man/man5/rc.conf.5 From owner-cvs-src@FreeBSD.ORG Sun Oct 14 19:11:02 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F386216A420; Sun, 14 Oct 2007 19:11:01 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C479813C467; Sun, 14 Oct 2007 19:11:01 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EJB1pO023860; Sun, 14 Oct 2007 19:11:01 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EJB1Nd023858; Sun, 14 Oct 2007 19:11:01 GMT (envelope-from ru) Message-Id: <200710141911.l9EJB1Nd023858@repoman.freebsd.org> From: Ruslan Ermilov Date: Sun, 14 Oct 2007 19:11:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man9 sensor_attach.9 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 19:11:02 -0000 ru 2007-10-14 19:11:01 UTC FreeBSD src repository Modified files: share/man/man9 sensor_attach.9 Log: Fix mdoc. Revision Changes Path 1.2 +22 -11 src/share/man/man9/sensor_attach.9 From owner-cvs-src@FreeBSD.ORG Sun Oct 14 19:12:37 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5AC5B16A418; Sun, 14 Oct 2007 19:12:37 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2C5EF13C474; Sun, 14 Oct 2007 19:12:37 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EJCb95024040; Sun, 14 Oct 2007 19:12:37 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EJCb8Y024039; Sun, 14 Oct 2007 19:12:37 GMT (envelope-from ru) Message-Id: <200710141912.l9EJCb8Y024039@repoman.freebsd.org> From: Ruslan Ermilov Date: Sun, 14 Oct 2007 19:12:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/systat systat.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 19:12:37 -0000 ru 2007-10-14 19:12:36 UTC FreeBSD src repository Modified files: usr.bin/systat systat.1 Log: Bump document date for the last change. Revision Changes Path 1.55 +1 -1 src/usr.bin/systat/systat.1 From owner-cvs-src@FreeBSD.ORG Sun Oct 14 19:21:01 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9C15C16A418; Sun, 14 Oct 2007 19:21:01 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6A80A13C45A; Sun, 14 Oct 2007 19:21:01 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EJL1x4024341; Sun, 14 Oct 2007 19:21:01 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EJL0YV024327; Sun, 14 Oct 2007 19:21:00 GMT (envelope-from ru) Message-Id: <200710141921.l9EJL0YV024327@repoman.freebsd.org> From: Ruslan Ermilov Date: Sun, 14 Oct 2007 19:20:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 19:21:01 -0000 ru 2007-10-14 19:20:59 UTC FreeBSD src repository Modified files: usr.sbin Makefile Log: Sort. Revision Changes Path 1.377 +1 -1 src/usr.sbin/Makefile From owner-cvs-src@FreeBSD.ORG Sun Oct 14 19:23:39 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 06E6416A417; Sun, 14 Oct 2007 19:23:39 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id CA8FA13C447; Sun, 14 Oct 2007 19:23:38 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EJNcO9024599; Sun, 14 Oct 2007 19:23:38 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EJNcwY024598; Sun, 14 Oct 2007 19:23:38 GMT (envelope-from ru) Message-Id: <200710141923.l9EJNcwY024598@repoman.freebsd.org> From: Ruslan Ermilov Date: Sun, 14 Oct 2007 19:23:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/sensorsd Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 19:23:39 -0000 ru 2007-10-14 19:23:38 UTC FreeBSD src repository Modified files: usr.sbin/sensorsd Makefile Log: style.Makefile(5) says: Do not use GCCisms (such as -g and -Wall) in CFLAGS. Revision Changes Path 1.2 +1 -3 src/usr.sbin/sensorsd/Makefile From owner-cvs-src@FreeBSD.ORG Sun Oct 14 19:38:11 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B949016A417; Sun, 14 Oct 2007 19:38:11 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8845113C448; Sun, 14 Oct 2007 19:38:11 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EJcBUr025292; Sun, 14 Oct 2007 19:38:11 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EJcBDG025290; Sun, 14 Oct 2007 19:38:11 GMT (envelope-from ru) Message-Id: <200710141938.l9EJcBDG025290@repoman.freebsd.org> From: Ruslan Ermilov Date: Sun, 14 Oct 2007 19:38:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/sensorsd sensorsd.8 sensorsd.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 19:38:11 -0000 ru 2007-10-14 19:38:11 UTC FreeBSD src repository Modified files: usr.sbin/sensorsd sensorsd.8 sensorsd.conf.5 Log: Fix makrup. There are still some OpenBSD-specific things in there that need tweaking. Revision Changes Path 1.2 +8 -7 src/usr.sbin/sensorsd/sensorsd.8 1.2 +32 -22 src/usr.sbin/sensorsd/sensorsd.conf.5 From owner-cvs-src@FreeBSD.ORG Sun Oct 14 19:40:17 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6B08D16A41B; Sun, 14 Oct 2007 19:40:17 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3355813C458; Sun, 14 Oct 2007 19:40:16 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EJeF1W025430; Sun, 14 Oct 2007 19:40:16 GMT (envelope-from emaste@repoman.freebsd.org) Received: (from emaste@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EJeFof025429; Sun, 14 Oct 2007 19:40:15 GMT (envelope-from emaste) Message-Id: <200710141940.l9EJeFof025429@repoman.freebsd.org> From: Ed Maste Date: Sun, 14 Oct 2007 19:40:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/aac aac_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 19:40:17 -0000 emaste 2007-10-14 19:40:15 UTC FreeBSD src repository Modified files: sys/dev/aac aac_pci.c Log: Add PCI IDs from Adaptec's driver version b11669: Adaptec RAID 3085 Adaptec RAID 31205 Adaptec RAID 31605 Adaptec RAID 5085 Adaptec RAID 51205 Adaptec RAID 51605 Adaptec RAID 5445 Adaptec RAID 5805 IBM ServeRAID 8s ICP RAID ICP5045BL ICP RAID ICP5085BL ICP RAID ICP5085SL ICP RAID ICP5125BR ICP RAID ICP5125SL ICP RAID ICP5165BR ICP RAID ICP5165SL ICP RAID ICP5445SL ICP RAID ICP5805BL ICP RAID ICP5805SL ICP9067MA SATA RAID Revision Changes Path 1.63 +42 -0 src/sys/dev/aac/aac_pci.c From owner-cvs-src@FreeBSD.ORG Sun Oct 14 19:55:33 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3CF4916A418; Sun, 14 Oct 2007 19:55:33 +0000 (UTC) (envelope-from lme@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0B42D13C44B; Sun, 14 Oct 2007 19:55:33 +0000 (UTC) (envelope-from lme@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EJtW4T026258; Sun, 14 Oct 2007 19:55:32 GMT (envelope-from lme@repoman.freebsd.org) Received: (from lme@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9EJtWcQ026257; Sun, 14 Oct 2007 19:55:32 GMT (envelope-from lme) Message-Id: <200710141955.l9EJtWcQ026257@repoman.freebsd.org> From: Lars Engels Date: Sun, 14 Oct 2007 19:55:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/calendar/calendars calendar.freebsd X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 19:55:33 -0000 lme 2007-10-14 19:55:32 UTC FreeBSD src repository (ports committer) Modified files: usr.bin/calendar/calendars calendar.freebsd Log: Add myself to the FreeBSD calendar. Approved by: miwi (mentor) Revision Changes Path 1.220 +1 -0 src/usr.bin/calendar/calendars/calendar.freebsd From owner-cvs-src@FreeBSD.ORG Mon Oct 15 02:43:40 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7214016A417; Mon, 15 Oct 2007 02:43:40 +0000 (UTC) (envelope-from sepotvin@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 4203D13C4B7; Mon, 15 Oct 2007 02:43:40 +0000 (UTC) (envelope-from sepotvin@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9F2heBf076693; Mon, 15 Oct 2007 02:43:40 GMT (envelope-from sepotvin@repoman.freebsd.org) Received: (from sepotvin@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9F2he9P076692; Mon, 15 Oct 2007 02:43:40 GMT (envelope-from sepotvin) Message-Id: <200710150243.l9F2he9P076692@repoman.freebsd.org> From: "Stephane E. Potvin" Date: Mon, 15 Oct 2007 02:43:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/pci pcireg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 02:43:40 -0000 sepotvin 2007-10-15 02:43:39 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/pci pcireg.h Log: MFC: - Fix a small bit slip in PCIM_PCAP_D[0-2]PME defines. - Add the definitions for D3PME_COLD and D3PME_HOT capabilities. Approved by: njl (mentor) Revision Changes Path 1.45.2.9 +5 -3 src/sys/dev/pci/pcireg.h From owner-cvs-src@FreeBSD.ORG Mon Oct 15 06:16:21 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C097816A417; Mon, 15 Oct 2007 06:16:21 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 1468A13C458; Mon, 15 Oct 2007 06:16:20 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A57699.dip.t-dialin.net [84.165.118.153]) by redbull.bpaserver.net (Postfix) with ESMTP id 23DA32E1BC; Mon, 15 Oct 2007 08:16:13 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id D390B5B480D; Mon, 15 Oct 2007 08:15:07 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.1/8.13.8/Submit) id l9F6F7rL022172; Mon, 15 Oct 2007 08:15:07 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Mon, 15 Oct 2007 08:15:07 +0200 Message-ID: <20071015081507.yi9t4ot8asg0wcw4@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Mon, 15 Oct 2007 08:15:07 +0200 From: Alexander Leidinger To: Poul-Henning Kamp References: <24712.1192384461@critter.freebsd.dk> In-Reply-To: <24712.1192384461@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.8, required 8, BAYES_00 -15.00, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10) X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: Wilko Bulte , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 06:16:21 -0000 Quoting Poul-Henning Kamp (from Sun, 14 Oct 2007 =20 17:54:21 +0000): > My only beef is with the architecture of the sensors framework, and > as a consequence thereof, with the actual code as well. When I asked you about a proposal how a better architecture looks =20 like, you didn't came up with an explanation and you didn't came up =20 with a list of things which you think are bad in the sensors =20 framework. You also didn't respond to counterarguments from me. I don't think it is fair to make such a noise, without coming up with =20 technical facts. Note: I don't object to backing out the commit. But as this seems to =20 be on the desk of core@, I wait for their decision regarding this (as =20 it is self contained and doesn't interfere with other stuff, we don't =20 need to hurry). > In OpenBSD the sensors framework has already turned into a dumping > ground, and I have all reason to belive that we will see the same > under FreeBSD. It will be what we make out of this. > See for instance Marc Balmers presentation from EuroBSDcon2007 about > putting radio-timecode receivers under the sensors framework, or I don't see a need to port this part instead of using the existing =20 time-infrastructure in our kernel (and I don't have my fingers in the =20 time related code at all like you, so I hope other people think =20 similar). > listen to the various mumblings about putting RAID-controller status > under sensors framework. What's wrong with this? Currently each RAID driver has to come up with =20 his own way of displaying the RAID status. It's like saying that each =20 network driver has to implement/display the stuff you can see with =20 ifconfig in its own way, instead of using the proper network driver =20 interface for this. > IFF we want to have a general catch-all framework for representing > any oddball state, LED or measurement in the computer, then we want > it to be much better structured than the code we are discussing now. Again, please point out specific deficits, so that Constantine and =20 others can explain why it is like it is and may be able to come up =20 with improvements which address your concerns. > But it is not even clear to me that we want such a framework, it makes > much more sense to keep the various indicators, measurements and > other input in their respective subsystems. We're back to the old discussion... please have a look there. You =20 failed to respond with a technical counterargument when I presented =20 the reasons why a framework to export sensoric data out of the kernel =20 is good to have (in short: similar reason why we have a standard way =20 of exporting status data from the network interface to ifconfig). > And IFF we add such an amount of code to FreeBSD, we want to have it > properly integrate into our kernel, using our device discovery > and registration (newbus) and not probing random (i2c) busses willy > nilly. Could you please explain how you want to integrate devices with =20 newbus, which are only accessible via the i2c bus? Feel free to show =20 us example code for one of those of our drivers which access the i2c =20 bus, which already existed before this commit. Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 GREAT MOMENTS IN AMERICAN HISTORY (#17): On November 13, Felix Unger was asked to remove himself from his place of residence. From owner-cvs-src@FreeBSD.ORG Mon Oct 15 07:13:10 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5DF0616A41A; Mon, 15 Oct 2007 07:13:10 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id 111D413C45A; Mon, 15 Oct 2007 07:13:09 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id 57EA317104; Mon, 15 Oct 2007 07:13:08 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id l9F7D7rM044702; Mon, 15 Oct 2007 07:13:08 GMT (envelope-from phk@critter.freebsd.dk) To: Alexander Leidinger From: "Poul-Henning Kamp" In-Reply-To: Your message of "Mon, 15 Oct 2007 08:15:07 +0200." <20071015081507.yi9t4ot8asg0wcw4@webmail.leidinger.net> Date: Mon, 15 Oct 2007 07:13:07 +0000 Message-ID: <44701.1192432387@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: Wilko Bulte , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 07:13:10 -0000 In message <20071015081507.yi9t4ot8asg0wcw4@webmail.leidinger.net>, Alexander L eidinger writes: >Quoting Poul-Henning Kamp (from Sun, 14 Oct 2007 >17:54:21 +0000): > >> My only beef is with the architecture of the sensors framework, and >> as a consequence thereof, with the actual code as well. > >When I asked you about a proposal how a better architecture looks >like, you didn't came up with an explanation and you didn't came up >with a list of things which you think are bad in the sensors >framework. You also didn't respond to counterarguments from me. > >[...] > >Could you please explain how you want to integrate devices with >newbus, which are only accessible via the i2c bus? Feel free to show >us example code for one of those of our drivers which access the i2c >bus, which already existed before this commit. So, lets see how that works: I propose that we write our own C/C++ compiler in perl. You object to that. Then I tell you: Now YOU have to write the compiler. No, I didn't think so either :-) I have several times in the past pointed out why it is a very bad idea to add a unstructured dumping ground to the kernel, and why it is bad to stick code in the kernel that can easier live in userland. Right now, the people who advocate importing the OpenBSD sensor framework need to tell us, in a coherent architecture document: A) Why we need it B) Why so much of it ends in the kernel C) How it integrates into FreeBSD and for the places where it does not (newbus ?) why it doesn't. Poul-Henning -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Mon Oct 15 07:48:47 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 73FCF16A417; Mon, 15 Oct 2007 07:48:47 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 5F57513C45A; Mon, 15 Oct 2007 07:48:46 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l9F7mV5T063961; Mon, 15 Oct 2007 01:48:32 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <47131B2F.1060900@samsco.org> Date: Mon, 15 Oct 2007 01:47:59 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: Alexander Leidinger References: <24712.1192384461@critter.freebsd.dk> <20071015081507.yi9t4ot8asg0wcw4@webmail.leidinger.net> In-Reply-To: <20071015081507.yi9t4ot8asg0wcw4@webmail.leidinger.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Mon, 15 Oct 2007 01:48:33 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: Wilko Bulte , Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 07:48:47 -0000 Alexander Leidinger wrote: > Quoting Poul-Henning Kamp (from Sun, 14 Oct 2007 > 17:54:21 +0000): > >> My only beef is with the architecture of the sensors framework, and >> as a consequence thereof, with the actual code as well. > > When I asked you about a proposal how a better architecture looks like, > you didn't came up with an explanation and you didn't came up with a > list of things which you think are bad in the sensors framework. You > also didn't respond to counterarguments from me. > > I don't think it is fair to make such a noise, without coming up with > technical facts. > > Note: I don't object to backing out the commit. But as this seems to be > on the desk of core@, I wait for their decision regarding this (as it is > self contained and doesn't interfere with other stuff, we don't need to > hurry). > >> In OpenBSD the sensors framework has already turned into a dumping >> ground, and I have all reason to belive that we will see the same >> under FreeBSD. > > It will be what we make out of this. > >> See for instance Marc Balmers presentation from EuroBSDcon2007 about >> putting radio-timecode receivers under the sensors framework, or > > I don't see a need to port this part instead of using the existing > time-infrastructure in our kernel (and I don't have my fingers in the > time related code at all like you, so I hope other people think similar). > >> listen to the various mumblings about putting RAID-controller status >> under sensors framework. > > What's wrong with this? Currently each RAID driver has to come up with > his own way of displaying the RAID status. It's like saying that each > network driver has to implement/display the stuff you can see with > ifconfig in its own way, instead of using the proper network driver > interface for this. > For the love of God, please don't use RAID as an example to support your argument for the sensord framework. Representing RAID state is several orders of magnitude more involved than representing network state. There are also landmines in the OpenBSD bits of RAID support that are best left out of FreeBSD, unless you like alienating vendors and risking legal action. Leave it alone. Please. I don't care what you do with lmsensors or cpu power settings or whatever. Leave RAID out of it. Thanks, Scott From owner-cvs-src@FreeBSD.ORG Mon Oct 15 08:06:43 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 72BB816A41B; Mon, 15 Oct 2007 08:06:43 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 4AB6313C448; Mon, 15 Oct 2007 08:06:43 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9F86hAr009399; Mon, 15 Oct 2007 08:06:43 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9F86gGt009393; Mon, 15 Oct 2007 08:06:43 GMT (envelope-from ru) Message-Id: <200710150806.l9F86gGt009393@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 15 Oct 2007 08:06:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/gnu/usr.bin/groff/tmac mdoc.local X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 08:06:43 -0000 ru 2007-10-15 08:06:42 UTC FreeBSD src repository Modified files: gnu/usr.bin/groff/tmac mdoc.local Log: Introduce FreeBSD 8.0 to mdoc(7). Revision Changes Path 1.60 +1 -0 src/gnu/usr.bin/groff/tmac/mdoc.local From owner-cvs-src@FreeBSD.ORG Mon Oct 15 08:07:15 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E82DC16A481; Mon, 15 Oct 2007 08:07:15 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C11DD13C467; Mon, 15 Oct 2007 08:07:15 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9F87FM3009469; Mon, 15 Oct 2007 08:07:15 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9F87FqV009468; Mon, 15 Oct 2007 08:07:15 GMT (envelope-from ru) Message-Id: <200710150807.l9F87FqV009468@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 15 Oct 2007 08:07:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 it.4 lm.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 08:07:16 -0000 ru 2007-10-15 08:07:15 UTC FreeBSD src repository Modified files: share/man/man4 it.4 lm.4 Log: Fix markup. Revision Changes Path 1.2 +7 -6 src/share/man/man4/it.4 1.2 +6 -5 src/share/man/man4/lm.4 From owner-cvs-src@FreeBSD.ORG Mon Oct 15 08:17:14 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6A89416A41A; Mon, 15 Oct 2007 08:17:14 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 43B3213C474; Mon, 15 Oct 2007 08:17:14 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9F8HE5O010706; Mon, 15 Oct 2007 08:17:14 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9F8HEQx010705; Mon, 15 Oct 2007 08:17:14 GMT (envelope-from ru) Message-Id: <200710150817.l9F8HEQx010705@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 15 Oct 2007 08:17:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 08:17:14 -0000 ru 2007-10-15 08:17:12 UTC FreeBSD src repository Modified files: share/man/man4 Makefile Log: Sort. Revision Changes Path 1.395 +6 -6 src/share/man/man4/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 15 08:26:13 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EDA2116A419; Mon, 15 Oct 2007 08:26:13 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C787513C46A; Mon, 15 Oct 2007 08:26:13 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9F8QDwV011226; Mon, 15 Oct 2007 08:26:13 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9F8QDiF011225; Mon, 15 Oct 2007 08:26:13 GMT (envelope-from ru) Message-Id: <200710150826.l9F8QDiF011225@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 15 Oct 2007 08:26:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/modules Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 08:26:14 -0000 ru 2007-10-15 08:26:12 UTC FreeBSD src repository Modified files: sys/modules Makefile Log: Sort. Revision Changes Path 1.542 +10 -10 src/sys/modules/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 15 08:29:54 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0DD4516A417; Mon, 15 Oct 2007 08:29:54 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DBE4C13C468; Mon, 15 Oct 2007 08:29:53 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9F8Troj011338; Mon, 15 Oct 2007 08:29:53 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9F8Tr9t011337; Mon, 15 Oct 2007 08:29:53 GMT (envelope-from ru) Message-Id: <200710150829.l9F8Tr9t011337@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 15 Oct 2007 08:29:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man4 coretemp.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 08:29:54 -0000 ru 2007-10-15 08:29:53 UTC FreeBSD src repository Modified files: share/man/man4 coretemp.4 Log: Markup nit. Revision Changes Path 1.3 +1 -1 src/share/man/man4/coretemp.4 From owner-cvs-src@FreeBSD.ORG Mon Oct 15 09:13:14 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0358816A419 for ; Mon, 15 Oct 2007 09:13:14 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.190]) by mx1.freebsd.org (Postfix) with ESMTP id 7374C13C45A for ; Mon, 15 Oct 2007 09:13:13 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: by nf-out-0910.google.com with SMTP id b2so1193779nfb for ; Mon, 15 Oct 2007 02:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer:sender; bh=19vBIJSo9F6WTkyE6Rz9wRnRyWSdT5mvh0JKNlbLV8U=; b=YvcU0MoOi5t4dZOT1SQEmtsuPvGL+n+wabm14NxCCT+Kbxrg9Tqz3+xAwen1CMeC1w5Uxru9vezKdwJxnT/eO9AjAl91Ld714DPgfpTAuvZmfrFgIH0fivWjUno53OKjmKWtrEdSVMK7J8V2jRTrsEX28oNk1WGKPSx4KG0htkE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer:sender; b=fKLJfT3lyhFkfcgXKZzht+VBO3H0u30xJSIhQ98pWN5EYMogEt0OrapjJzRvP9EM2ess63MGIoOh3D1oAesjKck++bReJmWtR2/vg8+kl1VEvO0HwXD19Zw2MmfCWLxKvLi5NvXCcJUcDgilMnHIMYFJHgTmq4LWDL/xW/bQUgE= Received: by 10.86.99.9 with SMTP id w9mr4800923fgb.1192439592204; Mon, 15 Oct 2007 02:13:12 -0700 (PDT) Received: from ?172.17.8.222? ( [193.136.24.210]) by mx.google.com with ESMTPS id 31sm7453219fkt.2007.10.15.02.13.10 (version=SSLv3 cipher=OTHER); Mon, 15 Oct 2007 02:13:11 -0700 (PDT) In-Reply-To: <47126474.9010108@root.org> References: <20071014105947.D096C16A57E@hub.freebsd.org> <47126474.9010108@root.org> Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Rui Paulo Date: Mon, 15 Oct 2007 10:13:01 +0100 To: Nate Lawson X-Mailer: Apple Mail (2.752.3) Sender: Rui Paulo Cc: cvs-src@freebsd.org, src-committers@FreeBSD.org, Alexander Leidinger , cvs-all@freebsd.org Subject: Re: cvs commit: src/share/man/man4 coretemp.4 src/sys/dev/coretemp coretemp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 09:13:14 -0000 On 14 Oct 2007, at 19:48, Nate Lawson wrote: > Alexander Leidinger wrote: >> netchild 2007-10-14 10:59:44 UTC >> >> FreeBSD src repository >> >> Modified files: >> share/man/man4 coretemp.4 >> sys/dev/coretemp coretemp.c >> Log: >> Convert coretemp(4) to the hardware sensors framework and >> make sure to never call sched_bind() for uninitialised CPUs. >> >> Submitted by: Constantine A. Murenin >> Sponsored by: Google Summer of Code 2007 (GSoC2007/cnst-sensors) >> Mentored by: syrinx >> Tested by: many >> OKed by: kensmith >> >> Revision Changes Path >> 1.2 +14 -6 src/share/man/man4/coretemp.4 >> 1.3 +46 -35 src/sys/dev/coretemp/coretemp.c > >> - thread_lock(curthread); >> - sched_unbind(curthread); >> - thread_unlock(curthread); >> + * Bind to specific CPU to read the correct temperature. >> + * If not all CPUs are initialised, then only read from >> + * cpu0, returning -1 on all other CPUs. >> + */ >> + if (smp_cpus > 1) { >> + thread_lock(curthread); >> + sched_bind(curthread, cpu); >> + msr = rdmsr(MSR_THERM_STATUS); >> + sched_unbind(curthread); >> + thread_unlock(curthread); >> + } else if (cpu != 0) >> + return (-1); >> + else >> + msr = rdmsr(MSR_THERM_STATUS); > > I reviewed this part of the patch for Rui Paulo and told him to use > smp_active instead of smp_cpus > 1. Sorry, for not getting back to you sooner, but there's a better way than that. I briefly chatted with jhb and the proper way is to use SYSINIT(9). This way the module works on UP and SMP machines. I have a patch, but my devel machine has panic()ed. Regards. -- Rui Paulo From owner-cvs-src@FreeBSD.ORG Mon Oct 15 09:51:31 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B12CD16A419; Mon, 15 Oct 2007 09:51:31 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8D35713C478; Mon, 15 Oct 2007 09:51:31 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9F9pV5B026507; Mon, 15 Oct 2007 09:51:31 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9F9pUm7026506; Mon, 15 Oct 2007 09:51:30 GMT (envelope-from ache) Message-Id: <200710150951.l9F9pUm7026506@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 15 Oct 2007 09:51:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/locale utf8.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 09:51:31 -0000 ache 2007-10-15 09:51:30 UTC FreeBSD src repository Modified files: lib/libc/locale utf8.c Log: Add comment explaining __mb_sb_limit trick here. Revision Changes Path 1.16 +5 -0 src/lib/libc/locale/utf8.c From owner-cvs-src@FreeBSD.ORG Mon Oct 15 10:44:00 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4B1C816A46C for ; Mon, 15 Oct 2007 10:44:00 +0000 (UTC) (envelope-from joao.barros@gmail.com) Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.233]) by mx1.freebsd.org (Postfix) with ESMTP id C1D1613C4BF for ; Mon, 15 Oct 2007 10:43:59 +0000 (UTC) (envelope-from joao.barros@gmail.com) Received: by wr-out-0506.google.com with SMTP id 70so682947wra for ; Mon, 15 Oct 2007 03:43:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; bh=5Qr5prfSK1grmOKz7qKkMy0nbntUtmymvY4e1Pos1FI=; b=eFZqVUmgLnjhlNsDbL2uItpsYcKHuplBNlEPjbdnC2kZrhBZAwHSa8d2NOxfWelGbtKltY4lJLls25stAm91PkMWp2dt9zhuBVSNVDtLGHvYmvKl8zIO6JSnKB7aIH6BQIZu+KYp9mmGytcLEUe9XcE8+TOMDoiRTlxal32NoL4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; b=WPXCUm7lRlegsAvwzKk0h8PN4P4nI505IG/PbcqJG3Q+iQMWzy1k3Olew99E5qghVQc76VLEHlTO0qxMqBGqKGAwcAf1PinWTP7U/jSt2L1HUPnC2zt8rSoJHEgQzFHwisIo7z6Afyw2h/7xG/fIM7fFKWavi2g41/wO5FHW+/4= Received: by 10.142.82.17 with SMTP id f17mr1372010wfb.1192445037975; Mon, 15 Oct 2007 03:43:57 -0700 (PDT) Received: by 10.142.90.13 with HTTP; Mon, 15 Oct 2007 03:43:57 -0700 (PDT) Message-ID: <70e8236f0710150343k590f5be8r8cdf3fd60df4abd2@mail.gmail.com> Date: Mon, 15 Oct 2007 11:43:57 +0100 From: "Joao Barros" To: "Scott Long" MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Cc: Wilko Bulte , src-committers@freebsd.org, Alexander Leidinger , cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 10:44:00 -0000 On 10/15/07, Scott Long wrote: > Alexander Leidinger wrote: > > Quoting Poul-Henning Kamp (from Sun, 14 Oct 2007 > > 17:54:21 +0000): > > > >> My only beef is with the architecture of the sensors framework, and > >> as a consequence thereof, with the actual code as well. > > > > When I asked you about a proposal how a better architecture looks like, > > you didn't came up with an explanation and you didn't came up with a > > list of things which you think are bad in the sensors framework. You > > also didn't respond to counterarguments from me. > > > > I don't think it is fair to make such a noise, without coming up with > > technical facts. > > > > Note: I don't object to backing out the commit. But as this seems to be > > on the desk of core@, I wait for their decision regarding this (as it is > > self contained and doesn't interfere with other stuff, we don't need to > > hurry). > > > >> In OpenBSD the sensors framework has already turned into a dumping > >> ground, and I have all reason to belive that we will see the same > >> under FreeBSD. > > > > It will be what we make out of this. > > > >> See for instance Marc Balmers presentation from EuroBSDcon2007 about > >> putting radio-timecode receivers under the sensors framework, or > > > > I don't see a need to port this part instead of using the existing > > time-infrastructure in our kernel (and I don't have my fingers in the > > time related code at all like you, so I hope other people think similar). > > > >> listen to the various mumblings about putting RAID-controller status > >> under sensors framework. > > > > What's wrong with this? Currently each RAID driver has to come up with > > his own way of displaying the RAID status. It's like saying that each > > network driver has to implement/display the stuff you can see with > > ifconfig in its own way, instead of using the proper network driver > > interface for this. > > > > For the love of God, please don't use RAID as an example to support your > argument for the sensord framework. Representing RAID state is several > orders of magnitude more involved than representing network state. > There are also landmines in the OpenBSD bits of RAID support that are > best left out of FreeBSD, unless you like alienating vendors and risking > legal action. Leave it alone. Please. I don't care what you do with > lmsensors or cpu power settings or whatever. Leave RAID out of it. > > Thanks, > > Scott Are you saying I shouldn't proceed with the bio port? -- Joao Barros From owner-cvs-src@FreeBSD.ORG Mon Oct 15 10:49:06 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3154316A420; Mon, 15 Oct 2007 10:49:06 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0DAA213C455; Mon, 15 Oct 2007 10:49:06 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9FAn511030885; Mon, 15 Oct 2007 10:49:05 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9FAn5qv030884; Mon, 15 Oct 2007 10:49:05 GMT (envelope-from kib) Message-Id: <200710151049.l9FAn5qv030884@repoman.freebsd.org> From: Konstantin Belousov Date: Mon, 15 Oct 2007 10:49:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/lib/libutil pidfile.3 pidfile.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 10:49:06 -0000 kib 2007-10-15 10:49:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libutil pidfile.3 pidfile.c Log: MFC rev. 1.6, 1.7 of src/lib/libutil/pidfile.3, rev. 1.8 of src/lib/libutil/pidfile.c: When pidfile is already locked and has zero length, do not return success and zero pid from pidfile_read(). Return EAGAIN instead. Sleep up to three times for 5 ms while waiting for pidfile to be written. Approved by: re (kensmith) Revision Changes Path 1.5.2.1 +5 -0 src/lib/libutil/pidfile.3 1.7.2.1 +15 -1 src/lib/libutil/pidfile.c From owner-cvs-src@FreeBSD.ORG Mon Oct 15 13:25:24 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 71C1416A46D; Mon, 15 Oct 2007 13:25:24 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id BEB8013C4A7; Mon, 15 Oct 2007 13:25:23 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A57699.dip.t-dialin.net [84.165.118.153]) by redbull.bpaserver.net (Postfix) with ESMTP id 8DF902E0D9; Mon, 15 Oct 2007 15:25:14 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 3A07E5B480D; Mon, 15 Oct 2007 15:24:09 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.1/8.13.8/Submit) id l9FDO9Sk093062; Mon, 15 Oct 2007 15:24:09 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Mon, 15 Oct 2007 15:24:08 +0200 Message-ID: <20071015152408.10kvgtog6cooc4wc@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Mon, 15 Oct 2007 15:24:08 +0200 From: Alexander Leidinger To: Poul-Henning Kamp References: <44701.1192432387@critter.freebsd.dk> In-Reply-To: <44701.1192432387@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-13.8, required 8, BAYES_00 -15.00, IMPRONONCABLE_2 1.50, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10, SMILEY -0.50) X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: Wilko Bulte , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 13:25:24 -0000 Quoting Poul-Henning Kamp (from Mon, 15 Oct 2007 =20 07:13:07 +0000): > In message <20071015081507.yi9t4ot8asg0wcw4@webmail.leidinger.net>, =20 > Alexander Leidinger writes: >> Quoting Poul-Henning Kamp (from Sun, 14 Oct 2007 >> 17:54:21 +0000): >> >>> My only beef is with the architecture of the sensors framework, and >>> as a consequence thereof, with the actual code as well. >> >> When I asked you about a proposal how a better architecture looks >> like, you didn't came up with an explanation and you didn't came up >> with a list of things which you think are bad in the sensors >> framework. You also didn't respond to counterarguments from me. >> >> [...] >> >> Could you please explain how you want to integrate devices with >> newbus, which are only accessible via the i2c bus? Feel free to show >> us example code for one of those of our drivers which access the i2c >> bus, which already existed before this commit. > > So, lets see how that works: > > =09I propose that we write our own C/C++ compiler in perl. > > =09You object to that. > > =09Then I tell you: Now YOU have to write the compiler. > > No, I didn't think so either :-) Come on Poul, you know that the response to such an objection would be =20 to ask for reasons for the objection and the constructive continuation =20 would be to point out weaknesses in an understandable way (and =20 pointing out better ways if known) by the person with the objections. > I have several times in the past pointed out why it is a very bad > idea to add a unstructured dumping ground to the kernel, and why > it is bad to stick code in the kernel that can easier live in > userland. And I responded that we need to have a way to export data from the =20 kernel to userland in an unified way. No need to replicate a lot of =20 code in a lot of places to export the data. When the data is out of =20 the kernel in an unified way, one can do a lot of things with it in an =20 automated way (e.g., use it in nagios or cacti, or whatever), but so =20 far we don't have a framework for this. I don't say the sensors framework can not be improved (in fact we got =20 some improvement suggestions) or that I know more than you, but I =20 think it doesn't deserve that much noise as is happening here currently. Regarding your argument to move some parts into the userland (if not, =20 please point out what you are talking about)... I assume you are still =20 talking about the temperature sensors. I already told you last time =20 that the current way (access to the i2c or smbus) needs more access =20 rights than using the userland parts of the sensors framework. I can =20 not remember that you objected to this security improvement or =20 provided technical arguments which made this point obsolete. Feel free =20 to point me to a corresponding mail I may have missed. Feel also free =20 to point out where Constantine or me aborted discussing things with =20 you, so far I remember that you didn't follow up on our last responses =20 to what you wrote the last time we talked about the sensors framework. > Right now, the people who advocate importing the OpenBSD sensor > framework need to tell us, in a coherent architecture document: > > A) Why we need it Already told here and in the past. I haven't seen any word from you =20 that those reasons are not enough for you (and why). > B) Why so much of it ends in the kernel If you talk about the temperature/voltage sensors: Already told here =20 and in the past. I haven't seen any word from you that those reasons =20 are not enough for you (and why). > C) How it integrates into FreeBSD and for the places where > it does not (newbus ?) why it doesn't. The improvement suggestions we got from someone else (private mail) =20 deal with newbus and provide an example. The suggestions also talk =20 about using taskqueue(9) and some other things. This critique is what =20 I call "constructive". From you I've only seen hand waving and whistle =20 blowing so far. Can we please go to a constructive way of criticism? Constantine agreed to improve what we have. So far the code is not =20 scheduled to go into 7.0 (and based upon the constructive suggestions =20 we got so far the code we have currently will not be in 7.0 for sure). =20 The code we have currently doesn't harm the system, provides =20 additional features, is far from seeing a release ATM (8.0 is about 18 =20 months away, plenty of time to remove unwanted parts), and the primary =20 author agreed to work on improvements. From an userlevel point of view the current offering is not bad. We =20 get an unified way of getting status information in a safe way. From a =20 developer which doesn't work on the framework point of view, the =20 kernel compiles and is not destabilized by the commit. The framework =20 is also not spread over the entire kernel. You object to the current implementation because you think it is bad. =20 Ok, I don't object to your objection. All I ask is to put the cards on =20 the table so that we can find a way forward. A way which gives the =20 users the new feature, and you the satisfaction of no bad parts in the =20 kernel you object to. You don't go to court and tell someone is guilty and then the person =20 has to prove he/she is not guilty. To me your objection looks similar =20 to the way Microsoft talks about patent issues in Linux... "I know you =20 do bad things but I don't tell you what". We all know that a lot of =20 people don't like this way of "doing business". If someone thinks my =20 view of this is way off, please tell me. Really, I want to know about =20 this if you think this is the case. So please, tell with concrete examples what's bad and why in your =20 opinion, and let Constantine have a look at it. For newbus and =20 taskqueue(9) we already have pointers for improvement, and I assume =20 Constantine is looking at them now. As far as I know the personality =20 of Constantine (I don't know him personally, just what I've seen here =20 on FreeBSD lists and in some private mails from him), I think he =20 either will use all constructive criticism to improve the framework, =20 or come up with an explanation why it is not possible to integrate =20 this suggestion in the framework. Note: some people pointed out that Pouls initial behavior was =20 needlessly rude and notified core@ because of this. Regardless from =20 the fact if I agree or not, I want to tell you that I'm not pissed off =20 at all and haven't switched to some aggressive countermeasure mode. =20 While this may be more or less normal behavior for a human being in =20 such a situation, I have the opinion that such reactions just result =20 in a drop of life quality. I managed to teach myself to stay more and =20 more calm in such situations. Typically I switch to a reduced emotions =20 mode where I try to come up with logical arguments. So if someone =20 reads my mail in some aggressive way, please start again and imagine a =20 calm intonation with the intend of going forward in a way which is =20 beneficial for the FreeBSD project. I would also suggest that everyone =20 who wants to answer tries to step back for a moment to analyze his own =20 feelings. If those feelings are not calm, then I suggest to sleep a =20 night over an answer. Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 You know you've been spending too much time on the computer when your friend misdates a check, and you suggest adding a "++" to fix it. From owner-cvs-src@FreeBSD.ORG Mon Oct 15 13:44:42 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 14A8516A420; Mon, 15 Oct 2007 13:44:42 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 6B88013C45D; Mon, 15 Oct 2007 13:44:41 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A57699.dip.t-dialin.net [84.165.118.153]) by redbull.bpaserver.net (Postfix) with ESMTP id 5174A2E0EE; Mon, 15 Oct 2007 15:44:27 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id F14D65B480D; Mon, 15 Oct 2007 15:43:21 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.1/8.13.8/Submit) id l9FDhLVJ096128; Mon, 15 Oct 2007 15:43:21 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Mon, 15 Oct 2007 15:43:21 +0200 Message-ID: <20071015154321.tl6x9nb9lwwgk8o8@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Mon, 15 Oct 2007 15:43:21 +0200 From: Alexander Leidinger To: Scott Long References: <24712.1192384461@critter.freebsd.dk> <20071015081507.yi9t4ot8asg0wcw4@webmail.leidinger.net> <47131B2F.1060900@samsco.org> In-Reply-To: <47131B2F.1060900@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-13.404, required 8, BAYES_00 -15.00, MIME_QP_LONG_LINE 1.40, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10) X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: Wilko Bulte , Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 13:44:42 -0000 Quoting Scott Long (from Mon, 15 Oct 2007 01:47:59 -0600= ): > Alexander Leidinger wrote: >> Quoting Poul-Henning Kamp (from Sun, 14 Oct =20 >> 2007 17:54:21 +0000): >>> listen to the various mumblings about putting RAID-controller status >>> under sensors framework. >> >> What's wrong with this? Currently each RAID driver has to come up =20 >> with his own way of displaying the RAID status. It's like saying =20 >> that each network driver has to implement/display the stuff you can =20 >> see with ifconfig in its own way, instead of using the proper =20 >> network driver interface for this. >> > > For the love of God, please don't use RAID as an example to support your > argument for the sensord framework. Representing RAID state is several > orders of magnitude more involved than representing network state. > There are also landmines in the OpenBSD bits of RAID support that are > best left out of FreeBSD, unless you like alienating vendors and risking > legal action. Leave it alone. Please. I don't care what you do with > lmsensors or cpu power settings or whatever. Leave RAID out of it. Talking about RAID status is not talking about alienating vendors. I =20 don't talk about alienating vendors and I don't intent to do. You may =20 not be able to display a full blown RAID status with the sensors =20 framework, but it allows for a generic "wors/works not" or =20 "OK/degraded" status display in drivers we have the source for. This =20 is enough for status monitoring (e.g., nagios). I don't know if you =20 talk about the OpenBSD bio framework or about some reverse engineered =20 RAID drivers in OpenBSD (or bad mails from them to some vendors). From =20 an user point of view the bio framework (as in "a generic interface =20 for the sysadmin to do RAID stuff", and not as in "the concrete =20 implementation in OpenBSD") is something you want to have. I don't =20 think that it is a bad idea to port it (and improve it). OpenBSD has =20 some RAID controllers converted to it and the framework already =20 represents an usable interface for a lot of cases. I don't know if it =20 needs improvement or not, I don't know if it can cover all current =20 feature needs for such a framework for all possible RAID systems (most =20 probably not), but it would be an improvement for vendors which want =20 to write support for their RAID hardware as they don't have to come up =20 with their own BSD code to manage those parts. And we could improve =20 "our bio framwork" (if we had/get one) based upon vendor feedback (we =20 already improved our network interfaces upon vendor feedback, haven't =20 we?). In case you talk about porting some "alienated" raid drivers =20 from OpenBSD... I agree that it is not a good idea to kick a vendor in =20 the ass (a vendor which provides some kind of FreeBSD support... if =20 there's a driver for raid hardware for which the vendor doesn't =20 provide any support for a driver for FreeBSD at all, it depends upon =20 the specific driver code from OpenBSD if it is a good idea to port it =20 or not). So in short: having a generic framework would be beneficial for =20 vendors. Kicking vendors in the ass is not my intention. Feel free to =20 document pitfalls in the RAID stuff in OpenBSD, so that nobody in =20 FreeBSd-land makes the same mistakes (but is able to get good parts if =20 the idea of an unified interface into FreeBSD). Sorry for not taking the time to write a more readable mail. Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 BEAUTY: =09What's in your eye when you have a bee in your hand. From owner-cvs-src@FreeBSD.ORG Mon Oct 15 13:50:46 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7B0D516A41B; Mon, 15 Oct 2007 13:50:46 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5C7A913C447; Mon, 15 Oct 2007 13:50:46 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9FDokho054152; Mon, 15 Oct 2007 13:50:46 GMT (envelope-from emaste@repoman.freebsd.org) Received: (from emaste@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9FDokQ3054151; Mon, 15 Oct 2007 13:50:46 GMT (envelope-from emaste) Message-Id: <200710151350.l9FDokQ3054151@repoman.freebsd.org> From: Ed Maste Date: Mon, 15 Oct 2007 13:50:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src Makefile.inc1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 13:50:46 -0000 emaste 2007-10-15 13:50:46 UTC FreeBSD src repository Modified files: . Makefile.inc1 Log: If a required install tool is missing, provide a more friendly error message (instead of cp's usage info). Revision Changes Path 1.589 +6 -1 src/Makefile.inc1 From owner-cvs-src@FreeBSD.ORG Mon Oct 15 13:51:02 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0F30516A478; Mon, 15 Oct 2007 13:51:02 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id ABE5E13C459; Mon, 15 Oct 2007 13:51:01 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l9FDoc2O065794; Mon, 15 Oct 2007 07:50:38 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4713700D.8040202@samsco.org> Date: Mon, 15 Oct 2007 07:50:05 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: Joao Barros References: <70e8236f0710150343k590f5be8r8cdf3fd60df4abd2@mail.gmail.com> In-Reply-To: <70e8236f0710150343k590f5be8r8cdf3fd60df4abd2@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Mon, 15 Oct 2007 07:50:38 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: Wilko Bulte , src-committers@freebsd.org, Alexander Leidinger , cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 13:51:02 -0000 Joao Barros wrote: > On 10/15/07, Scott Long wrote: >> Alexander Leidinger wrote: >>> Quoting Poul-Henning Kamp (from Sun, 14 Oct 2007 >>> 17:54:21 +0000): >>> >>>> My only beef is with the architecture of the sensors framework, and >>>> as a consequence thereof, with the actual code as well. >>> When I asked you about a proposal how a better architecture looks like, >>> you didn't came up with an explanation and you didn't came up with a >>> list of things which you think are bad in the sensors framework. You >>> also didn't respond to counterarguments from me. >>> >>> I don't think it is fair to make such a noise, without coming up with >>> technical facts. >>> >>> Note: I don't object to backing out the commit. But as this seems to be >>> on the desk of core@, I wait for their decision regarding this (as it is >>> self contained and doesn't interfere with other stuff, we don't need to >>> hurry). >>> >>>> In OpenBSD the sensors framework has already turned into a dumping >>>> ground, and I have all reason to belive that we will see the same >>>> under FreeBSD. >>> It will be what we make out of this. >>> >>>> See for instance Marc Balmers presentation from EuroBSDcon2007 about >>>> putting radio-timecode receivers under the sensors framework, or >>> I don't see a need to port this part instead of using the existing >>> time-infrastructure in our kernel (and I don't have my fingers in the >>> time related code at all like you, so I hope other people think similar). >>> >>>> listen to the various mumblings about putting RAID-controller status >>>> under sensors framework. >>> What's wrong with this? Currently each RAID driver has to come up with >>> his own way of displaying the RAID status. It's like saying that each >>> network driver has to implement/display the stuff you can see with >>> ifconfig in its own way, instead of using the proper network driver >>> interface for this. >>> >> For the love of God, please don't use RAID as an example to support your >> argument for the sensord framework. Representing RAID state is several >> orders of magnitude more involved than representing network state. >> There are also landmines in the OpenBSD bits of RAID support that are >> best left out of FreeBSD, unless you like alienating vendors and risking >> legal action. Leave it alone. Please. I don't care what you do with >> lmsensors or cpu power settings or whatever. Leave RAID out of it. >> >> Thanks, >> >> Scott > > Are you saying I shouldn't proceed with the bio port? > As has been discussed in various forums recently, this OpenBSD sensors stuff has been proceeding with little developer buy-in or discussion, and the developer input that has happened has largely been ignored. So with that said, let's all turn over a new leaf and get this process back on track. What exactly is the "bio port"? What does it do, what areas of the kernel and userland does it involve, what does it change, why is it a good idea? Scott From owner-cvs-src@FreeBSD.ORG Mon Oct 15 13:58:48 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6C9C216A41B; Mon, 15 Oct 2007 13:58:48 +0000 (UTC) (envelope-from henrik@brixandersen.dk) Received: from solow.pil.dk (relay.pil.dk [195.41.47.164]) by mx1.freebsd.org (Postfix) with ESMTP id 2858713C458; Mon, 15 Oct 2007 13:58:47 +0000 (UTC) (envelope-from henrik@brixandersen.dk) Received: from tirith.brixandersen.dk (osgiliath.brixandersen.dk [87.53.223.189]) by solow.pil.dk (Postfix) with ESMTP id 23C471CC0C1; Mon, 15 Oct 2007 15:58:47 +0200 (CEST) Received: by tirith.brixandersen.dk (Postfix, from userid 1001) id 3B07417036; Mon, 15 Oct 2007 15:58:46 +0200 (CEST) Date: Mon, 15 Oct 2007 15:58:46 +0200 From: Henrik Brix Andersen To: Scott Long Message-ID: <20071015135845.GG1290@tirith.brixandersen.dk> Mail-Followup-To: Scott Long , Joao Barros , Wilko Bulte , src-committers@freebsd.org, Alexander Leidinger , cvs-all@freebsd.org, cvs-src@freebsd.org References: <70e8236f0710150343k590f5be8r8cdf3fd60df4abd2@mail.gmail.com> <4713700D.8040202@samsco.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="q9KOos5vDmpwPx9o" Content-Disposition: inline In-Reply-To: <4713700D.8040202@samsco.org> X-PGP-Key: http://www.brixandersen.dk/files/HenrikBrixAndersen.asc User-Agent: Mutt/1.5.16 (2007-06-09) Cc: Joao Barros , src-committers@freebsd.org, Alexander Leidinger , cvs-src@freebsd.org, cvs-all@freebsd.org, Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 13:58:48 -0000 --q9KOos5vDmpwPx9o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 15, 2007 at 07:50:05AM -0600, Scott Long wrote: > As has been discussed in various forums recently, this OpenBSD sensors=20 > stuff has been proceeding with little developer buy-in or discussion, > and the developer input that has happened has largely been ignored. So > with that said, let's all turn over a new leaf and get this process back > on track. A very Good Idea (tm) :) > What exactly is the "bio port"? What does it do, what areas of the > kernel and userland does it involve, what does it change, why is it > a good idea? How about moving this discussion to the freebsd-arch@ mailing list? Regards, Brix --=20 Henrik Brix Andersen --q9KOos5vDmpwPx9o Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) Comment: GnuPG signed iD8DBQFHE3IVv+Q4flTiePgRAtHRAJ9MIlfkDcNiGLLrYamz6/nKHA20HACgrBJI gmUpSktF91AHTN4sIx21c7c= =arNL -----END PGP SIGNATURE----- --q9KOos5vDmpwPx9o-- From owner-cvs-src@FreeBSD.ORG Mon Oct 15 14:20:25 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 897F216A421; Mon, 15 Oct 2007 14:20:25 +0000 (UTC) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 67CDA13C47E; Mon, 15 Oct 2007 14:20:25 +0000 (UTC) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9FEKPc8058064; Mon, 15 Oct 2007 14:20:25 GMT (envelope-from nyan@repoman.freebsd.org) Received: (from nyan@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9FEKPn3058063; Mon, 15 Oct 2007 14:20:25 GMT (envelope-from nyan) Message-Id: <200710151420.l9FEKPn3058063@repoman.freebsd.org> From: Takahashi Yoshihiro Date: Mon, 15 Oct 2007 14:20:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libstand Makefile src/sys/boot/ficl Makefile src/sys/boot/pc98 Makefile.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 14:20:25 -0000 nyan 2007-10-15 14:20:24 UTC FreeBSD src repository Modified files: lib/libstand Makefile sys/boot/ficl Makefile sys/boot/pc98 Makefile.inc Log: Optimize for size on pc98. It enables to boot a kernel again. I don't know what's wrong (loader, boot2 or others), but this change is effective. Tested by: NAKAJI Hiroyuki MFC after: 3 days Revision Changes Path 1.58 +3 -0 src/lib/libstand/Makefile 1.45 +1 -1 src/sys/boot/ficl/Makefile 1.7 +2 -1 src/sys/boot/pc98/Makefile.inc From owner-cvs-src@FreeBSD.ORG Mon Oct 15 14:29:28 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 93BAC16A417 for ; Mon, 15 Oct 2007 14:29:28 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 0B99813C442 for ; Mon, 15 Oct 2007 14:29:27 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 0EDA446ECE; Mon, 15 Oct 2007 10:29:27 -0400 (EDT) Date: Mon, 15 Oct 2007 15:29:26 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Henrik Brix Andersen In-Reply-To: <20071015135845.GG1290@tirith.brixandersen.dk> Message-ID: <20071015152742.G32675@fledge.watson.org> References: <70e8236f0710150343k590f5be8r8cdf3fd60df4abd2@mail.gmail.com> <4713700D.8040202@samsco.org> <20071015135845.GG1290@tirith.brixandersen.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Scott Long , src-committers@freebsd.org, Alexander Leidinger , cvs-src@freebsd.org, Joao Barros , cvs-all@freebsd.org, Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 14:29:28 -0000 On Mon, 15 Oct 2007, Henrik Brix Andersen wrote: > On Mon, Oct 15, 2007 at 07:50:05AM -0600, Scott Long wrote: >> As has been discussed in various forums recently, this OpenBSD sensors >> stuff has been proceeding with little developer buy-in or discussion, and >> the developer input that has happened has largely been ignored. So with >> that said, let's all turn over a new leaf and get this process back on >> track. > > A very Good Idea (tm) :) > >> What exactly is the "bio port"? What does it do, what areas of the kernel >> and userland does it involve, what does it change, why is it a good idea? > > How about moving this discussion to the freebsd-arch@ mailing list? As a reminder, there was a pretty extensive thread on the topic of the sensor framework on the arch@ mailing list in July, with quite a few substantive comments made regarding both the design and implementation. People working in this area should be sure to review that entire thread before joinging in on a new one. Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Mon Oct 15 14:30:57 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5294916A473 for ; Mon, 15 Oct 2007 14:30:57 +0000 (UTC) (envelope-from kensmith@cse.Buffalo.EDU) Received: from phoebe.cse.buffalo.edu (phoebe.cse.buffalo.edu [128.205.32.89]) by mx1.freebsd.org (Postfix) with ESMTP id EA57413C469 for ; Mon, 15 Oct 2007 14:30:56 +0000 (UTC) (envelope-from kensmith@cse.Buffalo.EDU) Received: from [128.205.32.4] (opus.cse.buffalo.edu [128.205.32.4]) (authenticated bits=0) by phoebe.cse.buffalo.edu (8.14.1/8.13.7) with ESMTP id l9FEUSdY007024 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Mon, 15 Oct 2007 10:30:32 -0400 (EDT) (envelope-from kensmith@cse.buffalo.edu) From: Ken Smith To: Scott Long In-Reply-To: <4713700D.8040202@samsco.org> References: <70e8236f0710150343k590f5be8r8cdf3fd60df4abd2@mail.gmail.com> <4713700D.8040202@samsco.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-rr/OePQi363OzYtmVQMB" Organization: U. Buffalo CSE Department Date: Mon, 15 Oct 2007 10:30:28 -0400 Message-Id: <1192458628.95331.1.camel@opus.cse.buffalo.edu> Mime-Version: 1.0 X-Mailer: Evolution 2.10.2 FreeBSD GNOME Team Port X-DCC-Buffalo.EDU-Metrics: phoebe.cse.buffalo.edu 1336; Body=0 Fuz1=0 Fuz2=0 X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed version=3.2.3 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on phoebe.cse.buffalo.edu Cc: Joao Barros , src-committers@FreeBSD.org, Alexander Leidinger , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 14:30:57 -0000 --=-rr/OePQi363OzYtmVQMB Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon, 2007-10-15 at 07:50 -0600, Scott Long wrote: > As has been discussed in various forums recently, this OpenBSD sensors=20 > stuff has been proceeding with little developer buy-in or discussion, > and the developer input that has happened has largely been ignored. So > with that said, let's all turn over a new leaf and get this process back > on track. What exactly is the "bio port"? What does it do, what areas > of the kernel and userland does it involve, what does it change, why is=20 > it a good idea?=20 Yes! Please! But on arch@ please. :-) --=20 Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel | --=-rr/OePQi363OzYtmVQMB Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQBHE3l5/G14VSmup/YRAk/xAJ4xuKFOcIONwBjbz9/iYzl468yrswCeO4+p a6mlQ47T+ADl0+fwi8uaMZs= =TIBZ -----END PGP SIGNATURE----- --=-rr/OePQi363OzYtmVQMB-- From owner-cvs-src@FreeBSD.ORG Mon Oct 15 15:01:50 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 054CD16A417; Mon, 15 Oct 2007 15:01:50 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id 8365B13C468; Mon, 15 Oct 2007 15:01:49 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id ECE5817105; Mon, 15 Oct 2007 15:01:47 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id l9FF1lSE048259; Mon, 15 Oct 2007 15:01:47 GMT (envelope-from phk@critter.freebsd.dk) To: Alexander Leidinger From: "Poul-Henning Kamp" In-Reply-To: Your message of "Mon, 15 Oct 2007 15:24:08 +0200." <20071015152408.10kvgtog6cooc4wc@webmail.leidinger.net> Date: Mon, 15 Oct 2007 15:01:47 +0000 Message-ID: <48258.1192460507@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: Wilko Bulte , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 15:01:50 -0000 In message <20071015152408.10kvgtog6cooc4wc@webmail.leidinger.net>, Alexander L eidinger writes: >And I responded that we need to have a way to export data from the >kernel to userland in an unified way. I can't seem to find the supposed requirement for unification here, and in fact, it is exactly that a lot of crap gets bundled up under the wildcard term of "sensor" that I object to. The stuff I see people putting under the sensor framework doesn't have anything to do with each other, and all the sensor framework ends up being is a "small amount of data export" interface. >I already told you last time >that the current way (access to the i2c or smbus) needs more access >rights than using the userland parts of the sensors framework. More rights than what exactly ? >> Right now, the people who advocate importing the OpenBSD sensor >> framework need to tell us, in a coherent architecture document: >> >> A) Why we need it > >Already told here and in the past. I haven't seen any word from you >that those reasons are not enough for you (and why). No, I have yet to see why we need this framework. I have heard various arguments for why we need certain specific piece of data, but I have not heard why unifying all sorts of stuff in a new, badly designed kernel interface is needed. >> B) Why so much of it ends in the kernel > >If you talk about the temperature/voltage sensors: Already told here >and in the past. I haven't seen any word from you that those reasons >are not enough for you (and why). Anything that can be sensibly done in userland should be. The fact that it might take more work to do it properly is no excuse for this requirement. >> C) How it integrates into FreeBSD and for the places where >> it does not (newbus ?) why it doesn't. > >The improvement suggestions we got from someone else (private mail) >deal with newbus and provide an example. The suggestions also talk >about using taskqueue(9) and some other things. This critique is what >I call "constructive". From you I've only seen hand waving and whistle >blowing so far. Can we please go to a constructive way of criticism? It is hard to provide socalled "constructive criticism" when ones attitude to the entire concept is that it should be dragged behind the barn, summarily shot and buried right there and then. It's even harder to be constructive, when one registers ones opinion, only to see it completely ignored. >The code we have currently doesn't harm the system, [...] This is where I disagree: it does harm the system. It dumps a load of badly thought out code into our source tree, and that will effectively be in the way of any well thought out solution that might ever appear. This stuff should be backed out, and forced to live outside the tree until it satisfies our quality and architectural requirements. Forcing it to stay out of -current, means that the motivational pressure is on the people who thing we badly need this featureset, and gives them reason to improve it. Leaving it in the tree, is the sure fire way for it to become an unmaintained lump of code that slowly rots away. >You object to the current implementation because you think it is bad. s/think/know/ >Ok, I don't object to your objection. All I ask is to put the cards on >the table so that we can find a way forward. A way which gives the >users the new feature, and you the satisfaction of no bad parts in the >kernel you object to. The solution to that is to remove it from -current, let it live in P4 until such time that it passes muster in a review on arch@ which gives relevant people a chance to study and comment on it. >You don't go to court and tell someone is guilty and then the person >has to prove he/she is not guilty. No, I go to court, get a prelimnary injunction so that he is forced to stop while a proper review is carried out. Poul-Henning -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Mon Oct 15 15:23:11 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F47516A502; Mon, 15 Oct 2007 15:23:11 +0000 (UTC) (envelope-from mp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7DCDB13C491; Mon, 15 Oct 2007 15:23:11 +0000 (UTC) (envelope-from mp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9FFNBNd063120; Mon, 15 Oct 2007 15:23:11 GMT (envelope-from mp@repoman.freebsd.org) Received: (from mp@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9FFN9DX063119; Mon, 15 Oct 2007 15:23:09 GMT (envelope-from mp) Message-Id: <200710151523.l9FFN9DX063119@repoman.freebsd.org> From: Mark Peek Date: Mon, 15 Oct 2007 15:23:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: ZOULAS Cc: Subject: cvs commit: src/contrib/tcsh - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 15:23:11 -0000 mp 2007-10-15 15:23:08 UTC FreeBSD src repository src/contrib/tcsh - Imported sources Update of /home/ncvs/src/contrib/tcsh In directory repoman.freebsd.org:/tmp/cvs-serv62768 Log Message: Import two vendor fixes from tcsh-6.15.01 for MFC to 7.0. The fixes are: - Fix pty detection for autologout setting - kill `foo` got stuck because sigchld was disabled too soon Requested by: re Status: Vendor Tag: ZOULAS Release Tags: tcsh_6_15a U src/contrib/tcsh/tc.const.c U src/contrib/tcsh/sh.c U src/contrib/tcsh/sh.proc.c No conflicts created by this import From owner-cvs-src@FreeBSD.ORG Mon Oct 15 15:46:46 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6897916A41A for ; Mon, 15 Oct 2007 15:46:46 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247]) by mx1.freebsd.org (Postfix) with ESMTP id 2B40613C46A for ; Mon, 15 Oct 2007 15:46:46 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id A83D66691B8; Mon, 15 Oct 2007 17:29:49 +0200 (CEST) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gzd4xaNDQwrV; Mon, 15 Oct 2007 17:29:48 +0200 (CEST) Received: from vlk.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id B440F6691B4; Mon, 15 Oct 2007 17:29:48 +0200 (CEST) Received: (from rdivacky@localhost) by vlk.vlakno.cz (8.13.8/8.13.8/Submit) id l9FFTmoe086486; Mon, 15 Oct 2007 17:29:48 +0200 (CEST) (envelope-from rdivacky) Date: Mon, 15 Oct 2007 17:29:48 +0200 From: Roman Divacky To: Mark Peek Message-ID: <20071015152948.GA86427@freebsd.org> References: <200710151523.l9FFN9DX063119@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200710151523.l9FFN9DX063119@repoman.freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/contrib/tcsh - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 15:46:46 -0000 On Mon, Oct 15, 2007 at 03:23:09PM +0000, Mark Peek wrote: > mp 2007-10-15 15:23:08 UTC > > FreeBSD src repository > > src/contrib/tcsh - Imported sources > Update of /home/ncvs/src/contrib/tcsh > In directory repoman.freebsd.org:/tmp/cvs-serv62768 > > Log Message: > Import two vendor fixes from tcsh-6.15.01 for MFC to 7.0. The fixes are: > - Fix pty detection for autologout setting > - kill `foo` got stuck because sigchld was disabled too soon > > Requested by: re why not import tcsh-6.15.01 as a whole instead? also.. note that tcsh 6.15.00 with these fixes nor 6.15.01 doesnt fix the problems Steve Kargl is seeing. roman From owner-cvs-src@FreeBSD.ORG Mon Oct 15 16:17:49 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3F5ED16A419; Mon, 15 Oct 2007 16:17:49 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id E3F0313C459; Mon, 15 Oct 2007 16:17:48 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id BA766208D; Mon, 15 Oct 2007 18:17:39 +0200 (CEST) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: -0.0/3.0 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on tim.des.no Received: from ds4.des.no (des.no [80.203.243.180]) by smtp.des.no (Postfix) with ESMTP id A59A22088; Mon, 15 Oct 2007 18:17:39 +0200 (CEST) Received: by ds4.des.no (Postfix, from userid 1001) id 92D9584488; Mon, 15 Oct 2007 18:17:39 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Alexander Leidinger References: <44701.1192432387@critter.freebsd.dk> <20071015152408.10kvgtog6cooc4wc@webmail.leidinger.net> Date: Mon, 15 Oct 2007 18:17:39 +0200 In-Reply-To: <20071015152408.10kvgtog6cooc4wc@webmail.leidinger.net> (Alexander Leidinger's message of "Mon\, 15 Oct 2007 15\:24\:08 +0200") Message-ID: <86fy0c8i8s.fsf@ds4.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Wilko Bulte , Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 16:17:49 -0000 Alexander Leidinger writes: > And I responded that we need to have a way to export data from the > kernel to userland in an unified way. That's not a valid argument. We already have several ways to export data from the kernel to userland. You need to demonstrate why we need a new one, and specifically why we need the one you propose. If your only argument is "it needs to integrate with Nagios", then, well, if there isn't one already, I can write you a plugin that will allow Nagios to monitor any existing or future numeric sysctl node. It should take about half an hour. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Mon Oct 15 16:18:21 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D58916A421; Mon, 15 Oct 2007 16:18:21 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2915113C447; Mon, 15 Oct 2007 16:18:21 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9FGILtB067298; Mon, 15 Oct 2007 16:18:21 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9FGIKJV067297; Mon, 15 Oct 2007 16:18:20 GMT (envelope-from jhb) Message-Id: <200710151618.l9FGIKJV067297@repoman.freebsd.org> From: John Baldwin Date: Mon, 15 Oct 2007 16:18:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/pci intpm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 16:18:21 -0000 jhb 2007-10-15 16:18:20 UTC FreeBSD src repository Modified files: sys/pci intpm.c Log: Oops, convert a tsleep() to a msleep() that was missed when adding locking to this driver. Reported by: Michael Butler : imb of protected-networks net Revision Changes Path 1.40 +1 -1 src/sys/pci/intpm.c From owner-cvs-src@FreeBSD.ORG Mon Oct 15 16:42:22 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B14D916A417; Mon, 15 Oct 2007 16:42:22 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id 925FA13C468; Mon, 15 Oct 2007 16:42:22 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.1/8.14.1) with ESMTP id l9FGgMK8088559; Mon, 15 Oct 2007 09:42:22 -0700 (PDT) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.1/8.14.1/Submit) id l9FGgMf2088558; Mon, 15 Oct 2007 09:42:22 -0700 (PDT) (envelope-from obrien) Date: Mon, 15 Oct 2007 09:42:22 -0700 From: "David O'Brien" To: Mark Peek Message-ID: <20071015164222.GB88401@dragon.NUXI.org> References: <200710151523.l9FFN9DX063119@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200710151523.l9FFN9DX063119@repoman.freebsd.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/tcsh - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 16:42:22 -0000 On Mon, Oct 15, 2007 at 03:23:09PM +0000, Mark Peek wrote: > mp 2007-10-15 15:23:08 UTC > FreeBSD src repository > src/contrib/tcsh - Imported sources > Update of /home/ncvs/src/contrib/tcsh > In directory repoman.freebsd.org:/tmp/cvs-serv62768 > > Log Message: > Import two vendor fixes from tcsh-6.15.01 for MFC to 7.0. The fixes are: .. > U src/contrib/tcsh/tc.const.c > U src/contrib/tcsh/sh.c > U src/contrib/tcsh/sh.proc.c .. > Release Tags: tcsh_6_15a Mark, Please reimport this - such that there is a "tcsh_6_15a" tag on all files. Otherwise it makes it hard to do 'cvs diff -r tcsh_6_15a -r 1'. thanks, -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Oct 15 16:54:16 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB5F616A418; Mon, 15 Oct 2007 16:54:16 +0000 (UTC) (envelope-from mp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id BCA0713C447; Mon, 15 Oct 2007 16:54:16 +0000 (UTC) (envelope-from mp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9FGsGEO077971; Mon, 15 Oct 2007 16:54:16 GMT (envelope-from mp@repoman.freebsd.org) Received: (from mp@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9FGsGE6077970; Mon, 15 Oct 2007 16:54:16 GMT (envelope-from mp) Message-Id: <200710151654.l9FGsGE6077970@repoman.freebsd.org> From: Mark Peek Date: Mon, 15 Oct 2007 16:54:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: ZOULAS Cc: Subject: cvs commit: src/contrib/tcsh - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 16:54:16 -0000 mp 2007-10-15 16:54:16 UTC FreeBSD src repository src/contrib/tcsh - Imported sources Update of /home/ncvs/src/contrib/tcsh In directory repoman.freebsd.org:/tmp/cvs-serv77936 Log Message: Import two vendor fixes from tcsh-6.15.01 for MFC to 7.0. The fixes are: - Fix pty detection for autologout setting - kill `foo` got stuck because sigchld was disabled too soon Requested by: re Status: Vendor Tag: ZOULAS Release Tags: tcsh_6_15a U src/contrib/tcsh/Copyright U src/contrib/tcsh/FAQ U src/contrib/tcsh/Fixes U src/contrib/tcsh/Imakefile U src/contrib/tcsh/MAKEDIFFS U src/contrib/tcsh/MAKESHAR U src/contrib/tcsh/Makefile.in U src/contrib/tcsh/Makefile.std U src/contrib/tcsh/Makefile.vms U src/contrib/tcsh/NewThings U src/contrib/tcsh/Ported U src/contrib/tcsh/README U src/contrib/tcsh/README.imake U src/contrib/tcsh/WishList U src/contrib/tcsh/Y2K U src/contrib/tcsh/complete.tcsh U src/contrib/tcsh/config.guess U src/contrib/tcsh/config.h.in U src/contrib/tcsh/config.sub U src/contrib/tcsh/config_f.h U src/contrib/tcsh/configure U src/contrib/tcsh/configure.in U src/contrib/tcsh/csh-mode.el U src/contrib/tcsh/ed.h U src/contrib/tcsh/ed.chared.c U src/contrib/tcsh/ed.decls.h U src/contrib/tcsh/ed.defns.c U src/contrib/tcsh/ed.init.c U src/contrib/tcsh/ed.inputl.c U src/contrib/tcsh/ed.refresh.c U src/contrib/tcsh/ed.screen.c U src/contrib/tcsh/ed.term.c U src/contrib/tcsh/ed.term.h U src/contrib/tcsh/ed.xmap.c U src/contrib/tcsh/eight-bit.me U src/contrib/tcsh/gethost.c U src/contrib/tcsh/glob.3 U src/contrib/tcsh/glob.c U src/contrib/tcsh/glob.h U src/contrib/tcsh/host.defs U src/contrib/tcsh/imake.config U src/contrib/tcsh/install-sh U src/contrib/tcsh/ma.setp.c U src/contrib/tcsh/mi.termios.c U src/contrib/tcsh/mi.varargs.h U src/contrib/tcsh/mi.wait.h U src/contrib/tcsh/patchlevel.h U src/contrib/tcsh/pathnames.h U src/contrib/tcsh/sh.c U src/contrib/tcsh/sh.char.c U src/contrib/tcsh/sh.char.h U src/contrib/tcsh/sh.decls.h U src/contrib/tcsh/sh.dir.c U src/contrib/tcsh/sh.dir.h U src/contrib/tcsh/sh.dol.c U src/contrib/tcsh/sh.err.c U src/contrib/tcsh/sh.exec.c U src/contrib/tcsh/sh.exp.c U src/contrib/tcsh/sh.file.c U src/contrib/tcsh/sh.func.c U src/contrib/tcsh/sh.glob.c U src/contrib/tcsh/sh.h U src/contrib/tcsh/sh.hist.c U src/contrib/tcsh/sh.init.c U src/contrib/tcsh/sh.lex.c U src/contrib/tcsh/sh.misc.c U src/contrib/tcsh/sh.parse.c U src/contrib/tcsh/sh.print.c U src/contrib/tcsh/sh.proc.c U src/contrib/tcsh/sh.proc.h U src/contrib/tcsh/sh.sem.c U src/contrib/tcsh/sh.set.c U src/contrib/tcsh/sh.time.c U src/contrib/tcsh/sh.types.h U src/contrib/tcsh/tc.h U src/contrib/tcsh/snames.h U src/contrib/tcsh/src.desc U src/contrib/tcsh/tc.alloc.c U src/contrib/tcsh/tc.bind.c U src/contrib/tcsh/tc.const.c U src/contrib/tcsh/tc.decls.h U src/contrib/tcsh/tc.disc.c U src/contrib/tcsh/tc.func.c U src/contrib/tcsh/tc.nls.c U src/contrib/tcsh/tc.nls.h U src/contrib/tcsh/tc.os.c U src/contrib/tcsh/tc.os.h U src/contrib/tcsh/tc.printf.c U src/contrib/tcsh/tc.prompt.c U src/contrib/tcsh/tc.sched.c U src/contrib/tcsh/tc.sig.c U src/contrib/tcsh/tc.sig.h U src/contrib/tcsh/tc.str.c U src/contrib/tcsh/tc.vers.c U src/contrib/tcsh/tc.wait.h U src/contrib/tcsh/tc.who.c U src/contrib/tcsh/tcsh.man U src/contrib/tcsh/tcsh.man2html U src/contrib/tcsh/termcap.vms U src/contrib/tcsh/tw.color.c U src/contrib/tcsh/tw.h U src/contrib/tcsh/tw.comp.c U src/contrib/tcsh/tw.decls.h U src/contrib/tcsh/tw.help.c U src/contrib/tcsh/tw.init.c U src/contrib/tcsh/tw.parse.c U src/contrib/tcsh/tw.spell.c U src/contrib/tcsh/vms.termcap.c U src/contrib/tcsh/config/bsd4.4 U src/contrib/tcsh/nls/Makefile U src/contrib/tcsh/nls/C/charset U src/contrib/tcsh/nls/C/set1 U src/contrib/tcsh/nls/C/set10 U src/contrib/tcsh/nls/C/set11 U src/contrib/tcsh/nls/C/set12 U src/contrib/tcsh/nls/C/set13 U src/contrib/tcsh/nls/C/set14 U src/contrib/tcsh/nls/C/set15 U src/contrib/tcsh/nls/C/set16 U src/contrib/tcsh/nls/C/set17 U src/contrib/tcsh/nls/C/set18 U src/contrib/tcsh/nls/C/set19 U src/contrib/tcsh/nls/C/set2 U src/contrib/tcsh/nls/C/set20 U src/contrib/tcsh/nls/C/set21 U src/contrib/tcsh/nls/C/set22 U src/contrib/tcsh/nls/C/set23 U src/contrib/tcsh/nls/C/set24 U src/contrib/tcsh/nls/C/set25 U src/contrib/tcsh/nls/C/set26 U src/contrib/tcsh/nls/C/set27 U src/contrib/tcsh/nls/C/set29 U src/contrib/tcsh/nls/C/set3 U src/contrib/tcsh/nls/C/set30 U src/contrib/tcsh/nls/C/set31 U src/contrib/tcsh/nls/C/set4 U src/contrib/tcsh/nls/C/set5 U src/contrib/tcsh/nls/C/set6 U src/contrib/tcsh/nls/C/set7 U src/contrib/tcsh/nls/C/set8 U src/contrib/tcsh/nls/C/set9 U src/contrib/tcsh/nls/et/charset U src/contrib/tcsh/nls/et/set1 U src/contrib/tcsh/nls/et/set10 U src/contrib/tcsh/nls/et/set11 U src/contrib/tcsh/nls/et/set12 U src/contrib/tcsh/nls/et/set13 U src/contrib/tcsh/nls/et/set14 U src/contrib/tcsh/nls/et/set15 U src/contrib/tcsh/nls/et/set16 U src/contrib/tcsh/nls/et/set17 U src/contrib/tcsh/nls/et/set18 U src/contrib/tcsh/nls/et/set19 U src/contrib/tcsh/nls/et/set2 U src/contrib/tcsh/nls/et/set20 U src/contrib/tcsh/nls/et/set21 U src/contrib/tcsh/nls/et/set22 U src/contrib/tcsh/nls/et/set23 U src/contrib/tcsh/nls/et/set24 U src/contrib/tcsh/nls/et/set25 U src/contrib/tcsh/nls/et/set26 U src/contrib/tcsh/nls/et/set27 U src/contrib/tcsh/nls/et/set29 U src/contrib/tcsh/nls/et/set3 U src/contrib/tcsh/nls/et/set30 U src/contrib/tcsh/nls/et/set31 U src/contrib/tcsh/nls/et/set4 U src/contrib/tcsh/nls/et/set5 U src/contrib/tcsh/nls/et/set6 U src/contrib/tcsh/nls/et/set7 U src/contrib/tcsh/nls/et/set8 U src/contrib/tcsh/nls/et/set9 U src/contrib/tcsh/nls/finnish/charset U src/contrib/tcsh/nls/finnish/set1 U src/contrib/tcsh/nls/finnish/set10 U src/contrib/tcsh/nls/finnish/set11 U src/contrib/tcsh/nls/finnish/set12 U src/contrib/tcsh/nls/finnish/set13 U src/contrib/tcsh/nls/finnish/set14 U src/contrib/tcsh/nls/finnish/set15 U src/contrib/tcsh/nls/finnish/set16 U src/contrib/tcsh/nls/finnish/set17 U src/contrib/tcsh/nls/finnish/set18 U src/contrib/tcsh/nls/finnish/set19 U src/contrib/tcsh/nls/finnish/set2 U src/contrib/tcsh/nls/finnish/set20 U src/contrib/tcsh/nls/finnish/set21 U src/contrib/tcsh/nls/finnish/set22 U src/contrib/tcsh/nls/finnish/set23 U src/contrib/tcsh/nls/finnish/set24 U src/contrib/tcsh/nls/finnish/set25 U src/contrib/tcsh/nls/finnish/set26 U src/contrib/tcsh/nls/finnish/set27 U src/contrib/tcsh/nls/finnish/set29 U src/contrib/tcsh/nls/finnish/set3 U src/contrib/tcsh/nls/finnish/set30 U src/contrib/tcsh/nls/finnish/set31 U src/contrib/tcsh/nls/finnish/set4 U src/contrib/tcsh/nls/finnish/set5 U src/contrib/tcsh/nls/finnish/set6 U src/contrib/tcsh/nls/finnish/set7 U src/contrib/tcsh/nls/finnish/set8 U src/contrib/tcsh/nls/finnish/set9 U src/contrib/tcsh/nls/french/charset U src/contrib/tcsh/nls/french/set1 U src/contrib/tcsh/nls/french/set10 U src/contrib/tcsh/nls/french/set11 U src/contrib/tcsh/nls/french/set12 U src/contrib/tcsh/nls/french/set13 U src/contrib/tcsh/nls/french/set14 U src/contrib/tcsh/nls/french/set15 U src/contrib/tcsh/nls/french/set16 U src/contrib/tcsh/nls/french/set17 U src/contrib/tcsh/nls/french/set18 U src/contrib/tcsh/nls/french/set19 U src/contrib/tcsh/nls/french/set2 U src/contrib/tcsh/nls/french/set20 U src/contrib/tcsh/nls/french/set21 U src/contrib/tcsh/nls/french/set22 U src/contrib/tcsh/nls/french/set23 U src/contrib/tcsh/nls/french/set24 U src/contrib/tcsh/nls/french/set25 U src/contrib/tcsh/nls/french/set26 U src/contrib/tcsh/nls/french/set27 U src/contrib/tcsh/nls/french/set29 U src/contrib/tcsh/nls/french/set3 U src/contrib/tcsh/nls/french/set30 U src/contrib/tcsh/nls/french/set31 U src/contrib/tcsh/nls/french/set4 U src/contrib/tcsh/nls/french/set5 U src/contrib/tcsh/nls/french/set6 U src/contrib/tcsh/nls/french/set7 U src/contrib/tcsh/nls/french/set8 U src/contrib/tcsh/nls/french/set9 U src/contrib/tcsh/nls/german/charset U src/contrib/tcsh/nls/german/set1 U src/contrib/tcsh/nls/german/set10 U src/contrib/tcsh/nls/german/set11 U src/contrib/tcsh/nls/german/set12 U src/contrib/tcsh/nls/german/set13 U src/contrib/tcsh/nls/german/set14 U src/contrib/tcsh/nls/german/set15 U src/contrib/tcsh/nls/german/set16 U src/contrib/tcsh/nls/german/set17 U src/contrib/tcsh/nls/german/set18 U src/contrib/tcsh/nls/german/set19 U src/contrib/tcsh/nls/german/set2 U src/contrib/tcsh/nls/german/set20 U src/contrib/tcsh/nls/german/set21 U src/contrib/tcsh/nls/german/set22 U src/contrib/tcsh/nls/german/set23 U src/contrib/tcsh/nls/german/set24 U src/contrib/tcsh/nls/german/set25 U src/contrib/tcsh/nls/german/set26 U src/contrib/tcsh/nls/german/set27 U src/contrib/tcsh/nls/german/set29 U src/contrib/tcsh/nls/german/set3 U src/contrib/tcsh/nls/german/set30 U src/contrib/tcsh/nls/german/set31 U src/contrib/tcsh/nls/german/set4 U src/contrib/tcsh/nls/german/set5 U src/contrib/tcsh/nls/german/set6 U src/contrib/tcsh/nls/german/set7 U src/contrib/tcsh/nls/german/set8 U src/contrib/tcsh/nls/german/set9 U src/contrib/tcsh/nls/greek/charset U src/contrib/tcsh/nls/greek/set1 U src/contrib/tcsh/nls/greek/set10 U src/contrib/tcsh/nls/greek/set11 U src/contrib/tcsh/nls/greek/set12 U src/contrib/tcsh/nls/greek/set13 U src/contrib/tcsh/nls/greek/set14 U src/contrib/tcsh/nls/greek/set15 U src/contrib/tcsh/nls/greek/set16 U src/contrib/tcsh/nls/greek/set17 U src/contrib/tcsh/nls/greek/set18 U src/contrib/tcsh/nls/greek/set19 U src/contrib/tcsh/nls/greek/set2 U src/contrib/tcsh/nls/greek/set20 U src/contrib/tcsh/nls/greek/set21 U src/contrib/tcsh/nls/greek/set22 U src/contrib/tcsh/nls/greek/set23 U src/contrib/tcsh/nls/greek/set24 U src/contrib/tcsh/nls/greek/set25 U src/contrib/tcsh/nls/greek/set26 U src/contrib/tcsh/nls/greek/set27 U src/contrib/tcsh/nls/greek/set29 U src/contrib/tcsh/nls/greek/set3 U src/contrib/tcsh/nls/greek/set30 U src/contrib/tcsh/nls/greek/set31 U src/contrib/tcsh/nls/greek/set4 U src/contrib/tcsh/nls/greek/set5 U src/contrib/tcsh/nls/greek/set6 U src/contrib/tcsh/nls/greek/set7 U src/contrib/tcsh/nls/greek/set8 U src/contrib/tcsh/nls/greek/set9 U src/contrib/tcsh/nls/italian/charset U src/contrib/tcsh/nls/italian/set1 U src/contrib/tcsh/nls/italian/set10 U src/contrib/tcsh/nls/italian/set11 U src/contrib/tcsh/nls/italian/set12 U src/contrib/tcsh/nls/italian/set13 U src/contrib/tcsh/nls/italian/set14 U src/contrib/tcsh/nls/italian/set15 U src/contrib/tcsh/nls/italian/set16 U src/contrib/tcsh/nls/italian/set17 U src/contrib/tcsh/nls/italian/set18 U src/contrib/tcsh/nls/italian/set19 U src/contrib/tcsh/nls/italian/set2 U src/contrib/tcsh/nls/italian/set20 U src/contrib/tcsh/nls/italian/set21 U src/contrib/tcsh/nls/italian/set22 U src/contrib/tcsh/nls/italian/set23 U src/contrib/tcsh/nls/italian/set24 U src/contrib/tcsh/nls/italian/set25 U src/contrib/tcsh/nls/italian/set26 U src/contrib/tcsh/nls/italian/set27 U src/contrib/tcsh/nls/italian/set29 U src/contrib/tcsh/nls/italian/set3 U src/contrib/tcsh/nls/italian/set30 U src/contrib/tcsh/nls/italian/set31 U src/contrib/tcsh/nls/italian/set4 U src/contrib/tcsh/nls/italian/set5 U src/contrib/tcsh/nls/italian/set6 U src/contrib/tcsh/nls/italian/set7 U src/contrib/tcsh/nls/italian/set8 U src/contrib/tcsh/nls/italian/set9 U src/contrib/tcsh/nls/ja/charset U src/contrib/tcsh/nls/ja/set1 U src/contrib/tcsh/nls/ja/set10 U src/contrib/tcsh/nls/ja/set11 U src/contrib/tcsh/nls/ja/set12 U src/contrib/tcsh/nls/ja/set13 U src/contrib/tcsh/nls/ja/set15 U src/contrib/tcsh/nls/ja/set16 U src/contrib/tcsh/nls/ja/set17 U src/contrib/tcsh/nls/ja/set18 U src/contrib/tcsh/nls/ja/set2 U src/contrib/tcsh/nls/ja/set21 U src/contrib/tcsh/nls/ja/set24 U src/contrib/tcsh/nls/ja/set29 U src/contrib/tcsh/nls/ja/set3 U src/contrib/tcsh/nls/ja/set30 U src/contrib/tcsh/nls/ja/set4 U src/contrib/tcsh/nls/ja/set5 U src/contrib/tcsh/nls/ja/set6 U src/contrib/tcsh/nls/ja/set7 U src/contrib/tcsh/nls/ja/set8 U src/contrib/tcsh/nls/pl/charset U src/contrib/tcsh/nls/pl/README U src/contrib/tcsh/nls/pl/set1 U src/contrib/tcsh/nls/pl/set10 U src/contrib/tcsh/nls/pl/set11 U src/contrib/tcsh/nls/pl/set12 U src/contrib/tcsh/nls/pl/set13 U src/contrib/tcsh/nls/pl/set14 U src/contrib/tcsh/nls/pl/set15 U src/contrib/tcsh/nls/pl/set16 U src/contrib/tcsh/nls/pl/set17 U src/contrib/tcsh/nls/pl/set18 U src/contrib/tcsh/nls/pl/set19 U src/contrib/tcsh/nls/pl/set2 U src/contrib/tcsh/nls/pl/set20 U src/contrib/tcsh/nls/pl/set21 U src/contrib/tcsh/nls/pl/set22 U src/contrib/tcsh/nls/pl/set23 U src/contrib/tcsh/nls/pl/set24 U src/contrib/tcsh/nls/pl/set25 U src/contrib/tcsh/nls/pl/set26 U src/contrib/tcsh/nls/pl/set27 U src/contrib/tcsh/nls/pl/set29 U src/contrib/tcsh/nls/pl/set3 U src/contrib/tcsh/nls/pl/set30 U src/contrib/tcsh/nls/pl/set31 U src/contrib/tcsh/nls/pl/set4 U src/contrib/tcsh/nls/pl/set5 U src/contrib/tcsh/nls/pl/set6 U src/contrib/tcsh/nls/pl/set7 U src/contrib/tcsh/nls/pl/set8 U src/contrib/tcsh/nls/pl/set9 U src/contrib/tcsh/nls/russian/charset U src/contrib/tcsh/nls/russian/set1 U src/contrib/tcsh/nls/russian/set10 U src/contrib/tcsh/nls/russian/set11 U src/contrib/tcsh/nls/russian/set12 U src/contrib/tcsh/nls/russian/set13 U src/contrib/tcsh/nls/russian/set14 U src/contrib/tcsh/nls/russian/set15 U src/contrib/tcsh/nls/russian/set16 U src/contrib/tcsh/nls/russian/set17 U src/contrib/tcsh/nls/russian/set18 U src/contrib/tcsh/nls/russian/set19 U src/contrib/tcsh/nls/russian/set2 U src/contrib/tcsh/nls/russian/set20 U src/contrib/tcsh/nls/russian/set21 U src/contrib/tcsh/nls/russian/set22 U src/contrib/tcsh/nls/russian/set23 U src/contrib/tcsh/nls/russian/set24 U src/contrib/tcsh/nls/russian/set25 U src/contrib/tcsh/nls/russian/set26 U src/contrib/tcsh/nls/russian/set27 U src/contrib/tcsh/nls/russian/set29 U src/contrib/tcsh/nls/russian/set3 U src/contrib/tcsh/nls/russian/set30 U src/contrib/tcsh/nls/russian/set31 U src/contrib/tcsh/nls/russian/set4 U src/contrib/tcsh/nls/russian/set5 U src/contrib/tcsh/nls/russian/set6 U src/contrib/tcsh/nls/russian/set7 U src/contrib/tcsh/nls/russian/set8 U src/contrib/tcsh/nls/russian/set9 U src/contrib/tcsh/nls/spanish/charset U src/contrib/tcsh/nls/spanish/set1 U src/contrib/tcsh/nls/spanish/set10 U src/contrib/tcsh/nls/spanish/set11 U src/contrib/tcsh/nls/spanish/set12 U src/contrib/tcsh/nls/spanish/set13 U src/contrib/tcsh/nls/spanish/set14 U src/contrib/tcsh/nls/spanish/set15 U src/contrib/tcsh/nls/spanish/set16 U src/contrib/tcsh/nls/spanish/set17 U src/contrib/tcsh/nls/spanish/set18 U src/contrib/tcsh/nls/spanish/set19 U src/contrib/tcsh/nls/spanish/set2 U src/contrib/tcsh/nls/spanish/set20 U src/contrib/tcsh/nls/spanish/set21 U src/contrib/tcsh/nls/spanish/set22 U src/contrib/tcsh/nls/spanish/set23 U src/contrib/tcsh/nls/spanish/set24 U src/contrib/tcsh/nls/spanish/set25 U src/contrib/tcsh/nls/spanish/set26 U src/contrib/tcsh/nls/spanish/set27 U src/contrib/tcsh/nls/spanish/set29 U src/contrib/tcsh/nls/spanish/set3 U src/contrib/tcsh/nls/spanish/set30 U src/contrib/tcsh/nls/spanish/set31 U src/contrib/tcsh/nls/spanish/set4 U src/contrib/tcsh/nls/spanish/set5 U src/contrib/tcsh/nls/spanish/set6 U src/contrib/tcsh/nls/spanish/set7 U src/contrib/tcsh/nls/spanish/set8 U src/contrib/tcsh/nls/spanish/set9 U src/contrib/tcsh/nls/ukrainian/charset U src/contrib/tcsh/nls/ukrainian/set1 U src/contrib/tcsh/nls/ukrainian/set10 U src/contrib/tcsh/nls/ukrainian/set11 U src/contrib/tcsh/nls/ukrainian/set12 U src/contrib/tcsh/nls/ukrainian/set13 U src/contrib/tcsh/nls/ukrainian/set14 U src/contrib/tcsh/nls/ukrainian/set15 U src/contrib/tcsh/nls/ukrainian/set16 U src/contrib/tcsh/nls/ukrainian/set17 U src/contrib/tcsh/nls/ukrainian/set18 U src/contrib/tcsh/nls/ukrainian/set19 U src/contrib/tcsh/nls/ukrainian/set2 U src/contrib/tcsh/nls/ukrainian/set20 U src/contrib/tcsh/nls/ukrainian/set21 U src/contrib/tcsh/nls/ukrainian/set22 U src/contrib/tcsh/nls/ukrainian/set23 U src/contrib/tcsh/nls/ukrainian/set24 U src/contrib/tcsh/nls/ukrainian/set25 U src/contrib/tcsh/nls/ukrainian/set26 U src/contrib/tcsh/nls/ukrainian/set27 U src/contrib/tcsh/nls/ukrainian/set29 U src/contrib/tcsh/nls/ukrainian/set3 U src/contrib/tcsh/nls/ukrainian/set30 U src/contrib/tcsh/nls/ukrainian/set31 U src/contrib/tcsh/nls/ukrainian/set4 U src/contrib/tcsh/nls/ukrainian/set5 U src/contrib/tcsh/nls/ukrainian/set6 U src/contrib/tcsh/nls/ukrainian/set7 U src/contrib/tcsh/nls/ukrainian/set8 U src/contrib/tcsh/nls/ukrainian/set9 No conflicts created by this import From owner-cvs-src@FreeBSD.ORG Mon Oct 15 17:00:40 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1A60116A419 for ; Mon, 15 Oct 2007 17:00:40 +0000 (UTC) (envelope-from mp@FreeBSD.org) Received: from relay00.pair.com (relay00.pair.com [209.68.5.9]) by mx1.freebsd.org (Postfix) with SMTP id A76B813C45A for ; Mon, 15 Oct 2007 17:00:39 +0000 (UTC) (envelope-from mp@FreeBSD.org) Received: (qmail 12569 invoked by uid 0); 15 Oct 2007 16:33:59 -0000 Received: from unknown (HELO mp.local) (unknown) by unknown with SMTP; 15 Oct 2007 16:33:59 -0000 X-pair-Authenticated: 63.251.108.100 Message-ID: <47139675.1070201@FreeBSD.org> Date: Mon, 15 Oct 2007 09:33:57 -0700 From: Mark Peek User-Agent: Thunderbird 2.0.0.0pre (Macintosh/20070419) MIME-Version: 1.0 To: Roman Divacky References: <200710151523.l9FFN9DX063119@repoman.freebsd.org> <20071015152948.GA86427@freebsd.org> In-Reply-To: <20071015152948.GA86427@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/contrib/tcsh - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 17:00:40 -0000 On 10/15/07 8:29 AM, Roman Divacky wrote: > On Mon, Oct 15, 2007 at 03:23:09PM +0000, Mark Peek wrote: >> mp 2007-10-15 15:23:08 UTC >> >> FreeBSD src repository >> >> src/contrib/tcsh - Imported sources >> Update of /home/ncvs/src/contrib/tcsh >> In directory repoman.freebsd.org:/tmp/cvs-serv62768 >> >> Log Message: >> Import two vendor fixes from tcsh-6.15.01 for MFC to 7.0. The fixes are: >> - Fix pty detection for autologout setting >> - kill `foo` got stuck because sigchld was disabled too soon >> >> Requested by: re > > why not import tcsh-6.15.01 as a whole instead? also.. note that tcsh 6.15.00 > with these fixes nor 6.15.01 doesnt fix the problems Steve Kargl is seeing. I will be importing tcsh-6.15.01 into -current in the future. I had an explicit request from re@ to provide a fix for these bugs in 7.0 and it was agreed not to take the risk of taking 6.15.01 at this time. I'm doing the typical import into -current first and then MFC into 7.0 afterwards. I agree, this does not address Steve's issue. Mark From owner-cvs-src@FreeBSD.ORG Mon Oct 15 17:01:30 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CAAA016A420; Mon, 15 Oct 2007 17:01:30 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B9C8F13C465; Mon, 15 Oct 2007 17:01:30 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9FH1Ukl078491; Mon, 15 Oct 2007 17:01:30 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9FH1UMe078490; Mon, 15 Oct 2007 17:01:30 GMT (envelope-from delphij) Message-Id: <200710151701.l9FH1UMe078490@repoman.freebsd.org> From: Xin LI Date: Mon, 15 Oct 2007 17:01:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml src/contrib/less NEWS README charset.c less.man less.nro lessecho.man lessecho.nro lesskey.man lesskey.nro version.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 17:01:30 -0000 delphij 2007-10-15 17:01:30 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/relnotes/common new.sgml contrib/less NEWS README charset.c less.man less.nro lessecho.man lessecho.nro lesskey.man lesskey.nro version.c Log: MFC: less v409 Revision Changes Path 1.1.1.4.8.4 +4 -1 src/contrib/less/NEWS 1.1.1.4.8.4 +2 -2 src/contrib/less/README 1.1.1.3.8.4 +7 -5 src/contrib/less/charset.c 1.1.1.4.8.4 +1 -1 src/contrib/less/less.man 1.1.1.4.8.4 +1 -1 src/contrib/less/less.nro 1.1.1.1.2.4 +1 -1 src/contrib/less/lessecho.man 1.1.1.1.2.4 +1 -1 src/contrib/less/lessecho.nro 1.1.1.4.8.4 +1 -1 src/contrib/less/lesskey.man 1.1.1.4.8.4 +1 -1 src/contrib/less/lesskey.nro 1.1.1.4.8.4 +2 -1 src/contrib/less/version.c 1.883.2.83 +1 -1 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From owner-cvs-src@FreeBSD.ORG Mon Oct 15 17:34:58 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B6B3C16A46D; Mon, 15 Oct 2007 17:34:58 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8524C13C46E; Mon, 15 Oct 2007 17:34:58 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9FHYwEF081364; Mon, 15 Oct 2007 17:34:58 GMT (envelope-from emaste@repoman.freebsd.org) Received: (from emaste@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9FHYwlw081363; Mon, 15 Oct 2007 17:34:58 GMT (envelope-from emaste) Message-Id: <200710151734.l9FHYwlw081363@repoman.freebsd.org> From: Ed Maste Date: Mon, 15 Oct 2007 17:34:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/aac aac.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 17:34:58 -0000 emaste 2007-10-15 17:34:58 UTC FreeBSD src repository Modified files: sys/dev/aac aac.c Log: Correct calculation of aac_sg_tablesize. Obtained from: Adaptec, via driver b11669 Revision Changes Path 1.121 +4 -6 src/sys/dev/aac/aac.c From owner-cvs-src@FreeBSD.ORG Mon Oct 15 17:39:22 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5BFFA16A417; Mon, 15 Oct 2007 17:39:22 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id B70A413C491; Mon, 15 Oct 2007 17:39:21 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A57699.dip.t-dialin.net [84.165.118.153]) by redbull.bpaserver.net (Postfix) with ESMTP id 14E2A2E2F9; Mon, 15 Oct 2007 19:38:58 +0200 (CEST) Received: from deskjail (deskjail.Leidinger.net [192.168.1.109]) by outgoing.leidinger.net (Postfix) with ESMTP id ABB145B480D; Mon, 15 Oct 2007 19:37:52 +0200 (CEST) Date: Mon, 15 Oct 2007 19:36:58 +0200 From: Alexander Leidinger To: Scott Long Message-ID: <20071015193658.138fc9a5@deskjail> In-Reply-To: <4713700D.8040202@samsco.org> References: <70e8236f0710150343k590f5be8r8cdf3fd60df4abd2@mail.gmail.com> <4713700D.8040202@samsco.org> Organization: FreeBSD X-Mailer: Claws Mail 3.0.1 (GTK+ 2.10.14; i686-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.773, required 8, BAYES_00 -15.00, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10, SARE_RMML_Stock10 0.03) X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: Wilko Bulte , Joao Barros , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 17:39:22 -0000 Quoting Scott Long (Mon, 15 Oct 2007 07:50:05 -0600): > Joao Barros wrote: > > On 10/15/07, Scott Long wrote: > >> Alexander Leidinger wrote: > >>> Quoting Poul-Henning Kamp (from Sun, 14 Oct 2007 > >>> 17:54:21 +0000): > >>> > >>>> My only beef is with the architecture of the sensors framework, and > >>>> as a consequence thereof, with the actual code as well. > >>> When I asked you about a proposal how a better architecture looks like, > >>> you didn't came up with an explanation and you didn't came up with a > >>> list of things which you think are bad in the sensors framework. You > >>> also didn't respond to counterarguments from me. > >>> > >>> I don't think it is fair to make such a noise, without coming up with > >>> technical facts. > >>> > >>> Note: I don't object to backing out the commit. But as this seems to be > >>> on the desk of core@, I wait for their decision regarding this (as it is > >>> self contained and doesn't interfere with other stuff, we don't need to > >>> hurry). > >>> > >>>> In OpenBSD the sensors framework has already turned into a dumping > >>>> ground, and I have all reason to belive that we will see the same > >>>> under FreeBSD. > >>> It will be what we make out of this. > >>> > >>>> See for instance Marc Balmers presentation from EuroBSDcon2007 about > >>>> putting radio-timecode receivers under the sensors framework, or > >>> I don't see a need to port this part instead of using the existing > >>> time-infrastructure in our kernel (and I don't have my fingers in the > >>> time related code at all like you, so I hope other people think similar). > >>> > >>>> listen to the various mumblings about putting RAID-controller status > >>>> under sensors framework. > >>> What's wrong with this? Currently each RAID driver has to come up with > >>> his own way of displaying the RAID status. It's like saying that each > >>> network driver has to implement/display the stuff you can see with > >>> ifconfig in its own way, instead of using the proper network driver > >>> interface for this. > >>> > >> For the love of God, please don't use RAID as an example to support your > >> argument for the sensord framework. Representing RAID state is several > >> orders of magnitude more involved than representing network state. > >> There are also landmines in the OpenBSD bits of RAID support that are > >> best left out of FreeBSD, unless you like alienating vendors and risking > >> legal action. Leave it alone. Please. I don't care what you do with > >> lmsensors or cpu power settings or whatever. Leave RAID out of it. > >> > >> Thanks, > >> > >> Scott > > > > Are you saying I shouldn't proceed with the bio port? I would suggest to stop for some days, maybe Scott comes up with a description of something better. > As has been discussed in various forums recently, this OpenBSD sensors > stuff has been proceeding with little developer buy-in or discussion, Wait please. It was on the ides list before the soc and during the soc. There where links to an overview and to source files. And several committers voted in the Google soc interface for this framework (else another project would have been chosen instead). The code was shown around on public lists several times and some developers (I don't remember exactly which developers, we would have to check in the archives) provided some improvement suggestions during the soc which where incorporated/discussed. > and the developer input that has happened has largely been ignored. So Sorry, but this is not true. Poul objected before, yes. We started to talk with him, and then he stopped talking with us. I'm not aware that we insulted him or gave him other reasons to stop talking with us. So saying that his objections where ignored is not fair, I think. In total we have Poul on one side not wanting this framework, and several committers which agreed that the framework would be nice to have. I may be wrong, but I think Poul was also one of the people with voting rights and as far as I remember I didn't voted against the sensors framework (can probably be checked in the google webinterface for the soc). > with that said, let's all turn over a new leaf and get this process back > on track. What exactly is the "bio port"? What does it do, what areas > of the kernel and userland does it involve, what does it change, why is > it a good idea? It provides the possibility to do with raid, what ifconfig does with network interfaces. Like we have some standardized driver interfaces for network cards, the bio framework standardizes some interfaces (ioctls) for raid drivers. It is up to the raid driver writter to do the corresponding action. An example for such actions is blinking of LEDs in external enclosures or of harddisks (if possible/implemented in the driver) to identify parts for whatever reason (e.g., failed disk). Other examples are device listings, raid creation and hotspare handling. So it changes the need for the vendor/driver writter to come up with its own management application. He doesn't need to do the userland stuff, he only needs to provide the kernel driver. For the user this improves the administration situation, he doesn't need to know several applications with different syntax to do the raid management (if there's such an application at all), he just need to know one. Apart from ifconfig you maybe can also compare it with atacontrol for ATA and camcontrol for SCSI (camcontrol is not really a good example, but I include it regardless). This may not provide management controls for all possible features of a specific raid hardware, but as with our NIC driver interface which was extended from time to time, we can extend the bio framework as needed (which basically means to write down the name of an ioctl and describing the semantic of it). Bye, Alexander. -- ...and that is how we know the Earth to be banana-shaped. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 From owner-cvs-src@FreeBSD.ORG Mon Oct 15 17:39:48 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5444F16A418; Mon, 15 Oct 2007 17:39:48 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 29B8113C447; Mon, 15 Oct 2007 17:39:48 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9FHdmCI082816; Mon, 15 Oct 2007 17:39:48 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9FHdlRQ082815; Mon, 15 Oct 2007 17:39:47 GMT (envelope-from sam) Message-Id: <200710151739.l9FHdlRQ082815@repoman.freebsd.org> From: Sam Leffler Date: Mon, 15 Oct 2007 17:39:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb if_zydreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 17:39:48 -0000 sam 2007-10-15 17:39:47 UTC FreeBSD src repository Modified files: sys/dev/usb if_zydreg.h Log: fix a bug of RX routines that can't process multi-frame transactions properly due to the shortage of the RX buffer size. In a case of zyd devices, up to 3 frames can be combined in an USB transaction. So, RX buffer should be at least ((MCLBYTES + extra structs) * 3) Submitted by: Weongyo Jeong MFC after: 3 days Revision Changes Path 1.2 +3 -2 src/sys/dev/usb/if_zydreg.h From owner-cvs-src@FreeBSD.ORG Mon Oct 15 17:50:53 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6563116A4F1 for ; Mon, 15 Oct 2007 17:50:53 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 20A9D13C4A6 for ; Mon, 15 Oct 2007 17:50:52 +0000 (UTC) (envelope-from sam@errno.com) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id l9FHofnF059330 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 15 Oct 2007 10:50:41 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <4713A871.1080608@errno.com> Date: Mon, 15 Oct 2007 10:50:41 -0700 From: Sam Leffler User-Agent: Thunderbird 2.0.0.6 (X11/20070814) MIME-Version: 1.0 To: Alexander Leidinger References: <70e8236f0710150343k590f5be8r8cdf3fd60df4abd2@mail.gmail.com> <4713700D.8040202@samsco.org> <20071015193658.138fc9a5@deskjail> In-Reply-To: <20071015193658.138fc9a5@deskjail> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC-Rhyolite-Metrics: o.com; whitelist Cc: Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Joao Barros , cvs-all@FreeBSD.org, Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 17:50:53 -0000 Alexander Leidinger wrote: > Quoting Scott Long (Mon, 15 Oct 2007 07:50:05 -0600): > > >> Joao Barros wrote: >> >>> On 10/15/07, Scott Long wrote: >>> >>>> Alexander Leidinger wrote: >>>> >>>>> Quoting Poul-Henning Kamp (from Sun, 14 Oct 2007 >>>>> 17:54:21 +0000): >>>>> >>>>> >>>>>> My only beef is with the architecture of the sensors framework, and >>>>>> as a consequence thereof, with the actual code as well. >>>>>> >>>>> When I asked you about a proposal how a better architecture looks like, >>>>> you didn't came up with an explanation and you didn't came up with a >>>>> list of things which you think are bad in the sensors framework. You >>>>> also didn't respond to counterarguments from me. >>>>> >>>>> I don't think it is fair to make such a noise, without coming up with >>>>> technical facts. >>>>> >>>>> Note: I don't object to backing out the commit. But as this seems to be >>>>> on the desk of core@, I wait for their decision regarding this (as it is >>>>> self contained and doesn't interfere with other stuff, we don't need to >>>>> hurry). >>>>> >>>>> >>>>>> In OpenBSD the sensors framework has already turned into a dumping >>>>>> ground, and I have all reason to belive that we will see the same >>>>>> under FreeBSD. >>>>>> >>>>> It will be what we make out of this. >>>>> >>>>> >>>>>> See for instance Marc Balmers presentation from EuroBSDcon2007 about >>>>>> putting radio-timecode receivers under the sensors framework, or >>>>>> >>>>> I don't see a need to port this part instead of using the existing >>>>> time-infrastructure in our kernel (and I don't have my fingers in the >>>>> time related code at all like you, so I hope other people think similar). >>>>> >>>>> >>>>>> listen to the various mumblings about putting RAID-controller status >>>>>> under sensors framework. >>>>>> >>>>> What's wrong with this? Currently each RAID driver has to come up with >>>>> his own way of displaying the RAID status. It's like saying that each >>>>> network driver has to implement/display the stuff you can see with >>>>> ifconfig in its own way, instead of using the proper network driver >>>>> interface for this. >>>>> >>>>> >>>> For the love of God, please don't use RAID as an example to support your >>>> argument for the sensord framework. Representing RAID state is several >>>> orders of magnitude more involved than representing network state. >>>> There are also landmines in the OpenBSD bits of RAID support that are >>>> best left out of FreeBSD, unless you like alienating vendors and risking >>>> legal action. Leave it alone. Please. I don't care what you do with >>>> lmsensors or cpu power settings or whatever. Leave RAID out of it. >>>> >>>> Thanks, >>>> >>>> Scott >>>> >>> Are you saying I shouldn't proceed with the bio port? >>> > > I would suggest to stop for some days, maybe Scott comes up with > a description of something better. > > >> As has been discussed in various forums recently, this OpenBSD sensors >> stuff has been proceeding with little developer buy-in or discussion, >> > > Wait please. It was on the ides list before the soc and during the soc. > There where links to an overview and to source files. And several > committers voted in the Google soc interface for this framework (else > another project would have been chosen instead). The code was shown > around on public lists several times and some developers (I don't > remember exactly which developers, we would have to check in the > archives) provided some improvement suggestions during the soc which > where incorporated/discussed. > SoC projects are not expected to go into CVS. It's nice when they do but that is not the purpose of them (IMO). > >> and the developer input that has happened has largely been ignored. So >> > > Sorry, but this is not true. Poul objected before, yes. We started to > talk with him, and then he stopped talking with us. I'm not aware that > we insulted him or gave him other reasons to stop talking with us. So > saying that his objections where ignored is not fair, I think. > > In total we have Poul on one side not wanting this framework, and > several committers which agreed that the framework would be nice to > have. > > I may be wrong, but I think Poul was also one of the people with voting > rights and as far as I remember I didn't voted against the sensors > framework (can probably be checked in the google webinterface for the > soc). > You seem to have selective hearing. You have already received multiple responses (>3) that say BACK IT OUT but I only see your responding to phk (and to scott about the bio stuff). Constantine received numerous mails while he was working on his SoC project that said folks did not entirely agree with his approach. BUT because it was an SoC project and NOT code ready to be committed to CVS it was fine for him to continue down the path he did. I for one always assumed that before any code went into CVS there'd be public review and a consensus agreement before a commit. You have, for some reason, decided to push this stuff into CVS w/o taking the obvious step of requesting review. > >> with that said, let's all turn over a new leaf and get this process back >> on track. What exactly is the "bio port"? What does it do, what areas >> of the kernel and userland does it involve, what does it change, why is >> it a good idea? >> > > It provides the possibility to do with raid, what ifconfig does with > network interfaces. Like we have some standardized driver interfaces > for network cards, the bio framework standardizes some interfaces > (ioctls) for raid drivers. It is up to the raid driver writter to > do the corresponding action. An example for such actions is blinking of > LEDs in external enclosures or of harddisks (if possible/implemented in > the driver) to identify parts for whatever reason (e.g., failed disk). > Other examples are device listings, raid creation and hotspare handling. > > So it changes the need for the vendor/driver writter to come up with > its own management application. He doesn't need to do the userland > stuff, he only needs to provide the kernel driver. > > For the user this improves the administration situation, he doesn't > need to know several applications with different syntax to do the raid > management (if there's such an application at all), he just need to > know one. Apart from ifconfig you maybe can also compare it with > atacontrol for ATA and camcontrol for SCSI (camcontrol is not really a > good example, but I include it regardless). > > This may not provide management controls for all possible features of > a specific raid hardware, but as with our NIC driver interface which was > extended from time to time, we can extend the bio framework as needed > (which basically means to write down the name of an ioctl and describing > the semantic of it). > > Bye, > Alexander. > > From owner-cvs-src@FreeBSD.ORG Mon Oct 15 17:56:52 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 84EAE16A46B; Mon, 15 Oct 2007 17:56:52 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id A092713C458; Mon, 15 Oct 2007 17:56:49 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id A925C17105; Mon, 15 Oct 2007 17:56:47 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id l9FHuj5i001289; Mon, 15 Oct 2007 17:56:45 GMT (envelope-from phk@critter.freebsd.dk) To: Alexander Leidinger From: "Poul-Henning Kamp" In-Reply-To: Your message of "Mon, 15 Oct 2007 19:36:58 +0200." <20071015193658.138fc9a5@deskjail> Date: Mon, 15 Oct 2007 17:56:45 +0000 Message-ID: <1288.1192471005@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Joao Barros , cvs-all@FreeBSD.org, Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 17:56:52 -0000 In message <20071015193658.138fc9a5@deskjail>, Alexander Leidinger writes: >> As has been discussed in various forums recently, this OpenBSD sensors >> stuff has been proceeding with little developer buy-in or discussion, > >Wait please. It was on the ides list before the soc and during the soc. >There where links to an overview and to source files. And several >committers voted in the Google soc interface for this framework (else >another project would have been chosen instead). >[...] >I may be wrong, but I think Poul was also one of the people with voting >rights and as far as I remember I didn't voted against the sensors >framework (can probably be checked in the google webinterface for the >soc). Just because something is a good SoC project doesn't mean that it should end up in -current. SoC has en entirely different profile, and my vote or non-vote in one, is no reflection on my opinion on the other. >> and the developer input that has happened has largely been ignored. So > >Sorry, but this is not true. Poul objected before, yes. We started to >talk with him, and then he stopped talking with us. You never have, and still do not, address the central objection I have to this stuff: it's basic premise. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Mon Oct 15 18:26:57 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4448716A41B; Mon, 15 Oct 2007 18:26:57 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.freebsd.org (Postfix) with ESMTP id C947813C46A; Mon, 15 Oct 2007 18:26:56 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (ffquhwzonz4r9h4i@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.6/8.13.3) with ESMTP id l9FI7Ag2081197; Mon, 15 Oct 2007 11:07:10 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.6/8.13.3/Submit) id l9FI7AJE081196; Mon, 15 Oct 2007 11:07:10 -0700 (PDT) (envelope-from jmg) Date: Mon, 15 Oct 2007 11:07:09 -0700 From: John-Mark Gurney To: Alexander Leidinger Message-ID: <20071015180709.GO39759@funkthat.com> Mail-Followup-To: Alexander Leidinger , Wilko Bulte , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org References: <70e8236f0710150343k590f5be8r8cdf3fd60df4abd2@mail.gmail.com> <4713700D.8040202@samsco.org> <20071015193658.138fc9a5@deskjail> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071015193658.138fc9a5@deskjail> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (hydrogen.funkthat.com [127.0.0.1]); Mon, 15 Oct 2007 11:07:10 -0700 (PDT) Cc: Wilko Bulte , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 18:26:57 -0000 Alexander Leidinger wrote this message on Mon, Oct 15, 2007 at 19:36 +0200: > > and the developer input that has happened has largely been ignored. So > > Sorry, but this is not true. Poul objected before, yes. We started to > talk with him, and then he stopped talking with us. I'm not aware that > we insulted him or gave him other reasons to stop talking with us. So > saying that his objections where ignored is not fair, I think. > > In total we have Poul on one side not wanting this framework, and > several committers which agreed that the framework would be nice to > have. Please reread the thread back in July. phk was not the only one to object to the framework, and my emails were ignored... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-cvs-src@FreeBSD.ORG Mon Oct 15 18:39:16 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6FEB216A41A; Mon, 15 Oct 2007 18:39:16 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id E9F1213C45B; Mon, 15 Oct 2007 18:39:15 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 214537876-1834499 for multiple; Mon, 15 Oct 2007 14:36:31 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l9FIc83n075302; Mon, 15 Oct 2007 14:38:09 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Alexander Leidinger Date: Mon, 15 Oct 2007 14:34:40 -0400 User-Agent: KMail/1.9.6 References: <24712.1192384461@critter.freebsd.dk> <47131B2F.1060900@samsco.org> <20071015154321.tl6x9nb9lwwgk8o8@webmail.leidinger.net> In-Reply-To: <20071015154321.tl6x9nb9lwwgk8o8@webmail.leidinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200710151434.41801.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 15 Oct 2007 14:38:09 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4540/Sat Oct 13 21:43:55 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Scott Long , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Poul-Henning Kamp , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 18:39:16 -0000 On Monday 15 October 2007 09:43:21 am Alexander Leidinger wrote: > Quoting Scott Long (from Mon, 15 Oct 2007 01:47:59 -0600): > > > Alexander Leidinger wrote: > >> Quoting Poul-Henning Kamp (from Sun, 14 Oct > >> 2007 17:54:21 +0000): > > >>> listen to the various mumblings about putting RAID-controller status > >>> under sensors framework. > >> > >> What's wrong with this? Currently each RAID driver has to come up > >> with his own way of displaying the RAID status. It's like saying > >> that each network driver has to implement/display the stuff you can > >> see with ifconfig in its own way, instead of using the proper > >> network driver interface for this. > >> > > > > For the love of God, please don't use RAID as an example to support your > > argument for the sensord framework. Representing RAID state is several > > orders of magnitude more involved than representing network state. > > There are also landmines in the OpenBSD bits of RAID support that are > > best left out of FreeBSD, unless you like alienating vendors and risking > > legal action. Leave it alone. Please. I don't care what you do with > > lmsensors or cpu power settings or whatever. Leave RAID out of it. > > Talking about RAID status is not talking about alienating vendors. I > don't talk about alienating vendors and I don't intent to do. You may > not be able to display a full blown RAID status with the sensors > framework, but it allows for a generic "wors/works not" or > "OK/degraded" status display in drivers we have the source for. This > is enough for status monitoring (e.g., nagios). As I mentioned in the thread on arch@ where people brought up objections that were apparently completely ignored, this is far from useful for RAID monitoring. For example, if my RAID is down, which disk do I need to replace? Again, all this was covered earlier and (apparently) ignored. Also, what strikes me as odd is that I didn't see this patch posted again for review this time around before it was committed. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Mon Oct 15 19:11:35 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 91E8016A417; Mon, 15 Oct 2007 19:11:35 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 0546B13C461; Mon, 15 Oct 2007 19:11:34 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A57699.dip.t-dialin.net [84.165.118.153]) by redbull.bpaserver.net (Postfix) with ESMTP id 74C152E2F1; Mon, 15 Oct 2007 21:11:11 +0200 (CEST) Received: from deskjail (deskjail.Leidinger.net [192.168.1.109]) by outgoing.leidinger.net (Postfix) with ESMTP id ED6045B480D; Mon, 15 Oct 2007 21:10:05 +0200 (CEST) Date: Mon, 15 Oct 2007 21:09:09 +0200 From: Alexander Leidinger To: "Poul-Henning Kamp" Message-ID: <20071015210909.1b6b693b@deskjail> In-Reply-To: <48258.1192460507@critter.freebsd.dk> References: <20071015152408.10kvgtog6cooc4wc@webmail.leidinger.net> <48258.1192460507@critter.freebsd.dk> Organization: FreeBSD X-Mailer: Claws Mail 3.0.1 (GTK+ 2.10.14; i686-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=2.7, required 8, BAYES_20 1.00, IMPRONONCABLE_2 1.50, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10) X-BPAnet-MailScanner-SpamScore: ss X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: Wilko Bulte , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 19:11:35 -0000 Quoting "Poul-Henning Kamp" (Mon, 15 Oct 2007 15:01:47 +0000): > In message <20071015152408.10kvgtog6cooc4wc@webmail.leidinger.net>, Alexander L > eidinger writes: > > >And I responded that we need to have a way to export data from the > >kernel to userland in an unified way. > > I can't seem to find the supposed requirement for unification here, You didn't comment on what I wrote about reducing the work of reinventing a way to export the data we want to export again and again and again and again... > and in fact, it is exactly that a lot of crap gets bundled up > under the wildcard term of "sensor" that I object to. Exporting temperature readings / voltage measurement, system status is not crap. And when you write some monitoring probes in a large server farm, you don't want to hunt down every interesting data value in a lot of places. If you have the possibility to get a description and corresponding data value of several intersting stuff in a simple way, regardless of what hardware is used or replaced by stuff from another vendor, then it is a huge improvement. Specially if you work in a team with multiple administrators with several knowledge levels, and operators which have a low knowledge level but can follow some procedures. This doesn't even talk about turn-around (people leaving the company, entering the company) in the team itself. > The stuff I see people putting under the sensor framework doesn't > have anything to do with each other, and all the sensor framework > ends up being is a "small amount of data export" interface. The sensors are grouped in a hierarchy, the meta-data it contains (hw.sensors.cpuX...) is good to feed to a monitoring solution in the userland which lets the operator - which takes care about the monitoring - understand enough what is going on. > >I already told you last time > >that the current way (access to the i2c or smbus) needs more access > >rights than using the userland parts of the sensors framework. > > More rights than what exactly ? One popular userland temperature/voltage reading tool (as it supports a lot of popular devices) is mbmon. It is currently a SUID root application. It is like this as it accesses the smbus and/or ISA I/O ports directly. If we forget the ISA I/O ports part, we could maybe switch to a mbmon-user, but I don't really want to have such an user be able to query every device on the smbus. systat and sysctl are not SUID/SGID and don't require some special rights in /dev. I would say this is a big difference in favour of the sensors framework. > >> Right now, the people who advocate importing the OpenBSD sensor > >> framework need to tell us, in a coherent architecture document: > >> > >> A) Why we need it > > > >Already told here and in the past. I haven't seen any word from you > >that those reasons are not enough for you (and why). > > No, I have yet to see why we need this framework. Several committers which voted for this project in the soc webinterface seem to think otherwise, else they wouldn't have voted for it. > I have heard various arguments for why we need certain specific > piece of data, but I have not heard why unifying all sorts of stuff > in a new, badly designed kernel interface is needed. The unifying part is explained above. For the "badly designed" part I would like to hear what you don't like about it or how you think a better one looks like. > >> B) Why so much of it ends in the kernel > > > >If you talk about the temperature/voltage sensors: Already told here > >and in the past. I haven't seen any word from you that those reasons > >are not enough for you (and why). > > Anything that can be sensibly done in userland should be. If you agree that needing higher privileges is not sensible, I agree. > The fact that it might take more work to do it properly is no excuse > for this requirement. Would you please explain how accessing the ISA I/O ports of those devices or only specific devices on the smbus can be done properly (without elevated privileges) without a kernel driver? > >> C) How it integrates into FreeBSD and for the places where > >> it does not (newbus ?) why it doesn't. > > > >The improvement suggestions we got from someone else (private mail) > >deal with newbus and provide an example. The suggestions also talk > >about using taskqueue(9) and some other things. This critique is what > >I call "constructive". From you I've only seen hand waving and whistle > >blowing so far. Can we please go to a constructive way of criticism? > > It is hard to provide socalled "constructive criticism" when ones > attitude to the entire concept is that it should be dragged behind > the barn, summarily shot and buried right there and then. > > It's even harder to be constructive, when one registers ones opinion, > only to see it completely ignored. We're discussing it right now. And I was willing to discuss this even back when you talked about it the first time. It was you which stopped talking very fast. Several people think it is a good idea to have such a framework, and so far I've only seen one voiced opinion, that it is a bad idea to have such a framework. > >The code we have currently doesn't harm the system, [...] > > This is where I disagree: it does harm the system. > > It dumps a load of badly thought out code into our source tree, and > that will effectively be in the way of any well thought out solution > that might ever appear. > > This stuff should be backed out, and forced to live outside the tree > until it satisfies our quality and architectural requirements. How does this compare to your attitude of bringing stuff into the tree and letting other people fixup collateral damage in the past? But I drift away from the topic... so back to the sensors framework. To be able to address our quality and architectural requirements, we need first to know which quality and architectural requirements are violated by which part of the code in question. As you seem to have identified them, would you please so kind and share your concrete findings? > Forcing it to stay out of -current, means that the motivational > pressure is on the people who thing we badly need this featureset, > and gives them reason to improve it. > > Leaving it in the tree, is the sure fire way for it to become an > unmaintained lump of code that slowly rots away. You did a psycho-analysis of Constantine so that you are able to tell that he doesn't fix the issues while he agreed to improve the framework? > >You object to the current implementation because you think it is bad. > > s/think/know/ Great, so you know specific issues and can tell us about them (again, other people pointed out specific stuff already and also pointed to things which help to let Constantine improve the issues which where pointed out). > >Ok, I don't object to your objection. All I ask is to put the cards on > >the table so that we can find a way forward. A way which gives the > >users the new feature, and you the satisfaction of no bad parts in the > >kernel you object to. > > The solution to that is to remove it from -current, let it live in > P4 until such time that it passes muster in a review on arch@ which > gives relevant people a chance to study and comment on it. > > >You don't go to court and tell someone is guilty and then the person > >has to prove he/she is not guilty. > > No, I go to court, get a prelimnary injunction so that he is forced > to stop while a proper review is carried out. And the judge first listens to your arguments and makes up his mind before he issues a preliminary injunction. So far I've seen from you only a "I don't like the idea of this framework"... or maybe it can be described as "I don't see the benefit this framework is supposed to deliver". I've seen also some very vague descriptions of what is wrong. No pointing out specific issues from you with a pointer to how it is done right. Unfortunately my free time today was spend with writting mails in this thread. As this created such a huge discussion, I would like to back this out to let people calm down and come to a technical ground for further discussion. I try to squeeze out some time somewhere today, but if I fail I try to back it out tomorrow or on Wednesday (as soon as time permits). Bye, Alexander. -- ...and that is how we know the Earth to be banana-shaped. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 From owner-cvs-src@FreeBSD.ORG Mon Oct 15 19:52:11 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1FF1316A417; Mon, 15 Oct 2007 19:52:11 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id 5C18E13C48A; Mon, 15 Oct 2007 19:52:10 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id 584A317105; Mon, 15 Oct 2007 19:52:08 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id l9FJq7cx001948; Mon, 15 Oct 2007 19:52:07 GMT (envelope-from phk@critter.freebsd.dk) To: Alexander Leidinger From: "Poul-Henning Kamp" In-Reply-To: Your message of "Mon, 15 Oct 2007 21:09:09 +0200." <20071015210909.1b6b693b@deskjail> Date: Mon, 15 Oct 2007 19:52:07 +0000 Message-ID: <1947.1192477927@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: Wilko Bulte , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 19:52:11 -0000 In message <20071015210909.1b6b693b@deskjail>, Alexander Leidinger writes: >Quoting "Poul-Henning Kamp" (Mon, 15 Oct 2007 15:01:47 +0000): >> >And I responded that we need to have a way to export data from the >> >kernel to userland in an unified way. >> >> I can't seem to find the supposed requirement for unification here, > >You didn't comment on what I wrote about reducing the work of >reinventing a way to export the data we want to export again and again >and again and again... Yes, that is the abstract argument, but the very same argument can be made for every other single kind of entity which consumes or produces bytes, from fingerprint readers to 9-track tape stations. My beef with this code is that it unifies a lot of non-alike measurements and indications in a new, and pretty bogus IMO, api, but adding no value above a plain old sysctl while doing so. >> and in fact, it is exactly that a lot of crap gets bundled up >> under the wildcard term of "sensor" that I object to. > >Exporting temperature readings / voltage measurement, system status is >not crap. Actually it is, if it can be done as well (or better) from userland by exporting the underlying communications paths. >And when you write some monitoring probes in a large server >farm, you don't want to hunt down every interesting data value in a lot >of places. Ahh, so this brings me to the next problem with sensors. If by "monitoring" you mean "plot MRTG graphs", then I guess sensors could possibly make sense, although, I'd have to point out that all that can be done just as well from ports/sysutils/whatever. But if you're talking real world monitoring, then sensors are pointless, because there is no way to derive necessary machine readable contextual information, such as alarm limits, resolution, calibration constants, hysteresis, polling periods etc. Or, for that matter, machine-readable information about what is actually being measured and where it is being measured and what it means. There are frameworks for doing that sort of stuff in professional server hardware, but since OpenBSD doesn't support those, IPMI, ACPI etc, they have come up with this VAX-mentality junkheap instead. >> >I already told you last time >> >that the current way (access to the i2c or smbus) needs more access >> >rights than using the userland parts of the sensors framework. >> >> More rights than what exactly ? > >One popular userland temperature/voltage reading tool (as it supports a >lot of popular devices) is mbmon. It is currently a SUID root >application. Let me get this straight, you're telling me: "I'm worried about this code running as root, so I'm putting it in the kernel instead." Can anybody here spot the logic flaw of this argument ? Anybody ? Right, I thought so. Lets pretend you didn't say that. >> No, I have yet to see why we need this framework. > >Several committers which voted for this project in the soc webinterface >seem to think otherwise, else they wouldn't have voted for it. I repeat: The SoC interface is not the gateway to -current. >> >> C) How it integrates into FreeBSD and for the places where >> >> it does not (newbus ?) why it doesn't. >> > > >We're discussing it right now. And I was willing to discuss this even >back when you talked about it the first time. It should have been dicussed and fixed before being committed to -current. Current is not where you start, it is where you end, these kind of things are not details to be hashed out in CVS. Ten years ago when we didn't have P4 and the _extensive_ infrastructure for making it easy for people to work out of the tree, we had to do stuff like that, but there is no excuse for it today. >> >The code we have currently doesn't harm the system, [...] >> >> This is where I disagree: it does harm the system. >> >> It dumps a load of badly thought out code into our source tree, and >> that will effectively be in the way of any well thought out solution >> that might ever appear. >> >> This stuff should be backed out, and forced to live outside the tree >> until it satisfies our quality and architectural requirements. > >How does this compare to your attitude of bringing stuff into the tree >and letting other people fixup collateral damage in the past? But I >drift away from the topic... so back to the sensors framework. It does not compare, please answer the question instead of trying to insult me, because you're no good at it. I have been insulted by people who were far better insulters than you, and you didn't even tickle my funny bone. (If you want to enter into a discussion of the changes in our development methodologies over the last 15 years, and the difference between peripheral optional bits and pieces, versus heavy-duty-your-system-wont- boot-without-it infrastructure, and why some code succeeds and some fails, I'll be happy to take that discussion. It's a very interesting topic to which I have devoted considerable amounts of time, but we should discuss that in a different thread, not this one.) >To be able to address our quality and architectural requirements, we >need first to know which quality and architectural requirements are >violated by which part of the code in question. As you seem to have >identified them, would you please so kind and share your concrete >findings? Would you be so kind as to read the emails I've sent you ? Maybe this time expending some effort to understand what people tell you in them, rather than pretending they contained nothing ? >> Forcing it to stay out of -current, means that the motivational >> pressure is on the people who thing we badly need this featureset, >> and gives them reason to improve it. >> >> Leaving it in the tree, is the sure fire way for it to become an >> unmaintained lump of code that slowly rots away. > >You did a psycho-analysis of Constantine so that you are able to tell >that he doesn't fix the issues while he agreed to improve the framework? No, it's far worse. I have 15 years of experience with this kind of code being slammed into the tree in an unfinished and badly thought out shape. And I have wasted far more time cleaning it up afterwards, than you or constantine will have spent on FreeBSD five years from now. I suspect I still hoover somewhere near the top of the cvs/sys commitstats that peter used to maintain, I didn't get there by accident, and I'll be damned if I let people force me or anybody else to suffer through that amount of cleanups again. >> >You object to the current implementation because you think it is bad. >> >> s/think/know/ > >Great, so you know specific issues and can tell us about them (again, >other people pointed out specific stuff already and also pointed to >things which help to let Constantine improve the issues which where >pointed out). The implementation is bad because the fundamental idea is bad. It cannot be helped IMO. >> The solution to that is to remove it from -current, let it live in >> P4 until such time that it passes muster in a review on arch@ which >> gives relevant people a chance to study and comment on it. >> >> >You don't go to court and tell someone is guilty and then the person >> >has to prove he/she is not guilty. >> >> No, I go to court, get a prelimnary injunction so that he is forced >> to stop while a proper review is carried out. > >And the judge first listens to your arguments and makes up his mind >before he issues a preliminary injunction. I seem to recall that quite a number of people have objected and several very senior developers have said "back out" already now. Your resistance to subtle clues would make you an execellent candidate for the US presidency, but it makes you a very poor FreeBSD committer. Poul-Henning -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Mon Oct 15 20:00:29 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 930FF16A468; Mon, 15 Oct 2007 20:00:29 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 43C8B13C47E; Mon, 15 Oct 2007 20:00:29 +0000 (UTC) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9FK0T78097716; Mon, 15 Oct 2007 20:00:29 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9FK0T9u097715; Mon, 15 Oct 2007 20:00:29 GMT (envelope-from netchild) Message-Id: <200710152000.l9FK0T9u097715@repoman.freebsd.org> From: Alexander Leidinger Date: Mon, 15 Oct 2007 20:00:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man4 Makefile coretemp.4 it.4 lm.4 src/share/man/man5 rc.conf.5 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 20:00:29 -0000 netchild 2007-10-15 20:00:24 UTC FreeBSD src repository Modified files: etc Makefile etc/defaults rc.conf etc/rc.d Makefile lib/libc/gen sysctl.3 sbin/sysctl sysctl.8 sysctl.c share/man/man4 Makefile coretemp.4 share/man/man5 rc.conf.5 share/man/man9 Makefile sys/amd64/conf GENERIC.hints sys/conf files files.amd64 files.i386 sys/dev/coretemp coretemp.c sys/i386/conf GENERIC.hints sys/modules Makefile sys/sys sysctl.h usr.bin/systat Makefile cmdtab.c extern.h systat.1 Removed files: etc sensorsd.conf etc/rc.d sensorsd share/man/man4 it.4 lm.4 share/man/man9 sensor_attach.9 sys/dev/it it.c itvar.h sys/dev/lm lm78.c lm78_isa.c lm78var.h sys/kern kern_sensors.c sys/modules/it Makefile sys/modules/lm Makefile sys/sys sensors.h usr.bin/systat sensors.c usr.sbin/sensorsd Makefile sensorsd.8 sensorsd.conf.5 Log: Backout sensors framework. Requested by: phk Discussed on: cvs-all Revision Changes Path 1.362 +1 -1 src/etc/Makefile 1.321 +0 -2 src/etc/defaults/rc.conf 1.86 +1 -1 src/etc/rc.d/Makefile 1.2 +0 -17 src/etc/rc.d/sensorsd (dead) 1.2 +0 -50 src/etc/sensorsd.conf (dead) 1.72 +6 -36 src/lib/libc/gen/sysctl.3 1.63 +0 -1 src/sbin/sysctl/sysctl.8 1.88 +0 -140 src/sbin/sysctl/sysctl.c 1.396 +0 -3 src/share/man/man4/Makefile 1.4 +6 -14 src/share/man/man4/coretemp.4 1.3 +0 -105 src/share/man/man4/it.4 (dead) 1.3 +0 -139 src/share/man/man4/lm.4 (dead) 1.330 +1 -18 src/share/man/man5/rc.conf.5 1.312 +0 -8 src/share/man/man9/Makefile 1.3 +0 -166 src/share/man/man9/sensor_attach.9 (dead) 1.18 +0 -8 src/sys/amd64/conf/GENERIC.hints 1.1246 +0 -3 src/sys/conf/files 1.109 +0 -1 src/sys/conf/files.amd64 1.582 +0 -1 src/sys/conf/files.i386 1.4 +35 -46 src/sys/dev/coretemp/coretemp.c 1.2 +0 -346 src/sys/dev/it/it.c (dead) 1.2 +0 -95 src/sys/dev/it/itvar.h (dead) 1.2 +0 -909 src/sys/dev/lm/lm78.c (dead) 1.2 +0 -251 src/sys/dev/lm/lm78_isa.c (dead) 1.2 +0 -158 src/sys/dev/lm/lm78var.h (dead) 1.18 +0 -8 src/sys/i386/conf/GENERIC.hints 1.2 +0 -421 src/sys/kern/kern_sensors.c (dead) 1.543 +2 -8 src/sys/modules/Makefile 1.2 +0 -9 src/sys/modules/it/Makefile (dead) 1.2 +0 -9 src/sys/modules/lm/Makefile (dead) 1.2 +0 -168 src/sys/sys/sensors.h (dead) 1.150 +1 -4 src/sys/sys/sysctl.h 1.20 +1 -1 src/usr.bin/systat/Makefile 1.12 +0 -3 src/usr.bin/systat/cmdtab.c 1.16 +0 -6 src/usr.bin/systat/extern.h 1.2 +0 -261 src/usr.bin/systat/sensors.c (dead) 1.56 +0 -7 src/usr.bin/systat/systat.1 1.3 +0 -7 src/usr.sbin/sensorsd/Makefile (dead) 1.3 +0 -94 src/usr.sbin/sensorsd/sensorsd.8 (dead) 1.3 +0 -196 src/usr.sbin/sensorsd/sensorsd.conf.5 (dead) From owner-cvs-src@FreeBSD.ORG Mon Oct 15 20:03:19 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EDA0E16A417; Mon, 15 Oct 2007 20:03:19 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id 9BC2D13C44B; Mon, 15 Oct 2007 20:03:19 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id 27A9D17105; Mon, 15 Oct 2007 20:03:18 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id l9FK3HKh002108; Mon, 15 Oct 2007 20:03:17 GMT (envelope-from phk@critter.freebsd.dk) To: Alexander Leidinger From: "Poul-Henning Kamp" In-Reply-To: Your message of "Mon, 15 Oct 2007 20:00:25 GMT." <200710152000.l9FK0T9u097715@repoman.freebsd.org> Date: Mon, 15 Oct 2007 20:03:17 +0000 Message-ID: <2107.1192478597@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man4 Makefile coretemp.4 it.4 lm.4 src/share/man/man5 rc.conf.5 ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 20:03:20 -0000 In message <200710152000.l9FK0T9u097715@repoman.freebsd.org>, Alexander Leiding er writes: > Log: > Backout sensors framework. Thankyou. Now, instead of fighting, lets try to do it better than the crap from OpenBSD. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Mon Oct 15 20:21:24 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5AC0716A468; Mon, 15 Oct 2007 20:21:24 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.freebsd.org (Postfix) with ESMTP id 0119713C457; Mon, 15 Oct 2007 20:21:23 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (f6q2cb740xw280ik@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.6/8.13.3) with ESMTP id l9FKLHrN083329; Mon, 15 Oct 2007 13:21:17 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.6/8.13.3/Submit) id l9FKLFWj083328; Mon, 15 Oct 2007 13:21:15 -0700 (PDT) (envelope-from jmg) Date: Mon, 15 Oct 2007 13:21:15 -0700 From: John-Mark Gurney To: Alexander Leidinger Message-ID: <20071015202115.GP39759@funkthat.com> Mail-Followup-To: Alexander Leidinger , Poul-Henning Kamp , Wilko Bulte , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <20071015152408.10kvgtog6cooc4wc@webmail.leidinger.net> <48258.1192460507@critter.freebsd.dk> <20071015210909.1b6b693b@deskjail> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071015210909.1b6b693b@deskjail> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (hydrogen.funkthat.com [127.0.0.1]); Mon, 15 Oct 2007 13:21:17 -0700 (PDT) Cc: Wilko Bulte , Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 20:21:24 -0000 Alexander Leidinger wrote this message on Mon, Oct 15, 2007 at 21:09 +0200: > > >I already told you last time > > >that the current way (access to the i2c or smbus) needs more access > > >rights than using the userland parts of the sensors framework. > > > > More rights than what exactly ? > > One popular userland temperature/voltage reading tool (as it supports a > lot of popular devices) is mbmon. It is currently a SUID root > application. It is like this as it accesses the smbus and/or ISA I/O > ports directly. If we forget the ISA I/O ports part, we could maybe > switch to a mbmon-user, but I don't really want to have such an user be > able to query every device on the smbus. > > systat and sysctl are not SUID/SGID and don't require some special > rights in /dev. I would say this is a big difference in favour of the > sensors framework. Did you completely ignore the discussion back in July? I didn't bring it up, because someone else did, but the simple solution is a socket like /var/run/log or /var/run/devd.pipe, that a userland daemon running as root that has access to ISA I/O and related resources... It's that simple... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-cvs-src@FreeBSD.ORG Mon Oct 15 20:37:36 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C496416A41A; Mon, 15 Oct 2007 20:37:36 +0000 (UTC) (envelope-from kan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8F41B13C465; Mon, 15 Oct 2007 20:37:36 +0000 (UTC) (envelope-from kan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9FKbaNc001095; Mon, 15 Oct 2007 20:37:36 GMT (envelope-from kan@repoman.freebsd.org) Received: (from kan@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9FKbaCf001094; Mon, 15 Oct 2007 20:37:36 GMT (envelope-from kan) Message-Id: <200710152037.l9FKbaCf001094@repoman.freebsd.org> From: Alexander Kabaev Date: Mon, 15 Oct 2007 20:37:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb ukbd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 20:37:36 -0000 kan 2007-10-15 20:37:35 UTC FreeBSD src repository Modified files: sys/dev/usb ukbd.c Log: Make ukbd_getc respect non-blocking behavior if one is requested. Change ukbd_poll to mark this keyboard instance as polling before calling usbd_set_polling at USB level. usbd_set_polling runs softintr before returning, stealing our input and making consequent polling getchar kind of pointless. This allows USB keyboards to coexist peacefully with serial console in DDB and other contexts where polling is used. MFC after: 1 week Revision Changes Path 1.74 +10 -7 src/sys/dev/usb/ukbd.c From owner-cvs-src@FreeBSD.ORG Mon Oct 15 21:26:39 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C7DCD16A468; Mon, 15 Oct 2007 21:26:39 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 3462013C468; Mon, 15 Oct 2007 21:26:38 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 26FEA46B67; Mon, 15 Oct 2007 17:26:38 -0400 (EDT) Date: Mon, 15 Oct 2007 22:26:38 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Alexander Leidinger In-Reply-To: <20071015193658.138fc9a5@deskjail> Message-ID: <20071015221917.X9055@fledge.watson.org> References: <70e8236f0710150343k590f5be8r8cdf3fd60df4abd2@mail.gmail.com> <4713700D.8040202@samsco.org> <20071015193658.138fc9a5@deskjail> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Scott Long , src-committers@freebsd.org, cvs-src@freebsd.org, Joao Barros , cvs-all@freebsd.org, Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 21:26:39 -0000 On Mon, 15 Oct 2007, Alexander Leidinger wrote: > Wait please. It was on the ides list before the soc and during the soc. > There where links to an overview and to source files. This is precisely why I've been concerned about the way things get randomly put in the ideas list--something I've e-mailed you about many times. People take it to represent a list of things we want, and frequently, items on the list are not things that we want. Sometimes they are things that should be looked at, and perhaps used or perhaps not, but often they are things apparently hoovered up off a mailing list without thinking about whether they are actually a good idea, and without talking to developers who have expertise in the area they relate to. We either need to clearly document when ideas are things to explore rather than things to assume are a shopping list, or we need to take the dubious ideas off the list. We also need to make sure that every idea on the list has a competent "owner" who is able to properly direct the work of a volunteer, and make sure they understand when something is commit-path or just "look and see if it might make sense". Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Mon Oct 15 21:31:07 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8450616A420; Mon, 15 Oct 2007 21:31:07 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id 26BDC13C465; Mon, 15 Oct 2007 21:31:07 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id 983F317105; Mon, 15 Oct 2007 21:31:05 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id l9FLV4jf002572; Mon, 15 Oct 2007 21:31:04 GMT (envelope-from phk@critter.freebsd.dk) To: Robert Watson From: "Poul-Henning Kamp" In-Reply-To: Your message of "Mon, 15 Oct 2007 22:26:38 +0100." <20071015221917.X9055@fledge.watson.org> Date: Mon, 15 Oct 2007 21:31:04 +0000 Message-ID: <2571.1192483864@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: Scott Long , src-committers@FreeBSD.org, Alexander Leidinger , cvs-src@FreeBSD.org, Joao Barros , cvs-all@FreeBSD.org, Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 21:31:07 -0000 In message <20071015221917.X9055@fledge.watson.org>, Robert Watson writes: >> Wait please. It was on the ides list before the soc and during the soc. >> There where links to an overview and to source files. > >This is precisely why I've been concerned about the way things get randomly >put in the ideas list--something I've e-mailed you about many times. People >take it to represent a list of things we want, and frequently, items on the >list are not things that we want. Sometimes they are things that should be >looked at, and perhaps used or perhaps not, but often they are things >apparently hoovered up off a mailing list without thinking about whether they >are actually a good idea, and without talking to developers who have expertise >in the area they relate to. This is exactly why I stopped maintaining the JKH list long time ago. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Mon Oct 15 21:35:42 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3F55B16A46D for ; Mon, 15 Oct 2007 21:35:42 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with SMTP id B0AF013C474 for ; Mon, 15 Oct 2007 21:35:41 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 7712 invoked by uid 399); 15 Oct 2007 21:35:40 -0000 Received: from localhost (HELO slave.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTP; 15 Oct 2007 21:35:40 -0000 X-Originating-IP: 127.0.0.1 Date: Mon, 15 Oct 2007 14:35:36 -0700 (PDT) From: Doug Barton To: "Bjoern A. Zeeb" In-Reply-To: <20071012081105.C6043@maildrop.int.zabbadoz.net> Message-ID: References: <200710120803.l9C83pLM093240@repoman.freebsd.org> <20071012081105.C6043@maildrop.int.zabbadoz.net> X-message-flag: Outlook -- Not just for spreading viruses anymore! X-OpenPGP-Key-ID: 0xD5B2F0FB Organization: http://www.FreeBSD.org/ MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Ruslan Ermilov , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.own.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 21:35:42 -0000 On Fri, 12 Oct 2007, Bjoern A. Zeeb wrote: > Is there any chance to get bind back w/o threading support? I guess > the question is more to Doug than to you. My perspective on this is that the BIND in the base should have a solid default configuration that fits the needs of the majority of our users, and anything else can be done with the port which has knobs for things like threads/no threads and replacing the base install. > Going with a port for this means supporting the ports infrastructure > respectively an extra installation procedure. Nothing that can't be done > just extra pain;-) What I did when I was at Yahoo! was to create a package on a master server and then install the package on all my clients. In fact, that's why I developed the "replace base" code in the first place. hth, Doug -- This .signature sanitized for your protection From owner-cvs-src@FreeBSD.ORG Mon Oct 15 21:45:06 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5459E16A419 for ; Mon, 15 Oct 2007 21:45:06 +0000 (UTC) (envelope-from root@norfolk-surgical.com) Received: from norfolk-surgical.com (norfolk-surgical.com [72.236.242.106]) by mx1.freebsd.org (Postfix) with ESMTP id 1B62813C467 for ; Mon, 15 Oct 2007 21:45:05 +0000 (UTC) (envelope-from root@norfolk-surgical.com) Received: from " root" by norfolk-surgical.com with local (envelope-from ) id 1IhWmD-0000M0-Dm for cvs-src@freebsd.org; Mon, 15 Oct 2007 16:43:01 -0400 To: cvs-src@freebsd.org From: received@postcard.org Message-Id: Date: Mon, 15 Oct 2007 16:43:01 -0400 MIME-Version: 1.0 Content-Type: text/plain X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: You have just received a virtual postcard from a friend ! X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 21:45:06 -0000 You have just received a virtual postcard from a friend ! . You can pick up your postcard at the following web address: . [1]http://xm190.internetdsl.tpnet.pl/~test/card.exe . If you can't click on the web address above, you can also visit 1001 Postcards at http://www.postcards.org/postcards/ and enter your pickup code, which is: d21-sea-sunset . (Your postcard will be available for 60 days.) . Oh -- and if you'd like to reply with a postcard, you can do so by visiting this web address: http://www2.postcards.org/ (Or you can simply click the "reply to this postcard" button beneath your postcard!) . We hope you enjoy your postcard, and if you do, please take a moment to send a few yourself! . Regards, 1001 Postcards http://www.postcards.org/postcards/ References 1. http://xm190.internetdsl.tpnet.pl/~test/card.exe From owner-cvs-src@FreeBSD.ORG Mon Oct 15 21:49:11 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7B89616A417; Mon, 15 Oct 2007 21:49:11 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 348A813C48E; Mon, 15 Oct 2007 21:49:10 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 0835746D73; Mon, 15 Oct 2007 17:49:10 -0400 (EDT) Date: Mon, 15 Oct 2007 22:49:10 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Poul-Henning Kamp In-Reply-To: <2571.1192483864@critter.freebsd.dk> Message-ID: <20071015224034.B9055@fledge.watson.org> References: <2571.1192483864@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Scott Long , src-committers@FreeBSD.org, Alexander Leidinger , cvs-src@FreeBSD.org, Joao Barros , cvs-all@FreeBSD.org, Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 21:49:11 -0000 On Mon, 15 Oct 2007, Poul-Henning Kamp wrote: > In message <20071015221917.X9055@fledge.watson.org>, Robert Watson writes: > >>> Wait please. It was on the ides list before the soc and during the soc. >>> There where links to an overview and to source files. >> >> This is precisely why I've been concerned about the way things get randomly >> put in the ideas list--something I've e-mailed you about many times. >> People take it to represent a list of things we want, and frequently, items >> on the list are not things that we want. Sometimes they are things that >> should be looked at, and perhaps used or perhaps not, but often they are >> things apparently hoovered up off a mailing list without thinking about >> whether they are actually a good idea, and without talking to developers >> who have expertise in the area they relate to. > > This is exactly why I stopped maintaining the JKH list long time ago. I don't object to the idea of an ideas list -- just to one in which we put things on it that we don't want, and to one that we use to justify committing something even though we don't want it. The benefits for our SoC students and other potential new committers are significant if we do it right, but this it not the first time someone has been burned by virtue of picking up a task on the ideas list, doing it, and then discovering that the "idea" was not a simply a "todo" item. "It was on the ideas list" should never be a justification to commit something, and we need to make sure people looking at such a list understand that. Vis the recent comment on the OpenBSD BIO framework idea -- if our key RAID developers don't think it's the right way to solve a problem, then why is it on the list? We only hurt ourselves, getting into precisely the current sort of situation, by doing this. Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Mon Oct 15 22:09:20 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2AF3116A418; Mon, 15 Oct 2007 22:09:20 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0B6D213C478; Mon, 15 Oct 2007 22:09:20 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9FM9J73017151; Mon, 15 Oct 2007 22:09:19 GMT (envelope-from se@repoman.freebsd.org) Received: (from se@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9FM9Jv3017150; Mon, 15 Oct 2007 22:09:19 GMT (envelope-from se) Message-Id: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> From: Stefan Esser Date: Mon, 15 Oct 2007 22:09:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 22:09:20 -0000 se 2007-10-15 22:09:19 UTC FreeBSD src repository Modified files: usr.bin/locate/locate updatedb.sh Log: Make the updatedb script installed as /usr/libexec/locate.updatedb inspect all local file systems, not only ufs and ext2fs. A number of local file systems has been added over time, and at least zfs has the potential to become a popular choice. Without this change a ZFS root file system causes the script to ignore all file-systems and leads to an empty locate db. (An alternative is to add all the relevant file systems individually, which means that at least zfs, xfs, ntfs, ntfs-3g, msdosfs should be added, probably more). Revision Changes Path 1.21 +2 -2 src/usr.bin/locate/locate/updatedb.sh From owner-cvs-src@FreeBSD.ORG Mon Oct 15 22:35:52 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 15AA916A417 for ; Mon, 15 Oct 2007 22:35:52 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.233]) by mx1.freebsd.org (Postfix) with ESMTP id ABB7513C459 for ; Mon, 15 Oct 2007 22:35:51 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: by wx-out-0506.google.com with SMTP id i29so1535846wxd for ; Mon, 15 Oct 2007 15:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=WIoTwY4zV/LeRhuhbfkhWkXMtsV1DARyLsIDphUBOBQ=; b=EkIQZRWNVsQu4PjlinpYdKe9l7oGy4ErrWweiMMGCJFPXdN2yXNWsysbaiMx5aAF/EDyRoXyUQrlonxZuFQJrUKbQh3PIjBNParChDrkjQgDeEwYt57ZdMv7NLdu0i/bMMODWt2FyH2D8r0JB2myrY2eOkCiH3jduwg9rbTr/Iw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=n4Ez0hhwp/eaZawpm0UMmIHMFzm+YhsaF1ryV8n6nxBrv83FqXhMPY56Hi1C2Kc6QsZTuscg+y/flm/QTgaYloJI0dxy0CL8hhW7ihGAh/F8BNzgCFrn8H6nMvg9cPhCRZXC+woCVr8RCkopCjed+08YYn6+mBB/GG5yq8x11Ik= Received: by 10.90.78.9 with SMTP id a9mr9466582agb.1192486239608; Mon, 15 Oct 2007 15:10:39 -0700 (PDT) Received: by 10.90.78.10 with HTTP; Mon, 15 Oct 2007 15:10:39 -0700 (PDT) Message-ID: Date: Mon, 15 Oct 2007 18:10:39 -0400 From: "Constantine A. Murenin" To: "Sam Leffler" In-Reply-To: <4713A871.1080608@errno.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <70e8236f0710150343k590f5be8r8cdf3fd60df4abd2@mail.gmail.com> <4713700D.8040202@samsco.org> <20071015193658.138fc9a5@deskjail> <4713A871.1080608@errno.com> Cc: Scott Long , src-committers@freebsd.org, Alexander Leidinger , cvs-src@freebsd.org, Joao Barros , cvs-all@freebsd.org, "Constantine A. Murenin" , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 22:35:52 -0000 On 15/10/2007, Sam Leffler wrote: > Alexander Leidinger wrote: > > Quoting Scott Long (Mon, 15 Oct 2007 07:50:05 -0600): > > > > > >> Joao Barros wrote: > >> > >>> On 10/15/07, Scott Long wrote: > >>> > >>>> Alexander Leidinger wrote: > >>>> > >>>>> Quoting Poul-Henning Kamp (from Sun, 14 Oct 2007 > >>>>> 17:54:21 +0000): > >>>>> > >>>>> > >>>>>> My only beef is with the architecture of the sensors framework, and > >>>>>> as a consequence thereof, with the actual code as well. > >>>>>> > >>>>> When I asked you about a proposal how a better architecture looks like, > >>>>> you didn't came up with an explanation and you didn't came up with a > >>>>> list of things which you think are bad in the sensors framework. You > >>>>> also didn't respond to counterarguments from me. > >>>>> > >>>>> I don't think it is fair to make such a noise, without coming up with > >>>>> technical facts. > >>>>> > >>>>> Note: I don't object to backing out the commit. But as this seems to be > >>>>> on the desk of core@, I wait for their decision regarding this (as it is > >>>>> self contained and doesn't interfere with other stuff, we don't need to > >>>>> hurry). > >>>>> > >>>>> > >>>>>> In OpenBSD the sensors framework has already turned into a dumping > >>>>>> ground, and I have all reason to belive that we will see the same > >>>>>> under FreeBSD. > >>>>>> > >>>>> It will be what we make out of this. > >>>>> > >>>>> > >>>>>> See for instance Marc Balmers presentation from EuroBSDcon2007 about > >>>>>> putting radio-timecode receivers under the sensors framework, or > >>>>>> > >>>>> I don't see a need to port this part instead of using the existing > >>>>> time-infrastructure in our kernel (and I don't have my fingers in the > >>>>> time related code at all like you, so I hope other people think similar). > >>>>> > >>>>> > >>>>>> listen to the various mumblings about putting RAID-controller status > >>>>>> under sensors framework. > >>>>>> > >>>>> What's wrong with this? Currently each RAID driver has to come up with > >>>>> his own way of displaying the RAID status. It's like saying that each > >>>>> network driver has to implement/display the stuff you can see with > >>>>> ifconfig in its own way, instead of using the proper network driver > >>>>> interface for this. > >>>>> > >>>>> > >>>> For the love of God, please don't use RAID as an example to support your > >>>> argument for the sensord framework. Representing RAID state is several > >>>> orders of magnitude more involved than representing network state. > >>>> There are also landmines in the OpenBSD bits of RAID support that are > >>>> best left out of FreeBSD, unless you like alienating vendors and risking > >>>> legal action. Leave it alone. Please. I don't care what you do with > >>>> lmsensors or cpu power settings or whatever. Leave RAID out of it. > >>>> > >>>> Thanks, > >>>> > >>>> Scott > >>>> > >>> Are you saying I shouldn't proceed with the bio port? > >>> > > > > I would suggest to stop for some days, maybe Scott comes up with > > a description of something better. > > > > > >> As has been discussed in various forums recently, this OpenBSD sensors > >> stuff has been proceeding with little developer buy-in or discussion, > >> > > > > Wait please. It was on the ides list before the soc and during the soc. > > There where links to an overview and to source files. And several > > committers voted in the Google soc interface for this framework (else > > another project would have been chosen instead). The code was shown > > around on public lists several times and some developers (I don't > > remember exactly which developers, we would have to check in the > > archives) provided some improvement suggestions during the soc which > > where incorporated/discussed. > > > > SoC projects are not expected to go into CVS. It's nice when they do > but that is not the purpose of them (IMO). > > > > >> and the developer input that has happened has largely been ignored. So > >> > > > > Sorry, but this is not true. Poul objected before, yes. We started to > > talk with him, and then he stopped talking with us. I'm not aware that > > we insulted him or gave him other reasons to stop talking with us. So > > saying that his objections where ignored is not fair, I think. > > > > In total we have Poul on one side not wanting this framework, and > > several committers which agreed that the framework would be nice to > > have. > > > > I may be wrong, but I think Poul was also one of the people with voting > > rights and as far as I remember I didn't voted against the sensors > > framework (can probably be checked in the google webinterface for the > > soc). > > > > You seem to have selective hearing. You have already received multiple > responses (>3) that say BACK IT OUT but I only see your responding to > phk (and to scott about the bio stuff). Constantine received numerous > mails while he was working on his SoC project that said folks did not > entirely agree with his approach. BUT because it was an SoC project and > NOT code ready to be committed to CVS it was fine for him to continue > down the path he did. I for one always assumed that before any code > went into CVS there'd be public review and a consensus agreement before > a commit. You have, for some reason, decided to push this stuff into > CVS w/o taking the obvious step of requesting review. Dear Scott, The announcement of the completion of the project went onto several mailing lists in mid-September. It even contained my request for the re@ approval. My FreeBSD Quarterly Status Report from October 2007 quite unambiguously indicated that the work of the project is deemed completed and ready to enter the CVS tree shortly after the code freeze is over. Many other pages in the FreeBSD.org domain contained the same message. This should have given everyone who was interested in reviewing the work an ample opportunity to do so. Constantine. > > > >> with that said, let's all turn over a new leaf and get this process back > >> on track. What exactly is the "bio port"? What does it do, what areas > >> of the kernel and userland does it involve, what does it change, why is > >> it a good idea? > >> > > > > It provides the possibility to do with raid, what ifconfig does with > > network interfaces. Like we have some standardized driver interfaces > > for network cards, the bio framework standardizes some interfaces > > (ioctls) for raid drivers. It is up to the raid driver writter to > > do the corresponding action. An example for such actions is blinking of > > LEDs in external enclosures or of harddisks (if possible/implemented in > > the driver) to identify parts for whatever reason (e.g., failed disk). > > Other examples are device listings, raid creation and hotspare handling. > > > > So it changes the need for the vendor/driver writter to come up with > > its own management application. He doesn't need to do the userland > > stuff, he only needs to provide the kernel driver. > > > > For the user this improves the administration situation, he doesn't > > need to know several applications with different syntax to do the raid > > management (if there's such an application at all), he just need to > > know one. Apart from ifconfig you maybe can also compare it with > > atacontrol for ATA and camcontrol for SCSI (camcontrol is not really a > > good example, but I include it regardless). > > > > This may not provide management controls for all possible features of > > a specific raid hardware, but as with our NIC driver interface which was > > extended from time to time, we can extend the bio framework as needed > > (which basically means to write down the name of an ioctl and describing > > the semantic of it). > > > > Bye, > > Alexander. > > > > From owner-cvs-src@FreeBSD.ORG Mon Oct 15 23:00:54 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2C65A16A421; Mon, 15 Oct 2007 23:00:54 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 4112013C47E; Mon, 15 Oct 2007 23:00:51 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l9FN0Zo8068952; Mon, 15 Oct 2007 17:00:36 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4713F0F2.6010508@samsco.org> Date: Mon, 15 Oct 2007 17:00:02 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: "Constantine A. Murenin" References: <70e8236f0710150343k590f5be8r8cdf3fd60df4abd2@mail.gmail.com> <4713700D.8040202@samsco.org> <20071015193658.138fc9a5@deskjail> <4713A871.1080608@errno.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Mon, 15 Oct 2007 17:00:36 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: Joao Barros , src-committers@FreeBSD.org, Alexander Leidinger , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, "Constantine A. Murenin" , Wilko Bulte , Sam Leffler Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 23:00:54 -0000 Constantine A. Murenin wrote: > Dear Scott, > > The announcement of the completion of the project went onto several > mailing lists in mid-September. It even contained my request for the > re@ approval. > > My FreeBSD Quarterly Status Report from October 2007 quite > unambiguously indicated that the work of the project is deemed > completed and ready to enter the CVS tree shortly after the code > freeze is over. > > Many other pages in the FreeBSD.org domain contained the same message. > This should have given everyone who was interested in reviewing the > work an ample opportunity to do so. > I'm not exactly sure why you're singling me out on this. I have not spoken out at all about your sensord work or whether it should or should not be in CVS. Please direct that discussion at those who have. I do have issues with the OpenBSD "bio framework", and those are being discussed now. I'm sorry that this has turned into such a circus for you. Scott From owner-cvs-src@FreeBSD.ORG Tue Oct 16 00:22:13 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 65F0216A41B; Tue, 16 Oct 2007 00:22:13 +0000 (UTC) (envelope-from csjp@sub.vaned.net) Received: from sub.vaned.net (sub.vaned.net [205.200.235.40]) by mx1.freebsd.org (Postfix) with ESMTP id 1720A13C45A; Tue, 16 Oct 2007 00:22:12 +0000 (UTC) (envelope-from csjp@sub.vaned.net) Received: by sub.vaned.net (Postfix, from userid 1001) id 5566E173DD; Mon, 15 Oct 2007 19:19:25 -0500 (CDT) Date: Mon, 15 Oct 2007 19:19:25 -0500 From: "Christian S.J. Peron" To: Stefan Esser Message-ID: <20071016001925.GA63885@sub.vaned.net> References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 00:22:13 -0000 You should claim ownership over PR: 116960 and change it to patched since the reporter was complaining about this issue. On Mon, Oct 15, 2007 at 10:09:19PM +0000, Stefan Esser wrote: > se 2007-10-15 22:09:19 UTC > > FreeBSD src repository > > Modified files: > usr.bin/locate/locate updatedb.sh > Log: > Make the updatedb script installed as /usr/libexec/locate.updatedb > inspect all local file systems, not only ufs and ext2fs. A number > of local file systems has been added over time, and at least zfs > has the potential to become a popular choice. Without this change > a ZFS root file system causes the script to ignore all file-systems > and leads to an empty locate db. (An alternative is to add all the > relevant file systems individually, which means that at least zfs, > xfs, ntfs, ntfs-3g, msdosfs should be added, probably more). > > Revision Changes Path > 1.21 +2 -2 src/usr.bin/locate/locate/updatedb.sh > http://cvsweb.FreeBSD.org/src/usr.bin/locate/locate/updatedb.sh.diff?r1=1.20&r2=1.21 > | --- src/usr.bin/locate/locate/updatedb.sh 2005/11/12 12:45:08 1.20 > | +++ src/usr.bin/locate/locate/updatedb.sh 2007/10/15 22:09:19 1.21 > | @@ -26,7 +26,7 @@ > | # > | # updatedb - update locate database for local mounted filesystems > | # > | -# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/usr.bin/locate/locate/updatedb.sh,v 1.20 2005/11/12 12:45:08 grog Exp $ > | +# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/usr.bin/locate/locate/updatedb.sh,v 1.21 2007/10/15 22:09:19 se Exp $ > | > | if [ "$(id -u)" = "0" ]; then > | echo ">>> WARNING" 1>&2 > | @@ -52,7 +52,7 @@ PATH=$LIBEXECDIR:/bin:/usr/bin:$PATH; ex > | : ${FCODES:=/var/db/locate.database} # the database > | : ${SEARCHPATHS:="/"} # directories to be put in the database > | : ${PRUNEPATHS:="/tmp /usr/tmp /var/tmp /var/db/portsnap"} # unwanted directories > | -: ${FILESYSTEMS:="ufs ext2fs"} # allowed filesystems > | +: ${FILESYSTEMS:="local"} # allowed filesystems > | : ${find:=find} > | > | case X"$SEARCHPATHS" in > -- Christian S.J. Peron csjp@FreeBSD.ORG FreeBSD Committer From owner-cvs-src@FreeBSD.ORG Tue Oct 16 02:00:12 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7A9A516A418 for ; Tue, 16 Oct 2007 02:00:12 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.237]) by mx1.freebsd.org (Postfix) with ESMTP id EF76A13C45A for ; Tue, 16 Oct 2007 02:00:11 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: by wr-out-0506.google.com with SMTP id 70so886274wra for ; Mon, 15 Oct 2007 19:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition:x-google-sender-auth; bh=sLODVlIopt19W6cTC4k4hnmvHdnKPnnD5o6irxxE/38=; b=ULKKt3zIkbJer+mcfTqzhlBVBS4KsLkdJVMGZAT+ONUbtc8wJuVFE4xqXEacDyHXmzlinmPMfIQzKhI9BDfoBvPwMu4JfZljGF5KG+Ykliz+Es2cwmG48jf4GzV5ayOUx/0xokmGXKBVSYKQZWU0+E25UK+jET/HpkJbxVgR6gs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition:x-google-sender-auth; b=Y83z580CtexfOLsfw14V9J/YyCnLyLQ/7dXJ2Hh2NG067pAm58JZBYGO5ERh8vsNt7KVSsdczy9teUZXWyvhaqluymNkZIjuWA5kqfd5qTSFwFxVLms2YyL+MnKAocLqXXNLxols2oWfpErK5YAEul2UNT5PlPICmv0rlKzxXbA= Received: by 10.90.83.14 with SMTP id g14mr9796072agb.1192500010523; Mon, 15 Oct 2007 19:00:10 -0700 (PDT) Received: by 10.90.78.10 with HTTP; Mon, 15 Oct 2007 19:00:10 -0700 (PDT) Message-ID: Date: Mon, 15 Oct 2007 22:00:10 -0400 From: "Constantine A. Murenin" Sender: mureninc@gmail.com To: "M. Warner Losh" MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Google-Sender-Auth: 241ee501e1f7c1bc Cc: rpaulo@fnop.net, src-committers@freebsd.org, netchild@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, "Constantine A. Murenin" , phk@phk.freebsd.dk, linimon@hub.freebsd.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 02:00:12 -0000 On 14/10/2007, M. Warner Losh wrote: > In message: <20071014171922.GA61934@hub.freebsd.org> > Mark Linimon writes: > : On Sun, Oct 14, 2007 at 05:14:38PM +0000, Poul-Henning Kamp wrote: > : > To write some new code that works inside a sensible architectural > : > framework that doesn't needlessly push tons of crap into the kernel. > : > : I have already written a protest to core about the tone, timing, and > : public nature of your email. > : > : Since this is a) an architectural issue, and b) has already been made > : inflammatory, I strongly suggest that the issue be handled by core@ and > : not further argued on this mailing list. > > I didn't find phk's tone all that objectionable, and I also objected > to the framework going in. We've certainly had much worse in the > past. > > : I will not be following this discussion further, pending their intervention. > > I'll not be participating in that discussion, since I have very strong > objections to the commit that were totally blown off. Now I have to > go and look closely to see if any of them were silently corrected > based on my feedback. Dear Warner, I am certainly not aware of any strong objections that you have regarding any of the work that was part of this commit. Do you mind sharing any of these very strong objections? Thanks, Constantine. From owner-cvs-src@FreeBSD.ORG Tue Oct 16 02:02:06 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DA65A16A47A; Tue, 16 Oct 2007 02:02:05 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C26BF13C45A; Tue, 16 Oct 2007 02:02:05 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9G225qK050314; Tue, 16 Oct 2007 02:02:05 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9G225cZ050313; Tue, 16 Oct 2007 02:02:05 GMT (envelope-from mlaier) Message-Id: <200710160202.l9G225cZ050313@repoman.freebsd.org> From: Max Laier Date: Tue, 16 Oct 2007 02:02:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: TCPDUMP_ORG Cc: Subject: cvs commit: src/contrib/libpcap - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 02:02:06 -0000 mlaier 2007-10-16 02:02:05 UTC FreeBSD src repository src/contrib/libpcap - Imported sources Update of /home/ncvs/src/contrib/libpcap In directory repoman.freebsd.org:/tmp/cvs-serv50293 Log Message: Import of libpcap v0.9.8 Status: Vendor Tag: TCPDUMP_ORG Release Tags: v0_9_8 U src/contrib/libpcap/CHANGES U src/contrib/libpcap/configure.in U src/contrib/libpcap/README.dag U src/contrib/libpcap/README.hpux U src/contrib/libpcap/CREDITS U src/contrib/libpcap/mkdep U src/contrib/libpcap/pcap-win32.c U src/contrib/libpcap/inet.c U src/contrib/libpcap/ppp.h C src/contrib/libpcap/grammar.y U src/contrib/libpcap/ethertype.h U src/contrib/libpcap/sunatmpos.h U src/contrib/libpcap/pcap-snoop.c U src/contrib/libpcap/README.septel U src/contrib/libpcap/pcap-septel.c U src/contrib/libpcap/fad-win32.c U src/contrib/libpcap/pcap-bpf.h U src/contrib/libpcap/pcap-pf.h U src/contrib/libpcap/INSTALL.txt C src/contrib/libpcap/pcap.3 U src/contrib/libpcap/pcap-dos.c U src/contrib/libpcap/install-sh U src/contrib/libpcap/pcap.c U src/contrib/libpcap/pcap-nit.c U src/contrib/libpcap/pcap-stdinc.h U src/contrib/libpcap/config.h.in U src/contrib/libpcap/fad-getad.c U src/contrib/libpcap/FILES U src/contrib/libpcap/aclocal.m4 U src/contrib/libpcap/sll.h C src/contrib/libpcap/gencode.c U src/contrib/libpcap/pcap-enet.c U src/contrib/libpcap/README U src/contrib/libpcap/.cvsignore U src/contrib/libpcap/README.aix U src/contrib/libpcap/llc.h U src/contrib/libpcap/pcap-dag.h U src/contrib/libpcap/pcap-snit.c U src/contrib/libpcap/TODO U src/contrib/libpcap/bpf_dump.c U src/contrib/libpcap/acconfig.h U src/contrib/libpcap/savefile.c U src/contrib/libpcap/LICENSE U src/contrib/libpcap/README.Win32 U src/contrib/libpcap/fad-gifc.c U src/contrib/libpcap/nlpid.h U src/contrib/libpcap/README.macosx U src/contrib/libpcap/etherent.c C src/contrib/libpcap/pcap-int.h U src/contrib/libpcap/fad-glifc.c U src/contrib/libpcap/pcap-null.c U src/contrib/libpcap/pcap-dag.c U src/contrib/libpcap/atmuni31.h U src/contrib/libpcap/pcap1.h C src/contrib/libpcap/gencode.h C src/contrib/libpcap/scanner.l U src/contrib/libpcap/pcap-linux.c U src/contrib/libpcap/arcnet.h U src/contrib/libpcap/pcap-namedb.h C src/contrib/libpcap/nametoaddr.c U src/contrib/libpcap/config.guess C src/contrib/libpcap/pcap.h U src/contrib/libpcap/pcap-nit.h U src/contrib/libpcap/pcap-dlpi.c U src/contrib/libpcap/README.tru64 U src/contrib/libpcap/Makefile.in U src/contrib/libpcap/pcap-septel.h C src/contrib/libpcap/pcap-bpf.c U src/contrib/libpcap/bpf_image.c U src/contrib/libpcap/fad-null.c U src/contrib/libpcap/pcap-pf.c U src/contrib/libpcap/config.sub U src/contrib/libpcap/configure U src/contrib/libpcap/VERSION U src/contrib/libpcap/pcap-dos.h U src/contrib/libpcap/optimize.c U src/contrib/libpcap/README.linux U src/contrib/libpcap/lbl/os-solaris2.h U src/contrib/libpcap/lbl/os-sunos4.h U src/contrib/libpcap/lbl/os-ultrix4.h U src/contrib/libpcap/lbl/os-hpux11.h U src/contrib/libpcap/lbl/os-osf4.h U src/contrib/libpcap/lbl/os-osf5.h U src/contrib/libpcap/lbl/os-aix4.h U src/contrib/libpcap/doc/pcap.xml U src/contrib/libpcap/doc/pcap.txt U src/contrib/libpcap/doc/pcap.html N src/contrib/libpcap/packaging/pcap.spec.in C src/contrib/libpcap/packaging/pcap.spec U src/contrib/libpcap/bpf/net/bpf_filter.c 10 conflicts created by this import. Use the following command to help the merge: cvs checkout -jTCPDUMP_ORG:yesterday -jTCPDUMP_ORG src/contrib/libpcap From owner-cvs-src@FreeBSD.ORG Tue Oct 16 02:07:35 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 41C2D16A468 for ; Tue, 16 Oct 2007 02:07:35 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.232]) by mx1.freebsd.org (Postfix) with ESMTP id A4DCF13C465 for ; Tue, 16 Oct 2007 02:07:34 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: by wx-out-0506.google.com with SMTP id i29so1572599wxd for ; Mon, 15 Oct 2007 19:07:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; bh=7X5Yo3GHCwYGRlYjJeWk2/ypd6pAsNrTCFk+4WnGctk=; b=braCOeQAUZJuY3s1DK6yPRoBNEeb0eqRhbF/C4NgoCfcecwnOforNzT8+ljqP01mI+4JEhStPFxD+SVx2W0xUuluXYf2VhhHlg//pIplRgFevRIgjpV7dDLhKzI/gzS16wE9zZl6xh0+Pph5udZ1qqcwSR1G5X2k/N5fseyS93Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; b=F6cnBumjQoCiqQbUC9s1yunG+J2HR+cQtsJs2OAEtCHVKwZXOR3Wi83hTs8tsJYFTnYpOzQkNjxEAZVsDzP3+TqDEK3qkUWNNZIVPNcU4L627b5jx0kchdZVHlcZ+i4B01wwzXNgNAvb1vR0BXg0pdcJhtRIXjQORsGbZCsLSEs= Received: by 10.90.118.8 with SMTP id q8mr9782239agc.1192500453456; Mon, 15 Oct 2007 19:07:33 -0700 (PDT) Received: by 10.90.78.10 with HTTP; Mon, 15 Oct 2007 19:07:33 -0700 (PDT) Message-ID: Date: Mon, 15 Oct 2007 22:07:33 -0400 From: "Constantine A. Murenin" To: "Sam Leffler" MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Cc: src-committers@freebsd.org, Alexander Leidinger , cvs-src@freebsd.org, cvs-all@freebsd.org, "Constantine A. Murenin" , Poul-Henning Kamp Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 02:07:35 -0000 On 14/10/2007, Sam Leffler wrote: > Poul-Henning Kamp wrote: > > In message <200710141045.l9EAjW4m058732@repoman.freebsd.org>, Alexander Leiding > > er writes: > > > > > >> Log: > >> Import OpenBSD's sysctl hardware sensors framework. > >> > > > > I would like to register a complaint about this commit. > > > > When this was discussed I objected that this entire pile of crap does > > not belong in the kernel. > > > > I still think this is a festering junkpile that does not belong in > > the kernel, and that his should be backed out, until a proper > > architectural solution has been found. > > > > Adding a new bogus type of device tree just because on cannot be > > bothered to do things right, is the road that leads to things like > > SYSV IPC and away from a sustainable architecture for an operating > > system which is here for the long term. > > > > Please back this out. > > > > I'd have to agree that these changes need more buy in and review. I > recall many folks voiced complaints when the work was submitted to p4. > There are basic design issues that need to be resolved such as whether > code that's been added to the kernel is needed (instead of doing > user-space drivers). Having kernel support is usually dependent on > whether it's infeasible to do the work in user space and/or using the > results within the kernel. I also took a quick glance at the 2 drivers > that were added and see multiple issues that indicate this code needs > more review (possible div-by-zero, lack of newbus integration, probing > i2c devices, etc). Dear Sam, I'd be happy to hear about the possible div-by-zero bugs in any of these drivers. If there are any such bugs, people in OpenBSD/NetBSD and DragonFly BSD would be happy to fix 'em, as all of these systems share the same code. Probing i2c devices is another topic entirely. It was never even slightly advertised to be part of this SoC project, and I'd be more than happy to see someone to work in that area. In fact, until this backout, I was planning to explore that area myself. Cheers, Constantine. > I was very happy to see this SoC project happen and I think users could > benefit from a common sensor framework but I'd like to see one that is a > better fit to freebsd. > > Sam From owner-cvs-src@FreeBSD.ORG Tue Oct 16 02:07:56 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4A2C716A503; Tue, 16 Oct 2007 02:07:56 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 342F213C455; Tue, 16 Oct 2007 02:07:56 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9G27uIg051775; Tue, 16 Oct 2007 02:07:56 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9G27u1x051774; Tue, 16 Oct 2007 02:07:56 GMT (envelope-from mlaier) Message-Id: <200710160207.l9G27u1x051774@repoman.freebsd.org> From: Max Laier Date: Tue, 16 Oct 2007 02:07:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/contrib/libpcap INSTALL gencode.c gencode.h grammar.y nametoaddr.c pcap-bpf.c pcap-int.h pcap.3 pcap.h pf.h scanner.l src/contrib/libpcap/lbl gnuc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 02:07:56 -0000 mlaier 2007-10-16 02:07:56 UTC FreeBSD src repository Modified files: contrib/libpcap gencode.c gencode.h grammar.y nametoaddr.c pcap-bpf.c pcap-int.h pcap.3 pcap.h scanner.l Removed files: contrib/libpcap INSTALL pf.h contrib/libpcap/lbl gnuc.h Log: Resolve merge conflicts Approved by: re (kensmith) Obtained from: tcpdump.org Revision Changes Path 1.2 +0 -268 src/contrib/libpcap/INSTALL (dead) 1.17 +800 -363 src/contrib/libpcap/gencode.c 1.10 +13 -7 src/contrib/libpcap/gencode.h 1.12 +64 -26 src/contrib/libpcap/grammar.y 1.2 +0 -43 src/contrib/libpcap/lbl/gnuc.h (dead) 1.13 +4 -4 src/contrib/libpcap/nametoaddr.c 1.4 +12 -1 src/contrib/libpcap/pcap-bpf.c 1.13 +30 -7 src/contrib/libpcap/pcap-int.h 1.16 +14 -8 src/contrib/libpcap/pcap.3 1.13 +17 -8 src/contrib/libpcap/pcap.h 1.2 +0 -77 src/contrib/libpcap/pf.h (dead) 1.14 +11 -7 src/contrib/libpcap/scanner.l From owner-cvs-src@FreeBSD.ORG Tue Oct 16 02:10:45 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 25D1916A418; Tue, 16 Oct 2007 02:10:45 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id ED58013C494; Tue, 16 Oct 2007 02:10:44 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9G2Ai1Y051911; Tue, 16 Oct 2007 02:10:44 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9G2AiUn051910; Tue, 16 Oct 2007 02:10:44 GMT (envelope-from mlaier) Message-Id: <200710160210.l9G2AiUn051910@repoman.freebsd.org> From: Max Laier Date: Tue, 16 Oct 2007 02:10:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libpcap Makefile config.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 02:10:45 -0000 mlaier 2007-10-16 02:10:44 UTC FreeBSD src repository Modified files: lib/libpcap Makefile config.h Log: Update for libpcap 0.9.8 import Revision Changes Path 1.40 +4 -1 src/lib/libpcap/Makefile 1.6 +24 -2 src/lib/libpcap/config.h From owner-cvs-src@FreeBSD.ORG Tue Oct 16 02:12:06 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9B2DD16A421; Tue, 16 Oct 2007 02:12:06 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6ECAB13C465; Tue, 16 Oct 2007 02:12:06 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9G2C6JD052188; Tue, 16 Oct 2007 02:12:06 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9G2C6sZ052187; Tue, 16 Oct 2007 02:12:06 GMT (envelope-from mlaier) Message-Id: <200710160212.l9G2C6sZ052187@repoman.freebsd.org> From: Max Laier Date: Tue, 16 Oct 2007 02:12:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/contrib/pf/pflogd pflogd.c src/usr.sbin/wpa l2_packet.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 02:12:06 -0000 mlaier 2007-10-16 02:12:06 UTC FreeBSD src repository Modified files: contrib/pf/pflogd pflogd.c usr.sbin/wpa l2_packet.c Log: Update for libpcap 0.9.8 Revision Changes Path 1.13 +3 -0 src/contrib/pf/pflogd/pflogd.c 1.5 +7 -6 src/usr.sbin/wpa/l2_packet.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 02:20:53 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 695AE16A419; Tue, 16 Oct 2007 02:20:53 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5507613C474; Tue, 16 Oct 2007 02:20:53 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9G2KrOE052450; Tue, 16 Oct 2007 02:20:53 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9G2KrW4052449; Tue, 16 Oct 2007 02:20:53 GMT (envelope-from mlaier) Message-Id: <200710160220.l9G2KrW4052449@repoman.freebsd.org> From: Max Laier Date: Tue, 16 Oct 2007 02:20:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: LBL Cc: Subject: cvs commit: src/contrib/tcpdump - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 02:20:53 -0000 mlaier 2007-10-16 02:20:52 UTC FreeBSD src repository src/contrib/tcpdump - Imported sources Update of /home/ncvs/src/contrib/tcpdump In directory repoman.freebsd.org:/tmp/cvs-serv52360 Log Message: Import of tcpdump v3.9.8 Status: Vendor Tag: LBL Release Tags: v3_9_8 U src/contrib/tcpdump/packetdat.awk U src/contrib/tcpdump/print-sunrpc.c U src/contrib/tcpdump/configure.in U src/contrib/tcpdump/ospf6.h U src/contrib/tcpdump/print-eap.c U src/contrib/tcpdump/print-mobility.c U src/contrib/tcpdump/print-ascii.c U src/contrib/tcpdump/decnet.h U src/contrib/tcpdump/print-wb.c U src/contrib/tcpdump/slip.h U src/contrib/tcpdump/print-icmp6.c U src/contrib/tcpdump/tcp.h U src/contrib/tcpdump/print-vjc.c U src/contrib/tcpdump/print-raw.c C src/contrib/tcpdump/print-ip6.c C src/contrib/tcpdump/addrtoname.c U src/contrib/tcpdump/machdep.c U src/contrib/tcpdump/config.sub U src/contrib/tcpdump/print-sip.c U src/contrib/tcpdump/udp.h U src/contrib/tcpdump/print-atalk.c U src/contrib/tcpdump/smb.h C src/contrib/tcpdump/print-llc.c U src/contrib/tcpdump/configure U src/contrib/tcpdump/print-ah.c U src/contrib/tcpdump/print-ap1394.c U src/contrib/tcpdump/ether.h U src/contrib/tcpdump/CHANGES U src/contrib/tcpdump/print-pgm.c U src/contrib/tcpdump/slcompress.h U src/contrib/tcpdump/print-zephyr.c U src/contrib/tcpdump/chdlc.h U src/contrib/tcpdump/ethertype.h C src/contrib/tcpdump/print-token.c U src/contrib/tcpdump/atmuni31.h U src/contrib/tcpdump/netdissect.h U src/contrib/tcpdump/print-ip6opts.c U src/contrib/tcpdump/appletalk.h U src/contrib/tcpdump/print-enc.c U src/contrib/tcpdump/ip.h U src/contrib/tcpdump/print-sll.c U src/contrib/tcpdump/print-cdp.c U src/contrib/tcpdump/vfprintf.c U src/contrib/tcpdump/CREDITS U src/contrib/tcpdump/cpack.h U src/contrib/tcpdump/telnet.h U src/contrib/tcpdump/bootp.h N src/contrib/tcpdump/af.c U src/contrib/tcpdump/nlpid.c U src/contrib/tcpdump/isakmp.h U src/contrib/tcpdump/oui.c U src/contrib/tcpdump/gmt2local.h U src/contrib/tcpdump/print-rip.c U src/contrib/tcpdump/pcap_dump_ftell.c C src/contrib/tcpdump/print-ppp.c U src/contrib/tcpdump/PLATFORMS U src/contrib/tcpdump/decode_prefix.h U src/contrib/tcpdump/print-egp.c U src/contrib/tcpdump/config.h.in U src/contrib/tcpdump/gmpls.h C src/contrib/tcpdump/print-ip.c U src/contrib/tcpdump/l2vpn.h U src/contrib/tcpdump/ntp.h U src/contrib/tcpdump/print-bgp.c U src/contrib/tcpdump/print-cnfp.c C src/contrib/tcpdump/ieee802_11_radio.h U src/contrib/tcpdump/smbutil.c U src/contrib/tcpdump/print-netbios.c U src/contrib/tcpdump/sctpConstants.h U src/contrib/tcpdump/ipx.h U src/contrib/tcpdump/print-vrrp.c U src/contrib/tcpdump/rpc_msg.h U src/contrib/tcpdump/atime.awk U src/contrib/tcpdump/ah.h C src/contrib/tcpdump/tcpdump.1 U src/contrib/tcpdump/print-juniper.c U src/contrib/tcpdump/atm.h U src/contrib/tcpdump/print-dccp.c U src/contrib/tcpdump/print-ldp.c U src/contrib/tcpdump/print-lane.c U src/contrib/tcpdump/print-rsvp.c U src/contrib/tcpdump/acconfig.h U src/contrib/tcpdump/print-arcnet.c U src/contrib/tcpdump/dccp.h U src/contrib/tcpdump/setsignal.h U src/contrib/tcpdump/print-pflog.c U src/contrib/tcpdump/lane.h C src/contrib/tcpdump/print-fddi.c U src/contrib/tcpdump/sctpHeader.h U src/contrib/tcpdump/print-esp.c U src/contrib/tcpdump/print-lspping.c U src/contrib/tcpdump/print-aodv.c U src/contrib/tcpdump/print-pptp.c U src/contrib/tcpdump/ospf.h U src/contrib/tcpdump/print-mobile.c U src/contrib/tcpdump/fddi.h U src/contrib/tcpdump/ipproto.h U src/contrib/tcpdump/print-igmp.c U src/contrib/tcpdump/nfs.h U src/contrib/tcpdump/timed.h U src/contrib/tcpdump/print-rt6.c U src/contrib/tcpdump/print-bfd.c U src/contrib/tcpdump/print-symantec.c C src/contrib/tcpdump/parsenfsfh.c U src/contrib/tcpdump/print-ospf.c U src/contrib/tcpdump/route6d.h U src/contrib/tcpdump/aodv.h U src/contrib/tcpdump/send-ack.awk U src/contrib/tcpdump/print-radius.c U src/contrib/tcpdump/igrp.h C src/contrib/tcpdump/print-isoclns.c C src/contrib/tcpdump/print-pim.c C src/contrib/tcpdump/print-null.c U src/contrib/tcpdump/extract.h U src/contrib/tcpdump/ipfc.h U src/contrib/tcpdump/.cvsignore U src/contrib/tcpdump/cpack.c N src/contrib/tcpdump/af.h U src/contrib/tcpdump/nlpid.h U src/contrib/tcpdump/print-ipx.c U src/contrib/tcpdump/print-igrp.c U src/contrib/tcpdump/print-pppoe.c U src/contrib/tcpdump/print-decnet.c C src/contrib/tcpdump/tcpdump.c U src/contrib/tcpdump/print-arp.c N src/contrib/tcpdump/print-olsr.c U src/contrib/tcpdump/print-ipfc.c U src/contrib/tcpdump/oui.h U src/contrib/tcpdump/ipsec_doi.h C src/contrib/tcpdump/print-fr.c U src/contrib/tcpdump/bgp.h U src/contrib/tcpdump/print-ntp.c U src/contrib/tcpdump/mpls.h U src/contrib/tcpdump/print-tftp.c U src/contrib/tcpdump/print-sl.c C src/contrib/tcpdump/interface.h U src/contrib/tcpdump/README U src/contrib/tcpdump/print-lwres.c U src/contrib/tcpdump/mkdep U src/contrib/tcpdump/print-lmp.c U src/contrib/tcpdump/ppp.h U src/contrib/tcpdump/stime.awk C src/contrib/tcpdump/print-icmp.c U src/contrib/tcpdump/print-mpls.c U src/contrib/tcpdump/print-sctp.c N src/contrib/tcpdump/tftp.h U src/contrib/tcpdump/rpc_auth.h U src/contrib/tcpdump/bpf_dump.c U src/contrib/tcpdump/Makefile-devel-adds U src/contrib/tcpdump/print-rx.c U src/contrib/tcpdump/print-hsrp.c U src/contrib/tcpdump/print-beep.c C src/contrib/tcpdump/print-nfs.c U src/contrib/tcpdump/print-l2tp.c U src/contrib/tcpdump/addrtoname.h U src/contrib/tcpdump/netbios.h U src/contrib/tcpdump/machdep.h U src/contrib/tcpdump/esp.h U src/contrib/tcpdump/print-syslog.c U src/contrib/tcpdump/install-sh U src/contrib/tcpdump/l2tp.h U src/contrib/tcpdump/nfsfh.h U src/contrib/tcpdump/LICENSE U src/contrib/tcpdump/print-cip.c U src/contrib/tcpdump/print-ripng.c U src/contrib/tcpdump/print-timed.c C src/contrib/tcpdump/print-domain.c C src/contrib/tcpdump/aclocal.m4 U src/contrib/tcpdump/print-dhcp6.c U src/contrib/tcpdump/print-telnet.c C src/contrib/tcpdump/print-atm.c U src/contrib/tcpdump/print-smb.c U src/contrib/tcpdump/print-isakmp.c U src/contrib/tcpdump/llc.h U src/contrib/tcpdump/print-gre.c C src/contrib/tcpdump/print-udp.c U src/contrib/tcpdump/nameser.h U src/contrib/tcpdump/print-krb.c U src/contrib/tcpdump/mib.h U src/contrib/tcpdump/ipproto.c U src/contrib/tcpdump/print-ospf6.c U src/contrib/tcpdump/print-snmp.c U src/contrib/tcpdump/INSTALL U src/contrib/tcpdump/ip6.h U src/contrib/tcpdump/print-tcp.c U src/contrib/tcpdump/Readme.Win32 U src/contrib/tcpdump/print-msdp.c U src/contrib/tcpdump/print-eigrp.c U src/contrib/tcpdump/print-dvmrp.c U src/contrib/tcpdump/util.c U src/contrib/tcpdump/print-sunatm.c U src/contrib/tcpdump/print-stp.c U src/contrib/tcpdump/VERSION U src/contrib/tcpdump/oakley.h U src/contrib/tcpdump/icmp6.h U src/contrib/tcpdump/config.guess U src/contrib/tcpdump/pmap_prot.h U src/contrib/tcpdump/setsignal.c U src/contrib/tcpdump/rx.h U src/contrib/tcpdump/makemib U src/contrib/tcpdump/token.h U src/contrib/tcpdump/strcasecmp.c U src/contrib/tcpdump/print-chdlc.c U src/contrib/tcpdump/print-frag6.c U src/contrib/tcpdump/FILES C src/contrib/tcpdump/ieee802_11.h U src/contrib/tcpdump/TODO C src/contrib/tcpdump/print-802_11.c U src/contrib/tcpdump/arcnet.h U src/contrib/tcpdump/sll.h C src/contrib/tcpdump/print-ether.c C src/contrib/tcpdump/tcpdump-stdinc.h U src/contrib/tcpdump/Makefile.in U src/contrib/tcpdump/gmt2local.c U src/contrib/tcpdump/enc.h C src/contrib/tcpdump/print-bootp.c U src/contrib/tcpdump/print-slow.c U src/contrib/tcpdump/print-ipcomp.c U src/contrib/tcpdump/pcap-missing.h U src/contrib/tcpdump/gmpls.c U src/contrib/tcpdump/l2vpn.c U src/contrib/tcpdump/lbl/os-osf4.h U src/contrib/tcpdump/lbl/os-solaris2.h U src/contrib/tcpdump/lbl/os-sunos4.h U src/contrib/tcpdump/lbl/os-ultrix4.h U src/contrib/tcpdump/missing/strlcpy.c U src/contrib/tcpdump/missing/snprintf.c U src/contrib/tcpdump/missing/bittypes.h U src/contrib/tcpdump/missing/strdup.c U src/contrib/tcpdump/missing/addrsize.h U src/contrib/tcpdump/missing/addrinfo.h U src/contrib/tcpdump/missing/inet_pton.c U src/contrib/tcpdump/missing/sockstorage.h U src/contrib/tcpdump/missing/inet_aton.c U src/contrib/tcpdump/missing/datalinks.c U src/contrib/tcpdump/missing/dlnames.c U src/contrib/tcpdump/missing/resolv6.h U src/contrib/tcpdump/missing/resolv_ext.h U src/contrib/tcpdump/missing/getaddrinfo.c U src/contrib/tcpdump/missing/inet_ntop.c U src/contrib/tcpdump/missing/strsep.c U src/contrib/tcpdump/missing/getnameinfo.c U src/contrib/tcpdump/missing/strlcat.c U src/contrib/tcpdump/tests/isakmp1.sh U src/contrib/tcpdump/tests/lmp.sh U src/contrib/tcpdump/tests/esp4.sh U src/contrib/tcpdump/tests/print-A.out U src/contrib/tcpdump/tests/esp3.gdbinit U src/contrib/tcpdump/tests/esp5.out U src/contrib/tcpdump/tests/eapon1.out U src/contrib/tcpdump/tests/isakmp4500.puu U src/contrib/tcpdump/tests/bgp_vpn_attrset.out U src/contrib/tcpdump/tests/esp2.out U src/contrib/tcpdump/tests/espudp1.sh U src/contrib/tcpdump/tests/esp5.sh U src/contrib/tcpdump/tests/isakmp3.out U src/contrib/tcpdump/tests/isakmp2.sh U src/contrib/tcpdump/tests/isakmp4.out U src/contrib/tcpdump/tests/eapon1.gdbinit U src/contrib/tcpdump/tests/mpls-ldp-hello.puu U src/contrib/tcpdump/tests/eapon1.sh U src/contrib/tcpdump/tests/isakmp3.sh U src/contrib/tcpdump/tests/print-AA.out U src/contrib/tcpdump/tests/.cvsignore U src/contrib/tcpdump/tests/lmp.out U src/contrib/tcpdump/tests/alltests.sh U src/contrib/tcpdump/tests/eapon2.puu U src/contrib/tcpdump/tests/bgp_vpn_attrset.sh U src/contrib/tcpdump/tests/esp2.sh U src/contrib/tcpdump/tests/isakmp-pointer-loop.puu U src/contrib/tcpdump/tests/esp3.sh U src/contrib/tcpdump/tests/ospf-gmpls.out U src/contrib/tcpdump/tests/espudp1.out U src/contrib/tcpdump/tests/print-x.out U src/contrib/tcpdump/tests/isakmp4.sh U src/contrib/tcpdump/tests/02-sunrise-sunset-esp.puu U src/contrib/tcpdump/tests/esp1.sh U src/contrib/tcpdump/tests/esp0.sh U src/contrib/tcpdump/tests/isakmp-identification-segfault.puu U src/contrib/tcpdump/tests/esp2.gdbinit U src/contrib/tcpdump/tests/isakmp2.out U src/contrib/tcpdump/tests/mpls-ldp-hello.out U src/contrib/tcpdump/tests/mpls-ldp-hello.sh U src/contrib/tcpdump/tests/print-capXX.out U src/contrib/tcpdump/tests/ospf-gmpls.sh U src/contrib/tcpdump/tests/isakmp1.out U src/contrib/tcpdump/tests/eapon1.puu U src/contrib/tcpdump/tests/lmp.puu U src/contrib/tcpdump/tests/esp0.out U src/contrib/tcpdump/tests/print-flags.sh U src/contrib/tcpdump/tests/print-capX.out U src/contrib/tcpdump/tests/esp-secrets.txt U src/contrib/tcpdump/tests/08-sunrise-sunset-aes.puu U src/contrib/tcpdump/tests/08-sunrise-sunset-esp2.puu U src/contrib/tcpdump/tests/esp4.gdbinit U src/contrib/tcpdump/tests/espudp1.puu U src/contrib/tcpdump/tests/esp1.gdbinit U src/contrib/tcpdump/tests/esp5.gdbinit U src/contrib/tcpdump/tests/ospf-gmpls.puu U src/contrib/tcpdump/tests/print-xx.out U src/contrib/tcpdump/tests/print-flags.puu U src/contrib/tcpdump/tests/esp1.out U src/contrib/tcpdump/tests/isakmp-delete-segfault.puu 27 conflicts created by this import. Use the following command to help the merge: cvs checkout -jLBL:yesterday -jLBL src/contrib/tcpdump From owner-cvs-src@FreeBSD.ORG Tue Oct 16 02:31:51 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 037C316A418; Tue, 16 Oct 2007 02:31:51 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E300513C448; Tue, 16 Oct 2007 02:31:50 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9G2VoB4053251; Tue, 16 Oct 2007 02:31:50 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9G2Vne8053250; Tue, 16 Oct 2007 02:31:49 GMT (envelope-from mlaier) Message-Id: <200710160231.l9G2Vne8053250@repoman.freebsd.org> From: Max Laier Date: Tue, 16 Oct 2007 02:31:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/contrib/tcpdump addrtoname.c ieee802_11.h ieee802_11_radio.h interface.h parsenfsfh.c pf.h print-802_11.c print-atm.c print-bootp.c print-domain.c print-ether.c print-fddi.c print-fr.c print-icmp.c print-ip.c print-ip6.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 02:31:51 -0000 mlaier 2007-10-16 02:31:48 UTC FreeBSD src repository Modified files: contrib/tcpdump addrtoname.c ieee802_11.h ieee802_11_radio.h interface.h parsenfsfh.c print-802_11.c print-atm.c print-bootp.c print-domain.c print-ether.c print-fddi.c print-fr.c print-icmp.c print-ip.c print-ip6.c print-isoclns.c print-llc.c print-nfs.c print-null.c print-pim.c print-ppp.c print-token.c print-udp.c tcpdump-stdinc.h tcpdump.1 tcpdump.c Removed files: contrib/tcpdump pf.h Log: Resolve merge conflicts Approved by: re (kensmith) Obtained from: tcpdump.org Revision Changes Path 1.16 +6 -2 src/contrib/tcpdump/addrtoname.c 1.3 +44 -12 src/contrib/tcpdump/ieee802_11.h 1.3 +9 -5 src/contrib/tcpdump/ieee802_11_radio.h 1.13 +8 -3 src/contrib/tcpdump/interface.h 1.10 +28 -2 src/contrib/tcpdump/parsenfsfh.c 1.2 +0 -77 src/contrib/tcpdump/pf.h (dead) 1.3 +188 -110 src/contrib/tcpdump/print-802_11.c 1.13 +22 -17 src/contrib/tcpdump/print-atm.c 1.12 +286 -119 src/contrib/tcpdump/print-bootp.c 1.13 +50 -16 src/contrib/tcpdump/print-domain.c 1.18 +11 -9 src/contrib/tcpdump/print-ether.c 1.12 +1 -2 src/contrib/tcpdump/print-fddi.c 1.8 +25 -1 src/contrib/tcpdump/print-fr.c 1.12 +86 -30 src/contrib/tcpdump/print-icmp.c 1.15 +40 -31 src/contrib/tcpdump/print-ip.c 1.9 +3 -3 src/contrib/tcpdump/print-ip6.c 1.17 +35 -17 src/contrib/tcpdump/print-isoclns.c 1.13 +34 -15 src/contrib/tcpdump/print-llc.c 1.13 +82 -8 src/contrib/tcpdump/print-nfs.c 1.13 +9 -36 src/contrib/tcpdump/print-null.c 1.10 +40 -17 src/contrib/tcpdump/print-pim.c 1.17 +74 -7 src/contrib/tcpdump/print-ppp.c 1.9 +1 -2 src/contrib/tcpdump/print-token.c 1.10 +3 -1 src/contrib/tcpdump/print-udp.c 1.5 +9 -2 src/contrib/tcpdump/tcpdump-stdinc.h 1.18 +31 -11 src/contrib/tcpdump/tcpdump.1 1.12 +5 -2 src/contrib/tcpdump/tcpdump.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 02:32:44 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CA54E16A420; Tue, 16 Oct 2007 02:32:44 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9E7A513C46A; Tue, 16 Oct 2007 02:32:44 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9G2Wi5H053293; Tue, 16 Oct 2007 02:32:44 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9G2WiEE053292; Tue, 16 Oct 2007 02:32:44 GMT (envelope-from mlaier) Message-Id: <200710160232.l9G2WiEE053292@repoman.freebsd.org> From: Max Laier Date: Tue, 16 Oct 2007 02:32:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/tcpdump/tcpdump Makefile config.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 02:32:44 -0000 mlaier 2007-10-16 02:32:44 UTC FreeBSD src repository Modified files: usr.sbin/tcpdump/tcpdump Makefile config.h Log: Update for tcpdump 3.9.8 Revision Changes Path 1.46 +33 -26 src/usr.sbin/tcpdump/tcpdump/Makefile 1.8 +43 -19 src/usr.sbin/tcpdump/tcpdump/config.h From owner-cvs-src@FreeBSD.ORG Tue Oct 16 02:39:17 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6346216A41B; Tue, 16 Oct 2007 02:39:17 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3AF1D13C45A; Tue, 16 Oct 2007 02:39:17 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9G2dHTr053510; Tue, 16 Oct 2007 02:39:17 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9G2dHxk053509; Tue, 16 Oct 2007 02:39:17 GMT (envelope-from mlaier) Message-Id: <200710160239.l9G2dHxk053509@repoman.freebsd.org> From: Max Laier Date: Tue, 16 Oct 2007 02:39:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys param.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 02:39:17 -0000 mlaier 2007-10-16 02:39:16 UTC FreeBSD src repository Modified files: sys/sys param.h Log: Bump version for libpcap and tcpdump imports MFC after: 3 days Revision Changes Path 1.310 +1 -1 src/sys/sys/param.h From owner-cvs-src@FreeBSD.ORG Tue Oct 16 02:49:41 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 848A316A418; Tue, 16 Oct 2007 02:49:41 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5C4F913C44B; Tue, 16 Oct 2007 02:49:41 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9G2nfZN054274; Tue, 16 Oct 2007 02:49:41 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9G2nfGc054273; Tue, 16 Oct 2007 02:49:41 GMT (envelope-from marcel) Message-Id: <200710160249.l9G2nfGc054273@repoman.freebsd.org> From: Marcel Moolenaar Date: Tue, 16 Oct 2007 02:49:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ia64/disasm disasm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 02:49:41 -0000 marcel 2007-10-16 02:49:40 UTC FreeBSD src repository Modified files: sys/ia64/disasm disasm.h Log: Fix disassembly of the invala, itc, itr and hint instructions by fixing the opcode ordering. MFC after: 1 week Revision Changes Path 1.6 +1 -1 src/sys/ia64/disasm/disasm.h From owner-cvs-src@FreeBSD.ORG Tue Oct 16 02:57:50 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 34C9716A418 for ; Tue, 16 Oct 2007 02:57:50 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.231]) by mx1.freebsd.org (Postfix) with ESMTP id C81BA13C467 for ; Tue, 16 Oct 2007 02:57:49 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: by wr-out-0506.google.com with SMTP id 70so895858wra for ; Mon, 15 Oct 2007 19:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; bh=4ox01uisCJhzkf0Qc9tRsOtQswlLEkSIyJWPfPPQ9Ds=; b=LjSQdR7c74yTw5lST2v0VNX5eF77MMebPn/xpPEiJSJFeALiItAP6q45bkAg8vuTElKrB9OfJKU1D7vKj70Mc2daqdiFEtpVZhHismYZMEeQCB4Wu0jQMkvhL/WCW4rTNP2iCijoPHNItIpx0kkFG3Ibka9BKXzg8w7jtieQXds= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; b=Cs833/Gl8qp1L52qowgVoYnp+CznP6q+Z4uXm/m1I+f2kGgB5SNO6mBJpEZZr+ih/gNT4gF+xoJEyDjZp+L2U90FqPV2mft0A1f9OF0FTNyBYTvsNNRLHQMfUhP+pYQQpkY+mrK9R5oT4pHbZlqzizTkKa8qWSFOkSJ5dQealtw= Received: by 10.90.89.5 with SMTP id m5mr9849838agb.1192503468835; Mon, 15 Oct 2007 19:57:48 -0700 (PDT) Received: by 10.90.78.10 with HTTP; Mon, 15 Oct 2007 19:57:48 -0700 (PDT) Message-ID: Date: Mon, 15 Oct 2007 22:57:48 -0400 From: "Constantine A. Murenin" To: "John Baldwin" MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Cc: Scott Long , src-committers@freebsd.org, Alexander Leidinger , cvs-src@freebsd.org, cvs-all@freebsd.org, "Constantine A. Murenin" , Poul-Henning Kamp , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 02:57:50 -0000 On 15/10/2007, John Baldwin wrote: > On Monday 15 October 2007 09:43:21 am Alexander Leidinger wrote: > > Quoting Scott Long (from Mon, 15 Oct 2007 > 01:47:59 -0600): > > > > > Alexander Leidinger wrote: > > >> Quoting Poul-Henning Kamp (from Sun, 14 Oct > > >> 2007 17:54:21 +0000): > > > > >>> listen to the various mumblings about putting RAID-controller status > > >>> under sensors framework. > > >> > > >> What's wrong with this? Currently each RAID driver has to come up > > >> with his own way of displaying the RAID status. It's like saying > > >> that each network driver has to implement/display the stuff you can > > >> see with ifconfig in its own way, instead of using the proper > > >> network driver interface for this. > > >> > > > > > > For the love of God, please don't use RAID as an example to support your > > > argument for the sensord framework. Representing RAID state is several > > > orders of magnitude more involved than representing network state. > > > There are also landmines in the OpenBSD bits of RAID support that are > > > best left out of FreeBSD, unless you like alienating vendors and risking > > > legal action. Leave it alone. Please. I don't care what you do with > > > lmsensors or cpu power settings or whatever. Leave RAID out of it. > > > > Talking about RAID status is not talking about alienating vendors. I > > don't talk about alienating vendors and I don't intent to do. You may > > not be able to display a full blown RAID status with the sensors > > framework, but it allows for a generic "wors/works not" or > > "OK/degraded" status display in drivers we have the source for. This > > is enough for status monitoring (e.g., nagios). > > As I mentioned in the thread on arch@ where people brought up objections that > were apparently completely ignored, this is far from useful for RAID > monitoring. For example, if my RAID is down, which disk do I need to > replace? Again, all this was covered earlier and (apparently) ignored. > Also, what strikes me as odd is that I didn't see this patch posted again for > review this time around before it was committed. This has been addressed back in July. You'd use bioctl to see which exact disc needs to be replaced. Sensorsd is intended for an initial alert about something being wrong. C. From owner-cvs-src@FreeBSD.ORG Tue Oct 16 02:59:04 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3685116A417; Tue, 16 Oct 2007 02:59:04 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0FAC513C465; Tue, 16 Oct 2007 02:59:04 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9G2x3RI054869; Tue, 16 Oct 2007 02:59:03 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9G2x3U1054868; Tue, 16 Oct 2007 02:59:03 GMT (envelope-from marcel) Message-Id: <200710160259.l9G2x3U1054868@repoman.freebsd.org> From: Marcel Moolenaar Date: Tue, 16 Oct 2007 02:59:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ia64/ia64 db_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 02:59:04 -0000 marcel 2007-10-16 02:59:03 UTC FreeBSD src repository Modified files: sys/ia64/ia64 db_machdep.c Log: Print instruction stops to improve analysis of dependency violations. MFC after: 1 week Revision Changes Path 1.5 +2 -0 src/sys/ia64/ia64/db_machdep.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 03:07:56 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ED5D916A420; Tue, 16 Oct 2007 03:07:56 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C754813C447; Tue, 16 Oct 2007 03:07:56 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9G37usX056733; Tue, 16 Oct 2007 03:07:56 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9G37uWi056732; Tue, 16 Oct 2007 03:07:56 GMT (envelope-from marcel) Message-Id: <200710160307.l9G37uWi056732@repoman.freebsd.org> From: Marcel Moolenaar Date: Tue, 16 Oct 2007 03:07:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ia64/ia64 support.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 03:07:57 -0000 marcel 2007-10-16 03:07:56 UTC FreeBSD src repository Modified files: sys/ia64/ia64 support.S Log: The flushrs instruction must be the first in an instruction group. GNU as(1) already made sure of that, but it's better to actually have the code right. MFC after: 1 week Revision Changes Path 1.28 +1 -0 src/sys/ia64/ia64/support.S From owner-cvs-src@FreeBSD.ORG Tue Oct 16 03:20:33 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6AF6D16A418; Tue, 16 Oct 2007 03:20:33 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 4635613C459; Tue, 16 Oct 2007 03:20:33 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9G3KX3k057443; Tue, 16 Oct 2007 03:20:33 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9G3KXMG057442; Tue, 16 Oct 2007 03:20:33 GMT (envelope-from marcel) Message-Id: <200710160320.l9G3KXMG057442@repoman.freebsd.org> From: Marcel Moolenaar Date: Tue, 16 Oct 2007 03:20:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ia64/ia64 exception.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 03:20:33 -0000 marcel 2007-10-16 03:20:32 UTC FreeBSD src repository Modified files: sys/ia64/ia64 exception.S Log: Set PTE_ACCESSED in the PTE and before inserting it in the VHPT. This avoids back-to-back faults for all TLB misses. This can be improved further in the future by also setting PTE_DIRTY for TLB misses for write accesses. MFC after: 1 week Revision Changes Path 1.63 +12 -2 src/sys/ia64/ia64/exception.S From owner-cvs-src@FreeBSD.ORG Tue Oct 16 03:26:32 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3993416A421; Tue, 16 Oct 2007 03:26:32 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 148E813C45B; Tue, 16 Oct 2007 03:26:32 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9G3QVUI057896; Tue, 16 Oct 2007 03:26:31 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9G3QVPN057895; Tue, 16 Oct 2007 03:26:31 GMT (envelope-from mlaier) Message-Id: <200710160326.l9G3QVPN057895@repoman.freebsd.org> From: Max Laier Date: Tue, 16 Oct 2007 03:26:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin Makefile src/usr.sbin/sensorsd sensorsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 03:26:32 -0000 mlaier 2007-10-16 03:26:31 UTC FreeBSD src repository Modified files: usr.sbin Makefile Removed files: usr.sbin/sensorsd sensorsd.c Log: Some left over from the sensors framework. Revision Changes Path 1.378 +0 -1 src/usr.sbin/Makefile 1.2 +0 -644 src/usr.sbin/sensorsd/sensorsd.c (dead) From owner-cvs-src@FreeBSD.ORG Tue Oct 16 03:32:26 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8607316A41A for ; Tue, 16 Oct 2007 03:32:26 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.225]) by mx1.freebsd.org (Postfix) with ESMTP id 259C213C461 for ; Tue, 16 Oct 2007 03:32:25 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: by wx-out-0506.google.com with SMTP id i29so1588203wxd for ; Mon, 15 Oct 2007 20:32:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; bh=8h/DkOROPFVA2NO6EiAyhiWDFlEwtgoOWbC7V/FIR5E=; b=npCfUv70oMZ27dVxk2ej1LFvK1RJNncU6yXeeyqwSmxgoeTvTa9Z7EDSt592OwCEdrOb4xe0TSNTw7gW3GZfGh00rSJnyGAE0ma/Azl/Zk3nfNed0XQXWI2tDvnPL9c0gcjMWh7tl/M6ULn+pQgruFP4csoPBgQXOlpu24QC1Qs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; b=ctcpHDx46Pu/ZsuMfommjb/5NHF5og27Zlimkye4KXHvLYHeEzzUjtYjU7AxBzkrxkV35QTjWsxGNWbwNFmfukv2/2+KNDm6NK/2blHLkAvlzpPcTVVhUxKWnOJijXv/OGHIkLqkCONPi8GTO7G+YAl9VMKwgQiJ5TfRsEcySDs= Received: by 10.90.34.9 with SMTP id h9mr9854139agh.1192505545213; Mon, 15 Oct 2007 20:32:25 -0700 (PDT) Received: by 10.90.78.10 with HTTP; Mon, 15 Oct 2007 20:32:25 -0700 (PDT) Message-ID: Date: Mon, 15 Oct 2007 23:32:25 -0400 From: "Constantine A. Murenin" To: "Alexander Leidinger" MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Cc: Scott Long , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, "Constantine A. Murenin" , Poul-Henning Kamp , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 03:32:26 -0000 On 15/10/2007, Alexander Leidinger wrote: > Quoting Scott Long (from Mon, 15 Oct 2007 01:47:59 -0600): > > > Alexander Leidinger wrote: > >> Quoting Poul-Henning Kamp (from Sun, 14 Oct > >> 2007 17:54:21 +0000): > > >>> listen to the various mumblings about putting RAID-controller status > >>> under sensors framework. > >> > >> What's wrong with this? Currently each RAID driver has to come up > >> with his own way of displaying the RAID status. It's like saying > >> that each network driver has to implement/display the stuff you can > >> see with ifconfig in its own way, instead of using the proper > >> network driver interface for this. > >> > > > > For the love of God, please don't use RAID as an example to support your > > argument for the sensord framework. Representing RAID state is several > > orders of magnitude more involved than representing network state. > > There are also landmines in the OpenBSD bits of RAID support that are > > best left out of FreeBSD, unless you like alienating vendors and risking > > legal action. Leave it alone. Please. I don't care what you do with > > lmsensors or cpu power settings or whatever. Leave RAID out of it. > > Talking about RAID status is not talking about alienating vendors. I > don't talk about alienating vendors and I don't intent to do. You may > not be able to display a full blown RAID status with the sensors > framework, but it allows for a generic "wors/works not" or > "OK/degraded" status display in drivers we have the source for. This > is enough for status monitoring (e.g., nagios). I don't know if you > talk about the OpenBSD bio framework or about some reverse engineered > RAID drivers in OpenBSD (or bad mails from them to some vendors). From > an user point of view the bio framework (as in "a generic interface > for the sysadmin to do RAID stuff", and not as in "the concrete > implementation in OpenBSD") is something you want to have. I don't > think that it is a bad idea to port it (and improve it). OpenBSD has > some RAID controllers converted to it and the framework already > represents an usable interface for a lot of cases. I don't know if it > needs improvement or not, I don't know if it can cover all current > feature needs for such a framework for all possible RAID systems (most > probably not), but it would be an improvement for vendors which want > to write support for their RAID hardware as they don't have to come up > with their own BSD code to manage those parts. And we could improve > "our bio framwork" (if we had/get one) based upon vendor feedback (we > already improved our network interfaces upon vendor feedback, haven't > we?). In case you talk about porting some "alienated" raid drivers > from OpenBSD... I agree that it is not a good idea to kick a vendor in > the ass (a vendor which provides some kind of FreeBSD support... if > there's a driver for raid hardware for which the vendor doesn't > provide any support for a driver for FreeBSD at all, it depends upon > the specific driver code from OpenBSD if it is a good idea to port it > or not). > > So in short: having a generic framework would be beneficial for > vendors. Kicking vendors in the ass is not my intention. Feel free to > document pitfalls in the RAID stuff in OpenBSD, so that nobody in > FreeBSd-land makes the same mistakes (but is able to get good parts if > the idea of an unified interface into FreeBSD). > > Sorry for not taking the time to write a more readable mail. > > Bye, > Alexander. BTW, the RAID status part of the sensors framework was already ported into NetBSD's sister framework, envsys(4). So this approach to hardware monitoring is no longer unique to OpenBSD. C. From owner-cvs-src@FreeBSD.ORG Tue Oct 16 04:05:18 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9912216A418; Tue, 16 Oct 2007 04:05:18 +0000 (UTC) (envelope-from skip@menantico.com) Received: from vms044pub.verizon.net (vms044pub.verizon.net [206.46.252.44]) by mx1.freebsd.org (Postfix) with ESMTP id 7B2CB13C448; Tue, 16 Oct 2007 04:05:18 +0000 (UTC) (envelope-from skip@menantico.com) Received: from mx.menantico.com ([71.188.11.206]) by vms044.mailsrvcs.net (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPA id <0JPZ00471IRQU640@vms044.mailsrvcs.net>; Mon, 15 Oct 2007 22:23:51 -0500 (CDT) Date: Mon, 15 Oct 2007 23:25:17 -0400 From: Skip Ford In-reply-to: <4701F9DE.7090503@freebsd.org> To: Michael Bushkov Message-id: <20071016032517.GF51310@menantico.com> MIME-version: 1.0 Content-type: multipart/mixed; boundary=4Epv4kl9IRBfg3rk Content-disposition: inline References: <200709271230.l8RCUCWN003489@repoman.freebsd.org> <861wckqj81.fsf@ds4.des.no> <4701F9DE.7090503@freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.sbin/nscd/agents Makefile.inc group.c group.h passwd.c passwd.h services.c services.h src/usr.sbin/nscd Makefile agent.c agent.h cachelib.c cachelib.h cacheplcs.c cacheplcs.h config.c config.h debug.c hashtable.h log.c log.h mp_rs_query. ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 04:05:18 -0000 --4Epv4kl9IRBfg3rk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Michael Bushkov wrote: > > All cached references are currently eliminated cached(8) is still referenced in src.conf(5) in HEAD and RELENG_7. -- Skip --4Epv4kl9IRBfg3rk Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="src.conf.5.diff" Index: share/man/man5/src.conf.5 =================================================================== RCS file: /os/cvs/ncvs/src/share/man/man5/src.conf.5,v retrieving revision 1.18 diff -u -r1.18 src.conf.5 --- share/man/man5/src.conf.5 10 Oct 2007 06:04:43 -0000 1.18 +++ share/man/man5/src.conf.5 16 Oct 2007 01:28:49 -0000 @@ -457,7 +457,7 @@ .Pa nsswitch subsystem. The generic caching daemon, -.Xr cached 8 , +.Xr nscd 8 , will not be built either if this option is set. .It Va WITHOUT_OBJC .\" from FreeBSD: src/tools/build/options/WITHOUT_OBJC,v 1.1 2006/03/21 07:50:50 ru Exp --4Epv4kl9IRBfg3rk-- From owner-cvs-src@FreeBSD.ORG Tue Oct 16 07:36:04 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7D13616A421; Tue, 16 Oct 2007 07:36:04 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 691ED13C461; Tue, 16 Oct 2007 07:36:04 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9G7a3KU087967; Tue, 16 Oct 2007 07:36:03 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9G7a3oI087966; Tue, 16 Oct 2007 07:36:03 GMT (envelope-from davidxu) Message-Id: <200710160736.l9G7a3oI087966@repoman.freebsd.org> From: David Xu Date: Tue, 16 Oct 2007 07:36:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libthr/thread thr_pspinlock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 07:36:04 -0000 davidxu 2007-10-16 07:36:02 UTC FreeBSD src repository Modified files: lib/libthr/thread thr_pspinlock.c Log: Reverse the logic of UP and SMP. Submitted by: jasone Revision Changes Path 1.6 +1 -1 src/lib/libthr/thread/thr_pspinlock.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 07:46:16 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 54A2B16A417; Tue, 16 Oct 2007 07:46:16 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 41BD013C4B5; Tue, 16 Oct 2007 07:46:16 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9G7kGxX088506; Tue, 16 Oct 2007 07:46:16 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9G7kFWA088505; Tue, 16 Oct 2007 07:46:15 GMT (envelope-from davidxu) Message-Id: <200710160746.l9G7kFWA088505@repoman.freebsd.org> From: David Xu Date: Tue, 16 Oct 2007 07:46:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libthr/thread thr_once.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 07:46:16 -0000 davidxu 2007-10-16 07:46:15 UTC FreeBSD src repository Modified files: lib/libthr/thread thr_once.c Log: Use macro THR_CLEANUP_PUSH/POP, they are cheaper than pthread_cleanup_push/pop. Revision Changes Path 1.6 +4 -2 src/lib/libthr/thread/thr_once.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 08:54:16 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 901F516A419 for ; Tue, 16 Oct 2007 08:54:16 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247]) by mx1.freebsd.org (Postfix) with ESMTP id 55E3A13C45A for ; Tue, 16 Oct 2007 08:54:16 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 23F7F6691E4; Tue, 16 Oct 2007 10:54:15 +0200 (CEST) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZoyG9LHBOphB; Tue, 16 Oct 2007 10:54:14 +0200 (CEST) Received: from vlk.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 4957F668DE7; Tue, 16 Oct 2007 10:54:14 +0200 (CEST) Received: (from rdivacky@localhost) by vlk.vlakno.cz (8.13.8/8.13.8/Submit) id l9G8sEO0027487; Tue, 16 Oct 2007 10:54:14 +0200 (CEST) (envelope-from rdivacky) Date: Tue, 16 Oct 2007 10:54:14 +0200 From: Roman Divacky To: Scott Long Message-ID: <20071016085414.GA27376@freebsd.org> References: <200710122211.l9CMBM4J010733@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200710122211.l9CMBM4J010733@repoman.freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_all.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 08:54:16 -0000 On Fri, Oct 12, 2007 at 10:11:22PM +0000, Scott Long wrote: > scottl 2007-10-12 22:11:22 UTC > > FreeBSD src repository > > Modified files: > sys/cam/scsi scsi_all.h > Log: > Add a bunch of definitions and structures to support newer drivers. - page_start = (void *)((u_int8_t *)&mode_header[1] + + page_start = (void *)((u_int8_t *)&mode_header[2] + scsi_2btoul(mode_header->blk_desc_len)); are you sure this belongs here? roman From owner-cvs-src@FreeBSD.ORG Tue Oct 16 09:13:17 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 632E516A41A; Tue, 16 Oct 2007 09:13:17 +0000 (UTC) (envelope-from kris@FreeBSD.org) Received: from weak.local (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx1.freebsd.org (Postfix) with ESMTP id 2D80B13C455; Tue, 16 Oct 2007 09:13:15 +0000 (UTC) (envelope-from kris@FreeBSD.org) Message-ID: <471480AB.7090500@FreeBSD.org> Date: Tue, 16 Oct 2007 11:13:15 +0200 From: Kris Kennaway User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: David Xu , jasone@FreeBSD.org References: <200710160736.l9G7a3oI087966@repoman.freebsd.org> In-Reply-To: <200710160736.l9G7a3oI087966@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libthr/thread thr_pspinlock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 09:13:17 -0000 David Xu wrote: > davidxu 2007-10-16 07:36:02 UTC > > FreeBSD src repository > > Modified files: > lib/libthr/thread thr_pspinlock.c > Log: > Reverse the logic of UP and SMP. > > Submitted by: jasone > > Revision Changes Path > 1.6 +1 -1 src/lib/libthr/thread/thr_pspinlock.c > > ! Are there any common applications that use this? Kris From owner-cvs-src@FreeBSD.ORG Tue Oct 16 09:29:08 2007 Return-Path: Delivered-To: cvs-src@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E896816A41A; Tue, 16 Oct 2007 09:29:08 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D59D913C44B; Tue, 16 Oct 2007 09:29:08 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from [127.0.0.1] (root@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l9G9T3vH069184; Tue, 16 Oct 2007 09:29:05 GMT (envelope-from davidxu@freebsd.org) Message-ID: <47148493.2020904@freebsd.org> Date: Tue, 16 Oct 2007 17:29:55 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.13) Gecko/20070516 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kris Kennaway References: <200710160736.l9G7a3oI087966@repoman.freebsd.org> <471480AB.7090500@FreeBSD.org> In-Reply-To: <471480AB.7090500@FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, jasone@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libthr/thread thr_pspinlock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 09:29:09 -0000 Kris Kennaway wrote: > David Xu wrote: > >> davidxu 2007-10-16 07:36:02 UTC >> >> FreeBSD src repository >> >> Modified files: >> lib/libthr/thread thr_pspinlock.c Log: >> Reverse the logic of UP and SMP. >> Submitted by: jasone >> Revision Changes Path >> 1.6 +1 -1 src/lib/libthr/thread/thr_pspinlock.c >> >> > > ! > > Are there any common applications that use this? > > Kris > I don't know. From owner-cvs-src@FreeBSD.ORG Tue Oct 16 09:37:44 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 844F216A418 for ; Tue, 16 Oct 2007 09:37:44 +0000 (UTC) (envelope-from bushman@freebsd.org) Received: from mail.r61.net (mail.r61.net [195.208.245.249]) by mx1.freebsd.org (Postfix) with ESMTP id 00E2113C442 for ; Tue, 16 Oct 2007 09:37:43 +0000 (UTC) (envelope-from bushman@freebsd.org) Received: from [127.0.0.1] ([195.161.235.42]) (authenticated bits=0) by mail.r61.net (8.14.1/8.14.1) with ESMTP id l9G9bRkl092704; Tue, 16 Oct 2007 13:37:39 +0400 (MSD) (envelope-from bushman@freebsd.org) Message-ID: <47148642.8070307@freebsd.org> Date: Tue, 16 Oct 2007 13:37:06 +0400 From: Michael Bushkov User-Agent: Thunderbird 2.0.0.5 (Windows/20070716) MIME-Version: 1.0 To: Skip Ford References: <200709271230.l8RCUCWN003489@repoman.freebsd.org> <861wckqj81.fsf@ds4.des.no> <4701F9DE.7090503@freebsd.org> <20071016032517.GF51310@menantico.com> In-Reply-To: <20071016032517.GF51310@menantico.com> Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.sbin/nscd/agents Makefile.inc group.c group.h passwd.c passwd.h services.c services.h src/usr.sbin/nscd Makefile agent.c agent.h cachelib.c cachelib.h cacheplcs.c cacheplcs.h config.c config.h debug.c hashtable.h log.c log.h mp_rs_query. ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 09:37:44 -0000 I've sent a patch that corrects this for approval to re@ already, and will commit the changes to HEAD tomorrow morning. Skip Ford wrote: > Michael Bushkov wrote: >> All cached references are currently eliminated > > cached(8) is still referenced in src.conf(5) in HEAD and RELENG_7. > > -- With best regards, Michael Bushkov Southern Federal University From owner-cvs-src@FreeBSD.ORG Tue Oct 16 10:37:30 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E1A8C16A469; Tue, 16 Oct 2007 10:37:30 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc3-cdif2-0-0-cust64.cdif.cable.ntl.com [81.106.128.65]) by mx1.freebsd.org (Postfix) with ESMTP id AB37F13C43E; Tue, 16 Oct 2007 10:37:30 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.68 (FreeBSD)) (envelope-from ) id 1IhjX3-000OzP-Hi; Tue, 16 Oct 2007 11:20:13 +0100 Date: Tue, 16 Oct 2007 11:20:13 +0100 From: Ceri Davies To: Stefan Esser Message-ID: <20071016102013.GE23043@submonkey.net> References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="h56sxpGKRmy85csR" Content-Disposition: inline In-Reply-To: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.16 (2007-06-09) Sender: Ceri Davies Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 10:37:31 -0000 --h56sxpGKRmy85csR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 15, 2007 at 10:09:19PM +0000, Stefan Esser wrote: > se 2007-10-15 22:09:19 UTC >=20 > FreeBSD src repository >=20 > Modified files: > usr.bin/locate/locate updatedb.sh=20 > Log: > Make the updatedb script installed as /usr/libexec/locate.updatedb > inspect all local file systems, not only ufs and ext2fs. A number > of local file systems has been added over time, and at least zfs > has the potential to become a popular choice. Without this change > a ZFS root file system causes the script to ignore all file-systems > and leads to an empty locate db. (An alternative is to add all the > relevant file systems individually, which means that at least zfs, > xfs, ntfs, ntfs-3g, msdosfs should be added, probably more). This now includes /dev, /dev/fd, /proc, /compat/linux/proc, CD-ROMs and DVDs as well as duplicating everything in nullfs mounts, all of which are probab= ly undesirable -- well, they are undesirable to me; whether they are to others is the question ;-). Also, the example in /etc/locate.rc should be updated to avoid misleading users into thinking that ufs is the only filesystem searched (granted, this was wrong before). Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --h56sxpGKRmy85csR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFHFJBdocfcwTS3JF8RAkosAKC3TW1GcatgfsLy1EK0cs3yYUGPsgCdGw5V rUrJg6dTgug6MkQ1UfyBt3s= =Izth -----END PGP SIGNATURE----- --h56sxpGKRmy85csR-- From owner-cvs-src@FreeBSD.ORG Tue Oct 16 10:40:54 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7698516A419; Tue, 16 Oct 2007 10:40:54 +0000 (UTC) (envelope-from alfred@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6A93B13C465; Tue, 16 Oct 2007 10:40:54 +0000 (UTC) (envelope-from alfred@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GAesfa010154; Tue, 16 Oct 2007 10:40:54 GMT (envelope-from alfred@repoman.freebsd.org) Received: (from alfred@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GAes88010153; Tue, 16 Oct 2007 10:40:54 GMT (envelope-from alfred) Message-Id: <200710161040.l9GAes88010153@repoman.freebsd.org> From: Alfred Perlstein Date: Tue, 16 Oct 2007 10:40:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern subr_param.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 10:40:54 -0000 alfred 2007-10-16 10:40:54 UTC FreeBSD src repository Modified files: sys/kern subr_param.c Log: Export maxswzone, maxbcache, maxtsiz, dfldsiz, maxdsiz, dflssiz, maxssiz, and sgrowsiz via sysctl. MFC after: 1 week Revision Changes Path 1.74 +10 -0 src/sys/kern/subr_param.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 10:52:41 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9AAF116A469 for ; Tue, 16 Oct 2007 10:52:41 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from spacemail1-out.mgmt.space.net (spacemail1-out.mgmt.Space.Net [194.97.149.146]) by mx1.freebsd.org (Postfix) with ESMTP id 433D313C481 for ; Tue, 16 Oct 2007 10:52:41 +0000 (UTC) (envelope-from se@FreeBSD.org) X-SpaceNet-SBRS: None X-IronPort-AV: E=Sophos;i="4.21,283,1188770400"; d="scan'208";a="72750584" Received: from mail.atsec.com ([195.30.252.105]) by spacemail1-out.mgmt.space.net with ESMTP; 16 Oct 2007 12:22:30 +0200 Received: from [10.2.2.88] (frueh.atsec.com [217.110.13.170]) (Authenticated sender: se@atsec.com) by mail.atsec.com (Postfix) with ESMTP id D313491C540; Tue, 16 Oct 2007 12:22:28 +0200 (CEST) Message-ID: <471490E2.1020801@FreeBSD.org> Date: Tue, 16 Oct 2007 12:22:26 +0200 From: Stefan Esser User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: "Christian S.J. Peron" References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> <20071016001925.GA63885@sub.vaned.net> In-Reply-To: <20071016001925.GA63885@sub.vaned.net> X-Enigmail-Version: 0.95.3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 10:52:41 -0000 Christian S.J. Peron schrieb: > You should claim ownership over PR: 116960 and change it to patched > since the reporter was complaining about this issue. Thanks for the information, I'll take care of it ... I had sent a request for approval of the patch to the release engineer a few hours before the PR was submitted, and I was not aware, that it existed (it did not when I found that a ZFS root prevented the locate db from receiving any data, since the "find" just stopped after noticing that "/" was none of the known local file-system types ...) Regards, STefan > On Mon, Oct 15, 2007 at 10:09:19PM +0000, Stefan Esser wrote: >> se 2007-10-15 22:09:19 UTC >> >> FreeBSD src repository >> >> Modified files: >> usr.bin/locate/locate updatedb.sh >> Log: >> Make the updatedb script installed as /usr/libexec/locate.updatedb >> inspect all local file systems, not only ufs and ext2fs. A number >> of local file systems has been added over time, and at least zfs >> has the potential to become a popular choice. Without this change >> a ZFS root file system causes the script to ignore all file-systems >> and leads to an empty locate db. (An alternative is to add all the >> relevant file systems individually, which means that at least zfs, >> xfs, ntfs, ntfs-3g, msdosfs should be added, probably more). From owner-cvs-src@FreeBSD.ORG Tue Oct 16 10:54:56 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F44216A417; Tue, 16 Oct 2007 10:54:56 +0000 (UTC) (envelope-from alfred@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A6E3513C47E; Tue, 16 Oct 2007 10:54:56 +0000 (UTC) (envelope-from alfred@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GAsugS011457; Tue, 16 Oct 2007 10:54:56 GMT (envelope-from alfred@repoman.freebsd.org) Received: (from alfred@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GAsuNE011456; Tue, 16 Oct 2007 10:54:56 GMT (envelope-from alfred) Message-Id: <200710161054.l9GAsuNE011456@repoman.freebsd.org> From: Alfred Perlstein Date: Tue, 16 Oct 2007 10:54:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/cd9660 cd9660_vfsops.c src/sys/fs/coda coda_vfsops.c src/sys/fs/fdescfs fdesc_vfsops.c src/sys/fs/hpfs hpfs_vfsops.c src/sys/fs/msdosfs msdosfs_vfsops.c src/sys/fs/ntfs ntfs_vfsops.c src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 10:54:56 -0000 alfred 2007-10-16 10:54:56 UTC FreeBSD src repository Modified files: sys/fs/cd9660 cd9660_vfsops.c sys/fs/coda coda_vfsops.c sys/fs/fdescfs fdesc_vfsops.c sys/fs/hpfs hpfs_vfsops.c sys/fs/msdosfs msdosfs_vfsops.c sys/fs/ntfs ntfs_vfsops.c sys/fs/nullfs null_vfsops.c sys/fs/nwfs nwfs_vfsops.c sys/fs/portalfs portal_vfsops.c sys/fs/pseudofs pseudofs.c sys/fs/smbfs smbfs_vfsops.c sys/fs/udf udf_vfsops.c sys/fs/unionfs union_vfsops.c sys/gnu/fs/ext2fs ext2_vfsops.c sys/gnu/fs/reiserfs reiserfs_vfsops.c sys/gnu/fs/xfs/FreeBSD xfs_vfs.c sys/nfs4client nfs4_vfsops.c sys/nfsclient nfs_vfsops.c sys/ufs/ffs ffs_vfsops.c Log: Get rid of qaddr_t. Requested by: bde Revision Changes Path 1.151 +3 -3 src/sys/fs/cd9660/cd9660_vfsops.c 1.68 +1 -1 src/sys/fs/coda/coda_vfsops.c 1.57 +1 -1 src/sys/fs/fdescfs/fdesc_vfsops.c 1.61 +3 -3 src/sys/fs/hpfs/hpfs_vfsops.c 1.175 +3 -3 src/sys/fs/msdosfs/msdosfs_vfsops.c 1.89 +2 -2 src/sys/fs/ntfs/ntfs_vfsops.c 1.84 +1 -1 src/sys/fs/nullfs/null_vfsops.c 1.45 +2 -2 src/sys/fs/nwfs/nwfs_vfsops.c 1.61 +1 -1 src/sys/fs/portalfs/portal_vfsops.c 1.33 +1 -1 src/sys/fs/pseudofs/pseudofs.c 1.42 +2 -2 src/sys/fs/smbfs/smbfs_vfsops.c 1.49 +2 -2 src/sys/fs/udf/udf_vfsops.c 1.87 +1 -1 src/sys/fs/unionfs/union_vfsops.c 1.166 +3 -3 src/sys/gnu/fs/ext2fs/ext2_vfsops.c 1.10 +2 -2 src/sys/gnu/fs/reiserfs/reiserfs_vfsops.c 1.3 +1 -1 src/sys/gnu/fs/xfs/FreeBSD/xfs_vfs.c 1.28 +1 -1 src/sys/nfs4client/nfs4_vfsops.c 1.194 +1 -1 src/sys/nfsclient/nfs_vfsops.c 1.330 +3 -3 src/sys/ufs/ffs/ffs_vfsops.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 11:23:01 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B406216A418; Tue, 16 Oct 2007 11:23:01 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A965113C459; Tue, 16 Oct 2007 11:23:01 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GBN1AS014174; Tue, 16 Oct 2007 11:23:01 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GBN1xJ014169; Tue, 16 Oct 2007 11:23:01 GMT (envelope-from ru) Message-Id: <200710161123.l9GBN1xJ014169@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 16 Oct 2007 11:22:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/gen sysctl.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 11:23:01 -0000 ru 2007-10-16 11:22:58 UTC FreeBSD src repository Modified files: lib/libc/gen sysctl.3 Log: Rescue parts of the sensorsd commit that are still relevant: - HW_FLOATINGPOINT renamed to HW_FLOATINGPT. - Documented HW_REALMEM. - Sorted as per . Revision Changes Path 1.73 +9 -6 src/lib/libc/gen/sysctl.3 From owner-cvs-src@FreeBSD.ORG Tue Oct 16 11:29:15 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E0BBC16A418; Tue, 16 Oct 2007 11:29:15 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id D638613C458; Tue, 16 Oct 2007 11:29:15 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GBTFij014802; Tue, 16 Oct 2007 11:29:15 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GBTFhM014801; Tue, 16 Oct 2007 11:29:15 GMT (envelope-from ru) Message-Id: <200710161129.l9GBTFhM014801@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 16 Oct 2007 11:29:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/gen sysctl.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 11:29:16 -0000 ru 2007-10-16 11:29:13 UTC FreeBSD src repository Modified files: lib/libc/gen sysctl.3 Log: VM_METER is long deprecated. Revision Changes Path 1.74 +2 -2 src/lib/libc/gen/sysctl.3 From owner-cvs-src@FreeBSD.ORG Tue Oct 16 11:32:57 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7897816A417; Tue, 16 Oct 2007 11:32:57 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6D0E113C4C5; Tue, 16 Oct 2007 11:32:57 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GBWvjF015119; Tue, 16 Oct 2007 11:32:57 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GBWvGD015118; Tue, 16 Oct 2007 11:32:57 GMT (envelope-from ru) Message-Id: <200710161132.l9GBWvGD015118@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 16 Oct 2007 11:32:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/vm vm_param.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 11:32:57 -0000 ru 2007-10-16 11:32:57 UTC FreeBSD src repository Modified files: sys/vm vm_param.h Log: Fix CTL_VM_NAMES. Revision Changes Path 1.23 +8 -8 src/sys/vm/vm_param.h From owner-cvs-src@FreeBSD.ORG Tue Oct 16 11:39:29 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 269E616A419; Tue, 16 Oct 2007 11:39:29 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 1C51113C459; Tue, 16 Oct 2007 11:39:29 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GBdSlv015362; Tue, 16 Oct 2007 11:39:28 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GBdSEQ015361; Tue, 16 Oct 2007 11:39:28 GMT (envelope-from ru) Message-Id: <200710161139.l9GBdSEQ015361@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 16 Oct 2007 11:39:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/modules Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 11:39:29 -0000 ru 2007-10-16 11:39:28 UTC FreeBSD src repository Modified files: sys/modules Makefile Log: Rescue whitespace nits. Revision Changes Path 1.544 +2 -2 src/sys/modules/Makefile From owner-cvs-src@FreeBSD.ORG Tue Oct 16 11:46:44 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BD71716A473; Tue, 16 Oct 2007 11:46:44 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id AEFD213C481; Tue, 16 Oct 2007 11:46:44 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GBkirG015799; Tue, 16 Oct 2007 11:46:44 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GBkiRu015798; Tue, 16 Oct 2007 11:46:44 GMT (envelope-from ru) Message-Id: <200710161146.l9GBkiRu015798@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 16 Oct 2007 11:46:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys sysctl.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 11:46:44 -0000 ru 2007-10-16 11:46:44 UTC FreeBSD src repository Modified files: sys/sys sysctl.h Log: Rescue hw.machine_arch in CTL_HW_NAMES. Revision Changes Path 1.151 +1 -0 src/sys/sys/sysctl.h From owner-cvs-src@FreeBSD.ORG Tue Oct 16 13:01:46 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0D76E16A420; Tue, 16 Oct 2007 13:01:46 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id F262313C4A3; Tue, 16 Oct 2007 13:01:45 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 3F5CC46C02; Tue, 16 Oct 2007 09:01:39 -0400 (EDT) Date: Tue, 16 Oct 2007 14:01:39 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Ruslan Ermilov In-Reply-To: <200710161129.l9GBTFhM014801@repoman.freebsd.org> Message-ID: <20071016135940.B9055@fledge.watson.org> References: <200710161129.l9GBTFhM014801@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/gen sysctl.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 13:01:46 -0000 On Tue, 16 Oct 2007, Ruslan Ermilov wrote: > ru 2007-10-16 11:29:13 UTC > > FreeBSD src repository > > Modified files: > lib/libc/gen sysctl.3 > Log: > VM_METER is long deprecated. > > Revision Changes Path > 1.74 +2 -2 src/lib/libc/gen/sysctl.3 In general, we've also been encouraging a move to named sysctls from numeric constants. Should we be sweeping the tree to catch remaining uses, and possibly be considering hiding visibility of the numeric constants from user space by default? (i.e., #ifdef DEPRECATED_SYSCTL_CONSTANTS). I assume we'll want to continue to support them in kernel for the forseeable future to allow old FreeBSD user spaces to continue to run in jails on new kernels. Just something to think about now 8.x is alive and the life cycle is long... Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Tue Oct 16 14:05:53 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 88C6116A418; Tue, 16 Oct 2007 14:05:53 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 961D913C45A; Tue, 16 Oct 2007 14:05:53 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GE5rYl036309; Tue, 16 Oct 2007 14:05:53 GMT (envelope-from rrs@repoman.freebsd.org) Received: (from rrs@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GE5rh6036308; Tue, 16 Oct 2007 14:05:53 GMT (envelope-from rrs) Message-Id: <200710161405.l9GE5rh6036308@repoman.freebsd.org> From: Randall Stewart Date: Tue, 16 Oct 2007 14:05:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet sctp_constants.h sctp_indata.c sctp_input.c sctp_output.c sctp_pcb.c sctp_structs.h sctp_timer.c sctp_usrreq.c sctp_var.h sctputil.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 14:05:53 -0000 rrs 2007-10-16 14:05:52 UTC FreeBSD src repository Modified files: sys/netinet sctp_constants.h sctp_indata.c sctp_input.c sctp_output.c sctp_pcb.c sctp_structs.h sctp_timer.c sctp_usrreq.c sctp_var.h sctputil.c Log: - fix sctp_ifn initial refcount issue (prevents deletion) - fix a bug during cookie collision that prevented an association from coming up in a specific restart case. - Fix it so the shutdown-pending flag gets removed (this is more for correctness then needed) when we enter shutdown-sent or shutdown-ack-sent states. - Fix a bug that caused the receiver to sometimes NOT send a SACK when a duplicate TSN arrived. Without this fix it was possible for the association to fall down if the - Deleted primary destination is also stored when SCTP_MOBILITY_BASE. (Previously, it is stored when only SCTP_MOBILITY_FASTHANDOFF) - Fix a locking issue where we might call send_initiate_ack() and incorrectly state the lock held/not held. Also fix it so that when we release the lock the inp cannot be deleted on us. - Add the debug option that can cause the stack to panic instead of aborting an assoc. This does not and should never show up in options but is useful for debugging unexpected aborts. - Add cumack_log sent to track sending cumack information for the debug case where we are running a special log per assoc. - Added extra () aroudn sctp_sbspace macro to avoid compile warnings. MFC after: 1 week Revision Changes Path 1.33 +2 -0 src/sys/netinet/sctp_constants.h 1.46 +6 -3 src/sys/netinet/sctp_indata.c 1.66 +23 -42 src/sys/netinet/sctp_input.c 1.60 +11 -0 src/sys/netinet/sctp_output.c 1.63 +7 -2 src/sys/netinet/sctp_pcb.c 1.26 +2 -1 src/sys/netinet/sctp_structs.h 1.33 +1 -0 src/sys/netinet/sctp_timer.c 1.49 +2 -0 src/sys/netinet/sctp_usrreq.c 1.21 +1 -1 src/sys/netinet/sctp_var.h 1.67 +9 -5 src/sys/netinet/sctputil.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 16:18:40 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7ADED16A417; Tue, 16 Oct 2007 16:18:40 +0000 (UTC) (envelope-from mp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5BD1313C45D; Tue, 16 Oct 2007 16:18:40 +0000 (UTC) (envelope-from mp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GGIeNZ049747; Tue, 16 Oct 2007 16:18:40 GMT (envelope-from mp@repoman.freebsd.org) Received: (from mp@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GGIel2049746; Tue, 16 Oct 2007 16:18:40 GMT (envelope-from mp) Message-Id: <200710161618.l9GGIel2049746@repoman.freebsd.org> From: Mark Peek Date: Tue, 16 Oct 2007 16:18:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/contrib/tcsh sh.c sh.proc.c tc.const.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 16:18:40 -0000 mp 2007-10-16 16:18:40 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) contrib/tcsh sh.c sh.proc.c tc.const.c Log: Apply two vendor fixes from tcsh-6.15.01. The fixes are: - Fix pty detection for autologout setting - kill `foo` got stuck because sigchld was disabled too soon Approved by: re Revision Changes Path 1.1.1.9.2.1 +2 -2 src/contrib/tcsh/sh.c 1.1.1.7.2.1 +6 -7 src/contrib/tcsh/sh.proc.c 1.1.1.9.2.1 +1 -1 src/contrib/tcsh/tc.const.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 16:34:28 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8BAEA16A419; Tue, 16 Oct 2007 16:34:28 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id CE24713C465; Tue, 16 Oct 2007 16:34:27 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A54BF1.dip.t-dialin.net [84.165.75.241]) by redbull.bpaserver.net (Postfix) with ESMTP id 9798B2E145; Tue, 16 Oct 2007 18:34:17 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id E14615B480D; Tue, 16 Oct 2007 18:33:11 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.1/8.13.8/Submit) id l9GGXBbW066103; Tue, 16 Oct 2007 18:33:11 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Tue, 16 Oct 2007 18:33:11 +0200 Message-ID: <20071016183311.lu97hbwzggsk4ow4@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Tue, 16 Oct 2007 18:33:11 +0200 From: Alexander Leidinger To: Poul-Henning Kamp References: <1947.1192477927@critter.freebsd.dk> In-Reply-To: <1947.1192477927@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=3.377, required 8, BAYES_50 2.50, J_CHICKENPOX_27 0.60, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10, TW_SK 0.08) X-BPAnet-MailScanner-SpamScore: sss X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: Wilko Bulte , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 16:34:28 -0000 Quoting Poul-Henning Kamp (from Mon, 15 Oct 2007 =20 19:52:07 +0000): > In message <20071015210909.1b6b693b@deskjail>, Alexander Leidinger writes: >> Quoting "Poul-Henning Kamp" (Mon, 15 Oct 2007 =20 >> 15:01:47 +0000): > >>> >And I responded that we need to have a way to export data from the >>> >kernel to userland in an unified way. >>> >>> I can't seem to find the supposed requirement for unification here, >> >> You didn't comment on what I wrote about reducing the work of >> reinventing a way to export the data we want to export again and again >> and again and again... > > Yes, that is the abstract argument, but the very same argument can > be made for every other single kind of entity which consumes or > produces bytes, from fingerprint readers to 9-track tape stations. Why do we have a common linked list API? It's easy enough to do it =20 again and again and again... We have it because we don't want to do it =20 again and again... And with the sensors API we gain something similar. =20 Sure, we can do it with sysctls in every place. But with the sensors =20 API we reduce the code to write for such things like with the linked =20 lists API. > My beef with this code is that it unifies a lot of non-alike > measurements and indications in a new, and pretty bogus IMO, api, > but adding no value above a plain old sysctl while doing so. It adds meta-data which can be used in an automated way. This is done =20 with a consistent and documented API. Sure, we can do it with sysctls =20 by hand, but see above. >>> and in fact, it is exactly that a lot of crap gets bundled up >>> under the wildcard term of "sensor" that I object to. >> >> Exporting temperature readings / voltage measurement, system status is >> not crap. > > Actually it is, if it can be done as well (or better) from userland > by exporting the underlying communications paths. See below for the mbmon example. And for some things we already had =20 the export of this via sysctl (temperature of Intel core processors), =20 the sensors API "just" groups this together so that people don't have =20 to hunt such info down, adds meta data to it, so that tools can do =20 some automation, and unifies the API to export this info from the =20 kernel. >> And when you write some monitoring probes in a large server >> farm, you don't want to hunt down every interesting data value in a lot >> of places. > > Ahh, so this brings me to the next problem with sensors. > > If by "monitoring" you mean "plot MRTG graphs", then I guess sensors > could possibly make sense, although, I'd have to point out that all > that can be done just as well from ports/sysutils/whatever. With elevated privileges for those tools. See below. > But if you're talking real world monitoring, then sensors are > pointless, because there is no way to derive necessary machine > readable contextual information, such as alarm limits, resolution, > calibration constants, hysteresis, polling periods etc. Normally you configure this in the tools which do the monitoring, not =20 in the tools which acquire the data. I'm not talking about doing this =20 in the sensors framework, but I talk about to get rid of the need to =20 hunt down such information from everywhere. I makes it easier to write =20 monitoring probes. It is not supposed to make the monitoring itself =20 easier. > Or, for that matter, machine-readable information about what is > actually being measured and where it is being measured and what it > means. A human being still has to interprete the measurements. No doubts. But =20 with the framework you don't have to hunt down where to read the =20 sensor data, and how to name it. You can write a probe which takes =20 everything in the the sensors mib and let it produce names and values =20 for the probed things automatically. > There are frameworks for doing that sort of stuff in professional > server hardware, but since OpenBSD doesn't support those, IPMI, > ACPI etc, they have come up with this VAX-mentality junkheap instead. IPMI is intended to handle situations when the OS is not booted or the =20 system is not powered on. Yes, it allows some features when the OS is =20 booted too. Now... how much hardware out there supports IPMI, or =20 better... how much in production use doesn't use IPMI? I would say =20 quite a lot (we all know the managers, "do everything with no money at =20 all"). The sensors framework allows to monitor those systems in an =20 easy (because you don't need to invest that much work with the sensors =20 framework) way. Have you identified some parts in the sensors =20 framework which make it impossible to play together with IPMI? If yes, =20 would you please so kind and tell us what prevents them to play =20 together? Regarding ACPI... Nate (our ACPI committer) asked after the commit why =20 acpi_thermal was not modified to play together with the sensors =20 framework (the reason: ACPI was a little bit too much to do in the SoC =20 for Constantine, Nate agreed to work together (after some other work =20 in ACPI he wants to finish first) if desired (put on hold from the =20 sensors side until this discussion comes tp an conclusion), and also =20 suggested some improvements for the sensors framework). He didn't told =20 us about something in the framework, which prevents the use of it =20 together with ACPI. >>> >I already told you last time >>> >that the current way (access to the i2c or smbus) needs more access >>> >rights than using the userland parts of the sensors framework. >>> >>> More rights than what exactly ? >> >> One popular userland temperature/voltage reading tool (as it supports a >> lot of popular devices) is mbmon. It is currently a SUID root >> application. > > Let me get this straight, you're telling me: > > =09"I'm worried about this code running as root, so I'm putting > =09it in the kernel instead." > > Can anybody here spot the logic flaw of this argument ? > > Anybody ? > > Right, I thought so. Lets pretend you didn't say that. You missed the point. In our architecture we can not do it without =20 executing some code with elevated privileges. What I suggested was to =20 replace SUID root code with unknown security heritage and potential =20 complete access to the machine (direct access to ISA I/O ports and the =20 smbus), not only with code (which runs with elevated privileges) from =20 a known security heritage (from people which strongly care about =20 security), but also with an access method which doesn't need any =20 elevated privileges at all. I assume you think that for example =20 expoting some predefined numbers with "sysctl hw.sensors >outout" is =20 not something we need to care that much about from a security point of =20 view. Feel free to tell me if I'm wrong with my assumption. I at least =20 feel safer to export an int over sysctl, than to run the SUID root =20 mbmon tool. There may be other ways to accomplish the same. Maybe a daemon which =20 runs with elevated privileges and just outputs the temperature/voltage =20 as a number to a tool which runs without elevated privileges and =20 collects the data. So far we don't have such a tool, and in the =20 beginning I'm not sure we can trust such a tool to the same extend as =20 we can trust sysctl. And this would only affect sensors like lm (which is not part of the =20 sensors framework, but uses the sensors framework to export it's data, =20 and was used as an example to show how the sensors framework can be =20 used). What about other such data which lives in subsystems we don't =20 want to let an userland application mess around with? I don't know if =20 we want to let an userland application give that much access to ACPI. =20 ACPI already exports some data with sysctl. ATM it does it by hand. =20 The sensors framework provides an unified API to not do everything by =20 hand anymore. >>> No, I have yet to see why we need this framework. >> >> Several committers which voted for this project in the soc webinterface >> seem to think otherwise, else they wouldn't have voted for it. > > I repeat: The SoC interface is not the gateway to -current. It provides an idea in what people are interested in. And several =20 committers here in the thread also showed interest in this framework =20 (maybe not in the current implementation, but at least in the idea =20 behind it). Just because you do not see how such a framework can be =20 useful to you (so far I have the impression from your mails, that you =20 object to the idea of this framework), it doesn't mean other people =20 are not interested in it. So it is not a gateway for concrete =20 implementations into -current, but it shows what people are interested =20 in for -current. The current implementation of the sensors framework =20 may not use the best way of doing something in some places, but it is =20 not as bad as you give people the impression. In the mean time =20 Constantine had a look at the constructive critics we got so far, and =20 thinks that moving to the taskqueue API is not a bug problem. For the =20 newbus suggestion so far he asked for more information, as the man =20 pages didn't gave him enough input. As far as I know, the man pages of =20 newbus are known to be in a suboptimal shape. But as you seem to be =20 not interested in the idea of the sensors framework, one can have the =20 impression, that you are not interested to hear about improvements of =20 the implementation. >>> >> C) How it integrates into FreeBSD and for the places where >>> >> it does not (newbus ?) why it doesn't. >>> > >> >> We're discussing it right now. And I was willing to discuss this even >> back when you talked about it the first time. > > It should have been dicussed and fixed before being committed to > -current. Current is not where you start, it is where you end, these We where willing to listed to your concerns. You stopped talking about =20 them back then. > kind of things are not details to be hashed out in CVS. Constantine asked for review several times on -current. He got some =20 reviews several times for commits to perforce. He incorporated =20 suggestions from those reviews, or explained why it is like it is and =20 why he can not switch (with no replies with suggestions how to solve =20 the problems he sees with the suggestions). Now you come and ask why =20 nobody pointed out some flaws before (without telling us which =20 technical flaws you talk about). > Ten years ago when we didn't have P4 and the _extensive_ infrastructure > for making it easy for people to work out of the tree, we had to do > stuff like that, but there is no excuse for it today. Nobody is perfect. There will always be some bugs when something is =20 committed to -current. You don't talk about obvious problems here. =20 There's no destabilized system, there are no panics. You talk about =20 not using an underdocumented API and not using a generic framework for =20 creating tasks (so basically we talk about doing something by hand =20 what can be done with less work by using an API... sounds like what =20 the sensors framework tries to do for some kinds of data export). Note: the commit of the code from the sensors project was done in 3 =20 steps on purpose, the sensors framework, 2 temperature/voltage chip =20 drivers as examples how to use the sensors framework (and the benefit =20 of getting rid of a SUID root application in the userland), and =20 converting the existing CPU temperature sysctl (for some specific =20 Intel CPUs) from doing a sysctl by hand to the sensors framework (as =20 an example how to convert an existing part to the sensors framework). =20 So far we mixed the discussion about various parts of this together =20 under the umbrella of "sensors framework", which is not ok. >>> >The code we have currently doesn't harm the system, [...] >>> >>> This is where I disagree: it does harm the system. >>> >>> It dumps a load of badly thought out code into our source tree, and >>> that will effectively be in the way of any well thought out solution >>> that might ever appear. >>> >>> This stuff should be backed out, and forced to live outside the tree >>> until it satisfies our quality and architectural requirements. >> >> How does this compare to your attitude of bringing stuff into the tree >> and letting other people fixup collateral damage in the past? But I >> drift away from the topic... so back to the sensors framework. > > It does not compare, please answer the question instead of trying Which question? I don't see a question from you in the quoted part =20 above. And without mentioning the bad code, we can not proceed =20 discussing about it. The constructive responses so far don't give the =20 impression that there code is that bad as you suggest here. > to insult me, because you're no good at it. I have been insulted I don't try to insult you. >> To be able to address our quality and architectural requirements, we >> need first to know which quality and architectural requirements are >> violated by which part of the code in question. As you seem to have >> identified them, would you please so kind and share your concrete >> findings? > > Would you be so kind as to read the emails I've sent you ? Maybe > this time expending some effort to understand what people tell you in > them, rather than pretending they contained nothing ? So far I see from you that you are not interested in the idea of the =20 framework. And I see mails where people are interested in the idea of =20 the framework. And I see private mails which point out some =20 improvements. According specific quality problems, I haven't seen a =20 concrete mail from you, like saying "you use X, but this is should be =20 done with Y, see at place A how to do it better". I have seen such =20 mails from other people, but not from you. >>> Forcing it to stay out of -current, means that the motivational >>> pressure is on the people who thing we badly need this featureset, >>> and gives them reason to improve it. >>> >>> Leaving it in the tree, is the sure fire way for it to become an >>> unmaintained lump of code that slowly rots away. >> >> You did a psycho-analysis of Constantine so that you are able to tell >> that he doesn't fix the issues while he agreed to improve the framework? > > No, it's far worse. > > I have 15 years of experience with this kind of code being slammed > into the tree in an unfinished and badly thought out shape. > > And I have wasted far more time cleaning it up afterwards, than you > or constantine will have spent on FreeBSD five years from now. So would you please share your experience and tell us where parts are =20 wrong because of what reason and what kind of technique is better =20 suited to do it? So far I've only seen that you don't like the idea =20 itself and that you for this reason haven't looked at concrete problems. If someone reading this does not share this point of view, please, =20 tell me about it. So far I haven't got any mail to my similar question =20 in a previous mail, so please tell me about it if you think that I'm =20 wrong when I say that Poul gives the impression he doesn't like the =20 idea (while several other committers see benefit in it) and that it =20 seems that he didn't provided concrete pointers to problems in the =20 implementation. Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 Who on earth would eat a charred caterpillar!? No, no, you SINGE 'em! You SINGE 'em and eat 'em! From owner-cvs-src@FreeBSD.ORG Tue Oct 16 16:42:00 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F40F516A41B; Tue, 16 Oct 2007 16:41:59 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 83CBE13C447; Tue, 16 Oct 2007 16:41:59 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A54BF1.dip.t-dialin.net [84.165.75.241]) by redbull.bpaserver.net (Postfix) with ESMTP id 4A1552E0BD; Tue, 16 Oct 2007 18:41:53 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id C11915B480D; Tue, 16 Oct 2007 18:40:47 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.1/8.13.8/Submit) id l9GGelnL067292; Tue, 16 Oct 2007 18:40:47 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Tue, 16 Oct 2007 18:40:47 +0200 Message-ID: <20071016184047.8zh3fl90gksks40c@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Tue, 16 Oct 2007 18:40:47 +0200 From: Alexander Leidinger To: John-Mark Gurney References: <20071015152408.10kvgtog6cooc4wc@webmail.leidinger.net> <48258.1192460507@critter.freebsd.dk> <20071015210909.1b6b693b@deskjail> <20071015202115.GP39759@funkthat.com> In-Reply-To: <20071015202115.GP39759@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-13.404, required 8, BAYES_00 -15.00, MIME_QP_LONG_LINE 1.40, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10) X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: Wilko Bulte , Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 16:42:00 -0000 Quoting John-Mark Gurney (from Mon, 15 =20 Oct 2007 13:21:15 -0700): > Alexander Leidinger wrote this message on Mon, Oct 15, 2007 at 21:09 +0200= : >> > >I already told you last time >> > >that the current way (access to the i2c or smbus) needs more access >> > >rights than using the userland parts of the sensors framework. >> > >> > More rights than what exactly ? >> >> One popular userland temperature/voltage reading tool (as it supports a >> lot of popular devices) is mbmon. It is currently a SUID root >> application. It is like this as it accesses the smbus and/or ISA I/O >> ports directly. If we forget the ISA I/O ports part, we could maybe >> switch to a mbmon-user, but I don't really want to have such an user be >> able to query every device on the smbus. >> >> systat and sysctl are not SUID/SGID and don't require some special >> rights in /dev. I would say this is a big difference in favour of the >> sensors framework. > > Did you completely ignore the discussion back in July? I didn't bring > it up, because someone else did, but the simple solution is a socket Have you a pointer to it? I would like to analyze why I don't remember =20 to have seen this. > like /var/run/log or /var/run/devd.pipe, that a userland daemon running > as root that has access to ISA I/O and related resources... It's > that simple... And the code doesn't exists. And when it is written, when will it be =20 bugfree enough? The sysctl way of exporting integer data already has a =20 good track record, and porting the existing lm sensor (from a project =20 which is known to take much care about security) was easier to get =20 right. The project also was not about the lm sensor (I don't go and =20 count the size for the small lm sensor now). The lm sensor was one =20 example of using it. I don't think objection to the lm sensor driver =20 should lead to removal of the framework itself. One possible reaction =20 could be to say that the lm sensor should move to ports. Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 You can be replaced by this computer. From owner-cvs-src@FreeBSD.ORG Tue Oct 16 17:10:09 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5196B16A41B for ; Tue, 16 Oct 2007 17:10:09 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from spacemail2-out.mgmt.space.net (spacemail2-out.mgmt.Space.Net [194.97.149.148]) by mx1.freebsd.org (Postfix) with ESMTP id D385C13C45A for ; Tue, 16 Oct 2007 17:10:08 +0000 (UTC) (envelope-from se@FreeBSD.org) X-SpaceNet-SBRS: None X-IronPort-AV: E=Sophos;i="4.21,284,1188770400"; d="scan'208";a="69714765" Received: from mail.atsec.com ([195.30.252.105]) by spacemail2-out.mgmt.space.net with ESMTP; 16 Oct 2007 19:10:06 +0200 Received: from [10.2.2.88] (frueh.atsec.com [217.110.13.170]) (Authenticated sender: se@atsec.com) by mail.atsec.com (Postfix) with ESMTP id DC58F91C544; Tue, 16 Oct 2007 19:10:05 +0200 (CEST) Message-ID: <4714F06B.7070702@FreeBSD.org> Date: Tue, 16 Oct 2007 19:10:03 +0200 From: Stefan Esser User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Ceri Davies References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> <20071016102013.GE23043@submonkey.net> In-Reply-To: <20071016102013.GE23043@submonkey.net> X-Enigmail-Version: 0.95.3 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 17:10:09 -0000 Ceri Davies schrieb: > On Mon, Oct 15, 2007 at 10:09:19PM +0000, Stefan Esser wrote: >> se 2007-10-15 22:09:19 UTC >> >> FreeBSD src repository >> >> Modified files: >> usr.bin/locate/locate updatedb.sh >> Log: >> Make the updatedb script installed as /usr/libexec/locate.updatedb >> inspect all local file systems, not only ufs and ext2fs. A number >> of local file systems has been added over time, and at least zfs >> has the potential to become a popular choice. Without this change >> a ZFS root file system causes the script to ignore all file-systems >> and leads to an empty locate db. (An alternative is to add all the >> relevant file systems individually, which means that at least zfs, >> xfs, ntfs, ntfs-3g, msdosfs should be added, probably more). > > This now includes /dev, /dev/fd, /proc, /compat/linux/proc, CD-ROMs and DVDs > as well as duplicating everything in nullfs mounts, all of which are probably > undesirable -- well, they are undesirable to me; whether they are to > others is the question ;-). Ok, thank you for the information. I did not notice this in my tests. I'm not sure what the "local" pseudo fs-type is meant to be used for. Currently it appears to be identical to "not-remote" (which is what the locate db update tries to avoid, due to high network load and scan time). I plan to fix this within the next 24 hours (if anybody thinks it needs to be backed-out immediately, I'm willing to do this, but I'd rather put in the correct fix instead. Two possibilities: We could have another pseudo fs-type in find, which selects "real" file systems (and skips devfs, procfs, fdescfs, nullfs and probably more). Scanning of removable devices is dubious, too, independently of their file system. By selecting "local" and "disk based" file systems (which would omit not only the pseudo file-systems and nullfs, but also cd9660 and udf), no specific file systems needed to be put into the script (and find would have the knowledge). The second possibility is to extend the list in the update script. It needs to contain at least: ufs ext2fs zfs and probably also: xfs msdosfs ntfs ntfs-3g (?) Did I forget any? In fact, I'd rather enter "ufs ext2fs zfs xfs msdosfs ntfs" right now, instead of relying on the pseudo-fs definition in find, now that I think about it. Any opinions or comments? > Also, the example in /etc/locate.rc should be updated to avoid > misleading users into thinking that ufs is the only filesystem searched > (granted, this was wrong before). I'll fix this at the same time, but want to wait a few hours for some feedback. Regards, STefan From owner-cvs-src@FreeBSD.ORG Tue Oct 16 17:32:43 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 249DE16A418; Tue, 16 Oct 2007 17:32:43 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id 82DBD13C468; Tue, 16 Oct 2007 17:32:42 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id EF97517105; Tue, 16 Oct 2007 17:32:40 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id l9GHWerY013869; Tue, 16 Oct 2007 17:32:40 GMT (envelope-from phk@critter.freebsd.dk) To: Alexander Leidinger From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 16 Oct 2007 18:33:11 +0200." <20071016183311.lu97hbwzggsk4ow4@webmail.leidinger.net> Date: Tue, 16 Oct 2007 17:32:40 +0000 Message-ID: <13868.1192555960@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: Wilko Bulte , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 17:32:43 -0000 In message <20071016183311.lu97hbwzggsk4ow4@webmail.leidinger.net>, Alexander L eidinger writes: >> Yes, that is the abstract argument, but the very same argument can >> be made for every other single kind of entity which consumes or >> produces bytes, from fingerprint readers to 9-track tape stations. > >Why do we have a common linked list API? It's easy enough to do it >again and again and again... We have it because we don't want to do it >again and again... And with the sensors API we gain something similar. There is a very big difference between and sensors, in that is not an external API, but a convenience tool for code to maintain its own data internally, whereas sensors is an API for exporting data. >It adds meta-data which can be used in an automated way. This is done >with a consistent and documented API. Sure, we can do it with sysctls >by hand, but see above. What exactly do you mean when you say "used in an automated way" ? Can I run some magic program and tell it "alert me if something is wrong" or do I have to write a tedious configuration file to explain what "something is wrong" would look like to the program ? >It is not supposed to make the monitoring itself easier. >[...] >A human being still has to interprete the measurements. No doubts. But >with the framework you don't have to hunt down where to read the >sensor data, and how to name it. You can write a probe which takes >everything in the the sensors mib and let it produce names and values >for the probed things automatically. So the only problem sensors solves, is that it defines a single place in the sysctl tree, where you can find all sorts of non-random numbers, each of which comes with a piece of ascii text that isn't formatted in any consistent way ? I'd say, lets raise the bar several notches right here. How about we look at what is desirable from such a subsystem, and see what architecture that mandates ? Here are some things to think about: * Input only or input & output ? Would it make sense to be able to control the fans or power to various subsystems while we are at it ? * It should be possible to implement a sensor in userland, so that interface to external sensors is possible without forcing the code into the kernel. Think: Maxim/Dallas 1-Wire temperature sensors and similar. * Metadata information in machine redable format: - recommended, min and max poll rate - Nominal value, quantization step and alarm limit(s) - alarm transgression severity for system integrity - sensorfailure severity for system integrity - physical location of measured quantity ... * Event support ? - enumeration, arrival and departure of sensors - alarm transgressions - sensor failure ... * Interface and integration with IPMI, ACPI and similar. Do any of these have a metadata format we can use ? and probably a lot of other stuff I didn't think of right now... >Now... how much hardware out there supports IPMI, or >better... how much in production use doesn't use IPMI? But don't you think it would be better to have a subsystem that made it possible to use IPMI and ACPI, than to just say "Naa, that sucks, it must do, because we don't support it" ? >> Let me get this straight, you're telling me: >> >> "I'm worried about this code running as root, so I'm putting >> it in the kernel instead." > >You missed the point. No, I most certainly did not. By defining the sensor API (on top of sysctl) at the kernel/userland boundary you have decided that all sensor implementations must live in the kernel, there is no room in your architecture for sensors that live in userland. Effectively, you have elevated all sensor implementations to root++ priviledge, even if they don't need any priviledge at all. I don't care much about who wrote the code or how trustworthy they are, that's a problem that can be fixed along the way. But I do care about taking away, by design, the choice of running at low priviledge from people who implement sensors. >> I repeat: The SoC interface is not the gateway to -current. > >It provides an idea in what people are interested in. Sure, lets list "Peace in the middle-east" on there, I'm sure people are interested :-) "People", whoever they are, are interested in anything that sounds fancy or flashy, but that doesn't mean that they can or will actually use it for anything if somebody produce it, and it certainly gives no guarantee that you will not shoot yourself in the foot along the way if you do so. People was very interested in UFS soft-updates and snapshots, but if we had paid more attention to what it did to the buf subsystem, we would probably have been a lot more cautious. ZFS generates a lot of buzz, and similar concerns can, has been and should be raised about that. (My answer to that on is to turn buf into a library function, so that each filesystem gets to screw only itself up). >And several >committers here in the thread also showed interest in this framework >(maybe not in the current implementation, but at least in the idea >behind it). Right, but if we didn't object, you had saddled us with this implementation, without any actual discussion about what exactly the idea behind it was and if that was the right idea for us. >Just because you do not see how such a framework can be >useful to you (so far I have the impression from your mails, that you >object to the idea of this framework), I *can* see why and how such a framework can be useful, that's why I'm objecting to this half-baked attempt at it. >> Ten years ago when we didn't have P4 and the _extensive_ infrastructure >> for making it easy for people to work out of the tree, we had to do >> stuff like that, but there is no excuse for it today. > >Nobody is perfect. There will always be some bugs when something is >committed to -current. Bugs, yes, and we have means to deal with them. But we should try much harder to avoid half-baked concepts and wrong architecture, because that is 10 times harder to fix than a plain bug is. >You don't talk about obvious problems here. >There's no destabilized system, there are no panics. You talk about >not using an underdocumented API and not using a generic framework for >creating tasks [...] Yes, it does appear to me that we are not on the same level of abstraction. I am indeed not talking about how many compiler warnings or style(9) infractions this code has. I'm talking about: - if it actually solves a problem for us that we have. - if if should solve more problems than it does right now. - if it creates even more problems down the road. I'm talking about architecture, you're talking about code. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Tue Oct 16 17:53:00 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 09A7A16A419; Tue, 16 Oct 2007 17:53:00 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id D9A3313C459; Tue, 16 Oct 2007 17:52:59 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GHqx66065402; Tue, 16 Oct 2007 17:52:59 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GHqxRx065401; Tue, 16 Oct 2007 17:52:59 GMT (envelope-from marcel) Message-Id: <200710161752.l9GHqxRx065401@repoman.freebsd.org> From: Marcel Moolenaar Date: Tue, 16 Oct 2007 17:52:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ddb db_ps.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 17:53:00 -0000 marcel 2007-10-16 17:52:59 UTC FreeBSD src repository Modified files: sys/ddb db_ps.c Log: Print the stack bounds of the thread. Revision Changes Path 1.67 +2 -0 src/sys/ddb/db_ps.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 17:57:35 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4F89A16A419; Tue, 16 Oct 2007 17:57:35 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.freebsd.org (Postfix) with ESMTP id 1621C13C448; Tue, 16 Oct 2007 17:57:34 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (2rxe6fdavdm1p0hc@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.6/8.13.3) with ESMTP id l9GHvRpZ002549; Tue, 16 Oct 2007 10:57:27 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.6/8.13.3/Submit) id l9GHvQRu002548; Tue, 16 Oct 2007 10:57:26 -0700 (PDT) (envelope-from jmg) Date: Tue, 16 Oct 2007 10:57:26 -0700 From: John-Mark Gurney To: Alexander Leidinger Message-ID: <20071016175726.GS39759@funkthat.com> Mail-Followup-To: Alexander Leidinger , Poul-Henning Kamp , Wilko Bulte , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <20071015152408.10kvgtog6cooc4wc@webmail.leidinger.net> <48258.1192460507@critter.freebsd.dk> <20071015210909.1b6b693b@deskjail> <20071015202115.GP39759@funkthat.com> <20071016184047.8zh3fl90gksks40c@webmail.leidinger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071016184047.8zh3fl90gksks40c@webmail.leidinger.net> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (hydrogen.funkthat.com [127.0.0.1]); Tue, 16 Oct 2007 10:57:27 -0700 (PDT) Cc: Wilko Bulte , Poul-Henning Kamp , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 17:57:35 -0000 Alexander Leidinger wrote this message on Tue, Oct 16, 2007 at 18:40 +0200: > Quoting John-Mark Gurney (from Mon, 15 > Oct 2007 13:21:15 -0700): > > >Alexander Leidinger wrote this message on Mon, Oct 15, 2007 at 21:09 +0200: > >>> >I already told you last time > >>> >that the current way (access to the i2c or smbus) needs more access > >>> >rights than using the userland parts of the sensors framework. > >>> > >>> More rights than what exactly ? > >> > >>One popular userland temperature/voltage reading tool (as it supports a > >>lot of popular devices) is mbmon. It is currently a SUID root > >>application. It is like this as it accesses the smbus and/or ISA I/O > >>ports directly. If we forget the ISA I/O ports part, we could maybe > >>switch to a mbmon-user, but I don't really want to have such an user be > >>able to query every device on the smbus. > >> > >>systat and sysctl are not SUID/SGID and don't require some special > >>rights in /dev. I would say this is a big difference in favour of the > >>sensors framework. > > > >Did you completely ignore the discussion back in July? I didn't bring > >it up, because someone else did, but the simple solution is a socket > > Have you a pointer to it? I would like to analyze why I don't remember > to have seen this. Hmm.. Looks like no one specificly stated a socket, plenty people talked about userland, and a couple mentions of daemons.. You were so against doing any userland work that the discussion never got far enough to talk about design decisions and implementation... Rober Watson talking about using the SNMP daemon: http://docs.freebsd.org/cgi/getmsg.cgi?fetch=174429+0+/usr/local/www/db/text/2007/freebsd-arch/20070715.freebsd-arch phk talking about userland for MIB and kernel for transport: http://docs.freebsd.org/cgi/getmsg.cgi?fetch=170761+0+/usr/local/www/db/text/2007/freebsd-arch/20070715.freebsd-arch Doug Ambrisko talking about doing it both as a userland and a kernel interface: http://docs.freebsd.org/cgi/getmsg.cgi?fetch=53014+0+/usr/local/www/db/text/2007/freebsd-arch/20070715.freebsd-arch phk talking about why kernel is complicated and userland is better: http://docs.freebsd.org/cgi/getmsg.cgi?fetch=166332+0+/usr/local/www/db/text/2007/freebsd-arch/20070715.freebsd-arch > >like /var/run/log or /var/run/devd.pipe, that a userland daemon running > >as root that has access to ISA I/O and related resources... It's > >that simple... > > And the code doesn't exists. And when it is written, when will it be > bugfree enough? The sysctl way of exporting integer data already has a And code in the kernel is guaranteed to be bug free enough? I'd much rather have "bug free" code in the userland where the stability of the system isn't as greatly effected by the code than "bug free" code in the kernel... Also, I find writing bug free code much easier when done in userland as it's easier to go through the debug/recompile/test steps than the same for kernel code... You also forget that code doesn't get frozen in time... People will work on it in the future, and it will change... Can you guarantee that it will be bug free enough for the lifetime of the code? > good track record, and porting the existing lm sensor (from a project > which is known to take much care about security) was easier to get > right. The project also was not about the lm sensor (I don't go and > count the size for the small lm sensor now). The lm sensor was one > example of using it. I don't think objection to the lm sensor driver > should lead to removal of the framework itself. One possible reaction > could be to say that the lm sensor should move to ports. I've never talked about a specific sensor or anything...... I purely argued for the agregation of data to happen in userland and the kernel simply be a transport for the data to userland.... Maybe you should look at NUT: http://www.networkupstools.org/ It does a bit more than simply look at sensor readings, but it does do things like report voltage, temperature, and current battery charge... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-cvs-src@FreeBSD.ORG Tue Oct 16 18:11:25 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5CBC016A418; Tue, 16 Oct 2007 18:11:25 +0000 (UTC) (envelope-from jasone@freebsd.org) Received: from canonware.com (canonware.com [64.183.146.166]) by mx1.freebsd.org (Postfix) with ESMTP id 3DDCF13C474; Tue, 16 Oct 2007 18:11:24 +0000 (UTC) (envelope-from jasone@freebsd.org) Received: from [192.168.168.201] (canonware.com [64.183.146.166]) by canonware.com (Postfix) with ESMTP id 928B412989E; Tue, 16 Oct 2007 10:50:04 -0700 (PDT) Message-ID: <4714F750.9010804@freebsd.org> Date: Tue, 16 Oct 2007 10:39:28 -0700 From: Jason Evans User-Agent: Thunderbird 1.5.0.12 (X11/20070718) MIME-Version: 1.0 To: Kris Kennaway References: <200710160736.l9G7a3oI087966@repoman.freebsd.org> <471480AB.7090500@FreeBSD.org> In-Reply-To: <471480AB.7090500@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, David Xu , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libthr/thread thr_pspinlock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 18:11:25 -0000 Kris Kennaway wrote: > David Xu wrote: >> FreeBSD src repository >> >> Modified files: >> lib/libthr/thread thr_pspinlock.c Log: >> Reverse the logic of UP and SMP. >> Submitted by: jasone >> Revision Changes Path >> 1.6 +1 -1 src/lib/libthr/thread/thr_pspinlock.c > > Are there any common applications that use this? It's worth mentioning that this change, although correct, does not make a measurable performance difference for the tests I was running when I found the bug. It is possible that making the spinlocks adaptive would help, but I didn't look into this. (I was working on malloc performance enhancements that have turned out very nicely, but in the end I had to switch to hand-rolled "spin" mutexes that eventually convert to blocking, in order to avoid the possibility of unrecoverable priority inversion.) Jason From owner-cvs-src@FreeBSD.ORG Tue Oct 16 18:32:38 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5B04116A420; Tue, 16 Oct 2007 18:32:38 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 36FF413C474; Tue, 16 Oct 2007 18:32:38 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GIWcEL069357; Tue, 16 Oct 2007 18:32:38 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GIWcak069356; Tue, 16 Oct 2007 18:32:38 GMT (envelope-from cognet) Message-Id: <200710161832.l9GIWcak069356@repoman.freebsd.org> From: Olivier Houchard Date: Tue, 16 Oct 2007 18:32:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/mk bsd.cpu.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 18:32:38 -0000 cognet 2007-10-16 18:32:37 UTC FreeBSD src repository Modified files: share/mk bsd.cpu.mk Log: Backout rev 1.62, and revert to use -march=armv5te -D__XSCALE__ instead of -mcpu=xscale for XScale. gcc still has issues with -mcpu=xscale, and now crashes while building systat. Reported by: sam MFC After: 3 days Revision Changes Path 1.63 +3 -1 src/share/mk/bsd.cpu.mk From owner-cvs-src@FreeBSD.ORG Tue Oct 16 18:51:46 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C1B5016A417; Tue, 16 Oct 2007 18:51:46 +0000 (UTC) (envelope-from kris@FreeBSD.org) Received: from weak.local (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx1.freebsd.org (Postfix) with ESMTP id 7614F13C4B5; Tue, 16 Oct 2007 18:51:45 +0000 (UTC) (envelope-from kris@FreeBSD.org) Message-ID: <47150841.2080306@FreeBSD.org> Date: Tue, 16 Oct 2007 20:51:45 +0200 From: Kris Kennaway User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: Jason Evans References: <200710160736.l9G7a3oI087966@repoman.freebsd.org> <471480AB.7090500@FreeBSD.org> <4714F750.9010804@freebsd.org> In-Reply-To: <4714F750.9010804@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, David Xu , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libthr/thread thr_pspinlock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 18:51:46 -0000 Jason Evans wrote: > Kris Kennaway wrote: >> David Xu wrote: >>> FreeBSD src repository >>> >>> Modified files: >>> lib/libthr/thread thr_pspinlock.c Log: >>> Reverse the logic of UP and SMP. >>> Submitted by: jasone >>> Revision Changes Path >>> 1.6 +1 -1 src/lib/libthr/thread/thr_pspinlock.c >> >> Are there any common applications that use this? > > It's worth mentioning that this change, although correct, does not make > a measurable performance difference for the tests I was running when I > found the bug. It is possible that making the spinlocks adaptive would > help, but I didn't look into this. > > (I was working on malloc performance enhancements that have turned out > very nicely, but in the end I had to switch to hand-rolled "spin" > mutexes that eventually convert to blocking, in order to avoid the > possibility of unrecoverable priority inversion.) BTW I am looking at adding a non-portable (sort of) pthread mutex type that spins for a while when the lock is held, before blocking. This is sometimes good for performance when the pthread mutex is highly contended but held for short periods of time, and in fact Linux has such a mutex that is used by mysql with performance benefits. The real fix would be to make them adaptive in the same way as kernel mutexes (spin as long as the lock holder is running), but there is currently no easy way for userland to peer into the kernel to check the other thread's state. Kris From owner-cvs-src@FreeBSD.ORG Tue Oct 16 19:07:27 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9B52116A419; Tue, 16 Oct 2007 19:07:27 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6184A13C459; Tue, 16 Oct 2007 19:07:27 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GJ7R9W072512; Tue, 16 Oct 2007 19:07:27 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GJ7RQq072511; Tue, 16 Oct 2007 19:07:27 GMT (envelope-from sam) Message-Id: <200710161907.l9GJ7RQq072511@repoman.freebsd.org> From: Sam Leffler Date: Tue, 16 Oct 2007 19:07:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/dev/ath/ath_rate/sample sample.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 19:07:27 -0000 sam 2007-10-16 19:07:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/ath/ath_rate/sample sample.c Log: MFC 1.19: revert 1.18: the negotiated rate set may not match the hal rate tables, so using the hal's rateCodeToIndex array will produce wrong indices for the negotiated rate set Approved by: re (kensmith) Revision Changes Path 1.18.2.1 +34 -18 src/sys/dev/ath/ath_rate/sample/sample.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 19:17:49 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 17AE216A420; Tue, 16 Oct 2007 19:17:49 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0739B13C481; Tue, 16 Oct 2007 19:17:49 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GJHm3N073111; Tue, 16 Oct 2007 19:17:48 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GJHmSp073110; Tue, 16 Oct 2007 19:17:48 GMT (envelope-from marius) Message-Id: <200710161917.l9GJHmSp073110@repoman.freebsd.org> From: Marius Strobl Date: Tue, 16 Oct 2007 19:17:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/libexec/rtld-elf/sparc64 reloc.c src/sys/sparc64/sparc64 elf_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 19:17:49 -0000 marius 2007-10-16 19:17:48 UTC FreeBSD src repository Modified files: libexec/rtld-elf/sparc64 reloc.c sys/sparc64/sparc64 elf_machdep.c Log: - Fix the handling of R_SPARC_OLO10, which is a bit of a special case in the way we implement handling of relocations. As for the kernel part this fixes the loading of lots of modules, which failed to load due to unresolvable symbols when built after the GCC 4.2.0 import. This wasn't due to a change in GCC itself though but one of several changes in configuration done along the import. Specfically, HAVE_AS_REGISTER_PSEUDO_OP, which causes GCC to denote global registers used for scratch purposes and in turn GAS uses R_SPARC_OLO10 relocations for, is now defined. While at it replace some more ELF_R_TYPE which should have been ELF64_R_TYPE_ID but didn't cause problems so far. - Sync a sanity check between kernel and rtld(1) and change it to be maintenance free regarding the type used for the lookup table. - Sprinkle const on lookup tables. - Use __FBSDID. Reported and tested by: yongari MFC after: 5 days Revision Changes Path 1.16 +14 -9 src/libexec/rtld-elf/sparc64/reloc.c 1.24 +14 -8 src/sys/sparc64/sparc64/elf_machdep.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 19:25:27 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9A04316A46B; Tue, 16 Oct 2007 19:25:27 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 76C3E13C455; Tue, 16 Oct 2007 19:25:27 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GJPRcu073629; Tue, 16 Oct 2007 19:25:27 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GJPRFK073628; Tue, 16 Oct 2007 19:25:27 GMT (envelope-from sam) Message-Id: <200710161925.l9GJPRFK073628@repoman.freebsd.org> From: Sam Leffler Date: Tue, 16 Oct 2007 19:25:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern sched_ule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 19:25:27 -0000 sam 2007-10-16 19:25:27 UTC FreeBSD src repository Modified files: sys/kern sched_ule.c Log: ULE works fine on arm; allow it to be used Reviewed by: jeff, cognet, imp MFC after: 1 week Revision Changes Path 1.215 +1 -1 src/sys/kern/sched_ule.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 19:52:12 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 762DF16A41A; Tue, 16 Oct 2007 19:52:12 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 543B713C46E; Tue, 16 Oct 2007 19:52:12 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GJqCH7075177; Tue, 16 Oct 2007 19:52:12 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GJqCME075176; Tue, 16 Oct 2007 19:52:12 GMT (envelope-from cognet) Message-Id: <200710161952.l9GJqCME075176@repoman.freebsd.org> From: Olivier Houchard Date: Tue, 16 Oct 2007 19:52:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/arm/arm pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 19:52:12 -0000 cognet 2007-10-16 19:52:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/arm/arm pmap.c Log: MFC rev 1.78: revision 1.78 date: 2007/02/05 10:33:39; author: kevlo; state: Exp; lines: +0 -1 is unneeded. Revision Changes Path 1.36.2.6 +0 -1 src/sys/arm/arm/pmap.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 19:57:36 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B5C8616A46E; Tue, 16 Oct 2007 19:57:36 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9344A13C4C2; Tue, 16 Oct 2007 19:57:36 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GJvais075368; Tue, 16 Oct 2007 19:57:36 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GJvaFr075367; Tue, 16 Oct 2007 19:57:36 GMT (envelope-from cognet) Message-Id: <200710161957.l9GJvaFr075367@repoman.freebsd.org> From: Olivier Houchard Date: Tue, 16 Oct 2007 19:57:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/sys proc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 19:57:36 -0000 cognet 2007-10-16 19:57:36 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/sys proc.h Log: Make td_sqqueue explicitely signed, as we compare it with >= 0. On arm, char defaults to unsigned. Revision Changes Path 1.432.2.13 +1 -1 src/sys/sys/proc.h From owner-cvs-src@FreeBSD.ORG Tue Oct 16 19:58:41 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C7B8816A46B; Tue, 16 Oct 2007 19:58:41 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 7D32513C494; Tue, 16 Oct 2007 19:58:41 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l9GJwZYI075111; Tue, 16 Oct 2007 13:58:35 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <471517C8.9040505@samsco.org> Date: Tue, 16 Oct 2007 13:58:00 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: Roman Divacky References: <200710122211.l9CMBM4J010733@repoman.freebsd.org> <20071016085414.GA27376@freebsd.org> In-Reply-To: <20071016085414.GA27376@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Tue, 16 Oct 2007 13:58:35 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_all.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 19:58:41 -0000 Roman Divacky wrote: > On Fri, Oct 12, 2007 at 10:11:22PM +0000, Scott Long wrote: >> scottl 2007-10-12 22:11:22 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/cam/scsi scsi_all.h >> Log: >> Add a bunch of definitions and structures to support newer drivers. > > - page_start = (void *)((u_int8_t *)&mode_header[1] + > + page_start = (void *)((u_int8_t *)&mode_header[2] + > scsi_2btoul(mode_header->blk_desc_len)); > > are you sure this belongs here? > It's a minor bug fix that got grouped with the larger change. Are you upset that it wasn't clearly documented in the commit message, or are you pointing out that it's incorrect, or what? Scott From owner-cvs-src@FreeBSD.ORG Tue Oct 16 19:59:51 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9878B16A419; Tue, 16 Oct 2007 19:59:51 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6E2CC13C469; Tue, 16 Oct 2007 19:59:51 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GJxpbX075445; Tue, 16 Oct 2007 19:59:51 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GJxpkJ075444; Tue, 16 Oct 2007 19:59:51 GMT (envelope-from cognet) Message-Id: <200710161959.l9GJxpkJ075444@repoman.freebsd.org> From: Olivier Houchard Date: Tue, 16 Oct 2007 19:59:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/arm/arm busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 19:59:51 -0000 cognet 2007-10-16 19:59:51 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/arm/arm busdma_machdep.c Log: MFC rev 1.32: date: 2007/06/07 21:51:09; author: cognet; state: Exp; lines: +3 -4 There's no nobounce_dmamap on arm. Revision Changes Path 1.22.2.4 +3 -4 src/sys/arm/arm/busdma_machdep.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 20:11:16 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3A02216A419; Tue, 16 Oct 2007 20:11:16 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247]) by mx1.freebsd.org (Postfix) with ESMTP id DF89813C480; Tue, 16 Oct 2007 20:11:15 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 11924669211; Tue, 16 Oct 2007 22:11:14 +0200 (CEST) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EoXjcV5w+zPY; Tue, 16 Oct 2007 22:11:13 +0200 (CEST) Received: from vlk.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 1B1F366920F; Tue, 16 Oct 2007 22:11:13 +0200 (CEST) Received: (from rdivacky@localhost) by vlk.vlakno.cz (8.13.8/8.13.8/Submit) id l9GKBCNG052816; Tue, 16 Oct 2007 22:11:12 +0200 (CEST) (envelope-from rdivacky) Date: Tue, 16 Oct 2007 22:11:12 +0200 From: Roman Divacky To: Scott Long Message-ID: <20071016201112.GA52731@freebsd.org> References: <200710122211.l9CMBM4J010733@repoman.freebsd.org> <20071016085414.GA27376@freebsd.org> <471517C8.9040505@samsco.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <471517C8.9040505@samsco.org> User-Agent: Mutt/1.4.2.3i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_all.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 20:11:16 -0000 On Tue, Oct 16, 2007 at 01:58:00PM -0600, Scott Long wrote: > Roman Divacky wrote: > >On Fri, Oct 12, 2007 at 10:11:22PM +0000, Scott Long wrote: > >>scottl 2007-10-12 22:11:22 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/cam/scsi scsi_all.h > >> Log: > >> Add a bunch of definitions and structures to support newer drivers. > > > >- page_start = (void *)((u_int8_t *)&mode_header[1] + > >+ page_start = (void *)((u_int8_t *)&mode_header[2] + > > scsi_2btoul(mode_header->blk_desc_len)); > > > >are you sure this belongs here? > > > > It's a minor bug fix that got grouped with the larger change. Are you > upset that it wasn't clearly documented in the commit message, or are > you pointing out that it's incorrect, or what? It was not documented in the commit message so I thought you might have commited something by mistake... From owner-cvs-src@FreeBSD.ORG Tue Oct 16 20:40:05 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 78FC716A418; Tue, 16 Oct 2007 20:40:05 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 57DDA13C467; Tue, 16 Oct 2007 20:40:05 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GKe52u078696; Tue, 16 Oct 2007 20:40:05 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GKe5uI078695; Tue, 16 Oct 2007 20:40:05 GMT (envelope-from cognet) Message-Id: <200710162040.l9GKe5uI078695@repoman.freebsd.org> From: Olivier Houchard Date: Tue, 16 Oct 2007 20:40:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/arm pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 20:40:05 -0000 cognet 2007-10-16 20:40:04 UTC FreeBSD src repository Modified files: sys/arm/arm pmap.c Log: Use the direct mapping, if available, for pmap_zero_page_xscale() as well. Revision Changes Path 1.87 +15 -0 src/sys/arm/arm/pmap.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 21:10:27 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9DDF916A468; Tue, 16 Oct 2007 21:10:27 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 793BE13C459; Tue, 16 Oct 2007 21:10:27 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GLARQY090169; Tue, 16 Oct 2007 21:10:27 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GLARgx090168; Tue, 16 Oct 2007 21:10:27 GMT (envelope-from cognet) Message-Id: <200710162110.l9GLARgx090168@repoman.freebsd.org> From: Olivier Houchard Date: Tue, 16 Oct 2007 21:10:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern kern_thread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 21:10:27 -0000 cognet 2007-10-16 21:10:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern kern_thread.c Log: Use 16 - 1 instead of 16 as the align argument of uma_zcreate(), as it's what is expected. Revision Changes Path 1.216.2.8 +3 -2 src/sys/kern/kern_thread.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 21:14:00 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 85D8F16A41B; Tue, 16 Oct 2007 21:14:00 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6540213C455; Tue, 16 Oct 2007 21:14:00 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GLE0ex090547; Tue, 16 Oct 2007 21:14:00 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GLE0LK090546; Tue, 16 Oct 2007 21:14:00 GMT (envelope-from cognet) Message-Id: <200710162114.l9GLE0LK090546@repoman.freebsd.org> From: Olivier Houchard Date: Tue, 16 Oct 2007 21:14:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/arm/arm busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 21:14:00 -0000 cognet 2007-10-16 21:14:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/arm/arm busdma_machdep.c Log: MFC rev 1.33/ date: 2007/06/10 12:33:01; author: cognet; state: Exp; lines: +2 -1 Initialize the dma tag's bounce_zone to NULL if we didn't allocate it. Revision Changes Path 1.22.2.5 +2 -1 src/sys/arm/arm/busdma_machdep.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 21:14:24 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D75ED16A417; Tue, 16 Oct 2007 21:14:24 +0000 (UTC) (envelope-from wilko@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B7B7113C457; Tue, 16 Oct 2007 21:14:24 +0000 (UTC) (envelope-from wilko@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GLEOIX090579; Tue, 16 Oct 2007 21:14:24 GMT (envelope-from wilko@repoman.freebsd.org) Received: (from wilko@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GLEOJ7090578; Tue, 16 Oct 2007 21:14:24 GMT (envelope-from wilko) Message-Id: <200710162114.l9GLEOJ7090578@repoman.freebsd.org> From: Wilko Bulte Date: Tue, 16 Oct 2007 21:14:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: CVSROOT access X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 21:14:24 -0000 wilko 2007-10-16 21:14:24 UTC FreeBSD src repository Modified files: . access Log: travelling, reduce email volume Approved by: core Revision Changes Path 1.839 +1 -1 CVSROOT/access From owner-cvs-src@FreeBSD.ORG Tue Oct 16 21:24:44 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E82CB16A420; Tue, 16 Oct 2007 21:24:44 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DD48213C49D; Tue, 16 Oct 2007 21:24:44 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GLOiFX091255; Tue, 16 Oct 2007 21:24:44 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GLOif5091254; Tue, 16 Oct 2007 21:24:44 GMT (envelope-from cognet) Message-Id: <200710162124.l9GLOif5091254@repoman.freebsd.org> From: Olivier Houchard Date: Tue, 16 Oct 2007 21:24:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/arm/arm mem.c pmap.c vm_machdep.c src/sys/arm/include pmap.h sf_buf.h vmparam.h src/sys/arm/xscale/i80321 iq31244_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 21:24:45 -0000 cognet 2007-10-16 21:24:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/arm/arm mem.c pmap.c vm_machdep.c sys/arm/include pmap.h sf_buf.h vmparam.h sys/arm/xscale/i80321 iq31244_machdep.c Log: MFC the reimplementation of ARM_USE_SMALL_ALLOC. Revision Changes Path 1.1.2.2 +3 -7 src/sys/arm/arm/mem.c 1.36.2.7 +30 -4 src/sys/arm/arm/pmap.c 1.17.2.3 +139 -110 src/sys/arm/arm/vm_machdep.c 1.10.2.2 +4 -1 src/sys/arm/include/pmap.h 1.1.2.1 +26 -1 src/sys/arm/include/sf_buf.h 1.5.2.1 +7 -0 src/sys/arm/include/vmparam.h 1.13.2.1 +10 -3 src/sys/arm/xscale/i80321/iq31244_machdep.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 21:27:50 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EEA8416A4A6; Tue, 16 Oct 2007 21:27:50 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 4669513C48A; Tue, 16 Oct 2007 21:27:50 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 214735002-1834499 for multiple; Tue, 16 Oct 2007 17:29:48 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l9GLRaPn095469; Tue, 16 Oct 2007 17:27:39 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Olivier Houchard Date: Tue, 16 Oct 2007 16:37:36 -0400 User-Agent: KMail/1.9.6 References: <200710161957.l9GJvaFr075367@repoman.freebsd.org> In-Reply-To: <200710161957.l9GJvaFr075367@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200710161637.36950.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 16 Oct 2007 17:27:40 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4540/Sat Oct 13 21:43:55 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys proc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 21:27:51 -0000 On Tuesday 16 October 2007 03:57:36 pm Olivier Houchard wrote: > cognet 2007-10-16 19:57:36 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/sys proc.h > Log: > Make td_sqqueue explicitely signed, as we compare it with >= 0. On arm, > char defaults to unsigned. It probably should really be unsigned like td_tsqueue (serves the same purpose) FWIW, however it is currently an 'int' in HEAD. Probably changing td_sqqueue to u_char in HEAD, 7.x and 6.x would be the best fix. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Tue Oct 16 21:27:54 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7270916A417; Tue, 16 Oct 2007 21:27:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id CEB3813C461; Tue, 16 Oct 2007 21:27:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 214735023-1834499 for multiple; Tue, 16 Oct 2007 17:29:54 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l9GLRaPp095469; Tue, 16 Oct 2007 17:27:46 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Alexander Leidinger Date: Tue, 16 Oct 2007 17:26:31 -0400 User-Agent: KMail/1.9.6 References: <1947.1192477927@critter.freebsd.dk> <20071016183311.lu97hbwzggsk4ow4@webmail.leidinger.net> In-Reply-To: <20071016183311.lu97hbwzggsk4ow4@webmail.leidinger.net> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200710161726.32718.jhb@freebsd.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 16 Oct 2007 17:27:46 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4540/Sat Oct 13 21:43:55 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Wilko Bulte , Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 21:27:54 -0000 On Tuesday 16 October 2007 12:33:11 pm Alexander Leidinger wrote: > Constantine asked for review several times on -current. He got some > reviews several times for commits to perforce. He incorporated > suggestions from those reviews, or explained why it is like it is and > why he can not switch (with no replies with suggestions how to solve > the problems he sees with the suggestions). Now you come and ask why > nobody pointed out some flaws before (without telling us which > technical flaws you talk about). At least from my point of view this is not quite accurate as pretty much all my feedback to the p4 commits was ignored with basically "Well, I don't like doing it that way". Specifically, with regards to creating dynamic sysctl trees, Constantine feels that sysctl_add_oid(9) is a hack rather than recognizing that this is a feature of FreeBSD's sysctl system despite repeated e-mails on the subject. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Tue Oct 16 21:28:02 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A9B1316A4CE; Tue, 16 Oct 2007 21:27:59 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 01EFD13C465; Tue, 16 Oct 2007 21:27:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 214735010-1834499 for multiple; Tue, 16 Oct 2007 17:29:51 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l9GLRaPo095469; Tue, 16 Oct 2007 17:27:42 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: "Constantine A. Murenin" Date: Tue, 16 Oct 2007 17:01:58 -0400 User-Agent: KMail/1.9.6 References: In-Reply-To: MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200710161702.00008.jhb@freebsd.org> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 16 Oct 2007 17:27:42 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4540/Sat Oct 13 21:43:55 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Scott Long , src-committers@FreeBSD.org, Alexander Leidinger , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, "Constantine A. Murenin" , Poul-Henning Kamp , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 21:28:02 -0000 On Monday 15 October 2007 10:57:48 pm Constantine A. Murenin wrote: > On 15/10/2007, John Baldwin wrote: > > On Monday 15 October 2007 09:43:21 am Alexander Leidinger wrote: > > > Quoting Scott Long (from Mon, 15 Oct 2007 > > 01:47:59 -0600): > > > > > > > Alexander Leidinger wrote: > > > >> Quoting Poul-Henning Kamp (from Sun, 14 Oct > > > >> 2007 17:54:21 +0000): > > > > > > >>> listen to the various mumblings about putting RAID-controller status > > > >>> under sensors framework. > > > >> > > > >> What's wrong with this? Currently each RAID driver has to come up > > > >> with his own way of displaying the RAID status. It's like saying > > > >> that each network driver has to implement/display the stuff you can > > > >> see with ifconfig in its own way, instead of using the proper > > > >> network driver interface for this. > > > >> > > > > > > > > For the love of God, please don't use RAID as an example to support your > > > > argument for the sensord framework. Representing RAID state is several > > > > orders of magnitude more involved than representing network state. > > > > There are also landmines in the OpenBSD bits of RAID support that are > > > > best left out of FreeBSD, unless you like alienating vendors and risking > > > > legal action. Leave it alone. Please. I don't care what you do with > > > > lmsensors or cpu power settings or whatever. Leave RAID out of it. > > > > > > Talking about RAID status is not talking about alienating vendors. I > > > don't talk about alienating vendors and I don't intent to do. You may > > > not be able to display a full blown RAID status with the sensors > > > framework, but it allows for a generic "wors/works not" or > > > "OK/degraded" status display in drivers we have the source for. This > > > is enough for status monitoring (e.g., nagios). > > > > As I mentioned in the thread on arch@ where people brought up objections that > > were apparently completely ignored, this is far from useful for RAID > > monitoring. For example, if my RAID is down, which disk do I need to > > replace? Again, all this was covered earlier and (apparently) ignored. > > Also, what strikes me as odd is that I didn't see this patch posted again for > > review this time around before it was committed. > > This has been addressed back in July. You'd use bioctl to see which > exact disc needs to be replaced. Sensorsd is intended for an initial > alert about something being wrong. In July you actually said you weren't sure about bioctl(8). :) But also, this model really isn't very sufficient since it doesn't handle things like drives going away, etc. You really need to maintain a decent amount of state to keep all that, and this is far easier done in userland rather than in the kernel. However, you can choose to ignore real-world experience if you choose. Basically, by having so little data in hw.sensors if I had to write a RAID monitoring daemon I would just not use hw.sensors since it's easier for me to figure out the simple status myself based on the other state I already have to track (unless you write an event-driven daemon based on messages posted by the firmware in which case again you wouldn't use hw.sensors for that either). -- John Baldwin From owner-cvs-src@FreeBSD.ORG Tue Oct 16 21:31:16 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9B44516A417; Tue, 16 Oct 2007 21:31:16 +0000 (UTC) (envelope-from doginou@dong.ci0.org) Received: from dong.ci0.org (dong.ci0.org [IPv6:2001:7a8:2066:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id B13E513C45A; Tue, 16 Oct 2007 21:31:15 +0000 (UTC) (envelope-from doginou@dong.ci0.org) Received: from dong.ci0.org (localhost.ci0.org [127.0.0.1]) by dong.ci0.org (8.13.8/8.13.8) with ESMTP id l9GMJ4kj075199; Wed, 17 Oct 2007 00:19:04 +0200 (CEST) (envelope-from doginou@dong.ci0.org) Received: (from doginou@localhost) by dong.ci0.org (8.14.1/8.13.8/Submit) id l9GMJ31R075198; Wed, 17 Oct 2007 00:19:04 +0200 (CEST) (envelope-from doginou) Date: Wed, 17 Oct 2007 00:19:03 +0200 From: Olivier Houchard To: John Baldwin Message-ID: <20071016221903.GA75176@ci0.org> References: <200710161957.l9GJvaFr075367@repoman.freebsd.org> <200710161637.36950.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200710161637.36950.jhb@freebsd.org> User-Agent: Mutt/1.4.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys proc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 21:31:16 -0000 On Tue, Oct 16, 2007 at 04:37:36PM -0400, John Baldwin wrote: > On Tuesday 16 October 2007 03:57:36 pm Olivier Houchard wrote: > > cognet 2007-10-16 19:57:36 UTC > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_6) > > sys/sys proc.h > > Log: > > Make td_sqqueue explicitely signed, as we compare it with >= 0. On arm, > > char defaults to unsigned. > > It probably should really be unsigned like td_tsqueue (serves the same > purpose) FWIW, however it is currently an 'int' in HEAD. > > Probably changing td_sqqueue to u_char in HEAD, 7.x and 6.x would be the best > fix. I didn't investigate much. I saw it was an int on -CURRENT, and this test : MPASS(td->td_sqqueue < NR_SLEEPQS && td->td_sqqueue >= 0); If td_squeue can be unsigned, the test is wrong. Regards, Olivier From owner-cvs-src@FreeBSD.ORG Tue Oct 16 21:32:20 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1C6DD16A417; Tue, 16 Oct 2007 21:32:20 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id F09FB13C468; Tue, 16 Oct 2007 21:32:19 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GLWJN9091701; Tue, 16 Oct 2007 21:32:19 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9GLWJJB091700; Tue, 16 Oct 2007 21:32:19 GMT (envelope-from cognet) Message-Id: <200710162132.l9GLWJJB091700@repoman.freebsd.org> From: Olivier Houchard Date: Tue, 16 Oct 2007 21:32:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern kern_thread.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 21:32:20 -0000 cognet 2007-10-16 21:32:19 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern kern_thread.c Log: Oops. Remove a debug printf. Spotted out by: delphij Revision Changes Path 1.216.2.9 +0 -1 src/sys/kern/kern_thread.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 21:52:53 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7EE7616A417 for ; Tue, 16 Oct 2007 21:52:53 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.231]) by mx1.freebsd.org (Postfix) with ESMTP id 3F8C213C474 for ; Tue, 16 Oct 2007 21:52:52 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: by wx-out-0506.google.com with SMTP id i29so1830184wxd for ; Tue, 16 Oct 2007 14:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; bh=15JYcXWDwp4z8n51NzXkt3wkfmrpFrsdZelBoITaWPA=; b=p/VQBSjxnhGpTOLDCNnYOB7vodgjG9sVgHbqkuJ2Tzih8RBtXFjN7cyLDnd4MRkQXZVd8OvEtAypRl//Lpyv91lR13BnFR2M71h76ypi0DSPgl1UWZ/V+1GQFroPQ/lZsN7RscWEZOFXMmq+bb27Hkfb6luOekzwO+i7N0wGWts= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; b=B+TP40Yuh8eDf2tj7KgVSou1QxanGbAJu1U6cv/j5jqPQA06SfbzhgBfjHwL+5jCfoGnvNU8Wf3Ovjwy0w1yB/mwWYrJ2VOFh+WttcNrWWHeNDS6sJjIMvQmRkjKX1J/jaeIsDEkhbY16oN5UB6Jksc7YGj7ioM2C2kvtCD4ORw= Received: by 10.90.93.6 with SMTP id q6mr11473604agb.1192571178119; Tue, 16 Oct 2007 14:46:18 -0700 (PDT) Received: by 10.90.78.10 with HTTP; Tue, 16 Oct 2007 14:46:18 -0700 (PDT) Message-ID: Date: Tue, 16 Oct 2007 17:46:18 -0400 From: "Constantine A. Murenin" To: "John Baldwin" MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Cc: src-committers@freebsd.org, Alexander Leidinger , cvs-src@freebsd.org, cvs-all@freebsd.org, "Constantine A. Murenin" , Poul-Henning Kamp , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 21:52:53 -0000 On 16/10/2007, John Baldwin wrote: > On Tuesday 16 October 2007 12:33:11 pm Alexander Leidinger wrote: > > Constantine asked for review several times on -current. He got some > > reviews several times for commits to perforce. He incorporated > > suggestions from those reviews, or explained why it is like it is and > > why he can not switch (with no replies with suggestions how to solve > > the problems he sees with the suggestions). Now you come and ask why > > nobody pointed out some flaws before (without telling us which > > technical flaws you talk about). > > At least from my point of view this is not quite accurate as pretty much all > my feedback to the p4 commits was ignored with basically "Well, I don't like > doing it that way". Specifically, with regards to creating dynamic sysctl > trees, Constantine feels that sysctl_add_oid(9) is a hack rather than > recognizing that this is a feature of FreeBSD's sysctl system despite > repeated e-mails on the subject. Dear John, I have specifically addressed this concern of yours just several weeks ago. Please see the following message, which you've never replied to: http://lists.freebsd.org/pipermail/p4-projects/2007-September/021121.html I've used the documented parts of the FreeBSD's sysctl interface to preserve 100% userland compatibility with OpenBSD. I cannot possibly see why you would have a problem with such an approach other than for the fact that OpenBSD is not a proprietary system with wealthy sponsors. Cheers, Constantine. From owner-cvs-src@FreeBSD.ORG Tue Oct 16 22:10:25 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5EDD916A420; Tue, 16 Oct 2007 22:10:25 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id B70C813C46B; Tue, 16 Oct 2007 22:10:24 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 214739373-1834499 for multiple; Tue, 16 Oct 2007 18:12:20 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l9GMABDM095756; Tue, 16 Oct 2007 18:10:11 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: "Constantine A. Murenin" Date: Tue, 16 Oct 2007 18:09:09 -0400 User-Agent: KMail/1.9.6 References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200710161809.10755.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 16 Oct 2007 18:10:12 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4542/Tue Oct 16 16:31:56 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: src-committers@freebsd.org, Alexander Leidinger , cvs-src@freebsd.org, cvs-all@freebsd.org, "Constantine A. Murenin" , Poul-Henning Kamp , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 22:10:25 -0000 On Tuesday 16 October 2007 05:46:18 pm Constantine A. Murenin wrote: > On 16/10/2007, John Baldwin wrote: > > On Tuesday 16 October 2007 12:33:11 pm Alexander Leidinger wrote: > > > Constantine asked for review several times on -current. He got some > > > reviews several times for commits to perforce. He incorporated > > > suggestions from those reviews, or explained why it is like it is and > > > why he can not switch (with no replies with suggestions how to solve > > > the problems he sees with the suggestions). Now you come and ask why > > > nobody pointed out some flaws before (without telling us which > > > technical flaws you talk about). > > > > At least from my point of view this is not quite accurate as pretty much all > > my feedback to the p4 commits was ignored with basically "Well, I don't like > > doing it that way". Specifically, with regards to creating dynamic sysctl > > trees, Constantine feels that sysctl_add_oid(9) is a hack rather than > > recognizing that this is a feature of FreeBSD's sysctl system despite > > repeated e-mails on the subject. > > Dear John, > > I have specifically addressed this concern of yours just several weeks ago. > > Please see the following message, which you've never replied to: > > http://lists.freebsd.org/pipermail/p4-projects/2007-September/021121.html > > I've used the documented parts of the FreeBSD's sysctl interface to > preserve 100% userland compatibility with OpenBSD. FreeBSD already provides an interface for creating dynamic sysctl trees that is simpler than having to simulate a pseudo-tree via the .oid_handler routine. In some cases (such as kern.proc) FreeBSD still uses a function handler rather than giving each process its own sysctl node. However, in other cases (generally more recent ones, and ones not as large/performance impacting) such as dev.* or the recent proposal to give ifnet's their own nodes under 'net.if' or the like, sysctl_add_oid(9) is used. As to the process of walking sysctl trees being undocumented, it is simply missing a wrapper routine ala sysctlbyname(3) and a manpage. You could easily provide one and thus provide a facility for enumerating many different things than having several one-off oid_handler routines to enumerate subtrees. However, it is not some "backdoor" hack interface anymore than sysctlbyname(3) is. They are both equally hackish or non-hackish (depending on your point of view). > I cannot possibly > see why you would have a problem with such an approach other than for > the fact that OpenBSD is not a proprietary system with wealthy > sponsors. I think I'll let that speak for itself. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Tue Oct 16 22:10:53 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 51B1716A417; Tue, 16 Oct 2007 22:10:53 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id C30C613C4AA; Tue, 16 Oct 2007 22:10:52 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 214739371-1834499 for multiple; Tue, 16 Oct 2007 18:12:17 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l9GMA8kZ095751; Tue, 16 Oct 2007 18:10:08 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Olivier Houchard Date: Tue, 16 Oct 2007 17:45:01 -0400 User-Agent: KMail/1.9.6 References: <200710161957.l9GJvaFr075367@repoman.freebsd.org> <200710161637.36950.jhb@freebsd.org> <20071016221903.GA75176@ci0.org> In-Reply-To: <20071016221903.GA75176@ci0.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200710161745.02448.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 16 Oct 2007 18:10:08 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4542/Tue Oct 16 16:31:56 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys proc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 22:10:53 -0000 On Tuesday 16 October 2007 06:19:03 pm Olivier Houchard wrote: > On Tue, Oct 16, 2007 at 04:37:36PM -0400, John Baldwin wrote: > > On Tuesday 16 October 2007 03:57:36 pm Olivier Houchard wrote: > > > cognet 2007-10-16 19:57:36 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: (Branch: RELENG_6) > > > sys/sys proc.h > > > Log: > > > Make td_sqqueue explicitely signed, as we compare it with >= 0. On arm, > > > char defaults to unsigned. > > > > It probably should really be unsigned like td_tsqueue (serves the same > > purpose) FWIW, however it is currently an 'int' in HEAD. > > > > Probably changing td_sqqueue to u_char in HEAD, 7.x and 6.x would be the best > > fix. > > I didn't investigate much. I saw it was an int on -CURRENT, and this test : > MPASS(td->td_sqqueue < NR_SLEEPQS && td->td_sqqueue >= 0); > If td_squeue can be unsigned, the test is wrong. Yeah, it might be. It's meant to be an array index, so negative values really are meaningless. I'll fix it in HEAD if I get some time. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Tue Oct 16 22:21:06 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CBB1A16A417; Tue, 16 Oct 2007 22:21:06 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 5FC4F13C459; Tue, 16 Oct 2007 22:21:06 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 1D1301A4D7C; Tue, 16 Oct 2007 15:21:06 -0700 (PDT) Date: Tue, 16 Oct 2007 15:21:06 -0700 From: Alfred Perlstein To: Kris Kennaway Message-ID: <20071016222106.GF31826@elvis.mu.org> References: <200710160736.l9G7a3oI087966@repoman.freebsd.org> <471480AB.7090500@FreeBSD.org> <4714F750.9010804@freebsd.org> <47150841.2080306@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47150841.2080306@FreeBSD.org> User-Agent: Mutt/1.4.2.3i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Jason Evans , cvs-all@FreeBSD.org, David Xu Subject: Re: cvs commit: src/lib/libthr/thread thr_pspinlock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 22:21:06 -0000 * Kris Kennaway [071016 11:51] wrote: > Jason Evans wrote: > >Kris Kennaway wrote: > >>David Xu wrote: > >>> FreeBSD src repository > >>> > >>> Modified files: > >>> lib/libthr/thread thr_pspinlock.c Log: > >>> Reverse the logic of UP and SMP. > >>> Submitted by: jasone > >>> Revision Changes Path > >>> 1.6 +1 -1 src/lib/libthr/thread/thr_pspinlock.c > >> > >>Are there any common applications that use this? > > > >It's worth mentioning that this change, although correct, does not make > >a measurable performance difference for the tests I was running when I > >found the bug. It is possible that making the spinlocks adaptive would > >help, but I didn't look into this. > > > >(I was working on malloc performance enhancements that have turned out > >very nicely, but in the end I had to switch to hand-rolled "spin" > >mutexes that eventually convert to blocking, in order to avoid the > >possibility of unrecoverable priority inversion.) > > BTW I am looking at adding a non-portable (sort of) pthread mutex type > that spins for a while when the lock is held, before blocking. This is > sometimes good for performance when the pthread mutex is highly > contended but held for short periods of time, and in fact Linux has such > a mutex that is used by mysql with performance benefits. > > The real fix would be to make them adaptive in the same way as kernel > mutexes (spin as long as the lock holder is running), but there is > currently no easy way for userland to peer into the kernel to check the > other thread's state. Soon.... :D -- - Alfred Perlstein From owner-cvs-src@FreeBSD.ORG Tue Oct 16 22:47:20 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E8C716A421; Tue, 16 Oct 2007 22:47:20 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from mojo.ru (mojo.ru [84.252.152.63]) by mx1.freebsd.org (Postfix) with ESMTP id DB4B813C45A; Tue, 16 Oct 2007 22:47:19 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from [192.168.0.16] (nc-76-6-108-199.dhcp.embarqhsd.net [76.6.108.199]) (authenticated bits=0) by mojo.ru (8.12.11.20060308/8.12.10) with ESMTP id l9GMlGlq022515 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 17 Oct 2007 02:47:18 +0400 Message-ID: <47153F62.1080709@FreeBSD.org> Date: Tue, 16 Oct 2007 18:46:58 -0400 From: "Constantine A. Murenin" Organization: Google Summer of Code 2007 Student @ The FreeBSD Project User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.5) Gecko/20041217 X-Accept-Language: en-gb, en-gb-oed, en, en-us, ru, ru-ru, ru-su MIME-Version: 1.0 To: John Baldwin References: <200710161809.10755.jhb@freebsd.org> In-Reply-To: <200710161809.10755.jhb@freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: src-committers@FreeBSD.org, Alexander Leidinger , cvs-src@FreeBSD.org, Poul-Henning Kamp , cvs-all@FreeBSD.org, "Constantine A. Murenin" , "Constantine A. Murenin" , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 22:47:20 -0000 On 16/10/2007 18:09, John Baldwin wrote: > On Tuesday 16 October 2007 05:46:18 pm Constantine A. Murenin wrote: > >>On 16/10/2007, John Baldwin wrote: >> >>>On Tuesday 16 October 2007 12:33:11 pm Alexander Leidinger wrote: >>> >>>>Constantine asked for review several times on -current. He got some >>>>reviews several times for commits to perforce. He incorporated >>>>suggestions from those reviews, or explained why it is like it is and >>>>why he can not switch (with no replies with suggestions how to solve >>>>the problems he sees with the suggestions). Now you come and ask why >>>>nobody pointed out some flaws before (without telling us which >>>>technical flaws you talk about). >>> >>>At least from my point of view this is not quite accurate as pretty much > > all > >>>my feedback to the p4 commits was ignored with basically "Well, I don't > > like > >>>doing it that way". Specifically, with regards to creating dynamic sysctl >>>trees, Constantine feels that sysctl_add_oid(9) is a hack rather than >>>recognizing that this is a feature of FreeBSD's sysctl system despite >>>repeated e-mails on the subject. >> >>Dear John, >> >>I have specifically addressed this concern of yours just several weeks ago. >> >>Please see the following message, which you've never replied to: >> >>http://lists.freebsd.org/pipermail/p4-projects/2007-September/021121.html >> >>I've used the documented parts of the FreeBSD's sysctl interface to >>preserve 100% userland compatibility with OpenBSD. > > > FreeBSD already provides an interface for creating dynamic sysctl trees that > is simpler than having to simulate a pseudo-tree via the .oid_handler > routine. In some cases (such as kern.proc) FreeBSD still uses a function > handler rather than giving each process its own sysctl node. However, in > other cases (generally more recent ones, and ones not as large/performance > impacting) such as dev.* or the recent proposal to give ifnet's their own > nodes under 'net.if' or the like, sysctl_add_oid(9) is used. Which one is simpler is questionable. Take one more look at the number of different macros that are available in the sysctl(9) and friends, and then compare with four functions of the sensors framework: * sensor_attach(9) to attach a sensor to a sensordev tree * sensordev_install(9) to register the sensordev tree with sysctl(9) and the same with the "de" prefix sensordev_install(9) acts similarly to the sysctl(9) ctx concept, but is geared towards the sensors approach If you want to make sure you don't attract any new contributors, then certainly the bunch of the sysctl(9) macros are simpler. ;) > As to the process of walking sysctl trees being undocumented, it is simply > missing a wrapper routine ala sysctlbyname(3) and a manpage. You could > easily provide one and thus provide a facility for enumerating many different > things than having several one-off oid_handler routines to enumerate > subtrees. However, it is not some "backdoor" hack interface anymore than > sysctlbyname(3) is. They are both equally hackish or non-hackish (depending > on your point of view). This interface is about having a special tree for the hardware sensors, with special rules regarding the namespace. What you suggest is that I try to abandon this, but then why do you need this framework to start with? Cheers, Constantine. From owner-cvs-src@FreeBSD.ORG Tue Oct 16 22:58:23 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8230F16A41B; Tue, 16 Oct 2007 22:58:23 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from mojo.ru (mojo.ru [84.252.152.63]) by mx1.freebsd.org (Postfix) with ESMTP id BBB6C13C46E; Tue, 16 Oct 2007 22:58:22 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from [192.168.0.16] (nc-76-6-108-199.dhcp.embarqhsd.net [76.6.108.199]) (authenticated bits=0) by mojo.ru (8.12.11.20060308/8.12.10) with ESMTP id l9GMEqRw008168 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 17 Oct 2007 02:14:56 +0400 Message-ID: <471537CA.9080807@FreeBSD.org> Date: Tue, 16 Oct 2007 18:14:34 -0400 From: "Constantine A. Murenin" Organization: Google Summer of Code 2007 Student @ The FreeBSD Project User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.5) Gecko/20041217 X-Accept-Language: en-gb, en-gb-oed, en, en-us, ru, ru-ru, ru-su MIME-Version: 1.0 To: John Baldwin References: <200710161702.00008.jhb@freebsd.org> In-Reply-To: <200710161702.00008.jhb@freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Scott Long , src-committers@FreeBSD.org, Alexander Leidinger , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, "Constantine A. Murenin" , Poul-Henning Kamp , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 22:58:23 -0000 On 16/10/2007 17:01, John Baldwin wrote: > On Monday 15 October 2007 10:57:48 pm Constantine A. Murenin wrote: > >>On 15/10/2007, John Baldwin wrote: >> >>>On Monday 15 October 2007 09:43:21 am Alexander Leidinger wrote: >>> >>>>Quoting Scott Long (from Mon, 15 Oct 2007 >>> >>>01:47:59 -0600): >>> >>>>>Alexander Leidinger wrote: >>>>> >>>>>>Quoting Poul-Henning Kamp (from Sun, 14 Oct >>>>>>2007 17:54:21 +0000): >>>> >>>>>>>listen to the various mumblings about putting RAID-controller status >>>>>>>under sensors framework. >>>>>> >>>>>>What's wrong with this? Currently each RAID driver has to come up >>>>>>with his own way of displaying the RAID status. It's like saying >>>>>>that each network driver has to implement/display the stuff you can >>>>>> see with ifconfig in its own way, instead of using the proper >>>>>>network driver interface for this. >>>>>> >>>>> >>>>>For the love of God, please don't use RAID as an example to support > > your > >>>>>argument for the sensord framework. Representing RAID state is > > several > >>>>>orders of magnitude more involved than representing network state. >>>>>There are also landmines in the OpenBSD bits of RAID support that are >>>>>best left out of FreeBSD, unless you like alienating vendors and > > risking > >>>>>legal action. Leave it alone. Please. I don't care what you do with >>>>>lmsensors or cpu power settings or whatever. Leave RAID out of it. >>>> >>>>Talking about RAID status is not talking about alienating vendors. I >>>>don't talk about alienating vendors and I don't intent to do. You may >>>>not be able to display a full blown RAID status with the sensors >>>>framework, but it allows for a generic "wors/works not" or >>>>"OK/degraded" status display in drivers we have the source for. This >>>>is enough for status monitoring (e.g., nagios). >>> >>>As I mentioned in the thread on arch@ where people brought up objections > > that > >>>were apparently completely ignored, this is far from useful for RAID >>>monitoring. For example, if my RAID is down, which disk do I need to >>>replace? Again, all this was covered earlier and (apparently) ignored. >>>Also, what strikes me as odd is that I didn't see this patch posted again > > for > >>>review this time around before it was committed. >> >>This has been addressed back in July. You'd use bioctl to see which >>exact disc needs to be replaced. Sensorsd is intended for an initial >>alert about something being wrong. > > > In July you actually said you weren't sure about bioctl(8). :) But also, this > model really isn't very sufficient since it doesn't handle things like drives > going away, etc. You really need to maintain a decent amount of state to > keep all that, and this is far easier done in userland rather than in the > kernel. However, you can choose to ignore real-world experience if you > choose. > > Basically, by having so little data in hw.sensors if I had to write a RAID > monitoring daemon I would just not use hw.sensors since it's easier for me to > figure out the simple status myself based on the other state I already have > to track (unless you write an event-driven daemon based on messages posted by > the firmware in which case again you wouldn't use hw.sensors for that either). There is no other daemon that you'd need, you'd simply use sensorsd for this. You could write a script that would be executed by sensorsd if a certain logical disc drive sensor changes state, and then this script would call the bio framework and give you additional details on why the state was changed. Actually, you can indeed write your own daemon that would do the same thing in one package. The sysctl(3) interface of the sensors framework specifically allows you to request only sensors of certain type. For example, see ntpd/sensors.c, where only timedelta sensors are being queried, and all other types of sensors are never ever looked at. [0] C. [0] http://www.openbsd.org/cgi-bin/cvsweb/src/usr.sbin/ntpd/sensors.c From owner-cvs-src@FreeBSD.ORG Tue Oct 16 22:59:08 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0992D16A418; Tue, 16 Oct 2007 22:59:08 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc3-cdif2-0-0-cust64.cdif.cable.ntl.com [81.106.128.65]) by mx1.freebsd.org (Postfix) with ESMTP id 6412213C4A6; Tue, 16 Oct 2007 22:59:07 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.68 (FreeBSD)) (envelope-from ) id 1IhvNS-000CDO-Hf; Tue, 16 Oct 2007 23:59:06 +0100 Date: Tue, 16 Oct 2007 23:59:06 +0100 From: Ceri Davies To: Stefan Esser Message-ID: <20071016225906.GK23043@submonkey.net> References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> <20071016102013.GE23043@submonkey.net> <4714F06B.7070702@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rmUrFcWP4LYae1gV" Content-Disposition: inline In-Reply-To: <4714F06B.7070702@FreeBSD.org> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.16 (2007-06-09) Sender: Ceri Davies Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 22:59:08 -0000 --rmUrFcWP4LYae1gV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 16, 2007 at 07:10:03PM +0200, Stefan Esser wrote: > Ceri Davies schrieb: > > On Mon, Oct 15, 2007 at 10:09:19PM +0000, Stefan Esser wrote: > >> se 2007-10-15 22:09:19 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> usr.bin/locate/locate updatedb.sh=20 > >> Log: > >> Make the updatedb script installed as /usr/libexec/locate.updatedb > >> inspect all local file systems, not only ufs and ext2fs. A number > >> of local file systems has been added over time, and at least zfs > >> has the potential to become a popular choice. Without this change > >> a ZFS root file system causes the script to ignore all file-systems > >> and leads to an empty locate db. (An alternative is to add all the > >> relevant file systems individually, which means that at least zfs, > >> xfs, ntfs, ntfs-3g, msdosfs should be added, probably more). > >=20 > > This now includes /dev, /dev/fd, /proc, /compat/linux/proc, CD-ROMs and= DVDs > > as well as duplicating everything in nullfs mounts, all of which are pr= obably > > undesirable -- well, they are undesirable to me; whether they are to > > others is the question ;-). >=20 > Ok, thank you for the information. I did not notice this in my tests. >=20 > I'm not sure what the "local" pseudo fs-type is meant to be used for. > Currently it appears to be identical to "not-remote" (which is what > the locate db update tries to avoid, due to high network load and > scan time). >=20 > I plan to fix this within the next 24 hours (if anybody thinks it needs > to be backed-out immediately, I'm willing to do this, but I'd rather > put in the correct fix instead. >=20 > Two possibilities: We could have another pseudo fs-type in find, which > selects "real" file systems (and skips devfs, procfs, fdescfs, nullfs > and probably more). Scanning of removable devices is dubious, too, > independently of their file system. By selecting "local" and "disk > based" file systems (which would omit not only the pseudo file-systems > and nullfs, but also cd9660 and udf), no specific file systems needed > to be put into the script (and find would have the knowledge). While userland can tell if a filesystem is pseudo or not, (see lsvfs), I'm not sure that we can reliably tell whether a device is removable or not (cf. my camera, USB key, iPod, etc.). > The second possibility is to extend the list in the update script. It > needs to contain at least: >=20 > ufs ext2fs zfs >=20 > and probably also: >=20 > xfs msdosfs ntfs ntfs-3g (?) >=20 > Did I forget any? >=20 > In fact, I'd rather enter "ufs ext2fs zfs xfs msdosfs ntfs" right now, > instead of relying on the pseudo-fs definition in find, now that I think > about it. I think that's probably the best idea too. Thanks for working on this! Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --rmUrFcWP4LYae1gV Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFHFUI6ocfcwTS3JF8RAkwUAJ9hB2kpFOEl3BsixB6dCvmeYPGw/gCfS9OO CoL6HbgflAq1PHDffAe2WZg= =RP07 -----END PGP SIGNATURE----- --rmUrFcWP4LYae1gV-- From owner-cvs-src@FreeBSD.ORG Tue Oct 16 23:20:51 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 05A5416A417 for ; Tue, 16 Oct 2007 23:20:51 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.227]) by mx1.freebsd.org (Postfix) with ESMTP id 6744813C467 for ; Tue, 16 Oct 2007 23:20:49 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: by wr-out-0506.google.com with SMTP id 70so141356wra for ; Tue, 16 Oct 2007 16:20:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; bh=Lp+vInpjvhWVC6KykDRVfrMw8KJ2I04FkUP+W6bJnhQ=; b=twV1HP3a1onlKRg+y2BDBTdwDDerEt1E20zJdki30f9vEAYknV2ji8TG87+qOgeCKwf6V26KD7AUDU2wAK41OHAp98ehHWfQt1QdBFyhoFUWBa8HDNymSgEdsqpbtv97qg8UZASjHWci+8j1YkjMQ2jolE5CiEiiaotTDeosJQg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; b=ANmxG5oflxPdmAEAGoTNqJVtr/Qk08Ja1++F700zHaKU6JZmgWuipMXWnClBba8m326qCKFzmtx7zmMroq4Sxq26LzuFPW/b6+GZXyx0vWYkEH8OM61fLFzPTuYz07B5gtsXLar7Q2iLiH/GKldaBFjJILWT3rXAzB0te/ZE/so= Received: by 10.90.105.19 with SMTP id d19mr11591820agc.1192576847832; Tue, 16 Oct 2007 16:20:47 -0700 (PDT) Received: by 10.90.78.10 with HTTP; Tue, 16 Oct 2007 16:20:47 -0700 (PDT) Message-ID: Date: Tue, 16 Oct 2007 19:20:47 -0400 From: "Constantine A. Murenin" To: "Alexander Leidinger" MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Cc: src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, "Constantine A. Murenin" , Poul-Henning Kamp , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 23:20:51 -0000 On 16/10/2007, Alexander Leidinger wrote: > Quoting Poul-Henning Kamp (from Mon, 15 Oct 2007 > 19:52:07 +0000): > > > In message <20071015210909.1b6b693b@deskjail>, Alexander Leidinger writes: > >> Quoting "Poul-Henning Kamp" (Mon, 15 Oct 2007 > >> 15:01:47 +0000): > > > >>> >And I responded that we need to have a way to export data from the > >>> >kernel to userland in an unified way. > >>> > >>> I can't seem to find the supposed requirement for unification here, > >> > >> You didn't comment on what I wrote about reducing the work of > >> reinventing a way to export the data we want to export again and again > >> and again and again... > > > > Yes, that is the abstract argument, but the very same argument can > > be made for every other single kind of entity which consumes or > > produces bytes, from fingerprint readers to 9-track tape stations. > > Why do we have a common linked list API? It's easy enough to do it > again and again and again... We have it because we don't want to do it > again and again... And with the sensors API we gain something similar. > Sure, we can do it with sysctls in every place. But with the sensors > API we reduce the code to write for such things like with the linked > lists API. > > > My beef with this code is that it unifies a lot of non-alike > > measurements and indications in a new, and pretty bogus IMO, api, > > but adding no value above a plain old sysctl while doing so. > > It adds meta-data which can be used in an automated way. This is done > with a consistent and documented API. Sure, we can do it with sysctls > by hand, but see above. > > >>> and in fact, it is exactly that a lot of crap gets bundled up > >>> under the wildcard term of "sensor" that I object to. > >> > >> Exporting temperature readings / voltage measurement, system status is > >> not crap. > > > > Actually it is, if it can be done as well (or better) from userland > > by exporting the underlying communications paths. > > See below for the mbmon example. And for some things we already had > the export of this via sysctl (temperature of Intel core processors), > the sensors API "just" groups this together so that people don't have > to hunt such info down, adds meta data to it, so that tools can do > some automation, and unifies the API to export this info from the > kernel. > > >> And when you write some monitoring probes in a large server > >> farm, you don't want to hunt down every interesting data value in a lot > >> of places. > > > > Ahh, so this brings me to the next problem with sensors. > > > > If by "monitoring" you mean "plot MRTG graphs", then I guess sensors > > could possibly make sense, although, I'd have to point out that all > > that can be done just as well from ports/sysutils/whatever. > > With elevated privileges for those tools. See below. > > > But if you're talking real world monitoring, then sensors are > > pointless, because there is no way to derive necessary machine > > readable contextual information, such as alarm limits, resolution, > > calibration constants, hysteresis, polling periods etc. > > Normally you configure this in the tools which do the monitoring, not > in the tools which acquire the data. I'm not talking about doing this > in the sensors framework, but I talk about to get rid of the need to > hunt down such information from everywhere. I makes it easier to write > monitoring probes. It is not supposed to make the monitoring itself > easier. > > > Or, for that matter, machine-readable information about what is > > actually being measured and where it is being measured and what it > > means. > > A human being still has to interprete the measurements. No doubts. But > with the framework you don't have to hunt down where to read the > sensor data, and how to name it. You can write a probe which takes > everything in the the sensors mib and let it produce names and values > for the probed things automatically. > > > There are frameworks for doing that sort of stuff in professional > > server hardware, but since OpenBSD doesn't support those, IPMI, > > ACPI etc, they have come up with this VAX-mentality junkheap instead. > > IPMI is intended to handle situations when the OS is not booted or the > system is not powered on. Yes, it allows some features when the OS is > booted too. Now... how much hardware out there supports IPMI, or > better... how much in production use doesn't use IPMI? I would say > quite a lot (we all know the managers, "do everything with no money at > all"). The sensors framework allows to monitor those systems in an > easy (because you don't need to invest that much work with the sensors > framework) way. Have you identified some parts in the sensors > framework which make it impossible to play together with IPMI? If yes, > would you please so kind and tell us what prevents them to play > together? Alexander, Your questions are very valid indeed. It is this kind of problem that the OpenBSD sensors framework is trying to solve. OpenBSD already has the ipmi(4) using the sensors framework, and it is simply impossible for the system administrator to not use IPMI on an OpenBSD machine -- all you have to do is type `sysctl hw.sensors` or `systat sensors`, and you'll see all the readings momentarily -- unlike in some other systems, the values are already cached within the framework. Some googling revealed a nice web-site with some sensor readings: http://monitor.cns.ualberta.ca/?details http://monitor.cns.ualberta.ca/?startcarp1.srv.ualberta.ca_sensors hw.sensors.ipmi0.temp0=18.00 degC (Temp), OK hw.sensors.ipmi0.temp1=50.00 degC (Temp), OK hw.sensors.ipmi0.temp2=25.00 degC (Ambient Temp), OK hw.sensors.ipmi0.fan0=10875 RPM (FAN MOD 1A RPM), OK hw.sensors.ipmi0.fan1=9675 RPM (FAN MOD 1C RPM), OK hw.sensors.ipmi0.fan2=10650 RPM (FAN MOD 1B RPM), OK hw.sensors.ipmi0.fan3=9525 RPM (FAN MOD 1D RPM), OK hw.sensors.ipmi0.fan4=11100 RPM (FAN MOD 2A RPM), OK hw.sensors.ipmi0.fan5=9600 RPM (FAN MOD 2C RPM), OK hw.sensors.ipmi0.fan6=10575 RPM (FAN MOD 2B RPM), OK hw.sensors.ipmi0.fan7=9600 RPM (FAN MOD 2D RPM), OK hw.sensors.ipmi0.indicator0=Off (Intrusion), OK > > Regarding ACPI... Nate (our ACPI committer) asked after the commit why > acpi_thermal was not modified to play together with the sensors > framework (the reason: ACPI was a little bit too much to do in the SoC > for Constantine, Nate agreed to work together (after some other work > in ACPI he wants to finish first) if desired (put on hold from the > sensors side until this discussion comes tp an conclusion), and also > suggested some improvements for the sensors framework). He didn't told > us about something in the framework, which prevents the use of it > together with ACPI. > > >>> >I already told you last time > >>> >that the current way (access to the i2c or smbus) needs more access > >>> >rights than using the userland parts of the sensors framework. > >>> > >>> More rights than what exactly ? > >> > >> One popular userland temperature/voltage reading tool (as it supports a > >> lot of popular devices) is mbmon. It is currently a SUID root > >> application. > > > > Let me get this straight, you're telling me: > > > > "I'm worried about this code running as root, so I'm putting > > it in the kernel instead." > > > > Can anybody here spot the logic flaw of this argument ? > > > > Anybody ? > > > > Right, I thought so. Lets pretend you didn't say that. > > You missed the point. In our architecture we can not do it without > executing some code with elevated privileges. What I suggested was to > replace SUID root code with unknown security heritage and potential > complete access to the machine (direct access to ISA I/O ports and the > smbus), not only with code (which runs with elevated privileges) from > a known security heritage (from people which strongly care about > security), but also with an access method which doesn't need any > elevated privileges at all. I assume you think that for example > expoting some predefined numbers with "sysctl hw.sensors >outout" is > not something we need to care that much about from a security point of > view. Feel free to tell me if I'm wrong with my assumption. I at least > feel safer to export an int over sysctl, than to run the SUID root > mbmon tool. Exactly, I'd also like to point out that the i2c sensors on OpenBSD are enabled by default and were tested on many systems. It is very well known that improper probing of the smbus may result in certain machines being no longer usable -- just checkout the Linux-based lm-sensors README.thinkpad file, regarding ThinkPads. This is something that the OpenBSD project has been very serious about, and a lot of work was put into making the i2c probing as safe as possible, whilst still providing necessary functionality. > There may be other ways to accomplish the same. Maybe a daemon which > runs with elevated privileges and just outputs the temperature/voltage > as a number to a tool which runs without elevated privileges and > collects the data. So far we don't have such a tool, and in the > beginning I'm not sure we can trust such a tool to the same extend as > we can trust sysctl. > > And this would only affect sensors like lm (which is not part of the > sensors framework, but uses the sensors framework to export it's data, > and was used as an example to show how the sensors framework can be > used). What about other such data which lives in subsystems we don't > want to let an userland application mess around with? I don't know if > we want to let an userland application give that much access to ACPI. > ACPI already exports some data with sysctl. ATM it does it by hand. > The sensors framework provides an unified API to not do everything by > hand anymore. > > >>> No, I have yet to see why we need this framework. > >> > >> Several committers which voted for this project in the soc webinterface > >> seem to think otherwise, else they wouldn't have voted for it. > > > > I repeat: The SoC interface is not the gateway to -current. > > It provides an idea in what people are interested in. And several > committers here in the thread also showed interest in this framework > (maybe not in the current implementation, but at least in the idea > behind it). Just because you do not see how such a framework can be > useful to you (so far I have the impression from your mails, that you > object to the idea of this framework), it doesn't mean other people > are not interested in it. So it is not a gateway for concrete > implementations into -current, but it shows what people are interested > in for -current. The current implementation of the sensors framework > may not use the best way of doing something in some places, but it is > not as bad as you give people the impression. In the mean time > Constantine had a look at the constructive critics we got so far, and > thinks that moving to the taskqueue API is not a bug problem. For the > newbus suggestion so far he asked for more information, as the man > pages didn't gave him enough input. As far as I know, the man pages of > newbus are known to be in a suboptimal shape. But as you seem to be > not interested in the idea of the sensors framework, one can have the > impression, that you are not interested to hear about improvements of > the implementation. > > >>> >> C) How it integrates into FreeBSD and for the places where > >>> >> it does not (newbus ?) why it doesn't. > >>> > > >> > >> We're discussing it right now. And I was willing to discuss this even > >> back when you talked about it the first time. > > > > It should have been dicussed and fixed before being committed to > > -current. Current is not where you start, it is where you end, these > > We where willing to listed to your concerns. You stopped talking about > them back then. > > > kind of things are not details to be hashed out in CVS. > > Constantine asked for review several times on -current. He got some > reviews several times for commits to perforce. He incorporated > suggestions from those reviews, or explained why it is like it is and > why he can not switch (with no replies with suggestions how to solve > the problems he sees with the suggestions). Now you come and ask why > nobody pointed out some flaws before (without telling us which > technical flaws you talk about). > > > Ten years ago when we didn't have P4 and the _extensive_ infrastructure > > for making it easy for people to work out of the tree, we had to do > > stuff like that, but there is no excuse for it today. I am not so certain about the extensive infrastructure argument. So far, many FreeBSD committers have greeted me with total ignorance in regards to the p4 infrastructure. I repeatedly asked if some of my fixes could be committed from perforce into the CVS tree, and provided links to the patches that were submitted into my perforce branch, only to have to deal with the fact that people cannot apply those patches to the tree, and simply do not know how to use the perforce. It also remains to be seen how regular users can test the stuff from the perforce repository. For the complete duration of this project, I am not aware of any single person that has ever used my perforce branch, although a lot of people have expressed interest in this project. > Nobody is perfect. There will always be some bugs when something is > committed to -current. You don't talk about obvious problems here. > There's no destabilized system, there are no panics. You talk about > not using an underdocumented API and not using a generic framework for > creating tasks (so basically we talk about doing something by hand > what can be done with less work by using an API... sounds like what > the sensors framework tries to do for some kinds of data export). > > Note: the commit of the code from the sensors project was done in 3 > steps on purpose, the sensors framework, 2 temperature/voltage chip > drivers as examples how to use the sensors framework (and the benefit > of getting rid of a SUID root application in the userland), and > converting the existing CPU temperature sysctl (for some specific > Intel CPUs) from doing a sysctl by hand to the sensors framework (as > an example how to convert an existing part to the sensors framework). > So far we mixed the discussion about various parts of this together > under the umbrella of "sensors framework", which is not ok. > > >>> >The code we have currently doesn't harm the system, [...] > >>> > >>> This is where I disagree: it does harm the system. > >>> > >>> It dumps a load of badly thought out code into our source tree, and > >>> that will effectively be in the way of any well thought out solution > >>> that might ever appear. > >>> > >>> This stuff should be backed out, and forced to live outside the tree > >>> until it satisfies our quality and architectural requirements. > >> > >> How does this compare to your attitude of bringing stuff into the tree > >> and letting other people fixup collateral damage in the past? But I > >> drift away from the topic... so back to the sensors framework. > > > > It does not compare, please answer the question instead of trying > > Which question? I don't see a question from you in the quoted part > above. And without mentioning the bad code, we can not proceed > discussing about it. The constructive responses so far don't give the > impression that there code is that bad as you suggest here. > > > to insult me, because you're no good at it. I have been insulted > > I don't try to insult you. > > >> To be able to address our quality and architectural requirements, we > >> need first to know which quality and architectural requirements are > >> violated by which part of the code in question. As you seem to have > >> identified them, would you please so kind and share your concrete > >> findings? > > > > Would you be so kind as to read the emails I've sent you ? Maybe > > this time expending some effort to understand what people tell you in > > them, rather than pretending they contained nothing ? > > So far I see from you that you are not interested in the idea of the > framework. And I see mails where people are interested in the idea of > the framework. And I see private mails which point out some > improvements. According specific quality problems, I haven't seen a > concrete mail from you, like saying "you use X, but this is should be > done with Y, see at place A how to do it better". I have seen such > mails from other people, but not from you. > > >>> Forcing it to stay out of -current, means that the motivational > >>> pressure is on the people who thing we badly need this featureset, > >>> and gives them reason to improve it. > >>> > >>> Leaving it in the tree, is the sure fire way for it to become an > >>> unmaintained lump of code that slowly rots away. > >> > >> You did a psycho-analysis of Constantine so that you are able to tell > >> that he doesn't fix the issues while he agreed to improve the framework? > > > > No, it's far worse. > > > > I have 15 years of experience with this kind of code being slammed > > into the tree in an unfinished and badly thought out shape. > > > > And I have wasted far more time cleaning it up afterwards, than you > > or constantine will have spent on FreeBSD five years from now. > > So would you please share your experience and tell us where parts are > wrong because of what reason and what kind of technique is better > suited to do it? So far I've only seen that you don't like the idea > itself and that you for this reason haven't looked at concrete problems. > > If someone reading this does not share this point of view, please, > tell me about it. So far I haven't got any mail to my similar question > in a previous mail, so please tell me about it if you think that I'm > wrong when I say that Poul gives the impression he doesn't like the > idea (while several other committers see benefit in it) and that it > seems that he didn't provided concrete pointers to problems in the > implementation. > > Bye, > Alexander. From owner-cvs-src@FreeBSD.ORG Tue Oct 16 23:22:25 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1186416A469 for ; Tue, 16 Oct 2007 23:22:25 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with SMTP id B21E313C49D for ; Tue, 16 Oct 2007 23:22:24 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 22486 invoked by uid 399); 16 Oct 2007 23:22:23 -0000 Received: from localhost (HELO slave.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTP; 16 Oct 2007 23:22:23 -0000 X-Originating-IP: 127.0.0.1 Date: Tue, 16 Oct 2007 16:22:20 -0700 (PDT) From: Doug Barton To: "Constantine A. Murenin" In-Reply-To: <47153F62.1080709@FreeBSD.org> Message-ID: References: <200710161809.10755.jhb@freebsd.org> <47153F62.1080709@FreeBSD.org> X-message-flag: Outlook -- Not just for spreading viruses anymore! X-OpenPGP-Key-ID: 0xD5B2F0FB Organization: http://www.FreeBSD.org/ MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, "Constantine A. Murenin" , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, John Baldwin Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 23:22:25 -0000 On Tue, 16 Oct 2007, Constantine A. Murenin wrote: > If you want to make sure you don't attract any new contributors, then > certainly the bunch of the sysctl(9) macros are simpler. ;) Constantine, Just like with any other project there is a balance here between innovation and tradition. You may feel that we are on the wrong side of that fence, but it doesn't change the fact that if you want your code accepted by FreeBSD you need to do it "the FreeBSD way." That said, there is still room for innovation, and new code (or new ideas) that provide significant added value are always welcome. Based on what I've read from people people who know a lot more about kernel interfaces than I do, it would seem to me that your approach does not meet that criteria. So continuing to argue, point fingers, and sling mud only serves to make you look bad, and doesn't serve to actually get anything done. It's already been suggested that we draw the curtain on this act of the play, and I would like to second that. If you want to ask for help, propose a way forward, or discuss something constructive about this code, I suggest you take it to freebsd-arch@. Otherwise, I think we could all use a rest. Doug -- This .signature sanitized for your protection From owner-cvs-src@FreeBSD.ORG Wed Oct 17 00:03:57 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 358B616A468 for ; Wed, 17 Oct 2007 00:03:57 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.236]) by mx1.freebsd.org (Postfix) with ESMTP id DA41813C45B for ; Wed, 17 Oct 2007 00:03:00 +0000 (UTC) (envelope-from mureninc@gmail.com) Received: by wx-out-0506.google.com with SMTP id i29so1856076wxd for ; Tue, 16 Oct 2007 17:02:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; bh=8Tcd462L+Mu4Rf5f8VvJT+2JREbcd6Ln/vxBbDGmxlE=; b=NQBUjAMLY7hVyj3GhoBHFuDCrnyK2yYmx6ZUwgJq4VOYt+MdUP60UJZvgbtWFjuDy22c5jcfSPmE29wmw71NgINX8FtwmvbFvJjaasEgLL2QODI3oj5c1M2T5Yp1M/IHJ3M3rGOJ4Syx2oh+eUCRf6zxzo/R6Rft6sn2f16702M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:mime-version:content-type:content-transfer-encoding:content-disposition; b=g5VH/T2s73czOGjdyo1aa2i3PVwsJgw0z2NrsHdZ4NwX+7/lPQtTPDv8/UO1bYZtInDbc3HZKnJ7pazJLdYmmO7aIv2HSFrayWlgffFxwTiyn8JrRAdNcwm0DGj8YS9PrU38uU5gUwCGGcY/ddC5zEjJJX1y9P+QVe3gu2dTYf0= Received: by 10.90.52.18 with SMTP id z18mr11586124agz.1192579367226; Tue, 16 Oct 2007 17:02:47 -0700 (PDT) Received: by 10.90.96.9 with HTTP; Tue, 16 Oct 2007 17:02:47 -0700 (PDT) Message-ID: Date: Tue, 16 Oct 2007 20:02:47 -0400 From: "Constantine A. Murenin" To: "Poul-Henning Kamp" MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Cc: src-committers@freebsd.org, Alexander Leidinger , cvs-src@freebsd.org, cvs-all@freebsd.org, "Constantine A. Murenin" , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 00:03:57 -0000 On 16/10/2007, Poul-Henning Kamp wrote: > In message <20071016183311.lu97hbwzggsk4ow4@webmail.leidinger.net>, Alexander L > eidinger writes: > > >> Yes, that is the abstract argument, but the very same argument can > >> be made for every other single kind of entity which consumes or > >> produces bytes, from fingerprint readers to 9-track tape stations. > > > >Why do we have a common linked list API? It's easy enough to do it > >again and again and again... We have it because we don't want to do it > >again and again... And with the sensors API we gain something similar. > > There is a very big difference between and sensors, > in that is not an external API, but a convenience > tool for code to maintain its own data internally, whereas sensors > is an API for exporting data. > > >It adds meta-data which can be used in an automated way. This is done > >with a consistent and documented API. Sure, we can do it with sysctls > >by hand, but see above. > > What exactly do you mean when you say "used in an automated way" ? > > Can I run some magic program and tell it "alert me if something is > wrong" or do I have to write a tedious configuration file to explain > what "something is wrong" would look like to the program ? Yes, with ipmi(4), esm(4) etc on OpenBSD 4.2, sensorsd will automatically alert you if something is wrong. No configuration is required. With lm(4)-style drivers, the situation is different -- some, rather minimal, configuration will in fact be required. > >It is not supposed to make the monitoring itself easier. > >[...] > >A human being still has to interprete the measurements. No doubts. But > >with the framework you don't have to hunt down where to read the > >sensor data, and how to name it. You can write a probe which takes > >everything in the the sensors mib and let it produce names and values > >for the probed things automatically. > > So the only problem sensors solves, is that it defines a single > place in the sysctl tree, where you can find all sorts of non-random > numbers, each of which comes with a piece of ascii text that isn't > formatted in any consistent way ? > > I'd say, lets raise the bar several notches right here. > > How about we look at what is desirable from such a subsystem, and > see what architecture that mandates ? > > Here are some things to think about: > > * Input only or input & output ? > > Would it make sense to be able to control the fans or power > to various subsystems while we are at it ? This is something that originally got me into all of this in 2005. I currently have some crude hacks for lm(4) and the sensors framework that allow me to set the fan-speed on one of my systems. The problem with fan-control is the complexity it adds, most system administrators aren't really interested in slowing their fans down (although I am for my home servers), and, most importantly, many chips feature so many various fan-controlling possibilities that a coherent interface to accomplish such fan control isn't as easy as it may sound. For example, many recent chips have at least three ways to control the fan speed, by directly controlling the voltage, by doing fan-speed cruise, by doing temperature-based cruise. Additionally, there are selectors on which fan should be affected by which temperature. Moreover, recent chips provide several levels of temperature-based cruise. To complicate the matter, some chips are not wired by the manufacturer to actually do any of the controlling, even though they can in fact detect the speed and temperature just fine. The list goes on and on. > * It should be possible to implement a sensor in userland, so that > interface to external sensors is possible without forcing the > code into the kernel. Think: Maxim/Dallas 1-Wire temperature > sensors and similar. I am not certain about this, but OpenBSD already has support for 1-Wire sensors. > * Metadata information in machine redable format: > - recommended, min and max poll rate > - Nominal value, quantization step and alarm limit(s) > - alarm transgression severity for system integrity > - sensorfailure severity for system integrity > - physical location of measured quantity > ... OpenBSD has more than 50 drivers that utilise this sensor framework. With most i2c and Super I/O chips, you simply don't have this information, so why complicate the interface? > * Event support ? > - enumeration, arrival and departure of sensors > - alarm transgressions > - sensor failure > ... The arrival and departure could be implemented by sticking in some devctl calls into sensordev_install and sensordev_deinstall. Out of all sensor drivers in OpenBSD, I'm not aware of any single device that has any reason to attach or detach any individual sensors after being loaded. Effectively, there is an unsaid rule of not calling sensor_attach or sensor_detach after sensordev_install has already happened. > * Interface and integration with IPMI, ACPI and similar. > Do any of these have a metadata format we can use ? The sensors framework is integrated with ipmi(4) on OpenBSD. The status field of each sensor is used to define whether each individual sensor is performing within the specification. > > and probably a lot of other stuff I didn't think of right now... > > >Now... how much hardware out there supports IPMI, or > >better... how much in production use doesn't use IPMI? > > But don't you think it would be better to have a subsystem that > made it possible to use IPMI and ACPI, than to just say "Naa, > that sucks, it must do, because we don't support it" ? > > >> Let me get this straight, you're telling me: > >> > >> "I'm worried about this code running as root, so I'm putting > >> it in the kernel instead." > > > >You missed the point. > > No, I most certainly did not. > > By defining the sensor API (on top of sysctl) at the kernel/userland > boundary you have decided that all sensor implementations must live > in the kernel, there is no room in your architecture for sensors > that live in userland. > > Effectively, you have elevated all sensor implementations to root++ > priviledge, even if they don't need any priviledge at all. > > I don't care much about who wrote the code or how trustworthy they > are, that's a problem that can be fixed along the way. > > But I do care about taking away, by design, the choice of running > at low priviledge from people who implement sensors. > > >> I repeat: The SoC interface is not the gateway to -current. > > > >It provides an idea in what people are interested in. > > Sure, lets list "Peace in the middle-east" on there, I'm sure people > are interested :-) > > "People", whoever they are, are interested in anything that sounds > fancy or flashy, but that doesn't mean that they can or will actually > use it for anything if somebody produce it, and it certainly gives > no guarantee that you will not shoot yourself in the foot along the > way if you do so. > > People was very interested in UFS soft-updates and snapshots, but > if we had paid more attention to what it did to the buf subsystem, > we would probably have been a lot more cautious. ZFS generates a > lot of buzz, and similar concerns can, has been and should be raised > about that. (My answer to that on is to turn buf into a library > function, so that each filesystem gets to screw only itself up). > > >And several > >committers here in the thread also showed interest in this framework > >(maybe not in the current implementation, but at least in the idea > >behind it). > > Right, but if we didn't object, you had saddled us with this implementation, > without any actual discussion about what exactly the idea behind it > was and if that was the right idea for us. > > >Just because you do not see how such a framework can be > >useful to you (so far I have the impression from your mails, that you > >object to the idea of this framework), > > I *can* see why and how such a framework can be useful, that's why > I'm objecting to this half-baked attempt at it. > > >> Ten years ago when we didn't have P4 and the _extensive_ infrastructure > >> for making it easy for people to work out of the tree, we had to do > >> stuff like that, but there is no excuse for it today. > > > >Nobody is perfect. There will always be some bugs when something is > >committed to -current. > > Bugs, yes, and we have means to deal with them. > > But we should try much harder to avoid half-baked concepts and wrong > architecture, because that is 10 times harder to fix than a plain > bug is. > > >You don't talk about obvious problems here. > >There's no destabilized system, there are no panics. You talk about > >not using an underdocumented API and not using a generic framework for > >creating tasks [...] > > Yes, it does appear to me that we are not on the same level of > abstraction. > > I am indeed not talking about how many compiler warnings or style(9) > infractions this code has. > > I'm talking about: > - if it actually solves a problem for us that we have. > - if if should solve more problems than it does right now. > - if it creates even more problems down the road. > > I'm talking about architecture, you're talking about code. From owner-cvs-src@FreeBSD.ORG Wed Oct 17 04:15:42 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 07A7716A418; Wed, 17 Oct 2007 04:15:42 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com [216.240.101.25]) by mx1.freebsd.org (Postfix) with ESMTP id B97CF13C447; Wed, 17 Oct 2007 04:15:41 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from [192.168.1.104] (cpe-66-91-190-165.hawaii.res.rr.com [66.91.190.165]) (authenticated bits=0) by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id l9H4Fbu2020277 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO); Wed, 17 Oct 2007 00:15:39 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Tue, 16 Oct 2007 21:18:15 -0700 (PDT) From: Jeff Roberson X-X-Sender: jroberson@10.0.0.1 To: Kris Kennaway In-Reply-To: <47150841.2080306@FreeBSD.org> Message-ID: <20071016211711.B598@10.0.0.1> References: <200710160736.l9G7a3oI087966@repoman.freebsd.org> <471480AB.7090500@FreeBSD.org> <4714F750.9010804@freebsd.org> <47150841.2080306@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Jason Evans , cvs-all@freebsd.org, David Xu Subject: Re: cvs commit: src/lib/libthr/thread thr_pspinlock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 04:15:42 -0000 On Tue, 16 Oct 2007, Kris Kennaway wrote: > Jason Evans wrote: >> Kris Kennaway wrote: >>> David Xu wrote: >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> lib/libthr/thread thr_pspinlock.c Log: >>>> Reverse the logic of UP and SMP. >>>> Submitted by: jasone >>>> Revision Changes Path >>>> 1.6 +1 -1 src/lib/libthr/thread/thr_pspinlock.c >>> >>> Are there any common applications that use this? >> >> It's worth mentioning that this change, although correct, does not make a >> measurable performance difference for the tests I was running when I found >> the bug. It is possible that making the spinlocks adaptive would help, but >> I didn't look into this. >> >> (I was working on malloc performance enhancements that have turned out very >> nicely, but in the end I had to switch to hand-rolled "spin" mutexes that >> eventually convert to blocking, in order to avoid the possibility of >> unrecoverable priority inversion.) > > BTW I am looking at adding a non-portable (sort of) pthread mutex type that > spins for a while when the lock is held, before blocking. This is sometimes > good for performance when the pthread mutex is highly contended but held for > short periods of time, and in fact Linux has such a mutex that is used by > mysql with performance benefits. > > The real fix would be to make them adaptive in the same way as kernel mutexes > (spin as long as the lock holder is running), but there is currently no easy > way for userland to peer into the kernel to check the other thread's state. One thing that was suggested was to spin for a set number of times in user-space before entering the syscall which could continue to spin as long as the target was running. The initial few spins would catch quite a few cases and avoid the syscall overhead. Then the spin in kernel could last for longer and avoid the switch overhead. Sort of a hybrid approach. Jeff > > Kris > From owner-cvs-src@FreeBSD.ORG Wed Oct 17 07:27:51 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CE1A016A417; Wed, 17 Oct 2007 07:27:51 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B572313C45B; Wed, 17 Oct 2007 07:27:51 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9H7Rp0w028514; Wed, 17 Oct 2007 07:27:51 GMT (envelope-from se@repoman.freebsd.org) Received: (from se@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9H7Rpk3028513; Wed, 17 Oct 2007 07:27:51 GMT (envelope-from se) Message-Id: <200710170727.l9H7Rpk3028513@repoman.freebsd.org> From: Stefan Esser Date: Wed, 17 Oct 2007 07:27:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/locate/locate locate.rc updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 07:27:51 -0000 se 2007-10-17 07:27:51 UTC FreeBSD src repository Modified files: usr.bin/locate/locate locate.rc updatedb.sh Log: The previous version included too many file system types in the scan, since "local" includes also synthetic file systems (e.g. /dev, /proc) and loopback mounts. This version uses lsvfs to identify file system types that are local and additionally not synthetik, loopback mounts, or read-only. This has been suggested by Craig Rodrigues half a year ago. The patch that has been committed is based on his suggestion, but slightly modified. The comments in locate.rc have been updated to reflect the change and o include zfs and xfs in the example file system parameter that can be used to override the default outlined above. PR: 114101 Submitted by: rodrigc at crodrigues dot org (Craig Rodrigues) MFC: 2 weeks Revision Changes Path 1.11 +6 -2 src/usr.bin/locate/locate/locate.rc 1.22 +3 -1 src/usr.bin/locate/locate/updatedb.sh From owner-cvs-src@FreeBSD.ORG Wed Oct 17 08:17:43 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 12ACE16A419 for ; Wed, 17 Oct 2007 08:17:43 +0000 (UTC) (envelope-from wearabnet@yahoo.ca) Received: from web33712.mail.mud.yahoo.com (web33712.mail.mud.yahoo.com [68.142.201.209]) by mx1.freebsd.org (Postfix) with SMTP id A2BD513C45D for ; Wed, 17 Oct 2007 08:17:42 +0000 (UTC) (envelope-from wearabnet@yahoo.ca) Received: (qmail 49126 invoked by uid 60001); 17 Oct 2007 07:51:01 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.ca; h=X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID; b=kUjgD3fFxONp2Is6pWfx+jeyS+Ln7uCt//p2AtShaDjh5JgMoa4tasyPGSL/eshnFHvFRQgJY2YUPx3G5fCqLON4Kw1W7yYLkEJ/LA7z9bX6OetB3GQPCkr26wp78A92o7Ewdj07X6BGPDr7mNev+s7oNQTm4/xCnQLRSIQcOPE=; X-YMail-OSG: iJIq_.MVM1ng0XOh9eNZmvcx5bs7rV935pveZJmOL0ytPkS5Z47QhaB9ef7fgc8ff0gXdCv_WPFgKM6YDdDR2EMNpK6MuCm10dzLz4Sy4JMgHzV2f4w- Received: from [89.211.5.3] by web33712.mail.mud.yahoo.com via HTTP; Wed, 17 Oct 2007 00:51:01 PDT X-Mailer: YahooMailRC/814.05 YahooMailWebService/0.7.134.12 Date: Wed, 17 Oct 2007 00:51:01 -0700 (PDT) From: Abdullah Ibn Hamad Al-Marri To: David Xu , src-committers@FreeBSD.org, cvs-src@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-ID: <168960.48855.qm@web33712.mail.mud.yahoo.com> Cc: Subject: Re: cvs commit: src/lib/libthr/thread thr_once.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 08:17:43 -0000 =0A=0A=0A----- Original Message ----=0A> From: David Xu =0A> To: src-committers@FreeBSD.org; cvs-src@FreeBSD.org; cvs-all@FreeBSD= .org=0A> Sent: Tuesday, October 16, 2007 10:46:15 AM=0A> Subject: cvs commi= t: src/lib/libthr/thread thr_once.c=0A> =0A> davidxu 2007-10-16 07:46:1= 5 UTC=0A> =0A> FreeBSD src repository=0A> =0A> Modified files:=0A> = lib/libthr/thread thr_once.c =0A> Log:=0A> Use macro THR_CLEANUP_PUS= H/POP, they are cheaper=0A> than=0A> =0A pthread_cleanup_push/pop.=0A> = =0A> Revision Changes Path=0A> 1.6 +4 -2 src/lib/libthr/= thread/thr_once.c=0A> _______________________________________________=0A=0A= David,=0A=0AThank you!=0A=0AWhen do you plan to MFC the libthr changes to R= ELENG_7 and RELENG_6?=0A=0A=0A =0ARegards, =0A-Abdullah Ibn Hamad Al-Marri= =0AArab Portal=0Ahttp://www.WeArab.Net/=0A =0A=0A=0A=0A=0A_________________= _________________________________=0ADo You Yahoo!?=0ATired of spam? Yahoo!= Mail has the best spam protection around =0Ahttp://mail.yahoo.com From owner-cvs-src@FreeBSD.ORG Wed Oct 17 08:50:44 2007 Return-Path: Delivered-To: cvs-src@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 88F6316A418; Wed, 17 Oct 2007 08:50:44 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 55CA313C457; Wed, 17 Oct 2007 08:50:44 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from [127.0.0.1] (root@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l9H8odEZ056652; Wed, 17 Oct 2007 08:50:40 GMT (envelope-from davidxu@freebsd.org) Message-ID: <4715CD13.20205@freebsd.org> Date: Wed, 17 Oct 2007 16:51:31 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.13) Gecko/20070516 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kris Kennaway References: <200710160736.l9G7a3oI087966@repoman.freebsd.org> <471480AB.7090500@FreeBSD.org> <4714F750.9010804@freebsd.org> <47150841.2080306@FreeBSD.org> In-Reply-To: <47150841.2080306@FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Jason Evans , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libthr/thread thr_pspinlock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 08:50:44 -0000 Kris Kennaway wrote: > Jason Evans wrote: > >> Kris Kennaway wrote: >> >>> David Xu wrote: >>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> lib/libthr/thread thr_pspinlock.c Log: >>>> Reverse the logic of UP and SMP. >>>> Submitted by: jasone >>>> Revision Changes Path >>>> 1.6 +1 -1 src/lib/libthr/thread/thr_pspinlock.c >>> >>> >>> Are there any common applications that use this? >> >> >> It's worth mentioning that this change, although correct, does not >> make a measurable performance difference for the tests I was running >> when I found the bug. It is possible that making the spinlocks >> adaptive would help, but I didn't look into this. >> >> (I was working on malloc performance enhancements that have turned out >> very nicely, but in the end I had to switch to hand-rolled "spin" >> mutexes that eventually convert to blocking, in order to avoid the >> possibility of unrecoverable priority inversion.) > > > BTW I am looking at adding a non-portable (sort of) pthread mutex type > that spins for a while when the lock is held, before blocking. This is > sometimes good for performance when the pthread mutex is highly > contended but held for short periods of time, and in fact Linux has such > a mutex that is used by mysql with performance benefits. > > The real fix would be to make them adaptive in the same way as kernel > mutexes (spin as long as the lock holder is running), but there is > currently no easy way for userland to peer into the kernel to check the > other thread's state. > > Kris > I have a patch to adaptively spin in userland, kernel is not involved. http://people.freebsd.org/~davidxu/patch/libthr_spin.patch I have not seen visible performance improvement in some tests, unlike kernel code, many user application code do not care parallel performance, they only care exclusive accessing to a resource, you can call them badly written code, so spinning is not always useful. However, with this patch, Sun's mutex ping-pong program's performance is massively improved, try it. Regards, David Xu From owner-cvs-src@FreeBSD.ORG Wed Oct 17 08:54:25 2007 Return-Path: Delivered-To: cvs-src@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 520DC16A420; Wed, 17 Oct 2007 08:54:25 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3BC3013C455; Wed, 17 Oct 2007 08:54:25 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from [127.0.0.1] (root@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l9H8sLUL056691; Wed, 17 Oct 2007 08:54:22 GMT (envelope-from davidxu@freebsd.org) Message-ID: <4715CDF1.2010907@freebsd.org> Date: Wed, 17 Oct 2007 16:55:13 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.13) Gecko/20070516 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Abdullah Ibn Hamad Al-Marri References: <168960.48855.qm@web33712.mail.mud.yahoo.com> In-Reply-To: <168960.48855.qm@web33712.mail.mud.yahoo.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/lib/libthr/thread thr_once.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 08:54:25 -0000 Abdullah Ibn Hamad Al-Marri wrote: > > > ----- Original Message ---- > >>From: David Xu >>To: src-committers@FreeBSD.org; cvs-src@FreeBSD.org; cvs-all@FreeBSD.org >>Sent: Tuesday, October 16, 2007 10:46:15 AM >>Subject: cvs commit: src/lib/libthr/thread thr_once.c >> >>davidxu 2007-10-16 07:46:15 UTC >> >> FreeBSD src repository >> >> Modified files: >> lib/libthr/thread thr_once.c >> Log: >> Use macro THR_CLEANUP_PUSH/POP, they are cheaper >>than >> > > pthread_cleanup_push/pop. > >> >> Revision Changes Path >> 1.6 +4 -2 src/lib/libthr/thread/thr_once.c >>_______________________________________________ > > > David, > > Thank you! > > When do you plan to MFC the libthr changes to RELENG_7 and RELENG_6? > > > > Regards, > -Abdullah Ibn Hamad Al-Marri > Arab Portal > http://www.WeArab.Net/ > > This is a minor tweak, may not very urgent to be MFCed. Regards, David Xu From owner-cvs-src@FreeBSD.ORG Wed Oct 17 09:33:14 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 53A9E16A418; Wed, 17 Oct 2007 09:33:14 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id E93DB13C455; Wed, 17 Oct 2007 09:33:13 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A55CF3.dip.t-dialin.net [84.165.92.243]) by redbull.bpaserver.net (Postfix) with ESMTP id 27D882E0EE; Wed, 17 Oct 2007 11:33:07 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 4CF175B480D; Wed, 17 Oct 2007 11:32:02 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.1/8.13.8/Submit) id l9H9W2t6045562; Wed, 17 Oct 2007 11:32:02 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Wed, 17 Oct 2007 11:32:02 +0200 Message-ID: <20071017113202.aso25e4jhw8kg4c4@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Wed, 17 Oct 2007 11:32:02 +0200 From: Alexander Leidinger To: Robert Watson References: <70e8236f0710150343k590f5be8r8cdf3fd60df4abd2@mail.gmail.com> <4713700D.8040202@samsco.org> <20071015193658.138fc9a5@deskjail> <20071015221917.X9055@fledge.watson.org> In-Reply-To: <20071015221917.X9055@fledge.watson.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.8, required 8, BAYES_00 -15.00, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10) X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Joao Barros , cvs-all@FreeBSD.org, Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 09:33:14 -0000 Quoting Robert Watson (from Mon, 15 Oct 2007 =20 22:26:38 +0100 (BST)): [ideas list] > We either need to clearly document when ideas are things to explore > rather than things to assume are a shopping list, or we need to take > the dubious ideas off the list. We also need to make sure that every > idea on the list has a competent "owner" who is able to properly direct > the work of a volunteer, and make sure they understand when something > is commit-path or just "look and see if it might make sense". I have an idea how to do it on the page... I just need to get time to =20 do it. Do you want to review it before I commit it? It's basically =20 some text before the ideas explaining this. Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 The Ancient Doctrine of Mind Over Matter: =09I don't mind... and you don't matter. =09=09-- As revealed to reporter G. Rivera by Swami Havabanana From owner-cvs-src@FreeBSD.ORG Wed Oct 17 09:39:37 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4F8E316A41A; Wed, 17 Oct 2007 09:39:37 +0000 (UTC) (envelope-from joel@FreeBSD.org) Received: from swip.net (mailfe10.tele2.se [212.247.155.33]) by mx1.freebsd.org (Postfix) with ESMTP id 378AF13C4A3; Wed, 17 Oct 2007 09:39:35 +0000 (UTC) (envelope-from joel@FreeBSD.org) X-Cloudmark-Score: 0.000000 [] Received: from [81.233.61.198] (account mj571680@tele2.se HELO [192.168.0.112]) by mailfe10.swip.net (CommuniGate Pro SMTP 5.1.10) with ESMTPA id 484400927; Wed, 17 Oct 2007 11:39:33 +0200 From: Joel Dahl To: Alexander Leidinger In-Reply-To: <20071017113202.aso25e4jhw8kg4c4@webmail.leidinger.net> References: <70e8236f0710150343k590f5be8r8cdf3fd60df4abd2@mail.gmail.com> <4713700D.8040202@samsco.org> <20071015193658.138fc9a5@deskjail> <20071015221917.X9055@fledge.watson.org> <20071017113202.aso25e4jhw8kg4c4@webmail.leidinger.net> Content-Type: text/plain Date: Wed, 17 Oct 2007 11:39:32 +0200 Message-Id: <1192613972.1134.7.camel@jesus.automatvapen.se> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Joao Barros , cvs-all@FreeBSD.org, Robert Watson , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 09:39:37 -0000 On Wed, 2007-10-17 at 11:32 +0200, Alexander Leidinger wrote: > Quoting Robert Watson (from Mon, 15 Oct 2007 > 22:26:38 +0100 (BST)): > > [ideas list] > > We either need to clearly document when ideas are things to explore > > rather than things to assume are a shopping list, or we need to take > > the dubious ideas off the list. We also need to make sure that every > > idea on the list has a competent "owner" who is able to properly direct > > the work of a volunteer, and make sure they understand when something > > is commit-path or just "look and see if it might make sense". > > I have an idea how to do it on the page... I just need to get time to > do it. Do you want to review it before I commit it? It's basically > some text before the ideas explaining this. Actually, I also have an idea on how to do this. Can we perhaps work together on this one? -- Joel From owner-cvs-src@FreeBSD.ORG Wed Oct 17 09:47:16 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A542916A41B; Wed, 17 Oct 2007 09:47:16 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 667F313C45A; Wed, 17 Oct 2007 09:47:16 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 663E2471B3; Wed, 17 Oct 2007 05:47:09 -0400 (EDT) Date: Wed, 17 Oct 2007 10:47:09 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Alexander Leidinger , Joel Dahl In-Reply-To: <1192613972.1134.7.camel@jesus.automatvapen.se> Message-ID: <20071017104537.C60783@fledge.watson.org> References: <70e8236f0710150343k590f5be8r8cdf3fd60df4abd2@mail.gmail.com> <4713700D.8040202@samsco.org> <20071015193658.138fc9a5@deskjail> <20071015221917.X9055@fledge.watson.org> <20071017113202.aso25e4jhw8kg4c4@webmail.leidinger.net> <1192613972.1134.7.camel@jesus.automatvapen.se> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Joao Barros , cvs-all@FreeBSD.org, Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 09:47:16 -0000 On Wed, 17 Oct 2007, Joel Dahl wrote: > On Wed, 2007-10-17 at 11:32 +0200, Alexander Leidinger wrote: >> Quoting Robert Watson (from Mon, 15 Oct 2007 22:26:38 >> +0100 (BST)): >> >> [ideas list] >>> We either need to clearly document when ideas are things to explore rather >>> than things to assume are a shopping list, or we need to take the dubious >>> ideas off the list. We also need to make sure that every idea on the list >>> has a competent "owner" who is able to properly direct the work of a >>> volunteer, and make sure they understand when something is commit-path or >>> just "look and see if it might make sense". >> >> I have an idea how to do it on the page... I just need to get time to do >> it. Do you want to review it before I commit it? It's basically some text >> before the ideas explaining this. > > Actually, I also have an idea on how to do this. Can we perhaps work > together on this one? I'm happy to review things, but should let you know I've been largely offline for a month due to Leigh being in hospital, and I'm still only at the tip of the iceburg on catching up, so my turn-around may be a bit delayed. Per our previous e-mail discussions, I think having some sort of ideas list is very valuable, I think we just need to manage the list a little differently, and especially, manage expectations for the list :-). Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Wed Oct 17 09:52:09 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EB62216A417; Wed, 17 Oct 2007 09:52:09 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C34C113C457; Wed, 17 Oct 2007 09:52:09 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9H9q9Jo048547; Wed, 17 Oct 2007 09:52:09 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9H9q9BW048533; Wed, 17 Oct 2007 09:52:09 GMT (envelope-from kib) Message-Id: <200710170952.l9H9q9BW048533@repoman.freebsd.org> From: Konstantin Belousov Date: Wed, 17 Oct 2007 09:52:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/tail read.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 09:52:10 -0000 kib 2007-10-17 09:52:09 UTC FreeBSD src repository Modified files: usr.bin/tail read.c Log: Fix various memory leaks. Submitted by: rdivacky Obtained from: OpenBSD MFC after: 1 week Revision Changes Path 1.12 +13 -3 src/usr.bin/tail/read.c From owner-cvs-src@FreeBSD.ORG Wed Oct 17 10:16:20 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F82C16A417; Wed, 17 Oct 2007 10:16:20 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7815313C46E; Wed, 17 Oct 2007 10:16:20 +0000 (UTC) (envelope-from rrs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9HAGKB5054894; Wed, 17 Oct 2007 10:16:20 GMT (envelope-from rrs@repoman.freebsd.org) Received: (from rrs@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9HAGKUG054893; Wed, 17 Oct 2007 10:16:20 GMT (envelope-from rrs) Message-Id: <200710171016.l9HAGKUG054893@repoman.freebsd.org> From: Randall Stewart Date: Wed, 17 Oct 2007 10:16:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/netstat sctp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 10:16:20 -0000 rrs 2007-10-17 10:16:20 UTC FreeBSD src repository Modified files: usr.bin/netstat sctp.c Log: Fix incorrect string formats for netstat/s PR: 117175 Obtained from: Weongyo Jeong (weongyo.jeong@gmail.com) MFC after: 1 week Revision Changes Path 1.8 +48 -48 src/usr.bin/netstat/sctp.c From owner-cvs-src@FreeBSD.ORG Wed Oct 17 10:35:10 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 1856616A419; Wed, 17 Oct 2007 10:35:10 +0000 (UTC) Date: Wed, 17 Oct 2007 10:35:10 +0000 From: Alexey Dokuchaev To: Stefan Esser Message-ID: <20071017103509.GA71990@FreeBSD.org> References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> <20071016102013.GE23043@submonkey.net> <4714F06B.7070702@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <4714F06B.7070702@FreeBSD.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, Ceri Davies , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 10:35:10 -0000 On Tue, Oct 16, 2007 at 07:10:03PM +0200, Stefan Esser wrote: > Ceri Davies schrieb: > > On Mon, Oct 15, 2007 at 10:09:19PM +0000, Stefan Esser wrote: > >> se 2007-10-15 22:09:19 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> usr.bin/locate/locate updatedb.sh > >> Log: > >> Make the updatedb script installed as /usr/libexec/locate.updatedb > >> inspect all local file systems, not only ufs and ext2fs. A number > >> of local file systems has been added over time, and at least zfs > >> has the potential to become a popular choice. Without this change > >> a ZFS root file system causes the script to ignore all file-systems > >> and leads to an empty locate db. (An alternative is to add all the > >> relevant file systems individually, which means that at least zfs, > >> xfs, ntfs, ntfs-3g, msdosfs should be added, probably more). > > > > This now includes /dev, /dev/fd, /proc, /compat/linux/proc, CD-ROMs and DVDs > > as well as duplicating everything in nullfs mounts, all of which are probably > > undesirable -- well, they are undesirable to me; whether they are to > > others is the question ;-). > > Ok, thank you for the information. I did not notice this in my tests. > > I'm not sure what the "local" pseudo fs-type is meant to be used for. > Currently it appears to be identical to "not-remote" (which is what > the locate db update tries to avoid, due to high network load and > scan time). > > I plan to fix this within the next 24 hours (if anybody thinks it needs > to be backed-out immediately, I'm willing to do this, but I'd rather > put in the correct fix instead. > > Two possibilities: We could have another pseudo fs-type in find, which > selects "real" file systems (and skips devfs, procfs, fdescfs, nullfs > and probably more). Scanning of removable devices is dubious, too, > independently of their file system. By selecting "local" and "disk > based" file systems (which would omit not only the pseudo file-systems > and nullfs, but also cd9660 and udf), no specific file systems needed > to be put into the script (and find would have the knowledge). > > The second possibility is to extend the list in the update script. It > needs to contain at least: > > ufs ext2fs zfs > > and probably also: > > xfs msdosfs ntfs ntfs-3g (?) It might be a good idea to drop msdosfs off of this list. Real physical filesystems in Windoze world are typically NTFS now, and FAT is used mainly in removable storage. ./danfe From owner-cvs-src@FreeBSD.ORG Wed Oct 17 10:48:59 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A2E1816A418; Wed, 17 Oct 2007 10:48:59 +0000 (UTC) (envelope-from simon@benji.nitro.dk) Received: from mx.nitro.dk (zarniwoop.nitro.dk [83.92.207.38]) by mx1.freebsd.org (Postfix) with ESMTP id 58AD913C45A; Wed, 17 Oct 2007 10:48:59 +0000 (UTC) (envelope-from simon@benji.nitro.dk) Received: from benji.nitro.dk (unknown [192.168.3.39]) by mx.nitro.dk (Postfix) with ESMTP id CC1701E8C0F; Wed, 17 Oct 2007 10:33:30 +0000 (UTC) Received: by benji.nitro.dk (Postfix, from userid 2000) id 01903FD13; Wed, 17 Oct 2007 12:33:39 +0200 (CEST) Date: Wed, 17 Oct 2007 12:33:39 +0200 From: "Simon L. Nielsen" To: Stefan Esser Message-ID: <20071017103338.GB1003@zaphod.nitro.dk> References: <200710170727.l9H7Rpk3028513@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200710170727.l9H7Rpk3028513@repoman.freebsd.org> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate locate.rc updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 10:48:59 -0000 On 2007.10.17 07:27:51 +0000, Stefan Esser wrote: > se 2007-10-17 07:27:51 UTC > > FreeBSD src repository > > Modified files: > usr.bin/locate/locate locate.rc updatedb.sh > Log: > The previous version included too many file system types in the scan, > since "local" includes also synthetic file systems (e.g. /dev, /proc) > and loopback mounts. > > This version uses lsvfs to identify file system types that are local > and additionally not synthetik, loopback mounts, or read-only. This > has been suggested by Craig Rodrigues half a year ago. The patch that > has been committed is based on his suggestion, but slightly modified. Are you sure all read-only file systems should be excluded? I quite often have systems with some filesystem mounted read-only (often /), though granted most of those are "embedded" which doesn't run updatedb. Which kind of file systems were you thinking should be excluded by the RO part which isn't already removed by loopback|network|synthetic ? I'm not certain read-only shouldn't be excluded, but I just want to point out there are cases where read-only still might be a local and interesting file system. -- Simon L. Nielsen From owner-cvs-src@FreeBSD.ORG Wed Oct 17 11:26:14 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 520C516A41A for ; Wed, 17 Oct 2007 11:26:14 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from spacemail1-out.mgmt.space.net (spacemail1-out.mgmt.Space.Net [194.97.149.146]) by mx1.freebsd.org (Postfix) with ESMTP id D282E13C46E for ; Wed, 17 Oct 2007 11:26:13 +0000 (UTC) (envelope-from se@FreeBSD.org) X-SpaceNet-SBRS: None X-IronPort-AV: E=Sophos;i="4.21,289,1188770400"; d="scan'208";a="73557275" Received: from mail.atsec.com ([195.30.252.105]) by spacemail1-out.mgmt.space.net with ESMTP; 17 Oct 2007 13:26:11 +0200 Received: from [10.2.2.88] (frueh.atsec.com [217.110.13.170]) (Authenticated sender: se@atsec.com) by mail.atsec.com (Postfix) with ESMTP id 237C091C0DB; Wed, 17 Oct 2007 13:26:10 +0200 (CEST) Message-ID: <4715F150.8000404@FreeBSD.org> Date: Wed, 17 Oct 2007 13:26:08 +0200 From: Stefan Esser User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: "Simon L. Nielsen" References: <200710170727.l9H7Rpk3028513@repoman.freebsd.org> <20071017103338.GB1003@zaphod.nitro.dk> In-Reply-To: <20071017103338.GB1003@zaphod.nitro.dk> X-Enigmail-Version: 0.95.3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate locate.rc updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 11:26:14 -0000 Simon L. Nielsen wrote: > On 2007.10.17 07:27:51 +0000, Stefan Esser wrote: >> se 2007-10-17 07:27:51 UTC >> >> FreeBSD src repository >> >> Modified files: >> usr.bin/locate/locate locate.rc updatedb.sh >> Log: >> The previous version included too many file system types in the scan, >> since "local" includes also synthetic file systems (e.g. /dev, /proc) >> and loopback mounts. >> >> This version uses lsvfs to identify file system types that are local >> and additionally not synthetik, loopback mounts, or read-only. This >> has been suggested by Craig Rodrigues half a year ago. The patch that >> has been committed is based on his suggestion, but slightly modified. > > Are you sure all read-only file systems should be excluded? I quite > often have systems with some filesystem mounted read-only (often /), > though granted most of those are "embedded" which doesn't run > updatedb. The logic is not to exclude R/O file systems, but R/O file system *types*. E.g., an UFS root is scanned, whether mounted R/O or R/W (since it is a writable file system type) but a CD9660 root would be excluded. I was not sure about inclusion of this condition, but since CD and DVD drives have slow seek times (and removable media), this seemed reasonable to me. > Which kind of file systems were you thinking should be excluded by the > RO part which isn't already removed by loopback|network|synthetic ? The most common is cd9660, but the VFCF_READONLY flag is also set for UDF and ReiserFS (and possibly some file systems available as ports). > I'm not certain read-only shouldn't be excluded, but I just want to > point out there are cases where read-only still might be a local and > interesting file system. Please check the output of lsvfs on your system and let me know, if the current file system type selection in locate.updatedb does not match your expectations. I do not have all file system types available for testing (e.g. none of the fuse-fs sub-types and no smbfs). You can always override the file system types to inspect in the configuration file (/etc/loader.rc). But I hope that the new method to find a default is much better than the previous (too short) list and I think it is better than any hard-coded list for most users. Regards, STefan From owner-cvs-src@FreeBSD.ORG Wed Oct 17 11:34:47 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E769616A419 for ; Wed, 17 Oct 2007 11:34:47 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from spacemail1-out.mgmt.space.net (spacemail1-out.mgmt.Space.Net [194.97.149.146]) by mx1.freebsd.org (Postfix) with ESMTP id 6BD0613C45A for ; Wed, 17 Oct 2007 11:34:47 +0000 (UTC) (envelope-from se@FreeBSD.org) X-SpaceNet-SBRS: None X-IronPort-AV: E=Sophos;i="4.21,289,1188770400"; d="scan'208";a="73561192" Received: from mail.atsec.com ([195.30.252.105]) by spacemail1-out.mgmt.space.net with ESMTP; 17 Oct 2007 13:34:46 +0200 Received: from [10.2.2.88] (frueh.atsec.com [217.110.13.170]) (Authenticated sender: se@atsec.com) by mail.atsec.com (Postfix) with ESMTP id A2B7C91C0B4; Wed, 17 Oct 2007 13:34:45 +0200 (CEST) Message-ID: <4715F353.1070703@FreeBSD.org> Date: Wed, 17 Oct 2007 13:34:43 +0200 From: Stefan Esser User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Alexey Dokuchaev References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> <20071016102013.GE23043@submonkey.net> <4714F06B.7070702@FreeBSD.org> <20071017103509.GA71990@FreeBSD.org> In-Reply-To: <20071017103509.GA71990@FreeBSD.org> X-Enigmail-Version: 0.95.3 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, Ceri Davies , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 11:34:48 -0000 Alexey Dokuchaev wrote: > On Tue, Oct 16, 2007 at 07:10:03PM +0200, Stefan Esser wrote: >> The second possibility is to extend the list in the update script. It >> needs to contain at least: >> >> ufs ext2fs zfs >> >> and probably also: >> >> xfs msdosfs ntfs ntfs-3g (?) > > It might be a good idea to drop msdosfs off of this list. Real physical > filesystems in Windoze world are typically NTFS now, and FAT is used > mainly in removable storage. Yes, I considered this. In fact, if there is consensus that FAT should be excluded, I'd add another category to the configuration parameters of the locate.updatedb script. Currently there is: $SEARCHPATHS (start points for the directory scan) $PRUNEPATHS (sub-trees to exclude from scanning) $FILESYSTEMS (file system types to include) and we could add: $PRUNEFS (file system types to exclude) with the latter overriding $FILESYSTEMS ... As you may know, the new default for $FILESYSTEMS is all local, non-synthetic, non-loopback, principally writable file system types (which include msdosfs). The $PRUNEFS could be used to drop a few that could be scanned, but where it is still not desirable. Regards, STefan From owner-cvs-src@FreeBSD.ORG Wed Oct 17 11:41:44 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 15C8116A418; Wed, 17 Oct 2007 11:41:44 +0000 (UTC) (envelope-from jmallett@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 05E9313C459; Wed, 17 Oct 2007 11:41:44 +0000 (UTC) (envelope-from jmallett@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9HBfh6X062760; Wed, 17 Oct 2007 11:41:43 GMT (envelope-from jmallett@repoman.freebsd.org) Received: (from jmallett@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9HBfhjs062759; Wed, 17 Oct 2007 11:41:43 GMT (envelope-from jmallett) Message-Id: <200710171141.l9HBfhjs062759@repoman.freebsd.org> From: Juli Mallett Date: Wed, 17 Oct 2007 11:41:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/fmt fmt.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 11:41:44 -0000 jmallett 2007-10-17 11:41:40 UTC FreeBSD src repository Modified files: usr.bin/fmt fmt.c Log: Prevent strange crashes in fmt with absurd goal lengths introduced by the support for wide characters. If the sizeof (wchar_t) times max_length would yield a value beyond representation in a size_t, exit with a usage error up front, rather than strange errors down the line from trying to malloc (well, realloc) with a size of 0. This is perhaps not the optimal behaviour - a clamp may be more appropriate as we clamp the value of max_length now anyway, but this is at least better than segfaulting or worse. On systems which are friendly to malloc with a value of 0 the results could end up being strange corruption of the output. Revision Changes Path 1.23 +2 -0 src/usr.bin/fmt/fmt.c From owner-cvs-src@FreeBSD.ORG Wed Oct 17 11:43:15 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1101F16A418; Wed, 17 Oct 2007 11:43:15 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 81DFD13C43E; Wed, 17 Oct 2007 11:43:14 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A548C8.dip.t-dialin.net [84.165.72.200]) by redbull.bpaserver.net (Postfix) with ESMTP id 598922E0EE; Wed, 17 Oct 2007 13:43:06 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id AA0035B480D; Wed, 17 Oct 2007 13:42:00 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.1/8.13.8/Submit) id l9HBg0FM067222; Wed, 17 Oct 2007 13:42:00 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Wed, 17 Oct 2007 13:41:59 +0200 Message-ID: <20071017134159.xclghgdc0048swkw@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Wed, 17 Oct 2007 13:41:59 +0200 From: Alexander Leidinger To: Robert Watson References: <70e8236f0710150343k590f5be8r8cdf3fd60df4abd2@mail.gmail.com> <4713700D.8040202@samsco.org> <20071015193658.138fc9a5@deskjail> <20071015221917.X9055@fledge.watson.org> <20071017113202.aso25e4jhw8kg4c4@webmail.leidinger.net> <1192613972.1134.7.camel@jesus.automatvapen.se> <20071017104537.C60783@fledge.watson.org> In-Reply-To: <20071017104537.C60783@fledge.watson.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.8, required 8, BAYES_00 -15.00, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10) X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Barros , cvs-all@FreeBSD.org, Joel Dahl , Wilko Bulte , Joao Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 11:43:15 -0000 Quoting Robert Watson (from Wed, 17 Oct 2007 =20 10:47:09 +0100 (BST)): > On Wed, 17 Oct 2007, Joel Dahl wrote: > >> On Wed, 2007-10-17 at 11:32 +0200, Alexander Leidinger wrote: >>> Quoting Robert Watson (from Mon, 15 Oct 2007 =20 >>> 22:26:38 +0100 (BST)): >>> >>> [ideas list] >>>> We either need to clearly document when ideas are things to =20 >>>> explore rather than things to assume are a shopping list, or we =20 >>>> need to take the dubious ideas off the list. We also need to =20 >>>> make sure that every idea on the list has a competent "owner" who =20 >>>> is able to properly direct the work of a volunteer, and make =20 >>>> sure they understand when something is commit-path or just "look =20 >>>> and see if it might make sense". >>> >>> I have an idea how to do it on the page... I just need to get time =20 >>> to do it. Do you want to review it before I commit it? It's =20 >>> basically some text before the ideas explaining this. >> >> Actually, I also have an idea on how to do this. Can we perhaps =20 >> work together on this one? > > I'm happy to review things, but should let you know I've been largely > offline for a month due to Leigh being in hospital, and I'm still only As I have to go to the hospital next week too (tonsils), I propose =20 that I send my stuff to Joel, and he decides what he does with it. Best wishes to your wife, I hope it is nothing critical. Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 Doubt is a not a pleasant mental state, but certainty is a ridiculous one. =09=09-- Voltaire From owner-cvs-src@FreeBSD.ORG Wed Oct 17 12:28:38 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1BBB616A41B; Wed, 17 Oct 2007 12:28:38 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 0415513C47E; Wed, 17 Oct 2007 12:28:37 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id A4C571A4D7C; Wed, 17 Oct 2007 05:28:37 -0700 (PDT) Date: Wed, 17 Oct 2007 05:28:37 -0700 From: Alfred Perlstein To: Ceri Davies Message-ID: <20071017122837.GM31826@elvis.mu.org> References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> <20071016102013.GE23043@submonkey.net> <4714F06B.7070702@FreeBSD.org> <20071016225906.GK23043@submonkey.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071016225906.GK23043@submonkey.net> User-Agent: Mutt/1.4.2.3i Cc: cvs-src@FreeBSD.org, Stefan Esser , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 12:28:38 -0000 * Ceri Davies [071016 15:59] wrote: > On Tue, Oct 16, 2007 at 07:10:03PM +0200, Stefan Esser wrote: > > Ceri Davies schrieb: > > > On Mon, Oct 15, 2007 at 10:09:19PM +0000, Stefan Esser wrote: > > >> se 2007-10-15 22:09:19 UTC > > >> > > >> FreeBSD src repository > > >> > > >> Modified files: > > >> usr.bin/locate/locate updatedb.sh > > >> Log: > > >> Make the updatedb script installed as /usr/libexec/locate.updatedb > > >> inspect all local file systems, not only ufs and ext2fs. A number > > >> of local file systems has been added over time, and at least zfs > > >> has the potential to become a popular choice. Without this change > > >> a ZFS root file system causes the script to ignore all file-systems > > >> and leads to an empty locate db. (An alternative is to add all the > > >> relevant file systems individually, which means that at least zfs, > > >> xfs, ntfs, ntfs-3g, msdosfs should be added, probably more). > > > > > > This now includes /dev, /dev/fd, /proc, /compat/linux/proc, CD-ROMs and DVDs > > > as well as duplicating everything in nullfs mounts, all of which are probably > > > undesirable -- well, they are undesirable to me; whether they are to > > > others is the question ;-). > > > > Ok, thank you for the information. I did not notice this in my tests. > > > > I'm not sure what the "local" pseudo fs-type is meant to be used for. > > Currently it appears to be identical to "not-remote" (which is what > > the locate db update tries to avoid, due to high network load and > > scan time). > > > > I plan to fix this within the next 24 hours (if anybody thinks it needs > > to be backed-out immediately, I'm willing to do this, but I'd rather > > put in the correct fix instead. > > > > Two possibilities: We could have another pseudo fs-type in find, which > > selects "real" file systems (and skips devfs, procfs, fdescfs, nullfs > > and probably more). Scanning of removable devices is dubious, too, > > independently of their file system. By selecting "local" and "disk > > based" file systems (which would omit not only the pseudo file-systems > > and nullfs, but also cd9660 and udf), no specific file systems needed > > to be put into the script (and find would have the knowledge). > > While userland can tell if a filesystem is pseudo or not, (see lsvfs), > I'm not sure that we can reliably tell whether a device is removable or > not (cf. my camera, USB key, iPod, etc.). fstab(5) gives some hints, "noauto" would be a giveaway as well as value of 0 for 'fs_passno' is also a hint. -- - Alfred Perlstein From owner-cvs-src@FreeBSD.ORG Wed Oct 17 12:33:39 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 629F416A417; Wed, 17 Oct 2007 12:33:39 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 0934413C448; Wed, 17 Oct 2007 12:33:39 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 1E50E2092; Wed, 17 Oct 2007 14:33:30 +0200 (CEST) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: -0.0/3.0 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on tim.des.no Received: from ds4.des.no (des.no [80.203.243.180]) by smtp.des.no (Postfix) with ESMTP id 85B282088; Wed, 17 Oct 2007 14:33:29 +0200 (CEST) Received: by ds4.des.no (Postfix, from userid 1001) id 6C90884497; Wed, 17 Oct 2007 14:33:29 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Alfred Perlstein References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> <20071016102013.GE23043@submonkey.net> <4714F06B.7070702@FreeBSD.org> <20071016225906.GK23043@submonkey.net> <20071017122837.GM31826@elvis.mu.org> Date: Wed, 17 Oct 2007 14:33:29 +0200 In-Reply-To: <20071017122837.GM31826@elvis.mu.org> (Alfred Perlstein's message of "Wed\, 17 Oct 2007 05\:28\:37 -0700") Message-ID: <86y7e1ex9i.fsf@ds4.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Stefan Esser , cvs-src@FreeBSD.org, Ceri Davies , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 12:33:39 -0000 Alfred Perlstein writes: > Ceri Davies writes: > > While userland can tell if a filesystem is pseudo or not, (see > > lsvfs), I'm not sure that we can reliably tell whether a device is > > removable or not (cf. my camera, USB key, iPod, etc.). > fstab(5) gives some hints, "noauto" would be a giveaway as well as > value of 0 for 'fs_passno' is also a hint. No, fs_passno is pretty much always zero except for UFS / UFS2. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Wed Oct 17 12:51:40 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 7131D16A41B; Wed, 17 Oct 2007 12:51:40 +0000 (UTC) Date: Wed, 17 Oct 2007 12:51:40 +0000 From: Alexey Dokuchaev To: Stefan Esser Message-ID: <20071017125140.GA464@FreeBSD.org> References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> <20071016102013.GE23043@submonkey.net> <4714F06B.7070702@FreeBSD.org> <20071017103509.GA71990@FreeBSD.org> <4715F353.1070703@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <4715F353.1070703@FreeBSD.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, Ceri Davies , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 12:51:40 -0000 Circa Oct 17 2007, Stefan Esser wrote: > Yes, I considered this. In fact, if there is consensus that FAT should > be excluded, I'd add another category to the configuration parameters > of the locate.updatedb script. Currently there is: > > $SEARCHPATHS (start points for the directory scan) > $PRUNEPATHS (sub-trees to exclude from scanning) > > $FILESYSTEMS (file system types to include) > > and we could add: > > $PRUNEFS (file system types to exclude) > > with the latter overriding $FILESYSTEMS ... > > As you may know, the new default for $FILESYSTEMS is all local, > non-synthetic, non-loopback, principally writable file system types > (which include msdosfs). The $PRUNEFS could be used to drop a few > that could be scanned, but where it is still not desirable. Sounds pretty flexible to me. While adding new config knobs is generally a thing to avoid, in this case they seem pretty orthogonal to each other. ./danfe From owner-cvs-src@FreeBSD.ORG Wed Oct 17 13:42:50 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 405AB16A46B; Wed, 17 Oct 2007 13:42:50 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 1195813C49D; Wed, 17 Oct 2007 13:42:49 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by elvis.mu.org (Postfix) with ESMTP id CF4141A4D84; Wed, 17 Oct 2007 06:16:45 -0700 (PDT) From: John Baldwin To: "Constantine A. Murenin" Date: Wed, 17 Oct 2007 09:07:06 -0400 User-Agent: KMail/1.9.7 References: <200710161702.00008.jhb@freebsd.org> <471537CA.9080807@FreeBSD.org> In-Reply-To: <471537CA.9080807@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200710170907.07832.jhb@freebsd.org> Cc: Scott Long , src-committers@freebsd.org, Alexander Leidinger , cvs-src@freebsd.org, cvs-all@freebsd.org, Poul-Henning Kamp , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 13:42:50 -0000 On Tuesday 16 October 2007 06:14:34 pm Constantine A. Murenin wrote: > On 16/10/2007 17:01, John Baldwin wrote: > > > On Monday 15 October 2007 10:57:48 pm Constantine A. Murenin wrote: > > > >>On 15/10/2007, John Baldwin wrote: > >> > >>>On Monday 15 October 2007 09:43:21 am Alexander Leidinger wrote: > >>> > >>>>Quoting Scott Long (from Mon, 15 Oct 2007 > >>> > >>>01:47:59 -0600): > >>> > >>>>>Alexander Leidinger wrote: > >>>>> > >>>>>>Quoting Poul-Henning Kamp (from Sun, 14 Oct > >>>>>>2007 17:54:21 +0000): > >>>> > >>>>>>>listen to the various mumblings about putting RAID-controller status > >>>>>>>under sensors framework. > >>>>>> > >>>>>>What's wrong with this? Currently each RAID driver has to come up > >>>>>>with his own way of displaying the RAID status. It's like saying > >>>>>>that each network driver has to implement/display the stuff you can > >>>>>> see with ifconfig in its own way, instead of using the proper > >>>>>>network driver interface for this. > >>>>>> > >>>>> > >>>>>For the love of God, please don't use RAID as an example to support > > > > your > > > >>>>>argument for the sensord framework. Representing RAID state is > > > > several > > > >>>>>orders of magnitude more involved than representing network state. > >>>>>There are also landmines in the OpenBSD bits of RAID support that are > >>>>>best left out of FreeBSD, unless you like alienating vendors and > > > > risking > > > >>>>>legal action. Leave it alone. Please. I don't care what you do with > >>>>>lmsensors or cpu power settings or whatever. Leave RAID out of it. > >>>> > >>>>Talking about RAID status is not talking about alienating vendors. I > >>>>don't talk about alienating vendors and I don't intent to do. You may > >>>>not be able to display a full blown RAID status with the sensors > >>>>framework, but it allows for a generic "wors/works not" or > >>>>"OK/degraded" status display in drivers we have the source for. This > >>>>is enough for status monitoring (e.g., nagios). > >>> > >>>As I mentioned in the thread on arch@ where people brought up objections > > > > that > > > >>>were apparently completely ignored, this is far from useful for RAID > >>>monitoring. For example, if my RAID is down, which disk do I need to > >>>replace? Again, all this was covered earlier and (apparently) ignored. > >>>Also, what strikes me as odd is that I didn't see this patch posted again > > > > for > > > >>>review this time around before it was committed. > >> > >>This has been addressed back in July. You'd use bioctl to see which > >>exact disc needs to be replaced. Sensorsd is intended for an initial > >>alert about something being wrong. > > > > > > In July you actually said you weren't sure about bioctl(8). :) But also, this > > model really isn't very sufficient since it doesn't handle things like drives > > going away, etc. You really need to maintain a decent amount of state to > > keep all that, and this is far easier done in userland rather than in the > > kernel. However, you can choose to ignore real-world experience if you > > choose. > > > > Basically, by having so little data in hw.sensors if I had to write a RAID > > monitoring daemon I would just not use hw.sensors since it's easier for me to > > figure out the simple status myself based on the other state I already have > > to track (unless you write an event-driven daemon based on messages posted by > > the firmware in which case again you wouldn't use hw.sensors for that either). > > There is no other daemon that you'd need, you'd simply use sensorsd for > this. You could write a script that would be executed by sensorsd if a > certain logical disc drive sensor changes state, and then this script > would call the bio framework and give you additional details on why the > state was changed. That's actually not quite good enough as, for example, I want to keep yelling about a busted volume on a periodic basis until its fixed. Also, having a volume change state doesn't tell me if a drive was pulled. On at least one RAID controller firmware I am familiar with, the only way you can figure this out is to keep track of which drives are currently present with a generation count and use that to determine when a drive goes away. Even my monitoring daemon for ata-raid has to do this since the ata(4) driver just detaches and removes a drive when it fails and you have no way to figure out which drive died as the kernel thinks that drive no longer exists. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Wed Oct 17 13:42:50 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3945C16A469; Wed, 17 Oct 2007 13:42:50 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 0D35A13C494; Wed, 17 Oct 2007 13:42:49 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by elvis.mu.org (Postfix) with ESMTP id 0AB9C1A4D80; Wed, 17 Oct 2007 06:16:45 -0700 (PDT) From: John Baldwin To: "Constantine A. Murenin" Date: Wed, 17 Oct 2007 09:03:30 -0400 User-Agent: KMail/1.9.7 References: <200710161809.10755.jhb@freebsd.org> <47153F62.1080709@FreeBSD.org> In-Reply-To: <47153F62.1080709@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200710170903.31724.jhb@freebsd.org> Cc: src-committers@freebsd.org, Alexander Leidinger , cvs-src@freebsd.org, Poul-Henning Kamp , cvs-all@freebsd.org, "Constantine A. Murenin" , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 13:42:50 -0000 On Tuesday 16 October 2007 06:46:58 pm Constantine A. Murenin wrote: > On 16/10/2007 18:09, John Baldwin wrote: > > > On Tuesday 16 October 2007 05:46:18 pm Constantine A. Murenin wrote: > > > >>On 16/10/2007, John Baldwin wrote: > >> > >>>On Tuesday 16 October 2007 12:33:11 pm Alexander Leidinger wrote: > >>> > >>>>Constantine asked for review several times on -current. He got some > >>>>reviews several times for commits to perforce. He incorporated > >>>>suggestions from those reviews, or explained why it is like it is and > >>>>why he can not switch (with no replies with suggestions how to solve > >>>>the problems he sees with the suggestions). Now you come and ask why > >>>>nobody pointed out some flaws before (without telling us which > >>>>technical flaws you talk about). > >>> > >>>At least from my point of view this is not quite accurate as pretty much > > > > all > > > >>>my feedback to the p4 commits was ignored with basically "Well, I don't > > > > like > > > >>>doing it that way". Specifically, with regards to creating dynamic sysctl > >>>trees, Constantine feels that sysctl_add_oid(9) is a hack rather than > >>>recognizing that this is a feature of FreeBSD's sysctl system despite > >>>repeated e-mails on the subject. > >> > >>Dear John, > >> > >>I have specifically addressed this concern of yours just several weeks ago. > >> > >>Please see the following message, which you've never replied to: > >> > >>http://lists.freebsd.org/pipermail/p4-projects/2007-September/021121.html > >> > >>I've used the documented parts of the FreeBSD's sysctl interface to > >>preserve 100% userland compatibility with OpenBSD. > > > > > > FreeBSD already provides an interface for creating dynamic sysctl trees that > > is simpler than having to simulate a pseudo-tree via the .oid_handler > > routine. In some cases (such as kern.proc) FreeBSD still uses a function > > handler rather than giving each process its own sysctl node. However, in > > other cases (generally more recent ones, and ones not as large/performance > > impacting) such as dev.* or the recent proposal to give ifnet's their own > > nodes under 'net.if' or the like, sysctl_add_oid(9) is used. > > Which one is simpler is questionable. Take one more look at the number > of different macros that are available in the sysctl(9) and friends, and > then compare with four functions of the sensors framework: > > * sensor_attach(9) to attach a sensor to a sensordev tree > * sensordev_install(9) to register the sensordev tree with sysctl(9) > and the same with the "de" prefix > > sensordev_install(9) acts similarly to the sysctl(9) ctx concept, but is > geared towards the sensors approach > > If you want to make sure you don't attract any new contributors, then > certainly the bunch of the sysctl(9) macros are simpler. ;) I never said to not have sensor_*() routines. I just think that the sensor implementation should make use of dynamic sysctls to build the sysctl interface rather than treating dynamic sysctls as a temporary hack and adding a duplicate interface for walking the hw.sensors tree. > > As to the process of walking sysctl trees being undocumented, it is simply > > missing a wrapper routine ala sysctlbyname(3) and a manpage. You could > > easily provide one and thus provide a facility for enumerating many different > > things than having several one-off oid_handler routines to enumerate > > subtrees. However, it is not some "backdoor" hack interface anymore than > > sysctlbyname(3) is. They are both equally hackish or non-hackish (depending > > on your point of view). > > This interface is about having a special tree for the hardware sensors, > with special rules regarding the namespace. What you suggest is that I > try to abandon this, but then why do you need this framework to start with? I suggest you think in layered abstractions. sysctl is a tool for creating a namespace that the kernel exports to userland. Let sysctl manage the namespace and the sensor code just populate nodes in the namespace and manage sensors. I did some thinking last night about what I would really want out of a sensors framework btw, and will send a mail to arch@ about that. The short version though is that I do think the existing sensors code has a lot of things right (The sensor structure seems very reasonable for example. I might have done 4 states rather than 3, but 3 is quite workable as is.) The major hangups I think are requiring sensors to be a kernel user interface rather than a userland interface and the idea that that is somehow more secure, but more on that in my e-mail to arch@. -- John Baldwin From owner-cvs-src@FreeBSD.ORG Wed Oct 17 13:45:44 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 86A3516A41B; Wed, 17 Oct 2007 13:45:44 +0000 (UTC) (envelope-from krion@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 59FDE13C45D; Wed, 17 Oct 2007 13:45:44 +0000 (UTC) (envelope-from krion@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9HDji9U080376; Wed, 17 Oct 2007 13:45:44 GMT (envelope-from krion@repoman.freebsd.org) Received: (from krion@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9HDji3R080375; Wed, 17 Oct 2007 13:45:44 GMT (envelope-from krion) Message-Id: <200710171345.l9HDji3R080375@repoman.freebsd.org> From: Kirill Ponomarew Date: Wed, 17 Oct 2007 13:45:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/pkg_install/lib lib.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 13:45:44 -0000 krion 2007-10-17 13:45:43 UTC FreeBSD src repository Modified files: usr.sbin/pkg_install/lib lib.h Log: Update for INDEX-8 support. Revision Changes Path 1.61 +3 -1 src/usr.sbin/pkg_install/lib/lib.h From owner-cvs-src@FreeBSD.ORG Wed Oct 17 13:47:10 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A46E216A419; Wed, 17 Oct 2007 13:47:10 +0000 (UTC) (envelope-from krion@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7AFD413C442; Wed, 17 Oct 2007 13:47:10 +0000 (UTC) (envelope-from krion@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9HDlAjs080436; Wed, 17 Oct 2007 13:47:10 GMT (envelope-from krion@repoman.freebsd.org) Received: (from krion@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9HDlAP9080435; Wed, 17 Oct 2007 13:47:10 GMT (envelope-from krion) Message-Id: <200710171347.l9HDlAP9080435@repoman.freebsd.org> From: Kirill Ponomarew Date: Wed, 17 Oct 2007 13:47:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/pkg_install/lib lib.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 13:47:10 -0000 krion 2007-10-17 13:47:10 UTC FreeBSD src repository Modified files: usr.sbin/pkg_install/lib lib.h Log: Add whitespace. Revision Changes Path 1.62 +1 -1 src/usr.sbin/pkg_install/lib/lib.h From owner-cvs-src@FreeBSD.ORG Wed Oct 17 14:06:05 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 09DB116A41A; Wed, 17 Oct 2007 14:06:05 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 258AD13C455; Wed, 17 Oct 2007 14:06:03 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A548C8.dip.t-dialin.net [84.165.72.200]) by redbull.bpaserver.net (Postfix) with ESMTP id C2FCE2E2A4; Wed, 17 Oct 2007 16:05:46 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 3726E5B480D; Wed, 17 Oct 2007 16:04:41 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.1/8.13.8/Submit) id l9HE4f4C090814; Wed, 17 Oct 2007 16:04:41 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Wed, 17 Oct 2007 16:04:40 +0200 Message-ID: <20071017160440.b6fd00xs6cog888g@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Wed, 17 Oct 2007 16:04:40 +0200 From: Alexander Leidinger To: Poul-Henning Kamp References: <13868.1192555960@critter.freebsd.dk> In-Reply-To: <13868.1192555960@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=5.696, required 8, BAYES_50 2.50, IMPRONONCABLE_2 1.50, J_CHICKENPOX_27 0.60, MIME_QP_LONG_LINE 1.40, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10, SMILEY -0.50) X-BPAnet-MailScanner-SpamScore: sssss X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: Wilko Bulte , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 14:06:05 -0000 Quoting Poul-Henning Kamp (from Tue, 16 Oct 2007 =20 17:32:40 +0000): > In message <20071016183311.lu97hbwzggsk4ow4@webmail.leidinger.net>, =20 > Alexander L > eidinger writes: > >>> Yes, that is the abstract argument, but the very same argument can >>> be made for every other single kind of entity which consumes or >>> produces bytes, from fingerprint readers to 9-track tape stations. >> >> Why do we have a common linked list API? It's easy enough to do it >> again and again and again... We have it because we don't want to do it >> again and again... And with the sensors API we gain something similar. > > There is a very big difference between and sensors, > in that is not an external API, but a convenience > tool for code to maintain its own data internally, whereas sensors > is an API for exporting data. The idea behind is the same. Don't do a lot by hand what can be done =20 with less work with an API. >> It adds meta-data which can be used in an automated way. This is done >> with a consistent and documented API. Sure, we can do it with sysctls >> by hand, but see above. > > What exactly do you mean when you say "used in an automated way" ? You can write a probe for a monitoring system, which has a look at =20 hw.sensors and based upon the data it sees there can generate at least =20 reports, without the need that the probe needs =20 to be changed to be able to handle sensors which wheren't seen before. > Can I run some magic program and tell it "alert me if something is > wrong" or do I have to write a tedious configuration file to explain > what "something is wrong" would look like to the program ? It depends on the magic program and the sensor. As Constantine already =20 explained and you surely know, there are stupid sensors and there are =20 smart sensors. >> It is not supposed to make the monitoring itself easier. >> [...] >> A human being still has to interprete the measurements. No doubts. But >> with the framework you don't have to hunt down where to read the >> sensor data, and how to name it. You can write a probe which takes >> everything in the the sensors mib and let it produce names and values >> for the probed things automatically. > > So the only problem sensors solves, is that it defines a single > place in the sysctl tree, where you can find all sorts of non-random > numbers, each of which comes with a piece of ascii text that isn't > formatted in any consistent way ? > > I'd say, lets raise the bar several notches right here. > > How about we look at what is desirable from such a subsystem, and > see what architecture that mandates ? Hmmm... "desirable" is not the same as "useful" or "necessary". Let's =20 try to not overengineer this. Note: I also think as long as we try to =20 not prevent the framework to be able to handle specific things which =20 we think are desirable, the framework doesn't need to be able to =20 handle all from day one. > Here are some things to think about: > > * Input only or input & output ? > > Would it make sense to be able to control the fans or power > to various subsystems while we are at it ? Apart from what Constantine said: Do you want to change the power of various subsystems? Isn't the =20 system supposed to do it itself in a sensible and automatic way? I =20 would say it depends. Most of the time I don't want to fight with =20 something like this in a production system (and AFAIK Intel tries to =20 do more and more themself regarding power control in their CPUs, as =20 they noticed that often the "messing around" with this is ... =20 suboptimal). > * It should be possible to implement a sensor in userland, so that > interface to external sensors is possible without forcing the > code into the kernel. Think: Maxim/Dallas 1-Wire temperature > sensors and similar. I see hw.sensors as a interface to get the data from sensoric data =20 which is within control of the kernel into the userland. I don't think =20 about it as something where "sensor" includes status info from =20 userland applications. I fail to see where it is beneficial to put =20 data which isn't measured by something in the kernel (e.g. the fill =20 level of a database or any other value an userland program produces). =20 Could you please explain why it should be possible to feed such =20 userland data into the kernel? > * Metadata information in machine redable format: > - recommended, min and max poll rate Typically the monitoring programs I know poll based upon a fixed rate. =20 The sensor framework caches already data, and it is up to the code =20 which puts the value into place to decide if the sensor has to be =20 queried again or not. > - Nominal value, quantization step and alarm limit(s) Alarm limits normally are set in the monitoring applications I know =20 and depend upon various factors. > - alarm transgression severity for system integrity How can a sensor know this? If it is about something which is in =20 active use, a violation of a specific value may be critical for the =20 entire system, but if it is just present in the system and not used at =20 all, crossing the same value may be not critical. In general this is a =20 policy decision which can not be solved by the person writting the =20 handover of this data to the sensor framework. > - sensorfailure severity for system integrity Dito. > - physical location of measured quantity Do you know monitoring programs which allow probes to submit this =20 information to the monitoring program? If not, why should the =20 framework allow to keep this information in the kernel when a file on =20 the system satisfies the same requirement? > ... So far the things you mentioned are better suited to be kept in the =20 userland, instead of in the kernel. A simple file which a specific =20 syntax would be enough to let a probe automatically match a specific =20 sensor with this metadata and let it transfer this to the monitoring =20 application (if the monitoring application is suited to accept this =20 kind of data). > * Event support ? > - enumeration, arrival and departure of sensors > - alarm transgressions > - sensor failure > ... > > * Interface and integration with IPMI, ACPI and similar. > Do any of these have a metadata format we can use ? Constantine answered those already. > and probably a lot of other stuff I didn't think of right now... > >> Now... how much hardware out there supports IPMI, or >> better... how much in production use doesn't use IPMI? > > But don't you think it would be better to have a subsystem that > made it possible to use IPMI and ACPI, than to just say "Naa, > that sucks, it must do, because we don't support it" ? I haven't said it doesn't support it, I told you already that Nate =20 didn't identify something in the sensors framework which prevents the =20 use of ACPI and the sensors framework, and Constantine already showed =20 how it integrates with IPMI. >>> Let me get this straight, you're telling me: >>> >>> =09"I'm worried about this code running as root, so I'm putting >>> =09it in the kernel instead." >> >> You missed the point. > > No, I most certainly did not. > > By defining the sensor API (on top of sysctl) at the kernel/userland > boundary you have decided that all sensor implementations must live > in the kernel, there is no room in your architecture for sensors > that live in userland. No, I didn't. I said (even last time when you first told us that you =20 don't like the sensors framework), that the sensors framework is =20 supposed to export data which lifes in the kernel to the userland. I =20 never said the sensors framework is supposed to be the one and only =20 way of getting status data from a running system. Userland status =20 belongs to userland programs. It would be nice to have a userland =20 framework which collects userland status, so that you don't have to =20 run around, and it may not be a bad idea that this userland framework =20 may collect also the data from the sensors framework (e.g. one plugin =20 to get all hw.sensors data, instead of multiple plugins to get all the =20 various states from the various places of a non-uniform status export =20 from kernel to userland). But here we talk about exporting data from =20 the kernel to the userland via an API, not about a userland framework =20 to collect status information (some people may say we already have =20 this with SNMP). > Effectively, you have elevated all sensor implementations to root++ > priviledge, even if they don't need any priviledge at all. No, I haven't, see above. > I don't care much about who wrote the code or how trustworthy they > are, that's a problem that can be fixed along the way. > > But I do care about taking away, by design, the choice of running > at low priviledge from people who implement sensors. I'm not taking this away. >>> I repeat: The SoC interface is not the gateway to -current. >> >> It provides an idea in what people are interested in. > > Sure, lets list "Peace in the middle-east" on there, I'm sure people > are interested :-) > > "People", whoever they are, are interested in anything that sounds > fancy or flashy, but that doesn't mean that they can or will actually > use it for anything if somebody produce it, and it certainly gives > no guarantee that you will not shoot yourself in the foot along the > way if you do so. You said you don't like the idea of an unified way of exporting sensor =20 data which lifes in the kernel to the userland. You didn't provide =20 technical arguments against such an API (I'm not taking lm.4 into =20 account ATM, as this was not your main objection). When the "People" =20 voted for this project, they voted for this idea, which seems to work =20 nice in OpenBSD. You failed so far to show that it doesn't work in =20 FreeBSD, while we've seen several examples where we get benefits from =20 it. I don't say the implementation is free of bugs, or can not be =20 improved, but you are not talking about code, you are talking about =20 the idea. You are slapping our fellow committers (I don't count myself =20 here) into the face, which voted in favour of this project. You are =20 doing the same with those people which didn't voted against this =20 project. >> And several >> committers here in the thread also showed interest in this framework >> (maybe not in the current implementation, but at least in the idea >> behind it). > > Right, but if we didn't object, you had saddled us with this implementatio= n, > without any actual discussion about what exactly the idea behind it > was and if that was the right idea for us. I wouldn't have saddled us with the implementation. I would have maybe =20 saddled us with the API for the lifetime of one released branch... if =20 nobody would have improved it in the next 18 months (when HEAD is =20 branched). I don't think your very negatively sounding sentence above =20 is deserved. The people voting in the GSoC are supposed to reject =20 ideas which they identify as being outright bad. And for projects they =20 vote for, they have a look if it makes sense. If it doesn't make =20 sense, they don't vote for a project. The big disconnection between =20 FreeBSD and the SOC you are trying to put here, is not the case. I =20 agree that not everything which is produced in the soc deserves it's =20 way into CVS. But what gets rejected to far is stuff which proved =20 during the soc to be not usable. Either because the architecture =20 doesn't fit, like with the pluggable disk schedulers when you =20 introduced GEOM and the project wasn't usable anymore, or because the =20 student missed the goal, or when the goal was achieved but the =20 implementation was a cruel, or when we noticed that the project needs =20 complete rearchitecture because the initial design doesn't fit. >> Just because you do not see how such a framework can be >> useful to you (so far I have the impression from your mails, that you >> object to the idea of this framework), > > I *can* see why and how such a framework can be useful, that's why > I'm objecting to this half-baked attempt at it. Now you sound differently than before. Before you said you don't like =20 the idea of such a framework at all. Some of the points you bring on =20 the table above look overengineered to me (I pointed them out). And so =20 far I wasn't able to identify a point there, which the sensors =20 framework prevents to implement. I also want to point out that so far =20 the goal was to do what is needed and evolutionary improve the =20 architecture/implementation, instead of trying to produce a big thing =20 with bells, whistles, trumpets and whatever (in Germany we call this =20 "eierlegendewollmichsau"). We all know that overengineered projects =20 typically fail, and that the evolutionary behavior in OpenSource =20 software produces very good results (e.g., SMP in 4.x was very good =20 for this time, and now as we have "more SMP" and raised expectations =20 we morphed into something better). Some of the things you want to have =20 for sensors looks nice. Some of this nice stuff doesn't belong into =20 the kernel. And I haven't seen something which can not be done with =20 the sensors framework in a next step. So far the sensors framework =20 allows to provide features we don't have in RELENG_x. >>> Ten years ago when we didn't have P4 and the _extensive_ infrastructure >>> for making it easy for people to work out of the tree, we had to do >>> stuff like that, but there is no excuse for it today. >> >> Nobody is perfect. There will always be some bugs when something is >> committed to -current. > > Bugs, yes, and we have means to deal with them. > > But we should try much harder to avoid half-baked concepts and wrong > architecture, because that is 10 times harder to fix than a plain > bug is. Feel free to point out wrong architecture. Regarding the half-baked =20 part... so far Constantine already showed what is possible to do from =20 the list you came up with. I still think you are fighting against the =20 framework based mostly upon feelings, and not based upon technical =20 facts. >> You don't talk about obvious problems here. >> There's no destabilized system, there are no panics. You talk about >> not using an underdocumented API and not using a generic framework for >> creating tasks [...] > > Yes, it does appear to me that we are not on the same level of > abstraction. > > I am indeed not talking about how many compiler warnings or style(9) > infractions this code has. gcc 4 introduced new warnings. Without compiling this with -Werror on =20 e.g. RELENG_6 with gcc 3, I don't think you should talk about compiler =20 warnings at the moment, as the kernel is on a similar level (in case =20 we don't compile with -Werror anymore). Regarding style(9) Constantine =20 made several commits in p4 during the soc. > I'm talking about: > - if it actually solves a problem for us that we have. Yes. > - if if should solve more problems than it does right now. As you have seen it already does more than you think it is able to do. > - if it creates even more problems down the road. Have you identified some problems? > I'm talking about architecture, you're talking about code. Wrong. I never said the code is without the possibility to improve it =20 or that it is free of flaws. I'm talking about your behavior of =20 rejecting the idea (not even the architecture, but the idea) of the =20 sensors framework without accepting that other people see a benefit in =20 such a framework and calling it crap without comming up with technical =20 reasons. I'm also talking about the idea of the framework and what it =20 is supposed to do whiel you say that you don't like the idea. I may =20 also have talked about parts of the code, but it is wrong to say that =20 I focus on the code. And I'm also the wrong person to talk about the =20 code, Constantine is the person to talk with if it is about the code. Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 No one can feel as helpless as the owner of a sick goldfish. From owner-cvs-src@FreeBSD.ORG Wed Oct 17 14:32:51 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7A45016A418; Wed, 17 Oct 2007 14:32:51 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id E55E213C480; Wed, 17 Oct 2007 14:32:50 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A548C8.dip.t-dialin.net [84.165.72.200]) by redbull.bpaserver.net (Postfix) with ESMTP id C0C862E308; Wed, 17 Oct 2007 16:32:08 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 1E01F5B480D; Wed, 17 Oct 2007 16:31:03 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.1/8.13.8/Submit) id l9HEV2vN095200; Wed, 17 Oct 2007 16:31:02 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Wed, 17 Oct 2007 16:31:02 +0200 Message-ID: <20071017163102.jkl3sdzww8wkscw0@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Wed, 17 Oct 2007 16:31:02 +0200 From: Alexander Leidinger To: John Baldwin References: <200710161702.00008.jhb@freebsd.org> <471537CA.9080807@FreeBSD.org> <200710170907.07832.jhb@freebsd.org> In-Reply-To: <200710170907.07832.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-12.804, required 8, BAYES_00 -15.00, J_CHICKENPOX_27 0.60, MIME_QP_LONG_LINE 1.40, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10) X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, "Constantine A. Murenin" , Poul-Henning Kamp , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 14:32:51 -0000 Quoting John Baldwin (from Wed, 17 Oct 2007 09:07:06 -0400= ): > On Tuesday 16 October 2007 06:14:34 pm Constantine A. Murenin wrote: >> On 16/10/2007 17:01, John Baldwin wrote: >> > Basically, by having so little data in hw.sensors if I had to write a R= AID >> > monitoring daemon I would just not use hw.sensors since it's =20 >> easier for me to >> > figure out the simple status myself based on the other state I =20 >> already have >> > to track (unless you write an event-driven daemon based on =20 >> messages posted by >> > the firmware in which case again you wouldn't use hw.sensors for =20 >> that either). >> >> There is no other daemon that you'd need, you'd simply use sensorsd for >> this. You could write a script that would be executed by sensorsd if a >> certain logical disc drive sensor changes state, and then this script >> would call the bio framework and give you additional details on why the >> state was changed. > > That's actually not quite good enough as, for example, I want to keep yell= ing > about a busted volume on a periodic basis until its fixed. Also, =20 > having a volume > change state doesn't tell me if a drive was pulled. On at least one RAID > controller firmware I am familiar with, the only way you can figure =20 > this out is > to keep track of which drives are currently present with a =20 > generation count and > use that to determine when a drive goes away. Even my monitoring daemon f= or > ata-raid has to do this since the ata(4) driver just detaches and =20 > removes a drive > when it fails and you have no way to figure out which drive died as =20 > the kernel > thinks that drive no longer exists. Note, talking about interaction with bio or similar is not productive =20 ATM. On Sunday I had a discussion with scottl and he identified some =20 things with bio which don't make it a good choice for FreeBSD. =20 Unfortunately I didn't had time to take it off the ideas list so far. =20 Scott also agreed to come up with a description for a similar =20 framework that is is usable with our RAID drivers. Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 Mother is far too clever to understand anything she does not like. =09=09-- Arnold Bennett From owner-cvs-src@FreeBSD.ORG Wed Oct 17 15:05:03 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3E02116A420; Wed, 17 Oct 2007 15:05:03 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id D021813C494; Wed, 17 Oct 2007 15:05:02 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l9HF4p7U079964; Wed, 17 Oct 2007 09:04:52 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <47162487.2090408@samsco.org> Date: Wed, 17 Oct 2007 09:04:39 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: Alexander Leidinger References: <200710161702.00008.jhb@freebsd.org> <471537CA.9080807@FreeBSD.org> <200710170907.07832.jhb@freebsd.org> <20071017163102.jkl3sdzww8wkscw0@webmail.leidinger.net> In-Reply-To: <20071017163102.jkl3sdzww8wkscw0@webmail.leidinger.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Wed, 17 Oct 2007 09:04:52 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: src-committers@freebsd.org, John Baldwin , cvs-src@freebsd.org, cvs-all@freebsd.org, "Constantine A. Murenin" , Poul-Henning Kamp , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 15:05:03 -0000 Alexander Leidinger wrote: > Quoting John Baldwin (from Wed, 17 Oct 2007 09:07:06 > -0400): > >> On Tuesday 16 October 2007 06:14:34 pm Constantine A. Murenin wrote: >>> On 16/10/2007 17:01, John Baldwin wrote: > >>> > Basically, by having so little data in hw.sensors if I had to write >>> a RAID >>> > monitoring daemon I would just not use hw.sensors since it's >>> easier for me to >>> > figure out the simple status myself based on the other state I >>> already have >>> > to track (unless you write an event-driven daemon based on >>> messages posted by >>> > the firmware in which case again you wouldn't use hw.sensors for >>> that either). >>> >>> There is no other daemon that you'd need, you'd simply use sensorsd for >>> this. You could write a script that would be executed by sensorsd if a >>> certain logical disc drive sensor changes state, and then this script >>> would call the bio framework and give you additional details on why the >>> state was changed. >> >> That's actually not quite good enough as, for example, I want to keep >> yelling >> about a busted volume on a periodic basis until its fixed. Also, >> having a volume >> change state doesn't tell me if a drive was pulled. On at least one RAID >> controller firmware I am familiar with, the only way you can figure >> this out is >> to keep track of which drives are currently present with a generation >> count and >> use that to determine when a drive goes away. Even my monitoring >> daemon for >> ata-raid has to do this since the ata(4) driver just detaches and >> removes a drive >> when it fails and you have no way to figure out which drive died as >> the kernel >> thinks that drive no longer exists. > > Note, talking about interaction with bio or similar is not productive > ATM. On Sunday I had a discussion with scottl and he identified some > things with bio which don't make it a good choice for FreeBSD. > Unfortunately I didn't had time to take it off the ideas list so far. > Scott also agreed to come up with a description for a similar framework > that is is usable with our RAID drivers. > John has the most recent experience of anyone with writing RAID monitoring and control tools, and he's brought up some very good points with about some of the specific technical challenges. A simple sysctl tree like hw.sensors is stateless, and that doesn't cut it for an environment where devices can come and go. More intelligence and state is needed, and for that you need an event component to your framework. I still have no strong opinion on whether FreeBSD-specific APIs like sysctl and devd are the right mechanisms for this. Maybe when it comes to the storage side of monitoring, consolidating all information under GEOM via /dev/geom.ctl is the right path, or maybe it isn't. But ultimately, what works for lmsensors or CPU throttling or arbitrary 1 wire or 3 wire buses might not work for a more complex system like storage. Scott From owner-cvs-src@FreeBSD.ORG Wed Oct 17 15:26:32 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BFE4616A419; Wed, 17 Oct 2007 15:26:32 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 62A0D13C468; Wed, 17 Oct 2007 15:26:32 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 4AD771A4D80; Wed, 17 Oct 2007 08:26:32 -0700 (PDT) Date: Wed, 17 Oct 2007 08:26:32 -0700 From: Alfred Perlstein To: Dag-Erling Sm??rgrav Message-ID: <20071017152632.GN31826@elvis.mu.org> References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> <20071016102013.GE23043@submonkey.net> <4714F06B.7070702@FreeBSD.org> <20071016225906.GK23043@submonkey.net> <20071017122837.GM31826@elvis.mu.org> <86y7e1ex9i.fsf@ds4.des.no> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86y7e1ex9i.fsf@ds4.des.no> User-Agent: Mutt/1.4.2.3i Cc: Stefan Esser , cvs-src@FreeBSD.org, Ceri Davies , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 15:26:32 -0000 * Dag-Erling Sm??rgrav [071017 05:33] wrote: > Alfred Perlstein writes: > > Ceri Davies writes: > > > While userland can tell if a filesystem is pseudo or not, (see > > > lsvfs), I'm not sure that we can reliably tell whether a device is > > > removable or not (cf. my camera, USB key, iPod, etc.). > > fstab(5) gives some hints, "noauto" would be a giveaway as well as > > value of 0 for 'fs_passno' is also a hint. > > No, fs_passno is pretty much always zero except for UFS / UFS2. That is because we do not have checkers for the filesystems which we should. -- - Alfred Perlstein From owner-cvs-src@FreeBSD.ORG Wed Oct 17 15:51:04 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3D30416A419; Wed, 17 Oct 2007 15:51:04 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from mojo.ru (mojo.ru [84.252.152.63]) by mx1.freebsd.org (Postfix) with ESMTP id 806E013C455; Wed, 17 Oct 2007 15:51:03 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from [192.168.0.16] (nc-76-6-108-199.dhcp.embarqhsd.net [76.6.108.199]) (authenticated bits=0) by mojo.ru (8.12.11.20060308/8.12.10) with ESMTP id l9HFojoW013882 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 17 Oct 2007 19:50:48 +0400 Message-ID: <47162F40.8000203@FreeBSD.org> Date: Wed, 17 Oct 2007 11:50:24 -0400 From: "Constantine A. Murenin" Organization: Google Summer of Code 2007 Student @ The FreeBSD Project User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.5) Gecko/20041217 X-Accept-Language: en-gb, en-gb-oed, en, en-us, ru, ru-ru, ru-su MIME-Version: 1.0 To: John Baldwin References: <200710161702.00008.jhb@freebsd.org> <471537CA.9080807@FreeBSD.org> <200710170907.07832.jhb@freebsd.org> In-Reply-To: <200710170907.07832.jhb@freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Scott Long , src-committers@FreeBSD.org, Alexander Leidinger , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, "Constantine A. Murenin" , Poul-Henning Kamp , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 15:51:04 -0000 On 17/10/2007 09:07, John Baldwin wrote: > On Tuesday 16 October 2007 06:14:34 pm Constantine A. Murenin wrote: > >>On 16/10/2007 17:01, John Baldwin wrote: >> >> >>>On Monday 15 October 2007 10:57:48 pm Constantine A. Murenin wrote: >>> >>> >>>>On 15/10/2007, John Baldwin wrote: >>>> >>>> >>>>>On Monday 15 October 2007 09:43:21 am Alexander Leidinger wrote: >>>>> >>>>> >>>>>>Quoting Scott Long (from Mon, 15 Oct 2007 >>>>> >>>>>01:47:59 -0600): >>>>> >>>>> >>>>>>>Alexander Leidinger wrote: >>>>>>> >>>>>>> >>>>>>>>Quoting Poul-Henning Kamp (from Sun, 14 Oct >>>>>>>>2007 17:54:21 +0000): >>>>>> >>>>>>>>>listen to the various mumblings about putting RAID-controller status >>>>>>>>>under sensors framework. >>>>>>>> >>>>>>>>What's wrong with this? Currently each RAID driver has to come up >>>>>>>>with his own way of displaying the RAID status. It's like saying >>>>>>>>that each network driver has to implement/display the stuff you can >>>>>>>>see with ifconfig in its own way, instead of using the proper >>>>>>>>network driver interface for this. >>>>>>>> >>>>>>> >>>>>>>For the love of God, please don't use RAID as an example to support >>> >>>your >>> >>> >>>>>>>argument for the sensord framework. Representing RAID state is >>> >>>several >>> >>> >>>>>>>orders of magnitude more involved than representing network state. >>>>>>>There are also landmines in the OpenBSD bits of RAID support that are >>>>>>>best left out of FreeBSD, unless you like alienating vendors and >>> >>>risking >>> >>> >>>>>>>legal action. Leave it alone. Please. I don't care what you do with >>>>>>>lmsensors or cpu power settings or whatever. Leave RAID out of it. >>>>>> >>>>>>Talking about RAID status is not talking about alienating vendors. I >>>>>>don't talk about alienating vendors and I don't intent to do. You may >>>>>>not be able to display a full blown RAID status with the sensors >>>>>>framework, but it allows for a generic "wors/works not" or >>>>>>"OK/degraded" status display in drivers we have the source for. This >>>>>>is enough for status monitoring (e.g., nagios). >>>>> >>>>>As I mentioned in the thread on arch@ where people brought up objections >>> >>>that >>> >>> >>>>>were apparently completely ignored, this is far from useful for RAID >>>>>monitoring. For example, if my RAID is down, which disk do I need to >>>>>replace? Again, all this was covered earlier and (apparently) ignored. >>>>>Also, what strikes me as odd is that I didn't see this patch posted again >>> >>>for >>> >>> >>>>>review this time around before it was committed. >>>> >>>>This has been addressed back in July. You'd use bioctl to see which >>>>exact disc needs to be replaced. Sensorsd is intended for an initial >>>>alert about something being wrong. >>> >>> >>>In July you actually said you weren't sure about bioctl(8). :) But also, this >>>model really isn't very sufficient since it doesn't handle things like drives >>>going away, etc. You really need to maintain a decent amount of state to >>>keep all that, and this is far easier done in userland rather than in the >>>kernel. However, you can choose to ignore real-world experience if you >>>choose. >>> >>>Basically, by having so little data in hw.sensors if I had to write a RAID >>>monitoring daemon I would just not use hw.sensors since it's easier for me to >>>figure out the simple status myself based on the other state I already have >>>to track (unless you write an event-driven daemon based on messages posted by >>>the firmware in which case again you wouldn't use hw.sensors for that either). >> >>There is no other daemon that you'd need, you'd simply use sensorsd for >>this. You could write a script that would be executed by sensorsd if a >>certain logical disc drive sensor changes state, and then this script >>would call the bio framework and give you additional details on why the >>state was changed. > > > That's actually not quite good enough as, for example, I want to keep yelling > about a busted volume on a periodic basis until its fixed. Also, having a volume > change state doesn't tell me if a drive was pulled. On at least one RAID > controller firmware I am familiar with, the only way you can figure this out is > to keep track of which drives are currently present with a generation count and > use that to determine when a drive goes away. Even my monitoring daemon for > ata-raid has to do this since the ata(4) driver just detaches and removes a drive > when it fails and you have no way to figure out which drive died as the kernel > thinks that drive no longer exists. As I said back in July, I'm not terribly familiar with RAID, but I don't see why you can't accomplish this with the sensors framework. You didn't quote my other part of the reply about the ntpd/sensors.c example. You can use the sensors framework in the same way as ntpd does, e.g. you can send repeated warnings as long as one of the logical drive sensors is not in an OK state. In sensorsd.conf, you'd simply say "drive:istatus", and sensorsd won't bother you with duplicate warnings, since your own application will provide them more appropriately. Or such feature about repeated warnings about things not being in an OK state can always be added to sensorsd, too. C. From owner-cvs-src@FreeBSD.ORG Wed Oct 17 16:07:10 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB75A16A468; Wed, 17 Oct 2007 16:07:10 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9FC9113C481; Wed, 17 Oct 2007 16:07:10 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9HG7Ar7007587; Wed, 17 Oct 2007 16:07:10 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9HG7Alk007586; Wed, 17 Oct 2007 16:07:10 GMT (envelope-from jhb) Message-Id: <200710171607.l9HG7Alk007586@repoman.freebsd.org> From: John Baldwin Date: Wed, 17 Oct 2007 16:07:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/nfsclient nfs_subs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 16:07:10 -0000 jhb 2007-10-17 16:07:10 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/nfsclient nfs_subs.c Log: MFC: Fix for a race where out of order loading of NFS attrs into the nfsnode could lead to attrs being stale. Revision Changes Path 1.140.2.3 +17 -1 src/sys/nfsclient/nfs_subs.c From owner-cvs-src@FreeBSD.ORG Wed Oct 17 16:15:52 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A21A116A418 for ; Wed, 17 Oct 2007 16:15:52 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from spacemail1-out.mgmt.space.net (spacemail1-out.mgmt.Space.Net [194.97.149.146]) by mx1.freebsd.org (Postfix) with ESMTP id 2251E13C465 for ; Wed, 17 Oct 2007 16:15:51 +0000 (UTC) (envelope-from se@FreeBSD.org) X-SpaceNet-SBRS: None X-IronPort-AV: E=Sophos;i="4.21,290,1188770400"; d="scan'208";a="73731243" Received: from mail.atsec.com ([195.30.252.105]) by spacemail1-out.mgmt.space.net with ESMTP; 17 Oct 2007 18:15:11 +0200 Received: from [10.2.2.88] (frueh.atsec.com [217.110.13.170]) (Authenticated sender: se@atsec.com) by mail.atsec.com (Postfix) with ESMTP id ACCEB91C5FB; Wed, 17 Oct 2007 18:15:09 +0200 (CEST) Message-ID: <4716350B.90004@FreeBSD.org> Date: Wed, 17 Oct 2007 18:15:07 +0200 From: Stefan Esser User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Alfred Perlstein References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> <20071016102013.GE23043@submonkey.net> <4714F06B.7070702@FreeBSD.org> <20071016225906.GK23043@submonkey.net> <20071017122837.GM31826@elvis.mu.org> In-Reply-To: <20071017122837.GM31826@elvis.mu.org> X-Enigmail-Version: 0.95.3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, Ceri Davies , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 16:15:52 -0000 Alfred Perlstein wrote: > * Ceri Davies [071016 15:59] wrote: >> While userland can tell if a filesystem is pseudo or not, (see lsvfs), >> I'm not sure that we can reliably tell whether a device is removable or >> not (cf. my camera, USB key, iPod, etc.). > > fstab(5) gives some hints, "noauto" would be a giveaway as well as > value of 0 for 'fs_passno' is also a hint. Hmmm, file systems with noauto could be added to $PRUNEPATHS, I guess. But I'm against too much magic behind the scenes, since that may lead to violation of the POLA. I'll give it a try, anyway ... Other sub-directories exist that should be kept out of the locate db like /var/spool for example. Probably there are many more ... Regards, STefan From owner-cvs-src@FreeBSD.ORG Wed Oct 17 16:21:54 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1309C16A478; Wed, 17 Oct 2007 16:21:54 +0000 (UTC) (envelope-from ticso@cicely12.cicely.de) Received: from raven.bwct.de (raven.bwct.de [85.159.14.73]) by mx1.freebsd.org (Postfix) with ESMTP id 9E05013C469; Wed, 17 Oct 2007 16:21:53 +0000 (UTC) (envelope-from ticso@cicely12.cicely.de) Received: from cicely5.cicely.de ([10.1.1.7]) by raven.bwct.de (8.13.4/8.13.4) with ESMTP id l9HFqWZI059252; Wed, 17 Oct 2007 17:52:32 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: from cicely12.cicely.de (cicely12.cicely.de [10.1.1.14]) by cicely5.cicely.de (8.13.4/8.13.4) with ESMTP id l9HFqQCD081701 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 17 Oct 2007 17:52:26 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: from cicely12.cicely.de (localhost [127.0.0.1]) by cicely12.cicely.de (8.13.4/8.13.3) with ESMTP id l9HFqPcx039004; Wed, 17 Oct 2007 17:52:25 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: (from ticso@localhost) by cicely12.cicely.de (8.13.4/8.13.3/Submit) id l9HFqPck039003; Wed, 17 Oct 2007 17:52:25 +0200 (CEST) (envelope-from ticso) Date: Wed, 17 Oct 2007 17:52:25 +0200 From: Bernd Walter To: Poul-Henning Kamp , Alexander Leidinger Message-ID: <20071017155225.GU17048@cicely12.cicely.de> References: <24712.1192384461@critter.freebsd.dk> <20071015081507.yi9t4ot8asg0wcw4@webmail.leidinger.net> <20071014172115.GA24318@freebie.xs4all.nl> <24712.1192384461@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071015081507.yi9t4ot8asg0wcw4@webmail.leidinger.net> <24712.1192384461@critter.freebsd.dk> X-Operating-System: FreeBSD cicely12.cicely.de 5.4-STABLE alpha User-Agent: Mutt/1.5.9i X-Spam-Status: No, score=-4.3 required=5.0 tests=ALL_TRUSTED=-1.8, AWL=0.139, BAYES_00=-2.599 autolearn=ham version=3.1.7 X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on cicely12.cicely.de Cc: Wilko Bulte , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: ticso@cicely.de List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 16:21:54 -0000 On Sun, Oct 14, 2007 at 05:54:21PM +0000, Poul-Henning Kamp wrote: > And IFF we add such an amount of code to FreeBSD, we want to have it > properly integrate into our kernel, using our device discovery > and registration (newbus) and not probing random (i2c) busses willy > nilly. If it is really probing i2c busses then I fully agree with Poul and be strictly against this, because you _can't_ probe an i2c bus without risking major side effects. You can almost have a probing effect by doing 0-byte write access, but you still have to guess the device from the i2c address, which is not safe in many situations. For example in the embedded world we can have an i2c system with commonly used addresses reused for different purpose. Another example is that there are i2c switches used on alpha systems, such as the AS4100 - we never supported i2c on alpha, but this doesn't mean that other systems don't use it as well. Yet another example are the famous atmel eeprom chips used in some IBM notebooks which died on such an access. Then we have a bug on some i2c controllers (namely the twi in Atmel ARM9 chips), which makes it impossible to safely get the ack state on addressing. On Mon, Oct 15, 2007 at 08:15:07AM +0200, Alexander Leidinger wrote: > Quoting Poul-Henning Kamp (from Sun, 14 Oct 2007 > 17:54:21 +0000): > Could you please explain how you want to integrate devices with > newbus, which are only accessible via the i2c bus? Feel free to show > us example code for one of those of our drivers which access the i2c > bus, which already existed before this commit. For example the ds1672 driver (sys/dev/iicbus/ds1672.c) writen by sam: at91_twi0 iicbus0 [...] ds16720 at addr=0xd0 [...] The device name is a bit unfortunate - it consists of ds1672 beeing the driver name and 0 beeing the instance, but this is unrelated. The DS1672 is used as an RTC for some ARM boards, but it is written machine independend. -- B.Walter http://www.bwct.de http://www.fizon.de bernd@bwct.de info@bwct.de support@fizon.de From owner-cvs-src@FreeBSD.ORG Wed Oct 17 16:49:38 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B3A4616A419; Wed, 17 Oct 2007 16:49:38 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id 8894C13C457; Wed, 17 Oct 2007 16:49:38 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.1/8.14.1) with ESMTP id l9HGnbvo098095; Wed, 17 Oct 2007 09:49:37 -0700 (PDT) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.1/8.14.1/Submit) id l9HGnbOI098094; Wed, 17 Oct 2007 09:49:37 -0700 (PDT) (envelope-from obrien) Date: Wed, 17 Oct 2007 09:49:37 -0700 From: "David O'Brien" To: Alexey Dokuchaev Message-ID: <20071017164937.GB95535@dragon.NUXI.org> References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> <20071016102013.GE23043@submonkey.net> <4714F06B.7070702@FreeBSD.org> <20071017103509.GA71990@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071017103509.GA71990@FreeBSD.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.16 (2007-06-09) Cc: Ceri Davies , cvs-src@FreeBSD.org, Stefan Esser , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 16:49:38 -0000 On Wed, Oct 17, 2007 at 10:35:10AM +0000, Alexey Dokuchaev wrote: > It might be a good idea to drop msdosfs off of this list. Real physical > filesystems in Windoze world are typically NTFS now, and FAT is used > mainly in removable storage. Not nessisarly - vfat/fat32 is the only reliable FS that can be shared between FreeBSD and MS-Windows (and Linux). I use a FAT FS on my laptop for just this reason. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Wed Oct 17 17:22:57 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EDAB216A417; Wed, 17 Oct 2007 17:22:57 +0000 (UTC) (envelope-from gad@FreeBSD.org) Received: from smtp6.server.rpi.edu (smtp6.server.rpi.edu [128.113.2.226]) by mx1.freebsd.org (Postfix) with ESMTP id 8EC8C13C465; Wed, 17 Oct 2007 17:22:57 +0000 (UTC) (envelope-from gad@FreeBSD.org) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp6.server.rpi.edu (8.13.1/8.13.1) with ESMTP id l9HHMrBG026789; Wed, 17 Oct 2007 13:22:55 -0400 Mime-Version: 1.0 Message-Id: In-Reply-To: <4716350B.90004@FreeBSD.org> References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> <20071016102013.GE23043@submonkey.net> <4714F06B.7070702@FreeBSD.org> <20071016225906.GK23043@submonkey.net> <20071017122837.GM31826@elvis.mu.org> <4716350B.90004@FreeBSD.org> Date: Wed, 17 Oct 2007 13:22:52 -0400 To: Stefan Esser , Alfred Perlstein From: Garance A Drosehn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-RPI-SA-Score: undef - spam scanning disabled X-CanItPRO-Stream: default X-Canit-Stats-ID: Bayes signature not available X-Scanned-By: CanIt (www . roaringpenguin . com) on 128.113.2.226 Cc: cvs-src@FreeBSD.org, Ceri Davies , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 17:22:58 -0000 At 6:15 PM +0200 10/17/07, Stefan Esser wrote: >Alfred Perlstein wrote: >> * Ceri Davies [071016 15:59] wrote: >>> While userland can tell if a filesystem is pseudo or not, (see lsvfs), >>> I'm not sure that we can reliably tell whether a device is removable or >>> not (cf. my camera, USB key, iPod, etc.). >> >> fstab(5) gives some hints, "noauto" would be a giveaway as well as >> value of 0 for 'fs_passno' is also a hint. > >Hmmm, file systems with noauto could be added to $PRUNEPATHS, I guess. >But I'm against too much magic behind the scenes, since that may lead >to violation of the POLA. I'll give it a try, anyway ... I would not base locate.db decisions based on the setting of noauto. Sysadmins set noauto because they don't want the filesystem to be automatically mounted. We should not assume we know *why* they do not want it mounted. If you wanted to add some new mount option of 'nolocate', then we could use that value. But the noauto option has nothing to do with the locate command. -- Garance Alistair Drosehn = drosehn@rpi.edu Senior Systems Programmer or gad@FreeBSD.org Rensselaer Polytechnic Institute; Troy, NY; USA From owner-cvs-src@FreeBSD.ORG Wed Oct 17 17:30:46 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E9A1416A420; Wed, 17 Oct 2007 17:30:46 +0000 (UTC) (envelope-from ivoras@freebsd.org) Received: from ls405.t-com.hr (ls405.t-com.hr [195.29.150.135]) by mx1.freebsd.org (Postfix) with ESMTP id 5DE1F13C448; Wed, 17 Oct 2007 17:30:46 +0000 (UTC) (envelope-from ivoras@freebsd.org) Received: from ls248.t-com.hr (ls248.t-com.hr [195.29.150.237]) by ls405.t-com.hr (Postfix) with ESMTP id 53EDD39315; Wed, 17 Oct 2007 19:09:21 +0200 (CEST) Received: from ls248.t-com.hr (localhost.localdomain [127.0.0.1]) by ls248.t-com.hr (Qmlai) with ESMTP id 50A77D5004A; Wed, 17 Oct 2007 19:09:21 +0200 (CEST) Received: from ls248.t-com.hr (localhost.localdomain [127.0.0.1]) by ls248.t-com.hr (Qmlai) with ESMTP id 3AECBD50047; Wed, 17 Oct 2007 19:09:21 +0200 (CEST) X-Envelope-Sender: ivoras@freebsd.org Received: from [10.0.0.100] (89-172-55-34.adsl.net.t-com.hr [89.172.55.34]) by ls248.t-com.hr (Qmali) with ESMTP id 9646E5E0198; Wed, 17 Oct 2007 19:09:16 +0200 (CEST) Message-ID: <471641BA.1040002@freebsd.org> Date: Wed, 17 Oct 2007 19:09:14 +0200 From: Ivan Voras User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: obrien@FreeBSD.org References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> <20071016102013.GE23043@submonkey.net> <4714F06B.7070702@FreeBSD.org> <20071017103509.GA71990@FreeBSD.org> <20071017164937.GB95535@dragon.NUXI.org> In-Reply-To: <20071017164937.GB95535@dragon.NUXI.org> X-Enigmail-Version: 0.95.3 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig2F0E0E62DCC0124F6C4AFB3A" Cc: Alexey Dokuchaev , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Stefan Esser , Ceri Davies Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 17:30:47 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2F0E0E62DCC0124F6C4AFB3A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable David O'Brien wrote: > On Wed, Oct 17, 2007 at 10:35:10AM +0000, Alexey Dokuchaev wrote: >> It might be a good idea to drop msdosfs off of this list. Real physic= al >> filesystems in Windoze world are typically NTFS now, and FAT is used >> mainly in removable storage. >=20 > Not nessisarly - vfat/fat32 is the only reliable FS that can be shared > between FreeBSD and MS-Windows (and Linux). I use a FAT FS on my lapto= p > for just this reason. Well, there's another one :) I've been running it in that mode (FreeBSD+Linux+Windows) for 2+ years without problems. No journaling, though. --------------enig2F0E0E62DCC0124F6C4AFB3A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHFkG6ldnAQVacBcgRAjOpAJ4+PtlsAxtgIf/XUunbMxslByFk6gCg6Mbo wPHwcueKjgkfEiDCj+ks0E0= =Se0X -----END PGP SIGNATURE----- --------------enig2F0E0E62DCC0124F6C4AFB3A-- From owner-cvs-src@FreeBSD.ORG Wed Oct 17 17:51:31 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2BB0B16A419; Wed, 17 Oct 2007 17:51:31 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 1732A13C45B; Wed, 17 Oct 2007 17:51:31 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9HHpUPQ023673; Wed, 17 Oct 2007 17:51:30 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9HHpTFY023672; Wed, 17 Oct 2007 17:51:29 GMT (envelope-from delphij) Message-Id: <200710171751.l9HHpTFY023672@repoman.freebsd.org> From: Xin LI Date: Wed, 17 Oct 2007 17:51:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml src/contrib/less NEWS README charset.c less.man less.nro lessecho.man lessecho.nro lesskey.man lesskey.nro version.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 17:51:31 -0000 delphij 2007-10-17 17:51:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) release/doc/en_US.ISO8859-1/relnotes article.sgml contrib/less NEWS README charset.c less.man less.nro lessecho.man lessecho.nro lesskey.man lesskey.nro version.c Log: MFC: less v409. Approved by: re (kensmith) Revision Changes Path 1.1.1.8.2.1 +4 -1 src/contrib/less/NEWS 1.1.1.8.2.1 +2 -2 src/contrib/less/README 1.1.1.6.2.1 +7 -5 src/contrib/less/charset.c 1.1.1.8.2.1 +1 -1 src/contrib/less/less.man 1.1.1.8.2.1 +1 -1 src/contrib/less/less.nro 1.1.1.4.2.1 +1 -1 src/contrib/less/lessecho.man 1.1.1.4.2.1 +1 -1 src/contrib/less/lessecho.nro 1.1.1.8.2.1 +1 -1 src/contrib/less/lesskey.man 1.1.1.8.2.1 +1 -1 src/contrib/less/lesskey.nro 1.1.1.8.2.1 +2 -1 src/contrib/less/version.c 1.1068.2.2 +1 -1 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml From owner-cvs-src@FreeBSD.ORG Wed Oct 17 17:52:32 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3362F16A419; Wed, 17 Oct 2007 17:52:32 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 08C5313C46A; Wed, 17 Oct 2007 17:52:32 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9HHqVKC023716; Wed, 17 Oct 2007 17:52:31 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9HHqVtP023715; Wed, 17 Oct 2007 17:52:31 GMT (envelope-from delphij) Message-Id: <200710171752.l9HHqVtP023715@repoman.freebsd.org> From: Xin LI Date: Wed, 17 Oct 2007 17:52:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 17:52:32 -0000 delphij 2007-10-17 17:52:31 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes article.sgml Log: Mention that less was upgraded to 409. Revision Changes Path 1.1070 +1 -1 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml From owner-cvs-src@FreeBSD.ORG Wed Oct 17 18:41:59 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2BC3F16A417; Wed, 17 Oct 2007 18:41:59 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id DBA4C13C4B6; Wed, 17 Oct 2007 18:41:58 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 88A5846EDD; Wed, 17 Oct 2007 14:41:58 -0400 (EDT) Date: Wed, 17 Oct 2007 19:41:58 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Stefan Esser In-Reply-To: <4716350B.90004@FreeBSD.org> Message-ID: <20071017193822.Y60783@fledge.watson.org> References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> <20071016102013.GE23043@submonkey.net> <4714F06B.7070702@FreeBSD.org> <20071016225906.GK23043@submonkey.net> <20071017122837.GM31826@elvis.mu.org> <4716350B.90004@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Ceri Davies , cvs-src@FreeBSD.org, Alfred Perlstein , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 18:41:59 -0000 On Wed, 17 Oct 2007, Stefan Esser wrote: > Alfred Perlstein wrote: >> * Ceri Davies [071016 15:59] wrote: >>> While userland can tell if a filesystem is pseudo or not, (see lsvfs), I'm >>> not sure that we can reliably tell whether a device is removable or not >>> (cf. my camera, USB key, iPod, etc.). >> >> fstab(5) gives some hints, "noauto" would be a giveaway as well as value of >> 0 for 'fs_passno' is also a hint. > > Hmmm, file systems with noauto could be added to $PRUNEPATHS, I guess. But > I'm against too much magic behind the scenes, since that may lead to > violation of the POLA. I'll give it a try, anyway ... > > Other sub-directories exist that should be kept out of the locate db like > /var/spool for example. Probably there are many more ... Another possibility here is to add a noindex flag to fstab/mount options and to explicitly mark things that locate (and things that might follow locate) shouldn't index in addition to network file systems. Desktop auto-mounters could set the flag automatically. I also find myself a bit nervous about heuristics that think certain file systems might be removable devices implicitly, or certain types of drives, etc. Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Wed Oct 17 18:46:21 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3EC6816A41A; Wed, 17 Oct 2007 18:46:21 +0000 (UTC) (envelope-from ivoras@freebsd.org) Received: from ls405.t-com.hr (ls405.t-com.hr [195.29.150.135]) by mx1.freebsd.org (Postfix) with ESMTP id AB18A13C467; Wed, 17 Oct 2007 18:46:20 +0000 (UTC) (envelope-from ivoras@freebsd.org) Received: from ls248.t-com.hr (ls248.t-com.hr [195.29.150.237]) by ls405.t-com.hr (Postfix) with ESMTP id 307D03978B; Wed, 17 Oct 2007 20:46:19 +0200 (CEST) Received: from ls248.t-com.hr (localhost.localdomain [127.0.0.1]) by ls248.t-com.hr (Qmlai) with ESMTP id 2C7F1D50047; Wed, 17 Oct 2007 20:46:19 +0200 (CEST) Received: from ls248.t-com.hr (localhost.localdomain [127.0.0.1]) by ls248.t-com.hr (Qmlai) with ESMTP id 16489D5005E; Wed, 17 Oct 2007 20:46:19 +0200 (CEST) X-Envelope-Sender: ivoras@freebsd.org Received: from [10.0.0.100] (89-172-55-34.adsl.net.t-com.hr [89.172.55.34]) by ls248.t-com.hr (Qmali) with ESMTP id ACEB35E009B; Wed, 17 Oct 2007 20:46:18 +0200 (CEST) Message-ID: <47165878.4090103@freebsd.org> Date: Wed, 17 Oct 2007 20:46:16 +0200 From: Ivan Voras User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 References: <200710152209.l9FM9Jv3017150@repoman.freebsd.org> <20071016102013.GE23043@submonkey.net> <4714F06B.7070702@FreeBSD.org> <20071017103509.GA71990@FreeBSD.org> <20071017164937.GB95535@dragon.NUXI.org> <471641BA.1040002__37506.9366921254$1192642322$gmane$org@freebsd.org> In-Reply-To: <471641BA.1040002__37506.9366921254$1192642322$gmane$org@freebsd.org> X-Enigmail-Version: 0.95.3 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigC3587F08668EBDE7332349A6" Cc: Alexey Dokuchaev , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Stefan Esser , obrien@FreeBSD.org, Ceri Davies Subject: Re: cvs commit: src/usr.bin/locate/locate updatedb.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 18:46:21 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC3587F08668EBDE7332349A6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Ivan Voras wrote: > David O'Brien wrote: >> On Wed, Oct 17, 2007 at 10:35:10AM +0000, Alexey Dokuchaev wrote: >>> It might be a good idea to drop msdosfs off of this list. Real physi= cal >>> filesystems in Windoze world are typically NTFS now, and FAT is used >>> mainly in removable storage. >> Not nessisarly - vfat/fat32 is the only reliable FS that can be shared= >> between FreeBSD and MS-Windows (and Linux). I use a FAT FS on my lapt= op >> for just this reason. >=20 > Well, there's another one :) >=20 > I've been running it in that mode (FreeBSD+Linux+Windows) for 2+ years > without problems. No journaling, though. Sorry, a gremlin ate my link. Here's what I meant: http://www.fs-driver.org/ - it's an ext2 driver for Windows. But I also agree FAT32 is alive and popular choice, no only for stationary drives but also for "semi-stationary" large external USB hard drives and similar equipment - I don't think the time has come to discard FAT32 for local storage. (Many of things discussed in this thread are fairly easy on recent Linuxes with automounting - file systems that have been automounted are probably not permanent). --------------enigC3587F08668EBDE7332349A6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHFlh4ldnAQVacBcgRAkl5AJ4oFPuJUH/PZ4dwfWrllgQdQOp96gCeL5Ku 3NUsydtBxbg/kQ4xTisjhBs= =+wVM -----END PGP SIGNATURE----- --------------enigC3587F08668EBDE7332349A6-- From owner-cvs-src@FreeBSD.ORG Wed Oct 17 19:21:27 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB0F316A418 for ; Wed, 17 Oct 2007 19:21:27 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outO.internet-mail-service.net (outO.internet-mail-service.net [216.240.47.238]) by mx1.freebsd.org (Postfix) with ESMTP id A326213C4A8 for ; Wed, 17 Oct 2007 19:21:27 +0000 (UTC) (envelope-from julian@elischer.org) Received: from mx0.idiom.com (HELO idiom.com) (216.240.32.160) by out.internet-mail-service.net (qpsmtpd/0.40) with ESMTP; Wed, 17 Oct 2007 12:05:27 -0700 X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e Received: from julian-mac.elischer.org (nat.ironport.com [63.251.108.100]) by idiom.com (Postfix) with ESMTP id 1D169126704; Wed, 17 Oct 2007 12:05:27 -0700 (PDT) Message-ID: <47165D09.7040909@elischer.org> Date: Wed, 17 Oct 2007 12:05:45 -0700 From: Julian Elischer User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: Sam Leffler References: <70e8236f0710150343k590f5be8r8cdf3fd60df4abd2@mail.gmail.com> <4713700D.8040202@samsco.org> <20071015193658.138fc9a5@deskjail> <4713A871.1080608@errno.com> In-Reply-To: <4713A871.1080608@errno.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Scott Long , src-committers@FreeBSD.org, Alexander Leidinger , cvs-src@FreeBSD.org, Joao Barros , cvs-all@FreeBSD.org, Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 19:21:27 -0000 Sam Leffler wrote: > Alexander Leidinger wrote: >> Quoting Scott Long (Mon, 15 Oct 2007 07:50:05 -0600): keep in mind htere are a lot of people out here that have no opinion as we haven't looked at it in detail, who may like the idea of a sensor framework but don't know enough about this implementation to chime in. I've seen 4 people who say they don't like it, and 3 or 4 (I wasn't counting) who said that they either liked it or at least didn't see anything wrong with it. SO it's not a clear cut as it may appear. Having spent some time in past lives supporting various sensors, I know that there is a crying need for some sort of framework but that doesn't mean that it needs to be this one, or even in the kernel. Maybe we can find someone to arbitrate. We used to have an architecture board for this purpose but we got rid of it. >> From owner-cvs-src@FreeBSD.ORG Wed Oct 17 19:50:40 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A444116A417; Wed, 17 Oct 2007 19:50:40 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7FE9C13C45B; Wed, 17 Oct 2007 19:50:40 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9HJoeQj032524; Wed, 17 Oct 2007 19:50:40 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9HJoexd032523; Wed, 17 Oct 2007 19:50:40 GMT (envelope-from thompsa) Message-Id: <200710171950.l9HJoexd032523@repoman.freebsd.org> From: Andrew Thompson Date: Wed, 17 Oct 2007 19:50:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs zfs_fm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 19:50:40 -0000 thompsa 2007-10-17 19:50:40 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/contrib/opensolaris/uts/common/fs/zfs zfs_fm.c Log: MFC r1.3, 1.4 Print the ZFS ereport to the console if vfs.zfs.debug is set to help diagnose problems with zfs-on-root since devd isnt running yet. Approved by: re (kensmith) Revision Changes Path 1.2.2.1 +1 -0 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_fm.c From owner-cvs-src@FreeBSD.ORG Wed Oct 17 19:58:50 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A693616A418; Wed, 17 Oct 2007 19:58:50 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 82B1013C49D; Wed, 17 Oct 2007 19:58:50 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9HJwonr032956; Wed, 17 Oct 2007 19:58:50 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9HJwoS5032955; Wed, 17 Oct 2007 19:58:50 GMT (envelope-from yar) Message-Id: <200710171958.l9HJwoS5032955@repoman.freebsd.org> From: Yar Tikhiy Date: Wed, 17 Oct 2007 19:58:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/termcap termcap.src X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 19:58:50 -0000 yar 2007-10-17 19:58:50 UTC FreeBSD src repository Modified files: share/termcap termcap.src Log: Delete an extra backslash at the end of the xterm-basic entry. It can be missed easily that the following blank line formally belongs to the xterm-basic entry due to the unneeded backslash. PR: bin/80256 (audit trail) Revision Changes Path 1.149 +1 -1 src/share/termcap/termcap.src From owner-cvs-src@FreeBSD.ORG Wed Oct 17 20:09:57 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1E82216A418; Wed, 17 Oct 2007 20:09:57 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id EF65213C46A; Wed, 17 Oct 2007 20:09:56 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9HK9uZ7034668; Wed, 17 Oct 2007 20:09:56 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9HK9u5k034667; Wed, 17 Oct 2007 20:09:56 GMT (envelope-from yar) Message-Id: <200710172009.l9HK9u5k034667@repoman.freebsd.org> From: Yar Tikhiy Date: Wed, 17 Oct 2007 20:09:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/mk version_gen.awk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 20:09:57 -0000 yar 2007-10-17 20:09:56 UTC FreeBSD src repository Modified files: share/mk version_gen.awk Log: MFp4: - Check for duplicated symbols and suggest moving them to ObsoleteVersions. - Improve and unify error handling. - Make the regular expressions more uniform, robust, and less sensitive to harmless variations in the input such as those to whitespace amount. Reviewed by: deischen Tested with: md5 (Version.map files in /usr/obj stay the same) Revision Changes Path 1.4 +76 -30 src/share/mk/version_gen.awk From owner-cvs-src@FreeBSD.ORG Wed Oct 17 20:23:15 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 60B2016A420; Wed, 17 Oct 2007 20:23:15 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id C537313C4B3; Wed, 17 Oct 2007 20:23:14 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l9HKNDuG078408; Thu, 18 Oct 2007 00:23:13 +0400 (MSD) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru; s=default; t=1192652593; bh=yjSlUGM5p/pBlUd33aI41lVjxXx+Vc2J/anh0wK C+Vs=; l=1054; h=Date:From:To:Cc:Subject:Message-ID: Mail-Followup-To:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:User-Agent; b=M7jdOf7YY8rfm5KZgl5e AFi76shuUhXW7fKSg2RjKvGKybYDBUHGOUtuhQ9qHvKSi2mPOKwlqMWCjJM5/k4B6FZ 8u8I4JYvp1zxUd2WhkfFmY6yjgvyRTM/DQjIToD7AZEfo6upCbJ3niTCsJ8WLWPmO2l Nk+itdgr0XpqPRboI= Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l9HKNCSV078407; Thu, 18 Oct 2007 00:23:12 +0400 (MSD) (envelope-from ache) Date: Thu, 18 Oct 2007 00:23:12 +0400 From: Andrey Chernov To: Alexander Leidinger Message-ID: <20071017202312.GA78324@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Alexander Leidinger , John-Mark Gurney , Poul-Henning Kamp , Wilko Bulte , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <20071015152408.10kvgtog6cooc4wc@webmail.leidinger.net> <48258.1192460507@critter.freebsd.dk> <20071015210909.1b6b693b@deskjail> <20071015202115.GP39759@funkthat.com> <20071016184047.8zh3fl90gksks40c@webmail.leidinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071016184047.8zh3fl90gksks40c@webmail.leidinger.net> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: John-Mark Gurney , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG, Poul-Henning Kamp , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 20:23:15 -0000 gOn Tue, Oct 16, 2007 at 06:40:47PM +0200, Alexander Leidinger wrote: >> like /var/run/log or /var/run/devd.pipe, that a userland daemon running >> as root that has access to ISA I/O and related resources... It's >> that simple... > > And the code doesn't exists. And when it is written, when will it be > bugfree enough? The sysctl way of exporting integer data already has a good > track record, and porting the existing lm sensor (from a project which is > known to take much care about security) was easier to get right. The > project also was not about the lm sensor (I don't go and count the size for > the small lm sensor now). The lm sensor was one example of using it. I > don't think objection to the lm sensor driver should lead to removal of the > framework itself. One possible reaction could be to say that the lm sensor > should move to ports. Why not to put them under DEVFS like /dev/sensors/* ? They are devices after all. I agree that putting devices under sysctl.* is bad idea. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Wed Oct 17 20:24:24 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 486F016A4EB; Wed, 17 Oct 2007 20:24:24 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id 680FA13C469; Wed, 17 Oct 2007 20:24:17 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id 0052D1710A; Wed, 17 Oct 2007 20:24:14 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id l9HKOENc052184; Wed, 17 Oct 2007 20:24:14 GMT (envelope-from phk@critter.freebsd.dk) To: "Constantine A. Murenin" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 17 Oct 2007 11:50:24 -0400." <47162F40.8000203@FreeBSD.org> Date: Wed, 17 Oct 2007 20:24:14 +0000 Message-ID: <52183.1192652654@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: Scott Long , src-committers@FreeBSD.org, Alexander Leidinger , John Baldwin , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 20:24:24 -0000 In message <47162F40.8000203@FreeBSD.org>, "Constantine A. Murenin" writes: >You didn't quote my other part of the reply about the ntpd/sensors.c >example. FreeBSD already supports an API for timekeeping events, complying with the only relevant standard in this area: RFC 2783 Poul-Henning -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Wed Oct 17 20:36:14 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E00D416A420; Wed, 17 Oct 2007 20:36:14 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id 99B3413C494; Wed, 17 Oct 2007 20:36:13 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id 00C581710B; Wed, 17 Oct 2007 20:36:11 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id l9HKaBqe052236; Wed, 17 Oct 2007 20:36:11 GMT (envelope-from phk@critter.freebsd.dk) To: Alexander Leidinger From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 17 Oct 2007 16:04:40 +0200." <20071017160440.b6fd00xs6cog888g@webmail.leidinger.net> Date: Wed, 17 Oct 2007 20:36:11 +0000 Message-ID: <52235.1192653371@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: Wilko Bulte , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 20:36:15 -0000 In message <20071017160440.b6fd00xs6cog888g@webmail.leidinger.net>, Alexander L eidinger writes: >Quoting Poul-Henning Kamp (from Tue, 16 Oct 2007 =20 >17:32:40 +0000): This discussion is growing too many branches, I have pruned to the central core for now: >> By defining the sensor API (on top of sysctl) at the kernel/userland >> boundary you have decided that all sensor implementations must live >> in the kernel, there is no room in your architecture for sensors >> that live in userland. > >No, I didn't. I said (even last time when you first told us that you >don't like the sensors framework), that the sensors framework is >supposed to export data which lifes in the kernel to the userland. I >never said the sensors framework is supposed to be the one and only >way of getting status data from a running system. This is what I think is the most fatal flaw in this design. It is only an API for _some_ of the sensors in a system, and because of that limitation, it invites people to try to shoehorn things that do not belong there, into that subset. In this case, that puts code into the kernel that should under no circumstances (have to) live there. The timekeeping sensors is a prefect example of that, since March 2000 RFC2783 has defined the API for such stuff, but rather than go and do things properly, somebody goes and implements DCF77 decoding in the kernel. Kernel Architecture is just as much about preventing things as enabling them. Sensors, as here presented, fails both criteria: It doesn't do enough for the relevant subject matter, and doesn't keep irrelevant stuff abay. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Wed Oct 17 23:20:49 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B1F5C16A417; Wed, 17 Oct 2007 23:20:49 +0000 (UTC) (envelope-from tmclaugh@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9292013C455; Wed, 17 Oct 2007 23:20:49 +0000 (UTC) (envelope-from tmclaugh@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9HNKnp1063501; Wed, 17 Oct 2007 23:20:49 GMT (envelope-from tmclaugh@repoman.freebsd.org) Received: (from tmclaugh@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9HNKnGl063500; Wed, 17 Oct 2007 23:20:49 GMT (envelope-from tmclaugh) Message-Id: <200710172320.l9HNKnGl063500@repoman.freebsd.org> From: Tom McLaughlin Date: Wed, 17 Oct 2007 23:20:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/net nscache.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 23:20:49 -0000 tmclaugh 2007-10-17 23:20:49 UTC FreeBSD src repository (ports committer) Modified files: lib/libc/net nscache.c Log: - Correctly define CACHED_SOCKET_PATH as /var/run/nscd after cached to nscd renaming. Approved by: mux Revision Changes Path 1.2 +1 -1 src/lib/libc/net/nscache.c From owner-cvs-src@FreeBSD.ORG Wed Oct 17 23:29:02 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AFC5A16A41B; Wed, 17 Oct 2007 23:29:02 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9187F13C455; Wed, 17 Oct 2007 23:29:02 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9HNT2xM063926; Wed, 17 Oct 2007 23:29:02 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9HNT2RQ063925; Wed, 17 Oct 2007 23:29:02 GMT (envelope-from cognet) Message-Id: <200710172329.l9HNT2RQ063925@repoman.freebsd.org> From: Olivier Houchard Date: Wed, 17 Oct 2007 23:29:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/conf options.arm src/sys/arm/xscale/i80321 i80321_timer.c std.iq31244 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 23:29:02 -0000 cognet 2007-10-17 23:29:02 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/conf options.arm sys/arm/xscale/i80321 i80321_timer.c std.iq31244 Log: MFC: arm/xscale/i80321/i80321_timer.c 1.8 arm/xscale/i80321/std.iq31244 rev 1.3 conf/options.arm rev 1.6 The IQ80321 clock is 200MHz, but the IQ31244 is 198MHz, so add a kernel option to override the frequency Revision Changes Path 1.5.2.1 +4 -0 src/sys/arm/xscale/i80321/i80321_timer.c 1.2.2.1 +1 -0 src/sys/arm/xscale/i80321/std.iq31244 1.5.2.4 +2 -0 src/sys/conf/options.arm From owner-cvs-src@FreeBSD.ORG Thu Oct 18 00:00:37 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A4A8516A418; Thu, 18 Oct 2007 00:00:37 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.freebsd.org (Postfix) with ESMTP id 451AD13C468; Thu, 18 Oct 2007 00:00:37 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (90tezgnv85lp4ook@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.6/8.13.3) with ESMTP id l9I00ZX4029413; Wed, 17 Oct 2007 17:00:35 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.6/8.13.3/Submit) id l9I00XPm029412; Wed, 17 Oct 2007 17:00:33 -0700 (PDT) (envelope-from jmg) Date: Wed, 17 Oct 2007 17:00:33 -0700 From: John-Mark Gurney To: Andrey Chernov , Alexander Leidinger , Poul-Henning Kamp , Wilko Bulte , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20071018000032.GU39759@funkthat.com> Mail-Followup-To: Andrey Chernov , Alexander Leidinger , Poul-Henning Kamp , Wilko Bulte , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <20071015152408.10kvgtog6cooc4wc@webmail.leidinger.net> <48258.1192460507@critter.freebsd.dk> <20071015210909.1b6b693b@deskjail> <20071015202115.GP39759@funkthat.com> <20071016184047.8zh3fl90gksks40c@webmail.leidinger.net> <20071017202312.GA78324@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071017202312.GA78324@nagual.pp.ru> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (hydrogen.funkthat.com [127.0.0.1]); Wed, 17 Oct 2007 17:00:36 -0700 (PDT) Cc: Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 00:00:37 -0000 Andrey Chernov wrote this message on Thu, Oct 18, 2007 at 00:23 +0400: > gOn Tue, Oct 16, 2007 at 06:40:47PM +0200, Alexander Leidinger wrote: > >> like /var/run/log or /var/run/devd.pipe, that a userland daemon running > >> as root that has access to ISA I/O and related resources... It's > >> that simple... > > > > And the code doesn't exists. And when it is written, when will it be > > bugfree enough? The sysctl way of exporting integer data already has a good > > track record, and porting the existing lm sensor (from a project which is > > known to take much care about security) was easier to get right. The > > project also was not about the lm sensor (I don't go and count the size for > > the small lm sensor now). The lm sensor was one example of using it. I > > don't think objection to the lm sensor driver should lead to removal of the > > framework itself. One possible reaction could be to say that the lm sensor > > should move to ports. > > Why not to put them under DEVFS like /dev/sensors/* ? They are devices > after all. I agree that putting devices under sysctl.* is bad idea. a) How does a userland driver present a DEVFS/device instance? b) For exporting a simple integer, sysctl makes more sense than the device interface. (I'm not getting into naming the sysctl node, or where it should be located.) -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-cvs-src@FreeBSD.ORG Thu Oct 18 00:38:25 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 49E7316A417; Thu, 18 Oct 2007 00:38:25 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from mojo.ru (mojo.ru [84.252.152.63]) by mx1.freebsd.org (Postfix) with ESMTP id 8FB8213C44B; Thu, 18 Oct 2007 00:38:24 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from [192.168.0.16] (nc-76-6-108-199.dhcp.embarqhsd.net [76.6.108.199]) (authenticated bits=0) by mojo.ru (8.12.11.20060308/8.12.10) with ESMTP id l9I0cUlt015802 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 18 Oct 2007 04:38:32 +0400 Message-ID: <4716AAF2.5040209@FreeBSD.org> Date: Wed, 17 Oct 2007 20:38:10 -0400 From: "Constantine A. Murenin" Organization: Google Summer of Code 2007 Student @ The FreeBSD Project User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.5) Gecko/20041217 X-Accept-Language: en-gb, en-gb-oed, en, en-us, ru, ru-ru, ru-su MIME-Version: 1.0 To: John Baldwin References: <200710161809.10755.jhb@freebsd.org> <47153F62.1080709@FreeBSD.org> <200710170903.31724.jhb@freebsd.org> In-Reply-To: <200710170903.31724.jhb@freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: src-committers@FreeBSD.org, Alexander Leidinger , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, "Constantine A. Murenin" , Poul-Henning Kamp , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 00:38:25 -0000 On 17/10/2007 09:03, John Baldwin wrote: > On Tuesday 16 October 2007 06:46:58 pm Constantine A. Murenin wrote: > >>On 16/10/2007 18:09, John Baldwin wrote: >> >> >>>On Tuesday 16 October 2007 05:46:18 pm Constantine A. Murenin wrote: >>> >>> >>>>On 16/10/2007, John Baldwin wrote: >>>> >>>> >>>>>On Tuesday 16 October 2007 12:33:11 pm Alexander Leidinger wrote: >>>>> >>>>> >>>>>>Constantine asked for review several times on -current. He got some >>>>>>reviews several times for commits to perforce. He incorporated >>>>>>suggestions from those reviews, or explained why it is like it is and >>>>>>why he can not switch (with no replies with suggestions how to solve >>>>>>the problems he sees with the suggestions). Now you come and ask why >>>>>>nobody pointed out some flaws before (without telling us which >>>>>>technical flaws you talk about). >>>>> >>>>>At least from my point of view this is not quite accurate as pretty much >>> >>>all >>> >>> >>>>>my feedback to the p4 commits was ignored with basically "Well, I don't >>> >>>like >>> >>> >>>>>doing it that way". Specifically, with regards to creating dynamic sysctl >>>>>trees, Constantine feels that sysctl_add_oid(9) is a hack rather than >>>>>recognizing that this is a feature of FreeBSD's sysctl system despite >>>>>repeated e-mails on the subject. >>>> >>>>Dear John, >>>> >>>>I have specifically addressed this concern of yours just several weeks ago. >>>> >>>>Please see the following message, which you've never replied to: >>>> >>>>http://lists.freebsd.org/pipermail/p4-projects/2007-September/021121.html >>>> >>>>I've used the documented parts of the FreeBSD's sysctl interface to >>>>preserve 100% userland compatibility with OpenBSD. >>> >>> >>>FreeBSD already provides an interface for creating dynamic sysctl trees that >>>is simpler than having to simulate a pseudo-tree via the .oid_handler >>>routine. In some cases (such as kern.proc) FreeBSD still uses a function >>>handler rather than giving each process its own sysctl node. However, in >>>other cases (generally more recent ones, and ones not as large/performance >>>impacting) such as dev.* or the recent proposal to give ifnet's their own >>>nodes under 'net.if' or the like, sysctl_add_oid(9) is used. >> >>Which one is simpler is questionable. Take one more look at the number >>of different macros that are available in the sysctl(9) and friends, and >>then compare with four functions of the sensors framework: >> >>* sensor_attach(9) to attach a sensor to a sensordev tree >>* sensordev_install(9) to register the sensordev tree with sysctl(9) >>and the same with the "de" prefix >> >>sensordev_install(9) acts similarly to the sysctl(9) ctx concept, but is >>geared towards the sensors approach >> >>If you want to make sure you don't attract any new contributors, then >>certainly the bunch of the sysctl(9) macros are simpler. ;) > > > I never said to not have sensor_*() routines. I just think that the sensor > implementation should make use of dynamic sysctls to build the sysctl > interface rather than treating dynamic sysctls as a temporary hack and adding > a duplicate interface for walking the hw.sensors tree. I guess I see where you're coming from here. You are concerned that the hack to register sensor_attach'ed sensors with the sysctl(8) magic all at once may conflict with additional drivers, for example, if sensor_attach is called after sensordev_install. OpenBSD 4.2 has more than 50 drivers using this framework, and all of them satisfy the assertion that the above doesn't happen -- no sensor_attach calls are ever made after sensordev_install. On a similar note, the sensor_detach function is redundant -- the few drivers that actually use it won't notice any difference if it is removed in its entirety -- sensordev_deinstall automatically removes all sensors of a given sensordev. (Granted, this might be documented a bit more explicitly, but this has not been a problem so far.) In other words, it is usually the devices that hold sensors that are hotpluggable, not the individual sensors themselves. So in the realm of the sensor framework, the sysctl magic for sysctl(8) is not considered to be a temporary hack. >>>As to the process of walking sysctl trees being undocumented, it is simply >>>missing a wrapper routine ala sysctlbyname(3) and a manpage. You could >>>easily provide one and thus provide a facility for enumerating many different >>>things than having several one-off oid_handler routines to enumerate >>>subtrees. However, it is not some "backdoor" hack interface anymore than >>>sysctlbyname(3) is. They are both equally hackish or non-hackish (depending >>>on your point of view). >> >>This interface is about having a special tree for the hardware sensors, >>with special rules regarding the namespace. What you suggest is that I >>try to abandon this, but then why do you need this framework to start with? > > > I suggest you think in layered abstractions. sysctl is a tool for creating > a namespace that the kernel exports to userland. Let sysctl manage the > namespace and the sensor code just populate nodes in the namespace and manage > sensors. You are missing some point here. With this interface, sysctl is simply used as a transfer mechanism to export two structures: * struct sensordev, which defines how further sensors on a given device can be addressed and how many sensors of each type a given device has (this is something that would not be possible to export via the sysctl magic alone, BTW) * struct sensor, which provides readings of individual sensors on a given sensor device The above gives this framework the potential to be source-code compatible with any kind of sysctl interface, be that original non-dynamic sysctl, FreeBSD's dynamic sysctl, or possibly even NetBSD's dynamic sysctl. It also provides additional benefits -- the whole tree of a given sensordev can be traversed with completely ignoring sensors of certain types. What you are suggesting is that a FreeBSD-only sysctl-specific functions are used instead, also limiting the additional functionality provided by sensordev structure, but I see no technical benefit in this. (I hope my explanation above about the specific hack in relation to OpenBSD's existing drivers addresses your concern for good.) Thus the two-layered version of the framework (sensordev/sensor) defines its own namespace. Granted, on OpenBSD this is much more valuable than it is on FreeBSD, since FreeBSD already has dynamic sysctl mechanism (which is quite polluted by irrelevant and unused values, IMHO). However, many people are quite certain that the sensor framework is nonetheless valuable even on FreeBSD, too. It provides something that the plain FreeBSD dynamic sysctl interface doesn't provide -- simplicity of use for sensor-like devices and a common namespace with clearly defined restrictions. Cheers, Constantine. From owner-cvs-src@FreeBSD.ORG Thu Oct 18 01:14:33 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C153D16A421; Thu, 18 Oct 2007 01:14:33 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 2A0B013C481; Thu, 18 Oct 2007 01:14:32 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l9I1ERCL082586; Thu, 18 Oct 2007 05:14:27 +0400 (MSD) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru; s=default; t=1192670067; bh=aQGX4tvdXDAkfOmMkEWTQShIjRCakkgiXXUybMP bgLs=; l=819; h=Date:From:To:Subject:Message-ID:Mail-Followup-To: References:MIME-Version:Content-Type:Content-Disposition: In-Reply-To:User-Agent; b=gWluUtDS0VYk60kG238fnJAvaSoe6k9cUeRh5sAT kOrl430WDfPLXWklJssq95hAEZUCeellctT4drgxw3jOq+V0OhoyH6KYgAaPrNhsOwe eBOrpWhppQJYLtVtBu39Y/0cxpbN8c9W15M+mE23eVjp2qvSLYxsyMDoFjKzMJfw= Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l9I1EQLc082584; Thu, 18 Oct 2007 05:14:26 +0400 (MSD) (envelope-from ache) Date: Thu, 18 Oct 2007 05:14:25 +0400 From: Andrey Chernov To: Alexander Leidinger , Poul-Henning Kamp , Wilko Bulte , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20071018011425.GA82493@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Alexander Leidinger , Poul-Henning Kamp , Wilko Bulte , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <20071015152408.10kvgtog6cooc4wc@webmail.leidinger.net> <48258.1192460507@critter.freebsd.dk> <20071015210909.1b6b693b@deskjail> <20071015202115.GP39759@funkthat.com> <20071016184047.8zh3fl90gksks40c@webmail.leidinger.net> <20071017202312.GA78324@nagual.pp.ru> <20071018000032.GU39759@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071018000032.GU39759@funkthat.com> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 01:14:33 -0000 On Wed, Oct 17, 2007 at 05:00:33PM -0700, John-Mark Gurney wrote: > > Why not to put them under DEVFS like /dev/sensors/* ? They are devices > > after all. I agree that putting devices under sysctl.* is bad idea. > > a) How does a userland driver present a DEVFS/device instance? > > b) For exporting a simple integer, sysctl makes more sense than the > device interface. (I'm not getting into naming the sysctl node, or > where it should be located.) Your a) and b) are in logical conflict. If they are only simple integers (in general sensor can be more complicated than single integer) why userland driver is ever needed? Simple daemon is enough. I think loadable kernel modules are not worse than userland drivers since can be used only by those who needs them. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Thu Oct 18 01:26:08 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6D05D16A41A; Thu, 18 Oct 2007 01:26:08 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 0841F13C4B2; Thu, 18 Oct 2007 01:26:05 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l9I1Q3lD082706; Thu, 18 Oct 2007 05:26:03 +0400 (MSD) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru; s=default; t=1192670763; bh=DjWDnfZ7irRPqIOrocKLslRJhG+0ZCnxZvricx1 w4AQ=; l=1029; h=Date:From:To:Cc:Subject:Message-ID: Mail-Followup-To:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:User-Agent; b=Z8RGiNz3WhUIRpQrJIik tPpx2CbcwuXVkKU7zhi9luBnljmHpdoMiFXf0vXc5DbqoggYEE2Q+PwrCvbM59aqEo2 dxpJGLW/DLIJnvHE7DEpEjpnDX5/tj+RLGVCIuXDdzH3IPjr03v32Ym96jUZFqHdvhy JR3bEPCXbCYkUvmos= Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l9I1Q32i082704; Thu, 18 Oct 2007 05:26:03 +0400 (MSD) (envelope-from ache) Date: Thu, 18 Oct 2007 05:26:03 +0400 From: Andrey Chernov To: "Constantine A. Murenin" Message-ID: <20071018012602.GB82493@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , "Constantine A. Murenin" , John Baldwin , Alexander Leidinger , Wilko Bulte , Poul-Henning Kamp , src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-src@FreeBSD.ORG References: <200710161809.10755.jhb@freebsd.org> <47153F62.1080709@FreeBSD.org> <200710170903.31724.jhb@freebsd.org> <4716AAF2.5040209@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4716AAF2.5040209@FreeBSD.org> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: src-committers@FreeBSD.ORG, Alexander Leidinger , John Baldwin , cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG, Poul-Henning Kamp , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 01:26:08 -0000 On Wed, Oct 17, 2007 at 08:38:10PM -0400, Constantine A. Murenin wrote: > Thus the two-layered version of the framework (sensordev/sensor) defines > its own namespace. Granted, on OpenBSD this is much more valuable than it > is on FreeBSD, since FreeBSD already has dynamic sysctl mechanism (which is > quite polluted by irrelevant and unused values, IMHO). However, many people > are quite certain that the sensor framework is nonetheless valuable even on > FreeBSD, too. It provides something that the plain FreeBSD dynamic sysctl > interface doesn't provide -- simplicity of use for sensor-like devices and > a common namespace with clearly defined restrictions. You can't define enough level of restriction using sysctl framework, f.e. different permissions for different user groups. And with DEVFS it is an easy thing (I don't advocate for completely userland modules, kernel loadable modules are good enough, just dislike idea of using sysctls as poor man devices). -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Thu Oct 18 01:28:30 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9CFE616A418; Thu, 18 Oct 2007 01:28:30 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9301F13C447; Thu, 18 Oct 2007 01:28:30 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9I1SUkg081170; Thu, 18 Oct 2007 01:28:30 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9I1SURY081169; Thu, 18 Oct 2007 01:28:30 GMT (envelope-from thompsa) Message-Id: <200710180128.l9I1SURY081169@repoman.freebsd.org> From: Andrew Thompson Date: Thu, 18 Oct 2007 01:28:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/net if_lagg.c if_lagg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 01:28:30 -0000 thompsa 2007-10-18 01:28:30 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/net if_lagg.c if_lagg.h Log: MFC if_lagg.c r1.20, if_lagg.h r1.11 Fix two panics in lagg. 1. The locking was changed to shared but roundrobin mode still updated a pointer in the softc with the next tx interface to use. This will panic under high load. Change this to an atomically incremented sequence number in order to choose the tx port in round robin. 2. IFQ_HANDOFF will free the mbuf if the queue is full, this will then be freed again by lagg_start() and panic. Reorganised the error handling and freeing to fix this. Approved by: re (kensmith) Revision Changes Path 1.19.2.1 +33 -36 src/sys/net/if_lagg.c 1.10.2.1 +1 -0 src/sys/net/if_lagg.h From owner-cvs-src@FreeBSD.ORG Thu Oct 18 01:32:59 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 73D6916A475; Thu, 18 Oct 2007 01:32:59 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 4ADCA13C474; Thu, 18 Oct 2007 01:32:59 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9I1Wxpb081500; Thu, 18 Oct 2007 01:32:59 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9I1WxoA081499; Thu, 18 Oct 2007 01:32:59 GMT (envelope-from thompsa) Message-Id: <200710180132.l9I1WxoA081499@repoman.freebsd.org> From: Andrew Thompson Date: Thu, 18 Oct 2007 01:32:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/dev/ipw if_ipw.c if_ipwreg.h if_ipwvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 01:32:59 -0000 thompsa 2007-10-18 01:32:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/ipw if_ipw.c if_ipwreg.h if_ipwvar.h Log: MFC if_ipw.c r1.31-32, if_ipwreg.h 1.3, if_ipwvar.h r1.7 Update ipw to work with the new net80211 stack, plus other driver improvements. Approved by: re (kensmith) Revision Changes Path 1.30.2.1 +826 -217 src/sys/dev/ipw/if_ipw.c 1.2.2.1 +17 -2 src/sys/dev/ipw/if_ipwreg.h 1.6.2.1 +26 -1 src/sys/dev/ipw/if_ipwvar.h From owner-cvs-src@FreeBSD.ORG Thu Oct 18 05:06:59 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 50EB416A417; Thu, 18 Oct 2007 05:06:59 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2661313C45A; Thu, 18 Oct 2007 05:06:59 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9I56xj2005808; Thu, 18 Oct 2007 05:06:59 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9I56xa3005807; Thu, 18 Oct 2007 05:06:59 GMT (envelope-from imp) Message-Id: <200710180506.l9I56xa3005807@repoman.freebsd.org> From: Warner Losh Date: Thu, 18 Oct 2007 05:06:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/include armreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 05:06:59 -0000 imp 2007-10-18 05:06:58 UTC FreeBSD src repository Modified files: sys/arm/include armreg.h Log: Merge definitions for ARM9E, ARM10 and ARM11 processors from p4 (which got them from NetBSD). Revision Changes Path 1.7 +14 -2 src/sys/arm/include/armreg.h From owner-cvs-src@FreeBSD.ORG Thu Oct 18 05:12:21 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 99E8716A417; Thu, 18 Oct 2007 05:12:21 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6FA6B13C43E; Thu, 18 Oct 2007 05:12:21 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9I5CLCV006273; Thu, 18 Oct 2007 05:12:21 GMT (envelope-from yongari@repoman.freebsd.org) Received: (from yongari@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9I5CLGO006272; Thu, 18 Oct 2007 05:12:21 GMT (envelope-from yongari) Message-Id: <200710180512.l9I5CLGO006272@repoman.freebsd.org> From: Pyun YongHyeon Date: Thu, 18 Oct 2007 05:12:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/dev/gem if_gem.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 05:12:21 -0000 yongari 2007-10-18 05:12:20 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/gem if_gem.c Log: MFC if_gem.c, rev 1.45 to RELENG_7: Fix a NULL pointer dereference in Tx checksum calculation. Approved by: re (kensmith) Revision Changes Path 1.44.2.1 +5 -0 src/sys/dev/gem/if_gem.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 05:16:51 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 17B6316A418; Thu, 18 Oct 2007 05:16:51 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DFF9413C467; Thu, 18 Oct 2007 05:16:50 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9I5GoO2006468; Thu, 18 Oct 2007 05:16:50 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9I5Go41006467; Thu, 18 Oct 2007 05:16:50 GMT (envelope-from kientzle) Message-Id: <200710180516.l9I5Go41006467@repoman.freebsd.org> From: Tim Kientzle Date: Thu, 18 Oct 2007 05:16:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/lib/libarchive archive_read_support_format_zip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 05:16:51 -0000 kientzle 2007-10-18 05:16:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libarchive archive_read_support_format_zip.c Log: MFC 1.15: When reading ZIP archives, non-regular files should return EOF immediately on any attempts to read their data. (Previously, it would return a zero-length block, then EOF, which elicited bogus warnings from bsdtar.) Also, correct the EOF return to correctly identify EOF as part of an empty block at the correct offset. Approved by: re (Ken Smith) Revision Changes Path 1.14.2.1 +7 -0 src/lib/libarchive/archive_read_support_format_zip.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 05:19:45 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D1F7116A47B; Thu, 18 Oct 2007 05:19:45 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 665C613C478; Thu, 18 Oct 2007 05:19:45 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9I5JiI3006572; Thu, 18 Oct 2007 05:19:44 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9I5JiFU006571; Thu, 18 Oct 2007 05:19:44 GMT (envelope-from kientzle) Message-Id: <200710180519.l9I5JiFU006571@repoman.freebsd.org> From: Tim Kientzle Date: Thu, 18 Oct 2007 05:19:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/lib/libarchive archive_read_support_format_zip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 05:19:45 -0000 kientzle 2007-10-18 05:19:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libarchive archive_read_support_format_zip.c Log: MFC 1.15: Return EOF immediately for non-regular files, don't return an empty block first. In particular, this fixes a bogus warning from bsdtar when restoring directories from ZIP archives. Also, correct the return values at EOF to include the correct offset. Revision Changes Path 1.5.2.5 +7 -0 src/lib/libarchive/archive_read_support_format_zip.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 05:33:06 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 90A5916A417; Thu, 18 Oct 2007 05:33:06 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7CD5213C45B; Thu, 18 Oct 2007 05:33:06 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9I5X69f007556; Thu, 18 Oct 2007 05:33:06 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9I5X6Zf007555; Thu, 18 Oct 2007 05:33:06 GMT (envelope-from imp) Message-Id: <200710180533.l9I5X6Zf007555@repoman.freebsd.org> From: Warner Losh Date: Thu, 18 Oct 2007 05:33:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/arm cpufunc.c cpufunc_asm_arm11.S cpufunc_asm_armv5.S cpufunc_asm_armv5_ec.S identcpu.c src/sys/arm/include cpuconf.h cpufunc.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 05:33:06 -0000 imp 2007-10-18 05:33:06 UTC FreeBSD src repository Modified files: sys/arm/arm cpufunc.c identcpu.c sys/arm/include cpuconf.h cpufunc.h Added files: sys/arm/arm cpufunc_asm_arm11.S cpufunc_asm_armv5.S cpufunc_asm_armv5_ec.S Log: Merge support from p4 (from NetBSD) for arm9e and arm10, arm11 cores. Not yet connected to the build, but reduces diffs to p4 repo. Obtained from: NetBSD Revision Changes Path 1.19 +124 -4 src/sys/arm/arm/cpufunc.c 1.1 +124 -0 src/sys/arm/arm/cpufunc_asm_arm11.S (new) 1.1 +238 -0 src/sys/arm/arm/cpufunc_asm_armv5.S (new) 1.1 +206 -0 src/sys/arm/arm/cpufunc_asm_armv5_ec.S (new) 1.12 +54 -8 src/sys/arm/arm/identcpu.c 1.11 +33 -7 src/sys/arm/include/cpuconf.h 1.13 +55 -3 src/sys/arm/include/cpufunc.h From owner-cvs-src@FreeBSD.ORG Thu Oct 18 05:43:45 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B6F8316A41A; Thu, 18 Oct 2007 05:43:45 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8C33713C45A; Thu, 18 Oct 2007 05:43:45 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9I5hjUl008143; Thu, 18 Oct 2007 05:43:45 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9I5hjwF008142; Thu, 18 Oct 2007 05:43:45 GMT (envelope-from imp) Message-Id: <200710180543.l9I5hjwF008142@repoman.freebsd.org> From: Warner Losh Date: Thu, 18 Oct 2007 05:43:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/arm/at91 at91_mcireg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 05:43:45 -0000 imp 2007-10-18 05:43:45 UTC FreeBSD src repository Modified files: sys/arm/at91 at91_mcireg.h Log: correct guard variable names. Revision Changes Path 1.2 +3 -3 src/sys/arm/at91/at91_mcireg.h From owner-cvs-src@FreeBSD.ORG Thu Oct 18 06:44:34 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4544B16A417; Thu, 18 Oct 2007 06:44:34 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 92BE213C469; Thu, 18 Oct 2007 06:44:33 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A548C8.dip.t-dialin.net [84.165.72.200]) by redbull.bpaserver.net (Postfix) with ESMTP id 8DE8E2E0BD; Thu, 18 Oct 2007 08:44:26 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 638A45B480D; Thu, 18 Oct 2007 08:43:20 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.1/8.13.8/Submit) id l9I6hJKi067730; Thu, 18 Oct 2007 08:43:19 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Thu, 18 Oct 2007 08:43:19 +0200 Message-ID: <20071018084319.7whfk1pixt8o080w@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Thu, 18 Oct 2007 08:43:19 +0200 From: Alexander Leidinger To: Julian Elischer References: <70e8236f0710150343k590f5be8r8cdf3fd60df4abd2@mail.gmail.com> <4713700D.8040202@samsco.org> <20071015193658.138fc9a5@deskjail> <4713A871.1080608@errno.com> <47165D09.7040909@elischer.org> In-Reply-To: <47165D09.7040909@elischer.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-13.404, required 8, BAYES_00 -15.00, MIME_QP_LONG_LINE 1.40, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10) X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, Barros , cvs-all@FreeBSD.org, Wilko Bulte , Sam Leffler , Joao Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 06:44:34 -0000 Quoting Julian Elischer (from Wed, 17 Oct 2007 =20 12:05:45 -0700): > Sam Leffler wrote: >> Alexander Leidinger wrote: >>> Quoting Scott Long (Mon, 15 Oct 2007 07:50:05 -0600)= : > > keep in mind htere are a lot of people out here that have no opinion > as we haven't looked at it in detail, who may like the idea of a sensor > framework but don't know enough about this implementation to chime in. I keep this in mind. What I complain about is, that Poul hasn't looked =20 into the implementation. He said he doesn't like the _idea_ of a =20 sensors framework. He wasn't even complaining about the architecture, =20 he was saying the idea is crap without technical backing. I asked him =20 several times to bring specific technical points on the table, either =20 an explanation what is bad about the architecture or something the =20 implementation itself, but he didn't. He just repeated that the idea =20 itself is crap. If he would come up with understandable technical =20 arguments why something is not good, I wouldn't complain, but he =20 doesn't. He's major complaint is, that he doesn't like the idea itself. > Having spent some time in past lives supporting various sensors, > I know that there is a crying need for some sort of framework Maybe you should explain this to Poul, it seems I failed to explain =20 him why we would benefit from such kind of a framework. > but that doesn't mean that it needs to be this one, or even in the kernel. I see several levels of stuff which can be named "sensors framework" here. One level is in the kernel. It's just an export interface to transfer =20 status data from the kernel to userland. The goal of this framework is =20 IMO to "collect" all this data in the kernel and provide a single =20 point of contact for the userland to query this in-kernel data. That's =20 what the soc project was about. Let's call this kernel sensors =20 framework here. Then there's something in the userland, what can also be named =20 "sensors framework". This part would be responsible to be a single =20 point of contact for to query the status data of the entire system. =20 This userland part would be responsible to collect data which is =20 exported from the kernel, and to collect data from userland stuff. It =20 would provide an interface to be able to query the in-machine data =20 (some people may say SNMP can be used for this). Let's call this =20 single-system sensors framework here. And then there's something in the network what can be named "sensors =20 framework". This part would be responsible to collect sensor data in =20 the entire (sub-)network and provide an interface to query the data =20 from the entire (sub-)network (an example can be nagios or some =20 commercial offering). Let's call this group-level sensors framework =20 for now. The term "sensor data" may by ambiguous too. When I talk about sensor =20 data, this can be some data from a device, like =20 temperature/voltage/humidity/tv channel/ rotation speed/pressure =20 level/fill level/coordinates/whatever (what we want to include of this =20 stuff or not I don't talk about, e.g., ATM I don't see a need to =20 provide the TV channel via the sensors framework). Sensor data can =20 also be the status of a subsystem in the kernel, some database related =20 things in userland, the hitrate per second of a webserver, or =20 whatever. All (more or less) of those things may in the end need to =20 arrive in the group-level sensors framework. Before they arrive there, =20 they ideally arrive in the single-system sensors framework (reduces =20 probing complexity and the amount of work of the person who has to =20 configure the group-level sensors framework). And parts of this stuff =20 was in the kernel sensors framework before. The group-level sensors framework doesn't belong into FreeBSD IMO. For =20 the single-system sensors framework I have no strong opinion (and with =20 bsnmp we may have some sort of this already which just needs to be a =20 little bit extend (MIBs), but this depends upon your needs and =20 expectations). For a kernel sensors framework it is clear, that this =20 can not live it ports. To me the benefits of such a framework is =20 obvious. For several other people @FreeBSD.org I have the impression, =20 that it is also obvious. I don't object if someone brings up valid technical arguments why the =20 sensors framework this thread is all about is not suitable for =20 FreeBSD. Look into my mails, you see I specially ask for technical =20 arguments against it. But I object if someone just says it is crap =20 without providing technical backing. I didn't write the code, it's not =20 my baby, and if someone finds major flaws in it which can not be =20 corrected, shoot it. No objections from my side. But saying that the =20 idea is crap which makes it even not worth looking into this sensors =20 framework, while several people think we need something like this, is =20 far from being polite. And that's the reason why I object. I don't say it's the best architecture ever. But I say it serves a lot =20 of needs, is an improvement of the current situation, and is not done =20 in a very very bad way. Whoever comes up with an better way of doing =20 it is welcome by me, but he should take into account that this =20 specific sensors framework is shared with more than one other BSD and =20 allows code sharing (I'm not talking about implementation details, I'm =20 talking about the syntax/semantic). If suggested improvements =20 outweight the benefits from sharing the code, great, it's welcome by =20 me (and maybe the other BSDs are interested in those improvements too, =20 if they are not in a way which prevents the adoption those =20 improvements). > Maybe we can find someone to arbitrate. We used to have an architecture > board for this purpose but we got rid of it. I think the outcome at that time was to ask core@, and they may decide =20 to ask the people which formed the architecture review board before =20 (or people which have a lot of knowledge in the specific area). Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 The Martian Canals were clearly the Martian's last ditch effort! From owner-cvs-src@FreeBSD.ORG Thu Oct 18 07:12:49 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7BB1316A46C; Thu, 18 Oct 2007 07:12:49 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id B520A13C468; Thu, 18 Oct 2007 07:12:48 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A548C8.dip.t-dialin.net [84.165.72.200]) by redbull.bpaserver.net (Postfix) with ESMTP id 123072E06A; Thu, 18 Oct 2007 09:12:40 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 476A25B480D; Thu, 18 Oct 2007 09:11:34 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.1/8.13.8/Submit) id l9I7BYT0072584; Thu, 18 Oct 2007 09:11:34 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Thu, 18 Oct 2007 09:11:34 +0200 Message-ID: <20071018091134.jzo7m88374ow00c8@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Thu, 18 Oct 2007 09:11:34 +0200 From: Alexander Leidinger To: Poul-Henning Kamp References: <52235.1192653371@critter.freebsd.dk> In-Reply-To: <52235.1192653371@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-11.304, required 8, BAYES_00 -15.00, IMPRONONCABLE_2 1.50, J_CHICKENPOX_27 0.60, MIME_QP_LONG_LINE 1.40, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10) X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: Wilko Bulte , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 07:12:49 -0000 Quoting Poul-Henning Kamp (from Wed, 17 Oct 2007 =20 20:36:11 +0000): > In message <20071017160440.b6fd00xs6cog888g@webmail.leidinger.net>, =20 > Alexander L > eidinger writes: >> Quoting Poul-Henning Kamp (from Tue, 16 Oct 2007 =3D= 20 >> 17:32:40 +0000): > > This discussion is growing too many branches, I have pruned to the > central core for now: > >>> By defining the sensor API (on top of sysctl) at the kernel/userland >>> boundary you have decided that all sensor implementations must live >>> in the kernel, there is no room in your architecture for sensors >>> that live in userland. >> >> No, I didn't. I said (even last time when you first told us that you >> don't like the sensors framework), that the sensors framework is >> supposed to export data which lifes in the kernel to the userland. I >> never said the sensors framework is supposed to be the one and only >> way of getting status data from a running system. > > This is what I think is the most fatal flaw in this design. > > It is only an API for _some_ of the sensors in a system, and because > of that limitation, it invites people to try to shoehorn things > that do not belong there, into that subset. Again, we don't need to put everything what OpenBSD puts into =20 hw.sensors into our hw.sensors. If you object to include the time =20 stuff into hw.sensors when we have an existing and good API for this, =20 I don't object. I even agree with you, as this would be a good =20 technical argument. But this is unrelated to the sensors framework =20 (the API). It is related how this API is used. Nothing prevents us to =20 come up with a policy how this API shall be used. And for the "in a system" part, see my answer to Julian Elischer. You =20 are talking about something what I call "single-system sensor =20 framework" in the mail to him. > In this case, that puts code into the kernel that should under no > circumstances (have to) live there. > > The timekeeping sensors is a prefect example of that, since March > 2000 RFC2783 has defined the API for such stuff, but rather than > go and do things properly, somebody goes and implements DCF77 > decoding in the kernel. There was no modification to your time-stuff in FreeBSD. Instead of =20 complaining against the entire sensors framework, you could asks to =20 include a text somewhere, which tells that we are not interested to =20 add a sensor for the time stuff and why. > Kernel Architecture is just as much about preventing things as > enabling them. > > Sensors, as here presented, fails both criteria: It doesn't do > enough for the relevant subject matter, and doesn't keep > irrelevant stuff abay. Keeping the irrelevant stuff away means instantiating a policy. =20 Nothing prevents us from this. Feel free to start by contributing a =20 text which states that we don't want time sensors and why. For the =20 relevant things where you think it doesn't do enough, you should tell =20 us what you are talking about and why it is relevant. Maybe what you =20 want can be done without problems. As you haven't looked at the =20 framework itself (as you said you don't like the idea to an extend =20 that it is not even worth looking at it), you are in a weak position =20 to tell something can not be done with it (we've seen several times =20 that high level things you used to object against the sensors =20 framework integrate without problems into the sensors framework). Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 The man who can smile when things go wrong has thought of someone he can blame it on. From owner-cvs-src@FreeBSD.ORG Thu Oct 18 07:23:31 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B0A1E16A418; Thu, 18 Oct 2007 07:23:31 +0000 (UTC) (envelope-from grehan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 83A7513C448; Thu, 18 Oct 2007 07:23:31 +0000 (UTC) (envelope-from grehan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9I7NVuP017272; Thu, 18 Oct 2007 07:23:31 GMT (envelope-from grehan@repoman.freebsd.org) Received: (from grehan@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9I7NVWB017271; Thu, 18 Oct 2007 07:23:31 GMT (envelope-from grehan) Message-Id: <200710180723.l9I7NVWB017271@repoman.freebsd.org> From: Peter Grehan Date: Thu, 18 Oct 2007 07:23:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/powerpc Symbol.map X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 07:23:32 -0000 grehan 2007-10-18 07:23:31 UTC FreeBSD src repository Modified files: lib/libc/powerpc Symbol.map Log: Fix build from errors exposed with recent version_gen.awk commit. Not quite sure if this is 100% correct: awaiting review. But quieten tinderbox in the meantime. Revision Changes Path 1.6 +1 -2 src/lib/libc/powerpc/Symbol.map From owner-cvs-src@FreeBSD.ORG Thu Oct 18 07:26:21 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B69FB16A41A; Thu, 18 Oct 2007 07:26:21 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A05E913C4BB; Thu, 18 Oct 2007 07:26:21 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9I7QLoG017376; Thu, 18 Oct 2007 07:26:21 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9I7QLo7017375; Thu, 18 Oct 2007 07:26:21 GMT (envelope-from bde) Message-Id: <200710180726.l9I7QLo7017375@repoman.freebsd.org> From: Bruce Evans Date: Thu, 18 Oct 2007 07:26:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/msdosfs msdosfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 07:26:21 -0000 bde 2007-10-18 07:26:21 UTC FreeBSD src repository Modified files: sys/fs/msdosfs msdosfs_vnops.c Log: In msdosfs_settattr(), don't do synchronous updates of the denode (except indirectly for the size pseudo-attribute). If anything deserves a sync update, then it is ids and immutable flags, since these are related to security, but ffs never synced these and msdosfs doesn't support them. (ufs_setattr() only does an update in one case where it is least needed (for timestamps); it did pessimal sync updates for timestamps until 1998/03/08 but was changed for unlogged reasons related to soft updates.) Now msdosfs calls deupdat() with waitfor == 0, which normally gives a delayed update to disk but always gives a sync update of timestamps in core, while for ffs everything is delayed until the syncer daemon or other activity causes an update (except for timestamps). This gives a large optimization mainly for things like cp -p, where attribute adjustment could easily triple the number of physical I/O's if it is done synchronously (but cp -p to msdosfs is not as bad as that, since msdosfs doesn't support many attributes so null adjustments are more common, and msdosfs doesn't support ctimes so even if cp doesn't weed out null adjustments they don't become non-null after clobbering the ctime). Revision Changes Path 1.180 +1 -1 src/sys/fs/msdosfs/msdosfs_vnops.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 07:27:10 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D7F7616A41A; Thu, 18 Oct 2007 07:27:10 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 7F27413C4A6; Thu, 18 Oct 2007 07:27:10 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A548C8.dip.t-dialin.net [84.165.72.200]) by redbull.bpaserver.net (Postfix) with ESMTP id 3783F2E0CA; Thu, 18 Oct 2007 09:27:04 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 6F49D5B480D; Thu, 18 Oct 2007 09:25:58 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.1/8.13.8/Submit) id l9I7PwTg074880; Thu, 18 Oct 2007 09:25:58 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Thu, 18 Oct 2007 09:25:58 +0200 Message-ID: <20071018092558.3c9b4tkescko4g0c@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Thu, 18 Oct 2007 09:25:58 +0200 From: Alexander Leidinger To: Poul-Henning Kamp References: <52183.1192652654@critter.freebsd.dk> In-Reply-To: <52183.1192652654@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-13.404, required 8, BAYES_00 -15.00, MIME_QP_LONG_LINE 1.40, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10) X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: Scott Long , src-committers@FreeBSD.org, John Baldwin , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, "Constantine A. Murenin" , Wilko, Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 07:27:10 -0000 Quoting Poul-Henning Kamp (from Wed, 17 Oct 2007 =20 20:24:14 +0000): > In message <47162F40.8000203@FreeBSD.org>, "Constantine A. Murenin" writes= : > >> You didn't quote my other part of the reply about the ntpd/sensors.c >> example. > > FreeBSD already supports an API for timekeeping events, complying > with the only relevant standard in this area: RFC 2783 He didn't talk about using this for timekeeping stuff in FreeBSD. He =20 used this an an example what could be done for RAID. As you didn't asked for a specific action regarding this I try to do =20 it. Please correct me if I don't get it right: Constantine, we have a standards compliant API for timekeeping events. =20 Any time related stuff should use this API. Please add a text and a =20 pointer, e.g., in the man-page and/or any other sensible place, which =20 tells that our RFC 2783 compliant API shall be used. Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 Nipples, dimples, knuckles, NICKLES, wrinkles, pimples!! From owner-cvs-src@FreeBSD.ORG Thu Oct 18 07:39:53 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 204B616A41B; Thu, 18 Oct 2007 07:39:53 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id BA14413C48D; Thu, 18 Oct 2007 07:39:52 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.1/8.14.1) with ESMTP id l9I7bEhZ095698; Thu, 18 Oct 2007 01:37:14 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 18 Oct 2007 01:38:27 -0600 (MDT) Message-Id: <20071018.013827.-749244202.imp@bsdimp.com> To: netchild@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20071018091134.jzo7m88374ow00c8@webmail.leidinger.net> References: <52235.1192653371@critter.freebsd.dk> <20071018091134.jzo7m88374ow00c8@webmail.leidinger.net> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: wb@freebie.xs4all.nl, phk@phk.freebsd.dk, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 07:39:53 -0000 In message: <20071018091134.jzo7m88374ow00c8@webmail.leidinger.net> Alexander Leidinger writes: : Feel free to start by contributing a : text which states that we don't want time sensors and why. I think he already did that. The biggest reason is that you do not want your kernel to run all the ntpd reference clocks. Sure, you could move all that code into the kernel, but that violates rule number 1 about kernel program: don't put stuff in the kernel that doesn't belong there. Making them sensors necessarily means doing this, or coming up with a way for userland to pass time deltas it computes into the kernel to pass it back to ntpd via the sensor interface. That violates rule number 2 of kernel programming: don't cross domain boundaries needlessly. It is much easier to have all the data in ntpd without the extra circumlocutions that the sensor interface would force. There are people doing high precision timing applications with FreeBSD today. I'm one of them. Sensors for phase time differences are like pounding a screw with a hammer. Sure, it looks like it works and often time it works well enough for the application. But closer inspection shows the item constructed lacks structural integrity. There's all kinds of different nuances that need to be considered when doing high precision real-time timing systems. The current time difference sensor interface in OpenBSD just doesn't cut it. The industry standard RFC interfaces that we implement today are sufficient. They can handle both phase error measurements, as well as frequency error measurements. They can cope with simple timestamping of events, as well as measurements of the error in time. I've deployed about 10 different timing systems that pace system time to a PPS, sometimes one that isn't exactly on time or on frequency (but which other parts of the timing system can report the error in both those domains for). That would be impossible with the sensor framework as it currently stands. So you have three strikes against you with time sensors: they force kernel complexity or extra context switches, they artificially segregate data and the data that they can represent is insufficiently expressive for the demands of a real timing system. How can one objectively say that they are useful when they have so many problems? They flat out can't work for anything serious, and even if you tried, you'd find the extra complexity the design forces to be a bigger liability than the gain from having them be shoe-horned into a regular system. I do timing systems for a living: as an example, my timing systems are deployed at NIST and USNO to monitor the ensembles of clocks that go into the UTC time scale. This is only one of about a dozen different systems we've sold over the years. Phk does timing systems for a living too: he's built timing systems used for navigation at Danish airports. Warner From owner-cvs-src@FreeBSD.ORG Thu Oct 18 08:06:03 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C16C016A417; Thu, 18 Oct 2007 08:06:03 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 4558813C44B; Thu, 18 Oct 2007 08:06:03 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A548C8.dip.t-dialin.net [84.165.72.200]) by redbull.bpaserver.net (Postfix) with ESMTP id AC8142E0CA; Thu, 18 Oct 2007 10:05:48 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id E25DC5B480D; Thu, 18 Oct 2007 10:04:42 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.1/8.13.8/Submit) id l9I84gT7081411; Thu, 18 Oct 2007 10:04:42 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Thu, 18 Oct 2007 10:04:42 +0200 Message-ID: <20071018100442.a4i5vidp1c0kg8gg@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Thu, 18 Oct 2007 10:04:42 +0200 From: Alexander Leidinger To: ticso@cicely.de, Bernd Walter References: <24712.1192384461@critter.freebsd.dk> <20071015081507.yi9t4ot8asg0wcw4@webmail.leidinger.net> <20071014172115.GA24318@freebie.xs4all.nl> <24712.1192384461@critter.freebsd.dk> <20071017155225.GU17048@cicely12.cicely.de> In-Reply-To: <20071017155225.GU17048@cicely12.cicely.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-13.404, required 8, BAYES_00 -15.00, MIME_QP_LONG_LINE 1.40, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10) X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: Wilko Bulte , Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 08:06:03 -0000 Quoting Bernd Walter (from Wed, 17 Oct 2007 =20 17:52:25 +0200): > For example in the embedded world we can have an i2c system with > commonly used addresses reused for different purpose. Not talking about the specific part at hand (probing i2c), but =20 regarding embedded devices: there you craft your kernel by hand anyway =20 after deciding what you need and what not. > Another example is that there are i2c switches used on alpha systems, > such as the AS4100 - we never supported i2c on alpha, but this doesn't > mean that other systems don't use it as well. Do you know about amd64/i386 systems (where the code you talk about is =20 used) where this is the case? If not, do you think that with the =20 vendor mentality of saving every fraction of a cent it is likely, that =20 they use i2c switches? > Yet another example are the famous atmel eeprom chips used in some IBM > notebooks which died on such an access. That's bad. Can they be affected with by the code in question? > Then we have a bug on some i2c controllers (namely the twi in Atmel > ARM9 chips), which makes it impossible to safely get the ack state > on addressing. Are you talking about embedded stuff, or about stuff which is used on =20 i386/amd64? > On Mon, Oct 15, 2007 at 08:15:07AM +0200, Alexander Leidinger wrote: >> Quoting Poul-Henning Kamp (from Sun, 14 Oct 2007 >> 17:54:21 +0000): >> Could you please explain how you want to integrate devices with >> newbus, which are only accessible via the i2c bus? Feel free to show >> us example code for one of those of our drivers which access the i2c >> bus, which already existed before this commit. > > For example the ds1672 driver (sys/dev/iicbus/ds1672.c) writen by sam: > at91_twi0 > iicbus0 > [...] > ds16720 at addr=3D0xd0 > [...] > The device name is a bit unfortunate - it consists of ds1672 beeing > the driver name and 0 beeing the instance, but this is unrelated. > > The DS1672 is used as an RTC for some ARM boards, but it is written > machine independend. Thanks for this example. Do you know enough about this code that you =20 can help further if Constantine has questions regarding it and Sam has =20 no time to answer? Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 Any circuit design must contain at least one part which is obsolete, two par= ts which are unobtainable, and three parts which are still under development. From owner-cvs-src@FreeBSD.ORG Thu Oct 18 08:26:21 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E654616A421; Thu, 18 Oct 2007 08:26:21 +0000 (UTC) (envelope-from bushman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B83FD13C48E; Thu, 18 Oct 2007 08:26:21 +0000 (UTC) (envelope-from bushman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9I8QLAu021531; Thu, 18 Oct 2007 08:26:21 GMT (envelope-from bushman@repoman.freebsd.org) Received: (from bushman@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9I8QLDU021530; Thu, 18 Oct 2007 08:26:21 GMT (envelope-from bushman) Message-Id: <200710180826.l9I8QLDU021530@repoman.freebsd.org> From: Michael Bushkov Date: Thu, 18 Oct 2007 08:26:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc Makefile nscd.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 08:26:22 -0000 bushman 2007-10-18 08:26:21 UTC FreeBSD src repository Modified files: etc Makefile nscd.conf Log: Forced commit to note cached.conf -> nscd.conf repocopy. etc/Makefile changed accordingly. Approved by: brooks (mentor) Revision Changes Path 1.363 +1 -1 src/etc/Makefile 1.2 +0 -0 src/etc/nscd.conf From owner-cvs-src@FreeBSD.ORG Thu Oct 18 08:33:25 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4EC7E16A41A; Thu, 18 Oct 2007 08:33:25 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.freebsd.org (Postfix) with ESMTP id 1361313C457; Thu, 18 Oct 2007 08:33:24 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (s5o01cp7fozb7pxp@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.6/8.13.3) with ESMTP id l9I8XOFw036425; Thu, 18 Oct 2007 01:33:24 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.6/8.13.3/Submit) id l9I8XNqC036424; Thu, 18 Oct 2007 01:33:23 -0700 (PDT) (envelope-from jmg) Date: Thu, 18 Oct 2007 01:33:22 -0700 From: John-Mark Gurney To: Andrey Chernov , Alexander Leidinger , Poul-Henning Kamp , Wilko Bulte , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20071018083322.GX39759@funkthat.com> Mail-Followup-To: Andrey Chernov , Alexander Leidinger , Poul-Henning Kamp , Wilko Bulte , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <20071015152408.10kvgtog6cooc4wc@webmail.leidinger.net> <48258.1192460507@critter.freebsd.dk> <20071015210909.1b6b693b@deskjail> <20071015202115.GP39759@funkthat.com> <20071016184047.8zh3fl90gksks40c@webmail.leidinger.net> <20071017202312.GA78324@nagual.pp.ru> <20071018000032.GU39759@funkthat.com> <20071018011425.GA82493@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071018011425.GA82493@nagual.pp.ru> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (hydrogen.funkthat.com [127.0.0.1]); Thu, 18 Oct 2007 01:33:24 -0700 (PDT) Cc: Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 08:33:25 -0000 Andrey Chernov wrote this message on Thu, Oct 18, 2007 at 05:14 +0400: > On Wed, Oct 17, 2007 at 05:00:33PM -0700, John-Mark Gurney wrote: > > > Why not to put them under DEVFS like /dev/sensors/* ? They are devices > > > after all. I agree that putting devices under sysctl.* is bad idea. > > > > a) How does a userland driver present a DEVFS/device instance? > > > > b) For exporting a simple integer, sysctl makes more sense than the > > device interface. (I'm not getting into naming the sysctl node, or > > where it should be located.) > > Your a) and b) are in logical conflict. If they are only simple integers I never said they weren't... You asked why don't we put simple sensors like fan rpm as a device such as /dev/sensors/fan0, I replied w/ two examples/issues... > (in general sensor can be more complicated than single integer) why If it's more complicated then that's different, but from my understanding of the OpenBSD sensor framework is that you'd end up breaking those "complicated" sensors into seperate sensors... > userland driver is ever needed? Simple daemon is enough. Exactly my point... A userland driver is necessary if all sensores are to be listed in /dev/sensors/*... If it's only a subset that a userland library uses to query a few sensors like current cpu temperature, and the rest from a userland daemon, that's fine too... But /dev/sensors/* is should not be the complete or primary source of sensor data... > I think loadable kernel modules are not worse than userland drivers since > can be used only by those who needs them. Besides violating the first rule of kernel programming... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-cvs-src@FreeBSD.ORG Thu Oct 18 08:41:53 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 544ED16A468; Thu, 18 Oct 2007 08:41:53 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2982413C47E; Thu, 18 Oct 2007 08:41:53 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9I8frfp022319; Thu, 18 Oct 2007 08:41:53 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9I8fqBL022318; Thu, 18 Oct 2007 08:41:52 GMT (envelope-from delphij) Message-Id: <200710180841.l9I8fqBL022318@repoman.freebsd.org> From: Xin LI Date: Thu, 18 Oct 2007 08:41:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 08:41:53 -0000 delphij 2007-10-18 08:41:52 UTC FreeBSD src repository Modified files: . Makefile Log: Do not bail out for cleanworld target just because chflags is failed. Revision Changes Path 1.342 +2 -2 src/Makefile From owner-cvs-src@FreeBSD.ORG Thu Oct 18 09:03:40 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DD6BF16A417; Thu, 18 Oct 2007 09:03:40 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B3E9313C4B7; Thu, 18 Oct 2007 09:03:40 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9I93ejD033320; Thu, 18 Oct 2007 09:03:40 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9I93ewg033319; Thu, 18 Oct 2007 09:03:40 GMT (envelope-from des) Message-Id: <200710180903.l9I93ewg033319@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Thu, 18 Oct 2007 09:03:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/dev/puc puc_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 09:03:41 -0000 des 2007-10-18 09:03:40 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/puc puc_pci.c Log: MFC: (1.17) fix subvendor / subdevice matching Approved by: re (kensmith) Revision Changes Path 1.16.2.1 +19 -14 src/sys/dev/puc/puc_pci.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 09:09:23 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 649CE16A418; Thu, 18 Oct 2007 09:09:23 +0000 (UTC) (envelope-from bushman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3B30213C46E; Thu, 18 Oct 2007 09:09:23 +0000 (UTC) (envelope-from bushman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9I99NNI033509; Thu, 18 Oct 2007 09:09:23 GMT (envelope-from bushman@repoman.freebsd.org) Received: (from bushman@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9I99Nso033508; Thu, 18 Oct 2007 09:09:23 GMT (envelope-from bushman) Message-Id: <200710180909.l9I99Nso033508@repoman.freebsd.org> From: Michael Bushkov Date: Thu, 18 Oct 2007 09:09:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc cached.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 09:09:23 -0000 bushman 2007-10-18 09:09:23 UTC FreeBSD src repository Removed files: etc cached.conf Log: Removing obsolete etc/cached.conf. Approved by: brooks (mentor) Revision Changes Path 1.2 +0 -12 src/etc/cached.conf (dead) From owner-cvs-src@FreeBSD.ORG Thu Oct 18 09:10:17 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3885516A421; Thu, 18 Oct 2007 09:10:17 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 4539A13C467; Thu, 18 Oct 2007 09:10:15 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l9I9A8WV001660; Thu, 18 Oct 2007 13:10:08 +0400 (MSD) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru; s=default; t=1192698609; bh=O/QRFSPTpAeIPkaqqJ+zGPKBFAjByYeMvdCPdaD KoXE=; l=1292; h=Date:From:To:Subject:Message-ID:Mail-Followup-To: References:MIME-Version:Content-Type:Content-Disposition: In-Reply-To:User-Agent; b=RJd06lrXqs0iXKRvyTNSu5QvyemRZvUH/tqNnM1R i5VKuCsdqKQMLq2Ral1Rcb5I9LIaqQuZLEN9yA3w1pJAXwFh6cPiLMILa2GXp+beLXA YS2A3U0xwHl8maFYN6hexeQJhuolmdZhMWBP+hz8zO9p+e5YHEpvgrDPKD65sBOU= Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l9I9A8MB001659; Thu, 18 Oct 2007 13:10:08 +0400 (MSD) (envelope-from ache) Date: Thu, 18 Oct 2007 13:10:08 +0400 From: Andrey Chernov To: Alexander Leidinger , Poul-Henning Kamp , Wilko Bulte , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20071018091008.GA1546@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Alexander Leidinger , Poul-Henning Kamp , Wilko Bulte , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <20071015152408.10kvgtog6cooc4wc@webmail.leidinger.net> <48258.1192460507@critter.freebsd.dk> <20071015210909.1b6b693b@deskjail> <20071015202115.GP39759@funkthat.com> <20071016184047.8zh3fl90gksks40c@webmail.leidinger.net> <20071017202312.GA78324@nagual.pp.ru> <20071018000032.GU39759@funkthat.com> <20071018011425.GA82493@nagual.pp.ru> <20071018083322.GX39759@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071018083322.GX39759@funkthat.com> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 09:10:17 -0000 On Thu, Oct 18, 2007 at 01:33:22AM -0700, John-Mark Gurney wrote: > > (in general sensor can be more complicated than single integer) why > > If it's more complicated then that's different, but from my understanding > of the OpenBSD sensor framework is that you'd end up breaking those > "complicated" sensors into seperate sensors... I don't like OpenBSD sensors framework like almost everybody here:) I don't think that breaking complicated sensors into separate pieces is good idea. Usually reading/writing DEVFS device + few ioctls for complex cases must cover most complicated sensors. > > userland driver is ever needed? Simple daemon is enough. > > Exactly my point... A userland driver is necessary if all sensores are > to be listed in /dev/sensors/*... If it's only a subset that a userland > library uses to query a few sensors like current cpu temperature, and > the rest from a userland daemon, that's fine too... But /dev/sensors/* > is should not be the complete or primary source of sensor data... I have nothing against userland drivers, but prefer to have sensors into easy to use namespace (and, as devices after all, under DEVFS) with ability to set permissions for them separately, like file system allows. -- http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Thu Oct 18 09:11:31 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 383F316A419; Thu, 18 Oct 2007 09:11:31 +0000 (UTC) (envelope-from bushman@freebsd.org) Received: from mail.r61.net (mail.r61.net [195.208.245.249]) by mx1.freebsd.org (Postfix) with ESMTP id 844AB13C465; Thu, 18 Oct 2007 09:11:30 +0000 (UTC) (envelope-from bushman@freebsd.org) Received: from [127.0.0.1] (mail.mactime.ru [213.27.12.16]) (authenticated bits=0) by mail.r61.net (8.14.1/8.14.1) with ESMTP id l9I9BKUg008358; Thu, 18 Oct 2007 13:11:27 +0400 (MSD) (envelope-from bushman@freebsd.org) Message-ID: <4717232B.9080906@freebsd.org> Date: Thu, 18 Oct 2007 13:11:07 +0400 From: Michael Bushkov User-Agent: Thunderbird 2.0.0.5 (Windows/20070716) MIME-Version: 1.0 To: Michael Bushkov References: <200710180909.l9I99Nso033508@repoman.freebsd.org> In-Reply-To: <200710180909.l9I99Nso033508@repoman.freebsd.org> Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/etc cached.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 09:11:31 -0000 I should have done it with previous commit (that noted the cached.conf -> nscd.conf repocopy), but the removal was not committed due to the "HEAD" sticky tag in cached.conf. Sorry for the mess. Michael Bushkov wrote: > bushman 2007-10-18 09:09:23 UTC > > FreeBSD src repository > > Removed files: > etc cached.conf > Log: > Removing obsolete etc/cached.conf. > > Approved by: brooks (mentor) > > Revision Changes Path > 1.2 +0 -12 src/etc/cached.conf (dead) -- With best regards, Michael Bushkov Southern Federal University From owner-cvs-src@FreeBSD.ORG Thu Oct 18 09:24:23 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7CE7316A418; Thu, 18 Oct 2007 09:24:23 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id D105113C45A; Thu, 18 Oct 2007 09:24:22 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A548C8.dip.t-dialin.net [84.165.72.200]) by redbull.bpaserver.net (Postfix) with ESMTP id 72F4E2E0CA; Thu, 18 Oct 2007 11:24:14 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 9D5355B480D; Thu, 18 Oct 2007 11:23:08 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.1/8.13.8/Submit) id l9I9N7rP094410; Thu, 18 Oct 2007 11:23:07 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Thu, 18 Oct 2007 11:23:07 +0200 Message-ID: <20071018112307.pkb8qmn8ao4cog80@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Thu, 18 Oct 2007 11:23:07 +0200 From: Alexander Leidinger To: "M. Warner Losh" References: <52235.1192653371@critter.freebsd.dk> <20071018091134.jzo7m88374ow00c8@webmail.leidinger.net> <20071018.013827.-749244202.imp@bsdimp.com> In-Reply-To: <20071018.013827.-749244202.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.5, required 8, BAYES_00 -15.00, OFFER 0.30, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10) X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: wb@freebie.xs4all.nl, phk@phk.freebsd.dk, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 09:24:23 -0000 Quoting "M. Warner Losh" (from Thu, 18 Oct 2007 =20 01:38:27 -0600 (MDT)): > There are people doing high precision timing applications with FreeBSD > today. I'm one of them. Sensors for phase time differences are like > pounding a screw with a hammer. Sure, it looks like it works and > often time it works well enough for the application. But closer > inspection shows the item constructed lacks structural integrity. > There's all kinds of different nuances that need to be considered when > doing high precision real-time timing systems. The current time > difference sensor interface in OpenBSD just doesn't cut it. Warner, I already stated much earlier in the thread that I don't see a =20 benefit in providing time via the sensors framework, as we already =20 have a better API for this (I'm not a high precision time keeping guy, =20 and I've seen the advantage of what we have even before Poul talked =20 about this, as I know about the time related possibilities FreeBSD =20 offers). I also said earlier that we don't have to have all OpenBSD =20 sensors in FreeBSD, it depends upon the policy we use for sensors. All of this complains about specific sensors are not a technical =20 reason to object to the framework itself. If Poul would have said that =20 Constantine shall make sure that there's text in sensible places that =20 explain that we have a better API in FreeBSD for time and that this =20 API shall be used instead of the sensors framework, than that would =20 have been OK for me (I even would have supported Poul, as I clearly =20 see it as a step back for us to use the sensors framework for time). I =20 even asked for technical reasons, but he didn't provide them. I asked =20 for them already weeks/months ago, when Poul was objecting against the =20 idea of the sensors framework, but he didn't gave them. So it is not =20 some days in which Poul didn't came up with technical reasons against =20 the idea/framework, but weeks/months. When he objects to some specific sensors, great! Finally a technical =20 argument! After Poul repeatedly was saying for a too long time that =20 the idea is that bad that he doesn't even look at the framework, I'm =20 happy that he provides technical arguments now! But I have to say, =20 that the technical arguments he presented so far are about small parts =20 in the framework which should be polished, but nothing which makes the =20 framework look like the "crap" Poul said in this thread. He came up =20 with some buzzwords like ACPI and IPMI to prove his non technical =20 points against the framework he presented so far, and he was =20 told/shown that those work just nicely with this framework. If it is not clear, I don't write all those mails to defend each line =20 of code in the sensors framework. I write all those mails because I =20 object to Pouls way of complaining without technical arguments (not =20 that he presented invalid technical arguments, no, he wasn't even =20 willing to present technical arguments at all in the beginning) that =20 he showed for a long time in this thread. If this info is new to =20 someone reading this, he should read all my mails again with this =20 information again. If someone wants to talk about technical stuff... great, I'm sure =20 Constantine will discuss them with him. If someone wants to support Poul in his raid against the _idea_ of the =20 framework _without_ providing technical arguments against the _idea_, =20 this person can discuss this with me until I have to go to the =20 hospital next week and after I'm back a week or so later (I'm also not =20 available at the weekend, sorry). Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 To say you got a vote of confidence would be to say you needed a vote of confidence. =09=09-- Andrew Young From owner-cvs-src@FreeBSD.ORG Thu Oct 18 09:36:59 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 49ED416A417; Thu, 18 Oct 2007 09:36:59 +0000 (UTC) (envelope-from ticso@cicely12.cicely.de) Received: from raven.bwct.de (raven.bwct.de [85.159.14.73]) by mx1.freebsd.org (Postfix) with ESMTP id E152713C474; Thu, 18 Oct 2007 09:36:58 +0000 (UTC) (envelope-from ticso@cicely12.cicely.de) Received: from cicely5.cicely.de ([10.1.1.7]) by raven.bwct.de (8.13.4/8.13.4) with ESMTP id l9I9aXTJ088590; Thu, 18 Oct 2007 11:36:33 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: from cicely12.cicely.de (cicely12.cicely.de [10.1.1.14]) by cicely5.cicely.de (8.13.4/8.13.4) with ESMTP id l9I9aRuD090954 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 18 Oct 2007 11:36:27 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: from cicely12.cicely.de (localhost [127.0.0.1]) by cicely12.cicely.de (8.13.4/8.13.3) with ESMTP id l9I9aQ99041869; Thu, 18 Oct 2007 11:36:26 +0200 (CEST) (envelope-from ticso@cicely12.cicely.de) Received: (from ticso@localhost) by cicely12.cicely.de (8.13.4/8.13.3/Submit) id l9I9aQPO041868; Thu, 18 Oct 2007 11:36:26 +0200 (CEST) (envelope-from ticso) Date: Thu, 18 Oct 2007 11:36:26 +0200 From: Bernd Walter To: Alexander Leidinger Message-ID: <20071018093625.GA17048@cicely12.cicely.de> References: <24712.1192384461@critter.freebsd.dk> <20071015081507.yi9t4ot8asg0wcw4@webmail.leidinger.net> <20071014172115.GA24318@freebie.xs4all.nl> <24712.1192384461@critter.freebsd.dk> <20071017155225.GU17048@cicely12.cicely.de> <20071018100442.a4i5vidp1c0kg8gg@webmail.leidinger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071018100442.a4i5vidp1c0kg8gg@webmail.leidinger.net> X-Operating-System: FreeBSD cicely12.cicely.de 5.4-STABLE alpha User-Agent: Mutt/1.5.9i X-Spam-Status: No, score=-4.2 required=5.0 tests=ALL_TRUSTED=-1.8, AWL=0.166, BAYES_00=-2.599 autolearn=ham version=3.1.7 X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on cicely12.cicely.de Cc: src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Bernd Walter , Poul-Henning Kamp , Wilko Bulte , ticso@cicely.de Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: ticso@cicely.de List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 09:36:59 -0000 On Thu, Oct 18, 2007 at 10:04:42AM +0200, Alexander Leidinger wrote: > Quoting Bernd Walter (from Wed, 17 Oct 2007 > 17:52:25 +0200): > > >For example in the embedded world we can have an i2c system with > >commonly used addresses reused for different purpose. > > Not talking about the specific part at hand (probing i2c), but > regarding embedded devices: there you craft your kernel by hand anyway > after deciding what you need and what not. Not in every case. I've attached additional i2c components to many boards when they had headers and just used them from userland. > >Another example is that there are i2c switches used on alpha systems, > >such as the AS4100 - we never supported i2c on alpha, but this doesn't > >mean that other systems don't use it as well. > > Do you know about amd64/i386 systems (where the code you talk about is > used) where this is the case? If not, do you think that with the > vendor mentality of saving every fraction of a cent it is likely, that > they use i2c switches? No - I don't know any, but it is not unlikely that some big systems with lots of hotplugable PCI slots use i2c busses to switch power on them and in that case they either need many busses or switches. We don't support hotplugable PCI beside from cardbus right now, but who knows. Also Digital didn't used switches to spare a few cent, the i2c was integrated into the chipset and adding multiple channel didn't work easily. > >Yet another example are the famous atmel eeprom chips used in some IBM > >notebooks which died on such an access. > > That's bad. Can they be affected with by the code in question? I don't know the code yet, but since zero byte writes are the only way to get something similar to probing I assume yes. > >Then we have a bug on some i2c controllers (namely the twi in Atmel > >ARM9 chips), which makes it impossible to safely get the ack state > >on addressing. > > Are you talking about embedded stuff, or about stuff which is used on > i386/amd64? No - I'm talking about ARM in this special case. Another fact, which I just remember, is that the controller can't do 0 byte acces anyway, so you can't do probing at all, even without the ack bug. > >On Mon, Oct 15, 2007 at 08:15:07AM +0200, Alexander Leidinger wrote: > >>Quoting Poul-Henning Kamp (from Sun, 14 Oct 2007 > >>17:54:21 +0000): > >>Could you please explain how you want to integrate devices with > >>newbus, which are only accessible via the i2c bus? Feel free to show > >>us example code for one of those of our drivers which access the i2c > >>bus, which already existed before this commit. > > > >For example the ds1672 driver (sys/dev/iicbus/ds1672.c) writen by sam: > > at91_twi0 > > iicbus0 > >[...] > > ds16720 at addr=0xd0 > >[...] > >The device name is a bit unfortunate - it consists of ds1672 beeing > >the driver name and 0 beeing the instance, but this is unrelated. > > > >The DS1672 is used as an RTC for some ARM boards, but it is written > >machine independend. > > Thanks for this example. Do you know enough about this code that you > can help further if Constantine has questions regarding it and Sam has > no time to answer? I will try to help you with questions, but I just know the driver not the attachment framework. IIRC Warner Losh did the hint based attachment framework, so he will likely be able to help you about this. -- B.Walter http://www.bwct.de http://www.fizon.de bernd@bwct.de info@bwct.de support@fizon.de From owner-cvs-src@FreeBSD.ORG Thu Oct 18 10:32:29 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 09D8116A417; Thu, 18 Oct 2007 10:32:29 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id D9F7E13C461; Thu, 18 Oct 2007 10:32:28 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IAWSOK039297; Thu, 18 Oct 2007 10:32:28 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IAWS9d039296; Thu, 18 Oct 2007 10:32:28 GMT (envelope-from yar) Message-Id: <200710181032.l9IAWS9d039296@repoman.freebsd.org> From: Yar Tikhiy Date: Thu, 18 Oct 2007 10:32:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/mk version_gen.awk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 10:32:29 -0000 yar 2007-10-18 10:32:28 UTC FreeBSD src repository Modified files: share/mk version_gen.awk Log: Distinguish the cases when a dup symbol is in different versions (evil, needs a error) or in the same version (harmless, deserves a mere warning). Noticed by: grehan@, tinderbox Revision Changes Path 1.5 +24 -6 src/share/mk/version_gen.awk From owner-cvs-src@FreeBSD.ORG Thu Oct 18 10:51:07 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8622016A479; Thu, 18 Oct 2007 10:51:07 +0000 (UTC) (envelope-from takawata@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 4C31F13C47E; Thu, 18 Oct 2007 10:51:07 +0000 (UTC) (envelope-from takawata@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IAp7Se040243; Thu, 18 Oct 2007 10:51:07 GMT (envelope-from takawata@repoman.freebsd.org) Received: (from takawata@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IAp7UO040242; Thu, 18 Oct 2007 10:51:07 GMT (envelope-from takawata) Message-Id: <200710181051.l9IAp7UO040242@repoman.freebsd.org> From: Takanori Watanabe Date: Thu, 18 Oct 2007 10:51:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb uchcom.c usbdevs src/sys/modules/uchcom Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 10:51:07 -0000 takawata 2007-10-18 10:51:06 UTC FreeBSD src repository Modified files: sys/dev/usb usbdevs Added files: sys/dev/usb uchcom.c sys/modules/uchcom Makefile Log: Add Winchiphead (or Nanjin QinHeng Electronics) USB Serial converter driver. I tested it on cheap serial converter.(Only costs 980JPY.) Revision Changes Path 1.1 +1036 -0 src/sys/dev/usb/uchcom.c (new) 1.330 +2 -1 src/sys/dev/usb/usbdevs 1.1 +9 -0 src/sys/modules/uchcom/Makefile (new) From owner-cvs-src@FreeBSD.ORG Thu Oct 18 11:05:32 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6BBBA16A420; Thu, 18 Oct 2007 11:05:32 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 4834113C45B; Thu, 18 Oct 2007 11:05:32 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IB5Wda042882; Thu, 18 Oct 2007 11:05:32 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IB5WME042881; Thu, 18 Oct 2007 11:05:32 GMT (envelope-from davidxu) Message-Id: <200710181105.l9IB5WME042881@repoman.freebsd.org> From: David Xu Date: Thu, 18 Oct 2007 11:05:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/su su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 11:05:32 -0000 davidxu 2007-10-18 11:05:30 UTC FreeBSD src repository Modified files: usr.bin/su su.c Log: The upper while loop has already recycled child process, so the if statement has never executed as expected, fix it. MFC after: 3 days Revision Changes Path 1.87 +1 -3 src/usr.bin/su/su.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 11:28:38 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D730716A46B; Thu, 18 Oct 2007 11:28:38 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B18DA13C45B; Thu, 18 Oct 2007 11:28:38 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IBScvC044012; Thu, 18 Oct 2007 11:28:38 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IBScp8044011; Thu, 18 Oct 2007 11:28:38 GMT (envelope-from yar) Message-Id: <200710181128.l9IBScp8044011@repoman.freebsd.org> From: Yar Tikhiy Date: Thu, 18 Oct 2007 11:28:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/ia64 Symbol.map X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 11:28:38 -0000 yar 2007-10-18 11:28:38 UTC FreeBSD src repository Modified files: lib/libc/ia64 Symbol.map Log: The fork symbols aren't MD, they already live in sys/. Found by: version_gen.awk Tested by: md5(1) (libc.so hasn't changed at all) Revision Changes Path 1.4 +0 -3 src/lib/libc/ia64/Symbol.map From owner-cvs-src@FreeBSD.ORG Thu Oct 18 12:08:53 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF00516A420; Thu, 18 Oct 2007 12:08:53 +0000 (UTC) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8EF1913C4A5; Thu, 18 Oct 2007 12:08:53 +0000 (UTC) (envelope-from nyan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IC8rNE047434; Thu, 18 Oct 2007 12:08:53 GMT (envelope-from nyan@repoman.freebsd.org) Received: (from nyan@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IC8rEW047433; Thu, 18 Oct 2007 12:08:53 GMT (envelope-from nyan) Message-Id: <200710181208.l9IC8rEW047433@repoman.freebsd.org> From: Takahashi Yoshihiro Date: Thu, 18 Oct 2007 12:08:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/lib/libstand Makefile src/sys/boot/ficl Makefile src/sys/boot/pc98 Makefile.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 12:08:53 -0000 nyan 2007-10-18 12:08:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libstand Makefile sys/boot/ficl Makefile sys/boot/pc98 Makefile.inc Log: MFC: Optimize for size on pc98. It enables to boot a kernel again. Approved by: re (kensmith) Revision Changes Path 1.57.2.1 +3 -0 src/lib/libstand/Makefile 1.44.2.1 +1 -1 src/sys/boot/ficl/Makefile 1.6.2.1 +2 -1 src/sys/boot/pc98/Makefile.inc From owner-cvs-src@FreeBSD.ORG Thu Oct 18 12:34:32 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A373016A421; Thu, 18 Oct 2007 12:34:32 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.freebsd.org (Postfix) with ESMTP id 2E81C13C468; Thu, 18 Oct 2007 12:34:30 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from kobe.laptop (vader.bytemobile.ondsl.gr [83.235.244.135]) (authenticated bits=128) by igloo.linux.gr (8.14.1/8.14.1/Debian-9) with ESMTP id l9ICY3tf018900 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 18 Oct 2007 15:34:21 +0300 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.1/8.14.1) with ESMTP id l9ICXgfF003046; Thu, 18 Oct 2007 15:33:58 +0300 (EEST) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost) by kobe.laptop (8.14.1/8.14.1/Submit) id l9ICXgai003045; Thu, 18 Oct 2007 15:33:42 +0300 (EEST) (envelope-from keramida@freebsd.org) Date: Thu, 18 Oct 2007 15:33:42 +0300 From: Giorgos Keramidas To: Mark Peek Message-ID: <20071018123342.GA3003@kobe.laptop> References: <200710161618.l9GGIel2049746@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200710161618.l9GGIel2049746@repoman.freebsd.org> X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-4.117, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 0.28, BAYES_00 -2.60) X-Hellug-MailScanner-From: keramida@freebsd.org X-Spam-Status: No Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/contrib/tcsh sh.c sh.proc.c tc.const.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 12:34:32 -0000 On 2007-10-16 16:18, Mark Peek wrote: > mp 2007-10-16 16:18:40 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_7) > contrib/tcsh sh.c sh.proc.c tc.const.c > Log: > Apply two vendor fixes from tcsh-6.15.01. The fixes are: > - Fix pty detection for autologout setting > - kill `foo` got stuck because sigchld was disabled too soon Thanks! Now I can delete the pty patch :-) From owner-cvs-src@FreeBSD.ORG Thu Oct 18 12:53:11 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9333416A417; Thu, 18 Oct 2007 12:53:11 +0000 (UTC) (envelope-from edwin@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8D4DC13C468; Thu, 18 Oct 2007 12:53:11 +0000 (UTC) (envelope-from edwin@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9ICrB9l058586; Thu, 18 Oct 2007 12:53:11 GMT (envelope-from edwin@repoman.freebsd.org) Received: (from edwin@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9ICrBQI058585; Thu, 18 Oct 2007 12:53:11 GMT (envelope-from edwin) Message-Id: <200710181253.l9ICrBQI058585@repoman.freebsd.org> From: Edwin Groothuis Date: Thu, 18 Oct 2007 12:53:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/makewhatis makewhatis.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 12:53:11 -0000 edwin 2007-10-18 12:53:11 UTC FreeBSD src repository Modified files: usr.bin/makewhatis makewhatis.c Log: Teach makewhatis.c to treat .SS with the same severity as .SH. At least one port (net-mgmt/net-snmp) creates man-pages which are in the format: .SH NAME The Net-SNMP agent \- The snmp agent responds to SNMP queries from management stations. .PP .SS "Modules" At this moment, makewhatis determines the end of the .SH NAME section as where it finds .SH again, but there is none here, is it "terminated" by the .SS. PR: bin/116706 Submitted by: edwin@ Approved by: re (Ken Smith), grog (mentor) MFC after: 1 week Revision Changes Path 1.11 +2 -0 src/usr.bin/makewhatis/makewhatis.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 12:55:28 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 01DA116A417; Thu, 18 Oct 2007 12:55:28 +0000 (UTC) (envelope-from edwin@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id F031613C43E; Thu, 18 Oct 2007 12:55:27 +0000 (UTC) (envelope-from edwin@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9ICtRCH058713; Thu, 18 Oct 2007 12:55:27 GMT (envelope-from edwin@repoman.freebsd.org) Received: (from edwin@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9ICtR6S058712; Thu, 18 Oct 2007 12:55:27 GMT (envelope-from edwin) Message-Id: <200710181255.l9ICtR6S058712@repoman.freebsd.org> From: Edwin Groothuis Date: Thu, 18 Oct 2007 12:55:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/usr.bin/makewhatis makewhatis.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 12:55:28 -0000 edwin 2007-10-18 12:55:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.bin/makewhatis makewhatis.c Log: Fast MFC for inclusion of 7.0-BETA1: Teach makewhatis.c to treat .SS with the same severity as .SH. At least one port (net-mgmt/net-snmp) creates man-pages which are in the format: .SH NAME The Net-SNMP agent \- The snmp agent responds to SNMP queries from manag ement stations. .PP .SS "Modules" At this moment, makewhatis determines the end of the .SH NAME section as where it finds .SH again, but there is none here, is it "terminated" by the .SS. PR: bin/116706 Submitted by: edwin@ Approved by: re (Ken Smith), grog (mentor) Revision Changes Path 1.10.2.1 +2 -0 src/usr.bin/makewhatis/makewhatis.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 13:02:55 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B87FC16A418; Thu, 18 Oct 2007 13:02:55 +0000 (UTC) (envelope-from edwin@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9A98B13C4A6; Thu, 18 Oct 2007 13:02:55 +0000 (UTC) (envelope-from edwin@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9ID2tOG059158; Thu, 18 Oct 2007 13:02:55 GMT (envelope-from edwin@repoman.freebsd.org) Received: (from edwin@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9ID2tEu059157; Thu, 18 Oct 2007 13:02:55 GMT (envelope-from edwin) Message-Id: <200710181302.l9ID2tEu059157@repoman.freebsd.org> From: Edwin Groothuis Date: Thu, 18 Oct 2007 13:02:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/share/zoneinfo Makefile africa asia southamerica X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 13:02:55 -0000 edwin 2007-10-18 13:02:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/zoneinfo Makefile africa asia southamerica Log: MFC of src/share/zoneinfo MFV: tzdata2007h Revision Changes Path 1.20.2.4 +0 -0 src/share/zoneinfo/Makefile 1.14.14.6 +13 -3 src/share/zoneinfo/africa 1.25.2.6 +48 -6 src/share/zoneinfo/asia 1.24.2.6 +28 -7 src/share/zoneinfo/southamerica From owner-cvs-src@FreeBSD.ORG Thu Oct 18 13:05:50 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 37D6416A41A; Thu, 18 Oct 2007 13:05:50 +0000 (UTC) (envelope-from edwin@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 1A5A513C442; Thu, 18 Oct 2007 13:05:50 +0000 (UTC) (envelope-from edwin@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9ID5n5D060457; Thu, 18 Oct 2007 13:05:49 GMT (envelope-from edwin@repoman.freebsd.org) Received: (from edwin@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9ID5naO060456; Thu, 18 Oct 2007 13:05:49 GMT (envelope-from edwin) Message-Id: <200710181305.l9ID5naO060456@repoman.freebsd.org> From: Edwin Groothuis Date: Thu, 18 Oct 2007 13:05:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/share/zoneinfo africa asia southamerica X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 13:05:50 -0000 edwin 2007-10-18 13:05:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) share/zoneinfo africa asia southamerica Log: MFC of src/share/zoneinfo MFV: tzdata2007h Revision Changes Path 1.14.8.6 +13 -3 src/share/zoneinfo/africa 1.24.4.9 +48 -6 src/share/zoneinfo/asia 1.22.4.9 +28 -7 src/share/zoneinfo/southamerica From owner-cvs-src@FreeBSD.ORG Thu Oct 18 15:21:35 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BDC8116A469; Thu, 18 Oct 2007 15:21:35 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 97EEF13C458; Thu, 18 Oct 2007 15:21:35 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IFLZ1L070095; Thu, 18 Oct 2007 15:21:35 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IFLZ6C070094; Thu, 18 Oct 2007 15:21:35 GMT (envelope-from yar) Message-Id: <200710181521.l9IFLZ6C070094@repoman.freebsd.org> From: Yar Tikhiy Date: Thu, 18 Oct 2007 15:21:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/mk bsd.symver.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 15:21:35 -0000 yar 2007-10-18 15:21:35 UTC FreeBSD src repository Modified files: share/mk bsd.symver.mk Log: Explicitly verify if we have found the VERSION_GEN script instead of passing the possibly null argument to awk(1) and getting an obscure error from it. Revision Changes Path 1.5 +3 -0 src/share/mk/bsd.symver.mk From owner-cvs-src@FreeBSD.ORG Thu Oct 18 15:36:42 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 91CFD16A41A; Thu, 18 Oct 2007 15:36:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6E20513C4A3; Thu, 18 Oct 2007 15:36:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IFagZ8070854; Thu, 18 Oct 2007 15:36:42 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IFaglV070853; Thu, 18 Oct 2007 15:36:42 GMT (envelope-from jhb) Message-Id: <200710181536.l9IFaglV070853@repoman.freebsd.org> From: John Baldwin Date: Thu, 18 Oct 2007 15:36:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Cc: Subject: cvs commit: src/usr.bin/nfsstat nfsstat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 15:36:42 -0000 jhb 2007-10-18 15:36:42 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) usr.bin/nfsstat nfsstat.c Log: MFC: Use sysctlbyname(3) and some other minor cleanups. Revision Changes Path 1.15.2.4 +9 -14 src/usr.bin/nfsstat/nfsstat.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 15:48:11 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 50AF616A419; Thu, 18 Oct 2007 15:48:11 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2CF2413C448; Thu, 18 Oct 2007 15:48:11 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IFmB8B071389; Thu, 18 Oct 2007 15:48:11 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IFmBZQ071388; Thu, 18 Oct 2007 15:48:11 GMT (envelope-from bde) Message-Id: <200710181548.l9IFmBZQ071388@repoman.freebsd.org> From: Bruce Evans Date: Thu, 18 Oct 2007 15:48:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/msdosfs msdosfs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 15:48:11 -0000 bde 2007-10-18 15:48:10 UTC FreeBSD src repository Modified files: sys/fs/msdosfs msdosfs_vfsops.c Log: Fix some style bugs in the mount options list. Mainly, sort the list, leaving space for adding missing options. Negative options are sorted after removing their "no" prefix, and generic options are sorted before msdosfs-specific ones. Revision Changes Path 1.176 +7 -6 src/sys/fs/msdosfs/msdosfs_vfsops.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 16:25:48 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5181116A417; Thu, 18 Oct 2007 16:25:48 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2EDD513C442; Thu, 18 Oct 2007 16:25:48 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IGPmFw074711; Thu, 18 Oct 2007 16:25:48 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IGPlOX074710; Thu, 18 Oct 2007 16:25:47 GMT (envelope-from bde) Message-Id: <200710181625.l9IGPlOX074710@repoman.freebsd.org> From: Bruce Evans Date: Thu, 18 Oct 2007 16:25:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/msdosfs msdosfs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 16:25:48 -0000 bde 2007-10-18 16:25:47 UTC FreeBSD src repository Modified files: sys/fs/msdosfs msdosfs_vfsops.c Log: Add noclusterr and noclusterw options to the options list. I forgot these when I implemented clustering. Revision Changes Path 1.177 +1 -1 src/sys/fs/msdosfs/msdosfs_vfsops.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 16:38:08 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF9EE16A418; Thu, 18 Oct 2007 16:38:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 518F213C48E; Thu, 18 Oct 2007 16:38:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IGc8xQ075478; Thu, 18 Oct 2007 16:38:08 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IGc8CH075477; Thu, 18 Oct 2007 16:38:08 GMT (envelope-from jhb) Message-Id: <200710181638.l9IGc8CH075477@repoman.freebsd.org> From: John Baldwin Date: Thu, 18 Oct 2007 16:38:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/nfsclient nfs_vfsops.c src/sys/nfsserver nfs_serv.c src/usr.bin/nfsstat nfsstat.1 nfsstat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 16:38:08 -0000 jhb 2007-10-18 16:38:08 UTC FreeBSD src repository Modified files: sys/nfsclient nfs_vfsops.c sys/nfsserver nfs_serv.c usr.bin/nfsstat nfsstat.1 nfsstat.c Log: Add a -z flag to nfsstat which zeros the NFS statistics after displaying them. MFC after: 1 week Requested by: ps Submitted by: ps (6 years ago) Revision Changes Path 1.195 +1 -1 src/sys/nfsclient/nfs_vfsops.c 1.175 +1 -1 src/sys/nfsserver/nfs_serv.c 1.15 +4 -2 src/usr.bin/nfsstat/nfsstat.1 1.22 +44 -22 src/usr.bin/nfsstat/nfsstat.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 16:43:03 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2323016A417; Thu, 18 Oct 2007 16:43:03 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id B1A6413C46E; Thu, 18 Oct 2007 16:43:02 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.1/8.14.1) with ESMTP id l9IGej2G006242; Thu, 18 Oct 2007 10:40:45 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 18 Oct 2007 10:40:44 -0600 (MDT) Message-Id: <20071018.104044.74743493.imp@bsdimp.com> To: netchild@freebsd.org From: Warner Losh In-Reply-To: <20071018112307.pkb8qmn8ao4cog80@webmail.leidinger.net> References: <20071018091134.jzo7m88374ow00c8@webmail.leidinger.net> <20071018.013827.-749244202.imp@bsdimp.com> <20071018112307.pkb8qmn8ao4cog80@webmail.leidinger.net> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: wb@freebie.xs4all.nl, phk@phk.freebsd.dk, src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 16:43:03 -0000 > If someone wants to support Poul in his raid against the _idea_ of the > framework _without_ providing technical arguments against the _idea_, One of my main objections to the framework is that it precludes user-level sensors without some hokey interface for the userland sensor to write into the kernel its current values. It is certainyl a technical weakness in the current setup. It works for some i2c parts and a few others, but it falls down in the general case. That's what Poul has been trying to tell you and you've been dismissing this, and other arguments as irrelevant and tuen turning around and saying Poul isn't making a technical argument. Give me a break. Warner From owner-cvs-src@FreeBSD.ORG Thu Oct 18 16:47:24 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 88E1016A421; Thu, 18 Oct 2007 16:47:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6735113C4B5; Thu, 18 Oct 2007 16:47:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IGlOO4084849; Thu, 18 Oct 2007 16:47:24 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IGlOk6084848; Thu, 18 Oct 2007 16:47:24 GMT (envelope-from jhb) Message-Id: <200710181647.l9IGlOk6084848@repoman.freebsd.org> From: John Baldwin Date: Thu, 18 Oct 2007 16:47:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Cc: Subject: cvs commit: src/share/zoneinfo africa asia southamerica X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 16:47:24 -0000 jhb 2007-10-18 16:47:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) share/zoneinfo africa asia southamerica Log: MFC of src/share/zoneinfo MFV: tzdata2007h Revision Changes Path 1.10.2.7 +13 -3 src/share/zoneinfo/africa 1.14.2.12 +48 -6 src/share/zoneinfo/asia 1.12.2.12 +28 -7 src/share/zoneinfo/southamerica From owner-cvs-src@FreeBSD.ORG Thu Oct 18 16:55:03 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9C9BE16A419; Thu, 18 Oct 2007 16:55:03 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 3E22413C44B; Thu, 18 Oct 2007 16:55:03 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.1/8.14.1) with ESMTP id l9IGptaB006327; Thu, 18 Oct 2007 10:51:56 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 18 Oct 2007 10:51:55 -0600 (MDT) Message-Id: <20071018.105155.41639953.imp@bsdimp.com> To: ticso@cicely.de, ticso@cicely12.cicely.de From: Warner Losh In-Reply-To: <20071018093625.GA17048@cicely12.cicely.de> References: <20071017155225.GU17048@cicely12.cicely.de> <20071018100442.a4i5vidp1c0kg8gg@webmail.leidinger.net> <20071018093625.GA17048@cicely12.cicely.de> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: src-committers@FreeBSD.org, netchild@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, phk@phk.freebsd.dk, wb@freebie.xs4all.nl Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 16:55:03 -0000 > Also Digital didn't used switches to spare a few cent, the i2c was > integrated into the chipset and adding multiple channel didn't work > easily. We also use i2c switches in our product because we have only one i2c channel, but there are many devices on that channel that have to have the same address (think multiple plug-in cards). We have cards that have multiple SFP fiber nodes that are all on the same address, but only one pair of i2c lines to the board. There are good technical reasons why one needs i2c switches in real-world systems. It was cheaper to do the multiplexing than to get a SoC with real multichannel support. > > Thanks for this example. Do you know enough about this code that you > > can help further if Constantine has questions regarding it and Sam has > > no time to answer? > > I will try to help you with questions, but I just know the driver not > the attachment framework. > IIRC Warner Losh did the hint based attachment framework, so he will > likely be able to help you about this. I have a similar driver to the ds1672 as well that's waiting to go into the tree. I'll be happy to answer questions about them both. The whole reason I did hinted i2c was that I have an i2c bus here in my boxes at work that has both 16-bit and 8-bit eeprom on it. The's no way to probe eeprom devices. If you look at only 8-bit addresses, then you'll fail to see the 16-bit ones on the bus. If you look only at the 16-bit ones, then you will write a byte to the 8-bit ones due to the aborted write used to set the read addresses. I also had one device that we wound up not using hang the bus after a 0-byte write to it. It drove the clock line low and nobody else could clock after that. Since this was two years ago, I don't recall the part in question anymore and the hardware guy that I did the evaluation has left the company. Probing the i2c bus is dangerous. You might get away with it in liminited environments, but in general it is bad medicine. However, when I talked to Constatine about it, it seemed like he understood the dangers and was willing to make it optional. Warner From owner-cvs-src@FreeBSD.ORG Thu Oct 18 17:10:40 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C28B216A41A; Thu, 18 Oct 2007 17:10:40 +0000 (UTC) (envelope-from emax@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A118D13C4B5; Thu, 18 Oct 2007 17:10:40 +0000 (UTC) (envelope-from emax@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IHAe5E087192; Thu, 18 Oct 2007 17:10:40 GMT (envelope-from emax@repoman.freebsd.org) Received: (from emax@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IHAekp087191; Thu, 18 Oct 2007 17:10:40 GMT (envelope-from emax) Message-Id: <200710181710.l9IHAekp087191@repoman.freebsd.org> From: Maksim Yevmenkin Date: Thu, 18 Oct 2007 17:10:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/rc.d ppp X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 17:10:40 -0000 emax 2007-10-18 17:10:40 UTC FreeBSD src repository Modified files: etc/rc.d ppp Log: Teach /etc/rc.d/ppp how to start/stop individual instances of ppp. This is an extension of previous commit. Submitted by: Yuri Kurenkov < y dot kurenkov at init dot ru > Reviewed by: mtm MFC after: 3 days Revision Changes Path 1.15 +36 -3 src/etc/rc.d/ppp From owner-cvs-src@FreeBSD.ORG Thu Oct 18 18:30:23 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2DD0B16A417; Thu, 18 Oct 2007 18:30:23 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id A4ACB13C4D5; Thu, 18 Oct 2007 18:30:22 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 215030082-1834499 for multiple; Thu, 18 Oct 2007 14:32:22 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l9IIU4Rx020157; Thu, 18 Oct 2007 14:30:07 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Tom McLaughlin Date: Thu, 18 Oct 2007 11:55:19 -0400 User-Agent: KMail/1.9.6 References: <200710172320.l9HNKnGl063500@repoman.freebsd.org> In-Reply-To: <200710172320.l9HNKnGl063500@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200710181155.19806.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 18 Oct 2007 14:30:07 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4545/Wed Oct 17 17:05:57 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/net nscache.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 18:30:23 -0000 On Wednesday 17 October 2007 07:20:49 pm Tom McLaughlin wrote: > tmclaugh 2007-10-17 23:20:49 UTC > > FreeBSD src repository (ports committer) > > Modified files: > lib/libc/net nscache.c > Log: > - Correctly define CACHED_SOCKET_PATH as /var/run/nscd after cached to > nscd renaming. > > Approved by: mux > > Revision Changes Path > 1.2 +1 -1 src/lib/libc/net/nscache.c Should the macro be called NSCD_SOCKET_PATH perhaps? -- John Baldwin From owner-cvs-src@FreeBSD.ORG Thu Oct 18 18:45:17 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D8E8816A417; Thu, 18 Oct 2007 18:45:17 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B512513C467; Thu, 18 Oct 2007 18:45:17 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IIjHrC093432; Thu, 18 Oct 2007 18:45:17 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IIjHhR093431; Thu, 18 Oct 2007 18:45:17 GMT (envelope-from jhb) Message-Id: <200710181845.l9IIjHhR093431@repoman.freebsd.org> From: John Baldwin Date: Thu, 18 Oct 2007 18:45:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 18:45:18 -0000 jhb 2007-10-18 18:45:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/vm uma_core.c Log: MFC: Allow recursion on the 'zones' internal UMA zone. Approved by: re (kensmith) Revision Changes Path 1.147.2.1 +1 -1 src/sys/vm/uma_core.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 18:45:54 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 32F1616A418; Thu, 18 Oct 2007 18:45:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0F82213C467; Thu, 18 Oct 2007 18:45:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IIjr5J093466; Thu, 18 Oct 2007 18:45:53 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IIjrbE093462; Thu, 18 Oct 2007 18:45:53 GMT (envelope-from jhb) Message-Id: <200710181845.l9IIjrbE093462@repoman.freebsd.org> From: John Baldwin Date: Thu, 18 Oct 2007 18:45:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/vm uma_core.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 18:45:54 -0000 jhb 2007-10-18 18:45:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/vm uma_core.c Log: MFC: Allow recursion on the 'zones' internal UMA zone. Revision Changes Path 1.119.2.20 +1 -1 src/sys/vm/uma_core.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 18:58:09 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B80F916A418; Thu, 18 Oct 2007 18:58:09 +0000 (UTC) (envelope-from grehan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9423313C45A; Thu, 18 Oct 2007 18:58:09 +0000 (UTC) (envelope-from grehan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IIw9nP094070; Thu, 18 Oct 2007 18:58:09 GMT (envelope-from grehan@repoman.freebsd.org) Received: (from grehan@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IIw8FO094069; Thu, 18 Oct 2007 18:58:08 GMT (envelope-from grehan) Message-Id: <200710181858.l9IIw8FO094069@repoman.freebsd.org> From: Peter Grehan Date: Thu, 18 Oct 2007 18:58:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/powerpc Symbol.map X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 18:58:09 -0000 grehan 2007-10-18 18:58:07 UTC FreeBSD src repository Modified files: lib/libc/powerpc Symbol.map Log: Forced commit to signify that previous commit was: Reviewed: yar@ Revision Changes Path 1.7 +1 -1 src/lib/libc/powerpc/Symbol.map From owner-cvs-src@FreeBSD.ORG Thu Oct 18 19:26:24 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1033) id BEBC116A46B; Thu, 18 Oct 2007 19:26:24 +0000 (UTC) Date: Thu, 18 Oct 2007 19:26:24 +0000 From: Alexey Dokuchaev To: John Baldwin Message-ID: <20071018192624.GA17865@FreeBSD.org> References: <200710181536.l9IFaglV070853@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200710181536.l9IFaglV070853@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/nfsstat nfsstat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 19:26:24 -0000 On Thu, Oct 18, 2007 at 03:36:42PM +0000, John Baldwin wrote: > jhb 2007-10-18 15:36:42 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_4) > usr.bin/nfsstat nfsstat.c > Log: > MFC: Use sysctlbyname(3) and some other minor cleanups. Thanks for supporting 4.X, that best FreeBSD around! ./danfe From owner-cvs-src@FreeBSD.ORG Thu Oct 18 19:29:09 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B715616A418 for ; Thu, 18 Oct 2007 19:29:09 +0000 (UTC) (envelope-from wearabnet@yahoo.ca) Received: from web33701.mail.mud.yahoo.com (web33701.mail.mud.yahoo.com [68.142.201.198]) by mx1.freebsd.org (Postfix) with SMTP id 66DDA13C459 for ; Thu, 18 Oct 2007 19:29:09 +0000 (UTC) (envelope-from wearabnet@yahoo.ca) Received: (qmail 88378 invoked by uid 60001); 18 Oct 2007 19:29:08 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.ca; h=X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID; b=ZxabL/eXTdqSe0+3Krxg6jAYmMqSDodwjxqc+aBeggQbLlRXrbYnfnaqPqAZCKVh+IgZm9IyLa47YU9Fn7dK3kNv6lBM1UBgL2LRsQRnHQBn3iToL8ybIHQG1+Zve91aB9LWdl2FCf8xLAkox2nBcf41LnZJ/L9fNXo//r9JQcY=; X-YMail-OSG: TShtExkVM1kMkg5c8UwoTdSdStBvqmm1mBFWTRSjjWzh6Iosp1wql0JIs1kfH8ddF76J4NzF5ZRPKUJ9y.Lb0EICTUNMeDYDDrjTvZ4fa9KykSt3Qm0- Received: from [86.62.225.4] by web33701.mail.mud.yahoo.com via HTTP; Thu, 18 Oct 2007 12:29:08 PDT X-Mailer: YahooMailRC/814.05 YahooMailWebService/0.7.134.12 Date: Thu, 18 Oct 2007 12:29:08 -0700 (PDT) From: Abdullah Ibn Hamad Al-Marri To: Alexey Dokuchaev , John Baldwin MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-ID: <516244.87930.qm@web33701.mail.mud.yahoo.com> Cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/nfsstat nfsstat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 19:29:09 -0000 ----- Original Message ----=0A> From: Alexey Dokuchaev = =0A> To: John Baldwin =0A> Cc: cvs-src@FreeBSD.org; src-co= mmitters@FreeBSD.org; cvs-all@FreeBSD.org=0A> Sent: Thursday, October 18, 2= 007 10:26:24 PM=0A> Subject: Re: cvs commit: src/usr.bin/nfsstat nfsstat.c= =0A> =0A> On Thu, Oct 18, 2007 at 03:36:42PM +0000, John Baldwin wrote:=0A>= > jhb 2007-10-18 15:36:42 UTC=0A> > =0A> > FreeBSD src repositor= y=0A> > =0A> > Modified files: (Branch: RELENG_4)=0A> > usr.bi= n/nfsstat nfsstat.c =0A> > Log:=0A> > MFC: Use sysctlbyname(3) and= some other minor cleanups.=0A> =0A> Thanks for supporting 4.X, that best F= reeBSD around!=0A> =0A> ./danfe=0A=0Aheh! not better than 7.x when it comes= to SMP ;)=0A=0A---=0ARegards, =0A-Abdullah Ibn Hamad Al-Marri=0AArab Porta= l=0Ahttp://www.WeArab.Net/=0A=0A=0A=0A=0A=0A=0A____________________________= ______________________=0ADo You Yahoo!?=0ATired of spam? Yahoo! Mail has t= he best spam protection around =0Ahttp://mail.yahoo.com From owner-cvs-src@FreeBSD.ORG Thu Oct 18 19:36:32 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3BAFD16A421; Thu, 18 Oct 2007 19:36:32 +0000 (UTC) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 1736F13C491; Thu, 18 Oct 2007 19:36:32 +0000 (UTC) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IJaVUg097336; Thu, 18 Oct 2007 19:36:31 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IJaVDi097335; Thu, 18 Oct 2007 19:36:31 GMT (envelope-from peter) Message-Id: <200710181936.l9IJaVDi097335@repoman.freebsd.org> From: Peter Wemm Date: Thu, 18 Oct 2007 19:36:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/crypto/heimdal/appl/su Makefile.am su.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 19:36:32 -0000 peter 2007-10-18 19:36:31 UTC FreeBSD src repository Modified files: crypto/heimdal/appl/su Makefile.am su.c Log: Remove _FREEFALL_CONFIG hacks. su+pam_ksu works well enough to use on the freebsd.org cluster. Revision Changes Path 1.3 +0 -4 src/crypto/heimdal/appl/su/Makefile.am 1.3 +2 -14 src/crypto/heimdal/appl/su/su.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 19:40:25 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 0F17516A420; Thu, 18 Oct 2007 19:40:25 +0000 (UTC) Date: Thu, 18 Oct 2007 19:40:25 +0000 From: Alexey Dokuchaev To: Abdullah Ibn Hamad Al-Marri Message-ID: <20071018194024.GB17865@FreeBSD.org> References: <516244.87930.qm@web33701.mail.mud.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <516244.87930.qm@web33701.mail.mud.yahoo.com> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, John Baldwin Subject: Re: cvs commit: src/usr.bin/nfsstat nfsstat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 19:40:25 -0000 On Thu, Oct 18, 2007 at 12:29:08PM -0700, Abdullah Ibn Hamad Al-Marri wrote: > > From: Alexey Dokuchaev > > > > Thanks for supporting 4.X, that best FreeBSD around! > > > > ./danfe > > heh! not better than 7.x when it comes to SMP ;) 6.2 did not like my PIII desktop, whilst 5.5 did. 6.2-R does not like my laptop because of HDA... With 6.2-S, suspend/resume kills my box. 4.11-S works on one of my servers like a charm. And it would be forever. Yes, I will debug and send patches, but still. ./danfe From owner-cvs-src@FreeBSD.ORG Thu Oct 18 19:42:53 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CD23816A4CF; Thu, 18 Oct 2007 19:42:53 +0000 (UTC) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 1001A13C4BC; Thu, 18 Oct 2007 19:42:52 +0000 (UTC) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IJgpkT097721; Thu, 18 Oct 2007 19:42:51 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IJgp9C097720; Thu, 18 Oct 2007 19:42:51 GMT (envelope-from peter) Message-Id: <200710181942.l9IJgp9C097720@repoman.freebsd.org> From: Peter Wemm Date: Thu, 18 Oct 2007 19:42:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/kerberos5/usr.bin/ksu Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 19:42:54 -0000 peter 2007-10-18 19:42:50 UTC FreeBSD src repository Modified files: kerberos5/usr.bin/ksu Makefile Log: Remove _FREEFALL_CONFIG hacks Revision Changes Path 1.17 +1 -4 src/kerberos5/usr.bin/ksu/Makefile From owner-cvs-src@FreeBSD.ORG Thu Oct 18 20:19:34 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A19E716A420; Thu, 18 Oct 2007 20:19:34 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 946A013C4A5; Thu, 18 Oct 2007 20:19:34 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IKJYpJ000979; Thu, 18 Oct 2007 20:19:34 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IKJYMO000978; Thu, 18 Oct 2007 20:19:34 GMT (envelope-from simon) Message-Id: <200710182019.l9IKJYMO000978@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Thu, 18 Oct 2007 20:19:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: OPENSSL Cc: Subject: cvs commit: src/crypto/openssl/ssl - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 20:19:34 -0000 simon 2007-10-18 20:19:34 UTC FreeBSD src repository src/crypto/openssl/ssl - Imported sources Update of /home/ncvs/src/crypto/openssl/ssl In directory repoman.freebsd.org:/tmp/cvs-serv960 Log Message: Import DTLS security fix from upstream OpenSSL_0_9_8-stable branch. From the OpenSSL advisory: Andy Polyakov discovered a flaw in OpenSSL's DTLS implementation which could lead to the compromise of clients and servers with DTLS enabled. DTLS is a datagram variant of TLS specified in RFC 4347 first supported in OpenSSL version 0.9.8. Note that the vulnerabilities do not affect SSL and TLS so only clients and servers explicitly using DTLS are affected. We believe this flaw will permit remote code execution. Security: CVE-2007-4995 Security: http://www.openssl.org/news/secadv_20071012.txt Status: Vendor Tag: OPENSSL Release Tags: b0_9_8-20071018 U src/crypto/openssl/ssl/d1_both.c U src/crypto/openssl/ssl/dtls1.h U src/crypto/openssl/ssl/ssl.h U src/crypto/openssl/ssl/ssl_err.c No conflicts created by this import From owner-cvs-src@FreeBSD.ORG Thu Oct 18 21:22:16 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 46B3716A417; Thu, 18 Oct 2007 21:22:16 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 37A7D13C468; Thu, 18 Oct 2007 21:22:16 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9ILMGlr014266; Thu, 18 Oct 2007 21:22:16 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9ILMGZV014265; Thu, 18 Oct 2007 21:22:16 GMT (envelope-from thompsa) Message-Id: <200710182122.l9ILMGZV014265@repoman.freebsd.org> From: Andrew Thompson Date: Thu, 18 Oct 2007 21:22:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net ethernet.h if_bridge.c if_ethersubr.c if_vlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 21:22:16 -0000 thompsa 2007-10-18 21:22:15 UTC FreeBSD src repository Modified files: sys/net ethernet.h if_bridge.c if_ethersubr.c if_vlan.c Log: The bridging output function puts the mbuf directly on the interfaces send queue so the output network card must support the same tagging mechanism as how the frame was input (prepended Ethernet header tag or stripped HW mflag). Now the vlan Ethernet header is _always_ stripped in ether_input and the mbuf flagged, only only network cards with VLAN_HWTAGGING enabled would properly re-tag any outgoing vlan frames. If the outgoing interface does not support hardware tagging then readd the vlan header to the front of the frame. Move the common vlan encapsulation in to ether_vlanencap(). Reported by: Erik Osterholm, Jon Otterholm MFC after: 1 week Revision Changes Path 1.33 +1 -0 src/sys/net/ethernet.h 1.104 +17 -1 src/sys/net/if_bridge.c 1.237 +28 -0 src/sys/net/if_ethersubr.c 1.125 +1 -28 src/sys/net/if_vlan.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 21:42:07 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A481016A419; Thu, 18 Oct 2007 21:42:07 +0000 (UTC) (envelope-from darrenr@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9493D13C457; Thu, 18 Oct 2007 21:42:07 +0000 (UTC) (envelope-from darrenr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9ILg7mC015513; Thu, 18 Oct 2007 21:42:07 GMT (envelope-from darrenr@repoman.freebsd.org) Received: (from darrenr@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9ILg7No015512; Thu, 18 Oct 2007 21:42:07 GMT (envelope-from darrenr) Message-Id: <200710182142.l9ILg7No015512@repoman.freebsd.org> From: Darren Reed Date: Thu, 18 Oct 2007 21:42:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: DARRENR Cc: Subject: cvs commit: src/contrib/ipfilter - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 21:42:07 -0000 darrenr 2007-10-18 21:42:07 UTC FreeBSD src repository src/contrib/ipfilter - Imported sources Update of /home/ncvs/src/contrib/ipfilter In directory repoman.freebsd.org:/tmp/cvs-serv15293 Log Message: Import IPFilter 4.1.28 Status: Vendor Tag: DARRENR Release Tags: v4-1-28 U src/contrib/ipfilter/mlf_rule.c U src/contrib/ipfilter/kmem.h U src/contrib/ipfilter/pcap-ipf.h U src/contrib/ipfilter/IMPORTANT U src/contrib/ipfilter/ipmon.h U src/contrib/ipfilter/opts.h C src/contrib/ipfilter/md5.h C src/contrib/ipfilter/Makefile C src/contrib/ipfilter/radix_ipf.h U src/contrib/ipfilter/README U src/contrib/ipfilter/snoop.h U src/contrib/ipfilter/BNF U src/contrib/ipfilter/bpf_filter.c U src/contrib/ipfilter/mlfk_rule.c U src/contrib/ipfilter/mkfilters U src/contrib/ipfilter/STYLE.TXT U src/contrib/ipfilter/HISTORY U src/contrib/ipfilter/ipf.h U src/contrib/ipfilter/BugReport U src/contrib/ipfilter/Y2K C src/contrib/ipfilter/ip_fil.c C src/contrib/ipfilter/radix.c U src/contrib/ipfilter/ipt.h U src/contrib/ipfilter/WhatsNew40.txt U src/contrib/ipfilter/NAT.FreeBSD U src/contrib/ipfilter/md5.c U src/contrib/ipfilter/FAQ.FreeBSD U src/contrib/ipfilter/bsdinstall U src/contrib/ipfilter/bpf-ipf.h U src/contrib/ipfilter/BSD/ipfadm-rcd U src/contrib/ipfilter/BSD/kupgrade U src/contrib/ipfilter/BSD/Makefile.ipsend U src/contrib/ipfilter/BSD/make-devices U src/contrib/ipfilter/BSD/Makefile U src/contrib/ipfilter/FWTK/Index U src/contrib/ipfilter/FWTK/ftp-gw.diff U src/contrib/ipfilter/FWTK/README.ipfilter U src/contrib/ipfilter/FWTK/fwtk_transparent.diff U src/contrib/ipfilter/FWTK/fwtkp U src/contrib/ipfilter/FWTK/README U src/contrib/ipfilter/etc/services U src/contrib/ipfilter/etc/protocols U src/contrib/ipfilter/samples/Makefile U src/contrib/ipfilter/samples/userauth.c U src/contrib/ipfilter/samples/relay.c U src/contrib/ipfilter/samples/ipfilter-pb.gif U src/contrib/ipfilter/samples/proxy.c U src/contrib/ipfilter/test/nattest U src/contrib/ipfilter/test/itest U src/contrib/ipfilter/test/bpftest U src/contrib/ipfilter/test/Makefile U src/contrib/ipfilter/test/dotest U src/contrib/ipfilter/test/intest U src/contrib/ipfilter/test/hextest U src/contrib/ipfilter/test/mhtest U src/contrib/ipfilter/test/ptest U src/contrib/ipfilter/test/dotest6 U src/contrib/ipfilter/test/iptest U src/contrib/ipfilter/test/README.TXT U src/contrib/ipfilter/test/mtest U src/contrib/ipfilter/test/natipftest U src/contrib/ipfilter/test/test.format U src/contrib/ipfilter/test/logtest U src/contrib/ipfilter/test/vfycksum.pl U src/contrib/ipfilter/test/expected/f6 U src/contrib/ipfilter/test/expected/ni23 U src/contrib/ipfilter/test/expected/f10 U src/contrib/ipfilter/test/expected/ni11 U src/contrib/ipfilter/test/expected/p5 U src/contrib/ipfilter/test/expected/n6 U src/contrib/ipfilter/test/expected/i1 U src/contrib/ipfilter/test/expected/ni5 U src/contrib/ipfilter/test/expected/bpf-f1 U src/contrib/ipfilter/test/expected/n14 U src/contrib/ipfilter/test/expected/i15 U src/contrib/ipfilter/test/expected/in3 U src/contrib/ipfilter/test/expected/i12 U src/contrib/ipfilter/test/expected/i18 U src/contrib/ipfilter/test/expected/in4 U src/contrib/ipfilter/test/expected/ni2 U src/contrib/ipfilter/test/expected/ni8 U src/contrib/ipfilter/test/expected/n13 U src/contrib/ipfilter/test/expected/i20 U src/contrib/ipfilter/test/expected/i6 U src/contrib/ipfilter/test/expected/n1 U src/contrib/ipfilter/test/expected/p2 U src/contrib/ipfilter/test/expected/ni16 U src/contrib/ipfilter/test/expected/f17 U src/contrib/ipfilter/test/expected/f1 U src/contrib/ipfilter/test/expected/f13 U src/contrib/ipfilter/test/expected/f19 U src/contrib/ipfilter/test/expected/ni20 U src/contrib/ipfilter/test/expected/f5 U src/contrib/ipfilter/test/expected/ipv6.3 U src/contrib/ipfilter/test/expected/ni12 U src/contrib/ipfilter/test/expected/ni6 U src/contrib/ipfilter/test/expected/i8 U src/contrib/ipfilter/test/expected/i2 U src/contrib/ipfilter/test/expected/n5 U src/contrib/ipfilter/test/expected/i16 U src/contrib/ipfilter/test/expected/i11 U src/contrib/ipfilter/test/expected/n8 U src/contrib/ipfilter/test/expected/n2 U src/contrib/ipfilter/test/expected/i5 U src/contrib/ipfilter/test/expected/n10 U src/contrib/ipfilter/test/expected/ni1 U src/contrib/ipfilter/test/expected/ni15 U src/contrib/ipfilter/test/expected/p1 U src/contrib/ipfilter/test/expected/f8 U src/contrib/ipfilter/test/expected/f2 U src/contrib/ipfilter/test/expected/f14 N src/contrib/ipfilter/test/expected/i19.dist N src/contrib/ipfilter/test/expected/f24 U src/contrib/ipfilter/test/expected/p3 N src/contrib/ipfilter/test/expected/ipv6.6 U src/contrib/ipfilter/test/expected/l1 U src/contrib/ipfilter/test/expected/f16 U src/contrib/ipfilter/test/expected/bpf1 U src/contrib/ipfilter/test/expected/in5 U src/contrib/ipfilter/test/expected/i13 U src/contrib/ipfilter/test/expected/n12 U src/contrib/ipfilter/test/expected/ni9 U src/contrib/ipfilter/test/expected/ni3 U src/contrib/ipfilter/test/expected/i7 U src/contrib/ipfilter/test/expected/i21 U src/contrib/ipfilter/test/expected/n7 U src/contrib/ipfilter/test/expected/ni4 U src/contrib/ipfilter/test/expected/in2 U src/contrib/ipfilter/test/expected/i14 U src/contrib/ipfilter/test/expected/l1.b U src/contrib/ipfilter/test/expected/f7 U src/contrib/ipfilter/test/expected/f11 N src/contrib/ipfilter/test/expected/Makefile U src/contrib/ipfilter/test/expected/ip1 U src/contrib/ipfilter/test/expected/ni10 U src/contrib/ipfilter/test/expected/ipv6.1 U src/contrib/ipfilter/test/expected/ni14 U src/contrib/ipfilter/test/expected/ipv6.5 U src/contrib/ipfilter/test/expected/f3 U src/contrib/ipfilter/test/expected/f9 U src/contrib/ipfilter/test/expected/f15 U src/contrib/ipfilter/test/expected/i10 U src/contrib/ipfilter/test/expected/in6 U src/contrib/ipfilter/test/expected/i4 U src/contrib/ipfilter/test/expected/n3 U src/contrib/ipfilter/test/expected/n9 U src/contrib/ipfilter/test/expected/n11 U src/contrib/ipfilter/test/expected/ni7 N src/contrib/ipfilter/test/expected/n16 U src/contrib/ipfilter/test/expected/n4 U src/contrib/ipfilter/test/expected/i3 U src/contrib/ipfilter/test/expected/i9 U src/contrib/ipfilter/test/expected/i17 U src/contrib/ipfilter/test/expected/in1 U src/contrib/ipfilter/test/expected/ip2 U src/contrib/ipfilter/test/expected/f18 U src/contrib/ipfilter/test/expected/f12 U src/contrib/ipfilter/test/expected/f4 U src/contrib/ipfilter/test/expected/ni21 U src/contrib/ipfilter/test/expected/ipv6.2 U src/contrib/ipfilter/test/expected/f20 U src/contrib/ipfilter/test/expected/ni19 U src/contrib/ipfilter/test/expected/ni13 N src/contrib/ipfilter/test/regress/n16 U src/contrib/ipfilter/test/regress/i17 U src/contrib/ipfilter/test/regress/in1 U src/contrib/ipfilter/test/regress/f1 U src/contrib/ipfilter/test/regress/f18 U src/contrib/ipfilter/test/regress/ip2 U src/contrib/ipfilter/test/regress/f12 U src/contrib/ipfilter/test/regress/p3.pool U src/contrib/ipfilter/test/regress/i6 U src/contrib/ipfilter/test/regress/n1 U src/contrib/ipfilter/test/regress/f20 U src/contrib/ipfilter/test/regress/ni15.nat U src/contrib/ipfilter/test/regress/ni21.ipf U src/contrib/ipfilter/test/regress/n6 U src/contrib/ipfilter/test/regress/i1 U src/contrib/ipfilter/test/regress/ni12.nat U src/contrib/ipfilter/test/regress/ni4.ipf U src/contrib/ipfilter/test/regress/f15 U src/contrib/ipfilter/test/regress/ni3.ipf U src/contrib/ipfilter/test/regress/bpf-f1 U src/contrib/ipfilter/test/regress/ni2.nat U src/contrib/ipfilter/test/regress/f6 U src/contrib/ipfilter/test/regress/i10 U src/contrib/ipfilter/test/regress/in6 U src/contrib/ipfilter/test/regress/ni5.nat U src/contrib/ipfilter/test/regress/ni13.ipf U src/contrib/ipfilter/test/regress/n11 U src/contrib/ipfilter/test/regress/ni14.ipf U src/contrib/ipfilter/test/regress/ni20.nat U src/contrib/ipfilter/test/regress/bpf1 U src/contrib/ipfilter/test/regress/f2 U src/contrib/ipfilter/test/regress/f8 U src/contrib/ipfilter/test/regress/p1.ipf U src/contrib/ipfilter/test/regress/in2 U src/contrib/ipfilter/test/regress/i14 U src/contrib/ipfilter/test/regress/f11 U src/contrib/ipfilter/test/regress/ip1 U src/contrib/ipfilter/test/regress/n2 U src/contrib/ipfilter/test/regress/i5 U src/contrib/ipfilter/test/regress/n8 U src/contrib/ipfilter/test/regress/ni15.ipf U src/contrib/ipfilter/test/regress/ni21.nat U src/contrib/ipfilter/test/regress/ni12.ipf U src/contrib/ipfilter/test/regress/i2 N src/contrib/ipfilter/test/regress/f24 U src/contrib/ipfilter/test/regress/n5 U src/contrib/ipfilter/test/regress/i8 U src/contrib/ipfilter/test/regress/ni4.nat U src/contrib/ipfilter/test/regress/ni3.nat U src/contrib/ipfilter/test/regress/f16 U src/contrib/ipfilter/test/regress/ni2.ipf U src/contrib/ipfilter/test/regress/i19 U src/contrib/ipfilter/test/regress/ipv6.3 U src/contrib/ipfilter/test/regress/in5 U src/contrib/ipfilter/test/regress/i13 U src/contrib/ipfilter/test/regress/f5 U src/contrib/ipfilter/test/regress/ni5.ipf U src/contrib/ipfilter/test/regress/ni13.nat U src/contrib/ipfilter/test/regress/i21 U src/contrib/ipfilter/test/regress/n12 U src/contrib/ipfilter/test/regress/ni14.nat U src/contrib/ipfilter/test/regress/ni20.ipf U src/contrib/ipfilter/test/regress/ni11.ipf U src/contrib/ipfilter/test/regress/f7 U src/contrib/ipfilter/test/regress/ni9.nat U src/contrib/ipfilter/test/regress/ipv6.1 U src/contrib/ipfilter/test/regress/ni16.ipf U src/contrib/ipfilter/test/regress/i11 U src/contrib/ipfilter/test/regress/n10 U src/contrib/ipfilter/test/regress/ni7.nat U src/contrib/ipfilter/test/regress/n7 U src/contrib/ipfilter/test/regress/ni6.ipf U src/contrib/ipfilter/test/regress/ni1.ipf U src/contrib/ipfilter/test/regress/ni19.nat U src/contrib/ipfilter/test/regress/f14 U src/contrib/ipfilter/test/regress/ni23.ipf U src/contrib/ipfilter/test/regress/ni17.nat U src/contrib/ipfilter/test/regress/ni10.nat U src/contrib/ipfilter/test/regress/ni8.ipf U src/contrib/ipfilter/test/regress/f13 U src/contrib/ipfilter/test/regress/f19 U src/contrib/ipfilter/test/regress/p5.ipf U src/contrib/ipfilter/test/regress/i7 U src/contrib/ipfilter/test/regress/p2.ipf U src/contrib/ipfilter/test/regress/l1 N src/contrib/ipfilter/test/regress/ipv6.6 U src/contrib/ipfilter/test/regress/i16 U src/contrib/ipfilter/test/regress/ni11.nat U src/contrib/ipfilter/test/regress/i12 U src/contrib/ipfilter/test/regress/ni9.ipf U src/contrib/ipfilter/test/regress/in4 U src/contrib/ipfilter/test/regress/i18 U src/contrib/ipfilter/test/regress/ipv6.2 U src/contrib/ipfilter/test/regress/ni16.nat U src/contrib/ipfilter/test/regress/f4 U src/contrib/ipfilter/test/regress/i20 U src/contrib/ipfilter/test/regress/p5.pool U src/contrib/ipfilter/test/regress/ni7.ipf U src/contrib/ipfilter/test/regress/n13 U src/contrib/ipfilter/test/regress/ni6.nat U src/contrib/ipfilter/test/regress/ni1.nat U src/contrib/ipfilter/test/regress/i9 U src/contrib/ipfilter/test/regress/n4 U src/contrib/ipfilter/test/regress/i3 U src/contrib/ipfilter/test/regress/ni19.ipf U src/contrib/ipfilter/test/regress/ni23.nat U src/contrib/ipfilter/test/regress/ni10.ipf U src/contrib/ipfilter/test/regress/ni8.nat U src/contrib/ipfilter/test/regress/p1.pool U src/contrib/ipfilter/test/regress/f17 U src/contrib/ipfilter/test/regress/f10 U src/contrib/ipfilter/test/regress/n9 U src/contrib/ipfilter/test/regress/i4 U src/contrib/ipfilter/test/regress/n3 U src/contrib/ipfilter/test/regress/p3.ipf U src/contrib/ipfilter/test/regress/n14 U src/contrib/ipfilter/test/regress/f9 U src/contrib/ipfilter/test/regress/f3 U src/contrib/ipfilter/test/regress/i15 U src/contrib/ipfilter/test/regress/in3 U src/contrib/ipfilter/test/regress/ipv6.5 U src/contrib/ipfilter/test/input/n7 U src/contrib/ipfilter/test/input/f14 U src/contrib/ipfilter/test/input/f7 U src/contrib/ipfilter/test/input/ni17 U src/contrib/ipfilter/test/input/n10 U src/contrib/ipfilter/test/input/ni1 U src/contrib/ipfilter/test/input/ni10 U src/contrib/ipfilter/test/input/ni6 U src/contrib/ipfilter/test/input/p3 U src/contrib/ipfilter/test/input/l1 U src/contrib/ipfilter/test/input/f13 U src/contrib/ipfilter/test/input/f19 U src/contrib/ipfilter/test/input/f17 U src/contrib/ipfilter/test/input/n4 U src/contrib/ipfilter/test/input/ni2 U src/contrib/ipfilter/test/input/n13 U src/contrib/ipfilter/test/input/ni8 U src/contrib/ipfilter/test/input/ni14 U src/contrib/ipfilter/test/input/ipv6.3 U src/contrib/ipfilter/test/input/f4 U src/contrib/ipfilter/test/input/f9 U src/contrib/ipfilter/test/input/f3 U src/contrib/ipfilter/test/input/ni19 U src/contrib/ipfilter/test/input/ni5 U src/contrib/ipfilter/test/input/n14 U src/contrib/ipfilter/test/input/ni13 U src/contrib/ipfilter/test/input/ni21 U src/contrib/ipfilter/test/input/n9 U src/contrib/ipfilter/test/input/n3 U src/contrib/ipfilter/test/input/f10 U src/contrib/ipfilter/test/input/f18 U src/contrib/ipfilter/test/input/f12 U src/contrib/ipfilter/test/input/n1 U src/contrib/ipfilter/test/input/f20 U src/contrib/ipfilter/test/input/ni7 N src/contrib/ipfilter/test/input/n16 U src/contrib/ipfilter/test/input/ni11 N src/contrib/ipfilter/test/input/ipv6.6 U src/contrib/ipfilter/test/input/f1 U src/contrib/ipfilter/test/input/p2 U src/contrib/ipfilter/test/input/ni23 U src/contrib/ipfilter/test/input/p5 U src/contrib/ipfilter/test/input/ipv6.1 U src/contrib/ipfilter/test/input/f6 U src/contrib/ipfilter/test/input/n11 U src/contrib/ipfilter/test/input/ni16 U src/contrib/ipfilter/test/input/n6 U src/contrib/ipfilter/test/input/f15 U src/contrib/ipfilter/test/input/n2 U src/contrib/ipfilter/test/input/n8 U src/contrib/ipfilter/test/input/f11 U src/contrib/ipfilter/test/input/f2 U src/contrib/ipfilter/test/input/f8 U src/contrib/ipfilter/test/input/ipv6.5 U src/contrib/ipfilter/test/input/ni12 U src/contrib/ipfilter/test/input/ni4 U src/contrib/ipfilter/test/input/ip2.data U src/contrib/ipfilter/test/input/ni20 U src/contrib/ipfilter/test/input/p1 U src/contrib/ipfilter/test/input/ni9 U src/contrib/ipfilter/test/input/ni15 U src/contrib/ipfilter/test/input/n12 U src/contrib/ipfilter/test/input/ni3 U src/contrib/ipfilter/test/input/f5 U src/contrib/ipfilter/test/input/ipv6.2 N src/contrib/ipfilter/test/input/f24 U src/contrib/ipfilter/test/input/f16 U src/contrib/ipfilter/test/input/n5 U src/contrib/ipfilter/l4check/l4check.conf U src/contrib/ipfilter/l4check/http.check C src/contrib/ipfilter/l4check/l4check.c U src/contrib/ipfilter/l4check/Makefile U src/contrib/ipfilter/l4check/http.ok U src/contrib/ipfilter/lib/load_poolnode.c U src/contrib/ipfilter/lib/getproto.c U src/contrib/ipfilter/lib/printip.c U src/contrib/ipfilter/lib/ipft_td.c U src/contrib/ipfilter/lib/verbose.c U src/contrib/ipfilter/lib/getsumd.c U src/contrib/ipfilter/lib/getportproto.c U src/contrib/ipfilter/lib/printpool.c U src/contrib/ipfilter/lib/rwlock_emul.c U src/contrib/ipfilter/lib/nametokva.c U src/contrib/ipfilter/lib/getifname.c U src/contrib/ipfilter/lib/var.c U src/contrib/ipfilter/lib/icmpcode.c U src/contrib/ipfilter/lib/initparse.c U src/contrib/ipfilter/lib/print_toif.c U src/contrib/ipfilter/lib/flags.c U src/contrib/ipfilter/lib/printpoolnode.c U src/contrib/ipfilter/lib/bcopywrap.c U src/contrib/ipfilter/lib/ipft_ef.c U src/contrib/ipfilter/lib/remove_pool.c U src/contrib/ipfilter/lib/printhashdata.c C src/contrib/ipfilter/lib/printstate.c U src/contrib/ipfilter/lib/kmem.h U src/contrib/ipfilter/lib/optprintv6.c U src/contrib/ipfilter/lib/hostname.c U src/contrib/ipfilter/lib/load_hashnode.c U src/contrib/ipfilter/lib/Makefile C src/contrib/ipfilter/lib/ipft_tx.c U src/contrib/ipfilter/lib/printaps.c U src/contrib/ipfilter/lib/ipft_sn.c U src/contrib/ipfilter/lib/optname.c U src/contrib/ipfilter/lib/facpri.c U src/contrib/ipfilter/lib/load_http.c U src/contrib/ipfilter/lib/printhash.c U src/contrib/ipfilter/lib/inet_addr.c U src/contrib/ipfilter/lib/printpool_live.c C src/contrib/ipfilter/lib/printpacket.c U src/contrib/ipfilter/lib/load_file.c U src/contrib/ipfilter/lib/printportcmp.c U src/contrib/ipfilter/lib/printmask.c U src/contrib/ipfilter/lib/printhashnode.c U src/contrib/ipfilter/lib/printhostmask.c U src/contrib/ipfilter/lib/printlog.c U src/contrib/ipfilter/lib/printpooldata.c U src/contrib/ipfilter/lib/alist_new.c U src/contrib/ipfilter/lib/optprint.c U src/contrib/ipfilter/lib/remove_hash.c U src/contrib/ipfilter/lib/kmem.c U src/contrib/ipfilter/lib/load_url.c U src/contrib/ipfilter/lib/optvalue.c U src/contrib/ipfilter/lib/alist_free.c U src/contrib/ipfilter/lib/debug.c U src/contrib/ipfilter/lib/count4bits.c U src/contrib/ipfilter/lib/ipft_hx.c U src/contrib/ipfilter/lib/printhash_live.c U src/contrib/ipfilter/lib/printproto.c U src/contrib/ipfilter/lib/portname.c U src/contrib/ipfilter/lib/binprint.c U src/contrib/ipfilter/lib/buildopts.c U src/contrib/ipfilter/lib/gethost.c U src/contrib/ipfilter/lib/tcp_flags.c U src/contrib/ipfilter/lib/printtunable.c U src/contrib/ipfilter/lib/load_hash.c U src/contrib/ipfilter/lib/fill6bits.c U src/contrib/ipfilter/lib/printactivenat.c U src/contrib/ipfilter/lib/printfraginfo.c U src/contrib/ipfilter/lib/ntomask.c U src/contrib/ipfilter/lib/remove_poolnode.c U src/contrib/ipfilter/lib/checkrev.c U src/contrib/ipfilter/lib/printtqtable.c U src/contrib/ipfilter/lib/ipf_dotuning.c U src/contrib/ipfilter/lib/kvatoname.c U src/contrib/ipfilter/lib/printfr.c U src/contrib/ipfilter/lib/getport.c U src/contrib/ipfilter/lib/addipopt.c U src/contrib/ipfilter/lib/ionames.c U src/contrib/ipfilter/lib/mutex_emul.c U src/contrib/ipfilter/lib/printpacket6.c U src/contrib/ipfilter/lib/ipft_pc.c U src/contrib/ipfilter/lib/printsbuf.c U src/contrib/ipfilter/lib/count6bits.c U src/contrib/ipfilter/lib/v6optvalue.c U src/contrib/ipfilter/lib/printbuf.c U src/contrib/ipfilter/lib/printhostmap.c U src/contrib/ipfilter/lib/nat_setgroupmap.c U src/contrib/ipfilter/lib/addicmp.c U src/contrib/ipfilter/lib/printifname.c U src/contrib/ipfilter/lib/v6ionames.c U src/contrib/ipfilter/lib/getnattype.c U src/contrib/ipfilter/lib/resetlexer.c U src/contrib/ipfilter/lib/load_pool.c U src/contrib/ipfilter/lib/kmemcpywrap.c U src/contrib/ipfilter/lib/remove_hashnode.c U src/contrib/ipfilter/lib/facpri.h U src/contrib/ipfilter/lib/ipoptsec.c U src/contrib/ipfilter/lib/tcpflags.c C src/contrib/ipfilter/lib/printnat.c U src/contrib/ipfilter/tools/ipsyncs.c C src/contrib/ipfilter/tools/ipfstat.c U src/contrib/ipfilter/tools/ipftest.c U src/contrib/ipfilter/tools/ipsyncm.c U src/contrib/ipfilter/tools/ipfcomp.c U src/contrib/ipfilter/tools/lexer.h U src/contrib/ipfilter/tools/ipfs.c U src/contrib/ipfilter/tools/ippool_y.y U src/contrib/ipfilter/tools/Makefile C src/contrib/ipfilter/tools/ipnat.c U src/contrib/ipfilter/tools/ipmon_y.y U src/contrib/ipfilter/tools/BNF.ipnat C src/contrib/ipfilter/tools/ipf_y.y U src/contrib/ipfilter/tools/lex_var.h C src/contrib/ipfilter/tools/ipnat_y.y U src/contrib/ipfilter/tools/ipf.c U src/contrib/ipfilter/tools/ipscan_y.y U src/contrib/ipfilter/tools/BNF.ipf U src/contrib/ipfilter/tools/ippool.c C src/contrib/ipfilter/tools/lexer.c C src/contrib/ipfilter/tools/ipmon.c U src/contrib/ipfilter/iplang/iplang.h U src/contrib/ipfilter/iplang/iplang_l.l U src/contrib/ipfilter/iplang/iplang.tst U src/contrib/ipfilter/iplang/Makefile U src/contrib/ipfilter/iplang/BNF U src/contrib/ipfilter/iplang/iplang_y.y U src/contrib/ipfilter/rules/firewall U src/contrib/ipfilter/rules/example.12 U src/contrib/ipfilter/rules/example.6 U src/contrib/ipfilter/rules/ip_rules U src/contrib/ipfilter/rules/example.1 U src/contrib/ipfilter/rules/tcpstate U src/contrib/ipfilter/rules/nat.eg U src/contrib/ipfilter/rules/BASIC_1.FW U src/contrib/ipfilter/rules/example.sr U src/contrib/ipfilter/rules/example.5 U src/contrib/ipfilter/rules/example.11 U src/contrib/ipfilter/rules/example.2 U src/contrib/ipfilter/rules/example.8 U src/contrib/ipfilter/rules/BASIC_2.FW U src/contrib/ipfilter/rules/ipmon.conf U src/contrib/ipfilter/rules/ftppxy U src/contrib/ipfilter/rules/ftp-proxy U src/contrib/ipfilter/rules/example.7 U src/contrib/ipfilter/rules/example.13 U src/contrib/ipfilter/rules/BASIC.NAT U src/contrib/ipfilter/rules/example.9 U src/contrib/ipfilter/rules/example.3 U src/contrib/ipfilter/rules/pool.conf U src/contrib/ipfilter/rules/example.10 U src/contrib/ipfilter/rules/example.4 U src/contrib/ipfilter/rules/nat-setup U src/contrib/ipfilter/rules/server U src/contrib/ipfilter/perl/Services U src/contrib/ipfilter/perl/ipf-mrtg.pl U src/contrib/ipfilter/perl/LICENSE U src/contrib/ipfilter/perl/Isbgraph U src/contrib/ipfilter/perl/plog U src/contrib/ipfilter/perl/ipfmeta.pl U src/contrib/ipfilter/perl/logfilter.pl U src/contrib/ipfilter/perl/Ipfanaly.pl U src/contrib/ipfilter/ipsd/sbpf.c U src/contrib/ipfilter/ipsd/linux.h U src/contrib/ipfilter/ipsd/ipsdr.c U src/contrib/ipfilter/ipsd/slinux.c U src/contrib/ipfilter/ipsd/sdlpi.c U src/contrib/ipfilter/ipsd/ipsd.h U src/contrib/ipfilter/ipsd/snit.c U src/contrib/ipfilter/ipsd/README U src/contrib/ipfilter/ipsd/ipsd.c U src/contrib/ipfilter/ipsd/Makefile U src/contrib/ipfilter/ipsd/Celler/ip_compat.h U src/contrib/ipfilter/man/ipftest.1 U src/contrib/ipfilter/man/ipl.4 U src/contrib/ipfilter/man/ipf.4 U src/contrib/ipfilter/man/Makefile U src/contrib/ipfilter/man/ipfilter.4.mandoc C src/contrib/ipfilter/man/ippool.5 U src/contrib/ipfilter/man/ipmon.5 U src/contrib/ipfilter/man/ipmon.8 U src/contrib/ipfilter/man/ipnat.4 U src/contrib/ipfilter/man/ipfstat.8 U src/contrib/ipfilter/man/ippool.8 U src/contrib/ipfilter/man/ipfilter.5 U src/contrib/ipfilter/man/ipscan.5 U src/contrib/ipfilter/man/ipf.8 U src/contrib/ipfilter/man/ipf.5 U src/contrib/ipfilter/man/ipscan.8 U src/contrib/ipfilter/man/mkfilters.1 U src/contrib/ipfilter/man/ipfilter.4 U src/contrib/ipfilter/man/ipnat.5 U src/contrib/ipfilter/man/ipnat.8 U src/contrib/ipfilter/man/ipfs.8 U src/contrib/ipfilter/ipsend/tcpip.h C src/contrib/ipfilter/ipsend/iptests.c U src/contrib/ipfilter/ipsend/iptest.c U src/contrib/ipfilter/ipsend/Makefile C src/contrib/ipfilter/ipsend/sock.c U src/contrib/ipfilter/ipsend/ipsend.h U src/contrib/ipfilter/ipsend/ip_var.h U src/contrib/ipfilter/ipsend/lsock.c U src/contrib/ipfilter/ipsend/ipresend.c U src/contrib/ipfilter/ipsend/dltest.h U src/contrib/ipfilter/ipsend/44arp.c U src/contrib/ipfilter/ipsend/Crashable U src/contrib/ipfilter/ipsend/sbpf.c U src/contrib/ipfilter/ipsend/ipsend.5 U src/contrib/ipfilter/ipsend/ipsend.1 U src/contrib/ipfilter/ipsend/sockraw.c U src/contrib/ipfilter/ipsend/resend.c U src/contrib/ipfilter/ipsend/sirix.c U src/contrib/ipfilter/ipsend/larp.c U src/contrib/ipfilter/ipsend/ipsopt.c U src/contrib/ipfilter/ipsend/arp.c U src/contrib/ipfilter/ipsend/snit.c U src/contrib/ipfilter/ipsend/hpux.c U src/contrib/ipfilter/ipsend/ipsend.c U src/contrib/ipfilter/ipsend/ipresend.1 U src/contrib/ipfilter/ipsend/sdlpi.c U src/contrib/ipfilter/ipsend/dlcommon.c U src/contrib/ipfilter/ipsend/ip.c U src/contrib/ipfilter/ipsend/slinux.c U src/contrib/ipfilter/ipsend/linux.h U src/contrib/ipfilter/ipsend/iptest.1 U src/contrib/ipfilter/ipsend/in_var.h U src/contrib/ipfilter/ipsend/README U src/contrib/ipfilter/ipsend/.OLD/ip_compat.h 19 conflicts created by this import. Use the following command to help the merge: cvs checkout -jDARRENR:yesterday -jDARRENR src/contrib/ipfilter From owner-cvs-src@FreeBSD.ORG Thu Oct 18 21:42:54 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E4BD016A41B; Thu, 18 Oct 2007 21:42:54 +0000 (UTC) (envelope-from darrenr@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id D454613C469; Thu, 18 Oct 2007 21:42:54 +0000 (UTC) (envelope-from darrenr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9ILgs8J015589; Thu, 18 Oct 2007 21:42:54 GMT (envelope-from darrenr@repoman.freebsd.org) Received: (from darrenr@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9ILgsGd015588; Thu, 18 Oct 2007 21:42:54 GMT (envelope-from darrenr) Message-Id: <200710182142.l9ILgsGd015588@repoman.freebsd.org> From: Darren Reed Date: Thu, 18 Oct 2007 21:42:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: DARRENR Cc: Subject: cvs commit: src/sys/contrib/ipfilter/netinet - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 21:42:55 -0000 darrenr 2007-10-18 21:42:54 UTC FreeBSD src repository src/sys/contrib/ipfilter/netinet - Imported sources Update of /home/ncvs/src/sys/contrib/ipfilter/netinet In directory repoman.freebsd.org:/tmp/cvs-serv15525 Log Message: Import IPFilter 4.1.28 Status: Vendor Tag: DARRENR Release Tags: v4-1-28 C src/sys/contrib/ipfilter/netinet/ip_nat.h C src/sys/contrib/ipfilter/netinet/ip_fil.h C src/sys/contrib/ipfilter/netinet/ip_sync.c U src/sys/contrib/ipfilter/netinet/ip_rcmd_pxy.c U src/sys/contrib/ipfilter/netinet/QNX_OCL.txt U src/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c C src/sys/contrib/ipfilter/netinet/fil.c U src/sys/contrib/ipfilter/netinet/ip_raudio_pxy.c C src/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c C src/sys/contrib/ipfilter/netinet/ip_htable.c U src/sys/contrib/ipfilter/netinet/ip_pool.h C src/sys/contrib/ipfilter/netinet/ip_state.c U src/sys/contrib/ipfilter/netinet/ip_irc_pxy.c U src/sys/contrib/ipfilter/netinet/ip_auth.h C src/sys/contrib/ipfilter/netinet/ip_log.c U src/sys/contrib/ipfilter/netinet/ip_lookup.c C src/sys/contrib/ipfilter/netinet/ipl.h C src/sys/contrib/ipfilter/netinet/ip_proxy.c U src/sys/contrib/ipfilter/netinet/ip_scan.c U src/sys/contrib/ipfilter/netinet/IPFILTER.LICENCE U src/sys/contrib/ipfilter/netinet/ip_frag.h U src/sys/contrib/ipfilter/netinet/ip_rpcb_pxy.c U src/sys/contrib/ipfilter/netinet/ip_htable.h U src/sys/contrib/ipfilter/netinet/ip_pool.c C src/sys/contrib/ipfilter/netinet/ip_state.h C src/sys/contrib/ipfilter/netinet/ip_auth.c C src/sys/contrib/ipfilter/netinet/mlfk_ipl.c U src/sys/contrib/ipfilter/netinet/ip_ipsec_pxy.c C src/sys/contrib/ipfilter/netinet/ip_nat.c U src/sys/contrib/ipfilter/netinet/ip_sync.h U src/sys/contrib/ipfilter/netinet/ip_netbios_pxy.c C src/sys/contrib/ipfilter/netinet/ip_compat.h C src/sys/contrib/ipfilter/netinet/ip_frag.c U src/sys/contrib/ipfilter/netinet/ip_scan.h U src/sys/contrib/ipfilter/netinet/ip_pptp_pxy.c U src/sys/contrib/ipfilter/netinet/ip_lookup.h U src/sys/contrib/ipfilter/netinet/ip_proxy.h 16 conflicts created by this import. Use the following command to help the merge: cvs checkout -jDARRENR:yesterday -jDARRENR src/sys/contrib/ipfilter/netinet From owner-cvs-src@FreeBSD.ORG Thu Oct 18 21:44:22 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A413716A421; Thu, 18 Oct 2007 21:44:22 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 587A013C468; Thu, 18 Oct 2007 21:44:22 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9ILiMkR015701; Thu, 18 Oct 2007 21:44:22 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9ILiMhS015700; Thu, 18 Oct 2007 21:44:22 GMT (envelope-from cognet) Message-Id: <200710182144.l9ILiMhS015700@repoman.freebsd.org> From: Olivier Houchard Date: Thu, 18 Oct 2007 21:44:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/arm Symbol.map X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 21:44:22 -0000 cognet 2007-10-18 21:44:21 UTC FreeBSD src repository Modified files: lib/libc/arm Symbol.map Log: Unbreak arm build by removing duplicate symbols. Revision Changes Path 1.7 +0 -8 src/lib/libc/arm/Symbol.map From owner-cvs-src@FreeBSD.ORG Thu Oct 18 21:52:17 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 301C816A418; Thu, 18 Oct 2007 21:52:17 +0000 (UTC) (envelope-from darrenr@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 1C3E113C48E; Thu, 18 Oct 2007 21:52:16 +0000 (UTC) (envelope-from darrenr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9ILqGoD016547; Thu, 18 Oct 2007 21:52:16 GMT (envelope-from darrenr@repoman.freebsd.org) Received: (from darrenr@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9ILqGi4016543; Thu, 18 Oct 2007 21:52:16 GMT (envelope-from darrenr) Message-Id: <200710182152.l9ILqGi4016543@repoman.freebsd.org> From: Darren Reed Date: Thu, 18 Oct 2007 21:52:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/contrib/ipfilter Makefile ip_fil.c md5.h radix.c radix_ipf.h src/contrib/ipfilter/ipsend iptests.c sock.c src/contrib/ipfilter/l4check l4check.c src/contrib/ipfilter/lib ipft_tx.c printnat.c printpacket.c printstate.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 21:52:17 -0000 darrenr 2007-10-18 21:52:14 UTC FreeBSD src repository Modified files: contrib/ipfilter Makefile ip_fil.c md5.h radix.c radix_ipf.h contrib/ipfilter/ipsend iptests.c sock.c contrib/ipfilter/l4check l4check.c contrib/ipfilter/lib ipft_tx.c printnat.c printpacket.c printstate.c contrib/ipfilter/man ippool.5 contrib/ipfilter/tools ipf_y.y ipfstat.c ipmon.c ipnat.c ipnat_y.y lexer.c sys/contrib/ipfilter/netinet fil.c ip_auth.c ip_compat.h ip_fil.h ip_fil_freebsd.c ip_frag.c ip_htable.c ip_log.c ip_nat.c ip_nat.h ip_proxy.c ip_state.c ip_state.h ip_sync.c ipl.h mlfk_ipl.c Log: Pullup IPFilter 4.1.28 from the vendor branch into HEAD. MFC after: 7 days Revision Changes Path 1.8 +8 -11 src/contrib/ipfilter/Makefile 1.6 +6 -3 src/contrib/ipfilter/ip_fil.c 1.14 +6 -2 src/contrib/ipfilter/ipsend/iptests.c 1.19 +6 -2 src/contrib/ipfilter/ipsend/sock.c 1.3 +30 -13 src/contrib/ipfilter/l4check/l4check.c 1.7 +23 -12 src/contrib/ipfilter/lib/ipft_tx.c 1.5 +9 -4 src/contrib/ipfilter/lib/printnat.c 1.5 +2 -2 src/contrib/ipfilter/lib/printpacket.c 1.6 +2 -2 src/contrib/ipfilter/lib/printstate.c 1.3 +1 -1 src/contrib/ipfilter/man/ippool.5 1.3 +1 -1 src/contrib/ipfilter/md5.h 1.5 +6 -0 src/contrib/ipfilter/radix.c 1.5 +2 -2 src/contrib/ipfilter/radix_ipf.h 1.7 +24 -0 src/contrib/ipfilter/tools/ipf_y.y 1.7 +3 -3 src/contrib/ipfilter/tools/ipfstat.c 1.8 +32 -3 src/contrib/ipfilter/tools/ipmon.c 1.6 +62 -3 src/contrib/ipfilter/tools/ipnat.c 1.6 +1 -0 src/contrib/ipfilter/tools/ipnat_y.y 1.5 +39 -16 src/contrib/ipfilter/tools/lexer.c 1.53 +162 -123 src/sys/contrib/ipfilter/netinet/fil.c 1.45 +17 -17 src/sys/contrib/ipfilter/netinet/ip_auth.c 1.34 +126 -56 src/sys/contrib/ipfilter/netinet/ip_compat.h 1.36 +31 -20 src/sys/contrib/ipfilter/netinet/ip_fil.h 1.7 +135 -148 src/sys/contrib/ipfilter/netinet/ip_fil_freebsd.c 1.33 +7 -7 src/sys/contrib/ipfilter/netinet/ip_frag.c 1.5 +39 -51 src/sys/contrib/ipfilter/netinet/ip_htable.c 1.34 +20 -14 src/sys/contrib/ipfilter/netinet/ip_log.c 1.43 +187 -67 src/sys/contrib/ipfilter/netinet/ip_nat.c 1.27 +5 -1 src/sys/contrib/ipfilter/netinet/ip_nat.h 1.30 +6 -4 src/sys/contrib/ipfilter/netinet/ip_proxy.c 1.40 +108 -64 src/sys/contrib/ipfilter/netinet/ip_state.c 1.20 +3 -5 src/sys/contrib/ipfilter/netinet/ip_state.h 1.6 +5 -5 src/sys/contrib/ipfilter/netinet/ip_sync.c 1.27 +3 -3 src/sys/contrib/ipfilter/netinet/ipl.h 1.20 +9 -0 src/sys/contrib/ipfilter/netinet/mlfk_ipl.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 21:52:31 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A875D16A494; Thu, 18 Oct 2007 21:52:31 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 803C513C4AC; Thu, 18 Oct 2007 21:52:31 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9ILqVUo016580; Thu, 18 Oct 2007 21:52:31 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9ILqVnV016579; Thu, 18 Oct 2007 21:52:31 GMT (envelope-from thompsa) Message-Id: <200710182152.l9ILqVnV016579@repoman.freebsd.org> From: Andrew Thompson Date: Thu, 18 Oct 2007 21:52:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net ethernet.h if_ethersubr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 21:52:31 -0000 thompsa 2007-10-18 21:52:31 UTC FreeBSD src repository Modified files: sys/net ethernet.h if_ethersubr.c Log: Use a uint16_t type for the vlan tag rather an int. Revision Changes Path 1.34 +1 -1 src/sys/net/ethernet.h 1.238 +1 -1 src/sys/net/if_ethersubr.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 22:07:15 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 49DCB16A46B; Thu, 18 Oct 2007 22:07:15 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from smtpoutm.mac.com (smtpoutm.mac.com [17.148.16.75]) by mx1.freebsd.org (Postfix) with ESMTP id 2801F13C46A; Thu, 18 Oct 2007 22:07:14 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from mac.com (asmtp003-s [10.150.69.66]) by smtpoutm.mac.com (Xserve/smtpout012/MantshX 4.0) with ESMTP id l9ILahV3021774; Thu, 18 Oct 2007 14:36:43 -0700 (PDT) Received: from [172.24.104.90] (natint3.juniper.net [66.129.224.36]) (authenticated bits=0) by mac.com (Xserve/asmtp003/MantshX 4.0) with ESMTP id l9ILafkV002555 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Thu, 18 Oct 2007 14:36:42 -0700 (PDT) In-Reply-To: <200710181128.l9IBScp8044011@repoman.freebsd.org> References: <200710181128.l9IBScp8044011@repoman.freebsd.org> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Thu, 18 Oct 2007 14:36:40 -0700 To: Yar Tikhiy X-Mailer: Apple Mail (2.752.2) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/ia64 Symbol.map X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 22:07:15 -0000 On Oct 18, 2007, at 4:28 AM, Yar Tikhiy wrote: > yar 2007-10-18 11:28:38 UTC > > FreeBSD src repository > > Modified files: > lib/libc/ia64 Symbol.map > Log: > The fork symbols aren't MD, they already live in sys/. > > Found by: version_gen.awk > Tested by: md5(1) (libc.so hasn't changed at all) Thanks! -- Marcel Moolenaar xcllnt@mac.com From owner-cvs-src@FreeBSD.ORG Thu Oct 18 22:20:08 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6F94716A417; Thu, 18 Oct 2007 22:20:08 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A4A8B13C455; Thu, 18 Oct 2007 22:20:07 +0000 (UTC) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IMK701019080; Thu, 18 Oct 2007 22:20:07 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IMK7RN019076; Thu, 18 Oct 2007 22:20:07 GMT (envelope-from simon) Message-Id: <200710182220.l9IMK7RN019076@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Thu, 18 Oct 2007 22:20:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/crypto/openssl/ssl d1_both.c dtls1.h ssl.h ssl_err.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 22:20:08 -0000 simon 2007-10-18 22:20:04 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) crypto/openssl/ssl d1_both.c dtls1.h ssl.h ssl_err.c Log: MFC: Import DTLS security fix from upstream OpenSSL_0_9_8-stable branch. Security: CVE-2007-4995 Security: http://www.openssl.org/news/secadv_20071012.txt Approved by: re (kensmith) Revision Changes Path 1.1.1.1.2.1 +533 -605 src/crypto/openssl/ssl/d1_both.c 1.1.1.1.2.1 +3 -4 src/crypto/openssl/ssl/dtls1.h 1.1.1.16.2.1 +1 -0 src/crypto/openssl/ssl/ssl.h 1.1.1.11.2.1 +1 -0 src/crypto/openssl/ssl/ssl_err.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 22:47:40 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2366916A469; Thu, 18 Oct 2007 22:47:40 +0000 (UTC) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id EB50613C46B; Thu, 18 Oct 2007 22:47:39 +0000 (UTC) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IMldrK020675; Thu, 18 Oct 2007 22:47:39 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IMldPh020674; Thu, 18 Oct 2007 22:47:39 GMT (envelope-from peter) Message-Id: <200710182247.l9IMldPh020674@repoman.freebsd.org> From: Peter Wemm Date: Thu, 18 Oct 2007 22:47:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/vm vm_mmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 22:47:40 -0000 peter 2007-10-18 22:47:39 UTC FreeBSD src repository Modified files: sys/vm vm_mmap.c Log: Fix cosmetic bug in stale copy of msync_args. 'len' is size_t, not int. Revision Changes Path 1.214 +1 -1 src/sys/vm/vm_mmap.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 23:02:18 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DEDEE16A46B; Thu, 18 Oct 2007 23:02:18 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id AABF013C481; Thu, 18 Oct 2007 23:02:18 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9IN2IO2021638; Thu, 18 Oct 2007 23:02:18 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9IN2IGU021637; Thu, 18 Oct 2007 23:02:18 GMT (envelope-from alc) Message-Id: <200710182302.l9IN2IGU021637@repoman.freebsd.org> From: Alan Cox Date: Thu, 18 Oct 2007 23:02:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/vm vm_object.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 23:02:19 -0000 alc 2007-10-18 23:02:18 UTC FreeBSD src repository Modified files: sys/vm vm_object.c Log: The previous revision, updating vm_object_page_remove() for the new page cache, did not account for the case where the vm object has nothing but cached pages. Reported by: kris, tegge Reviewed by: tegge MFC after: 3 days Revision Changes Path 1.386 +2 -1 src/sys/vm/vm_object.c From owner-cvs-src@FreeBSD.ORG Thu Oct 18 23:35:09 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B4BD416A419; Thu, 18 Oct 2007 23:35:09 +0000 (UTC) (envelope-from bushman@freebsd.org) Received: from mail.r61.net (mail.r61.net [195.208.245.249]) by mx1.freebsd.org (Postfix) with ESMTP id 415E513C44B; Thu, 18 Oct 2007 23:35:07 +0000 (UTC) (envelope-from bushman@freebsd.org) Received: from [127.0.0.1] ([195.161.235.42]) (authenticated bits=0) by mail.r61.net (8.14.1/8.14.1) with ESMTP id l9INYsDK057136; Fri, 19 Oct 2007 03:35:03 +0400 (MSD) (envelope-from bushman@freebsd.org) Message-ID: <4717ED91.9040401@freebsd.org> Date: Fri, 19 Oct 2007 03:34:41 +0400 From: Michael Bushkov User-Agent: Thunderbird 2.0.0.5 (Windows/20070716) MIME-Version: 1.0 To: John Baldwin References: <200710172320.l9HNKnGl063500@repoman.freebsd.org> <200710181155.19806.jhb@freebsd.org> In-Reply-To: <200710181155.19806.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Tom McLaughlin Subject: Re: cvs commit: src/lib/libc/net nscache.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 23:35:09 -0000 Actually, this is not the only place, where libc refers to the now-nscd using its old "cached" name, so correcting this macro only won't fix the problem. Actually, most of the API in lib/libc/net/nscache.c and lib/libc/net/cachedcli.c should be changed to use the new name. I'll handle this. John Baldwin wrote: > On Wednesday 17 October 2007 07:20:49 pm Tom McLaughlin wrote: >> tmclaugh 2007-10-17 23:20:49 UTC >> >> FreeBSD src repository (ports committer) >> >> Modified files: >> lib/libc/net nscache.c >> Log: >> - Correctly define CACHED_SOCKET_PATH as /var/run/nscd after cached to >> nscd renaming. >> >> Approved by: mux >> >> Revision Changes Path >> 1.2 +1 -1 src/lib/libc/net/nscache.c > > Should the macro be called NSCD_SOCKET_PATH perhaps? > -- With best regards, Michael Bushkov Southern Federal University From owner-cvs-src@FreeBSD.ORG Thu Oct 18 23:52:46 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7536F16A420; Thu, 18 Oct 2007 23:52:46 +0000 (UTC) (envelope-from bushman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 4C21613C4A7; Thu, 18 Oct 2007 23:52:46 +0000 (UTC) (envelope-from bushman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9INqkRZ025352; Thu, 18 Oct 2007 23:52:46 GMT (envelope-from bushman@repoman.freebsd.org) Received: (from bushman@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9INqk0a025351; Thu, 18 Oct 2007 23:52:46 GMT (envelope-from bushman) Message-Id: <200710182352.l9INqk0a025351@repoman.freebsd.org> From: Michael Bushkov Date: Thu, 18 Oct 2007 23:52:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src ObsoleteFiles.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 23:52:46 -0000 bushman 2007-10-18 23:52:45 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) . ObsoleteFiles.inc Log: MFC: Remove default (compressed) manpages. Approved by: re (kensmith), brooks(mentor) Revision Changes Path 1.112.2.1 +2 -2 src/ObsoleteFiles.inc From owner-cvs-src@FreeBSD.ORG Thu Oct 18 23:59:12 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F229016A418; Thu, 18 Oct 2007 23:59:12 +0000 (UTC) (envelope-from bushman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C97FB13C448; Thu, 18 Oct 2007 23:59:12 +0000 (UTC) (envelope-from bushman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9INxCrB025589; Thu, 18 Oct 2007 23:59:12 GMT (envelope-from bushman@repoman.freebsd.org) Received: (from bushman@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9INxCma025588; Thu, 18 Oct 2007 23:59:12 GMT (envelope-from bushman) Message-Id: <200710182359.l9INxCma025588@repoman.freebsd.org> From: Michael Bushkov Date: Thu, 18 Oct 2007 23:59:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/lib/libc/net nscache.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 23:59:13 -0000 bushman 2007-10-18 23:59:12 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libc/net nscache.c Log: MFC: Correctly define CACHED_SOCKET_PATH as /var/run/nscd after cached to nscd renaming. Approved by: re (kensmith), brooks (mentor) Revision Changes Path 1.1.2.1 +1 -1 src/lib/libc/net/nscache.c From owner-cvs-src@FreeBSD.ORG Fri Oct 19 00:09:55 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7DF1B16A418; Fri, 19 Oct 2007 00:09:55 +0000 (UTC) (envelope-from bushman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E979413C44B; Fri, 19 Oct 2007 00:09:54 +0000 (UTC) (envelope-from bushman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9J09s8g027297; Fri, 19 Oct 2007 00:09:54 GMT (envelope-from bushman@repoman.freebsd.org) Received: (from bushman@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9J09stE027296; Fri, 19 Oct 2007 00:09:54 GMT (envelope-from bushman) Message-Id: <200710190009.l9J09stE027296@repoman.freebsd.org> From: Michael Bushkov Date: Fri, 19 Oct 2007 00:09:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/etc Makefile cached.conf nscd.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 00:09:55 -0000 bushman 2007-10-19 00:09:54 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) etc Makefile Added files: (Branch: RELENG_7) etc nscd.conf Removed files: (Branch: RELENG_7) etc cached.conf Log: MFC: Renaming etc/cached.conf to etc/nscd.conf. etc/Makefile changed accordingly. Approved by: re (kensmith), brooks (mentor) Revision Changes Path 1.360.2.1 +1 -1 src/etc/Makefile 1.1.2.1 +0 -12 src/etc/cached.conf (dead) 1.2.2.1 +12 -0 src/etc/nscd.conf (new) From owner-cvs-src@FreeBSD.ORG Fri Oct 19 00:16:32 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1827416A419; Fri, 19 Oct 2007 00:16:32 +0000 (UTC) (envelope-from bushman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E27C713C48A; Fri, 19 Oct 2007 00:16:31 +0000 (UTC) (envelope-from bushman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9J0GUfA027721; Fri, 19 Oct 2007 00:16:30 GMT (envelope-from bushman@repoman.freebsd.org) Received: (from bushman@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9J0GUpo027720; Fri, 19 Oct 2007 00:16:30 GMT (envelope-from bushman) Message-Id: <200710190016.l9J0GUpo027720@repoman.freebsd.org> From: Michael Bushkov Date: Fri, 19 Oct 2007 00:16:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man5 nsswitch.conf.5 src.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 00:16:32 -0000 bushman 2007-10-19 00:16:29 UTC FreeBSD src repository Modified files: share/man/man5 nsswitch.conf.5 src.conf.5 Log: Small fix in man pages after cached -> nscd renaming. Approved by: brooks (mentor) Revision Changes Path 1.18 +5 -5 src/share/man/man5/nsswitch.conf.5 1.19 +1 -1 src/share/man/man5/src.conf.5 From owner-cvs-src@FreeBSD.ORG Fri Oct 19 00:18:19 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8186416A417; Fri, 19 Oct 2007 00:18:19 +0000 (UTC) (envelope-from bushman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5860113C455; Fri, 19 Oct 2007 00:18:19 +0000 (UTC) (envelope-from bushman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9J0IJds027804; Fri, 19 Oct 2007 00:18:19 GMT (envelope-from bushman@repoman.freebsd.org) Received: (from bushman@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9J0IJd7027803; Fri, 19 Oct 2007 00:18:19 GMT (envelope-from bushman) Message-Id: <200710190018.l9J0IJd7027803@repoman.freebsd.org> From: Michael Bushkov Date: Fri, 19 Oct 2007 00:18:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/share/man/man5 nsswitch.conf.5 src.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 00:18:19 -0000 bushman 2007-10-19 00:18:19 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/man/man5 nsswitch.conf.5 src.conf.5 Log: Fast MFC: Small fix in man pages after cached -> nscd renaming. Approved by: re (kensmith), brooks (mentor) Revision Changes Path 1.17.2.1 +5 -5 src/share/man/man5/nsswitch.conf.5 1.18.2.1 +1 -1 src/share/man/man5/src.conf.5 From owner-cvs-src@FreeBSD.ORG Fri Oct 19 03:04:03 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 794E316A417; Fri, 19 Oct 2007 03:04:03 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 65A5D13C448; Fri, 19 Oct 2007 03:04:03 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9J343LT049360; Fri, 19 Oct 2007 03:04:03 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9J343Ag049359; Fri, 19 Oct 2007 03:04:03 GMT (envelope-from mlaier) Message-Id: <200710190304.l9J343Ag049359@repoman.freebsd.org> From: Max Laier Date: Fri, 19 Oct 2007 03:04:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/contrib/libpcap CHANGES CREDITS FILES INSTALL INSTALL.txt Makefile.in README.dag TODO VERSION bpf_image.c config.h.in configure configure.in fad-getad.c fad-win32.c gencode.c gencode.h grammar.y inet.c nametoaddr.c optimize.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 03:04:03 -0000 mlaier 2007-10-19 03:04:02 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) contrib/libpcap CHANGES CREDITS FILES INSTALL.txt Makefile.in README.dag TODO VERSION bpf_image.c config.h.in configure configure.in fad-getad.c fad-win32.c gencode.c gencode.h grammar.y inet.c nametoaddr.c optimize.c pcap-bpf.c pcap-bpf.h pcap-dag.c pcap-dlpi.c pcap-int.h pcap-linux.c pcap-win32.c pcap.3 pcap.c pcap.h savefile.c scanner.l contrib/tcpdump CHANGES CREDITS FILES INSTALL Makefile.in README VERSION addrtoname.c bootp.h config.h.in configure configure.in dccp.h ieee802_11.h ieee802_11_radio.h interface.h ip.h llc.h nameser.h netdissect.h ospf.h parsenfsfh.c print-802_11.c print-atm.c print-bfd.c print-bgp.c print-bootp.c print-chdlc.c print-dccp.c print-dhcp6.c print-domain.c print-ether.c print-fddi.c print-fr.c print-icmp.c print-ip.c print-ip6.c print-ipfc.c print-isoclns.c print-juniper.c print-l2tp.c print-lane.c print-ldp.c print-llc.c print-lmp.c print-lspping.c print-nfs.c print-null.c print-ospf.c print-pflog.c print-pim.c print-ppp.c print-pptp.c print-rsvp.c print-rx.c print-sctp.c print-sll.c print-smb.c print-tcp.c print-tftp.c print-token.c print-udp.c smbutil.c tcp.h tcpdump-stdinc.h tcpdump.1 tcpdump.c udp.h util.c contrib/tcpdump/tests print-capX.out print-capXX.out contrib/pf/pflogd pflogd.c lib/libpcap Makefile config.h usr.sbin/tcpdump/tcpdump Makefile config.h usr.sbin/wpa l2_packet.c Added files: (Branch: RELENG_7) contrib/tcpdump af.c af.h print-olsr.c tftp.h Removed files: (Branch: RELENG_7) contrib/libpcap INSTALL pf.h contrib/libpcap/lbl gnuc.h contrib/tcpdump pf.h Log: MFC: Import of tcpdump 3.9.8 and libpcap 0.9.8 Approved by: re (kensmith) Revision Changes Path 1.1.1.10.2.1 +85 -1 src/contrib/libpcap/CHANGES 1.1.1.7.2.1 +7 -0 src/contrib/libpcap/CREDITS 1.1.1.8.10.1 +0 -1 src/contrib/libpcap/FILES 1.1.1.5.24.1 +0 -342 src/contrib/libpcap/INSTALL (dead) 1.1.1.4.10.1 +1 -2 src/contrib/libpcap/INSTALL.txt 1.1.1.8.10.1 +8 -15 src/contrib/libpcap/Makefile.in 1.1.1.2.2.1 +22 -1 src/contrib/libpcap/README.dag 1.1.1.2.24.1 +0 -7 src/contrib/libpcap/TODO 1.1.1.11.2.1 +1 -1 src/contrib/libpcap/VERSION 1.1.1.6.10.1 +2 -2 src/contrib/libpcap/bpf_image.c 1.1.1.6.2.1 +12 -0 src/contrib/libpcap/config.h.in 1.1.1.10.2.1 +3820 -2811 src/contrib/libpcap/configure 1.1.1.10.2.1 +37 -3 src/contrib/libpcap/configure.in 1.1.1.3.10.1 +6 -2 src/contrib/libpcap/fad-getad.c 1.1.1.3.2.1 +18 -16 src/contrib/libpcap/fad-win32.c 1.16.2.1 +800 -363 src/contrib/libpcap/gencode.c 1.9.2.1 +13 -7 src/contrib/libpcap/gencode.h 1.11.2.1 +64 -26 src/contrib/libpcap/grammar.y 1.1.1.10.10.1 +97 -31 src/contrib/libpcap/inet.c 1.1.1.2.28.1 +0 -43 src/contrib/libpcap/lbl/gnuc.h (dead) 1.12.10.1 +4 -4 src/contrib/libpcap/nametoaddr.c 1.1.1.7.10.1 +27 -13 src/contrib/libpcap/optimize.c 1.3.2.1 +12 -1 src/contrib/libpcap/pcap-bpf.c 1.1.1.4.2.1 +143 -6 src/contrib/libpcap/pcap-bpf.h 1.1.1.4.2.1 +243 -122 src/contrib/libpcap/pcap-dag.c 1.1.1.10.2.1 +9 -1 src/contrib/libpcap/pcap-dlpi.c 1.12.2.1 +30 -7 src/contrib/libpcap/pcap-int.h 1.1.1.9.2.1 +90 -27 src/contrib/libpcap/pcap-linux.c 1.1.1.4.2.1 +38 -10 src/contrib/libpcap/pcap-win32.c 1.15.2.1 +14 -8 src/contrib/libpcap/pcap.3 1.1.1.11.2.1 +30 -20 src/contrib/libpcap/pcap.c 1.12.2.1 +17 -8 src/contrib/libpcap/pcap.h 1.1.1.2.10.1 +0 -77 src/contrib/libpcap/pf.h (dead) 1.1.1.10.2.1 +199 -2 src/contrib/libpcap/savefile.c 1.13.2.1 +11 -7 src/contrib/libpcap/scanner.l 1.12.2.1 +3 -0 src/contrib/pf/pflogd/pflogd.c 1.1.1.11.2.1 +89 -1 src/contrib/tcpdump/CHANGES 1.1.1.8.2.1 +12 -0 src/contrib/tcpdump/CREDITS 1.1.1.10.2.1 +4 -1 src/contrib/tcpdump/FILES 1.1.1.10.2.1 +16 -15 src/contrib/tcpdump/INSTALL 1.1.1.10.2.1 +7 -16 src/contrib/tcpdump/Makefile.in 1.1.1.10.10.1 +4 -3 src/contrib/tcpdump/README 1.1.1.13.2.1 +1 -1 src/contrib/tcpdump/VERSION 1.15.2.1 +6 -2 src/contrib/tcpdump/addrtoname.c 1.1.1.1.2.1 +63 -0 src/contrib/tcpdump/af.c (new) 1.1.1.1.2.1 +57 -0 src/contrib/tcpdump/af.h (new) 1.1.1.5.18.1 +11 -1 src/contrib/tcpdump/bootp.h 1.1.1.7.10.1 +8 -5 src/contrib/tcpdump/config.h.in 1.1.1.11.2.1 +5992 -4664 src/contrib/tcpdump/configure 1.1.1.11.2.1 +8 -2 src/contrib/tcpdump/configure.in 1.1.1.1.4.1 +5 -3 src/contrib/tcpdump/dccp.h 1.2.2.1 +44 -12 src/contrib/tcpdump/ieee802_11.h 1.2.2.1 +9 -5 src/contrib/tcpdump/ieee802_11_radio.h 1.12.2.1 +8 -3 src/contrib/tcpdump/interface.h 1.1.1.3.10.1 +2 -1 src/contrib/tcpdump/ip.h 1.1.1.9.2.1 +4 -2 src/contrib/tcpdump/llc.h 1.1.1.3.18.1 +22 -2 src/contrib/tcpdump/nameser.h 1.1.1.2.2.1 +2 -2 src/contrib/tcpdump/netdissect.h 1.1.1.6.2.1 +2 -1 src/contrib/tcpdump/ospf.h 1.9.10.1 +28 -2 src/contrib/tcpdump/parsenfsfh.c 1.1.1.2.10.1 +0 -77 src/contrib/tcpdump/pf.h (dead) 1.2.2.1 +188 -110 src/contrib/tcpdump/print-802_11.c 1.12.2.1 +22 -17 src/contrib/tcpdump/print-atm.c 1.1.1.3.10.1 +2 -2 src/contrib/tcpdump/print-bfd.c 1.1.1.9.2.1 +50 -49 src/contrib/tcpdump/print-bgp.c 1.11.10.1 +286 -119 src/contrib/tcpdump/print-bootp.c 1.1.1.7.2.1 +27 -26 src/contrib/tcpdump/print-chdlc.c 1.1.1.1.4.1 +35 -28 src/contrib/tcpdump/print-dccp.c 1.1.1.6.10.1 +78 -44 src/contrib/tcpdump/print-dhcp6.c 1.12.10.1 +50 -16 src/contrib/tcpdump/print-domain.c 1.17.2.1 +11 -9 src/contrib/tcpdump/print-ether.c 1.11.2.1 +1 -2 src/contrib/tcpdump/print-fddi.c 1.7.2.1 +25 -1 src/contrib/tcpdump/print-fr.c 1.11.10.1 +86 -30 src/contrib/tcpdump/print-icmp.c 1.14.2.1 +40 -31 src/contrib/tcpdump/print-ip.c 1.8.2.1 +3 -3 src/contrib/tcpdump/print-ip6.c 1.1.1.3.2.1 +1 -3 src/contrib/tcpdump/print-ipfc.c 1.16.2.1 +35 -17 src/contrib/tcpdump/print-isoclns.c 1.1.1.3.2.1 +35 -11 src/contrib/tcpdump/print-juniper.c 1.1.1.8.10.1 +1 -9 src/contrib/tcpdump/print-l2tp.c 1.1.1.6.2.1 +1 -2 src/contrib/tcpdump/print-lane.c 1.1.1.4.2.1 +15 -16 src/contrib/tcpdump/print-ldp.c 1.12.2.1 +34 -15 src/contrib/tcpdump/print-llc.c 1.1.1.2.10.1 +10 -13 src/contrib/tcpdump/print-lmp.c 1.1.1.2.10.1 +10 -3 src/contrib/tcpdump/print-lspping.c 1.12.10.1 +82 -8 src/contrib/tcpdump/print-nfs.c 1.12.2.1 +9 -36 src/contrib/tcpdump/print-null.c 1.1.1.1.2.1 +397 -0 src/contrib/tcpdump/print-olsr.c (new) 1.1.1.10.2.1 +4 -8 src/contrib/tcpdump/print-ospf.c 1.1.1.3.2.1 +24 -2 src/contrib/tcpdump/print-pflog.c 1.9.2.1 +40 -17 src/contrib/tcpdump/print-pim.c 1.16.10.1 +74 -7 src/contrib/tcpdump/print-ppp.c 1.1.1.3.10.1 +1 -9 src/contrib/tcpdump/print-pptp.c 1.1.1.5.2.1 +219 -12 src/contrib/tcpdump/print-rsvp.c 1.1.1.7.10.1 +17 -12 src/contrib/tcpdump/print-rx.c 1.1.1.6.2.1 +3 -2 src/contrib/tcpdump/print-sctp.c 1.1.1.7.2.1 +4 -2 src/contrib/tcpdump/print-sll.c 1.1.1.9.10.1 +3 -3 src/contrib/tcpdump/print-smb.c 1.1.1.11.2.1 +2 -2 src/contrib/tcpdump/print-tcp.c 1.1.1.6.10.1 +12 -6 src/contrib/tcpdump/print-tftp.c 1.8.2.1 +1 -2 src/contrib/tcpdump/print-token.c 1.9.10.1 +3 -1 src/contrib/tcpdump/print-udp.c 1.1.1.7.10.1 +10 -1 src/contrib/tcpdump/smbutil.c 1.1.1.4.10.1 +2 -2 src/contrib/tcpdump/tcp.h 1.4.2.1 +9 -2 src/contrib/tcpdump/tcpdump-stdinc.h 1.17.2.1 +31 -11 src/contrib/tcpdump/tcpdump.1 1.11.2.1 +5 -2 src/contrib/tcpdump/tcpdump.c 1.1.1.1.4.1 +10 -10 src/contrib/tcpdump/tests/print-capX.out 1.1.1.1.4.1 +10 -10 src/contrib/tcpdump/tests/print-capXX.out 1.1.1.1.2.1 +82 -0 src/contrib/tcpdump/tftp.h (new) 1.1.1.3.10.1 +3 -2 src/contrib/tcpdump/udp.h 1.1.1.10.10.1 +5 -3 src/contrib/tcpdump/util.c 1.39.2.1 +4 -1 src/lib/libpcap/Makefile 1.5.10.1 +24 -2 src/lib/libpcap/config.h 1.45.2.1 +33 -26 src/usr.sbin/tcpdump/tcpdump/Makefile 1.7.10.1 +43 -19 src/usr.sbin/tcpdump/tcpdump/config.h 1.4.2.1 +7 -6 src/usr.sbin/wpa/l2_packet.c From owner-cvs-src@FreeBSD.ORG Fri Oct 19 03:50:49 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4A0316A41B; Fri, 19 Oct 2007 03:50:49 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9FF7713C458; Fri, 19 Oct 2007 03:50:49 +0000 (UTC) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9J3onUG051727; Fri, 19 Oct 2007 03:50:49 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9J3onHr051726; Fri, 19 Oct 2007 03:50:49 GMT (envelope-from kientzle) Message-Id: <200710190350.l9J3onHr051726@repoman.freebsd.org> From: Tim Kientzle Date: Fri, 19 Oct 2007 03:50:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/lib/libarchive archive_write_set_format_cpio.c archive_write_set_format_cpio_newc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 03:50:49 -0000 kientzle 2007-10-19 03:50:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libarchive archive_write_set_format_cpio.c archive_write_set_format_cpio_newc.c Log: MFC: archive_write_set_format_cpio.c 1.12 MFC: archive_write_set_format_cpio_newc.c 1.2 Non-regular files should have zero-length bodies. libarchive flags this to clients by updating the entry description when it writes the header. Revision Changes Path 1.5.2.4 +6 -1 src/lib/libarchive/archive_write_set_format_cpio.c 1.1.2.2 +6 -1 src/lib/libarchive/archive_write_set_format_cpio_newc.c From owner-cvs-src@FreeBSD.ORG Fri Oct 19 05:29:18 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B077A16A41B; Fri, 19 Oct 2007 05:29:18 +0000 (UTC) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8F8F113C448; Fri, 19 Oct 2007 05:29:18 +0000 (UTC) (envelope-from rodrigc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9J5TIWl068007; Fri, 19 Oct 2007 05:29:18 GMT (envelope-from rodrigc@repoman.freebsd.org) Received: (from rodrigc@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9J5TINB068006; Fri, 19 Oct 2007 05:29:18 GMT (envelope-from rodrigc) Message-Id: <200710190529.l9J5TINB068006@repoman.freebsd.org> From: Craig Rodrigues Date: Fri, 19 Oct 2007 05:29:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/mount mount.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 05:29:18 -0000 rodrigc 2007-10-19 05:29:18 UTC FreeBSD src repository Modified files: sbin/mount mount.8 Log: Remove stale reference to mount_std. Revision Changes Path 1.83 +0 -1 src/sbin/mount/mount.8 From owner-cvs-src@FreeBSD.ORG Fri Oct 19 05:48:48 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9FB6216A421; Fri, 19 Oct 2007 05:48:48 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7FD1813C45A; Fri, 19 Oct 2007 05:48:48 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9J5mmce069204; Fri, 19 Oct 2007 05:48:48 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9J5mlT4069203; Fri, 19 Oct 2007 05:48:47 GMT (envelope-from alc) Message-Id: <200710190548.l9J5mlT4069203@repoman.freebsd.org> From: Alan Cox Date: Fri, 19 Oct 2007 05:48:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/vm vm_object.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 05:48:48 -0000 alc 2007-10-19 05:48:46 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/vm vm_object.c Log: MFC revision 1.386 The previous revision, updating vm_object_page_remove() for the new page cache, did not account for the case where the vm object has nothing but cached pages. Approved by: re (kensmith) Requested by: kensmith Revision Changes Path 1.385.2.1 +2 -1 src/sys/vm/vm_object.c From owner-cvs-src@FreeBSD.ORG Fri Oct 19 06:23:40 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A3B4A16A41B; Fri, 19 Oct 2007 06:23:40 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8475913C468; Fri, 19 Oct 2007 06:23:40 +0000 (UTC) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9J6Ne2Q074026; Fri, 19 Oct 2007 06:23:40 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9J6NeM0074025; Fri, 19 Oct 2007 06:23:40 GMT (envelope-from davidxu) Message-Id: <200710190623.l9J6NeM0074025@repoman.freebsd.org> From: David Xu Date: Fri, 19 Oct 2007 06:23:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libc/stdlib atoi.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 06:23:40 -0000 davidxu 2007-10-19 06:23:39 UTC FreeBSD src repository Modified files: lib/libc/stdlib atoi.3 Log: Remove out of date notes, the atoi code is thread-safe and async-cancel safe. Discussed with: desichen Revision Changes Path 1.14 +0 -4 src/lib/libc/stdlib/atoi.3 From owner-cvs-src@FreeBSD.ORG Fri Oct 19 07:18:57 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2261D16A41A; Fri, 19 Oct 2007 07:18:57 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 03E0B13C447; Fri, 19 Oct 2007 07:18:57 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9J7Iufc079778; Fri, 19 Oct 2007 07:18:56 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9J7Iug7079777; Fri, 19 Oct 2007 07:18:56 GMT (envelope-from mtm) Message-Id: <200710190718.l9J7Iug7079777@repoman.freebsd.org> From: Mike Makonnen Date: Fri, 19 Oct 2007 07:18:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/adduser rmuser.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 07:18:57 -0000 mtm 2007-10-19 07:18:56 UTC FreeBSD src repository Modified files: usr.sbin/adduser rmuser.sh Log: The POP daemon's temporary mail file has a leading dot ('.'). This was lost in the shell script rewrite of the rmuser command. Submitted by: Ian Smith Revision Changes Path 1.10 +3 -3 src/usr.sbin/adduser/rmuser.sh From owner-cvs-src@FreeBSD.ORG Fri Oct 19 07:46:34 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DBB1016A46E; Fri, 19 Oct 2007 07:46:34 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B727413C4A7; Fri, 19 Oct 2007 07:46:34 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9J7kYth081252; Fri, 19 Oct 2007 07:46:34 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9J7kYI7081251; Fri, 19 Oct 2007 07:46:34 GMT (envelope-from mtm) Message-Id: <200710190746.l9J7kYI7081251@repoman.freebsd.org> From: Mike Makonnen Date: Fri, 19 Oct 2007 07:46:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/usr.sbin/adduser rmuser.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 07:46:35 -0000 mtm 2007-10-19 07:46:34 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.sbin/adduser rmuser.sh Log: MFC: rev. 1.10 The POP daemon's temporary mail file has a leading dot ('.'). This was lost in the shell script rewrite of the rmuser command. Approved by: re (kensmith) Revision Changes Path 1.9.10.1 +3 -3 src/usr.sbin/adduser/rmuser.sh From owner-cvs-src@FreeBSD.ORG Fri Oct 19 07:53:15 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 57A0716A41B; Fri, 19 Oct 2007 07:53:15 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3A5D213C461; Fri, 19 Oct 2007 07:53:15 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9J7rFBt081671; Fri, 19 Oct 2007 07:53:15 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9J7rFJo081670; Fri, 19 Oct 2007 07:53:15 GMT (envelope-from mtm) Message-Id: <200710190753.l9J7rFJo081670@repoman.freebsd.org> From: Mike Makonnen Date: Fri, 19 Oct 2007 07:53:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/adduser rmuser.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 07:53:15 -0000 mtm 2007-10-19 07:53:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/adduser rmuser.sh Log: MFC: rev. 1.10 The POP daemon's temporary mail file has a leading dot ('.'). This was lost in the shell script rewrite of the rmuser command. Revision Changes Path 1.9.2.1 +3 -3 src/usr.sbin/adduser/rmuser.sh From owner-cvs-src@FreeBSD.ORG Fri Oct 19 07:55:53 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9590B16A418; Fri, 19 Oct 2007 07:55:53 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 765DE13C455; Fri, 19 Oct 2007 07:55:53 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9J7tr96081823; Fri, 19 Oct 2007 07:55:53 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9J7tq0m081822; Fri, 19 Oct 2007 07:55:52 GMT (envelope-from mtm) Message-Id: <200710190755.l9J7tq0m081822@repoman.freebsd.org> From: Mike Makonnen Date: Fri, 19 Oct 2007 07:55:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/usr.sbin/adduser rmuser.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 07:55:53 -0000 mtm 2007-10-19 07:55:52 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) usr.sbin/adduser rmuser.sh Log: MFC: rev. 1.10 The POP daemon's temporary mail file has a leading dot ('.'). This was lost in the shell script rewrite of the rmuser command. Revision Changes Path 1.8.2.2 +3 -3 src/usr.sbin/adduser/rmuser.sh From owner-cvs-src@FreeBSD.ORG Fri Oct 19 08:16:31 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C1E2C16A421; Fri, 19 Oct 2007 08:16:31 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A585A13C461; Fri, 19 Oct 2007 08:16:31 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9J8GV0q083986; Fri, 19 Oct 2007 08:16:31 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9J8GVgk083985; Fri, 19 Oct 2007 08:16:31 GMT (envelope-from mtm) Message-Id: <200710190816.l9J8GVgk083985@repoman.freebsd.org> From: Mike Makonnen Date: Fri, 19 Oct 2007 08:16:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/usr.sbin/adduser adduser.8 rmuser.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 08:16:31 -0000 mtm 2007-10-19 08:16:30 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/adduser adduser.8 rmuser.8 Log: MFC: rmuser.8 rev. 1.24,1.24 : Typo fixes. adduser.8 rev. 1.57-1.59: Typo and markup fixes rev. 1.56: Add adding_user.8 to SEE ALSO, note that usernames may contain any character but not being with a hyphen, similar to adding_user.8. PR: 35732 Revision Changes Path 1.55.8.1 +9 -6 src/usr.sbin/adduser/adduser.8 1.23.8.1 +2 -2 src/usr.sbin/adduser/rmuser.8 From owner-cvs-src@FreeBSD.ORG Fri Oct 19 08:53:16 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6BB7E16A420; Fri, 19 Oct 2007 08:53:16 +0000 (UTC) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E589D13C4EA; Fri, 19 Oct 2007 08:53:15 +0000 (UTC) (envelope-from silby@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9J8rF0E095906; Fri, 19 Oct 2007 08:53:15 GMT (envelope-from silby@repoman.freebsd.org) Received: (from silby@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9J8rFRc095905; Fri, 19 Oct 2007 08:53:15 GMT (envelope-from silby) Message-Id: <200710190853.l9J8rFRc095905@repoman.freebsd.org> From: Mike Silbersack Date: Fri, 19 Oct 2007 08:53:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet tcp_syncache.c tcp_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 08:53:16 -0000 silby 2007-10-19 08:53:15 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c tcp_usrreq.c Log: Pick the smallest possible TCP window scaling factor that will still allow us to scale up to sb_max, aka kern.ipc.maxsockbuf. We do this because there are broken firewalls that will corrupt the window scale option, leading to the other endpoint believing that our advertised window is unscaled. At scale factors larger than 5 the unscaled window will drop below 1500 bytes, leading to serious problems when traversing these broken firewalls. With the default maxsockbuf of 256K, a scale factor of 3 will be chosen by this algorithm. Those who choose a larger maxsockbuf should watch out for the compatiblity problems mentioned above. Reviewed by: andre Revision Changes Path 1.131 +17 -6 src/sys/netinet/tcp_syncache.c 1.164 +1 -2 src/sys/netinet/tcp_usrreq.c From owner-cvs-src@FreeBSD.ORG Fri Oct 19 08:59:59 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7F71616A480; Fri, 19 Oct 2007 08:59:59 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 626C113C457; Fri, 19 Oct 2007 08:59:59 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9J8xxuq096201; Fri, 19 Oct 2007 08:59:59 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9J8xxwM096200; Fri, 19 Oct 2007 08:59:59 GMT (envelope-from mtm) Message-Id: <200710190859.l9J8xxwM096200@repoman.freebsd.org> From: Mike Makonnen Date: Fri, 19 Oct 2007 08:59:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/rc.d kerberos X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 08:59:59 -0000 mtm 2007-10-19 08:59:59 UTC FreeBSD src repository Modified files: etc/rc.d kerberos Log: Partial backout of rev. 1.6, but instead of putting kerberos5_server_flags back in command_args, put it where rc.subr(8) expects it: kerberos5_flags. Revision Changes Path 1.7 +1 -0 src/etc/rc.d/kerberos From owner-cvs-src@FreeBSD.ORG Fri Oct 19 10:37:35 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0070E16A4C7; Fri, 19 Oct 2007 10:37:34 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id D4BB313C4B2; Fri, 19 Oct 2007 10:37:34 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JAbY5p003945; Fri, 19 Oct 2007 10:37:34 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JAbYBR003944; Fri, 19 Oct 2007 10:37:34 GMT (envelope-from rwatson) Message-Id: <200710191037.l9JAbYBR003944@repoman.freebsd.org> From: Robert Watson Date: Fri, 19 Oct 2007 10:37:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libbsm Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 10:37:35 -0000 rwatson 2007-10-19 10:37:34 UTC FreeBSD src repository Modified files: lib/libbsm Makefile Log: Install getaudit_addr(2) and setaudit_addr(2) links to getaudit(2) and setaudit(2). MFC after: 3 days Submitted by: csjp Obtained from: TrustedBSD Project Revision Changes Path 1.8 +3 -1 src/lib/libbsm/Makefile From owner-cvs-src@FreeBSD.ORG Fri Oct 19 11:37:13 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AD6BE16A420; Fri, 19 Oct 2007 11:37:12 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 6683B13C465; Fri, 19 Oct 2007 11:36:24 +0000 (UTC) (envelope-from netchild@freebsd.org) Received: from outgoing.leidinger.net (p54A564CA.dip.t-dialin.net [84.165.100.202]) by redbull.bpaserver.net (Postfix) with ESMTP id C3BF22E0EE; Fri, 19 Oct 2007 13:36:06 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 918505B480D; Fri, 19 Oct 2007 13:35:00 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.1/8.13.8/Submit) id l9JBZ0Xh058828; Fri, 19 Oct 2007 13:35:00 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Fri, 19 Oct 2007 13:35:00 +0200 Message-ID: <20071019133500.epngxkctq88c8s00@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Fri, 19 Oct 2007 13:35:00 +0200 From: Alexander Leidinger To: John-Mark Gurney References: <20071015152408.10kvgtog6cooc4wc@webmail.leidinger.net> <48258.1192460507@critter.freebsd.dk> <20071015210909.1b6b693b@deskjail> <20071015202115.GP39759@funkthat.com> <20071016184047.8zh3fl90gksks40c@webmail.leidinger.net> <20071016175726.GS39759@funkthat.com> In-Reply-To: <20071016175726.GS39759@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-12.727, required 8, BAYES_00 -15.00, J_CHICKENPOX_27 0.60, MIME_QP_LONG_LINE 1.40, RDNS_DYNAMIC 0.10, SARE_FROM_SPAM_WORD3 0.10, TW_PH 0.08) X-BPAnet-MailScanner-From: netchild@freebsd.org X-Spam-Status: No Cc: Wilko Bulte , Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 11:37:13 -0000 Quoting John-Mark Gurney (from Tue, 16 =20 Oct 2007 10:57:26 -0700): > Alexander Leidinger wrote this message on Tue, Oct 16, 2007 at 18:40 +0200= : >> Quoting John-Mark Gurney (from Mon, 15 >> Oct 2007 13:21:15 -0700): >> >> >Alexander Leidinger wrote this message on Mon, Oct 15, 2007 at 21:09 +02= 00: >> >>> >I already told you last time >> >>> >that the current way (access to the i2c or smbus) needs more access >> >>> >rights than using the userland parts of the sensors framework. >> >>> >> >>> More rights than what exactly ? >> >> >> >>One popular userland temperature/voltage reading tool (as it supports a >> >>lot of popular devices) is mbmon. It is currently a SUID root >> >>application. It is like this as it accesses the smbus and/or ISA I/O >> >>ports directly. If we forget the ISA I/O ports part, we could maybe >> >>switch to a mbmon-user, but I don't really want to have such an user be >> >>able to query every device on the smbus. >> >> >> >>systat and sysctl are not SUID/SGID and don't require some special >> >>rights in /dev. I would say this is a big difference in favour of the >> >>sensors framework. >> > >> >Did you completely ignore the discussion back in July? I didn't bring >> >it up, because someone else did, but the simple solution is a socket >> >> Have you a pointer to it? I would like to analyze why I don't remember >> to have seen this. > > Hmm.. Looks like no one specificly stated a socket, plenty people > talked about userland, and a couple mentions of daemons.. You were so > against doing any userland work that the discussion never got far > enough to talk about design decisions and implementation... I think we maybe haven't talked about the same things... in =20 Constantines sensors framework (the code which is responsible to fill =20 hw.sensors with data) I still think there's no room for userland data. =20 See my description of different sensor frameworks on arch from =20 yesterday). This is decoupled from e.g., lm.4. So far we have no safe way of =20 querying such devices from userland. lm.4 gives us the safe way. It's =20 tested in OpenBSD to not harm systems, and our sysctl interface (via =20 Constantines sensors framework) allows to export the data in a safe =20 way (compared with e.g., todays situation with mbmon with elevated =20 privileges which give full access to the application which queries the =20 hardware). It also serves as a good example of using Constantines =20 sensors framework with known to work code. Constantines work contains =20 a little bit of userland code, to give the user something to play =20 with. The main part of the work was the in-kernel framework, not the =20 userland part. For Constantines project in the soc, the userland work =20 proposed in the thread on arch was out of scope. lm.4 is used to access common hardware on mainboards. Currently you =20 need elevated privileges without any protection layer between the code =20 doing the data reading and the user requesting it. With lm.4 and the =20 sensors framework we have our sysctl framework as a protection layer =20 in between. I don't say everything needs to be in the kernel, but the =20 current situation is not good, and this we get for free. If there's =20 some kind of framework, where the lm.4 stuff can be added to the =20 userland to get similar benefits we get with lm.4, I surely don't =20 object to move it there (systems evolve, and I welcome this). But =20 Constantines project was not about such a framework, and nobody is =20 working on something like this. So it's not that I object in general, =20 it's that we don't have the infrastructure to move in this direction. > Rober Watson talking about using the SNMP daemon: > http://docs.freebsd.org/cgi/getmsg.cgi?fetch=3D174429+0+/usr/local/www/db/= text/2007/freebsd-arch/20070715.freebsd-arch Robert is talking about what fits into single-system sensors framework =20 on arch. > phk talking about userland for MIB and kernel for transport: > http://docs.freebsd.org/cgi/getmsg.cgi?fetch=3D170761+0+/usr/local/www/db/= text/2007/freebsd-arch/20070715.freebsd-arch Poul was arguing that there's no benefit from Constantines sensors =20 framework and wanted to do something what I call a single-system =20 sensors framework in the mail to arch from yesterday (he didn't care =20 to look even at the architecture of Constantines work). Nobody is =20 saying that a single-system sensor framework is not a good idea (if it =20 belongs to ports or into our basesystem e.g., via using our bsnmp or =20 by writting something else, is not something I care much about), but =20 Poul said Constantines work (the idea behind, to export sensor data =20 via a common API from the kernel, so that users of FreeBSD don't have =20 to go and hunt down sensor data from the kernel from a lot of places =20 and that developers don't have to reinvent the wheel how to export the =20 data from the kernel) is not worth our time. > Doug Ambrisko talking about doing it both as a userland and a kernel > interface: > http://docs.freebsd.org/cgi/getmsg.cgi?fetch=3D53014+0+/usr/local/www/db/t= ext/2007/freebsd-arch/20070715.freebsd-arch Doug suggested to do a combination of what I describe in my mail to =20 arch from yesterday as a kernel sensors framework and a single-system =20 sensors framework. Constantines work was about the part of a kernel =20 sensors framework. He also provided some userland code so that data =20 from the kernel sensor framework can be logged into syslog, and that =20 users can see this data in a top-like fashion. Doug was not saying =20 something against the kernel sensors framework. And I think he said =20 what he said based upon what he has read in Pouls mails. > phk talking about why kernel is complicated and userland is better: > http://docs.freebsd.org/cgi/getmsg.cgi?fetch=3D166332+0+/usr/local/www/db/= text/2007/freebsd-arch/20070715.freebsd-arch Somehow I get a mail from Robert when I follow this link. Regarding =20 what you wrote as the explanation for the link: Poul objected to the =20 entire kernel work Constantine was doing, without looking at the =20 architecture or the code. I was explaining that Constantines work was =20 about providing a way of exporting sensor data from the kernel to the =20 userland and that nobody prevents us to run some sensor data collector =20 program (what I better describe as a single-system sensor framework in =20 my mail to arch from yesterday) in userland. Poul was focused on his =20 userland approach without any common API to access kernel stuff =20 (Constantines work). He also didn't continue the discussion >> >like /var/run/log or /var/run/devd.pipe, that a userland daemon running >> >as root that has access to ISA I/O and related resources... It's >> >that simple... >> >> And the code doesn't exists. And when it is written, when will it be >> bugfree enough? The sysctl way of exporting integer data already has a > > And code in the kernel is guaranteed to be bug free enough? I'd much > rather have "bug free" code in the userland where the stability of the > system isn't as greatly effected by the code than "bug free" code in > the kernel... It's easier to write safe code to do the lm stuff (this stuff is less =20 complex) in the kernel, than it is to write a safe infrastructure =20 which "only" gives access to ISA I/O (you can do a lot with ISA I/O =20 access, it needs to be in a way that resources there which are bound =20 by drivers in the kernel don't get circumvented), as the complexity is =20 different. > Also, I find writing bug free code much easier when done in userland > as it's easier to go through the debug/recompile/test steps than the > same for kernel code... There are critical bugs, and non-critical bugs. If you give userland =20 access to ISA resources on a "common use" instead of a "rare =20 circumstances" base (which would be the case in an interval based =20 monitoring) in our current infrastrucuture, I'm not convinced, that is =20 is that much easier. If we talk about a hypotetical =20 ISA-access-infrastructure, which prevents the use of malicious things =20 with kernel-attached devices, then the situation looks different. >> good track record, and porting the existing lm sensor (from a project >> which is known to take much care about security) was easier to get >> right. The project also was not about the lm sensor (I don't go and >> count the size for the small lm sensor now). The lm sensor was one >> example of using it. I don't think objection to the lm sensor driver >> should lead to removal of the framework itself. One possible reaction >> could be to say that the lm sensor should move to ports. > > I've never talked about a specific sensor or anything...... I purely > argued for the agregation of data to happen in userland and the kernel > simply be a transport for the data to userland.... And Constantines sensors framework is supposed to give a common API to =20 transport the data to userland. > Maybe you should look at NUT: http://www.networkupstools.org/ > > It does a bit more than simply look at sensor readings, but it does > do things like report voltage, temperature, and current battery charge... You are talking about what I call a group-level sensors framework. See =20 my mail from yesterday to arch how this fits into my current view of =20 the world with Constantines sensors framework. Bye, Alexander. --=20 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137 Dr. Zoidberg: "Now I'm not saying Professor Farnsworth is old, but if you consider his age he's likely to die soon." From owner-cvs-src@FreeBSD.ORG Fri Oct 19 12:23:25 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CF7A816A417; Fri, 19 Oct 2007 12:23:25 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C9AC813C469; Fri, 19 Oct 2007 12:23:25 +0000 (UTC) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JCNPjH011624; Fri, 19 Oct 2007 12:23:25 GMT (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JCNPFt011623; Fri, 19 Oct 2007 12:23:25 GMT (envelope-from bde) Message-Id: <200710191223.l9JCNPFt011623@repoman.freebsd.org> From: Bruce Evans Date: Fri, 19 Oct 2007 12:23:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/msdosfs msdosfs_denode.c msdosfs_lookup.c msdosfs_vfsops.c msdosfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 12:23:25 -0000 bde 2007-10-19 12:23:25 UTC FreeBSD src repository Modified files: sys/fs/msdosfs msdosfs_denode.c msdosfs_lookup.c msdosfs_vfsops.c msdosfs_vnops.c Log: Implement the async (really, delayed-write) mount option for msdosfs. This is much simpler than for ffs since there are many fewer places where we need to choose between a delayed write and a sync write -- just 5 in msdosfs and more than 30 in ffs. This is more complete and correct than in ffs. Several places in ffs are are still missing the choice. ffs_update() has a layering violation that breaks callers which want to force a sync update (mainly fsync(2) and O_SYNC write(2)). However, fsync(2) and O_SYNC write(2) are still more broken than in ffs, since they are broken for default (non-sync non-async) mounts too. Both fail to sync the FAT in all cases, and both fail to sync the directory entry in some cases after losing a race. Async everything is probably safer than the half-baked sync of metadata given by default mounts. Revision Changes Path 1.98 +2 -2 src/sys/fs/msdosfs/msdosfs_denode.c 1.52 +9 -3 src/sys/fs/msdosfs/msdosfs_lookup.c 1.178 +1 -1 src/sys/fs/msdosfs/msdosfs_vfsops.c 1.181 +6 -4 src/sys/fs/msdosfs/msdosfs_vnops.c From owner-cvs-src@FreeBSD.ORG Fri Oct 19 12:30:39 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 867D016A41B; Fri, 19 Oct 2007 12:30:39 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6903913C45A; Fri, 19 Oct 2007 12:30:39 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JCUda8011914; Fri, 19 Oct 2007 12:30:39 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JCUdII011913; Fri, 19 Oct 2007 12:30:39 GMT (envelope-from kensmith) Message-Id: <200710191230.l9JCUdII011913@repoman.freebsd.org> From: Ken Smith Date: Fri, 19 Oct 2007 12:30:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/conf GENERIC src/sys/i386/conf GENERIC X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 12:30:39 -0000 kensmith 2007-10-19 12:30:34 UTC FreeBSD src repository Modified files: sys/amd64/conf GENERIC sys/i386/conf GENERIC Log: Switch over to ULE as the default scheduler for amd64 and i386 architectures. Revision Changes Path 1.485 +1 -1 src/sys/amd64/conf/GENERIC 1.475 +1 -1 src/sys/i386/conf/GENERIC From owner-cvs-src@FreeBSD.ORG Fri Oct 19 12:46:16 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 03E4416A417; Fri, 19 Oct 2007 12:46:16 +0000 (UTC) (envelope-from rpaulo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id DC57A13C458; Fri, 19 Oct 2007 12:46:15 +0000 (UTC) (envelope-from rpaulo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JCkFMq012850; Fri, 19 Oct 2007 12:46:15 GMT (envelope-from rpaulo@repoman.freebsd.org) Received: (from rpaulo@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JCkF0d012849; Fri, 19 Oct 2007 12:46:15 GMT (envelope-from rpaulo) Message-Id: <200710191246.l9JCkF0d012849@repoman.freebsd.org> From: Rui Paulo Date: Fri, 19 Oct 2007 12:46:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet ip.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 12:46:16 -0000 rpaulo 2007-10-19 12:46:15 UTC FreeBSD src repository Modified files: sys/netinet ip.h Log: Remove IPTOS_CE and IPTOS_ECT constants. They were defined in RFC 2481 but later obsoleted by RFC 3168. Discussed on freebsd-net with no objections. Approved by: njl (mentor), rwatson Revision Changes Path 1.32 +0 -5 src/sys/netinet/ip.h From owner-cvs-src@FreeBSD.ORG Fri Oct 19 12:48:03 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D9A416A41A; Fri, 19 Oct 2007 12:48:03 +0000 (UTC) (envelope-from rpaulo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 31B2013C459; Fri, 19 Oct 2007 12:48:03 +0000 (UTC) (envelope-from rpaulo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JCm3de021630; Fri, 19 Oct 2007 12:48:03 GMT (envelope-from rpaulo@repoman.freebsd.org) Received: (from rpaulo@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JCm3SV021629; Fri, 19 Oct 2007 12:48:03 GMT (envelope-from rpaulo) Message-Id: <200710191248.l9JCm3SV021629@repoman.freebsd.org> From: Rui Paulo Date: Fri, 19 Oct 2007 12:48:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/ipfw ipfw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 12:48:03 -0000 rpaulo 2007-10-19 12:48:02 UTC FreeBSD src repository Modified files: sbin/ipfw ipfw2.c Log: Comply with the removal of IPTOS_CE and IPTOS_ECT. Discussed on freebsd-net with no objections. Approved by: njl (mentor), rwatson Revision Changes Path 1.109 +2 -2 src/sbin/ipfw/ipfw2.c From owner-cvs-src@FreeBSD.ORG Fri Oct 19 13:09:02 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5778D16A418; Fri, 19 Oct 2007 13:09:02 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3B46C13C465; Fri, 19 Oct 2007 13:09:02 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JD92N7032845; Fri, 19 Oct 2007 13:09:02 GMT (envelope-from mav@repoman.freebsd.org) Received: (from mav@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JD92dl032844; Fri, 19 Oct 2007 13:09:02 GMT (envelope-from mav) Message-Id: <200710191309.l9JD92dl032844@repoman.freebsd.org> From: Alexander Motin Date: Fri, 19 Oct 2007 13:09:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/netgraph ng_l2tp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 13:09:02 -0000 mav 2007-10-19 13:09:01 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/netgraph ng_l2tp.c Log: MFC rev. 1.18-1.21 - Fix thread safety. - Make some optimizations. Approved by: re (kensmith) Revision Changes Path 1.17.2.1 +151 -106 src/sys/netgraph/ng_l2tp.c From owner-cvs-src@FreeBSD.ORG Fri Oct 19 14:01:25 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 90B4D16A417; Fri, 19 Oct 2007 14:01:25 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7248013C474; Fri, 19 Oct 2007 14:01:25 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JE1PJn040935; Fri, 19 Oct 2007 14:01:25 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JE1PNX040932; Fri, 19 Oct 2007 14:01:25 GMT (envelope-from ru) Message-Id: <200710191401.l9JE1PNX040932@repoman.freebsd.org> From: Ruslan Ermilov Date: Fri, 19 Oct 2007 14:01:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/tools/build/options WITHOUT_NS_CACHING X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 14:01:25 -0000 ru 2007-10-19 14:01:25 UTC FreeBSD src repository Modified files: tools/build/options WITHOUT_NS_CACHING Log: cached -> nscd Revision Changes Path 1.2 +1 -1 src/tools/build/options/WITHOUT_NS_CACHING From owner-cvs-src@FreeBSD.ORG Fri Oct 19 14:03:05 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DCF3F16A417; Fri, 19 Oct 2007 14:03:05 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C012013C44B; Fri, 19 Oct 2007 14:03:05 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JE357u042246; Fri, 19 Oct 2007 14:03:05 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JE35T9042245; Fri, 19 Oct 2007 14:03:05 GMT (envelope-from ru) Message-Id: <200710191403.l9JE35T9042245@repoman.freebsd.org> From: Ruslan Ermilov Date: Fri, 19 Oct 2007 14:03:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/man/man5 src.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 14:03:06 -0000 ru 2007-10-19 14:03:05 UTC FreeBSD src repository Modified files: share/man/man5 src.conf.5 Log: Regen (nscd -> cached, WITHOUT_LIBPTHREAD disabling BIND). Revision Changes Path 1.20 +16 -2 src/share/man/man5/src.conf.5 From owner-cvs-src@FreeBSD.ORG Fri Oct 19 14:13:02 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2978016A46C; Fri, 19 Oct 2007 14:13:02 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id EF77513C44B; Fri, 19 Oct 2007 14:13:01 +0000 (UTC) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JED2dF042860; Fri, 19 Oct 2007 14:13:02 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JED1MF042859; Fri, 19 Oct 2007 14:13:01 GMT (envelope-from kensmith) Message-Id: <200710191413.l9JED1MF042859@repoman.freebsd.org> From: Ken Smith Date: Fri, 19 Oct 2007 14:13:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/conf newvers.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 14:13:02 -0000 kensmith 2007-10-19 14:13:01 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/conf newvers.sh Log: Time to start calling it BETA1. Approved by: re (implicit) Revision Changes Path 1.72.2.2 +1 -1 src/sys/conf/newvers.sh From owner-cvs-src@FreeBSD.ORG Fri Oct 19 14:25:56 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6A68116A419; Fri, 19 Oct 2007 14:25:56 +0000 (UTC) (envelope-from rermilov@team.vega.ru) Received: from mail.vega.ru (mx1.vega.ru [87.242.77.163]) by mx1.freebsd.org (Postfix) with ESMTP id 1830213C465; Fri, 19 Oct 2007 14:25:55 +0000 (UTC) (envelope-from rermilov@team.vega.ru) Received: from [87.242.97.68] (port=1107 helo=edoofus.dev.vega.ru) by mail.vega.ru with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68 (FreeBSD)) (envelope-from ) id 1IisT4-000FEA-8O; Fri, 19 Oct 2007 14:04:50 +0000 Received: from edoofus.dev.vega.ru (localhost [127.0.0.1]) by edoofus.dev.vega.ru (8.14.1/8.14.1) with ESMTP id l9JE41oF050659; Fri, 19 Oct 2007 18:04:01 +0400 (MSD) (envelope-from rermilov@team.vega.ru) Received: (from ru@localhost) by edoofus.dev.vega.ru (8.14.1/8.14.1/Submit) id l9JE41ch050658; Fri, 19 Oct 2007 18:04:01 +0400 (MSD) (envelope-from rermilov@team.vega.ru) X-Authentication-Warning: edoofus.dev.vega.ru: ru set sender to rermilov@team.vega.ru using -f Date: Fri, 19 Oct 2007 18:04:01 +0400 From: Ruslan Ermilov To: Michael Bushkov , Brooks Davis , Ken Smith Message-ID: <20071019140401.GA37972@team.vega.ru> References: <200710190018.l9J0IJd7027803@repoman.freebsd.org> <200710190016.l9J0GUpo027720@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200710190018.l9J0IJd7027803@repoman.freebsd.org> <200710190016.l9J0GUpo027720@repoman.freebsd.org> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man5 nsswitch.conf.5 src.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 14:25:56 -0000 Hi Michael, This commit and its MFC is not quite correct. The src.conf(5) manpage is automatically generated using tools/build/options/. Changes to this manpage should go there first and committed; then the manpage should be regenerated using the makeman shell script and committed separately (the commit must be separate so that file revisions are correct). I've fixed HEAD. Please proceed with MFCing it. On Fri, Oct 19, 2007 at 12:16:30AM +0000, Michael Bushkov wrote: > bushman 2007-10-19 00:16:29 UTC > > FreeBSD src repository > > Modified files: > share/man/man5 nsswitch.conf.5 src.conf.5 > Log: > Small fix in man pages after cached -> nscd renaming. > > Approved by: brooks (mentor) > > Revision Changes Path > 1.18 +5 -5 src/share/man/man5/nsswitch.conf.5 > 1.19 +1 -1 src/share/man/man5/src.conf.5 > On Fri, Oct 19, 2007 at 12:18:19AM +0000, Michael Bushkov wrote: > bushman 2007-10-19 00:18:19 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_7) > share/man/man5 nsswitch.conf.5 src.conf.5 > Log: > Fast MFC: Small fix in man pages after cached -> nscd renaming. > > Approved by: re (kensmith), brooks (mentor) > > Revision Changes Path > 1.17.2.1 +5 -5 src/share/man/man5/nsswitch.conf.5 > 1.18.2.1 +1 -1 src/share/man/man5/src.conf.5 > -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer From owner-cvs-src@FreeBSD.ORG Fri Oct 19 14:29:40 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1FABB16A420; Fri, 19 Oct 2007 14:29:40 +0000 (UTC) (envelope-from bushman@freebsd.org) Received: from mail.r61.net (mail.r61.net [195.208.245.249]) by mx1.freebsd.org (Postfix) with ESMTP id 8B35613C467; Fri, 19 Oct 2007 14:29:38 +0000 (UTC) (envelope-from bushman@freebsd.org) Received: from [127.0.0.1] (shogun.cc.rsu.ru [195.208.252.84]) (authenticated bits=0) by mail.r61.net (8.14.1/8.14.1) with ESMTP id l9JETZBZ080595; Fri, 19 Oct 2007 18:29:37 +0400 (MSD) (envelope-from bushman@freebsd.org) Message-ID: <4718BF41.8000104@freebsd.org> Date: Fri, 19 Oct 2007 18:29:21 +0400 From: Michael Bushkov User-Agent: Thunderbird 2.0.0.5 (Windows/20070716) MIME-Version: 1.0 To: Ruslan Ermilov References: <200710190018.l9J0IJd7027803@repoman.freebsd.org> <200710190016.l9J0GUpo027720@repoman.freebsd.org> <20071019140401.GA37972@team.vega.ru> In-Reply-To: <20071019140401.GA37972@team.vega.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, Brooks Davis , src-committers@freebsd.org, cvs-all@freebsd.org, Ken Smith Subject: Re: cvs commit: src/share/man/man5 nsswitch.conf.5 src.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 14:29:40 -0000 Hi Ruslan, Thanks for pointing this out. I'll do the MFCing part. Ruslan Ermilov wrote: > Hi Michael, > > This commit and its MFC is not quite correct. The src.conf(5) > manpage is automatically generated using tools/build/options/. > Changes to this manpage should go there first and committed; > then the manpage should be regenerated using the makeman shell > script and committed separately (the commit must be separate so > that file revisions are correct). I've fixed HEAD. Please > proceed with MFCing it. > > On Fri, Oct 19, 2007 at 12:16:30AM +0000, Michael Bushkov wrote: >> bushman 2007-10-19 00:16:29 UTC >> >> FreeBSD src repository >> >> Modified files: >> share/man/man5 nsswitch.conf.5 src.conf.5 >> Log: >> Small fix in man pages after cached -> nscd renaming. >> >> Approved by: brooks (mentor) >> >> Revision Changes Path >> 1.18 +5 -5 src/share/man/man5/nsswitch.conf.5 >> 1.19 +1 -1 src/share/man/man5/src.conf.5 >> > > On Fri, Oct 19, 2007 at 12:18:19AM +0000, Michael Bushkov wrote: >> bushman 2007-10-19 00:18:19 UTC >> >> FreeBSD src repository >> >> Modified files: (Branch: RELENG_7) >> share/man/man5 nsswitch.conf.5 src.conf.5 >> Log: >> Fast MFC: Small fix in man pages after cached -> nscd renaming. >> >> Approved by: re (kensmith), brooks (mentor) >> >> Revision Changes Path >> 1.17.2.1 +5 -5 src/share/man/man5/nsswitch.conf.5 >> 1.18.2.1 +1 -1 src/share/man/man5/src.conf.5 >> > > -- With best regards, Michael Bushkov Southern Federal University From owner-cvs-src@FreeBSD.ORG Fri Oct 19 15:04:18 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AFC4B16A475; Fri, 19 Oct 2007 15:04:18 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5D3B113C4CA; Fri, 19 Oct 2007 15:04:18 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JF4ITI046754; Fri, 19 Oct 2007 15:04:18 GMT (envelope-from mav@repoman.freebsd.org) Received: (from mav@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JF4Ios046753; Fri, 19 Oct 2007 15:04:18 GMT (envelope-from mav) Message-Id: <200710191504.l9JF4Ios046753@repoman.freebsd.org> From: Alexander Motin Date: Fri, 19 Oct 2007 15:04:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netgraph netgraph.h ng_base.c ng_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 15:04:18 -0000 mav 2007-10-19 15:04:18 UTC FreeBSD src repository Modified files: sys/netgraph netgraph.h ng_base.c ng_socket.c Log: Implement new apply callback mechanism to handle item forwarding. When item forwarded refence counter is incremented, when item processed, counter decremented. When counter reaches zero, apply handler is getting called. Now it allows to report right connect() call status from user-level at the right time. Revision Changes Path 1.69 +37 -5 src/sys/netgraph/netgraph.h 1.136 +182 -65 src/sys/netgraph/ng_base.c 1.83 +13 -12 src/sys/netgraph/ng_socket.c From owner-cvs-src@FreeBSD.ORG Fri Oct 19 15:15:51 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 730B816A46D; Fri, 19 Oct 2007 15:15:51 +0000 (UTC) Date: Fri, 19 Oct 2007 15:15:51 +0000 From: Alexey Dokuchaev To: Bruce Evans Message-ID: <20071019151551.GA12127@FreeBSD.org> References: <200710191223.l9JCNPFt011623@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200710191223.l9JCNPFt011623@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/msdosfs msdosfs_denode.c msdosfs_lookup.c msdosfs_vfsops.c msdosfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 15:15:51 -0000 On Fri, Oct 19, 2007 at 12:23:25PM +0000, Bruce Evans wrote: > bde 2007-10-19 12:23:25 UTC > > FreeBSD src repository > > Modified files: > sys/fs/msdosfs msdosfs_denode.c msdosfs_lookup.c > msdosfs_vfsops.c msdosfs_vnops.c > Log: > Implement the async (really, delayed-write) mount option for msdosfs. Neat, thanks! ./danfe From owner-cvs-src@FreeBSD.ORG Fri Oct 19 15:19:23 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 70BCF16A417; Fri, 19 Oct 2007 15:19:23 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 4BE9813C455; Fri, 19 Oct 2007 15:19:23 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JFJNXZ047488; Fri, 19 Oct 2007 15:19:23 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JFJNOw047487; Fri, 19 Oct 2007 15:19:23 GMT (envelope-from scottl) Message-Id: <200710191519.l9JFJNOw047487@repoman.freebsd.org> From: Scott Long Date: Fri, 19 Oct 2007 15:19:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/dev/ciss ciss.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 15:19:23 -0000 scottl 2007-10-19 15:19:23 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/ciss ciss.c Log: Merge rev 1.82: Don't serialize requests to the controller. Approved by: re Revision Changes Path 1.81.2.1 +2 -1 src/sys/dev/ciss/ciss.c From owner-cvs-src@FreeBSD.ORG Fri Oct 19 15:21:17 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7685016A41B; Fri, 19 Oct 2007 15:21:17 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3C71913C478; Fri, 19 Oct 2007 15:21:17 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JFLH5V047782; Fri, 19 Oct 2007 15:21:17 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JFLHU7047781; Fri, 19 Oct 2007 15:21:17 GMT (envelope-from scottl) Message-Id: <200710191521.l9JFLHU7047781@repoman.freebsd.org> From: Scott Long Date: Fri, 19 Oct 2007 15:21:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/dev/twa tw_osl.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 15:21:17 -0000 scottl 2007-10-19 15:21:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/twa tw_osl.h Log: Merge rev 1.6: Disable defered interrupt processing. There are reports that this feature still works with the 4BSD scheduler, but I'm disabling it anyways for the sake of safety. Approved by: re Revision Changes Path 1.5.2.1 +2 -0 src/sys/dev/twa/tw_osl.h From owner-cvs-src@FreeBSD.ORG Fri Oct 19 15:22:25 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2B90616A421; Fri, 19 Oct 2007 15:22:25 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0838313C45D; Fri, 19 Oct 2007 15:22:25 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JFMOQI047886; Fri, 19 Oct 2007 15:22:24 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JFMO4q047885; Fri, 19 Oct 2007 15:22:24 GMT (envelope-from scottl) Message-Id: <200710191522.l9JFMO4q047885@repoman.freebsd.org> From: Scott Long Date: Fri, 19 Oct 2007 15:22:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/dev/mpt mpt_cam.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 15:22:25 -0000 scottl 2007-10-19 15:22:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/mpt mpt_cam.c Log: Merge rev 1.62: Fix use-after-free panic. Approved by: re Revision Changes Path 1.61.2.1 +0 -1 src/sys/dev/mpt/mpt_cam.c From owner-cvs-src@FreeBSD.ORG Fri Oct 19 15:23:23 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8AE1A16A421; Fri, 19 Oct 2007 15:23:23 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6852713C494; Fri, 19 Oct 2007 15:23:23 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JFNNdQ047989; Fri, 19 Oct 2007 15:23:23 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JFNNqC047988; Fri, 19 Oct 2007 15:23:23 GMT (envelope-from scottl) Message-Id: <200710191523.l9JFNNqC047988@repoman.freebsd.org> From: Scott Long Date: Fri, 19 Oct 2007 15:23:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/dev/mfi mfi_cam.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 15:23:23 -0000 scottl 2007-10-19 15:23:23 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/mfi mfi_cam.c Log: Merge rev 1.3: Clean up warnings on boot. Approved by: re Revision Changes Path 1.2.2.1 +14 -17 src/sys/dev/mfi/mfi_cam.c From owner-cvs-src@FreeBSD.ORG Fri Oct 19 15:49:40 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 67FFC16A41A; Fri, 19 Oct 2007 15:49:40 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 564E113C43E; Fri, 19 Oct 2007 15:49:40 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JFneC0049184; Fri, 19 Oct 2007 15:49:40 GMT (envelope-from ariff@repoman.freebsd.org) Received: (from ariff@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JFne1Z049183; Fri, 19 Oct 2007 15:49:40 GMT (envelope-from ariff) Message-Id: <200710191549.l9JFne1Z049183@repoman.freebsd.org> From: Ariff Abdullah Date: Fri, 19 Oct 2007 15:49:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/pci/hda hdac.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 15:49:40 -0000 ariff 2007-10-19 15:49:40 UTC FreeBSD src repository Modified files: sys/dev/sound/pci/hda hdac.c Log: - Gigabyte G33-S2H fixup, due to the present of multiple competing codecs. Codec at address 0 seems purely digital, or perhaps an HDMI interface. Let the driver skip it and continue scanning the codecs starting with address 2 (Realtek ALC885). * Due to possibilities of future similar cases, put enough logic in hdac_scan_codecs() to force codec scanning starting from XX address via tunable "hint.pcm.%d.codec_index". Reported / Tested by: Toomas Pelberg - Trivial headphone / speaker automute fixup for Fujitsu-Siemens AMILO Si 1848 laptop. Reported / Tested by: Ed - Trivial headphone / speaker automute fixup for Fujitsu-Siemens Lifebook S7020D laptop. Reported / Tested by: Jaromir Dvoracek - Some smart vendor trying to create interplanetary wormhole by screwing pci config space during their BIOS update. The side effects of their failure attempt includes mutilated hardware id, broken speaker automuting and loosing the entire analog CD connectivity, thus causing enough collateral damages to collapse the entire universe. Move along with it. Please exercise extra cautious when applying BIOS updates. Reported / Tested by: Pietro Cerutti - assembled laptop, based on the MSI-1034 (662) which is now becoming MSI-034A. - Fix no sound issues (on headphones) for Lenovo ThinkCentre A55 due to global automute table entry which is not applicable for non-laptops. Reported / Tested by: Piotr Smyrak - Speaker mute control for HP DC7700 since the front headphone jack does not generate any interesting unsolicited signal/response. Reported / Tested by: tyop @ irc.freenode.net Approved by: re (kensmith) MFC after: 3 days Revision Changes Path 1.45 +71 -13 src/sys/dev/sound/pci/hda/hdac.c From owner-cvs-src@FreeBSD.ORG Fri Oct 19 15:53:45 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B7D6616A473; Fri, 19 Oct 2007 15:53:45 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id ABC1013C45B; Fri, 19 Oct 2007 15:53:45 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JFrjKV049547; Fri, 19 Oct 2007 15:53:45 GMT (envelope-from ariff@repoman.freebsd.org) Received: (from ariff@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JFrjpE049546; Fri, 19 Oct 2007 15:53:45 GMT (envelope-from ariff) Message-Id: <200710191553.l9JFrjpE049546@repoman.freebsd.org> From: Ariff Abdullah Date: Fri, 19 Oct 2007 15:53:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/dev/sound/pci/hda hdac.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 15:53:45 -0000 ariff 2007-10-19 15:53:45 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/sound/pci/hda hdac.c Log: - Gigabyte G33-S2H fixup, due to the present of multiple competing codecs. Codec at address 0 seems purely digital, or perhaps an HDMI interface. Let the driver skip it and continue scanning the codecs starting with address 2 (Realtek ALC885). * Due to possibilities of future similar cases, put enough logic in hdac_scan_codecs() to force codec scanning starting from XX address via tunable "hint.pcm.%d.codec_index". Reported / Tested by: Toomas Pelberg - Trivial headphone / speaker automute fixup for Fujitsu-Siemens AMILO Si 1848 laptop. Reported / Tested by: Ed - Trivial headphone / speaker automute fixup for Fujitsu-Siemens Lifebook S7020D laptop. Reported / Tested by: Jaromir Dvoracek - Some smart vendor trying to create interplanetary wormhole by screwing pci config space during their BIOS update. The side effects of their failure attempt includes mutilated hardware id, broken speaker automuting and loosing the entire analog CD connectivity, thus causing enough collateral damages to collapse the entire universe. Move along with it. Please exercise extra cautious when applying BIOS updates. Reported / Tested by: Pietro Cerutti - assembled laptop, based on the MSI-1034 (662) which is now becoming MSI-034A. - Fix no sound issues (on headphones) for Lenovo ThinkCentre A55 due to global automute table entry which is not applicable for non-laptops. Reported / Tested by: Piotr Smyrak - Speaker mute control for HP DC7700 since the front headphone jack does not generate any interesting unsolicited signal/response. Reported / Tested by: tyop @ irc.freenode.net Approved by: re (kensmith) Revision Changes Path 1.44.2.1 +71 -13 src/sys/dev/sound/pci/hda/hdac.c From owner-cvs-src@FreeBSD.ORG Fri Oct 19 16:02:18 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D73F716A46B; Fri, 19 Oct 2007 16:02:18 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B1BED13C480; Fri, 19 Oct 2007 16:02:18 +0000 (UTC) (envelope-from bmah@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JG2IDC050041; Fri, 19 Oct 2007 16:02:18 GMT (envelope-from bmah@repoman.freebsd.org) Received: (from bmah@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JG2I9s050040; Fri, 19 Oct 2007 16:02:18 GMT (envelope-from bmah) Message-Id: <200710191602.l9JG2I9s050040@repoman.freebsd.org> From: "Bruce A. Mah" Date: Fri, 19 Oct 2007 16:02:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 16:02:18 -0000 bmah 2007-10-19 16:02:18 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes article.sgml Log: Trim release notes for 8-CURRENT. Revision Changes Path 1.1071 +17 -2365 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml From owner-cvs-src@FreeBSD.ORG Fri Oct 19 16:33:31 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EE35116A47D; Fri, 19 Oct 2007 16:33:31 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A9CCF13C49D; Fri, 19 Oct 2007 16:33:31 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JGXVpe052751; Fri, 19 Oct 2007 16:33:31 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JGXVdX052750; Fri, 19 Oct 2007 16:33:31 GMT (envelope-from sam) Message-Id: <200710191633.l9JGXVdX052750@repoman.freebsd.org> From: Sam Leffler Date: Fri, 19 Oct 2007 16:33:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb if_zyd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 16:33:32 -0000 sam 2007-10-19 16:33:31 UTC FreeBSD src repository Modified files: sys/dev/usb if_zyd.c Log: fix an incorrect setting of `retry times' in case of zd1211b, we should set the ZYD_MACB_MAX_RETRY register instead of ZYD_MAC_RETRY Submitted by: Weongyo Jeong MFC after: 1 week Revision Changes Path 1.6 +1 -1 src/sys/dev/usb/if_zyd.c From owner-cvs-src@FreeBSD.ORG Fri Oct 19 16:48:49 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5401E16A419; Fri, 19 Oct 2007 16:48:49 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 29DBA13C491; Fri, 19 Oct 2007 16:48:49 +0000 (UTC) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JGmnpj062161; Fri, 19 Oct 2007 16:48:49 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JGmnsc062156; Fri, 19 Oct 2007 16:48:49 GMT (envelope-from obrien) Message-Id: <200710191648.l9JGmnsc062156@repoman.freebsd.org> From: "David E. O'Brien" Date: Fri, 19 Oct 2007 16:48:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/ddb db_command.c src/sys/sparc64/sparc64 db_interface.c src/sys/powerpc/powerpc db_interface.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 16:48:49 -0000 obrien 2007-10-19 16:48:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/ddb db_command.c sys/sparc64/sparc64 db_interface.c sys/powerpc/powerpc db_interface.c Log: MFC: Remove sparc64 & PowerPC MD 'reboot' and 'halt' commands and make them MI. 'reboot' is an alias for 'reset'. Revision Changes Path 1.60.2.3 +10 -0 src/sys/ddb/db_command.c 1.5.2.1 +0 -14 src/sys/powerpc/powerpc/db_interface.c 1.10.8.1 +0 -11 src/sys/sparc64/sparc64/db_interface.c From owner-cvs-src@FreeBSD.ORG Fri Oct 19 16:56:05 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 42CA216A41B; Fri, 19 Oct 2007 16:56:05 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id BD79D13C4A3; Fri, 19 Oct 2007 16:56:03 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 7A2D846F3E; Fri, 19 Oct 2007 12:56:00 -0400 (EDT) Date: Fri, 19 Oct 2007 17:56:00 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Darren Reed In-Reply-To: <200710182142.l9ILgsGd015588@repoman.freebsd.org> Message-ID: <20071019175247.C83542@fledge.watson.org> References: <200710182142.l9ILgsGd015588@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/ipfilter/netinet - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 16:56:05 -0000 On Thu, 18 Oct 2007, Darren Reed wrote: > darrenr 2007-10-18 21:42:54 UTC > > FreeBSD src repository > > src/sys/contrib/ipfilter/netinet - Imported sources > Update of /home/ncvs/src/sys/contrib/ipfilter/netinet > In directory repoman.freebsd.org:/tmp/cvs-serv15525 > > Log Message: > Import IPFilter 4.1.28 > > Status: > > Vendor Tag: DARRENR > Release Tags: v4-1-28 I didn't see a reply from you on the thread on current@ regarding the ipfilter panics, so I'll ask here: does this import resolve the panics that users are experiencing with ipfilter on 7.x/8.x when INVARIANTS is enabled? Robert N M Watson Computer Laboratory University of Cambridge From owner-cvs-src@FreeBSD.ORG Fri Oct 19 17:02:55 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8205E16A469; Fri, 19 Oct 2007 17:02:55 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 581A813C44B; Fri, 19 Oct 2007 17:02:55 +0000 (UTC) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JH2tQv063263; Fri, 19 Oct 2007 17:02:55 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JH2tus063262; Fri, 19 Oct 2007 17:02:55 GMT (envelope-from sam) Message-Id: <200710191702.l9JH2tus063262@repoman.freebsd.org> From: Sam Leffler Date: Fri, 19 Oct 2007 17:02:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/dev/usb if_zydreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 17:02:55 -0000 sam 2007-10-19 17:02:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/usb if_zydreg.h Log: MFC 1.2: increase max rx size so there's room for multi-frame transactions Submitted by: Weongyo Jeong Reviewed by: sam Approved by: re (kensmith) Revision Changes Path 1.1.2.1 +3 -2 src/sys/dev/usb/if_zydreg.h From owner-cvs-src@FreeBSD.ORG Fri Oct 19 17:08:39 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 54E6716A46E; Fri, 19 Oct 2007 17:08:39 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 2B30C13C457; Fri, 19 Oct 2007 17:08:39 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JH8dHw064713; Fri, 19 Oct 2007 17:08:39 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JH8dMk064712; Fri, 19 Oct 2007 17:08:39 GMT (envelope-from cognet) Message-Id: <200710191708.l9JH8dMk064712@repoman.freebsd.org> From: Olivier Houchard Date: Fri, 19 Oct 2007 17:08:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/share/mk bsd.cpu.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 17:08:39 -0000 cognet 2007-10-19 17:08:38 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/mk bsd.cpu.mk Log: MFC rev 1.63: date: 2007/10/16 18:32:37; author: cognet; state: Exp; lines: +3 -1 Backout rev 1.62, and revert to use -march=armv5te -D__XSCALE__ instead of -mcpu=xscale for XScale. gcc still has issues with -mcpu=xscale, and now crashes while building systat. Approved by: re (kensmith) Revision Changes Path 1.62.2.1 +3 -1 src/share/mk/bsd.cpu.mk From owner-cvs-src@FreeBSD.ORG Fri Oct 19 17:18:42 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 00C0016A41B; Fri, 19 Oct 2007 17:18:42 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.177]) by mx1.freebsd.org (Postfix) with ESMTP id 0EB7B13C442; Fri, 19 Oct 2007 17:18:27 +0000 (UTC) (envelope-from max@love2party.net) Received: from amd64.laiers.local (dslb-088-066-029-194.pools.arcor-ip.net [88.66.29.194]) by mrelayeu.kundenserver.de (node=mrelayeu8) with ESMTP (Nemesis) id 0ML31I-1IivUQ1Tyf-0008Ki; Fri, 19 Oct 2007 19:18:26 +0200 From: Max Laier Organization: FreeBSD To: Robert Watson Date: Fri, 19 Oct 2007 19:18:08 +0200 User-Agent: KMail/1.9.7 References: <200710182142.l9ILgsGd015588@repoman.freebsd.org> <20071019175247.C83542@fledge.watson.org> In-Reply-To: <20071019175247.C83542@fledge.watson.org> X-Face: ,,8R(x[kmU]tKN@>gtH1yQE4aslGdu+2]; R]*pL,U>^H?)gW@49@wdJ`H<=?utf-8?q?=25=7D*=5FBD=0A=09U=5For=3D=5CmOZf764=26nYj=3DJYbR1PW0ud?=>|!~,,CPC.1-D$FG@0h3#'5"k{V]a~.<=?utf-8?q?mZ=7D44=23Se=7Em=0A=09Fe=7E=5C=5DX5B=5D=5Fxj?=(ykz9QKMw_l0C2AQ]}Ym8)fU MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6125884.gSIXVcmuoo"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200710191918.25235.max@love2party.net> X-Provags-ID: V01U2FsdGVkX19erHRu2F9ZpBPo6pTqC7VaKGm7OUv9U1klnPH d2gKNIYOwf8HmGfx/W4qTjwIPyGqdd+2JbFNhmK+SUDtdyCgFO FPeQZPBT7jT1RelehnhUeOr0PxaKvBnkL2/EABTI2w= Cc: Darren Reed , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/contrib/ipfilter/netinet - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 17:18:42 -0000 --nextPart6125884.gSIXVcmuoo Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Friday 19 October 2007, Robert Watson wrote: > On Thu, 18 Oct 2007, Darren Reed wrote: > > darrenr 2007-10-18 21:42:54 UTC > > > > FreeBSD src repository > > > > src/sys/contrib/ipfilter/netinet - Imported sources > > Update of /home/ncvs/src/sys/contrib/ipfilter/netinet > > In directory repoman.freebsd.org:/tmp/cvs-serv15525 > > > > Log Message: > > Import IPFilter 4.1.28 > > > > Status: > > > > Vendor Tag: DARRENR > > Release Tags: v4-1-28 > > I didn't see a reply from you on the thread on current@ regarding the > ipfilter panics, so I'll ask here: does this import resolve the panics > that users are experiencing with ipfilter on 7.x/8.x when INVARIANTS is > enabled? According to my reading, the crashes described in=20 http://lists.freebsd.org/pipermail/freebsd-current/2007-October/078484.html= =20 are still present due to the following code in ip_fil_freebsd.c line=20 490ff: READ_ENTER(&ipf_global); error =3D fr_ioctlswitch(unit, data, cmd, mode, p->p_uid, p); Where fr_ioctlswitch() does the actual copyin/copyout and READ_ENTER=20 acquires a rwlock(9) which can't sleep. This is an improvement over the=20 previous attempt to sleep in the transmission path (due to useing sx(9)=20 locks), but it is still not correct and fragile even without INVARIANTS. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart6125884.gSIXVcmuoo Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQBHGObhXyyEoT62BG0RAl46AJ9UhNkiUA8jFnyDEhK6t/fA57vBIQCfZKnF 40qKlVxtWo6TxMO719MS30Y= =LOWw -----END PGP SIGNATURE----- --nextPart6125884.gSIXVcmuoo-- From owner-cvs-src@FreeBSD.ORG Fri Oct 19 18:13:33 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 87F1916A41A; Fri, 19 Oct 2007 18:13:33 +0000 (UTC) (envelope-from darrenr@freebsd.org) Received: from out1.smtp.messagingengine.com (out1.smtp.messagingengine.com [66.111.4.25]) by mx1.freebsd.org (Postfix) with ESMTP id CA63613C458; Fri, 19 Oct 2007 18:13:31 +0000 (UTC) (envelope-from darrenr@freebsd.org) Received: from compute2.internal (compute2.internal [10.202.2.42]) by out1.messagingengine.com (Postfix) with ESMTP id 2DBFD335A7; Fri, 19 Oct 2007 13:57:48 -0400 (EDT) Received: from web5.messagingengine.com ([10.202.2.214]) by compute2.internal (MEProxy); Fri, 19 Oct 2007 13:57:48 -0400 Received: by web5.messagingengine.com (Postfix, from userid 99) id 0C3B42390A; Fri, 19 Oct 2007 13:57:48 -0400 (EDT) Message-Id: <1192816668.26349.1216811849@webmail.messagingengine.com> X-Sasl-Enc: b5rZREqSh6Rbg7TCV5a6UDqKzhQzmnUnD9ibTBqD0SNB 1192816668 From: "Darren Reed" To: "Robert Watson" Content-Disposition: inline Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="ISO-8859-1" MIME-Version: 1.0 X-Mailer: MessagingEngine.com Webmail Interface References: <200710182142.l9ILgsGd015588@repoman.freebsd.org> <20071019175247.C83542@fledge.watson.org> In-Reply-To: <20071019175247.C83542@fledge.watson.org> Date: Fri, 19 Oct 2007 19:57:48 +0200 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/ipfilter/netinet - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: darrenr@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 18:13:33 -0000 On Fri, 19 Oct 2007 17:56:00 +0100 (BST), "Robert Watson" said: > > On Thu, 18 Oct 2007, Darren Reed wrote: > > > darrenr 2007-10-18 21:42:54 UTC > > > > FreeBSD src repository > > > > src/sys/contrib/ipfilter/netinet - Imported sources > > Update of /home/ncvs/src/sys/contrib/ipfilter/netinet > > In directory repoman.freebsd.org:/tmp/cvs-serv15525 > > > > Log Message: > > Import IPFilter 4.1.28 > > > > Status: > > > > Vendor Tag: DARRENR > > Release Tags: v4-1-28 > > I didn't see a reply from you on the thread on current@ regarding the > ipfilter > panics, so I'll ask here: does this import resolve the panics that users > are > experiencing with ipfilter on 7.x/8.x when INVARIANTS is enabled? I do most of my testing with GENERIC as I assume that's what others will also do... Is INVARIANTS enabled in GENERIC? If not, should it be? Darren -- Darren Reed darrenr@fastmail.net From owner-cvs-src@FreeBSD.ORG Fri Oct 19 18:24:20 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 394B816A417; Fri, 19 Oct 2007 18:24:20 +0000 (UTC) (envelope-from rpaulo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id F12CA13C48A; Fri, 19 Oct 2007 18:24:19 +0000 (UTC) (envelope-from rpaulo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JIOJ1m069897; Fri, 19 Oct 2007 18:24:19 GMT (envelope-from rpaulo@repoman.freebsd.org) Received: (from rpaulo@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JIOJMl069896; Fri, 19 Oct 2007 18:24:19 GMT (envelope-from rpaulo) Message-Id: <200710191824.l9JIOJMl069896@repoman.freebsd.org> From: Rui Paulo Date: Fri, 19 Oct 2007 18:24:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/ipfw ipfw.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 18:24:20 -0000 rpaulo 2007-10-19 18:24:19 UTC FreeBSD src repository Modified files: sbin/ipfw ipfw.8 Log: Change IPTOS_CE to IPTOS_ECN_CE. Approved by: njl (mentor) Revision Changes Path 1.205 +2 -2 src/sbin/ipfw/ipfw.8 From owner-cvs-src@FreeBSD.ORG Fri Oct 19 18:25:42 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 71B1E16A417; Fri, 19 Oct 2007 18:25:42 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [210.51.165.229]) by mx1.freebsd.org (Postfix) with ESMTP id 0C12C13C448; Fri, 19 Oct 2007 18:25:42 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from localhost (tarsier.geekcn.org [210.51.165.229]) by tarsier.geekcn.org (Postfix) with ESMTP id 2CA10EC2582; Sat, 20 Oct 2007 02:25:49 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([210.51.165.229]) by localhost (mail.geekcn.org [210.51.165.229]) (amavisd-new, port 10024) with ESMTP id 7IY+vzYbKW6n; Sat, 20 Oct 2007 02:25:44 +0800 (CST) Received: from LI-Xins-MacBook.local (71.5.7.139.ptr.us.xo.net [71.5.7.139]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTP id 0C869EC263A; Sat, 20 Oct 2007 02:25:42 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type; b=C/COoKgWs79LVRJbO1AgQxqT4m8oav260CeKsQUW0PFZ9Cqug58wJ1yLtmUkENbjL ysReHt6oMj709prrS3AiA== Message-ID: <4718F69D.2000803@delphij.net> Date: Fri, 19 Oct 2007 11:25:33 -0700 From: LI Xin Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: darrenr@FreeBSD.ORG References: <200710182142.l9ILgsGd015588@repoman.freebsd.org> <20071019175247.C83542@fledge.watson.org> <1192816668.26349.1216811849@webmail.messagingengine.com> In-Reply-To: <1192816668.26349.1216811849@webmail.messagingengine.com> X-Enigmail-Version: 0.95.3 OpenPGP: url=http://www.delphij.net/delphij.asc Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig52A5359283EA08CC85002F0F" Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, Robert Watson , cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/contrib/ipfilter/netinet - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 18:25:42 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig52A5359283EA08CC85002F0F Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Darren Reed wrote: > On Fri, 19 Oct 2007 17:56:00 +0100 (BST), "Robert Watson" > said: >> On Thu, 18 Oct 2007, Darren Reed wrote: >> >>> darrenr 2007-10-18 21:42:54 UTC >>> >>> FreeBSD src repository >>> >>> src/sys/contrib/ipfilter/netinet - Imported sources >>> Update of /home/ncvs/src/sys/contrib/ipfilter/netinet >>> In directory repoman.freebsd.org:/tmp/cvs-serv15525 >>> >>> Log Message: >>> Import IPFilter 4.1.28 >>> >>> Status: >>> >>> Vendor Tag: DARRENR >>> Release Tags: v4-1-28 >> I didn't see a reply from you on the thread on current@ regarding the >> ipfilter=20 >> panics, so I'll ask here: does this import resolve the panics that use= rs >> are=20 >> experiencing with ipfilter on 7.x/8.x when INVARIANTS is enabled? >=20 > I do most of my testing with GENERIC as I assume that's what > others will also do... >=20 > Is INVARIANTS enabled in GENERIC? > If not, should it be? INVARIANTS is enabled on HEAD but not RELENG_* branches (as it is mostly a diagnostic option and affects performance negatively), so if you are testing RELENG_7 then it is not enabled. Cheers, --=20 Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! --------------enig52A5359283EA08CC85002F0F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHGPadOfuToMruuMARCnGyAKCMdWWiAr3Cx6TMW0SGiDCpj74nmgCdFzOY QHMnV3wG6iGMUMvXJgU9EWs= =kUZn -----END PGP SIGNATURE----- --------------enig52A5359283EA08CC85002F0F-- From owner-cvs-src@FreeBSD.ORG Fri Oct 19 19:17:53 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BFC5416A417; Fri, 19 Oct 2007 19:17:53 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8ABCC13C478; Fri, 19 Oct 2007 19:17:53 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JJHrmJ076465; Fri, 19 Oct 2007 19:17:53 GMT (envelope-from emaste@repoman.freebsd.org) Received: (from emaste@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JJHr6L076464; Fri, 19 Oct 2007 19:17:53 GMT (envelope-from emaste) Message-Id: <200710191917.l9JJHr6L076464@repoman.freebsd.org> From: Ed Maste Date: Fri, 19 Oct 2007 19:17:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern syscalls.master X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 19:17:53 -0000 emaste 2007-10-19 19:17:53 UTC FreeBSD src repository Modified files: sys/kern syscalls.master Log: Put comments about syscalls by the correct ones, and use the correct syscall number in the comment. Revision Changes Path 1.234 +2 -2 src/sys/kern/syscalls.master From owner-cvs-src@FreeBSD.ORG Fri Oct 19 20:09:58 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CBBBF16A41A; Fri, 19 Oct 2007 20:09:58 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 949A513C45D; Fri, 19 Oct 2007 20:09:58 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JK9w4G081633; Fri, 19 Oct 2007 20:09:58 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JK9wwR081632; Fri, 19 Oct 2007 20:09:58 GMT (envelope-from ru) Message-Id: <200710192009.l9JK9wwR081632@repoman.freebsd.org> From: Ruslan Ermilov Date: Fri, 19 Oct 2007 20:09:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netgraph ng_base.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 20:09:58 -0000 ru 2007-10-19 20:09:58 UTC FreeBSD src repository Modified files: sys/netgraph ng_base.c Log: Fix build with NETGRAPH_DEBUG. Revision Changes Path 1.137 +9 -1 src/sys/netgraph/ng_base.c From owner-cvs-src@FreeBSD.ORG Fri Oct 19 20:15:58 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9251C16A420; Fri, 19 Oct 2007 20:15:58 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 58FB713C459; Fri, 19 Oct 2007 20:15:58 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JKFwRQ082075; Fri, 19 Oct 2007 20:15:58 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from delphij@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JKFwVk082074; Fri, 19 Oct 2007 20:15:58 GMT (envelope-from delphij) Message-Id: <200710192015.l9JKFwVk082074@repoman.freebsd.org> From: Xin LI Date: Fri, 19 Oct 2007 20:15:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 20:15:58 -0000 delphij 2007-10-19 20:15:57 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes article.sgml Log: IPFilter has been updated from 4.1.23 to 4.1.28. Revision Changes Path 1.1072 +2 -1 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml From owner-cvs-src@FreeBSD.ORG Fri Oct 19 22:55:44 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3CF9C16A41B; Fri, 19 Oct 2007 22:55:44 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 1435D13C459; Fri, 19 Oct 2007 22:55:44 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9JMtiwa002883; Fri, 19 Oct 2007 22:55:44 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9JMtgR5002882; Fri, 19 Oct 2007 22:55:42 GMT (envelope-from mtm) Message-Id: <200710192255.l9JMtgR5002882@repoman.freebsd.org> From: Mike Makonnen Date: Fri, 19 Oct 2007 22:55:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/etc/rc.d amd X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 22:55:44 -0000 mtm 2007-10-19 22:55:42 UTC FreeBSD src repository Modified files: etc/rc.d amd Log: The amd_map_program knob can potentially contain a command whose output is then used as an argument to the amd program. This outpu may contain newlines, but the script did not take care to strip those newlines before apending it to rc_flags. Revision 1.72 of rc.subr(8) introduced changes that exposed this problem (specifically putting the final eval'ed command in quotes).[1] Also, for correctness' sake, shell directives appended to the command-line by the script should go into command_args, and not appended directly to rc_flags. Reported by: John E Hein [1] Tested by: John E Hein MFC after: 1 week Revision Changes Path 1.19 +3 -2 src/etc/rc.d/amd From owner-cvs-src@FreeBSD.ORG Fri Oct 19 23:54:36 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 961A216A41B; Fri, 19 Oct 2007 23:54:36 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from mojo.ru (mojo.ru [84.252.152.63]) by mx1.freebsd.org (Postfix) with ESMTP id A9B7813C480; Fri, 19 Oct 2007 23:54:35 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from [192.168.0.16] (nc-76-6-108-199.dhcp.embarqhsd.net [76.6.108.199]) (authenticated bits=0) by mojo.ru (8.12.11.20060308/8.12.10) with ESMTP id l9JNshFh007427 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 20 Oct 2007 03:54:45 +0400 Message-ID: <471943AD.3040402@FreeBSD.org> Date: Fri, 19 Oct 2007 19:54:21 -0400 From: "Constantine A. Murenin" Organization: Google Summer of Code 2007 Student @ The FreeBSD Project User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.5) Gecko/20041217 X-Accept-Language: en-gb, en-gb-oed, en, en-us, ru, ru-ru, ru-su MIME-Version: 1.0 To: Alexander Leidinger References: <52183.1192652654@critter.freebsd.dk> <20071018092558.3c9b4tkescko4g0c@webmail.leidinger.net> In-Reply-To: <20071018092558.3c9b4tkescko4g0c@webmail.leidinger.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Scott Long , src-committers@FreeBSD.org, John Baldwin , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, "Constantine A. Murenin" , Poul-Henning Kamp , Wilko Bulte Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf f X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 23:54:36 -0000 On 18/10/2007 03:25, Alexander Leidinger wrote: > Quoting Poul-Henning Kamp (from Wed, 17 Oct 2007 > 20:24:14 +0000): > >> In message <47162F40.8000203@FreeBSD.org>, "Constantine A. Murenin" >> writes: >> >>> You didn't quote my other part of the reply about the ntpd/sensors.c >>> example. >> >> >> FreeBSD already supports an API for timekeeping events, complying >> with the only relevant standard in this area: RFC 2783 > > > He didn't talk about using this for timekeeping stuff in FreeBSD. He > used this an an example what could be done for RAID. I confirm. > As you didn't asked for a specific action regarding this I try to do > it. Please correct me if I don't get it right: > > Constantine, we have a standards compliant API for timekeeping events. > Any time related stuff should use this API. Please add a text and a > pointer, e.g., in the man-page and/or any other sensible place, which > tells that our RFC 2783 compliant API shall be used. Sure, in fact, I don't think such documentation is even needed -- OpenNTPD, the primary daemon that benefits from the timedelta sensors, resides in the ports tree, so any timedelta drivers could be implemented as loadable kernel modules and also reside in the ports tree, to be used together with OpenNTPD. I see no technical or architectural violations here, merely an extra alternative for the end users. The sensors framework itself, on the other hand, obviously cannot reside in the ports tree. C. From owner-cvs-src@FreeBSD.ORG Sat Oct 20 00:45:32 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 98A5016A41A; Sat, 20 Oct 2007 00:45:32 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 557D613C455; Sat, 20 Oct 2007 00:45:32 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9K0jWRS010532; Sat, 20 Oct 2007 00:45:32 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9K0jWFI010531; Sat, 20 Oct 2007 00:45:32 GMT (envelope-from mtm) Message-Id: <200710200045.l9K0jWFI010531@repoman.freebsd.org> From: Mike Makonnen Date: Sat, 20 Oct 2007 00:45:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/adduser adduser.8 adduser.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2007 00:45:32 -0000 mtm 2007-10-20 00:45:32 UTC FreeBSD src repository Modified files: usr.sbin/adduser adduser.8 adduser.sh Log: Allow adding a user(s) to additional groups in batch mode as well. Submitted by: Eygene Ryabinkin (modulo minor changes) MFC after: 2 weeks Revision Changes Path 1.60 +1 -1 src/usr.sbin/adduser/adduser.8 1.31 +1 -0 src/usr.sbin/adduser/adduser.sh From owner-cvs-src@FreeBSD.ORG Sat Oct 20 02:10:10 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C154116A417; Sat, 20 Oct 2007 02:10:10 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 797CC13C458; Sat, 20 Oct 2007 02:10:10 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9K2AAeD025586; Sat, 20 Oct 2007 02:10:10 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9K2AA54025585; Sat, 20 Oct 2007 02:10:10 GMT (envelope-from thompsa) Message-Id: <200710200210.l9K2AA54025585@repoman.freebsd.org> From: Andrew Thompson Date: Sat, 20 Oct 2007 02:10:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_bridge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2007 02:10:10 -0000 thompsa 2007-10-20 02:10:10 UTC FreeBSD src repository Modified files: sys/net if_bridge.c Log: Use ETHER_BPF_MTAP so that the vlan tags are visible to bpf(4) when bridging a vlan trunk. Discussed with: csjp MFC after: 3 days Revision Changes Path 1.105 +4 -4 src/sys/net/if_bridge.c From owner-cvs-src@FreeBSD.ORG Sat Oct 20 02:43:24 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 030A016A46B; Sat, 20 Oct 2007 02:43:24 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B0F2F13C481; Sat, 20 Oct 2007 02:43:23 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9K2hNIW027347; Sat, 20 Oct 2007 02:43:23 GMT (envelope-from thompsa@repoman.freebsd.org) Received: (from thompsa@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9K2hNad027346; Sat, 20 Oct 2007 02:43:23 GMT (envelope-from thompsa) Message-Id: <200710200243.l9K2hNad027346@repoman.freebsd.org> From: Andrew Thompson Date: Sat, 20 Oct 2007 02:43:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_lagg.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2007 02:43:24 -0000 thompsa 2007-10-20 02:43:23 UTC FreeBSD src repository Modified files: sys/net if_lagg.c Log: Use ETHER_BPF_MTAP so that the vlan tags are visible to bpf(4) when stacked under a vlan. MFC after: 3 days Revision Changes Path 1.21 +2 -2 src/sys/net/if_lagg.c From owner-cvs-src@FreeBSD.ORG Sat Oct 20 09:41:55 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C03C516A41B; Sat, 20 Oct 2007 09:41:55 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A28CC13C467; Sat, 20 Oct 2007 09:41:55 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9K9ftSU076908; Sat, 20 Oct 2007 09:41:55 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9K9ftSc076907; Sat, 20 Oct 2007 09:41:55 GMT (envelope-from pjd) Message-Id: <200710200941.l9K9ftSc076907@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 20 Oct 2007 09:41:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys vnode.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2007 09:41:55 -0000 pjd 2007-10-20 09:41:55 UTC FreeBSD src repository Modified files: sys/sys vnode.h Log: Remove redundant prototypes. Revision Changes Path 1.327 +0 -2 src/sys/sys/vnode.h From owner-cvs-src@FreeBSD.ORG Sat Oct 20 11:25:36 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9846D16A468; Sat, 20 Oct 2007 11:25:36 +0000 (UTC) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 32CBB13C4B0; Sat, 20 Oct 2007 11:25:34 +0000 (UTC) (envelope-from matteo@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9KBPYdL085574; Sat, 20 Oct 2007 11:25:34 GMT (envelope-from matteo@repoman.freebsd.org) Received: (from matteo@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9KBPYUl085573; Sat, 20 Oct 2007 11:25:34 GMT (envelope-from matteo) Message-Id: <200710201125.l9KBPYUl085573@repoman.freebsd.org> From: Matteo Riondato Date: Sat, 20 Oct 2007 11:25:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/mountd mountd.8 mountd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2007 11:25:36 -0000 matteo 2007-10-20 11:25:34 UTC FreeBSD src repository Modified files: usr.sbin/mountd mountd.8 mountd.c Log: Add the -h option to mountd, similar to the one in nfsd(8) -h bindip Specify specific IP addresses to bind to for TCP and UDP requests. This option may be specified multiple times. If no -h option is specified, mountd will bind to INADDR_ANY. Note that when specifying IP addresses with -h, mountd will automatically add 127.0.0.1 and if IPv6 is enabled, ::1 to the list. PR: bin/114097 Reviewed by: pjd (an eariler version of the patch) MFC after: 1 week Revision Changes Path 1.31 +19 -1 src/usr.sbin/mountd/mountd.8 1.95 +321 -159 src/usr.sbin/mountd/mountd.c From owner-cvs-src@FreeBSD.ORG Sat Oct 20 15:07:57 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A1C4416A419; Sat, 20 Oct 2007 15:07:57 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7ECFE13C459; Sat, 20 Oct 2007 15:07:57 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9KF7v1e011799; Sat, 20 Oct 2007 15:07:57 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9KF7vV1011798; Sat, 20 Oct 2007 15:07:57 GMT (envelope-from csjp) Message-Id: <200710201507.l9KF7vV1011798@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Sat, 20 Oct 2007 15:07:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/usr.bin/lockf lockf.1 lockf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2007 15:07:57 -0000 csjp 2007-10-20 15:07:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.bin/lockf lockf.1 lockf.c Log: MFC lockf.c revision 1.17 MFC lockf.1 revision 1.19 Approved by: re (kensmith) Revision Changes Path 1.18.2.1 +13 -1 src/usr.bin/lockf/lockf.1 1.16.2.1 +59 -10 src/usr.bin/lockf/lockf.c From owner-cvs-src@FreeBSD.ORG Sat Oct 20 15:09:26 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9753316A46C; Sat, 20 Oct 2007 15:09:26 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 708A613C459; Sat, 20 Oct 2007 15:09:25 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9KF9PPk011853; Sat, 20 Oct 2007 15:09:25 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9KF9PDL011852; Sat, 20 Oct 2007 15:09:25 GMT (envelope-from csjp) Message-Id: <200710201509.l9KF9PDL011852@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Sat, 20 Oct 2007 15:09:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/net bpf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2007 15:09:26 -0000 csjp 2007-10-20 15:09:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/net bpf.c Log: MFC bpf.c revision 1.182 Approved by: re@ (kensmith) Revision Changes Path 1.181.2.1 +2 -0 src/sys/net/bpf.c From owner-cvs-src@FreeBSD.ORG Sat Oct 20 15:11:01 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 462BD16A41B; Sat, 20 Oct 2007 15:11:01 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 15D8513C4A6; Sat, 20 Oct 2007 15:11:01 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9KFB0At012034; Sat, 20 Oct 2007 15:11:00 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9KFB0aJ012026; Sat, 20 Oct 2007 15:11:00 GMT (envelope-from csjp) Message-Id: <200710201511.l9KFB0aJ012026@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Sat, 20 Oct 2007 15:11:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/sys/security/audit audit_pipe.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2007 15:11:01 -0000 csjp 2007-10-20 15:11:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/security/audit audit_pipe.c Log: MFC audit_pipe.c revision 1.12 Approved by: re@ (kensmith) Revision Changes Path 1.11.2.1 +2 -2 src/sys/security/audit/audit_pipe.c From owner-cvs-src@FreeBSD.ORG Sat Oct 20 18:46:18 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2A22C16A419; Sat, 20 Oct 2007 18:46:18 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0715D13C45D; Sat, 20 Oct 2007 18:46:18 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9KIkHgY037032; Sat, 20 Oct 2007 18:46:17 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9KIkHEn037031; Sat, 20 Oct 2007 18:46:17 GMT (envelope-from ru) Message-Id: <200710201846.l9KIkHEn037031@repoman.freebsd.org> From: Ruslan Ermilov Date: Sat, 20 Oct 2007 18:46:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/mk bsd.compat.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2007 18:46:18 -0000 ru 2007-10-20 18:46:16 UTC FreeBSD src repository Modified files: share/mk bsd.compat.mk Log: Align the warning message with the one in bsd.own.mk. Revision Changes Path 1.24 +1 -1 src/share/mk/bsd.compat.mk From owner-cvs-src@FreeBSD.ORG Sat Oct 20 19:01:50 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DEB1316A420; Sat, 20 Oct 2007 19:01:50 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id CDEC213C457; Sat, 20 Oct 2007 19:01:50 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9KJ1oGl038145; Sat, 20 Oct 2007 19:01:50 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9KJ1o2W038144; Sat, 20 Oct 2007 19:01:50 GMT (envelope-from ru) Message-Id: <200710201901.l9KJ1o2W038144@repoman.freebsd.org> From: Ruslan Ermilov Date: Sat, 20 Oct 2007 19:01:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/share/mk bsd.lib.mk bsd.own.mk src/lib/libpam/modules/pam_unix Makefile src/lib/ncurses/ncurses Makefile src/usr.bin/lex/lib Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2007 19:01:51 -0000 ru 2007-10-20 19:01:50 UTC FreeBSD src repository Modified files: share/mk bsd.lib.mk bsd.own.mk lib/libpam/modules/pam_unix Makefile lib/ncurses/ncurses Makefile usr.bin/lex/lib Makefile Log: - Convert NO_INSTALLLIB option to a new syntax: makefiles should test MK_INSTALLLIB, users can set WITHOUT_INSTALLLIB. The old NO_INSTALLLIB is still supported as several makefiles set it. - While here, fix an install when instructed not to install libs (usr.bin/lex/lib/Makefile). PR: bin/114200 Submitted by: Henrik Brix Andersen Revision Changes Path 1.22 +1 -0 src/lib/libpam/modules/pam_unix/Makefile 1.93 +1 -1 src/lib/ncurses/ncurses/Makefile 1.183 +1 -1 src/share/mk/bsd.lib.mk 1.69 +2 -0 src/share/mk/bsd.own.mk 1.11 +2 -0 src/usr.bin/lex/lib/Makefile From owner-cvs-src@FreeBSD.ORG Sat Oct 20 19:10:14 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7E08B16A41B; Sat, 20 Oct 2007 19:10:14 +0000 (UTC) (envelope-from henrik@brixandersen.dk) Received: from solow.pil.dk (relay.pil.dk [195.41.47.164]) by mx1.freebsd.org (Postfix) with ESMTP id 3D37113C468; Sat, 20 Oct 2007 19:10:13 +0000 (UTC) (envelope-from henrik@brixandersen.dk) Received: from tirith.brixandersen.dk (osgiliath.brixandersen.dk [87.53.223.189]) by solow.pil.dk (Postfix) with ESMTP id AD77C1CC0E7; Sat, 20 Oct 2007 21:10:06 +0200 (CEST) Received: by tirith.brixandersen.dk (Postfix, from userid 1001) id 5647C11435; Sat, 20 Oct 2007 19:10:03 +0000 (UTC) Date: Sat, 20 Oct 2007 19:10:03 +0000 From: Henrik Brix Andersen To: Ruslan Ermilov Message-ID: <20071020191003.GB16208@tirith.brixandersen.dk> Mail-Followup-To: Ruslan Ermilov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200710201901.l9KJ1o2W038144@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+g7M9IMkV8truYOl" Content-Disposition: inline In-Reply-To: <200710201901.l9KJ1o2W038144@repoman.freebsd.org> X-PGP-Key: http://www.brixandersen.dk/files/HenrikBrixAndersen.asc User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.lib.mk bsd.own.mk src/lib/libpam/modules/pam_unix Makefile src/lib/ncurses/ncurses Makefile src/usr.bin/lex/lib Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2007 19:10:14 -0000 --+g7M9IMkV8truYOl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 20, 2007 at 07:01:50PM +0000, Ruslan Ermilov wrote: > ru 2007-10-20 19:01:50 UTC >=20 > FreeBSD src repository >=20 > Modified files: > share/mk bsd.lib.mk bsd.own.mk=20 > lib/libpam/modules/pam_unix Makefile=20 > lib/ncurses/ncurses Makefile=20 > usr.bin/lex/lib Makefile=20 > Log: > - Convert NO_INSTALLLIB option to a new syntax: makefiles should > test MK_INSTALLLIB, users can set WITHOUT_INSTALLLIB. The old > NO_INSTALLLIB is still supported as several makefiles set it. > =20 > - While here, fix an install when instructed not to install libs > (usr.bin/lex/lib/Makefile). > =20 > PR: bin/114200 > Submitted by: Henrik Brix Andersen Thank you for taking care of this - I trust this will be MFC'ed before RELENG_7_0 is branched? Regards, Brix --=20 Henrik Brix Andersen --+g7M9IMkV8truYOl Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) Comment: GnuPG signed iD8DBQFHGlKKv+Q4flTiePgRAocfAJ9Btc2G5Y8hRjh/OuyyqQ/qs8U6DgCeK2bv rLU2lMhu6H9xQ8MWWFnnkjQ= =+a8z -----END PGP SIGNATURE----- --+g7M9IMkV8truYOl-- From owner-cvs-src@FreeBSD.ORG Sat Oct 20 20:23:39 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D812016A417; Sat, 20 Oct 2007 20:23:39 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7158013C43E; Sat, 20 Oct 2007 20:23:39 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9KKNdNP045508; Sat, 20 Oct 2007 20:23:39 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9KKNd8S045507; Sat, 20 Oct 2007 20:23:39 GMT (envelope-from mlaier) Message-Id: <200710202023.l9KKNd8S045507@repoman.freebsd.org> From: Max Laier Date: Sat, 20 Oct 2007 20:23:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/contrib/libpcap pcap.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2007 20:23:40 -0000 mlaier 2007-10-20 20:23:39 UTC FreeBSD src repository Modified files: contrib/libpcap pcap.h Log: Revert back to including the whole net/bpf.h again. Requested by: sam, nork X-MFC after: now Revision Changes Path 1.14 +1 -3 src/contrib/libpcap/pcap.h From owner-cvs-src@FreeBSD.ORG Sat Oct 20 20:27:02 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A1F4016A475; Sat, 20 Oct 2007 20:27:02 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 63DF913C511; Sat, 20 Oct 2007 20:26:58 +0000 (UTC) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9KKPnqF045687; Sat, 20 Oct 2007 20:25:49 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9KKPnJ3045686; Sat, 20 Oct 2007 20:25:49 GMT (envelope-from mlaier) Message-Id: <200710202025.l9KKPnJ3045686@repoman.freebsd.org> From: Max Laier Date: Sat, 20 Oct 2007 20:25:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_7 Cc: Subject: cvs commit: src/contrib/libpcap pcap.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2007 20:27:02 -0000 mlaier 2007-10-20 20:25:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) contrib/libpcap pcap.h Log: MFC: pcap.h, 1.14 Revert back to including the whole net/bpf.h again. Approved by: re (implicit) Revision Changes Path 1.12.2.2 +1 -3 src/contrib/libpcap/pcap.h From owner-cvs-src@FreeBSD.ORG Sat Oct 20 22:18:45 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 639F516A420; Sat, 20 Oct 2007 22:18:45 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id D491C13C45B; Sat, 20 Oct 2007 22:18:43 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9KMIgOf068210; Sat, 20 Oct 2007 22:18:42 GMT (envelope-from bz@repoman.freebsd.org) Received: (from bz@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9KMIgpL068209; Sat, 20 Oct 2007 22:18:42 GMT (envelope-from bz) Message-Id: <200710202218.l9KMIgpL068209@repoman.freebsd.org> From: "Bjoern A. Zeeb" Date: Sat, 20 Oct 2007 22:18:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/i386/i386 in_cksum.c src/sys/i386/include in_cksum.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2007 22:18:45 -0000 bz 2007-10-20 22:18:42 UTC FreeBSD src repository Modified files: sys/i386/i386 in_cksum.c sys/i386/include in_cksum.h Log: Fold multiple asm statements into one so that the compiler at a certain optimization level (-march=pentium-mmx for example) does not insert intermediate ops which would trash the carry. Change both sys/i386/i386/in_cksum.c[1] and sys/i386/include/in_cksum.h. To my best understanding the same problem was addressed in rev. 1.16 of src/sys/i386/include/in_cksum.h for just a single function 3y ago. Reviewed by: jhb Submitted by: Zhouyi ZHOU (intial version of [1]) MFC after: 5 days PR: 115678, 69257 Revision Changes Path 1.29 +77 -43 src/sys/i386/i386/in_cksum.c 1.18 +14 -7 src/sys/i386/include/in_cksum.h From owner-cvs-src@FreeBSD.ORG Sat Oct 20 23:23:27 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C7BFC16A419; Sat, 20 Oct 2007 23:23:27 +0000 (UTC) (envelope-from julian@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B06D713C455; Sat, 20 Oct 2007 23:23:27 +0000 (UTC) (envelope-from julian@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l9KNNREp073805; Sat, 20 Oct 2007 23:23:27 GMT (envelope-from julian@repoman.freebsd.org) Received: (from julian@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l9KNNRPQ073804; Sat, 20 Oct 2007 23:23:27 GMT (envelope-from julian) Message-Id: <200710202323.l9KNNRPQ073804@repoman.freebsd.org> From: Julian Elischer Date: Sat, 20 Oct 2007 23:23:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/cam cam_xpt.c src/sys/compat/ndis subr_ntoskrnl.c src/sys/compat/opensolaris/sys proc.h src/sys/contrib/opensolaris/uts/common/fs/zfs vdev_geom.c zvol.c src/sys/contrib/pf/net pf.c pf_ioctl.c src/sys/dev/aac aac.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2007 23:23:27 -0000 julian 2007-10-20 23:23:23 UTC FreeBSD src repository Modified files: sys/cam cam_xpt.c sys/compat/ndis subr_ntoskrnl.c sys/compat/opensolaris/sys proc.h sys/contrib/opensolaris/uts/common/fs/zfs vdev_geom.c zvol.c sys/contrib/pf/net pf.c pf_ioctl.c sys/dev/aac aac.c sys/dev/acpica acpi_thermal.c sys/dev/aic7xxx aic_osm_lib.c aic_osm_lib.h sys/dev/bktr msp34xx.c sys/dev/ciss ciss.c sys/dev/fdc fdc.c sys/dev/firewire firewire.c sys/dev/flash at45d.c sys/dev/hptmv entry.c sys/dev/hwpmc hwpmc_logging.c sys/dev/if_ndis if_ndis.c sys/dev/ipmi ipmi_kcs.c ipmi_smic.c ipmi_ssif.c sys/dev/iscsi/initiator isc_sm.c isc_soc.c sys/dev/isp isp_freebsd.c sys/dev/iwi if_iwi.c sys/dev/md md.c sys/dev/mmc mmcsd.c sys/dev/mpt mpt.h mpt_cam.c mpt_raid.c sys/dev/ofw ofw_disk.c sys/dev/pccbb pccbb.c pccbb_pci.c sys/dev/random harvest.c randomdev_soft.c sys/dev/sound/midi sequencer.c sys/dev/usb usb.c usb_port.h sys/dev/utopia utopia.c sys/geom/bde g_bde.c g_bde_work.c sys/geom/eli g_eli.c sys/geom/journal g_journal.c sys/geom/mirror g_mirror.c sys/geom/multipath g_multipath.c sys/geom/raid3 g_raid3.c sys/geom/vinum geom_vinum_drive.c geom_vinum_init.c geom_vinum_plex.c geom_vinum_volume.c sys/i386/bios apm.c sys/kern init_main.c kern_acct.c kern_fork.c kern_idle.c kern_intr.c kern_kthread.c kern_shutdown.c subr_taskqueue.c vfs_aio.c vfs_bio.c vfs_subr.c sys/netinet sctp_bsd_addr.c sys/netsmb smb_iod.c sys/nfs4client nfs4_vfsops.c sys/nfsclient nfs_nfsiod.c sys/opencrypto crypto.c sys/security/audit audit_worker.c sys/sun4v/sun4v simdisk.c sys/sys kthread.h sys/ufs/ffs ffs_softdep.c sys/vm vm_zeroidle.c Log: Rename the kthread_xxx (e.g. kthread_create()) calls to kproc_xxx as they actually make whole processes. Thos makes way for us to add REAL kthread_create() and friends that actually make theads. it turns out that most of these calls actually end up being moved back to the thread version when it's added. but we need to make this cosmetic change first. I'd LOVE to do this rename in 7.0 so that we can eventually MFC the new kthread_xxx() calls. Revision Changes Path 1.191 +1 -1 src/sys/cam/cam_xpt.c 1.91 +6 -6 src/sys/compat/ndis/subr_ntoskrnl.c 1.3 +3 -3 src/sys/compat/opensolaris/sys/proc.h 1.5 +2 -2 src/sys/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c 1.3 +2 -2 src/sys/contrib/opensolaris/uts/common/fs/zfs/zvol.c 1.47 +1 -1 src/sys/contrib/pf/net/pf.c 1.29 +3 -3 src/sys/contrib/pf/net/pf_ioctl.c 1.122 +2 -2 src/sys/dev/aac/aac.c 1.65 +3 -3 src/sys/dev/acpica/acpi_thermal.c 1.7 +1 -1 src/sys/dev/aic7xxx/aic_osm_lib.c 1.7 +2 -2 src/sys/dev/aic7xxx/aic_osm_lib.h 1.6 +4 -4 src/sys/dev/bktr/msp34xx.c 1.84 +3 -3 src/sys/dev/ciss/ciss.c 1.318 +2 -2 src/sys/dev/fdc/fdc.c 1.101 +2 -2 src/sys/dev/firewire/firewire.c 1.2 +1 -1 src/sys/dev/flash/at45d.c 1.18 +1 -1 src/sys/dev/hptmv/entry.c 1.8 +2 -2 src/sys/dev/hwpmc/hwpmc_logging.c 1.125 +1 -1 src/sys/dev/if_ndis/if_ndis.c 1.2 +2 -2 src/sys/dev/ipmi/ipmi_kcs.c 1.5 +2 -2 src/sys/dev/ipmi/ipmi_smic.c 1.3 +2 -2 src/sys/dev/ipmi/ipmi_ssif.c 1.2 +2 -2 src/sys/dev/iscsi/initiator/isc_sm.c 1.2 +2 -2 src/sys/dev/iscsi/initiator/isc_soc.c 1.147 +2 -2 src/sys/dev/isp/isp_freebsd.c 1.58 +2 -2 src/sys/dev/iwi/if_iwi.c 1.170 +2 -2 src/sys/dev/md/md.c 1.4 +2 -2 src/sys/dev/mmc/mmcsd.c 1.43 +2 -2 src/sys/dev/mpt/mpt.h 1.63 +1 -1 src/sys/dev/mpt/mpt_cam.c 1.16 +1 -1 src/sys/dev/mpt/mpt_raid.c 1.19 +1 -1 src/sys/dev/ofw/ofw_disk.c 1.166 +3 -3 src/sys/dev/pccbb/pccbb.c 1.27 +1 -1 src/sys/dev/pccbb/pccbb_pci.c 1.26 +2 -2 src/sys/dev/random/harvest.c 1.16 +1 -1 src/sys/dev/random/randomdev_soft.c 1.27 +2 -2 src/sys/dev/sound/midi/sequencer.c 1.121 +4 -4 src/sys/dev/usb/usb.c 1.99 +3 -3 src/sys/dev/usb/usb_port.h 1.12 +2 -2 src/sys/dev/utopia/utopia.c 1.30 +1 -1 src/sys/geom/bde/g_bde.c 1.29 +1 -1 src/sys/geom/bde/g_bde_work.c 1.39 +2 -2 src/sys/geom/eli/g_eli.c 1.14 +4 -4 src/sys/geom/journal/g_journal.c 1.94 +3 -3 src/sys/geom/mirror/g_mirror.c 1.2 +2 -2 src/sys/geom/multipath/g_multipath.c 1.82 +3 -3 src/sys/geom/raid3/g_raid3.c 1.26 +3 -3 src/sys/geom/vinum/geom_vinum_drive.c 1.12 +10 -10 src/sys/geom/vinum/geom_vinum_init.c 1.18 +3 -3 src/sys/geom/vinum/geom_vinum_plex.c 1.12 +2 -2 src/sys/geom/vinum/geom_vinum_volume.c 1.148 +2 -2 src/sys/i386/bios/apm.c 1.284 +1 -1 src/sys/kern/init_main.c 1.96 +3 -3 src/sys/kern/kern_acct.c 1.283 +1 -1 src/sys/kern/kern_fork.c 1.49 +3 -3 src/sys/kern/kern_idle.c 1.148 +6 -6 src/sys/kern/kern_intr.c 1.39 +7 -7 src/sys/kern/kern_kthread.c 1.183 +1 -1 src/sys/kern/kern_shutdown.c 1.40 +4 -4 src/sys/kern/subr_taskqueue.c 1.234 +2 -2 src/sys/kern/vfs_aio.c 1.529 +1 -1 src/sys/kern/vfs_bio.c 1.708 +2 -2 src/sys/kern/vfs_subr.c 1.15 +1 -1 src/sys/netinet/sctp_bsd_addr.c 1.18 +2 -2 src/sys/netsmb/smb_iod.c 1.29 +2 -2 src/sys/nfs4client/nfs4_vfsops.c 1.92 +3 -3 src/sys/nfsclient/nfs_nfsiod.c 1.28 +3 -3 src/sys/opencrypto/crypto.c 1.17 +2 -2 src/sys/security/audit/audit_worker.c 1.3 +1 -1 src/sys/sun4v/sun4v/simdisk.c 1.9 +5 -5 src/sys/sys/kthread.h 1.212 +1 -1 src/sys/ufs/ffs/ffs_softdep.c 1.50 +1 -1 src/sys/vm/vm_zeroidle.c