From owner-freebsd-rc@FreeBSD.ORG Sun Mar 2 05:17:02 2008 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 112E9106567E for ; Sun, 2 Mar 2008 05:17:02 +0000 (UTC) (envelope-from peacock@gooseberry.webfusion.co.uk) Received: from gooseberry.webfusion.co.uk (gooseberry.webfusion.co.uk [212.67.202.192]) by mx1.freebsd.org (Postfix) with ESMTP id A080E8FC15 for ; Sun, 2 Mar 2008 05:17:01 +0000 (UTC) (envelope-from peacock@gooseberry.webfusion.co.uk) Received: from peacock by gooseberry.webfusion.co.uk with local (Exim 4.54) id 1JVg5W-0003ez-DP for freebsd-rc@hub.freebsd.org; Sun, 02 Mar 2008 04:46:14 +0000 To: freebsd-rc@hub.freebsd.org From: Mastercard UEFA Champions League Lottery Inc. MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 8bit Message-Id: Date: Sun, 02 Mar 2008 04:46:14 +0000 Cc: Subject: Mastercard UEFA Claims.. X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mastercarduefaclaims@yahoo.com.hk List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Mar 2008 05:17:02 -0000 ATTENTION: Winner The Local Organising Committee of the Mastercard sponsors and the European Champions League is glad to announce to the world the giving away of the sum of THREE HUNDRED MILLION POUNDS to 100 lucky email addresses all over the world. This promotion is in Appreciation of our International Support for the past Soccer Events and the correspondent earnings at the stock market which was far beyond our projected quarterly earnings. Be informed that all winners in this program have been selected randomly through a computer ballot system drawn from over 1,500,000 companies and individual e-mail addresses database. Your email address happened to be one of the lucky winnerS of THREE MILLION POUNDS among the One Hundred email addressess chosen. In order to claim your prize, you will have to fill out the form below and send it back to us for verification and then you will be informed on how to make claims of your Bankers Check for the sum which has already been deposited along with your email contact. It is mandatory you take note that your email address was attached to Serial Number: 889-207 and Batch Number: EU-155DB11-003/LL. We use this opportunity to thank all our Sponsors/ Contributors of this program: MASTERCARD, AIR EMIRATES, ADIDAS, NIKE, MCDONALDS, UNITED AIRLINES, BMW, VIRGIN ATLANTIC, UMBRO-SPORTLINE, FUJIFILM, AIR-ASIA, BARCLAYS, VODAFONE, NOKIA N-SERIES, LUCOZADE SPORT, AND A HOST OF EMAIL SERVICE PROVIDERS FOR ALLOWING THE USE OF THEIR DATABASE FOR THE DRAWS AND ALSO FOR THE PROVISION OF SECURE (SSL) EMAIL DELIVERY SYSTEMS. NAME:.................................................. AGE:..................................................... SEX:...................................................... ADDRESS:............................................ EMAIL:................................................. TEL.:..................................................... OCCUPATION:........................................ COUNTRY:............................................. Please you are advised to complete the form and send back to us for prompt collection. You are automatically disqualified if you are below 17 years of age. This E-mail message (including attachments, if any)is intended for the use of the individual or entity to which it is addressed and may contain Information that is privileged, proprietary, confidential and exempted from disclosure. If you are not the intended recipient, you are notified that any dissemination, distribution or copying of this communication is strictly prohibited. Congratulation once again and you are advised to send reply to your claims officer for you to be accredited for payment:CLAIMS OFFICER: MR. DOUGLAS WALKER Sincerely, Etheridge Knight. From owner-freebsd-rc@FreeBSD.ORG Mon Mar 3 11:07:15 2008 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B1EEE106567B for ; Mon, 3 Mar 2008 11:07:15 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id AB42A8FC19 for ; Mon, 3 Mar 2008 11:07:15 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m23B7FUO022172 for ; Mon, 3 Mar 2008 11:07:15 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m23B7Ea9022168 for freebsd-rc@FreeBSD.org; Mon, 3 Mar 2008 11:07:15 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 3 Mar 2008 11:07:15 GMT Message-Id: <200803031107.m23B7Ea9022168@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Mar 2008 11:07:15 -0000 Current FreeBSD problem reports Critical problems Serious problems S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/98758 rc [jail] [patch] Templatize 'jail_fstab' in /etc/rc.d/ja o conf/98846 rc [jail] [patch] Templatize 'jail_rootdir' in /etc/rc.d/ o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/118255 rc savecore never finding kernel core dumps (rcorder prob 4 problems total. Non-critical problems S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/45226 rc [patch] Fix for rc.network, ppp-user annoyance o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} f bin/65258 rc [patch] [request] save /etc/rc.firewall from changing o conf/73677 rc [patch] add support for powernow states to power_profi o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o conf/88913 rc [patch] wrapper support for rc.subr o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/103486 rc [rc.d] [jail] [patch] rc.d/jail: mount fstab after dev o conf/103489 rc [rc.d] [jail] [patch] named_chroot_autoupdate doesn't o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/105568 rc [patch] [request] Add more flexibility to rc.conf, to o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa f conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/114119 rc [jail] [patch] [request] /etc/rc.d/jail improvements f o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/118385 rc [patch] [rc] /etc/rc.d/motd doesn't work on custom sys o conf/119076 rc [patch] [rc] /etc/rc.d/netif tries to remove alias add o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119995 rc [patch] New rc.d script ddb to load ddb scripts from / o conf/120194 rc [patch] UFS volumes on ZVOLs cannot be fsck'd at boot o conf/120228 rc [zfs] [patch] Split ZFS volume startup / ease ZFS swap o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/120431 rc [patch] devfs.rules are not initialized under certain o bin/121101 rc [patch] named(8): named_chroot_autoupdate forgets prot 37 problems total. From owner-freebsd-rc@FreeBSD.ORG Wed Mar 5 18:40:05 2008 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B6E6106566B for ; Wed, 5 Mar 2008 18:40:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EF1C28FC1B for ; Wed, 5 Mar 2008 18:40:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m25Ie4Fa094660 for ; Wed, 5 Mar 2008 18:40:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m25Ie46l094659; Wed, 5 Mar 2008 18:40:04 GMT (envelope-from gnats) Date: Wed, 5 Mar 2008 18:40:04 GMT Message-Id: <200803051840.m25Ie46l094659@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: dfilter@FreeBSD.org (dfilter service) Cc: Subject: Re: conf/119995: commit references a PR X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Mar 2008 18:40:05 -0000 The following reply was made to PR conf/119995; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: conf/119995: commit references a PR Date: Wed, 5 Mar 2008 18:33:07 +0000 (UTC) brooks 2008-03-05 18:32:58 UTC FreeBSD src repository Modified files: share/man/man5 rc.conf.5 etc Makefile etc/defaults rc.conf etc/rc.d Makefile Added files: etc ddb.conf etc/rc.d ddb Log: Use the new command file feature of ddb(8) to support setting ddb(4) scripts at boot. This is currently disabled by default. /etc/ddb.conf contains some potentially reasonable default scripts. PR: conf/119995 Submitted by: Scot Hetzel (Earlier version) X-MFC after: textdumps Revision Changes Path 1.366 +1 -1 src/etc/Makefile 1.1 +15 -0 src/etc/ddb.conf (new) 1.327 +2 -0 src/etc/defaults/rc.conf 1.89 +1 -1 src/etc/rc.d/Makefile 1.1 +32 -0 src/etc/rc.d/ddb (new) 1.335 +13 -0 src/share/man/man5/rc.conf.5 _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" From owner-freebsd-rc@FreeBSD.ORG Wed Mar 5 19:00:30 2008 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4C3FD1065670; Wed, 5 Mar 2008 19:00:30 +0000 (UTC) (envelope-from brooks@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 233348FC16; Wed, 5 Mar 2008 19:00:30 +0000 (UTC) (envelope-from brooks@FreeBSD.org) Received: from freefall.freebsd.org (brooks@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m25J0UAR096431; Wed, 5 Mar 2008 19:00:30 GMT (envelope-from brooks@freefall.freebsd.org) Received: (from brooks@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m25J0TaZ096427; Wed, 5 Mar 2008 19:00:29 GMT (envelope-from brooks) Date: Wed, 5 Mar 2008 19:00:29 GMT Message-Id: <200803051900.m25J0TaZ096427@freefall.freebsd.org> To: swhetzel@gmail.com, brooks@FreeBSD.org, freebsd-rc@FreeBSD.org, brooks@FreeBSD.org From: brooks@FreeBSD.org Cc: Subject: Re: conf/119995: [patch] New rc.d script ddb to load ddb scripts from /etc/ddb.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Mar 2008 19:00:30 -0000 Synopsis: [patch] New rc.d script ddb to load ddb scripts from /etc/ddb.conf State-Changed-From-To: open->patched State-Changed-By: brooks State-Changed-When: Wed Mar 5 18:59:58 UTC 2008 State-Changed-Why: Committed to head. Responsible-Changed-From-To: freebsd-rc->brooks Responsible-Changed-By: brooks Responsible-Changed-When: Wed Mar 5 18:59:58 UTC 2008 Responsible-Changed-Why: Committed to head. http://www.freebsd.org/cgi/query-pr.cgi?pr=119995 From owner-freebsd-rc@FreeBSD.ORG Wed Mar 5 21:11:58 2008 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7CFF51065756; Wed, 5 Mar 2008 21:11:57 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 570478FC29; Wed, 5 Mar 2008 21:11:57 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (linimon@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m25LBvw7007051; Wed, 5 Mar 2008 21:11:57 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m25LBvaf007047; Wed, 5 Mar 2008 21:11:57 GMT (envelope-from linimon) Date: Wed, 5 Mar 2008 21:11:57 GMT Message-Id: <200803052111.m25LBvaf007047@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-rc@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: conf/121406: default rarpd_flags are wrong. X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Mar 2008 21:11:58 -0000 Synopsis: default rarpd_flags are wrong. Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: linimon Responsible-Changed-When: Wed Mar 5 21:11:38 UTC 2008 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=121406 From owner-freebsd-rc@FreeBSD.ORG Thu Mar 6 14:07:31 2008 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1A88E1065674; Thu, 6 Mar 2008 14:07:31 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E4E348FC29; Thu, 6 Mar 2008 14:07:30 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from freefall.freebsd.org (mtm@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m26E7UEv090415; Thu, 6 Mar 2008 14:07:30 GMT (envelope-from mtm@freefall.freebsd.org) Received: (from mtm@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m26E7UdO090411; Thu, 6 Mar 2008 14:07:30 GMT (envelope-from mtm) Date: Thu, 6 Mar 2008 14:07:30 GMT Message-Id: <200803061407.m26E7UdO090411@freefall.freebsd.org> To: trasz@FreeBSD.org, mtm@FreeBSD.org, freebsd-rc@FreeBSD.org, mtm@FreeBSD.org From: mtm@FreeBSD.org Cc: Subject: Re: conf/121406: default rarpd_flags are wrong. X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Mar 2008 14:07:31 -0000 Synopsis: default rarpd_flags are wrong. State-Changed-From-To: open->patched State-Changed-By: mtm State-Changed-When: Thu Mar 6 13:53:12 UTC 2008 State-Changed-Why: Fixed in -CURRENT. MFC in 1 week Responsible-Changed-From-To: freebsd-rc->mtm Responsible-Changed-By: mtm Responsible-Changed-When: Thu Mar 6 13:53:12 UTC 2008 Responsible-Changed-Why: Fixed in -CURRENT. MFC in 1 week http://www.freebsd.org/cgi/query-pr.cgi?pr=121406 From owner-freebsd-rc@FreeBSD.ORG Fri Mar 7 11:33:51 2008 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D510E106566C; Fri, 7 Mar 2008 11:33:50 +0000 (UTC) (envelope-from gavin@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 968128FC1C; Fri, 7 Mar 2008 11:33:50 +0000 (UTC) (envelope-from gavin@FreeBSD.org) Received: from freefall.freebsd.org (gavin@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m27BXoTu096845; Fri, 7 Mar 2008 11:33:50 GMT (envelope-from gavin@freefall.freebsd.org) Received: (from gavin@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m27BXoXH096841; Fri, 7 Mar 2008 11:33:50 GMT (envelope-from gavin) Date: Fri, 7 Mar 2008 11:33:50 GMT Message-Id: <200803071133.m27BXoXH096841@freefall.freebsd.org> To: gavin@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-rc@FreeBSD.org From: gavin@FreeBSD.org Cc: Subject: Re: conf/121452: /etc/rc.d/ppp not working as expected X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2008 11:33:52 -0000 Synopsis: /etc/rc.d/ppp not working as expected Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: gavin Responsible-Changed-When: Fri Mar 7 11:32:42 UTC 2008 Responsible-Changed-Why: Over to freebsd-rc mailing list http://www.freebsd.org/cgi/query-pr.cgi?pr=121452 From owner-freebsd-rc@FreeBSD.ORG Fri Mar 7 14:31:00 2008 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C05FE1065672; Fri, 7 Mar 2008 14:31:00 +0000 (UTC) (envelope-from vwe@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 954A48FC14; Fri, 7 Mar 2008 14:31:00 +0000 (UTC) (envelope-from vwe@FreeBSD.org) Received: from freefall.freebsd.org (vwe@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m27EV0ls013025; Fri, 7 Mar 2008 14:31:00 GMT (envelope-from vwe@freefall.freebsd.org) Received: (from vwe@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m27EV0B6013021; Fri, 7 Mar 2008 14:31:00 GMT (envelope-from vwe) Date: Fri, 7 Mar 2008 14:31:00 GMT Message-Id: <200803071431.m27EV0B6013021@freefall.freebsd.org> To: usselmann.m@icg-online.de, vwe@FreeBSD.org, freebsd-rc@FreeBSD.org From: vwe@FreeBSD.org Cc: Subject: Re: conf/121452: /etc/rc.d/ppp not working as expected X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2008 14:31:00 -0000 Synopsis: /etc/rc.d/ppp not working as expected State-Changed-From-To: open->feedback State-Changed-By: vwe State-Changed-When: Fri Mar 7 14:29:55 UTC 2008 State-Changed-Why: Manfred, I'm wondering if you can remove the dash of your ppp profile name? Rename it to "tdsl" and see, if you're still experiencing the same? http://www.freebsd.org/cgi/query-pr.cgi?pr=121452 From owner-freebsd-rc@FreeBSD.ORG Fri Mar 7 15:50:49 2008 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4EB21065671; Fri, 7 Mar 2008 15:50:49 +0000 (UTC) (envelope-from brooks@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 9A3CB8FC17; Fri, 7 Mar 2008 15:50:49 +0000 (UTC) (envelope-from brooks@FreeBSD.org) Received: from freefall.freebsd.org (brooks@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m27FonoS019552; Fri, 7 Mar 2008 15:50:49 GMT (envelope-from brooks@freefall.freebsd.org) Received: (from brooks@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m27FonUO019548; Fri, 7 Mar 2008 15:50:49 GMT (envelope-from brooks) Date: Fri, 7 Mar 2008 15:50:49 GMT Message-Id: <200803071550.m27FonUO019548@freefall.freebsd.org> To: brooks@FreeBSD.org, freebsd-rc@FreeBSD.org, brooks@FreeBSD.org From: brooks@FreeBSD.org Cc: Subject: Re: conf/121452: [patch] /etc/rc.d/ppp not working as expected X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2008 15:50:49 -0000 Old Synopsis: /etc/rc.d/ppp not working as expected New Synopsis: [patch] /etc/rc.d/ppp not working as expected Responsible-Changed-From-To: freebsd-rc->brooks Responsible-Changed-By: brooks Responsible-Changed-When: Fri Mar 7 15:50:13 UTC 2008 Responsible-Changed-Why: I've proposed a patch. http://www.freebsd.org/cgi/query-pr.cgi?pr=121452 From owner-freebsd-rc@FreeBSD.ORG Fri Mar 7 16:11:35 2008 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 806C3106567E; Fri, 7 Mar 2008 16:11:35 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 203138FC2B; Fri, 7 Mar 2008 16:11:34 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.1/8.13.8) with ESMTP id m27FnqBx045475; Fri, 7 Mar 2008 09:49:52 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.2/8.14.2/Submit) id m27FnqiJ045474; Fri, 7 Mar 2008 09:49:52 -0600 (CST) (envelope-from brooks) Date: Fri, 7 Mar 2008 09:49:52 -0600 From: Brooks Davis To: usselmann.m@icg-online.de Message-ID: <20080307154951.GB34313@lor.one-eyed-alien.net> References: <200803071133.m27BXoXH096841@freefall.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="z6Eq5LdranGa6ru8" Content-Disposition: inline In-Reply-To: <200803071133.m27BXoXH096841@freefall.freebsd.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Fri, 07 Mar 2008 09:49:52 -0600 (CST) Cc: freebsd-bugs@freebsd.org, freebsd-rc@freebsd.org Subject: Re: conf/121452: /etc/rc.d/ppp not working as expected X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2008 16:11:35 -0000 --z6Eq5LdranGa6ru8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable The following patch should allow profile name to contain ".-/+" characters as we do with interfaces. It also documents the previous undocumnted per-profile overrides of _mode and _nat which were the cause of the problem. If someone who uses ppp could test this, I'd be happy to commit it. -- Brooks Index: etc/rc.d/ppp =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/etc/rc.d/ppp,v retrieving revision 1.16 diff -u -p -r1.16 ppp --- etc/rc.d/ppp 26 Jan 2008 14:02:19 -0000 1.16 +++ etc/rc.d/ppp 7 Mar 2008 15:42:29 -0000 @@ -21,17 +21,22 @@ ppp_start_profile() local _ppp_profile _ppp_mode _ppp_nat =20 _ppp_profile=3D$1 + _ppp_profile_cleaned=3D$1 + _punct=3D". - / +" + for _punct_c in $_punct; do + _ppp_profile_cleaned=3D`ltr ${_ppp_profile_cleaned} ${_punct_c} '_'` + done =20 # Check for ppp profile mode override. # - eval _ppp_mode=3D\$ppp_${_ppp_profile}_mode + eval _ppp_mode=3D\$ppp_${_ppp_profile_cleaned}_mode if [ -z "$_ppp_mode" ]; then _ppp_mode=3D$ppp_mode fi =20 # Check for ppp profile nat override. # - eval _ppp_nat=3D\$ppp_${_ppp_profile}_nat + eval _ppp_nat=3D\$ppp_${_ppp_profile_cleaned}_nat if [ -z "$_ppp_nat" ]; then _ppp_nat=3D$ppp_nat fi Index: share/man/man5/rc.conf.5 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/share/man/man5/rc.conf.5,v retrieving revision 1.335 diff -u -p -r1.335 rc.conf.5 --- share/man/man5/rc.conf.5 5 Mar 2008 18:32:58 -0000 1.335 +++ share/man/man5/rc.conf.5 7 Mar 2008 15:42:29 -0000 @@ -1315,11 +1315,30 @@ If set to run the .Xr ppp 8 daemon. +.It Va ppp_profile +.Pq Vt str +The name of the profile to use from +.Pa /etc/ppp/ppp.conf . +Also used for per-profile overrides of +.Va ppp_mode +and +.Va ppp_nat . +When the profile name contains any of the characters +.Dq Li .-/+ +they are translated to +.Dq Li _ +for the proposes of the override variable names. .It Va ppp_mode .Pq Vt str Mode in which to run the .Xr ppp 8 daemon. +.It Va ppp_ Ns Ao Ar profile Ac Ns _mode +.Pq Vt str +Overrides the global +.Va ppp_mode +for +.Ar profile . Accepted modes are .Dq Li auto , .Dq Li ddial , @@ -1336,10 +1355,12 @@ Used in conjunction with .Va gateway_enable allows hosts on private network addresses access to the Internet using this host as a network address translating router. -.It Va ppp_profile +.It Va ppp_ Ns Ao Ar profile Ac Ns _nat .Pq Vt str -The name of the profile to use from -.Pa /etc/ppp/ppp.conf . +Overrides the global +.Va ppp_nat +for +.Ar profile . .It Va ppp_user .Pq Vt str The name of the user under which --z6Eq5LdranGa6ru8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iD8DBQFH0WQfXY6L6fI4GtQRAno7AKDUKp8JMzfetCCeIcFaHJbG5XpsVwCcCupa TGmfIAueZeE7VGPR6vR/TBk= =qnXT -----END PGP SIGNATURE----- --z6Eq5LdranGa6ru8-- From owner-freebsd-rc@FreeBSD.ORG Fri Mar 7 17:58:32 2008 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 233121065673 for ; Fri, 7 Mar 2008 17:58:32 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.152]) by mx1.freebsd.org (Postfix) with ESMTP id A0E2D8FC1D for ; Fri, 7 Mar 2008 17:58:31 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: by fg-out-1718.google.com with SMTP id 16so497849fgg.35 for ; Fri, 07 Mar 2008 09:58:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=qKj/aReG1it0H1v0P2Um6OFlXCvdtmPkWZz4F2xeBaU=; b=vp+g9qLkZfkfsRlIoK8NxW9j3Qhoew4NDyy8GVXBv3c6/ffYVK+/iZV2aTEVk6QOyfeekc56ZMgeEHzK6/ZhxN1+p6Sy2FWPuwNVyaapYL25PKXtL6yehPKF+DD+pHoqpHhDrydVmQ460zYeRZBW6Sl/x30UgYJTupbdDt4F+Ok= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=pYyfZ8xPSd4pHBCJJaHpFO8w6GFjdGJU7eSD4kxlG0R/sETI/LrCbdejFGZdcwtGyiYfgsQFuDrmEXzbzNm0vzV6ScnpSVp6fp7ZjMy1V6SWGDOV9uJ7UnrKF62Et0XgzhlIdQ+lY9KgwIO3iJ6RUphmbvSI9AvlgXU/UIEkyzI= Received: by 10.86.70.8 with SMTP id s8mr1776754fga.29.1204911246578; Fri, 07 Mar 2008 09:34:06 -0800 (PST) Received: by 10.86.23.12 with HTTP; Fri, 7 Mar 2008 09:34:06 -0800 (PST) Message-ID: Date: Fri, 7 Mar 2008 09:34:06 -0800 From: "Maksim Yevmenkin" To: "Brooks Davis" In-Reply-To: <20080307154951.GB34313@lor.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200803071133.m27BXoXH096841@freefall.freebsd.org> <20080307154951.GB34313@lor.one-eyed-alien.net> Cc: freebsd-rc@freebsd.org, freebsd-bugs@freebsd.org, usselmann.m@icg-online.de Subject: Re: conf/121452: /etc/rc.d/ppp not working as expected X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2008 17:58:32 -0000 On Fri, Mar 7, 2008 at 7:49 AM, Brooks Davis wrote: > The following patch should allow profile name to contain ".-/+" characters > as we do with interfaces. It also documents the previous undocumnted > per-profile overrides of _mode and _nat which were the cause of the problem. > If someone who uses ppp could test this, I'd be happy to commit it. i'm not so sure about this one. if i have "t-dsl" as a profile name, i will not be able to specify any overrides for this profile, because shell won't let me have "ppp_t-dsl_mode" and/or "ppp_t-dsl_nat" variable. so, the translation here is not really needed, imo, and, perhaps, could even be considered harmful. perhaps we should do one of the following 1) demand that ppp profile names should be "shell clean" and document it or 2) if a ppp profile name is not "shell clean" simply do not evaluate profile overrides and use defaults thanks, max From owner-freebsd-rc@FreeBSD.ORG Fri Mar 7 18:09:08 2008 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D02AB1065675; Fri, 7 Mar 2008 18:09:08 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 59DE38FC23; Fri, 7 Mar 2008 18:09:08 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.1/8.13.8) with ESMTP id m27I97dt047055; Fri, 7 Mar 2008 12:09:07 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.2/8.14.2/Submit) id m27I97tb047054; Fri, 7 Mar 2008 12:09:07 -0600 (CST) (envelope-from brooks) Date: Fri, 7 Mar 2008 12:09:07 -0600 From: Brooks Davis To: Maksim Yevmenkin Message-ID: <20080307180907.GA45978@lor.one-eyed-alien.net> References: <200803071133.m27BXoXH096841@freefall.freebsd.org> <20080307154951.GB34313@lor.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LZvS9be/3tNcYl/X" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Fri, 07 Mar 2008 12:09:07 -0600 (CST) Cc: usselmann.m@icg-online.de, freebsd-bugs@freebsd.org, Brooks Davis , freebsd-rc@freebsd.org Subject: Re: conf/121452: /etc/rc.d/ppp not working as expected X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2008 18:09:09 -0000 --LZvS9be/3tNcYl/X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 07, 2008 at 09:34:06AM -0800, Maksim Yevmenkin wrote: > On Fri, Mar 7, 2008 at 7:49 AM, Brooks Davis wrote: > > The following patch should allow profile name to contain ".-/+" charact= ers > > as we do with interfaces. It also documents the previous undocumnted > > per-profile overrides of _mode and _nat which were the cause of the pr= oblem. > > If someone who uses ppp could test this, I'd be happy to commit it. >=20 > i'm not so sure about this one. if i have "t-dsl" as a profile name, i > will not be able to specify any overrides for this profile, because > shell won't let me have "ppp_t-dsl_mode" and/or "ppp_t-dsl_nat" > variable. so, the translation here is not really needed, imo, and, > perhaps, could even be considered harmful. perhaps we should do one of > the following The point of the patch is to change all ".-/+" characters to _ which means the variable will be ppp_t_dsl_(mode|nat) so you can use the profile overrides. It's an exact copy of the code we use for interface variables. > 1) demand that ppp profile names should be "shell clean" and document it >=20 > or >=20 > 2) if a ppp profile name is not "shell clean" simply do not evaluate > profile overrides and use defaults I'm opposed to 2. I'd be OK with 1, but think folding common punctuation into _ may be a better option given that we're already doing it elsewhere. -- Brooks --LZvS9be/3tNcYl/X Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iD8DBQFH0YTCXY6L6fI4GtQRApyRAKDQsykd9iQlm0w2tMdm5GZ/bcFxEgCffJ2d UzuNqSrX7227kKBmTthmqY8= =2EgV -----END PGP SIGNATURE----- --LZvS9be/3tNcYl/X-- From owner-freebsd-rc@FreeBSD.ORG Fri Mar 7 18:43:28 2008 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 77E491065678 for ; Fri, 7 Mar 2008 18:43:28 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.156]) by mx1.freebsd.org (Postfix) with ESMTP id EBAB38FC2F for ; Fri, 7 Mar 2008 18:43:27 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: by fg-out-1718.google.com with SMTP id 16so510675fgg.35 for ; Fri, 07 Mar 2008 10:43:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=3dGuM4BNlnNgP086uAKIrlkDA/U0YkeJ9FAjiTlXkQs=; b=h1HrPpnul0PoGqW77ZYZEZIQmNwZG1VIuetN+KR5d1VEDJIU9b9Ut6OBgtuZW0e4VLU6OKlNF0lBK9Zc2GLmHF5ntUqMRlpXQz4y/3nDvCFlPXfBP51cbZ9R7UtSrCdPMU1FeO8oysgH8xCB2Ew57BLOdzqoqPo8RiH39UPHrDc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=jhZw6sNCGJIOBkKx9nJfU3nhWJNBO3CAJOb7HsM0+svXOSYdq/7XVTwGl7thAiHxxLjd1s2BPvJ7WWgiU6GOYvbZobZ1Gk6VE+11JcPYWbvPj9eHkugCIkUA8gQbgIH2TCBZ+C7H8+2vProRbvCeaRrLpN3rL0+dCU7XKq17uvQ= Received: by 10.86.28.5 with SMTP id b5mr1847328fgb.47.1204915406499; Fri, 07 Mar 2008 10:43:26 -0800 (PST) Received: by 10.86.23.12 with HTTP; Fri, 7 Mar 2008 10:43:26 -0800 (PST) Message-ID: Date: Fri, 7 Mar 2008 10:43:26 -0800 From: "Maksim Yevmenkin" To: "Brooks Davis" In-Reply-To: <20080307180907.GA45978@lor.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200803071133.m27BXoXH096841@freefall.freebsd.org> <20080307154951.GB34313@lor.one-eyed-alien.net> <20080307180907.GA45978@lor.one-eyed-alien.net> Cc: usselmann.m@icg-online.de, freebsd-bugs@freebsd.org, freebsd-rc@freebsd.org Subject: Re: conf/121452: /etc/rc.d/ppp not working as expected X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2008 18:43:28 -0000 On Fri, Mar 7, 2008 at 10:09 AM, Brooks Davis wrote: > On Fri, Mar 07, 2008 at 09:34:06AM -0800, Maksim Yevmenkin wrote: > > On Fri, Mar 7, 2008 at 7:49 AM, Brooks Davis wrote: > > > The following patch should allow profile name to contain ".-/+" characters > > > as we do with interfaces. It also documents the previous undocumnted > > > per-profile overrides of _mode and _nat which were the cause of the problem. > > > If someone who uses ppp could test this, I'd be happy to commit it. > > > > i'm not so sure about this one. if i have "t-dsl" as a profile name, i > > will not be able to specify any overrides for this profile, because > > shell won't let me have "ppp_t-dsl_mode" and/or "ppp_t-dsl_nat" > > variable. so, the translation here is not really needed, imo, and, > > perhaps, could even be considered harmful. perhaps we should do one of > > the following > > The point of the patch is to change all ".-/+" characters to _ which > means the variable will be ppp_t_dsl_(mode|nat) so you can use the > profile overrides. It's an exact copy of the code we use for interface > variables. i get that. what i was trying to say is that overrides for the "t-dsl" profile (with hyphen) are now, obviously, "ppp_t_dsl_mode" and/or "ppp_t_dsl_nat". to me, it is somewhat confusing. another (pretty weak :) argument is that all ".-/+" characters are mapped onto single "_" character. this could potentially create a collision in variable names. i realize that you have done exactly the same thing as in get_if_var() in network.subr. are there any examples of network interface variable names that are not "shell clean"? > > 1) demand that ppp profile names should be "shell clean" and document it > > > > or > > > > 2) if a ppp profile name is not "shell clean" simply do not evaluate > > profile overrides and use defaults > > I'm opposed to 2. I'd be OK with 1, but think folding common > punctuation into _ may be a better option given that we're already doing > it elsewhere. i'm still not sure :) however, please do not take it as an objection :) since we already have similar code (and no one, including me, complained :), it probably makes more sense to do the same here. thanks, max From owner-freebsd-rc@FreeBSD.ORG Fri Mar 7 19:41:07 2008 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BBC551065677; Fri, 7 Mar 2008 19:41:07 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 635418FC29; Fri, 7 Mar 2008 19:41:07 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.1/8.13.8) with ESMTP id m27Jf6CW048022; Fri, 7 Mar 2008 13:41:06 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.2/8.14.2/Submit) id m27Jf6pL048021; Fri, 7 Mar 2008 13:41:06 -0600 (CST) (envelope-from brooks) Date: Fri, 7 Mar 2008 13:41:06 -0600 From: Brooks Davis To: Maksim Yevmenkin Message-ID: <20080307194106.GA47910@lor.one-eyed-alien.net> References: <200803071133.m27BXoXH096841@freefall.freebsd.org> <20080307154951.GB34313@lor.one-eyed-alien.net> <20080307180907.GA45978@lor.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HcAYCG3uE/tztfnV" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Fri, 07 Mar 2008 13:41:06 -0600 (CST) Cc: usselmann.m@icg-online.de, freebsd-bugs@freebsd.org, Brooks Davis , freebsd-rc@freebsd.org Subject: Re: conf/121452: /etc/rc.d/ppp not working as expected X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2008 19:41:08 -0000 --HcAYCG3uE/tztfnV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 07, 2008 at 10:43:26AM -0800, Maksim Yevmenkin wrote: > On Fri, Mar 7, 2008 at 10:09 AM, Brooks Davis wrote: > > On Fri, Mar 07, 2008 at 09:34:06AM -0800, Maksim Yevmenkin wrote: > > > On Fri, Mar 7, 2008 at 7:49 AM, Brooks Davis wr= ote: > > > > The following patch should allow profile name to contain ".-/+" ch= aracters > > > > as we do with interfaces. It also documents the previous undocum= nted > > > > per-profile overrides of _mode and _nat which were the cause of t= he problem. > > > > If someone who uses ppp could test this, I'd be happy to commit i= t. > > > > > > i'm not so sure about this one. if i have "t-dsl" as a profile name,= i > > > will not be able to specify any overrides for this profile, because > > > shell won't let me have "ppp_t-dsl_mode" and/or "ppp_t-dsl_nat" > > > variable. so, the translation here is not really needed, imo, and, > > > perhaps, could even be considered harmful. perhaps we should do one = of > > > the following > > > > The point of the patch is to change all ".-/+" characters to _ which > > means the variable will be ppp_t_dsl_(mode|nat) so you can use the > > profile overrides. It's an exact copy of the code we use for interface > > variables. >=20 > i get that. what i was trying to say is that overrides for the "t-dsl" > profile (with hyphen) are now, obviously, "ppp_t_dsl_mode" and/or > "ppp_t_dsl_nat". to me, it is somewhat confusing. another (pretty > weak :) argument is that all ".-/+" characters are mapped onto single > "_" character. this could potentially create a collision in variable > names. i realize that you have done exactly the same thing as in > get_if_var() in network.subr. are there any examples of network > interface variable names that are not "shell clean"? When I added the functionality it was to handle '.', but I figured I'd add other common separators at the same time and figured collisions aren't likely. For other variables there may be argument for rejecting values that aren't shell clean, but it's not clear to me how to write such a shell function. If someone could figure that out it would make a good addition to rc.subr and I wouldn't mind taking that approach here. I just figured that we've got precedent for the other approach. -- Brooks > > > 1) demand that ppp profile names should be "shell clean" and documen= t it > > > > > > or > > > > > > 2) if a ppp profile name is not "shell clean" simply do not evaluate > > > profile overrides and use defaults > > > > I'm opposed to 2. I'd be OK with 1, but think folding common > > punctuation into _ may be a better option given that we're already doi= ng > > it elsewhere. >=20 > i'm still not sure :) however, please do not take it as an objection > :) since we already have similar code (and no one, including me, > complained :), it probably makes more sense to do the same here. >=20 > thanks, > max >=20 --HcAYCG3uE/tztfnV Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iD8DBQFH0ZpRXY6L6fI4GtQRAkLdAKDN1RritxuB1Ivd1lvsO0DMhX8Q6QCg1Cnt BpByTzcoh+MIDZxUkKddDOU= =FKZT -----END PGP SIGNATURE----- --HcAYCG3uE/tztfnV-- From owner-freebsd-rc@FreeBSD.ORG Sat Mar 8 00:31:43 2008 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 636AC106566B; Sat, 8 Mar 2008 00:31:43 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.delphij.net (delphij-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:2c9::2]) by mx1.freebsd.org (Postfix) with ESMTP id E8BB68FC1A; Sat, 8 Mar 2008 00:31:42 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [202.108.54.204]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.delphij.net (Postfix) with ESMTPS id D737A28458; Sat, 8 Mar 2008 08:31:41 +0800 (CST) Received: from localhost (tarsier.geekcn.org [202.108.54.204]) by tarsier.geekcn.org (Postfix) with ESMTP id 840B7EB2209; Sat, 8 Mar 2008 08:31:41 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([202.108.54.204]) by localhost (mail.geekcn.org [202.108.54.204]) (amavisd-new, port 10024) with ESMTP id yypYQIN93tFX; Sat, 8 Mar 2008 08:31:36 +0800 (CST) Received: from charlie.delphij.net (71.5.7.139.ptr.us.xo.net [71.5.7.139]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id 77C58EB1CB5; Sat, 8 Mar 2008 08:31:34 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:subject:x-enigmail-version:openpgp:content-type; b=q849YKxfpIPXJsnfbWVYSF528Hq4G9kG5wO0RpGVQ6CW7ilfhqY0ifkFRnNJkSVl0 hMdG61YxbxDdGpnHxr0Ww== Message-ID: <47D1DE64.20405@delphij.net> Date: Fri, 07 Mar 2008 16:31:32 -0800 From: Xin LI Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.12 (X11/20080303) MIME-Version: 1.0 To: freebsd-rc@FreeBSD.org, mtm@FreeBSD.org X-Enigmail-Version: 0.95.6 OpenPGP: id=18EDEBA0; url=http://www.delphij.net/delphij.asc Content-Type: multipart/mixed; boundary="------------070004040207080402080502" Cc: Subject: [RFC] Split nextboot deletion from /etc/rc.d/root X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Mar 2008 00:31:43 -0000 This is a multi-part message in MIME format. --------------070004040207080402080502 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi, Here is a patch that moves the nextboot deletion from /etc/rc.d/root to a new script which would be fired after mountlate. The reason behind this is that /boot is not necessarily part of the /, and doing nextboot -D would give an error if /boot is not mounted (i.e. in a typical setup of ZFS root). Objections? Cheers, -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! --------------070004040207080402080502 Content-Type: text/plain; name="patch-nextboot-split.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="patch-nextboot-split.diff" Index: Makefile =================================================================== RCS file: /home/ncvs/src/etc/rc.d/Makefile,v retrieving revision 1.89 diff -u -p -r1.89 Makefile --- Makefile 5 Mar 2008 18:32:58 -0000 1.89 +++ Makefile 8 Mar 2008 00:14:00 -0000 @@ -23,7 +23,7 @@ FILES= DAEMON FILESYSTEMS LOGIN NETWORKI mixer motd mountcritlocal mountcritremote mountlate \ mdconfig mdconfig2 mountd moused mroute6d mrouted msgs \ named natd netif netoptions \ - network_ipv6 newsyslog nfsclient nfsd \ + network_ipv6 newsyslog nextboot nfsclient nfsd \ nfsserver nisdomain nsswitch ntpd ntpdate \ othermta \ pf pflog pfsync \ Index: root =================================================================== RCS file: /home/ncvs/src/etc/rc.d/root,v retrieving revision 1.16 diff -u -p -r1.16 root --- root 8 Dec 2007 07:20:22 -0000 1.16 +++ root 8 Mar 2008 00:13:42 -0000 @@ -30,12 +30,6 @@ root_start() esac umount -a >/dev/null 2>&1 - - # If we booted a special kernel remove the record - # so we will boot the default kernel next time. - if [ -x /sbin/nextboot ]; then - /sbin/nextboot -D - fi } load_rc_config $name Index: nextboot =================================================================== RCS file: nextboot diff -N nextboot --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ nextboot 8 Mar 2008 00:14:21 -0000 @@ -0,0 +1,26 @@ +#!/bin/sh +# +# $FreeBSD$ +# + +# PROVIDE: nextboot +# REQUIRE: mountlate +# KEYWORD: nojail + +. /etc/rc.subr + +name="nextboot" +start_cmd="nextboot_start" +stop_cmd=":" + +nextboot_start() +{ + # If we booted a special kernel remove the record + # so we will boot the default kernel next time. + if [ -x /sbin/nextboot ]; then + /sbin/nextboot -D + fi +} + +load_rc_config $name +run_rc_command "$1" --------------070004040207080402080502-- From owner-freebsd-rc@FreeBSD.ORG Sat Mar 8 09:55:09 2008 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8A2E7106566B; Sat, 8 Mar 2008 09:55:09 +0000 (UTC) (envelope-from usselmann.m@icg-online.de) Received: from bravo579.server4you.de (bravo579.server4you.de [85.25.132.33]) by mx1.freebsd.org (Postfix) with ESMTP id 49BB08FC14; Sat, 8 Mar 2008 09:55:09 +0000 (UTC) (envelope-from usselmann.m@icg-online.de) Received: from p54b249d5.dip.t-dialin.net ([84.178.73.213] helo=localhost) by bravo579.server4you.de with esmtpa (Exim 4.50) id 1JXvNH-0007vx-GV; Sat, 08 Mar 2008 10:29:51 +0100 Date: Sat, 8 Mar 2008 10:29:49 +0100 From: Manfred Usselmann To: vwe@FreeBSD.org Message-Id: <20080308102949.d3428f4b.usselmann.m@icg-online.de> In-Reply-To: <200803071431.m27EV0B6013021@freefall.freebsd.org> References: <200803071431.m27EV0B6013021@freefall.freebsd.org> Organization: ICG IT Consulting GmbH X-Mailer: Sylpheed 2.4.5 (GTK+ 2.12.0; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: freebsd-rc@FreeBSD.org, bug-followup@FreeBSD.org Subject: Re: conf/121452: /etc/rc.d/ppp not working as expected X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Mar 2008 09:55:09 -0000 vwe@FreeBSD.org schrieb am Fri, 7 Mar 2008 14:31:00 GMT: > Synopsis: /etc/rc.d/ppp not working as expected > > State-Changed-From-To: open->feedback > State-Changed-By: vwe > State-Changed-When: Fri Mar 7 14:29:55 UTC 2008 > State-Changed-Why: > > Manfred, > I'm wondering if you can remove the dash of your ppp profile name? > Rename it to "tdsl" and see, if you're still experiencing the same? > > http://www.freebsd.org/cgi/query-pr.cgi?pr=121452 By renaming the profile from t-dsl to tdsl the problem disappears. Manfred -- ________________________________________________________________________ Manfred Usselmann usselmann.m@icg-online.de From owner-freebsd-rc@FreeBSD.ORG Sat Mar 8 10:30:49 2008 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 252721065675 for ; Sat, 8 Mar 2008 10:30:49 +0000 (UTC) (envelope-from usselmann.m@icg-online.de) Received: from bravo579.server4you.de (bravo579.server4you.de [85.25.132.33]) by mx1.freebsd.org (Postfix) with ESMTP id 9761E8FC18 for ; Sat, 8 Mar 2008 10:30:48 +0000 (UTC) (envelope-from usselmann.m@icg-online.de) Received: from p54b249d5.dip.t-dialin.net ([84.178.73.213] helo=localhost) by bravo579.server4you.de with esmtpa (Exim 4.50) id 1JXwK4-0001tw-I6; Sat, 08 Mar 2008 11:30:36 +0100 Date: Sat, 8 Mar 2008 11:30:35 +0100 From: Manfred Usselmann To: Brooks Davis Message-Id: <20080308113035.186b4a48.usselmann.m@icg-online.de> In-Reply-To: <20080307194106.GA47910@lor.one-eyed-alien.net> References: <200803071133.m27BXoXH096841@freefall.freebsd.org> <20080307154951.GB34313@lor.one-eyed-alien.net> <20080307180907.GA45978@lor.one-eyed-alien.net> <20080307194106.GA47910@lor.one-eyed-alien.net> Organization: ICG IT Consulting GmbH X-Mailer: Sylpheed 2.4.5 (GTK+ 2.12.0; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: freebsd-bugs@freebsd.org, freebsd-rc@freebsd.org, Roland Scheller Subject: Re: conf/121452: /etc/rc.d/ppp not working as expected X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Mar 2008 10:30:49 -0000 Brooks Davis schrieb am Fri, 7 Mar 2008 13:41:06 -0600: > On Fri, Mar 07, 2008 at 10:43:26AM -0800, Maksim Yevmenkin wrote: > > On Fri, Mar 7, 2008 at 10:09 AM, Brooks Davis > > wrote: > > > On Fri, Mar 07, 2008 at 09:34:06AM -0800, Maksim Yevmenkin wrote: > > > > On Fri, Mar 7, 2008 at 7:49 AM, Brooks Davis > > > > wrote: > > > > > The following patch should allow profile name to contain > > > > > ".-/+" characters as we do with interfaces. It also > > > > > documents the previous undocumnted per-profile overrides of > > > > > _mode and _nat which were the cause of the problem. If > > > > > someone who uses ppp could test this, I'd be happy to commit > > > > > it. I could test that it is working in my case with 't-dsl'. But a complete test would of course involve multiple profiles with mode overrides. Not sure how to test this with the one ISP I'm using. > > > > > > > > i'm not so sure about this one. if i have "t-dsl" as a profile > > > > name, i will not be able to specify any overrides for this > > > > profile, because shell won't let me have "ppp_t-dsl_mode" > > > > and/or "ppp_t-dsl_nat" variable. The questions is would I want to. I took t-dsl as profile name because this is the name of the product I'm using (from German Telekom). I'm using this name since 4.x times and I believe it was used in an example still linked from the handbook http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/pppoe.html "Nutzung von T-DSL und T-Online mit FreeBSD by Udo Erdelhoff (in German)." The links seems to be no longer available though. Anyhow I was not aware that something was wrong with this name and I was not even aware that it is possible to use multiple profiles in rc.conf and overrides per profile. Most probably most people are not aware of this. Even 'man rc.conf' doesn't mention that possibility! The only way I became aware of it was when I couldn't access our box via ssh from a customer because the automatic redial had failed. After some investigation I noticed that /usr/sbin/ppp was running with -auto instead of -ddial as specified in rc.conf. OK, I simply restarted ppp with the correct parameter and was very surprised a few days later when the problem reoccured. > > > > so, the translation here is > > > > not really needed, imo, The translation is needed to make the script work again for the standard case (only ppp_mode is used) and thereby provide backwards compatibility. > > > > and, perhaps, could even be considered > > > > harmful. perhaps we should do one of the following > > > > > > The point of the patch is to change all ".-/+" characters to _ > > > which means the variable will be ppp_t_dsl_(mode|nat) so you can > > > use the profile overrides. Well, if you want to use the new functionality (the overrides) you should probably use a more suitable profile name. IMO the main point of the patch is to make it work for the standard case as well. Currently as a side effect of the added flexibility ppp_mode and ppp_nat are no longer working. They are silently ignored, if you use something like t-dsl as profile name what was perfectly possible for many years. > > > It's an exact copy of the code we use > > > for interface variables. > > > > i get that. what i was trying to say is that overrides for the > > "t-dsl" profile (with hyphen) are now, obviously, "ppp_t_dsl_mode" > > and/or "ppp_t_dsl_nat". to me, it is somewhat confusing. another > > (pretty weak :) argument is that all ".-/+" characters are mapped > > onto single "_" character. this could potentially create a > > collision in variable names. i realize that you have done exactly > > the same thing as in get_if_var() in network.subr. are there any > > examples of network interface variable names that are not "shell > > clean"? > > When I added the functionality it was to handle '.', but I figured I'd > add other common separators at the same time and figured collisions > aren't likely. For other variables there may be argument for > rejecting values that aren't shell clean, but it's not clear to me > how to write such a shell function. If someone could figure that out > it would make a good addition to rc.subr and I wouldn't mind taking > that approach here. I just figured that we've got precedent for the > other approach. > > -- Brooks > > > > > 1) demand that ppp profile names should be "shell clean" and > > > > document it This could break old configurations because profile names valid until now would become invalid. > > > > > > > > or > > > > > > > > 2) if a ppp profile name is not "shell clean" simply do not > > > > evaluate profile overrides and use defaults Yes, I believe it is a fair assumption that somebody using a "wrong" profile name is not aware of the overrides and doesn't want to use them. This would be ok for me since the overrides are pretty new, not "shell clean" ppp profiles have anyhow never worked with overrides and someone adopting this new functionality will probably test it and notice the problem. But it should be documented that shell clean names are needed for overrides to work. > > > I'm opposed to 2. I'd be OK with 1, but think folding common > > > punctuation into _ may be a better option given that we're > > > already doing it elsewhere. I believe this is a valid point. If it is not appropriate here it should probably changed at the other place as well. But I believe that folding common punctuation into _ is a good workaround because not everybody running a FreeBSD system is an expert in shell scripting and aware of the fact that a ppp profile name now needs to be "shell clean" and what exactly this means... On the other hand somebody who wants to use the overrides needs to delve into the problem a bit more and will see the relationship between profile name and variable names for the mode and nat overrides. > > i'm still not sure :) however, please do not take it as an objection > > :) since we already have similar code (and no one, including me, > > complained :), it probably makes more sense to do the same here. > > > > thanks, > > max > > Regards, Manfred -- ________________________________________________________________________ Manfred Usselmann usselmann.m@icg-online.de From owner-freebsd-rc@FreeBSD.ORG Sat Mar 8 15:29:49 2008 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C5B5F106566C; Sat, 8 Mar 2008 15:29:49 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 521188FC13; Sat, 8 Mar 2008 15:29:49 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.1/8.13.8) with ESMTP id m28FTmA8058906; Sat, 8 Mar 2008 09:29:48 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.2/8.14.2/Submit) id m28FTlOM058905; Sat, 8 Mar 2008 09:29:48 -0600 (CST) (envelope-from brooks) Date: Sat, 8 Mar 2008 09:29:47 -0600 From: Brooks Davis To: Manfred Usselmann Message-ID: <20080308152947.GA58790@lor.one-eyed-alien.net> References: <200803071133.m27BXoXH096841@freefall.freebsd.org> <20080307154951.GB34313@lor.one-eyed-alien.net> <20080307180907.GA45978@lor.one-eyed-alien.net> <20080307194106.GA47910@lor.one-eyed-alien.net> <20080308113035.186b4a48.usselmann.m@icg-online.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jI8keyz6grp/JLjh" Content-Disposition: inline In-Reply-To: <20080308113035.186b4a48.usselmann.m@icg-online.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Sat, 08 Mar 2008 09:29:48 -0600 (CST) Cc: freebsd-bugs@freebsd.org, Brooks Davis , freebsd-rc@freebsd.org, Roland Scheller Subject: Re: conf/121452: /etc/rc.d/ppp not working as expected X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Mar 2008 15:29:49 -0000 --jI8keyz6grp/JLjh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 08, 2008 at 11:30:35AM +0100, Manfred Usselmann wrote: > Brooks Davis schrieb am Fri, 7 Mar 2008 13:41:06 > -0600: >=20 > > On Fri, Mar 07, 2008 at 10:43:26AM -0800, Maksim Yevmenkin wrote: > > > On Fri, Mar 7, 2008 at 10:09 AM, Brooks Davis > > > wrote: > > > > On Fri, Mar 07, 2008 at 09:34:06AM -0800, Maksim Yevmenkin wrote: > > > > > On Fri, Mar 7, 2008 at 7:49 AM, Brooks Davis > > > > > wrote: > > > > > > The following patch should allow profile name to contain > > > > > > ".-/+" characters as we do with interfaces. It also > > > > > > documents the previous undocumnted per-profile overrides of > > > > > > _mode and _nat which were the cause of the problem. If > > > > > > someone who uses ppp could test this, I'd be happy to commit > > > > > > it. >=20 > I could test that it is working in my case with 't-dsl'. But a complete > test would of course involve multiple profiles with mode overrides. Not > sure how to test this with the one ISP I'm using. I don't need a complete test. Just a quick sanity check that I didn't totally break the script. I'm fairly confident that I got the change right= and I know the basics are correct. -- Brooks --jI8keyz6grp/JLjh Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iD8DBQFH0rDqXY6L6fI4GtQRAuGFAKCagUiqwjkkpLJAObq1BxUKC2GBZQCeN7kF Z0GU/XJZbch7eKMvkHVQk5I= =8p0i -----END PGP SIGNATURE----- --jI8keyz6grp/JLjh-- From owner-freebsd-rc@FreeBSD.ORG Sat Mar 8 15:38:06 2008 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6F6441065675 for ; Sat, 8 Mar 2008 15:38:06 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 17CA48FC1A for ; Sat, 8 Mar 2008 15:38:05 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.1/8.13.8) with ESMTP id m28FblHx058970; Sat, 8 Mar 2008 09:37:47 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.2/8.14.2/Submit) id m28FbkVX058969; Sat, 8 Mar 2008 09:37:46 -0600 (CST) (envelope-from brooks) Date: Sat, 8 Mar 2008 09:37:46 -0600 From: Brooks Davis To: d@delphij.net Message-ID: <20080308153746.GB58790@lor.one-eyed-alien.net> References: <47D1DE64.20405@delphij.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZoaI/ZTpAVc4A5k6" Content-Disposition: inline In-Reply-To: <47D1DE64.20405@delphij.net> User-Agent: Mutt/1.5.17 (2007-11-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Sat, 08 Mar 2008 09:37:47 -0600 (CST) Cc: mtm@freebsd.org, freebsd-rc@freebsd.org Subject: Re: [RFC] Split nextboot deletion from /etc/rc.d/root X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Mar 2008 15:38:06 -0000 --ZoaI/ZTpAVc4A5k6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 07, 2008 at 04:31:32PM -0800, Xin LI wrote: > Hi, >=20 > Here is a patch that moves the nextboot deletion from /etc/rc.d/root to a= =20 > new script which would be fired after mountlate. The reason behind this = is=20 > that /boot is not necessarily part of the /, and doing nextboot -D would= =20 > give an error if /boot is not mounted (i.e. in a typical setup of ZFS=20 > root). >=20 > Objections? This seems somewhat risky in that delaying removal of the nextboot file mea= ns crashes under moderate load (like running rc.d) will be harder to recover f= rom. What about doing it both places? -- Brooks > Cheers, > --=20 > Xin LI http://www.delphij.net/ > FreeBSD - The Power to Serve! > Index: Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/ncvs/src/etc/rc.d/Makefile,v > retrieving revision 1.89 > diff -u -p -r1.89 Makefile > --- Makefile 5 Mar 2008 18:32:58 -0000 1.89 > +++ Makefile 8 Mar 2008 00:14:00 -0000 > @@ -23,7 +23,7 @@ FILES=3D DAEMON FILESYSTEMS LOGIN NETWORKI > mixer motd mountcritlocal mountcritremote mountlate \ > mdconfig mdconfig2 mountd moused mroute6d mrouted msgs \ > named natd netif netoptions \ > - network_ipv6 newsyslog nfsclient nfsd \ > + network_ipv6 newsyslog nextboot nfsclient nfsd \ > nfsserver nisdomain nsswitch ntpd ntpdate \ > othermta \ > pf pflog pfsync \ > Index: root > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/ncvs/src/etc/rc.d/root,v > retrieving revision 1.16 > diff -u -p -r1.16 root > --- root 8 Dec 2007 07:20:22 -0000 1.16 > +++ root 8 Mar 2008 00:13:42 -0000 > @@ -30,12 +30,6 @@ root_start() > esac > =20 > umount -a >/dev/null 2>&1 > - > - # If we booted a special kernel remove the record > - # so we will boot the default kernel next time. > - if [ -x /sbin/nextboot ]; then > - /sbin/nextboot -D > - fi > } > =20 > load_rc_config $name > Index: nextboot > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: nextboot > diff -N nextboot > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ nextboot 8 Mar 2008 00:14:21 -0000 > @@ -0,0 +1,26 @@ > +#!/bin/sh > +# > +# $FreeBSD$ > +# > + > +# PROVIDE: nextboot > +# REQUIRE: mountlate > +# KEYWORD: nojail > + > +. /etc/rc.subr > + > +name=3D"nextboot" > +start_cmd=3D"nextboot_start" > +stop_cmd=3D":" > + > +nextboot_start() > +{ > + # If we booted a special kernel remove the record > + # so we will boot the default kernel next time. > + if [ -x /sbin/nextboot ]; then > + /sbin/nextboot -D > + fi > +} > + > +load_rc_config $name > +run_rc_command "$1" > _______________________________________________ > freebsd-rc@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-rc > To unsubscribe, send any mail to "freebsd-rc-unsubscribe@freebsd.org" --ZoaI/ZTpAVc4A5k6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iD8DBQFH0rLKXY6L6fI4GtQRAmNUAKCd4OuiB5/bLQMZMTi+T1zVZGINKQCgyZvo H4UNagZb61CJ6vBXj5UGKUo= =3WFX -----END PGP SIGNATURE----- --ZoaI/ZTpAVc4A5k6--