From owner-p4-projects@FreeBSD.ORG  Sun Dec  7 00:26:34 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 0DD251065675; Sun,  7 Dec 2008 00:26:34 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C5D891065672
	for <perforce@freebsd.org>; Sun,  7 Dec 2008 00:26:33 +0000 (UTC)
	(envelope-from zec@icir.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id B4BB58FC13
	for <perforce@freebsd.org>; Sun,  7 Dec 2008 00:26:33 +0000 (UTC)
	(envelope-from zec@icir.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id mB70QXju036324
	for <perforce@freebsd.org>; Sun, 7 Dec 2008 00:26:33 GMT
	(envelope-from zec@icir.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id mB70QXpt036322
	for perforce@freebsd.org; Sun, 7 Dec 2008 00:26:33 GMT
	(envelope-from zec@icir.org)
Date: Sun, 7 Dec 2008 00:26:33 GMT
Message-Id: <200812070026.mB70QXpt036322@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	zec@icir.org using -f
From: Marko Zec <zec@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 154226 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Dec 2008 00:26:34 -0000

http://perforce.freebsd.org/chv.cgi?CH=154226

Change 154226 by zec@zec_tpx32 on 2008/12/07 00:26:21

	Improve style and remove an XXX comment which no longer holds.

Affected files ...

.. //depot/projects/vimage-commit2/src/sys/kern/kern_linker.c#6 edit
.. //depot/projects/vimage-commit2/src/sys/kern/kern_vimage.c#4 edit
.. //depot/projects/vimage-commit2/src/sys/netinet/tcp_subr.c#36 edit

Differences ...

==== //depot/projects/vimage-commit2/src/sys/kern/kern_linker.c#6 (text+ko) ====

@@ -1311,10 +1311,9 @@
 			CURVNET_SET(TD_TO_VNET(td));
 			error = vi_symlookup(&lookup, symstr);
 			CURVNET_RESTORE();
-			if (error == 0) {
+			if (error == 0)
 				error = copyout(&lookup, uap->data,
 						sizeof(lookup));
-			}
 		}
 #else
 		if (lf == NULL)

==== //depot/projects/vimage-commit2/src/sys/kern/kern_vimage.c#4 (text+ko) ====

@@ -82,12 +82,12 @@
 			if (strcmp(symstr, mapentry->name) == 0) {
 				lookup->symvalue = (u_long) mapentry->base;
 				lookup->symsize = mapentry->size;
-				return 0;
+				return (0);
 			}
 		}
 	}
 
-	return ENOENT;
+	return (ENOENT);
 }
 
 static void

==== //depot/projects/vimage-commit2/src/sys/netinet/tcp_subr.c#36 (text+ko) ====

@@ -1483,7 +1483,6 @@
 #define ISN_RANDOM_INCREMENT (4096 - 1)
 
 #ifdef VIMAGE_GLOBALS
-/* XXX WARNING WARNING clash with contrib/pf/net/pf_subr.c - REVISIT !!! */
 static u_char isn_secret[32];
 static int isn_last_reseed;
 static u_int32_t isn_offset, isn_offset_old;