From owner-freebsd-rc@FreeBSD.ORG Mon Sep 7 11:07:07 2009 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9422F10656C2 for ; Mon, 7 Sep 2009 11:07:07 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 781098FC29 for ; Mon, 7 Sep 2009 11:07:07 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n87B77C5010365 for ; Mon, 7 Sep 2009 11:07:07 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n87B76n5010361 for freebsd-rc@FreeBSD.org; Mon, 7 Sep 2009 11:07:06 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 7 Sep 2009 11:07:06 GMT Message-Id: <200909071107.n87B76n5010361@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Sep 2009 11:07:07 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/138460 rc [patch] start local rc scripts in background o conf/138208 rc [rc] [patch] Making rc.firewall (workstation) IPv6 awa o conf/137629 rc [rc] background_dhclient rc.conf option causing double o conf/137470 rc [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameter o conf/136875 rc [request] _flags appending o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133987 rc [rc.d] defaultroute broken with DHCP in some cases o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132766 rc wait_for_pids() in /etc/rc.subr is dull. o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/130414 rc [patch] rc services started with onestart are not stop o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/127917 rc [patch] dumpon rejects on start with physmem>swap even o bin/126562 rc rcorder(8) fails to run unrelated startup scripts when o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped o bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/120228 rc [zfs] [patch] Split ZFS volume startup / ease ZFS swap o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105568 rc [patch] [request] Add more flexibility to rc.conf, to o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/45226 rc [patch] Fix for rc.network, ppp-user annoyance o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 62 problems total. From owner-freebsd-rc@FreeBSD.ORG Wed Sep 9 18:31:25 2009 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3B8451065695; Wed, 9 Sep 2009 18:31:25 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2B9648FC24; Wed, 9 Sep 2009 18:31:25 +0000 (UTC) Received: from freefall.freebsd.org (pjd@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n89IVPiB065422; Wed, 9 Sep 2009 18:31:25 GMT (envelope-from pjd@freefall.freebsd.org) Received: (from pjd@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n89IVOS9065418; Wed, 9 Sep 2009 18:31:24 GMT (envelope-from pjd) Date: Wed, 9 Sep 2009 18:31:24 GMT Message-Id: <200909091831.n89IVOS9065418@freefall.freebsd.org> To: ady@freebsd.ady.ro, pjd@FreeBSD.org, freebsd-rc@FreeBSD.org, pjd@FreeBSD.org From: pjd@FreeBSD.org Cc: Subject: Re: conf/120228: [zfs] [patch] Split ZFS volume startup / ease ZFS swap volumes management X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Sep 2009 18:31:25 -0000 Synopsis: [zfs] [patch] Split ZFS volume startup / ease ZFS swap volumes management State-Changed-From-To: open->closed State-Changed-By: pjd State-Changed-When: śro 9 wrz 2009 18:14:21 UTC State-Changed-Why: Thank you for your patch, but I already committed something along those line. rc.d/zfs script was broken and there is now also rc.d/zvol script. It was created so ZVOL-based file systems can be mounted from /etc/fstab. Using ZVOL property to setup swap was intended - ZFS file systems are also not mounted from /etc/fstab. All in all using ZVOL for swap is unreliable anyway. Responsible-Changed-From-To: freebsd-rc->pjd Responsible-Changed-By: pjd Responsible-Changed-When: śro 9 wrz 2009 18:14:21 UTC Responsible-Changed-Why: I'll take this one. http://www.freebsd.org/cgi/query-pr.cgi?pr=120228 From owner-freebsd-rc@FreeBSD.ORG Fri Sep 11 10:34:49 2009 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2320E1065696; Fri, 11 Sep 2009 10:34:49 +0000 (UTC) (envelope-from ady@ady.ro) Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.27]) by mx1.freebsd.org (Postfix) with ESMTP id 964CE8FC2A; Fri, 11 Sep 2009 10:34:48 +0000 (UTC) Received: by ey-out-2122.google.com with SMTP id 4so255797eyf.9 for ; Fri, 11 Sep 2009 03:34:47 -0700 (PDT) MIME-Version: 1.0 Sender: ady@ady.ro Received: by 10.211.141.7 with SMTP id t7mr345374ebn.99.1252665287327; Fri, 11 Sep 2009 03:34:47 -0700 (PDT) In-Reply-To: <200909091831.n89IVOS9065418@freefall.freebsd.org> References: <200909091831.n89IVOS9065418@freefall.freebsd.org> From: Adrian Penisoara Date: Fri, 11 Sep 2009 12:34:27 +0200 X-Google-Sender-Auth: c24ea4c5cec2c4a7 Message-ID: <78cb3d3f0909110334g6757f08fh57a0ab97c02b2d9a@mail.gmail.com> To: pjd@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-rc@freebsd.org Subject: Re: conf/120228: [zfs] [patch] Split ZFS volume startup / ease ZFS swap volumes management X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2009 10:34:49 -0000 Hi, On Wed, Sep 9, 2009 at 8:31 PM, wrote: > Synopsis: [zfs] [patch] Split ZFS volume startup / ease ZFS swap volumes = management > > State-Changed-From-To: open->closed > State-Changed-By: pjd > State-Changed-When: =C5=9Bro 9 wrz 2009 18:14:21 UTC > State-Changed-Why: > Thank you for your patch, but I already committed something along those l= ine. We're probably speaking of SVN changeset 195938 ? > rc.d/zfs script was broken and there is now also rc.d/zvol script. It was > created so ZVOL-based file systems can be mounted from /etc/fstab. > Using ZVOL property to setup swap was intended - ZFS file systems are als= o not > mounted from /etc/fstab. All in all using ZVOL for swap is unreliable any= way. While I do understand the "unreliable" part I still fail to understand why do we need to complicate matters with ZFS user property signatures to mount ZFS swap volumes instead of the traditional /etc/fstab way -- is there a concrete reason for this (besides said reliability) ? Thanks, Adrian Penisoara EnterpriseBSD From owner-freebsd-rc@FreeBSD.ORG Fri Sep 11 12:20:56 2009 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9D724106566C for ; Fri, 11 Sep 2009 12:20:56 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello087206049004.chello.pl [87.206.49.4]) by mx1.freebsd.org (Postfix) with ESMTP id E0C038FC20 for ; Fri, 11 Sep 2009 12:20:54 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 82EF245E6F; Fri, 11 Sep 2009 14:20:52 +0200 (CEST) Received: from localhost (pdawidek.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 91A8945C98; Fri, 11 Sep 2009 14:20:47 +0200 (CEST) Date: Fri, 11 Sep 2009 14:20:50 +0200 From: Pawel Jakub Dawidek To: Adrian Penisoara Message-ID: <20090911122050.GC1673@garage.freebsd.pl> References: <200909091831.n89IVOS9065418@freefall.freebsd.org> <78cb3d3f0909110334g6757f08fh57a0ab97c02b2d9a@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jL2BoiuKMElzg3CS" Content-Disposition: inline In-Reply-To: <78cb3d3f0909110334g6757f08fh57a0ab97c02b2d9a@mail.gmail.com> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=4.5 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: freebsd-rc@freebsd.org Subject: Re: conf/120228: [zfs] [patch] Split ZFS volume startup / ease ZFS swap volumes management X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2009 12:20:56 -0000 --jL2BoiuKMElzg3CS Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 11, 2009 at 12:34:27PM +0200, Adrian Penisoara wrote: > Hi, >=20 > On Wed, Sep 9, 2009 at 8:31 PM, wrote: > > Synopsis: [zfs] [patch] Split ZFS volume startup / ease ZFS swap volume= s management > > > > State-Changed-From-To: open->closed > > State-Changed-By: pjd > > State-Changed-When: =C5=9Bro 9 wrz 2009 18:14:21 UTC > > State-Changed-Why: > > Thank you for your patch, but I already committed something along those= line. >=20 > We're probably speaking of SVN changeset 195938 ? Yes. > > rc.d/zfs script was broken and there is now also rc.d/zvol script. It w= as > > created so ZVOL-based file systems can be mounted from /etc/fstab. > > Using ZVOL property to setup swap was intended - ZFS file systems are a= lso not > > mounted from /etc/fstab. All in all using ZVOL for swap is unreliable a= nyway. >=20 > While I do understand the "unreliable" part I still fail to understand > why do we need to complicate matters with ZFS user property signatures > to mount ZFS swap volumes instead of the traditional /etc/fstab way -- > is there a concrete reason for this (besides said reliability) ? The idea is to keep things consistent. You can still use /etc/fstab to put swap on ZVOLs, no? You can also set mountpoint property for file system to 'legacy' and then you can mount it from to /etc/fstab too. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --jL2BoiuKMElzg3CS Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFKqkCiForvXbEpPzQRAhHnAJ4gu+GtLT302RLjlGq6/kkJs31FfQCg3Uii Flmnw6i5SPcUi7Fnisv0Jj4= =ONbe -----END PGP SIGNATURE----- --jL2BoiuKMElzg3CS-- From owner-freebsd-rc@FreeBSD.ORG Fri Sep 11 15:20:06 2009 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BD5AA106566B; Fri, 11 Sep 2009 15:20:06 +0000 (UTC) (envelope-from ady@ady.ro) Received: from mail-ew0-f208.google.com (mail-ew0-f208.google.com [209.85.219.208]) by mx1.freebsd.org (Postfix) with ESMTP id F40568FC12; Fri, 11 Sep 2009 15:20:05 +0000 (UTC) Received: by ewy4 with SMTP id 4so1189123ewy.36 for ; Fri, 11 Sep 2009 08:20:04 -0700 (PDT) MIME-Version: 1.0 Sender: ady@ady.ro Received: by 10.211.141.7 with SMTP id t7mr678272ebn.99.1252682402179; Fri, 11 Sep 2009 08:20:02 -0700 (PDT) In-Reply-To: <20090911122050.GC1673@garage.freebsd.pl> References: <200909091831.n89IVOS9065418@freefall.freebsd.org> <78cb3d3f0909110334g6757f08fh57a0ab97c02b2d9a@mail.gmail.com> <20090911122050.GC1673@garage.freebsd.pl> From: Adrian Penisoara Date: Fri, 11 Sep 2009 17:19:41 +0200 X-Google-Sender-Auth: 2ae435233c56130f Message-ID: <78cb3d3f0909110819m35f2d5ceo64de128320091a76@mail.gmail.com> To: Pawel Jakub Dawidek Content-Type: text/plain; charset=ISO-8859-1 Cc: guido@freebsd.org, freebsd-rc@freebsd.org Subject: Re: conf/120228: [zfs] [patch] Split ZFS volume startup / ease ZFS swap volumes management X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2009 15:20:06 -0000 Hi, On Fri, Sep 11, 2009 at 2:20 PM, Pawel Jakub Dawidek wrote: [...] >> >> We're probably speaking of SVN changeset 195938 ? > > Yes. > >> > rc.d/zfs script was broken and there is now also rc.d/zvol script. It was >> > created so ZVOL-based file systems can be mounted from /etc/fstab. >> > Using ZVOL property to setup swap was intended - ZFS file systems are also not >> > mounted from /etc/fstab. All in all using ZVOL for swap is unreliable anyway. >> >> While I do understand the "unreliable" part I still fail to understand >> why do we need to complicate matters with ZFS user property signatures >> to mount ZFS swap volumes instead of the traditional /etc/fstab way -- >> is there a concrete reason for this (besides said reliability) ? > > The idea is to keep things consistent. You can still use /etc/fstab to > put swap on ZVOLs, no? You can also set mountpoint property for file Actually using /etc/fstab for zvol swap is not quite working in the current setup since /etc/rc.d/swap1 does not automatically swapoff upon shutdown which makes 'zvol stop' attempt to close the (swap) volume(s) while still in use. I guess 'zfs volfini' should be triggered by a shutdown hook similarly to what geom(4) classes are using. I see Guido committed a swapoff hook in changeset 189624 (similar to what I suggested in my initial PR) but immediately backed it out the next day. Funny thing is that this swapoff hook flip-flopped over time, see changesets 135389, 137255. Is there a reason not to have the swap devices automatically unmounted from /etc/swap1 upon shutdown ? > system to 'legacy' and then you can mount it from to /etc/fstab too. > Perhaps not the best idea: what if I export and then import a zpool from one system to another -- then I will have some swap volumes automatically mounted upon boot, breaking POLA. You can argue that ZFS filesystems will also be automatically mounted too, but this is a consistent behavior across different OSes while the discussed swap volume automount is FreeBSD specific. Sorry to insist, but I still think we should we keep it simple... Unless people are already using/depending on this feature. Regards, Adrian. From owner-freebsd-rc@FreeBSD.ORG Fri Sep 11 15:41:47 2009 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5E7D9106566B for ; Fri, 11 Sep 2009 15:41:47 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello087206049004.chello.pl [87.206.49.4]) by mx1.freebsd.org (Postfix) with ESMTP id 92D398FC1A for ; Fri, 11 Sep 2009 15:41:46 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id D00AC45F20; Fri, 11 Sep 2009 17:41:44 +0200 (CEST) Received: from localhost (pdawidek.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id A7A0045EEF; Fri, 11 Sep 2009 17:41:39 +0200 (CEST) Date: Fri, 11 Sep 2009 17:41:42 +0200 From: Pawel Jakub Dawidek To: Adrian Penisoara Message-ID: <20090911154142.GF1673@garage.freebsd.pl> References: <200909091831.n89IVOS9065418@freefall.freebsd.org> <78cb3d3f0909110334g6757f08fh57a0ab97c02b2d9a@mail.gmail.com> <20090911122050.GC1673@garage.freebsd.pl> <78cb3d3f0909110819m35f2d5ceo64de128320091a76@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VuQYccsttdhdIfIP" Content-Disposition: inline In-Reply-To: <78cb3d3f0909110819m35f2d5ceo64de128320091a76@mail.gmail.com> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 8.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=4.5 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: guido@freebsd.org, freebsd-rc@freebsd.org Subject: Re: conf/120228: [zfs] [patch] Split ZFS volume startup / ease ZFS swap volumes management X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2009 15:41:47 -0000 --VuQYccsttdhdIfIP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 11, 2009 at 05:19:41PM +0200, Adrian Penisoara wrote: > Actually using /etc/fstab for zvol swap is not quite working in the > current setup since /etc/rc.d/swap1 does not automatically swapoff > upon shutdown which makes 'zvol stop' attempt to close the (swap) > volume(s) while still in use. > I guess 'zfs volfini' should be triggered by a shutdown hook > similarly to what geom(4) classes are using. >=20 > I see Guido committed a swapoff hook in changeset 189624 (similar to > what I suggested in my initial PR) but immediately backed it out the > next day. Funny thing is that this swapoff hook flip-flopped over > time, see changesets 135389, 137255. >=20 > Is there a reason not to have the swap devices automatically > unmounted from /etc/swap1 upon shutdown ? The answer is simple: we don't want swapoff to fail. There really no point in removing swap on shutdown (it could still be a good idea to do it when administrator executes /etc/rc.d/swap1 stop). We unmount file systems on shutdown, because we want to keep them consistent. There is no need to keep swap consistent, as the data will be useless after reboot anyway. All in all running swapoff at shutdown time increases reboot time and introduce possibility of failure (I think the kernel can panic if there is no enough memory to move everything out of the swap, but I might be wrong here). There are some tricky cases too. For example: # truncate -s 1g /swap.img # mdconfig -a -f /swap.img # swapon /dev/md0 Now if we don't remove swap we won't be able to unmount file system in non-forcible way. > > system to 'legacy' and then you can mount it from to /etc/fstab too. > > >=20 > Perhaps not the best idea: what if I export and then import a zpool > from one system to another -- then I will have some swap volumes > automatically mounted upon boot, breaking POLA. >=20 > You can argue that ZFS filesystems will also be automatically mounted > too, but this is a consistent behavior across different OSes while the > discussed swap volume automount is FreeBSD specific. >=20 > Sorry to insist, but I still think we should we keep it simple... > Unless people are already using/depending on this feature. Please understand that I don't want to disallow swap configuration from /etc/fstab. I'm just giving an option. I'll think about it a bit more and talk to some people what they think about this and I'll get back to you. Maybe this property is indeed redundant, but I don't want to make any rush decisions. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --VuQYccsttdhdIfIP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFKqm+2ForvXbEpPzQRAlCbAJ9NrKXxe0iHQ/II/Y4tDlRs6NKGoQCgywOn /8QRcqDdnK+syjkz6G4ab9o= =FcZK -----END PGP SIGNATURE----- --VuQYccsttdhdIfIP-- From owner-freebsd-rc@FreeBSD.ORG Sat Sep 12 02:10:38 2009 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5CACB106568B; Sat, 12 Sep 2009 02:10:38 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 33AFB8FC1F; Sat, 12 Sep 2009 02:10:38 +0000 (UTC) Received: from freefall.freebsd.org (linimon@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n8C2Ac3j079930; Sat, 12 Sep 2009 02:10:38 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n8C2AcrP079920; Sat, 12 Sep 2009 02:10:38 GMT (envelope-from linimon) Date: Sat, 12 Sep 2009 02:10:38 GMT Message-Id: <200909120210.n8C2AcrP079920@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-rc@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: conf/138686: [rc.conf] $named_conf in rc.conf is not used X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Sep 2009 02:10:38 -0000 Old Synopsis: $named_conf in rc.conf is not used New Synopsis: [rc.conf] $named_conf in rc.conf is not used Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: linimon Responsible-Changed-When: Sat Sep 12 02:10:12 UTC 2009 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=138686