From owner-freebsd-bluetooth@FreeBSD.ORG Thu May 6 11:58:07 2010 Return-Path: Delivered-To: freebsd-bluetooth@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5FE4F1065676 for ; Thu, 6 May 2010 11:58:07 +0000 (UTC) (envelope-from emelie@ns11-wistee.fr) Received: from ns11.wistee.fr (dns-ns11.wistee.fr [94.124.84.11]) by mx1.freebsd.org (Postfix) with ESMTP id 22BC08FC19 for ; Thu, 6 May 2010 11:58:07 +0000 (UTC) Received: from emelie by ns11.wistee.fr with local (Exim 4.67) (envelope-from ) id 1O9ziL-0003En-Qg for freebsd-bluetooth@freebsd.org; Thu, 06 May 2010 13:58:01 +0200 To: freebsd-bluetooth@freebsd.org X-PHP-Script: emelie.ns11-wistee.fr/blainne.php for 41.251.59.30 From: IRISH NATIONAL LOTTERY MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 8bit Message-Id: Sender: Date: Thu, 06 May 2010 13:58:01 +0200 Subject: Contact Us:(IRISH NATIONAL LOTTERY) X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: irishnational.lot@englandmail.com List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 May 2010 11:58:07 -0000 Dear Reader Greetings from Irish National Lottery here in london.We wish to inform you that £750,000.00 Pounds has been awarded to your E-mail in our IRISH NATIONAL LOTTERY ONLINE PROMO PROGRAMME To file your claims contact our fiduciary agent for claims: Mr. Edward Brown Email: edwardbrown85@gmail.com Provide him with the information below: Full Names:............. Tel:............. Sex:............ Age:............ Congratulations once more. From owner-freebsd-bluetooth@FreeBSD.ORG Thu May 6 22:27:41 2010 Return-Path: Delivered-To: freebsd-bluetooth@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DBE2B1065672; Thu, 6 May 2010 22:27:41 +0000 (UTC) (envelope-from alex.deiter@gmail.com) Received: from mail-yw0-f181.google.com (mail-yw0-f181.google.com [209.85.211.181]) by mx1.freebsd.org (Postfix) with ESMTP id 4945C8FC19; Thu, 6 May 2010 22:27:41 +0000 (UTC) Received: by ywh11 with SMTP id 11so301498ywh.7 for ; Thu, 06 May 2010 15:27:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:content-type; bh=pPAa6U8Z/puL57Hl4AQ0ArM0sHDhSbyK+XLTnf+NOvg=; b=nALj7bSAB3gF2oz5OezvKVvztHjsVzPd6T8rIRV16e8kNUSVbWHA5hfVsRgwCjaXEB 0CYe22wNsXQLf8AAtNXDQvUaqAE9ops/O8SMcG5LtuXwSFiBK07Uj4GB6rFbsidzyEhd vJMSZ8FrS9DjdypiX1Uy4/DCpl++4cPGQjIOc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=I0DO3qAKmMauwuTExFTURhdcZc7iXZdHj9X/zUk1IYHJfr43kX81PsFJfc4OfMV5Gq jZ8V0NaH94A5ckmKTfo5liOfuSSvnguvdwID0x3L4Q86XQhv5PdKOeakfTnI9PUBp9oQ doFB0axjg3OcICG1lL7Mnq8LuTahizN7819Qk= MIME-Version: 1.0 Received: by 10.100.229.2 with SMTP id b2mr8989082anh.255.1273183094227; Thu, 06 May 2010 14:58:14 -0700 (PDT) Received: by 10.100.91.20 with HTTP; Thu, 6 May 2010 14:58:13 -0700 (PDT) Date: Fri, 7 May 2010 01:58:13 +0400 Message-ID: From: Alex Deiter To: freebsd-usb@freebsd.org, current@freebsd.org, freebsd-bluetooth@freebsd.org, kaiw@freebsd.org, hps@freebsd.org Content-Type: multipart/mixed; boundary=001636af02d71770320485f40a56 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Subject: Revision 205728: broken bluetooth mouse support X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 May 2010 22:27:42 -0000 --001636af02d71770320485f40a56 Content-Type: text/plain; charset=UTF-8 Hi, Bluetooth mouse support is broken after Revision 205728: http://svn.freebsd.org/viewvc/base?view=revision&revision=205728 When I move the mouse - cursor stays in same place but moves the current position of the console. Proposed patch as an attachment. Could you please revew this ? Thanks a lot! -- Alex Deiter --001636af02d71770320485f40a56-- From owner-freebsd-bluetooth@FreeBSD.ORG Fri May 7 10:25:45 2010 Return-Path: Delivered-To: freebsd-bluetooth@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AACF31065670; Fri, 7 May 2010 10:25:45 +0000 (UTC) (envelope-from kaiwang27@gmail.com) Received: from mail-ew0-f224.google.com (mail-ew0-f224.google.com [209.85.219.224]) by mx1.freebsd.org (Postfix) with ESMTP id D28B58FC19; Fri, 7 May 2010 10:25:44 +0000 (UTC) Received: by ewy24 with SMTP id 24so216702ewy.33 for ; Fri, 07 May 2010 03:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:received :x-authentication-warning:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=z/z4a2JXXeOwINGEcy4L5O1hJVfzoy5SuHnZ8leis9c=; b=t2pY/Fw6jQASg34vK0N2ALj1kkk/2Zp7lrvn2KT9uDdd1E6wd/puW0dCFKq7cxEPZa dUQ/Wz3MmVPbk/wb7OildmYgQiuoHo4dvRyaHlc6txUzYVpQo0HOy2+Lgdv4k+ZtYzZI zHb02WISNacsgOe8eFB5mBeDsSU3ut4zf7Xao= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=x-authentication-warning:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; b=jg8U1M8fM5eoPA/zSjHSOvSlnZGxnoqX6WK+Eldq0KFulNBqxzin8FL+Gue7kuIRdG sIIMr6j2d8nlEJ95FMp8G8v4xgyMA+bUsvuD/2XYAs38o0rL5VzCgC7qG8KxHkiikVoD BF8cgfDXuxpYXNa9UP6YMv2wE17VZOJx6eOc8= Received: by 10.213.41.142 with SMTP id o14mr3846721ebe.18.1273226257228; Fri, 07 May 2010 02:57:37 -0700 (PDT) Received: from localhost (81-233-38-26-no36.tbcn.telia.com [81.233.38.26]) by mx.google.com with ESMTPS id 14sm1060751ewy.14.2010.05.07.02.57.35 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 07 May 2010 02:57:35 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=localhost.my.domain) by localhost with esmtp (Exim 4.71 (FreeBSD)) (envelope-from ) id 1OAKJ5-0000nj-4O; Fri, 07 May 2010 11:57:19 +0200 Received: (from kaiw@localhost) by localhost.my.domain (8.14.3/8.14.3/Submit) id o479vJZg003082; Fri, 7 May 2010 11:57:19 +0200 (CEST) (envelope-from kaiwang27@gmail.com) X-Authentication-Warning: localhost.my.domain: kaiw set sender to kaiwang27@gmail.com using -f Date: Fri, 7 May 2010 11:57:18 +0200 From: Kai Wang To: Alex Deiter Message-ID: <20100507095718.GA3047@viskning> References: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="huq684BweRXVnRxX" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Cc: freebsd-bluetooth@freebsd.org, current@freebsd.org, freebsd-usb@freebsd.org, hps@freebsd.org Subject: Re: Revision 205728: broken bluetooth mouse support X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2010 10:25:45 -0000 --huq684BweRXVnRxX Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Fri, May 07, 2010 at 01:58:13AM +0400, Alex Deiter wrote: > Hi, > > Bluetooth mouse support is broken after Revision 205728: > > http://svn.freebsd.org/viewvc/base?view=revision&revision=205728 > > When I move the mouse - cursor stays in same place but moves the > current position of the console. > > Proposed patch as an attachment. Could you please revew this ? Hi Alex, If we adopt your patch, usbhidctl(1) and usbhidaction(1) will be broken again on device with multiple report IDs. Could you please try if the attached patch for the bthidd(8) daemon works as well? Thanks, Kai --huq684BweRXVnRxX Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="bthidd.txt" Index: usr.sbin/bluetooth/bthidd/hid.c =================================================================== --- usr.sbin/bluetooth/bthidd/hid.c (revision 207113) +++ usr.sbin/bluetooth/bthidd/hid.c (working copy) @@ -130,7 +130,7 @@ hid_interrupt(bthid_session_p s, uint8_t *data, in hid_item_t h; int32_t report_id, usage, page, val, mouse_x, mouse_y, mouse_z, mouse_butt, - mevents, kevents; + mevents, kevents, i; assert(s != NULL); assert(s->srv != NULL); @@ -150,8 +150,8 @@ hid_interrupt(bthid_session_p s, uint8_t *data, in } report_id = data[1]; - data += 2; - len -= 2; + data ++; + len --; hid_device = get_hid_device(&s->bdaddr); assert(hid_device != NULL); @@ -202,17 +202,11 @@ hid_interrupt(bthid_session_p s, uint8_t *data, in if (val && val < kbd_maxkey()) bit_set(s->keys1, val); - data ++; - len --; - - len = min(len, h.report_size); - while (len > 0) { + for (i = 1; i < h.report_count; i++) { + h.pos += h.report_size; val = hid_get_data(data, &h); if (val && val < kbd_maxkey()) bit_set(s->keys1, val); - - data ++; - len --; } } break; --huq684BweRXVnRxX-- From owner-freebsd-bluetooth@FreeBSD.ORG Fri May 7 10:37:46 2010 Return-Path: Delivered-To: freebsd-bluetooth@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BB3D51065670; Fri, 7 May 2010 10:37:46 +0000 (UTC) (envelope-from alex.deiter@gmail.com) Received: from mail-gx0-f226.google.com (mail-gx0-f226.google.com [209.85.217.226]) by mx1.freebsd.org (Postfix) with ESMTP id 38DBD8FC14; Fri, 7 May 2010 10:37:45 +0000 (UTC) Received: by gxk26 with SMTP id 26so521122gxk.13 for ; Fri, 07 May 2010 03:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=LF+KPWP6om1zljSLOQqkYNdYJWYoLaX6ZVyFBEZarQg=; b=hujLRgQ0LDjWveWQcqu6KdCpfJbxv7Bs/nc16xMEj/ZFoGIUB3bDBz/MZeVy+FcP62 v/qfKiGN50DNmN0Cy+SodtvxduiBt0GbjempkVnGx99c66hHhe1AnktAmDnbEP47QPj8 /9rKIBAAuIce6lx3bk+EsZ6fWZ58U+9bNls58= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=f/iVe0muAT6/m0den3avqKLmcUd1j86E5kO5co4c5OMsGt2m49uaJtaRO6qaMb8Pzh buasIeaZCkT8Gtf6x9q5/P7dkXeuYanhi1mou4BYrSa7GXruZOXchqcEWFpO+bTfawFb p+Fz2NmrihLUk3Hq5f+tXXe7NhpRKTOVJkod8= MIME-Version: 1.0 Received: by 10.101.205.18 with SMTP id h18mr1079anq.30.1273228659391; Fri, 07 May 2010 03:37:39 -0700 (PDT) Received: by 10.100.91.20 with HTTP; Fri, 7 May 2010 03:37:39 -0700 (PDT) In-Reply-To: <20100507095718.GA3047@viskning> References: <20100507095718.GA3047@viskning> Date: Fri, 7 May 2010 14:37:39 +0400 Message-ID: From: Alex Deiter To: Kai Wang Content-Type: text/plain; charset=UTF-8 Cc: freebsd-bluetooth@freebsd.org, current@freebsd.org, freebsd-usb@freebsd.org, hps@freebsd.org Subject: Re: Revision 205728: broken bluetooth mouse support X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2010 10:37:46 -0000 Hi Kal, Thanks a lot for your patch! I`m apply this patch and my bt mouse work fine again! For Hans: > Which daemon is driving the BT mouse? bthidd patch for bthidd(8) works fine only WITH your patches for: lib/libusbhid/data.c sys/dev/usb/usb_hid.c sys/dev/usb/usbhid.h Thanks a lot! 2010/5/7 Kai Wang : > On Fri, May 07, 2010 at 01:58:13AM +0400, Alex Deiter wrote: >> Hi, >> >> Bluetooth mouse support is broken after Revision 205728: >> >> http://svn.freebsd.org/viewvc/base?view=revision&revision=205728 >> >> When I move the mouse - cursor stays in same place but moves the >> current position of the console. >> >> Proposed patch as an attachment. Could you please revew this ? > > Hi Alex, > > If we adopt your patch, usbhidctl(1) and usbhidaction(1) will be > broken again on device with multiple report IDs. > > Could you please try if the attached patch for the bthidd(8) > daemon works as well? > > Thanks, > Kai > -- -- Alex Deiter