From owner-freebsd-fs@FreeBSD.ORG Sun Jan 3 01:40:17 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 339291065693; Sun, 3 Jan 2010 01:40:17 +0000 (UTC) (envelope-from nekoexmachina@gmail.com) Received: from mail-fx0-f227.google.com (mail-fx0-f227.google.com [209.85.220.227]) by mx1.freebsd.org (Postfix) with ESMTP id 2F6AD8FC12; Sun, 3 Jan 2010 01:40:16 +0000 (UTC) Received: by fxm27 with SMTP id 27so13296599fxm.3 for ; Sat, 02 Jan 2010 17:40:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=Bt3P21gxkIfm1ejmc9nmRwmIbTYmtVWe/vewT8JTcJs=; b=G5waeI97s5ehmWqKeFeu60IcUhe6rqtpYEr680TZE9Z0V6yXRQfsESmJbhJl8q7s7x 8b2a5selfu8H0u5oMlkvLb6YOa1eos6be79hPNGh/y8+i4kg2N0mcd88aYg6EI5yxzlI K04/uvxgpBtXo2Y8+XcZ1qIZjOq4bvooydQS0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=W/8a+p1wBj8vcW0yxqOQ9GyzZBfCUSiF+6n254EshrY0gnBCk735Hbpgr36qCBBte9 Hi0tlvcfNHUVwjB+VAspM7IgLDJG66FbD6flLzDckKhWcZ9LqaKkCfoRGq8pLtsiW8bf LtiiSugBa75BTV2azH6C0muPgUgEU/xp5263I= MIME-Version: 1.0 Received: by 10.103.141.16 with SMTP id t16mr8088651mun.38.1262482802530; Sat, 02 Jan 2010 17:40:02 -0800 (PST) In-Reply-To: <884554e60912180038w3442dc67of9a1ed755f399df0@mail.gmail.com> References: <884554e60912090842x1bf1e8e4u842cbce4647aa63@mail.gmail.com> <884554e60912101351o2d592c6fn99f64bb2fd8c33be@mail.gmail.com> <4b21a7b9.5744f10a.3378.6447@mx.google.com> <884554e60912110938n79439fc1p4a3d41f81bb88991@mail.gmail.com> <5da0588e0912112203v52653fb2ic71d97970b615547@mail.gmail.com> <884554e60912120149t6cd0df5me349b1fdf485b0c@mail.gmail.com> <884554e60912120547i1ccca7acob8714fd5121a5508@mail.gmail.com> <4b2a6cad.9713f30a.573f.ffffad80@mx.google.com> <20091217180445.GA4115@a91-153-117-195.elisa-laajakaista.fi> <884554e60912180038w3442dc67of9a1ed755f399df0@mail.gmail.com> Date: Sun, 3 Jan 2010 04:40:02 +0300 Message-ID: <884554e61001021740h40294fabn95c5a7c1f0bca788@mail.gmail.com> From: Mikle Krutov To: freebsd-fs@freebsd.org, jh@freebsd.org, stas@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Subject: Re: [8.0-RELEASE] ext2fs mount fails X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jan 2010 01:40:17 -0000 Sorry for such a long time no-write. I've got to the PC with freebsd installed, and managed to copy all of data from ext2fs to zfs via linux-livecd. What data about this two partitions should be sent to fbsd-bugs? Also, not even 1 version of fbsd could mount them, tried 7.2 (livefs cd), 8.0-RELEASE and STABLE, so it may be not the fbsd bug. 2009/12/18 Mikle Krutov : > Well, i could not verify that under freebsd. Every fs-tool (except > testdisk - tried to use it to restore superblock after message 'wrong > magic number' appeared first time) tells me that i've got wrong magic > number for this filesystem. > I can not give the gpart show output right now; will send it in couple of= days. > > 2009/12/17 Jaakko Heinonen : >> On 2009-12-17, Aditya Sarawgi wrote: >>> > Yes, it's 100% ext2fs. =C2=A0I could not create dump with fbsd - 'wro= ng >>> > magic number', so i used linux livecd. >> >>> Mikle, file a pr. jh@, stas@ any ideas about this. >> >> How did you verify that /dev/ad8p1 contains a valid ext2fs (on FreeBSD)? >> AFAIK, recent dumpe2fs should work in any case if the partition contains >> a valid file system. My guess is that there is something wrong with the >> partition or how FreeBSD sees the partition. >> >> "gpart show" output might be useful for starters and maybe similar >> output from Linux. >> >> -- >> Jaakko >> > From owner-freebsd-fs@FreeBSD.ORG Sun Jan 3 12:35:12 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E0D9C106568B; Sun, 3 Jan 2010 12:35:12 +0000 (UTC) (envelope-from gavin@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B8B528FC1A; Sun, 3 Jan 2010 12:35:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o03CZCWP085778; Sun, 3 Jan 2010 12:35:12 GMT (envelope-from gavin@freefall.freebsd.org) Received: (from gavin@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o03CZCgZ085774; Sun, 3 Jan 2010 12:35:12 GMT (envelope-from gavin) Date: Sun, 3 Jan 2010 12:35:12 GMT Message-Id: <201001031235.o03CZCgZ085774@freefall.freebsd.org> To: gavin@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-fs@FreeBSD.org From: gavin@FreeBSD.org Cc: Subject: Re: bin/138043: [patch] fsck_ffs(8) broken, partial patch X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jan 2010 12:35:13 -0000 Synopsis: [patch] fsck_ffs(8) broken, partial patch Responsible-Changed-From-To: freebsd-bugs->freebsd-fs Responsible-Changed-By: gavin Responsible-Changed-When: Sun Jan 3 12:34:54 UTC 2010 Responsible-Changed-Why: Over to maintainer(s) http://www.freebsd.org/cgi/query-pr.cgi?pr=138043 From owner-freebsd-fs@FreeBSD.ORG Sun Jan 3 19:25:05 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D3FA1065670; Sun, 3 Jan 2010 19:25:05 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 172768FC20; Sun, 3 Jan 2010 19:25:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o03JP445095899; Sun, 3 Jan 2010 19:25:04 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o03JP4Of095895; Sun, 3 Jan 2010 19:25:04 GMT (envelope-from linimon) Date: Sun, 3 Jan 2010 19:25:04 GMT Message-Id: <201001031925.o03JP4Of095895@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-fs@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: kern/142271: [zfs] [patch] race condition on zpool create X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jan 2010 19:25:05 -0000 Synopsis: [zfs] [patch] race condition on zpool create Responsible-Changed-From-To: freebsd-bugs->freebsd-fs Responsible-Changed-By: linimon Responsible-Changed-When: Sun Jan 3 19:24:51 UTC 2010 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=142271 From owner-freebsd-fs@FreeBSD.ORG Mon Jan 4 11:06:56 2010 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7CDED1065679 for ; Mon, 4 Jan 2010 11:06:56 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 51DE48FC20 for ; Mon, 4 Jan 2010 11:06:56 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o04B6uhl064874 for ; Mon, 4 Jan 2010 11:06:56 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o04B6tWN064870 for freebsd-fs@FreeBSD.org; Mon, 4 Jan 2010 11:06:55 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 4 Jan 2010 11:06:55 GMT Message-Id: <201001041106.o04B6tWN064870@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-fs@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-fs@FreeBSD.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2010 11:06:56 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/142271 fs [zfs] [patch] race condition on zpool create o kern/142068 fs [ufs] BSD labels are got deleted spontaneously o kern/141950 fs [unionfs] [lor] ufs/unionfs(/ufs) o kern/141897 fs [msdosfs] [panic] Kernel panic. msdofs: file name leng o kern/141718 fs [zfs] [panic] kernel panic when 'zfs rename' is used o o kern/141685 fs [zfs] zfs corruption on adaptec 5805 raid controller o kern/141463 fs [nfs] [panic] Frequent kernel panics after upgrade fro o kern/141305 fs [zfs] FreeBSD ZFS+sendfile severe performance issues ( o kern/141257 fs [gvinum] No puedo crear RAID5 por SW con gvinum o kern/141235 fs [disklabel] 8.0 no longer provides /dev entries for al o kern/141194 fs [tmpfs] tmpfs treats the size option as mod 2^32 o kern/141177 fs [zfs] fsync() on FIFO causes panic() on zfs o kern/141091 fs [patch] [nullfs] fix panics with DIAGNOSTIC enabled o kern/141086 fs [nfs] [panic] panic("nfs: bioread, not dir") on FreeBS o kern/141010 fs [zfs] "zfs scrub" fails when backed by files in UFS2 o kern/140888 fs [zfs] boot fail from zfs root while the pool resilveri o kern/140682 fs [netgraph] [panic] random panic in netgraph o kern/140661 fs [zfs] /boot/loader fails to work on a GPT/ZFS-only sys o kern/140640 fs [zfs] snapshot crash o kern/140433 fs [zfs] [panic] panic while replaying ZIL after crash o kern/140134 fs [msdosfs] write and fsck destroy filesystem integrity o kern/140068 fs [smbfs] [patch] smbfs does not allow semicolon in file o kern/139725 fs [zfs] zdb(1) dumps core on i386 when examining zpool c o kern/139715 fs [zfs] vfs.numvnodes leak on busy zfs o bin/139651 fs [nfs] mount(8): read-only remount of NFS volume does n o kern/139597 fs [patch] [tmpfs] tmpfs initializes va_gen but doesn't u o kern/139564 fs [zfs] [panic] 8.0-RC1 - Fatal trap 12 at end of shutdo o kern/139407 fs [smbfs] [panic] smb mount causes system crash if remot o kern/139363 fs [nfs] diskless root nfs mount from non FreeBSD server o kern/138790 fs [zfs] ZFS ceases caching when mem demand is high o kern/138524 fs [msdosfs] disks and usb flashes/cards with Russian lab o kern/138421 fs [ufs] [patch] remove UFS label limitations o kern/138367 fs [tmpfs] [panic] 'panic: Assertion pages > 0 failed' wh o kern/138202 fs mount_msdosfs(1) see only 2Gb o kern/138109 fs [extfs] [patch] Minor cleanups to the sys/gnu/fs/ext2f o bin/138043 fs [patch] fsck_ffs(8) broken, partial patch f kern/137037 fs [zfs] [hang] zfs rollback on root causes FreeBSD to fr o kern/136968 fs [ufs] [lor] ufs/bufwait/ufs (open) o kern/136945 fs [ufs] [lor] filedesc structure/ufs (poll) o kern/136944 fs [ffs] [lor] bufwait/snaplk (fsync) o kern/136873 fs [ntfs] Missing directories/files on NTFS volume o kern/136865 fs [nfs] [patch] NFS exports atomic and on-the-fly atomic o kern/136470 fs [nfs] Cannot mount / in read-only, over NFS o kern/135594 fs [zfs] Single dataset unresponsive with Samba o kern/135546 fs [zfs] zfs.ko module doesn't ignore zpool.cache filenam o kern/135469 fs [ufs] [panic] kernel crash on md operation in ufs_dirb o kern/135050 fs [zfs] ZFS clears/hides disk errors on reboot o kern/134491 fs [zfs] Hot spares are rather cold... o kern/133980 fs [panic] [ffs] panic: ffs_valloc: dup alloc o kern/133676 fs [smbfs] [panic] umount -f'ing a vnode-based memory dis o kern/133614 fs [panic] panic: ffs_truncate: read-only filesystem o kern/133174 fs [msdosfs] [patch] msdosfs must support utf-encoded int f kern/133150 fs [zfs] Page fault with ZFS on 7.1-RELEASE/amd64 while w o kern/132960 fs [ufs] [panic] panic:ffs_blkfree: freeing free frag o kern/132597 fs [tmpfs] [panic] tmpfs-related panic while interrupting o kern/132397 fs reboot causes filesystem corruption (failure to sync b o kern/132331 fs [ufs] [lor] LOR ufs and syncer o kern/132237 fs [msdosfs] msdosfs has problems to read MSDOS Floppy o kern/132145 fs [panic] File System Hard Crashes o kern/131995 fs [nfs] Failure to mount NFSv4 server o kern/131441 fs [unionfs] [nullfs] unionfs and/or nullfs not combineab o kern/131360 fs [nfs] poor scaling behavior of the NFS server under lo o kern/131342 fs [nfs] mounting/unmounting of disks causes NFS to fail o bin/131341 fs makefs: error "Bad file descriptor" on the mount poin o kern/130979 fs [smbfs] [panic] boot/kernel/smbfs.ko o kern/130920 fs [msdosfs] cp(1) takes 100% CPU time while copying file o kern/130229 fs [iconv] usermount fails on fs that need iconv o kern/130210 fs [nullfs] Error by check nullfs o kern/129760 fs [nfs] after 'umount -f' of a stale NFS share FreeBSD l o kern/129488 fs [smbfs] Kernel "bug" when using smbfs in smbfs_smb.c: o kern/129231 fs [ufs] [patch] New UFS mount (norandom) option - mostly o kern/129152 fs [panic] non-userfriendly panic when trying to mount(8) o kern/129059 fs [zfs] [patch] ZFS bootloader whitelistable via WITHOUT f kern/128829 fs smbd(8) causes periodic panic on 7-RELEASE o kern/127659 fs [tmpfs] tmpfs memory leak o kern/127420 fs [gjournal] [panic] Journal overflow on gmirrored gjour o kern/127029 fs [panic] mount(8): trying to mount a write protected zi o kern/126287 fs [ufs] [panic] Kernel panics while mounting an UFS file s kern/125738 fs [zfs] [request] SHA256 acceleration in ZFS p kern/124621 fs [ext3] [patch] Cannot mount ext2fs partition f bin/124424 fs [zfs] zfs(8): zfs list -r shows strange snapshots' siz o kern/123939 fs [msdosfs] corrupts new files o kern/122380 fs [ffs] ffs_valloc:dup alloc (Soekris 4801/7.0/USB Flash o bin/122172 fs [fs]: amd(8) automount daemon dies on 6.3-STABLE i386, o bin/121898 fs [nullfs] pwd(1)/getcwd(2) fails with Permission denied o bin/121779 fs [ufs] snapinfo(8) (and related tools?) only work for t o bin/121366 fs [zfs] [patch] Automatic disk scrubbing from periodic(8 o bin/121072 fs [smbfs] mount_smbfs(8) cannot normally convert the cha f kern/120991 fs [panic] [fs] [snapshot] System crashes when manipulati o kern/120483 fs [ntfs] [patch] NTFS filesystem locking changes o kern/120482 fs [ntfs] [patch] Sync style changes between NetBSD and F f kern/119735 fs [zfs] geli + ZFS + samba starting on boot panics 7.0-B o kern/118912 fs [2tb] disk sizing/geometry problem with large array o kern/118713 fs [minidump] [patch] Display media size required for a k o bin/118249 fs mv(1): moving a directory changes its mtime o kern/118107 fs [ntfs] [panic] Kernel panic when accessing a file at N o bin/117315 fs [smbfs] mount_smbfs(8) and related options can't mount o kern/117314 fs [ntfs] Long-filename only NTFS fs'es cause kernel pani o kern/117158 fs [zfs] zpool scrub causes panic if geli vdevs detach on o bin/116980 fs [msdosfs] [patch] mount_msdosfs(8) resets some flags f o kern/116913 fs [ffs] [panic] ffs_blkfree: freeing free block p kern/116608 fs [msdosfs] [patch] msdosfs fails to check mount options o kern/116583 fs [ffs] [hang] System freezes for short time when using o kern/116170 fs [panic] Kernel panic when mounting /tmp o kern/115645 fs [snapshots] [panic] lockmgr: thread 0xc4c00d80, not ex o bin/115361 fs [zfs] mount(8) gets into a state where it won't set/un o kern/114955 fs [cd9660] [patch] [request] support for mask,dirmask,ui o kern/114847 fs [ntfs] [patch] [request] dirmask support for NTFS ala o kern/114676 fs [ufs] snapshot creation panics: snapacct_ufs2: bad blo o bin/114468 fs [patch] [request] add -d option to umount(8) to detach o kern/113852 fs [smbfs] smbfs does not properly implement DFS referral o bin/113838 fs [patch] [request] mount(8): add support for relative p o bin/113049 fs [patch] [request] make quot(8) use getopt(3) and show o kern/112658 fs [smbfs] [patch] smbfs and caching problems (resolves b o kern/111843 fs [msdosfs] Long Names of files are incorrectly created o kern/111782 fs [ufs] dump(8) fails horribly for large filesystems s bin/111146 fs [2tb] fsck(8) fails on 6T filesystem o kern/109024 fs [msdosfs] mount_msdosfs: msdosfs_iconv: Operation not o kern/109010 fs [msdosfs] can't mv directory within fat32 file system o bin/107829 fs [2TB] fdisk(8): invalid boundary checking in fdisk / w o kern/106030 fs [ufs] [panic] panic in ufs from geom when a dead disk o kern/104406 fs [ufs] Processes get stuck in "ufs" state under persist o kern/104133 fs [ext2fs] EXT2FS module corrupts EXT2/3 filesystems o kern/103035 fs [ntfs] Directories in NTFS mounted disc images appear o kern/101324 fs [smbfs] smbfs sometimes not case sensitive when it's s o kern/99290 fs [ntfs] mount_ntfs ignorant of cluster sizes o kern/97377 fs [ntfs] [patch] syntax cleanup for ntfs_ihash.c o kern/95222 fs [iso9660] File sections on ISO9660 level 3 CDs ignored o kern/94849 fs [ufs] rename on UFS filesystem is not atomic o kern/94769 fs [ufs] Multiple file deletions on multi-snapshotted fil o kern/94733 fs [smbfs] smbfs may cause double unlock o kern/93942 fs [vfs] [patch] panic: ufs_dirbad: bad dir (patch from D o kern/92272 fs [ffs] [hang] Filling a filesystem while creating a sna f kern/91568 fs [ufs] [panic] writing to UFS/softupdates DVD media in o kern/91134 fs [smbfs] [patch] Preserve access and modification time a kern/90815 fs [smbfs] [patch] SMBFS with character conversions somet o kern/88657 fs [smbfs] windows client hang when browsing a samba shar o kern/88266 fs [smbfs] smbfs does not implement UIO_NOCOPY and sendfi o kern/87859 fs [smbfs] System reboot while umount smbfs. o kern/86587 fs [msdosfs] rm -r /PATH fails with lots of small files o kern/85326 fs [smbfs] [panic] saving a file via samba to an overquot o kern/84589 fs [2TB] 5.4-STABLE unresponsive during background fsck 2 o kern/80088 fs [smbfs] Incorrect file time setting on NTFS mounted vi o kern/73484 fs [ntfs] Kernel panic when doing `ls` from the client si o bin/73019 fs [ufs] fsck_ufs(8) cannot alloc 607016868 bytes for ino o kern/71774 fs [ntfs] NTFS cannot "see" files on a WinXP filesystem o kern/68978 fs [panic] [ufs] crashes with failing hard disk, loose po o kern/65920 fs [nwfs] Mounted Netware filesystem behaves strange o kern/65901 fs [smbfs] [patch] smbfs fails fsx write/truncate-down/tr o kern/61503 fs [smbfs] mount_smbfs does not work as non-root o kern/55617 fs [smbfs] Accessing an nsmb-mounted drive via a smb expo o kern/51685 fs [hang] Unbounded inode allocation causes kernel to loc o kern/51583 fs [nullfs] [patch] allow to work with devices and socket o kern/36566 fs [smbfs] System reboot with dead smb mount and umount o kern/18874 fs [2TB] 32bit NFS servers export wrong negative values t 155 problems total. From owner-freebsd-fs@FreeBSD.ORG Mon Jan 4 16:17:26 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 20F20106568F; Mon, 4 Jan 2010 16:17:26 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EBDC98FC21; Mon, 4 Jan 2010 16:17:25 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o04GHP2R044097; Mon, 4 Jan 2010 16:17:25 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o04GHPZI044093; Mon, 4 Jan 2010 16:17:25 GMT (envelope-from linimon) Date: Mon, 4 Jan 2010 16:17:25 GMT Message-Id: <201001041617.o04GHPZI044093@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-amd64@FreeBSD.org, freebsd-fs@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: kern/142306: [zfs] [panic] ZFS drive (from OSX Leopard) causes two kernel panics X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2010 16:17:26 -0000 Old Synopsis: ZFS (from OSX Leopard) causes two kernel panics New Synopsis: [zfs] [panic] ZFS drive (from OSX Leopard) causes two kernel panics Responsible-Changed-From-To: freebsd-amd64->freebsd-fs Responsible-Changed-By: linimon Responsible-Changed-When: Mon Jan 4 16:15:58 UTC 2010 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=142306 From owner-freebsd-fs@FreeBSD.ORG Wed Jan 6 08:23:19 2010 Return-Path: Delivered-To: fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 15A2510656A3; Wed, 6 Jan 2010 08:23:19 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id C2CFC8FC1B; Wed, 6 Jan 2010 08:23:18 +0000 (UTC) Received: from outgoing.leidinger.net (pD9E2C252.dip.t-dialin.net [217.226.194.82]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 5E946A5FF; Wed, 6 Jan 2010 09:23:12 +0100 (CET) Received: from unknown (unknown [192.168.2.110]) by outgoing.leidinger.net (Postfix) with ESMTP id 58E3C19AD9B; Wed, 6 Jan 2010 09:23:08 +0100 (CET) Date: Wed, 6 Jan 2010 09:23:07 +0100 From: Alexander Leidinger To: fs@freebsd.org Message-ID: <20100106092307.00007a42@unknown> In-Reply-To: <20091230155910.21474ubpm9u244qo@webmail.leidinger.net> References: <20091230155910.21474ubpm9u244qo@webmail.leidinger.net> X-Mailer: Claws Mail 3.7.2cvs15 (GTK+ 2.16.0; i586-pc-mingw32msvc) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 5E946A5FF.8C615 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-1.363, required 6, autolearn=disabled, ALL_TRUSTED -1.44, TW_SK 0.08) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1263370993.62981@BRtK3vX9N7LncDDgTpaUVA X-EBL-Spam-Status: No Cc: stable@freebsd.org Subject: Re: Some fixes for ZFS on 7-stable (more testers wanted) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2010 08:23:19 -0000 On Wed, 30 Dec 2009 15:59:10 +0100 Alexander Leidinger wrote: > Hi, > > I backported some changes from 8-stable to 7-stable, I have this > running on one 7-stable machine. I would like to get some more > feedback for it (even an "it works for me" would be great). The main > part of this change is that the FreeBSD taskqueue is used now > instead of the opensolaris one (a more detailed list is below). I committed this. On my system I didn't see more unstable behavior with this patch, as I was seeing without this patch. I will continue with merging more ZFS fixes to 7-stable. Bye, Alexander. From owner-freebsd-fs@FreeBSD.ORG Wed Jan 6 09:55:31 2010 Return-Path: Delivered-To: fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C1CFD106568B for ; Wed, 6 Jan 2010 09:55:31 +0000 (UTC) (envelope-from mgamsjager@gmail.com) Received: from mail-bw0-f213.google.com (mail-bw0-f213.google.com [209.85.218.213]) by mx1.freebsd.org (Postfix) with ESMTP id 54E778FC18 for ; Wed, 6 Jan 2010 09:55:31 +0000 (UTC) Received: by bwz5 with SMTP id 5so10830761bwz.3 for ; Wed, 06 Jan 2010 01:55:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=olplhzLCartEzaouDv98W23/4EBJmUNeZUGfOGqKNAQ=; b=nJiwj8/xGzKNjk+mGE/2jUvwCyHmPQ3wo5T3qMr9hUbQtvXgQZe8AC0PM7yMt33POk moMTyYfRMr/F6qhXD3qADpqvIYH8oSVdk5In/QUIswkIMpMjIt6bk+zh8wn5bTBh/vSR LYOM5ov8Lwf1dd0ZG/6apZjIE3vD4vew+J4hc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=t++jWD9RRPO2Q3hfQs8A2lW9AOTbWyOCgOpx424A8cP4iMJh+rH+1LPvcGGlAtdJSM sLKaRqKRFFs1QEBJc5guFM+g9U8sLPaV81nbFwIBLe4XPDpWGo8uskwvaQT7+9Xl8lkp 74zgMhp3w8dWCanWyAU5LCDEXbhVpywCbgPLY= MIME-Version: 1.0 Received: by 10.204.25.67 with SMTP id y3mr16383122bkb.187.1262770122154; Wed, 06 Jan 2010 01:28:42 -0800 (PST) From: Matthias Gamsjager Date: Wed, 6 Jan 2010 10:28:19 +0100 Message-ID: <585602e11001060128w4bd0cbabl90d30b4338043090@mail.gmail.com> To: fs@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Subject: ZFS v14 -> 8-stable X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2010 09:55:31 -0000 Hi, Any idea when kern/141800 will be MFC'd to 8-stable? Bye, Matthias From owner-freebsd-fs@FreeBSD.ORG Wed Jan 6 09:56:14 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 54BDE106566C for ; Wed, 6 Jan 2010 09:56:14 +0000 (UTC) (envelope-from mgamsjager@gmail.com) Received: from mail-bw0-f213.google.com (mail-bw0-f213.google.com [209.85.218.213]) by mx1.freebsd.org (Postfix) with ESMTP id DE9EF8FC18 for ; Wed, 6 Jan 2010 09:56:13 +0000 (UTC) Received: by bwz5 with SMTP id 5so10831076bwz.3 for ; Wed, 06 Jan 2010 01:56:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=WeJe3abTGQNUO57o6jeGo+jAAeK62JNn/l4bb7c/iW8=; b=e08TCZKjqRJWzNX/FQGBsAlhCKU0ZiPiwv04gKfcHgISx+nrcSvlIxtngXJIO9nLqV Yj2Co+lsYWWOAnFCY15LIiGHuIyTYTN4Y4ci/XkmOPA+zVDmMSwqX6oRMNSpKU27Uojs iA2hFdIJCgne1aXSP7Ohndd9dRFJEh6OKRPqc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=PxFAMLLChFnFKH+ifPA7hm2J9GbwZ8s1uly7icCdG3JGgM0PoxItYDRzqjqiDNncWX KbnIwihXxvsEfi9xMdiv+vW2j757nSZdG9SCFeDtzbdzVSGV33roWAzgKgb1viKmDKPh OEIwR7ZWJxnYbnZiVCcPopk7rT7ri4dOz1LOQ= MIME-Version: 1.0 Received: by 10.204.148.85 with SMTP id o21mr3117144bkv.134.1262770411731; Wed, 06 Jan 2010 01:33:31 -0800 (PST) From: Matthias Gamsjager Date: Wed, 6 Jan 2010 10:33:09 +0100 Message-ID: <585602e11001060133k68ccfd4ep81987f155960769c@mail.gmail.com> To: freebsd-fs@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: ZFS v14 -> 8-stable X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2010 09:56:14 -0000 Hi, Any idea when kern/141800 will be MFC'd to 8-stable? Bye, Matthias From owner-freebsd-fs@FreeBSD.ORG Wed Jan 6 10:14:06 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 07027106568B for ; Wed, 6 Jan 2010 10:14:06 +0000 (UTC) (envelope-from artemb@gmail.com) Received: from mail-iw0-f198.google.com (mail-iw0-f198.google.com [209.85.223.198]) by mx1.freebsd.org (Postfix) with ESMTP id C31708FC18 for ; Wed, 6 Jan 2010 10:14:05 +0000 (UTC) Received: by iwn36 with SMTP id 36so11578426iwn.3 for ; Wed, 06 Jan 2010 02:13:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type; bh=hO1iyNEgRNyd3f1fVhrrGsOJviAj52oceWpBbai57Kg=; b=Bmq/RpWe1V0QfPfTdm6z7A1ksc9Aqp0OvM+kN6bcYWiC+85edCBB6KlJlCDCwF1CXJ sE1+GTzPy0M2TQNMsSbaeD6V6C4DEteOTA2mfVQGo6sEo8qOICyohWbujPW8yrXZqNvR ZfDICxV8QqavKHqYAnd1qKjRk2OJhLS2djcdc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=uHbjyCI7+Uq8t+1jFpNOh0sZ7mQAdLbojQlN8BmoRxV0KOAHMXIOreM0iONVg5mmvv v5UfhVmt9yjxVzcVJSY0ZwGg4tVAe+crlnLXUV5J71Ii2HmL8THOiByvjGU60u8bwIJB 7V7//VuWdynhuSUL1oDtfhJJCl2lFIsr3SvMQ= MIME-Version: 1.0 Sender: artemb@gmail.com Received: by 10.231.147.210 with SMTP id m18mr764763ibv.48.1262772833198; Wed, 06 Jan 2010 02:13:53 -0800 (PST) In-Reply-To: <585602e11001060133k68ccfd4ep81987f155960769c@mail.gmail.com> References: <585602e11001060133k68ccfd4ep81987f155960769c@mail.gmail.com> Date: Wed, 6 Jan 2010 02:13:53 -0800 X-Google-Sender-Auth: 1362643e0feb53b7 Message-ID: From: Artem Belevich To: Matthias Gamsjager Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-fs@freebsd.org Subject: Re: ZFS v14 -> 8-stable X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2010 10:14:06 -0000 >From the commit message included in the PR you've linked to: PR: kern/141800 Submitted by: mm Reviewed by: pjd, trasz Obtained from: OpenSolaris MFC after: 2 weeks I guess we'll see it in -8 in a couple of weeks. --Artem On Wed, Jan 6, 2010 at 1:33 AM, Matthias Gamsjager wrote: > Hi, > > Any idea when kern/141800 > will be MFC'd to 8-stable? > > > Bye, > Matthias > _______________________________________________ > freebsd-fs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" > From owner-freebsd-fs@FreeBSD.ORG Wed Jan 6 10:16:35 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 28ABB106568B for ; Wed, 6 Jan 2010 10:16:35 +0000 (UTC) (envelope-from delphij@gmail.com) Received: from mail-pw0-f44.google.com (mail-pw0-f44.google.com [209.85.160.44]) by mx1.freebsd.org (Postfix) with ESMTP id F41F98FC18 for ; Wed, 6 Jan 2010 10:16:34 +0000 (UTC) Received: by pwi15 with SMTP id 15so11954948pwi.3 for ; Wed, 06 Jan 2010 02:16:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=ZH9sDLSZjGSmpUbMt0KSljZxx8inW2zb72JR7zNUQNo=; b=D3pech5VaeQZiFzASYxuuRyLnGPGxR2w9JGaERBCblx0ZD9smHHYDJV/7HflzYRZj/ y1//vuPzTu07oLfkxpDK86RqdoWjD0cykrarh0QwqhFzTcEDvZPvsNVLvh7thqWwAFUj NOaEj+tdIOfpsu0Io5UdcAPCxTrc0EU71FZsQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=bhbsTq00VDzMra+/m41GWDg3NgPxLQUDySMHLmx+fr+Dvzds/xjiLCXB9+YUG1fY/m TR0sYet50MIvvQdFjcWX9V7l5EcMdr58fNN+14rs+lLMj6wnonAo7iiW+HD0KLJFmqfb lFEzFS72HSDBe80Apt/EOLUjI4q5dGs/hchro= MIME-Version: 1.0 Received: by 10.115.102.18 with SMTP id e18mr4340718wam.174.1262772982742; Wed, 06 Jan 2010 02:16:22 -0800 (PST) In-Reply-To: References: <585602e11001060133k68ccfd4ep81987f155960769c@mail.gmail.com> Date: Wed, 6 Jan 2010 02:16:22 -0800 Message-ID: From: Xin LI To: Artem Belevich Content-Type: text/plain; charset=UTF-8 Cc: freebsd-fs@freebsd.org Subject: Re: ZFS v14 -> 8-stable X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2010 10:16:35 -0000 On Wed, Jan 6, 2010 at 2:13 AM, Artem Belevich wrote: > >From the commit message included in the PR you've linked to: > > PR: kern/141800 > Submitted by: mm > Reviewed by: pjd, trasz > Obtained from: OpenSolaris > MFC after: 2 weeks > > I guess we'll see it in -8 in a couple of weeks. Yes. Actually I just set up a test 8.0 system yesterday right before I left office. Unless the test would find some breaking regression I'll MFC it as scheduled. Cheers, -- Xin LI http://www.delphij.net From owner-freebsd-fs@FreeBSD.ORG Wed Jan 6 10:19:51 2010 Return-Path: Delivered-To: fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4B2CE10656C1 for ; Wed, 6 Jan 2010 10:19:51 +0000 (UTC) (envelope-from delphij@gmail.com) Received: from mail-px0-f182.google.com (mail-px0-f182.google.com [209.85.216.182]) by mx1.freebsd.org (Postfix) with ESMTP id 244618FC18 for ; Wed, 6 Jan 2010 10:19:50 +0000 (UTC) Received: by pxi12 with SMTP id 12so11254040pxi.3 for ; Wed, 06 Jan 2010 02:19:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=JJjJ79WNmKl7k/CvNVwiWyeRPdwSWcs332ZAZtjs5N4=; b=ll5suTUg0JKPBJLt7+8JANXdYAzYq45JW/aIxnWXzijpqwJWId/u88iKGsAztUtb89 fQin41fH+UyAKxbiAp7SuvuUeGUpG+EPpTaThqt8nNGGH7RSl67+i4h8KLzSdow7+CRh DFn64M5+FhhUDN/37E4PeMzbPV/kGbotk2om4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=nRfE+yhrzrG/yf5ompk8ely4dywq9AhMQig7T5Wp0FnMOkCXXcKMQhHGR0W2hjGHZu K00sU7EkxJmJ2klEhk49D0dHAZf/MuiuhdsxKiPvTGx27s8QklTUQSw6vkRnDFNwXXKz zw9A8UUdyUBMPC9bOH7DRAurJbOFjzcAH+9GI= MIME-Version: 1.0 Received: by 10.114.236.22 with SMTP id j22mr453598wah.217.1262771821908; Wed, 06 Jan 2010 01:57:01 -0800 (PST) In-Reply-To: <585602e11001060128w4bd0cbabl90d30b4338043090@mail.gmail.com> References: <585602e11001060128w4bd0cbabl90d30b4338043090@mail.gmail.com> Date: Wed, 6 Jan 2010 01:57:01 -0800 Message-ID: From: Xin LI To: Matthias Gamsjager Content-Type: text/plain; charset=UTF-8 Cc: fs@freebsd.org Subject: Re: ZFS v14 -> 8-stable X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2010 10:19:51 -0000 On Wed, Jan 6, 2010 at 1:28 AM, Matthias Gamsjager wrote: > Hi, > > Any idea when kern/141800 > will be MFC'd to 8-stable? I'll need to do some testing and make sure there is no overlooked problem with it. Cheers, -- Xin LI http://www.delphij.net From owner-freebsd-fs@FreeBSD.ORG Wed Jan 6 10:23:29 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9E9881065692 for ; Wed, 6 Jan 2010 10:23:29 +0000 (UTC) (envelope-from mgamsjager@gmail.com) Received: from mail-bw0-f213.google.com (mail-bw0-f213.google.com [209.85.218.213]) by mx1.freebsd.org (Postfix) with ESMTP id 297C68FC20 for ; Wed, 6 Jan 2010 10:23:28 +0000 (UTC) Received: by bwz5 with SMTP id 5so10843069bwz.3 for ; Wed, 06 Jan 2010 02:23:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=fXuX1ubZV/alqNSArUX/ozbB9uL0e7+yjBj3Gf4tUmw=; b=Rki484fkESAfQYbIClGfUVBNnA6/FGo12Y+MCPhALzyzfqEZVYzdKHPoEQsPnpq+70 0ASWjfetOl7WLXbwXpEQ6U5PGVxdDsXT1wDqt+RbHyHQ+IcyHAhzAdoFYKS0nj90Rmez 55AsyTw3USCJ5WfdNSmXaNTXTH/hYeppZ4mMU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=tDmj33K/Fmz3h9LfbHHKJ7wKwduikqOPfiGMbqKVSqbPvLRoIiXJC92seswB7uUrbJ o7/LO7Omz9lU40976mTWs+e2Hk+hI7FPqUWprVvhN/ak7/Mt1mLNxIoIFOLtjaCx5Ykw 9b3NES430j/tOIIxIJJIZ6Qhsev2+GgUefB4w= MIME-Version: 1.0 Received: by 10.204.9.131 with SMTP id l3mr2163059bkl.38.1262773405137; Wed, 06 Jan 2010 02:23:25 -0800 (PST) In-Reply-To: References: <585602e11001060133k68ccfd4ep81987f155960769c@mail.gmail.com> From: Matthias Gamsjager Date: Wed, 6 Jan 2010 11:23:05 +0100 Message-ID: <585602e11001060223h7656c4f5s20e8b27f3bb7130c@mail.gmail.com> To: Artem Belevich Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-fs@freebsd.org Subject: Re: ZFS v14 -> 8-stable X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2010 10:23:29 -0000 Guess I missed that :/ but nevertheless i'm looking forward to it :) On Wed, Jan 6, 2010 at 11:13 AM, Artem Belevich wrote: > From the commit message included in the PR you've linked to: > > PR: kern/141800 > Submitted by: mm > Reviewed by: pjd, trasz > Obtained from: OpenSolaris > MFC after: 2 weeks > > I guess we'll see it in -8 in a couple of weeks. > > --Artem > > > > On Wed, Jan 6, 2010 at 1:33 AM, Matthias Gamsjager > wrote: > > Hi, > > > > Any idea when kern/141800< > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/141800> > > will be MFC'd to 8-stable? > > > > > > Bye, > > Matthias > > _______________________________________________ > > freebsd-fs@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-fs > > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" > > > From owner-freebsd-fs@FreeBSD.ORG Wed Jan 6 22:10:34 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F3B2106568B; Wed, 6 Jan 2010 22:10:34 +0000 (UTC) (envelope-from mattjreimer@gmail.com) Received: from mail-gx0-f209.google.com (mail-gx0-f209.google.com [209.85.217.209]) by mx1.freebsd.org (Postfix) with ESMTP id 4C10F8FC23; Wed, 6 Jan 2010 22:10:34 +0000 (UTC) Received: by gxk1 with SMTP id 1so5642960gxk.14 for ; Wed, 06 Jan 2010 14:10:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type; bh=kUJkS6iCAj+aDkKzROkliJX5gldDLxYSopBbnQCRu8c=; b=mV1lks+T2FSg5tyxNBmHs4iNsBOpLR9PufU5nltaoFu2uUJJ6BKzkSRGQ9SyfEA8Yw kuk9X18WmOSk2GSnnHr8Er8LhbyWf+F0O9+DC0tnBauEIEfJzurU8bIHZAfjSDjuRsBF I9zspJU5O1fKiBgngrLMa0MicxtuK94MuJ1m0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=tU8SI8CJqnK8kL3w84ORipOEcHxoKYYuhPJR5cXvFEzsUElaMig/8RubuG2CCQjUPX UU8UkNaWw9U4hyUtVwCXOvc21yunobvrmu5IsWZ3SPavVMLwlQiO+t+eulBcDhyGz0t+ SDFIK5qApZBGJBabl99k6G15/iAQESNZEPOc8= MIME-Version: 1.0 Received: by 10.151.88.17 with SMTP id q17mr15702691ybl.190.1262815828628; Wed, 06 Jan 2010 14:10:28 -0800 (PST) Date: Wed, 6 Jan 2010 14:10:28 -0800 Message-ID: From: Matt Reimer To: freebsd-fs , Doug Rabson , Pawel Jakub Dawidek Content-Type: multipart/mixed; boundary=000e0cd7040ae20e63047c86387f Cc: Subject: PATCH: more efficient raidz memory usage for (gpt)zfsboot, zfsloader X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2010 22:10:34 -0000 --000e0cd7040ae20e63047c86387f Content-Type: text/plain; charset=ISO-8859-1 Would one of you be able to review this patch and commit it if it's acceptable? This is the same patch I submitted last month. Matt ---- Teach the (gpt)zfsboot and zfsloader raidz code to use its buffers more efficiently. Before this patch, in the worst case memory use would increase exponentially on the number of drives in the raidz vdev. Sponsored by: VPOP Technologies, Inc. Matt Reimer --000e0cd7040ae20e63047c86387f Content-Type: application/octet-stream; name="raidz-mem.patch" Content-Disposition: attachment; filename="raidz-mem.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g37tvwgu0 LS0tIC9zeXMvY2RkbC9ib290L3pmcy96ZnNzdWJyLmMuT1JJRwkyMDA5LTExLTE0IDA4OjE0OjUx LjAwMDAwMDAwMCAtMDgwMAorKysgL3N5cy9jZGRsL2Jvb3QvemZzL3pmc3N1YnIuYwkyMDA5LTEy LTA3IDE1OjI3OjQ5LjAwMDAwMDAwMCAtMDgwMApAQCAtNDU0LDcgKzQ1NCw3IEBACiAKIHN0YXRp YyB2b2lkCiB2ZGV2X3JhaWR6X3JlY29uc3RydWN0X3BxKHJhaWR6X2NvbF90ICpjb2xzLCBpbnQg bnBhcml0eSwgaW50IGFjb2xzLAotICAgIGludCB4LCBpbnQgeSkKKyAgICBpbnQgeCwgaW50IHks IHZvaWQgKnRlbXBfcCwgdm9pZCAqdGVtcF9xKQogewogCXVpbnQ4X3QgKnAsICpxLCAqcHh5LCAq cXh5LCAqeGQsICp5ZCwgdG1wLCBhLCBiLCBhZXhwLCBiZXhwOwogCXZvaWQgKnBkYXRhLCAqcWRh dGE7CkBAIC00NzgsMTAgKzQ3OCw4IEBACiAJeHNpemUgPSBjb2xzW3hdLnJjX3NpemU7CiAJeXNp emUgPSBjb2xzW3ldLnJjX3NpemU7CiAKLQljb2xzW1ZERVZfUkFJRFpfUF0ucmNfZGF0YSA9Ci0J CXpmc19hbGxvY190ZW1wKGNvbHNbVkRFVl9SQUlEWl9QXS5yY19zaXplKTsKLQljb2xzW1ZERVZf UkFJRFpfUV0ucmNfZGF0YSA9Ci0JCXpmc19hbGxvY190ZW1wKGNvbHNbVkRFVl9SQUlEWl9RXS5y Y19zaXplKTsKKwljb2xzW1ZERVZfUkFJRFpfUF0ucmNfZGF0YSA9IHRlbXBfcDsKKwljb2xzW1ZE RVZfUkFJRFpfUV0ucmNfZGF0YSA9IHRlbXBfcTsKIAljb2xzW3hdLnJjX3NpemUgPSAwOwogCWNv bHNbeV0ucmNfc2l6ZSA9IDA7CiAKQEAgLTU1MSw5ICs1NDksMTIgQEAKIAl1aW50NjRfdCBmID0g YiAlIGRjb2xzOwogCXVpbnQ2NF90IG8gPSAoYiAvIGRjb2xzKSA8PCB1bml0X3NoaWZ0OwogCXVp bnQ2NF90IHEsIHIsIGNvZmY7Ci0JaW50IGMsIGMxLCBiYywgY29sLCBhY29scywgZGV2aWR4LCBh c2l6ZSwgbjsKKwlpbnQgYywgYzEsIGJjLCBjb2wsIGFjb2xzLCBkZXZpZHgsIGFzaXplLCBuLCBt YXhfcmNfc2l6ZTsKIAlzdGF0aWMgcmFpZHpfY29sX3QgY29sc1sxNl07CiAJcmFpZHpfY29sX3Qg KnJjLCAqcmMxOworCXZvaWQgKm9yaWcsICpvcmlnMSwgKnRlbXBfcCwgKnRlbXBfcTsKKworCW9y aWcgPSBvcmlnMSA9IHRlbXBfcCA9IHRlbXBfcSA9IE5VTEw7CiAKIAlxID0gcyAvIChkY29scyAt IG5wYXJpdHkpOwogCXIgPSBzIC0gcSAqIChkY29scyAtIG5wYXJpdHkpOwpAQCAtNTYxLDYgKzU2 Miw3IEBACiAKIAlhY29scyA9IChxID09IDAgPyBiYyA6IGRjb2xzKTsKIAlhc2l6ZSA9IDA7CisJ bWF4X3JjX3NpemUgPSAwOwogCQogCWZvciAoYyA9IDA7IGMgPCBhY29sczsgYysrKSB7CiAJCWNv bCA9IGYgKyBjOwpAQCAtNTc3LDYgKzU3OSw4IEBACiAJCWNvbHNbY10ucmNfdHJpZWQgPSAwOwog CQljb2xzW2NdLnJjX3NraXBwZWQgPSAwOwogCQlhc2l6ZSArPSBjb2xzW2NdLnJjX3NpemU7CisJ CWlmIChjb2xzW2NdLnJjX3NpemUgPiBtYXhfcmNfc2l6ZSkKKwkJCW1heF9yY19zaXplID0gY29s c1tjXS5yY19zaXplOwogCX0KIAogCWFzaXplID0gcm91bmR1cChhc2l6ZSwgKG5wYXJpdHkgKyAx KSA8PCB1bml0X3NoaWZ0KTsKQEAgLTc3Nyw4ICs3ODEsMTMgQEAKIAkJCS8vQVNTRVJUKGMgIT0g YWNvbHMpOwogCQkJLy9BU1NFUlQoIXJjLT5yY19za2lwcGVkIHx8IHJjLT5yY19lcnJvciA9PSBF TlhJTyB8fCByYy0+cmNfZXJyb3IgPT0gRVNUQUxFKTsKIAorCQkJaWYgKCF0ZW1wX3ApCisJCQkJ dGVtcF9wID0gemZzX2FsbG9jX3RlbXAobWF4X3JjX3NpemUpOworCQkJaWYgKCF0ZW1wX3EpCisJ CQkJdGVtcF9xID0gemZzX2FsbG9jX3RlbXAobWF4X3JjX3NpemUpOworCiAJCQl2ZGV2X3JhaWR6 X3JlY29uc3RydWN0X3BxKGNvbHMsIG5wYXJpdHksIGFjb2xzLAotCQkJICAgIGMxLCBjKTsKKwkJ CSAgICBjMSwgYywgdGVtcF9wLCB0ZW1wX3EpOwogCiAJCQlpZiAoemlvX2NoZWNrc3VtX2Vycm9y KGJwLCBidWYpID09IDApCiAJCQkJcmV0dXJuICgwKTsKQEAgLTg0NSwxOCArODU0LDEyIEBACiAJ CXJldHVybiAoRUlPKTsKIAl9CiAKLQlhc2l6ZSA9IDA7Ci0JZm9yIChjID0gMDsgYyA8IGFjb2xz OyBjKyspIHsKLQkJcmMgPSAmY29sc1tjXTsKLQkJaWYgKHJjLT5yY19zaXplID4gYXNpemUpCi0J CQlhc2l6ZSA9IHJjLT5yY19zaXplOwotCX0KIAlpZiAoY29sc1tWREVWX1JBSURaX1BdLnJjX2Vy cm9yID09IDApIHsKIAkJLyoKIAkJICogQXR0ZW1wdCB0byByZWNvbnN0cnVjdCB0aGUgZGF0YSBm cm9tIHBhcml0eSBQLgogCQkgKi8KLQkJdm9pZCAqb3JpZzsKLQkJb3JpZyA9IHpmc19hbGxvY190 ZW1wKGFzaXplKTsKKwkJaWYgKCFvcmlnKQorCQkJb3JpZyA9IHpmc19hbGxvY190ZW1wKG1heF9y Y19zaXplKTsKIAkJZm9yIChjID0gbnBhcml0eTsgYyA8IGFjb2xzOyBjKyspIHsKIAkJCXJjID0g JmNvbHNbY107CiAKQEAgLTg3NCw4ICs4NzcsOCBAQAogCQkvKgogCQkgKiBBdHRlbXB0IHRvIHJl Y29uc3RydWN0IHRoZSBkYXRhIGZyb20gcGFyaXR5IFEuCiAJCSAqLwotCQl2b2lkICpvcmlnOwot CQlvcmlnID0gemZzX2FsbG9jX3RlbXAoYXNpemUpOworCQlpZiAoIW9yaWcpCisJCQlvcmlnID0g emZzX2FsbG9jX3RlbXAobWF4X3JjX3NpemUpOwogCQlmb3IgKGMgPSBucGFyaXR5OyBjIDwgYWNv bHM7IGMrKykgewogCQkJcmMgPSAmY29sc1tjXTsKIApAQCAtODk1LDkgKzg5OCwxNCBAQAogCQkv KgogCQkgKiBBdHRlbXB0IHRvIHJlY29uc3RydWN0IHRoZSBkYXRhIGZyb20gYm90aCBQIGFuZCBR LgogCQkgKi8KLQkJdm9pZCAqb3JpZywgKm9yaWcxOwotCQlvcmlnID0gemZzX2FsbG9jX3RlbXAo YXNpemUpOwotCQlvcmlnMSA9IHpmc19hbGxvY190ZW1wKGFzaXplKTsKKwkJaWYgKCFvcmlnKQor CQkJb3JpZyA9IHpmc19hbGxvY190ZW1wKG1heF9yY19zaXplKTsKKwkJaWYgKCFvcmlnMSkKKwkJ CW9yaWcxID0gemZzX2FsbG9jX3RlbXAobWF4X3JjX3NpemUpOworCQlpZiAoIXRlbXBfcCkKKwkJ CXRlbXBfcCA9IHpmc19hbGxvY190ZW1wKG1heF9yY19zaXplKTsKKwkJaWYgKCF0ZW1wX3EpCisJ CQl0ZW1wX3EgPSB6ZnNfYWxsb2NfdGVtcChtYXhfcmNfc2l6ZSk7CiAJCWZvciAoYyA9IG5wYXJp dHk7IGMgPCBhY29scyAtIDE7IGMrKykgewogCQkJcmMgPSAmY29sc1tjXTsKIApAQCAtOTA5LDcg KzkxNyw3IEBACiAJCQkJbWVtY3B5KG9yaWcxLCByYzEtPnJjX2RhdGEsIHJjMS0+cmNfc2l6ZSk7 CiAKIAkJCQl2ZGV2X3JhaWR6X3JlY29uc3RydWN0X3BxKGNvbHMsIG5wYXJpdHksCi0JCQkJICAg IGFjb2xzLCBjLCBjMSk7CisJCQkJICAgIGFjb2xzLCBjLCBjMSwgdGVtcF9wLCB0ZW1wX3EpOwog CiAJCQkJaWYgKHppb19jaGVja3N1bV9lcnJvcihicCwgYnVmKSA9PSAwKQogCQkJCQlyZXR1cm4g KDApOwo= --000e0cd7040ae20e63047c86387f-- From owner-freebsd-fs@FreeBSD.ORG Wed Jan 6 22:12:02 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AA4FD106568F; Wed, 6 Jan 2010 22:12:02 +0000 (UTC) (envelope-from mattjreimer@gmail.com) Received: from mail-yw0-f197.google.com (mail-yw0-f197.google.com [209.85.211.197]) by mx1.freebsd.org (Postfix) with ESMTP id 46A448FC18; Wed, 6 Jan 2010 22:12:02 +0000 (UTC) Received: by ywh35 with SMTP id 35so8992640ywh.7 for ; Wed, 06 Jan 2010 14:11:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=FvSwZ0WAia3j2sN19Sz+yakHDmV6vP0QQ4F+4wjEh0I=; b=TUlPxrL992E6Sk+pZ3Sg4CPXDIEkMJ9Rf9cEwLX0p2V/PiAl9tlyg85/2fBDuEucX0 S4tK4afQ00qEYic69wkSAs/fiC+D07yQo7FYQCF81UjpP/PFz6Rrj/1D6xWbfU6aPfYK 99I4eBexNZsqH4DMd2/MTwUCFoOj6sxp77zqs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=MCIMuw+wlfE1kbjCKRvtfN6NRV+jjFEQ4VPpoebpocGgxQ5LvyaNF5aac0+ScFXcWH OGoSG+mUxK6pS9dcG6A7QwxHxCT/Zul0HDxoCTe/yF/xK3UHGTEv4OMT+xXaYD7APh7j xAMxCiOqB71Q22gAL5hzrPt5OzikqFOyx+Tc8= MIME-Version: 1.0 Received: by 10.151.89.39 with SMTP id r39mr2094144ybl.254.1262815916525; Wed, 06 Jan 2010 14:11:56 -0800 (PST) In-Reply-To: References: Date: Wed, 6 Jan 2010 14:11:56 -0800 Message-ID: From: Matt Reimer To: freebsd-fs , Doug Rabson , Pawel Jakub Dawidek Content-Type: multipart/mixed; boundary=000e0cd729021f29f6047c863ea1 Cc: Subject: Fwd: PATCH: teach (gpt)zfsboot, zfsloader to discern vdev status correctly X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2010 22:12:02 -0000 --000e0cd729021f29f6047c863ea1 Content-Type: text/plain; charset=ISO-8859-1 Would one of you be able to review this patch and commit it if it's acceptable? This is the same patch I submitted last month. Matt ---- Instead of assuming all vdevs are healthy, check the newest vdev label for each vdev's status. Booting from a degraded vdev should now be more robust. Sponsored by: VPOP Technologies, Inc. Matt Reimer (Note that much of this patch is merely whitespace change due to a block needing to be reindented. I've attached correct-status-nowhitespace.patch to make review easier.) --000e0cd729021f29f6047c863ea1 Content-Type: application/octet-stream; name="correct-status.patch" Content-Disposition: attachment; filename="correct-status.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g37u1j5r0 LS0tIC9zeXMvY2RkbC9ib290L3pmcy96ZnNpbXBsLmguT1JJRwkyMDA5LTExLTIxIDA3OjAyOjM1 LjAwMDAwMDAwMCAtMDgwMAorKysgL3N5cy9jZGRsL2Jvb3QvemZzL3pmc2ltcGwuaAkyMDA5LTEy LTA3IDEzOjUwOjI2LjAwMDAwMDAwMCAtMDgwMApAQCAtNTQ2LDcgKzU0Niw2IEBACiAjZGVmaW5l CVpQT09MX0NPTkZJR19EVEwJCSJEVEwiCiAjZGVmaW5lCVpQT09MX0NPTkZJR19TVEFUUwkJInN0 YXRzIgogI2RlZmluZQlaUE9PTF9DT05GSUdfV0hPTEVfRElTSwkJIndob2xlX2Rpc2siCi0jZGVm aW5lCVpQT09MX0NPTkZJR19PRkZMSU5FCQkib2ZmbGluZSIKICNkZWZpbmUJWlBPT0xfQ09ORklH X0VSUkNPVU5UCQkiZXJyb3JfY291bnQiCiAjZGVmaW5lCVpQT09MX0NPTkZJR19OT1RfUFJFU0VO VAkibm90X3ByZXNlbnQiCiAjZGVmaW5lCVpQT09MX0NPTkZJR19TUEFSRVMJCSJzcGFyZXMiCkBA IC01NTYsNiArNTU1LDE2IEBACiAjZGVmaW5lCVpQT09MX0NPTkZJR19IT1NUTkFNRQkJImhvc3Ru YW1lIgogI2RlZmluZQlaUE9PTF9DT05GSUdfVElNRVNUQU1QCQkidGltZXN0YW1wIiAvKiBub3Qg c3RvcmVkIG9uIGRpc2sgKi8KIAorLyoKKyAqIFRoZSBwZXJzaXN0ZW50IHZkZXYgc3RhdGUgaXMg c3RvcmVkIGFzIHNlcGFyYXRlIHZhbHVlcyByYXRoZXIgdGhhbiBhIHNpbmdsZQorICogJ3ZkZXZf c3RhdGUnIGVudHJ5LiAgVGhpcyBpcyBiZWNhdXNlIGEgZGV2aWNlIGNhbiBiZSBpbiBtdWx0aXBs ZSBzdGF0ZXMsIHN1Y2gKKyAqIGFzIG9mZmxpbmUgYW5kIGRlZ3JhZGVkLgorICovCisjZGVmaW5l IFpQT09MX0NPTkZJR19PRkZMSU5FICAgICAgICAgICAgIm9mZmxpbmUiCisjZGVmaW5lIFpQT09M X0NPTkZJR19GQVVMVEVEICAgICAgICAgICAgImZhdWx0ZWQiCisjZGVmaW5lIFpQT09MX0NPTkZJ R19ERUdSQURFRCAgICAgICAgICAgImRlZ3JhZGVkIgorI2RlZmluZSBaUE9PTF9DT05GSUdfUkVN T1ZFRCAgICAgICAgICAgICJyZW1vdmVkIgorCiAjZGVmaW5lCVZERVZfVFlQRV9ST09UCQkJInJv b3QiCiAjZGVmaW5lCVZERVZfVFlQRV9NSVJST1IJCSJtaXJyb3IiCiAjZGVmaW5lCVZERVZfVFlQ RV9SRVBMQUNJTkcJCSJyZXBsYWNpbmciCkBAIC01ODgsNyArNTk3LDkgQEAKIAlWREVWX1NUQVRF X1VOS05PV04gPSAwLAkvKiBVbmluaXRpYWxpemVkIHZkZXYJCQkqLwogCVZERVZfU1RBVEVfQ0xP U0VELAkvKiBOb3QgY3VycmVudGx5IG9wZW4JCQkqLwogCVZERVZfU1RBVEVfT0ZGTElORSwJLyog Tm90IGFsbG93ZWQgdG8gb3BlbgkJCSovCisgICAgICAgIFZERVZfU1RBVEVfUkVNT1ZFRCwJLyog RXhwbGljaXRseSByZW1vdmVkIGZyb20gc3lzdGVtCSovCiAJVkRFVl9TVEFURV9DQU5UX09QRU4s CS8qIFRyaWVkIHRvIG9wZW4sIGJ1dCBmYWlsZWQJCSovCisgICAgICAgIFZERVZfU1RBVEVfRkFV TFRFRCwJLyogRXh0ZXJuYWwgcmVxdWVzdCB0byBmYXVsdCBkZXZpY2UJKi8KIAlWREVWX1NUQVRF X0RFR1JBREVELAkvKiBSZXBsaWNhdGVkIHZkZXYgd2l0aCB1bmhlYWx0aHkga2lkcwkqLwogCVZE RVZfU1RBVEVfSEVBTFRIWQkvKiBQcmVzdW1lZCBnb29kCQkJKi8KIH0gdmRldl9zdGF0ZV90Owot LS0gL3N5cy9ib290L3pmcy96ZnNpbXBsLmMuT1JJRwkyMDA5LTExLTIxIDA3OjAyOjM1LjAwMDAw MDAwMCAtMDgwMAorKysgL3N5cy9ib290L3pmcy96ZnNpbXBsLmMJMjAwOS0xMi0wNyAxNDozNjoy MC4wMDAwMDAwMDAgLTA4MDAKQEAgLTQwNCw3ICs0MDQsNyBAQAogfQogCiBzdGF0aWMgaW50Ci12 ZGV2X2luaXRfZnJvbV9udmxpc3QoY29uc3QgdW5zaWduZWQgY2hhciAqbnZsaXN0LCB2ZGV2X3Qg Kip2ZGV2cCkKK3ZkZXZfaW5pdF9mcm9tX252bGlzdChjb25zdCB1bnNpZ25lZCBjaGFyICpudmxp c3QsIHZkZXZfdCAqKnZkZXZwLCBpbnQgaXNfbmV3ZXIpCiB7CiAJaW50IHJjOwogCXVpbnQ2NF90 IGd1aWQsIGlkLCBhc2hpZnQsIG5wYXJpdHk7CkBAIC00MTIsNyArNDEyLDggQEAKIAljb25zdCBj aGFyICpwYXRoOwogCXZkZXZfdCAqdmRldiwgKmtpZDsKIAljb25zdCB1bnNpZ25lZCBjaGFyICpr aWRzOwotCWludCBua2lkcywgaTsKKwlpbnQgbmtpZHMsIGksIGlzX25ldzsKKwl1aW50NjRfdCBp c19vZmZsaW5lLCBpc19mYXVsdGVkLCBpc19kZWdyYWRlZCwgaXNfcmVtb3ZlZDsKIAogCWlmIChu dmxpc3RfZmluZChudmxpc3QsIFpQT09MX0NPTkZJR19HVUlELAogCQkJREFUQV9UWVBFX1VJTlQ2 NCwgMCwgJmd1aWQpCkBAIC00MjQsMTcgKzQyNSw2IEBACiAJCXJldHVybiAoRU5PRU5UKTsKIAl9 CiAKLQkvKgotCSAqIEFzc3VtZSB0aGF0IGlmIHdlJ3ZlIHNlZW4gdGhpcyB2ZGV2IHRyZWUgYmVm b3JlLCB0aGlzIG9uZQotCSAqIHdpbGwgYmUgaWRlbnRpY2FsLgotCSAqLwotCXZkZXYgPSB2ZGV2 X2ZpbmQoZ3VpZCk7Ci0JaWYgKHZkZXYpIHsKLQkJaWYgKHZkZXZwKQotCQkJKnZkZXZwID0gdmRl djsKLQkJcmV0dXJuICgwKTsKLQl9Ci0KIAlpZiAoc3RyY21wKHR5cGUsIFZERVZfVFlQRV9NSVJS T1IpCiAJICAgICYmIHN0cmNtcCh0eXBlLCBWREVWX1RZUEVfRElTSykKIAkgICAgJiYgc3RyY21w KHR5cGUsIFZERVZfVFlQRV9SQUlEWikpIHsKQEAgLTQ0Miw0NCArNDMyLDk1IEBACiAJCXJldHVy biAoRUlPKTsKIAl9CiAKLQlpZiAoIXN0cmNtcCh0eXBlLCBWREVWX1RZUEVfTUlSUk9SKSkKLQkJ dmRldiA9IHZkZXZfY3JlYXRlKGd1aWQsIHZkZXZfbWlycm9yX3JlYWQpOwotCWVsc2UgaWYgKCFz dHJjbXAodHlwZSwgVkRFVl9UWVBFX1JBSURaKSkKLQkJdmRldiA9IHZkZXZfY3JlYXRlKGd1aWQs IHZkZXZfcmFpZHpfcmVhZCk7Ci0JZWxzZQotCQl2ZGV2ID0gdmRldl9jcmVhdGUoZ3VpZCwgdmRl dl9kaXNrX3JlYWQpOworCWlzX29mZmxpbmUgPSBpc19yZW1vdmVkID0gaXNfZmF1bHRlZCA9IGlz X2RlZ3JhZGVkID0gMDsKKworCW52bGlzdF9maW5kKG52bGlzdCwgWlBPT0xfQ09ORklHX09GRkxJ TkUsIERBVEFfVFlQRV9VSU5UNjQsIDAsCisJCQkmaXNfb2ZmbGluZSk7CisJbnZsaXN0X2ZpbmQo bnZsaXN0LCBaUE9PTF9DT05GSUdfUkVNT1ZFRCwgREFUQV9UWVBFX1VJTlQ2NCwgMCwKKwkJCSZp c19yZW1vdmVkKTsKKwludmxpc3RfZmluZChudmxpc3QsIFpQT09MX0NPTkZJR19GQVVMVEVELCBE QVRBX1RZUEVfVUlOVDY0LCAwLAorCQkJJmlzX2ZhdWx0ZWQpOworCW52bGlzdF9maW5kKG52bGlz dCwgWlBPT0xfQ09ORklHX0RFR1JBREVELCBEQVRBX1RZUEVfVUlOVDY0LCAwLAorCQkJJmlzX2Rl Z3JhZGVkKTsKKworCXZkZXYgPSB2ZGV2X2ZpbmQoZ3VpZCk7CisJaWYgKCF2ZGV2KSB7CisKKwkJ aXNfbmV3ID0gMTsKKworCQlpZiAoIXN0cmNtcCh0eXBlLCBWREVWX1RZUEVfTUlSUk9SKSkKKwkJ CXZkZXYgPSB2ZGV2X2NyZWF0ZShndWlkLCB2ZGV2X21pcnJvcl9yZWFkKTsKKwkJZWxzZSBpZiAo IXN0cmNtcCh0eXBlLCBWREVWX1RZUEVfUkFJRFopKQorCQkJdmRldiA9IHZkZXZfY3JlYXRlKGd1 aWQsIHZkZXZfcmFpZHpfcmVhZCk7CisJCWVsc2UKKwkJCXZkZXYgPSB2ZGV2X2NyZWF0ZShndWlk LCB2ZGV2X2Rpc2tfcmVhZCk7CisKKwkJdmRldi0+dl9pZCA9IGlkOworCQlpZiAobnZsaXN0X2Zp bmQobnZsaXN0LCBaUE9PTF9DT05GSUdfQVNISUZULAorCQkJREFUQV9UWVBFX1VJTlQ2NCwgMCwg JmFzaGlmdCkgPT0gMCkKKwkJCXZkZXYtPnZfYXNoaWZ0ID0gYXNoaWZ0OworCQllbHNlCisJCQl2 ZGV2LT52X2FzaGlmdCA9IDA7CisJCWlmIChudmxpc3RfZmluZChudmxpc3QsIFpQT09MX0NPTkZJ R19OUEFSSVRZLAorCQkJREFUQV9UWVBFX1VJTlQ2NCwgMCwgJm5wYXJpdHkpID09IDApCisJCQl2 ZGV2LT52X25wYXJpdHkgPSBucGFyaXR5OworCQllbHNlCisJCQl2ZGV2LT52X25wYXJpdHkgPSAw OworCQlpZiAobnZsaXN0X2ZpbmQobnZsaXN0LCBaUE9PTF9DT05GSUdfUEFUSCwKKwkJCQlEQVRB X1RZUEVfU1RSSU5HLCAwLCAmcGF0aCkgPT0gMCkgeworCQkJaWYgKHN0cmxlbihwYXRoKSA+IDUK KwkJCSAgICAmJiBwYXRoWzBdID09ICcvJworCQkJICAgICYmIHBhdGhbMV0gPT0gJ2QnCisJCQkg ICAgJiYgcGF0aFsyXSA9PSAnZScKKwkJCSAgICAmJiBwYXRoWzNdID09ICd2JworCQkJICAgICYm IHBhdGhbNF0gPT0gJy8nKQorCQkJCXBhdGggKz0gNTsKKwkJCXZkZXYtPnZfbmFtZSA9IHN0cmR1 cChwYXRoKTsKKwkJfSBlbHNlIHsKKwkJCWlmICghc3RyY21wKHR5cGUsICJyYWlkeiIpKSB7CisJ CQkJaWYgKHZkZXYtPnZfbnBhcml0eSA9PSAxKQorCQkJCQl2ZGV2LT52X25hbWUgPSAicmFpZHox IjsKKwkJCQllbHNlCisJCQkJCXZkZXYtPnZfbmFtZSA9ICJyYWlkejIiOworCQkJfSBlbHNlIHsK KwkJCQl2ZGV2LT52X25hbWUgPSBzdHJkdXAodHlwZSk7CisJCQl9CisJCX0KKworCQlpZiAoaXNf b2ZmbGluZSkKKwkJCXZkZXYtPnZfc3RhdGUgPSBWREVWX1NUQVRFX09GRkxJTkU7CisJCWVsc2Ug aWYgKGlzX3JlbW92ZWQpCisJCQl2ZGV2LT52X3N0YXRlID0gVkRFVl9TVEFURV9SRU1PVkVEOwor CQllbHNlIGlmIChpc19mYXVsdGVkKQorCQkJdmRldi0+dl9zdGF0ZSA9IFZERVZfU1RBVEVfRkFV TFRFRDsKKwkJZWxzZSBpZiAoaXNfZGVncmFkZWQpCisJCQl2ZGV2LT52X3N0YXRlID0gVkRFVl9T VEFURV9ERUdSQURFRDsKKwkJZWxzZQorCQkJdmRldi0+dl9zdGF0ZSA9IFZERVZfU1RBVEVfSEVB TFRIWTsKIAotCXZkZXYtPnZfaWQgPSBpZDsKLQlpZiAobnZsaXN0X2ZpbmQobnZsaXN0LCBaUE9P TF9DT05GSUdfQVNISUZULAotCQlEQVRBX1RZUEVfVUlOVDY0LCAwLCAmYXNoaWZ0KSA9PSAwKQot CQl2ZGV2LT52X2FzaGlmdCA9IGFzaGlmdDsKLQllbHNlCi0JCXZkZXYtPnZfYXNoaWZ0ID0gMDsK LQlpZiAobnZsaXN0X2ZpbmQobnZsaXN0LCBaUE9PTF9DT05GSUdfTlBBUklUWSwKLQkJREFUQV9U WVBFX1VJTlQ2NCwgMCwgJm5wYXJpdHkpID09IDApCi0JCXZkZXYtPnZfbnBhcml0eSA9IG5wYXJp dHk7Ci0JZWxzZQotCQl2ZGV2LT52X25wYXJpdHkgPSAwOwotCWlmIChudmxpc3RfZmluZChudmxp c3QsIFpQT09MX0NPTkZJR19QQVRILAotCQkJREFUQV9UWVBFX1NUUklORywgMCwgJnBhdGgpID09 IDApIHsKLQkJaWYgKHN0cmxlbihwYXRoKSA+IDUKLQkJICAgICYmIHBhdGhbMF0gPT0gJy8nCi0J CSAgICAmJiBwYXRoWzFdID09ICdkJwotCQkgICAgJiYgcGF0aFsyXSA9PSAnZScKLQkJICAgICYm IHBhdGhbM10gPT0gJ3YnCi0JCSAgICAmJiBwYXRoWzRdID09ICcvJykKLQkJCXBhdGggKz0gNTsK LQkJdmRldi0+dl9uYW1lID0gc3RyZHVwKHBhdGgpOwogCX0gZWxzZSB7Ci0JCWlmICghc3RyY21w KHR5cGUsICJyYWlkeiIpKSB7Ci0JCQlpZiAodmRldi0+dl9ucGFyaXR5ID09IDEpCi0JCQkJdmRl di0+dl9uYW1lID0gInJhaWR6MSI7CisKKwkJaXNfbmV3ID0gMDsKKworCQlpZiAoaXNfbmV3ZXIp IHsKKworCQkJLyogV2UndmUgYWxyZWFkeSBzZWVuIHRoaXMgdmRldiwgYnV0IGZyb20gYW4gb2xk ZXIKKwkJCSAqIHZkZXYgbGFiZWwsIHNvIGxldCdzIHJlZnJlc2ggaXRzIHN0YXRlIGZyb20gdGhl CisJCQkgKiBuZXdlciBsYWJlbC4gKi8KKworCQkJaWYgKGlzX29mZmxpbmUpCisJCQkJdmRldi0+ dl9zdGF0ZSA9IFZERVZfU1RBVEVfT0ZGTElORTsKKwkJCWVsc2UgaWYgKGlzX3JlbW92ZWQpCisJ CQkJdmRldi0+dl9zdGF0ZSA9IFZERVZfU1RBVEVfUkVNT1ZFRDsKKwkJCWVsc2UgaWYgKGlzX2Zh dWx0ZWQpCisJCQkJdmRldi0+dl9zdGF0ZSA9IFZERVZfU1RBVEVfRkFVTFRFRDsKKwkJCWVsc2Ug aWYgKGlzX2RlZ3JhZGVkKQorCQkJCXZkZXYtPnZfc3RhdGUgPSBWREVWX1NUQVRFX0RFR1JBREVE OwogCQkJZWxzZQotCQkJCXZkZXYtPnZfbmFtZSA9ICJyYWlkejIiOwotCQl9IGVsc2UgewotCQkJ dmRldi0+dl9uYW1lID0gc3RyZHVwKHR5cGUpOworCQkJCXZkZXYtPnZfc3RhdGUgPSBWREVWX1NU QVRFX0hFQUxUSFk7CiAJCX0KIAl9CisKIAlyYyA9IG52bGlzdF9maW5kKG52bGlzdCwgWlBPT0xf Q09ORklHX0NISUxEUkVOLAogCQkJIERBVEFfVFlQRV9OVkxJU1RfQVJSQVksICZua2lkcywgJmtp ZHMpOwogCS8qCkBAIC00ODgsMTAgKzUyOSwxMiBAQAogCWlmIChyYyA9PSAwKSB7CiAJCXZkZXYt PnZfbmNoaWxkcmVuID0gbmtpZHM7CiAJCWZvciAoaSA9IDA7IGkgPCBua2lkczsgaSsrKSB7Ci0J CQlyYyA9IHZkZXZfaW5pdF9mcm9tX252bGlzdChraWRzLCAma2lkKTsKKwkJCXJjID0gdmRldl9p bml0X2Zyb21fbnZsaXN0KGtpZHMsICZraWQsIGlzX25ld2VyKTsKIAkJCWlmIChyYykKIAkJCQly ZXR1cm4gKHJjKTsKLQkJCVNUQUlMUV9JTlNFUlRfVEFJTCgmdmRldi0+dl9jaGlsZHJlbiwga2lk LCB2X2NoaWxkbGluayk7CisJCQlpZiAoaXNfbmV3KQorCQkJCVNUQUlMUV9JTlNFUlRfVEFJTCgm dmRldi0+dl9jaGlsZHJlbiwga2lkLAorCQkJCQkJICAgdl9jaGlsZGxpbmspOwogCQkJa2lkcyA9 IG52bGlzdF9uZXh0KGtpZHMpOwogCQl9CiAJfSBlbHNlIHsKQEAgLTU5Myw3ICs2MzYsOSBAQAog CQkiVU5LTk9XTiIsCiAJCSJDTE9TRUQiLAogCQkiT0ZGTElORSIsCisJCSJSRU1PVkVEIiwKIAkJ IkNBTlRfT1BFTiIsCisJCSJGQVVMVEVEIiwKIAkJIkRFR1JBREVEIiwKIAkJIk9OTElORSIKIAl9 OwpAQCAtNzExLDcgKzc1Niw3IEBACiAJdWludDY0X3QgcG9vbF90eGcsIHBvb2xfZ3VpZDsKIAlj b25zdCBjaGFyICpwb29sX25hbWU7CiAJY29uc3QgdW5zaWduZWQgY2hhciAqdmRldnM7Ci0JaW50 IGksIHJjOworCWludCBpLCByYywgaXNfbmV3ZXI7CiAJY2hhciB1cGJ1ZlsxMDI0XTsKIAljb25z dCBzdHJ1Y3QgdWJlcmJsb2NrICp1cDsKIApAQCAtNzkzLDEyICs4MzgsMTUgQEAKIAkJc3BhID0g c3BhX2NyZWF0ZShwb29sX2d1aWQpOwogCQlzcGEtPnNwYV9uYW1lID0gc3RyZHVwKHBvb2xfbmFt ZSk7CiAJfQotCWlmIChwb29sX3R4ZyA+IHNwYS0+c3BhX3R4ZykKKwlpZiAocG9vbF90eGcgPiBz cGEtPnNwYV90eGcpIHsKIAkJc3BhLT5zcGFfdHhnID0gcG9vbF90eGc7CisJCWlzX25ld2VyID0g MTsKKwl9IGVsc2UKKwkJaXNfbmV3ZXIgPSAwOwogCiAJLyoKIAkgKiBHZXQgdGhlIHZkZXYgdHJl ZSBhbmQgY3JlYXRlIG91ciBpbi1jb3JlIGNvcHkgb2YgaXQuCi0JICogSWYgd2UgYWxyZWFkeSBo YXZlIGEgaGVhbHRoeSB2ZGV2IHdpdGggdGhpcyBndWlkLCB0aGlzIG11c3QKKwkgKiBJZiB3ZSBh bHJlYWR5IGhhdmUgYSB2ZGV2IHdpdGggdGhpcyBndWlkLCB0aGlzIG11c3QKIAkgKiBiZSBzb21l IGtpbmQgb2YgYWxpYXMgKG92ZXJsYXBwaW5nIHNsaWNlcywgZGFuZ2Vyb3VzbHkgZGVkaWNhdGVk CiAJICogZGlza3MgZXRjKS4KIAkgKi8KQEAgLTgwOCwxNiArODU2LDE2IEBACiAJCXJldHVybiAo RUlPKTsKIAl9CiAJdmRldiA9IHZkZXZfZmluZChndWlkKTsKLQlpZiAodmRldiAmJiB2ZGV2LT52 X3N0YXRlID09IFZERVZfU1RBVEVfSEVBTFRIWSkgeworCWlmICh2ZGV2ICYmIHZkZXYtPnZfcGh5 c19yZWFkKQkvKiBIYXMgdGhpcyB2ZGV2IGFscmVhZHkgYmVlbiBpbml0ZWQ/ICovCiAJCXJldHVy biAoRUlPKTsKLQl9CiAKIAlpZiAobnZsaXN0X2ZpbmQobnZsaXN0LAogCQkJWlBPT0xfQ09ORklH X1ZERVZfVFJFRSwKIAkJCURBVEFfVFlQRV9OVkxJU1QsIDAsICZ2ZGV2cykpIHsKIAkJcmV0dXJu IChFSU8pOwogCX0KLQlyYyA9IHZkZXZfaW5pdF9mcm9tX252bGlzdCh2ZGV2cywgJnRvcF92ZGV2 KTsKKworCXJjID0gdmRldl9pbml0X2Zyb21fbnZsaXN0KHZkZXZzLCAmdG9wX3ZkZXYsIGlzX25l d2VyKTsKIAlpZiAocmMpCiAJCXJldHVybiAocmMpOwogCkBAIC04MzgsNyArODg2LDYgQEAKIAlp ZiAodmRldikgewogCQl2ZGV2LT52X3BoeXNfcmVhZCA9IHJlYWQ7CiAJCXZkZXYtPnZfcmVhZF9w cml2ID0gcmVhZF9wcml2OwotCQl2ZGV2LT52X3N0YXRlID0gVkRFVl9TVEFURV9IRUFMVEhZOwog CX0gZWxzZSB7CiAJCXByaW50ZigiWkZTOiBpbmNvbnNpc3RlbnQgbnZsaXN0IGNvbnRlbnRzXG4i KTsKIAkJcmV0dXJuIChFSU8pOwo= --000e0cd729021f29f6047c863ea1 Content-Type: application/octet-stream; name="correct-status-nowhitespace.patch" Content-Disposition: attachment; filename="correct-status-nowhitespace.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g37u3wsw1 LS0tIHpmcy96ZnNpbXBsLmMuT1JJRwkyMDA5LTExLTIxIDE1OjAyOjM1LjAwMDAwMDAwMCArMDAw MAorKysgemZzL3pmc2ltcGwuYwkyMDA5LTEyLTExIDEyOjI2OjM4Ljc0NTk1NDI5NyArMDAwMApA QCAtNTEsNyArNTEsNyBAQAogc3RhdGljIGNoYXIgKnphcF9zY3JhdGNoOwogc3RhdGljIGNoYXIg Knpmc190ZW1wX2J1ZiwgKnpmc190ZW1wX2VuZCwgKnpmc190ZW1wX3B0cjsKIAotI2RlZmluZSBU RU1QX1NJWkUJKDEqU1BBX01BWEJMT0NLU0laRSkKKyNkZWZpbmUgVEVNUF9TSVpFCSgxMDI0ICog MTAyNCkKIAogc3RhdGljIGludCB6aW9fcmVhZChzcGFfdCAqc3BhLCBjb25zdCBibGtwdHJfdCAq YnAsIHZvaWQgKmJ1Zik7CiAKQEAgLTQwNCw3ICs0MDQsNyBAQAogfQogCiBzdGF0aWMgaW50Ci12 ZGV2X2luaXRfZnJvbV9udmxpc3QoY29uc3QgdW5zaWduZWQgY2hhciAqbnZsaXN0LCB2ZGV2X3Qg Kip2ZGV2cCkKK3ZkZXZfaW5pdF9mcm9tX252bGlzdChjb25zdCB1bnNpZ25lZCBjaGFyICpudmxp c3QsIHZkZXZfdCAqKnZkZXZwLCBpbnQgaXNfbmV3ZXIpCiB7CiAJaW50IHJjOwogCXVpbnQ2NF90 IGd1aWQsIGlkLCBhc2hpZnQsIG5wYXJpdHk7CkBAIC00MTIsNyArNDEyLDggQEAKIAljb25zdCBj aGFyICpwYXRoOwogCXZkZXZfdCAqdmRldiwgKmtpZDsKIAljb25zdCB1bnNpZ25lZCBjaGFyICpr aWRzOwotCWludCBua2lkcywgaTsKKwlpbnQgbmtpZHMsIGksIGlzX25ldzsKKwl1aW50NjRfdCBp c19vZmZsaW5lLCBpc19mYXVsdGVkLCBpc19kZWdyYWRlZCwgaXNfcmVtb3ZlZDsKIAogCWlmIChu dmxpc3RfZmluZChudmxpc3QsIFpQT09MX0NPTkZJR19HVUlELAogCQkJREFUQV9UWVBFX1VJTlQ2 NCwgMCwgJmd1aWQpCkBAIC00MjQsMTcgKzQyNSw2IEBACiAJCXJldHVybiAoRU5PRU5UKTsKIAl9 CiAKLQkvKgotCSAqIEFzc3VtZSB0aGF0IGlmIHdlJ3ZlIHNlZW4gdGhpcyB2ZGV2IHRyZWUgYmVm b3JlLCB0aGlzIG9uZQotCSAqIHdpbGwgYmUgaWRlbnRpY2FsLgotCSAqLwotCXZkZXYgPSB2ZGV2 X2ZpbmQoZ3VpZCk7Ci0JaWYgKHZkZXYpIHsKLQkJaWYgKHZkZXZwKQotCQkJKnZkZXZwID0gdmRl djsKLQkJcmV0dXJuICgwKTsKLQl9Ci0KIAlpZiAoc3RyY21wKHR5cGUsIFZERVZfVFlQRV9NSVJS T1IpCiAJICAgICYmIHN0cmNtcCh0eXBlLCBWREVWX1RZUEVfRElTSykKIAkgICAgJiYgc3RyY21w KHR5cGUsIFZERVZfVFlQRV9SQUlEWikpIHsKQEAgLTQ0Miw2ICs0MzIsMjIgQEAKIAkJcmV0dXJu IChFSU8pOwogCX0KIAorCWlzX29mZmxpbmUgPSBpc19yZW1vdmVkID0gaXNfZmF1bHRlZCA9IGlz X2RlZ3JhZGVkID0gMDsKKworCW52bGlzdF9maW5kKG52bGlzdCwgWlBPT0xfQ09ORklHX09GRkxJ TkUsIERBVEFfVFlQRV9VSU5UNjQsIDAsCisJCQkmaXNfb2ZmbGluZSk7CisJbnZsaXN0X2ZpbmQo bnZsaXN0LCBaUE9PTF9DT05GSUdfUkVNT1ZFRCwgREFUQV9UWVBFX1VJTlQ2NCwgMCwKKwkJCSZp c19yZW1vdmVkKTsKKwludmxpc3RfZmluZChudmxpc3QsIFpQT09MX0NPTkZJR19GQVVMVEVELCBE QVRBX1RZUEVfVUlOVDY0LCAwLAorCQkJJmlzX2ZhdWx0ZWQpOworCW52bGlzdF9maW5kKG52bGlz dCwgWlBPT0xfQ09ORklHX0RFR1JBREVELCBEQVRBX1RZUEVfVUlOVDY0LCAwLAorCQkJJmlzX2Rl Z3JhZGVkKTsKKworCXZkZXYgPSB2ZGV2X2ZpbmQoZ3VpZCk7CisJaWYgKCF2ZGV2KSB7CisKKwkJ aXNfbmV3ID0gMTsKKwogCWlmICghc3RyY21wKHR5cGUsIFZERVZfVFlQRV9NSVJST1IpKQogCQl2 ZGV2ID0gdmRldl9jcmVhdGUoZ3VpZCwgdmRldl9taXJyb3JfcmVhZCk7CiAJZWxzZSBpZiAoIXN0 cmNtcCh0eXBlLCBWREVWX1RZUEVfUkFJRFopKQpAQCAtNDgwLDYgKzQ4Niw0MSBAQAogCQkJdmRl di0+dl9uYW1lID0gc3RyZHVwKHR5cGUpOwogCQl9CiAJfQorCisJCWlmIChpc19vZmZsaW5lKQor CQkJdmRldi0+dl9zdGF0ZSA9IFZERVZfU1RBVEVfT0ZGTElORTsKKwkJZWxzZSBpZiAoaXNfcmVt b3ZlZCkKKwkJCXZkZXYtPnZfc3RhdGUgPSBWREVWX1NUQVRFX1JFTU9WRUQ7CisJCWVsc2UgaWYg KGlzX2ZhdWx0ZWQpCisJCQl2ZGV2LT52X3N0YXRlID0gVkRFVl9TVEFURV9GQVVMVEVEOworCQll bHNlIGlmIChpc19kZWdyYWRlZCkKKwkJCXZkZXYtPnZfc3RhdGUgPSBWREVWX1NUQVRFX0RFR1JB REVEOworCQllbHNlCisJCQl2ZGV2LT52X3N0YXRlID0gVkRFVl9TVEFURV9IRUFMVEhZOworCisJ fSBlbHNlIHsKKworCQlpc19uZXcgPSAwOworCisJCWlmIChpc19uZXdlcikgeworCisJCQkvKiBX ZSd2ZSBhbHJlYWR5IHNlZW4gdGhpcyB2ZGV2LCBidXQgZnJvbSBhbiBvbGRlcgorCQkJICogdmRl diBsYWJlbCwgc28gbGV0J3MgcmVmcmVzaCBpdHMgc3RhdGUgZnJvbSB0aGUKKwkJCSAqIG5ld2Vy IGxhYmVsLiAqLworCisJCQlpZiAoaXNfb2ZmbGluZSkKKwkJCQl2ZGV2LT52X3N0YXRlID0gVkRF Vl9TVEFURV9PRkZMSU5FOworCQkJZWxzZSBpZiAoaXNfcmVtb3ZlZCkKKwkJCQl2ZGV2LT52X3N0 YXRlID0gVkRFVl9TVEFURV9SRU1PVkVEOworCQkJZWxzZSBpZiAoaXNfZmF1bHRlZCkKKwkJCQl2 ZGV2LT52X3N0YXRlID0gVkRFVl9TVEFURV9GQVVMVEVEOworCQkJZWxzZSBpZiAoaXNfZGVncmFk ZWQpCisJCQkJdmRldi0+dl9zdGF0ZSA9IFZERVZfU1RBVEVfREVHUkFERUQ7CisJCQllbHNlCisJ CQkJdmRldi0+dl9zdGF0ZSA9IFZERVZfU1RBVEVfSEVBTFRIWTsKKwkJfQorCX0KKwogCXJjID0g bnZsaXN0X2ZpbmQobnZsaXN0LCBaUE9PTF9DT05GSUdfQ0hJTERSRU4sCiAJCQkgREFUQV9UWVBF X05WTElTVF9BUlJBWSwgJm5raWRzLCAma2lkcyk7CiAJLyoKQEAgLTQ4OCwxMCArNTI5LDEyIEBA CiAJaWYgKHJjID09IDApIHsKIAkJdmRldi0+dl9uY2hpbGRyZW4gPSBua2lkczsKIAkJZm9yIChp ID0gMDsgaSA8IG5raWRzOyBpKyspIHsKLQkJCXJjID0gdmRldl9pbml0X2Zyb21fbnZsaXN0KGtp ZHMsICZraWQpOworCQkJcmMgPSB2ZGV2X2luaXRfZnJvbV9udmxpc3Qoa2lkcywgJmtpZCwgaXNf bmV3ZXIpOwogCQkJaWYgKHJjKQogCQkJCXJldHVybiAocmMpOwotCQkJU1RBSUxRX0lOU0VSVF9U QUlMKCZ2ZGV2LT52X2NoaWxkcmVuLCBraWQsIHZfY2hpbGRsaW5rKTsKKwkJCWlmIChpc19uZXcp CisJCQkJU1RBSUxRX0lOU0VSVF9UQUlMKCZ2ZGV2LT52X2NoaWxkcmVuLCBraWQsCisJCQkJCQkg ICB2X2NoaWxkbGluayk7CiAJCQlraWRzID0gbnZsaXN0X25leHQoa2lkcyk7CiAJCX0KIAl9IGVs c2UgewpAQCAtNTkzLDcgKzYzNiw5IEBACiAJCSJVTktOT1dOIiwKIAkJIkNMT1NFRCIsCiAJCSJP RkZMSU5FIiwKKwkJIlJFTU9WRUQiLAogCQkiQ0FOVF9PUEVOIiwKKwkJIkZBVUxURUQiLAogCQki REVHUkFERUQiLAogCQkiT05MSU5FIgogCX07CkBAIC03MTEsNyArNzU2LDcgQEAKIAl1aW50NjRf dCBwb29sX3R4ZywgcG9vbF9ndWlkOwogCWNvbnN0IGNoYXIgKnBvb2xfbmFtZTsKIAljb25zdCB1 bnNpZ25lZCBjaGFyICp2ZGV2czsKLQlpbnQgaSwgcmM7CisJaW50IGksIHJjLCBpc19uZXdlcjsK IAljaGFyIHVwYnVmWzEwMjRdOwogCWNvbnN0IHN0cnVjdCB1YmVyYmxvY2sgKnVwOwogCkBAIC03 OTMsMTIgKzgzOCwxNSBAQAogCQlzcGEgPSBzcGFfY3JlYXRlKHBvb2xfZ3VpZCk7CiAJCXNwYS0+ c3BhX25hbWUgPSBzdHJkdXAocG9vbF9uYW1lKTsKIAl9Ci0JaWYgKHBvb2xfdHhnID4gc3BhLT5z cGFfdHhnKQorCWlmIChwb29sX3R4ZyA+IHNwYS0+c3BhX3R4ZykgewogCQlzcGEtPnNwYV90eGcg PSBwb29sX3R4ZzsKKwkJaXNfbmV3ZXIgPSAxOworCX0gZWxzZQorCQlpc19uZXdlciA9IDA7CiAK IAkvKgogCSAqIEdldCB0aGUgdmRldiB0cmVlIGFuZCBjcmVhdGUgb3VyIGluLWNvcmUgY29weSBv ZiBpdC4KLQkgKiBJZiB3ZSBhbHJlYWR5IGhhdmUgYSBoZWFsdGh5IHZkZXYgd2l0aCB0aGlzIGd1 aWQsIHRoaXMgbXVzdAorCSAqIElmIHdlIGFscmVhZHkgaGF2ZSBhIHZkZXYgd2l0aCB0aGlzIGd1 aWQsIHRoaXMgbXVzdAogCSAqIGJlIHNvbWUga2luZCBvZiBhbGlhcyAob3ZlcmxhcHBpbmcgc2xp Y2VzLCBkYW5nZXJvdXNseSBkZWRpY2F0ZWQKIAkgKiBkaXNrcyBldGMpLgogCSAqLwpAQCAtODA4 LDE2ICs4NTYsMTYgQEAKIAkJcmV0dXJuIChFSU8pOwogCX0KIAl2ZGV2ID0gdmRldl9maW5kKGd1 aWQpOwotCWlmICh2ZGV2ICYmIHZkZXYtPnZfc3RhdGUgPT0gVkRFVl9TVEFURV9IRUFMVEhZKSB7 CisJaWYgKHZkZXYgJiYgdmRldi0+dl9waHlzX3JlYWQpCS8qIEhhcyB0aGlzIHZkZXYgYWxyZWFk eSBiZWVuIGluaXRlZD8gKi8KIAkJcmV0dXJuIChFSU8pOwotCX0KIAogCWlmIChudmxpc3RfZmlu ZChudmxpc3QsCiAJCQlaUE9PTF9DT05GSUdfVkRFVl9UUkVFLAogCQkJREFUQV9UWVBFX05WTElT VCwgMCwgJnZkZXZzKSkgewogCQlyZXR1cm4gKEVJTyk7CiAJfQotCXJjID0gdmRldl9pbml0X2Zy b21fbnZsaXN0KHZkZXZzLCAmdG9wX3ZkZXYpOworCisJcmMgPSB2ZGV2X2luaXRfZnJvbV9udmxp c3QodmRldnMsICZ0b3BfdmRldiwgaXNfbmV3ZXIpOwogCWlmIChyYykKIAkJcmV0dXJuIChyYyk7 CiAKQEAgLTgzOCw3ICs4ODYsNiBAQAogCWlmICh2ZGV2KSB7CiAJCXZkZXYtPnZfcGh5c19yZWFk ID0gcmVhZDsKIAkJdmRldi0+dl9yZWFkX3ByaXYgPSByZWFkX3ByaXY7Ci0JCXZkZXYtPnZfc3Rh dGUgPSBWREVWX1NUQVRFX0hFQUxUSFk7CiAJfSBlbHNlIHsKIAkJcHJpbnRmKCJaRlM6IGluY29u c2lzdGVudCBudmxpc3QgY29udGVudHNcbiIpOwogCQlyZXR1cm4gKEVJTyk7Cg== --000e0cd729021f29f6047c863ea1-- From owner-freebsd-fs@FreeBSD.ORG Wed Jan 6 22:37:29 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 721F51065672; Wed, 6 Jan 2010 22:37:29 +0000 (UTC) (envelope-from delphij@gmail.com) Received: from mail-pz0-f202.google.com (mail-pz0-f202.google.com [209.85.222.202]) by mx1.freebsd.org (Postfix) with ESMTP id 4319D8FC16; Wed, 6 Jan 2010 22:37:29 +0000 (UTC) Received: by pzk40 with SMTP id 40so10446811pzk.7 for ; Wed, 06 Jan 2010 14:37:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=bzZxMNNVaho42IX4tXU/zd+VWU4yqtOI+0QmGe7vjlg=; b=R+q01t4RPavcEezdmZK9m/jDW8+at3b+AK24a89oSGVk8DMNkiOV/MF7nNZLaNC1Mt yI82sKKhUAFZzc09BY6hCMAtWlARBcbP3CB7QL96Rd+MKj1TIv2BjUjPMAqLFnCdJ/oV JAi1UZzzXV0pGmbD91MMBbKye4pLcfk0QdzDk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=K9R6sUUz0afiVVVaPWhBGKVB2FjDtxSlc9AxEm8m6s3nAda9J2FyiK6ColcQMmbt/k 5KM1KmuJoK9HqBfvN8AId2Agd5W5kSxYnckBj0GpQlRZ+K5s7IroHyW5sn7MkEfnhwTr 1bj81eZB9DlfE5rjK6CBtaA9IikZUyQRqhp0Q= MIME-Version: 1.0 Received: by 10.114.242.8 with SMTP id p8mr1523545wah.169.1262817445650; Wed, 06 Jan 2010 14:37:25 -0800 (PST) In-Reply-To: References: Date: Wed, 6 Jan 2010 14:37:25 -0800 Message-ID: From: Xin LI To: Matt Reimer Content-Type: text/plain; charset=UTF-8 Cc: freebsd-fs , Pawel Jakub Dawidek Subject: Re: PATCH: teach (gpt)zfsboot, zfsloader to discern vdev status correctly X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2010 22:37:29 -0000 Hi, Matt, On Wed, Jan 6, 2010 at 2:11 PM, Matt Reimer wrote: > Would one of you be able to review this patch and commit it if it's > acceptable? This is the same patch I submitted last month. The patch looks fine to me. By the way, I think the patch has raised TEMP_SIZE from 128K to 1MB, how was the number being chosen? Cheers, -- Xin LI http://www.delphij.net From owner-freebsd-fs@FreeBSD.ORG Wed Jan 6 22:41:12 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0118F106568F for ; Wed, 6 Jan 2010 22:41:12 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello089077043238.chello.pl [89.77.43.238]) by mx1.freebsd.org (Postfix) with ESMTP id 457388FC14 for ; Wed, 6 Jan 2010 22:41:10 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 3C03B45CBA; Wed, 6 Jan 2010 23:41:09 +0100 (CET) Received: from localhost (chello089077043238.chello.pl [89.77.43.238]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 49D5445C9C; Wed, 6 Jan 2010 23:41:04 +0100 (CET) Date: Wed, 6 Jan 2010 23:41:12 +0100 From: Pawel Jakub Dawidek To: Matt Reimer Message-ID: <20100106224112.GC1719@garage.freebsd.pl> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qjNfmADvan18RZcF" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: freebsd-fs Subject: Re: PATCH: more efficient raidz memory usage for (gpt)zfsboot, zfsloader X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2010 22:41:12 -0000 --qjNfmADvan18RZcF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 06, 2010 at 02:10:28PM -0800, Matt Reimer wrote: > Would one of you be able to review this patch and commit it if it's > acceptable? This is the same patch I submitted last month. I just committed your patch. I'm very sorry for the lack of response. I hoped that Doug will handle it, as zfsboot is his work. Please keep up the good work and won't be discouraged by long response times! --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --qjNfmADvan18RZcF Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFLRRGIForvXbEpPzQRAgrjAJ96F+3JTESKjMm6MnqndvXGHMbfagCgtPfJ KVVYUrRwKP6mLNTVxWW0a8k= =rUpl -----END PGP SIGNATURE----- --qjNfmADvan18RZcF-- From owner-freebsd-fs@FreeBSD.ORG Wed Jan 6 22:44:29 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DA402106566C for ; Wed, 6 Jan 2010 22:44:29 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello089077043238.chello.pl [89.77.43.238]) by mx1.freebsd.org (Postfix) with ESMTP id 707AB8FC1C for ; Wed, 6 Jan 2010 22:44:29 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 9F86D45CD8; Wed, 6 Jan 2010 23:44:27 +0100 (CET) Received: from localhost (chello089077043238.chello.pl [89.77.43.238]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 9A78A45C9C; Wed, 6 Jan 2010 23:44:22 +0100 (CET) Date: Wed, 6 Jan 2010 23:44:32 +0100 From: Pawel Jakub Dawidek To: Xin LI Message-ID: <20100106224432.GD1719@garage.freebsd.pl> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Km1U/tdNT/EmXiR1" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: freebsd-fs Subject: Re: PATCH: teach (gpt)zfsboot, zfsloader to discern vdev status correctly X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2010 22:44:29 -0000 --Km1U/tdNT/EmXiR1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 06, 2010 at 02:37:25PM -0800, Xin LI wrote: > Hi, Matt, >=20 > On Wed, Jan 6, 2010 at 2:11 PM, Matt Reimer wrote: > > Would one of you be able to review this patch and commit it if it's > > acceptable? This is the same patch I submitted last month. >=20 > The patch looks fine to me. I committed Matt's other patch few minutes ago. If you could handle this one, that would be great. It would be very wasteful not to use Matt's work. Thanks! --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --Km1U/tdNT/EmXiR1 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFLRRJPForvXbEpPzQRAiaPAKChwE47bM/KyZlNrYRqq49UUfi8cwCfRdc/ EVDcG2umloavu/UvSkded3I= =UHUe -----END PGP SIGNATURE----- --Km1U/tdNT/EmXiR1-- From owner-freebsd-fs@FreeBSD.ORG Wed Jan 6 22:56:58 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 18F601065C8A; Wed, 6 Jan 2010 22:56:58 +0000 (UTC) (envelope-from delphij@gmail.com) Received: from mail-pw0-f44.google.com (mail-pw0-f44.google.com [209.85.160.44]) by mx1.freebsd.org (Postfix) with ESMTP id DDE008FC0A; Wed, 6 Jan 2010 22:56:57 +0000 (UTC) Received: by pwi15 with SMTP id 15so12568998pwi.3 for ; Wed, 06 Jan 2010 14:56:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=7v+sRt3vtLtOQmLPBiywCa+Y2NMSOmYof6iOA1a+ubM=; b=DuFYT8EyO0tnzsG8uCv+mWdmrZXPKrumakEGxHygiiKc+dtwtoCQs0TkulYF/CIotK n8uLJIthgtszB8mJpWu8XUluRWCoC6ujEo6j5ewf+XU4OgPh6Mr99Llxu40AYPKHpHsO gMavjNSBUaLKy2wfMQlngf4GjcuU0SvaVukeU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=GjIhrcCgBBrw+Y2FDc365vV4CCyaTEfIfd0Gkavabgpu2LzUCgRijT9zc5JtDQG54g XbfAzU80TCGZIxqPWh+0LVe6HJKROVlTkFdk5A1WWxVFzQUQeJRRxjZM+SWLKzu8vjaI cQ98q23Xjiggs444lXxVLTdG/LVMMQygEEt6M= MIME-Version: 1.0 Received: by 10.114.138.10 with SMTP id l10mr1004563wad.3.1262818614478; Wed, 06 Jan 2010 14:56:54 -0800 (PST) In-Reply-To: References: Date: Wed, 6 Jan 2010 14:56:54 -0800 Message-ID: From: Xin LI To: Matt Reimer Content-Type: text/plain; charset=UTF-8 Cc: freebsd-fs , Pawel Jakub Dawidek Subject: Re: PATCH: teach (gpt)zfsboot, zfsloader to discern vdev status correctly X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2010 22:56:58 -0000 On Wed, Jan 6, 2010 at 2:37 PM, Xin LI wrote: > Hi, Matt, > > On Wed, Jan 6, 2010 at 2:11 PM, Matt Reimer wrote: >> Would one of you be able to review this patch and commit it if it's >> acceptable? This is the same patch I submitted last month. > > By the way, I think the patch has raised TEMP_SIZE from 128K to 1MB, > how was the number being chosen? Never mind, I have found the original discussion about this. Cheers, -- Xin LI http://www.delphij.net From owner-freebsd-fs@FreeBSD.ORG Wed Jan 6 23:13:56 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 624F41065694; Wed, 6 Jan 2010 23:13:56 +0000 (UTC) (envelope-from delphij@gmail.com) Received: from mail-pw0-f44.google.com (mail-pw0-f44.google.com [209.85.160.44]) by mx1.freebsd.org (Postfix) with ESMTP id 318158FC15; Wed, 6 Jan 2010 23:13:55 +0000 (UTC) Received: by pwi15 with SMTP id 15so12578985pwi.3 for ; Wed, 06 Jan 2010 15:13:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=xBpAudaNfqNfNTuc0HXV7WrMTaGR/MLaP1WcuQRDrto=; b=OewrdOJtKHmlP1D6kfjbw/JFLBF9peRq0unvBnAQS/3VR/2cGzv5GPca7ivOLTBHud G5nUB1/60QaAgbSVVONNyvpzChFp+COLdlJkjaMGZXZ5Ks5UctxOgXXoP5OKlb0fnjYk HdMn0XaEBNTUpvDV3M1UbNAfLNCCsNKHa+tHs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=RjnJSaQ9i3QzhUs98hgDGTPofL6yUusq7EyzDfmgs30tIiNiDH6pXNqCFSJfK81yy3 zXxdbSsx2w9MCOgWsbQVbN1+92Fq6H9xkQ5SjEI5llRTuNi/dlmDM15Tn6cBBo3MUceF 22iD9fGF3Dcm6srjDXxGXhZqcrhxV8EN/62K0= MIME-Version: 1.0 Received: by 10.114.242.8 with SMTP id p8mr1547208wah.169.1262819629803; Wed, 06 Jan 2010 15:13:49 -0800 (PST) In-Reply-To: References: Date: Wed, 6 Jan 2010 15:13:49 -0800 Message-ID: From: Xin LI To: Matt Reimer Content-Type: text/plain; charset=UTF-8 Cc: freebsd-fs , Pawel Jakub Dawidek Subject: Re: PATCH: teach (gpt)zfsboot, zfsloader to discern vdev status correctly X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2010 23:13:56 -0000 Hi, Matt, I have committed your proposed change with slight space changes (some space -> tab to fit nearby code style, and no blank line after and before if's { }), with a MFC set of 2 weeks. Thanks for the submission which makes FreeBSD better! Cheers, -- Xin LI http://www.delphij.net From owner-freebsd-fs@FreeBSD.ORG Wed Jan 6 23:18:12 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6B5941065692; Wed, 6 Jan 2010 23:18:12 +0000 (UTC) (envelope-from mattjreimer@gmail.com) Received: from mail-yx0-f172.google.com (mail-yx0-f172.google.com [209.85.210.172]) by mx1.freebsd.org (Postfix) with ESMTP id 13FE18FC0A; Wed, 6 Jan 2010 23:18:11 +0000 (UTC) Received: by yxe2 with SMTP id 2so3131550yxe.7 for ; Wed, 06 Jan 2010 15:18:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=eB8NutOoPxG98jZmUNybmWARvaDNWAGUbaIsScPWwbI=; b=ewSqk1xxlPt9HmIgSSlVsufLvmPbDO3pymNxqWqUSUtwvmWkKsJSZ7DtVdTe2l+dc4 3j4H5AFhbjfFbFT/PXdIlVv6c1g7P1poRlJKlHBp0ZvYmq9nBVdZQW40SF39CFJHQNz+ Mr2AK3zNYD9CRSnNxm8Cdf4gQJ71DkdPtYHVQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=J3OigwWDWjB/PPTY9ChhBDh9WPY+Eo9cn0oRCLjJ1f9GFDOdxEUg2mP5qXiPmG5vJS nwftowgHVtcwVVaIWmJ/tgcf6M9Fp6MAej+1HngDae37l3RAdL/lQNbJwwrw11MvfNff z8S7oPKbLLqbTQk/U4kIiEcC8a40bzduZVHu8= MIME-Version: 1.0 Received: by 10.150.102.37 with SMTP id z37mr41258472ybb.69.1262819888953; Wed, 06 Jan 2010 15:18:08 -0800 (PST) In-Reply-To: References: Date: Wed, 6 Jan 2010 15:18:08 -0800 Message-ID: From: Matt Reimer To: freebsd-fs Content-Type: text/plain; charset=ISO-8859-1 Cc: Pawel Jakub Dawidek Subject: Re: PATCH: teach (gpt)zfsboot, zfsloader to discern vdev status correctly X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2010 23:18:12 -0000 On Wed, Jan 6, 2010 at 3:13 PM, Xin LI wrote: > Hi, Matt, > > I have committed your proposed change with slight space changes (some > space -> tab to fit nearby code style, and no blank line after and > before if's { }), with a MFC set of 2 weeks. > > Thanks for the submission which makes FreeBSD better! Thanks! Matt From owner-freebsd-fs@FreeBSD.ORG Thu Jan 7 00:22:15 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 275B7106566C; Thu, 7 Jan 2010 00:22:15 +0000 (UTC) (envelope-from mckusick@mckusick.com) Received: from chez.mckusick.com (chez.mckusick.com [64.81.247.49]) by mx1.freebsd.org (Postfix) with ESMTP id 066578FC21; Thu, 7 Jan 2010 00:22:14 +0000 (UTC) Received: from chez.mckusick.com (localhost [127.0.0.1]) by chez.mckusick.com (8.14.3/8.14.3) with ESMTP id o070Lq0J056953; Wed, 6 Jan 2010 16:21:53 -0800 (PST) (envelope-from mckusick@chez.mckusick.com) Message-Id: <201001070021.o070Lq0J056953@chez.mckusick.com> To: Dan Strick In-reply-to: <200912291843.nBTIhBF0026212@chez.mckusick.com> Date: Wed, 06 Jan 2010 16:21:52 -0800 From: Kirk McKusick Cc: freebsd-fs@freebsd.org, bug-followup@freebsd.org Subject: Re: kern/141992: fsck cannot repair file system in which it finds an error X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2010 00:22:15 -0000 So, I have (finally) gotten a chance to try out the disk image that you sent me using fsck_ffs from a FreeBSD 8.0 system. Here is the correction report and patch that I made: Author: mckusick Date: Thu Jan 7 00:17:36 2010 New Revision: 201700 URL: http://svn.freebsd.org/changeset/base/201700 Log: This corrects a bug that manifested itself as identifying the last cylinder group of a UFS1 filesystem as bad. The error was in the check and not in the cylinder group itself. So even though fsck fixed the cylinder group correctly, it was still endlessly reported as bad. PR: 141992 MFC after: 2 weeks Reported by: Dan Strick Modified: head/sbin/fsck_ffs/fsutil.c Modified: head/sbin/fsck_ffs/fsutil.c ============================================================================== --- head/sbin/fsck_ffs/fsutil.c Thu Jan 7 00:04:29 2010 (r201699) +++ head/sbin/fsck_ffs/fsutil.c Thu Jan 7 00:17:36 2010 (r201700) @@ -436,7 +436,7 @@ check_cgmagic(int cg, struct cg *cgp) ((sblock.fs_magic == FS_UFS1_MAGIC && cgp->cg_old_niblk == sblock.fs_ipg && cgp->cg_ndblk <= sblock.fs_fpg && - cgp->cg_old_ncyl == sblock.fs_old_cpg) || + cgp->cg_old_ncyl <= sblock.fs_old_cpg) || (sblock.fs_magic == FS_UFS2_MAGIC && cgp->cg_niblk == sblock.fs_ipg && cgp->cg_ndblk <= sblock.fs_fpg && Please apply this patch to your fsck_ffs and confirm for me that it corrects your problem. Thanks for all your help. Kirk McKusick From owner-freebsd-fs@FreeBSD.ORG Thu Jan 7 01:13:33 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 70DB51065679; Thu, 7 Jan 2010 01:13:33 +0000 (UTC) (envelope-from mckusick@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 48B088FC14; Thu, 7 Jan 2010 01:13:33 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o071DXoq010484; Thu, 7 Jan 2010 01:13:33 GMT (envelope-from mckusick@freefall.freebsd.org) Received: (from mckusick@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o071DWWe010480; Thu, 7 Jan 2010 01:13:32 GMT (envelope-from mckusick) Date: Thu, 7 Jan 2010 01:13:32 GMT Message-Id: <201001070113.o071DWWe010480@freefall.freebsd.org> To: hsu@bbnetworks.net, mckusick@FreeBSD.org, freebsd-fs@FreeBSD.org From: mckusick@FreeBSD.org Cc: Subject: Re: bin/138043: [patch] fsck_ffs(8) broken, partial patch X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2010 01:13:33 -0000 Synopsis: [patch] fsck_ffs(8) broken, partial patch State-Changed-From-To: open->closed State-Changed-By: mckusick State-Changed-When: Thu Jan 7 01:11:31 UTC 2010 State-Changed-Why: The suggested fix was added in r176575 by delphij on 2008-02-25. The more detailed error messages were added by me in r201708. http://www.freebsd.org/cgi/query-pr.cgi?pr=138043 From owner-freebsd-fs@FreeBSD.ORG Thu Jan 7 01:20:04 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5608D1065670 for ; Thu, 7 Jan 2010 01:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2C8A98FC1F for ; Thu, 7 Jan 2010 01:20:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o071K4Zo010937 for ; Thu, 7 Jan 2010 01:20:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o071K4l8010935; Thu, 7 Jan 2010 01:20:04 GMT (envelope-from gnats) Date: Thu, 7 Jan 2010 01:20:04 GMT Message-Id: <201001070120.o071K4l8010935@freefall.freebsd.org> To: freebsd-fs@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: bin/138043: commit references a PR X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2010 01:20:04 -0000 The following reply was made to PR bin/138043; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: bin/138043: commit references a PR Date: Thu, 7 Jan 2010 01:11:08 +0000 (UTC) Author: mckusick Date: Thu Jan 7 01:10:49 2010 New Revision: 201708 URL: http://svn.freebsd.org/changeset/base/201708 Log: Add some error messages suggested in PR bin/138043. The code to correct the problem was added in r176575 by delphij on 2008-02-25. PR: 138043 Reported by: Heikki Suonsivu Modified: head/sbin/fsck_ffs/main.c head/sbin/fsck_ffs/pass1.c Modified: head/sbin/fsck_ffs/main.c ============================================================================== --- head/sbin/fsck_ffs/main.c Thu Jan 7 00:57:40 2010 (r201707) +++ head/sbin/fsck_ffs/main.c Thu Jan 7 01:10:49 2010 (r201708) @@ -406,7 +406,10 @@ checkfilesys(char *filesys) */ if (duplist) { if (preen || usedsoftdep) - pfatal("INTERNAL ERROR: dups with -p"); + pfatal("INTERNAL ERROR: dups with %s%s%s", + preen ? "-p" : "", + (preen && usedsoftdep) ? " and " : "", + usedsoftdep ? "softupdates" : ""); printf("** Phase 1b - Rescan For More DUPS\n"); pass1b(); } Modified: head/sbin/fsck_ffs/pass1.c ============================================================================== --- head/sbin/fsck_ffs/pass1.c Thu Jan 7 00:57:40 2010 (r201707) +++ head/sbin/fsck_ffs/pass1.c Thu Jan 7 01:10:49 2010 (r201708) @@ -98,10 +98,16 @@ pass1(void) rebuildcg = 1; if (!rebuildcg && sblock.fs_magic == FS_UFS2_MAGIC) { inosused = cgrp.cg_initediblk; - if (inosused > sblock.fs_ipg) + if (inosused > sblock.fs_ipg) { + pfatal("%s (%d > %d) %s %d\nReset to %d\n", + "Too many initialized inodes", inosused, + sblock.fs_ipg, "in cylinder group", c, + sblock.fs_ipg); inosused = sblock.fs_ipg; - } else + } + } else { inosused = sblock.fs_ipg; + } if (got_siginfo) { printf("%s: phase 1: cyl group %d of %d (%d%%)\n", cdevname, c, sblock.fs_ncg, _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-fs@FreeBSD.ORG Thu Jan 7 02:00:13 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 194A81065670 for ; Thu, 7 Jan 2010 02:00:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E32378FC1A for ; Thu, 7 Jan 2010 02:00:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o0720CJo046756 for ; Thu, 7 Jan 2010 02:00:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o0720Ctn046755; Thu, 7 Jan 2010 02:00:12 GMT (envelope-from gnats) Date: Thu, 7 Jan 2010 02:00:12 GMT Message-Id: <201001070200.o0720Ctn046755@freefall.freebsd.org> To: freebsd-fs@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: bin/138043: commit references a PR X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2010 02:00:13 -0000 The following reply was made to PR bin/138043; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: bin/138043: commit references a PR Date: Thu, 7 Jan 2010 01:55:43 +0000 (UTC) Author: delphij Date: Thu Jan 7 01:55:34 2010 New Revision: 201711 URL: http://svn.freebsd.org/changeset/base/201711 Log: MFC r176575: In pass1(), cap inosused to fs_ipg rather than allowing arbitrary number read from cylinder group. Chances that we read a smarshed cylinder group, and we can not 100% trust information it has supplied. fsck_ffs(8) will crash otherwise for some cases. PR: bin/138043 Reminded by: mckusick Modified: stable/7/sbin/fsck_ffs/pass1.c Directory Properties: stable/7/sbin/fsck_ffs/ (props changed) Modified: stable/7/sbin/fsck_ffs/pass1.c ============================================================================== --- stable/7/sbin/fsck_ffs/pass1.c Thu Jan 7 01:24:09 2010 (r201710) +++ stable/7/sbin/fsck_ffs/pass1.c Thu Jan 7 01:55:34 2010 (r201711) @@ -93,9 +93,11 @@ pass1(void) inumber = c * sblock.fs_ipg; setinodebuf(inumber); getblk(&cgblk, cgtod(&sblock, c), sblock.fs_cgsize); - if (sblock.fs_magic == FS_UFS2_MAGIC) + if (sblock.fs_magic == FS_UFS2_MAGIC) { inosused = cgrp.cg_initediblk; - else + if (inosused > sblock.fs_ipg) + inosused = sblock.fs_ipg; + } else inosused = sblock.fs_ipg; if (got_siginfo) { printf("%s: phase 1: cyl group %d of %d (%d%%)\n", _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-fs@FreeBSD.ORG Thu Jan 7 02:00:15 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 30FAE10656AA for ; Thu, 7 Jan 2010 02:00:15 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id CA6678FC0C for ; Thu, 7 Jan 2010 02:00:14 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o0720Ewa046818 for ; Thu, 7 Jan 2010 02:00:14 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o0720ENr046817; Thu, 7 Jan 2010 02:00:14 GMT (envelope-from gnats) Date: Thu, 7 Jan 2010 02:00:14 GMT Message-Id: <201001070200.o0720ENr046817@freefall.freebsd.org> To: freebsd-fs@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: bin/138043: commit references a PR X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2010 02:00:15 -0000 The following reply was made to PR bin/138043; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: bin/138043: commit references a PR Date: Thu, 7 Jan 2010 01:56:48 +0000 (UTC) Author: delphij Date: Thu Jan 7 01:56:35 2010 New Revision: 201712 URL: http://svn.freebsd.org/changeset/base/201712 Log: MFC r176575: In pass1(), cap inosused to fs_ipg rather than allowing arbitrary number read from cylinder group. Chances that we read a smarshed cylinder group, and we can not 100% trust information it has supplied. fsck_ffs(8) will crash otherwise for some cases. PR: bin/138043 Reminded by: mckusick Modified: stable/6/sbin/fsck_ffs/pass1.c Directory Properties: stable/6/sbin/fsck_ffs/ (props changed) Modified: stable/6/sbin/fsck_ffs/pass1.c ============================================================================== --- stable/6/sbin/fsck_ffs/pass1.c Thu Jan 7 01:55:34 2010 (r201711) +++ stable/6/sbin/fsck_ffs/pass1.c Thu Jan 7 01:56:35 2010 (r201712) @@ -93,9 +93,11 @@ pass1(void) inumber = c * sblock.fs_ipg; setinodebuf(inumber); getblk(&cgblk, cgtod(&sblock, c), sblock.fs_cgsize); - if (sblock.fs_magic == FS_UFS2_MAGIC) + if (sblock.fs_magic == FS_UFS2_MAGIC) { inosused = cgrp.cg_initediblk; - else + if (inosused > sblock.fs_ipg) + inosused = sblock.fs_ipg; + } else inosused = sblock.fs_ipg; if (got_siginfo) { printf("%s: phase 1: cyl group %d of %d (%d%%)\n", _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-fs@FreeBSD.ORG Thu Jan 7 02:00:16 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ACA191065679 for ; Thu, 7 Jan 2010 02:00:16 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 82A2C8FC1B for ; Thu, 7 Jan 2010 02:00:16 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o0720Gaw046839 for ; Thu, 7 Jan 2010 02:00:16 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o0720GmS046833; Thu, 7 Jan 2010 02:00:16 GMT (envelope-from gnats) Date: Thu, 7 Jan 2010 02:00:16 GMT Message-Id: <201001070200.o0720GmS046833@freefall.freebsd.org> To: freebsd-fs@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: bin/138043: commit references a PR X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2010 02:00:16 -0000 The following reply was made to PR bin/138043; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: bin/138043: commit references a PR Date: Thu, 7 Jan 2010 01:57:22 +0000 (UTC) Author: delphij Date: Thu Jan 7 01:57:13 2010 New Revision: 201713 URL: http://svn.freebsd.org/changeset/base/201713 Log: MFC r176575: In pass1(), cap inosused to fs_ipg rather than allowing arbitrary number read from cylinder group. Chances that we read a smarshed cylinder group, and we can not 100% trust information it has supplied. fsck_ffs(8) will crash otherwise for some cases. PR: bin/138043 Reminded by: mckusick Modified: stable/5/sbin/fsck_ffs/pass1.c Directory Properties: stable/5/sbin/fsck_ffs/ (props changed) Modified: stable/5/sbin/fsck_ffs/pass1.c ============================================================================== --- stable/5/sbin/fsck_ffs/pass1.c Thu Jan 7 01:56:35 2010 (r201712) +++ stable/5/sbin/fsck_ffs/pass1.c Thu Jan 7 01:57:13 2010 (r201713) @@ -93,9 +93,11 @@ pass1(void) inumber = c * sblock.fs_ipg; setinodebuf(inumber); getblk(&cgblk, cgtod(&sblock, c), sblock.fs_cgsize); - if (sblock.fs_magic == FS_UFS2_MAGIC) + if (sblock.fs_magic == FS_UFS2_MAGIC) { inosused = cgrp.cg_initediblk; - else + if (inosused > sblock.fs_ipg) + inosused = sblock.fs_ipg; + } else inosused = sblock.fs_ipg; if (got_siginfo) { printf("%s: phase 1: cyl group %d of %d (%d%%)\n", _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-fs@FreeBSD.ORG Thu Jan 7 04:09:30 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EE92B1065676; Thu, 7 Jan 2010 04:09:30 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C5E958FC0C; Thu, 7 Jan 2010 04:09:30 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o0749UsG058380; Thu, 7 Jan 2010 04:09:30 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o0749UOk058376; Thu, 7 Jan 2010 04:09:30 GMT (envelope-from linimon) Date: Thu, 7 Jan 2010 04:09:30 GMT Message-Id: <201001070409.o0749UOk058376@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-fs@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: kern/142401: [ntfs] [patch] Minor updates to NTFS from NetBSD X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2010 04:09:31 -0000 Old Synopsis: Minor updates to NTFS from NetBSD New Synopsis: [ntfs] [patch] Minor updates to NTFS from NetBSD Responsible-Changed-From-To: freebsd-bugs->freebsd-fs Responsible-Changed-By: linimon Responsible-Changed-When: Thu Jan 7 04:09:12 UTC 2010 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=142401 From owner-freebsd-fs@FreeBSD.ORG Thu Jan 7 09:12:33 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D6CD21065672 for ; Thu, 7 Jan 2010 09:12:33 +0000 (UTC) (envelope-from mla_strick@att.net) Received: from smtp127.sbc.mail.sp1.yahoo.com (smtp127.sbc.mail.sp1.yahoo.com [69.147.65.186]) by mx1.freebsd.org (Postfix) with SMTP id A30CB8FC1F for ; Thu, 7 Jan 2010 09:12:33 +0000 (UTC) Received: (qmail 51915 invoked from network); 7 Jan 2010 09:12:30 -0000 Received: from adsl-69-228-193-61.dsl.pltn13.pacbell.net (mla_strick@69.228.193.61 with login) by smtp127.sbc.mail.sp1.yahoo.com with SMTP; 07 Jan 2010 01:12:30 -0800 PST X-Yahoo-SMTP: ppEzeiKswBBq7wHVNDEiPbPsAwzyGELyRI8IdiDYGqsxaD5uQA-- X-YMail-OSG: CUcpZ3AVM1mVgNyArgHE8iQbdi_w6PGxv8tKRtJdHe06yS4LJ.3SXKV7hR3ZVbNVpeG8RldwoL6ehu49lJ0qmRFnOZhen3ZrqqdpC4a_XEfPQetdANVVVgewUkkBfi1COANl103GHMXasAE7zSYettUaf6UA.rYp9cXMOjBklb5f5hU9EaZ7hcDwcwwT8C1jWO8VuBoApKAaXeKujfmXJiLCIpENN_rwzICG2t7BmD0kd.CzzR0hPzpZ2L2RaF2O0TL_TUALDqkZLX_9z4p2yk2I6haa2qo- X-Yahoo-Newman-Property: ymail-3 Received: from mist.nodomain (localhost [127.0.0.1]) by mist.nodomain (8.14.3/8.14.3) with ESMTP id o079CT36009669; Thu, 7 Jan 2010 01:12:29 -0800 (PST) (envelope-from mla@mist.nodomain) Received: (from dan@localhost) by mist.nodomain (8.14.3/8.14.3/Submit) id o079CS4p009668; Thu, 7 Jan 2010 01:12:28 -0800 (PST) (envelope-from mla) Date: Thu, 7 Jan 2010 01:12:28 -0800 (PST) From: Dan Strick Message-Id: <201001070912.o079CS4p009668@mist.nodomain> To: mckusick@mckusick.com In-Reply-To: <201001070021.o070Lq0J056953@chez.mckusick.com> Cc: freebsd-fs@freebsd.org, bug-followup@freebsd.org, mla@mist.nodomain Subject: Re: kern/141992: fsck cannot repair file system in which it finds an error X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2010 09:12:33 -0000 > From mckusick@mckusick.com Thu Jan 7 00:55:35 2010 > To: Dan Strick > Subject: Re: kern/141992: fsck cannot repair file system in ... > ... > > Please apply this patch to your fsck_ffs and confirm for me that it > corrects your problem. Thanks for all your help. This patch does indeed make the problem I had with that particular file system go away. Thanks, Dan Strick From owner-freebsd-fs@FreeBSD.ORG Thu Jan 7 16:52:38 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5D2EE106568B; Thu, 7 Jan 2010 16:52:38 +0000 (UTC) (envelope-from jh@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 35C5E8FC12; Thu, 7 Jan 2010 16:52:38 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o07GqcnY070050; Thu, 7 Jan 2010 16:52:38 GMT (envelope-from jh@freefall.freebsd.org) Received: (from jh@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o07Gqcmx070046; Thu, 7 Jan 2010 16:52:38 GMT (envelope-from jh) Date: Thu, 7 Jan 2010 16:52:38 GMT Message-Id: <201001071652.o07Gqcmx070046@freefall.freebsd.org> To: jh@FreeBSD.org, freebsd-fs@FreeBSD.org, jh@FreeBSD.org From: jh@FreeBSD.org Cc: Subject: Re: kern/141194: [tmpfs] tmpfs treats the size option as mod 2^32 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2010 16:52:38 -0000 Synopsis: [tmpfs] tmpfs treats the size option as mod 2^32 Responsible-Changed-From-To: freebsd-fs->jh Responsible-Changed-By: jh Responsible-Changed-When: Thu Jan 7 16:52:37 UTC 2010 Responsible-Changed-Why: Take. http://www.freebsd.org/cgi/query-pr.cgi?pr=141194 From owner-freebsd-fs@FreeBSD.ORG Fri Jan 8 13:37:17 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 944971065670; Fri, 8 Jan 2010 13:37:17 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6B1108FC1D; Fri, 8 Jan 2010 13:37:17 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o08DbHQX060502; Fri, 8 Jan 2010 13:37:17 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o08DbHV0060498; Fri, 8 Jan 2010 13:37:17 GMT (envelope-from linimon) Date: Fri, 8 Jan 2010 13:37:17 GMT Message-Id: <201001081337.o08DbHV0060498@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-fs@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: kern/142466: Update 7.2 -> 8.0 on Raid 1 ends with screwed raid [regression] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2010 13:37:17 -0000 Old Synopsis: Update 7.2 -> 8.0 on Raid 1 ends with screwed raid New Synopsis: Update 7.2 -> 8.0 on Raid 1 ends with screwed raid [regression] Responsible-Changed-From-To: freebsd-bugs->freebsd-fs Responsible-Changed-By: linimon Responsible-Changed-When: Fri Jan 8 13:34:08 UTC 2010 Responsible-Changed-Why: I can't really figure out how to classify this one, since it talks about "/dev/ar0" as being a disk device, but it's clearly fs-related. http://www.freebsd.org/cgi/query-pr.cgi?pr=142466 From owner-freebsd-fs@FreeBSD.ORG Fri Jan 8 18:07:16 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 46746106568D for ; Fri, 8 Jan 2010 18:07:16 +0000 (UTC) (envelope-from benschumacher@gmail.com) Received: from mail-pw0-f44.google.com (mail-pw0-f44.google.com [209.85.160.44]) by mx1.freebsd.org (Postfix) with ESMTP id 1F1928FC17 for ; Fri, 8 Jan 2010 18:07:15 +0000 (UTC) Received: by pwi15 with SMTP id 15so175922pwi.3 for ; Fri, 08 Jan 2010 10:07:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=NVH+DNzUasktbMFGXsPR0J+MBPVhf/3s4DDWj6oy88E=; b=YUfKE35I1pRWWypLyIPO3E7lDCZvOyfPpEUXErUnXJ/m4CV2v7u4M8OYfU8hvoaYrw OPsLdGpB8FggkAoNfs3FeLObyuoaomJQrfcUunr1nZYmlQQnwLXYj+f1TkKWM5HYEusl Htmw6/otZukOjwe4nMAbfiKTVLnazUwTkfKTM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type; b=f26wqFrmgKPjP51X0KnynJb70NFhG2tgIP9YAXjZ/pGp3x4YAz508VNJZ27SdBzLCf f2cZSKVJW4WungE6B5VMuYjY9IY/PQfHppDWMutobxx1XRpSwolxcR4RwO8apaYkcCwB Szsqa+rOsrNyUe4YwuBhOKeWdeZkoreMCfAAw= MIME-Version: 1.0 Sender: benschumacher@gmail.com Received: by 10.143.27.37 with SMTP id e37mr3704137wfj.234.1262974031064; Fri, 08 Jan 2010 10:07:11 -0800 (PST) Date: Fri, 8 Jan 2010 11:07:11 -0700 X-Google-Sender-Auth: 3333ea583c878070 Message-ID: <9859143f1001081007t3990555dk624e512e7150201d@mail.gmail.com> From: Ben Schumacher To: freebsd-fs Content-Type: text/plain; charset=UTF-8 Subject: Odd behavior with volume labels and gmirror X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2010 18:07:16 -0000 Hey- I haven't search the list, so this could be covered already, but I've seen odd behavior with volume labels and gmirror. First some background. Here's my uname: $ uname -a FreeBSD filer.sats.internal 8.0-RELEASE-p1 FreeBSD 8.0-RELEASE-p1 #1: Mon Dec 21 10:21:37 MST 2009 ben@filer.sats.internal:/usr/obj/data/FreeBSD/RELENG_8_0/src/sys/FILER i386 I have a 4-way gmirror: $ gmirror status Name Status Components mirror/root COMPLETE ad6s1 ad12s1 ad14s1 ad18s1 With multiple labeled slices: $ tunefs -p /dev/mirror/roota tunefs: ACLs: (-a) disabled tunefs: MAC multilabel: (-l) disabled tunefs: soft updates: (-n) disabled tunefs: gjournal: (-J) disabled tunefs: maximum blocks per file in a cylinder group: (-e) 2048 tunefs: average file size: (-f) 16384 tunefs: average number of files in a directory: (-s) 64 tunefs: minimum percentage of free space: (-m) 8% tunefs: optimization preference: (-o) time tunefs: volume label: (-L) root $ tunefs -p /dev/mirror/rootf tunefs: ACLs: (-a) disabled tunefs: MAC multilabel: (-l) disabled tunefs: soft updates: (-n) enabled tunefs: gjournal: (-J) disabled tunefs: maximum blocks per file in a cylinder group: (-e) 2048 tunefs: average file size: (-f) 16384 tunefs: average number of files in a directory: (-s) 64 tunefs: minimum percentage of free space: (-m) 8% tunefs: optimization preference: (-o) time tunefs: volume label: (-L) usr And used these in my /etc/fstab for mounting: $ cat /etc/fstab # Device Mountpoint FStype Options Dump Pass# /dev/mirror/rootb.eli none swap sw 0 0 /dev/da0b none swap sw 1 0 /dev/ufs/root / ufs rw 1 1 /dev/ufs/tmp /tmp ufs rw,nosuid 2 2 /dev/ufs/usr /usr ufs rw 2 2 /dev/ufr/var /var ufs rw 2 2 The issue I experienced last night is that after a power outage, the system detected the labelled filesystems names from some of the GEOM providers of the mirror -- specifically they appear to all be mapped to "/dev/ad18s1[adef]" and the machine never managed to fully boot without some manual intervention to change /etc/fstab back to using the mirror devices instead of the labels. Insult to injury, I *may* have a drive going bad (ad18), but given what was happening with the mounting, I'm not really sure. I used recoverdisk to dup that disk to the others and it seemed to work fine, but during the label problem I was getting some READ_DMA errors trying to rebuild the mirror. I guess my question is, is using labels on mirrors unreliable since the labels write through and apparently can get detected from the devices before the mirror is loaded? Or is this a bug that I should file a pr for? Thanks for your attention. Cheers, Ben From owner-freebsd-fs@FreeBSD.ORG Sat Jan 9 00:24:33 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E6DD1106566B; Sat, 9 Jan 2010 00:24:33 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id BEA318FC14; Sat, 9 Jan 2010 00:24:33 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o090OXLk024203; Sat, 9 Jan 2010 00:24:33 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o090OX2T024199; Sat, 9 Jan 2010 00:24:33 GMT (envelope-from linimon) Date: Sat, 9 Jan 2010 00:24:33 GMT Message-Id: <201001090024.o090OX2T024199@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-fs@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: kern/142489: [zfs] [lor] allproc/zfs LOR X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jan 2010 00:24:34 -0000 Old Synopsis: [lor] allproc/zfs LOR New Synopsis: [zfs] [lor] allproc/zfs LOR Responsible-Changed-From-To: freebsd-bugs->freebsd-fs Responsible-Changed-By: linimon Responsible-Changed-When: Sat Jan 9 00:24:13 UTC 2010 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=142489 From owner-freebsd-fs@FreeBSD.ORG Sat Jan 9 23:35:33 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1A0FE1065692 for ; Sat, 9 Jan 2010 23:35:33 +0000 (UTC) (envelope-from stevenschlansker@gmail.com) Received: from mail-yx0-f171.google.com (mail-yx0-f171.google.com [209.85.210.171]) by mx1.freebsd.org (Postfix) with ESMTP id C04D68FC0C for ; Sat, 9 Jan 2010 23:35:32 +0000 (UTC) Received: by yxe1 with SMTP id 1so19057926yxe.3 for ; Sat, 09 Jan 2010 15:35:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:content-type:mime-version :subject:from:in-reply-to:date:content-transfer-encoding:message-id :references:to:x-mailer; bh=Y9FfXUojKxNnGklHpB3GvyLcNgjcjrOQVD/fpMlgL6Y=; b=hdVwbhF9+A8SuGOUF2rFsGmhDCkmZUYSMQqxXdbitRQ2ADjOccHfXM2dOHkyRsr7NP Dln9OLnCcaGLScIWOMrULhXUrC3ahdpjOGiBeJdHuYnAWb+TSvVvwQK8XBnrnDChE5dq gPSsGBBVh3UypBiJIJ+IpaBfMy/nSEBMVC0pA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=content-type:mime-version:subject:from:in-reply-to:date :content-transfer-encoding:message-id:references:to:x-mailer; b=WBeRfhP34FKj0iQyTG6kN40UD01bCxWUT3RbBFbxWVEpcGgs82eW7PSsGEFmSDXRWH Vr8TGVCydZbKQDaRwsBxWoaeiJKVeW1oYfqJaVIaNprsVYCNpbsk33nc3yQR4BXSSfwZ jQrJnoC7Uea7vXacDYFAE3Pa9LVX1qx+8povY= Received: by 10.151.16.3 with SMTP id t3mr5363777ybi.264.1263080128840; Sat, 09 Jan 2010 15:35:28 -0800 (PST) Received: from ?192.168.42.92? (70-36-134-162.dsl.dynamic.sonic.net [70.36.134.162]) by mx.google.com with ESMTPS id 9sm9854822yxf.41.2010.01.09.15.35.27 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 09 Jan 2010 15:35:27 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Apple Message framework v1077) From: Steven Schlansker In-Reply-To: Date: Sat, 9 Jan 2010 15:35:03 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <048AF210-8B9A-40EF-B970-E8794EC66B2F@gmail.com> <4B315320.5050504@quip.cz> <5da0588e0912221741r48395defnd11e34728d2b7b97@mail.gmail.com> <9CEE3EE5-2CF7-440E-B5F4-D2BD796EA55C@gmail.com> <5565955F-482A-4628-A528-117C58046B1F@gmail.com> To: freebsd-fs@freebsd.org X-Mailer: Apple Mail (2.1077) Subject: Re: ZFS: Can't repair raidz2 (Cannot replace a replacing device) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jan 2010 23:35:33 -0000 On Dec 27, 2009, at 8:59 PM, Wes Morgan wrote: > On Sun, 27 Dec 2009, Steven Schlansker wrote: >=20 >>=20 >> On Dec 24, 2009, at 5:17 AM, Wes Morgan wrote: >>=20 >>> On Wed, 23 Dec 2009, Steven Schlansker wrote: >>>>=20 >>>> Why has the replacing vdev not gone away? I still can't detach - >>>> [steven@universe:~]% sudo zpool detach universe 6170688083648327969 >>>> cannot detach 6170688083648327969: no valid replicas >>>> even though now there actually is a valid replica (ad26) >>>=20 >>> Try detaching ad26. If it lets you do that it will abort the = replacement and then you just do another replacement with the real = device. If it won't let you do that, you may be stuck having to do some = metadata tricks. >>>=20 >>=20 >> errors: No known data errors >> [steven@universe:~]% sudo zpool detach universe ad26 >> cannot detach ad26: no valid replicas >> [steven@universe:~]% sudo zpool offline -t universe ad26 >> cannot offline ad26: no valid replicas >>=20 >=20 > I just tried to re-create this scenario with some sparse files and I = was able to detach it completely (below). There is one difference, = however. Your array is returning checksum errors for the ad26 device. = Perhaps this is making the system think that there is no sibling device = in the replacement node that has all the data, so it denies the detach. = Even though logically the data will be recovered by a scrub later.. = Interesting. If you can determine where the detach is failing, that will = help paint the complete picture. >=20 Interestingly enough, I found a solution! Somewhat roundabout, but what = I did was replace a different device and let it resilver completely. = Then the array looked like this: NAME STATE READ WRITE CKSUM universe DEGRADED 0 0 0 raidz2 DEGRADED 0 0 0 ad16 ONLINE 0 0 0 replacing DEGRADED 0 0 0 ad26 ONLINE 0 0 0 6170688083648327969 UNAVAIL 0 1.13M 0 was = /dev/ad12 ad8 ONLINE 0 0 0 da0 ONLINE 0 0 0 ad10 ONLINE 0 0 0 concat/ad4ex ONLINE 0 0 0 ad24 ONLINE 0 0 0 concat/ad6ex ONLINE 0 0 0 Just for kicks, I then tried to detach - [steven@universe:~]% sudo zpool detach universe 6170688083648327969 [steven@universe:~]% sudo zpool status pool: universe state: ONLINE scrub: none requested config: NAME STATE READ WRITE CKSUM universe ONLINE 0 0 0 raidz2 ONLINE 0 0 0 ad16 ONLINE 0 0 0 ad26 ONLINE 0 0 0 ad8 ONLINE 0 0 0 da0 ONLINE 0 0 0 ad10 ONLINE 0 0 0 concat/ad4ex ONLINE 0 0 0 ad24 ONLINE 0 0 0 concat/ad6ex ONLINE 0 0 0 Ta-da! I have no idea why this helped, or how it fixed it, but if = anyone has this problem in the future try replacing a different device, letting it resilver, and = then detach the original problematic devices.