From owner-freebsd-ports@FreeBSD.ORG Sun Jan 3 00:09:29 2010 Return-Path: Delivered-To: FreeBSD-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7C58D1065670 for ; Sun, 3 Jan 2010 00:09:29 +0000 (UTC) (envelope-from nikola.lecic@anthesphoria.net) Received: from anthesphoria.net (anthesphoria.net [200.46.204.219]) by mx1.freebsd.org (Postfix) with ESMTP id 2CB088FC1A for ; Sun, 3 Jan 2010 00:09:28 +0000 (UTC) X-Bogosity: No, tests=bogofilter X-DKIM: Sendmail DKIM Filter v2.8.3 anthesphoria.net o0309ODm082493 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anthesphoria.net; s=phero; t=1262477368; bh=s+qTJTflsY4LaiBTbIr8TuR4bEN23YKE45rfKBbmhx4=; l=3650; h=Date:From:To:Cc:Subject:In-Reply-To:References:Mime-Version: Content-Type:Content-Transfer-Encoding; b=AqlqlG//jrC8AuUselVBfo1+FjYCb3KMkBCv1fVKEE1QcwapaFVQQtxdmSi7vk5qR 3Rl4EeHN4GvIZXJIiv76u/2YJxWCfhouVGnVBjTxbp9BUiGc8SANePvYYpjLYKnuf4 uGICnjwstMjyRgI3evtGwZqDXIgSlxG9YTwjeC4M= Received: from black.localhost (dynamic-213-198-192-91.adsl.eunet.rs [213.198.192.91]) (authenticated bits=0) by anthesphoria.net (8.14.3/8.14.3) with ESMTP id o0309ODm082493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 3 Jan 2010 01:09:26 +0100 (CET) (envelope-from nikola.lecic@anthesphoria.net) Message-Id: <201001030009.o0309ODm082493@anthesphoria.net> Date: Sun, 3 Jan 2010 01:06:03 +0100 From: Nikola =?UTF-8?B?TGXEjWnEhw==?= To: Doug Barton In-Reply-To: <4B3FBD85.9090109@FreeBSD.org> References: <201001021701.o02H19VE093008@anthesphoria.net> <4B3FBD85.9090109@FreeBSD.org> X-Mailer: Claws Mail 3.7.1 (GTK+ 2.16.2; i386-portbld-freebsd7.2) X-Face: pbl6-.[$G'Fi(Ogs2xlXP-V6{3||$Y[LOYs&~GJoikj'cVjcFC[V7du;;0~6nO= [Vi2?uU1Pq~,=Adj@,T:|"`$AF~il]J.Nz#2pU',Y7.{B;m/?{#sO^Dvo$rnmY6] X-Operating-System: FreeBSD 7-STABLE X-OpenPGP-Fingerprint: FEF3 66AF C90E EDC3 D878 7CDC 956D F4AB A377 1C9B X-OpenPGP-Preferred-Keyserver: x-hkp://pgpkeys.pca.dfn.de Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAMAAABg3Am1AAAAP1BMVEW/o5oJFQugmIt8gnhy bWEZJSRHRjqzlI0hIhcsHhd7X1RbWlLe3dWOgXZhWUY0Mye0t6sODgj5//8pOEOcfnVQ+D28 AAACWElEQVRIidWV3XLrIAyEbZAF5p/E7/+sZwVx46bgaS+PZpJedD+kRUJZHn+M5X8Cwq+B EIlzZkuqDKAfQEhr7bGu1Xr1yXwC1KUQyweRyi1A9QSsxL7XyuUGiG99RjAnzjWXKaCavp2d OSEoEeVqywQIu8jbyZDHVyRUFcYAteO7nKipF6VU+pbiApRejlSeknMxqh44Jw0BOgsSuXOH AMuyqGivvi8A1070BO44TgC21QjIJ8AtgxOgETgphZ9AsN3zd8B0gAcZvoB8AmLbmEWlObBa GSJclADJs/finNY5ALnMRkaOlLdty0wNoKnp1UK2rrs7nE/J+0RRGjG8JXiToX4+t7UCiP75 fHKSDNdWX4Bo26RuAlTcEUFPCSZo5yGgANhqt5ytlHSQ99S67TINSypn52wr6ZDhM2iEOZwJ IyAwElT0AX8EAHEY9MGYwzyGgG8J9l2epsxSBNT1yxBo47pDjATsDtMBSbFMAHkQO+Ll4Uiu AWYKPKSmPct4VHZEyjk5Hvc1fnH9UcM0gG33USsNwhi102MGZEmADNYzRa010YEHdN0BH3sJ 0yFdwDfmlCKRRue0ekwB3BO2MDxn77A2vG9AmAOh1k08c58KFIXRuFuVuKe2iPFM2xg1INwB eEWwgHeDDFEyaH2/vWFbfhYE0K8Id0DBxKKkbXsDHwl+9KGvewBe2gB98WoOpPO3aoVrL4wq uvrZtRJ/6VexLfJSdGY9Bri+9dWyeCgCYPvr0fD5egJtmLif34HNvo28ALanXu40S0FdX6CX f+bwmeG38WfgH6BpgKIbq96MAAAAAElFTkSuQmCC Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD-ports@FreeBSD.org Subject: Re: portmaster: printing messages that do not come from pkg-message files X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jan 2010 00:09:29 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: RIPEMD160 On Sat, 02 Jan 2010 13:41:25 -0800 in <4B3FBD85.9090109@FreeBSD.org> Doug Barton wrote: =20 > Nikola Le=C4=8Di=C4=87 wrote: > > Hello, > >=20 > > portmaster's feature to print collected pkg-message files after > > successful installation is very useful. However, there are many > > ports that echo messages from inside Makefile, usually in > > post-install phase (but not exclusively there). > >=20 > > A simple question: would it be possible (or better, would it be > > desirable) to collect that text as well and to include it in the > > final output in the same way it is done with pkg-messages? >=20 > In a word, no. :) Random messages emitted by the port at random > points in the process are evil (well, usually they are evil), and > should not be encouraged. I see. I asked because the practice to emit such messages seems to be widespread and I cannot find any place where the Porters Handbook discourages it -- correct me if I am wrong. > Messages related to build choices should be handled by OPTIONS, > information that the user needs after the port is installed should be > handled in the pkg-message. Portmaster has support for both of those. Yes, but port messages often tells what could have been done differently _before_; see below. > If you have something specific in mind, or specific examples of a port > that emits something meaningful I'll be glad to take another look, but > as a general principle my opinion is that using the established > mechanisms is the better route to take. editors/openoffice.org-*: the ports emit a lot of important info through files/Makefile.knobs; it would be nice to have these messages printed after the build; they are not about what should be done after the install, but about what *could* be done differently. multimedia/mplayer: the same thing, two important messages that should not be lost somewhere in a huge build log. net/quagga: big pre-everything and crucial post-install info. security/stunnel: again, crucial post-install info. databases/mysql60-server: everything that is important is echoed in advance. devel/tmake: an example of short post-install message -- is it worth adding pkg-message instead? Also, lang/php_doc www/apache22 www/moinmoin mail/squirrelmail Finally, not that important, but some my own ports have Makefile messages: textproc/scim-kmfl-imengine in pre-patch and other scim-kmfl-* ports in post-install; I never met any resistance by any committer in regard to that fact. I understand that these things could be handled by OPTIONS and pkg_message, but this is not the case. So, if this behaviour is considered definitely bad, maybe maintainers should be called to gradually adapt their ports accordingly (as Julien Laffaye suggested in his reply and as it was done in the past, e.g. for adding more DESKTOP_ENTRIES)? > PS, I'm glad you find the pkg-message feature useful. :) Indeed, among many others. :-) Best wishes, - --=20 Nikola Le=C4=8Di=C4=87 =3D =D0=9D=D0=B8=D0=BA=D0=BE=D0=BB=D0=B0 =D0=9B=D0= =B5=D1=87=D0=B8=D1=9B fingerprint : FEF3 66AF C90E EDC3 D878 7CDC 956D F4AB A377 1C9B ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iJwEAQEDAAYFAks/33IACgkQ/MM/0rYIoZgs5wQAqtZw+Eo202UROBisv3cAQZTR ee7GbA+JTQ9UphbMhWQ+M65S2fysr+1Lo2VrE0RZ9QGWGQQXxljsbqFQXLOGzd2J mnwJypW8xHbB+10mA2xJ7HgFDtIV1yc3dsgU1wAK96OF4zWsaz/BLMUG/TSJM9Gb vfiVootdRYyhqzET10c=3D =3DoqBc -----END PGP SIGNATURE-----