From owner-freebsd-hackers@freebsd.org Mon Oct 5 05:40:43 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 953D5A1022A for ; Mon, 5 Oct 2015 05:40:43 +0000 (UTC) (envelope-from j.deboynepollard-newsgroups@ntlworld.com) Received: from know-smtprelay-omc-5.server.virginmedia.net (know-smtprelay-omc-5.server.virginmedia.net [80.0.253.69]) by mx1.freebsd.org (Postfix) with ESMTP id E07A8300 for ; Mon, 5 Oct 2015 05:40:41 +0000 (UTC) (envelope-from j.deboynepollard-newsgroups@ntlworld.com) Received: from [192.168.1.100] ([86.10.211.13]) by know-smtprelay-5-imp with bizsmtp id RHfW1r00D0HtmFq01HfWUr; Mon, 05 Oct 2015 06:39:30 +0100 X-Originating-IP: [86.10.211.13] X-Spam: 0 X-Authority: v=2.1 cv=Sd8KDalu c=1 sm=1 tr=0 a=SB7hr1IvJSWWr45F2gQiKw==:117 a=SB7hr1IvJSWWr45F2gQiKw==:17 a=NLZqzBF-AAAA:8 a=IkcTkHD0fZMA:10 a=xZ8m6LBGGdpluPDHvEAA:9 a=QEXdDO2ut3YA:10 a=XdyKOaxJwVsA:10 Subject: nosh version 1.21 To: supervision@list.skarnet.org, FreeBSD Hackers , debian-user@lists.debian.org References: <54430B41.3010301@NTLWorld.com> <54B86FD5.3090203@NTLWorld.com> <554E53EF.4080600@NTLWorld.com> <554E93AF.3070709@NTLWorld.com> <556BA130.50708@NTLWorld.com> <55902328.8080602@NTLWorld.com> <55D5CFA2.5010402@NTLWorld.com> <55D8B9AC.6010209@NTLWorld.com> <56089268.6080007@NTLWorld.com> From: Jonathan de Boyne Pollard Message-ID: <56120D11.4080506@NTLWorld.com> Date: Mon, 5 Oct 2015 06:39:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.0; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <56089268.6080007@NTLWorld.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2015 05:40:43 -0000 The nosh package is now up to version 1.21 . * http://homepage.ntlworld.com./jonathan.deboynepollard/Softwares/nosh.html console-terminal-emulator now has a mouse input event protocol, and speaks both the DEC VT Locator protocol and the xterm Private Mode 1006 protocol over the terminal interface to applications. These are the protocols that you get with ttymouse=dec and ttymouse=sgr in vim. Since support for the 1006 protocol is fairly widespread in the relevant places nowadays, it seemed not worthwhile implementing the inferior Private Mode 1005 and Private Mode 1015 protocols. Moreover, console-terminal-emulator is UTF-8 and the Private Mode 1005 protocol has ambiguities once one introduces UTF-8. console-fb-realizer as yet only talks to real mouse input devices on Linux, but handling FreeBSD/PC-BSD mouse input devices is on the roadmap. This has necessitated a change in the command-line syntax of console-fb-realizer, and concomitant changes in the pre-supplied realizer service bundle, which will need to be updated in tandem if you are using user-space virtual terminals. This change allows the mouse input device to be specified in addition to the keyboard input event device. It also slightly regularizes display-only mode, which is signified now by the simple lack of any mouse or keyboard device specifications, rather than by an explicit option. Yes, I am aware that there's no mouse cursor sprite drawn yet. Acutely so. FreeBSD improvements include the completion of geli and gbde import that the sharp-eyed might have noticed quietly part-done in version 1.20. /etc/fstab entries for volumes using these should now be translated into appropriate interdependent mount@*, gbde@*, and geli@* service bundles. This is rather difficult for me to test, though, as noted on the roadmap. The big PC-BSD improvement is jails support, which has lurked at the bottom of the roadmap page for a while. Both PC-BSD Warden and FreeBSD 9 jails are now recognized by the external configuration import subsystem, and converted into appropriate service bundles. The mechanism here is fairly straightforward: The jails themselves are one service bundle, and the programs that run in the jails are another. The latter service is after/ and wants/ the former service. The jexec command is a chain loading tool that modifies process state in the same vein as setuidgid, softlimit, and envdir, and one can simply employ it as such. The jail command can be used analogously, with jail -c and jail -r, to how the mount and umount commands in mount@* service bundles are used. Those are what the import subsystem does. Importing Warden Linux jails isn't available yet; and some of the more esoteric FreeBSD 9 rc.conf and PC-BSD Warden METADIR/* jail options are not yet imported. Enabling jails to be autostarted at bootstrap is via the "jails" and "warden" targets, by the way. The rc.d conversion project has progressed, with a few more things wiped off. As mentioned in the version 1.20 message, all assistance in wiping the final 40-odd FreeBSD rc.d scripts off the list, to be found on the roadmap page, is welcome. And if any PC-BSD people have ideas on how to turn things like /usr/local/etc/rc.d/pc-samba into service bundles, those are welcome too. (Note that pre-supplied service bundles already exist for the Linux flavours of some of these, which may or may not be a starting point.) From owner-freebsd-hackers@freebsd.org Mon Oct 5 16:10:20 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E895D9B5BCB for ; Mon, 5 Oct 2015 16:10:20 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ob0-x22c.google.com (mail-ob0-x22c.google.com [IPv6:2607:f8b0:4003:c01::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BA94210A for ; Mon, 5 Oct 2015 16:10:20 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by obbbh8 with SMTP id bh8so132294983obb.0 for ; Mon, 05 Oct 2015 09:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=AB9jZIgFkab9NE47X5Dqx/LZot8tReqQ2hbjAq739WE=; b=qCaS+EW80IaFP9HtsMPbzMLQxB74mZD6WtqzEu2ZK8WwjO6lYP+ihXoBb3ZrgRO87w XdOtMUvCmLz6s5Bgej24ta5MW8gKcQambYApEQ55ReR74BWEyTlHGaXR4OBM5eBCMa4I TjjOOOddsBmr0FxY1fuJUNTit+t+/4yqC/UZAi8mpgXukRjPKMq9QBY+hY0uhuNdLxP1 /dnlSJgnYdP0mSUkbP5AsDMKQlVvdAdI44awgkbUjbvYrbyGx0Cl+q/J3BIzvau7PmV4 ZzCu8K2/h52AM8IsDR/PvVyb47DvcgLwnxHKFw/2VgQlvmXsrdKp9fHAeoTaVwwQ5+ac nTSg== MIME-Version: 1.0 X-Received: by 10.60.79.193 with SMTP id l1mr16980211oex.60.1444061420119; Mon, 05 Oct 2015 09:10:20 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.202.71.6 with HTTP; Mon, 5 Oct 2015 09:10:20 -0700 (PDT) In-Reply-To: <17754582315773747312@scdbackup.webframe.org> References: <3FEED4EA-25B2-4F6A-AEA1-4390B8BC4F2D@gmail.com> <17754582315773747312@scdbackup.webframe.org> Date: Mon, 5 Oct 2015 10:10:20 -0600 X-Google-Sender-Auth: 3cLRDlqIN3apTLVhcs8wv3f0S_c Message-ID: Subject: Re: Which program produces FreeBSD-11.0-CURRENT-amd64-*-disc1.iso ? From: Alan Somers To: Thomas Schmitt Cc: "freebsd-hackers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2015 16:10:21 -0000 Our Coverity checker found 34 potential defects in the head/usr.sbin/makefs directory. Sadly, I can't find any way to export that information. Would it be possible to get Thomas an account? FYI, Thomas, the FreeBSD project has had a free Coverity account for a few years now. It does a good job of notifying us of new bugs, and some files have been cleaned up. But since more than 18,000 potential defects have been found and most of them are false positives, there is still a huge backlog of untriaged defects. -Alan On Sat, Oct 3, 2015 at 3:16 PM, Thomas Schmitt wrote: > Hi, > > Garrett Cooper wrote: >> ISOs are created by makefs in the base system: >> https://svnweb.freebsd.org/base/head/release/amd64/mkisoimages.sh?view=log > > I assume that the source is at > https://svnweb.freebsd.org/base/head/usr.sbin/makefs/ > > There i can see the reason for problem #1 (unitialized malloc > memory in date field) and that my assessment of problem #3 > was wrong (two bugs, one partly correcting the other). > > Thanks for the pointer. > > > Have a nice day :) > > Thomas > > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" From owner-freebsd-hackers@freebsd.org Mon Oct 5 19:00:50 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6D0CC99A395 for ; Mon, 5 Oct 2015 19:00:50 +0000 (UTC) (envelope-from scdbackup@gmx.net) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2B9CF7D4 for ; Mon, 5 Oct 2015 19:00:49 +0000 (UTC) (envelope-from scdbackup@gmx.net) Received: from scdbackup.webframe.org ([79.192.94.39]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MMXVC-1ZhXdP3GOc-008G0N for ; Mon, 05 Oct 2015 21:00:41 +0200 Date: Mon, 05 Oct 2015 21:02:08 +0200 From: "Thomas Schmitt" To: freebsd-hackers@freebsd.org Subject: Re: Which program produces FreeBSD-11.0-CURRENT-amd64-*-disc1.iso ? Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit References: In-Reply-To: Message-Id: <16694582476300143275@scdbackup.webframe.org> X-Provags-ID: V03:K0:6ZHSJpo2mjA29fevE9BAsiaeq3N/Wdk7sSTK6j75/mHpnpzkv/N UR/Z7+hycslyWsG7bcKgf3QRMlF9+wC7ECkLIfyDp8xDKwUpExa3OyIko14cikwv5vni9Nm kabyn8MbTops1FUnOH5e+Q5iRT1GYxEqxrGSyWKzrCNUM3MWYsFPCxTmADv+9RQ0AnlGI+V PGrzJ9uVYtzzYv4m92hrA== X-UI-Out-Filterresults: notjunk:1;V01:K0:G1YpWrxxWeg=:mR5zB3j8Tt0fpxeL+QNTfP oqbtVt846sWe+C3f5Z8UBmJ0Ehj+7DF5k//bMj7MuW8xs6q1mRJg9C995xf4iweVp/e8UD60l NXod0qT0vFglQTZVAGysoaVKx9geMtjdq1ZVxC/IVBZ/VRfvfKePNEjgON+UAxR0e0eCBoowG NhR4Dw68YpSKFexQC6f278IqK97UXkftBpYYWdApfB2ePCnsHgDAgAbkmXAzfxQI8pKF0zj1R hUqKeSMxJXN4+2iuIrsiUavHBkpkxWfBZYBUAkRh68Ll/S2JXjjHnh7BOAyYDd7koIxYqnvz3 qoOGeB4jd2lLtqZ7O5qpRSSxTa/s2vwaQsXvzzwVCidrgFl0IvZQcXNKIwFdgnid4l+9rcy6n fn/+EpfFfGIPFK7suNNMvpLJrPkPvGIrzOR4gePaBt7gYqGAPKsTFScFIlGmCVRv+u4okTyrP sWMz0XzvpVCpninMPoPGQwIyHzrVpfMP7w1DN5CXyLRS7B98J8AMpIuq0WeTI1EzyFSLx8PIm J2UaGCQjwVBdGLwFHSwN/Qz4QM1/obp6KjtYm8KbaTGYh/gPc7X3dCWhPMXaj8XzWhdTImUj7 GAPm0tL0bNl/d4A8Cjl1Gtwh2gJ4QJ4jUqsnc2AUwr3K9enATc48mk9IdjkTSnArJ9mXTlNhP 1L0K5oZnICFpNZRRqLR22lfxuZxLxqM886CjVkDB8V8dgfhx3riexrSfQzoxHPMagTTtEnGiL 4rQWPC9MKum4yyameQ82VaAU/yQpNjuZAiC0+4P42GbUoNNV2hW5ledwjEu6uQqpm3cBH94tj lJIpXtQ X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2015 19:00:50 -0000 Hi, > the FreeBSD project has had a free Coverity account for a > few years now. Does it also get applied to ports ? Especially i would be interested in my own upstream stuff: http://portsmon.freebsd.org/portoverview.py?category=devel&portname=libburn http://portsmon.freebsd.org/portoverview.py?category=devel&portname=libisofs http://portsmon.freebsd.org/portoverview.py?category=sysutils&portname=xorriso Meanwhile i filed https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203531 Problem #1 would be a candidate for Coverity. "Uninitialized malloc memory in timestamp of root directory." The other three problems are decisions at the discretion of the programmer. We will have to wait a few more years before automats can tell us that we got the specs wrong or try to save a few bytes where it is not worth the hassle. > Would it be possible to get Thomas an account? A list of my own errors would not really be welcome but in any case appreciated. :)) A Coverity run over makefs would make sense if my proposals get implemented in some way. I hope they are safe, but one never knows. Have a nice day :) Thomas From owner-freebsd-hackers@freebsd.org Mon Oct 5 19:46:53 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8EE549B66F4 for ; Mon, 5 Oct 2015 19:46:53 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from slim.berklix.org (slim.berklix.org [94.185.90.68]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1F9961EFA; Mon, 5 Oct 2015 19:46:51 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from mart.js.berklix.net (p5083C0E0.dip0.t-ipconnect.de [80.131.192.224]) (authenticated bits=128) by slim.berklix.org (8.14.5/8.14.5) with ESMTP id t95JlU2m070112; Mon, 5 Oct 2015 21:47:30 +0200 (CEST) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (fire.js.berklix.net [192.168.91.41]) by mart.js.berklix.net (8.14.3/8.14.3) with ESMTP id t95JklOu066103; Mon, 5 Oct 2015 21:46:47 +0200 (CEST) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (localhost [127.0.0.1]) by fire.js.berklix.net (8.14.7/8.14.7) with ESMTP id t95JkTaT031200; Mon, 5 Oct 2015 21:46:41 +0200 (CEST) (envelope-from jhs@berklix.com) Message-Id: <201510051946.t95JkTaT031200@fire.js.berklix.net> To: Alan Somers cc: Thomas Schmitt Cc: "freebsd-hackers@freebsd.org" Subject: Re: Which program produces FreeBSD-11.0-CURRENT-amd64-*-disc1.iso ? From: "Julian H. Stacey" Organization: http://berklix.com BSD Unix Linux Consultants, Munich Germany User-agent: EXMH on FreeBSD http://berklix.com/free/ X-URL: http://www.berklix.com In-reply-to: Your message "Mon, 05 Oct 2015 10:10:20 -0600." Date: Mon, 05 Oct 2015 21:46:29 +0200 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2015 19:46:53 -0000 Hi, Reference: > From: Alan Somers > Date: Mon, 5 Oct 2015 10:10:20 -0600 Alan Somers wrote: > Our Coverity checker found 34 potential defects in the > head/usr.sbin/makefs directory. Sadly, I can't find any way to export > that information. Off topic, & a cludge, & I'm sure you'r looking for divert of stdout really, but if you get desperate: /usr/ports/graphics/xv has a frame / window / moused section grabber. /usr/ports/graphics/tesseract is a nice OCR optical character recognition program, works well here on tiff format. Cheers, Julian -- Julian Stacey, BSD Linux Unix Sys. Eng. Consultant Munich http://berklix.com Reply After previous text to preserve context, as in a play script. Indent previous text with > Insert new lines before 80 chars. Use plain text, Not quoted-printable, Not HTML, Not base64, Not MS.doc. From owner-freebsd-hackers@freebsd.org Mon Oct 5 21:04:48 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DF36599A5AE for ; Mon, 5 Oct 2015 21:04:48 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi0-x22f.google.com (mail-oi0-x22f.google.com [IPv6:2607:f8b0:4003:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B7841640 for ; Mon, 5 Oct 2015 21:04:48 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by oiww128 with SMTP id w128so98154022oiw.2 for ; Mon, 05 Oct 2015 14:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=oxIlAlxyX6co9FtqrN4xO3WrNC+YEx0GjPyCN6kA9Lg=; b=Z39wvCPLJZJO+2783YBN4ALbTaSIqD/iw+JwEfSKpL+HzNImkZ5o5SFGpdoBIPz6LY Glc7IZdlcximJfqdYrweCbvjEyaCIpE8QTUijs9vSXaD4ktlXKj0kX2K0zVm5Tu4UvQR ugY2iqrNNLleVzVY/A4mYplzdsV5d3RthsIHVThI8TXCLi+6n0ZaJTPdceT7kBFuBM6e 4Z43PRu/ZftvHmd8TWxwxGR3UIQCRCOwB86a2yIql9wRfF+HANdV1jWQuGE3rBCW4jRv 1xUXrniniT7GoVQrp0k400O/XC09r9Z/zhonrs8K9Rgb5xaA5H/46e0pcVVBsiiBccy/ Lk4A== MIME-Version: 1.0 X-Received: by 10.202.228.210 with SMTP id b201mr17820404oih.100.1444079087808; Mon, 05 Oct 2015 14:04:47 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.202.71.6 with HTTP; Mon, 5 Oct 2015 14:04:47 -0700 (PDT) In-Reply-To: <16694582476300143275@scdbackup.webframe.org> References: <16694582476300143275@scdbackup.webframe.org> Date: Mon, 5 Oct 2015 15:04:47 -0600 X-Google-Sender-Auth: dUb2DaM-YeXObhJbx680nb9lvZM Message-ID: Subject: Re: Which program produces FreeBSD-11.0-CURRENT-amd64-*-disc1.iso ? From: Alan Somers To: Thomas Schmitt Cc: "freebsd-hackers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2015 21:04:49 -0000 On Mon, Oct 5, 2015 at 1:02 PM, Thomas Schmitt wrote: > Hi, > >> the FreeBSD project has had a free Coverity account for a >> few years now. > > Does it also get applied to ports ? > Especially i would be interested in my own upstream stuff: > http://portsmon.freebsd.org/portoverview.py?category=devel&portname=libburn > http://portsmon.freebsd.org/portoverview.py?category=devel&portname=libisofs > http://portsmon.freebsd.org/portoverview.py?category=sysutils&portname=xorriso > > Meanwhile i filed > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203531 > > Problem #1 would be a candidate for Coverity. > "Uninitialized malloc memory in timestamp of root directory." > > The other three problems are decisions at the discretion of > the programmer. We will have to wait a few more years before > automats can tell us that we got the specs wrong or try to > save a few bytes where it is not worth the hassle. > > >> Would it be possible to get Thomas an account? > > A list of my own errors would not really be welcome but in > any case appreciated. :)) > > A Coverity run over makefs would make sense if my proposals > get implemented in some way. I hope they are safe, but one > never knows. > > > Have a nice day :) > > Thomas Nope. Coverity only runs on CURRENT. It only knows how to check C and C++ code, so it wouldn't be very useful in ports, anyway. Thanks a lot for the bug report! -Alan From owner-freebsd-hackers@freebsd.org Mon Oct 5 23:03:57 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CAAF99B994E for ; Mon, 5 Oct 2015 23:03:57 +0000 (UTC) (envelope-from jan@digitaldaemon.com) Received: from digitaldaemon.com (digitaldaemon.com [162.217.114.50]) by mx1.freebsd.org (Postfix) with SMTP id 6336FA for ; Mon, 5 Oct 2015 23:03:57 +0000 (UTC) (envelope-from jan@digitaldaemon.com) Received: (qmail 61513 invoked by uid 89); 5 Oct 2015 22:57:14 -0000 Received: from c-73-198-164-157.hsd1.nj.comcast.net (HELO ?192.168.0.6?) (jan@digitaldaemon.com@73.198.164.157) by digitaldaemon.com with SMTP; 5 Oct 2015 22:57:14 -0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: Which program produces FreeBSD-11.0-CURRENT-amd64-*-disc1.iso ? From: Jan Knepper X-Mailer: iPhone Mail (12H143) In-Reply-To: Date: Mon, 5 Oct 2015 18:57:13 -0400 Cc: Thomas Schmitt , "freebsd-hackers@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <62905755-63CE-430E-A6AA-D3FCE3EF347A@digitaldaemon.com> References: <16694582476300143275@scdbackup.webframe.org> To: Alan Somers X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2015 23:03:57 -0000 Actually... Coverity also can check Java, C#, JavaScript and Objective-C. The group I work for at the FAA uses it for C/C++ Jan ManiaC++ Jan Knepper > On Oct 5, 2015, at 17:04, Alan Somers wrote: >=20 >> On Mon, Oct 5, 2015 at 1:02 PM, Thomas Schmitt wrote:= >> Hi, >>=20 >>> the FreeBSD project has had a free Coverity account for a >>> few years now. >>=20 >> Does it also get applied to ports ? >> Especially i would be interested in my own upstream stuff: >> http://portsmon.freebsd.org/portoverview.py?category=3Ddevel&portname=3D= libburn >> http://portsmon.freebsd.org/portoverview.py?category=3Ddevel&portname=3D= libisofs >> http://portsmon.freebsd.org/portoverview.py?category=3Dsysutils&portname= =3Dxorriso >>=20 >> Meanwhile i filed >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D203531 >>=20 >> Problem #1 would be a candidate for Coverity. >> "Uninitialized malloc memory in timestamp of root directory." >>=20 >> The other three problems are decisions at the discretion of >> the programmer. We will have to wait a few more years before >> automats can tell us that we got the specs wrong or try to >> save a few bytes where it is not worth the hassle. >>=20 >>=20 >>> Would it be possible to get Thomas an account? >>=20 >> A list of my own errors would not really be welcome but in >> any case appreciated. :)) >>=20 >> A Coverity run over makefs would make sense if my proposals >> get implemented in some way. I hope they are safe, but one >> never knows. >>=20 >>=20 >> Have a nice day :) >>=20 >> Thomas >=20 > Nope. Coverity only runs on CURRENT. It only knows how to check C and > C++ code, so it wouldn't be very useful in ports, anyway. Thanks a > lot for the bug report! >=20 > -Alan > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"= From owner-freebsd-hackers@freebsd.org Mon Oct 5 23:48:50 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2326E9B9DBC for ; Mon, 5 Oct 2015 23:48:50 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ob0-x232.google.com (mail-ob0-x232.google.com [IPv6:2607:f8b0:4003:c01::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DE87D7D3; Mon, 5 Oct 2015 23:48:49 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by obbbh8 with SMTP id bh8so141588396obb.0; Mon, 05 Oct 2015 16:48:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=unaT74T5BNDpWW/ptIgnlALxNo1GLCIcwwN8V7KITd0=; b=S1AuOiXNLLFWaRuQV+1awNYmpuIazENiUu/yUzu7nOcYdX6RHCakIwnAi1BslrBrd7 /P0//qE3FVo17KX7ldplYaQ94Kktn4QzuCXL/JsK4WOc8qRHHFtrfg+kNvuKh17OxMdn teE1CVSfTFwDExAx7abAXvghvs3mKV5WdrMZz083KJLzqmnNgND7g44p7i9qgsDd+jG3 gpsdnPJSMUWGxn/Yjlfpf7pDGMWWhgCIRjJE//xca8Muwregsq1Q7b0nMznf65qmBW+F CjPDZy6AhdTZmXcum8Fkq8IVrJO0757ilXhY1djz86mKtcuUCtmhFW49M23qtBOE/1uc bE1A== MIME-Version: 1.0 X-Received: by 10.182.65.164 with SMTP id y4mr18505401obs.65.1444088929168; Mon, 05 Oct 2015 16:48:49 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.202.71.6 with HTTP; Mon, 5 Oct 2015 16:48:49 -0700 (PDT) In-Reply-To: <62905755-63CE-430E-A6AA-D3FCE3EF347A@digitaldaemon.com> References: <16694582476300143275@scdbackup.webframe.org> <62905755-63CE-430E-A6AA-D3FCE3EF347A@digitaldaemon.com> Date: Mon, 5 Oct 2015 17:48:49 -0600 X-Google-Sender-Auth: vjxwytO7FIcB8cg4OAJIBnfnX9c Message-ID: Subject: Re: Which program produces FreeBSD-11.0-CURRENT-amd64-*-disc1.iso ? From: Alan Somers To: Jan Knepper Cc: Alan Somers , Thomas Schmitt , "freebsd-hackers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2015 23:48:50 -0000 Well, yes you are correct. I should've said, "of the languages in use by FreeBSD, Coverity can only check C and C++". The Ports tree is mostly makefiles. -Alan On Mon, Oct 5, 2015 at 4:57 PM, Jan Knepper wrote: > Actually... Coverity also can check Java, C#, JavaScript and Objective-C. > > The group I work for at the FAA uses it for C/C++ > > Jan > > > > ManiaC++ > Jan Knepper > >> On Oct 5, 2015, at 17:04, Alan Somers wrote: >> >>> On Mon, Oct 5, 2015 at 1:02 PM, Thomas Schmitt wrote: >>> Hi, >>> >>>> the FreeBSD project has had a free Coverity account for a >>>> few years now. >>> >>> Does it also get applied to ports ? >>> Especially i would be interested in my own upstream stuff: >>> http://portsmon.freebsd.org/portoverview.py?category=devel&portname=libburn >>> http://portsmon.freebsd.org/portoverview.py?category=devel&portname=libisofs >>> http://portsmon.freebsd.org/portoverview.py?category=sysutils&portname=xorriso >>> >>> Meanwhile i filed >>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203531 >>> >>> Problem #1 would be a candidate for Coverity. >>> "Uninitialized malloc memory in timestamp of root directory." >>> >>> The other three problems are decisions at the discretion of >>> the programmer. We will have to wait a few more years before >>> automats can tell us that we got the specs wrong or try to >>> save a few bytes where it is not worth the hassle. >>> >>> >>>> Would it be possible to get Thomas an account? >>> >>> A list of my own errors would not really be welcome but in >>> any case appreciated. :)) >>> >>> A Coverity run over makefs would make sense if my proposals >>> get implemented in some way. I hope they are safe, but one >>> never knows. >>> >>> >>> Have a nice day :) >>> >>> Thomas >> >> Nope. Coverity only runs on CURRENT. It only knows how to check C and >> C++ code, so it wouldn't be very useful in ports, anyway. Thanks a >> lot for the bug report! >> >> -Alan >> _______________________________________________ >> freebsd-hackers@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-hackers >> To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" From owner-freebsd-hackers@freebsd.org Tue Oct 6 00:18:04 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3A5659B18BE for ; Tue, 6 Oct 2015 00:18:04 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 1F32D876 for ; Tue, 6 Oct 2015 00:18:04 +0000 (UTC) (envelope-from rpaulo@me.com) Received: by mailman.ysv.freebsd.org (Postfix) id 1C4FB9B18BD; Tue, 6 Oct 2015 00:18:04 +0000 (UTC) Delivered-To: hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1BEA09B18BC for ; Tue, 6 Oct 2015 00:18:04 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from mr11p00im-asmtp002.me.com (mr11p00im-asmtp002.me.com [17.110.69.253]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EA5F6875 for ; Tue, 6 Oct 2015 00:18:03 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from akita.hsd1.ca.comcast.net (c-73-162-13-215.hsd1.ca.comcast.net [73.162.13.215]) by mr11p00im-asmtp002.me.com (Oracle Communications Messaging Server 7.0.5.35.0 64bit (built Mar 31 2015)) with ESMTPSA id <0NVR00DOLSPVPC00@mr11p00im-asmtp002.me.com> for hackers@freebsd.org; Mon, 05 Oct 2015 23:17:57 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-10-05_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 kscore.is_bulkscore=1.66533453693773e-16 compositescore=0.981618935876834 phishscore=0 kscore.is_spamscore=0 rbsscore=0.981618935876834 recipient_to_sender_totalscore=0 spamscore=0 urlsuspectscore=0.981618935876834 adultscore=1 kscore.compositescore=0 circleOfTrustscore=0 suspectscore=1 recipient_domain_to_sender_totalscore=0 bulkscore=0 recipient_domain_to_sender_domain_totalscore=0 recipient_to_sender_domain_totalscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1412110000 definitions=main-1510050299 Message-id: <1444087075.6210.17.camel@me.com> Subject: boostrap target From: Rui Paulo To: hackers@freebsd.org Date: Mon, 05 Oct 2015 16:17:55 -0700 Content-type: text/plain; charset=UTF-8 X-Mailer: Evolution 3.16.5-1 MIME-version: 1.0 Content-transfer-encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 00:18:04 -0000 Ian and I were trying to figure out how the boostrap target gets called in usr.bin/lex/Makefile. It seems to be part of afterdepend, but I couldn't figure out how it gets added. Any ideas? -- Rui Paulo From owner-freebsd-hackers@freebsd.org Tue Oct 6 00:40:39 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 65C7A9B6149 for ; Tue, 6 Oct 2015 00:40:39 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 460C26C7 for ; Tue, 6 Oct 2015 00:40:39 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 454739B6148; Tue, 6 Oct 2015 00:40:39 +0000 (UTC) Delivered-To: hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2B0779B6147 for ; Tue, 6 Oct 2015 00:40:39 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x22d.google.com (mail-pa0-x22d.google.com [IPv6:2607:f8b0:400e:c03::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F30E86C6 for ; Tue, 6 Oct 2015 00:40:38 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by padhy16 with SMTP id hy16so51446042pad.1 for ; Mon, 05 Oct 2015 17:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=lPB6t7zZAwRQyQDRbJqsYHsL7lB7wLp0UnRI0fYoaNI=; b=TW67Ka2JKNbXoEyeAOnkx7+WDu8FnHZGfX9zBCVCRkdjxqvNZeWUisETWAeYvHcwK0 AfcKACW9XiRyQeTeBb9CJQ6RJpODH4TtMD4iNPQj9e59T1NfA7PPzyLknQAunIVjaL0g 272KHi5G9PnHB6AxLVQ+7B2idcFOT/HR0eHoLb2aDfR6xBV9PbJAoNT7h7BoAaGku8PC /zBBXGtEaTBSmNrYRx9xfc41EXO9LMLMBu2zZtcLjDBjM3InOCOt8wjgrtxv4SoRvjkr zjBJMhTIrlq4QCxzHp6eeKX0mspN+XIin0RNewUgF1B91Shebf28syNvmfYSasCWMiKl Hcfw== X-Received: by 10.66.236.129 with SMTP id uu1mr43267972pac.34.1444092038520; Mon, 05 Oct 2015 17:40:38 -0700 (PDT) Received: from ?IPv6:2601:601:800:126d:610a:70fc:5f44:1c7f? ([2601:601:800:126d:610a:70fc:5f44:1c7f]) by smtp.gmail.com with ESMTPSA id rk2sm29782301pbc.75.2015.10.05.17.40.37 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 05 Oct 2015 17:40:37 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: boostrap target From: NGie Cooper In-Reply-To: <1444087075.6210.17.camel@me.com> Date: Mon, 5 Oct 2015 17:40:36 -0700 Cc: hackers@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <33379C03-977C-47B5-93AB-447715A9C215@gmail.com> References: <1444087075.6210.17.camel@me.com> To: Rui Paulo X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 00:40:39 -0000 > On Oct 5, 2015, at 16:17, Rui Paulo wrote: >=20 > Ian and I were trying to figure out how the boostrap target gets = called > in usr.bin/lex/Makefile. It seems to be part of afterdepend, but I > couldn't figure out how it gets added. Any ideas? Looking at ^/head/Makefile@r35703, `make bootstrap` for = usr.bin/lex/Makefile@r35703 was broken when bootstrap-tools, etc, was = written. Here=E2=80=99s the revision where it was brought in: ------------------------------------------------------------------------ r16519 | nate | 1996-06-19 13:48:06 -0700 (Wed, 19 Jun 1996) | 6 lines Finish the import and merge in FreeBSD specific changes. Add a 'bootstrap' target which *must* be run before building the new version, since the new scanner relies on the current version of flex to build itself otherwise. Here=E2=80=99s what ^/head/Makefile@r35703 used to look like: 33133 adam .if !defined(NOTOOLS) 17308 peter @echo 17308 peter @echo = "--------------------------------------------------------------" 27910 asami @echo " Rebuilding bootstrap tools" 17308 peter @echo = "--------------------------------------------------------------" 27910 asami cd ${.CURDIR} && ${BMAKE} bootstrap ... 17308 peter bootstrap: 27910 asami .if defined(DESTDIR) 27910 asami rm -f ${DESTDIR}/usr/src/sys 27910 asami ln -s ${.CURDIR}/sys ${DESTDIR}/usr/src 27910 asami cd ${.CURDIR}/include && find -dx . | cpio -dump = ${DESTDIR}/usr/include 34575 bde cd ${.CURDIR}/include && ${MAKE} symlinks 27910 asami .endif 35479 bde cd ${.CURDIR}/usr.bin/make && ${MAKE} = ${MK_FLAGS} ${_DEPEND} && \ 30113 jkh ${MAKE} ${MK_FLAGS} all && \ 30113 jkh ${MAKE} ${MK_FLAGS} -B install = ${CLEANDIR} ${OBJDIR} 35479 bde cd ${.CURDIR}/usr.bin/xinstall && ${MAKE} = ${MK_FLAGS} ${_DEPEND} && \ 30113 jkh ${MAKE} ${MK_FLAGS} all && \ 30113 jkh ${MAKE} ${MK_FLAGS} -B install = ${CLEANDIR} ${OBJDIR} 34509 bde cd ${.CURDIR}/usr.bin/lex && ${MAKE} bootstrap = && \ 35479 bde ${MAKE} ${MK_FLAGS} ${_DEPEND} && \ 30170 jkh ${MAKE} ${MK_FLAGS} -DNOLIB all && \ 30113 jkh ${MAKE} ${MK_FLAGS} -DNOLIB -B install = ${CLEANDIR}= From owner-freebsd-hackers@freebsd.org Tue Oct 6 01:02:30 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 627129B93F8 for ; Tue, 6 Oct 2015 01:02:30 +0000 (UTC) (envelope-from jan@digitaldaemon.com) Received: from digitaldaemon.com (digitaldaemon.com [162.217.114.50]) by mx1.freebsd.org (Postfix) with SMTP id 00FA514C8 for ; Tue, 6 Oct 2015 01:02:29 +0000 (UTC) (envelope-from jan@digitaldaemon.com) Received: (qmail 67340 invoked by uid 89); 6 Oct 2015 01:02:26 -0000 Received: from c-73-198-164-157.hsd1.nj.comcast.net (HELO ?192.168.0.6?) (jan@digitaldaemon.com@73.198.164.157) by digitaldaemon.com with SMTP; 6 Oct 2015 01:02:26 -0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: Which program produces FreeBSD-11.0-CURRENT-amd64-*-disc1.iso ? From: Jan Knepper X-Mailer: iPhone Mail (12H143) In-Reply-To: Date: Mon, 5 Oct 2015 21:02:25 -0400 Cc: Thomas Schmitt , "freebsd-hackers@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <73D2694F-BB8D-4369-8846-3A1056ABD9F9@digitaldaemon.com> References: <16694582476300143275@scdbackup.webframe.org> <62905755-63CE-430E-A6AA-D3FCE3EF347A@digitaldaemon.com> To: Alan Somers X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 01:02:30 -0000 Well, that would be the bare ports tree. I am presuming that the question was about the ports code that is downloaded= and build. There is a lot of C and C++ code among that. It would be great to run Coveri= ty on that as well. However, I personally think that is more the responsibil= ity of the specific port development team... Jan ManiaC++ Jan Knepper > On Oct 5, 2015, at 19:48, Alan Somers wrote: >=20 > Well, yes you are correct. I should've said, "of the languages in use > by FreeBSD, Coverity can only check C and C++". The Ports tree is > mostly makefiles. >=20 > -Alan >=20 >> On Mon, Oct 5, 2015 at 4:57 PM, Jan Knepper wrote= : >> Actually... Coverity also can check Java, C#, JavaScript and Objective-C.= >>=20 >> The group I work for at the FAA uses it for C/C++ >>=20 >> Jan >>=20 >>=20 >>=20 >> ManiaC++ >> Jan Knepper >>=20 >>>> On Oct 5, 2015, at 17:04, Alan Somers wrote: >>>>=20 >>>> On Mon, Oct 5, 2015 at 1:02 PM, Thomas Schmitt wrot= e: >>>> Hi, >>>>=20 >>>>> the FreeBSD project has had a free Coverity account for a >>>>> few years now. >>>>=20 >>>> Does it also get applied to ports ? >>>> Especially i would be interested in my own upstream stuff: >>>> http://portsmon.freebsd.org/portoverview.py?category=3Ddevel&portname=3D= libburn >>>> http://portsmon.freebsd.org/portoverview.py?category=3Ddevel&portname=3D= libisofs >>>> http://portsmon.freebsd.org/portoverview.py?category=3Dsysutils&portnam= e=3Dxorriso >>>>=20 >>>> Meanwhile i filed >>>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D203531 >>>>=20 >>>> Problem #1 would be a candidate for Coverity. >>>> "Uninitialized malloc memory in timestamp of root directory." >>>>=20 >>>> The other three problems are decisions at the discretion of >>>> the programmer. We will have to wait a few more years before >>>> automats can tell us that we got the specs wrong or try to >>>> save a few bytes where it is not worth the hassle. >>>>=20 >>>>=20 >>>>> Would it be possible to get Thomas an account? >>>>=20 >>>> A list of my own errors would not really be welcome but in >>>> any case appreciated. :)) >>>>=20 >>>> A Coverity run over makefs would make sense if my proposals >>>> get implemented in some way. I hope they are safe, but one >>>> never knows. >>>>=20 >>>>=20 >>>> Have a nice day :) >>>>=20 >>>> Thomas >>>=20 >>> Nope. Coverity only runs on CURRENT. It only knows how to check C and >>> C++ code, so it wouldn't be very useful in ports, anyway. Thanks a >>> lot for the bug report! >>>=20 >>> -Alan >>> _______________________________________________ >>> freebsd-hackers@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/freebsd-hackers >>> To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.or= g" From owner-freebsd-hackers@freebsd.org Tue Oct 6 01:08:35 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C71B59B984D for ; Tue, 6 Oct 2015 01:08:35 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A9D3B190E for ; Tue, 6 Oct 2015 01:08:35 +0000 (UTC) (envelope-from rpaulo@me.com) Received: by mailman.ysv.freebsd.org (Postfix) id A742A9B984C; Tue, 6 Oct 2015 01:08:35 +0000 (UTC) Delivered-To: hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A5F009B984A for ; Tue, 6 Oct 2015 01:08:35 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from mr11p00im-asmtp001.me.com (mr11p00im-asmtp001.me.com [17.110.69.252]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 81B0E190D for ; Tue, 6 Oct 2015 01:08:35 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from akita (c-73-162-13-215.hsd1.ca.comcast.net [73.162.13.215]) by mr11p00im-asmtp001.me.com (Oracle Communications Messaging Server 7.0.5.35.0 64bit (built Mar 31 2015)) with ESMTPSA id <0NVR006XCXU27F10@mr11p00im-asmtp001.me.com> for hackers@freebsd.org; Tue, 06 Oct 2015 01:08:28 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-10-06_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 kscore.is_bulkscore=0 compositescore=0.981618935876834 phishscore=0 kscore.is_spamscore=0 rbsscore=0.981618935876834 recipient_to_sender_totalscore=0 spamscore=0 urlsuspectscore=0.981618935876834 adultscore=0 kscore.compositescore=0 circleOfTrustscore=0 suspectscore=0 recipient_domain_to_sender_totalscore=0 bulkscore=0 recipient_domain_to_sender_domain_totalscore=0 recipient_to_sender_domain_totalscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1412110000 definitions=main-1510060015 Message-id: <1444093706.6210.26.camel@me.com> Subject: Re: boostrap target From: Rui Paulo To: NGie Cooper Cc: hackers@freebsd.org Date: Mon, 05 Oct 2015 18:08:26 -0700 In-reply-to: <33379C03-977C-47B5-93AB-447715A9C215@gmail.com> References: <1444087075.6210.17.camel@me.com> <33379C03-977C-47B5-93AB-447715A9C215@gmail.com> Content-type: text/plain; charset=UTF-8 X-Mailer: Evolution 3.16.5-1 MIME-version: 1.0 Content-transfer-encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 01:08:35 -0000 On Mon, 2015-10-05 at 17:40 -0700, NGie Cooper wrote: > > On Oct 5, 2015, at 16:17, Rui Paulo wrote: > > > > Ian and I were trying to figure out how the boostrap target gets > > called > > in usr.bin/lex/Makefile. It seems to be part of afterdepend, but I > > couldn't figure out how it gets added. Any ideas? > > Looking at ^/head/Makefile@r35703, `make bootstrap` for > usr.bin/lex/Makefile@r35703 was broken when bootstrap-tools, etc, was > written. That doesn't answer my question because I still don't know how it gets added to afterdepend. -- Rui Paulo From owner-freebsd-hackers@freebsd.org Tue Oct 6 01:13:38 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 337EE9B9CE5 for ; Tue, 6 Oct 2015 01:13:38 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 188BD1CAD for ; Tue, 6 Oct 2015 01:13:38 +0000 (UTC) (envelope-from ian@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 15DEE9B9CE3; Tue, 6 Oct 2015 01:13:38 +0000 (UTC) Delivered-To: hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EFBB19B9CE2 for ; Tue, 6 Oct 2015 01:13:37 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C52F51CAC for ; Tue, 6 Oct 2015 01:13:37 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from ilsoft.org (unknown [73.34.117.227]) by outbound2.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Tue, 6 Oct 2015 01:14:21 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t961DTtJ028244; Mon, 5 Oct 2015 19:13:29 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1444094009.66572.105.camel@freebsd.org> Subject: Re: boostrap target From: Ian Lepore To: NGie Cooper Cc: Rui Paulo , hackers@freebsd.org Date: Mon, 05 Oct 2015 19:13:29 -0600 In-Reply-To: <33379C03-977C-47B5-93AB-447715A9C215@gmail.com> References: <1444087075.6210.17.camel@me.com> <33379C03-977C-47B5-93AB-447715A9C215@gmail.com> Content-Type: text/plain; charset="iso-8859-13" X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 01:13:38 -0000 On Mon, 2015-10-05 at 17:40 -0700, NGie Cooper wrote: > > On Oct 5, 2015, at 16:17, Rui Paulo wrote: > > > > Ian and I were trying to figure out how the boostrap target gets called > > in usr.bin/lex/Makefile. It seems to be part of afterdepend, but I > > couldn't figure out how it gets added. Any ideas? > > Looking at ^/head/Makefile@r35703, `make bootstrap` for usr.bin/lex/Makefile@r35703 was broken when bootstrap-tools, etc, was written. > > Here˙s the revision where it was brought in: > > ------------------------------------------------------------------------ > r16519 | nate | 1996-06-19 13:48:06 -0700 (Wed, 19 Jun 1996) | 6 lines > > Finish the import and merge in FreeBSD specific changes. > > Add a 'bootstrap' target which *must* be run before building the new > version, since the new scanner relies on the current version of flex to > build itself otherwise. > > Here˙s what ^/head/Makefile@r35703 used to look like: > > 33133 adam .if !defined(NOTOOLS) > 17308 peter @echo > 17308 peter @echo "--------------------------------------------------------------" > 27910 asami @echo " Rebuilding bootstrap tools" > 17308 peter @echo "--------------------------------------------------------------" > 27910 asami cd ${.CURDIR} && ${BMAKE} bootstrap > ... > 17308 peter bootstrap: > 27910 asami .if defined(DESTDIR) > 27910 asami rm -f ${DESTDIR}/usr/src/sys > 27910 asami ln -s ${.CURDIR}/sys ${DESTDIR}/usr/src > 27910 asami cd ${.CURDIR}/include && find -dx . | cpio -dump ${DESTDIR}/usr/include > 34575 bde cd ${.CURDIR}/include && ${MAKE} symlinks > 27910 asami .endif > 35479 bde cd ${.CURDIR}/usr.bin/make && ${MAKE} ${MK_FLAGS} ${_DEPEND} && \ > 30113 jkh ${MAKE} ${MK_FLAGS} all && \ > 30113 jkh ${MAKE} ${MK_FLAGS} -B install ${CLEANDIR} ${OBJDIR} > 35479 bde cd ${.CURDIR}/usr.bin/xinstall && ${MAKE} ${MK_FLAGS} ${_DEPEND} && \ > 30113 jkh ${MAKE} ${MK_FLAGS} all && \ > 30113 jkh ${MAKE} ${MK_FLAGS} -B install ${CLEANDIR} ${OBJDIR} > 34509 bde cd ${.CURDIR}/usr.bin/lex && ${MAKE} bootstrap && \ > 35479 bde ${MAKE} ${MK_FLAGS} ${_DEPEND} && \ > 30170 jkh ${MAKE} ${MK_FLAGS} -DNOLIB all && \ > 30113 jkh ${MAKE} ${MK_FLAGS} -DNOLIB -B install ${CLEANDIR} I don't see how changes from 1999 (which is when "${BMAKE} bootstrap" disappeared from Makefile.inc1) have anything to do with the fact that the most recent import of flex (in 2013) added a bootstrap target that wasn't there previously, and that nothing nowadays invokes it. I'm also not really clear on why the latest import added a bootstrap target that never runs and doesn't seem to be needed (now that I've added a dependency so that the new m4 is built before the new lex). -- Ian From owner-freebsd-hackers@freebsd.org Tue Oct 6 01:19:48 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CF2299BAF43 for ; Tue, 6 Oct 2015 01:19:48 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id B7C8C1EB3 for ; Tue, 6 Oct 2015 01:19:48 +0000 (UTC) (envelope-from ian@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id B74D59BAF3F; Tue, 6 Oct 2015 01:19:48 +0000 (UTC) Delivered-To: hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B6EA79BAF3D for ; Tue, 6 Oct 2015 01:19:48 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from erouter6.ore.mailhop.org (erouter6.ore.mailhop.org [54.187.213.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 97A801EB2 for ; Tue, 6 Oct 2015 01:19:48 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from ilsoft.org (unknown [73.34.117.227]) by outbound3.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Tue, 6 Oct 2015 01:18:00 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t961JeNs028252; Mon, 5 Oct 2015 19:19:40 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1444094380.66572.109.camel@freebsd.org> Subject: Re: boostrap target From: Ian Lepore To: Rui Paulo Cc: NGie Cooper , hackers@freebsd.org Date: Mon, 05 Oct 2015 19:19:40 -0600 In-Reply-To: <1444093706.6210.26.camel@me.com> References: <1444087075.6210.17.camel@me.com> <33379C03-977C-47B5-93AB-447715A9C215@gmail.com> <1444093706.6210.26.camel@me.com> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 01:19:48 -0000 On Mon, 2015-10-05 at 18:08 -0700, Rui Paulo wrote: > On Mon, 2015-10-05 at 17:40 -0700, NGie Cooper wrote: > > > On Oct 5, 2015, at 16:17, Rui Paulo wrote: > > > > > > Ian and I were trying to figure out how the boostrap target gets > > > called > > > in usr.bin/lex/Makefile. It seems to be part of afterdepend, but I > > > couldn't figure out how it gets added. Any ideas? > > > > Looking at ^/head/Makefile@r35703, `make bootstrap` for > > usr.bin/lex/Makefile@r35703 was broken when bootstrap-tools, etc, was > > written. > > That doesn't answer my question because I still don't know how it gets > added to afterdepend. > I think what you found that's related to afterdepend has something to do with META_MODE stuff that shouldn't be in play for the problem I was chasing. It appears that the only makefiles in the system that have a bootstrap: target are the latest version of lex (but not the version we had before it), and contrib/binutils and contrib/gcc. In other words, by searching and by experimenting, I've concluded the answer to "What invokes the bootstrap: target in makefiles?" is "Nothing does, since 1999." -- Ian From owner-freebsd-hackers@freebsd.org Tue Oct 6 01:21:50 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 62D0C9B6270 for ; Tue, 6 Oct 2015 01:21:50 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 416682C9 for ; Tue, 6 Oct 2015 01:21:50 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 40DDF9B626D; Tue, 6 Oct 2015 01:21:50 +0000 (UTC) Delivered-To: hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 27D419B626C for ; Tue, 6 Oct 2015 01:21:50 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x234.google.com (mail-pa0-x234.google.com [IPv6:2607:f8b0:400e:c03::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EE4B12C3 for ; Tue, 6 Oct 2015 01:21:49 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by pacfv12 with SMTP id fv12so196496718pac.2 for ; Mon, 05 Oct 2015 18:21:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=+QONNDGVBiPIwEnYaCiJonQN4Aig9L/IM3lijYNgMYQ=; b=LLnZNaq9b9/WCEHDQgDRU8HmmYekXS5oN1oI/yLnlCNnnuq98sz8KUGZmgZnQx4umG UgwHkAeofZBGcv+SJg1/efk4gmTKG7jorVv3353BvMNPyQJX+0aVKpA4iYWDAYrTxIVW FD5oN2P6h0QUwodt1xPRgMqb6O3RY4CsklSFJip2LBKWorIfnxV9Nv3n3G4ctM1q+Xsb L1q7/hnB5TBKGiUfll15VHm8qfc6nLzLOG35ilDCOoF3KGxFcWMbrqLm9nGO6O2krean uVstY4oj1UnXvE1drCVGBYmk5RXmOR1JQKespSi2d/vd8CoYhncYLwsgQU1HRQFf1wfl snKw== X-Received: by 10.66.255.42 with SMTP id an10mr42891063pad.107.1444094509602; Mon, 05 Oct 2015 18:21:49 -0700 (PDT) Received: from ?IPv6:2601:601:800:126d:610a:70fc:5f44:1c7f? ([2601:601:800:126d:610a:70fc:5f44:1c7f]) by smtp.gmail.com with ESMTPSA id ql5sm30105563pac.46.2015.10.05.18.21.48 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 05 Oct 2015 18:21:48 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: boostrap target From: NGie Cooper In-Reply-To: <1444093706.6210.26.camel@me.com> Date: Mon, 5 Oct 2015 18:21:47 -0700 Cc: hackers@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <4E5E6A74-F722-4F34-8B76-6A9DA653F0C5@gmail.com> References: <1444087075.6210.17.camel@me.com> <33379C03-977C-47B5-93AB-447715A9C215@gmail.com> <1444093706.6210.26.camel@me.com> To: Rui Paulo X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 01:21:50 -0000 > On Oct 5, 2015, at 18:08, Rui Paulo wrote: >=20 > On Mon, 2015-10-05 at 17:40 -0700, NGie Cooper wrote: >>> On Oct 5, 2015, at 16:17, Rui Paulo wrote: >>>=20 >>> Ian and I were trying to figure out how the boostrap target gets >>> called >>> in usr.bin/lex/Makefile. It seems to be part of afterdepend, but I >>> couldn't figure out how it gets added. Any ideas? >>=20 >> Looking at ^/head/Makefile@r35703, `make bootstrap` for=20 >> usr.bin/lex/Makefile@r35703 was broken when bootstrap-tools, etc, was >> written. >=20 > That doesn't answer my question because I still don't know how it gets > added to afterdepend. `make afterdepend` doesn't do anything right now in that directory when = with and without meta mode with my copy of FreeBSD: $ uname -a FreeBSD fbsd11 11.0-CURRENT FreeBSD 11.0-CURRENT #2 = r287529+e3e7b86(isilon-atf): Mon Sep 7 00:12:58 PDT 2015 = ngie@fbsd11:/usr/obj/usr/src/git/sys/GENERIC-NODEBUG amd64 $ grep Bootstrapping ~/bw.log || echo not found not found $ __MAKE_CONF=3D/dev/null SRCCONF=3D/dev/null make obj =3D=3D=3D> lib (obj) /usr/obj/usr/src/svn/usr.bin/lex/lib created for = /usr/src/svn/usr.bin/lex/lib [ngie@fbsd11 /usr/src/svn/usr.bin/lex]$ make depend yacc -d -o parse.c /usr/src/svn/usr.bin/lex/../../contrib/flex/parse.y lex -t -is /usr/src/svn/usr.bin/lex/../../contrib/flex/scan.l > scan.c sed 's/m4_/m4postproc_/g; s/m4preproc_/m4_/g' = /usr/src/svn/usr.bin/lex/../../contrib/flex/flex.skl | m4 = -I/usr/src/svn/usr.bin/lex/../../contrib/flex -P `awk -f = /usr/src/svn/usr.bin/lex/version.awk /usr/src/svn/usr.bin/lex/config.h` = | sed 's/m4postproc_/m4_/g' | sh = /usr/src/svn/usr.bin/lex/../../contrib/flex/mkskel.sh > skel.c rm -f .depend mkdep -f .depend -a -I. -I/usr/src/svn/usr.bin/lex = -I/usr/src/svn/usr.bin/lex/../../contrib/flex -DHAVE_CONFIG_H -std=3Dgnu99= /usr/src/svn/usr.bin/lex/../../contrib/flex/buf.c = /usr/src/svn/usr.bin/lex/../../contrib/flex/ccl.c = /usr/src/svn/usr.bin/lex/../../contrib/flex/dfa.c = /usr/src/svn/usr.bin/lex/../../contrib/flex/ecs.c = /usr/src/svn/usr.bin/lex/../../contrib/flex/filter.c = /usr/src/svn/usr.bin/lex/../../contrib/flex/gen.c = /usr/src/svn/usr.bin/lex/../../contrib/flex/main.c = /usr/src/svn/usr.bin/lex/../../contrib/flex/misc.c = /usr/src/svn/usr.bin/lex/../../contrib/flex/nfa.c = /usr/src/svn/usr.bin/lex/../../contrib/flex/options.c parse.c = /usr/src/svn/usr.bin/lex/../../contrib/flex/regex.c scan.c = /usr/src/svn/usr.bin/lex/../../contrib/flex/scanflags.c = /usr/src/svn/usr.bin/lex/../../contrib/flex/scanopt.c skel.c = /usr/src/svn/usr.bin/lex/../../contrib/flex/sym.c = /usr/src/svn/usr.bin/lex/../../contrib/flex/tables.c = /usr/src/svn/usr.bin/lex/../../contrib/flex/tables_shared.c = /usr/src/svn/usr.bin/lex/../../contrib/flex/tblcmp.c = /usr/src/svn/usr.bin/lex/../../contrib/flex/yylex.c echo lex: /usr/lib/libc.a >> .depend =3D=3D=3D> lib (depend) rm -f .depend mkdep -f .depend -a -std=3Dgnu99 = /usr/src/svn/usr.bin/lex/lib/../../../contrib/flex/libmain.c = /usr/src/svn/usr.bin/lex/lib/../../../contrib/flex/libyywrap.c $ __MAKE_CONF=3D/dev/null SRCCONF=3D/dev/null make afterdepend $= From owner-freebsd-hackers@freebsd.org Tue Oct 6 01:54:27 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 173159B6210 for ; Tue, 6 Oct 2015 01:54:27 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id EE1E46C0 for ; Tue, 6 Oct 2015 01:54:26 +0000 (UTC) (envelope-from rpaulo@me.com) Received: by mailman.ysv.freebsd.org (Postfix) id ED9429B620F; Tue, 6 Oct 2015 01:54:26 +0000 (UTC) Delivered-To: hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ED3159B620E for ; Tue, 6 Oct 2015 01:54:26 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from mr11p00im-asmtp001.me.com (mr11p00im-asmtp001.me.com [17.110.69.252]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CCE436BF; Tue, 6 Oct 2015 01:54:26 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from akita (c-73-162-13-215.hsd1.ca.comcast.net [73.162.13.215]) by mr11p00im-asmtp001.me.com (Oracle Communications Messaging Server 7.0.5.35.0 64bit (built Mar 31 2015)) with ESMTPSA id <0NVR00H43ZYNEC30@mr11p00im-asmtp001.me.com>; Tue, 06 Oct 2015 01:54:26 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-10-06_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 kscore.is_bulkscore=0 compositescore=0.981618935876834 phishscore=0 kscore.is_spamscore=0 rbsscore=0.981618935876834 recipient_to_sender_totalscore=0 spamscore=0 urlsuspectscore=0.981618935876834 adultscore=0 kscore.compositescore=0 circleOfTrustscore=0 suspectscore=0 recipient_domain_to_sender_totalscore=0 bulkscore=0 recipient_domain_to_sender_domain_totalscore=0 recipient_to_sender_domain_totalscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1412110000 definitions=main-1510060029 Message-id: <1444096463.6210.31.camel@me.com> Subject: Re: boostrap target From: Rui Paulo To: Ian Lepore , NGie Cooper Cc: hackers@freebsd.org Date: Mon, 05 Oct 2015 18:54:23 -0700 In-reply-to: <1444094009.66572.105.camel@freebsd.org> References: <1444087075.6210.17.camel@me.com> <33379C03-977C-47B5-93AB-447715A9C215@gmail.com> <1444094009.66572.105.camel@freebsd.org> Content-type: text/plain; charset=UTF-8 X-Mailer: Evolution 3.16.5-1 MIME-version: 1.0 Content-transfer-encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 01:54:27 -0000 On Mon, 2015-10-05 at 19:13 -0600, Ian Lepore wrote: > I don't see how changes from 1999 (which is when "${BMAKE} bootstrap" > disappeared from Makefile.inc1) have anything to do with the fact > that > the most recent import of flex (in 2013) added a bootstrap target > that > wasn't there previously, and that nothing nowadays invokes it. I'm > also > not really clear on why the latest import added a bootstrap target > that > never runs and doesn't seem to be needed (now that I've added a > dependency so that the new m4 is built before the new lex). Does that mean your "beforedepend: boostrap" anchor isn't needed anymore on FreeBSD 8? -- Rui Paulo From owner-freebsd-hackers@freebsd.org Tue Oct 6 02:00:05 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 170FE9B66B8 for ; Tue, 6 Oct 2015 02:00:05 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id F3239968 for ; Tue, 6 Oct 2015 02:00:04 +0000 (UTC) (envelope-from ian@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id F098F9B66B7; Tue, 6 Oct 2015 02:00:04 +0000 (UTC) Delivered-To: hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F03599B66B6 for ; Tue, 6 Oct 2015 02:00:04 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CF652967 for ; Tue, 6 Oct 2015 02:00:04 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from ilsoft.org (unknown [73.34.117.227]) by outbound2.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Tue, 6 Oct 2015 02:00:54 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t96202pf028317; Mon, 5 Oct 2015 20:00:02 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1444096802.66572.115.camel@freebsd.org> Subject: Re: boostrap target From: Ian Lepore To: Rui Paulo Cc: NGie Cooper , hackers@freebsd.org Date: Mon, 05 Oct 2015 20:00:02 -0600 In-Reply-To: <1444096463.6210.31.camel@me.com> References: <1444087075.6210.17.camel@me.com> <33379C03-977C-47B5-93AB-447715A9C215@gmail.com> <1444094009.66572.105.camel@freebsd.org> <1444096463.6210.31.camel@me.com> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 02:00:05 -0000 On Mon, 2015-10-05 at 18:54 -0700, Rui Paulo wrote: > On Mon, 2015-10-05 at 19:13 -0600, Ian Lepore wrote: > > I don't see how changes from 1999 (which is when "${BMAKE} bootstrap" > > disappeared from Makefile.inc1) have anything to do with the fact > > that > > the most recent import of flex (in 2013) added a bootstrap target > > that > > wasn't there previously, and that nothing nowadays invokes it. I'm > > also > > not really clear on why the latest import added a bootstrap target > > that > > never runs and doesn't seem to be needed (now that I've added a > > dependency so that the new m4 is built before the new lex). > > Does that mean your "beforedepend: boostrap" anchor isn't needed > anymore on FreeBSD 8? > I decided the "beforedepend: bootstrap" attempt at a fix was wrong, because it led to always using the precompiled/processed versions of the generated files on every pass (boostrap tools, world, crossbuilding), and I think that wasn't the intention. I discovered (by accident, actually) that there was no need to run the bootstap target at all as long as m4 got built before lex during the bootstrap-tools stage, so that's the fix I applied, and it was sufficient to build current and stable-10 on a stable-8 build host. I suppose at this point the bootstrap target, and all the pre-generated files it copies, could be deleted. Unless they're serving some other purpose I'm not aware of, like maybe some folks have a need to run that target manually. -- Ian From owner-freebsd-hackers@freebsd.org Tue Oct 6 02:53:33 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 12A019C203C for ; Tue, 6 Oct 2015 02:53:33 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id E80885E4 for ; Tue, 6 Oct 2015 02:53:32 +0000 (UTC) (envelope-from rpaulo@me.com) Received: by mailman.ysv.freebsd.org (Postfix) id E59859C2039; Tue, 6 Oct 2015 02:53:32 +0000 (UTC) Delivered-To: hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB5AC9C2036 for ; Tue, 6 Oct 2015 02:53:32 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from mr11p00im-asmtp003.me.com (mr11p00im-asmtp003.me.com [17.110.69.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AA56140E for ; Tue, 6 Oct 2015 02:53:32 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from akita (c-73-162-13-215.hsd1.ca.comcast.net [73.162.13.215]) by mr11p00im-asmtp003.me.com (Oracle Communications Messaging Server 7.0.5.35.0 64bit (built Mar 31 2015)) with ESMTPSA id <0NVR00A23ZWZO200@mr11p00im-asmtp003.me.com> for hackers@freebsd.org; Tue, 06 Oct 2015 01:53:26 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-10-06_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 kscore.is_bulkscore=0 compositescore=0.981618935876834 phishscore=0 kscore.is_spamscore=0 rbsscore=0.981618935876834 recipient_to_sender_totalscore=0 spamscore=0 urlsuspectscore=0.981618935876834 adultscore=0 kscore.compositescore=0 circleOfTrustscore=0 suspectscore=0 recipient_domain_to_sender_totalscore=0 bulkscore=0 recipient_domain_to_sender_domain_totalscore=0 recipient_to_sender_domain_totalscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1412110000 definitions=main-1510060028 Message-id: <1444096403.6210.30.camel@me.com> Subject: Re: boostrap target From: Rui Paulo To: NGie Cooper Cc: hackers@freebsd.org Date: Mon, 05 Oct 2015 18:53:23 -0700 In-reply-to: <4E5E6A74-F722-4F34-8B76-6A9DA653F0C5@gmail.com> References: <1444087075.6210.17.camel@me.com> <33379C03-977C-47B5-93AB-447715A9C215@gmail.com> <1444093706.6210.26.camel@me.com> <4E5E6A74-F722-4F34-8B76-6A9DA653F0C5@gmail.com> Content-type: text/plain; charset=UTF-8 X-Mailer: Evolution 3.16.5-1 MIME-version: 1.0 Content-transfer-encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 02:53:33 -0000 On Mon, 2015-10-05 at 18:21 -0700, NGie Cooper wrote: > > On Oct 5, 2015, at 18:08, Rui Paulo wrote: > > > > On Mon, 2015-10-05 at 17:40 -0700, NGie Cooper wrote: > > > > On Oct 5, 2015, at 16:17, Rui Paulo wrote: > > > > > > > > Ian and I were trying to figure out how the boostrap target > > > > gets > > > > called > > > > in usr.bin/lex/Makefile. It seems to be part of afterdepend, > > > > but I > > > > couldn't figure out how it gets added. Any ideas? > > > > > > Looking at ^/head/Makefile@r35703, `make bootstrap` for > > > usr.bin/lex/Makefile@r35703 was broken when bootstrap-tools, etc, > > > was > > > written. > > > > That doesn't answer my question because I still don't know how it > > gets > > added to afterdepend. > > `make afterdepend` doesn't do anything right now in that directory > when with and without meta mode with my copy of FreeBSD: > > $ uname -a > FreeBSD fbsd11 11.0-CURRENT FreeBSD 11.0-CURRENT #2 > r287529+e3e7b86(isilon-atf): Mon Sep 7 00:12:58 PDT 2015 > ngie@fbsd11:/usr/obj/usr/src/git/sys/GENERIC-NODEBUG amd64 > $ grep Bootstrapping ~/bw.log || echo not found > not found > $ __MAKE_CONF=/dev/null SRCCONF=/dev/null make obj > ===> lib (obj) > /usr/obj/usr/src/svn/usr.bin/lex/lib created for > /usr/src/svn/usr.bin/lex/lib > [ngie@fbsd11 /usr/src/svn/usr.bin/lex]$ make depend > yacc -d -o parse.c > /usr/src/svn/usr.bin/lex/../../contrib/flex/parse.y > lex -t -is /usr/src/svn/usr.bin/lex/../../contrib/flex/scan.l > > scan.c > sed 's/m4_/m4postproc_/g; s/m4preproc_/m4_/g' > /usr/src/svn/usr.bin/lex/../../contrib/flex/flex.skl | m4 > -I/usr/src/svn/usr.bin/lex/../../contrib/flex -P `awk -f > /usr/src/svn/usr.bin/lex/version.awk > /usr/src/svn/usr.bin/lex/config.h` | sed 's/m4postproc_/m4_/g' | sh > /usr/src/svn/usr.bin/lex/../../contrib/flex/mkskel.sh > skel.c > rm -f .depend > mkdep -f .depend -a -I. -I/usr/src/svn/usr.bin/lex > -I/usr/src/svn/usr.bin/lex/../../contrib/flex -DHAVE_CONFIG_H > -std=gnu99 /usr/src/svn/usr.bin/lex/../../contrib/flex/buf.c > /usr/src/svn/usr.bin/lex/../../contrib/flex/ccl.c > /usr/src/svn/usr.bin/lex/../../contrib/flex/dfa.c > /usr/src/svn/usr.bin/lex/../../contrib/flex/ecs.c > /usr/src/svn/usr.bin/lex/../../contrib/flex/filter.c > /usr/src/svn/usr.bin/lex/../../contrib/flex/gen.c > /usr/src/svn/usr.bin/lex/../../contrib/flex/main.c > /usr/src/svn/usr.bin/lex/../../contrib/flex/misc.c > /usr/src/svn/usr.bin/lex/../../contrib/flex/nfa.c > /usr/src/svn/usr.bin/lex/../../contrib/flex/options.c parse.c > /usr/src/svn/usr.bin/lex/../../contrib/flex/regex.c scan.c > /usr/src/svn/usr.bin/lex/../../contrib/flex/scanflags.c > /usr/src/svn/usr.bin/lex/../../contrib/flex/scanopt.c skel.c > /usr/src/svn/usr.bin/lex/../../contrib/flex/sym.c > /usr/src/svn/usr.bin/lex/../../contrib/flex/tables.c > /usr/src/svn/usr.bin/lex/../../contrib/flex/tables_shared.c > /usr/src/svn/ > usr.bin/lex/../../contrib/flex/tblcmp.c > /usr/src/svn/usr.bin/lex/../../contrib/flex/yylex.c > echo lex: /usr/lib/libc.a >> .depend > ===> lib (depend) > rm -f .depend > mkdep -f .depend -a -std=gnu99 > /usr/src/svn/usr.bin/lex/lib/../../../contrib/flex/libmain.c > /usr/src/svn/usr.bin/lex/lib/../../../contrib/flex/libyywrap.c > $ __MAKE_CONF=/dev/null SRCCONF=/dev/null make afterdepend Hmm, ok, I confused the output because boostrap depends on skel.c. It turns out that only the target skel.c is run... -- Rui Paulo From owner-freebsd-hackers@freebsd.org Tue Oct 6 04:59:18 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 355FD9BAF95 for ; Tue, 6 Oct 2015 04:59:18 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 16C6EDD7 for ; Tue, 6 Oct 2015 04:59:18 +0000 (UTC) (envelope-from rpaulo@me.com) Received: by mailman.ysv.freebsd.org (Postfix) id 13F8F9BAF94; Tue, 6 Oct 2015 04:59:18 +0000 (UTC) Delivered-To: hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 138A59BAF92 for ; Tue, 6 Oct 2015 04:59:18 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from mr11p00im-asmtp004.me.com (mr11p00im-asmtp004.me.com [17.110.69.135]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E3D0CDD5; Tue, 6 Oct 2015 04:59:17 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from akita.hsd1.ca.comcast.net (c-73-162-13-215.hsd1.ca.comcast.net [73.162.13.215]) by mr11p00im-asmtp004.me.com (Oracle Communications Messaging Server 7.0.5.35.0 64bit (built Mar 31 2015)) with ESMTPSA id <0NVS00EP68IJOE10@mr11p00im-asmtp004.me.com>; Tue, 06 Oct 2015 04:59:11 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-10-06_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 kscore.is_bulkscore=7.38298311375729e-15 compositescore=0.981618935876834 phishscore=0 kscore.is_spamscore=0 rbsscore=0.981618935876834 recipient_to_sender_totalscore=0 spamscore=0 urlsuspectscore=0.981618935876834 adultscore=0 kscore.compositescore=0 circleOfTrustscore=0 suspectscore=0 recipient_domain_to_sender_totalscore=0 bulkscore=0 recipient_domain_to_sender_domain_totalscore=0 recipient_to_sender_domain_totalscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1412110000 definitions=main-1510060085 Message-id: <1444107547.6210.35.camel@me.com> Subject: Re: boostrap target From: Rui Paulo To: Ian Lepore Cc: hackers@freebsd.org, NGie Cooper Date: Mon, 05 Oct 2015 21:59:07 -0700 In-reply-to: <1444096802.66572.115.camel@freebsd.org> References: <1444087075.6210.17.camel@me.com> <33379C03-977C-47B5-93AB-447715A9C215@gmail.com> <1444094009.66572.105.camel@freebsd.org> <1444096463.6210.31.camel@me.com> <1444096802.66572.115.camel@freebsd.org> Content-type: text/plain; charset=UTF-8 X-Mailer: Evolution 3.16.5-1 MIME-version: 1.0 Content-transfer-encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 04:59:18 -0000 On Mon, 2015-10-05 at 20:00 -0600, Ian Lepore wrote: > I decided the "beforedepend: bootstrap" attempt at a fix was wrong, > because it led to always using the precompiled/processed versions of > the > generated files on every pass (boostrap tools, world, crossbuilding), > and I think that wasn't the intention. I discovered (by accident, > actually) that there was no need to run the bootstap target at all as > long as m4 got built before lex during the bootstrap-tools stage, so > that's the fix I applied, and it was sufficient to build current and > stable-10 on a stable-8 build host. Well, I thought that was what jkim added in 2013. Is your BOOTSTRAPPING variable set correctly? diff --git a/Makefile.inc1 b/Makefile.inc1 index 1e58f47..f0649ef 100644 --- a/Makefile.inc1 +++ b/Makefile.inc1 @@ -1206,6 +1206,10 @@ _sed= usr.bin/sed _lex= usr.bin/lex .endif +.if ${BOOTSTRAPPING} < 1000002 +_m4= usr.bin/m4 +.endif + .if ${BOOTSTRAPPING} < 1000013 _yacc= lib/liby \ usr.bin/yacc @@ -1283,6 +1287,7 @@ bootstrap-tools: usr.bin/rpcgen \ ${_sed} \ ${_yacc} \ + ${_m4} \ ${_lex} \ lib/libmd \ usr.bin/xinstall \ > > I suppose at this point the bootstrap target, and all the pre > -generated > files it copies, could be deleted. Unless they're serving some other > purpose I'm not aware of, like maybe some folks have a need to run > that > target manually. Looking again, all the GENFILES are generated by the bootstrap target based on the rule init$f -> $f. However, as you say it probably should be deleted because there's no difference between init$f and $f. -- Rui Paulo From owner-freebsd-hackers@freebsd.org Tue Oct 6 06:24:33 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09B8299ADD3 for ; Tue, 6 Oct 2015 06:24:33 +0000 (UTC) (envelope-from scdbackup@gmx.net) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B0BEDEC for ; Tue, 6 Oct 2015 06:24:32 +0000 (UTC) (envelope-from scdbackup@gmx.net) Received: from scdbackup.webframe.org ([79.192.94.39]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0M4WNA-1aZ7yU2tjg-00yjMz for ; Tue, 06 Oct 2015 08:24:22 +0200 Date: Tue, 06 Oct 2015 08:25:50 +0200 From: "Thomas Schmitt" To: freebsd-hackers@freebsd.org Subject: Re: Which program produces FreeBSD-11.0-CURRENT-amd64-*-disc1.iso ? Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit References: <73D2694F-BB8D-4369-8846-3A1056ABD9F9@digitaldaemon.com> In-Reply-To: <73D2694F-BB8D-4369-8846-3A1056ABD9F9@digitaldaemon.com> Message-Id: <4020582369874944691@scdbackup.webframe.org> X-Provags-ID: V03:K0:BdY1nN/FXbmY1xLhxLjsSPT2d/wvSSnjYFEOa69XvqLRZpmgpDM H9NT4eVtUXGkLbZZk87Fkw+uBpiA8OitJMnHZx0NCu1P4zhgFM0mGv+PRp6pbXg+urRXxY+ 3olVola5ng0edIwAZ/uMiqD4lvjiSUi3m0UJPUF/TlGc9jfSVCrZmETV55QUOQDXtV+fnyD I2EVihGuhqFC+TwXC/2Kw== X-UI-Out-Filterresults: notjunk:1;V01:K0:eNcCJ9+fF34=:/en7MXmoNgrA4I1HiaP0yF NLhOPOTz6h9XdlhL1QrpOaFWvcF5y3XuE8V+npwvOkSR8yIIY4g5CUiqJCSV+GbMNuwooO+N+ V+zEc8omPI5IToYcZCi+y14PTE0xpIXmDhoBjAGTfVbH37VWGxTsVvRm+15U0ncPBXB0sMlu1 3Dnv+ZiS5EfkfSY02sAFbOMhQlYSBnh1nzOQLxXLK9w8in66/N1yPx/qYfodGlEuERL3T+S3/ YcEHN4TDA9QXqDbK92lOnJffslbdK7uITl99j6CkFEz4j4t9YUOw1/3ZmXmdNhY9rkSdghKDj t4i9XMqXbdzd1xNzBmJoevhTbkrmhLDlKyS52j4jgo165zWWa7lmd+Ad7skR5yo1p9NFf1GLp MBFgE3iz2k/NuO6wQTfqv9KQEebQM21dvJmIcamyr/C3gnB7W4/b5FDPvD1YhfTGTazS65iZI weThVQvj8kIR3Jzc5/Uxx0E3ohNLNhmBsn5jn/617SS1TKHHfBvmFv95gdrSDw0JDvF/ZETb+ cyiyltpGdvC4fz2Hi5+DvnNVmp/0OPUx1w4hUg9OjGqRQKOlb2W4+hNtJgFY4SkQBJ0ShUR3b 0i+BQsqZ42gWempx5pkhpEYbfbLVGr55w9cKzoInttAVIZRAKYsXUhmdw4Rwvn2xSDdmnJCZm HjenvpX0HKQY0yXsutrQdYarqdKkXANqaqmFbxm8ueacK45cErD4ERMHC7DqfcELTtVLPgsRr zSBZyAezu5nuVRIrJAHzfCUWEZTm+RDTAl/pz3gR3+c2VJSxujeNFwp2wTdfT+V3QdXCROv4Z IeSPpEx X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 06:24:33 -0000 Hi, Alan Somers wrote: >>>>> the FreeBSD project has had a free Coverity account for a i wrote: >>>> i would be interested in my own upstream stuff Jan Knepper wrote: > I am presuming that the question was about the ports code that is downloaded > and build. Yes, i hoped for a cheap code review of my libraries and command line tools written in C. > I personally think that is more the responsibility of the specific > port development team... If i could get contact to that team, i would first ask for update from 1.3.4 to 1.4.0 (18 months between them). That might already replace some boring old bugs by interesting new ones. Actually i stumbled over the makefs problems when making regression tests with xorriso. libisofs and the Linux kernel showed strange differences. First i fixed the bugs in libisofs, then i diagnosed the ones in Linux, and then i reported the remaing problems here. (One just has to shake the tree hard enough ...) FreeBSD and NetBSD ISOs are somewhat exotic, viewed from mkisofs traditions. Nevertheless the most strange ISO i got is a firmware repair ISO for hard disks. It contains no files but only a boot image which actually is DOS-on-a-floppy. Have a nice day :) Thomas From owner-freebsd-hackers@freebsd.org Tue Oct 6 14:19:20 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 07D759B6469 for ; Tue, 6 Oct 2015 14:19:20 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id E29B1281 for ; Tue, 6 Oct 2015 14:19:19 +0000 (UTC) (envelope-from ian@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id E1CAC9B6468; Tue, 6 Oct 2015 14:19:19 +0000 (UTC) Delivered-To: hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E08729B6467 for ; Tue, 6 Oct 2015 14:19:19 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BE147280 for ; Tue, 6 Oct 2015 14:19:19 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from ilsoft.org (unknown [73.34.117.227]) by outbound1.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Tue, 6 Oct 2015 14:19:58 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t96EJB82029523; Tue, 6 Oct 2015 08:19:11 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1444141151.66572.124.camel@freebsd.org> Subject: Re: boostrap target From: Ian Lepore To: Rui Paulo Cc: hackers@freebsd.org, NGie Cooper Date: Tue, 06 Oct 2015 08:19:11 -0600 In-Reply-To: <1444107547.6210.35.camel@me.com> References: <1444087075.6210.17.camel@me.com> <33379C03-977C-47B5-93AB-447715A9C215@gmail.com> <1444094009.66572.105.camel@freebsd.org> <1444096463.6210.31.camel@me.com> <1444096802.66572.115.camel@freebsd.org> <1444107547.6210.35.camel@me.com> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 14:19:20 -0000 On Mon, 2015-10-05 at 21:59 -0700, Rui Paulo wrote: > On Mon, 2015-10-05 at 20:00 -0600, Ian Lepore wrote: > > I decided the "beforedepend: bootstrap" attempt at a fix was wrong, > > because it led to always using the precompiled/processed versions of > > the > > generated files on every pass (boostrap tools, world, crossbuilding), > > and I think that wasn't the intention. I discovered (by accident, > > actually) that there was no need to run the bootstap target at all as > > long as m4 got built before lex during the bootstrap-tools stage, so > > that's the fix I applied, and it was sufficient to build current and > > stable-10 on a stable-8 build host. > > Well, I thought that was what jkim added in 2013. Is your > BOOTSTRAPPING variable set correctly? > > diff --git a/Makefile.inc1 b/Makefile.inc1 > index 1e58f47..f0649ef 100644 > --- a/Makefile.inc1 > +++ b/Makefile.inc1 > @@ -1206,6 +1206,10 @@ _sed= usr.bin/sed > _lex= usr.bin/lex > .endif > > +.if ${BOOTSTRAPPING} < 1000002 > +_m4= usr.bin/m4 > +.endif > + > .if ${BOOTSTRAPPING} < 1000013 > _yacc= lib/liby \ > usr.bin/yacc > @@ -1283,6 +1287,7 @@ bootstrap-tools: > usr.bin/rpcgen \ > ${_sed} \ > ${_yacc} \ > + ${_m4} \ > ${_lex} \ > lib/libmd \ > usr.bin/xinstall \ > This was necessary, but not sufficient without the dependency to ensure m4 is built before lex while parallel-building. It may be that it was sufficient in 2013, I can't remember when we added the increased parallelism in the bootstrap-tools stage. -- Ian > > > > I suppose at this point the bootstrap target, and all the pre > > -generated > > files it copies, could be deleted. Unless they're serving some other > > purpose I'm not aware of, like maybe some folks have a need to run > > that > > target manually. > > Looking again, all the GENFILES are generated by the bootstrap target > based on the rule init$f -> $f. > > However, as you say it probably should be deleted because there's no > difference between init$f and $f. > From owner-freebsd-hackers@freebsd.org Tue Oct 6 14:36:16 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 329489D028D for ; Tue, 6 Oct 2015 14:36:16 +0000 (UTC) (envelope-from jan@digitaldaemon.com) Received: from digitaldaemon.com (digitaldaemon.com [162.217.114.50]) by mx1.freebsd.org (Postfix) with SMTP id EEEFE1E6 for ; Tue, 6 Oct 2015 14:36:15 +0000 (UTC) (envelope-from jan@digitaldaemon.com) Received: (qmail 14364 invoked by uid 89); 6 Oct 2015 14:36:10 -0000 Received: from mobile-166-170-033-002.mycingular.net (HELO ?10.133.217.90?) (jan@digitaldaemon.com@166.170.33.2) by digitaldaemon.com with SMTP; 6 Oct 2015 14:36:10 -0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: Which program produces FreeBSD-11.0-CURRENT-amd64-*-disc1.iso ? From: Jan Knepper X-Mailer: iPhone Mail (12H143) In-Reply-To: <4020582369874944691@scdbackup.webframe.org> Date: Tue, 6 Oct 2015 10:36:09 -0400 Cc: "freebsd-hackers@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <5C58BD8B-991D-4CB3-B319-157C20EA2B55@digitaldaemon.com> References: <73D2694F-BB8D-4369-8846-3A1056ABD9F9@digitaldaemon.com> <4020582369874944691@scdbackup.webframe.org> To: Thomas Schmitt X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 14:36:16 -0000 ManiaC++ Jan Knepper > On Oct 6, 2015, at 02:25, Thomas Schmitt wrote: >=20 > Hi, >=20 > Alan Somers wrote: >>>>>> the FreeBSD project has had a free Coverity account for a >=20 > i wrote: >>>>> i would be interested in my own upstream stuff >=20 > Jan Knepper wrote: >> I am presuming that the question was about the ports code that is downloa= ded >> and build. >=20 > Yes, i hoped for a cheap code review of my libraries and > command line tools written in C. Coverity is much better than a cheap code review. I think you can get a demo= for free.=20 Companies can not hire a person to do what Coverity does for the price it co= sts. www.coverity.com >=20 >=20 >> I personally think that is more the responsibility of the specific >> port development team... I would have to check, but if it is open source I think Coverity will scan i= t for free (gov't grant). >=20 > If i could get contact to that team, i would first ask for update > from 1.3.4 to 1.4.0 (18 months between them). That might already > replace some boring old bugs by interesting new ones. >=20 > Actually i stumbled over the makefs problems when making regression > tests with xorriso. libisofs and the Linux kernel showed strange > differences. First i fixed the bugs in libisofs, then i diagnosed > the ones in Linux, and then i reported the remaing problems here. > (One just has to shake the tree hard enough ...) >=20 > FreeBSD and NetBSD ISOs are somewhat exotic, viewed from mkisofs > traditions. Nevertheless the most strange ISO i got is a firmware > repair ISO for hard disks. It contains no files but only a boot > image which actually is DOS-on-a-floppy. >=20 >=20 > Have a nice day :) >=20 > Thomas >=20 > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"= From owner-freebsd-hackers@freebsd.org Tue Oct 6 14:52:45 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0CDC49D0D12 for ; Tue, 6 Oct 2015 14:52:45 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ob0-x234.google.com (mail-ob0-x234.google.com [IPv6:2607:f8b0:4003:c01::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C63D3D5D for ; Tue, 6 Oct 2015 14:52:44 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by obbbh8 with SMTP id bh8so155853259obb.0 for ; Tue, 06 Oct 2015 07:52:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=7XiBwKIHUL1mYjq1JhZVzNYXBqAOGRgNnU2aiCPh7+4=; b=UWZvRiV10DQqhbHCKdLHH1EVZD9GmJ+5a27Vu6+5MnfKmDw45qiZbcrz7SC9e0XKc0 +08lf7NLAbsPevUV3hEgER1h+IZblif93CbzgMi8Z25YrKOWLQ/xeBdPsgzQLsApqxJo yJJ81TRZusF7aLa3jFBnvi64ftS09mM8geT+A04eQEpDW7dUmQufTwmla7Xfj+ZEIdWy +Q7RrdsuJdKlQlNEfph5nnca+QX5GZS9gTFNU336uhZ96BWK87RuFA10F3EnRrczZz6Q TsNTis4WPToDjHp1rUu7RF5c7FbJh74vOhw/kAtgY+hH9nMaX/Pl57axLicXsO2xe1ER cM5A== MIME-Version: 1.0 X-Received: by 10.182.28.100 with SMTP id a4mr21943714obh.38.1444143164048; Tue, 06 Oct 2015 07:52:44 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.202.71.6 with HTTP; Tue, 6 Oct 2015 07:52:43 -0700 (PDT) In-Reply-To: <5C58BD8B-991D-4CB3-B319-157C20EA2B55@digitaldaemon.com> References: <73D2694F-BB8D-4369-8846-3A1056ABD9F9@digitaldaemon.com> <4020582369874944691@scdbackup.webframe.org> <5C58BD8B-991D-4CB3-B319-157C20EA2B55@digitaldaemon.com> Date: Tue, 6 Oct 2015 08:52:43 -0600 X-Google-Sender-Auth: 909qoBabrlQTN4tvc_6mK6MTvmk Message-ID: Subject: Re: Which program produces FreeBSD-11.0-CURRENT-amd64-*-disc1.iso ? From: Alan Somers To: Jan Knepper Cc: Thomas Schmitt , "freebsd-hackers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 14:52:45 -0000 On Tue, Oct 6, 2015 at 8:36 AM, Jan Knepper wrote: > > > ManiaC++ > Jan Knepper > >> On Oct 6, 2015, at 02:25, Thomas Schmitt wrote: >> >> Hi, >> >> Alan Somers wrote: >>>>>>> the FreeBSD project has had a free Coverity account for a >> >> i wrote: >>>>>> i would be interested in my own upstream stuff >> >> Jan Knepper wrote: >>> I am presuming that the question was about the ports code that is downloaded >>> and build. >> >> Yes, i hoped for a cheap code review of my libraries and >> command line tools written in C. > > Coverity is much better than a cheap code review. I think you can get a demo for free. > Companies can not hire a person to do what Coverity does for the price it costs. www.coverity.com > >> >> >>> I personally think that is more the responsibility of the specific >>> port development team... > > I would have to check, but if it is open source I think Coverity will scan it for free (gov't grant). That's right. You can register new projects here: https://scan.coverity.com/projects/new > >> >> If i could get contact to that team, i would first ask for update >> from 1.3.4 to 1.4.0 (18 months between them). That might already >> replace some boring old bugs by interesting new ones. >> >> Actually i stumbled over the makefs problems when making regression >> tests with xorriso. libisofs and the Linux kernel showed strange >> differences. First i fixed the bugs in libisofs, then i diagnosed >> the ones in Linux, and then i reported the remaing problems here. >> (One just has to shake the tree hard enough ...) >> >> FreeBSD and NetBSD ISOs are somewhat exotic, viewed from mkisofs >> traditions. Nevertheless the most strange ISO i got is a firmware >> repair ISO for hard disks. It contains no files but only a boot >> image which actually is DOS-on-a-floppy. >> >> >> Have a nice day :) >> >> Thomas >> >> _______________________________________________ >> freebsd-hackers@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-hackers >> To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" From owner-freebsd-hackers@freebsd.org Tue Oct 6 15:19:50 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 19D639D0180 for ; Tue, 6 Oct 2015 15:19:50 +0000 (UTC) (envelope-from jan@digitaldaemon.com) Received: from digitaldaemon.com (digitaldaemon.com [162.217.114.50]) by mx1.freebsd.org (Postfix) with SMTP id C73F11516 for ; Tue, 6 Oct 2015 15:19:49 +0000 (UTC) (envelope-from jan@digitaldaemon.com) Received: (qmail 16344 invoked by uid 89); 6 Oct 2015 15:19:45 -0000 Received: from mobile-166-170-033-002.mycingular.net (HELO ?10.133.217.90?) (jan@digitaldaemon.com@166.170.33.2) by digitaldaemon.com with SMTP; 6 Oct 2015 15:19:45 -0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: Which program produces FreeBSD-11.0-CURRENT-amd64-*-disc1.iso ? From: Jan Knepper X-Mailer: iPhone Mail (12H143) In-Reply-To: Date: Tue, 6 Oct 2015 11:19:44 -0400 Cc: Thomas Schmitt , "freebsd-hackers@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <98CF5BE8-A0BF-4996-A3F8-855CA1B91A25@digitaldaemon.com> References: <73D2694F-BB8D-4369-8846-3A1056ABD9F9@digitaldaemon.com> <4020582369874944691@scdbackup.webframe.org> <5C58BD8B-991D-4CB3-B319-157C20EA2B55@digitaldaemon.com> To: Alan Somers X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 15:19:50 -0000 Great! ManiaC++ Jan Knepper > On Oct 6, 2015, at 10:52, Alan Somers wrote: >=20 >> On Tue, Oct 6, 2015 at 8:36 AM, Jan Knepper wrote= : >>=20 >>=20 >> ManiaC++ >> Jan Knepper >>=20 >>> On Oct 6, 2015, at 02:25, Thomas Schmitt wrote: >>>=20 >>> Hi, >>>=20 >>> Alan Somers wrote: >>>>>>>> the FreeBSD project has had a free Coverity account for a >>>=20 >>> i wrote: >>>>>>> i would be interested in my own upstream stuff >>>=20 >>> Jan Knepper wrote: >>>> I am presuming that the question was about the ports code that is downl= oaded >>>> and build. >>>=20 >>> Yes, i hoped for a cheap code review of my libraries and >>> command line tools written in C. >>=20 >> Coverity is much better than a cheap code review. I think you can get a d= emo for free. >> Companies can not hire a person to do what Coverity does for the price it= costs. www.coverity.com >>=20 >>>=20 >>>=20 >>>> I personally think that is more the responsibility of the specific >>>> port development team... >>=20 >> I would have to check, but if it is open source I think Coverity will sca= n it for free (gov't grant). >=20 >=20 > That's right. You can register new projects here: > https://scan.coverity.com/projects/new >=20 >=20 >>=20 >>>=20 >>> If i could get contact to that team, i would first ask for update >>> from 1.3.4 to 1.4.0 (18 months between them). That might already >>> replace some boring old bugs by interesting new ones. >>>=20 >>> Actually i stumbled over the makefs problems when making regression >>> tests with xorriso. libisofs and the Linux kernel showed strange >>> differences. First i fixed the bugs in libisofs, then i diagnosed >>> the ones in Linux, and then i reported the remaing problems here. >>> (One just has to shake the tree hard enough ...) >>>=20 >>> FreeBSD and NetBSD ISOs are somewhat exotic, viewed from mkisofs >>> traditions. Nevertheless the most strange ISO i got is a firmware >>> repair ISO for hard disks. It contains no files but only a boot >>> image which actually is DOS-on-a-floppy. >>>=20 >>>=20 >>> Have a nice day :) >>>=20 >>> Thomas >>>=20 >>> _______________________________________________ >>> freebsd-hackers@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/freebsd-hackers >>> To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.or= g" >> _______________________________________________ >> freebsd-hackers@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-hackers >> To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org= " From owner-freebsd-hackers@freebsd.org Tue Oct 6 16:59:20 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0C2FF9D0A93 for ; Tue, 6 Oct 2015 16:59:20 +0000 (UTC) (envelope-from scdbackup@gmx.net) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 91087B81 for ; Tue, 6 Oct 2015 16:59:19 +0000 (UTC) (envelope-from scdbackup@gmx.net) Received: from scdbackup.webframe.org ([91.63.124.210]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0LztD9-1adcdb2q95-0154A0 for ; Tue, 06 Oct 2015 18:59:16 +0200 Date: Tue, 06 Oct 2015 19:00:45 +0200 From: "Thomas Schmitt" To: freebsd-hackers@freebsd.org Subject: Re: Which program produces FreeBSD-11.0-CURRENT-amd64-*-disc1.iso ? Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit References: In-Reply-To: Message-Id: <9083582407425579659@scdbackup.webframe.org> X-Provags-ID: V03:K0:azOGh7tfwKFcWBgBhA4cpb7b8bEpkek6Fv/oQ2J1BWJ/0Odrl3k zDp/Y3vASFt12k+3rAb6IOZCsYRdyKWe+0TG4+vfkqwT/osV96e7jLdgxKBrj9ZbTYP0UgB Fwrhny9q3ZljxTjszd+YBBB+NwzG2YZZ2XW2iLzonsd6d4JC4UBrSFbFTaW4TJz7kLfv+rt duHOc292+lnXkUFD7VvAw== X-UI-Out-Filterresults: notjunk:1;V01:K0:gFdA4InQ3uU=:DFS+tEm8FUB7raaq7uPcuY MJRlD6Sze07LD+LPPDI+MEIxQrkxfSD+W4E7nLUp6LUvksG+xB+TR0lCQz04G0EUKNts25GPO JvwMjoimyohj9dOkY1eEtOIYRIeurWS1rgQBjZzjngs8sN1ARa4tk33Ss9zDhCjz1IbhQ2LxH +vMmeJlkfVM//DsdPRYzr701JPYL7tPXa5qoA7DAvUNjLPOUo7n3aMMf992guVSq22brFXlrd AaesNJm/UG/qiCfSWrTBv6xdUZVWv4AkVwYQ6kp14ugLGn+N+HkuA232iw2mgYijdnlrmTn8C C8z3OaDyIEUUUKJ00DhdYZCHBW/sD2b1ef469VB+G9QfycmvPtHi7UoQOpWIYS3drpVc1Bq6l 5mChXyTMTlRQW74SHFxoRuU9DLWyR2QMP+pJ4m2NNFE84HS3zEwjoRfZFgPsXUTjk/WAEGauU 65Gf0s4UBeWDPfCk+bBl8GdRYk7YXBdnFC4FSfVNvVoXT8lL3HTNtT/ZODWTNoG1kmapFVzCJ FmMhj7+q0oS7uNnHI/oUiTiIMu9f4us9v/ElVanxra9qmfPiukjKGkCZBoRjuhXZIackNo2um 2sCbaBcU6tj0XtaOZ4jsaQqKaDppTg87J9RES4n9aSu9uoNCjGv004Exv0LMEuAwRcFgPHKMZ kgQb1508qTsxrDXxNQSla0CYWWjffmIHLrp/WVdtJTTPv7Hh5/6zj99nfVcBIXW2c+5FVQNvO 4DEw4vv7sHkWabIePdD8HnsEXQEUdR9kagxkmO4ONlNXKavysU2SWDIXbjdDFexsRb4CV+Vow BabeNz/ X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 16:59:20 -0000 Hi, Alan Somers wrote: > https://scan.coverity.com/projects/new I dimly remember to have tried signing up a while ago. Now i recognize the captcha which then refused to work. I got a new computer meanwhile ... seems to work. Let's see what happens if i submit libisofs for a start. I got an account, activated it, and submitted the project https://scan.coverity.com/projects/libisofs But now i shall download and run software. 330 MB compressed. This will need some sandboxing. Tomorrow ... Have a nice day :) Thomas From owner-freebsd-hackers@freebsd.org Wed Oct 7 14:32:30 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9250F9D19A3 for ; Wed, 7 Oct 2015 14:32:30 +0000 (UTC) (envelope-from scdbackup@gmx.net) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2957D283 for ; Wed, 7 Oct 2015 14:32:29 +0000 (UTC) (envelope-from scdbackup@gmx.net) Received: from scdbackup.webframe.org ([91.63.124.210]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0LevUh-1aOurq1jKx-00qewU for ; Wed, 07 Oct 2015 16:32:21 +0200 Date: Wed, 07 Oct 2015 16:33:53 +0200 From: "Thomas Schmitt" To: freebsd-hackers@freebsd.org Subject: Re: Which program produces FreeBSD-11.0-CURRENT-amd64-*-disc1.iso ? Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit References: <9083582407425579659@scdbackup.webframe.org> In-Reply-To: <9083582407425579659@scdbackup.webframe.org> Message-Id: <1932581961325486449@scdbackup.webframe.org> X-Provags-ID: V03:K0:KMAVu9QCS00NKiqhWXsvMM50ygGQkmWIRJutdgWgeQjpV9s5RBG 2Acw6l/o4wJjIkBW0/QY0ktAqX2ZjxPHYoQzwh59h4kp9AG7CexO3LP+Jw+CYB8SNR06bAP WAnLjZAQVKz+yxzrt/nQwOuapM2JQu8JkMO02e2vpaBjK27RVjuOfvXDa9mGyXuUTO5UMtn M7TYMwH59Fq/Do1ZVb/wA== X-UI-Out-Filterresults: notjunk:1;V01:K0:YQpqnOtzVNY=:Fi8AC38BNOxH5C3Jt7pCHR xZ/uQt5Sweh+vTRhUxXJleiKWhvvTOlCJMmzOa6OlcMXZyD6ojbUDs3MJbhxEOSMlYpEK0K68 BMJq/54XvTbuyNj3ozRpwSGuri/RZFngF2U2yCFkmglhd5bbSYZt9H1DxfcJdmrtUdLZwX3zG cvvhzHuSsCiBNljRMixqkueE0Ok44+rzjHcLanqOjKCHVINl3gkSrwRvNq/hG8TUI6Bkcf3ud yTS3Cn5bgCk4SC2RDtUY5KwLdPZgbwSXxrgAUqpznRf2TcOvWeLlEWbTd3PYnIbXxbMHpBIEN WOEyzGLOiHp+friC8aJfs92PX5e+gGoqfs15fcLLxjMaD7k9RPbqPsGoJbUjsJ021qcmZ+HF5 f5+LeHnX0vUq5SeBd+vV0SDMFFbTUdtaMloqdAVNEspGab1AAiCOTaSnWeKHdVXuhdbvw4S5R 91FHwuHaQDeizP2PDco+N/1kaKD0hcIBjJnkAcJalZ0wWC3JjjEwLb7cOrqxtbG03IOQsqGgX wmR2aBZrUPwpMSmiX+4cQGPjCjCxw3Ioj5qB0s3QSyGflFw/zR8UfE6sWpw7OnrIZqblSM3OB ArquZBRNvgJ5rxA46taqcL7aAfkP7hwidVzpKfH6t3WUnR8cf56VDTB2o+asZJSKV7dORyLoo ze1XKWBrwOKe/NFoTZ45DZoX0qzWhcWoIIwdmdffuynrZ6daSlYBoixnioto2bjA3LMrqOVEs MWMFh7FhpxDwGPDt3Ty8XjMTvRaXCfojAHbf5sbgVCriGfUNNjoWkyO+T+JvGQLTdMCWEv7Mz B4EPqAd X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2015 14:32:30 -0000 Hi, a first libisofs cov-build tarball of libisofs is now submitted to Coverity Scan. 71 defects. Now i am curious to see them. (Still hidden because of pending open source verification.) Alan Somers wrote: > Our Coverity checker found 34 potential defects in the > head/usr.sbin/makefs directory. Sadly, I can't find any way to export > that information. Would it be possible to get Thomas an account? I applied for "Observer/User" status in Coverity Scan project "FreeBSD". In my application i pointed to this list, to my PR 203531, and i promised to make more PRs if i deem reported makefs problems to be bugs. Now all depends on how busy the people are who have to decide. Have a nice day :) Thomas From owner-freebsd-hackers@freebsd.org Wed Oct 7 15:31:26 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5B7D29D005E for ; Wed, 7 Oct 2015 15:31:26 +0000 (UTC) (envelope-from jan@digitaldaemon.com) Received: from digitaldaemon.com (digitaldaemon.com [162.217.114.50]) by mx1.freebsd.org (Postfix) with SMTP id E91AB887 for ; Wed, 7 Oct 2015 15:31:25 +0000 (UTC) (envelope-from jan@digitaldaemon.com) Received: (qmail 94207 invoked by uid 89); 7 Oct 2015 15:31:16 -0000 Received: from mobile-166-170-034-019.mycingular.net (HELO ?10.8.33.148?) (jan@digitaldaemon.com@166.170.34.19) by digitaldaemon.com with SMTP; 7 Oct 2015 15:31:16 -0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: Which program produces FreeBSD-11.0-CURRENT-amd64-*-disc1.iso ? From: Jan Knepper X-Mailer: iPhone Mail (12H143) In-Reply-To: <1932581961325486449@scdbackup.webframe.org> Date: Wed, 7 Oct 2015 11:31:14 -0400 Cc: "freebsd-hackers@freebsd.org" Content-Transfer-Encoding: 7bit Message-Id: <5D932450-B70A-41B7-B35B-FAA562C7969A@digitaldaemon.com> References: <9083582407425579659@scdbackup.webframe.org> <1932581961325486449@scdbackup.webframe.org> To: Thomas Schmitt X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2015 15:31:26 -0000 :-) ManiaC++ Jan Knepper > On Oct 7, 2015, at 10:33, Thomas Schmitt wrote: > > Hi, > > a first libisofs cov-build tarball of libisofs is now submitted > to Coverity Scan. 71 defects. Now i am curious to see them. > (Still hidden because of pending open source verification.) > > > Alan Somers wrote: >> Our Coverity checker found 34 potential defects in the >> head/usr.sbin/makefs directory. Sadly, I can't find any way to export >> that information. Would it be possible to get Thomas an account? > > I applied for "Observer/User" status in Coverity Scan > project "FreeBSD". In my application i pointed to this list, > to my PR 203531, and i promised to make more PRs if i deem > reported makefs problems to be bugs. > > Now all depends on how busy the people are who have to decide. > > > Have a nice day :) > > Thomas > > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" From owner-freebsd-hackers@freebsd.org Wed Oct 7 16:23:06 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 669919D1FBA for ; Wed, 7 Oct 2015 16:23:06 +0000 (UTC) (envelope-from scdbackup@gmx.net) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EC2716C2 for ; Wed, 7 Oct 2015 16:23:05 +0000 (UTC) (envelope-from scdbackup@gmx.net) Received: from scdbackup.webframe.org ([91.63.124.210]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MS5xC-1aCyvA1i7G-00TDsI for ; Wed, 07 Oct 2015 18:22:58 +0200 Date: Wed, 07 Oct 2015 18:24:30 +0200 From: "Thomas Schmitt" To: freebsd-hackers@freebsd.org Subject: Re: Which program produces FreeBSD-11.0-CURRENT-amd64-*-disc1.iso ? Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit References: <5D932450-B70A-41B7-B35B-FAA562C7969A@digitaldaemon.com> In-Reply-To: <5D932450-B70A-41B7-B35B-FAA562C7969A@digitaldaemon.com> Message-Id: <9458198733024153@scdbackup.webframe.org> X-Provags-ID: V03:K0:sG9cpWzBC3XLGXpQ/p3Vva9nLXbWhNFmHDX6HHu2AkhI2xi4rR7 dYWPPrbgEFx46eRkyw8TFHa6avDnZUJ2oP3Ti3ftc+j/M+OZPo6VJ2znK7afjcmmtXNWP0s v6GhxIY1hjNpu+uyTze0K4Ct4Uw4nshROIEuePwcs0/kCcwZZ9bTi4h+HYK5fih2hmjnm6y EwPnVqouVowYcC+HhVIOA== X-UI-Out-Filterresults: notjunk:1;V01:K0:GIt9KB7yC2w=:rDUOFYeO+QcJ4kDm/9LFOh Cy5aXvLv8NA12mODmwuK/GwF/ZdbnPiWa+DGo001tcsxf56KUvi6/faftt5l8wbVmPIG8QVsd aVQcwu9xwFm0sf+fH1hhUZWDtAoyxUF81KHjGAJvFr1P1B+WIeETpq/w7yNN+sKa18eapoiLJ zBQB0lFe2ITM7xC9M5XVbh6TpDOSjjAqVBTryL+5xI6s6T6z/9J75+MUWIVytj46KzDgUp9SG nwWJ2pPquU/OB17JnHMoEK07KMJDG58J5Wix+ZXaWnDNSfnAZ8v9Ezk+O0kbZRf/V0A3yHXl/ 6+JOT1LKh1LEOh5JKQovUDz/e1lGiWCQhkj8ikL4hlgGtJrYOna2ShCa/hse7tlXjbNGYt7rj UGIJ/Ld+N+MxEh39urapV5OWB2bKjz77oM6X29/SN1Fdy5C/wlS22YqzPpWyuLiHI7UsLkJsT 2GPbe17cejClUgMyUyTqnoNozP70TqG1y0MAhKDWhgfrLlqW7TBsmpHMBdJX/u2kBFs38bavY fm9H7/Ylfvo/dAYyfWSJFUxL86q5xfLLE59XjHM5+/qsCtHi77GJHHw/6gonruue2vc+13klr 02h+Y7CYbEp//J6OwvdhAEAOlMCfdC3RpbGtm11TyVp/zjnAPPLtBeVdpudl7kefgCOkUbtoT lWiWd+P9pwmHJRhoCTjiAdknIiuHNwDniGIQrF8sVf/Wg3UnLsjvcsmrmN/pr0Sx2UObgZO9i ho9pgI96CiP05BVxZV1mBv8/LzPcR18tKQZS2n4sWTH71VXpwGI/5JMhcCJsICZ7rqN6KNg18 d9TnTR/ X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2015 16:23:06 -0000 Hi, thanks for letting me into the FreeBSD Coverity project. I had the quick intro tour through the interface (and once again hate it when the Internet tries to look like a GUI program). But how do i narrow the list to usr.sbin/makefs ? I tried Settings->Filters->File with "usr.sbin/makefs", "iso9660_rrip.c", and "/usr.sbin/makefs/cd9660/iso9660_rrip.c". The only effect was that the list of issues became empty. Have a nice day :) Thomas From owner-freebsd-hackers@freebsd.org Wed Oct 7 16:31:34 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E39DB9D04E8 for ; Wed, 7 Oct 2015 16:31:34 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi0-x235.google.com (mail-oi0-x235.google.com [IPv6:2607:f8b0:4003:c06::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AC70FA58 for ; Wed, 7 Oct 2015 16:31:34 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by oibi136 with SMTP id i136so12311648oib.3 for ; Wed, 07 Oct 2015 09:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=lt9fKLl4HTDZzwYNNBd/yt4HLW7wXmuZbSJXgg/5rq4=; b=xMAjgiQsbr1fXW5NzI8DUDjNZWlbaTy1e/RRrC3j6AqdBECohHhhSPoQJjKyXoXH7E 0b2nSl0fGPFuknO9nKhPbcvQ7136TR96r0sQLYuaQ+2Cb4G2o2FoctYhhKd+kLQZUuJ4 lRJlZuBatI5KishYdC7xQKZJ3x8Q+NPM9e+GdFARPHyDTIvFLR4oRUQYrX2b5NhBzz6a rdxnvhbxaeannhfQlZ+VZLc8EjntTaoKzt108WfGT/1V4tinSmOrGMxP0nbmpayyRJBs biC8eBmlubT2mQ8IjXXaYmZKePqDGmxLh2rLNjxgnOdNs6ah5Y5rL4y+VZglGF3bwdlb XKAw== MIME-Version: 1.0 X-Received: by 10.202.228.210 with SMTP id b201mr1281959oih.100.1444235494005; Wed, 07 Oct 2015 09:31:34 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.202.71.6 with HTTP; Wed, 7 Oct 2015 09:31:33 -0700 (PDT) In-Reply-To: <9458198733024153@scdbackup.webframe.org> References: <5D932450-B70A-41B7-B35B-FAA562C7969A@digitaldaemon.com> <9458198733024153@scdbackup.webframe.org> Date: Wed, 7 Oct 2015 10:31:33 -0600 X-Google-Sender-Auth: 22j8keYpzZFB2QiPfUN_lw-jHmE Message-ID: Subject: Re: Which program produces FreeBSD-11.0-CURRENT-amd64-*-disc1.iso ? From: Alan Somers To: Thomas Schmitt Cc: "freebsd-hackers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2015 16:31:35 -0000 On Wed, Oct 7, 2015 at 10:24 AM, Thomas Schmitt wrote: > Hi, > > thanks for letting me into the FreeBSD Coverity project. > > I had the quick intro tour through the interface (and once again > hate it when the Internet tries to look like a GUI program). > > But how do i narrow the list to usr.sbin/makefs ? > I tried Settings->Filters->File with "usr.sbin/makefs", > "iso9660_rrip.c", and "/usr.sbin/makefs/cd9660/iso9660_rrip.c". > The only effect was that the list of issues became empty. > > > Have a nice day :) > > Thomas > To put it bluntly, Coverity's UI kind of sucks. It took me a long time to figure out how to do what you want. Here are the steps: 1) Find the "View Defects" page. I think you already did. 2) There are three horizontal bars at the top left. Click on them and select "Issues by Snapshot: Outstanding Defects" 3) Click on the gear symbol in the top center, next to the word "Filters". 4) In the ensuing popup, delesect everything except "File". For File, type "*makefs*" I see 34 issues when I do this. -Alan From owner-freebsd-hackers@freebsd.org Wed Oct 7 17:28:48 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 318FC9D0541 for ; Wed, 7 Oct 2015 17:28:48 +0000 (UTC) (envelope-from scdbackup@gmx.net) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BA78D1BE9 for ; Wed, 7 Oct 2015 17:28:47 +0000 (UTC) (envelope-from scdbackup@gmx.net) Received: from scdbackup.webframe.org ([91.63.124.210]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0M9s8K-1Zuv930rQ8-00B6wO for ; Wed, 07 Oct 2015 19:28:45 +0200 Date: Wed, 07 Oct 2015 19:30:17 +0200 From: "Thomas Schmitt" To: freebsd-hackers@freebsd.org Subject: Re: Which program produces FreeBSD-11.0-CURRENT-amd64-*-disc1.iso ? Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit References: In-Reply-To: Message-Id: <70258199182991531@scdbackup.webframe.org> X-Provags-ID: V03:K0:74f829/O6itNiHMADsi2XgzbL33X1hDRm1wZ8MPspP9tUlfQBf7 4GfbqmAdGyYKtZ265wv7e57n5vGZwVsgIZKAJq9zU4iGPR8fEOXPUabXIZK4EVL6gTYAJqB CziqJyP8Qd2rncyjUEGdbU9MwmRO5OnPKOmBA9NWOWLS2j4NdvSm+q1TEqXI3oDf4NpA8h+ fnNylwiDzrH7BSRa+gDPA== X-UI-Out-Filterresults: notjunk:1;V01:K0:H6A53IkOjRo=:4gxeI56mrdw0J5ylfPd6ue cEiUZnYwktOeFrQuqHEU0IbkIsaTx/YbqUsAQLLOAAiABCdZhaut52Bse5rU5imqdkTrj/jix 3DTW7fAP0g3HpYiNxTZM61Qc7xKmSYe71TtQzdg6q+LOkA7XL0umdDXvgA5vmstqYvlE9UieH Gi58uMigeisBpVVWUsQMHP1znmwkIG5T47Uter3Cz/mr/FbeOiWBInEhT23M0XdFgIyVxEdCw VoUTaw2938uQt7rbShVBR0EJWEqxwIa+9UKWpq/kYh7oYaWlaV0cBPXvwDFvgh95qfqJqpmJD hVD9KUCDhAMf+3gHt5Wp34vhu3Yw3XkTZYC8lQW7Im3x7Svq1rqS/eOu996KXfrZxRRadGdT9 my/UL39G6yejQ4y1Ui1f/5RPyRLjp5ylGL0VTcxxg8ewxxAk2Qpb9AMIcI2G0uW31oqXEX2GL BQL75BLoaRkAhPEuK8GVc1h/B3BBaFahOohuOX3zxAx3dC6NFElQviccop4ijJ1/xPrb7AcLN +3IjzAtiDOSblBjDhGdJrrTn3aAIcynaLTsisTFwsWYflW3cZgLczh0q3r6YK1BjCTTyGvkAc SBgJyvL6lAXViAtNPphJDLmN5ZFOfk60TMzpfj/rhAkT9uNDZGN3QtMqABOYUuU7VQRLXfFml rOeL0g2fBqBRFFsC3zmWATcaf/n+m69ncs8CUqw86Pg5gN7Z23+eUzNV2O28Ntgixge5X1XLT ARaK67lCCj487jxNkKZngfpWHSCFIge8nu/02nyOZrcn7d+olsHeu7510oga7O5rlZSnsQElD uDR9zmB X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2015 17:28:48 -0000 Hi, Alan Somers wrote: > 4) In the ensuing popup, delesect everything except "File". For File, > type "*makefs*" I was not far away from that. Close, but no banana. Well, now i get with or without file filter a window saying "An error has occurred while updating the page. Please reload the page to try again. Error: Sorry, an unexpected error has occurred." (Great. Copy+Paste from error messages. Not every desktop does this. But is this the server or my browser talking to me ?) It seems to be time for a longer break. Will try again tomorrow. Have a nice day :) Thomas From owner-freebsd-hackers@freebsd.org Thu Oct 8 00:52:57 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A07799D1FEC for ; Thu, 8 Oct 2015 00:52:57 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qg0-x22e.google.com (mail-qg0-x22e.google.com [IPv6:2607:f8b0:400d:c04::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 608F59B9 for ; Thu, 8 Oct 2015 00:52:57 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by qgev79 with SMTP id v79so29945188qge.0 for ; Wed, 07 Oct 2015 17:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=oM2mkZOz1ATS/SM9f/URmluwAHeZJEksK4pxXGOSZ4w=; b=HwKSpmNfnI7sKdSR3kQMFBatNDo8ibDiZ9x4DYto4wyAvfoHXbeYZg4TuiBUratgc0 wnQfEYRu2TeiGdlxdXwGKVynyqb6JGWc42U63qjASMM/j+L08QSn6fi43VkB4ErLqiCs easpMU/hwqByKRetA6YTQgT2vIYQy4FJfpW7zSRTEeICpGh+602hE/PmJJAf4OXtQWoZ 3z2JypJMspf1T2013GDShQskOlLDd6Bcj3qz1dmk+siKoEgFDxXuoKg57QwKZGnaBTh+ u1BvOUWrlH9UqGe0C69Z+9JYzaZe1od2oltnD4sRhg01NZIdk52/257dwDHFPMkJNAGz Rgng== MIME-Version: 1.0 X-Received: by 10.140.217.70 with SMTP id n67mr5333594qhb.96.1444265576313; Wed, 07 Oct 2015 17:52:56 -0700 (PDT) Received: by 10.140.94.44 with HTTP; Wed, 7 Oct 2015 17:52:56 -0700 (PDT) Date: Wed, 7 Oct 2015 17:52:56 -0700 Message-ID: Subject: Comparing behavior of test-fesetenv.c on AMD Opterons and Intel Xeons: running FNSTENV on Opteron -- should it zero out __x87.__other? From: NGie Cooper To: "freebsd-hackers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2015 00:52:57 -0000 Hi, I was recently given a bug where one of the tests on a FreeBSD[-based] OS (it's close-ish to 10.0-RELEASE in some regards) was failing when running test-fesetenv.c on AMD Opteron processors using a VMware Hypervisor, because one of the memcmp asserts was being tripped. I did some checking in gdb and it turns out the Intel Xeon processor was either zero'ing out or leaving alone __x87.__other, and the AMD Opteron processor was populating __x87.__other with garbage. Looking at the processor architecture manuals, it seems that the values are undefined, i.e. can be non-determinate and should be ignored when running the test, however, I'm not 100% sure if my analysis is correct. I was wondering if someone who knew a bit more about amd64 architecture and floating point could comment on this. I've included the context from my investigation of the bug at the bottom of the email. Thank you! -NGie >From lib/msun/amd64/fenv.c: 40 const fenv_t __fe_dfl_env = { 41 { 0xffff0000 | __INITIAL_FPUCW__, 42 0xffff0000, 43 0xffffffff, 44 { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 45 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0xff } 46 }, 47 __INITIAL_MXCSR__ 48 }; $ grep -r __INITIAL_FPUCW__ sys/ sys/amd64/amd64/fpu.c: control = __INITIAL_FPUCW__; sys/amd64/amd64/fpu.c: if (curpcb->pcb_initial_fpucw != __INITIAL_FPUCW__) sys/amd64/amd64/machdep.c: pcb->pcb_initial_fpucw = __INITIAL_FPUCW__; sys/x86/include/fpu.h:#define __INITIAL_FPUCW__ 0x037F $ grep -r __INITIAL_MXCSR__ sys/ sys/amd64/amd64/fpu.c: mxcsr = __INITIAL_MXCSR__; sys/x86/include/fpu.h:#define __INITIAL_MXCSR__ 0x1F80 $ The numbers in decimal for amd64 are as follows: 0xffff0000 | __INITIAL_FPUCW__ -> 4294902655 0xffff0000 -> 4294901760 0xffffffff -> 4294967295 '\377\377' -> '\xff\xff' __INITIAL_MXCSR -> 8064 On Intel, the values between env and FE_DFL_ENV are consistent but on the system with an AMD Opteron, env.__x87.__other after calling fesetenv is full of garbage. 80 #else /* __amd64__ */ 81 typedef struct { 82 struct { 83 __uint32_t __control; 84 __uint32_t __status; 85 __uint32_t __tag; 86 char __other[16]; 87 } __x87; 88 __uint32_t __mxcsr; 89 } fenv_t; 90 #endif /* __i386__ */ # cat Makefile # $FreeBSD$ TESTS= test-cexp test-conj test-csqrt test-ctrig \ test-exponential test-fenv test-fma \ test-fmaxmin test-ilogb test-invtrig test-invctrig \ test-logarithm test-lrint \ test-lround test-nan test-nearbyint test-next test-rem test-trig CFLAGS+= -g -O0 -lm -Wno-unknown-pragmas CFLAGS+= -std=c99 .PHONY: tests tests: ${TESTS} for p in ${TESTS}; do ${.OBJDIR}/$$p; done .PHONY: clean clean: -rm -f ${TESTS} # prove -v test-fenv.t test-fenv....Assertion failed: (memcmp(&env, FE_DFL_ENV, sizeof(env)) == 0), function test_dfl_env, file test-fenv.c, line 136. 1..8 dubious Test returned status 0 (wstat 134, 0x86) DIED. FAILED tests 1-8 Failed 8/8 tests, 0.00% okay Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- test-fenv.t 0 134 8 16 200.00% 1-8 Failed 1/1 test scripts, 0.00% okay. 8/8 subtests failed, 0.00% okay. # gdb ./test-fenv GNU gdb (GDB) 7.7.1 [GDB v7.7.1 for FreeBSD] Copyright (C) 2014 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-portbld-freebsd11.0". Type "show configuration" for configuration details. For bug reporting instructions, please see: . Find the GDB manual and other documentation resources online at: . For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from ./test-fenv...done. (gdb) c The program is not being run. (gdb) quit vOneFS-GR3-1# gdb ./test-fenv GNU gdb (GDB) 7.7.1 [GDB v7.7.1 for FreeBSD] Copyright (C) 2014 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-portbld-freebsd11.0". Type "show configuration" for configuration details. For bug reporting instructions, please see: . Find the GDB manual and other documentation resources online at: . For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from ./test-fenv...done. (gdb) r Starting program: /usr/src/tools/regression/lib/msun/test-fenv 1..8 Assertion failed: (memcmp(&env, FE_DFL_ENV, sizeof(env)) == 0), function test_dfl_env, file test-fenv.c, line 136. Program received signal SIGABRT, Aborted. 0x0000000800b842ca in kill () from /lib/libc.so.7 (gdb) frame 3 #3 0x0000000000400ec9 in test_dfl_env () at test-fenv.c:136 136 assert(memcmp(&env, FE_DFL_ENV, sizeof(env)) == 0); (gdb) p env $1 = {__x87 = {__control = 4294902655, __status = 4294901760, __tag = 4294967295, __other = "W\224}\200 \000\004\001\250\244D\201;\000\377\377"}, __mxcsr = 8064} (gdb) p ((fenv_t)__fe_dfl_env) $2 = {__x87 = {__control = 4294902655, __status = 4294901760, __tag = 4294967295, __other = '\000' , "\377\377"}, __mxcsr = 8064} 1. http://support.amd.com/TechDocs/26569_APM_v5.pdf 2. http://www.intel.com/Assets/en_US/PDF/manual/253666.pdf From owner-freebsd-hackers@freebsd.org Thu Oct 8 07:24:49 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 869BE9D1199 for ; Thu, 8 Oct 2015 07:24:49 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 02243262 for ; Thu, 8 Oct 2015 07:24:48 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id t987OiFR069343 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 8 Oct 2015 10:24:44 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua t987OiFR069343 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id t987Oi3P069342; Thu, 8 Oct 2015 10:24:44 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 8 Oct 2015 10:24:44 +0300 From: Konstantin Belousov To: NGie Cooper Cc: "freebsd-hackers@freebsd.org" Subject: Re: Comparing behavior of test-fesetenv.c on AMD Opterons and Intel Xeons: running FNSTENV on Opteron -- should it zero out __x87.__other? Message-ID: <20151008072444.GO2257@kib.kiev.ua> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2015 07:24:49 -0000 On Wed, Oct 07, 2015 at 05:52:56PM -0700, NGie Cooper wrote: I removed a lot of text which I am unable to parse. > Assertion failed: (memcmp(&env, FE_DFL_ENV, sizeof(env)) == 0), > function test_dfl_env, file test-fenv.c, line 136. > > Program received signal SIGABRT, Aborted. > 0x0000000800b842ca in kill () from /lib/libc.so.7 > (gdb) frame 3 > #3 0x0000000000400ec9 in test_dfl_env () at test-fenv.c:136 > 136 assert(memcmp(&env, FE_DFL_ENV, sizeof(env)) == 0); > (gdb) p env > $1 = {__x87 = {__control = 4294902655, __status = 4294901760, __tag = > 4294967295, __other = "W\224}\200 > \000\004\001\250\244D\201;\000\377\377"}, __mxcsr = 8064} > (gdb) p ((fenv_t)__fe_dfl_env) > $2 = {__x87 = {__control = 4294902655, __status = 4294901760, __tag = > 4294967295, __other = '\000' , "\377\377"}, __mxcsr > = 8064} This test is wrong. The __other member of the struct fenv_t is not filled by fegetenv(), so it content retains a stack garbage that was there before the call. On the other hand, FE_DFL_ENV is explicitely initialized with zeroes. Test must be fixed to compare only meaningful fields of two environments. From owner-freebsd-hackers@freebsd.org Thu Oct 8 07:38:20 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6999B9D1C20 for ; Thu, 8 Oct 2015 07:38:20 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x22a.google.com (mail-pa0-x22a.google.com [IPv6:2607:f8b0:400e:c03::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3BA811B9 for ; Thu, 8 Oct 2015 07:38:20 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by pacex6 with SMTP id ex6so47120047pac.0 for ; Thu, 08 Oct 2015 00:38:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=OX39QbLljyjp9zWEiLPn1HzLrkAHFNuogaqn5P+Dl+A=; b=H6/CmVHkfQuYd5GRknCUNwBGUElwVS5bZ1IaoMv4cztfVysk3pgPH2fCBcobSQ72RW K6JS1aJTPXC0eEi/dor0mCzo5pbV8OzsOszT3ALzX5ngJK+5z0JLXx6SUfKaewlmrdzj uITzYAED/i5FGDKeGjDdcYVeNoq1cKWXUBeLwDARFkXTBAtAGGhNbG94Lm+obbwomB4s UGcLdq47K7yYNxcZmmlZC4dVgDWQoAGX2ehVLu4L22JhTR6F0ZS2RToiyInUkobU3GvB xCcviovYyWXcI8MQTwpKWIckIA+f3oDX0KwJWz6LfbhKm6jqNL9iMqgMib7xhYmDJANs K0CA== X-Received: by 10.67.30.136 with SMTP id ke8mr6599752pad.16.1444289899879; Thu, 08 Oct 2015 00:38:19 -0700 (PDT) Received: from [33.167.215.6] ([172.56.32.252]) by smtp.gmail.com with ESMTPSA id ot8sm43587110pbb.26.2015.10.08.00.38.19 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 08 Oct 2015 00:38:19 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: Comparing behavior of test-fesetenv.c on AMD Opterons and Intel Xeons: running FNSTENV on Opteron -- should it zero out __x87.__other? From: Garrett Cooper X-Mailer: iPhone Mail (13A452) In-Reply-To: <20151008072444.GO2257@kib.kiev.ua> Date: Thu, 8 Oct 2015 00:38:15 -0700 Cc: "freebsd-hackers@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <20151008072444.GO2257@kib.kiev.ua> To: Konstantin Belousov X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2015 07:38:20 -0000 > On Oct 8, 2015, at 00:24, Konstantin Belousov wrote:= >=20 > On Wed, Oct 07, 2015 at 05:52:56PM -0700, NGie Cooper wrote: > I removed a lot of text which I am unable to parse. >=20 >> Assertion failed: (memcmp(&env, FE_DFL_ENV, sizeof(env)) =3D=3D 0), >> function test_dfl_env, file test-fenv.c, line 136. >>=20 >> Program received signal SIGABRT, Aborted. >> 0x0000000800b842ca in kill () from /lib/libc.so.7 >> (gdb) frame 3 >> #3 0x0000000000400ec9 in test_dfl_env () at test-fenv.c:136 >> 136 assert(memcmp(&env, FE_DFL_ENV, sizeof(env)) =3D=3D 0); >> (gdb) p env >> $1 =3D {__x87 =3D {__control =3D 4294902655, __status =3D 4294901760, __t= ag =3D >> 4294967295, __other =3D "W\224}\200 >> \000\004\001\250\244D\201;\000\377\377"}, __mxcsr =3D 8064} >> (gdb) p ((fenv_t)__fe_dfl_env) >> $2 =3D {__x87 =3D {__control =3D 4294902655, __status =3D 4294901760, __t= ag =3D >> 4294967295, __other =3D '\000' , "\377\377"}, __mxcsr >> =3D 8064} >=20 > This test is wrong. The __other member of the struct fenv_t is not filled= > by fegetenv(), so it content retains a stack garbage that was there before= > the call. On the other hand, FE_DFL_ENV is explicitely initialized with > zeroes. >=20 > Test must be fixed to compare only meaningful fields of two environments. Hi kib! Ok -- that's what my gut was telling me when I was reading the spec, but I n= eeded a second opinion. Interesting how Intel leaves the __other field alone= and AMD [opterons] don't ;/.. Thanks :)! -NGie= From owner-freebsd-hackers@freebsd.org Thu Oct 8 08:06:30 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C1B8D9D1209 for ; Thu, 8 Oct 2015 08:06:30 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 373ED7CE for ; Thu, 8 Oct 2015 08:06:30 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id t9886Lk4080039 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 8 Oct 2015 11:06:21 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua t9886Lk4080039 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id t9886LmH080038; Thu, 8 Oct 2015 11:06:21 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 8 Oct 2015 11:06:21 +0300 From: Konstantin Belousov To: Garrett Cooper Cc: "freebsd-hackers@freebsd.org" Subject: Re: Comparing behavior of test-fesetenv.c on AMD Opterons and Intel Xeons: running FNSTENV on Opteron -- should it zero out __x87.__other? Message-ID: <20151008080621.GP2257@kib.kiev.ua> References: <20151008072444.GO2257@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2015 08:06:30 -0000 On Thu, Oct 08, 2015 at 12:38:15AM -0700, Garrett Cooper wrote: > > > On Oct 8, 2015, at 00:24, Konstantin Belousov wrote: > > > > On Wed, Oct 07, 2015 at 05:52:56PM -0700, NGie Cooper wrote: > > I removed a lot of text which I am unable to parse. > > > >> Assertion failed: (memcmp(&env, FE_DFL_ENV, sizeof(env)) == 0), > >> function test_dfl_env, file test-fenv.c, line 136. > >> > >> Program received signal SIGABRT, Aborted. > >> 0x0000000800b842ca in kill () from /lib/libc.so.7 > >> (gdb) frame 3 > >> #3 0x0000000000400ec9 in test_dfl_env () at test-fenv.c:136 > >> 136 assert(memcmp(&env, FE_DFL_ENV, sizeof(env)) == 0); > >> (gdb) p env > >> $1 = {__x87 = {__control = 4294902655, __status = 4294901760, __tag = > >> 4294967295, __other = "W\224}\200 > >> \000\004\001\250\244D\201;\000\377\377"}, __mxcsr = 8064} > >> (gdb) p ((fenv_t)__fe_dfl_env) > >> $2 = {__x87 = {__control = 4294902655, __status = 4294901760, __tag = > >> 4294967295, __other = '\000' , "\377\377"}, __mxcsr > >> = 8064} > > > > This test is wrong. The __other member of the struct fenv_t is not filled > > by fegetenv(), so it content retains a stack garbage that was there before > > the call. On the other hand, FE_DFL_ENV is explicitely initialized with > > zeroes. > > > > Test must be fixed to compare only meaningful fields of two environments. > > Hi kib! > > Ok -- that's what my gut was telling me when I was reading the spec, but I needed a second opinion. Interesting how Intel leaves the __other field alone and AMD [opterons] don't ;/.. Your statement does not make any sense. Re-read what I tell above. The __other field is not written by code, the code does not change by the matter of being run on Intel or AMD processors. It just happens so that on one of your system the stack are seems to be zero, while on another, it does not. From owner-freebsd-hackers@freebsd.org Thu Oct 8 09:14:14 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9B9799D0B39 for ; Thu, 8 Oct 2015 09:14:14 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x231.google.com (mail-pa0-x231.google.com [IPv6:2607:f8b0:400e:c03::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6C2E11E79 for ; Thu, 8 Oct 2015 09:14:14 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by pacex6 with SMTP id ex6so49638085pac.0 for ; Thu, 08 Oct 2015 02:14:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=21sQ+sliqZCWyONWMr1urJSrOY0vw4K/xDUitPxU7aE=; b=c8t5qed6xTzuyl4mAG2zHvcMMoXaJ1arZi/KX+Mz0ZBDUo/thVPnYi7kC3yq9rdt6B JFZO/VC2PufK6I3OIkzDzpmZ7wpEsySe8nmHa+uNXABMM+bj6yplH9pRga6ggGW5/XSm 3FL6+gi1LEHN97KoGnBKsIeTa/LAPv723oeTO4acXIfe1GdSpIFYUzbrpMdgSVMX3eNL Ul6TukeTIPavhVTijG54b81TxeFIrP3xDMOzRQHeYFTojy419qXjmMMgYol78dpNDSl6 JtY8x8n8uqgsDGfbW7J7TehcvH3w9zwQF8m2IhInGyakLCSNlSpA3Rvk98jCyDkXXsZE /2mA== X-Received: by 10.68.204.65 with SMTP id kw1mr6905125pbc.76.1444295653652; Thu, 08 Oct 2015 02:14:13 -0700 (PDT) Received: from [192.168.20.11] (c-24-16-212-205.hsd1.wa.comcast.net. [24.16.212.205]) by smtp.gmail.com with ESMTPSA id xo2sm14114128pbb.48.2015.10.08.02.14.13 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 08 Oct 2015 02:14:13 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: Comparing behavior of test-fesetenv.c on AMD Opterons and Intel Xeons: running FNSTENV on Opteron -- should it zero out __x87.__other? From: Garrett Cooper X-Mailer: iPhone Mail (13A452) In-Reply-To: <20151008080621.GP2257@kib.kiev.ua> Date: Thu, 8 Oct 2015 02:14:12 -0700 Cc: "freebsd-hackers@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <20151008072444.GO2257@kib.kiev.ua> <20151008080621.GP2257@kib.kiev.ua> To: Konstantin Belousov X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2015 09:14:14 -0000 > On Oct 8, 2015, at 01:06, Konstantin Belousov wrote:= >=20 >> On Thu, Oct 08, 2015 at 12:38:15AM -0700, Garrett Cooper wrote: ... >> Hi kib! >>=20 >> Ok -- that's what my gut was telling me when I was reading the spec, but I= needed a second opinion. Interesting how Intel leaves the __other field alo= ne and AMD [opterons] don't ;/.. >=20 > Your statement does not make any sense. Re-read what I tell above. > The __other field is not written by code, the code does not change > by the matter of being run on Intel or AMD processors. It just happens > so that on one of your system the stack are seems to be zero, while on > another, it does not. I thought __other corresponded to C0-C3 based on my read of the spec -- is t= hat incorrect? Thanks!= From owner-freebsd-hackers@freebsd.org Thu Oct 8 09:34:01 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 451F39D1A9C for ; Thu, 8 Oct 2015 09:34:01 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B1433DB7 for ; Thu, 8 Oct 2015 09:34:00 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id t989XtQo000370 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 8 Oct 2015 12:33:55 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua t989XtQo000370 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id t989XtgP000369; Thu, 8 Oct 2015 12:33:55 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 8 Oct 2015 12:33:55 +0300 From: Konstantin Belousov To: Garrett Cooper Cc: "freebsd-hackers@freebsd.org" Subject: Re: Comparing behavior of test-fesetenv.c on AMD Opterons and Intel Xeons: running FNSTENV on Opteron -- should it zero out __x87.__other? Message-ID: <20151008093355.GS2257@kib.kiev.ua> References: <20151008072444.GO2257@kib.kiev.ua> <20151008080621.GP2257@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2015 09:34:01 -0000 On Thu, Oct 08, 2015 at 02:14:12AM -0700, Garrett Cooper wrote: > > > On Oct 8, 2015, at 01:06, Konstantin Belousov wrote: > > > >> On Thu, Oct 08, 2015 at 12:38:15AM -0700, Garrett Cooper wrote: > > ... > > >> Hi kib! > >> > >> Ok -- that's what my gut was telling me when I was reading the spec, but I needed a second opinion. Interesting how Intel leaves the __other field alone and AMD [opterons] don't ;/.. > > > > Your statement does not make any sense. Re-read what I tell above. > > The __other field is not written by code, the code does not change > > by the matter of being run on Intel or AMD processors. It just happens > > so that on one of your system the stack are seems to be zero, while on > > another, it does not. > > I thought __other corresponded to C0-C3 based on my read of the spec -- is that incorrect? What are C0-C3 you reference ? I can only think about condition code bits from the FPU status word which have that names, but the word is put into the __status field of fenv_t. And, what spec did you read ? From owner-freebsd-hackers@freebsd.org Thu Oct 8 09:47:37 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0A2039D16D6 for ; Thu, 8 Oct 2015 09:47:37 +0000 (UTC) (envelope-from scdbackup@gmx.net) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8F07ACE7 for ; Thu, 8 Oct 2015 09:47:36 +0000 (UTC) (envelope-from scdbackup@gmx.net) Received: from scdbackup.webframe.org ([91.63.124.210]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0Lt2BW-1alX0P31nW-012YWn for ; Thu, 08 Oct 2015 11:47:27 +0200 Date: Thu, 08 Oct 2015 11:49:01 +0200 From: "Thomas Schmitt" To: freebsd-hackers@freebsd.org Subject: What to do with triaged Coverity complaints about makefs ? Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <302195821622251047657@scdbackup.webframe.org> X-Provags-ID: V03:K0:znj2Abs5be8Do0fZT8pREw9YWeUBLOjnZ9H6IaDJrAbkIJKco9y XUs87SiJbrCGXwjTsqLKF56Dn2/d0g1SQE13hdEOFzHZ/Tj33G5VAXrL0vnaMI7JBrZJAC2 Xwc9arOgLFMylSzWcGHL7xKhoNuo9lFAdq9HUIK5KRoMuq9WUPIErB9uGKn/zZOv+c+2TDo lsVVwclyRaEH2tMNJk0lA== X-UI-Out-Filterresults: notjunk:1;V01:K0:6k17Vd3YgGQ=:+iaMcyMtzeELBd9gVGoskA Tdjj86SXjyrk4VoEiEXkJWyWs4MuIqmVSp4lfAW2HFeMXWPi89uisaqBiT9OpvGlv8kiIo+wH r+64i2hz2hbNKvJzE/7GwveNM+fqlH0blb+kpnwNXTUdckAmjmCw9VpCVEhygqLDwjvpdW4V0 PLgOsnH7gxIGSrFV6K90XxX2m2VviqiBJtXhkRQR8XslGgA1/cgQCctryMqng6ILe81Q/F/+k /WIUFHcpzBrwOHRXsIkTMUHNXrtykOfJo5ALESS67E1SEC9V5z4HX3WVbn0AUzb/f4xr9yRzZ 5AAL9+5mz+P6tKaHng7ownvOHBlvrv3ftytWwDkQFrjjIfuFht4PtP+H4hAsB48l+6knE1mx0 RyViiQ97Em/MQH13OeOtUWQf5i2rtkqCli3Pu7DdumZ2tQJNKMseCt/uRVI7oFuX90SIry9F8 1VdMAYRjO5p2H892NmVOENt6+nEqBLmUZkH3aWWRrL74/CP2HaRkW6lbat665DPGDtco63L9d 5sJCprHPIABQTZWa8CUNvYhVfHVFsRy5X0tWNw0/DpX6Vptsnk04tKMMj2IZNz8yVfYyU/32I EfQtsl36WTtsyJBZqh5jFBgd9eq9NGIfk84M6NgbrcYMIINNy/WhZ5ePs6gk1MALjPOOT0oW/ sFSYlwl8Du5E+jb3iuleIzNVUYGApUD/cj3t2spEoKSt1tsa+XsqM3MQgSuWuL8JUMb6dy/L+ Ma27EZSqF4zmptL354rvGpLpmE69t0gpODpPErq3LWakHRy0Q7ETh4p+HrhzEWWGTmkaqMISr jqK7K18 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2015 09:47:37 -0000 Hi, i now get to see the makefs complaints of Coverity. (The trick was to try logging out, which failed, but then produced the list of complaints and made the GUI willing to show details.) Many complaints are about the FFS aspect of makefs, of which i have no clue. Some more are about /usr.sbin/makefs/cd9660/cd9660_debug.c, of which i do not really understand the purpose. So i mainly cared for bugs related to ISO 9660 production. Two ISO 9660 related complaints are easy to understand, but i currently lack the makefs background to decide how to react on the miserable failure to write to disk. Meanwhile i got 9 diagnoses with remedy proposals (if real bug) and 2 diagnoses without proposals. Now what to do with my findings ? File 6 PRs for 974635+974636, 976312, 977470, 978431, 1008927, 1305659 ? Fill out the Coverity "Triage" window at the right side of the GUI ? (Am i entitled to do more than reading there ?) ============================================================== Overview: 974635 : DIRTY HACK : Copying several struct elements by single memcpy(). 974636 : DIRTY HACK : Copying several struct elements by single memcpy(). 975347 : NO DISK FULL PROVISIONS : How to react on failed fseek() ? 975348 : NO DISK FULL PROVISIONS : How to react on failed fseek() ? 975621 : FALSE POSITIVE : 976312 : SIGSEGV : Processing is unaware of exotic option. 976924 : FALSE POSITIVE : 977470 : SPECS VIOLATION : Writing slightly wrong Boot Record. 978431 : MEMORY LEAK : No free() after malloc(). 1008927 : WRONG SIZEOF CHECK : Comparing bit count rather than byte count. 1305659 : MAYBE SIGSEGV : Unclear whether reaction on malloc failure suffices. ============================================================== Information sources: Coverity report: https://scan6.coverity.com/reports.htm#v36539/p10022 with File filter "*makefs*" Source obtained by: svn co https://svn.FreeBSD.org/base/head/usr.sbin/makefs makefs Wider FreeBSD code studied via: https://svnweb.freebsd.org/base/head/ ============================================================== 974635 : DIRTY HACK : Copying several struct elements by single memcpy(). -------------------------------------------------------------- usr.sbin/makefs/ffs/ffs_bswap.c CID 974635 : Destination buffer too small (BUFFER_SIZE) 10. buffer_size: You might overrun the 48 byte destination string n->di_db by writing the maximum 60 bytes from o->di_db. 138 memcpy(n->di_db, o->di_db, (NDADDR + NIADDR) * sizeof(u_int32_t)); --------------- Source analysis: This does not apply to ISO 9660. But indeed sys/ufs/ufs/dinode.h defines #define NDADDR 12 /* Direct addresses in inode. */ #define NIADDR 3 /* Indirect addresses in inode. */ and typedef int32_t ufs1_daddr_t; ... struct ufs1_dinode { ... ufs1_daddr_t di_db[NDADDR]; /* 40: Direct disk blocks. */ ufs1_daddr_t di_ib[NIADDR]; /* 88: Indirect disk blocks. */ ... So both arrays get copied in one memcpy() operation. --------------- Remedy proposal: One should consider to use two separate memcpy() calls. (I cannot judge whether the alignment of 40 and 88 needs padding bytes on any architecture.) ============================================================== 974636 : DIRTY HACK : Copying several struct elements by single memcpy(). -------------------------------------------------------------- usr.sbin/makefs/ffs/ffs_bswap.c CID 974636 : Destination buffer too small (BUFFER_SIZE) 20. buffer_size: You might overrun the 16 byte destination string n->di_extb by writing the maximum 136 bytes from o->di_extb. 168 memcpy(n->di_extb, o->di_extb, (NXADDR + NDADDR + NIADDR) * 8); --------------- Source analysis: Like CID 974635. sys/ufs/ufs/dinode.h defines typedef int64_t ufs2_daddr_t; ... struct ufs2_dinode { ... ufs2_daddr_t di_extb[NXADDR];/* 96: External attributes block. */ ufs2_daddr_t di_db[NDADDR]; /* 112: Direct disk blocks. */ ufs2_daddr_t di_ib[NIADDR]; /* 208: Indirect disk blocks. */ --------------- Remedy proposal: One should consider to use three separate memcpy() calls. ============================================================== 975347 : NO DISK FULL PROVISIONS : How to react on failed fseek() ? -------------------------------------------------------------- usr.sbin/makefs/cd9660/cd9660_eltorito.c CID 975347 : Unchecked return value from library (CHECKED_RETURN) 5. check_return: Calling fseek(fd, 32UL - strlen(part_type) - 1UL, 1) without checking return value. (Ouch, an ISO producer which does not work on sequential file objects. That's quite inconvenient for users.) >>> How to react on failure to address ? ============================================================== 975348 : NO DISK FULL PROVISIONS : How to react on failed fseek() ? -------------------------------------------------------------- usr.sbin/makefs/cd9660/cd9660_eltorito.c CID 975348: Unchecked return value from library (CHECKED_RETURN) 33. check_return: Calling fseek(fd, 510L, 0) without checking return >>> How to react on failure to address ? ============================================================== 975621 : FALSE POSITIVE : -------------------------------------------------------------- usr.sbin/makefs/cd9660/cd9660_write.c CID 975621 (#1 of 1): Copy-paste error (COPY_PASTE_ERROR) copy_paste_error: rf in fclose(rf) looks like a copy-paste error. Should it say fd instead? 471 (void)fclose(rf); --------------- Source analysis: The suspicion stems from the assymetric reaction on error. Only the read FILE pointer rf was opened inside the function. So it gets closed in both error cases: with read FILE *rf and with write FILE *fd. if (ferror(rf)) { ... (void)fclose(rf); ... if (ferror(fd)) { ... (void)fclose(rf); ============================================================== 976312 : SIGSEGV : Processing is unaware of exotic option. -------------------------------------------------------------- usr.sbin/makefs/cd9660.c CID 976312: Explicit null dereferenced (FORWARD_NULL)i 4. var_deref_op: Dereferencing null pointer conversion_function. 1740 return (*conversion_function)(oldname, newname, is_file); --------------- Source analysis: The function pointer is non-NULL only if diskStructure.isoLevel is 1 or 2. A snippet in cd9660_parse_opts() indicates that the value can indeed be 3: option_t cd9660_options[] = { { "l", &diskStructure.isoLevel, 1, 3, "ISO Level" }, { "isolevel", &diskStructure.isoLevel, 1, 3, "ISO Level" }, ... One should test makefs with option -l 3. The line 1740 is in function cd9660_convert_filename(). ISO 9660 level 3 allows the same file names as level 2. The use of ISO level 3 is not announced anywhere in the ISO image but rather becomes visible only if a file is large enough to need more than one extent. Extents can have 4 GiB - 2 KiB of size. The offer of ISO level 3 is questionable because neither FreeBSD nor NetBSD can read files with multiple extents from ISO 9660. http://lists.freebsd.org/pipermail/freebsd-hackers/2012-April/038552.html Surely nobody has ever created a level 3 ISO with makefs. I doubt that it is prepared for multiple extents at all. --------------- Remedy proposal: Use the same conversion function for all levels above 1: - else if (diskStructure.isoLevel == 2) + else conversion_function = &cd9660_level2_convert_filename; Consider to restrict isoLevel to 1 and 2. - { "l", &diskStructure.isoLevel, 1, 3, "ISO Level" }, + { "l", &diskStructure.isoLevel, 1, 2, "ISO Level" }, ============================================================== 976924 : FALSE POSITIVE : -------------------------------------------------------------- usr.sbin/makefs/cd9660.c CID 976924: Memset fill value of '0' (NO_EFFECT)bad_memset: Memset with fill value '0' (the zero character). 684 memset(diskStructure.primaryDescriptor.expiration_date, 48, 16UL). 685 diskStructure.primaryDescriptor.expiration_date[16] = 0; --------------- Source analysis: This is correct. ECMA-11 8.4.26.1 says: "If all characters in RBP 1 to 16 of this field are the digit ZERO and the number in RBP 17 is zero, it shall mean that the date and time are not specified." "ZERO" means ASCII 48 = '0', "zero" means ASCII 0 = NUL. ============================================================== 977469 : -------------------------------------------------------------- usr.sbin/makefs/cd9660/cd9660_debug.c CID 977469: Out-of-bounds access (OVERRUN) 1. overrun-buffer-val: Overrunning array pttemp->parent_number of 2 bytes by passing it to a function which accesses it at byte offset 3. 186 printf("%i\n", 187 debug_get_encoded_number(pttemp->parent_number,mode)); --------------- Source analysis: The problem is in debug_get_encoded_number() which depending on mode reads more or less bytes. >>> ============================================================== 977470 : SPECS VIOLATION : Writing slightly wrong Boot Record. -------------------------------------------------------------- usr.sbin/makefs/cd9660/cd9660_eltorito.c CID 977470: Out-of-bounds access (OVERRUN) 2. overrun-buffer-val: Overrunning array diskStructure.boot_descriptor->boot_catalog_pointer of 4 bytes by passing it to a function which accesses it at byte offset 4. 374 cd9660_bothendian_dword(first_sector, 375 diskStructure.boot_descriptor->boot_catalog_pointer); --------------- Source analysis: cd9660_bothendian_dword() indeed writes 8 bytes (both endian) into usr.sbin/makefs/cd9660.h defines typedef struct _iso9660_disk { ... boot_volume_descriptor *boot_descriptor; ... } iso9660_disk; usr.sbin/makefs/cd9660/cd9660_eltorito.h defines typedef struct _boot_volume_descriptor { ... u_char boot_catalog_pointer [ISODCL(0x47,0x4A)]; u_char unused2 [ISODCL(0x4B,0x7FF)]; } boot_volume_descriptor; So the overrun hits the first 4 bytes of .unused2 . The little endian 4-byte value gets written to .boot_catalog_pointer, even on big endian architectures. This could be very bad if used for more computations. But obviously this will only be written as byte string to the ISO image. El Torito 1.0 (1995) Figure 7 specifies bytes 0x4B to 0x7FFF of the record as "Unused, must be 0." But FreeBSD-11.0-CURRENT-amd64-20151001-r288459-disc1.iso has at byte address (17 * 2048 + 0x4B) the values {0, 0, 0, 19} which is the big endian address of the boot catalog. --------------- Remedy proposal: Use function cd9660_731() instead of cd9660_bothendian_dword(): - cd9660_bothendian_dword(first_sector, - cd9660_731(first_sector, diskStructure.boot_descriptor->boot_catalog_pointer); ============================================================== 978431 : MEMORY LEAK : No free() after malloc(). -------------------------------------------------------------- usr.sbin/makefs/cd9660/cd9660_write.c CID 978431: Resource leak (RESOURCE_LEAK) 9. leaked_storage: Variable buffer going out of scope leaks the storage it points to. 216 return cd9660_write_filedata(fd, sector, buffer_head, 217 path_table_sectors); --------------- Source analysis: There are two return statements in the function. The first one (return 0) is ok, because malloc() returned NULL. The second one uses the allocated buffer and does not free it. --------------- Remedy proposal: Untangle the return statement. + int ret; ... - return cd9660_write_filedata(fd, sector, buffer_head, + ret = cd9660_write_filedata(fd, sector, buffer_head, path_table_sectors); + free(buffer); + return ret; ============================================================== 1008927 : WRONG SIZEOF CHECK : Comparing bit count rather than byte count. -------------------------------------------------------------- usr.sbin/makefs/cd9660/cd9660_rrip.c CID 1008927: Operands don't affect result (CONSTANT_EXPRESSION_RESULT) result_independent_of_operands: (uint64_t)fnode->inode->st.st_dev >> 32 is 0 regardless of the values of its operands. This occurs as an argument to a function call. --------------- Source analysis: The complained statement is in an if case which obviously shall take care for 64-bit dev_t. But the test expression looks for 256-bit dev_t (which i doubt that it does exist anywhere). --------------- Remedy proposal: - if (sizeof (fnode->inode->st.st_dev) > 32) + if (sizeof (fnode->inode->st.st_dev) > 4) ============================================================== 1305659 : MAYBE SIGSEGV : Unclear whether reaction on malloc failure suffices. -------------------------------------------------------------- usr.sbin/makefs/cd9660.c CID 1305659: Dereference before null check (REVERSE_INULL)i check_after_deref: Null-checking var suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 431 if (var) 432 free(var); --------------- Source analysis: Indeed the function should bail out when allocation fails. 327 if ((var = strdup(option)) == NULL) 328 err(1, "allocating memory for copy of option string"); If err() does not finally call exit(), then the program runs into a SIGSEGV by 331 val = strchr(var, '='); The function cd9660_parse_opts() gets called by usr.sbin/makefs/makefs.c if (! fstype->parse_options(p, &fsoptions)) usage(); usage() calls exit(1). So i assume that return NULL would be the way to indicate error and cause abort. But usage() will indicate a user error where a resource shortage is the reason. (Not that i deam "!" a valid test for NULL. Why define NULL if one assumes it to be 0 anyway ?) --------------- Remedy proposal: Call exit(1) if no memory is available. (Unless you can find the definition of err() and verify that it calls exit().) - if ((var = strdup(option)) == NULL) + if ((var = strdup(option)) == NULL) { err(1, "allocating memory for copy of option string"); + exit(1); + } In any case remove the test which made Coverity suspicious. - if (var) - free(var); + free(var); ============================================================== Have a nice day :) Thomas From owner-freebsd-hackers@freebsd.org Thu Oct 8 15:01:02 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A0D629D247C for ; Thu, 8 Oct 2015 15:01:02 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ob0-x22a.google.com (mail-ob0-x22a.google.com [IPv6:2607:f8b0:4003:c01::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 69D41AA4 for ; Thu, 8 Oct 2015 15:01:02 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by obbda8 with SMTP id da8so40367121obb.1 for ; Thu, 08 Oct 2015 08:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=tB+qind8x+XEceajmMitghkptktqZrRcfCDm0LMKRTs=; b=Aq61BjU65YlGTF4uYxZ+u20EgGTDDMO1MqaUqUuGSDMSTCg1++Q+G1hqeziXGsetGf xHsCLCbNC6a4sZ9K5+LEyE+mbK/5eIQvclk9qT0lXDP0W5hLIYNiWwMkveU75LZqO8KS Aixvm+3bL56gEONQxf8vx2iYKB91Axi0CeaHTGs9lv6pgkPvQBerZGzud49uM6KCzDtm 0sro8RW2pcgWRUeO+GsibEUL3opLzSY6hJKfyGLPv4HaAAbi5tw8uPdA/cot2Ei/hmLL tWhvnNQJUMcOqIfv/HIkiGq9znYfB/nu1KgSysgbPwKr52eOPyyl+zjIexfVmkdd2DuP WtTg== MIME-Version: 1.0 X-Received: by 10.60.117.170 with SMTP id kf10mr4660255oeb.60.1444316461480; Thu, 08 Oct 2015 08:01:01 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.202.71.6 with HTTP; Thu, 8 Oct 2015 08:01:01 -0700 (PDT) In-Reply-To: <302195821622251047657@scdbackup.webframe.org> References: <302195821622251047657@scdbackup.webframe.org> Date: Thu, 8 Oct 2015 09:01:01 -0600 X-Google-Sender-Auth: i6fVYba5SeBnsocyOtBOck9Ykho Message-ID: Subject: Re: What to do with triaged Coverity complaints about makefs ? From: Alan Somers To: Thomas Schmitt Cc: "freebsd-hackers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2015 15:01:02 -0000 On Thu, Oct 8, 2015 at 3:49 AM, Thomas Schmitt wrote: > Hi, > > i now get to see the makefs complaints of Coverity. > (The trick was to try logging out, which failed, but then produced > the list of complaints and made the GUI willing to show details.) > > Many complaints are about the FFS aspect of makefs, of which i > have no clue. > Some more are about /usr.sbin/makefs/cd9660/cd9660_debug.c, > of which i do not really understand the purpose. > So i mainly cared for bugs related to ISO 9660 production. > > Two ISO 9660 related complaints are easy to understand, but > i currently lack the makefs background to decide how to > react on the miserable failure to write to disk. > > Meanwhile i got 9 diagnoses with remedy proposals (if real bug) > and 2 diagnoses without proposals. > > > Now what to do with my findings ? > > File 6 PRs for 974635+974636, 976312, 977470, 978431, 1008927, > 1305659 ? > > Fill out the Coverity "Triage" window at the right side of the > GUI ? (Am i entitled to do more than reading there ?) Filling out the Coverity triage info is good. Filing PRs is better. Doing both is better yet. But ultimately, the next step forward is to attract the attention of a developer who can review and commit your patches. Checking "svn log" for recent committers to that directory is a good idea, but you should probably exclude people who've only committed makefile and man page changes. In this case, marius, davide, and jmg look like good candidates. After your patches are committed, coverity will update the issues automatically on its next scan. It currently scans once every 2 or 3 weeks. -Alan From owner-freebsd-hackers@freebsd.org Thu Oct 8 18:16:06 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5496C9D1CBD for ; Thu, 8 Oct 2015 18:16:06 +0000 (UTC) (envelope-from scdbackup@gmx.net) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D9073E87 for ; Thu, 8 Oct 2015 18:16:04 +0000 (UTC) (envelope-from scdbackup@gmx.net) Received: from scdbackup.webframe.org ([91.63.124.210]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0Lugbo-1ajkFg40Ke-00zqhr for ; Thu, 08 Oct 2015 20:15:57 +0200 Date: Thu, 08 Oct 2015 20:17:31 +0200 From: "Thomas Schmitt" To: freebsd-hackers@freebsd.org Subject: Re: What to do with triaged Coverity complaints about makefs ? Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit References: In-Reply-To: Message-Id: <3250582195207722079@scdbackup.webframe.org> X-Provags-ID: V03:K0:Uj1U+Fb9WtVTAZdycdR9+YbOpn3HXv/tAaQL/1dGhqvQ0tYisAA meDyfjKII2BuSJ8YXzIBYcKRhSdcOq/CkA8gokCKCq0YAWSKymXdGLRO8mg6Y4nc/69TrlW 7M3zbaE5VfU22LXTCCCVXuRqM/a8kzx7LLQsxMGkP70PxN8wVkC02PtrvmaH3pIvOo0sxWB Y6p/8UR6uebmtLq7RhPBQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:a2sz1skoU+8=:XPPjNEf43bo+QCgQRiBku8 u/yS4L/b4xUCyRQIEYqotTRaikF7J0JHbVL2fbZsGpxjGosbStZsdVU2xvxIEeaWCV8pvrckW 1wTzzN5EjndZl5MBOfEJPrroy7Bl32qOiPmlvr2GaielkO7GlYkBF0EFj/9SLRfonYQGI04r7 xvp77Zz6FdK7U8CxoRWzpcb7Y8dqHOzxiNBKDO57KAkgS5L5rTw6jruSGGe4RDlvwp7oA/ZAl Rnpxqaq0W5e0vmP5LX2Jw5gB0vrXs4c0sTLn2aKLF9aJUDCKEGjr3I8dom93QfOVH+MvM5eMi w1kunR5pRnvvQmZaXM8Ih+o6IMGkL2rILyps4gj3uUhyRwQuJX8zjKCGD2nWBKBJBAbfwf8Cj sRZCg5tO6Ly5Qirw+FpzExRvWV8Bhei044bE8Ton5S3/dsvMyIpJl6V/YlGjp58TixalADN2e kgCQrRy3G8uY7QeNG5CWCh7pXo0Q9Q3kIX1EYQfM7dfWT1DCGLtaByilGD/SQbxOvdBNpT1K5 +m4S6yb98VHSQWYJ5S+Hnza924Yh7HsMgggRWTfeNd/FUVKEfTvrjERiJ3ewXaYHzCOEasx3W AuFYcbbTIwCuMPF0v9NZHTRNUiVq8UMtHaLjp/Yw9aqlPBgW5kC4Gzqklw0T1gEAvsd8vuK3H NWNtlUuDsZoVxI39Jk9IWrDZQsf2GpqQlah5yGE0VvX4pHnDCNapuD6l2T01btlsa0u/K5GIs Jdrrm7Xupl8etNi/FLdW0wA3ZjSoiQ2+/EoVL3mOxkxEUDIFkmju2y0Do/UJEFDLfnrCLcxFn pLOnfp5 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2015 18:16:06 -0000 Hi, Alan Somers wrote: > Filling out the Coverity triage info is good. It seems that i am not authorized. The "Apply" button is greyed out even if i choose menu items and fill fields. > Filing PRs is better. So i will have to leave out the good and do the better. My own complaint list is available now. Oweh ! I already fixed 5 stupid memory faults in case of error. 66 more untriaged. (This all went through extensive regression tests with valgrind.) Have a nice day :) Thomas