From owner-freebsd-hackers@freebsd.org Sun Mar 25 01:58:54 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2763CF62829 for ; Sun, 25 Mar 2018 01:58:54 +0000 (UTC) (envelope-from f0andrey@gmail.com) Received: from mail-oi0-x243.google.com (mail-oi0-x243.google.com [IPv6:2607:f8b0:4003:c06::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B20666C682; Sun, 25 Mar 2018 01:58:53 +0000 (UTC) (envelope-from f0andrey@gmail.com) Received: by mail-oi0-x243.google.com with SMTP id q71-v6so13357853oic.6; Sat, 24 Mar 2018 18:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Dol4HHBRe3MnEmJX1/CZFnoTWA70G6bAXPsIw0/NSLk=; b=nZ5nro0MYezkQqiZMw0PcjYgbOmU84ZtKLS6kmmnMadEFQ4e8SuFTONYn1Gr9lIo48 7vyOLkvv/t7tsZSrph3A+IbpnzMGsw8kdkxmL89b1VIAP7Erfkr8cDopKFraxtRMC2Yd NDXl+eJ+EevoXgEauyg7N5ciEJ9DWX4VaxF7ghSp6A9aAtZ6lN9+9/002qDRG/SRUCI5 A86wvLFKQyS1lDjVQ3IHxUZp3ff1Git6SJfnjIc++yiT0ezwEHyHqO5FRCpQPY48m4+8 onjdcF2j5EnHfteFgzhiBOO+cQ9edqTI/71s6pMYJ/EnuUBhhfFHf7QACDBHwOXL+n99 VdEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Dol4HHBRe3MnEmJX1/CZFnoTWA70G6bAXPsIw0/NSLk=; b=IwkDLSnQxKwxsZwHy3p4LpDYjsdCugxeVOtIoum2wOFNS6PgtyvXjBTGilKYF+hw0z QcJOBhYadB8PrNL6vW3MNbDlIPMXJa8nXorJuOt1sSt1TlQRVAmLOsCObqI2D7J1mY6R GmGmobczqhW7KaHfdVr/b+izCzWJjG173DhZ3xeqCYQssXKNey4qpg3ErPFrbGQ7SwJH gqDROeyAyZTnVO1/IX1yYltHHFU2YqsininI/Z/QuW2Wh9SIiHF4WFvPFhOlbW8cGiQF 1CS7i/D9SHWonIYRY6GIK2SLPNvYcUXvqDPQS0CQXVixttCZGu6xJdZOrAtnmJtGdbYs W3ew== X-Gm-Message-State: AElRT7Fr4VQZcBAkvOJnkMH7yMnAeMfsIMOd+V7RUPbcqwf/qqOXYnDB PcHkCTo9u0MooNEMdw7j23bWfsS0ITPiGcX46q4= X-Google-Smtp-Source: AG47ELtAtjSFYfKS6LzLiRXsOahdLW3eaGuZqnUV6i2I1dj23fDaOwV4fGeoWSOv+eTAmJ09jTjnGA9uE4Z68i91VgQ= X-Received: by 10.202.229.11 with SMTP id c11mr19002432oih.193.1521943132977; Sat, 24 Mar 2018 18:58:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.35.205 with HTTP; Sat, 24 Mar 2018 18:58:52 -0700 (PDT) In-Reply-To: References: From: Andrey Fesenko Date: Sun, 25 Mar 2018 04:58:52 +0300 Message-ID: Subject: Re: [GSoC] Proposal draft on "Dual-stack ping(1) command" To: Tongbo Zhang Cc: gavin@freebsd.org, freebsd-hackers@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Mar 2018 01:58:54 -0000 On Sat, Mar 24, 2018 at 4:08 PM, Tongbo Zhang wrote: > Hi all, > > I am Tongbo Zhang, a graduated student from Jilin University, China. My > major is Computer Science and Technology. This year I'd like to participate > in GSoC 2018 with FreeBSD on project "Dual-stack ping(1) command" which I > think I am capable. > > I have read some documents and articles to get familiar with network > programming. I also browsed the sources of these two commands to find the > starting point of coding work. Recently I finished the draft of my > proposal, and I really appreciated it if you could review it and give me > some advice. Thanks. > Are you see previous attempts? GSoC 2015 Task: Unifying ping and ping6 https://groups.google.com/d/msg/muc.lists.freebsd.hackers/43dwsiWHleA/d4c9Us_4hXgJ From owner-freebsd-hackers@freebsd.org Sun Mar 25 04:29:17 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0D34BF6C1F7 for ; Sun, 25 Mar 2018 04:29:17 +0000 (UTC) (envelope-from jmaloney@ixsystems.com) Received: from mail-qk0-x229.google.com (mail-qk0-x229.google.com [IPv6:2607:f8b0:400d:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A6675727DE for ; Sun, 25 Mar 2018 04:29:15 +0000 (UTC) (envelope-from jmaloney@ixsystems.com) Received: by mail-qk0-x229.google.com with SMTP id o184so16914743qkd.13 for ; Sat, 24 Mar 2018 21:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ixsystems-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=VfTLlZlkhiWIMhlxpxDXMe+mAOl1SDRJlPgmLVdAjqM=; b=FC+pLQ216mfMzE4Ea1JJ7xGFTmWNRQs7PXIdbhPxI/TmtX32VQeTftPCNuGpoQwI2w L2GwHEdUb8V5lVWQ2cR1CJCl1x494U+EThal+e3ylSxc9yKVnGC5SsuiUlgEpdk/OheU Ub6CTdkeBakBaqMbYR/UTuZpsg8YN5zskommAeocv6QpiwpwLmGI0CjzLUnXxgm+Ac/f F9Y978xVj3Vg6W5t7/1BYSPrQtYX978+FY9nubbY1I0FcE1tDEgqwdE0H9Eqb12JwnA/ 1YofGhpyp2ZHrL0uvb3pRhvbDwyCH8+A1lcuE43yOmGwWsrOIl7GLMNgIuYhr3cU19Yf j85A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=VfTLlZlkhiWIMhlxpxDXMe+mAOl1SDRJlPgmLVdAjqM=; b=g98fGRvHQTUUZyxtkygYB9QwfeVUMx2Lpttcy+iffTlCaPeUjqXp22qlW1Df7BCtNF qTwFdBWIHcyX2fUKaqxeuNlmY7kZz+ODyeopEouryOT1YlZsKawBHB47MrvVv55FEkcO tne//a+S17kkT1we93TNohUp39IWYvQP/YrB0nbYT5M01DcJm0LfrY1SioUdjQhTNIqn ntY3wwAkMmZCRF3Zhx/t2wpX0gOW0J9UZqEES77LG0ZYhYX4GzOviDA7iRMltMtMJKoe g/38z8Df3WpEjanSbwsqf1kmLxn4HASvNcUdpDezbbYmQsY4SUvN0lTZYNeIraGoWNgK sDfA== X-Gm-Message-State: AElRT7FSmKEsvPAciiCGVPi81tDIOdu/kO9UttqlEdzfufG5aDQjfGbD KI+pgshGK7jJY6gJXl2GnAaXMvh+srgjZljaNqQS/w== X-Google-Smtp-Source: AG47ELs+VIlM6LzkqMLPUK6w79QB9dfzr7tfr6G4SAxcumgm9D2n46K19CU/P6+VmVDRG3SQ0mDPtYArzAWJoFq+1wk= X-Received: by 10.55.22.28 with SMTP id g28mr48650296qkh.152.1521952154905; Sat, 24 Mar 2018 21:29:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.63.119 with HTTP; Sat, 24 Mar 2018 21:29:14 -0700 (PDT) From: Joe Maloney Date: Sun, 25 Mar 2018 00:29:14 -0400 Message-ID: Subject: Re: OpenRC 0.35 for FreeBSD To: freebsd-hackers@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Mar 2018 04:29:17 -0000 Sorry for the delay in responding, and thanks for the replies. Specifically OpenRC just adds a couple of neat things like service supervision, parallel startup, and some interesting features like service hotplug. Originally I had planned to respond back with a more eloquent email covering features, scary things, that had been reviewed by peers with a higher writing skill than a mere mortal like myself. Considering the technical challenges I encountered I feel more inclined to stop here for now, and just wing it with an explanation. TrueOS has a decent (not perfect) implementation of OpenRC with over 1100 scripts for various ports. Those were easy conversions. It turns out however I underestimated how much work it would be to create a proper drop in for FreeBSD that meets my standards as an end user. While trying to deal with dhclient conversion I just found myself displeased fighting with network.subr race conditions. This work didn't even begin to address ipv6 at this point. I also looked at integrating dhcpcd which supports ipv6, and ipv4 into base which TrueOS uses from ports. However this was beyond my skill level to write a proper Makefile for that. For any solution like launchd that requires xml having to write over 1100 in a different format like xml, or ucl vs conversion I think would add even more overhead than something like OpenRC where most scripts just work after a few simple modifications. Then you have base which was over 100 last I checked. While I could see the benefits of FreeBSD adopting something new like launchd with UCL I think the biggest blocker would be dealing with network.subr. Maybe I am wrong but it sure seems that way. When I looked at runit I think it didn't provide the same level of per service management from what I recall but that was years ago. I am more of a sysadmin if that makes sense so I have to back away from the keyboard when it requires reinventing the wheel too much versus planning, and taking on a project incrementally in phases. In short. I underestimated this effort for FreeBSD on a technical level given my current skillset. Otherwise on a political level I would have been have happy to put forth the work in to give talks, have discussions about various options, and so on which I already have at various Linux conferences. The last conference S.E.L.F was very rewarding where I met one of the co-founders who told me a very interesting story about the political work required to baselayout 2 into Gentoo. Prior to that I did not push that hard to get my talks accepted at various BSD conferences because I wanted to wait until I had something substantial, and practice giving talks vs just coming to the table with nothing, and only talking about what is possible. Anyways I am afraid the TrueOS implementation that I helped with is the best I can offer for a more proper evaluation at this time than what I was working on. I can maybe circle back in another year, or so to see if this is more do-able. If so by that time I will be able provide a better presentation with a comparison of various init options based on feedback here. Cheers. Joe Maloney On Tue, Mar 6, 2018 at 7:34 AM, Jan Bramkamp wrote: > On 02.03.18 17:11, Jonathan Anderson wrote:> On 02.03.18 17:11, Jonathan Anderson wrote:> On 02.03.18 17:11, Jonathan Anderson wrote: >> >> On 2 Mar 2018, at 12:13, Jonathan Anderson wrote: >>> >>> >>> [...] there are a number of options that I've heard of vying for >>> consideration: >>> >>> - finit >>> - jobd (is this still a thing?) >>> - nosh >>> - OpenRC >>> - runit >> >> >> Oh, and also s6: https://skarnet.org/software/s6/why.html > > > I've run s6 + s6-rc as init replacement for FreeBSD 11.1 on my laptop for > over a year. The init_path kenv simplifies testing alternative init systems > a lot. It works really well and required only minimal porting. > > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" From owner-freebsd-hackers@freebsd.org Sun Mar 25 05:54:29 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C5448F70934 for ; Sun, 25 Mar 2018 05:54:29 +0000 (UTC) (envelope-from theron.tarigo@gmail.com) Received: from mail-qk0-x231.google.com (mail-qk0-x231.google.com [IPv6:2607:f8b0:400d:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5AB0F75918 for ; Sun, 25 Mar 2018 05:54:29 +0000 (UTC) (envelope-from theron.tarigo@gmail.com) Received: by mail-qk0-x231.google.com with SMTP id s188so17021529qkb.2 for ; Sat, 24 Mar 2018 22:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:to:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=+aDbwjQiirvSqG5ijQyVS/jwOqYMGKSFF2lghsyvVi4=; b=q5rzRhSJawnC+FaDirVaKrmP/zfAp8apoaCMeaZiWHXbjrmjkkUEFa3oMmOkkUwVbj TFiUu1yc7OAaaEBOZt9bpNZS8+n90vM93ZPVFdSy8GdJSzeuzLI8k8y8s6BYv+/XTj6m z5ekP77YuVGvt+2MBNui0Ebu/77ms1XRGGQaX/Wn0iU7r0T5PTUwdjUEaXZcjMnDqwzk WCINF5AVGc9rgb5TTIII9T1j9Fl+04gY66XHBHi4KORdNOl8Jln1immzPVy8wPWUZVMi 1TAfRzmkWdF0WEKD1zPXdXIpIYmxrYQu5DD7+s/BoVv8zm8ie5KO6ghvRCvxoly4M9Vx ExHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:to:from:subject:message-id:date :user-agent:mime-version:content-transfer-encoding:content-language; bh=+aDbwjQiirvSqG5ijQyVS/jwOqYMGKSFF2lghsyvVi4=; b=HcSh6XviB57uUB6vFqHEAL/fjNj567dttRnnT3SLWcz3CK0vjseJpqcxB2/Zl2mS2Z P8l6gi7fIzetpfJXqdHte6UWV1C9cm9eqIXxloEm1vuHyVyiF68HIMYrfpZdYD86enTO Ij57IdPsRPWs541WOP9IhTtgPcr03rK+4Q2SRv2crOmxrAH89l4leY7jXT+YJFzEhcCM Xb/fchQN/KJGMLF+FGyL8rXFB2X6JIqhFU1K/VsCZlpTR/a9tDpKhWV/bsAx93J2IQBA di/TVp2W9jgqr7AUow49wsDehO/OfecqgsTiQea6kBmjdvta4T4sGDb56Gvn6VJNHwRg hl5g== X-Gm-Message-State: AElRT7H2lJrx2JbUC1pFEohL7By5/njJ9BQyl4XyWcDoEi4x2VUNi5SU 0W75rmUCfgXT962cTjWnmt7nWJb7 X-Google-Smtp-Source: AG47ELvjKC3PYEQRK6juY6xjaTNRO8rJpAll6L7bkhDHRzmr3hEMLoQWznVoZiWgeqUgqjdPdD/MpA== X-Received: by 10.55.7.5 with SMTP id 5mr50137350qkh.290.1521957268585; Sat, 24 Mar 2018 22:54:28 -0700 (PDT) Received: from [168.122.12.186] (dhcp-wifi-8021x-168-122-12-186.bu.edu. [168.122.12.186]) by smtp.gmail.com with ESMTPSA id t36sm9244738qtd.69.2018.03.24.22.54.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 Mar 2018 22:54:28 -0700 (PDT) Sender: Theron Tarigo To: "freebsd-hackers@freebsd.org" From: Theron Tarigo Subject: GSoC Idea: Fakechroot on FreeBSD; Ports building in clean non-root environment Message-ID: Date: Sun, 25 Mar 2018 01:54:27 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Mar 2018 05:54:30 -0000 Hello All, I am an undergraduate a Boston University looking to contribute to FreeBSD this summer under GSoC.  I made a posting to this list last week about an idea to implement per-process namespaces, but I have decided that this would be too big in scope for GSoC and I have decided instead to revisit a more manageable idea with similar motivations. The motivation for this idea is to provided a way to safely and cleanly build ports without superuser privileges, jails, or touching the installed system in any way. The project would consist of two parts.  The first would be to write a utility providing similar functionality to the "fakechroot" already found on Debian GNU, but compatible with FreeBSD's libc. This utility would intercept calls to open(...) and related libc functions to emulate the behavior of running the program within a modified file namespace, but without requiring any special kernel functionality or superuser priviliges. Once this first part is out of the way, the utility will serve as the basis for a ports building script which is free to operate independently from the installed system.  One particular improvement I would like to make is to provide a command for fetching and installing (into a user-owned path) all build dependencies for a port from binary packages, saving space and time that would otherwise be needed to compile these from source.  Using the path redirection utility, "/usr/local" can be made to redirect to the user-owned installation, allowing unmodified binaries from the official package repository to function.  Furthermore, with such redirection of the PREFIX directory, binary packages may be built with the correct paths such that they may be later installed system-wide (by root) as with binary packages built by the existing processes. The project would consist of a few related small, manageable parts, therefore a proper proposal will be somewhat lengthy, although not representing an overly complex project.  Should proper integration with pkg and ports not be achievable in time, the path redirection utility itself and consequent ability to build ports within a clean, non-jail environment at the very least would be useful deliverables. I have several years of experience with programming in C and have previously implemented library function call intercepting tricks as will be needed for the fakechroot part of the project, so the approach is already familiar to me.  I have been a user of FreeBSD for the past two years and successfully maintain a personal system running CURRENT with a mix of installed binary packages and builds from ports, so I have familiarized myself with these parts of the system and have encountered some of the gotchas to be aware of.  I have previously performed an experiment in which I successfully built a working package of unmodified x11-servers/xorg-server without superuser or jails, which I accomplished through modifying PATH and LD_LIBRARY_PATH and with some other hacks.  However, I believe that due to limitations I encountered with this approach, a generalized file path redirection library is a more appropriate solution. Please let me know if you would be interested in mentoring this project or can suggest someone who might be. Thanks, Theron Tarigo From owner-freebsd-hackers@freebsd.org Sun Mar 25 07:56:25 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A87FEF5307F for ; Sun, 25 Mar 2018 07:56:25 +0000 (UTC) (envelope-from ztb5129@gmail.com) Received: from mail-qk0-x235.google.com (mail-qk0-x235.google.com [IPv6:2607:f8b0:400d:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 265EA799CB; Sun, 25 Mar 2018 07:56:25 +0000 (UTC) (envelope-from ztb5129@gmail.com) Received: by mail-qk0-x235.google.com with SMTP id h14so17111223qkj.11; Sun, 25 Mar 2018 00:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=otCYpVyIijsjAii7+cZf3ObvPrIvMgc3XdTHtASbtd4=; b=t691JhqzbjlpeAmt2arnrr1l6JV5CswdZiuftDp7DpDdi4y3LPGskLC7aExmkO3jjp lp+R2KBK3EM/vv+w002rCNnVcPOKPgq2G9SHwi3rdqmcTgybdGm2bb6GE1ctfC9grs+4 RaqKmhZb8Ebq+zVzE0LHMGenKLAMrhzzp/UFkBKthetCp5H5O93QLsA3igDZmUH0nHYp ZwpKmwPHNtGcewpnXw6/NTJ7Ul+PBLMpGMo85o3qVVIu2xCGeATm1D+BcF1ZO/P9l3TI 17ejsao6inVO74dRqq6UXlMFK9KYKUsjsyUYitFT189cmSmYwdmdDab1rKr1/sfv2g4r Mdmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=otCYpVyIijsjAii7+cZf3ObvPrIvMgc3XdTHtASbtd4=; b=QVn408o5bXppr80aLPIrUpkUFVgNwNlZqCmBvEYiGCQNC5jA1ydwmSFLilqa2VPbYm SGBuLWkJRXhilCAo1caPJeMqqyyJKA9VypQ4weMfwbBi3cS5U919/EAKCcmamTtcL4hv eQuqzCD1NIOouqtCQLtBoeD9amSaelr38C5j+SIchmQN+Uw0jlrrfTinaKvKVz7vr/SX w+gQ1SwkGWaNvtI8GCwTRXCc3spOICc4efJ8FQNcPQUmEnnBwMdHLF9uwX9/hAVuadIZ FJMEzqIU6NQ2890h7n7kNSEVxNY4tszRHfd1kATLXzKrtlRGxCrGQMXAxZI4maAt4JJl rYnQ== X-Gm-Message-State: AElRT7EDQP0LmQj1vK2fp3nXu+wuOuekYuXmkY+W9rUNsMZgz3l3PHoa euC0XRrVZG/of6CwxE2HSHlA1UXPwNlmbob9EQ== X-Google-Smtp-Source: AG47ELto1jf5o+P4u6uFeCZQt4W7o6hCSwUhzcF7Nh+35LgYHMKHXHGcHVd8o9CLJv4E40xr7Adyce9Rd1ZQEMFO244= X-Received: by 10.55.185.69 with SMTP id j66mr50405791qkf.216.1521964584648; Sun, 25 Mar 2018 00:56:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.19.201 with HTTP; Sun, 25 Mar 2018 00:56:23 -0700 (PDT) In-Reply-To: References: From: Tongbo Zhang Date: Sun, 25 Mar 2018 15:56:23 +0800 Message-ID: Subject: Re: [GSoC] Proposal draft on "Dual-stack ping(1) command" To: Andrey Fesenko Cc: gavin@freebsd.org, freebsd-hackers@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Mar 2018 07:56:25 -0000 Hi=EF=BC=8C Thanks for your reply. I have followed the link and browsed the previous FreeBSD GSoC accepted projects but I didn't find this one in them. I'm confused if this project has been finished or been cancled? Best regards, Tongbo Zhang. From owner-freebsd-hackers@freebsd.org Sun Mar 25 18:01:56 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 192AAF5EC95 for ; Sun, 25 Mar 2018 18:01:56 +0000 (UTC) (envelope-from marklmi26-fbsd@yahoo.com) Received: from sonic304-22.consmr.mail.gq1.yahoo.com (sonic304-22.consmr.mail.gq1.yahoo.com [98.137.68.203]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 95820711F8 for ; Sun, 25 Mar 2018 18:01:55 +0000 (UTC) (envelope-from marklmi26-fbsd@yahoo.com) X-YMail-OSG: cgo82c8VM1lzG9I6Ziesmdtdg6LgIzBAmcsBuwyB.jlGra9BE31jEPEnwNkuoOv HqLXv_WIMSRjzHJD3y3rJESTzYIyh33wWrUUL6u248mV4yMogA180xavVtiGkadFWNS6EjcIzzm5 CH0aJX2h8ad2pQ7L7iixXQg5ti8h3oGKKPBA.MoylXAmg.ytGWGQyM1DomNlSGkZTtszp22qCcxG ADcjrTIul2tKJItwz6qRgXsIVNYT4yX0uFsC.9o3QLOFcVa7bUjnSO3HddALIVSxl6Z_jiLmRFhZ eBlv8Arvjn4dylrWl5v4kTlJci_9kxZcj4TdrFsZQjupms5l8GiRov7FBWfA6JepMZ_gOQSIRzYT 3qSH0qX5BWQXzwvulQO0XQKS9ByoFSWGpOsHrAX7WD41bIEevqAiHegTsGIiPXS2AltyxUKngEBy JQXxJkYyvdzufeVxXyN3vaEnVAqzutjW_ApsMQW.7CaZRCsM8mdqvBy2dxO8XQJ45QoGEhl57fQm FNnKSmwvnJQ.Clzq7_Ty70.eyKoGu1Pn3zQ-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.gq1.yahoo.com with HTTP; Sun, 25 Mar 2018 18:01:54 +0000 Received: from c-76-115-7-162.hsd1.or.comcast.net (EHLO [192.168.1.25]) ([76.115.7.162]) by smtp426.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID d9a89e232fcac827685f8dd6e5b8e48b; Sun, 25 Mar 2018 17:41:39 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: head -r331499 amd64/threadripper panic in vm_page_free_prep during "poudriere bulk -a", after 14h 22m or so. Message-Id: <8D9C49CB-957E-40A5-8EB0-D90D8AC02060@yahoo.com> Date: Sun, 25 Mar 2018 10:41:38 -0700 To: FreeBSD Current , FreeBSD Hackers , freebsd-amd64@freebsd.org X-Mailer: Apple Mail (2.3445.5.20) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Mar 2018 18:01:56 -0000 FreeBSD panic'd while attempting to see if a "poudriere bulk -w -a" would get the "unnecessary swapping" problem in my UFS-only context, -r331499 (non-debug but with symbols), under Hyper-V. This is a Ryzen Threadripper context, but I've no clue if that is important to the problem. This was after 14 hours or so of building: . . . [14:22:05] [18] [00:01:16] Finished devel/p5-Test-HTML-Tidy | = p5-Test-HTML-Tidy-1.00_1: Success [14:22:08] [18] [00:00:00] Building devel/ocaml-camlp5 | = ocaml-camlp5-6.16 So I've no clue if or how to repeat this. Unfortunately dump was unsuccessful. So all I have is the backtrace. Hand typed from a screen shot of the console window: cpuid =3D 18 time =3D 1521986594 KDB: stack backtrace: db_trace_self_srapper() at db_trace_self_srapper+0x2b/frame = 0xfffffe00f2e132a0 vpanic() at vpanic+0x18d/frame 0xfffffe00f2e13300 panic() at panic+0c43/frame 0xfffffe00f2e13360 vm_page_free_prep() at vm_page_free_prep+0x174/frame 0xfffffe00f2e13390 vm_page_free_toq() at vm_page_free_toq+0x11/frame 0xfffffe00f2e133b0 unlock_and_deallocate() at unlock_and_deallocate+0xbb/frame = 0xfffffe00f2e133d0 vm_fault_hold() at vm_fault_hold+0x1d04/frame 0xfffffe00f2e13500 proc_rwmem() at proc_rwmem+0x8d/frame 0xfffffe00f2e13570 proc_readmem() at proc_readmem+0x46/frame 0xfffffe00f2e135d0 get_proc_vector() at get_proc_vector+0x16e/frame 0xfffffe00f2e13660 proc_getauxv() at proc_getauxv+0x26/frame 0xfffffe00f2e136a0 elf64_note_procstat_auxv() at elf64_note_procstat_auxv+0x1ee/frame = 0xfffffe00f2e136f0 elf64_coredump() at elf64coredump+0x57c7/frame 0xfffffe00f2e137c0 sigexit() at sigexit+0x76f/frame 0xfffffe00f2e139b0 postsig() at postsig+0x289/frame 0xfffffe00f2e13a70 ast() at ast+0x357/frame 0xfffffe00f2e13ab0 doreti_ast() at doreti_ast+0x1f/frame 0x706d6f6320432041 KBD: enter: panic [ thread pid 61836 tid 101063 ] Stopped at kdb_enter+0x3b: movq $0,kdb_why The Hyper-V/Ryzen-Threadripper context was/is: FreeBSD 12.0-CURRENT r331499M amd64 FreeBSD clang version 6.0.0 (tags/RELEASE_600/final 326565) (based on = LLVM 6.0.0) SRAT: Ignoring memory at addr 0x1b28200000 VT(vga): text 80x25 Hyper-V Version: 10.0.16299 [SP0] = Features=3D0x2e7f PM Features=3D0x0 [C2] Features3=3D0xbed7b2 Timecounter "Hyper-V" frequency 10000000 Hz quality 2000 CPU: AMD Ryzen Threadripper 1950X 16-Core Processor (3393.73-MHz = K8-class CPU) Origin=3D"AuthenticAMD" Id=3D0x800f11 Family=3D0x17 Model=3D0x1 = Stepping=3D1 = Features=3D0x1783fbff = Features2=3D0xfed83203 AMD Features=3D0x2e500800 AMD Features2=3D0x3f3 Structured Extended = Features=3D0x201c01a9 XSAVE Features=3D0xf AMD Extended Feature Extensions ID EBX=3D0x4 Hypervisor: Origin =3D "Microsoft Hv" real memory =3D 115964116992 (110592 MB) avail memory =3D 112847249408 (107619 MB) Event timer "LAPIC" quality 600 ACPI APIC Table: FreeBSD/SMP: Multiprocessor System Detected: 29 CPUs FreeBSD/SMP: 1 package(s) x 29 core(s) (I leave 3 hardware threads and some of the 128 GiBytes of memory for Windows 10 Pro x64.) FreeBSD and its swap are directly on NVMe SSDs, not in NTFS file(s). The M in -r331499M is for powerpc64/powerpc/arm64/armv7 related experiments, not amd64: # svnlite status /usr/src/ | sort ? /usr/src/nohup.out ? /usr/src/sys/amd64/conf/GENERIC-DBG ? /usr/src/sys/amd64/conf/GENERIC-NODBG ? /usr/src/sys/arm/conf/GENERIC-DBG ? /usr/src/sys/arm/conf/GENERIC-NODBG ? /usr/src/sys/arm64/conf/GENERIC-DBG ? /usr/src/sys/arm64/conf/GENERIC-NODBG ? /usr/src/sys/dts/arm/a83t.dtsi ? /usr/src/sys/dts/arm/sinovoip-bpi-m3.dts ? /usr/src/sys/dts/arm/sun8i-a83t-sinovoip-bpi-m3.dts ? /usr/src/sys/dts/arm/sun8i-a83t.dtsi ? /usr/src/sys/powerpc/conf/GENERIC64vtsc-DBG ? /usr/src/sys/powerpc/conf/GENERIC64vtsc-NODBG ? /usr/src/sys/powerpc/conf/GENERICvtsc-DBG ? /usr/src/sys/powerpc/conf/GENERICvtsc-NODBG M /usr/src/contrib/llvm/lib/Target/PowerPC/PPCFrameLowering.cpp M /usr/src/contrib/llvm/tools/lld/ELF/Arch/PPC64.cpp M /usr/src/crypto/openssl/crypto/armcap.c M /usr/src/lib/libkvm/kvm_powerpc.c M /usr/src/lib/libkvm/kvm_private.c M /usr/src/stand/defs.mk M /usr/src/stand/powerpc/boot1.chrp/Makefile M /usr/src/stand/powerpc/kboot/Makefile M /usr/src/sys/arm64/arm64/identcpu.c M /usr/src/sys/conf/kmod.mk M /usr/src/sys/conf/ldscript.powerpc M /usr/src/sys/kern/subr_pcpu.c M /usr/src/sys/modules/dtb/allwinner/Makefile M /usr/src/sys/powerpc/aim/mmu_oea64.c M /usr/src/sys/powerpc/ofw/ofw_machdep.c M /usr/src/sys/powerpc/powerpc/interrupt.c M /usr/src/sys/powerpc/powerpc/mp_machdep.c M /usr/src/sys/powerpc/powerpc/trap.c M /usr/src/usr.bin/top/machine.c That last is because I've modified top to also report for swap: Maximum Observed Used (abbreviated: MaxObsUsed) when it is positive. For example: Swap: 256G Total, 483M Used, 483M MaxObsUsed, 256G Free =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-hackers@freebsd.org Mon Mar 26 02:17:18 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1D03DF5FDD2 for ; Mon, 26 Mar 2018 02:17:18 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-qt0-x231.google.com (mail-qt0-x231.google.com [IPv6:2607:f8b0:400d:c0d::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AB498851A9 for ; Mon, 26 Mar 2018 02:17:17 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-qt0-x231.google.com with SMTP id s48so18119274qtb.10 for ; Sun, 25 Mar 2018 19:17:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=w6yQ/b6FCsJyE3ht7UP4AxpRm9FX90XvCVpPjjIUkwQ=; b=uDVRH4FrQeuh7kWdnN7qNrkI38P/9wBVwQPMFmje2jFY+TBIkg20yggIDK4PF4FtLU Q8xp9H6C9oQjKLlcBDbAGVp9+YmEiG7uYuxdlDjg5+MP3YZGKOikM86/jgAQw4PIMfds v3NlUOCnHdorZeJE97AbV95CufCpUz4EAwqtR7W3ELRvbanvrGhhKeLRESy3KD7lhT3t 7YixXrDJs9imOk/8p9u2197LMY+tRbBDp9ePkl/vYWXr5tnJAayGo/L/kG5xSDlMORH+ 6FTa4J3ox+V5nGjv0wI7eyGOrnqyATkizwywdkZS4AS4phjTa5WYXliClMMjoWxM7KHD PJBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=w6yQ/b6FCsJyE3ht7UP4AxpRm9FX90XvCVpPjjIUkwQ=; b=UNWvf+YjIt7F7/Q8RvtK6wNaYPAPCGn7fxAlWHoGAXYj9IjlejUUMm5swiZOuzAWU7 7E80AjJlu5AoxxKN9cCQZpaGMPD1w0ycW2PIzbJ5jrH56XndSzbp+7C8ygg15jAAuKHG WIUnWLhmmXVWkwXM8AzGz3qtiF36GlRv+hVbOiHA2bLyz5A5WFZ1a4LBWKzr63YovnMb s9OKgXaTolAHnQsLJtVWT0C6AfHk8ToZJenDTNysaxH8U34eLF71Ti2NfpqCd4y+mLmm QdpF+ix3vxm+WvmzGF0MWlCXV8JSKNjvyTZvTKiqw5OOTCrjT2GJazWApe4UIqJwZL4T e2nQ== X-Gm-Message-State: AElRT7HOy+5zwN4Qq2lVK7HKu82dWKxmHTfZsW1hw/dibmQhwGDx79T+ /hwBxtzLiSvWXjPedOE39/NF9MbOba096yJkpfo= X-Google-Smtp-Source: AIpwx4/DYGEuM/PftNXBZKKn2gdpXFKhulHF7J+Gyfh/XmOYpFh0HFrCfG+HwyaGvzYezkT2QC8IWgqzMHdFDbvQ340= X-Received: by 10.237.35.137 with SMTP id j9mr16173355qtc.181.1522030637157; Sun, 25 Mar 2018 19:17:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.81.207 with HTTP; Sun, 25 Mar 2018 19:17:16 -0700 (PDT) In-Reply-To: References: From: Ryan Stone Date: Sun, 25 Mar 2018 22:17:16 -0400 Message-ID: Subject: Re: GSoC Idea: Fakechroot on FreeBSD; Ports building in clean non-root environment To: Theron Tarigo Cc: "freebsd-hackers@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 02:17:18 -0000 Hi Theron, Earlier in the year I experimented with a similar idea, although my goal was quite different. I eventually hit a roadblock that I wasn't able to overcome: on FreeBSD, /usr/bin/cc and /usr/bin/c++ are statically linked binaries. The makes it impossible to intercept any system calls made by the "victim" binary. Would this be a problem for what you're trying to do? I'm not very familiar with the ports build process. From owner-freebsd-hackers@freebsd.org Mon Mar 26 02:29:11 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D746AF60DA1 for ; Mon, 26 Mar 2018 02:29:10 +0000 (UTC) (envelope-from darius@dons.net.au) Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by mx1.freebsd.org (Postfix) with ESMTP id D6B7985AD6 for ; Mon, 26 Mar 2018 02:29:08 +0000 (UTC) (envelope-from darius@dons.net.au) Received: from ppp118-210-25-90.bras1.adl4.internode.on.net (HELO midget.dons.net.au) ([118.210.25.90]) by ipmail07.adl2.internode.on.net with ESMTP; 26 Mar 2018 12:53:58 +1030 Received: from midget.dons.net.au (localhost [127.0.0.1]) by midget.dons.net.au (8.15.1/8.14.9) with ESMTPS id w2Q2Ne8t039491 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Mon, 26 Mar 2018 12:53:52 +1030 (CST) (envelope-from darius@dons.net.au) Received: (from mailnull@localhost) by midget.dons.net.au (8.15.1/8.14.9/Submit) id w2Q24cZn025776 for ; Mon, 26 Mar 2018 12:34:38 +1030 (CST) (envelope-from darius@dons.net.au) X-Authentication-Warning: midget.dons.net.au: mailnull set sender to using -f Received: from [203.31.81.59] ([203.31.81.59]) by ppp118-210-25-90.bras1.adl4.internode.on.net (envelope-sender ) (MIMEDefang) with ESMTP id w2Q24Wbg025760; Mon, 26 Mar 2018 12:34:38 +1030 Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: Testing requested: Hybrid ISO/USB boot From: "O'Connor, Daniel" In-Reply-To: <35FF5A67-B8CA-43C8-B39E-6797066CBD7E@FreeBSD.org> Date: Mon, 26 Mar 2018 12:34:31 +1030 Cc: Thomas Schmitt , FreeBSD Hackers , FreeBSD current Message-Id: <2EE00D68-73CA-4832-8057-54D741BCC5BE@dons.net.au> References: <3373772881814803857@scdbackup.webframe.org> <35FF5A67-B8CA-43C8-B39E-6797066CBD7E@FreeBSD.org> To: Benno Rice X-Mailer: Apple Mail (2.3445.5.20) X-Spam-Score: 2.8 (**) No, score=2.8 required=5.0 tests=HELO_MISC_IP, HTML_IMAGE_ONLY_24, HTML_MESSAGE, RDNS_NONE autolearn=no autolearn_force=no version=3.4.0 X-Scanned-By: MIMEDefang 2.75 on 10.0.2.1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 02:29:11 -0000 > On 24 Mar 2018, at 07:31, Benno Rice wrote: > I think I=E2=80=99ve addressed this in this revision: >=20 > https://svnweb.freebsd.org/changeset/base/331463 = >=20 > And I=E2=80=99ve regenerated the image here: >=20 > https://people.freebsd.org/~benno/hybrid-bootonly-20180323-00.iso.xz = Hi Benno, I tried this image on a Supermicro SYS-5019S-M (X11SSH-Fmotherboard) and = it boots both ways (USB was via a USB stick, ISO was via the IPMI CD = emulation with the Java JNLP applet) The USB way booted legacy and the CD emulation booted UEFI (not sure if = that's significant). I also tried renaming it to .img and then telling the JNLP applet it was = a hard disk image but the BIOS didn't detect it. It also has a 'Web ISO' option but I can't figure out how you're = supposed to enter a URL so I couldn't try it. Thanks for the work! -- Daniel O'Connor "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C From owner-freebsd-hackers@freebsd.org Mon Mar 26 03:54:32 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 60C8CF6731E for ; Mon, 26 Mar 2018 03:54:32 +0000 (UTC) (envelope-from theron.tarigo@gmail.com) Received: from mail-qt0-x22d.google.com (mail-qt0-x22d.google.com [IPv6:2607:f8b0:400d:c0d::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E81ED688DC for ; Mon, 26 Mar 2018 03:54:31 +0000 (UTC) (envelope-from theron.tarigo@gmail.com) Received: by mail-qt0-x22d.google.com with SMTP id g5so7122714qth.7 for ; Sun, 25 Mar 2018 20:54:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=LBOwB1I8MMVRGNrlOBaiUmFEpI/Sxuej1Vro/GMWQdo=; b=AdtdxU/tMRK6Xv/zqeB/qcExBdZ2l66M/i+hSargWF8JyzHOFzb2tNo6yUZTUNQxuq Q3f593FuVvlzZLdT2BiBgfNqEt9C/hRThkspbrA0o4nMDcNPyigyR+hPOY89OMzSuiCm mRJuB1gvEy441uvSG6IF7L9SIeryOPX529Cbu/OT1efVDbj/5i7oKE/sovk44DMYDRzL 48vyskHIOVuDSNq3N/Gz+ulP4geGEU8uq9GHjUgivCR+U0GknxtkcUnAaUwKkrL1U5P9 jpf3zlRYihWDm7yhc4UvrRIUZlOMHuTxUwib+mvYEdf6jet0hibrgE5nLbu0qOGXuRik QlLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=LBOwB1I8MMVRGNrlOBaiUmFEpI/Sxuej1Vro/GMWQdo=; b=J0pQh2tJ+qTM29XMUOtPnIM+b/9OJdluUr5kYvNzEUg1NqGOgh/nwwcSy5Lzc2HGi5 zfyFOKxz5y0thG42wZaaG67aYGE2GGwEYz4ejMXXyOD8q1+VMbkjStKc5DZ4IoQfDMzc E/hi3EyjD6tU6Mwho5sCLFJdNqe/4gMUE1Nkk5183C/gJZIsUiErh7bmVYzqyGbLPXfY VHf2B2uO0LHA+Lo9nIBEoeDOcb/YVeRRjT1m3Gb9QLEHD5vxAiYI0RfY2IH5W9EN+al5 Q1iLo3h8wAzwfMy9b6eD+VFQdAottpepojUCL+3Ae1t2PJxqX0zKyrWn7fiOyDSRYyX3 RP6w== X-Gm-Message-State: AElRT7FFrszPYrj1FcxDas67UI5VPT9WODh/K7VgWTzBgjCewytCafAH NIZ8bJgwVJoB2467nqP7iJaulX1J X-Google-Smtp-Source: AIpwx4+sjEJ7uSZHm4tBI3oJdrT8K/cBBiFrGe++T5D8k3mGUVIow/h1YDireHaj+0gaD5dIsv6mlw== X-Received: by 10.200.81.200 with SMTP id d8mr20896237qtn.1.1522036471337; Sun, 25 Mar 2018 20:54:31 -0700 (PDT) Received: from [168.122.12.186] (dhcp-wifi-8021x-168-122-12-186.bu.edu. [168.122.12.186]) by smtp.gmail.com with ESMTPSA id a12sm10699234qtm.74.2018.03.25.20.54.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Mar 2018 20:54:30 -0700 (PDT) Sender: Theron Tarigo Subject: Re: GSoC Idea: Fakechroot on FreeBSD; Ports building in clean non-root environment To: Ryan Stone Cc: "freebsd-hackers@freebsd.org" References: From: Theron Tarigo Message-ID: Date: Sun, 25 Mar 2018 23:54:30 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 03:54:32 -0000 On 03/25/18 22:17, Ryan Stone wrote: > Hi Theron, > > Earlier in the year I experimented with a similar idea, although my > goal was quite different. I eventually hit a roadblock that I wasn't > able to overcome: on FreeBSD, /usr/bin/cc and /usr/bin/c++ are > statically linked binaries. The makes it impossible to intercept any > system calls made by the "victim" binary. Would this be a problem for > what you're trying to do? I'm not very familiar with the ports build > process. Hi Ryan, Thanks for pointing this out.  This will somewhat complicate the process - the fakechroot component will need to be statically linked into these binaries, which then would need to live somewhere as modified copies to achieve the goal of providing a solution that may be used without modification of the base installed system.  However, the number of these static binaries is small - apart from a few exceptions which aren't involved in compiling ports (devd, init), it seems to be limited to the compiler toolchain.  Within the realm of software provided by ports, "pkg-static" is the only statically linked binary I can find in my system.  Appropriately modified static toolchain binaries may be provided as a port, which has the additional advantage of further decoupling the ports building process from the local base system.  Using the existing llvm60 port might be another way, as these binaries are all dynamically linked, however many existing ports are tested to work with the toolchain from base, not with the one from the llvm port. Theron From owner-freebsd-hackers@freebsd.org Mon Mar 26 13:45:53 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 40B48F6E73C for ; Mon, 26 Mar 2018 13:45:53 +0000 (UTC) (envelope-from mateus@mateus.tech) Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0117.outbound.protection.outlook.com [104.47.40.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT TLS CA 4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5014D7ED82 for ; Mon, 26 Mar 2018 13:45:51 +0000 (UTC) (envelope-from mateus@mateus.tech) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mateusrodrigueslive.onmicrosoft.com; s=selector1-mateus-tech; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8NPtP/HBpE1pkifHn9RQYES9C/WdyUMkHYJwBBuoE8Q=; b=w70HYnpuW2L8g+7UOvrBqk44hxF9CpbOXHhUNH2GhaiaREJLp0JTJfVJA80dGqczvYmO4r27jc5Grm9Gp6DBfngzjt3yvNA2veO6iqfDHbWVVnxuqAPw8u3fFY/yNzg+NBGtPpYoVOR5nBfH6I5dy6RZ+s7rp2Uz5azYSH6RcDI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=mateus@mateus.tech; Received: from [10.7.226.107] (177.20.152.120) by CP2P152MB1124.LAMP152.PROD.OUTLOOK.COM (2603:10d6:101:1d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.609.10; Mon, 26 Mar 2018 13:45:46 +0000 From: Mateus Rodrigues de Morais To: freebsd-hackers@freebsd.org Subject: [GSoC '18] Porting CoreCLR, CoreFX and PowerShell to FreeBSD Message-ID: Date: Mon, 26 Mar 2018 10:45:50 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [177.20.152.120] X-ClientProxiedBy: SC1P215CA0037.LAMP215.PROD.OUTLOOK.COM (2603:10d6:4:41::23) To CP2P152MB1124.LAMP152.PROD.OUTLOOK.COM (2603:10d6:101:1d::11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 07087dfc-a77c-461d-3c3c-08d5931fe12f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(7021125)(5600026)(4604075)(4534165)(7022125)(4603075)(7168020)(4627221)(201702281549075)(7048125)(7024125)(7027125)(7028125)(7023125)(2017052603328)(7153060)(7193020); SRVR:CP2P152MB1124; X-Microsoft-Exchange-Diagnostics: 1; CP2P152MB1124; 3:uBBtNUm2Khf6tdNMQN8Hg/cIjmyHZGg1VIicBGMG2T1X25MX1630JoSzqtMC2anCxIBRY3dHIZabLLZhheYTEnszICVEvFVMx7B8HfDDjtyPu8hTO7ahQcT3b5VZxtCn0mcXJbBL1d5p59P/vnzq9EifDRxXgDsqSH3WhbuSYgXmy1KetTZZm4Ll0mf6FtZSCNSlIgp+FXznZlB6B8Vrb76I8mGpU3l3Ft4h6/BxD+f846JsVsEEdjDRE37cV2dn; 25:0yegN9OW6EQZjJfxwugL7QsXVodJOYeB1g8C2XZPggYG5RH8epLPJqyjZ/CBIudZh6H/cYRZBndqh8ZTdkwHzUcwR03LlU7oqHaiSFnpubgkJiPhNDiw3Il7nvirtyEkxTqGoYkSW865vQObCgvd2KGOkWVhBAa3c9E8pRPqQrduLgvBr2JusXCCNPjjCLcDIzu+4DpO+resdGN7yvkQ3YVM/zDJs9OinLu5keV8xST1WS2K0X35mU1+usoeW/EAcQJq81Z0QzR44/4z6SPsCSqNF785zsuBdoq90SLaIyDZqXmES5mhut3tLW+9frpXZYsqc3xTi53pRSzV2Ik/7A==; 31:mGa1AqU3llGfPrxSYbDdH7lY8RRZInaH5fkWFxQ5WXnavUysXifHp3AU+GYMFWVjgnRM26iRCZMmBsl87ay3NdKU/ShNZtKufoX2RjjJmBd2kz5CTZ94VPf0RWxayNSKLMHRNaXxWXo93S6MjK192QZ5YGxqi+nscm5m3+7sRyI15qkLGVSHrYWzRAiriBnDLhc+LVzKT2Fmt9sRGFJMnmYs+xiLw9Qt6WVdmimuxrg= X-MS-TrafficTypeDiagnostic: CP2P152MB1124: X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231221)(944501327)(52105095)(93006095)(93001095)(6041310)(20161123562045)(2016111802025)(20161123558120)(20161123564045)(20161123560045)(6043046)(6072148)(201708071742011); SRVR:CP2P152MB1124; BCL:0; PCL:0; RULEID:; SRVR:CP2P152MB1124; X-Microsoft-Exchange-Diagnostics: 1; CP2P152MB1124; 4:qJqCEd8527TsA7AQ8wvb14tjQvrcNBGEfw7C+WZkemBImRfZ6Cn5W0TeznvdD+Q0rjf3pmf9g6+o7ngiDpzivpBdy6tXGEzccphBooUI7mmL7bcbYOLMX1oFKnSyGXYhaqMi/QuO7D/1OtDzks1cx0G7xwp/N+kpmnROFEW/E2+f4W9ml6feI478SpL3tM/IpeBLt1oNddtSLJBM7pTpm1yKgPY0Oa2hc4WAV43oZeDksVeBP/Dhs1gKy0lM7w42zcR3xMoYWrZBurZU+mYUnQ== X-Forefront-PRVS: 06237E4555 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6049001)(39380400002)(39830400003)(376002)(346002)(366004)(396003)(189003)(199004)(53754006)(504964003)(16526019)(77096007)(81156014)(81166006)(5660300001)(186003)(6486002)(8676002)(68736007)(50466002)(64126003)(53936002)(2361001)(2351001)(6306002)(31696002)(65826007)(55236004)(26005)(6916009)(6666003)(65956001)(31686004)(16576012)(67846002)(66066001)(25786009)(23676004)(2486003)(478600001)(52116002)(52146003)(3846002)(2906002)(97736004)(58126008)(47776003)(316002)(65806001)(6116002)(45080400002)(386003)(36756003)(966005)(305945005)(7736002)(59450400001)(8936002)(86362001)(2616005)(956004)(105586002)(230700001)(106356001); DIR:OUT; SFP:1102; SCL:1; SRVR:CP2P152MB1124; H:[10.7.226.107]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mateus.tech does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDUDJQMTUyTUIxMTI0OzIzOm5jOFB0cWxicjZSNmM0RkZzMStHMi85SmQ2?= =?utf-8?B?OEVPWlRFbDd2UXQxdm5uSlVJOXNoRkN0OXhOS2VSNmdaU0NHbnplUXdzTXAy?= =?utf-8?B?OUhvNVRhODhEbUFDb0ZMODEyNlZiQ1k1ejVmcHE1YkhzR3QzWnFFMS96V1F1?= =?utf-8?B?cVQ4dWpuQWxhZ1JVRzk3WHBHRkszRFgyNXhJcytsUnVBUXh2Qy92cXhWbDZx?= =?utf-8?B?T2xybDUrSXhJUTFBQlhNMjIydHpqQU56Q0JCMno1ZG16Z0Z1MVpBOHZMS2RQ?= =?utf-8?B?WVpNOWpBSGk2TzkzN1hBcjBucmFkWlQvR01xb2hHczFlblZiOVRncjJLT1Za?= =?utf-8?B?STJxR0J3OTFnQitjVGdWVmFtaDVNanZJVU5XeDhwY1pDTGFrQ3psdVJaVmpB?= =?utf-8?B?WFR0Q2w3K3FwVzhuZ3FBU2toeXRQZjlQTTJXanJsUGZCVy90QlMwZmVQc3p0?= =?utf-8?B?dlNDTGExYWExbC9SUThwV1N6UUlhT21UMnpLc21JaGlPWFdBcnc3YlhUWDZw?= =?utf-8?B?UUNGdXpBc3hrTDlRWWZHTzF0eFB0NWdMQVJwZ3B5VUxLTWFwcExMcG9SUU05?= =?utf-8?B?b0NGUWxjbHNzWlQwbHJrRkoreVhGZlRjSWJVd0swVGRUQW11cTdKaXBhWXli?= =?utf-8?B?YzBZb1diK2RVeVFsYkVZdDVQS0hNZCtpTjRET1J0UkxFUmJPb1d4TktHWUdY?= =?utf-8?B?cStXRWZuY3pJb1NvUU1MU1ZvU1dnNm5KZEMyVXZKSXFXcDBLYk5UVXRmNHpi?= =?utf-8?B?VnVoSzZ1eG1Ndy9RRGtqK1BRTzRYWVB0ZVJKRVlFKzhHbklPL0R4amxiY2dG?= =?utf-8?B?WENqT2w3dENDYmZUSE1KZ3ZPN0FncHV4YWRYbE5FZGprd0lzU3o1eFJpVTJi?= =?utf-8?B?RWtEdmJvN0R2RUkydXB2ZEZ6Uk4yclZnK1huZWw2bU0wY1NmbnBqbjBNUmx5?= =?utf-8?B?NVZTbGtTU2x4LzMzM3ZPdnpnbFBqS1poZ3NwYkErZExGK1hmZFdZTHBONWM3?= =?utf-8?B?U0dPdE5YNkk4a0JHU0N4aTVUZGRKN3l2YkloMXlyTlFJL2lLYS9IMG56cCtF?= =?utf-8?B?M2YxMDJyYmRMUDBId0YxNHBOUFdjMWovQTZicVBvcXRHbHh1NlN5eUpmMU5Z?= =?utf-8?B?YVZWcVdPVFMrbEsxdVRzNFk2RHpidHoyeFp4bjRWM3RDZHk2bWJhQmJqdkRH?= =?utf-8?B?OTlPaDVYV3hPYVhnUklPdmNOeVY2UElvRVlJdmlma0FCbStheGlpT0FpMENJ?= =?utf-8?B?ZFFWdG9ya1BScnBsdkZaRHVEbUEvS2pLSHVMZVNhNkIvWXBVRTJSa0t1Q3lM?= =?utf-8?B?YmtralZ1eExmbk9sYVpqNStSaFF3TWRqU1JkcU1jUWN6a29JVG9BNk5YSitZ?= =?utf-8?B?MDdvNmtSS2tLei9nV2Yvc1VUeWV6K0xQZVNvdkMzZFVoOThWRWF3NHFMZHZj?= =?utf-8?B?YnhkSEN2RllnQzRudGhBZldmUGN1a2pBUlZ1M2VGSGwrKy9hYTdVVWNXaUxj?= =?utf-8?B?RVk4N0w2MDZrU0RQZDM4cEVkc2VzRkRiVEVSc3c5Z0hiUjNDSVJUSjlZVm1J?= =?utf-8?B?TEFNenI3bktURUdBdzN1TWZGYkFIQXRhTHNqK3g2Rnp3RUlxdlBqeHMyaVJw?= =?utf-8?B?bW0rZnJPU2xHRDlwWThVOWdHYjRON0l4Y0wwL1hKMkM1a2lHYjB1dlR3ZU4x?= =?utf-8?B?MGVaWE5adS9KMXk5K0FIZGhWQTNPem4rUXBxbjhWQ1FEdVBjSStIRGIxeStH?= =?utf-8?B?dU5oclJEVE9hRzhWM0c4RCs1ME9WV1V6QmZqNll2eVhJeXkvQitISGcvNXlJ?= =?utf-8?B?ZWtJK3BsdWhTazBMN3dxNFhmV0RZMzhNRVU0cUNMc3YwTkp0MmdJNHhjMzI0?= =?utf-8?B?MndYK1Y0SnkvSFF1aU5oZmNWU3kyVFRIVU5Qamk1TW8vZ2ZjNGZIa21vN1J0?= =?utf-8?B?ZXBoMDc0dTArWGJLejFIVXh2TWNuYkR4MklkRDE5WExjQnE0d2NnQTVHWHln?= =?utf-8?Q?vPU/DS?= X-Microsoft-Antispam-Message-Info: IX5rxJsW6FMumjcjVXYoROu0S0e6lmwt4san9wBEuqMR22nL2YnID5sWWW+fHnF0G4TpVFJfYFS6Ih9waSifyRmMqTCDneVyzO7GNeQgV+rYOCHal8poIw7kXxicofRd/N83DQZmX3C3nnhh26jmC28ER18iask5/Y+II9xtJAxL4/iJAOLJPKxDYnaqyQrN X-Microsoft-Exchange-Diagnostics: 1; CP2P152MB1124; 6:gnDJg2GlsYMrjQhpihL/f0hYxyfhahAC2lKn7vvDQChADSkQpBTM/6DbQMw4yXYC5LPeeCeuF9iFALzlyOM6/E3nGfPo2iMSA3Qy1QjQ2Tf7gCQFEJmWUwUtqIFFPUMwZEZkRpHmspm+bLJ3u9oDIaHCUVtLo1HwRKQCsnTPWgsMXi0eOhtivCzKL4/psAzX4s756sD1rbnRWx2xrWA1blw8KqjKadBG4OZFkmVo5eANBUM+YgF+qWzDG1PE58sQokxIcoiyjTiEaIFPUg/b/+wS4sA18/Gb+iWve7ew0jCPAeLEfLW79uLIpYpzk2sMQfy/2ZDLxraBi02jMTPJgoYolLVfP0W7oZhQ+3UeFom6EenuUNuvMGwd6ihu/oLEhikgvG5RpmyUK0yt0pPsTH7HSy6hgLqDZIvxG1E+aTB4GuAxpGxFBB83QW1J33HlFXmnVsQ5hr3a7ldoeeqwDQ==; 5:On9zoFohW8KKvpCOj8Ja7kmRJoHbsxGSmOVdtzfCiQaZ7XKwHToKpdVZGyDx55YNp49137Vuy1+cu8r7RGxEu77WPNYK5OjIIVSL2Opn1Ckp133aXYLfKr7NZSsd5P2Jad0A8MOfs3/l7uv3hA+zFkI5spKL/zdfb4a8SFZ/Et0=; 24:qTx42yvY8atGNIpTR594dIWiCz8ZlSs/77hMJt6fYngiW9P9x5WAsj1wWpUXRED9nW40Uu9CPC50DEN91+zIDV7OdwhzzQcGRAvTekAuu0M= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CP2P152MB1124; 7:SPl/u5799VUcX1QVa+441PXG2iPG89Tddj7Wa9OuCgz/fH0M3iYoORFk1EVyFdp3V3bgOJaviUMB9fV8bMR38gjhRbVL55ul+VPf7/y8kyJzsvPQHFGXwz1/e0KcJ7qjzLlGGDQo+I7qrBz+ws59sZbbMZ8YnOw1pjZuqaihSwPgyYdt3qipGCUESu2NpcxtFt6Ap+1g04/7wcESD+uaUWv6noYKr6+eQE1FrW+9k5AbpIJQ/jEbh0tj+2a+jCGp X-OriginatorOrg: mateus.tech X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2018 13:45:46.9057 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 07087dfc-a77c-461d-3c3c-08d5931fe12f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3cb2d6d7-8d6e-44b8-954d-3085729d2030 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CP2P152MB1124 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 13:45:53 -0000 Hi all, I'm an undergraduate at the Federal University of Rio Grande do Norte (Natal, Brazil) looking to contribute to FreeBSD this summer under GSoC. I'd like to follow on this idea (https://wiki.freebsd.org/SummerOfCodeIdeas#CoreCLR:_add_Microsoft.27s_CoreCLR_and_CoreFX_to_the_Ports_tree.) and help port Microsoft's CoreCLR and CoreFX to FreeBSD in order to ultimately be able to run a PowerShell instance on the system. As I understand, there's already work in progress on building the CoreCLR and CoreFX libraries to FreeBSD so this part shouldn't take much time to overcome. The real challenge seems to be on the PowerShell part. I've got around 9 years of experience in the Microsoft stack -- C# primarily -- but little experience with FreeBSD itself. I've been involved with open source for a while and am also a Linux user. I'm looking for a potential mentor for this project and open to suggestions and ideas as to better approach this problem. The deadline for submission on GSoC '18 is tomorrow, so I understand this may not be an optimal time to start a conversation on the subject. However, I came across the GSoC program for this year around two days ago and I'd still like to take this chance. Thank you in advance, -- Mateus Rodrigues de Morais https://mateus.tech From owner-freebsd-hackers@freebsd.org Mon Mar 26 21:46:18 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 49DD6F6E3F2 for ; Mon, 26 Mar 2018 21:46:18 +0000 (UTC) (envelope-from stb@lassitu.de) Received: from gilb.zs64.net (gilb.zs64.net [IPv6:2a00:14b0:4200:32e0::1ea]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gilb.zs64.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E036F75C38 for ; Mon, 26 Mar 2018 21:46:17 +0000 (UTC) (envelope-from stb@lassitu.de) Received: by gilb.zs64.net (Postfix, from stb@lassitu.de) id ACB82247F for ; Mon, 26 Mar 2018 21:46:15 +0000 (UTC) From: Stefan Bethke Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Bugzilla converts patch to CRLF line endings? Message-Id: Date: Mon, 26 Mar 2018 23:46:14 +0200 To: freebsd-hackers@FreeBSD.org X-Mailer: Apple Mail (2.3445.5.20) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 21:46:18 -0000 Hey, I=E2=80=99ve submitted patched for the ports I maintain by copy/pasting = the svn diff output into the Bugzilla attachment form for a long time. = The committer working on = https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226941 noticed that = the patch apparently has CRLF line endings, making it hard(er) to apply = it properly. Working on a Mac with Terminal and Safari, I have not have noticed any = such behaviour. When I copy/paste from Bugzilla into Terminal, = everything works just fine, so I can do =E2=80=9Ecd /usr/ports/cat/port; = patch -p0=E2=80=9C then paste and ^D. When I download the attachment from the =E2=80=9Eraw=E2=80=9C attachment = link (in my example = https://bz-attachments.freebsd.org/attachment.cgi?id=3D191852) with curl = or wget, I do get to see CR-LF. Where does that happen? And is that a bug or a feature? Stefan --=20 Stefan Bethke Fon +49 151 14070811 From owner-freebsd-hackers@freebsd.org Mon Mar 26 21:50:47 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 652BAF6E79D; Mon, 26 Mar 2018 21:50:47 +0000 (UTC) (envelope-from eric@vangyzen.net) Received: from smtp.vangyzen.net (hotblack.vangyzen.net [199.48.133.146]) by mx1.freebsd.org (Postfix) with ESMTP id 11DFB75DF8; Mon, 26 Mar 2018 21:50:46 +0000 (UTC) (envelope-from eric@vangyzen.net) Received: from sweettea.beer.town (unknown [76.164.8.130]) by smtp.vangyzen.net (Postfix) with ESMTPSA id 664305646B; Mon, 26 Mar 2018 16:44:34 -0500 (CDT) To: freebsd-hackers@freebsd.org, FreeBSD Current From: Eric van Gyzen Subject: Realtek RTS525A SD card reader Message-ID: Date: Mon, 26 Mar 2018 16:44:33 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 21:50:47 -0000 Is anyone working on a FreeBSD driver for the Realtek RTS525A SD card reader?  My new Dell XPS 13 has one: none7@pci0:59:0:0: class=0xff0000 card=0x075b1028 chip=0x525a10ec rev=0x01 hdr=0x00 vendor = 'Realtek Semiconductor Co., Ltd.' device = 'RTS525A PCI Express Card Reader' I see that the OpenBSD rtsx driver supports it: https://github.com/openbsd/src/commit/2c295edd2d779a7f5269c2ae901559edbf040016 I don't know anything about SD/MMC devices and standards, and I'm not familiar with FreeBSD's current SD/MMC code, but I think it would be fun to learn.  Does it make sense to try porting this driver, or would someone recommend a different approach? Thanks in advance for any advice. Eric From owner-freebsd-hackers@freebsd.org Tue Mar 27 16:26:51 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 792A9F6760F for ; Tue, 27 Mar 2018 16:26:51 +0000 (UTC) (envelope-from danny@cs.huji.ac.il) Received: from kabab.cs.huji.ac.il (kabab.cs.huji.ac.il [132.65.116.210]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0A3F26F9B2 for ; Tue, 27 Mar 2018 16:26:50 +0000 (UTC) (envelope-from danny@cs.huji.ac.il) Received: from imac.bk.cs.huji.ac.il ([132.65.179.42]) by kabab.cs.huji.ac.il with esmtp id 1f0rKe-000BU9-LV for freebsd-hackers@freebsd.org; Tue, 27 Mar 2018 19:20:20 +0300 From: Daniel Braniss Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: how to add local changes to buildworld? Message-Id: Date: Tue, 27 Mar 2018 19:20:20 +0300 To: freebsd-hackers@freebsd.org X-Mailer: Apple Mail (2.3445.5.20) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 16:26:51 -0000 Hi, I have some local additions which int the past, after making changes to = some Makefiles, etc, I got them compiled but somehow, things stopped working after 11, so I=E2=80=99m now trying = to do a fresh set of patches, and was wondering if there is some docs around on how to to this = cleanly? trying to figure out the *.mk is becoming a bit complicated. thanks, danny From owner-freebsd-hackers@freebsd.org Tue Mar 27 16:42:28 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F39E8F6905C for ; Tue, 27 Mar 2018 16:42:27 +0000 (UTC) (envelope-from lakhanshiva@gmail.com) Received: from mail-oi0-x22e.google.com (mail-oi0-x22e.google.com [IPv6:2607:f8b0:4003:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 87C3770CE0 for ; Tue, 27 Mar 2018 16:42:27 +0000 (UTC) (envelope-from lakhanshiva@gmail.com) Received: by mail-oi0-x22e.google.com with SMTP id e8-v6so6039806oii.4 for ; Tue, 27 Mar 2018 09:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=jgKHS96V+qPpBuV/s7EzniIhg71oCUAYY38RguIkbL4=; b=Q0Yp76QrPTY8RnRLB/S8P8+Op7WfU4q8EFMe4dA8Bncqi6aLWM1GsXqhTRmTZPXSZa 26HDKh/wRyY4KbbkiFUZ9F/t3dGqmOoR+12LZonFXJImFKT+Tuk1hnrI2zj56cw1TE3x PN/pTSPsNEbDmFQRQLIlx9yOkFAYv2qIH5mq8zo1jcNJfukl0BknglJBYo5o5Wun2FRR w9gi91gC19h2JJCw+rh2f3YSwwHFMEjHxA+edcbCzLIqvvrn39N6yTqzxtmMZUbNJLC/ J9NH+V25Ex2PUQkAKT2LQ21P+j+JGOgQjCk5fQpe+c6LV9xAk6jr/gMkZGQUbYl6RKGW rUHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=jgKHS96V+qPpBuV/s7EzniIhg71oCUAYY38RguIkbL4=; b=oO3OkM20il1GYX8YN19vpXdlbonvH9Ov6+QTnvkpYxca9/NkXPxWxQo+AWvbxYRoW0 sCC3y+k3h76Ei4sB4YY85YbS19+78it5lUqrSrXpYZSMiDYsGwNhRa3OJTmqH0pw5DoW 5zqMSrF6rqUrN1C5PxQm5QJvcIxTP3DOMeoqUb8iZZFC4waf1MWoB82jfbsH7vyKVI+b nRXR7LtQl86g4FId7Q9wZ9C9sTt4+nW5nZzpJ5efHqlZybN1mMTcRLyLI7vmjc2njRNo cNNNV1H+JS44e7dlmqpLXzjo3txrW0C7qsaizZj16zuqG+lhejDxqtCUN6gLNZp8rS0U uy9A== X-Gm-Message-State: ALQs6tAh4+FNi3CEww/GZpWKy1xrqZtPmSbXOTodY4GVOQtHuPu77BLr QX2qzoLR0sChrRcpEYPKsHy/zPuPqQWuQwdfCVx85Q== X-Google-Smtp-Source: AIpwx49dnBfV37/EbnO73sF3i7Ur2KOhmmojJgLTxEah6eWBB7gQPtm6/gWTO5c/fQHbIQyVH09F6fRvVW9yX5fvo7U= X-Received: by 10.202.219.67 with SMTP id s64mr23409oig.303.1522168946621; Tue, 27 Mar 2018 09:42:26 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:44a8:0:0:0:0:0 with HTTP; Tue, 27 Mar 2018 09:42:26 -0700 (PDT) From: Lakhan Shiva Date: Tue, 27 Mar 2018 22:12:26 +0530 Message-ID: Subject: Commit privileges and branching To: freebsd-hackers@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 16:42:28 -0000 Hi, I would like to start working on converting PCI drivers that already have a table but font have a MODULE_PNP_INFO. I would like to know more about the branching strategy and the process to check in first piece of code. I am uising FreeBSD VM current image. I will be using SVN for checking out and checking in code from the VM. thanks, Lakhan Kamireddy. From owner-freebsd-hackers@freebsd.org Tue Mar 27 16:47:16 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CFA98F69764 for ; Tue, 27 Mar 2018 16:47:16 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5DC2E71186 for ; Tue, 27 Mar 2018 16:47:16 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 7e35c20e-31de-11e8-91c6-33ffc249f3e8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.eu.mailhop.org (Halon) with ESMTPSA id 7e35c20e-31de-11e8-91c6-33ffc249f3e8; Tue, 27 Mar 2018 16:47:12 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w2RGl5g1061115; Tue, 27 Mar 2018 10:47:05 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1522169225.49673.36.camel@freebsd.org> Subject: Re: how to add local changes to buildworld? From: Ian Lepore To: Daniel Braniss , freebsd-hackers@freebsd.org Date: Tue, 27 Mar 2018 10:47:05 -0600 In-Reply-To: References: Content-Type: text/plain; charset="iso-8859-7" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 16:47:17 -0000 On Tue, 2018-03-27 at 19:20 +0300, Daniel Braniss wrote: > Hi, > I have some local additions which int the past, after making changes > to some Makefiles, etc, I got them compiled > but somehow, things stopped working after 11, so I¢m now trying to do > a fresh set of patches, > and was wondering if there is some docs around on how to to this > cleanly? trying to figure out the *.mk is becoming a bit complicated. > thanks, > danny > If you're asking what I think (you want to add code of your own into the buildworld), just add LOCAL_DIRS="path/to/dir1 path/to/dir2" to the buildworld command line and it will visit your directories and run the same targets there as for standard freebsd dirs (so your makefiles have to have those targets, mostly easily accomplished by including the usual bsd..mk where foo=prog|lib|subdir|whatever. The local dir paths in LOCAL_DIRS must be relative to the top-level freebsd source dir, you can't use absolute paths (but you can use relative paths that take you outside the freebsd path, I think, like ../mysources/project1). -- Ian From owner-freebsd-hackers@freebsd.org Tue Mar 27 17:14:41 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 433B2F6C47B for ; Tue, 27 Mar 2018 17:14:41 +0000 (UTC) (envelope-from nonesuch@longcount.org) Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com [IPv6:2607:f8b0:4001:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CAF4E72CC0 for ; Tue, 27 Mar 2018 17:14:40 +0000 (UTC) (envelope-from nonesuch@longcount.org) Received: by mail-io0-x22b.google.com with SMTP id d7so139875ioc.11 for ; Tue, 27 Mar 2018 10:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=longcount-org.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=sDeFxlhkDVlLkTCH6A9JwHSlQwRQcsRl4KMT/XJqhL0=; b=roDYOEjSGokds98QCXBpEl5uE/rQezlumVHvvNb5MiZj78TAG49eSW++2QrJkpshhA oG45hU9jm8IDVPkTQ+iZuzQfdJJsIk5yI78x7VUfbp/Bw0l9mYP2WwM1Arj6kbSyim50 wWrXUIQcxtc0YqBUC/BKJsC/wNsV8BeVXTos2X2O408yQZiuuy85TMv+X1ySvXP9+n8+ UpPqyrtmQLa1le+n/uDVzsiAyPkrIAc+y27IQochAMPbBehaN6BigGZ76y2yIn7ntZrR hB1Z5kpzmxxY5j/f+tSPxBoJoOZH0/7G/sdxzvevUfbZgEMBfwCLiso5ltGVFogKZx8r mJEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=sDeFxlhkDVlLkTCH6A9JwHSlQwRQcsRl4KMT/XJqhL0=; b=SRFmLDdKlt8BrfAlEN2IL7zBw8J+W+y9H0wc6fl0ub95a4F1eiKlN92f+0fKKOwJum /raguRlFLY8vugUb3XxHrL3H/x0cJL3dvS1IWVhCgx4fgnA6dQJddc+3fc1OkLoYKvJK qXcNjFnYfqe6cGtCW9/bww/9PIo9w46Z+sdRGXCht0gQdKkDa6lT17p0ieViWuzSVX3g 8l3N2fTMNZV24FwYjn6wT26loT+VWfnAzRSFGfMs+6l1f6WJhWvXoDCOS8CkV1YohE1a 8qVyU3VVmNyZZ7ViUyBu5/ovQ23pLqepHzGPxh5/qBiOKcOtBW3iI8zNGCOF6kqytHBf qv0w== X-Gm-Message-State: AElRT7FY3HwGmLq3TiQI+jRqpoCd0H6XtrmUjdOyf5Li122lHhEMlPe3 5boToC1jyQ5lRiipVoo6tNOCvQ== X-Google-Smtp-Source: AG47ELspUUghXBNW1VJ/nx1H64tXoYjHXtzTdLQ4eMMKxx7kK205oZIdU0KyAc+En0MtgXk4YJ9XMw== X-Received: by 10.107.28.15 with SMTP id c15mr46871627ioc.247.1522170880100; Tue, 27 Mar 2018 10:14:40 -0700 (PDT) Received: from [192.168.8.68] ([38.104.68.66]) by smtp.gmail.com with ESMTPSA id s128-v6sm1461854itb.39.2018.03.27.10.14.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Mar 2018 10:14:38 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: Commit privileges and branching From: Mark Saad X-Mailer: iPhone Mail (15D100) In-Reply-To: Date: Tue, 27 Mar 2018 13:14:37 -0400 Cc: freebsd-hackers@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Lakhan Shiva X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 17:14:41 -0000 Lakhan=20 Rule of thumb here is ; first do some of the work and submit a patch . Th= is patch would be on the FreeBSD head branch in svn. See svnlite co svn://sv= n.freebsd.org/base/head and work from there . Commit access to FreeBSD is no= t handed out without showing you can do the work first . Also I would look i= nto who is the maintainer of this code is currently; and reach out to them w= ith your patches when ready.=20 --- Mark Saad | nonesuch@longcount.org > On Mar 27, 2018, at 12:42 PM, Lakhan Shiva wrote: >=20 > Hi, >=20 > I would like to start working on converting PCI drivers that already have a= > table but font have a MODULE_PNP_INFO. I would like to know more about the= > branching strategy and the process to check in first piece of code. I am > uising FreeBSD VM current image. I will be using SVN for checking out and > checking in code from the VM. >=20 > thanks, > Lakhan Kamireddy. > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"= From owner-freebsd-hackers@freebsd.org Tue Mar 27 20:27:00 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0A6C2F56F0E for ; Tue, 27 Mar 2018 20:27:00 +0000 (UTC) (envelope-from gonzo@bluezbox.com) Received: from id.bluezbox.com (id.bluezbox.com [45.55.20.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9ABE07E69B for ; Tue, 27 Mar 2018 20:26:59 +0000 (UTC) (envelope-from gonzo@bluezbox.com) Received: from localhost ([127.0.0.1] helo=id.bluezbox.com) by id.bluezbox.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1 (FreeBSD)) (envelope-from ) id 1f0uTl-000OT4-Cw; Tue, 27 Mar 2018 12:41:59 -0700 Received: (from gonzo@localhost) by id.bluezbox.com (8.15.2/8.15.2/Submit) id w2RJfukW094057; Tue, 27 Mar 2018 12:41:56 -0700 (PDT) (envelope-from gonzo@bluezbox.com) X-Authentication-Warning: id.bluezbox.com: gonzo set sender to gonzo@bluezbox.com using -f Date: Tue, 27 Mar 2018 12:41:55 -0700 From: Oleksandr Tymoshenko To: Stefan Bethke Cc: freebsd-hackers@FreeBSD.org Subject: Re: Bugzilla converts patch to CRLF line endings? Message-ID: <20180327194155.GA93992@bluezbox.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: FreeBSD/11.1-RELEASE-p4 (amd64) User-Agent: Mutt/1.9.1 (2017-09-22) X-Spam-Level: -- X-Spam-Report: Spam detection software, running on the system "id.bluezbox.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see The administrator of that system for details. Content preview: Stefan Bethke (stb@lassitu.de) wrote: > Hey, > > I’ve submitted patched for the ports I maintain by copy/pasting the svn diff output into the Bugzilla attachment form for a long time. The committer [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 20:27:00 -0000 Stefan Bethke (stb@lassitu.de) wrote: > Hey, > > I’ve submitted patched for the ports I maintain by copy/pasting the svn diff output into the Bugzilla attachment form for a long time. The committer working on https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226941 noticed that the patch apparently has CRLF line endings, making it hard(er) to apply it properly. > > Working on a Mac with Terminal and Safari, I have not have noticed any such behaviour. When I copy/paste from Bugzilla into Terminal, everything works just fine, so I can do „cd /usr/ports/cat/port; patch -p0“ then paste and ^D. > > When I download the attachment from the „raw“ attachment link (in my example https://bz-attachments.freebsd.org/attachment.cgi?id=191852) with curl or wget, I do get to see CR-LF. > > Where does that happen? And is that a bug or a feature? I think it's a standard: https://stackoverflow.com/a/14217315 Looks like browser is supposed to convert newlines in input field to CR LF. I just tried it on our test instance \r\n-s are part of a request, not added later. Bugzilla doesn't perfomr any transformation of copy-pasted attachment text and saves it as-is. -- gonzo From owner-freebsd-hackers@freebsd.org Tue Mar 27 20:45:14 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 14D31F59B34 for ; Tue, 27 Mar 2018 20:45:14 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22b.google.com (mail-it0-x22b.google.com [IPv6:2607:f8b0:4001:c0b::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 98D1D7F5F5 for ; Tue, 27 Mar 2018 20:45:13 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22b.google.com with SMTP id m134-v6so927076itb.3 for ; Tue, 27 Mar 2018 13:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=j6+RmFAUDNyqBZM/ZBbLKpKeXB0bDSptton39xERatk=; b=GMTEczzClca7agd1MPrDzTfPEKB4O6cYvPStdA+nXRHhBBjKw9f4tteQ/U1W2zOFE/ w+VFLJGJGhB3wQxwfdhd7GFdWhGXz/pIDzEtAT1p9W/LiNRtRMcoyOzfeBAzLKPPJnjT JVkMvLDAaoGC9Tv2pOTxTAoErWtFyYp/J2lcaIwxpMxWnSCHj/0NwnUGUdpE0hPLPb1U uCTCsaWp+t7KChHwPEjAFEuuuyASy9HNkNiGR60HgnLMDD0slzFzOMnKuMqlQi9oKWrL yTZXqrm4Q8GteCC6H9iBoM8X7+z1bQSBqc6FTlYSNXfU/qMBKnb/+tS/Te5O3pwrOkoQ lxig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=j6+RmFAUDNyqBZM/ZBbLKpKeXB0bDSptton39xERatk=; b=MJKvFZSdxQ4JXmvqkIimOJHBatP+YJ+MvYzlKKmoMtdSF0UxQehu0WRpbdpFIBVE48 e4eORE2e4ufEvlLVuxnW148Lz3bLLJGAoM9PtWHsO81Ed9Jffn/tiAGLug86QGauN1JU qsu03vHGDXsP2MrwfVMHDxSS5z//Xbm6wvkAE/NjEbiwkX6AwgmsQPY8629Co7jVuYJ7 1ZFQHwNwnsbwscFUYSJMfQPKrAmuzVea4S6s58hP0nUYGKwU4W0GPC6oqsgqou8UDxYh ROnAKHU6+O7wQHo7uUc6Dcj0COCw5CLLnzk3+fuCRVLHnZHVw8M8p/PVwvBU5ULbZTsx LfCw== X-Gm-Message-State: AElRT7HO3nEO1ndJJ0lRDAa0O1UX+s5mork82mIsX14rguh5M5x/gi/O 9Cm6g0AoGNe2MbueOM4L6pZH4BDk8K7bwNQY9kM0GA== X-Google-Smtp-Source: AIpwx49zDtI2S5Dj73kMFU48FO7Fm2R8dhlkUBkSfBjJ6JkgZSouZOxv7Dkmh7HUBpiLtLEQD7qMaK6Rbqgc3cPjhBw= X-Received: by 2002:a24:b649:: with SMTP id d9-v6mr832178itj.51.1522183512963; Tue, 27 Mar 2018 13:45:12 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.203.196 with HTTP; Tue, 27 Mar 2018 13:45:12 -0700 (PDT) X-Originating-IP: [192.173.67.1] In-Reply-To: References: From: Warner Losh Date: Tue, 27 Mar 2018 13:45:12 -0700 X-Google-Sender-Auth: YnrpzEcj9y9Y3Y96UvZg3jLJlx4 Message-ID: Subject: Re: Commit privileges and branching To: Lakhan Shiva Cc: "freebsd-hackers@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 20:45:14 -0000 On Tue, Mar 27, 2018 at 9:42 AM, Lakhan Shiva wrote: > Hi, > > I would like to start working on converting PCI drivers that already have a > table but font have a MODULE_PNP_INFO. I would like to know more about the > branching strategy and the process to check in first piece of code. I am > uising FreeBSD VM current image. I will be using SVN for checking out and > checking in code from the VM. > There's two paths forward for you. If you are selected for GSoC, you'll have our gsoc svn repo available. The other option is to fork from http://www.github.org/freebsd/freebsd using git. The way that commits normally land in the FreeBSD is that some committer will push them in with a tag saying that you'd submitted it and when there's enough you'd get a commit bit of all has gone well. If you're doing GSoC, then you and your mentor would work this out. Warner From owner-freebsd-hackers@freebsd.org Wed Mar 28 05:51:04 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EC305F5EC52 for ; Wed, 28 Mar 2018 05:51:03 +0000 (UTC) (envelope-from danny@cs.huji.ac.il) Received: from kabab.cs.huji.ac.il (kabab.cs.huji.ac.il [132.65.116.210]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7FC9076FD4; Wed, 28 Mar 2018 05:51:03 +0000 (UTC) (envelope-from danny@cs.huji.ac.il) Received: from bach.cs.huji.ac.il ([132.65.80.20]) by kabab.cs.huji.ac.il with esmtp id 1f13z5-0000vw-2R; Wed, 28 Mar 2018 08:50:55 +0300 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: how to add local changes to buildworld? From: Daniel Braniss In-Reply-To: <1522169225.49673.36.camel@freebsd.org> Date: Wed, 28 Mar 2018 08:50:54 +0300 Cc: freebsd-hackers@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <539E3F8D-8275-4904-8D19-8FB31C05787C@cs.huji.ac.il> References: <1522169225.49673.36.camel@freebsd.org> To: Ian Lepore X-Mailer: Apple Mail (2.3445.5.20) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 05:51:04 -0000 > On 27 Mar 2018, at 19:47, Ian Lepore wrote: >=20 > On Tue, 2018-03-27 at 19:20 +0300, Daniel Braniss wrote: >> Hi, >> I have some local additions which int the past, after making changes >> to some Makefiles, etc, I got them compiled >> but somehow, things stopped working after 11, so I=E2=80=99m now = trying to do >> a fresh set of patches, >> and was wondering if there is some docs around on how to to this >> cleanly? trying to figure out the *.mk is becoming a bit complicated. >> thanks, >> danny >>=20 >=20 > If you're asking what I think (you want to add code of your own into > the buildworld), just add LOCAL_DIRS=3D"path/to/dir1 path/to/dir2" to = the > buildworld command line and it will visit your directories and run the > same targets there as for standard freebsd dirs (so your makefiles = have > to have those targets, mostly easily accomplished by including the > usual bsd..mk where foo=3Dprog|lib|subdir|whatever. >=20 > The local dir paths in LOCAL_DIRS must be relative to the top-level > freebsd source dir, you can't use absolute paths (but you can use > relative paths that take you outside the freebsd path, I think, like > ../mysources/project1). >=20 > -- Ian >=20 I guess in my haste I was not clear enough :-) my problem is the dependency, in particular, it=E2=80=99s a pam module, that needs a local library. in = the past the library was compiled first, and then the module, now it still happens, but the module does not find the library, which = has been compiled! there is a new piece of mail that i=E2=80=99m missing :-(=20 i=E2=80=99ll try again with LOCAL_DIRS. thanks danny From owner-freebsd-hackers@freebsd.org Wed Mar 28 08:57:25 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 36C9EF6C2CD for ; Wed, 28 Mar 2018 08:57:25 +0000 (UTC) (envelope-from wojtek@puchar.net) Received: from puchar.net (puchar.net [194.1.144.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "puchar.net", Issuer "puchar.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 88D237DD5D for ; Wed, 28 Mar 2018 08:57:24 +0000 (UTC) (envelope-from wojtek@puchar.net) Received: Received: from 127.0.0.1 (localhost [127.0.0.1]) by puchar.net (8.15.2/8.15.2) with ESMTPS id w2S8RTLf015210 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Wed, 28 Mar 2018 10:27:29 +0200 (CEST) (envelope-from puchar-wojtek@puchar.net) Received: from localhost (puchar-wojtek@localhost) by puchar.net (8.15.2/8.15.2/Submit) with ESMTP id w2S8ROZs015207 for ; Wed, 28 Mar 2018 10:27:24 +0200 (CEST) (envelope-from puchar-wojtek@puchar.net) Date: Wed, 28 Mar 2018 10:27:24 +0200 (CEST) From: Wojciech Puchar To: freebsd-hackers@freebsd.org Subject: speculative execution hacking patch Message-ID: User-Agent: Alpine 2.20 (BSF 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 08:57:25 -0000 after i've upgraded FreeBSD to latest 10 that have this patch (vm.pmap.pti is 1) i see vm.pmap.pcid_save_cnt equal to 0 Is it just but in sysctl reporting or something i cannot understand vm.pmap.pcid_enabled is 1 so why system doesn't use this feature From owner-freebsd-hackers@freebsd.org Wed Mar 28 11:43:26 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D1DEFF51E0A for ; Wed, 28 Mar 2018 11:43:25 +0000 (UTC) (envelope-from stb@lassitu.de) Received: from gilb.zs64.net (gilb.zs64.net [IPv6:2a00:14b0:4200:32e0::1ea]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gilb.zs64.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D2128475A for ; Wed, 28 Mar 2018 11:43:25 +0000 (UTC) (envelope-from stb@lassitu.de) Received: by gilb.zs64.net (Postfix, from stb@lassitu.de) id 3C44615787A; Wed, 28 Mar 2018 11:43:16 +0000 (UTC) From: Stefan Bethke Message-Id: <341CBD5C-89AF-4EA5-AD06-A43D267440ED@lassitu.de> Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: Bugzilla converts patch to CRLF line endings? Date: Wed, 28 Mar 2018 13:43:14 +0200 In-Reply-To: <20180327194155.GA93992@bluezbox.com> Cc: freebsd-hackers@FreeBSD.org To: Oleksandr Tymoshenko References: <20180327194155.GA93992@bluezbox.com> X-Mailer: Apple Mail (2.3273) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 11:43:26 -0000 > Am 27.03.2018 um 21:41 schrieb Oleksandr Tymoshenko = : >=20 > Stefan Bethke (stb@lassitu.de) wrote: >> Hey, >>=20 >> I=E2=80=99ve submitted patched for the ports I maintain by = copy/pasting the svn diff output into the Bugzilla attachment form for a = long time. The committer working on = https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226941 noticed that = the patch apparently has CRLF line endings, making it hard(er) to apply = it properly. >>=20 >> Working on a Mac with Terminal and Safari, I have not have noticed = any such behaviour. When I copy/paste from Bugzilla into Terminal, = everything works just fine, so I can do =E2=80=9Ecd /usr/ports/cat/port; = patch -p0=E2=80=9C then paste and ^D. >>=20 >> When I download the attachment from the =E2=80=9Eraw=E2=80=9C = attachment link (in my example = https://bz-attachments.freebsd.org/attachment.cgi?id=3D191852) with curl = or wget, I do get to see CR-LF. >>=20 >> Where does that happen? And is that a bug or a feature? >=20 > I think it's a standard: https://stackoverflow.com/a/14217315 > Looks like browser is supposed to convert newlines in input field > to CR LF. I just tried it on our test instance \r\n-s are part > of a request, not added later. Bugzilla doesn't perfomr any > transformation of copy-pasted attachment text and saves it as-is. That's an unfortunate feature of Bugzilla then, considering that it = offers users to copy/paste patches into a textarea field, and = subsequently allows users to download the patch again, with the line = endings unmodified from the transport encoding. Interestingly, it is possible to download a patch file with correct line = endings by using the correct link. If you follow the link with the file = description as it's name, you get the data as submitted, with the wrong = line endings: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D191852= If you click on the "Diff" link, then download the "Raw Unified" link, = you'll get a file with correct line endings: = https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D191852&action=3Ddiff= &collapsed=3D&headers=3D1&format=3Draw = (This only works if the attachment has been marked as a patch.) Would it be a good idea to add instructions to either the attachment = upload or download page to explain about the line endings situation? Stefan --=20 Stefan Bethke Fon +49 151 14070811 From owner-freebsd-hackers@freebsd.org Wed Mar 28 11:58:28 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 89A44F531C5 for ; Wed, 28 Mar 2018 11:58:28 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from mail.ptrcrt.ch (ptrcrt.ch [IPv6:2a02:2770:8:0:21a:4aff:fe7e:c6be]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ED01E84F68; Wed, 28 Mar 2018 11:58:27 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from mail.ptrcrt.ch (mail.ptrcrt.ch [192.168.1.1]) by mail.ptrcrt.ch (OpenSMTPD) with ESMTP id 52225eb3; Wed, 28 Mar 2018 11:58:26 +0000 (UTC) Received: from ptrcrt.ch (mail.ptrcrt.ch [192.168.1.1]) by mail.ptrcrt.ch (OpenSMTPD) with ESMTPS id 016ffa5c TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Wed, 28 Mar 2018 11:58:25 +0000 (UTC) Date: Wed, 28 Mar 2018 11:58:25 +0000 From: Pietro Cerutti To: freebsd-hackers@FreeBSD.org, sjg@FreeBSD.org Subject: bmake: variable modifiers in SysV include Message-ID: <20180328115825.ydfnbly6hpsvbo3h@ptrcrt.ch> Reply-To: Pietro Cerutti MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dm6dm3xo5ccsc5bo" Content-Disposition: inline X-PGP-Key: fp="DA6D E106 A5B8 54B8 5DD8 6D49 ADD0 D38E A192 089E"; id="0xA192089E"; get=; get=; get=; get= OpenPGP: id=A192089E; url=https://gahr.ch/pgp/0xADD0D38EA192089E.txt; url=https://keybase.io/gahr/key.asc User-Agent: NeoMutt/20180323-25-688f04 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 11:58:28 -0000 --dm6dm3xo5ccsc5bo Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, our make (contrib/bmake) does not currently support variable modifiers=20 in SysV-style "include" directives. See this simple example: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D % cat Makefile Makefile1.inc Makefile2.inc Makefile3.inc # Makefile SUB=3D Makefile2.foo Makefile3.foo include Makefile1.inc $(SUB:.foo=3D.inc) # =3D=3D=3D=3D=3D THIS =3D=3D=3D= =3D=3D # Makefile1.inc FOO=3D foo # Makefile2.inc BAR=3D bar # Makefile3.inc all: @echo ${FOO} ${BAR} % make make: "/usr/home/gahr/tmp/mk-sysv-include/Makefile" line 5: Need an operator make: Fatal errors encountered -- cannot continue make: stopped in /usr/home/gahr/tmp/mk-sysv-include =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D This patch [1] corrects this problem, and results in the expected % make foo bar Apart from parentheses reshuffling, the patch just removes a check that=20 inhibits SysV inclusion if the line being parsed contains a colon (:)=20 character. This has been there since bmake has supported SysV includes [2]. Questions: 1. Any ideas why the check is there, and what problem it's preventing? 2. Anybody with src bit would like to approve me committing the fix? Thanks! [1] https://people.freebsd.org/~gahr/bmake-inc-subst.diff [2] http://cvsweb.netbsd.org/bsdweb.cgi/src/usr.bin/make/parse.c.diff?r1=3D= 1.4&r2=3D1.5 --=20 Pietro Cerutti --dm6dm3xo5ccsc5bo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJiBAABCgBMFiEE2m3hBqW4VLhd2G1JrdDTjqGSCJ4FAlq7g10uFIAAAAAAFQAQ cGthLWFkZHJlc3NAZ251cGcub3JnZ2FockBGcmVlQlNELm9yZwAKCRCt0NOOoZII nlhUD/oCgLjHensB56uaTPF2500pOVg8UzybdrbjgWhSvnEAqzipLc3XqrtTqOXa BFYwGKSjnJGRT13t0Jl0cd+tRJfQZ/ar+VonUUYbm0RW7eJGM7kW1QDg8aoR9Tup lIEtYukWGT4jED/pVj7mHeuPaYh9BtPNaNNTzQZWP+gY4BEohPkl0fMtGHBmNwYE yNUbwF297iRdGPfwBFFCH77t4jWHb9u+wS5MeiUffVw6ITz/wUiE2Qgb3fha85w3 Z8HtxjL5Ju+bTCk8TTsxywuGdAKfCKB5qRNXZQYkYv7bLMWy9RRqYRc5KZTWU3TA rXQAnihodTmgoeHRkmQDIHc9+k4dEz5qze4m2fE44q7fMNSTux7TYRAJ0QOXQKhR GCOF6kEvQk3I/lf9v/gM6CE82InfN1QDinKwnnzus+JE3fwXi6qC80kkuU7yESza JCiOHzOQbafGqtQ1AOeXMsK0VfNTYVS0GabKLkqF1912Kumpmj6H/8ItQKFvXVOp zJoyPOHXyGcFySizXrZsPQ/zEq6PdckBk442AHM3nOh9EvVAKG12T3aaDcJJ6uxK OBcnJkA0rCn5M5O7BQfnTtFCEAOTEfx8babC7axAAx6on0ajN8oaJ14XFegHnmZW AHOLbo70Y6Bt5bJ/7ztMUoWaJrRflJcA6eNx2OGVWQvjDtox8Q== =yFxA -----END PGP SIGNATURE----- --dm6dm3xo5ccsc5bo-- From owner-freebsd-hackers@freebsd.org Wed Mar 28 14:39:19 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 63F32F64372 for ; Wed, 28 Mar 2018 14:39:19 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E940D6E7A4 for ; Wed, 28 Mar 2018 14:39:18 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: afd605aa-3295-11e8-bb8e-b35b57339d60 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.ore.mailhop.org (Halon) with ESMTPSA id afd605aa-3295-11e8-bb8e-b35b57339d60; Wed, 28 Mar 2018 14:38:32 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w2SEd9O9063978; Wed, 28 Mar 2018 08:39:10 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1522247949.49673.54.camel@freebsd.org> Subject: Re: how to add local changes to buildworld? From: Ian Lepore To: Daniel Braniss Cc: freebsd-hackers@freebsd.org Date: Wed, 28 Mar 2018 08:39:09 -0600 In-Reply-To: <539E3F8D-8275-4904-8D19-8FB31C05787C@cs.huji.ac.il> References: <1522169225.49673.36.camel@freebsd.org> <539E3F8D-8275-4904-8D19-8FB31C05787C@cs.huji.ac.il> Content-Type: multipart/mixed; boundary="=-HE4N3m0OyjMXI39S+Zrl" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 14:39:19 -0000 --=-HE4N3m0OyjMXI39S+Zrl Content-Type: text/plain; charset="iso-8859-7" Content-Transfer-Encoding: 8bit On Wed, 2018-03-28 at 08:50 +0300, Daniel Braniss wrote: > > > > > On 27 Mar 2018, at 19:47, Ian Lepore wrote: > > > > On Tue, 2018-03-27 at 19:20 +0300, Daniel Braniss wrote: > > > > > > Hi, > > > I have some local additions which int the past, after making changes > > > to some Makefiles, etc, I got them compiled > > > but somehow, things stopped working after 11, so I¢m now trying to do > > > a fresh set of patches, > > > and was wondering if there is some docs around on how to to this > > > cleanly? trying to figure out the *.mk is becoming a bit complicated. > > > thanks, > > > danny > > > > > If you're asking what I think (you want to add code of your own into > > the buildworld), just add LOCAL_DIRS="path/to/dir1 path/to/dir2" to the > > buildworld command line and it will visit your directories and run the > > same targets there as for standard freebsd dirs (so your makefiles have > > to have those targets, mostly easily accomplished by including the > > usual bsd..mk where foo=prog|lib|subdir|whatever. > > > > The local dir paths in LOCAL_DIRS must be relative to the top-level > > freebsd source dir, you can't use absolute paths (but you can use > > relative paths that take you outside the freebsd path, I think, like > > ../mysources/project1). > > > > -- Ian > > > I guess in my haste I was not clear enough :-) > my problem is the dependency, > in particular, it¢s a pam module, that needs a local library. in the past the library was compiled first, and then the module, > now it still happens, but the module does not find the library, which has been compiled! there is a new piece of mail that > i¢m missing :-(  > i¢ll try again with LOCAL_DIRS. > thanks > danny Oh yeah, libraries... there is also a LOCAL_LIB_DIRS you can set to list libraries.  But looking at Makefile.inc1 it builds the local lib dirs after the other local dirs, which seems completely wrong and useless.  I think the LOCAL_LIB_DIRS should be built along with the base system dirs; the attached patch would do that. -- Ian --=-HE4N3m0OyjMXI39S+Zrl Content-Disposition: inline; filename="Makefile.inc1.locallibs_first.diff" Content-Type: text/x-patch; name="Makefile.inc1.locallibs_first.diff"; charset="ASCII" Content-Transfer-Encoding: 7bit Index: Makefile.inc1 =================================================================== --- Makefile.inc1 (revision 331499) +++ Makefile.inc1 (working copy) @@ -241,6 +241,17 @@ X${BINUTIL}?= ${${BINUTIL}} SUBDIR= ${SUBDIR_OVERRIDE} .else SUBDIR= lib libexec +# Add LOCAL_LIB_DIRS, but only if they will not be picked up as a SUBDIR +# of a LOCAL_DIRS directory. This allows LOCAL_DIRS=foo and +# LOCAL_LIB_DIRS=foo/lib to behave as expected. +.for _DIR in ${LOCAL_DIRS:M*/} ${LOCAL_DIRS:N*/:S|$|/|} +_REDUNDANT_LIB_DIRS+= ${LOCAL_LIB_DIRS:M${_DIR}*} +.endfor +.for _DIR in ${LOCAL_LIB_DIRS} +.if ${_DIR} == ".WAIT" || (empty(_REDUNDANT_LIB_DIRS:M${_DIR}) && exists(${.CURDIR}/${_DIR}/Makefile)) +SUBDIR+= ${_DIR} +.endif +.endfor .if !defined(NO_ROOT) && (make(installworld) || make(install)) # Ensure libraries are installed before progressing. SUBDIR+=.WAIT @@ -282,17 +293,6 @@ SUBDIR+=contrib/ofed SUBDIR+= ${_DIR} .endif .endfor -# Add LOCAL_LIB_DIRS, but only if they will not be picked up as a SUBDIR -# of a LOCAL_DIRS directory. This allows LOCAL_DIRS=foo and -# LOCAL_LIB_DIRS=foo/lib to behave as expected. -.for _DIR in ${LOCAL_DIRS:M*/} ${LOCAL_DIRS:N*/:S|$|/|} -_REDUNDANT_LIB_DIRS+= ${LOCAL_LIB_DIRS:M${_DIR}*} -.endfor -.for _DIR in ${LOCAL_LIB_DIRS} -.if ${_DIR} == ".WAIT" || (empty(_REDUNDANT_LIB_DIRS:M${_DIR}) && exists(${.CURDIR}/${_DIR}/Makefile)) -SUBDIR+= ${_DIR} -.endif -.endfor # We must do etc/ last as it hooks into building the man whatis file # by calling 'makedb' in share/man. This is only relevant for --=-HE4N3m0OyjMXI39S+Zrl-- From owner-freebsd-hackers@freebsd.org Wed Mar 28 15:18:49 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9E495F67EEE for ; Wed, 28 Mar 2018 15:18:49 +0000 (UTC) (envelope-from lakhanshiva@gmail.com) Received: from mail-oi0-x230.google.com (mail-oi0-x230.google.com [IPv6:2607:f8b0:4003:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2F50D70D40 for ; Wed, 28 Mar 2018 15:18:49 +0000 (UTC) (envelope-from lakhanshiva@gmail.com) Received: by mail-oi0-x230.google.com with SMTP id e123-v6so2428900oih.13 for ; Wed, 28 Mar 2018 08:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8r8T83S86t3sXT93zV4TPDwGrE3wVk6lXnkkFLxKvRg=; b=cUAvPrlSbEtMorAsjobVCXzJnTSV+dyk/yzLmfI3Yjx5AgRUWohgB7Ctb2MQCGBKEk 9yooDlq6vmYILyhPvLGYGvm0A86ubp8ARg9FdglGYXN+5iMOO58yfU1C4IdXxjBSOblP Fw70RG3l0mw31JbS/cq2CsGwuFSl9hDg/ZiKJtvtITM3C/uootqdOmsj+HRnz0lJs0Z5 lM7UvBvrwax/H7Vl86+cC5g4ia0N8U1ksAPvBxZIHSA0vhx5sdF5IY+D1cbqs0x5WI/A MAZBthLsn1gm/ykKZG1M8yLss6p77yNdehaQAi9H5GA5klhoJhkoCsfw4g8hgsKYoLG9 3wig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8r8T83S86t3sXT93zV4TPDwGrE3wVk6lXnkkFLxKvRg=; b=rpev9ocHwjmKJFUWVx3UUZml+yEp9gzzlHh7ovH7O1V3SKa35MiApMTshwNdjuSb5f JI2fTWlPqvx7Hb53lhWwMlVqf8Rr6fozrVvQThaPJUW6afYiuvEnGIti3ENfkELZvSB6 LSIrkYsak+a5oI0xnWiS8J88OIKesgUGGmGfbd+Lai3RKLktySMU76XKcckzPnhr2E7N jZ/OU5BAPzwuI85vgIHHIVGXtxA/YGWrQatU9vCeFIUnhKUkZK79fcC8+Ddqw11oafHB vDxEy/wbiVGnMpBT5ta4KRvaOy5a5daEMywIom68VWAJsbO12SVp/ltSf3VEGfhLoqBa lWow== X-Gm-Message-State: ALQs6tANmSvOoE8BnZfCfZeqty2V8MYFzfMfEPZayKljbMYbMGX52V1K r4iKztmCfGzL2A5QNO2Ub4MjpoJqf5+bbB94BazMsQ== X-Google-Smtp-Source: AIpwx49HMSnKq/SSXjh0yhj6KpxIdm6FWm76WzZLAEG83eHJrbL6zYikmfFOnnUO9IVafd+4zao3qNj6dOzky8DGHl0= X-Received: by 10.202.74.194 with SMTP id x185mr2125728oia.295.1522250328322; Wed, 28 Mar 2018 08:18:48 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:44a8:0:0:0:0:0 with HTTP; Wed, 28 Mar 2018 08:18:47 -0700 (PDT) In-Reply-To: References: From: Lakhan Shiva Date: Wed, 28 Mar 2018 20:48:47 +0530 Message-ID: Subject: Re: Commit privileges and branching To: Warner Losh Cc: "freebsd-hackers@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 15:18:49 -0000 Hi, I have made a pull request as suggested. https://github.com/freebsd/freebsd/pull/135 In this I have added the PNP info for the puc driver. Please review and comment, for a possible merge. Thanks, Lakhan On Wed, Mar 28, 2018 at 2:15 AM, Warner Losh wrote: > > > On Tue, Mar 27, 2018 at 9:42 AM, Lakhan Shiva > wrote: > >> Hi, >> >> I would like to start working on converting PCI drivers that already have >> a >> table but font have a MODULE_PNP_INFO. I would like to know more about the >> branching strategy and the process to check in first piece of code. I am >> uising FreeBSD VM current image. I will be using SVN for checking out and >> checking in code from the VM. >> > > There's two paths forward for you. > > If you are selected for GSoC, you'll have our gsoc svn repo available. > > The other option is to fork from http://www.github.org/freebsd/freebsd > using git. > > The way that commits normally land in the FreeBSD is that some committer > will push them in with a tag saying that you'd submitted it and when > there's enough you'd get a commit bit of all has gone well. > > If you're doing GSoC, then you and your mentor would work this out. > > Warner > From owner-freebsd-hackers@freebsd.org Wed Mar 28 16:05:09 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9BA11F6A4D2 for ; Wed, 28 Mar 2018 16:05:08 +0000 (UTC) (envelope-from danny@cs.huji.ac.il) Received: from kabab.cs.huji.ac.il (kabab.cs.huji.ac.il [132.65.116.210]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E4970737C4; Wed, 28 Mar 2018 16:05:07 +0000 (UTC) (envelope-from danny@cs.huji.ac.il) Received: from imac.bk.cs.huji.ac.il ([132.65.179.42]) by kabab.cs.huji.ac.il with esmtp id 1f1DZP-0004Kh-IY; Wed, 28 Mar 2018 19:05:03 +0300 From: Daniel Braniss Message-Id: Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: how to add local changes to buildworld? Date: Wed, 28 Mar 2018 19:05:03 +0300 In-Reply-To: <1522247949.49673.54.camel@freebsd.org> Cc: freebsd-hackers@freebsd.org To: Ian Lepore References: <1522169225.49673.36.camel@freebsd.org> <539E3F8D-8275-4904-8D19-8FB31C05787C@cs.huji.ac.il> <1522247949.49673.54.camel@freebsd.org> X-Mailer: Apple Mail (2.3445.5.20) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 16:05:09 -0000 > On 28 Mar 2018, at 17:39, Ian Lepore wrote: >=20 > On Wed, 2018-03-28 at 08:50 +0300, Daniel Braniss wrote: >>=20 >>>=20 >>> On 27 Mar 2018, at 19:47, Ian Lepore wrote: >>>=20 >>> On Tue, 2018-03-27 at 19:20 +0300, Daniel Braniss wrote: >>>>=20 >>>> Hi, >>>> I have some local additions which int the past, after making = changes >>>> to some Makefiles, etc, I got them compiled >>>> but somehow, things stopped working after 11, so I=E2=80=99m now = trying to do >>>> a fresh set of patches, >>>> and was wondering if there is some docs around on how to to this >>>> cleanly? trying to figure out the *.mk is becoming a bit = complicated. >>>> thanks, >>>> danny >>>>=20 >>> If you're asking what I think (you want to add code of your own into >>> the buildworld), just add LOCAL_DIRS=3D"path/to/dir1 path/to/dir2" = to the >>> buildworld command line and it will visit your directories and run = the >>> same targets there as for standard freebsd dirs (so your makefiles = have >>> to have those targets, mostly easily accomplished by including the >>> usual bsd..mk where foo=3Dprog|lib|subdir|whatever. >>>=20 >>> The local dir paths in LOCAL_DIRS must be relative to the top-level >>> freebsd source dir, you can't use absolute paths (but you can use >>> relative paths that take you outside the freebsd path, I think, like >>> ../mysources/project1). >>>=20 >>> -- Ian >>>=20 >> I guess in my haste I was not clear enough :-) >> my problem is the dependency, >> in particular, it=E2=80=99s a pam module, that needs a local library. = in the past the library was compiled first, and then the module, >> now it still happens, but the module does not find the library, which = has been compiled! there is a new piece of mail that >> i=E2=80=99m missing :-(=20 >> i=E2=80=99ll try again with LOCAL_DIRS. >> thanks >> danny >=20 > Oh yeah, libraries... there is also a LOCAL_LIB_DIRS you can set to > list libraries. But looking at Makefile.inc1 it builds the local lib > dirs after the other local dirs, which seems completely wrong and > useless. I think the LOCAL_LIB_DIRS should be built along with the > base system dirs; the attached patch would do that. >=20 > -- Ian > Index: Makefile.inc1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- Makefile.inc1 (revision 331499) > +++ Makefile.inc1 (working copy) > @@ -241,6 +241,17 @@ X${BINUTIL}?=3D ${${BINUTIL}} > SUBDIR=3D ${SUBDIR_OVERRIDE} > .else > SUBDIR=3D lib libexec > +# Add LOCAL_LIB_DIRS, but only if they will not be picked up as a = SUBDIR > +# of a LOCAL_DIRS directory. This allows LOCAL_DIRS=3Dfoo and > +# LOCAL_LIB_DIRS=3Dfoo/lib to behave as expected. > +.for _DIR in ${LOCAL_DIRS:M*/} ${LOCAL_DIRS:N*/:S|$|/|} > +_REDUNDANT_LIB_DIRS+=3D ${LOCAL_LIB_DIRS:M${_DIR}*} > +.endfor > +.for _DIR in ${LOCAL_LIB_DIRS} > +.if ${_DIR} =3D=3D ".WAIT" || (empty(_REDUNDANT_LIB_DIRS:M${_DIR}) && = exists(${.CURDIR}/${_DIR}/Makefile)) > +SUBDIR+=3D ${_DIR} > +.endif > +.endfor > .if !defined(NO_ROOT) && (make(installworld) || make(install)) > # Ensure libraries are installed before progressing. > SUBDIR+=3D.WAIT > @@ -282,17 +293,6 @@ SUBDIR+=3Dcontrib/ofed > SUBDIR+=3D ${_DIR} > .endif > .endfor > -# Add LOCAL_LIB_DIRS, but only if they will not be picked up as a = SUBDIR > -# of a LOCAL_DIRS directory. This allows LOCAL_DIRS=3Dfoo and > -# LOCAL_LIB_DIRS=3Dfoo/lib to behave as expected. > -.for _DIR in ${LOCAL_DIRS:M*/} ${LOCAL_DIRS:N*/:S|$|/|} > -_REDUNDANT_LIB_DIRS+=3D ${LOCAL_LIB_DIRS:M${_DIR}*} > -.endfor > -.for _DIR in ${LOCAL_LIB_DIRS} > -.if ${_DIR} =3D=3D ".WAIT" || (empty(_REDUNDANT_LIB_DIRS:M${_DIR}) && = exists(${.CURDIR}/${_DIR}/Makefile)) > -SUBDIR+=3D ${_DIR} > -.endif > -.endfor >=20 > # We must do etc/ last as it hooks into building the man whatis file > # by calling 'makedb' in share/man. This is only relevant for i also found LOCAL_LIB_DIRS, and the library was built, but then when I = tried to use it with LIBADD +=3D idng it complained it didn=E2=80=99t know what I was talking, so I had to add = it to bsd.libnames.mk and bsd.own.mk which is sort of messy. BTW, the order of the libs in my case was not important, as long as they = got compiled before the pam module! anyways, now I have changed my old method (dates back to 4!) and = switched to use mercurial + svn, and hopefully will be able to track my local changes better - though I=E2=80=99= m still figuring out how to do this :-) thanks, danny From owner-freebsd-hackers@freebsd.org Wed Mar 28 16:17:30 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A359AF6ABBE for ; Wed, 28 Mar 2018 16:17:30 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4A903740B3; Wed, 28 Mar 2018 16:17:30 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 9C1EE5A9F17; Wed, 28 Mar 2018 16:17:29 +0000 (UTC) Date: Wed, 28 Mar 2018 16:17:29 +0000 From: Brooks Davis To: Daniel Braniss Cc: Ian Lepore , freebsd-hackers@freebsd.org Subject: Re: how to add local changes to buildworld? Message-ID: <20180328161729.GD88362@spindle.one-eyed-alien.net> References: <1522169225.49673.36.camel@freebsd.org> <539E3F8D-8275-4904-8D19-8FB31C05787C@cs.huji.ac.il> <1522247949.49673.54.camel@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="V88s5gaDVPzZ0KCq" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 16:17:31 -0000 --V88s5gaDVPzZ0KCq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 28, 2018 at 07:05:03PM +0300, Daniel Braniss wrote: >=20 >=20 > > On 28 Mar 2018, at 17:39, Ian Lepore wrote: > >=20 > > On Wed, 2018-03-28 at 08:50 +0300, Daniel Braniss wrote: > >>=20 > >>>=20 > >>> On 27 Mar 2018, at 19:47, Ian Lepore wrote: > >>>=20 > >>> On Tue, 2018-03-27 at 19:20 +0300, Daniel Braniss wrote: > >>>>=20 > >>>> Hi, > >>>> I have some local additions which int the past, after making changes > >>>> to some Makefiles, etc, I got them compiled > >>>> but somehow, things stopped working after 11, so I???m now trying to= do > >>>> a fresh set of patches, > >>>> and was wondering if there is some docs around on how to to this > >>>> cleanly? trying to figure out the *.mk is becoming a bit complicated. > >>>> thanks, > >>>> danny > >>>>=20 > >>> If you're asking what I think (you want to add code of your own into > >>> the buildworld), just add LOCAL_DIRS=3D"path/to/dir1 path/to/dir2" to= the > >>> buildworld command line and it will visit your directories and run the > >>> same targets there as for standard freebsd dirs (so your makefiles ha= ve > >>> to have those targets, mostly easily accomplished by including the > >>> usual bsd..mk where foo=3Dprog|lib|subdir|whatever. > >>>=20 > >>> The local dir paths in LOCAL_DIRS must be relative to the top-level > >>> freebsd source dir, you can't use absolute paths (but you can use > >>> relative paths that take you outside the freebsd path, I think, like > >>> ../mysources/project1). > >>>=20 > >>> -- Ian > >>>=20 > >> I guess in my haste I was not clear enough :-) > >> my problem is the dependency, > >> in particular, it???s a pam module, that needs a local library. in the= past the library was compiled first, and then the module, > >> now it still happens, but the module does not find the library, which = has been compiled! there is a new piece of mail that > >> i???m missing :-(=20 > >> i???ll try again with LOCAL_DIRS. > >> thanks > >> danny > >=20 > > Oh yeah, libraries... there is also a LOCAL_LIB_DIRS you can set to > > list libraries. But looking at Makefile.inc1 it builds the local lib > > dirs after the other local dirs, which seems completely wrong and > > useless. I think the LOCAL_LIB_DIRS should be built along with the > > base system dirs; the attached patch would do that. > > > > -- Ian > > Index: Makefile.inc1 > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- Makefile.inc1 (revision 331499) > > +++ Makefile.inc1 (working copy) > > @@ -241,6 +241,17 @@ X${BINUTIL}?=3D ${${BINUTIL}} > > SUBDIR=3D ${SUBDIR_OVERRIDE} > > .else > > SUBDIR=3D lib libexec > > +# Add LOCAL_LIB_DIRS, but only if they will not be picked up as a SUBD= IR > > +# of a LOCAL_DIRS directory. This allows LOCAL_DIRS=3Dfoo and > > +# LOCAL_LIB_DIRS=3Dfoo/lib to behave as expected. > > +.for _DIR in ${LOCAL_DIRS:M*/} ${LOCAL_DIRS:N*/:S|$|/|} > > +_REDUNDANT_LIB_DIRS+=3D ${LOCAL_LIB_DIRS:M${_DIR}*} > > +.endfor > > +.for _DIR in ${LOCAL_LIB_DIRS} > > +.if ${_DIR} =3D=3D ".WAIT" || (empty(_REDUNDANT_LIB_DIRS:M${_DIR}) && = exists(${.CURDIR}/${_DIR}/Makefile)) > > +SUBDIR+=3D ${_DIR} > > +.endif > > +.endfor > > .if !defined(NO_ROOT) && (make(installworld) || make(install)) > > # Ensure libraries are installed before progressing. > > SUBDIR+=3D.WAIT > > @@ -282,17 +293,6 @@ SUBDIR+=3Dcontrib/ofed > > SUBDIR+=3D ${_DIR} > > .endif > > .endfor > > -# Add LOCAL_LIB_DIRS, but only if they will not be picked up as a SUBD= IR > > -# of a LOCAL_DIRS directory. This allows LOCAL_DIRS=3Dfoo and > > -# LOCAL_LIB_DIRS=3Dfoo/lib to behave as expected. > > -.for _DIR in ${LOCAL_DIRS:M*/} ${LOCAL_DIRS:N*/:S|$|/|} > > -_REDUNDANT_LIB_DIRS+=3D ${LOCAL_LIB_DIRS:M${_DIR}*} > > -.endfor > > -.for _DIR in ${LOCAL_LIB_DIRS} > > -.if ${_DIR} =3D=3D ".WAIT" || (empty(_REDUNDANT_LIB_DIRS:M${_DIR}) && = exists(${.CURDIR}/${_DIR}/Makefile)) > > -SUBDIR+=3D ${_DIR} > > -.endif > > -.endfor > >=20 > > # We must do etc/ last as it hooks into building the man whatis file > > # by calling 'makedb' in share/man. This is only relevant for >=20 >=20 > i also found LOCAL_LIB_DIRS, and the library was built, but then when I t= ried to use it with > LIBADD +=3D idng > it complained it didn???t know what I was talking, so I had to add it to = bsd.libnames.mk and bsd.own.mk > which is sort of messy. I thought I'd adding infrastructure for that in CheriBSD, but it looks like I'd hacked around it. In our tree, the odd things live under a ctsrd subtree and I have a ctsrd/ctsrd.libnames.mk the gets added for all things in the tree via Makefile.inc includes. That works for us because the only things that use those libraries lives in the tree. -- Brooks --V88s5gaDVPzZ0KCq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJau8AYAAoJEKzQXbSebgfAwzQIAJ9Z1fHaFHQa5R5Pfge7lgzQ 8O8QEgJAdrsMt7Ds1kAvYs0xqSsK2RiXbcu9lzoplEqnPwlc/vJ7I1eqFWvvBBIs ABUgHdHLi+XZZqZff/9FEbucn4ghuJ/9afLbpJg6khhfW6ADYLlqusEDgu8aZydD CUjrrAGdzBlnhO6zbQBImXQiIhwnmPsXh/tSuoNlqtQvgbU4AHPP34jtf7tBGXYf KN/hn0uvgXWAnNUsYX2SZHqKeyOkdh8Kab3n78MJLoho793qShQ9B9lX6X8Sd+iW y/uYn3cnGN6N1EqLoG5SrunRkYMsfwXmaObNZp0DPsMeeqfbEd+zBGfmjflzivM= =QGFk -----END PGP SIGNATURE----- --V88s5gaDVPzZ0KCq-- From owner-freebsd-hackers@freebsd.org Wed Mar 28 18:15:46 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BFDB6F6EB5A for ; Wed, 28 Mar 2018 18:15:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x235.google.com (mail-it0-x235.google.com [IPv6:2607:f8b0:4001:c0b::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B78E7B436 for ; Wed, 28 Mar 2018 18:15:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x235.google.com with SMTP id c1-v6so4778751itj.1 for ; Wed, 28 Mar 2018 11:15:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=wFZDN5XJ672p9ch0ggk9HXwh8HyaG5Sc6oZyhTP4GjI=; b=SHxz6tG+F6278t6ZFbmHNnif1hY5ekApcdlPWw0/2QLQHGIn+snp6QCh1/Ux6I6wtJ 78Io03dKkWSPcCnIzH+bKIT4PeDZLomzuRyhAeHWPxmwPqhIBgngPh17n7Ev/OMRpGS6 yQFdoXyv5Hb4/P7tKBITm2yDc1BhrZD3oT+mhwScU9tmbKm8nKkINnk6aARGcFLnEl3n Ae/TdkTUNrRO7CqSyiIRJ8AvpjC6jWrrKkEpbLCo/I7r2GhywCFOj9iu2DaCV+ft3go7 dfmx7wTNmTqUqiVSyEq+ulsHHKS41IxP27mAy77BxN4cZ3kLkFgE0lfOkLyxPv1HZzMC TbpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=wFZDN5XJ672p9ch0ggk9HXwh8HyaG5Sc6oZyhTP4GjI=; b=HjxYJU6jfozlPGD1hOl2Rr4bGoCePSQsUpeGrvoqJuQtDI6+DVFa6RJzRaBHY6DVq5 JU+v4tcAVDzS8UIU4fUanNd96Cgdb9hz6JB76hWsg9G7u+cW9LIbrhVrLfJkNg57bx8A +3tE/OJiwdLu0h8f4KBjpVY4oaukC4zglwiUbFy8VGq8FLe32HRAF56UtL+0nSDsYMKv TuigdqrjNFqpsNGM/6IzXzbg6VTx8nPxEYGq05/b+VYvzYp2CktPyiCYKJgx9g4m25Pn EX08AVxcpqImcxwxMXEHzg9yz81rwKDzE89A9gsjBf66ffE/2As3KTpu9mSY5VUcHreq 4dUA== X-Gm-Message-State: AElRT7G7DcM39+FqmRF9BFhWn1K1ggRVFk4xdIQLkIIjb/WZyjWuvZae vlkW2bcoZTQw5YaB308R3OH12lQ5rFTJkv7jbwTU+Q== X-Google-Smtp-Source: AIpwx4+9v4HKe1+pEgOZfK524HAb8XwjhigtJGeXXGwG+WJxIw4ycpWhPsFUB7aJgP+DLE3pRq6mchdMeV+U4z0naeA= X-Received: by 2002:a24:4286:: with SMTP id i128-v6mr4597997itb.73.1522260945495; Wed, 28 Mar 2018 11:15:45 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.203.196 with HTTP; Wed, 28 Mar 2018 11:15:44 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: From: Warner Losh Date: Wed, 28 Mar 2018 11:15:44 -0700 X-Google-Sender-Auth: 4vjzRlwjzOUFgrzJW5NJA_UFPUI Message-ID: Subject: Re: Commit privileges and branching To: Lakhan Shiva Cc: "freebsd-hackers@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 18:15:47 -0000 Thanks! I'll comment there. Warner On Wed, Mar 28, 2018 at 8:18 AM, Lakhan Shiva wrote: > Hi, > > I have made a pull request as suggested. > https://github.com/freebsd/freebsd/pull/135 > > In this I have added the PNP info for the puc driver. > > Please review and comment, for a possible merge. > > Thanks, > Lakhan > > On Wed, Mar 28, 2018 at 2:15 AM, Warner Losh wrote: > >> >> >> On Tue, Mar 27, 2018 at 9:42 AM, Lakhan Shiva >> wrote: >> >>> Hi, >>> >>> I would like to start working on converting PCI drivers that already >>> have a >>> table but font have a MODULE_PNP_INFO. I would like to know more about >>> the >>> branching strategy and the process to check in first piece of code. I am >>> uising FreeBSD VM current image. I will be using SVN for checking out and >>> checking in code from the VM. >>> >> >> There's two paths forward for you. >> >> If you are selected for GSoC, you'll have our gsoc svn repo available. >> >> The other option is to fork from http://www.github.org/freebsd/freebsd >> using git. >> >> The way that commits normally land in the FreeBSD is that some committer >> will push them in with a tag saying that you'd submitted it and when >> there's enough you'd get a commit bit of all has gone well. >> >> If you're doing GSoC, then you and your mentor would work this out. >> >> Warner >> > > From owner-freebsd-hackers@freebsd.org Wed Mar 28 19:47:46 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 48C69F7167A for ; Wed, 28 Mar 2018 19:47:46 +0000 (UTC) (envelope-from dieterbsd@gmail.com) Received: from mail-io0-x22d.google.com (mail-io0-x22d.google.com [IPv6:2607:f8b0:4001:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BA5197F9DE for ; Wed, 28 Mar 2018 19:47:45 +0000 (UTC) (envelope-from dieterbsd@gmail.com) Received: by mail-io0-x22d.google.com with SMTP id v13so4917259iob.6 for ; Wed, 28 Mar 2018 12:47:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=QaWZrmiIzwE1oXNgm1kgw3jNfFoZLz01IciqR/Xm5nQ=; b=i4tE9+IRHiaSdSNIUcLf5Lfl9xfZEH0tuOsIiL4T+5Y04QgAPa5KsF+/hMV0nkzpO0 1JuOHvMwwc/mNYj4sTNjDXiJ/s46ovI8ZzLu2l4r2sFmKFUkUp0QtXwYmnwAHOP+qsbn qjJKeJVfDPDiXg+yCSZLXIkW83wilIaix3Y+5ABNmovJs6wuVFi9Dc2W+Z/lFX6eUPJS ynbHsk28XdBNnH3Ow/UmR6D9mrDqfJChRv7ZPzgiDnnl5BDWFzGQf/M9urhSWVzXrbqp 0NADFGOQRsp6YKa/IKRXC1nkiqg27I807uerTqFzPMJO/jsXjwyWW6QPX4DKNbaOIKis wdZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=QaWZrmiIzwE1oXNgm1kgw3jNfFoZLz01IciqR/Xm5nQ=; b=Y0HQSrMMphbFwUkSGOdWkeyUnUYx4SUzJFFil75eLpros1QLAC2ud8PDWPpurtxjmE 1+4UV5nxhInt6vsOFsa3iADFJN99WLJlsJH50xzoTbPTPk4mzo+HZc9Phgobjrcam1S+ SMwOZQUZdyx8EGh1A2qigNijl8aicZXOs6+fhg6a6irPZzxECnKUaXTE/EoXr6708bGe Ft1J5GgjA/nRdzy/k0GDTt1OndiLs8dqVc4XdyL0wTJKFLSGgvV+g+kuLo5W2D7Foor+ BMQy9oV3deC4kj93JtyRvv80KryogWNuFDdUtTIBYGpXIh5Ltm9uwQCSoSf5QI45JRoZ l0PA== X-Gm-Message-State: AElRT7E0U6Ujuh/Axr6ZpNBBSkpsuU1epANsu6Fb2+SYahhScRMy/xwK 2ZkyCkXLz01+OKixstwKVOS2CPfWQXKB0jLtH/A= X-Google-Smtp-Source: AIpwx48k0rPeF8IzQz9TAKWdYi5to03FzZWPzagmrtmvcyF0XHaLoYlOSLVY/P9sGAJrJ/vduuNzr5OGyeo07xzPVR4= X-Received: by 10.107.146.136 with SMTP id u130mr13343982iod.96.1522266465234; Wed, 28 Mar 2018 12:47:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.192.242.196 with HTTP; Wed, 28 Mar 2018 12:47:44 -0700 (PDT) From: Dieter BSD Date: Wed, 28 Mar 2018 11:47:44 -0800 Message-ID: Subject: Re: GSoC Idea: per-process filesystem namespaces for FreeBSD To: theron.tarigo@gmail.com, freebsd-hackers@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 19:47:46 -0000 Someone typed: > A kind of related task; FreeBSD could benefit from : Fixing and > improving unionfs / nullfs. There are some weird issues with the current > unionfs ... > try to unmount it in the wrong order or thrash a unionfs with > lots of writes on top of a tmpfs and things break Suggestion: fix the unionfs so that it works. 1) Code review. Read the code looking for problems. 2) Hunt down whatever filesystem tests exist. Run them. Do they pass? 3) Are the tests complete? Assuming that they are not: Complete the test suite: A) Functional tests (A filesystem should be able to do x, y, and z. Test that it can. Include various stress tests, and things like a kernel panic, disconnecting a disk's data cable, various types of raid, with/without encryption, various newfs options, labels, ...) B) Code tests (Write test cases to exercise every line of code, and verify that you get the expected result.) 4) Check for open PRs against the filesystem. Can your expanded test suite duplicate the problem? 5) Fix any problems found. 6) Don't forget the filesystem support tools, like newfs, fsck, dump/restore, ... 7) Is the documentation complete, and does it match the code? Remember that the test suite needs documentation too. This should be a good first step towards the Plan 9 functionality. From owner-freebsd-hackers@freebsd.org Wed Mar 28 20:34:22 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E286BF72812 for ; Wed, 28 Mar 2018 20:34:21 +0000 (UTC) (envelope-from embaudarm@gmail.com) Received: from mail-ot0-x232.google.com (mail-ot0-x232.google.com [IPv6:2607:f8b0:4003:c0f::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 71982819AA; Wed, 28 Mar 2018 20:34:21 +0000 (UTC) (envelope-from embaudarm@gmail.com) Received: by mail-ot0-x232.google.com with SMTP id r30-v6so4114498otr.2; Wed, 28 Mar 2018 13:34:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=leJvwKVoACIiywTwxNYDOV6xyZcBrC6MJzZUagNsGBk=; b=kxd295h3V3oP6KzJMDTKDfvmBk1ZmKCI3zy5lhXQPRNjm1kkGMvynMysyVaNguJEIT d6OjcUp21wtxSnLGerE3oCQkkZILV+BX2+rl8LdgeYtVVpwkDDtUkraW6rXeu307KnKw CztRDzvvMHXA77d3YBKNr/GjZCS7RNMwzCmrjO4iTBiVeZkN6zRYza5EMWzleWtNmHhi 8br3IQ8KGXPLwifZPOOF/GMER7U6TG7Jzok3It3Vq2wvf64skZPefOjKhaNJKRA1bmLZ j89FvRzqH7ET/c1pxQoDjbatd9C+TE8aSf5rm5AQ4hSaJTZAzgvBMawS6sl1vE56RjbJ zG2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=leJvwKVoACIiywTwxNYDOV6xyZcBrC6MJzZUagNsGBk=; b=oCRBUJDKhCjNMk8fsaSKxD+zm+94SN4E15UVMV6b4Rwn7i5AAML4/KzVKEV/rmqSYk AU6jWBsr/QjhcWouH1X8OegdDbcKmrSGTZeNT7bL675wSQZkMejkShXhNMVw6HFUGcMJ EVtGMRnQloX+n8oUTa+qYGo2VF+s701ORXJ9+s3yCfVvqTESPGupMvu7f82lubOxFkzg UKGlJdVHxAasTUCef6KMvu/+/hG2knnJPPFjeYWbuFhxRlk1R9xnQp9rTJ5Y3+SRAspU ICg4ONoDR4w2JwXNKYS2x7z1pYDnbRbqgjyc4glAzpvl6Qp5uoxC6Olmxqt4QnPPzUhY RUbw== X-Gm-Message-State: AElRT7Hhk2JUeu4NdbS3afDyvPM2IZ/5cSmdm39RKUXH7mkV5zMIeAMi fw5gvFljvAW2FggqxxCyGhg6M+OVcWDP55p8wYXbYQ== X-Google-Smtp-Source: AIpwx4/MFSx28BezsOqGyLJfWpPK3nrZUsIOTVdl2jDeJ7EnXXkC/FBvd+KasEv7+TFirRGLBf5L74vNLn1uzLRIHy8= X-Received: by 2002:a9d:5e06:: with SMTP id d6-v6mr3021702oti.148.1522269260660; Wed, 28 Mar 2018 13:34:20 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:4292:0:0:0:0:0 with HTTP; Wed, 28 Mar 2018 13:33:40 -0700 (PDT) In-Reply-To: <1521383420.99081.87.camel@freebsd.org> References: <1521383420.99081.87.camel@freebsd.org> From: Lee D Date: Wed, 28 Mar 2018 16:33:40 -0400 Message-ID: Subject: Re: Custom I2C and RTC chip drivers: where is iccbus_get_nostop() defined? To: Ian Lepore Cc: FreeBSD Hackers Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 20:34:22 -0000 On Sun, Mar 18, 2018 at 10:30 AM, Ian Lepore wrote: > Nostop is an ivar of the child device, so iicbus_get_nostop() is formed > by the IICBUS_ACCESSOR macro in iicbus.h. > > Now for the bad news: don't use it. It doesn't work. It's 100% a bug > in the code that maybe kinda-sorta seemed to work for whoever added it, > because accidentally the right garbage was on the stack in the local > nostop var. The generic transfer code doesn't check that the accessor > failed so it ends up using stack garbage for nostop. The reason > there's g'teed to be no such ivar is because the code is asking the > wrong device, and it doesn't even have a handle to the right child > device to get the info it wants. > > So the bottom line is, write your transfer routine to work however it > has to work. That might mean ignoring the stop/nostop flags and just > doing whatever your hardware does. Like if a write transaction is > handled by the hardware by putting the slave address and the offse- > within-slave values into registers and it does a write of the offset > then a read from the slave and you get no control over whether it does > that as two transactions or as 1 transaction with a repeat-start > between the read and write, then just silently do it that way. > > I had forgotten about the nostop mess, which I discovered some time > last year. It really needs to be fixed the right way, which is to > remove the nostop hack, remove all uses of the NOSTOP flag everywhere > in the code, and make the default behavior that all back-to-back > operations in the same array of cmds handed to a single transfer call > have implicit repeat-start behavior when changing slave or direction. > We could add a specific STOP flag to force a stop/start between two > commands, but even that's not really needed. > > The only example of a transfer-only driver I know of offhand is the rpi > driver (arm/broadcom/bcm2835/bcm2835_bsc.c). Unfortunately, bugs in > the rpi silicon complicate the code and make it a messy example. > > -- Ian > First let me apologize for taking so long to respond. What you've told me is actually good news as far as I am concerned, that I can just do what needs to be done in my driver. So thanks! Lee From owner-freebsd-hackers@freebsd.org Thu Mar 29 00:13:48 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 34627F57EAB for ; Thu, 29 Mar 2018 00:13:48 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "thawte SHA256 SSL CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 86B2B6B31D; Thu, 29 Mar 2018 00:13:47 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from pps.filterd (m0108161.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2T08tLu011245; Wed, 28 Mar 2018 17:13:46 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=to : cc : subject : in-reply-to : references : from : mime-version : content-type : content-id : date : message-id; s=PPS1017; bh=7KUiS1xIMWy80v5ZDYy+qQ2b2h97Vg9EYxL9btbBD5Y=; b=PNodiO4ZMY19QMncM4/Alq3VGDbWpWgqJSsbWDMcSb/JW85iVRNd4zuytuUe9hYgv+Ag rXfFtLxnfGMUY/WnM+7CqTvnM8u0W8KRbT94Ei0TxdKXJkh7Rzk4C+itdVntBhwSXEJU n/pTLyQwIyt9RGFOxvN0gP4JLHKmCi8xKqX/hO+b45vB1cd+55TJ0kaygrnOuDNxJrPy RwFVvQby9saqH/6fGLvgobl9VFojTDhgM37bMoC84ap+mCfaaFxDyVuBfeOCubPSUdVB SRxh8jcg/RhCLA2g0FF0VijyyT0JMnKvEkqse2PPQw88ENXVfIsIQo6DE66N9uCXowuh Jw== Received: from nam03-by2-obe.outbound.protection.outlook.com (mail-by2nam03lp0052.outbound.protection.outlook.com [216.32.180.52]) by mx0b-00273201.pphosted.com with ESMTP id 2h0gjagh2u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Mar 2018 17:13:46 -0700 Received: from SN1PR05CA0003.namprd05.prod.outlook.com (2a01:111:e400:5197::13) by CY4PR05MB3063.namprd05.prod.outlook.com (2603:10b6:903:f8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.631.5; Thu, 29 Mar 2018 00:13:44 +0000 Received: from DM3NAM05FT045.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::200) by SN1PR05CA0003.outlook.office365.com (2a01:111:e400:5197::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.631.5 via Frontend Transport; Thu, 29 Mar 2018 00:13:44 +0000 Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.12 as permitted sender) Received: from p-emfe01a-sac.jnpr.net (66.129.239.12) by DM3NAM05FT045.mail.protection.outlook.com (10.152.98.159) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.631.2 via Frontend Transport; Thu, 29 Mar 2018 00:13:44 +0000 Received: from p-mailhub01.juniper.net (10.47.226.20) by p-emfe01a-sac.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 28 Mar 2018 17:13:43 -0700 Received: from kaos.jnpr.net (kaos.jnpr.net [172.21.30.60]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id w2T0Dc9B026765; Wed, 28 Mar 2018 17:13:43 -0700 (envelope-from sjg@juniper.net) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id 5681351335; Wed, 28 Mar 2018 17:13:36 -0700 (PDT) To: Pietro Cerutti CC: , Subject: Re: bmake: variable modifiers in SysV include In-Reply-To: <20180328115825.ydfnbly6hpsvbo3h@ptrcrt.ch> References: <20180328115825.ydfnbly6hpsvbo3h@ptrcrt.ch> Comments: In-reply-to: Pietro Cerutti message dated "Wed, 28 Mar 2018 11:58:25 -0000." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 25.3.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <990.1522282416.1@kaos.jnpr.net> Date: Wed, 28 Mar 2018 17:13:36 -0700 Message-ID: <4361.1522282416@kaos.jnpr.net> X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:66.129.239.12; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(376002)(396003)(39860400002)(346002)(39380400002)(2980300002)(189003)(199004)(76506005)(7126003)(6916009)(229853002)(5660300001)(105596002)(69596002)(77096007)(26005)(117636001)(186003)(53936002)(107886003)(47776003)(486005)(97876018)(305945005)(46406003)(54906003)(2810700001)(486005)(476003)(126002)(2906002)(6246003)(76176011)(7696005)(11346002)(446003)(356003)(8676002)(6266002)(9686003)(106466001)(50466002)(450100002)(68736007)(86362001)(336012)(23726003)(97756001)(55016002)(16586007)(8936002)(81156014)(81166006)(50226002)(97736004)(53416004)(4326008)(316002)(478600001)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR05MB3063; H:p-emfe01a-sac.jnpr.net; FPR:; SPF:SoftFail; LANG:en; PTR:InfoDomainNonexistent; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; DM3NAM05FT045; 1:lj+j6MfpXTFZ1YdN1M2up+u1keIuu+vqf7GJ5QTG+JrFqErZX1kUgDRD5efIMDMrBhO2onnWUesPsdBHot4X/PcfedjnpKemkQIQdYIVDbb63oWnHkWWvQWrOQXdCwoO X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d4a78a2-c593-4fd1-9a53-08d59509ef5b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060); SRVR:CY4PR05MB3063; X-Microsoft-Exchange-Diagnostics: 1; CY4PR05MB3063; 3:f0zCKkw76iAu7ndyoUyOFFz0K6MHjPeRLrpZJDLXRdtlH8X1fr8T3hKE32G5cHH00J5+fQBz9tMV5w8MoNWCWlnhn7xR9V3Qy6b5Dy23JxKMFTWbolxO5kcTrvE17Bog1PWgsWBB/sdQPyISdKgNxjUOk24rab8e7KZNMn1OT6j62r7QPxX8uKCKNBZ7o9ivSzv+BTYycBPPcxdw3nTBAQ0vJEQ2laD/pwB5Kq5ni7zHNz2lsOciHbPtil6ewZBUpEtRrYdvxe8mjWYlH6jwU6c0BwUJtqsbzqWdyddTPrudzIyQp0QLfNwp40BiiDTx2z2s0RMimkHaTf9khC/CrYUvrkVpU49HcXnudQTbBp0=; 25:yWl5uVmDIm4KfPcOk/a3kbWnE2uDJKQKWW2Jt5iCb/xiAE7Ccd7/v/aJy5zaq7ATXZs5GIcdhMY9WTv/xlecEM824/AfXo1cTUo3kI6W2SmbmLhKnhVEtPdiu0ecDHl5uUyI1Xekth73YSUrYGy2WwEuUkaQrEH6v5ZAbmdWm54DIUFtckEfgYkXAp4m/6NwLuqf1fgtD8qHdW7az9iFUAJLOGPvd39NOEwChXbrLF9SM/cLssMfYbZmI3YWurFDauQopK0RJ0NFgK6TENZCodLmXHSwnwMUw15++DJqA/IH4vgNxMA5E0SoteY9bRzyiJpDgv2NiKGL0aiFsgYN2A== X-MS-TrafficTypeDiagnostic: CY4PR05MB3063: X-Microsoft-Exchange-Diagnostics: 1; CY4PR05MB3063; 31:mmiKUyKdRUK2x7kLTm6QryAjeYAnU11QS7u+yVxbaLXH/ky/nFSjImGIQHWGWPHNrPl1EmcsnWQx23hLyGGwaCFG+BvBHuG/WTDkUkp1VeArzUIAD9IzoFPf6VSb+px0IpFfZ7/QoA3uZYLTeXNaV8/cg2bK7if9yBBxgsjOn1XYt0CF8h+JvQTD8oZZFRPun1hFHxJJ3jl6sRS/On4NprfJj1kQNK0LY9PxiA9SzBE=; 20:ftxqy44jTBm0NaDr2UUnyEV4eyhCK7rGk/nY/Ybslu/dSQpU8B2U9TlfuU56+qGfxOxS/1GdCIcANYvrETfRpB99dndN6xAJxTbuw0be5uJkEjS9NGY2Ry0yMt/p2XPj09eJCX+U0rkCbyiw5UyO9kSnLTV0+VpaMCeVHpgxw/ae+yuWmtAjcq1TIcOfRBWVQDS5TLs2nQCkpdnU8MFIxRyEB5Ok9j9a04xmAgZXnbG8845MbfHwPJ58Y3SyVH1lRWXIt5jS9i6cFAImB/zudVAcVjPvt0DPJutuN8H0HlKQ66CHpmPkyxBdf/RCJNvEQcAj4GewI9yg2ZXvZPyjiMyexTbzgZyOnpvUh/TMMFEIRw++rZA67P4UfcJC5h0GZV/SPhszvFX6uxwp10WBn1Y86CQLvO3yS4Q6BRbeTugJ7gU+D9deKikpkOaluGsssc0Pxqa70x/8LajlRR+seh9lw8Hwru6Qa48pMuZziJQpvWPS4vmZ6WXVSGgwqy/b X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(93006095)(93003095)(3002001)(10201501046)(6055026)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:CY4PR05MB3063; BCL:0; PCL:0; RULEID:; SRVR:CY4PR05MB3063; X-Microsoft-Exchange-Diagnostics: 1; CY4PR05MB3063; 4:Vbzue2Dr9SfTgCWb+/Z/mToddJrVa4n3oFqUiq9rF5xPkh4Z4Utm2MQBM1KMxQcWTThNkM9+n1et7g43nMD9ogN6v1bG+3glEuenkqDLUHG54nucEczO2gGQlSuH3yP2spKcVY3+0Kgce9/A3lIYRVbSmBWDWskUPV0anQitvhgyF3REHD1of2SuzBU4x4xTIHFglAMTuXIn+7crWXvWA8SVb6jSgYQ/Ren63+3QoL4SGnEXg+EU1t6+Pheb8Y9esTs3jrkJTSSq8vBN9sSRBQ== X-Forefront-PRVS: 0626C21B10 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR05MB3063; 23:RaDaMQYJXoiYP0nsFDJ1L9HlRot6UbTc42w0vHhMW?= =?us-ascii?Q?j51gS3Sd6HcNQ2lcieyN4JuQWNcvyMPNeeMGyT9zjg6+EE/zje6AeCUI87Yw?= =?us-ascii?Q?AYVRALVAzuGXHqMYQeZOeG8CJsIunwBSXAngyzbm229316J2mTFA7GbLYcb3?= =?us-ascii?Q?mdNPhOujavQolirkFU0G442hHD7+/AN5pHTZWcCX3Vanzso5qIkh5xSMf32L?= =?us-ascii?Q?ehjgwVFlqArTbvtgDwk56RVB7c/gTrqIOoWIJQINjlCpkkaC6e70lEIsDBLy?= =?us-ascii?Q?qe9QDV6dpHGBm0qr0xfE2pxYOmtCe9c7jpH7lC792WSyoROH3IPMVbwenj4i?= =?us-ascii?Q?df+rtpft5/fzd3RmoHJFSqvSgprFniI4O9XGYiLrObxQ0eoqZBii+Hc0m7SY?= =?us-ascii?Q?amy3hkNAgMk4oWsnPWoR6ac45dvFPodyuwsk9uWTdZpWhoyD2hDbOFAMcalz?= =?us-ascii?Q?3+ZI1Z3PV5gidyWF8UGVrJq+8z+uSWzauMtivvKnCSFtrlgYbGzBXgETuJWC?= =?us-ascii?Q?QuNsD+d6JHn+3H5Q4TUv85cVJrhW/6QFSWEpayvu6ZRB4J9s7HbFyr0LIHOZ?= =?us-ascii?Q?Q6QnIrNCGfKCc2Lby0jtkO3scKU+zhD2SYlkKjL5FfVJ9TocT+VMSJTQMqiW?= =?us-ascii?Q?fdyx3c7BAlrIw1A4ZZlu8YTTLV52Qklp7iu/k/cBTg/GKyEeag0pzSxfUaeK?= =?us-ascii?Q?56ALACS4RwrW69DFuTULyvRwjSHzR7ZumwcvLs8V0T0wG+T+aMC/JJXfUidI?= =?us-ascii?Q?lJrj61P1pileaCpqyReOmPqXuIOOh3EprmK91t7xJPJdz6h00Cyvv8dgsNZT?= =?us-ascii?Q?tpAqCeSOIqF/sxBxlR8ncAlxCJjTRwKkLVEfYF+kqB2o5ZAURa0reWPaUHNH?= =?us-ascii?Q?1cD6BBc6h7KJrqcuxNq36pzUIGRJ/4l0s1AMZ0b1G110HSR917FDLRznlGjd?= =?us-ascii?Q?PZMUOtcpeUmIZ8Osm6e+VDevP2Kn348k+3szAYTVoNF1lNALI2U4FooQahYw?= =?us-ascii?Q?91Yc0nUsc1sdOOXg+aD1duGLNYRHfYTCjmN5DAuYcLIH1KLzWQTnzut5rAJg?= =?us-ascii?Q?aCC796GSXVmiITAr3hloiiXJaLgYJ5a5jzAUXhbhZhT9v6LsYGDciYgU3dTw?= =?us-ascii?Q?WvXGkM2ysJbKetd3oqcUUt7ayJxDb8dSiZ9xTJiUIy1oMpnlC3Csc1LVtzv/?= =?us-ascii?Q?H5qIjtmvK+XJZBIOIU+wm41f9tTAdJsx+6DRvvFo1P84l2QQJPIW4KBwsmtk?= =?us-ascii?Q?57ap6nnwc7kHmwOVRGdzi3y0PNL7IKOJH0cb+zRG2KgtGbAbVcR39trj/Wvs?= =?us-ascii?Q?SzknDThRmIZZc+/ZjdRIvC7D4GzoXpCEBuBVBz4D5lfG2aoOa6GwhfZAeun5?= =?us-ascii?Q?3RHFA=3D=3D?= X-Microsoft-Antispam-Message-Info: oOW66rAWAlcZoODo1DVTGER70dOuxMnIPHRNkugkHIE5mirCDHgHDrg0djcQW/tTY1WHQfs9BcALdpuqdaCW2XJ06g2R16NlZJhFxY6R3JWlum9ilSaZgIFzIkuztnhyouRVvcnhEu+WMwG1jOiZvjKsv2qXxdK2g0uDadK/T+uO+DIw7bHj4YATLmtQF7Cz X-Microsoft-Exchange-Diagnostics: 1; CY4PR05MB3063; 6:Wxq3ElmHDJJKoxS2UJwb3mdLcY+chfYLaYnbhg5KPYcw6acXusyv/imK/FF++NKI9SjdJIs1ddzSnyPD1FUIikvhDKyODXU0nGU+ikLwIhBSe+NIW//MypfDUCcd8P+fZQJiLP2bovSGDibvp5hIvhdBIyzpb5PCByW4hYDErj/eGpGasfNH5B7s6I9iJadH2t96V+HFK7xpMGEC35dKevAq3Evo7Aa+DwY0acHD1IPWP0bqvFZo9lbhqj4t0ikjQsz5KNOsPWiQmetyrDtG32tZJGETPdmfCWl5d0XFex8cEnOvf2rCTY8NrPxfnfZjiuYlDrCMxmUG1jSEuu3beUpS+MZ9lP1xfCzOoJ+jkPjL9IT/nw5lw8F+hTro5/elyBl3anG94QTjWLMtB7f/nqoDoTOncdfBrYWY02tPhgy9O2y8vqZGPX1RHkKatVrV6eNXObZu2TA5LnP3VT6NWw==; 5:6gXiIN0Wnk9MrcR58XtiQ8xaM6e2qbtg5Km8H/fUqqRTIlxGmjTtt/6m6JiLxaIQRteqFr82HVogZD4VgFRucVmMOEB570VSKd34eIo0maJdJDz5M8wbta0HAe9kfY/zuTfUFX4AHZ6tYyQUBqZ0y4o9l478kTzpY9ozuomjIVQ=; 24:A9i/Zhu8Rh7oglyWU+txR4znADGDM4keiDmj9tFMz4zaRTPK+80dlfdsSo3p7H22/hWLtC7/pvM4U5ebDk9jVDrrgp4PlcfW3VhCiTDlkCk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR05MB3063; 7:HHa3D51xIW6rVCR+oWvqaGSoYDNM/pX/E0xPY3xH4eMsoocskwNFCWUUJSGSQIVkivCDjWnLyeTRZpaej8vtmAjxrFhxUmkmu2ylCfCH0V84AG+FsgeSJxDH0NHt08vfMSUwSdhfwj/rG/M8vKdesjlR2wzLLCB3hf1cB0D79E3TEz2Isog4evkRycvpCBlXhNyuqoRlZusEadJtQc0O/nrqHIg7iPQzONORHOiexsiRwm0/i3cOTr9ZJPQ1T0nV X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2018 00:13:44.2826 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0d4a78a2-c593-4fd1-9a53-08d59509ef5b X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.12]; Helo=[p-emfe01a-sac.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR05MB3063 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2018-03-28_08:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=647 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803290000 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 00:13:48 -0000 Pietro Cerutti wrote: > our make (contrib/bmake) does not currently support variable modifiers > in SysV-style "include" directives. See this simple example: > Apart from parentheses reshuffling, the patch just removes a check > that inhibits SysV inclusion if the line being parsed contains a colon > (:) character. > > This has been there since bmake has supported SysV includes [2]. > > Questions: > > 1. Any ideas why the check is there, and what problem it's preventing? > 2. Anybody with src bit would like to approve me committing the fix? Can you pls fwd your issue to tech-toolchain@netbsd.org (cc me) that way whoever it was who added the support for sysV style include can comment. Thanks --sjg From owner-freebsd-hackers@freebsd.org Fri Mar 30 08:38:16 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AAC12F50ABA for ; Fri, 30 Mar 2018 08:38:16 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from mail.ptrcrt.ch (ptrcrt.ch [IPv6:2a02:2770:8:0:21a:4aff:fe7e:c6be]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 284957D438 for ; Fri, 30 Mar 2018 08:38:16 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from mail.ptrcrt.ch (mail.ptrcrt.ch [192.168.1.1]) by mail.ptrcrt.ch (OpenSMTPD) with ESMTP id bf5b6617; Fri, 30 Mar 2018 08:38:13 +0000 (UTC) Received: from ptrcrt.ch (mail.ptrcrt.ch [192.168.1.1]) by mail.ptrcrt.ch (OpenSMTPD) with ESMTPS id e0a1daca TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Fri, 30 Mar 2018 08:38:13 +0000 (UTC) Date: Fri, 30 Mar 2018 08:38:13 +0000 From: Pietro Cerutti To: "Simon J. Gerraty" Cc: freebsd-hackers@FreeBSD.org Subject: Re: bmake: variable modifiers in SysV include Message-ID: <20180330083813.jfq3kwb5bzuhpeie@ptrcrt.ch> Reply-To: Pietro Cerutti References: <20180328115825.ydfnbly6hpsvbo3h@ptrcrt.ch> <4361.1522282416@kaos.jnpr.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="enbehtemswptyf5c" Content-Disposition: inline In-Reply-To: <4361.1522282416@kaos.jnpr.net> X-PGP-Key: fp="DA6D E106 A5B8 54B8 5DD8 6D49 ADD0 D38E A192 089E"; id="0xA192089E"; get=; get=; get=; get= OpenPGP: id=A192089E; url=https://gahr.ch/pgp/0xADD0D38EA192089E.txt; url=https://keybase.io/gahr/key.asc User-Agent: NeoMutt/20180323-25-688f04 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 08:38:17 -0000 --enbehtemswptyf5c Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mar 28 18 17:13, Simon J. Gerraty wrote: >Pietro Cerutti wrote: > >> our make (contrib/bmake) does not currently support variable modifiers >> in SysV-style "include" directives. See this simple example: > >> Apart from parentheses reshuffling, the patch just removes a check >> that inhibits SysV inclusion if the line being parsed contains a colon >> (:) character. >> >> This has been there since bmake has supported SysV includes [2]. >> >> Questions: >> >> 1. Any ideas why the check is there, and what problem it's preventing? >> 2. Anybody with src bit would like to approve me committing the fix? > >Can you pls fwd your issue to tech-toolchain@netbsd.org (cc me) >that way whoever it was who added the support for sysV style include >can comment. Hi Simon, I can't reply to Christos' email properly because I'm not subscribed to=20 that ML. Anyway, it looks like the original reason for the check on the=20 colon doesn't look too sustainable anymore :) Would you like to commit my fix to NetBSD? Thanks! --=20 Pietro Cerutti --enbehtemswptyf5c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJiBAABCgBMFiEE2m3hBqW4VLhd2G1JrdDTjqGSCJ4FAlq993EuFIAAAAAAFQAQ cGthLWFkZHJlc3NAZ251cGcub3JnZ2FockBGcmVlQlNELm9yZwAKCRCt0NOOoZII no2zEACLLP+84VjrsHyIk1sboPew+aeP5YxS/S0aDLGxYR91kRf3p/NMDg+VolC/ iFTHyd34t8jP1OXysMTRDwI3SMbTrQLGJXSNBam6sbS4+xNFNZ2UBHVuQfDYkBUS 29suIbMZowZvon+biBwJf7gFKKI9hUqVMFmEMc1N97zTFrb4Msr1GgRZETaI945P bbc2cKfHw6TbzvhAoyNH8S2iaIUUngFQrxQSMS729k45PhW7/QWP4xtxKQwSh80d wGtEGyVqrHHs4PqE8KkKYNOtWRhIHUh4rb2LQc4NGkkxSPqEZuiiiD2I8kePQRjO 7eCQSGQhs9fG2e9c4Rtms6JWUQ8XDTrzNu7P4cH28TQBXgW2pAR1OV5Dbppf4PVz S/oUMpefW1RasQTykcL9BlFI97P0Z57in/ufgyWhMXxBmtQUCrAUfo06KDoNtu/i 9wChYWkdw0jtyoD7yAAhLOautA4yGKb29lJM+JWw+rWLew3WQ+KFpN/ZMxd524wI heBIrCmGjIb9eQOEt7WEDfdxVCUmj4vrakclCG/e7W6VpXtHUg2elWAwboYvjWBu H9ilk11AO/G1vsl1WXcxpMhSs4j4WzjVj044BOJ3hakdcGvi3RgSzHrbaE4hz42F 0eVRIgeP0PBWYGzKxMLEXz8GZwu4NsdDoqZjoDNbixuWK26gfA== =IX13 -----END PGP SIGNATURE----- --enbehtemswptyf5c--