From owner-freebsd-geom@freebsd.org Sun Jan 13 21:01:25 2019 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2E2061487428 for ; Sun, 13 Jan 2019 21:01:25 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id CD8C190FE1 for ; Sun, 13 Jan 2019 21:01:24 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 9015F148741F; Sun, 13 Jan 2019 21:01:24 +0000 (UTC) Delivered-To: geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7DF59148741D for ; Sun, 13 Jan 2019 21:01:24 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 16A7890FDA for ; Sun, 13 Jan 2019 21:01:24 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 514CFA17E for ; Sun, 13 Jan 2019 21:01:23 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x0DL1Npw021857 for ; Sun, 13 Jan 2019 21:01:23 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x0DL1N0Y021848 for geom@FreeBSD.org; Sun, 13 Jan 2019 21:01:23 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201901132101.x0DL1N0Y021848@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: geom@FreeBSD.org Subject: Problem reports for geom@FreeBSD.org that need special attention Date: Sun, 13 Jan 2019 21:01:23 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jan 2019 21:01:25 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- In Progress | 218679 | [geli] add a verify command 1 problems total for which you should take action. From owner-freebsd-geom@freebsd.org Mon Jan 14 18:08:08 2019 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8E2A61482376 for ; Mon, 14 Jan 2019 18:08:08 +0000 (UTC) (envelope-from vandervelde.ag@gmail.com) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A58116E758 for ; Mon, 14 Jan 2019 18:08:07 +0000 (UTC) (envelope-from vandervelde.ag@gmail.com) Received: by mail-qk1-x733.google.com with SMTP id o8so11062646qkk.11 for ; Mon, 14 Jan 2019 10:08:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=HqzB0mNvsURtBW6yeDx/x0NUiD395/rWNlIR1cql2JI=; b=C5/Nkn6YDGmbBL41H9x5LFMSw+9V29wr30ZwYV4zFusypDe1l1bkRWpfLTjVdEG9+U FjvZdLriuhrTGE+CpCdVyvKymdd+x+2tT4k8+jQNj/XVMoHOQqJXZdOWy3xDzzqugLhp uWWZyj7c+kGI+PDYrIuSPQe4rxxYoA32R7L4B+smcW4poKx+X+9bJPJehWC1uAk3WKj5 BM+U0zFp2UXQ8H35QxlCN5I3a8C2wxRfRHkWvGU+iMSWC6g32/6C3dv6Spca1nnpTxYG uwuU85kOJt8wTnNMJ2GDvX1xO28XpPrkj0nRcZ8YwyOtaUU8Sv5zdBsngN448fJdjatB i49Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=HqzB0mNvsURtBW6yeDx/x0NUiD395/rWNlIR1cql2JI=; b=DHN6HAYuaL8O0EZsyNmp4ZMAW05QwwOefZCXZSwNIuOyTwsqtA/tbfoflD+0g7vU1t 27bOLmqLdS+d3AyRuXvk+va2FQB+w62vHB4MKeN/tX6ak4lGIzUxt/mPb6nu/4xq1mnC lK5CKhk6NTrtxVoFdkAhI/fA0OMJ1qEciIT8k/oFo+5H1YVZf7TJzxs/Uqfnizj0KpcB hMzwOPSC7oSWwOeJCJdvwu7TKGStt9uYYr1nBanNeuAeY4ss6E29rxuZiH6Fuhq5wryM jSvN0OfgXbNQNHZ+qoPP+4YVw0Arn5GRSSJ8rL4YtTsXilOUrkIhEBlvHkftu2QCnoZ5 w7Vg== X-Gm-Message-State: AJcUukcq/3LSR+drY/7fCqldS+CsImcPvrQKEdAHGcgf7sLdNj6Ij6uR F+hhL37WUMqxfOmkwaMnYovZUKlF X-Google-Smtp-Source: ALg8bN6iv7IYzCR8Y5T88+JWedmvcQhKb5k+BpY79n6Xz5fbgF4nu3hqzSz0M1mAw3U52kMWv6lWUg== X-Received: by 2002:a37:9302:: with SMTP id v2mr23172528qkd.202.1547489286824; Mon, 14 Jan 2019 10:08:06 -0800 (PST) Received: from noresult.ad.umassmed.edu (noresult.ad.umassmed.edu. [146.189.164.86]) by smtp.gmail.com with ESMTPSA id u50sm55146918qta.23.2019.01.14.10.08.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Jan 2019 10:08:06 -0800 (PST) From: Arjan van der Velde Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: arc4random rather than zero padding in geom_eli Message-Id: <22BD67F7-079F-4528-8C9F-27C7B0878B7C@gmail.com> Date: Mon, 14 Jan 2019 13:08:05 -0500 To: freebsd-geom@freebsd.org X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: A58116E758 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=C5/Nkn6Y; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vanderveldeag@gmail.com designates 2607:f8b0:4864:20::733 as permitted sender) smtp.mailfrom=vanderveldeag@gmail.com X-Spamd-Result: default: False [-6.23 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; TO_DN_NONE(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.95)[-0.951,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-geom@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(-2.77)[ip: (-9.72), ipnet: 2607:f8b0::/32(-2.31), asn: 15169(-1.77), country: US(-0.08)]; RCVD_IN_DNSWL_NONE(0.00)[3.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0] X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 18:08:08 -0000 Hi! Surprised by seeing streaks of zeros every 4k on my geli encrypted = drive, I realized they are zero-padded sectors (i.e. the 9th sector = underlying every encrypted 4K). I was wondering if it=E2=80=99d be a = good idea to do this instead: [freebsd .../geom/eli]$ svn diff Index: g_eli_integrity.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- g_eli_integrity.c (revision 343023) +++ g_eli_integrity.c (working copy) @@ -472,7 +472,7 @@ * only partially filled. */ if (bp->bio_cmd =3D=3D BIO_WRITE) - memset(data + sc->sc_alen + = data_secsize, 0, + arc4random_buf(data + sc->sc_alen + = data_secsize, encr_secsize - sc->sc_alen - = data_secsize); } [freebsd .../geom/eli]$ Thanks! =E2=80=94 Arjan