From owner-cvs-games Mon Sep 5 06:12:09 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id GAA04277 for cvs-games-outgoing; Mon, 5 Sep 1994 06:12:09 -0700 Received: (from bde@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id GAA04267; Mon, 5 Sep 1994 06:12:04 -0700 Date: Mon, 5 Sep 1994 06:12:04 -0700 From: Bruce Evans Message-Id: <199409051312.GAA04267@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-games, davidg, dyson, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/games Makefile Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk bde 94/09/05 06:12:03 Modified: games Makefile Log: Remove chess from subdirs. It doesn't exist. Add a missing right parentheses to an expression. From owner-cvs-games Tue Sep 6 11:34:39 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id LAA04765 for cvs-games-outgoing; Tue, 6 Sep 1994 11:34:39 -0700 Received: (from gpalmer@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id LAA04755; Tue, 6 Sep 1994 11:34:23 -0700 Date: Tue, 6 Sep 1994 11:34:23 -0700 From: Gary Palmer (FreeBSD/ARM Team) Message-Id: <199409061834.LAA04755@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-games, davidg, dyson, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/games/boggle Makefile Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk gpalmer 94/09/06 11:34:22 Modified: games/boggle Makefile Log: Add missing close brackets to two exists() statements From owner-cvs-games Wed Sep 7 20:56:11 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id UAA02442 for cvs-games-outgoing; Wed, 7 Sep 1994 20:56:11 -0700 Received: (from jkh@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id UAA02431; Wed, 7 Sep 1994 20:56:07 -0700 Date: Wed, 7 Sep 1994 20:56:07 -0700 From: "Jordan K. Hubbard" Message-Id: <199409080356.UAA02431@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-games, davidg, dyson, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/games/boggle Makefile Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk jkh 94/09/07 20:56:06 Modified: games/boggle Makefile Log: Make this install rule work properly. I screwed the pooch when I added the MKINDX stuff. Submitted by: jkh From owner-cvs-games Wed Sep 7 20:59:44 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id UAA02492 for cvs-games-outgoing; Wed, 7 Sep 1994 20:59:44 -0700 Received: (from jkh@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id UAA02482; Wed, 7 Sep 1994 20:59:38 -0700 Date: Wed, 7 Sep 1994 20:59:38 -0700 From: "Jordan K. Hubbard" Message-Id: <199409080359.UAA02482@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-games, davidg, dyson, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/games/boggle Makefile Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk jkh 94/09/07 20:59:38 Modified: games Makefile games/boggle Makefile Log: Fixup the .if exists() stuff I messed up the first time. Submitted by: jkh From owner-cvs-games Wed Sep 7 21:07:37 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id VAA02623 for cvs-games-outgoing; Wed, 7 Sep 1994 21:07:37 -0700 Received: (from jkh@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id VAA02613; Wed, 7 Sep 1994 21:07:30 -0700 Date: Wed, 7 Sep 1994 21:07:30 -0700 From: "Jordan K. Hubbard" Message-Id: <199409080407.VAA02613@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-games, davidg, dyson, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/games/ching/phx Makefile ching.phx.c pathnames.h Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk jkh 94/09/07 21:07:29 Modified: games Makefile Removed: games/ching Makefile ching.h games/ching/cno Makefile ching.cno.c games/ching/phx Makefile ching.phx.c pathnames.h Log: Nuke the ching port - it's highly bogus and I'm sure we can find another (better) one if we ever get overwhelmed by requests. Submitted by: jkh From owner-cvs-games Wed Sep 7 21:11:49 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id VAA02708 for cvs-games-outgoing; Wed, 7 Sep 1994 21:11:49 -0700 Received: (from jkh@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id VAA02698; Wed, 7 Sep 1994 21:11:47 -0700 Date: Wed, 7 Sep 1994 21:11:47 -0700 From: "Jordan K. Hubbard" Message-Id: <199409080411.VAA02698@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-games, davidg, dyson, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/games/phantasia Makefile Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk jkh 94/09/07 21:11:47 Modified: games/phantasia Makefile Log: More preventive medicine on making directories before installation. Submitted by: jkh From owner-cvs-games Wed Sep 7 21:15:39 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id VAA02762 for cvs-games-outgoing; Wed, 7 Sep 1994 21:15:39 -0700 Received: (from jkh@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id VAA02752; Wed, 7 Sep 1994 21:15:35 -0700 Date: Wed, 7 Sep 1994 21:15:35 -0700 From: "Jordan K. Hubbard" Message-Id: <199409080415.VAA02752@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-games, davidg, dyson, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/games/phantasia Makefile Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk jkh 94/09/07 21:15:35 Modified: games/phantasia Makefile Log: Woo, naughty! It just occurred to me that this guy wasn't using ${DESTDIR} - fixed. Submitted by: jkh From owner-cvs-games Wed Sep 7 21:18:02 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id VAA02815 for cvs-games-outgoing; Wed, 7 Sep 1994 21:18:02 -0700 Received: (from jkh@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id VAA02805; Wed, 7 Sep 1994 21:17:59 -0700 Date: Wed, 7 Sep 1994 21:17:59 -0700 From: "Jordan K. Hubbard" Message-Id: <199409080417.VAA02805@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-games, davidg, dyson, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/games/quiz Makefile Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk jkh 94/09/07 21:17:58 Modified: games/quiz Makefile Log: Make this work with missing dirs. Submitted by: jkh From owner-cvs-games Wed Sep 7 23:17:22 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id XAA03904 for cvs-games-outgoing; Wed, 7 Sep 1994 23:17:22 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.8/8.6.6) with ESMTP id XAA03896; Wed, 7 Sep 1994 23:16:53 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.8/8.6.6) id XAA26435; Wed, 7 Sep 1994 23:16:54 -0700 From: "Rodney W. Grimes" Message-Id: <199409080616.XAA26435@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/games/phantasia Makefile To: jkh@freefall.cdrom.com (Jordan K. Hubbard) Date: Wed, 7 Sep 1994 23:16:53 -0700 (PDT) Cc: ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-games@freefall.cdrom.com, davidg@freefall.cdrom.com, dyson@freefall.cdrom.com, gpalmer@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, jkh@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, paul@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com In-Reply-To: <199409080411.VAA02698@freefall.cdrom.com> from "Jordan K. Hubbard" at Sep 7, 94 09:11:47 pm X-Mailer: ELM [version 2.4 PL23] Content-Type: text Content-Length: 659 Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk > > jkh 94/09/07 21:11:47 > > Modified: games/phantasia Makefile > Log: > More preventive medicine on making directories before installation. > Submitted by: jkh No single Makefile in /usr/src should in any way shape of form should being doing a mkdir command. This is what mtree and etc/mtree/BSD.* are for and this is what /usr/src/Makefile directories: is for. If there was a mkdir command in as BSD Makefile it sould be removed and replaced with the proper mtree entrie(s). -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD From owner-cvs-games Thu Sep 8 00:19:50 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id AAA05494 for cvs-games-outgoing; Thu, 8 Sep 1994 00:19:50 -0700 Received: (from rgrimes@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id AAA05484; Thu, 8 Sep 1994 00:19:46 -0700 Date: Thu, 8 Sep 1994 00:19:46 -0700 From: "Rodney W. Grimes" Message-Id: <199409080719.AAA05484@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-games, davidg, dyson, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/games/boggle Makefile Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk rgrimes 94/09/08 00:19:46 Modified: games/boggle Makefile Log: Remove mkdir for installation directory, it is now handled by mtree. From owner-cvs-games Thu Sep 8 03:51:56 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id DAA09910 for cvs-games-outgoing; Thu, 8 Sep 1994 03:51:56 -0700 Received: (from bde@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id DAA09900; Thu, 8 Sep 1994 03:51:50 -0700 Date: Thu, 8 Sep 1994 03:51:50 -0700 From: Bruce Evans Message-Id: <199409081051.DAA09900@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-games, davidg, dyson, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/games/fortune Makefile Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk bde 94/09/08 03:51:49 Modified: games/fortune Makefile Log: Add datfiles to SUBDIR for obj target too. "make install" wrote to the source directory and failed when the source directory was nfs mounted. This was fixed in 1.1.5. Sigh. From owner-cvs-games Thu Sep 8 11:49:09 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id LAA17241 for cvs-games-outgoing; Thu, 8 Sep 1994 11:49:09 -0700 Received: (from jkh@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id LAA17231; Thu, 8 Sep 1994 11:49:00 -0700 Date: Thu, 8 Sep 1994 11:49:00 -0700 From: "Jordan K. Hubbard" Message-Id: <199409081849.LAA17231@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-games, davidg, dfr, dyson, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/games Makefile Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk jkh 94/09/08 11:48:59 Modified: games Makefile Log: Gack - this was totally broken. Reviewed by: Submitted by: From owner-cvs-games Thu Sep 8 12:15:55 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id MAA17866 for cvs-games-outgoing; Thu, 8 Sep 1994 12:15:55 -0700 Received: (from jkh@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id MAA17854; Thu, 8 Sep 1994 12:15:49 -0700 Date: Thu, 8 Sep 1994 12:15:49 -0700 From: "Jordan K. Hubbard" Message-Id: <199409081915.MAA17854@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-games, davidg, dfr, dyson, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/games/x11/xroach Makefile Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk jkh 94/09/08 12:15:48 Modified: games/x11/xneko Makefile games/x11/xroach Makefile Log: Sigh. Ok, now that these have been uncovered by fixing the Makefile, make them work! :-) Just include ${X11BASE}/include in the CFLAGS, basically. Submitted by: jkh From owner-cvs-games Thu Sep 8 12:19:57 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id MAA18100 for cvs-games-outgoing; Thu, 8 Sep 1994 12:19:57 -0700 Received: (from jkh@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id MAA18090; Thu, 8 Sep 1994 12:19:50 -0700 Date: Thu, 8 Sep 1994 12:19:50 -0700 From: "Jordan K. Hubbard" Message-Id: <199409081919.MAA18090@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-games, davidg, dfr, dyson, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/games/phantasia Makefile Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk jkh 94/09/08 12:19:49 Modified: games/phantasia Makefile Log: Remove the conditional mkdir of /var/games/phantasia - done by mtree now. Submitted by: jkh From owner-cvs-games Thu Sep 8 13:01:59 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id NAA20384 for cvs-games-outgoing; Thu, 8 Sep 1994 13:01:59 -0700 Received: (from jkh@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id NAA20362; Thu, 8 Sep 1994 13:01:47 -0700 Date: Thu, 8 Sep 1994 13:01:47 -0700 From: "Jordan K. Hubbard" Message-Id: <199409082001.NAA20362@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-games, davidg, dfr, dyson, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/games/monop Makefile brd.dat cards.c cards.inp deck.h execute.c getinp.c houses.c initdeck.c jail.c misc.c mon.dat monop.6 monop.c monop.def monop.ext monop.h morg.c pathnames.h print.c prop.c prop.dat rent.c roll.c spec.c trade.c Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk jkh 94/09/08 13:01:45 Modified: games Makefile Removed: games/monop Makefile brd.dat cards.c cards.inp deck.h execute.c getinp.c houses.c initdeck.c jail.c misc.c mon.dat monop.6 monop.c monop.def monop.ext monop.h morg.c pathnames.h print.c prop.c prop.dat rent.c roll.c spec.c trade.c Log: Nuke monop - we don't need any grief from Parker Brothers on their copyrighted and trademarked game. Reviewed by: jkh Submitted by: sef From owner-cvs-games Fri Sep 9 05:19:37 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id FAA06953 for cvs-games-outgoing; Fri, 9 Sep 1994 05:19:37 -0700 Received: (from rgrimes@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id FAA06943; Fri, 9 Sep 1994 05:19:33 -0700 Date: Fri, 9 Sep 1994 05:19:33 -0700 From: "Rodney W. Grimes" Message-Id: <199409091219.FAA06943@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-games, davidg, dfr, dyson, gclarkii, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/games/boggle Makefile Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk rgrimes 94/09/09 05:19:32 Modified: games/boggle Makefile Log: No longer use installed binary data files for input, use ../../share/dict/web2 as the input file for the dictionary. From owner-cvs-games Fri Sep 9 10:03:54 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id KAA14080 for cvs-games-outgoing; Fri, 9 Sep 1994 10:03:54 -0700 Received: (from jkh@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id KAA14050; Fri, 9 Sep 1994 10:03:45 -0700 Date: Fri, 9 Sep 1994 10:03:45 -0700 From: "Jordan K. Hubbard" Message-Id: <199409091703.KAA14050@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-games, davidg, dfr, dyson, gclarkii, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/games/x11 Makefile Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk jkh 94/09/09 10:03:44 Added: games/x11 Makefile Log: How embarassing. I totally forgot to cvs add this thing. Thanks, Rod! Submitted by: jkh From owner-cvs-games Fri Sep 9 10:24:43 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id KAA15294 for cvs-games-outgoing; Fri, 9 Sep 1994 10:24:43 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.8/8.6.6) with ESMTP id KAA15270; Fri, 9 Sep 1994 10:24:04 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.8/8.6.6) id KAA11750; Fri, 9 Sep 1994 10:24:03 -0700 From: "Rodney W. Grimes" Message-Id: <199409091724.KAA11750@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/games/x11 Makefile To: jkh@freefall.cdrom.com (Jordan K. Hubbard) Date: Fri, 9 Sep 1994 10:24:02 -0700 (PDT) Cc: ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-games@freefall.cdrom.com, davidg@freefall.cdrom.com, dfr@freefall.cdrom.com, dyson@freefall.cdrom.com, gclarkii@freefall.cdrom.com, gpalmer@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, jkh@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, paul@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com In-Reply-To: <199409091703.KAA14050@freefall.cdrom.com> from "Jordan K. Hubbard" at Sep 9, 94 10:03:45 am X-Mailer: ELM [version 2.4 PL23] Content-Type: text Content-Length: 746 Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk > > jkh 94/09/09 10:03:44 ^^^ > > Added: games/x11 Makefile > Log: > How embarassing. I totally forgot to cvs add this thing. Thanks, Rod! ^^^^^^^^^^ > Submitted by: jkh ^^^ And here it is again!!! > Now WHO submitted it? And who reviewed it? Can we slow down a little and be more carefull. Quite a bit of my time last night was spent cleaning up behind others :-(. I am NOT meaning this directed towards you Jordan, it applies to many of the commit access people. [Even I blew a few of the submit/review lines last night. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD From owner-cvs-games Fri Sep 9 10:33:14 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id KAA15526 for cvs-games-outgoing; Fri, 9 Sep 1994 10:33:14 -0700 Received: from localhost (localhost [127.0.0.1]) by freefall.cdrom.com (8.6.8/8.6.6) with SMTP id KAA15515; Fri, 9 Sep 1994 10:33:06 -0700 X-Authentication-Warning: freefall.cdrom.com: Host localhost didn't use HELO protocol To: "Rodney W. Grimes" cc: jkh@freefall.cdrom.com (Jordan K. Hubbard), ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-games@freefall.cdrom.com, davidg@freefall.cdrom.com, dfr@freefall.cdrom.com, dyson@freefall.cdrom.com, gclarkii@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, paul@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com Subject: Re: cvs commit: src/games/x11 Makefile In-reply-to: Your message of "Fri, 09 Sep 94 10:24:02 PDT." <199409091724.KAA11750@gndrsh.aac.dev.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Date: Fri, 09 Sep 1994 10:33:05 -0700 Message-ID: <15514.779131985@freefall.cdrom.com> From: Gary Palmer (FreeBSD/ARM Team) Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk In message <199409091724.KAA11750@gndrsh.aac.dev.com>, "Rodney W. Grimes" write s: >Now WHO submitted it? And who reviewed it? Can we slow down a little and >be more carefull. Quite a bit of my time last night was spent cleaning up >behind others :-(. >I am NOT meaning this directed towards you Jordan, it applies to many of >the commit access people. [Even I blew a few of the submit/review lines >last night. Right - can I be clear about this point please? If I make a trivial bug fix, I nuke both the 'Submitted by:' and 'Reviewed By:' lines. If I make a non-trivial change to the system, I get someone else to check it over first, then put their (freefall e-mail addr?) in the Reviewed By: line? If someone asks me (unlikely, but possible) to make a change, I put their e-mail addr & name on the 'Submitted By:' line? Do I also add my addr to the Reviewed By: line (assuming I did the sensible thing and checked it before doing a cvs commit)? Thanks Gary (a cvs newbie) From owner-cvs-games Fri Sep 9 11:31:20 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id LAA18495 for cvs-games-outgoing; Fri, 9 Sep 1994 11:31:20 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.8/8.6.6) with ESMTP id LAA18449; Fri, 9 Sep 1994 11:30:43 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.8/8.6.6) id LAA12050; Fri, 9 Sep 1994 11:30:48 -0700 From: "Rodney W. Grimes" Message-Id: <199409091830.LAA12050@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/games/x11 Makefile To: gpalmer@freefall.cdrom.com (Gary Palmer) Date: Fri, 9 Sep 1994 11:30:47 -0700 (PDT) Cc: jkh@freefall.cdrom.com, ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-games@freefall.cdrom.com, davidg@freefall.cdrom.com, dfr@freefall.cdrom.com, dyson@freefall.cdrom.com, gclarkii@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, paul@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com In-Reply-To: <15514.779131985@freefall.cdrom.com> from "Gary Palmer" at Sep 9, 94 10:33:05 am X-Mailer: ELM [version 2.4 PL23] Content-Type: text Content-Length: 3042 Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk > > In message <199409091724.KAA11750@gndrsh.aac.dev.com>, "Rodney W. Grimes" write > s: > >Now WHO submitted it? And who reviewed it? Can we slow down a little and > >be more carefull. Quite a bit of my time last night was spent cleaning up > >behind others :-(. > > >I am NOT meaning this directed towards you Jordan, it applies to many of > >the commit access people. [Even I blew a few of the submit/review lines > >last night. > > Right - can I be clear about this point please? I will try to clear the evedintally very muddy water :-). > If I make a trivial bug fix, > I nuke both the 'Submitted by:' and 'Reviewed By:' lines. Right. Since in this case you are the submitter, and we hope you reviewed your own trivial fix before commiting by doing some kind of test. > If I make > a non-trivial change to the system, I get someone else to check it > over first, then put their (freefall e-mail addr?) in the Reviewed By: line? Yes, or there name if they are not a freefall user. Say for instance I find bug garp in vi, I hack away at it, find the problem, come up with what I think to be a good patch. I take that patch and send it to say, well.. Keith Bostic. He looks it over, says, yea, right, thanks for the fix. You now put Keith Bostic on the reviewed by line. The reviewed by line does NOT have to even be a FreeBSD developer or commit person. It can be anyone who has a reasonable knowledge of the code being dealt with. > If someone asks me (unlikely, but possible) to make a change, I put their > e-mail addr & name on the 'Submitted By:' line? Yes! > Do I also add my addr to the Reviewed By: line (assuming I did the > sensible thing and checked it before doing a cvs commit)? No, the action of committing someone elses work tells me that you are the person who did the review. And this is important, often a patch or change will be posted by a user to one of our lists, the patch may or maynot be complete or even the correct thing to do. Take for instance my recent commit of the libg++ fixes. I looked them over, they do indead fix the symptoms of the problem, but they go about it by modifing a file that is clearly labeled do not modify this file as it is computer generated. I noted this fact in the commit message, in the file I wrongly modified, and made a plea for someone with more time and g++ expertise to go fix it the right way. IMHO I did a pretty complete job of looking the patch over, and pointing to the correct way to fix it, and made things work until we can fix it. Note that even with out my balking about the change to the file even the change that was submitted was not quite right, and I fixed that before the commit (FYI, the #include was OUTSIDE the #ifdef omnipotenet protection and it should really be inside it, a very minor nit). > Gary (a cvs newbie) We where all in that state at one time or another :-). -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD From owner-cvs-games Fri Sep 9 12:23:19 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id MAA24495 for cvs-games-outgoing; Fri, 9 Sep 1994 12:23:19 -0700 Received: from localhost (localhost [127.0.0.1]) by freefall.cdrom.com (8.6.8/8.6.6) with SMTP id MAA24456; Fri, 9 Sep 1994 12:22:46 -0700 X-Authentication-Warning: freefall.cdrom.com: Host localhost didn't use HELO protocol To: "Rodney W. Grimes" cc: ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-games@freefall.cdrom.com, davidg@freefall.cdrom.com, dfr@freefall.cdrom.com, dyson@freefall.cdrom.com, gclarkii@freefall.cdrom.com, gpalmer@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, paul@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com Subject: Re: cvs commit: src/games/x11 Makefile In-reply-to: Your message of "Fri, 09 Sep 94 10:24:02 PDT." <199409091724.KAA11750@gndrsh.aac.dev.com> Date: Fri, 09 Sep 1994 12:22:45 -0700 Message-ID: <24455.779138565@freefall.cdrom.com> From: "Jordan K. Hubbard" Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk > > Added: games/x11 Makefile > > Log: > > How embarassing. I totally forgot to cvs add this thing. Thanks, Rod! > ^^^^^^^^^^ > > Submitted by: jkh > ^^^ > > And here it is again!!! > > > > Now WHO submitted it? And who reviewed it? Can we slow down a little and > be more carefull. Quite a bit of my time last night was spent cleaning up > behind others :-(. Well now wait.. I did submit it! It was _my_ Makefile, which I simply forgot to add. Sure, you yelled at me about not having one, but this just jogged me into doing what I should have done all in one go. You're saying I shouldn't put "Submitted by" in my own work? Now you're really confusing me here. I'm trying to do the right thing, but it doesn't help when you have 2 different versions of what the right thing is!!!! Please clarify your position WRT "Submitted by" lines ASAP. Jordan From owner-cvs-games Sat Sep 10 11:53:42 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id LAA22126 for cvs-games-outgoing; Sat, 10 Sep 1994 11:53:42 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.8/8.6.6) with ESMTP id LAA22118; Sat, 10 Sep 1994 11:53:13 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.8/8.6.6) id LAA14062; Sat, 10 Sep 1994 11:53:16 -0700 From: "Rodney W. Grimes" Message-Id: <199409101853.LAA14062@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/games/x11 Makefile To: jkh@freefall.cdrom.com (Jordan K. Hubbard) Date: Sat, 10 Sep 1994 11:53:16 -0700 (PDT) Cc: ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-games@freefall.cdrom.com, davidg@freefall.cdrom.com, dfr@freefall.cdrom.com, dyson@freefall.cdrom.com, gclarkii@freefall.cdrom.com, gpalmer@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, paul@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com In-Reply-To: <24455.779138565@freefall.cdrom.com> from "Jordan K. Hubbard" at Sep 9, 94 12:22:45 pm X-Mailer: ELM [version 2.4 PL23] Content-Type: text Content-Length: 1493 Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk > > > > Added: games/x11 Makefile > > > Log: > > > How embarassing. I totally forgot to cvs add this thing. Thanks, Rod! > > ^^^^^^^^^^ > > > Submitted by: jkh > > ^^^ > > > > And here it is again!!! > > > > > > > Now WHO submitted it? And who reviewed it? Can we slow down a little and > > be more carefull. Quite a bit of my time last night was spent cleaning up > > behind others :-(. > > Well now wait.. I did submit it! It was _my_ Makefile, which I simply > forgot to add. Sure, you yelled at me about not having one, but this > just jogged me into doing what I should have done all in one go. > > You're saying I shouldn't put "Submitted by" in my own work? Yes, that is exactly what I am saying. THe commit message already says you commited it. THe submitted by is thus redundant, and having log files full of reduntant info is just ugly. > Now you're really confusing me here. I'm trying to do the right > thing, but it doesn't help when you have 2 different versions of what > the right thing is!!!! Please clarify your position WRT "Submitted by" > lines ASAP. I think Paul R. posted what should be commited as the new rcstemplate file, plus the ``Liberated from: NetBSD'' line. If someone has not already commited this, I will as soon as my email is read. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD From owner-cvs-games Sat Sep 10 15:31:06 1994 Return-Path: cvs-games-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id PAA01903 for cvs-games-outgoing; Sat, 10 Sep 1994 15:31:06 -0700 Received: (from jkh@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id PAA01890; Sat, 10 Sep 1994 15:31:01 -0700 Date: Sat, 10 Sep 1994 15:31:01 -0700 From: "Jordan K. Hubbard" Message-Id: <199409102231.PAA01890@freefall.cdrom.com> To: ache, adam, alm, ats, bde, csgr, cvs-games, davidg, dfr, dyson, gclarkii, gpalmer, guido, hsu, jkh, joerg, julian, jvh, karl, martin, nate, paul, phk, proven, pst, rgrimes, rich, se, sean, sef, smace, sos, torstenb, wollman Subject: cvs commit: src/games/x11 Makefile Sender: cvs-games-owner@freefall.cdrom.com Precedence: bulk jkh 94/09/10 15:31:00 Modified: games/x11 Makefile Log: More properly include ../../Makefile.inc from Makefiles. Reviewed by: jkh Submitted by: rgrimes