From owner-cvs-lib Sun Jul 24 13:55:16 1994 Return-Path: cvs-lib-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id NAA29681 for cvs-lib-outgoing; Sun, 24 Jul 1994 13:55:16 -0700 Received: (from phk@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id NAA29670; Sun, 24 Jul 1994 13:55:13 -0700 Date: Sun, 24 Jul 1994 13:55:13 -0700 From: Poul-Henning Kamp Message-Id: <199407242055.NAA29670@freefall.cdrom.com> To: ache, alm, ats, csgr, cvs-lib, davidg, dyson, jkh, jvh, karl, nate, paul, phk, pst, rgrimes, rich, sean, smace, sos, wollman Subject: cvs commit: src/lib/libmd .depend Sender: cvs-lib-owner@freefall.cdrom.com Precedence: bulk phk 94/07/24 13:55:12 Removed: lib/libmd .depend Log: Reviewed by: phk zapped a .depend which had crept in. From owner-cvs-lib Sun Jul 24 22:26:39 1994 Return-Path: cvs-lib-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id WAA04308 for cvs-lib-outgoing; Sun, 24 Jul 1994 22:26:39 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.8/8.6.6) with ESMTP id WAA04302; Sun, 24 Jul 1994 22:26:28 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.8/8.6.6) id WAA24861; Sun, 24 Jul 1994 22:23:40 -0700 From: "Rodney W. Grimes" Message-Id: <199407250523.WAA24861@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/lib/libmd .depend To: phk@freefall.cdrom.com (Poul-Henning Kamp) Date: Sun, 24 Jul 1994 22:23:39 -0700 (PDT) Cc: ache@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-lib@freefall.cdrom.com, davidg@freefall.cdrom.com, dyson@freefall.cdrom.com, jkh@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, nate@freefall.cdrom.com, paul@freefall.cdrom.com, phk@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, sean@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, wollman@freefall.cdrom.com In-Reply-To: <199407242055.NAA29670@freefall.cdrom.com> from "Poul-Henning Kamp" at Jul 24, 94 01:55:13 pm X-Mailer: ELM [version 2.4 PL23] Content-Type: text Content-Length: 1033 Sender: cvs-lib-owner@freefall.cdrom.com Precedence: bulk > > phk 94/07/24 13:55:12 > > Removed: lib/libmd .depend > Log: > Reviewed by: phk ^^^^^^^^^^^^^^^^^^^^^^^^^^^ > zapped a .depend which had crept in. > You are not reading what it says.... you are the author of this patch: CVS: Delete the ``Reviewed by'' line if this is somebody else's work CVS: Delete the ``Submitted by'' line if this is NOT somebody else's CVS: work (you are the author). This should have looked like this: phk 94/07/24 13:55:12 Removed: lib/libmd .depend Log: Submitted by: phk zapped a .depend which had crept in. And note.. this was a trivial thing that really does not warrant review, but be thinking about haveing all changes reviewed... so you can fill in BOTH lines... and probably stop a lot of bad commits. That is what I believe Garrett had in mind when he added the rcstemplate stuff. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD From owner-cvs-lib Mon Jul 25 09:57:45 1994 Return-Path: cvs-lib-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.8/8.6.6) id JAA08995 for cvs-lib-outgoing; Mon, 25 Jul 1994 09:57:45 -0700 Received: from tfs.com (mailhub.tfs.COM [140.145.250.1]) by freefall.cdrom.com (8.6.8/8.6.6) with SMTP id JAA08989; Mon, 25 Jul 1994 09:57:36 -0700 Received: by tfs.com (smail3.1.28.1) Message-Id: From: phk@tfs.com (Poul-Henning Kamp) Subject: Re: cvs commit: src/lib/libmd .depend To: rgrimes@gndrsh.aac.dev.com (Rodney W. Grimes) Date: Mon, 25 Jul 1994 09:58:11 -0700 (PDT) Cc: phk@freefall.cdrom.com, ache@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-lib@freefall.cdrom.com, davidg@freefall.cdrom.com, dyson@freefall.cdrom.com, jkh@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, nate@freefall.cdrom.com, paul@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, sean@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, wollman@freefall.cdrom.com In-Reply-To: <199407250523.WAA24861@gndrsh.aac.dev.com> from "Rodney W. Grimes" at Jul 24, 94 10:23:39 pm X-Mailer: ELM [version 2.4 PL23] Content-Type: text Content-Length: 1266 Sender: cvs-lib-owner@freefall.cdrom.com Precedence: bulk > And note.. this was a trivial thing that really does not warrant review, > but be thinking about haveing all changes reviewed... so you can fill > in BOTH lines... and probably stop a lot of bad commits. That is what > I believe Garrett had in mind when he added the rcstemplate stuff. I think I must have misunderstood you when we talked about it then. I thought the Reviewed by line was supposed to be there >in any case< as "who to point the gun at". Garretts CVS-INFO makes this somewhat clearer, but I still miss the "step-by-step manual". For instance Garrett insist that libmd should have been "cvs add"'ed instead of imported. I disagree. If libmd had had just a couple of subdirs that would have been a royal pain to do, with much bigger risk of errors. I'd like to restate my caution against the "2nd system syndrome" again: I know that we had a couple of bad commits during before 2.0, but we should NOT make it too difficult for people to submit changes, or FreeBSD will stall. We have to make an tradeoff here. I'm all for reviews, except they should be swift and not hold up things which are OK. -- Poul-Henning Kamp TRW Financial Systems, Inc. FreeBSD has, until now, not one single time had an undetected error. :-)