From owner-cvs-ports Sun May 21 15:37:58 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id PAA00478 for cvs-ports-outgoing; Sun, 21 May 1995 15:37:58 -0700 Received: (from jhs@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id PAA00464 ; Sun, 21 May 1995 15:37:50 -0700 Date: Sun, 21 May 1995 15:37:50 -0700 From: Julian Stacey Message-Id: <199505212237.PAA00464@freefall.cdrom.com> To: CVS-commiters, cvs-ports Subject: cvs commit: ports/comms/hylafax - Imported sources Sender: cvs-ports-owner@freebsd.org Precedence: bulk jhs 95/05/21 15:37:50 Log: Reviewed by: Earlier draft reviewed by Satoshi (Thanks) A new import based on Sam Leffler's Hylafax V3.0pl0. Flexfax is now obsolete. Import includes & applies the base patch Sam posted on the flexfax mail list (mail list is still called flexfax, though the package is called Hylafax). Sam declared our ports/comms/flexfax to be obsolete (over a year old). Sometime after the CD release, I will post a proposal to remove ports/comms/flexfax. I will maintain ports/comms/hylafax as I need fax capability. Thanks to Asami Satoshi for suggested improvements, I leave him to `bless' this port by adding the final comms/Makefile: SUBDIR += hylafax Until he does that, any mistakes I may have made shouldnt break any makes :-) I've undoubtedly screwed something up, somewhere, its a big port (30M inc bins),please test, Oh... and "Share & Enjoy" :-) --- Julian Stacey Tel. +49 89 268616. Fax Modem: 2608126 http://www.regent.e-technik.tu-muenchen.de/people/jhs.html Status: Vendor Tag: hylafax Release Tags: hylafax_3_0_0 N ports/comms/hylafax/Makefile N ports/comms/hylafax/files/md5 N ports/comms/hylafax/files/lutRS18.Makefile N ports/comms/hylafax/files/lutRS18.bdf.diff N ports/comms/hylafax/patches/patch-aa N ports/comms/hylafax/patches/patch-ab N ports/comms/hylafax/patches/patch-ac N ports/comms/hylafax/patches/patch-ad N ports/comms/hylafax/pkg/COMMENT N ports/comms/hylafax/pkg/DESCR N ports/comms/hylafax/pkg/PLIST N ports/comms/hylafax/pkg/README No conflicts created by this import From owner-cvs-ports Sun May 21 18:32:16 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id SAA03732 for cvs-ports-outgoing; Sun, 21 May 1995 18:32:16 -0700 Received: (from asami@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id SAA03719 ; Sun, 21 May 1995 18:32:04 -0700 Date: Sun, 21 May 1995 18:32:04 -0700 From: Satoshi Asami Message-Id: <199505220132.SAA03719@freefall.cdrom.com> To: CVS-commiters, cvs-ports Subject: cvs commit: ports/comms/hylafax/files md5 Sender: cvs-ports-owner@freebsd.org Precedence: bulk asami 95/05/21 18:32:04 Modified: comms/hylafax Makefile comms/hylafax/files md5 Log: Reduce the brokenness of this port a little by adding "EXTRACT_SUFX=-tar.gz" and taking out all the echo's in pre-fetch that complains how it doesn't work. Reorder some variables, take out the numerous KEYWORD lines, etc. This port is still broken rather badly. For starters, there are 17 chunks of failing patches. From owner-cvs-ports Sun May 21 18:42:58 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id SAA04153 for cvs-ports-outgoing; Sun, 21 May 1995 18:42:58 -0700 Received: from silvia.HIP.Berkeley.EDU (silvia.HIP.Berkeley.EDU [136.152.64.181]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id SAA04144 ; Sun, 21 May 1995 18:42:52 -0700 Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.6.11/8.6.9) id SAA18778; Sun, 21 May 1995 18:42:50 -0700 Date: Sun, 21 May 1995 18:42:50 -0700 Message-Id: <199505220142.SAA18778@silvia.HIP.Berkeley.EDU> To: jhs@freefall.cdrom.com CC: CVS-commiters@freefall.cdrom.com, cvs-ports@freefall.cdrom.com In-reply-to: <199505212237.PAA00464@freefall.cdrom.com> (message from Julian Stacey on Sun, 21 May 1995 15:37:50 -0700) Subject: Re: cvs commit: ports/comms/hylafax - Imported sources From: asami@cs.berkeley.edu (Satoshi Asami | =?ISO-2022-JP?B?GyRCQHUbKEI=?= =?ISO-2022-JP?B?GyRCOCsbKEIgGyRCOC0bKEI=?=) Sender: cvs-ports-owner@freebsd.org Precedence: bulk * Reviewed by: Earlier draft reviewed by Satoshi (Thanks) Julian, I asked you to send me a mail when you are done, not to commit it. All I did at that time was to make some comments on your 100+ line Makefile, I haven't taken a look at any of your numerous auxiliary scripts and I haven't done any testing. I regret your decision to ignore what I said. * I will maintain ports/comms/hylafax as I need fax capability. You haven't demonstrated you can maintain the port (see below), this isn't an excuse to import something I can't understand. * Thanks to Asami Satoshi for suggested improvements, * I leave him to `bless' this port by adding the final * comms/Makefile: SUBDIR += hylafax * Until he does that, any mistakes I may have made shouldnt break * any makes :-) You don't understand. I do NOT want a broken or messy port in the tree. Whether it's referred to by the parent Makefile is irrelevant, and I want NO ports in the BROKEN list, that list exists for things that worked before but don't anymore because of one reason or another, not to squeeze in things that are known to be broken to begin with. I tried to fix the Makefile now, added EXTRACT_SUFX and deleted the useless echo statements in the pre-fetch target, re-made the checksums but it now has 17 (!) failed hunks of patches. If you can't fix this within 24 hours, expect it to be purged from the repository and replaced by another, simpler and working version. Satoshi From owner-cvs-ports Sun May 21 18:47:02 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id SAA04291 for cvs-ports-outgoing; Sun, 21 May 1995 18:47:02 -0700 Received: from silvia.HIP.Berkeley.EDU (silvia.HIP.Berkeley.EDU [136.152.64.181]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id SAA04283 ; Sun, 21 May 1995 18:46:58 -0700 Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.6.11/8.6.9) id SAA18797; Sun, 21 May 1995 18:46:56 -0700 Date: Sun, 21 May 1995 18:46:56 -0700 Message-Id: <199505220146.SAA18797@silvia.HIP.Berkeley.EDU> To: jhs@freefall.cdrom.com CC: CVS-commiters@freefall.cdrom.com, cvs-ports@freefall.cdrom.com In-reply-to: <199505220142.SAA18778@silvia.HIP.Berkeley.EDU> (asami@cs.berkeley.edu) Subject: Re: cvs commit: ports/comms/hylafax - Imported sources From: asami@cs.berkeley.edu (Satoshi Asami | =?ISO-2022-JP?B?GyRCQHUbKEI=?= =?ISO-2022-JP?B?GyRCOCsbKEIgGyRCOC0bKEI=?=) Sender: cvs-ports-owner@freebsd.org Precedence: bulk * If you can't fix this within 24 hours, expect it to be purged from the * repository and replaced by another, simpler and working version. By the way, don't commit anything, if you think you got it fixed, send me a mail with a pointer to the updated port, ok? Satoshi From owner-cvs-ports Mon May 22 09:27:38 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id JAA27655 for cvs-ports-outgoing; Mon, 22 May 1995 09:27:38 -0700 Received: (from ache@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id JAA27644 ; Mon, 22 May 1995 09:27:34 -0700 Date: Mon, 22 May 1995 09:27:34 -0700 From: "Andrey A. Chernov" Message-Id: <199505221627.JAA27644@freefall.cdrom.com> To: CVS-commiters, cvs-ports Subject: cvs commit: ports/net/ncftp2/patches patch-ab Sender: cvs-ports-owner@freebsd.org Precedence: bulk ache 95/05/22 09:27:33 Added: net/ncftp2/patches patch-ab Log: Fix divide by zero bug From owner-cvs-ports Mon May 22 16:31:21 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id QAA01094 for cvs-ports-outgoing; Mon, 22 May 1995 16:31:21 -0700 Received: from vector.eikon.e-technik.tu-muenchen.de (vector.eikon.e-technik.tu-muenchen.de [129.187.142.36]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id QAA00953 ; Mon, 22 May 1995 16:29:30 -0700 Received: from localhost (localhost [127.0.0.1]) by vector.eikon.e-technik.tu-muenchen.de (8.6.11/8.6.9) with SMTP id AAA07935; Tue, 23 May 1995 00:16:49 +0200 Message-Id: <199505222216.AAA07935@vector.eikon.e-technik.tu-muenchen.de> X-Authentication-Warning: vector.eikon.e-technik.tu-muenchen.de: Host localhost didn't use HELO protocol To: asami@cs.berkeley.edu (Satoshi Asami | =?ISO-2022-JP?B?GyRCQHUbKEI=?= =?ISO-2022-JP?B?GyRCOCsbKEIgGyRCOC0bKEI=?=) cc: jhs@freefall.cdrom.com, CVS-commiters@freefall.cdrom.com, cvs-ports@freefall.cdrom.com Subject: Re: cvs commit: ports/comms/hylafax - Imported sources In-reply-to: Your message of "Mon, 22 May 1995 03:42:50 +0200." <199505220142.SAA18778@silvia.HIP.Berkeley.EDU> Date: Tue, 23 May 1995 00:16:48 +0200 From: Julian Howard Stacey Sender: cvs-ports-owner@freebsd.org Precedence: bulk Satoshi, You've made several references to my supposedly rotten Hylafax port ... - You wrote I had comitted a bad port, - You threatened to delete it in 24 hours. ! - You hacked it & the patches don't apply to the new (wrong) distfile, (& to be fair, some bits are improved, thanks). I agree what now lies in ports (Ref. ctm 438) does Not work, that is because I made one mistake, & you made more :-( Your threat/promise to delete it, I treat as mixed, as I don't want that hacked up port in there, but I do want my working port (& yes, I'd like your good hacks on top, too please :-) Fortunately I've realised where we both went wrong (in different places, useful to know to avoid for future) & offer 2 alternative solutions further below :-) ---- First however, let me disprove your statements about a bad port: Yes FreeBSD Hylafax is broken ! It is also Not what I committed. Anyone who doubts My version Compiles & Works: I can prove it - just mail me : - Your email address for private email receipt of a 70K typescript of hylafax (my version as originally committed, recompiled today on my host (commands from ctm src 645, older kernel) - Your fax number, so I can fax you (or preferably a friend you name in Germany (cheaper for me than faxing internationally) ! - Your login name & a some way encrypted password for this host, so I can grant your temporary login here when I'm next dial-up slip connected. There are people on this list that know I have a working Hylafax here. I've already faxed them with it weeks ago. Anyone who merely wants a port or package of Hylafax on FreeBSD can also `roll their own': grab the distfile I worked from, & my original port tree in freefall.cdrom.com:~jhs/hylafax* (PS my home system is currently based on src ctm 645, except older kernel). ---- > All I did at that time was to make some comments on your 100+ line Makefile, Useful comments too, most (perhaps all) incorporated, Thanks :-) ---- > Julian, I asked you to send me a mail when you are done, not to commit it. That puzzled me, it contradicted what you had posted earlier, The attempted interactive micro-management of this port initial commit was unexpected, you shifted targets from a `Hylafax now for the CD', to a stance of `ideal styelised port of Hylafax, no matter if it makes it on to the CD'. You had earlier written you wanted hylafax ( & had chased for it). You had earlier written we were in code freeze _except for new ports_ (go check your outgoing posting log if in doubt) So I worked hard & long, exclusively on Hylafax, to get a working error free port to contribute, then as my IP access availability was intermittent, & as talk sessions between us don't work well, what with timezones, & tiredness one end, & a ticking stopwatch reminding me of telecom modem charges the other end, I commited the New Port while I could, as soon as complete, to give us a Working Port before the impending CD deadline. Interactive work between us isn't ideal, eg when you're tiredly composing a `talk' message & I have an appointment pressing, while also hearing my stopwatch ticking at peak telecom modem rate. I'm not on line except when I pay to be, & it is not a good idea for us to try to work interactively together on one port. Better either of us alone. Interactive is better in adjacent timezones, with permanent IP connectivity, not dial-up. I understood I had a mandate to provide a New Port, I considered myself bound not to change it after commit, & to consider it frozen, _once_ it was integrated, but I had not realise you intended to micro-manage this little project prior to initial commit. ---- > I haven't taken a look at any of your numerous > auxiliary scripts and I haven't done any testing. Don't worry, `cd /usr/ports; make' does NOT use this tree yet (I very deliberately added no SUBDIR += hylafax in comms/Makefile), thus it Cannot break the ports tree, precisely until such time as you have had time to look, & do decide to add SUBDIR += hylafax. Unless you own & rely on a fax modem as I do, my actual software_in_use as compiled, installed, & used on day of commit, is more `tested' anyway. ---- One thing I did not do was refetch the distfile, to check it had unchanged content, (I didn't as I have a _slow_ link here in Munich), I _did_ check it was still on the same distribution site with the same name. I did not ftp it to freefall/thud & run md5 or make on it there, as that would have been difficult & slow (it's 30M), though I could have nohup make'd it. Anyway, that's what files/md5 checks for, & even if I'd checked it, it could have changed straight after (& indeed may change yet again (hope not)). ---- When you took my commited port, You ignored my original committed md5 (ab3bdeee68a6cd64c270e09dffe928e7) & commited a new md5 (014ec8a64ea7493d26c50c61b5ef3111). You applied my patches, which failed, you seemed to assume I'd written bad patches too ! If an md5 complains, & patches blow: consider the possibility the distfile may have changed ! Don't just commit a new md5. ----- > You haven't demonstrated you can maintain the port (see below), Totally Unfair ! You denied me any chance to ! In the ~14 hours between commiting this & then getting the mail, first I was asleep, then I was waiting for my mail link to restore itself. You broke Hylafax by changing md5, & now accuse me of bad maintenance ! ---- > this isn't an excuse to import something I can't understand. I'm not looking to excuse myself for something you don't understand. Don't touch what what ain't broke ! ---- > I do NOT want a broken or messy port in the tree. No one wants broken ports. You imply a messy port that works is not wanted ? Tell that to the folks that want fax capability ! At least what I commited _works_, which is more than some ports/Makefiles do. Anyway first `messiness' was a workaround the broken handling of DISTNAME in your area (share/mk/bsd.port.mk) I'm glad to hear you've added EXTRACT_SUFX, I've had a quick look, I'll look more, when I get all the src ctms (IP has been intermittent last 2 days, not all ctms here). ---- > ... BROKEN list, ... I never raised this topic re hylafax, you'r confusing another thread. ---- > If you can't fix this within 24 hours, expect it to be purged from the > repository and replaced by another, simpler and working version. RIDICULOUS, - YOU IGNORED THE WRONG DISTFILE MD5 WARNING Tossing out the port after you've micro-managed it & it's now screwed up would not be a good example to encourage new people to start contributing ports. 2 SOLUTIONS I SEE A (Quick Reliable) - Back Out (& save as diff -c) all your changes. - Copy the generic distrib file in freefall:~jhs (that I got from sgi.com), to some ftp'able place on the Internet, - Change DISTNAME & MASTER_SITES to new location. - Optionally selectively reapply your changes. B) - Fix the current contents of ports. I'd prefer (A) I'm not keen to do (B), but have no further time for either for a few days, Real Life (TM) now calls. I'd be happiest if you did (A) prior to CD-pressing on freefall, & you will get back a working port with the supplied distfile. (B) is less atractive, (& who knows if distfile will change again). Julian Stacey From owner-cvs-ports Mon May 22 23:30:29 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id XAA09306 for cvs-ports-outgoing; Mon, 22 May 1995 23:30:29 -0700 Received: (from jmacd@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id XAA09296 ; Mon, 22 May 1995 23:30:25 -0700 Date: Mon, 22 May 1995 23:30:25 -0700 From: Joshua Peck Macdonald Message-Id: <199505230630.XAA09296@freefall.cdrom.com> To: CVS-commiters, cvs-ports Subject: cvs commit: ports/lang/scheme48/patches patch-a Sender: cvs-ports-owner@freebsd.org Precedence: bulk jmacd 95/05/22 23:30:24 Modified: lang/scheme48/patches patch-a Log: Build failed if . was not in the builder's path. Fixed Submitted by: sky@csua.berkeley.edu From owner-cvs-ports Tue May 23 20:10:28 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id UAA26924 for cvs-ports-outgoing; Tue, 23 May 1995 20:10:28 -0700 Received: (from ache@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id UAA26893 ; Tue, 23 May 1995 20:08:59 -0700 Date: Tue, 23 May 1995 20:08:59 -0700 From: "Andrey A. Chernov" Message-Id: <199505240308.UAA26893@freefall.cdrom.com> To: CVS-commiters, cvs-ports Subject: cvs commit: ports/utils/pgp.non-usa_only/patches patch-ab Sender: cvs-ports-owner@freebsd.org Precedence: bulk ache 95/05/23 20:08:58 Added: utils/pgp.non-usa_only/patches patch-ab Log: Fix per-system russian charset determination From owner-cvs-ports Tue May 23 20:17:01 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id UAA27116 for cvs-ports-outgoing; Tue, 23 May 1995 20:17:01 -0700 Received: (from ache@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id UAA27101 ; Tue, 23 May 1995 20:16:52 -0700 Date: Tue, 23 May 1995 20:16:52 -0700 From: "Andrey A. Chernov" Message-Id: <199505240316.UAA27101@freefall.cdrom.com> To: CVS-commiters, cvs-ports Subject: cvs commit: ports/utils/pgp.usa_only/patches patch-ad Sender: cvs-ports-owner@freebsd.org Precedence: bulk ache 95/05/23 20:16:51 Added: utils/pgp.usa_only/patches patch-ad Log: Fix per-system russian charset determination From owner-cvs-ports Tue May 23 22:35:54 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id WAA29530 for cvs-ports-outgoing; Tue, 23 May 1995 22:35:54 -0700 Received: (from asami@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id WAA29518 ; Tue, 23 May 1995 22:35:49 -0700 Date: Tue, 23 May 1995 22:35:49 -0700 From: Satoshi Asami Message-Id: <199505240535.WAA29518@freefall.cdrom.com> To: CVS-commiters, cvs-ports Subject: cvs commit: ports/mail/popper/patches patch-ac Sender: cvs-ports-owner@freebsd.org Precedence: bulk asami 95/05/23 22:35:48 Added: mail/popper/patches patch-ac Log: Make popper work for both DES and MD4 passwords. Basically, just change one of the error checks from "strlen(.) != 13" to "strlen(.) != 13 && strlen(.) != 34". Submitted by: Martin Renters From owner-cvs-ports Tue May 23 23:46:35 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id XAA01337 for cvs-ports-outgoing; Tue, 23 May 1995 23:46:35 -0700 Received: from silvia.HIP.Berkeley.EDU (silvia.HIP.Berkeley.EDU [136.152.64.181]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id XAA01328 ; Tue, 23 May 1995 23:46:27 -0700 Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.6.11/8.6.9) id XAA03989; Tue, 23 May 1995 23:44:46 -0700 Date: Tue, 23 May 1995 23:44:46 -0700 Message-Id: <199505240644.XAA03989@silvia.HIP.Berkeley.EDU> To: jhs@vector.eikon.e-technik.tu-muenchen.de CC: jhs@freefall.cdrom.com, CVS-commiters@freefall.cdrom.com, cvs-ports@freefall.cdrom.com In-reply-to: <199505222216.AAA07935@vector.eikon.e-technik.tu-muenchen.de> (message from Julian Howard Stacey on Tue, 23 May 1995 00:16:48 +0200) Subject: Re: cvs commit: ports/comms/hylafax - Imported sources From: asami@cs.berkeley.edu (Satoshi Asami | =?ISO-2022-JP?B?GyRCQHUbKEI=?= =?ISO-2022-JP?B?GyRCOCsbKEIgGyRCOC0bKEI=?=) Sender: cvs-ports-owner@freebsd.org Precedence: bulk * > Julian, I asked you to send me a mail when you are done, not to commit it. * * That puzzled me, it contradicted what you had posted earlier, : * You had earlier written you wanted hylafax ( & had chased for it). * You had earlier written we were in code freeze _except for new ports_ * (go check your outgoing posting log if in doubt) That's why I asked you EXPLICITLY to NOT commit it after taking a look at the initial snapshot of your port. That is NOT commit material, and needs lots of cleanup. * > I haven't taken a look at any of your numerous * > auxiliary scripts and I haven't done any testing. * * Don't worry, `cd /usr/ports; make' does NOT use this tree yet You don't understand. If it doesn't work or if it's too messy, it doesn't belong there. Taking a port out of the SUBDIR list is the last resort to minimize the damage when something goes out of date or breaks, not a way to import a new port. :) * Unless you own & rely on a fax modem as I do, my actual software_in_use * as compiled, installed, & used on day of commit, is more `tested' anyway. I have never doubted it works for you. But that doesn't mean the port works for everybody. * If an md5 complains, & patches blow: consider the possibility the distfile * may have changed ! Don't just commit a new md5. Then explain this: % cat /e/work/asami/ports/comms/hylafax/files/md5 MD5 (hylafax-v3.0pl0-tar.gz) = 014ec8a64ea7493d26c50c61b5ef3111 % md5 ~jhs/hylafax-v3.0pl0-tar.gz /e/ports/distfiles/hylafax-v3.0pl0-tar.gz MD5 (/home/jhs/hylafax-v3.0pl0-tar.gz) = 014ec8a64ea7493d26c50c61b5ef3111 MD5 (/e/ports/distfiles/hylafax-v3.0pl0-tar.gz) = 014ec8a64ea7493d26c50c61b5ef3111 The files/md5 you committed doesn't even match what you have in your home directory! In fact, the md5 I committed matches yours. Also, the distfile on ftp.sgi.com has been there since April 9, if you have something else, that's really old. * > You haven't demonstrated you can maintain the port (see below), * * Totally Unfair ! You denied me any chance to ! * In the ~14 hours between commiting this & then getting the mail, first I was * asleep, then I was waiting for my mail link to restore itself. * You broke Hylafax by changing md5, & now accuse me of bad maintenance ! Hey don't read too much into my words, what I said was that you haven't demonstrated it (you haven't even given the chance yet!), I didn't say you failed or anything. I just can't trust you YET, okay? (I see it that this is the first port you made.) :) Making something work on your machine is one thing. Making that into a port that works on ANYBODY'S MACHINE is a totally different thing, especially for a port as complicated as hylafax. You probably should have tried something easier, not hylafax. * > I do NOT want a broken or messy port in the tree. * * No one wants broken ports. * You imply a messy port that works is not wanted ? Yes. It will be un-manageable in the future, and will be broken quickly. * Anyway first `messiness' was a workaround the broken handling of DISTNAME * in your area (share/mk/bsd.port.mk) * I'm glad to hear you've added EXTRACT_SUFX, I've had a quick look, It's still very messy even after I removed all the stuff about the -tar.gz suffix. ;) Anyway, I don't really see any solution to this, I can't even get it to compile on thud, so I'm sorry but I have to take this out. Satoshi From owner-cvs-ports Wed May 24 00:09:24 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id AAA01687 for cvs-ports-outgoing; Wed, 24 May 1995 00:09:24 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id AAA01680 ; Wed, 24 May 1995 00:09:14 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id AAA08617; Wed, 24 May 1995 00:08:53 -0700 From: "Rodney W. Grimes" Message-Id: <199505240708.AAA08617@gndrsh.aac.dev.com> Subject: Re: cvs commit: ports/mail/popper/patches patch-ac To: asami@freefall.cdrom.com (Satoshi Asami) Date: Wed, 24 May 1995 00:08:53 -0700 (PDT) Cc: CVS-commiters@freefall.cdrom.com, cvs-ports@freefall.cdrom.com In-Reply-To: <199505240535.WAA29518@freefall.cdrom.com> from "Satoshi Asami" at May 23, 95 10:35:49 pm X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 1120 Sender: cvs-ports-owner@freebsd.org Precedence: bulk > > asami 95/05/23 22:35:48 > > Added: mail/popper/patches patch-ac > Log: > Make popper work for both DES and MD4 passwords. Basically, just > change one of the error checks from "strlen(.) != 13" to "strlen(.) != > 13 && strlen(.) != 34". > > Submitted by: Martin Renters Code that knows about the length of the password entry in a system should be considered extremly non portable at best, and a violation of data abstraction at worst. The man page for getpwent says: char *pw_passwd; /* encrypted password */ No place in any of the manual pages will you find that the string length of the password string is either 13 or 34 bytes, Poul and I dug all over for this very thing when he wanted to do the MD5 password before it was ever done to make sure we would not be breaking a documented interface. Popper should treat this as a null terminated string of unknown length! -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD From owner-cvs-ports Wed May 24 00:17:58 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id AAA01775 for cvs-ports-outgoing; Wed, 24 May 1995 00:17:58 -0700 Received: from precipice.shockwave.com (precipice.shockwave.com [171.69.108.33]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id AAA01769 ; Wed, 24 May 1995 00:17:46 -0700 Received: from localhost (localhost [127.0.0.1]) by precipice.shockwave.com (8.6.11/8.6.9) with SMTP id AAA00425; Wed, 24 May 1995 00:16:37 -0700 Message-Id: <199505240716.AAA00425@precipice.shockwave.com> To: "Rodney W. Grimes" cc: asami@freefall.cdrom.com (Satoshi Asami), CVS-commiters@freefall.cdrom.com, cvs-ports@freefall.cdrom.com Subject: Re: cvs commit: ports/mail/popper/patches patch-ac In-reply-to: Your message of "Wed, 24 May 1995 00:08:53 PDT." <199505240708.AAA08617@gndrsh.aac.dev.com> Date: Wed, 24 May 1995 00:16:36 -0700 From: Paul Traina Sender: cvs-ports-owner@freebsd.org Precedence: bulk Absolutely... I thought I already submitted a patch for this that got rid of the check entirely. The check is totally unnecessary. From: "Rodney W. Grimes" Subject: Re: cvs commit: ports/mail/popper/patches patch-ac > > asami 95/05/23 22:35:48 > > Added: mail/popper/patches patch-ac > Log: > Make popper work for both DES and MD4 passwords. Basically, just > change one of the error checks from "strlen(.) != 13" to "strlen(.) != > 13 && strlen(.) != 34". > > Submitted by: Martin Renters Code that knows about the length of the password entry in a system should be considered extremly non portable at best, and a violation of data abstraction at worst. The man page for getpwent says: char *pw_passwd; /* encrypted password */ No place in any of the manual pages will you find that the string length of the password string is either 13 or 34 bytes, Poul and I dug all over for this very thing when he wanted to do the MD5 password before it was ever done to make sure we would not be breaking a documented interface. Popper should treat this as a null terminated string of unknown length! -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD From owner-cvs-ports Wed May 24 01:27:47 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id BAA03357 for cvs-ports-outgoing; Wed, 24 May 1995 01:27:47 -0700 Received: from silvia.HIP.Berkeley.EDU (silvia.HIP.Berkeley.EDU [136.152.64.181]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id BAA03332 ; Wed, 24 May 1995 01:27:27 -0700 Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.6.11/8.6.9) id BAA04354; Wed, 24 May 1995 01:27:18 -0700 Date: Wed, 24 May 1995 01:27:18 -0700 Message-Id: <199505240827.BAA04354@silvia.HIP.Berkeley.EDU> To: pst@shockwave.com CC: rgrimes@gndrsh.aac.dev.com, CVS-commiters@freefall.cdrom.com, cvs-ports@freefall.cdrom.com In-reply-to: <199505240716.AAA00425@precipice.shockwave.com> (message from Paul Traina on Wed, 24 May 1995 00:16:36 -0700) Subject: Re: cvs commit: ports/mail/popper/patches patch-ac From: asami@cs.berkeley.edu (Satoshi Asami | =?ISO-2022-JP?B?GyRCQHUbKEI=?= =?ISO-2022-JP?B?GyRCOCsbKEIgGyRCOC0bKEI=?=) Sender: cvs-ports-owner@freebsd.org Precedence: bulk * Absolutely... I thought I already submitted a patch for this that * got rid of the check entirely. The check is totally unnecessary. Oh, ok. I assume you submitted the patch to the popper maintenance people, in which case the fix should be in the upcoming new release (due out Thursday). Since the current version is severely broken (according to the maintainers, that's why it disappeared from the master site so quickly), we will have to upgrade this to the new version anyway (despite the code freeze). So I'll leave this port as it is for now, at least it won't blow up on MD4 machines. Satoshi From owner-cvs-ports Fri May 26 15:17:28 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id PAA03885 for cvs-ports-outgoing; Fri, 26 May 1995 15:17:28 -0700 Received: (from ache@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id PAA03872 ; Fri, 26 May 1995 15:17:23 -0700 Date: Fri, 26 May 1995 15:17:23 -0700 From: "Andrey A. Chernov" Message-Id: <199505262217.PAA03872@freefall.cdrom.com> To: CVS-commiters, cvs-ports Subject: cvs commit: ports/net/chimera Makefile Sender: cvs-ports-owner@freebsd.org Precedence: bulk ache 95/05/26 15:17:23 Modified: net/chimera Makefile Log: Set PREFIX directly to ${X11BASE}, it is overwriting somehow to /usr/X386 in old variant From owner-cvs-ports Fri May 26 17:32:32 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id RAA06797 for cvs-ports-outgoing; Fri, 26 May 1995 17:32:32 -0700 Received: from silvia.HIP.Berkeley.EDU (silvia.HIP.Berkeley.EDU [136.152.64.181]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id RAA06790 ; Fri, 26 May 1995 17:32:26 -0700 Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.6.11/8.6.9) id RAA01781; Fri, 26 May 1995 17:32:24 -0700 Date: Fri, 26 May 1995 17:32:24 -0700 Message-Id: <199505270032.RAA01781@silvia.HIP.Berkeley.EDU> To: ache@freefall.cdrom.com CC: CVS-commiters@freefall.cdrom.com, cvs-ports@freefall.cdrom.com In-reply-to: <199505262217.PAA03872@freefall.cdrom.com> (ache@freefall.cdrom.com) Subject: Re: cvs commit: ports/net/chimera Makefile From: asami@cs.berkeley.edu (Satoshi Asami | =?ISO-2022-JP?B?GyRCQHUbKEI=?= =?ISO-2022-JP?B?GyRCOCsbKEIgGyRCOC0bKEI=?=) Sender: cvs-ports-owner@freebsd.org Precedence: bulk * Modified: net/chimera Makefile * Log: * Set PREFIX directly to ${X11BASE}, it is overwriting somehow to /usr/X386 * in old variant Are you sure about this? I checked my compilation log, I even took out your new line and recompiled & reinstalled it on thud, and everything went into /usr/X11R6 happily. Exactly what made you think PREFIX is set to /usr/X386? As there is an "USE_IMAKE=yes" a few line below your addition, your change wouldn't have made any difference. If you take a look at the latest bsd.port.mk, PREFIX is set (?=) to ${X11BASE} conditional to the existence of USE_IMAKE or USE_X11. Also, I know this is a "bug fix", but I am the maintainer of this port, and in addition to that, we are in code freeze. I would have expected you to contact me first, either as a maintainer or the ports administrator.... :) Satoshi From owner-cvs-ports Fri May 26 19:43:59 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id TAA08989 for cvs-ports-outgoing; Fri, 26 May 1995 19:43:59 -0700 Received: from sequent.kiae.su (sequent.kiae.su [144.206.136.6]) by freefall.cdrom.com (8.6.10/8.6.6) with SMTP id TAA08980 ; Fri, 26 May 1995 19:43:45 -0700 Received: by sequent.kiae.su id AA13213 (5.65.kiae-2 ); Sat, 27 May 1995 06:43:08 +0400 Received: by sequent.KIAE.su (UUMAIL/2.0); Sat, 27 May 95 06:43:06 +0400 Received: (from ache@localhost) by astral.msk.su (8.6.8/8.6.6) id GAA00434; Sat, 27 May 1995 06:08:12 +0400 To: Satoshi Asami | =?ISO-2022-JP?B?GyRCQHUbKEI=?= =?ISO-2022-JP?B?GyRCOCsbKEIgGyRCOC0bKEI=?= Cc: CVS-commiters@freefall.cdrom.com, cvs-ports@freefall.cdrom.com References: <199505270032.RAA01781@silvia.HIP.Berkeley.EDU> In-Reply-To: <199505270032.RAA01781@silvia.HIP.Berkeley.EDU>; from Satoshi Asami | =?ISO-2022-JP?B?GyRCQHUbKEI=?= =?ISO-2022-JP?B?GyRCOCsbKEIgGyRCOC0bKEI=?= at Fri, 26 May 1995 17:32:24 -0700 Message-Id: Organization: Olahm Ha-Yetzirah Date: Sat, 27 May 1995 06:08:11 +0400 (MSD) X-Mailer: Mail/@ [v2.37 FreeBSD] From: "Andrey A. Chernov, Black Mage" X-Class: Fast Subject: Re: cvs commit: ports/net/chimera Makefile Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: cvs-ports-owner@freebsd.org Precedence: bulk In message <199505270032.RAA01781@silvia.HIP.Berkeley.EDU> Satoshi Asami | =?ISO-2022-JP?B?GyRCQHUbKEI=?= =?ISO-2022-JP?B?GyRCOCsbKEIgGyRCOC0bKEI=?= writes: > * Modified: net/chimera Makefile > * Log: > * Set PREFIX directly to ${X11BASE}, it is overwriting somehow to /usr/X386 > * in old variant >Are you sure about this? I checked my compilation log, I even took >out your new line and recompiled & reinstalled it on thud, and >everything went into /usr/X11R6 happily. Exactly what made you think >PREFIX is set to /usr/X386? Sorry, my fault, I have uncommented X11BASE=/usr/X386 in my /etc/make.conf :-( You can safely remove my "fix" via cvs now... From owner-cvs-ports Fri May 26 21:48:36 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id VAA11300 for cvs-ports-outgoing; Fri, 26 May 1995 21:48:36 -0700 Received: (from asami@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id VAA11290 ; Fri, 26 May 1995 21:48:32 -0700 Date: Fri, 26 May 1995 21:48:32 -0700 From: Satoshi Asami Message-Id: <199505270448.VAA11290@freefall.cdrom.com> To: CVS-commiters, cvs-ports Subject: cvs commit: ports/net/chimera Makefile Sender: cvs-ports-owner@freebsd.org Precedence: bulk asami 95/05/26 21:48:32 Modified: net/chimera Makefile Log: Back out previous commit, Andrey confirmed it was not needed. From owner-cvs-ports Sat May 27 00:45:03 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id AAA13721 for cvs-ports-outgoing; Sat, 27 May 1995 00:45:03 -0700 Received: (from asami@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id AAA13704 ; Sat, 27 May 1995 00:44:57 -0700 Date: Sat, 27 May 1995 00:44:57 -0700 From: Satoshi Asami Message-Id: <199505270744.AAA13704@freefall.cdrom.com> To: CVS-commiters, cvs-ports Subject: cvs commit: ports/games/xrisk/patches patch-a Sender: cvs-ports-owner@freebsd.org Precedence: bulk asami 95/05/27 00:44:57 Modified: games/xrisk Makefile Log: Add USE_X11 so that PREFIX gets set to ${X11BASE} correctly. Modified: games/xrisk/patches patch-a Log: Add -I${PREFIX}/include and -L${PREFIX}/lib where necessary. Submitted (partially) by: Philippe Charnier From owner-cvs-ports Sat May 27 00:58:51 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id AAA13950 for cvs-ports-outgoing; Sat, 27 May 1995 00:58:51 -0700 Received: (from asami@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id AAA13940 ; Sat, 27 May 1995 00:58:47 -0700 Date: Sat, 27 May 1995 00:58:47 -0700 From: Satoshi Asami Message-Id: <199505270758.AAA13940@freefall.cdrom.com> To: CVS-commiters, cvs-ports Subject: cvs commit: ports/mail/popper/pkg COMMENT Sender: cvs-ports-owner@freebsd.org Precedence: bulk asami 95/05/27 00:58:47 Modified: mail/popper Makefile mail/popper/files md5 mail/popper/pkg COMMENT Removed: mail/popper/patches patch-aa patch-ac Log: Upgrade to version 2.1.4-r3. According to the master site maintainers, the previous version had a huge problem and had to be removed from the master site, and that's why I'm doing this this late in the cycle. Also, the problems that patch-aa (off_t) and patch-ac (password length) address seem to be fixed, so take them out. From owner-cvs-ports Sat May 27 01:15:35 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id BAA14230 for cvs-ports-outgoing; Sat, 27 May 1995 01:15:35 -0700 Received: (from asami@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id BAA14220 ; Sat, 27 May 1995 01:15:22 -0700 Date: Sat, 27 May 1995 01:15:22 -0700 From: Satoshi Asami Message-Id: <199505270815.BAA14220@freefall.cdrom.com> To: CVS-commiters, cvs-ports Subject: cvs commit: ports INDEX Sender: cvs-ports-owner@freebsd.org Precedence: bulk asami 95/05/27 01:15:20 Modified: . INDEX Log: The latest and greatest, all-singing and all-dancing INDEX. (j/k, Jordan, how's sysinstall going? :) From owner-cvs-ports Sat May 27 04:30:54 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id EAA20832 for cvs-ports-outgoing; Sat, 27 May 1995 04:30:54 -0700 Received: (from ats@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id EAA20818 ; Sat, 27 May 1995 04:30:49 -0700 Date: Sat, 27 May 1995 04:30:49 -0700 From: Andreas Schulz Message-Id: <199505271130.EAA20818@freefall.cdrom.com> To: CVS-commiters, cvs-ports Subject: cvs commit: ports/graphics/povray/patches patch-b Sender: cvs-ports-owner@freebsd.org Precedence: bulk ats 95/05/27 04:30:49 Modified: graphics/povray/patches patch-b Log: Changed the hardocded /usr/X11R6 to ${X11BASE} so that people with older Xfree releases get a chance. Added into the loaderflags a -L${X11}/lib so that the X11 libraries can be found. From owner-cvs-ports Sat May 27 04:33:26 1995 Return-Path: cvs-ports-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id EAA20918 for cvs-ports-outgoing; Sat, 27 May 1995 04:33:26 -0700 Received: (from ats@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id EAA20908 ; Sat, 27 May 1995 04:33:24 -0700 Date: Sat, 27 May 1995 04:33:24 -0700 From: Andreas Schulz Message-Id: <199505271133.EAA20908@freefall.cdrom.com> To: CVS-commiters, cvs-ports Subject: cvs commit: ports/graphics/povray/patches patch-b Sender: cvs-ports-owner@freebsd.org Precedence: bulk ats 95/05/27 04:33:24 Modified: graphics/povray/patches patch-b Log: Forgot a $ sign in the previous commit of the patch file.