From owner-cvs-sys Sun Nov 12 00:59:10 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA00465 for cvs-sys-outgoing; Sun, 12 Nov 1995 00:59:10 -0800 Received: (from davidg@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA00456 ; Sun, 12 Nov 1995 00:59:00 -0800 Date: Sun, 12 Nov 1995 00:59:00 -0800 From: David Greenman Message-Id: <199511120859.AAA00456@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/vm vm_map.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk davidg 95/11/12 00:58:59 Modified: sys/vm vm_map.c Log: Moved vm_map_lock call to inside the splhigh protection in vm_map_find(). This closes a probably rare but nonetheless real window that would result in a process hanging or the system panicing. Reviewed by: dyson, davidg Submitted by: kato@eclogite.eps.nagoya-u.ac.jp (KATO Takenori) From owner-cvs-sys Sun Nov 12 01:00:00 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA00530 for cvs-sys-outgoing; Sun, 12 Nov 1995 01:00:00 -0800 Received: (from davidg@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA00521 ; Sun, 12 Nov 1995 00:59:58 -0800 Date: Sun, 12 Nov 1995 00:59:58 -0800 From: David Greenman Message-Id: <199511120859.AAA00521@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/vm vm_map.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk davidg 95/11/12 00:59:58 Branch: sys/vm RELENG_2_1_0 Modified: sys/vm vm_map.c Log: Brought in change from rev 1.26: moved vm_map_lock call to close window. From owner-cvs-sys Sun Nov 12 02:17:04 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA03584 for cvs-sys-outgoing; Sun, 12 Nov 1995 02:17:04 -0800 Received: (from davidg@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA03572 ; Sun, 12 Nov 1995 02:16:57 -0800 Date: Sun, 12 Nov 1995 02:16:57 -0800 From: David Greenman Message-Id: <199511121016.CAA03572@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/isofs/cd9660 cd9660_lookup.c cd9660_vnops.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk davidg 95/11/12 02:16:55 Modified: sys/isofs/cd9660 cd9660_lookup.c cd9660_vnops.c Log: Fix isoilk hang caused by not checking for read-onlyness in several places. The fix for this in Lite-2 is more complete, but these quick hacks of mine are safer for now. I plan to integrate the additional Lite-2 stuff at some later time. Should completely fix PR810. From owner-cvs-sys Sun Nov 12 02:36:27 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA04088 for cvs-sys-outgoing; Sun, 12 Nov 1995 02:36:27 -0800 Received: (from davidg@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA04078 ; Sun, 12 Nov 1995 02:36:23 -0800 Date: Sun, 12 Nov 1995 02:36:23 -0800 From: David Greenman Message-Id: <199511121036.CAA04078@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/isofs/cd9660 cd9660_vnops.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk davidg 95/11/12 02:36:22 Modified: sys/isofs/cd9660 cd9660_vnops.c Log: Brought in the setattr call support from Lite-2 so that more correct error returns are provided. Obtained from: 4.4BSD-Lite2 From owner-cvs-sys Sun Nov 12 02:40:46 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA04247 for cvs-sys-outgoing; Sun, 12 Nov 1995 02:40:46 -0800 Received: (from davidg@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA04234 ; Sun, 12 Nov 1995 02:40:39 -0800 Date: Sun, 12 Nov 1995 02:40:39 -0800 From: David Greenman Message-Id: <199511121040.CAA04234@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/isofs/cd9660 cd9660_lookup.c cd9660_vnops.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk davidg 95/11/12 02:40:39 Branch: sys/isofs/cd9660 RELENG_2_1_0 Modified: sys/isofs/cd9660 cd9660_lookup.c cd9660_vnops.c Log: Brought in fixes from main branch: check properly for read-onlyness, and provide correct error returns when attempting to set the file attributes. From owner-cvs-sys Sun Nov 12 09:03:06 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id JAA15450 for cvs-sys-outgoing; Sun, 12 Nov 1995 09:03:06 -0800 Received: (from markm@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id JAA15441 ; Sun, 12 Nov 1995 09:02:52 -0800 Date: Sun, 12 Nov 1995 09:02:52 -0800 From: Mark Murray Message-Id: <199511121702.JAA15441@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/isa/pcvt pcvt_hdr.h pcvt_kbd.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk markm 95/11/12 09:02:50 Modified: sys/i386/isa/pcvt pcvt_hdr.h pcvt_kbd.c Log: Add /dev/random hooks to the key input routines for pcvt. This allows the scancodes on a PCVT machine to be used as stochastic input as well as SysCons.. Reviewed by: Joerg Wunsch From owner-cvs-sys Sun Nov 12 11:52:21 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id LAA26870 for cvs-sys-outgoing; Sun, 12 Nov 1995 11:52:21 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id LAA26835 ; Sun, 12 Nov 1995 11:52:11 -0800 Date: Sun, 12 Nov 1995 11:52:11 -0800 From: Poul-Henning Kamp Message-Id: <199511121952.LAA26835@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/sys sysctl.h Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk phk 95/11/12 11:52:11 Modified: sys/i386/i386 machdep.c sys/kern kern_clock.c kern_sysctl.c sys/sys sysctl.h Log: The entire sysctl callback to read/write version. I havn't tested this as much as I'd like to, but the malloc stunt I tried for an interim for sure does worse. Now we can read and write from any kind of address-space, not only user and kernel, using callbacks. This may be over-generalization for now, but it's actually simpler. From owner-cvs-sys Mon Nov 13 00:22:36 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA27100 for cvs-sys-outgoing; Mon, 13 Nov 1995 00:22:36 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA27044 ; Mon, 13 Nov 1995 00:22:27 -0800 Date: Mon, 13 Nov 1995 00:22:27 -0800 From: Bruce Evans Message-Id: <199511130822.AAA27044@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern vfs_syscalls.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk bde 95/11/13 00:22:25 Modified: sys/kern vfs_syscalls.c Log: Fixed a cast in olseek(). Fixed confusing order of declarations of getvnode()'s args. From owner-cvs-sys Mon Nov 13 00:39:54 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA01451 for cvs-sys-outgoing; Mon, 13 Nov 1995 00:39:54 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA01420 ; Mon, 13 Nov 1995 00:39:46 -0800 Date: Mon, 13 Nov 1995 00:39:46 -0800 From: Bruce Evans Message-Id: <199511130839.AAA01420@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/pccard pcic.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk bde 95/11/13 00:39:45 Modified: sys/pccard pcic.c Log: Fixed the type of yet another timeout function. Fixed the type of pcic_unload(). Replaced nosys() by lkm_nullcmd() in pcic_mod() and in a misplaced comment about the lkm interface. From owner-cvs-sys Mon Nov 13 00:52:18 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA05034 for cvs-sys-outgoing; Mon, 13 Nov 1995 00:52:18 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA04982 ; Mon, 13 Nov 1995 00:52:10 -0800 Date: Mon, 13 Nov 1995 00:52:10 -0800 From: Bruce Evans Message-Id: <199511130852.AAA04982@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/sys mount.h Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk bde 95/11/13 00:52:09 Modified: sys/i386/isa atapi.c sys/sys mount.h Log: Replaced nosys() by lkm_nullcmd(). From owner-cvs-sys Mon Nov 13 00:58:16 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA06932 for cvs-sys-outgoing; Mon, 13 Nov 1995 00:58:16 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA06892 ; Mon, 13 Nov 1995 00:58:10 -0800 Date: Mon, 13 Nov 1995 00:58:10 -0800 From: Bruce Evans Message-Id: <199511130858.AAA06892@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/ibcs2 ibcs2_signal.h Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk bde 95/11/13 00:58:08 Modified: sys/i386/ibcs2 ibcs2_signal.h Log: Fixed parentheses in macros. From owner-cvs-sys Mon Nov 13 01:03:50 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA08062 for cvs-sys-outgoing; Mon, 13 Nov 1995 01:03:50 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA07991 ; Mon, 13 Nov 1995 01:03:35 -0800 Date: Mon, 13 Nov 1995 01:03:35 -0800 From: Bruce Evans Message-Id: <199511130903.BAA07991@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/ibcs2 ibcs2_ipc.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk bde 95/11/13 01:03:33 Modified: sys/i386/ibcs2 ibcs2_ipc.c Log: Added bogus casts to avoid compiler warnings. From owner-cvs-sys Mon Nov 13 02:45:36 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA24805 for cvs-sys-outgoing; Mon, 13 Nov 1995 02:45:36 -0800 Received: (from davidg@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA24779 ; Mon, 13 Nov 1995 02:45:27 -0800 Date: Mon, 13 Nov 1995 02:45:27 -0800 From: David Greenman Message-Id: <199511131045.CAA24779@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern kern_exec.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk davidg 95/11/13 02:45:26 Modified: sys/kern kern_exec.c Log: Use kmem_alloc_pageable/kmem_free to allocate memory instead of individual VM map functions. From owner-cvs-sys Mon Nov 13 02:54:02 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA25596 for cvs-sys-outgoing; Mon, 13 Nov 1995 02:54:02 -0800 Received: (from davidg@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA25563 ; Mon, 13 Nov 1995 02:53:44 -0800 Date: Mon, 13 Nov 1995 02:53:44 -0800 From: David Greenman Message-Id: <199511131053.CAA25563@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/vm vm_kern.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk davidg 95/11/13 02:53:42 Modified: sys/vm vm_kern.c Log: Fixed up a comment and removed some #if 0'd code. From owner-cvs-sys Mon Nov 13 05:54:22 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id FAA23434 for cvs-sys-outgoing; Mon, 13 Nov 1995 05:54:22 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id FAA23411 ; Mon, 13 Nov 1995 05:54:11 -0800 Date: Mon, 13 Nov 1995 05:54:11 -0800 From: Poul-Henning Kamp Message-Id: <199511131354.FAA23411@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern kern_sysctl.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk phk 95/11/13 05:54:10 Modified: sys/kern kern_sysctl.c Log: Try to make my new scheme work more along the lines of the manual. There are still some gray areas here and there. From owner-cvs-sys Mon Nov 13 11:33:29 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id LAA21295 for cvs-sys-outgoing; Mon, 13 Nov 1995 11:33:29 -0800 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id LAA21243 ; Mon, 13 Nov 1995 11:33:02 -0800 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id GAA03496; Tue, 14 Nov 1995 06:29:33 +1100 Date: Tue, 14 Nov 1995 06:29:33 +1100 From: Bruce Evans Message-Id: <199511131929.GAA03496@godzilla.zeta.org.au> To: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, phk@freefall.freebsd.org Subject: Re: cvs commit: src/sys/kern kern_sysctl.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk > Modified: sys/kern kern_sysctl.c > Log: > Try to make my new scheme work more along the lines of the manual. > There are still some gray areas here and there. I noticed possible sign extension problems: e.g., in sysctl_old_kernel: i = min(req->oldlen - req->oldidx, l); if (i > 0) ... min() handles u_ints, so if req->oldlen < req->oldidx, the result is probably l and wrong. The result is probably never < 0. You should use imin() to handle ints. However, you should probably be using u_ints throughout. sysctl()'s args are u_ints but userland_sysctl() converts them to ints before checking their values. Preposterously large lengths become negative and it's not clear how they are handled. E.g., req.oldlen = *oldlenp; ^^^^^^^^^^ ^^^^^^^^ int size_t If *oldlenp == (size_t)-1, then req.oldlen == -1. Thus req->oldlen can be smaller than req->oldidx. However, min() probably does the right thing by converting everything to u_int, at least when size_t is u_int. Many uses of the wrong min() function were introduced when the MIN() macro was replaced by the min() functions. Bruce From owner-cvs-sys Mon Nov 13 13:18:03 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id NAA29160 for cvs-sys-outgoing; Mon, 13 Nov 1995 13:18:03 -0800 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id NAA29145 ; Mon, 13 Nov 1995 13:17:51 -0800 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id IAA07329; Tue, 14 Nov 1995 08:15:34 +1100 Date: Tue, 14 Nov 1995 08:15:34 +1100 From: Bruce Evans Message-Id: <199511132115.IAA07329@godzilla.zeta.org.au> To: CVS-commiters@freefall.freebsd.org, bde@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/msdosfs msdosfs_vnops.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk > Modified: sys/msdosfs msdosfs_vnops.c > Log: > Fixed getdirentries() on nfs mounted msdosfs's. No cookies were returned > for certain common combinations of directory sizes, cluster sizes, and i/o > sizes (e.g., 4K, 4K, and 4K). The fix in rev. 1.21 was incomplete. > > Reviewed by: dfr > Obtained from: party from NetBSD I thought that this bug was related to nfsv3 and didn't affect 2.1, so I left the fix in my queue for too long. However, it seems to be an old bug. 2.1 is also missing the fix for the VOP_LINK arg order botch (rev 1.18 of msdosfs_vnops.c). Bruce From owner-cvs-sys Mon Nov 13 14:09:59 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id OAA02830 for cvs-sys-outgoing; Mon, 13 Nov 1995 14:09:59 -0800 Received: (from peter@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id OAA02814 ; Mon, 13 Nov 1995 14:09:44 -0800 Date: Mon, 13 Nov 1995 14:09:44 -0800 From: Peter Wemm Message-Id: <199511132209.OAA02814@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/net if_ppp.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk peter 95/11/13 14:09:43 Modified: sys/net if_ppp.c Log: Enhance the likelyhood that IPX over ppp will actually work.. :-) Note that pppd doesn't have an ipxcp.c module for negotiating and confuguring IPX at startup, but after these mods, you can manually ifconfig IPX addresses on the interface and it will probably work.. :-) From owner-cvs-sys Mon Nov 13 21:16:51 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id VAA26067 for cvs-sys-outgoing; Mon, 13 Nov 1995 21:16:51 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id VAA26050 ; Mon, 13 Nov 1995 21:16:39 -0800 Date: Mon, 13 Nov 1995 21:16:39 -0800 From: Bruce Evans Message-Id: <199511140516.VAA26050@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/nfs nfs_syscalls.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk bde 95/11/13 21:16:38 Modified: sys/nfs nfs_syscalls.c Log: Included to get central declarations for syscall args structs and prototypes for syscalls. Ifdefed duplicated decentralized declarations of args structs. It's convenient to have this visible but they are hard to maintain. Some are already different from the central declarations. 4.4lite2 puts them in comments in the function headers but I wanted to avoid the large changes for that. From owner-cvs-sys Mon Nov 13 21:43:58 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id VAA27623 for cvs-sys-outgoing; Mon, 13 Nov 1995 21:43:58 -0800 Received: from Root.COM (implode.Root.COM [198.145.90.17]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id VAA27598 ; Mon, 13 Nov 1995 21:43:44 -0800 Received: from corbin.Root.COM (corbin [198.145.90.50]) by Root.COM (8.6.12/8.6.5) with ESMTP id VAA27717; Mon, 13 Nov 1995 21:43:43 -0800 Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.12/8.6.5) with SMTP id VAA04312; Mon, 13 Nov 1995 21:38:09 -0800 Message-Id: <199511140538.VAA04312@corbin.Root.COM> To: Bruce Evans cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/nfs nfs_syscalls.c In-reply-to: Your message of "Mon, 13 Nov 95 21:16:39 PST." <199511140516.VAA26050@freefall.freebsd.org> From: David Greenman Reply-To: davidg@Root.COM Date: Mon, 13 Nov 1995 21:38:09 -0800 Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk >bde 95/11/13 21:16:38 > > Modified: sys/nfs nfs_syscalls.c > Log: > Included to get central declarations for syscall args > structs and prototypes for syscalls. > > Ifdefed duplicated decentralized declarations of args structs. It's > convenient to have this visible but they are hard to maintain. Some > are already different from the central declarations. 4.4lite2 puts > them in comments in the function headers but I wanted to avoid the > large changes for that. Now that the definitions are in sysproto.h, I'd like to see them removed from the .c files. -DG From owner-cvs-sys Mon Nov 13 22:21:03 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id WAA29921 for cvs-sys-outgoing; Mon, 13 Nov 1995 22:21:03 -0800 Received: from Root.COM (implode.Root.COM [198.145.90.17]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id WAA29906 ; Mon, 13 Nov 1995 22:20:55 -0800 Received: from corbin.Root.COM (corbin [198.145.90.50]) by Root.COM (8.6.12/8.6.5) with ESMTP id WAA27783; Mon, 13 Nov 1995 22:20:50 -0800 Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.12/8.6.5) with SMTP id WAA04429; Mon, 13 Nov 1995 22:15:12 -0800 Message-Id: <199511140615.WAA04429@corbin.Root.COM> To: Bruce Evans cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/msdosfs msdosfs_vnops.c In-reply-to: Your message of "Tue, 14 Nov 95 08:15:34 +1100." <199511132115.IAA07329@godzilla.zeta.org.au> From: David Greenman Reply-To: davidg@Root.COM Date: Mon, 13 Nov 1995 22:15:11 -0800 Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk >> Modified: sys/msdosfs msdosfs_vnops.c >> Log: >> Fixed getdirentries() on nfs mounted msdosfs's. No cookies were returned >> for certain common combinations of directory sizes, cluster sizes, and i/o >> sizes (e.g., 4K, 4K, and 4K). The fix in rev. 1.21 was incomplete. >> >> Reviewed by: dfr >> Obtained from: party from NetBSD > >I thought that this bug was related to nfsv3 and didn't affect 2.1, so I >left the fix in my queue for too long. However, it seems to be an old bug. > >2.1 is also missing the fix for the VOP_LINK arg order botch (rev 1.18 of >msdosfs_vnops.c). 2.1 is supposed to be missing the changes from rev 1.18. I didn't bring any of the VOP_LINK argument order changes into the release. -DG From owner-cvs-sys Mon Nov 13 23:27:00 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id XAA04436 for cvs-sys-outgoing; Mon, 13 Nov 1995 23:27:00 -0800 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id XAA04338 ; Mon, 13 Nov 1995 23:24:37 -0800 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id SAA00861; Tue, 14 Nov 1995 18:22:25 +1100 Date: Tue, 14 Nov 1995 18:22:25 +1100 From: Bruce Evans Message-Id: <199511140722.SAA00861@godzilla.zeta.org.au> To: bde@freefall.freebsd.org, davidg@Root.COM Subject: Re: cvs commit: src/sys/nfs nfs_syscalls.c Cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk >>bde 95/11/13 21:16:38 >> >> Modified: sys/nfs nfs_syscalls.c >> Log: >> Included to get central declarations for syscall args >> structs and prototypes for syscalls. >> >> Ifdefed duplicated decentralized declarations of args structs. It's >> convenient to have this visible but they are hard to maintain. Some >> are already different from the central declarations. 4.4lite2 puts >> them in comments in the function headers but I wanted to avoid the >> large changes for that. > Now that the definitions are in sysproto.h, I'd like to see them removed >from the .c files. I'm not sure if they should be removed as far as that. Do you think we should remove the pseudo-declarations from all vnode op functions too? Such declarations are useful iff they are correct. For examples of possibly harmful incorrect ones, see almost any readdir(): ext2fs_readdir(): eofflag and cookies are missing eofflag and cookies aren't referenced so nfs can't work ufs_readdir(): eofflag is missing but is referenced (nfs works :-) msdosfs_readdir(): members are out of order Bruce From owner-cvs-sys Mon Nov 13 23:30:35 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id XAA04711 for cvs-sys-outgoing; Mon, 13 Nov 1995 23:30:35 -0800 Received: from Root.COM (implode.Root.COM [198.145.90.17]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id XAA04692 ; Mon, 13 Nov 1995 23:30:25 -0800 Received: from corbin.Root.COM (corbin [198.145.90.50]) by Root.COM (8.6.12/8.6.5) with ESMTP id XAA27943; Mon, 13 Nov 1995 23:30:16 -0800 Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.12/8.6.5) with SMTP id XAA00205; Mon, 13 Nov 1995 23:30:11 -0800 Message-Id: <199511140730.XAA00205@corbin.Root.COM> To: Bruce Evans cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/nfs nfs_syscalls.c In-reply-to: Your message of "Tue, 14 Nov 95 18:22:25 +1100." <199511140722.SAA00861@godzilla.zeta.org.au> From: David Greenman Reply-To: davidg@Root.COM Date: Mon, 13 Nov 1995 23:30:07 -0800 Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk >>>bde 95/11/13 21:16:38 >>> >>> Modified: sys/nfs nfs_syscalls.c >>> Log: >>> Included to get central declarations for syscall args >>> structs and prototypes for syscalls. >>> >>> Ifdefed duplicated decentralized declarations of args structs. It's >>> convenient to have this visible but they are hard to maintain. Some >>> are already different from the central declarations. 4.4lite2 puts >>> them in comments in the function headers but I wanted to avoid the >>> large changes for that. > >> Now that the definitions are in sysproto.h, I'd like to see them removed >>from the .c files. > >I'm not sure if they should be removed as far as that. Do you think we >should remove the pseudo-declarations from all vnode op functions too? >Such declarations are useful iff they are correct. For examples of >possibly harmful incorrect ones, see almost any readdir(): The vnode op functions are auto-generated and not really part of the source tree. I see syscalls as being different since the delarations are now in a standard, centralized place. -DG From owner-cvs-sys Mon Nov 13 23:36:05 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id XAA05257 for cvs-sys-outgoing; Mon, 13 Nov 1995 23:36:05 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id XAA05244 ; Mon, 13 Nov 1995 23:35:59 -0800 Date: Mon, 13 Nov 1995 23:35:59 -0800 From: Bruce Evans Message-Id: <199511140735.XAA05244@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/sys kernel.h lkm.h Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk bde 95/11/13 23:35:58 Modified: lkm/coff coff.c lkm/ibcs2 ibcs2.c lkm/ipfw ipfw_lkm.c lkm/linux linux.c lkm/syscons/blank blank_saver.c lkm/syscons/fade fade_saver.c lkm/syscons/green green_saver.c lkm/syscons/snake snake_saver.c lkm/syscons/star star_saver.c sys/i386/isa atapi.c wcd.c sys/pccard pcic.c sys/sys kernel.h lkm.h Log: Changed the first (name) arg of MOD_DEV(), MOD_EXEC() and MOD_MISC() from a string to an identifier so that it can be used to generate declarations and strings. It's much easier to stringize an identifier than to identifize a string. A uniform naming scheme must be used for the automatically generated things to apply. This is a feature. Used the module identifer to generate prototypes for the module load, unload and stat functions. Removed the few prototypes for these that already existed. Used the module identifier to generate a unique struct tag in MOD_DEV(). This should probably be done for all the MOD_*() macros. Moved the trailing semicolon from the MOD_*() macro definitions to the macro invocations that didn't already (bogusly) have it. Staticized the module load and unload functions. Added function return types for the module load, unload and stat functions. lkm/ibcs2/ibcs2.c: Included to get everything prototyped. Cleaned up #includes. lkm/ibcs2/ipfw.c: Cleaned up #includes. lkm/linux/linux.c: The module name had to change from "linux_emulator" to "linux_mod" to be automatically generated. Cleaned up #includes. lkm/syscons/*/*_saver.c: Completed delcarations of function pointers. sys/i386/isa/atapi.c: The module name had to change from "atapi" to "atapi_mod" to be automatically generated. sys/i386/isa/wcd.c: Used the fixed MOD_DEV(). This module has two devices and expanded the macro in the source instead of fixing it. The module names had to change from "wcd" and "rwcd" to "wcd_mod" and "rwcd_mod" to be automatically generated. sys/pccard/pcic.c: The module name had to change from "pcic" to "pcic_mod" to be automatically generated. From owner-cvs-sys Tue Nov 14 00:26:08 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA09476 for cvs-sys-outgoing; Tue, 14 Nov 1995 00:26:08 -0800 Received: from tfs.com (tfs.com [140.145.250.1]) by freefall.freebsd.org (8.6.12/8.6.6) with SMTP id AAA09456 ; Tue, 14 Nov 1995 00:25:44 -0800 Received: from critter.tfs.com by tfs.com (smail3.1.28.1) with SMTP id m0tFGgY-0003w1C; Tue, 14 Nov 95 00:25 PST Received: from localhost (localhost [127.0.0.1]) by critter.tfs.com (8.6.11/8.6.9) with SMTP id JAA00221; Tue, 14 Nov 1995 09:25:39 +0100 X-Authentication-Warning: localhost.tfs.com: Host localhost didn't use HELO protocol To: Bruce Evans cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, phk@freefall.freebsd.org Subject: Re: cvs commit: src/sys/kern kern_sysctl.c In-reply-to: Your message of "Tue, 14 Nov 1995 06:29:33 +1100." <199511131929.GAA03496@godzilla.zeta.org.au> Date: Tue, 14 Nov 1995 09:25:38 +0100 Message-ID: <219.816337538@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk > > Modified: sys/kern kern_sysctl.c > > Log: > > Try to make my new scheme work more along the lines of the manual. > > There are still some gray areas here and there. > > I noticed possible sign extension problems: e.g., in sysctl_old_kernel: I have noticed this, I'm not sure I like the choice of types at all, but I'll try to make this consistent. My first goal is to get rid of the corpse, aka all the old sysctl stuff, so that I can concentrate on the new stuff. -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so. From owner-cvs-sys Tue Nov 14 00:54:42 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA11902 for cvs-sys-outgoing; Tue, 14 Nov 1995 00:54:42 -0800 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id AAA11864 ; Tue, 14 Nov 1995 00:54:11 -0800 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id SAA02115; Tue, 14 Nov 1995 18:47:06 +1100 Date: Tue, 14 Nov 1995 18:47:06 +1100 From: Bruce Evans Message-Id: <199511140747.SAA02115@godzilla.zeta.org.au> To: bde@zeta.org.au, davidg@Root.COM Subject: Re: cvs commit: src/sys/nfs nfs_syscalls.c Cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk >>>> Ifdefed duplicated decentralized declarations of args structs. It's >>... >>> Now that the definitions are in sysproto.h, I'd like to see them removed >>>from the .c files. >> >>I'm not sure if they should be removed as far as that. Do you think we >>should remove the pseudo-declarations from all vnode op functions too? >>Such declarations are useful iff they are correct. For examples of >>possibly harmful incorrect ones, see almost any readdir(): > The vnode op functions are auto-generated and not really part of the source >tree. I see syscalls as being different since the delarations are now in a >standard, centralized place. Only the VOP* stubs are automatically generated. Compare rename() with ufs_rename(). We can retire when ufs_rename() can be automatically generated :-). Bruce From owner-cvs-sys Tue Nov 14 01:06:17 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA13442 for cvs-sys-outgoing; Tue, 14 Nov 1995 01:06:17 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA13383 ; Tue, 14 Nov 1995 01:05:48 -0800 Date: Tue, 14 Nov 1995 01:05:48 -0800 From: Poul-Henning Kamp Message-Id: <199511140905.BAA13383@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern sys_process.c kern_sysctl.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk phk 95/11/14 01:05:45 Modified: sys/kern sys_process.c kern_sysctl.c Log: Move the process-table stuff to a more suitable file. Remove filetable stuff from kern_sysctl.c From owner-cvs-sys Tue Nov 14 01:07:50 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA13644 for cvs-sys-outgoing; Tue, 14 Nov 1995 01:07:50 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA13584 ; Tue, 14 Nov 1995 01:07:23 -0800 Date: Tue, 14 Nov 1995 01:07:23 -0800 From: Poul-Henning Kamp Message-Id: <199511140907.BAA13584@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern kern_ntptime.c kern_sysctl.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk phk 95/11/14 01:07:19 Modified: sys/kern kern_ntptime.c kern_sysctl.c Log: Move KERN_NTP to a more suitable file. From owner-cvs-sys Tue Nov 14 01:11:23 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA14091 for cvs-sys-outgoing; Tue, 14 Nov 1995 01:11:23 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA14059 ; Tue, 14 Nov 1995 01:11:01 -0800 Date: Tue, 14 Nov 1995 01:11:01 -0800 From: Poul-Henning Kamp Message-Id: <199511140911.BAA14059@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern kern_xxx.c kern_sysctl.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk phk 95/11/14 01:10:58 Modified: sys/kern kern_xxx.c kern_sysctl.c Log: Get rid of domainnamelen. From owner-cvs-sys Tue Nov 14 01:17:05 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA14635 for cvs-sys-outgoing; Tue, 14 Nov 1995 01:17:05 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA14591 ; Tue, 14 Nov 1995 01:16:36 -0800 Date: Tue, 14 Nov 1995 01:16:36 -0800 From: Poul-Henning Kamp Message-Id: <199511140916.BAA14591@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern kern_proc.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk phk 95/11/14 01:16:32 Modified: sys/kern kern_proc.c Log: Hmm, I seem to have got all my patches screwed up anyway. Too bad. this is where the proctable stuff went. From owner-cvs-sys Tue Nov 14 01:18:04 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA14798 for cvs-sys-outgoing; Tue, 14 Nov 1995 01:18:04 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA14748 ; Tue, 14 Nov 1995 01:17:42 -0800 Date: Tue, 14 Nov 1995 01:17:42 -0800 From: Poul-Henning Kamp Message-Id: <199511140917.BAA14748@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern kern_sysctl.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk phk 95/11/14 01:17:39 Modified: sys/kern kern_sysctl.c Log: KERN_MAXFILESPERPROC, KERN_MAXFILES went to another file. From owner-cvs-sys Tue Nov 14 01:19:38 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA14963 for cvs-sys-outgoing; Tue, 14 Nov 1995 01:19:38 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA14941 ; Tue, 14 Nov 1995 01:19:24 -0800 Date: Tue, 14 Nov 1995 01:19:24 -0800 From: Poul-Henning Kamp Message-Id: <199511140919.BAA14941@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern vfs_cluster.c vfs_subr.c vfs_syscalls.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk phk 95/11/14 01:19:21 Modified: sys/kern vfs_cluster.c vfs_subr.c vfs_syscalls.c Log: Change some of the debug sysctl vars. The semantics of these will change. From owner-cvs-sys Tue Nov 14 01:22:45 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA15380 for cvs-sys-outgoing; Tue, 14 Nov 1995 01:22:45 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA15339 ; Tue, 14 Nov 1995 01:22:22 -0800 Date: Tue, 14 Nov 1995 01:22:22 -0800 From: Poul-Henning Kamp Message-Id: <199511140922.BAA15339@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern kern_sysctl.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk phk 95/11/14 01:22:20 Modified: sys/kern kern_sysctl.c Log: Convert dumpdev & securelevel. From owner-cvs-sys Tue Nov 14 01:26:38 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA15777 for cvs-sys-outgoing; Tue, 14 Nov 1995 01:26:38 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA15743 ; Tue, 14 Nov 1995 01:26:21 -0800 Date: Tue, 14 Nov 1995 01:26:21 -0800 From: Poul-Henning Kamp Message-Id: <199511140926.BAA15743@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern kern_sysctl.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk phk 95/11/14 01:26:19 Modified: sys/kern kern_sysctl.c Log: A couple of nitpicks. From owner-cvs-sys Tue Nov 14 01:29:47 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA16169 for cvs-sys-outgoing; Tue, 14 Nov 1995 01:29:47 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA16126 ; Tue, 14 Nov 1995 01:29:38 -0800 Date: Tue, 14 Nov 1995 01:29:38 -0800 From: Poul-Henning Kamp Message-Id: <199511140929.BAA16126@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/vm vm_extern.h vm_meter.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk phk 95/11/14 01:29:36 Modified: sys/kern kern_sysctl.c sys/vm vm_extern.h vm_meter.c Log: Move all the VM sysctl stuff home where it belongs. From owner-cvs-sys Tue Nov 14 01:37:36 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA17203 for cvs-sys-outgoing; Tue, 14 Nov 1995 01:37:36 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA17175 ; Tue, 14 Nov 1995 01:37:26 -0800 Date: Tue, 14 Nov 1995 01:37:26 -0800 From: Poul-Henning Kamp Message-Id: <199511140937.BAA17175@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern kern_sysctl.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk phk 95/11/14 01:37:25 Modified: sys/isofs/cd9660 cd9660_rrip.c sys/miscfs/kernfs kernfs_vnops.c sys/nfs nfs_vfsops.c sys/kern kern_sysctl.c Log: Get rid of hostnamelen variable. From owner-cvs-sys Tue Nov 14 01:40:14 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA17649 for cvs-sys-outgoing; Tue, 14 Nov 1995 01:40:14 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA17626 ; Tue, 14 Nov 1995 01:40:09 -0800 Date: Tue, 14 Nov 1995 01:40:09 -0800 From: Poul-Henning Kamp Message-Id: <199511140940.BAA17626@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/ufs/ffs ffs_alloc.c ffs_vnops.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk phk 95/11/14 01:40:08 Modified: sys/kern kern_sysctl.c sys/gnu/ext2fs ext2_alloc.c ext2_vnops.c sys/ufs/ffs ffs_alloc.c ffs_vnops.c Log: Get rid of the last debug sysctl variables of the old style. From owner-cvs-sys Tue Nov 14 01:42:50 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA18037 for cvs-sys-outgoing; Tue, 14 Nov 1995 01:42:50 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA17971 ; Tue, 14 Nov 1995 01:42:28 -0800 Date: Tue, 14 Nov 1995 01:42:28 -0800 From: Poul-Henning Kamp Message-Id: <199511140942.BAA17971@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern kern_sysctl.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk phk 95/11/14 01:42:26 Modified: sys/sys sysctl.h sys/kern kern_sysctl.c Log: Final part of this bunch of sysctl commits: cleanup. From owner-cvs-sys Tue Nov 14 01:52:45 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA19419 for cvs-sys-outgoing; Tue, 14 Nov 1995 01:52:45 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA19378 ; Tue, 14 Nov 1995 01:52:31 -0800 Date: Tue, 14 Nov 1995 01:52:31 -0800 From: Poul-Henning Kamp Message-Id: <199511140952.BAA19378@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/i386 machdep.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk phk 95/11/14 01:52:29 Modified: sys/i386/i386 machdep.c Log: Fix a couple of printfs. From owner-cvs-sys Tue Nov 14 01:53:33 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA19550 for cvs-sys-outgoing; Tue, 14 Nov 1995 01:53:33 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA19527 ; Tue, 14 Nov 1995 01:53:23 -0800 Date: Tue, 14 Nov 1995 01:53:23 -0800 From: Poul-Henning Kamp Message-Id: <199511140953.BAA19527@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/isa ultra14f.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk phk 95/11/14 01:53:21 Modified: sys/i386/isa ultra14f.c Log: Make a lot of private stuff static From owner-cvs-sys Tue Nov 14 01:58:47 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA20316 for cvs-sys-outgoing; Tue, 14 Nov 1995 01:58:47 -0800 Received: from tfs.com (tfs.com [140.145.250.1]) by freefall.freebsd.org (8.6.12/8.6.6) with SMTP id BAA20250 ; Tue, 14 Nov 1995 01:58:19 -0800 Received: from critter.tfs.com by tfs.com (smail3.1.28.1) with SMTP id m0tFI88-0003vyC; Tue, 14 Nov 95 01:58 PST Received: from localhost (localhost [127.0.0.1]) by critter.tfs.com (8.6.11/8.6.9) with SMTP id KAA00562; Tue, 14 Nov 1995 10:58:14 +0100 X-Authentication-Warning: localhost.tfs.com: Host localhost didn't use HELO protocol cc: CVS-commiters@freebsd.org, cvs-sys@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_sysctl.c In-reply-to: Your message of "Tue, 14 Nov 1995 01:42:28 PST." <199511140942.BAA17971@freefall.freebsd.org> Date: Tue, 14 Nov 1995 10:58:14 +0100 Message-ID: <560.816343094@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-cvs-sys@freebsd.org Precedence: bulk > phk 95/11/14 01:42:26 > > Modified: sys/sys sysctl.h > sys/kern kern_sysctl.c > Log: > Final part of this bunch of sysctl commits: cleanup. Well, It didn't go as smooth as I had hoped, but I hope the world still stands (& makes). Otherwise yell... I'm not yet done of course, but I'm getting closer... -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so. From owner-cvs-sys Tue Nov 14 01:59:06 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA20374 for cvs-sys-outgoing; Tue, 14 Nov 1995 01:59:06 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA20337 ; Tue, 14 Nov 1995 01:58:52 -0800 Date: Tue, 14 Nov 1995 01:58:52 -0800 From: Poul-Henning Kamp Message-Id: <199511140958.BAA20337@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/scsi 93cx6.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk phk 95/11/14 01:58:49 Modified: sys/i386/isa lpt.c sys/i386/isa/sound ad1848_mixer.h sys/i386/scsi 93cx6.c Log: Staticize various private parts. From owner-cvs-sys Tue Nov 14 02:03:03 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA20983 for cvs-sys-outgoing; Tue, 14 Nov 1995 02:03:03 -0800 Received: from tfs.com (tfs.com [140.145.250.1]) by freefall.freebsd.org (8.6.12/8.6.6) with SMTP id CAA20905 ; Tue, 14 Nov 1995 02:02:27 -0800 Received: from critter.tfs.com by tfs.com (smail3.1.28.1) with SMTP id m0tFIBm-0003vyC; Tue, 14 Nov 95 02:02 PST Received: from localhost (localhost [127.0.0.1]) by critter.tfs.com (8.6.11/8.6.9) with SMTP id LAA00572; Tue, 14 Nov 1995 11:01:48 +0100 X-Authentication-Warning: localhost.tfs.com: Host localhost didn't use HELO protocol To: Peter Wemm cc: Poul-Henning Kamp , CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/kern kern_sysctl.c In-reply-to: Your message of "Tue, 14 Nov 1995 04:48:24 +0800." Date: Tue, 14 Nov 1995 11:01:48 +0100 Message-ID: <570.816343308@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk > Yep. You missed this one: Well, maybe... > + #if 0 > if (arg2) > error = SYSCTL_OUT(req, arg1, arg2); > else > + #endif > This is necessary for sysctl_handle_string (a string by definition is > null terminated. use the sysctl_handle_opaque for a fixed block of > memory. the hostname buffer is a string, not a 256 byte chunk) > > If you dont do the above change, gethostname(buf, 64) will fail with > ENOMEM, and cause gated, amd and mountd to fail. Well, what if the hostname actually WAS 255 bytes long then ? I would rather it fail all the time and we can get the code fixed, than having a mismatch between expectations like this... > I've been using the following hack regression check program while > fiddling. It's probably not entirely right, but it demonstrates the > results of the above breakage. got it. > BTW: it seems like the old sysctl() does not behave as documented.. It > doesn't seem like it will return an estimate of the KERN_HOSTNAME size on > a very old 2.2-current (27 september). The manpage explicitly says > "returns 0 on success and -1 on failure". Old -current and -stable may > need the first assert() commented out. The interface is badly designed, how about this one: get some variable old buffer too small, new buffer correct. it should return ENOMEM because it cannot copyout, but should the new value be installed ? I'm seriously considering allowing only a "get" or a "set" per syscall, not both. But then again, that is too draconian isn't it ? -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so. From owner-cvs-sys Tue Nov 14 02:04:22 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA21183 for cvs-sys-outgoing; Tue, 14 Nov 1995 02:04:22 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA21151 ; Tue, 14 Nov 1995 02:04:08 -0800 Date: Tue, 14 Nov 1995 02:04:08 -0800 From: Poul-Henning Kamp Message-Id: <199511141004.CAA21151@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/pci if_de.c Sender: owner-cvs-sys@FreeBSD.org Precedence: bulk phk 95/11/14 02:04:03 Modified: sys/pci if_de.c Log: statizice some internal magic. From owner-cvs-sys Tue Nov 14 12:35:23 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id MAA10911 for cvs-sys-outgoing; Tue, 14 Nov 1995 12:35:23 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id MAA10850 ; Tue, 14 Nov 1995 12:35:03 -0800 Date: Tue, 14 Nov 1995 12:35:03 -0800 From: Poul-Henning Kamp Message-Id: <199511142035.MAA10850@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/netinet igmp.c igmp_var.h in.c in.h in_pcb.c in_pcb.h in_proto.c in_rmx.c in_var.h ip_fw.c ip_icmp.c ip_icmp.h ip_input.c ip_mroute.c ip_output.c ip_var.h raw_ip.c tcp_debug.c tcp_debug.h tcp_fsm.h tcp_input.c tcp_subr.c tcp_timer.c tcp_timer.h tcp_usrreq.c tcp_var.h udp_usrreq.c udp_var.h Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk phk 95/11/14 12:35:01 Modified: sys/netinet igmp.c igmp_var.h in.c in.h in_pcb.c in_pcb.h in_proto.c in_rmx.c in_var.h ip_fw.c ip_icmp.c ip_icmp.h ip_input.c ip_mroute.c ip_output.c ip_var.h raw_ip.c tcp_debug.c tcp_debug.h tcp_fsm.h tcp_input.c tcp_subr.c tcp_timer.c tcp_timer.h tcp_usrreq.c tcp_var.h udp_usrreq.c udp_var.h Log: New style sysctl & staticize alot of stuff. From owner-cvs-sys Tue Nov 14 12:43:48 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id MAA11658 for cvs-sys-outgoing; Tue, 14 Nov 1995 12:43:48 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id MAA11635 ; Tue, 14 Nov 1995 12:43:32 -0800 Date: Tue, 14 Nov 1995 12:43:32 -0800 From: Poul-Henning Kamp Message-Id: <199511142043.MAA11635@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern kern_sysctl.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk phk 95/11/14 12:43:32 Modified: sys/kern kern_sysctl.c Log: Do what is generally belived to be the right thing, though it may not be :-) From owner-cvs-sys Tue Nov 14 12:49:35 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id MAA12109 for cvs-sys-outgoing; Tue, 14 Nov 1995 12:49:35 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id MAA12092 ; Tue, 14 Nov 1995 12:49:27 -0800 Date: Tue, 14 Nov 1995 12:49:27 -0800 From: Poul-Henning Kamp Message-Id: <199511142049.MAA12092@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/pccard pccard.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk phk 95/11/14 12:49:25 Modified: sys/i386/isa labpc.c sys/pccard pccard.c Log: Fiddle with From owner-cvs-sys Tue Nov 14 12:52:22 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id MAA12297 for cvs-sys-outgoing; Tue, 14 Nov 1995 12:52:22 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id MAA12288 ; Tue, 14 Nov 1995 12:52:17 -0800 Date: Tue, 14 Nov 1995 12:52:17 -0800 From: Poul-Henning Kamp Message-Id: <199511142052.MAA12288@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/include devconf.h Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk phk 95/11/14 12:52:16 Modified: sys/i386/include devconf.h Log: Removed: #include #include #include #include #include #include they are not needed, and slows down compilation. From owner-cvs-sys Tue Nov 14 12:53:26 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id MAA12404 for cvs-sys-outgoing; Tue, 14 Nov 1995 12:53:26 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id MAA12390 ; Tue, 14 Nov 1995 12:53:22 -0800 Date: Tue, 14 Nov 1995 12:53:22 -0800 From: Poul-Henning Kamp Message-Id: <199511142053.MAA12390@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/vm swap_pager.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk phk 95/11/14 12:53:22 Modified: sys/vm swap_pager.c Log: staticize. From owner-cvs-sys Tue Nov 14 19:28:13 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id TAA06525 for cvs-sys-outgoing; Tue, 14 Nov 1995 19:28:13 -0800 Received: (from asami@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id TAA06470 ; Tue, 14 Nov 1995 19:27:30 -0800 Date: Tue, 14 Nov 1995 19:27:30 -0800 From: Satoshi Asami Message-Id: <199511150327.TAA06470@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/scsi cd.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk asami 95/11/14 19:27:19 Modified: sys/scsi cd.c Log: Minor aesthetics (changed "." to space in "cd present.[a x b records]" and removed extraneous newline after "can't get the size"). From owner-cvs-sys Tue Nov 14 20:02:47 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id UAA07491 for cvs-sys-outgoing; Tue, 14 Nov 1995 20:02:47 -0800 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id UAA07483 ; Tue, 14 Nov 1995 20:02:31 -0800 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id OAA16085; Wed, 15 Nov 1995 14:57:23 +1100 Date: Wed, 15 Nov 1995 14:57:23 +1100 From: Bruce Evans Message-Id: <199511150357.OAA16085@godzilla.zeta.org.au> To: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, phk@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa ultra14f.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk > Modified: sys/i386/isa ultra14f.c > Log: > Make a lot of private stuff static Please add `static' to the function headers as well as to (some of) the prototypes. Bruce From owner-cvs-sys Tue Nov 14 20:03:22 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id UAA07571 for cvs-sys-outgoing; Tue, 14 Nov 1995 20:03:22 -0800 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id UAA07556 ; Tue, 14 Nov 1995 20:03:13 -0800 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id PAA16202; Wed, 15 Nov 1995 15:00:21 +1100 Date: Wed, 15 Nov 1995 15:00:21 +1100 From: Bruce Evans Message-Id: <199511150400.PAA16202@godzilla.zeta.org.au> To: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, phk@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/scsi 93cx6.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk > Modified: sys/i386/isa lpt.c > sys/i386/isa/sound ad1848_mixer.h > sys/i386/scsi 93cx6.c > Log: > Staticize various private parts. Please don't declare static varable in header files (see ad1848_mixer.h). Bruce From owner-cvs-sys Tue Nov 14 20:36:24 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id UAA09087 for cvs-sys-outgoing; Tue, 14 Nov 1995 20:36:24 -0800 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id UAA09073 ; Tue, 14 Nov 1995 20:36:14 -0800 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id PAA17458; Wed, 15 Nov 1995 15:29:43 +1100 Date: Wed, 15 Nov 1995 15:29:43 +1100 From: Bruce Evans Message-Id: <199511150429.PAA17458@godzilla.zeta.org.au> To: peter@jhome.dialix.com, phk@critter.tfs.com Subject: Re: cvs commit: src/sys/kern kern_sysctl.c Cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, phk@freefall.freebsd.org Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk I noticed a whole class of (old) sysctl bugs. Consider e.g., setdomainname(). The string is copied in directly over the old string. If the copyin() faults, the old string is trashed. sysctl() returns EFAULT but the caller has no way of knowing if the old value is trashed. To avoid this, all copyin()s should go to temporary storage. The bad malloc() method worked better here :-). >The interface is badly designed, how about this one: > get some variable > old buffer too small, > new buffer correct. >it should return ENOMEM because it cannot copyout, but should the >new value be installed ? mpp and I fixed sysctl_string() to copyout as much as fits. 4.4lite2 is still broken here (it returns immediately). We decided to install the new value in the ENOMEM case. This is probably wrong. Bruce From owner-cvs-sys Tue Nov 14 20:53:27 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id UAA10295 for cvs-sys-outgoing; Tue, 14 Nov 1995 20:53:27 -0800 Received: from jhome.DIALix.COM (jhome.DIALix.COM [192.203.228.69]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id UAA10239 ; Tue, 14 Nov 1995 20:52:56 -0800 Received: (from peter@localhost) by jhome.DIALix.COM (8.6.12/8.6.9) id MAA04435; Wed, 15 Nov 1995 12:51:02 +0800 Date: Wed, 15 Nov 1995 12:51:02 +0800 (WST) From: Peter Wemm To: Bruce Evans cc: phk@critter.tfs.com, CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/kern kern_sysctl.c In-Reply-To: <199511150429.PAA17458@godzilla.zeta.org.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk On Wed, 15 Nov 1995, Bruce Evans wrote: > > I noticed a whole class of (old) sysctl bugs. Consider e.g., > setdomainname(). The string is copied in directly over the > old string. If the copyin() faults, the old string is trashed. > sysctl() returns EFAULT but the caller has no way of knowing > if the old value is trashed. Remember, root doesn't make mistaks. :-) > To avoid this, all copyin()s should go to temporary storage. > The bad malloc() method worked better here :-). Hmm. Poul-Henning has used a useracc(new, newlen, B_READ) before going into the sysctl handlers. I thought this was sufficient to be reasonably sure that accidents aren't going to happen? > >The interface is badly designed, how about this one: > > > get some variable > > old buffer too small, > > new buffer correct. > > >it should return ENOMEM because it cannot copyout, but should the > >new value be installed ? > > mpp and I fixed sysctl_string() to copyout as much as fits. > 4.4lite2 is still broken here (it returns immediately). We decided > to install the new value in the ENOMEM case. This is probably > wrong. Well.. As long as root doesn't make mistaks it's not relevant as it never happens. :-) Seriously though, It is a very definate grey area. I think you are right in both counts.. It should copyout as much as fits on ENOMEM, but if it's going to return an error, it probably should not attempt the copyin. Incidently, I think this is the new behavior of Poul-Henning's code (if copyout fails, copyin not attempted). -Peter > Bruce > From owner-cvs-sys Tue Nov 14 23:46:01 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id XAA01498 for cvs-sys-outgoing; Tue, 14 Nov 1995 23:46:01 -0800 Received: (from davidg@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id XAA01483 ; Tue, 14 Nov 1995 23:45:58 -0800 Date: Tue, 14 Nov 1995 23:45:58 -0800 From: David Greenman Message-Id: <199511150745.XAA01483@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/isa if_ed.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk davidg 95/11/14 23:45:57 Modified: sys/i386/isa if_ed.c Log: Correct the bogus probe for 8216/8416 cards...it was broken. Submitted by: Steve Piette From owner-cvs-sys Tue Nov 14 23:46:42 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id XAA01668 for cvs-sys-outgoing; Tue, 14 Nov 1995 23:46:42 -0800 Received: (from davidg@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id XAA01654 ; Tue, 14 Nov 1995 23:46:38 -0800 Date: Tue, 14 Nov 1995 23:46:38 -0800 From: David Greenman Message-Id: <199511150746.XAA01654@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/isa if_ed.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk davidg 95/11/14 23:46:38 Branch: sys/i386/isa RELENG_2_1_0 Modified: sys/i386/isa if_ed.c Log: Brought in changes from rev 1.85: fix broken probe for 8216/8416 cards. From owner-cvs-sys Wed Nov 15 01:19:51 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA10361 for cvs-sys-outgoing; Wed, 15 Nov 1995 01:19:51 -0800 Received: from tfs.com (tfs.com [140.145.250.1]) by freefall.freebsd.org (8.6.12/8.6.6) with SMTP id BAA10344 ; Wed, 15 Nov 1995 01:19:32 -0800 Received: from critter.tfs.com by tfs.com (smail3.1.28.1) with SMTP id m0tFe0A-0003vlC; Wed, 15 Nov 95 01:19 PST Received: from localhost (localhost [127.0.0.1]) by critter.tfs.com (8.6.11/8.6.9) with SMTP id KAA02527; Wed, 15 Nov 1995 10:19:28 +0100 X-Authentication-Warning: localhost.tfs.com: Host localhost didn't use HELO protocol To: Peter Wemm cc: Bruce Evans , CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/kern kern_sysctl.c In-reply-to: Your message of "Wed, 15 Nov 1995 12:51:02 +0800." Date: Wed, 15 Nov 1995 10:19:27 +0100 Message-ID: <2525.816427167@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk > Hmm. Poul-Henning has used a useracc(new, newlen, B_READ) before going > into the sysctl handlers. I thought this was sufficient to be reasonably > sure that accidents aren't going to happen? Actually, I still lack one feature, which I deliberatly have held back on. The old implementation would lock the (old,oldlen) so that it could do the copyout without a context-switch. In all cases but kern.vnode. I really hate that exception, but on the other hand I'm not sure I really think we should have that feature anyway. It's going to be quite an effort to implement atomicity on a SMP system, and I really don't think it is the right way to solve the problem. I can see that it's a lot easier in the user-land, but boy is it a mess in the kernel. Now, we can agree that the sysctl system call is badly designed. It lacks a get-next, it lacks a "flags" or something similar for controlling a feature like this... I'm not too keen on making yet a new syscall, but it may be the right thing to do nonetheless. The alternative is to use a oid-prefix: 0.1. Get/Set with locked user-land buffers 0.2. GetNext 0.3. GetInfo, returns name & type info on 0.4 GetBulk, "new" is a list of OID's, get them all into "old". (needs some packing rules) Another thing I would love to make is a ability to create variables for user-land purposes: 0.5. Create a variable, "new" holds info. This would allow us to use sysctl as a miniature registry for information, for instance: domainname which crypt to use as default. what to do in malloc in case of an allocation error. anything else you can thing off... What do you people think ? -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so. From owner-cvs-sys Wed Nov 15 01:24:50 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA10780 for cvs-sys-outgoing; Wed, 15 Nov 1995 01:24:50 -0800 Received: from tfs.com (tfs.com [140.145.250.1]) by freefall.freebsd.org (8.6.12/8.6.6) with SMTP id BAA10762 ; Wed, 15 Nov 1995 01:24:32 -0800 Received: from critter.tfs.com by tfs.com (smail3.1.28.1) with SMTP id m0tFe4z-0003vlC; Wed, 15 Nov 95 01:24 PST Received: from localhost (localhost [127.0.0.1]) by critter.tfs.com (8.6.11/8.6.9) with SMTP id KAA02595; Wed, 15 Nov 1995 10:24:27 +0100 X-Authentication-Warning: localhost.tfs.com: Host localhost didn't use HELO protocol To: Bruce Evans cc: peter@jhome.dialix.com, CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, phk@freefall.freebsd.org Subject: Re: cvs commit: src/sys/kern kern_sysctl.c In-reply-to: Your message of "Wed, 15 Nov 1995 15:29:43 +1100." <199511150429.PAA17458@godzilla.zeta.org.au> Date: Wed, 15 Nov 1995 10:24:26 +0100 Message-ID: <2593.816427466@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk > I noticed a whole class of (old) sysctl bugs. Consider e.g., > setdomainname(). The string is copied in directly over the > old string. If the copyin() faults, the old string is trashed. > sysctl() returns EFAULT but the caller has no way of knowing > if the old value is trashed. > > To avoid this, all copyin()s should go to temporary storage. > The bad malloc() method worked better here :-). Hmm, yeah, but how to tell when to use it. I could complicate the policy a bit: copyout(->old) if (error) return (error) copyin(<-new) if (error && we_did_copyout) copyin(<-old) return (error); But is it really worth it ? > >The interface is badly designed, how about this one: > > > get some variable > > old buffer too small, > > new buffer correct. > > >it should return ENOMEM because it cannot copyout, but should the > >new value be installed ? > > mpp and I fixed sysctl_string() to copyout as much as fits. > 4.4lite2 is still broken here (it returns immediately). We decided > to install the new value in the ENOMEM case. This is probably > wrong. I think so... -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so. From owner-cvs-sys Wed Nov 15 06:54:25 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id GAA08196 for cvs-sys-outgoing; Wed, 15 Nov 1995 06:54:25 -0800 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id GAA08175 ; Wed, 15 Nov 1995 06:54:14 -0800 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id BAA08213; Thu, 16 Nov 1995 01:51:11 +1100 Date: Thu, 16 Nov 1995 01:51:11 +1100 From: Bruce Evans Message-Id: <199511151451.BAA08213@godzilla.zeta.org.au> To: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, phk@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/include devconf.h Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk > Modified: sys/i386/include devconf.h > Log: > Removed: > #include > #include > #include > #include > #include > #include > they are not needed, and slows down compilation. These are needed is some applications, e.g., lsdev. I think lsdev should include things for itself; however, the headers shouldn't have any interdependencies that stop them working unless _many_ supporting headers are included in the right order. Bruce From owner-cvs-sys Wed Nov 15 08:42:26 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id IAA20771 for cvs-sys-outgoing; Wed, 15 Nov 1995 08:42:26 -0800 Received: from halloran-eldar.lcs.mit.edu (halloran-eldar.lcs.mit.edu [18.26.0.159]) by freefall.freebsd.org (8.6.12/8.6.6) with SMTP id IAA20684 ; Wed, 15 Nov 1995 08:42:04 -0800 Received: by halloran-eldar.lcs.mit.edu; (5.65/1.1.8.2/19Aug95-0530PM) id AA26165; Wed, 15 Nov 1995 11:41:59 -0500 Date: Wed, 15 Nov 1995 11:41:59 -0500 From: "Garrett A. Wollman" Message-Id: <9511151641.AA26165@halloran-eldar.lcs.mit.edu> To: Poul-Henning Kamp Cc: Peter Wemm , Bruce Evans , CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/kern kern_sysctl.c In-Reply-To: <2525.816427167@critter.tfs.com> References: <2525.816427167@critter.tfs.com> Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk < said: > The old implementation would lock the (old,oldlen) so that it could > do the copyout without a context-switch. > In all cases but kern.vnode. > I really hate that exception, but on the other hand I'm not sure I really > think we should have that feature anyway. It's going to be quite an effort > to implement atomicity on a SMP system, and I really don't think it is the > right way to solve the problem. I can see that it's a lot easier in the > user-land, but boy is it a mess in the kernel. The purpose of this is to prevent race conditions even in a uniprocessor system. > Now, we can agree that the sysctl system call is badly designed. > It lacks a get-next And so? > I'm not too keen on making yet a new syscall, but it may be the right > thing to do nonetheless. The alternative is to use a oid-prefix: > 0.1. Get/Set with locked user-land buffers > 0.2. GetNext > 0.3. GetInfo, returns name & type info on > 0.4 GetBulk, "new" is a list of OID's, get them all > into "old". (needs some packing rules) Ick. > Another thing I would love to make is a ability to create variables for > user-land purposes: > 0.5. Create a variable, "new" holds info. Do it in the C library; that's why there's code on that side of the interface. > This would allow us to use sysctl as a miniature registry for information, > for instance: > domainname There is no reason to store the domain name anywhere, since all it takes to figure it out is: if ((dom = strchr(hostname, '.')) == 0) flame_stupid_idiot_who_didnt_set_hostname_to_FQDN(); dom++; > which crypt to use as default. > what to do in malloc in case of an allocation error. > anything else you can thing off... > What do you people think ? Ick. -GAWollman -- Garrett A. Wollman | Shashish is simple, it's discreet, it's brief. ... wollman@lcs.mit.edu | Shashish is the bonding of hearts in spite of distance. Opinions not those of| It is a bond more powerful than absence. We like people MIT, LCS, ANA, or NSA| who like Shashish. - Claude McKenzie + Florent Vollant From owner-cvs-sys Wed Nov 15 08:55:50 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id IAA22771 for cvs-sys-outgoing; Wed, 15 Nov 1995 08:55:50 -0800 Received: from tfs.com (tfs.com [140.145.250.1]) by freefall.freebsd.org (8.6.12/8.6.6) with SMTP id IAA22705 ; Wed, 15 Nov 1995 08:55:23 -0800 Received: from critter.tfs.com by tfs.com (smail3.1.28.1) with SMTP id m0tFl7J-0003wiC; Wed, 15 Nov 95 08:55 PST Received: from localhost (localhost [127.0.0.1]) by critter.tfs.com (8.6.11/8.6.9) with SMTP id RAA03128; Wed, 15 Nov 1995 17:55:22 +0100 X-Authentication-Warning: localhost.tfs.com: Host localhost didn't use HELO protocol To: "Garrett A. Wollman" cc: Peter Wemm , Bruce Evans , CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/kern kern_sysctl.c In-reply-to: Your message of "Wed, 15 Nov 1995 11:41:59 EST." <9511151641.AA26165@halloran-eldar.lcs.mit.edu> Date: Wed, 15 Nov 1995 17:55:22 +0100 Message-ID: <3126.816454522@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk > < said: > > > The old implementation would lock the (old,oldlen) so that it could > > do the copyout without a context-switch. > > > In all cases but kern.vnode. > > > I really hate that exception, but on the other hand I'm not sure I really > > think we should have that feature anyway. It's going to be quite an effort > > to implement atomicity on a SMP system, and I really don't think it is the > > right way to solve the problem. I can see that it's a lot easier in the > > user-land, but boy is it a mess in the kernel. > > The purpose of this is to prevent race conditions even in a > uniprocessor system. what race-conditions ? -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so. From owner-cvs-sys Wed Nov 15 13:57:32 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id NAA05581 for cvs-sys-outgoing; Wed, 15 Nov 1995 13:57:32 -0800 Received: from ref.tfs.com (ref.tfs.com [140.145.254.251]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id NAA05482 ; Wed, 15 Nov 1995 13:57:10 -0800 Received: (from julian@localhost) by ref.tfs.com (8.6.12/8.6.9) id NAA01351; Wed, 15 Nov 1995 13:55:12 -0800 From: Julian Elischer Message-Id: <199511152155.NAA01351@ref.tfs.com> Subject: Re: cvs commit: src/sys/kern kern_sysctl.c To: phk@critter.tfs.com (Poul-Henning Kamp) Date: Wed, 15 Nov 1995 13:55:11 -0800 (PST) Cc: peter@jhome.dialix.com, bde@zeta.org.au, CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org In-Reply-To: <2525.816427167@critter.tfs.com> from "Poul-Henning Kamp" at Nov 15, 95 10:19:27 am X-Mailer: ELM [version 2.4 PL24] Content-Type: text Content-Length: 850 Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk > > Another thing I would love to make is a ability to create variables for > user-land purposes: > > 0.5. Create a variable, "new" holds info. > > This would allow us to use sysctl as a miniature registry for information, > for instance: > domainname > which crypt to use as default. > what to do in malloc in case of an allocation error. > anything else you can thing off... > > What do you people think ? ok this is like "System-wide" environment variables.. it also means we are going to have 4 ways of doing similar things.. 1/ environment variables passwd from init 2/ sysctl variables 3/ /proc and /kern could be extended to store these things 4/ I've considered extending devfs to allow access to system stuff I thought about being able to extend the sysctl interface into a f/s interface (just replace them dots with /) :) From owner-cvs-sys Thu Nov 16 01:02:20 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA16266 for cvs-sys-outgoing; Thu, 16 Nov 1995 01:02:20 -0800 Received: from tfs.com (tfs.com [140.145.250.1]) by freefall.freebsd.org (8.6.12/8.6.6) with SMTP id BAA16214 ; Thu, 16 Nov 1995 01:02:05 -0800 Received: from critter.tfs.com by tfs.com (smail3.1.28.1) with SMTP id m0tG0Co-0003wlC; Thu, 16 Nov 95 01:02 PST Received: from localhost (localhost [127.0.0.1]) by critter.tfs.com (8.6.11/8.6.9) with SMTP id KAA04390; Thu, 16 Nov 1995 10:02:00 +0100 X-Authentication-Warning: localhost.tfs.com: Host localhost didn't use HELO protocol To: Julian Elischer cc: peter@jhome.dialix.com, bde@zeta.org.au, CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/kern kern_sysctl.c In-reply-to: Your message of "Wed, 15 Nov 1995 13:55:11 PST." <199511152155.NAA01351@ref.tfs.com> Date: Thu, 16 Nov 1995 10:01:59 +0100 Message-ID: <4388.816512519@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk > > Another thing I would love to make is a ability to create variables for > > user-land purposes: > > > > 0.5. Create a variable, "new" holds info. > > > > This would allow us to use sysctl as a miniature registry for information, > > for instance: > > domainname > > which crypt to use as default. > > what to do in malloc in case of an allocation error. > > anything else you can thing off... > > > > What do you people think ? > > ok this is like "System-wide" environment variables.. except that if we check on the securelvl, they are much safer than any other method... > it also means we are going to have 4 ways of doing similar things.. > 1/ environment variables passwd from init can't be relied on, anyone can change them. > 2/ sysctl variables Can be protected by securelvl, or even by their own "change-no-more" sysctl variable. > 3/ /proc and /kern could be extended to store these things /kern should die and sysctl used insted. (unless we think plan9 is the way to go :-) > 4/ I've considered extending devfs to allow access to > system stuff don't. Keep devfs for device nodes. Don't mix too much in there. > I thought about being able to extend the sysctl interface into a f/s interfac e > (just replace them dots with /) Yeah, but why ? -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so. From owner-cvs-sys Thu Nov 16 01:45:37 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA23985 for cvs-sys-outgoing; Thu, 16 Nov 1995 01:45:37 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA23960 ; Thu, 16 Nov 1995 01:45:27 -0800 Date: Thu, 16 Nov 1995 01:45:27 -0800 From: Bruce Evans Message-Id: <199511160945.BAA23960@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern vfs_subr.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/16 01:45:26 Modified: sys/kern vfs_subr.c Log: Fixed support for DIAGNOSTIC option. SYSCTL_INT() depends on kernel.h. From owner-cvs-sys Thu Nov 16 01:51:34 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA25063 for cvs-sys-outgoing; Thu, 16 Nov 1995 01:51:34 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA25046 ; Thu, 16 Nov 1995 01:51:24 -0800 Date: Thu, 16 Nov 1995 01:51:24 -0800 From: Bruce Evans Message-Id: <199511160951.BAA25046@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/vm swap_pager.c swap_pager.h Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/16 01:51:23 Modified: sys/netinet udp_usrreq.c udp_var.h sys/vm swap_pager.c swap_pager.h Log: Fixed recent staticizations. Some protypes for static functions were left in headers and not staticized. From owner-cvs-sys Thu Nov 16 01:56:20 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA25871 for cvs-sys-outgoing; Thu, 16 Nov 1995 01:56:20 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA25801 ; Thu, 16 Nov 1995 01:56:08 -0800 Date: Thu, 16 Nov 1995 01:56:08 -0800 From: Bruce Evans Message-Id: <199511160956.BAA25801@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/isa if_ed.c lpt.c pcaudio.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/16 01:56:06 Modified: sys/i386/isa if_ed.c lpt.c pcaudio.c Log: Included . It used to be included as a side effect of including . From owner-cvs-sys Thu Nov 16 02:07:40 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA27644 for cvs-sys-outgoing; Thu, 16 Nov 1995 02:07:40 -0800 Received: from ref.tfs.com (ref.tfs.com [140.145.254.251]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id CAA27630 ; Thu, 16 Nov 1995 02:07:32 -0800 Received: (from julian@localhost) by ref.tfs.com (8.6.12/8.6.9) id CAA01384; Thu, 16 Nov 1995 02:05:21 -0800 From: Julian Elischer Message-Id: <199511161005.CAA01384@ref.tfs.com> Subject: Re: cvs commit: src/sys/kern kern_sysctl.c To: phk@critter.tfs.com (Poul-Henning Kamp) Date: Thu, 16 Nov 1995 02:05:18 -0800 (PST) Cc: peter@jhome.dialix.com, bde@zeta.org.au, CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org In-Reply-To: <4388.816512519@critter.tfs.com> from "Poul-Henning Kamp" at Nov 16, 95 10:01:59 am X-Mailer: ELM [version 2.4 PL24] Content-Type: text Content-Length: 1889 Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk > > 1/ environment variables passwd from init > can't be relied on, anyone can change them. that depends on the semantics of env variables.. > > 2/ sysctl variables > Can be protected by securelvl, or even by their own > "change-no-more" sysctl variable. > > 3/ /proc and /kern could be extended to store these things > /kern should die and sysctl used insted. (unless we think > plan9 is the way to go :-) well? why not.. why have several DIFFERENT hierarchical schemes for maintaining this stuff.. ? > > 4/ I've considered extending devfs to allow access to > > system stuff > don't. Keep devfs for device nodes. Don't mix too much in there. devfs could become part of a virtual root fs which could encompass all that stuff.. > > > I thought about being able to extend the sysctl interface into a f/s interfac > e > > (just replace them dots with /) > Yeah, but why ? because it seems like so much duplication.... I just thought of a counter-argument however.. chroot'd processes still need to get to sysctl stuff just the same... On that topic I'd like to think about a few things.. some time.. 1/ disjoint filesystems :) 2/ directories having data e.g. # cd /fred # cat . this directory contains sources for foo # ls Makefile foo.c foo.h OR in devfs.... # fdisk /devs/rsd0 [make slice] # disklabel /devs/rsd0/slice1 [make partition] # newfs /devs/rsd0/slice1/parta # mount /devs/sd0/slice1/parta /mnt I think I could make that work.. :) can hardly wait for my holidays.. I have SO MUCH I want to hack on :) :) :) julian +----------------------------------+ ______ _ __ | __--_|\ Julian Elischer | \ U \/ / On assignment | / \ julian@ref.tfs.com +------>x USA \ in a very strange | ( OZ ) 300 lakeside Dr. oakland CA. \___ ___ | country ! +- X_.---._/ USA+(510) 645-3137(wk) \_/ \\ v From owner-cvs-sys Thu Nov 16 02:11:06 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA28203 for cvs-sys-outgoing; Thu, 16 Nov 1995 02:11:06 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA28185 ; Thu, 16 Nov 1995 02:10:55 -0800 Date: Thu, 16 Nov 1995 02:10:55 -0800 From: Bruce Evans Message-Id: <199511161010.CAA28185@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/gnu/isdn if_ii.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/16 02:10:54 Modified: sys/gnu/isdn if_ii.c Log: Fixed the types of iioutput() and ii_input(). Trailing args were missing. Completed function declarations. From owner-cvs-sys Thu Nov 16 02:22:47 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA29612 for cvs-sys-outgoing; Thu, 16 Nov 1995 02:22:47 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA29588 ; Thu, 16 Nov 1995 02:22:36 -0800 Date: Thu, 16 Nov 1995 02:22:36 -0800 From: Bruce Evans Message-Id: <199511161022.CAA29588@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/gnu/isdn iitel.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/16 02:22:35 Modified: sys/gnu/isdn iitel.c Log: Fixed the type of itel_input(). A trailing arg was missing. Included "conf.h" to get some prototypes. Removed some useless includes. From owner-cvs-sys Thu Nov 16 02:35:43 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA01341 for cvs-sys-outgoing; Thu, 16 Nov 1995 02:35:43 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA01312 ; Thu, 16 Nov 1995 02:35:36 -0800 Date: Thu, 16 Nov 1995 02:35:36 -0800 From: Bruce Evans Message-Id: <199511161035.CAA01312@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/gnu/isdn iitty.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/16 02:35:33 Modified: sys/gnu/isdn iitty.c Log: Fixed the type of ity_input(). A trailing arg was missing. Completed function declarations. Added prototypes. Removed some useless includes. From owner-cvs-sys Thu Nov 16 02:45:12 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA02622 for cvs-sys-outgoing; Thu, 16 Nov 1995 02:45:12 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA02579 ; Thu, 16 Nov 1995 02:44:53 -0800 Date: Thu, 16 Nov 1995 02:44:53 -0800 From: Bruce Evans Message-Id: <199511161044.CAA02579@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/gnu/isdn isdn_ioctl.h Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/16 02:44:51 Modified: sys/gnu/isdn isdn_ioctl.h Log: Completed function declarations. Added prototypes. From owner-cvs-sys Thu Nov 16 02:47:36 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA02959 for cvs-sys-outgoing; Thu, 16 Nov 1995 02:47:36 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA02923 ; Thu, 16 Nov 1995 02:47:24 -0800 Date: Thu, 16 Nov 1995 02:47:24 -0800 From: Bruce Evans Message-Id: <199511161047.CAA02923@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/gnu/isdn isdn.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/16 02:47:23 Modified: sys/gnu/isdn isdn.c Log: Fixed a call to the listen function. A trailing arg was missing. Fixed the type of isdn_check(). A trailing arg was missing. Included "conf.h" to get some prototypes. Completed function declarations. Added prototypes. Removed some useless includes. From owner-cvs-sys Thu Nov 16 02:58:46 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA04525 for cvs-sys-outgoing; Thu, 16 Nov 1995 02:58:46 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA04491 ; Thu, 16 Nov 1995 02:58:39 -0800 Date: Thu, 16 Nov 1995 02:58:39 -0800 From: Bruce Evans Message-Id: <199511161058.CAA04491@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/miscfs/fdesc fdesc_vfsops.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/16 02:58:37 Modified: sys/miscfs/fdesc fdesc_vfsops.c Log: Fixed the type of fdesc_sync(). Trailing args were missing. Fixed the type of fdesc_fhtovp(). The args had little resemblance to the correct ones. Added prototypes. From owner-cvs-sys Thu Nov 16 03:16:29 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id DAA06459 for cvs-sys-outgoing; Thu, 16 Nov 1995 03:16:29 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id DAA06440 ; Thu, 16 Nov 1995 03:16:17 -0800 Date: Thu, 16 Nov 1995 03:16:17 -0800 From: Bruce Evans Message-Id: <199511161116.DAA06440@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/miscfs/kernfs kernfs_vfsops.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/16 03:16:16 Modified: sys/miscfs/kernfs kernfs_vfsops.c Log: Fixed the type of kernfs_sync(). Trailing args were missing. Fixed the type of kernfs_fhtovp(). The args had little resemblance to the correct ones. Added prototypes. From owner-cvs-sys Thu Nov 16 03:24:23 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id DAA07216 for cvs-sys-outgoing; Thu, 16 Nov 1995 03:24:23 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id DAA07207 ; Thu, 16 Nov 1995 03:24:10 -0800 Date: Thu, 16 Nov 1995 03:24:10 -0800 From: Bruce Evans Message-Id: <199511161124.DAA07207@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/miscfs/portal portal_vfsops.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/16 03:24:09 Modified: sys/miscfs/portal portal_vfsops.c Log: Fixed the type of portal_sync(). Trailing args were missing. Fixed the type of portal_fhtovp(). The args had little resemblance to the correct ones. Added prototypes. From owner-cvs-sys Thu Nov 16 03:35:15 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id DAA08171 for cvs-sys-outgoing; Thu, 16 Nov 1995 03:35:15 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id DAA08152 ; Thu, 16 Nov 1995 03:34:56 -0800 Date: Thu, 16 Nov 1995 03:34:56 -0800 From: Bruce Evans Message-Id: <199511161134.DAA08152@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/miscfs/procfs procfs_vfsops.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/16 03:34:54 Modified: sys/miscfs/procfs procfs_vfsops.c Log: Fixed the type of procfs_sync(). Trailing args were missing. Fixed the type of procfs_fhtovp(). The args had little resemblance to the correct ones. Added prototypes. From owner-cvs-sys Thu Nov 16 03:39:24 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id DAA08415 for cvs-sys-outgoing; Thu, 16 Nov 1995 03:39:24 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id DAA08404 ; Thu, 16 Nov 1995 03:39:14 -0800 Date: Thu, 16 Nov 1995 03:39:14 -0800 From: Bruce Evans Message-Id: <199511161139.DAA08404@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/miscfs/procfs procfs.h procfs_vnops.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/16 03:39:13 Modified: sys/miscfs/procfs procfs.h procfs_vnops.c Log: Moved declarations for static functions to the correct place (not in a header). Removed stupid comments. From owner-cvs-sys Thu Nov 16 03:48:31 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id DAA08856 for cvs-sys-outgoing; Thu, 16 Nov 1995 03:48:31 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id DAA08836 ; Thu, 16 Nov 1995 03:48:15 -0800 Date: Thu, 16 Nov 1995 03:48:15 -0800 From: Bruce Evans Message-Id: <199511161148.DAA08836@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/msdosfs msdosfs_vfsops.c msdosfsmount.h Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/16 03:48:13 Modified: sys/msdosfs msdosfs_vfsops.c msdosfsmount.h Log: Moved declarations for static functions to the correct place (not in a header) and cleaned them up. From owner-cvs-sys Thu Nov 16 11:00:36 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id LAA06386 for cvs-sys-outgoing; Thu, 16 Nov 1995 11:00:36 -0800 Received: (from phk@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id LAA06374 ; Thu, 16 Nov 1995 11:00:28 -0800 Date: Thu, 16 Nov 1995 11:00:28 -0800 From: Poul-Henning Kamp Message-Id: <199511161900.LAA06374@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/sys sysctl.h Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk phk 95/11/16 11:00:27 Modified: sys/kern kern_sysctl.c uipc_domain.c sys/net route.h rtsock.c sys/sys sysctl.h Log: All net.* sysctl converted now. From owner-cvs-sys Fri Nov 17 04:11:43 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id EAA28549 for cvs-sys-outgoing; Fri, 17 Nov 1995 04:11:43 -0800 Received: (from davidg@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id EAA28537 ; Fri, 17 Nov 1995 04:11:28 -0800 Date: Fri, 17 Nov 1995 04:11:28 -0800 From: David Greenman Message-Id: <199511171211.EAA28537@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/pci if_de.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk davidg 95/11/17 04:11:27 Modified: sys/pci if_de.c Log: Set flag to stop backoff counter from counting when carrier activity is detected. This dramatically reduces the collision rate (about 1/10th of what is was previously). Submitted by: Matt Thomas From owner-cvs-sys Fri Nov 17 04:16:55 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id EAA28903 for cvs-sys-outgoing; Fri, 17 Nov 1995 04:16:55 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.222.226]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id EAA28891 ; Fri, 17 Nov 1995 04:16:32 -0800 Received: from localhost (localhost [127.0.0.1]) by time.cdrom.com (8.6.12/8.6.9) with SMTP id EAA02940; Fri, 17 Nov 1995 04:15:35 -0800 To: David Greenman cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/pci if_de.c In-reply-to: Your message of "Fri, 17 Nov 1995 04:11:28 PST." <199511171211.EAA28537@freefall.freebsd.org> Date: Fri, 17 Nov 1995 04:15:35 -0800 Message-ID: <2938.816610535@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk P.S. Changes like this post-2.1 really make a strong argument for a unified patch mechanism. Can we start talking about this again now, please? Jordan > davidg 95/11/17 04:11:27 > > Modified: sys/pci if_de.c > Log: > Set flag to stop backoff counter from counting when carrier activity is > detected. This dramatically reduces the collision rate (about 1/10th of > what is was previously). > > Submitted by: Matt Thomas From owner-cvs-sys Fri Nov 17 06:52:05 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id GAA07535 for cvs-sys-outgoing; Fri, 17 Nov 1995 06:52:05 -0800 Received: from tfs.com (tfs.com [140.145.250.1]) by freefall.freebsd.org (8.6.12/8.6.6) with SMTP id GAA07482 ; Fri, 17 Nov 1995 06:51:52 -0800 Received: from critter.tfs.com by tfs.com (smail3.1.28.1) with SMTP id m0tGS8X-0003wWC; Fri, 17 Nov 95 06:51 PST Received: from localhost (localhost [127.0.0.1]) by critter.tfs.com (8.6.11/8.6.9) with SMTP id NAA01558; Fri, 17 Nov 1995 13:38:27 +0100 X-Authentication-Warning: critter.tfs.com: Host localhost didn't use HELO protocol To: "Jordan K. Hubbard" cc: David Greenman , CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/pci if_de.c In-reply-to: Your message of "Fri, 17 Nov 1995 04:15:35 PST." <2938.816610535@time.cdrom.com> Date: Fri, 17 Nov 1995 13:38:27 +0100 Message-ID: <1556.816611907@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk > P.S. Changes like this post-2.1 really make a strong argument for a > unified patch mechanism. Can we start talking about this again > now, please? > I'm all for using CTM. -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so. From owner-cvs-sys Fri Nov 17 07:25:21 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id HAA08889 for cvs-sys-outgoing; Fri, 17 Nov 1995 07:25:21 -0800 Received: from Root.COM (implode.Root.COM [198.145.90.17]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id HAA08875 ; Fri, 17 Nov 1995 07:25:05 -0800 Received: from corbin.Root.COM (corbin [198.145.90.50]) by Root.COM (8.6.12/8.6.5) with ESMTP id HAA00259; Fri, 17 Nov 1995 07:24:58 -0800 Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.12/8.6.5) with SMTP id HAA00371; Fri, 17 Nov 1995 07:24:30 -0800 Message-Id: <199511171524.HAA00371@corbin.Root.COM> To: Poul-Henning Kamp cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/pci if_de.c In-reply-to: Your message of "Fri, 17 Nov 95 13:38:27 +0100." <1556.816611907@critter.tfs.com> From: David Greenman Reply-To: davidg@Root.COM Date: Fri, 17 Nov 1995 07:24:30 -0800 Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk >> P.S. Changes like this post-2.1 really make a strong argument for a >> unified patch mechanism. Can we start talking about this again >> now, please? >> >I'm all for using CTM. CTM isn't for everyone. I really would prefer an FTP based patch mechanism. -DG From owner-cvs-sys Fri Nov 17 07:34:09 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id HAA09442 for cvs-sys-outgoing; Fri, 17 Nov 1995 07:34:09 -0800 Received: from tfs.com (tfs.com [140.145.250.1]) by freefall.freebsd.org (8.6.12/8.6.6) with SMTP id HAA09412 ; Fri, 17 Nov 1995 07:33:55 -0800 Received: from critter.tfs.com by tfs.com (smail3.1.28.1) with SMTP id m0tGSnZ-0003vmC; Fri, 17 Nov 95 07:33 PST Received: from localhost (localhost [127.0.0.1]) by critter.tfs.com (8.6.11/8.6.9) with SMTP id QAA00251; Fri, 17 Nov 1995 16:33:50 +0100 X-Authentication-Warning: critter.tfs.com: Host localhost didn't use HELO protocol To: davidg@Root.COM cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/pci if_de.c In-reply-to: Your message of "Fri, 17 Nov 1995 07:24:30 PST." <199511171524.HAA00371@corbin.Root.COM> Date: Fri, 17 Nov 1995 16:33:49 +0100 Message-ID: <249.816622429@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk > >> P.S. Changes like this post-2.1 really make a strong argument for a > >> unified patch mechanism. Can we start talking about this again > >> now, please? > >> > >I'm all for using CTM. > > CTM isn't for everyone. I really would prefer an FTP based patch mechanism From owner-cvs-sys Fri Nov 17 14:24:02 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id OAA02895 for cvs-sys-outgoing; Fri, 17 Nov 1995 14:24:02 -0800 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id OAA02884 ; Fri, 17 Nov 1995 14:23:46 -0800 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id JAA25889; Sat, 18 Nov 1995 09:20:45 +1100 Date: Sat, 18 Nov 1995 09:20:45 +1100 From: Bruce Evans Message-Id: <199511172220.JAA25889@godzilla.zeta.org.au> To: davidg@Root.COM, phk@critter.tfs.com Subject: Re: cvs commit: src/sys/pci if_de.c Cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk >> >I'm all for using CTM. >> >> CTM isn't for everyone. I really would prefer an FTP based patch mechanism >. >Applying CTM deltas is easy... > cat foo | ctm get foo "|ctm" ctm is a reliable patch mechanism that happens to have a lot of support for mail transport. Bruce From owner-cvs-sys Fri Nov 17 20:20:06 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id UAA17847 for cvs-sys-outgoing; Fri, 17 Nov 1995 20:20:06 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id UAA17764 ; Fri, 17 Nov 1995 20:19:48 -0800 Date: Fri, 17 Nov 1995 20:19:48 -0800 From: Bruce Evans Message-Id: <199511180419.UAA17764@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/gnu/i386/isa nic3008.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/17 20:19:47 Modified: sys/gnu/i386/isa nic3008.c Log: Fixed the type of nic_listen(). A trailing arg was missing. Fixed calls to s_intr(). There was sometimes an extra trailing arg. From owner-cvs-sys Fri Nov 17 20:37:46 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id UAA19563 for cvs-sys-outgoing; Fri, 17 Nov 1995 20:37:46 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id UAA19517 ; Fri, 17 Nov 1995 20:37:28 -0800 Date: Fri, 17 Nov 1995 20:37:28 -0800 From: Bruce Evans Message-Id: <199511180437.UAA19517@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/apm apm.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/17 20:37:27 Modified: sys/i386/apm apm.c Log: Fixed the types of apm_default_resume() and apm_default_suspend(). Added prototypes. From owner-cvs-sys Fri Nov 17 21:12:24 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id VAA22644 for cvs-sys-outgoing; Fri, 17 Nov 1995 21:12:24 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id VAA22605 ; Fri, 17 Nov 1995 21:12:13 -0800 Date: Fri, 17 Nov 1995 21:12:13 -0800 From: Bruce Evans Message-Id: <199511180512.VAA22605@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/boot/kzipboot boot.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/17 21:12:12 Modified: sys/i386/boot/kzipboot boot.c Log: Fixed scrolling. The bottom line wasn't cleared. This caused the boot to display "Booting the kernelel...done" instead of "Booting the kernel". Removed save and restore of BIOS memory. kzipped kernels haven't ever overlaid the BIOS memory. From owner-cvs-sys Fri Nov 17 21:25:46 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id VAA23890 for cvs-sys-outgoing; Fri, 17 Nov 1995 21:25:46 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id VAA23880 ; Fri, 17 Nov 1995 21:25:28 -0800 Date: Fri, 17 Nov 1995 21:25:28 -0800 From: Bruce Evans Message-Id: <199511180525.VAA23880@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/boot/kzipboot head.S tail.S Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/17 21:25:26 Modified: sys/i386/boot/kzipboot head.S tail.S Log: Removed bogus padding that wasted 0x500 bytes. Improved code and comments. Don't do anything except transfer control in the head.o module. From owner-cvs-sys Fri Nov 17 21:34:25 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id VAA24508 for cvs-sys-outgoing; Fri, 17 Nov 1995 21:34:25 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id VAA24462 ; Fri, 17 Nov 1995 21:34:05 -0800 Date: Fri, 17 Nov 1995 21:34:05 -0800 From: Bruce Evans Message-Id: <199511180534.VAA24462@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/conf files.i386 Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/17 21:34:03 Modified: sys/i386/conf files.i386 Log: Restored the device-driverness off wd.c. It got lost when wdc was introduced. Fixed the device-driverness of atapi.c and spkr.c. These changes are actually no-ops because ${DRIVER_C} is the same as ${NORMAL_C} for the i386. I could do without magic CFLAGS. Special handling should be in the sources if possible. From owner-cvs-sys Fri Nov 17 22:49:54 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id WAA28405 for cvs-sys-outgoing; Fri, 17 Nov 1995 22:49:54 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id WAA28378 ; Fri, 17 Nov 1995 22:49:38 -0800 Date: Fri, 17 Nov 1995 22:49:38 -0800 From: Bruce Evans Message-Id: <199511180649.WAA28378@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/i386 db_interface.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/17 22:49:38 Modified: sys/i386/i386 db_interface.c Log: Fixed handling of trace traps when cons_unavail is set. Added comments about handing of other cases. From owner-cvs-sys Fri Nov 17 22:54:16 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id WAA29004 for cvs-sys-outgoing; Fri, 17 Nov 1995 22:54:16 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id WAA28992 ; Fri, 17 Nov 1995 22:54:12 -0800 Date: Fri, 17 Nov 1995 22:54:12 -0800 From: Bruce Evans Message-Id: <199511180654.WAA28992@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/i386 vm_machdep.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/17 22:54:12 Modified: sys/i386/i386 vm_machdep.c Log: Fixed the type of vm_fault_quick() - don't convert types back and forth through bogus immediate types. Added prototypes. From owner-cvs-sys Fri Nov 17 23:07:13 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id XAA00201 for cvs-sys-outgoing; Fri, 17 Nov 1995 23:07:13 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id XAA00183 ; Fri, 17 Nov 1995 23:07:07 -0800 Date: Fri, 17 Nov 1995 23:07:07 -0800 From: Bruce Evans Message-Id: <199511180707.XAA00183@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/isa cx.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/17 23:07:06 Modified: sys/i386/isa cx.c Log: Fixed the type of a timeout function. Removed related bogus casts of function pointers. Removed a bogus include. From owner-cvs-sys Fri Nov 17 23:48:19 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id XAA01522 for cvs-sys-outgoing; Fri, 17 Nov 1995 23:48:19 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id XAA01513 ; Fri, 17 Nov 1995 23:48:13 -0800 Date: Fri, 17 Nov 1995 23:48:13 -0800 From: Bruce Evans Message-Id: <199511180748.XAA01513@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/isa fd.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/17 23:48:12 Modified: sys/i386/isa fd.c Log: Fixed (nonexistent) initialization of bp->b_pblkno. disksort() for floppies must have been random in 2.x since we reintroduced sorting on b_pblkno on 1995/03/18. Drivers still initialize b_cylin/b_resid although this is no longer used. Removed unused, wrong function fdsize(). (Returning 0 means that the device exists and has size 0, not that the device doesn't exist. swaponvp() allows for size 0 by stupidly calling the d_psize function twice if the size isn't 0. setdumpdev() doesn't allow for it.) Continued removing /* ARGSUSED */ from drivers. From owner-cvs-sys Sat Nov 18 00:12:50 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA02235 for cvs-sys-outgoing; Sat, 18 Nov 1995 00:12:50 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA02215 ; Sat, 18 Nov 1995 00:12:33 -0800 Date: Sat, 18 Nov 1995 00:12:33 -0800 From: Bruce Evans Message-Id: <199511180812.AAA02215@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/isa/ic i82586.h Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/18 00:12:32 Modified: sys/i386/isa/ic i82586.h Log: Staticized an inline function. All inlines in kernel headers should be static. The function shouldn't be here anyway. It is driver dependent, while `ic' files are supposed to only depend on the IC. From owner-cvs-sys Sat Nov 18 00:22:26 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA02643 for cvs-sys-outgoing; Sat, 18 Nov 1995 00:22:26 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA02596 ; Sat, 18 Nov 1995 00:21:18 -0800 Date: Sat, 18 Nov 1995 00:21:18 -0800 From: Bruce Evans Message-Id: <199511180821.AAA02596@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/isa if_cx.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/18 00:21:17 Modified: sys/i386/isa if_cx.c Log: Fixed a bogus include path. Removed a bogus include. Added prototypes. From owner-cvs-sys Sat Nov 18 00:29:15 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA02936 for cvs-sys-outgoing; Sat, 18 Nov 1995 00:29:15 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA02926 ; Sat, 18 Nov 1995 00:29:07 -0800 Date: Sat, 18 Nov 1995 00:29:07 -0800 From: Bruce Evans Message-Id: <199511180829.AAA02926@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/isa if_ed.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/18 00:29:07 Modified: sys/i386/isa if_ed.c Log: Fixed staticization - use `static' in function headers, not just in prototypes. From owner-cvs-sys Sat Nov 18 00:36:17 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA03226 for cvs-sys-outgoing; Sat, 18 Nov 1995 00:36:17 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA03174 ; Sat, 18 Nov 1995 00:35:53 -0800 Date: Sat, 18 Nov 1995 00:35:53 -0800 From: Bruce Evans Message-Id: <199511180835.AAA03174@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/isa if_ie.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/18 00:35:52 Modified: sys/i386/isa if_ie.c Log: Fixed the type of a timeout function. Added prototypes. From owner-cvs-sys Sat Nov 18 00:39:37 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA03334 for cvs-sys-outgoing; Sat, 18 Nov 1995 00:39:37 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA03324 ; Sat, 18 Nov 1995 00:39:30 -0800 Date: Sat, 18 Nov 1995 00:39:30 -0800 From: Bruce Evans Message-Id: <199511180839.AAA03324@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/isa if_ze.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/18 00:39:30 Modified: sys/i386/isa if_ze.c Log: Fixed the types of the apm hook functions. Completed function declarations. Added prototypes. From owner-cvs-sys Sat Nov 18 00:58:25 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA03966 for cvs-sys-outgoing; Sat, 18 Nov 1995 00:58:25 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA03957 ; Sat, 18 Nov 1995 00:58:17 -0800 Date: Sat, 18 Nov 1995 00:58:17 -0800 From: Bruce Evans Message-Id: <199511180858.AAA03957@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/isa if_zp.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/18 00:58:16 Modified: sys/i386/isa if_zp.c Log: Fixed the types of the apm hook functions. Completed function declarations. Added prototypes. Partially fixed the path to cons.h. From owner-cvs-sys Sat Nov 18 01:30:02 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA05146 for cvs-sys-outgoing; Sat, 18 Nov 1995 01:30:02 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA05117 ; Sat, 18 Nov 1995 01:29:43 -0800 Date: Sat, 18 Nov 1995 01:29:43 -0800 From: Bruce Evans Message-Id: <199511180929.BAA05117@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/isa isa.h Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/18 01:29:41 Modified: sys/i386/isa isa.h Log: Updated comments. The comments about the unused addresses get broken almost every time someone uses an address. This file is probably not the right place to keep track of the unused addresses (or used addresses :->). Fixed comments on #endif's to match code. Added defines for ASC and GSC sizes. This file is not the right place to keep track of scanner addresses, but while there here and we pretend to keep track of unused addresses, the sizes need to be here too. Sorted IO_*SIZE defines. From owner-cvs-sys Sat Nov 18 01:38:12 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA06282 for cvs-sys-outgoing; Sat, 18 Nov 1995 01:38:12 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA06237 ; Sat, 18 Nov 1995 01:37:52 -0800 Date: Sat, 18 Nov 1995 01:37:52 -0800 From: Bruce Evans Message-Id: <199511180937.BAA06237@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/i386/isa/sound dev_table.h Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/18 01:37:49 Modified: sys/i386/isa/sound dev_table.h Log: Moved bogusly placed #endif that hid some prototypes. From owner-cvs-sys Sat Nov 18 02:02:16 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA08972 for cvs-sys-outgoing; Sat, 18 Nov 1995 02:02:16 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id CAA08911 ; Sat, 18 Nov 1995 02:01:48 -0800 Date: Sat, 18 Nov 1995 02:01:48 -0800 From: Bruce Evans Message-Id: <199511181001.CAA08911@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern kern_sig.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/18 02:01:43 Modified: sys/kern kern_sig.c Log: Cleaned up SA_NODEFER changes. Added prototypes. From owner-cvs-sys Sat Nov 18 03:07:23 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id DAA14154 for cvs-sys-outgoing; Sat, 18 Nov 1995 03:07:23 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id DAA14142 ; Sat, 18 Nov 1995 03:07:06 -0800 Date: Sat, 18 Nov 1995 03:07:06 -0800 From: Bruce Evans Message-Id: <199511181107.DAA14142@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern tty_compat.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/18 03:07:04 Modified: sys/kern tty_compat.c Log: Improved formatting. Added a comment about possibly better handling of INPCK. Added a prototype. From owner-cvs-sys Sat Nov 18 03:26:47 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id DAA15376 for cvs-sys-outgoing; Sat, 18 Nov 1995 03:26:47 -0800 Received: from irz301.inf.tu-dresden.de (irz301.inf.tu-dresden.de [141.76.1.11]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id DAA15348 ; Sat, 18 Nov 1995 03:26:11 -0800 Received: from sax.sax.de by irz301.inf.tu-dresden.de (8.6.12/8.6.12-s1) with ESMTP id MAA02416; Sat, 18 Nov 1995 12:24:42 +0100 Received: by sax.sax.de (8.6.11/8.6.12-s1) with UUCP id MAA14169; Sat, 18 Nov 1995 12:24:42 +0100 Received: (from j@localhost) by uriah.heep.sax.de (8.6.12/8.6.9) id LAA20777; Sat, 18 Nov 1995 11:41:58 +0100 From: J Wunsch Message-Id: <199511181041.LAA20777@uriah.heep.sax.de> Subject: Re: cvs commit: src/sys/i386/isa isa.h To: bde@freefall.freebsd.org (Bruce Evans) Date: Sat, 18 Nov 1995 11:41:58 +0100 (MET) Cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: <199511180929.BAA05117@freefall.freebsd.org> from "Bruce Evans" at Nov 18, 95 01:29:43 am X-Phone: +49-351-2012 669 X-Mailer: ELM [version 2.4 PL23] MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Content-Length: 698 Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk As Bruce Evans wrote: > > bde 95/11/18 01:29:41 > > Modified: sys/i386/isa isa.h > Log: > Updated comments. The comments about the unused addresses get broken > almost every time someone uses an address. This file is probably not > the right place to keep track of the unused addresses (or used > addresses :->). Updated... Fixed... perhaps it's also time to finally move out the timer base frequency #define into isa.h now? (The various definitions could perhaps be found by "XXX should be in isa.h". :-) -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-) From owner-cvs-sys Sat Nov 18 03:35:48 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id DAA16130 for cvs-sys-outgoing; Sat, 18 Nov 1995 03:35:48 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id DAA16094 ; Sat, 18 Nov 1995 03:35:16 -0800 Date: Sat, 18 Nov 1995 03:35:16 -0800 From: Bruce Evans Message-Id: <199511181135.DAA16094@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern vfs_syscalls.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/18 03:35:13 Modified: sys/kern vfs_syscalls.c Log: Fixed the errno returned by rename("dir1", "dir2/."). It was EISDIR (duh); translate it to EINVAL which is the errno for other renames to ".". From owner-cvs-sys Sat Nov 18 04:28:58 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id EAA18502 for cvs-sys-outgoing; Sat, 18 Nov 1995 04:28:58 -0800 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id EAA18487 ; Sat, 18 Nov 1995 04:28:29 -0800 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id XAA23409; Sat, 18 Nov 1995 23:27:45 +1100 Date: Sat, 18 Nov 1995 23:27:45 +1100 From: Bruce Evans Message-Id: <199511181227.XAA23409@godzilla.zeta.org.au> To: bde@freefall.freebsd.org, j@uriah.heep.sax.de Subject: Re: cvs commit: src/sys/i386/isa isa.h Cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk >> Modified: sys/i386/isa isa.h >> Log: >> Updated comments. The comments about the unused addresses get broken >> almost every time someone uses an address. This file is probably not >> the right place to keep track of the unused addresses (or used >> addresses :->). >Updated... Fixed... perhaps it's also time to finally move out the >timer base frequency #define into isa.h now? (The various definitions >could perhaps be found by "XXX should be in isa.h". :-) I didn't know much about the header layout when I wrote the first of those XXX's. The frequency should be defined in a clock driver `reg.h' file (`reg' is a misleading abbreviation for `mapping of the device registers to i/o or memory and other miscellaneous bus glue). We already have two such files with mostly misplaced things in them: timerreg.h for the `clk0' device rtc.h for the `rtc0' device We should have ic/i825[3-4].h for the clk0 device's ic clkreg.h for the clk0 device's bus glue including TIMER_FREQ ic/mc146818.h for the rtc0 device's ic rtcreg.h for the rtc0 device's bus glue (this is particularly messy because the device registers are multiplexed and some firmware (BIOS) conventions are best recorded here) I won't be cleaning this up any time sonn because I'm sick of cleaning up (and I still have to commit prototype-related changes for about 300 files). Bruce From owner-cvs-sys Sat Nov 18 04:49:42 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id EAA19437 for cvs-sys-outgoing; Sat, 18 Nov 1995 04:49:42 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id EAA19416 ; Sat, 18 Nov 1995 04:49:22 -0800 Date: Sat, 18 Nov 1995 04:49:22 -0800 From: Bruce Evans Message-Id: <199511181249.EAA19416@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/miscfs/specfs spec_vnops.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/18 04:49:19 Modified: sys/miscfs/specfs spec_vnops.c Log: KNFized spec_getpages_idone() and spec_getpages(). Moved misplaced #includes. Completed function pointer declarations. From owner-cvs-sys Sat Nov 18 05:01:58 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id FAA20348 for cvs-sys-outgoing; Sat, 18 Nov 1995 05:01:58 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id FAA20290 ; Sat, 18 Nov 1995 05:01:28 -0800 Date: Sat, 18 Nov 1995 05:01:28 -0800 From: Bruce Evans Message-Id: <199511181301.FAA20290@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/net if.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/18 05:01:23 Modified: sys/net if.c Log: Added bogus casts to avoid warnings. Continued cleaning up sysinit stuff. From owner-cvs-sys Sat Nov 18 05:08:13 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id FAA20911 for cvs-sys-outgoing; Sat, 18 Nov 1995 05:08:13 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id FAA20885 ; Sat, 18 Nov 1995 05:07:57 -0800 Date: Sat, 18 Nov 1995 05:07:57 -0800 From: Bruce Evans Message-Id: <199511181307.FAA20885@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/net slcompress.h Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/18 05:07:54 Modified: sys/net slcompress.h Log: Fixed a comment. From owner-cvs-sys Sat Nov 18 05:25:54 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id FAA23741 for cvs-sys-outgoing; Sat, 18 Nov 1995 05:25:54 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id FAA23728 ; Sat, 18 Nov 1995 05:25:44 -0800 Date: Sat, 18 Nov 1995 05:25:44 -0800 From: Bruce Evans Message-Id: <199511181325.FAA23728@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/netinet ip_icmp.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/18 05:25:43 Modified: sys/netinet ip_icmp.c Log: Fixed the type of a function pointer. From owner-cvs-sys Sat Nov 18 15:34:13 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id PAA25428 for cvs-sys-outgoing; Sat, 18 Nov 1995 15:34:13 -0800 Received: (from dyson@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id PAA25400 ; Sat, 18 Nov 1995 15:34:00 -0800 Date: Sat, 18 Nov 1995 15:34:00 -0800 From: John Dyson Message-Id: <199511182334.PAA25400@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern vfs_bio.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk dyson 95/11/18 15:33:55 Modified: sys/kern vfs_bio.c Log: Added a missing splx(s). From owner-cvs-sys Sat Nov 18 16:51:40 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id QAA29676 for cvs-sys-outgoing; Sat, 18 Nov 1995 16:51:40 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id QAA29664 ; Sat, 18 Nov 1995 16:51:31 -0800 Date: Sat, 18 Nov 1995 16:51:31 -0800 From: Bruce Evans Message-Id: <199511190051.QAA29664@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/sys signalvar.h Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/18 16:51:30 Modified: sys/sys signalvar.h Log: Moved the prototype for setsigvec() from kern_sig.c to signalvar.h. Completed function pointer declarations. From owner-cvs-sys Sat Nov 18 16:59:31 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id QAA00163 for cvs-sys-outgoing; Sat, 18 Nov 1995 16:59:31 -0800 Received: (from bde@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id QAA00151 ; Sat, 18 Nov 1995 16:59:25 -0800 Date: Sat, 18 Nov 1995 16:59:25 -0800 From: Bruce Evans Message-Id: <199511190059.QAA00151@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern kern_time.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk bde 95/11/18 16:59:25 Modified: sys/kern kern_time.c Log: Fixed settimeofday(): - don't allow invalid timevals. - normalize timevals as they are built - don't call timevaladd() with a possibly invalid timeval and normalize the result. Fixed a warning. From owner-cvs-sys Sat Nov 18 17:42:44 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id RAA01712 for cvs-sys-outgoing; Sat, 18 Nov 1995 17:42:44 -0800 Received: (from davidg@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id RAA01703 ; Sat, 18 Nov 1995 17:42:36 -0800 Date: Sat, 18 Nov 1995 17:42:36 -0800 From: David Greenman Message-Id: <199511190142.RAA01703@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern vfs_bio.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk davidg 95/11/18 17:42:36 Branch: sys/kern RELENG_2_1_0 Modified: sys/kern vfs_bio.c Log: Add missing splx(s) - from rev 1.70. Note that this change is too late for 2.1-release. The effects of the missing splx would be seen on NFS clients with soft or intr mounted filesystems and then only after a timeout had occurred. Submitted by: dyson From owner-cvs-sys Sat Nov 18 17:50:51 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id RAA02082 for cvs-sys-outgoing; Sat, 18 Nov 1995 17:50:51 -0800 Received: from rocky.sri.MT.net (rocky.sri.MT.net [204.182.243.10]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id RAA02070 ; Sat, 18 Nov 1995 17:50:37 -0800 Received: (from nate@localhost) by rocky.sri.MT.net (8.6.12/8.6.12) id SAA15427; Sat, 18 Nov 1995 18:53:02 -0700 Date: Sat, 18 Nov 1995 18:53:02 -0700 From: Nate Williams Message-Id: <199511190153.SAA15427@rocky.sri.MT.net> To: David Greenman Cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/kern vfs_bio.c In-Reply-To: <199511190142.RAA01703@freefall.freebsd.org> References: <199511190142.RAA01703@freefall.freebsd.org> Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk > Branch: sys/kern RELENG_2_1_0 > Modified: sys/kern vfs_bio.c > Log: > Add missing splx(s) - from rev 1.70. Note that this change is too late for > 2.1-release. The effects of the missing splx would be seen on NFS clients > with soft or intr mounted filesystems and then only after a timeout had > occurred. Could the NFS bug I reported earlier be related to this fix, since here is the line out of /etc/fstab? fly:/usr5 /usr5 nfs rw,soft,intr Nate From owner-cvs-sys Sat Nov 18 17:52:52 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id RAA02243 for cvs-sys-outgoing; Sat, 18 Nov 1995 17:52:52 -0800 Received: (from davidg@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id RAA02232 ; Sat, 18 Nov 1995 17:52:46 -0800 Date: Sat, 18 Nov 1995 17:52:46 -0800 From: David Greenman Message-Id: <199511190152.RAA02232@freefall.freebsd.org> To: CVS-commiters, cvs-sys Subject: cvs commit: src/sys/kern kern_prot.c Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk davidg 95/11/18 17:52:45 Branch: sys/kern RELENG_2_1_0 Modified: sys/kern kern_prot.c Log: From rev 1.14: Disallow setgroups() with ngroups=0. There should always be one group (the effective gid). This works around a panic ("nfsreq nogrps") that occurs with NFS clients. This change is too late for 2.1-release. Obtained from: 4.4BSD-Lite2 From owner-cvs-sys Sat Nov 18 17:56:34 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id RAA02488 for cvs-sys-outgoing; Sat, 18 Nov 1995 17:56:34 -0800 Received: from Root.COM (implode.Root.COM [198.145.90.17]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id RAA02483 ; Sat, 18 Nov 1995 17:56:29 -0800 Received: from corbin.Root.COM (corbin [198.145.90.50]) by Root.COM (8.6.12/8.6.5) with ESMTP id RAA02493; Sat, 18 Nov 1995 17:56:28 -0800 Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.12/8.6.5) with SMTP id RAA00840; Sat, 18 Nov 1995 17:51:28 -0800 Message-Id: <199511190151.RAA00840@corbin.Root.COM> To: Nate Williams cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/kern vfs_bio.c In-reply-to: Your message of "Sat, 18 Nov 95 18:53:02 MST." <199511190153.SAA15427@rocky.sri.MT.net> From: David Greenman Reply-To: davidg@Root.COM Date: Sat, 18 Nov 1995 17:51:28 -0800 Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk >> Branch: sys/kern RELENG_2_1_0 >> Modified: sys/kern vfs_bio.c >> Log: >> Add missing splx(s) - from rev 1.70. Note that this change is too late for >> 2.1-release. The effects of the missing splx would be seen on NFS clients >> with soft or intr mounted filesystems and then only after a timeout had >> occurred. > >Could the NFS bug I reported earlier be related to this fix, since here >is the line out of /etc/fstab? The nfsreq nogrps panic? No. This bug would show itself as a disk I/O hang. -DG