From owner-cvs-user Thu Aug 24 02:04:40 1995 Return-Path: cvs-user-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id CAA09354 for cvs-user-outgoing; Thu, 24 Aug 1995 02:04:40 -0700 Received: (from phk@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id CAA09345 ; Thu, 24 Aug 1995 02:04:34 -0700 Date: Thu, 24 Aug 1995 02:04:34 -0700 From: Poul-Henning Kamp Message-Id: <199508240904.CAA09345@freefall.FreeBSD.org> To: CVS-commiters, cvs-user Subject: cvs commit: src/lkm/pcic - New directory Sender: cvs-user-owner@FreeBSD.org Precedence: bulk phk 95/08/24 02:04:33 src/lkm/pcic - New directory From owner-cvs-user Thu Aug 24 02:06:35 1995 Return-Path: cvs-user-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id CAA09451 for cvs-user-outgoing; Thu, 24 Aug 1995 02:06:35 -0700 Received: (from phk@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id CAA09422 ; Thu, 24 Aug 1995 02:06:28 -0700 Date: Thu, 24 Aug 1995 02:06:28 -0700 From: Poul-Henning Kamp Message-Id: <199508240906.CAA09422@freefall.FreeBSD.org> To: CVS-commiters, cvs-user Subject: cvs commit: src/lkm/pcic Makefile Sender: cvs-user-owner@FreeBSD.org Precedence: bulk phk 95/08/24 02:06:25 Modified: lkm Makefile Added: lkm/pcic Makefile Log: pcic lkm for the pccard stuff. From owner-cvs-user Fri Aug 25 02:49:30 1995 Return-Path: cvs-user-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id CAA21197 for cvs-user-outgoing; Fri, 25 Aug 1995 02:49:30 -0700 Received: (from phk@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id CAA21169 ; Fri, 25 Aug 1995 02:49:22 -0700 Date: Fri, 25 Aug 1995 02:49:22 -0700 From: Poul-Henning Kamp Message-Id: <199508250949.CAA21169@freefall.FreeBSD.org> To: CVS-commiters, cvs-user Subject: cvs commit: src/lkm/pcic Makefile Sender: cvs-user-owner@FreeBSD.org Precedence: bulk phk 95/08/25 02:49:21 Modified: lkm/pcic Makefile Log: Remove my xxxinit hack. It was too gross. From owner-cvs-user Fri Aug 25 15:52:38 1995 Return-Path: cvs-user-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id PAA07598 for cvs-user-outgoing; Fri, 25 Aug 1995 15:52:38 -0700 Received: (from markm@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id PAA07586 ; Fri, 25 Aug 1995 15:52:33 -0700 Date: Fri, 25 Aug 1995 15:52:33 -0700 From: Mark Murray Message-Id: <199508252252.PAA07586@freefall.FreeBSD.org> To: CVS-commiters, cvs-user Subject: cvs commit: src/eBones/registerd Makefile registerd.c Sender: cvs-user-owner@FreeBSD.org Precedence: bulk markm 95/08/25 15:52:32 Modified: eBones Copyright.MIT Copyright.SIPB Makefile Makefile.inc README.libdes patchlevel.h eBones/acl Makefile acl_files.c acl_files.doc eBones/ext_srvtab Makefile ext_srvtab.c eBones/include ChangeLog Makefile addr_comp.h admin_server.h conf-bsd386i.h conf-bsdapollo.h conf-bsdibm032.h conf-bsdm68k.h conf-bsdsparc.h conf-bsdtahoe.h conf-bsdvax.h conf-ibm370.h conf-pc.h conf-pyr.h conf-ultmips2.h conf.h des.h highc.h kdc.h klog.h kparse.h krb.h krb_conf.h krb_db.h lsb_addr_comp.h osconf.h passwd_server.h principal.h prot.h eBones/kadmin Makefile kadmin.c kadmin_cmds.ct eBones/kadmind Makefile kadm_funcs.c kadm_server.h eBones/kdb Makefile krb_cache.c krb_dbm.c krb_kdb_utils.c krb_lib.c print_princ.c eBones/kdb_destroy Makefile kdb_destroy.c eBones/kdb_edit Makefile kdb_edit.c maketime.c time.h eBones/kdb_init Makefile kdb_init.c eBones/kdb_util Makefile kdb_util.c eBones/kdestroy Makefile kdestroy.c eBones/kerberos Makefile cr_err_reply.c kerberos.c eBones/kinit Makefile kinit.c eBones/klist Makefile klist.c eBones/kprop Makefile kprop.c kprop.h eBones/kpropd Makefile kpropd.c eBones/krb Makefile add_ticket.c create_auth_reply.c create_ciph.c create_death_packet.c create_ticket.c debug_decl.c decomp_ticket.c des_rw.c dest_tkt.c extract_ticket.c fgetst.c get_ad_tkt.c get_admhst.c get_cred.c get_in_tkt.c get_krbhst.c get_krbrlm.c get_phost.c get_pw_tkt.c get_request.c get_svc_in_tkt.c get_tf_fullname.c get_tf_realm.c getrealm.c getst.c in_tkt.c k_gethostname.c klog.c kname_parse.c kntoln.c kparse.c krb_err.et krb_err_txt.c krb_get_in_tkt.c krbglue.c kuserok.c log.c mk_err.c mk_priv.c mk_req.c mk_safe.c month_sname.c netread.c netwrite.c one.c pkt_cipher.c pkt_clen.c rd_err.c rd_priv.c rd_req.c rd_safe.c read_service_key.c recvauth.c save_credentials.c send_to_kdc.c sendauth.c stime.c tf_shm.c tf_util.c tkt_string.c util.c eBones/ksrvtgt Makefile ksrvtgt.c eBones/ksrvutil Makefile ksrvutil.c eBones/kstash Makefile kstash.c eBones/libkadm Makefile kadm.h kadm_cli_wrap.c kadm_err.et kadm_stream.c kadm_supp.c eBones/make_keypair make_keypair.c eBones/passwd kpasswd.c eBones/register Makefile register.c eBones/registerd Makefile registerd.c Log: Start the eBones cleanup ball rolling. These are the start of a lot of work to clean up the FreeBSD eBones code. these changes include, but are not limited to: - Create prototypes for all the library routines - Make all the libraries compile clean with -Wall set - Fix numerous small bugs shown up in the above process - Prepare the code for libdes's removal to secure/ - add register, registerd and make_keypair to the make Lots more will follow in days to come. OK'ed by: rgrimes From owner-cvs-user Fri Aug 25 16:47:01 1995 Return-Path: cvs-user-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id QAA09993 for cvs-user-outgoing; Fri, 25 Aug 1995 16:47:01 -0700 Received: from localhost (localhost [127.0.0.1]) by freefall.FreeBSD.org (8.6.11/8.6.6) with SMTP id QAA09986 ; Fri, 25 Aug 1995 16:46:56 -0700 Message-Id: <199508252346.QAA09986@freefall.FreeBSD.org> X-Authentication-Warning: freefall.FreeBSD.org: Host localhost didn't use HELO protocol To: Mark Murray cc: CVS-commiters@freefall.FreeBSD.org, cvs-user@freefall.FreeBSD.org Subject: Re: cvs commit: src/eBones/registerd Makefile registerd.c In-reply-to: Your message of "Fri, 25 Aug 95 15:52:33 PDT." <199508252252.PAA07586@freefall.FreeBSD.org> Date: Fri, 25 Aug 1995 16:46:55 -0700 From: "Justin T. Gibbs" Sender: cvs-user-owner@FreeBSD.org Precedence: bulk >markm 95/08/25 15:52:32 > > Modified: eBones Copyright.MIT Copyright.SIPB Makefile Makefile.inc > ... > Log: > Start the eBones cleanup ball rolling. > These are the start of a lot of work to clean up the FreeBSD eBones code. > these changes include, but are not limited to: > - Create prototypes for all the library routines > - Make all the libraries compile clean with -Wall set > - Fix numerous small bugs shown up in the above process > - Prepare the code for libdes's removal to secure/ > - add register, registerd and make_keypair to the make > Lots more will follow in days to come. > > OK'ed by: rgrimes Was there a reason for changing all function declarations from: static send_recv(pkt,rpkt,f,_to,addrs) KTEXT pkt; KTEXT rpkt; int f; struct sockaddr_in *_to; struct hostent *addrs; { to: static int send_recv(KTEXT pkt, KTEXT rpkt, int f, struct sockaddr_in *_to, struct hostent *addrs) { I don't view this as a cleanup at all. It makes unnecessary conflicts with the original code and makes it more difficult to incomperate patches from outside sources. :-( -- Justin T. Gibbs =========================================== Software Developer - Walnut Creek CDROM FreeBSD: Turning PCs into workstations =========================================== From owner-cvs-user Fri Aug 25 17:26:31 1995 Return-Path: cvs-user-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id RAA11435 for cvs-user-outgoing; Fri, 25 Aug 1995 17:26:31 -0700 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.34]) by freefall.FreeBSD.org (8.6.11/8.6.6) with ESMTP id RAA11408 ; Fri, 25 Aug 1995 17:26:02 -0700 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id KAA06952; Sat, 26 Aug 1995 10:19:05 +1000 Date: Sat, 26 Aug 1995 10:19:05 +1000 From: Bruce Evans Message-Id: <199508260019.KAA06952@godzilla.zeta.org.au> To: gibbs@freefall.FreeBSD.org, markm@freefall.FreeBSD.org Subject: Re: cvs commit: src/eBones/registerd Makefile registerd.c Cc: CVS-commiters@freefall.FreeBSD.org, cvs-user@freefall.FreeBSD.org Sender: cvs-user-owner@FreeBSD.org Precedence: bulk >Was there a reason for changing all function declarations from: >static send_recv(pkt,rpkt,f,_to,addrs) > KTEXT pkt; > KTEXT rpkt; > int f; > struct sockaddr_in *_to; > struct hostent *addrs; >{ >to: >static int send_recv(KTEXT pkt, KTEXT rpkt, int f, struct sockaddr_in *_to, > struct hostent *addrs) >{ Perhaps lack of a visible policy in this area. >I don't view this as a cleanup at all. It makes unnecessary conflicts with >the original code and makes it more difficult to incomperate patches from >outside sources. I agree. However, if the original really didn't have an explicit return type, then there is no way to get it through gcc -Wall -Wreally-all without changing the key line of the declaration. Bruce From owner-cvs-user Fri Aug 25 17:36:06 1995 Return-Path: cvs-user-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id RAA11948 for cvs-user-outgoing; Fri, 25 Aug 1995 17:36:06 -0700 Received: from localhost (localhost [127.0.0.1]) by freefall.FreeBSD.org (8.6.11/8.6.6) with SMTP id RAA11941 ; Fri, 25 Aug 1995 17:36:03 -0700 Message-Id: <199508260036.RAA11941@freefall.FreeBSD.org> X-Authentication-Warning: freefall.FreeBSD.org: Host localhost didn't use HELO protocol To: Bruce Evans cc: markm@freefall.FreeBSD.org, CVS-commiters@freefall.FreeBSD.org, cvs-user@freefall.FreeBSD.org Subject: Re: cvs commit: src/eBones/registerd Makefile registerd.c In-reply-to: Your message of "Sat, 26 Aug 95 10:19:05 +1000." <199508260019.KAA06952@godzilla.zeta.org.au> Date: Fri, 25 Aug 1995 17:36:03 -0700 From: "Justin T. Gibbs" Sender: cvs-user-owner@FreeBSD.org Precedence: bulk >Perhaps lack of a visible policy in this area. Perhaps. >>I don't view this as a cleanup at all. It makes unnecessary conflicts with >>the original code and makes it more difficult to incomperate patches from >>outside sources. > >I agree. > >However, if the original really didn't have an explicit return type, then >there is no way to get it through gcc -Wall -Wreally-all without changing >the key line of the declaration. > >Bruce I missed the missing int in the declaration. Taking a look through the files as they stand now, the declaration format is very inconsistent. With the few diffs that I've looked at so far, most of the inconsistancies come from today's changes. The code also will not compile without the following diff: Index: registerd/Makefile =================================================================== RCS file: /usr/cvs/src/eBones/registerd/Makefile,v retrieving revision 1.2 diff -c -r1.2 Makefile *** 1.2 1995/08/25 22:52:31 --- Makefile 1995/08/26 00:21:52 *************** *** 10,16 **** PROG= registerd SRCS= registerd.c ! CFLAGS+=-DCRYPT -DKERBEROS -I${.CURDIR}/../register .PATH: ${.CURDIR}/../../usr.bin/rlogin DPADD= ${LIBKDB} ${LIBKRB} ${LIBDES} LDADD= -lkdb -lkrb -ldes --- 10,16 ---- PROG= registerd SRCS= registerd.c ! CFLAGS+=-DCRYPT -DKERBEROS -I${.CURDIR}/../register -I${.CURDIR}/../include .PATH: ${.CURDIR}/../../usr.bin/rlogin DPADD= ${LIBKDB} ${LIBKRB} ${LIBDES} LDADD= -lkdb -lkrb -ldes Index: make_keypair/Makefile =================================================================== RCS file: /usr/cvs/src/eBones/make_keypair/Makefile,v retrieving revision 1.1.1.1 diff -c -r1.1.1.1 Makefile *** 1.1.1.1 1994/09/30 14:50:05 --- Makefile 1995/08/26 00:22:39 *************** *** 2,8 **** PROG= make_keypair MAN8= make_keypair.8 ! CFLAGS+=-DKERBEROS -I${.CURDIR}/../register DPADD= ${LIBKRB} ${LIBDES} LDADD= -lkdb -lkrb -ldes --- 2,8 ---- PROG= make_keypair MAN8= make_keypair.8 ! CFLAGS+=-DKERBEROS -I${.CURDIR}/../register -I${.CURDIR}/../include DPADD= ${LIBKRB} ${LIBDES} LDADD= -lkdb -lkrb -ldes -- Justin T. Gibbs =========================================== Software Developer - Walnut Creek CDROM FreeBSD: Turning PCs into workstations =========================================== From owner-cvs-user Fri Aug 25 21:57:07 1995 Return-Path: cvs-user-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id VAA19142 for cvs-user-outgoing; Fri, 25 Aug 1995 21:57:07 -0700 Received: (from davidg@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id VAA19126 ; Fri, 25 Aug 1995 21:57:04 -0700 Date: Fri, 25 Aug 1995 21:57:04 -0700 From: David Greenman Message-Id: <199508260457.VAA19126@freefall.FreeBSD.org> To: CVS-commiters, cvs-user Subject: cvs commit: src/release/libdisk write_disk.c Sender: cvs-user-owner@FreeBSD.org Precedence: bulk davidg 95/08/25 21:57:04 Modified: release/libdisk write_disk.c Log: Brought in changes from rev 1.14.2.1 into main branch. From owner-cvs-user Fri Aug 25 23:45:27 1995 Return-Path: cvs-user-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id XAA23349 for cvs-user-outgoing; Fri, 25 Aug 1995 23:45:27 -0700 Received: from grunt.grondar.za (grunt.grondar.za [196.7.18.129]) by freefall.FreeBSD.org (8.6.11/8.6.6) with ESMTP id XAA23239 ; Fri, 25 Aug 1995 23:44:28 -0700 Received: from grumble.grondar.za (grumble.grondar.za [196.7.18.130]) by grunt.grondar.za (8.6.12/8.6.9) with ESMTP id IAA05094; Sat, 26 Aug 1995 08:44:20 +0200 Received: from localhost (localhost [127.0.0.1]) by grumble.grondar.za (8.6.11/8.6.9) with SMTP id IAA25059; Sat, 26 Aug 1995 08:44:19 +0200 Message-Id: <199508260644.IAA25059@grumble.grondar.za> X-Authentication-Warning: grumble.grondar.za: Host localhost didn't use HELO protocol To: "Justin T. Gibbs" cc: Mark Murray , CVS-commiters@freefall.FreeBSD.org, cvs-user@freefall.FreeBSD.org Subject: Re: cvs commit: src/eBones/registerd Makefile registerd.c Date: Sat, 26 Aug 1995 08:44:19 +0200 From: Mark Murray Sender: cvs-user-owner@FreeBSD.org Precedence: bulk > Was there a reason for changing all function declarations from: > > static send_recv(pkt,rpkt,f,_to,addrs) > KTEXT pkt; > KTEXT rpkt; > int f; > struct sockaddr_in *_to; > struct hostent *addrs; > { > > to: > > static int send_recv(KTEXT pkt, KTEXT rpkt, int f, struct sockaddr_in *_to, > struct hostent *addrs) > { Yes. The code had not been maintained by its original author(s) in many years (since 1989). I had been asking for a while for code reviewers and help etc, and found little. I then went qnd found a couple of up-to-date (newish) pieces of BSD code (I can't remember which, now) and modeled the coding style on them. The old code was _really_ bad. In many places there were no or conflicting function definitions, and the easiest way to generate headers was to do them in-place. It is _not_ my intention to do this to every piece of code I touch. I just did it here to jack the code back up into the 20th century. > I don't view this as a cleanup at all. It makes unnecessary conflicts with > the original code and makes it more difficult to incomperate patches from > outside sources. I understand your reservations, but there has been little or no movement in this code since 1989, and it is suffering badly from bit rot. We have just about the whole eBones source in our tree now, and anything else just needs the headers. M -- Mark Murray 46 Harvey Rd, Claremont, Cape Town 7700, South Africa +27 21 61-3768 GMT+0200 Finger mark@grumble.grondar.za for PGP key From owner-cvs-user Fri Aug 25 23:50:24 1995 Return-Path: cvs-user-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id XAA23785 for cvs-user-outgoing; Fri, 25 Aug 1995 23:50:24 -0700 Received: from grunt.grondar.za (grunt.grondar.za [196.7.18.129]) by freefall.FreeBSD.org (8.6.11/8.6.6) with ESMTP id XAA23761 ; Fri, 25 Aug 1995 23:50:02 -0700 Received: from grumble.grondar.za (grumble.grondar.za [196.7.18.130]) by grunt.grondar.za (8.6.12/8.6.9) with ESMTP id IAA05108; Sat, 26 Aug 1995 08:49:54 +0200 Received: from localhost (localhost [127.0.0.1]) by grumble.grondar.za (8.6.11/8.6.9) with SMTP id IAA25109; Sat, 26 Aug 1995 08:49:53 +0200 Message-Id: <199508260649.IAA25109@grumble.grondar.za> X-Authentication-Warning: grumble.grondar.za: Host localhost didn't use HELO protocol To: Bruce Evans cc: gibbs@freefall.FreeBSD.org, markm@freefall.FreeBSD.org, CVS-commiters@freefall.FreeBSD.org, cvs-user@freefall.FreeBSD.org Subject: Re: cvs commit: src/eBones/registerd Makefile registerd.c Date: Sat, 26 Aug 1995 08:49:53 +0200 From: Mark Murray Sender: cvs-user-owner@FreeBSD.org Precedence: bulk > >I don't view this as a cleanup at all. It makes unnecessary conflicts with > >the original code and makes it more difficult to incomperate patches from > >outside sources. > > I agree. > > However, if the original really didn't have an explicit return type, then > there is no way to get it through gcc -Wall -Wreally-all without changing > the key line of the declaration. There are very many functions that did not have return types or any other kind of useful info. Doing all this exposed a number of buglets. (BTW, I have not used -Wreally-all. Didn't think it was worth _that_ much trouble) M -- Mark Murray 46 Harvey Rd, Claremont, Cape Town 7700, South Africa +27 21 61-3768 GMT+0200 Finger mark@grumble.grondar.za for PGP key From owner-cvs-user Sat Aug 26 00:00:55 1995 Return-Path: cvs-user-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id AAA24250 for cvs-user-outgoing; Sat, 26 Aug 1995 00:00:55 -0700 Received: from grunt.grondar.za (grunt.grondar.za [196.7.18.129]) by freefall.FreeBSD.org (8.6.11/8.6.6) with ESMTP id AAA24235 ; Sat, 26 Aug 1995 00:00:36 -0700 Received: from grumble.grondar.za (grumble.grondar.za [196.7.18.130]) by grunt.grondar.za (8.6.12/8.6.9) with ESMTP id JAA05139; Sat, 26 Aug 1995 09:00:28 +0200 Received: from localhost (localhost [127.0.0.1]) by grumble.grondar.za (8.6.11/8.6.9) with SMTP id JAA25229; Sat, 26 Aug 1995 09:00:27 +0200 Message-Id: <199508260700.JAA25229@grumble.grondar.za> X-Authentication-Warning: grumble.grondar.za: Host localhost didn't use HELO protocol To: "Justin T. Gibbs" cc: Bruce Evans , markm@freefall.FreeBSD.org, CVS-commiters@freefall.FreeBSD.org, cvs-user@freefall.FreeBSD.org Subject: Re: cvs commit: src/eBones/registerd Makefile registerd.c Date: Sat, 26 Aug 1995 09:00:26 +0200 From: Mark Murray Sender: cvs-user-owner@FreeBSD.org Precedence: bulk > >However, if the original really didn't have an explicit return type, then > >there is no way to get it through gcc -Wall -Wreally-all without changing > >the key line of the declaration. > > > >Bruce > > I missed the missing int in the declaration. Taking a look through the > files as they stand now, the declaration format is very inconsistent. > With the few diffs that I've looked at so far, most of the inconsistancies co me > from today's changes. The code also will not compile without the following > diff: This is because of the impending move of libdes. Damn. Until this happens (RSN), a better patch (actually a 2-day kluge) is to hand copy des.h to /usr/include M -- Mark Murray 46 Harvey Rd, Claremont, Cape Town 7700, South Africa +27 21 61-3768 GMT+0200 Finger mark@grumble.grondar.za for PGP key From owner-cvs-user Sat Aug 26 01:02:38 1995 Return-Path: cvs-user-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id BAA28072 for cvs-user-outgoing; Sat, 26 Aug 1995 01:02:38 -0700 Received: from localhost (localhost [127.0.0.1]) by freefall.FreeBSD.org (8.6.11/8.6.6) with SMTP id BAA28060 ; Sat, 26 Aug 1995 01:02:30 -0700 Message-Id: <199508260802.BAA28060@freefall.FreeBSD.org> X-Authentication-Warning: freefall.FreeBSD.org: Host localhost didn't use HELO protocol To: Mark Murray cc: Mark Murray , CVS-commiters@freefall.FreeBSD.org, cvs-user@freefall.FreeBSD.org Subject: Re: cvs commit: src/eBones/registerd Makefile registerd.c In-reply-to: Your message of "Sat, 26 Aug 95 08:44:19 +0200." <199508260644.IAA25059@grumble.grondar.za> Date: Sat, 26 Aug 1995 01:02:30 -0700 From: "Justin T. Gibbs" Sender: cvs-user-owner@FreeBSD.org Precedence: bulk >Yes. The code had not been maintained by its original author(s) in many years >(since 1989). I had been asking for a while for code reviewers and help etc, >and found little. If the diffs had been sent to me, I would have reviewed them just as I had orignally promised some month or so ago. I make this offer once again since I'm currently working in eBones bringing in the work of an outside author. >I then went qnd found a couple of up-to-date (newish) >pieces of BSD code (I can't remember which, now) and modeled the coding >style on them. Maybe its just me since almost all of my work has been in the kernel and 95% of the kernel follows the first style (including new code). >The old code was _really_ bad. In many places there were no or conflicting >function definitions, and the easiest way to generate headers was to do >them in-place. I have not problem with you fixing the function definitions to be consistent, but that did not require changing the format of 35% of the definitions so that they aren't consistent with the format of the ones you haven't touched. >It is _not_ my intention to do this to every piece of code I touch. I just >did it here to jack the code back up into the 20th century. Which means that the code will continue to be inconsistent in format. >> I don't view this as a cleanup at all. It makes unnecessary conflicts with >> the original code and makes it more difficult to incomperate patches from >> outside sources. > >I understand your reservations, but there has been little or no movement in >this code since 1989, and it is suffering badly from bit rot. We have just >about the whole eBones source in our tree now, and anything else just needs >the headers. Well, it certainly spammed all of my work in bringing in Dieter Dworkin Muller's multi-homed server fixes to eBones, so the scenario was not contrived at all. > >M >-- >Mark Murray >46 Harvey Rd, Claremont, Cape Town 7700, South Africa >+27 21 61-3768 GMT+0200 >Finger mark@grumble.grondar.za for PGP key -- Justin T. Gibbs =========================================== Software Developer - Walnut Creek CDROM FreeBSD: Turning PCs into workstations =========================================== From owner-cvs-user Sat Aug 26 01:12:47 1995 Return-Path: cvs-user-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id BAA28601 for cvs-user-outgoing; Sat, 26 Aug 1995 01:12:47 -0700 Received: from localhost (localhost [127.0.0.1]) by freefall.FreeBSD.org (8.6.11/8.6.6) with SMTP id BAA28587 ; Sat, 26 Aug 1995 01:12:39 -0700 Message-Id: <199508260812.BAA28587@freefall.FreeBSD.org> X-Authentication-Warning: freefall.FreeBSD.org: Host localhost didn't use HELO protocol To: Mark Murray cc: Bruce Evans , markm@freefall.FreeBSD.org, CVS-commiters@freefall.FreeBSD.org, cvs-user@freefall.FreeBSD.org Subject: Re: cvs commit: src/eBones/registerd Makefile registerd.c In-reply-to: Your message of "Sat, 26 Aug 95 09:00:26 +0200." <199508260700.JAA25229@grumble.grondar.za> Date: Sat, 26 Aug 1995 01:12:38 -0700 From: "Justin T. Gibbs" Sender: cvs-user-owner@FreeBSD.org Precedence: bulk >> >However, if the original really didn't have an explicit return type, then >> >there is no way to get it through gcc -Wall -Wreally-all without changing >> >the key line of the declaration. >> > >> >Bruce >> >> I missed the missing int in the declaration. Taking a look through the >> files as they stand now, the declaration format is very inconsistent. >> With the few diffs that I've looked at so far, most of the inconsistancies co >me >> from today's changes. The code also will not compile without the following >> diff: > >This is because of the impending move of libdes. Damn. Until this happens >(RSN), a better patch (actually a 2-day kluge) is to hand copy des.h to >/usr/include Go change the Makefile back to not building registerd and make_keypair. That change was not ready to be committed. It's a much better solution than leaving the tree broken for 2 days. > >M > >-- >Mark Murray >46 Harvey Rd, Claremont, Cape Town 7700, South Africa >+27 21 61-3768 GMT+0200 >Finger mark@grumble.grondar.za for PGP key -- Justin T. Gibbs =========================================== Software Developer - Walnut Creek CDROM FreeBSD: Turning PCs into workstations =========================================== From owner-cvs-user Sat Aug 26 05:45:09 1995 Return-Path: cvs-user-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id FAA17175 for cvs-user-outgoing; Sat, 26 Aug 1995 05:45:09 -0700 Received: (from markm@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id FAA17165 ; Sat, 26 Aug 1995 05:45:07 -0700 Date: Sat, 26 Aug 1995 05:45:07 -0700 From: Mark Murray Message-Id: <199508261245.FAA17165@freefall.FreeBSD.org> To: CVS-commiters, cvs-user Subject: cvs commit: src/eBones/include krb.h Sender: cvs-user-owner@FreeBSD.org Precedence: bulk markm 95/08/26 05:45:07 Modified: eBones/include krb.h Log: Allow the kerberos utilities and kerberised code to still find des.h in the old place. This corrects an upgrade that sneaked through too early. From owner-cvs-user Sat Aug 26 06:46:15 1995 Return-Path: cvs-user-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id GAA18432 for cvs-user-outgoing; Sat, 26 Aug 1995 06:46:15 -0700 Received: (from markm@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id GAA18422 ; Sat, 26 Aug 1995 06:46:13 -0700 Date: Sat, 26 Aug 1995 06:46:13 -0700 From: Mark Murray Message-Id: <199508261346.GAA18422@freefall.FreeBSD.org> To: CVS-commiters, cvs-user Subject: cvs commit: src/eBones Makefile Sender: cvs-user-owner@FreeBSD.org Precedence: bulk markm 95/08/26 06:46:12 Modified: eBones Makefile Log: Remove register, registerd & make_keypair until thedes library is moved. m From owner-cvs-user Sat Aug 26 10:07:14 1995 Return-Path: cvs-user-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id KAA23960 for cvs-user-outgoing; Sat, 26 Aug 1995 10:07:14 -0700 Received: from precipice.shockwave.com (precipice.shockwave.com [171.69.108.33]) by freefall.FreeBSD.org (8.6.11/8.6.6) with ESMTP id KAA23952 ; Sat, 26 Aug 1995 10:07:07 -0700 Received: from localhost (localhost [127.0.0.1]) by precipice.shockwave.com (8.6.12/8.6.12) with SMTP id KAA14627; Sat, 26 Aug 1995 10:04:57 -0700 Message-Id: <199508261704.KAA14627@precipice.shockwave.com> To: Mark Murray cc: "Justin T. Gibbs" , Mark Murray , CVS-commiters@freefall.FreeBSD.org, cvs-user@freefall.FreeBSD.org Subject: Re: cvs commit: src/eBones/registerd Makefile registerd.c In-reply-to: Your message of "Sat, 26 Aug 1995 08:44:19 +0200." <199508260644.IAA25059@grumble.grondar.za> Date: Sat, 26 Aug 1995 10:04:56 -0700 From: Paul Traina Sender: cvs-user-owner@FreeBSD.org Precedence: bulk From: Mark Murray Subject: Re: cvs commit: src/eBones/registerd Makefile registerd.c I understand your reservations, but there has been little or no movement in this code since 1989, and it is suffering badly from bit rot. We have just about the whole eBones source in our tree now, and anything else just needs the headers. In this one particular case, I happen to agree with and support Mark's decision to do this. I think everyone knows how strongly I feel about NOT screwing up other people's code because of integration pains. Well, in this case, it's -our- code (until we do K5).