From owner-cvs-usrbin Sun May 14 15:46:18 1995 Return-Path: cvs-usrbin-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id PAA03371 for cvs-usrbin-outgoing; Sun, 14 May 1995 15:46:18 -0700 Received: (from ache@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id PAA03361 ; Sun, 14 May 1995 15:46:16 -0700 Date: Sun, 14 May 1995 15:46:16 -0700 From: "Andrey A. Chernov" Message-Id: <199505142246.PAA03361@freefall.cdrom.com> To: CVS-commiters, cvs-usrbin Subject: cvs commit: src/usr.bin/tset tset.c Sender: cvs-usrbin-owner@freebsd.org Precedence: bulk ache 95/05/14 15:46:16 Modified: usr.bin/tset tset.c Log: Fix false backspace reporting From owner-cvs-usrbin Sun May 14 17:03:35 1995 Return-Path: cvs-usrbin-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id RAA07144 for cvs-usrbin-outgoing; Sun, 14 May 1995 17:03:35 -0700 Received: (from ache@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id RAA07134 ; Sun, 14 May 1995 17:03:33 -0700 Date: Sun, 14 May 1995 17:03:33 -0700 From: "Andrey A. Chernov" Message-Id: <199505150003.RAA07134@freefall.cdrom.com> To: CVS-commiters, cvs-usrbin Subject: cvs commit: src/usr.bin/rpcgen rpc_parse.c Sender: cvs-usrbin-owner@freebsd.org Precedence: bulk ache 95/05/14 17:03:33 Modified: usr.bin/rpcgen rpc_parse.c Log: End of listcan be not marked, fix it Submitted by: Kai Vorma From owner-cvs-usrbin Sun May 14 17:13:03 1995 Return-Path: cvs-usrbin-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id RAA07876 for cvs-usrbin-outgoing; Sun, 14 May 1995 17:13:03 -0700 Received: from trout.sri.MT.net (trout.sri.MT.net [204.182.243.12]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id RAA07856 ; Sun, 14 May 1995 17:12:48 -0700 Received: (from nate@localhost) by trout.sri.MT.net (8.6.11/8.6.11) id SAA24242; Sun, 14 May 1995 18:16:58 -0600 Date: Sun, 14 May 1995 18:16:58 -0600 From: Nate Williams Message-Id: <199505150016.SAA24242@trout.sri.MT.net> To: "Andrey A. Chernov" Cc: CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com Subject: Re: cvs commit: src/usr.bin/rpcgen rpc_parse.c In-Reply-To: <199505150003.RAA07134@freefall.cdrom.com> References: <199505150003.RAA07134@freefall.cdrom.com> Sender: cvs-usrbin-owner@freebsd.org Precedence: bulk Andrey A. Chernov writes: > ache 95/05/14 17:03:33 > > Modified: usr.bin/rpcgen rpc_parse.c > Log: > End of listcan be not marked, fix it > Submitted by: Kai Vorma I looked at this fix, and I'm not sure that the proposed 'fix' was necessary. Did you look at the fix at determine if it was indeed needed? Nate From owner-cvs-usrbin Sun May 14 23:29:37 1995 Return-Path: cvs-usrbin-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id XAA18590 for cvs-usrbin-outgoing; Sun, 14 May 1995 23:29:37 -0700 Received: from freud.hut.fi (freud.hut.fi [192.26.109.226]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id XAA18582 ; Sun, 14 May 1995 23:29:29 -0700 Received: (from vode@localhost) by freud.hut.fi (8.6.11/8.6.7) id JAA06651; Mon, 15 May 1995 09:28:56 +0300 Date: Mon, 15 May 1995 09:28:56 +0300 (EET DST) From: Kai Vorma To: Nate Williams cc: "Andrey A. Chernov" , CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com Subject: Re: cvs commit: src/usr.bin/rpcgen rpc_parse.c In-Reply-To: <199505150016.SAA24242@trout.sri.MT.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: cvs-usrbin-owner@freebsd.org Precedence: bulk On Sun, 14 May 1995, Nate Williams wrote: > Andrey A. Chernov writes: > > ache 95/05/14 17:03:33 > > > > Modified: usr.bin/rpcgen rpc_parse.c > > Log: > > End of listcan be not marked, fix it > > Submitted by: Kai Vorma > > I looked at this fix, and I'm not sure that the proposed 'fix' was > necessary. Did you look at the fix at determine if it was indeed needed? Without this fix the last plist->next link is uninitialized. rpcgen still works, because the way BSD malloc works (it cannot reuse freed memory so it asks more from the system and that memory is zeroed -> next-link happens to be NULL). I have replaced the system malloc with a better one and rpcgen dumps core without this patch. ..vode From owner-cvs-usrbin Sun May 14 23:57:04 1995 Return-Path: cvs-usrbin-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id XAA19669 for cvs-usrbin-outgoing; Sun, 14 May 1995 23:57:04 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id XAA19651 ; Sun, 14 May 1995 23:56:50 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id XAA05295; Sun, 14 May 1995 23:56:44 -0700 From: "Rodney W. Grimes" Message-Id: <199505150656.XAA05295@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/usr.bin/rpcgen rpc_parse.c To: ache@freefall.cdrom.com (Andrey A. Chernov) Date: Sun, 14 May 1995 23:56:43 -0700 (PDT) Cc: CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com In-Reply-To: <199505150003.RAA07134@freefall.cdrom.com> from "Andrey A. Chernov" at May 14, 95 05:03:33 pm X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 1145 Sender: cvs-usrbin-owner@freebsd.org Precedence: bulk > > ache 95/05/14 17:03:33 > > Modified: usr.bin/rpcgen rpc_parse.c > Log: > End of listcan be not marked, fix it > Submitted by: Kai Vorma I would really like to see commits being review at this stage of the game. Even Jordan, David, myself, and PHK are having almost all of our work reviewed by 1 if not 2 other folks. We need to be extreamly conservative right now. We have what looks to be a pretty damn good system, and with *any* change that may fix one bug there is always the chance of adding another one :-(. I saw this report come in, though about it, and basically decided it was not ``critical enough'' to fix at this time in the game give the risk factor we are operating under. Since you may know more about the rpc code, I will let this patch stand for now, but please, let's all get every thing we do from here until the code FREEZE is lifted reviewed by someone else after we think it looks like a valid thing to be done. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD From owner-cvs-usrbin Mon May 15 00:32:01 1995 Return-Path: cvs-usrbin-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id AAA20643 for cvs-usrbin-outgoing; Mon, 15 May 1995 00:32:01 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id AAA20636 ; Mon, 15 May 1995 00:31:55 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id AAA05385; Mon, 15 May 1995 00:31:18 -0700 From: "Rodney W. Grimes" Message-Id: <199505150731.AAA05385@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/usr.bin/rpcgen rpc_parse.c To: vode@freud.hut.fi (Kai Vorma) Date: Mon, 15 May 1995 00:31:18 -0700 (PDT) Cc: nate@trout.sri.MT.net, ache@freefall.cdrom.com, CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com In-Reply-To: from "Kai Vorma" at May 15, 95 09:28:56 am X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 1309 Sender: cvs-usrbin-owner@freebsd.org Precedence: bulk > > > > On Sun, 14 May 1995, Nate Williams wrote: > > > Andrey A. Chernov writes: > > > ache 95/05/14 17:03:33 > > > > > > Modified: usr.bin/rpcgen rpc_parse.c > > > Log: > > > End of listcan be not marked, fix it > > > Submitted by: Kai Vorma > > > > I looked at this fix, and I'm not sure that the proposed 'fix' was > > necessary. Did you look at the fix at determine if it was indeed needed? > > Without this fix the last plist->next link is uninitialized. rpcgen > still works, because the way BSD malloc works (it cannot reuse freed > memory so it asks more from the system and that memory is zeroed -> > next-link happens to be NULL). > > I have replaced the system malloc with a better one and rpcgen > dumps core without this patch. Then this is not a critical bug fix, becuase as ship freebsd does not have the bug! Are you *absolutely* sure your change has no side effects that would cause something else to break? If so I can live with this change, if not, I am probably going to step a cvs admin -o maj.min on rpc_parse.c and obsolete this last change until after the release is done. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD From owner-cvs-usrbin Mon May 15 00:52:20 1995 Return-Path: cvs-usrbin-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id AAA21012 for cvs-usrbin-outgoing; Mon, 15 May 1995 00:52:20 -0700 Received: from Root.COM (implode.Root.COM [198.145.90.1]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id AAA21004 ; Mon, 15 May 1995 00:52:12 -0700 Received: from corbin.Root.COM (corbin.Root.COM [198.145.90.18]) by Root.COM (8.6.8/8.6.5) with ESMTP id AAA05153; Mon, 15 May 1995 00:55:17 -0700 Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.11/8.6.5) with SMTP id AAA00193; Mon, 15 May 1995 00:52:13 -0700 Message-Id: <199505150752.AAA00193@corbin.Root.COM> To: "Rodney W. Grimes" cc: vode@freud.hut.fi (Kai Vorma), nate@trout.sri.mt.net, ache@freefall.cdrom.com, CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com Subject: Re: cvs commit: src/usr.bin/rpcgen rpc_parse.c In-reply-to: Your message of "Mon, 15 May 95 00:31:18 PDT." <199505150731.AAA05385@gndrsh.aac.dev.com> From: David Greenman Reply-To: davidg@Root.COM Date: Mon, 15 May 1995 00:52:11 -0700 Sender: cvs-usrbin-owner@freebsd.org Precedence: bulk >> On Sun, 14 May 1995, Nate Williams wrote: >> >> > Andrey A. Chernov writes: >> > > ache 95/05/14 17:03:33 >> > > >> > > Modified: usr.bin/rpcgen rpc_parse.c >> > > Log: >> > > End of listcan be not marked, fix it >> > > Submitted by: Kai Vorma >> > >> > I looked at this fix, and I'm not sure that the proposed 'fix' was >> > necessary. Did you look at the fix at determine if it was indeed needed? >> >> Without this fix the last plist->next link is uninitialized. rpcgen >> still works, because the way BSD malloc works (it cannot reuse freed >> memory so it asks more from the system and that memory is zeroed -> >> next-link happens to be NULL). >> >> I have replaced the system malloc with a better one and rpcgen >> dumps core without this patch. > >Then this is not a critical bug fix, becuase as ship freebsd does not >have the bug! > >Are you *absolutely* sure your change has no side effects that would >cause something else to break? If so I can live with this change, >if not, I am probably going to step a cvs admin -o maj.min on rpc_parse.c >and obsolete this last change until after the release is done. I've looked at the change closely and it is correct. In all cases, the "proc_list" is expected to be terminated by a NULL 'next' pointer. The NULL must be assigned here because this is where the list is allocated/constructed, and there is no other place where this can occur. -DG From owner-cvs-usrbin Mon May 15 04:58:12 1995 Return-Path: cvs-usrbin-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id EAA28243 for cvs-usrbin-outgoing; Mon, 15 May 1995 04:58:12 -0700 Received: (from davidg@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id EAA28232 ; Mon, 15 May 1995 04:58:04 -0700 Date: Mon, 15 May 1995 04:58:04 -0700 From: David Greenman Message-Id: <199505151158.EAA28232@freefall.cdrom.com> To: CVS-commiters, cvs-usrbin Subject: cvs commit: src/usr.bin/telnet commands.c Sender: cvs-usrbin-owner@freebsd.org Precedence: bulk davidg 95/05/15 04:58:04 Modified: usr.bin/telnet commands.c Log: Use symbolic "IPTOS_LOWDELAY" instead of octal bit value for this socket option. The bit value was wrong. From owner-cvs-usrbin Mon May 15 06:28:47 1995 Return-Path: cvs-usrbin-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id GAA00665 for cvs-usrbin-outgoing; Mon, 15 May 1995 06:28:47 -0700 Received: from sequent.kiae.su (sequent.kiae.su [144.206.136.6]) by freefall.cdrom.com (8.6.10/8.6.6) with SMTP id GAA00648 ; Mon, 15 May 1995 06:28:29 -0700 Received: by sequent.kiae.su id AA15408 (5.65.kiae-2 ); Mon, 15 May 1995 17:26:03 +0400 Received: by sequent.KIAE.su (UUMAIL/2.0); Mon, 15 May 95 17:26:03 +0400 Received: (from ache@localhost) by astral.msk.su (8.6.8/8.6.6) id RAA00644; Mon, 15 May 1995 17:15:42 +0400 To: "Rodney W. Grimes" Cc: CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com References: <199505150656.XAA05295@gndrsh.aac.dev.com> In-Reply-To: <199505150656.XAA05295@gndrsh.aac.dev.com>; from "Rodney W. Grimes" at Sun, 14 May 1995 23:56:43 -0700 (PDT) Message-Id: Organization: Olahm Ha-Yetzirah Date: Mon, 15 May 1995 17:15:42 +0400 (MSD) X-Mailer: Mail/@ [v2.35 FreeBSD] From: "Andrey A. Chernov, Black Mage" X-Class: Fast Subject: Re: cvs commit: src/usr.bin/rpcgen rpc_parse.c Lines: 37 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Length: 1591 Sender: cvs-usrbin-owner@freebsd.org Precedence: bulk In message <199505150656.XAA05295@gndrsh.aac.dev.com> Rodney W. Grimes writes: >> >> ache 95/05/14 17:03:33 >> >> Modified: usr.bin/rpcgen rpc_parse.c >> Log: >> End of listcan be not marked, fix it >> Submitted by: Kai Vorma >I would really like to see commits being review at this stage of the >game. Even Jordan, David, myself, and PHK are having almost all of >our work reviewed by 1 if not 2 other folks. >I saw this report come in, though about it, and basically decided it >was not ``critical enough'' to fix at this time in the game give the >risk factor we are operating under. >Since you may know more about the rpc code, I will let this patch >stand for now, but please, let's all get every thing we do from here >until the code FREEZE is lifted reviewed by someone else after we >think it looks like a valid thing to be done. Rod, previously you write different things: only kernel and /usr/src/Makefile targets commits must be reviewd by 2 or more peoples (just read your announce), it is bad tone to change policy on the fly. I am smart enough to not commit suspicious thing at this stage or conslut with others about suspicious things. About this patch: I carefully check code flow and find that old code is definitely broken. -- Andrey A. Chernov : And I rest so composedly, /Now, in my bed, ache@astral.msk.su : That any beholder /Might fancy me dead - FidoNet: 2:5020/230.3 : Might start at beholding me, /Thinking me dead. RELCOM Team,FreeBSD Team : E.A.Poe From "For Annie" 1849 From owner-cvs-usrbin Mon May 15 06:31:34 1995 Return-Path: cvs-usrbin-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id GAA00750 for cvs-usrbin-outgoing; Mon, 15 May 1995 06:31:34 -0700 Received: from sequent.kiae.su (sequent.kiae.su [144.206.136.6]) by freefall.cdrom.com (8.6.10/8.6.6) with SMTP id GAA00735 ; Mon, 15 May 1995 06:31:11 -0700 Received: by sequent.kiae.su id AA15465 (5.65.kiae-2 ); Mon, 15 May 1995 17:26:16 +0400 Received: by sequent.KIAE.su (UUMAIL/2.0); Mon, 15 May 95 17:26:15 +0400 Received: (from ache@localhost) by astral.msk.su (8.6.8/8.6.6) id RAA00664; Mon, 15 May 1995 17:23:50 +0400 To: "Rodney W. Grimes" , Kai Vorma Cc: CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com, nate@trout.sri.MT.net References: <199505150731.AAA05385@gndrsh.aac.dev.com> In-Reply-To: <199505150731.AAA05385@gndrsh.aac.dev.com>; from "Rodney W. Grimes" at Mon, 15 May 1995 00:31:18 -0700 (PDT) Message-Id: Organization: Olahm Ha-Yetzirah Date: Mon, 15 May 1995 17:23:50 +0400 (MSD) X-Mailer: Mail/@ [v2.35 FreeBSD] From: "Andrey A. Chernov, Black Mage" X-Class: Fast Subject: Re: cvs commit: src/usr.bin/rpcgen rpc_parse.c Lines: 51 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Length: 1992 Sender: cvs-usrbin-owner@freebsd.org Precedence: bulk In message <199505150731.AAA05385@gndrsh.aac.dev.com> Rodney W. Grimes writes: >> >> >> >> On Sun, 14 May 1995, Nate Williams wrote: >> >> > Andrey A. Chernov writes: >> > > ache 95/05/14 17:03:33 >> > > >> > > Modified: usr.bin/rpcgen rpc_parse.c >> > > Log: >> > > End of listcan be not marked, fix it >> > > Submitted by: Kai Vorma >> > >> > I looked at this fix, and I'm not sure that the proposed 'fix' was >> > necessary. Did you look at the fix at determine if it was indeed needed? >> >> Without this fix the last plist->next link is uninitialized. rpcgen >> still works, because the way BSD malloc works (it cannot reuse freed >> memory so it asks more from the system and that memory is zeroed -> >> next-link happens to be NULL). >> >> I have replaced the system malloc with a better one and rpcgen >> dumps core without this patch. >Then this is not a critical bug fix, becuase as ship freebsd does not >have the bug! It have, but this bag is masked with other things (side effect of malloc). You follow bad way Rod: I remember in some days we have two bugs: one in syscons and one in termcap which masked each other and complex variant do right things, according to your way we don't need to fix them. >Are you *absolutely* sure your change has no side effects that would >cause something else to break? If so I can live with this change, >if not, I am probably going to step a cvs admin -o maj.min on rpc_parse.c >and obsolete this last change until after the release is done. Rod, did you even saw whole code? I think that any one year C programmer can easily understand what happens there with and without this patch. -- Andrey A. Chernov : And I rest so composedly, /Now, in my bed, ache@astral.msk.su : That any beholder /Might fancy me dead - FidoNet: 2:5020/230.3 : Might start at beholding me, /Thinking me dead. RELCOM Team,FreeBSD Team : E.A.Poe From "For Annie" 1849 From owner-cvs-usrbin Tue May 16 04:29:50 1995 Return-Path: cvs-usrbin-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id EAA07585 for cvs-usrbin-outgoing; Tue, 16 May 1995 04:29:50 -0700 Received: (from davidg@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id EAA07573 ; Tue, 16 May 1995 04:29:45 -0700 Date: Tue, 16 May 1995 04:29:45 -0700 From: David Greenman Message-Id: <199505161129.EAA07573@freefall.cdrom.com> To: CVS-commiters, cvs-usrbin Subject: cvs commit: src/usr.bin/w w.c Sender: cvs-usrbin-owner@freebsd.org Precedence: bulk davidg 95/05/16 04:29:43 Modified: usr.bin/w w.c Log: If an ut_host field in an utmp entry contains a ':' (e.g. for an xterm session) w doesn't handle the non-'\0' terminated char arrays in struct utmp properly. Submitted by: jarle@idt.unit.no From owner-cvs-usrbin Wed May 17 20:01:31 1995 Return-Path: cvs-usrbin-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id UAA23089 for cvs-usrbin-outgoing; Wed, 17 May 1995 20:01:31 -0700 Received: (from jfieber@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id UAA23079 ; Wed, 17 May 1995 20:01:29 -0700 Date: Wed, 17 May 1995 20:01:29 -0700 From: John Fieber Message-Id: <199505180301.UAA23079@freefall.cdrom.com> To: CVS-commiters, cvs-usrbin Subject: cvs commit: src/usr.bin/sgmlfmt sgmlfmt.pl Sender: cvs-usrbin-owner@freebsd.org Precedence: bulk jfieber 95/05/17 20:01:29 Modified: usr.bin/sgmlfmt sgmlfmt.pl Log: Remove extraneous empty paragraphs (

) from the output. From owner-cvs-usrbin Fri May 19 02:53:56 1995 Return-Path: cvs-usrbin-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id CAA18501 for cvs-usrbin-outgoing; Fri, 19 May 1995 02:53:56 -0700 Received: (from guido@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id CAA18487 ; Fri, 19 May 1995 02:53:53 -0700 Date: Fri, 19 May 1995 02:53:53 -0700 From: Guido van Rooij Message-Id: <199505190953.CAA18487@freefall.cdrom.com> To: CVS-commiters, cvs-usrbin Subject: cvs commit: src/usr.bin/login login_fbtab.c Sender: cvs-usrbin-owner@freebsd.org Precedence: bulk guido 95/05/19 02:53:52 Modified: usr.bin/login login_fbtab.c Log: Set copyright so we can actually distribute and use it. Reviewed by: David Greenman Submitted by: Wietse Venema Obtained from: