From owner-cvs-etc Mon Jul 29 23:29:10 1996 Return-Path: owner-cvs-etc Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id XAA23558 for cvs-etc-outgoing; Mon, 29 Jul 1996 23:29:10 -0700 (PDT) Received: (from jkh@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id XAA23537; Mon, 29 Jul 1996 23:29:01 -0700 (PDT) Date: Mon, 29 Jul 1996 23:29:01 -0700 (PDT) From: "Jordan K. Hubbard" Message-Id: <199607300629.XAA23537@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-etc Subject: cvs commit: src/etc rc Sender: owner-cvs-etc@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 96/07/29 23:29:00 Modified: etc rc Log: Edit this for consistency's sake (though it's syntactically identical). Noticed-By: "William A. Gill" Revision Changes Path 1.96 +2 -2 src/etc/rc From owner-cvs-etc Tue Jul 30 00:28:51 1996 Return-Path: owner-cvs-etc Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA26996 for cvs-etc-outgoing; Tue, 30 Jul 1996 00:28:51 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id AAA26991; Tue, 30 Jul 1996 00:28:39 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.12/8.6.9) id RAA07220; Tue, 30 Jul 1996 17:20:46 +1000 Date: Tue, 30 Jul 1996 17:20:46 +1000 From: Bruce Evans Message-Id: <199607300720.RAA07220@godzilla.zeta.org.au> To: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-etc@freefall.freebsd.org, jkh@freefall.freebsd.org Subject: Re: cvs commit: src/etc rc Sender: owner-cvs-etc@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > Modified: etc rc > Log: > Edit this for consistency's sake (though it's syntactically identical). > Noticed-By: "William A. Gill" > > Revision Changes Path > 1.96 +2 -2 src/etc/rc There are many more inconsistencies in sysconfig. NO is sometimes quoted and sometimes not. Mostly not. Quoting it mainly wastes space. Also, in rc, some (poor) comments say that the test is $foo != NO, but the test is actually "X${foo}" != X"NO". The braces mainly waste space. Other (poor) comments say that the test is $foo == NO for the reverse condition, but == isn't an operator for `test'. Bruce From owner-cvs-etc Tue Jul 30 00:36:20 1996 Return-Path: owner-cvs-etc Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA27327 for cvs-etc-outgoing; Tue, 30 Jul 1996 00:36:20 -0700 (PDT) Received: from silvia.HIP.Berkeley.EDU (silvia.HIP.Berkeley.EDU [136.152.64.181]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id AAA27303; Tue, 30 Jul 1996 00:36:10 -0700 (PDT) Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.7.5/8.6.9) id AAA03429; Tue, 30 Jul 1996 00:35:50 -0700 (PDT) Date: Tue, 30 Jul 1996 00:35:50 -0700 (PDT) Message-Id: <199607300735.AAA03429@silvia.HIP.Berkeley.EDU> To: bde@zeta.org.au CC: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-etc@freefall.freebsd.org, jkh@freefall.freebsd.org In-reply-to: <199607300720.RAA07220@godzilla.zeta.org.au> (message from Bruce Evans on Tue, 30 Jul 1996 17:20:46 +1000) Subject: Re: cvs commit: src/etc rc From: asami@cs.berkeley.edu (Satoshi Asami) Sender: owner-cvs-etc@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk * the test is actually "X${foo}" != X"NO". The braces mainly waste space. ^^^^^^^^^^^^^^^^^^ This is quite inconsistent itself, shouldn't it be X"$foo" != X"NO" or "X$foo" != "XNO" if we are converting syntactically equivalent statments for consistency's sake? Satoshi From owner-cvs-etc Tue Jul 30 00:47:31 1996 Return-Path: owner-cvs-etc Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA27598 for cvs-etc-outgoing; Tue, 30 Jul 1996 00:47:31 -0700 (PDT) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id AAA27581; Tue, 30 Jul 1996 00:47:24 -0700 (PDT) Received: from time.cdrom.com (localhost [127.0.0.1]) by time.cdrom.com (8.7.5/8.6.9) with ESMTP id AAA11799; Tue, 30 Jul 1996 00:46:45 -0700 (PDT) To: Bruce Evans Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-etc@freefall.freebsd.org Subject: Re: cvs commit: src/etc rc In-reply-to: Your message of "Tue, 30 Jul 1996 17:20:46 +1000." <199607300720.RAA07220@godzilla.zeta.org.au> Date: Tue, 30 Jul 1996 00:46:45 -0700 Message-ID: <11797.838712805@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-etc@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Well, I certainly wasn't setting out to right all of sysinstall's wrongs, just that one submission. ;) If anyone's interested in going on a cleanup rampage in there, please, be my most welcome guest! :-) Jordan > > Modified: etc rc > > Log: > > Edit this for consistency's sake (though it's syntactically identical). > > Noticed-By: "William A. Gill" > > > > Revision Changes Path > > 1.96 +2 -2 src/etc/rc > > There are many more inconsistencies in sysconfig. NO is sometimes quoted > and sometimes not. Mostly not. Quoting it mainly wastes space. > > Also, in rc, some (poor) comments say that the test is $foo != NO, but > the test is actually "X${foo}" != X"NO". The braces mainly waste space. > Other (poor) comments say that the test is $foo == NO for the reverse > condition, but == isn't an operator for `test'. > > Bruce From owner-cvs-etc Tue Jul 30 00:48:30 1996 Return-Path: owner-cvs-etc Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA27647 for cvs-etc-outgoing; Tue, 30 Jul 1996 00:48:30 -0700 (PDT) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id AAA27642; Tue, 30 Jul 1996 00:48:28 -0700 (PDT) Received: from time.cdrom.com (localhost [127.0.0.1]) by time.cdrom.com (8.7.5/8.6.9) with ESMTP id AAA12101; Tue, 30 Jul 1996 00:47:54 -0700 (PDT) To: asami@cs.berkeley.edu (Satoshi Asami) cc: bde@zeta.org.au, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-etc@freefall.freebsd.org, jkh@freefall.freebsd.org Subject: Re: cvs commit: src/etc rc In-reply-to: Your message of "Tue, 30 Jul 1996 00:35:50 PDT." <199607300735.AAA03429@silvia.HIP.Berkeley.EDU> Date: Tue, 30 Jul 1996 00:47:54 -0700 Message-ID: <12099.838712874@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-etc@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk I personally prefer my variable expansions to be *always* bracketed, whether they need it lexically or not, simply because it causes the variable names to stand out better in the text. Jordan > * the test is actually "X${foo}" != X"NO". The braces mainly waste space. > ^^^^^^^^^^^^^^^^^^ > This is quite inconsistent itself, shouldn't it be > > X"$foo" != X"NO" > > or > > "X$foo" != "XNO" > > if we are converting syntactically equivalent statments for > consistency's sake? > > Satoshi From owner-cvs-etc Tue Jul 30 01:00:26 1996 Return-Path: owner-cvs-etc Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA28163 for cvs-etc-outgoing; Tue, 30 Jul 1996 01:00:26 -0700 (PDT) Received: from silvia.HIP.Berkeley.EDU (silvia.HIP.Berkeley.EDU [136.152.64.181]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id BAA28121; Tue, 30 Jul 1996 01:00:09 -0700 (PDT) Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.7.5/8.6.9) id BAA03486; Tue, 30 Jul 1996 01:00:00 -0700 (PDT) Date: Tue, 30 Jul 1996 01:00:00 -0700 (PDT) Message-Id: <199607300800.BAA03486@silvia.HIP.Berkeley.EDU> To: jkh@time.cdrom.com CC: bde@zeta.org.au, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-etc@freefall.freebsd.org, jkh@freefall.freebsd.org In-reply-to: <12099.838712874@time.cdrom.com> (jkh@time.cdrom.com) Subject: Re: cvs commit: src/etc rc From: asami@cs.berkeley.edu (Satoshi Asami) Sender: owner-cvs-etc@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk * I personally prefer my variable expansions to be *always* bracketed, * whether they need it lexically or not, simply because it causes the * variable names to stand out better in the text. * * Jordan * * > * the test is actually "X${foo}" != X"NO". The braces mainly waste space. * > ^^^^^^^^^^^^^^^^^^ * > This is quite inconsistent itself, shouldn't it be * > * > X"$foo" != X"NO" * > * > or * > * > "X$foo" != "XNO" My comment wasn't on curly braces. Please look at the quotes carefully. Actually, as Bruce says, not quoting the XNO at all is probably the best idea. Satoshi From owner-cvs-etc Tue Jul 30 01:47:24 1996 Return-Path: owner-cvs-etc Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA00692 for cvs-etc-outgoing; Tue, 30 Jul 1996 01:47:24 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id BAA00685; Tue, 30 Jul 1996 01:47:19 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.12/8.6.9) id SAA09583; Tue, 30 Jul 1996 18:20:57 +1000 Date: Tue, 30 Jul 1996 18:20:57 +1000 From: Bruce Evans Message-Id: <199607300820.SAA09583@godzilla.zeta.org.au> To: asami@cs.berkeley.edu, jkh@time.cdrom.com Subject: Re: cvs commit: src/etc rc Cc: CVS-committers@freefall.freebsd.org, bde@zeta.org.au, cvs-all@freefall.freebsd.org, cvs-etc@freefall.freebsd.org, jkh@freefall.freebsd.org Sender: owner-cvs-etc@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >I personally prefer my variable expansions to be *always* bracketed, >whether they need it lexically or not, simply because it causes the >variable names to stand out better in the text. I prefer minimal punctuation because it is faster to type and easier to read. Maybe we need a style guide for shell scripts too :-). Bruce From owner-cvs-etc Tue Jul 30 23:47:14 1996 Return-Path: owner-cvs-etc Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id XAA10594 for cvs-etc-outgoing; Tue, 30 Jul 1996 23:47:14 -0700 (PDT) Received: (from pst@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id XAA10579; Tue, 30 Jul 1996 23:47:07 -0700 (PDT) Date: Tue, 30 Jul 1996 23:47:07 -0700 (PDT) From: Paul Traina Message-Id: <199607310647.XAA10579@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-etc Subject: cvs commit: src/etc security Sender: owner-cvs-etc@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk pst 96/07/30 23:47:06 Modified: etc security Log: Move intermediary file generation to /var partition Revision Changes Path 1.14 +2 -2 src/etc/security