From owner-cvs-sbin Sun Dec 1 03:25:48 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA10663 for cvs-sbin-outgoing; Sun, 1 Dec 1996 03:25:48 -0800 (PST) Received: (from sos@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA10646; Sun, 1 Dec 1996 03:25:40 -0800 (PST) Date: Sun, 1 Dec 1996 03:25:40 -0800 (PST) From: Soren Schmidt Message-Id: <199612011125.DAA10646@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sys, cvs-sbin Subject: cvs commit: src/sys/kern subr_diskslice.c src/sbin/i386/fdisk fdisk.c src/sys/ufs/ufs ufs_disksubr.c src/sys/scsi od.c sd.c src/sbin/newfs mkfs.c newfs.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk sos 96/12/01 03:25:39 Modified: sys/kern subr_diskslice.c sys/ufs/ufs ufs_disksubr.c sys/scsi od.c sd.c sbin/i386/fdisk fdisk.c sbin/newfs mkfs.c newfs.c Log: This update adds the support for != 512 byte sector SCSI devices to the sd & od drivers. There is also slight changes to fdisk & newfs in order to comply with different sectorsizes. Currently sectors of size 512, 1024 & 2048 are supported, the only restriction beeing in fdisk, which hunts for the sectorsize of the device. This is based on patches to od.c and the other system files by John Gumb & Barry Scott, minor changes and the sd.c patches by me. There also exist some patches for the msdos filesys code, but I havn't been able to test those (yet). John Gumb (john@talisker.demon.co.uk) Barry Scott (barry@scottb.demon.co.uk) Revision Changes Path 1.31 +3 -1 src/sys/kern/subr_diskslice.c 1.27 +3 -3 src/sys/ufs/ufs/ufs_disksubr.c 1.24 +49 -5 src/sys/scsi/od.c 1.96 +80 -7 src/sys/scsi/sd.c 1.13 +24 -5 src/sbin/i386/fdisk/fdisk.c 1.12 +3 -1 src/sbin/newfs/mkfs.c 1.14 +15 -2 src/sbin/newfs/newfs.c From owner-cvs-sbin Sun Dec 1 05:44:18 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id FAA15161 for cvs-sbin-outgoing; Sun, 1 Dec 1996 05:44:18 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id FAA15147; Sun, 1 Dec 1996 05:44:07 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.3/8.6.9) id AAA20664; Mon, 2 Dec 1996 00:29:20 +1100 Date: Mon, 2 Dec 1996 00:29:20 +1100 From: Bruce Evans Message-Id: <199612011329.AAA20664@godzilla.zeta.org.au> To: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, sos@freefall.freebsd.org Subject: Re: cvs commit: src/sys/kern subr_diskslice.c src/sbin/i386/fdisk fdisk.c src/sys/ufs/ufs ufs_disksubr.c src/sys/scsi od.c sd.c src/sbin/newfs mkfs.c newfs.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > Modified: sys/kern subr_diskslice.c > sys/ufs/ufs ufs_disksubr.c > sys/scsi od.c sd.c > sbin/i386/fdisk fdisk.c > sbin/newfs mkfs.c newfs.c > Log: > This update adds the support for != 512 byte sector SCSI devices to > the sd & od drivers. There is also slight changes to fdisk & newfs > in order to comply with different sectorsizes. > Currently sectors of size 512, 1024 & 2048 are supported, the only > restriction beeing in fdisk, which hunts for the sectorsize of > the device. > This is based on patches to od.c and the other system files by > John Gumb & Barry Scott, minor changes and the sd.c patches by > me. Urk. This version does the scaling in the wrong place. The scaling belongs in subr_diskslice.c, not in dozens of drivers. I was planning to use the version by akiyama@kme.mei.co.jp (Shunsuke Akiyama) in the kernel. Bruce From owner-cvs-sbin Sun Dec 1 08:24:44 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id IAA20015 for cvs-sbin-outgoing; Sun, 1 Dec 1996 08:24:44 -0800 (PST) Received: from irz301.inf.tu-dresden.de (irz301.inf.tu-dresden.de [141.76.1.11]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id IAA19921; Sun, 1 Dec 1996 08:22:48 -0800 (PST) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by irz301.inf.tu-dresden.de (8.6.12/8.6.12-s1) with ESMTP id RAA18320; Sun, 1 Dec 1996 17:22:45 +0100 Received: (from uucp@localhost) by sax.sax.de (8.6.12/8.6.12-s1) with UUCP id RAA20516; Sun, 1 Dec 1996 17:22:44 +0100 Received: (from j@localhost) by uriah.heep.sax.de (8.8.2/8.6.9) id QAA14281; Sun, 1 Dec 1996 16:59:41 +0100 (MET) From: J Wunsch Message-Id: <199612011559.QAA14281@uriah.heep.sax.de> Subject: Re: cvs commit: src/sys/kern subr_diskslice.c src/sbin/i386/fdisk fdisk.c src/sys/ufs/ufs ufs_disksubr.c src/sys/scsi od.c sd.c To: bde@zeta.org.au (Bruce Evans) Date: Sun, 1 Dec 1996 16:59:41 +0100 (MET) Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, sos@freefall.freebsd.org Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: <199612011329.AAA20664@godzilla.zeta.org.au> from Bruce Evans at "Dec 2, 96 00:29:20 am" X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E X-Mailer: ELM [version 2.4ME+ PL17 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk As Bruce Evans wrote: > Urk. This version does the scaling in the wrong place. The scaling > belongs in subr_diskslice.c, not in dozens of drivers. I was planning to > use the version by akiyama@kme.mei.co.jp (Shunsuke Akiyama) in the kernel. Aren't you also on the scsi list? The above has been mildly discussed there, and i cannot remember any arguments from you pro or con either approach. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-) From owner-cvs-sbin Sun Dec 1 08:33:26 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id IAA20443 for cvs-sbin-outgoing; Sun, 1 Dec 1996 08:33:26 -0800 (PST) Received: from ravenock.cybercity.dk (disn46.cybercity.dk [194.16.57.46]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id IAA20419; Sun, 1 Dec 1996 08:33:13 -0800 (PST) Received: (from sos@localhost) by ravenock.cybercity.dk (8.8.3/8.7.3) id RAA23486; Sun, 1 Dec 1996 17:35:20 +0100 (MET) Message-Id: <199612011635.RAA23486@ravenock.cybercity.dk> Subject: Re: cvs commit: src/sys/kern subr_diskslice.c src/sbin/i386/fdisk fdisk.c src/sys/ufs/ufs ufs_disksubr.c src/sys/scsi od.c sd.cO To: bde@zeta.org.au (Bruce Evans) Date: Sun, 1 Dec 1996 17:35:09 +0100 (MET) From: "Soren Schmidt" Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, sos@freefall.freebsd.org In-Reply-To: <199612011329.AAA20664@godzilla.zeta.org.au> from "Bruce Evans" at Dec 2, 96 00:29:20 am From: sos@FreeBSD.org Reply-to: sos@FreeBSD.org X-Mailer: ELM [version 2.4 PL25 ME8b] MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: owner-cvs-sbin@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk In reply to Bruce Evans who wrote: > > > > Modified: sys/kern subr_diskslice.c > > sys/ufs/ufs ufs_disksubr.c > > sys/scsi od.c sd.c > > sbin/i386/fdisk fdisk.c > > sbin/newfs mkfs.c newfs.c > > Log: > > This update adds the support for != 512 byte sector SCSI devices to > > the sd & od drivers. There is also slight changes to fdisk & newfs > > in order to comply with different sectorsizes. > > Currently sectors of size 512, 1024 & 2048 are supported, the only > > restriction beeing in fdisk, which hunts for the sectorsize of > > the device. > > This is based on patches to od.c and the other system files by > > John Gumb & Barry Scott, minor changes and the sd.c patches by > > me. > > Urk. This version does the scaling in the wrong place. The scaling > belongs in subr_diskslice.c, not in dozens of drivers. I was planning to > use the version by akiyama@kme.mei.co.jp (Shunsuke Akiyama) in the kernel. This works for me, but feel free to change it to something better.... -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Søren Schmidt (sos@FreeBSD.org) FreeBSD Core Team Even more code to hack -- will it ever end .. From owner-cvs-sbin Sun Dec 1 09:21:26 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id JAA22302 for cvs-sbin-outgoing; Sun, 1 Dec 1996 09:21:26 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id JAA22284; Sun, 1 Dec 1996 09:21:18 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.3/8.6.9) id EAA27211; Mon, 2 Dec 1996 04:12:32 +1100 Date: Mon, 2 Dec 1996 04:12:32 +1100 From: Bruce Evans Message-Id: <199612011712.EAA27211@godzilla.zeta.org.au> To: bde@zeta.org.au, sos@ravenock.cybercity.dk Subject: Re: cvs commit: src/sys/kern subr_diskslice.c src/sbin/i386/fdisk fdisk.c src/sys/ufs/ufs ufs_disksubr.c src/sys/scsi od.c sd.cO Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, sos@freefall.freebsd.org Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >> > Modified: sys/kern subr_diskslice.c >> > sys/ufs/ufs ufs_disksubr.c >> > sys/scsi od.c sd.c >> > sbin/i386/fdisk fdisk.c >> > sbin/newfs mkfs.c newfs.c >> > Log: >> > This update adds the support for != 512 byte sector SCSI devices to >> >> Urk. This version does the scaling in the wrong place. The scaling > >This works for me, but feel free to change it to something better.... It has a serious problem: od.c and sd.c break the the EOF handling by restoring bp->b_bcount. It is now possible to write beyond the end of a slice or partition. This can probably be fixed quickly by rescaling bp->b_bcount instead of restoring it (the same as for bp->b_resid). I don't have time to test this now. Bruce From owner-cvs-sbin Mon Dec 2 13:42:29 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id NAA15989 for cvs-sbin-outgoing; Mon, 2 Dec 1996 13:42:29 -0800 (PST) Received: (from fenner@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id NAA15957; Mon, 2 Dec 1996 13:42:18 -0800 (PST) Date: Mon, 2 Dec 1996 13:42:18 -0800 (PST) From: Bill Fenner Message-Id: <199612022142.NAA15957@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/ping ping.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk fenner 96/12/02 13:42:14 Modified: sbin/ping ping.c Log: Fix math in SIGINFO printer. Revision Changes Path 1.11 +2 -2 src/sbin/ping/ping.c From owner-cvs-sbin Tue Dec 3 07:41:26 1996 Return-Path: owner-cvs-sbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id HAA22249 for cvs-sbin-outgoing; Tue, 3 Dec 1996 07:41:26 -0800 (PST) Received: (from phk@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id HAA22232; Tue, 3 Dec 1996 07:41:16 -0800 (PST) Date: Tue, 3 Dec 1996 07:41:16 -0800 (PST) From: Poul-Henning Kamp Message-Id: <199612031541.HAA22232@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/ping ping.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 96/12/03 07:41:15 Branch: sbin/ping RELENG_2_2 Modified: sbin/ping ping.c Log: YAMFC Revision Changes Path 1.8.2.3 +2 -2 src/sbin/ping/ping.c From owner-cvs-sbin Sat Dec 7 12:20:47 1996 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id MAA08981 for cvs-sbin-outgoing; Sat, 7 Dec 1996 12:20:47 -0800 (PST) Received: (from sef@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id MAA08968; Sat, 7 Dec 1996 12:20:43 -0800 (PST) Date: Sat, 7 Dec 1996 12:20:43 -0800 (PST) From: Sean Eric Fagan Message-Id: <199612072020.MAA08968@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/ping ping.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk sef 96/12/07 12:20:43 Modified: sbin/ping ping.c Log: Change how SIGINFO is handled -- set a flag (of sig_atomic_t), and check that flag on every iteration of the loop. This avoids calling fprintf inside a signal handler, which is always somewhat icky. Reviewed by: bde Revision Changes Path 1.12 +34 -15 src/sbin/ping/ping.c From owner-cvs-sbin Sat Dec 7 22:27:12 1996 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id WAA28759 for cvs-sbin-outgoing; Sat, 7 Dec 1996 22:27:12 -0800 (PST) Received: (from pst@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id WAA28752; Sat, 7 Dec 1996 22:27:10 -0800 (PST) Date: Sat, 7 Dec 1996 22:27:10 -0800 (PST) From: Paul Traina Message-Id: <199612080627.WAA28752@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-sbin Subject: cvs commit: src/sbin/ping ping.c Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk pst 96/12/07 22:27:10 Modified: sbin/ping ping.c Log: Fix typo in last patch. empty!=emtpy Revision Changes Path 1.13 +1 -1 src/sbin/ping/ping.c