From owner-cvs-games Mon May 12 22:53:51 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id WAA02148 for cvs-games-outgoing; Mon, 12 May 1997 22:53:51 -0700 (PDT) Received: from freefall.freebsd.org (freefall.cdrom.com [204.216.27.21]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id WAA02117; Mon, 12 May 1997 22:53:31 -0700 (PDT) From: Satoshi Asami Received: (from asami@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id WAA14707; Mon, 12 May 1997 22:52:40 -0700 (PDT) Date: Mon, 12 May 1997 22:52:40 -0700 (PDT) Message-Id: <199705130552.WAA14707@freefall.freebsd.org> To: CVS-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-games@FreeBSD.ORG Subject: cvs commit: src/games/adventure Makefile Sender: owner-cvs-games@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk asami 97/05/12 22:52:40 Modified: games/adventure Makefile Log: Add ${CFLAGS} and ${LDFLAGS} to the setup command line. Revision Changes Path 1.3 +1 -1 src/games/adventure/Makefile From owner-cvs-games Mon May 12 22:59:59 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id WAA02363 for cvs-games-outgoing; Mon, 12 May 1997 22:59:59 -0700 (PDT) Received: from freefall.freebsd.org (freefall.cdrom.com [204.216.27.21]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id WAA02340; Mon, 12 May 1997 22:59:47 -0700 (PDT) From: Satoshi Asami Received: (from asami@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id WAA14766; Mon, 12 May 1997 22:58:56 -0700 (PDT) Date: Mon, 12 May 1997 22:58:56 -0700 (PDT) Message-Id: <199705130558.WAA14766@freefall.freebsd.org> To: CVS-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-games@FreeBSD.ORG Subject: cvs commit: src/games/adventure Makefile Sender: owner-cvs-games@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk asami 97/05/12 22:58:56 Branch: games/adventure RELENG_2_2 Modified: games/adventure Makefile Log: Merge 1.2 and 1.3. Revision Changes Path 1.1.1.1.8.1 +2 -2 src/games/adventure/Makefile From owner-cvs-games Mon May 12 23:43:18 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id XAA04403 for cvs-games-outgoing; Mon, 12 May 1997 23:43:18 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id XAA04386; Mon, 12 May 1997 23:43:05 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id QAA14766; Tue, 13 May 1997 16:21:59 +1000 Date: Tue, 13 May 1997 16:21:59 +1000 From: Bruce Evans Message-Id: <199705130621.QAA14766@godzilla.zeta.org.au> To: asami@FreeBSD.ORG, cvs-all@FreeBSD.ORG, CVS-committers@FreeBSD.ORG, cvs-games@FreeBSD.ORG Subject: Re: cvs commit: src/games/adventure Makefile Sender: owner-cvs-games@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > Modified: games/adventure Makefile > Log: > Add ${CFLAGS} and ${LDFLAGS} to the setup command line. Please improve low quality makefiles instead of adding more cruft to them. Removing the explicit rule gives better results (the implicit null suffix rule ".c" gets used). The dependencies for `setup' are still broken. Tools like `setup' are most easily handled by putting them in a separate directory, although this causes different problems with dependencies. There should be more general support for tools. See bin/sh for a more interesting example. The dependencies for sh are complicated enough as it is (it's hard to make them correct enough for -j3 to work) and putting the tools in separate directories wouldn't help (see tn3270 for how badly this works). Bruce From owner-cvs-games Tue May 13 00:23:11 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id AAA06133 for cvs-games-outgoing; Tue, 13 May 1997 00:23:11 -0700 (PDT) Received: from silvia.HIP.Berkeley.EDU (ala-ca8-15.ix.netcom.com [207.93.141.143]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id AAA06105; Tue, 13 May 1997 00:22:48 -0700 (PDT) Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.8.5/8.6.9) id AAA19515; Tue, 13 May 1997 00:20:54 -0700 (PDT) Date: Tue, 13 May 1997 00:20:54 -0700 (PDT) Message-Id: <199705130720.AAA19515@silvia.HIP.Berkeley.EDU> To: bde@zeta.org.au CC: cvs-all@FreeBSD.ORG, CVS-committers@FreeBSD.ORG, cvs-games@FreeBSD.ORG In-reply-to: <199705130621.QAA14766@godzilla.zeta.org.au> (message from Bruce Evans on Tue, 13 May 1997 16:21:59 +1000) Subject: Re: cvs commit: src/games/adventure Makefile From: asami@vader.cs.berkeley.edu (Satoshi Asami) Sender: owner-cvs-games@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk * Please improve low quality makefiles instead of adding more cruft to them. * Removing the explicit rule gives better results (the implicit null suffix * rule ".c" gets used). Well, if you say so. But note that I saw this before my commit: === revision 1.2 date: 1996/12/13 14:19:00; author: bde; state: Exp; lines: +1 -1 Made `setup' depend on libraries. === I assume I can delete this change too? :) Satoshi From owner-cvs-games Tue May 13 00:27:43 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id AAA06400 for cvs-games-outgoing; Tue, 13 May 1997 00:27:43 -0700 (PDT) Received: from freefall.freebsd.org (freefall.cdrom.com [204.216.27.21]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id AAA06343; Tue, 13 May 1997 00:27:11 -0700 (PDT) From: Satoshi Asami Received: (from asami@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id AAA15224; Tue, 13 May 1997 00:26:19 -0700 (PDT) Date: Tue, 13 May 1997 00:26:19 -0700 (PDT) Message-Id: <199705130726.AAA15224@freefall.freebsd.org> To: CVS-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-games@FreeBSD.ORG Subject: cvs commit: src/games/adventure Makefile Sender: owner-cvs-games@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk asami 97/05/13 00:26:19 Modified: games/adventure Makefile Log: Remove explicit rule for setup. This effectively deletes revisions 1.2 and 1.3 as well. Revision Changes Path 1.4 +0 -3 src/games/adventure/Makefile From owner-cvs-games Tue May 13 00:29:11 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id AAA06494 for cvs-games-outgoing; Tue, 13 May 1997 00:29:11 -0700 (PDT) Received: from freefall.freebsd.org (freefall.cdrom.com [204.216.27.21]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id AAA06460; Tue, 13 May 1997 00:28:53 -0700 (PDT) From: Satoshi Asami Received: (from asami@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id AAA15267; Tue, 13 May 1997 00:28:02 -0700 (PDT) Date: Tue, 13 May 1997 00:28:02 -0700 (PDT) Message-Id: <199705130728.AAA15267@freefall.freebsd.org> To: CVS-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-games@FreeBSD.ORG Subject: cvs commit: src/games/adventure Makefile Sender: owner-cvs-games@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk asami 97/05/13 00:28:02 Branch: games/adventure RELENG_2_2 Modified: games/adventure Makefile Log: Merge 1.4. Revision Changes Path 1.1.1.1.8.2 +0 -3 src/games/adventure/Makefile From owner-cvs-games Tue May 13 00:31:03 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id AAA06617 for cvs-games-outgoing; Tue, 13 May 1997 00:31:03 -0700 (PDT) Received: from silvia.HIP.Berkeley.EDU (ala-ca8-15.ix.netcom.com [207.93.141.143]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id AAA06576; Tue, 13 May 1997 00:30:42 -0700 (PDT) Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.8.5/8.6.9) id AAA02635; Tue, 13 May 1997 00:30:33 -0700 (PDT) Date: Tue, 13 May 1997 00:30:33 -0700 (PDT) Message-Id: <199705130730.AAA02635@silvia.HIP.Berkeley.EDU> To: CVS-committers@freebsd.org, cvs-all@freebsd.org, cvs-games@freebsd.org In-reply-to: <199705130726.AAA15224@freefall.freebsd.org> (message from Satoshi Asami on Tue, 13 May 1997 00:26:19 -0700 (PDT)) Subject: Re: cvs commit: src/games/adventure Makefile From: asami@vader.cs.berkeley.edu (Satoshi Asami) Sender: owner-cvs-games@freebsd.org X-Loop: FreeBSD.org Precedence: bulk * Log: * Remove explicit rule for setup. This effectively deletes revisions 1.2 * and 1.3 as well. Forgot to add "Suggested by: bde". Satoshi