From owner-cvs-usrsbin Wed Jan 1 01:30:15 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id BAA20974 for cvs-usrsbin-outgoing; Wed, 1 Jan 1997 01:30:15 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id BAA20967; Wed, 1 Jan 1997 01:30:14 -0800 (PST) Date: Wed, 1 Jan 1997 01:30:14 -0800 (PST) From: Peter Wemm Message-Id: <199701010930.BAA20967@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/named Makefile Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/01/01 01:30:14 Modified: usr.sbin/named Makefile Log: Remove dmalloc here too. Revision Changes Path 1.15 +3 -3 src/usr.sbin/named/Makefile From owner-cvs-usrsbin Wed Jan 1 01:31:57 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id BAA21054 for cvs-usrsbin-outgoing; Wed, 1 Jan 1997 01:31:57 -0800 (PST) Received: from spinner.DIALix.COM (root@spinner.DIALix.COM [192.203.228.67]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id BAA21030; Wed, 1 Jan 1997 01:31:41 -0800 (PST) Received: from spinner.DIALix.COM (peter@localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.8.4/8.8.4) with ESMTP id RAA02807; Wed, 1 Jan 1997 17:31:30 +0800 (WST) Message-Id: <199701010931.RAA02807@spinner.DIALix.COM> X-Mailer: exmh version 2.0beta 12/23/96 To: "Jordan K. Hubbard" cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/named Makefile In-reply-to: Your message of "Tue, 31 Dec 1996 21:17:24 PST." <199701010517.VAA13947@freefall.freebsd.org> Date: Wed, 01 Jan 1997 17:31:30 +0800 From: Peter Wemm Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk "Jordan K. Hubbard" wrote: > jkh 96/12/31 21:17:24 > > Modified: usr.sbin/named Makefile > Log: > Include ns_udp.c here too. oops! I forgot to commit this. I was still marvelling at how cleanly the import went and kinda forgot to fix the glue.. :-/ Sorry... Cheers, -Peter From owner-cvs-usrsbin Wed Jan 1 01:47:07 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id BAA21667 for cvs-usrsbin-outgoing; Wed, 1 Jan 1997 01:47:07 -0800 (PST) Received: from spinner.DIALix.COM (root@spinner.DIALix.COM [192.203.228.67]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id BAA21653; Wed, 1 Jan 1997 01:46:22 -0800 (PST) Received: from spinner.DIALix.COM (peter@localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.8.4/8.8.4) with ESMTP id RAA02913; Wed, 1 Jan 1997 17:46:05 +0800 (WST) Message-Id: <199701010946.RAA02913@spinner.DIALix.COM> X-Mailer: exmh version 2.0beta 12/23/96 To: Peter Wemm cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/named Makefile In-reply-to: Your message of "Wed, 01 Jan 1997 01:30:14 PST." <199701010930.BAA20967@freefall.freebsd.org> Date: Wed, 01 Jan 1997 17:46:05 +0800 From: Peter Wemm Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Peter Wemm wrote: > peter 97/01/01 01:30:14 > > Modified: usr.sbin/named Makefile > Log: > Remove dmalloc here too. BTW, if you get compile failures here, remember your .depend file may be out of date and still be referencing the old files. Do a 'make cleandepend' here if you're using 'make -DNOCLEAN world' or whatever. Cheers, -Peter From owner-cvs-usrsbin Thu Jan 2 09:48:24 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id JAA18609 for cvs-usrsbin-outgoing; Thu, 2 Jan 1997 09:48:24 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id JAA18593; Thu, 2 Jan 1997 09:48:19 -0800 (PST) Date: Thu, 2 Jan 1997 09:48:19 -0800 (PST) From: Mike Pritchard Message-Id: <199701021748.JAA18593@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib, cvs-usrbin, cvs-sbin, cvs-usrsbin Subject: cvs commit: src/sbin/dumplfs dumplfs.8 src/usr.sbin/kernbb kernbb.8 src/lib/libc/net inet.3 ns.3 src/lib/libc/sys mincore.2 readlink.2 vfork.2 src/lib/libm/common_source atan2.3 src/usr.bin/login login.1 src/sbin/mount_std mount_std.8 src/usr.sbin/quot quot.8 src/usr.bin/w w.1 src/lib/libc/stdlib calloc.3 memory.3 src/sbin/nologin nologin.5 src/usr.sbin/pcvt/keycap/man5 keycap.5 Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk mpp 97/01/02 09:48:18 Branch: sbin/dumplfs RELENG_2_2 usr.sbin/kernbb RELENG_2_2 lib/libc/net RELENG_2_2 lib/libc/stdlib RELENG_2_2 lib/libc/sys RELENG_2_2 lib/libm/common_source RELENG_2_2 usr.bin/login RELENG_2_2 sbin/mount_std RELENG_2_2 sbin/nologin RELENG_2_2 usr.sbin/pcvt/keycap/man5 RELENG_2_2 usr.sbin/quot RELENG_2_2 usr.bin/w RELENG_2_2 Modified: sbin/dumplfs dumplfs.8 usr.sbin/kernbb kernbb.8 lib/libc/net inet.3 ns.3 lib/libc/stdlib calloc.3 memory.3 lib/libc/sys mincore.2 readlink.2 vfork.2 lib/libm/common_source atan2.3 usr.bin/login login.1 sbin/mount_std mount_std.8 sbin/nologin nologin.5 usr.sbin/pcvt/keycap/man5 keycap.5 usr.sbin/quot quot.8 usr.bin/w w.1 Log: YAMFC: various minor man page cleanups Revision Changes Path 1.1.1.1.8.1 +3 -2 src/sbin/dumplfs/dumplfs.8 1.1.6.1 +2 -1 src/usr.sbin/kernbb/kernbb.8 1.2.2.1 +2 -2 src/lib/libc/net/inet.3 1.1.1.1.8.1 +2 -1 src/lib/libc/net/ns.3 1.1.1.1.8.1 +3 -2 src/lib/libc/stdlib/calloc.3 1.1.1.1.8.1 +3 -2 src/lib/libc/stdlib/memory.3 1.4.2.1 +4 -3 src/lib/libc/sys/mincore.2 1.2.2.1 +4 -3 src/lib/libc/sys/readlink.2 1.4.2.1 +3 -2 src/lib/libc/sys/vfork.2 1.1.1.1.8.1 +3 -2 src/lib/libm/common_source/atan2.3 1.4.2.1 +3 -2 src/usr.bin/login/login.1 1.3.2.2 +6 -6 src/sbin/mount_std/mount_std.8 1.2.2.1 +9 -7 src/sbin/nologin/nologin.5 1.2.2.1 +2 -5 src/usr.sbin/pcvt/keycap/man5/keycap.5 1.3.4.1 +2 -2 src/usr.sbin/quot/quot.8 1.2.8.1 +2 -1 src/usr.bin/w/w.1 From owner-cvs-usrsbin Thu Jan 2 20:42:22 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id UAA28320 for cvs-usrsbin-outgoing; Thu, 2 Jan 1997 20:42:22 -0800 (PST) Received: (from davidn@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id UAA28313; Thu, 2 Jan 1997 20:42:20 -0800 (PST) Date: Thu, 2 Jan 1997 20:42:20 -0800 (PST) From: David Nugent Message-Id: <199701030442.UAA28313@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/pw pw_user.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk davidn 97/01/02 20:42:19 Modified: usr.sbin/pw pw_user.c Log: Implemented /home -> /usr/home symlink kludge. If home basedir would be created in the root partition, create it under /usr instead, and symlink /basedir -> /usr/basedir. Revision Changes Path 1.11 +28 -11 src/usr.sbin/pw/pw_user.c From owner-cvs-usrsbin Thu Jan 2 22:33:20 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id WAA02573 for cvs-usrsbin-outgoing; Thu, 2 Jan 1997 22:33:20 -0800 (PST) Received: (from davidn@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id WAA02566; Thu, 2 Jan 1997 22:33:18 -0800 (PST) Date: Thu, 2 Jan 1997 22:33:18 -0800 (PST) From: David Nugent Message-Id: <199701030633.WAA02566@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/pw pw_user.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk davidn 97/01/02 22:33:17 Branch: usr.sbin/pw RELENG_2_2 Modified: usr.sbin/pw pw_user.c Log: Brings /usr symlink kludge into 2.2 branch. Revision Changes Path 1.1.1.1.2.6 +28 -11 src/usr.sbin/pw/pw_user.c From owner-cvs-usrsbin Thu Jan 2 23:13:27 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id XAA04276 for cvs-usrsbin-outgoing; Thu, 2 Jan 1997 23:13:27 -0800 (PST) Received: (from jkh@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id XAA04264; Thu, 2 Jan 1997 23:13:24 -0800 (PST) Date: Thu, 2 Jan 1997 23:13:24 -0800 (PST) From: "Jordan K. Hubbard" Message-Id: <199701030713.XAA04264@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/syslogd syslogd.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 97/01/02 23:13:23 Modified: usr.sbin/syslogd syslogd.c Log: Unlink LogName before attempting to open it. Since we now have a lovely bug in syslogd which causes it to die after random amounts of time (widely reported), this at least allows the administrator to easily restart it without wondering why it simply exits again each time. Revision Changes Path 1.17 +2 -1 src/usr.sbin/syslogd/syslogd.c From owner-cvs-usrsbin Thu Jan 2 23:24:19 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id XAA04859 for cvs-usrsbin-outgoing; Thu, 2 Jan 1997 23:24:19 -0800 (PST) Received: (from jkh@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id XAA04852; Thu, 2 Jan 1997 23:24:18 -0800 (PST) Date: Thu, 2 Jan 1997 23:24:18 -0800 (PST) From: "Jordan K. Hubbard" Message-Id: <199701030724.XAA04852@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/syslogd syslogd.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 97/01/02 23:24:17 Branch: usr.sbin/syslogd RELENG_2_2 Modified: usr.sbin/syslogd syslogd.c Log: Merge r1.17 from current Revision Changes Path 1.12.2.3 +2 -1 src/usr.sbin/syslogd/syslogd.c From owner-cvs-usrsbin Fri Jan 3 02:52:59 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id CAA12848 for cvs-usrsbin-outgoing; Fri, 3 Jan 1997 02:52:59 -0800 (PST) Received: from irz301.inf.tu-dresden.de (irz301.inf.tu-dresden.de [141.76.1.11]) by freefall.freebsd.org (8.8.4/8.8.4) with SMTP id CAA12677; Fri, 3 Jan 1997 02:51:32 -0800 (PST) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by irz301.inf.tu-dresden.de (8.6.12/8.6.12-s1) with ESMTP id LAA27016; Fri, 3 Jan 1997 11:51:24 +0100 Received: (from uucp@localhost) by sax.sax.de (8.6.12/8.6.12-s1) with UUCP id LAA04569; Fri, 3 Jan 1997 11:51:23 +0100 Received: (from j@localhost) by uriah.heep.sax.de (8.8.4/8.6.9) id LAA14219; Fri, 3 Jan 1997 11:49:03 +0100 (MET) Message-ID: Date: Fri, 3 Jan 1997 11:49:03 +0100 From: j@uriah.heep.sax.de (J Wunsch) To: jkh@freefall.freebsd.org (Jordan K. Hubbard) Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c References: <199701030713.XAA04264@freefall.freebsd.org> X-Mailer: Mutt 0.55-PL10 Mime-Version: 1.0 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: <199701030713.XAA04264@freefall.freebsd.org>; from Jordan K. Hubbard on Jan 2, 1997 23:13:24 -0800 Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk As Jordan K. Hubbard wrote: > jkh 97/01/02 23:13:23 > > Modified: usr.sbin/syslogd syslogd.c > Log: > Unlink LogName before attempting to open it. Since we now have a lovely > bug in syslogd which causes it to die after random amounts of time (widely > reported), this at least allows the administrator to easily restart it > without wondering why it simply exits again each time. This change is wrong. We've been there before, and deliberately decided to keep the unlike out, and leave this to /etc/rc, or to the admin to do it. Right now, you've broken logging from savecore(8) which writes to the syslog socket before syslogd is running. sysylogd used to be able to extract its messages from the socket buffer previously (maybe months ago). Don't work around bugs by introducing new bugs. If syslogd dies, it must be investigated. Mine didn't yet, but i've noticed: Jan 1 16:34:09 uriah syslogd: /dev/: Is a directory Jan 1 16:34:09 uriah last message repeated 3 times ...without knowing what went wrong. Too bad that you've also instantly merged this to 2.2. Changes of this kind should at least be discussed and run in -current for a week or two before. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-) From owner-cvs-usrsbin Fri Jan 3 06:19:41 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id GAA23233 for cvs-usrsbin-outgoing; Fri, 3 Jan 1997 06:19:41 -0800 (PST) Received: from sovcom.kiae.su (sovcom.kiae.su [193.125.152.1]) by freefall.freebsd.org (8.8.4/8.8.4) with SMTP id GAA23228; Fri, 3 Jan 1997 06:19:34 -0800 (PST) Received: by sovcom.kiae.su id AA05787 (5.65.kiae-1 ); Fri, 3 Jan 1997 16:46:11 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Fri, 3 Jan 97 16:46:10 +0300 Received: from localhost (nagual.ru [127.0.0.1]) by nagual.ru (8.8.4/8.8.4) with SMTP id QAA00404; Fri, 3 Jan 1997 16:42:54 +0300 (MSK) Date: Fri, 3 Jan 1997 16:42:53 +0300 (MSK) From: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7_=2F_Andrey_Chern?= =?KOI8-R?Q?ov?= To: "Jordan K. Hubbard" Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c In-Reply-To: <199701030713.XAA04264@freefall.freebsd.org> Message-Id: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Thu, 2 Jan 1997, Jordan K. Hubbard wrote: > jkh 97/01/02 23:13:23 > > Modified: usr.sbin/syslogd syslogd.c > Log: > Unlink LogName before attempting to open it. Since we now have a lovely > bug in syslogd which causes it to die after random amounts of time (widely > reported), this at least allows the administrator to easily restart it > without wondering why it simply exits again each time. You broke logging of messages which goes before socket open this way, please back it out. BTW, we definitely no need in such hackery, no fix is even better that masking real bug because it allows to find right solution in future and masking not allows to solve it at all. -- Andrey A. Chernov http://www.nagual.ru/~ache/ From owner-cvs-usrsbin Fri Jan 3 06:59:05 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id GAA25280 for cvs-usrsbin-outgoing; Fri, 3 Jan 1997 06:59:05 -0800 (PST) Received: from pillar.elsevier.co.uk (root@pillar.elsevier.co.uk [193.131.222.35]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id GAA25217; Fri, 3 Jan 1997 06:57:22 -0800 (PST) Received: from snowdon.elsevier.co.uk (snowdon.elsevier.co.uk [193.131.197.164]) by pillar.elsevier.co.uk (8.8.3/8.8.3) with ESMTP id OAA23747; Fri, 3 Jan 1997 14:56:20 GMT Received: from cadair.elsevier.co.uk by snowdon.elsevier.co.uk with SMTP (PP); Fri, 3 Jan 1997 14:56:42 +0000 Received: from tees.elsevier.co.uk (tees.elsevier.co.uk [193.131.197.60]) by cadair.elsevier.co.uk (8.8.3/8.8.3) with ESMTP id OAA13430; Fri, 3 Jan 1997 14:56:36 GMT Received: (from dpr@localhost) by tees.elsevier.co.uk (8.8.3/8.8.3) id OAA01904; Fri, 3 Jan 1997 14:55:10 GMT To: "Jordan K. Hubbard" Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c References: <199701030713.XAA04264@freefall.freebsd.org> From: Paul Richards Date: 03 Jan 1997 14:55:09 +0000 In-Reply-To: "Jordan K. Hubbard"'s message of Thu, 2 Jan 1997 23:13:24 -0800 (PST) Message-ID: <57iv5est9u.fsf@tees.elsevier.co.uk> Lines: 37 X-Mailer: Gnus v5.3/Emacs 19.30 Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk "Jordan K. Hubbard" writes: > Modified: usr.sbin/syslogd syslogd.c > Log: > Unlink LogName before attempting to open it. Since we now have a lovely > bug in syslogd which causes it to die after random amounts of time (widely > reported), this at least allows the administrator to easily restart it > without wondering why it simply exits again each time. Ahhhhhhhh!! This is the very line that I removed in rev 1.6 !! LogName can be set from the command line, doing an unconditional link can be *VERY* dangerous if you happen to mis-type it. If syslogd fails to create the socket for some reason it's much better for the admin to see that than too let syslogd think it knows what it's doing and simply unlink LogName. Why is syslogd simply exiting and why would the unlink() fix this? It should print an error message if it fails to open the socket so the administrator should now why it's not restarting up. Another point is that the conditional unlink() in the die() function should clean up the socket under most terminal circumstances, if syslogd is exiting without doing so then it'd be nice to work out how since that's where the real bug is. These signals should all unlink LogName when syslogd dies. (void)signal(SIGTERM, die); (void)signal(SIGINT, Debug ? die : SIG_IGN); (void)signal(SIGQUIT, Debug ? die : SIG_IGN); -- Paul Richards. Originative Solutions Ltd. (Netcraft Ltd. contractor) Elsevier Science TIS online journal project. Email: p.richards@elsevier.co.uk Phone: 0370 462071 (Mobile), +44 (0)1865 843155 From owner-cvs-usrsbin Fri Jan 3 07:48:22 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id HAA28081 for cvs-usrsbin-outgoing; Fri, 3 Jan 1997 07:48:22 -0800 (PST) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id HAA28074; Fri, 3 Jan 1997 07:48:18 -0800 (PST) Received: from time.cdrom.com (localhost [127.0.0.1]) by time.cdrom.com (8.8.4/8.6.9) with ESMTP id HAA23464; Fri, 3 Jan 1997 07:48:00 -0800 (PST) To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) cc: jkh@freefall.freebsd.org (Jordan K. Hubbard), CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c In-reply-to: Your message of "Fri, 03 Jan 1997 11:49:03 +0100." Date: Fri, 03 Jan 1997 07:48:00 -0800 Message-ID: <23460.852306480@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk I'll simply back this out of -current and 2.2 in the next few hours. No harm done, sorry - I wasn't aware of the savecore dependencies (how gross! :). If the syslogd death problem were easy to catch, we'd probably have it fixed by now tho.. :( > As Jordan K. Hubbard wrote: > > > jkh 97/01/02 23:13:23 > > > > Modified: usr.sbin/syslogd syslogd.c > > Log: > > Unlink LogName before attempting to open it. Since we now have a lovely > > bug in syslogd which causes it to die after random amounts of time (widel y > > reported), this at least allows the administrator to easily restart it > > without wondering why it simply exits again each time. > > This change is wrong. We've been there before, and deliberately > decided to keep the unlike out, and leave this to /etc/rc, or to the > admin to do it. Right now, you've broken logging from savecore(8) > which writes to the syslog socket before syslogd is running. sysylogd > used to be able to extract its messages from the socket buffer > previously (maybe months ago). > > Don't work around bugs by introducing new bugs. If syslogd dies, it > must be investigated. Mine didn't yet, but i've noticed: > > Jan 1 16:34:09 uriah syslogd: /dev/: Is a directory > Jan 1 16:34:09 uriah last message repeated 3 times > > ...without knowing what went wrong. > > Too bad that you've also instantly merged this to 2.2. Changes of > this kind should at least be discussed and run in -current for a week > or two before. > > -- > cheers, J"org > > joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE > Never trust an operating system you don't have sources for. ;-) From owner-cvs-usrsbin Fri Jan 3 08:04:34 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id IAA29108 for cvs-usrsbin-outgoing; Fri, 3 Jan 1997 08:04:34 -0800 (PST) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id IAA29100; Fri, 3 Jan 1997 08:04:26 -0800 (PST) Received: from time.cdrom.com (localhost [127.0.0.1]) by time.cdrom.com (8.8.4/8.6.9) with ESMTP id IAA23565; Fri, 3 Jan 1997 08:03:34 -0800 (PST) To: Paul Richards cc: "Jordan K. Hubbard" , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c In-reply-to: Your message of "03 Jan 1997 14:55:09 GMT." <57iv5est9u.fsf@tees.elsevier.co.uk> Date: Fri, 03 Jan 1997 08:03:34 -0800 Message-ID: <23562.852307414@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > These signals should all unlink LogName when syslogd dies. And it's undoubtedly some other signal, like SIGSEGV :) Jordan From owner-cvs-usrsbin Fri Jan 3 08:10:57 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id IAA29446 for cvs-usrsbin-outgoing; Fri, 3 Jan 1997 08:10:57 -0800 (PST) Received: from spinner.DIALix.COM (root@spinner.DIALix.COM [192.203.228.67]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id IAA29437; Fri, 3 Jan 1997 08:10:47 -0800 (PST) Received: from spinner.DIALix.COM (peter@localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.8.4/8.8.4) with ESMTP id AAA25840; Sat, 4 Jan 1997 00:10:17 +0800 (WST) Message-Id: <199701031610.AAA25840@spinner.DIALix.COM> X-Mailer: exmh version 2.0beta 12/23/96 To: "Jordan K. Hubbard" cc: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch), jkh@freefall.freebsd.org (Jordan K. Hubbard), CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c In-reply-to: Your message of "Fri, 03 Jan 1997 07:48:00 PST." <23460.852306480@time.cdrom.com> Date: Sat, 04 Jan 1997 00:10:17 +0800 From: Peter Wemm Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk "Jordan K. Hubbard" wrote: > I'll simply back this out of -current and 2.2 in the next few hours. > No harm done, sorry - I wasn't aware of the savecore dependencies > (how gross! :). I've sent mail on this off list, but for what it's worth, in /etc/rc we have: rm -f /var/run/log echo ' syslogd.'; syslogd Apart from the possibility of bugs in the unlink() code (Bruce has commented on it), the change Jordan made should be about the same as moving the rm -f into syslogd itself. It shouldn't make any difference.. (But then again, I've had a rough few weeks, I am probably missing something obvious again) I'm also not sure why it was possible for savecore to do a send() to the /dev/log unix domain socket before anything had bound to it and started listening for datagrams on it. Is this a special feature of AF_UNIX sockets? > If the syslogd death problem were easy to catch, we'd probably have > it fixed by now tho.. :( Does anybody have more details on this? I'd like to find out what's going on since I've got a lot of syslogd's blood on my hands over the last few months. Do the people that are seeing this problem have user broadcasts in their /etc/syslog.conf file? eg: *.err root *.notice;news.err root *.alert root Do the problems seem to happen around the time of a message coming through here? [..] > > > Unlink LogName before attempting to open it. Since we now have a lovel y > > > bug in syslogd which causes it to die after random amounts of time (wid el > y > > > reported), this at least allows the administrator to easily restart it > > > without wondering why it simply exits again each time. Cheers, -Peter From owner-cvs-usrsbin Fri Jan 3 08:20:58 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id IAA00110 for cvs-usrsbin-outgoing; Fri, 3 Jan 1997 08:20:58 -0800 (PST) Received: from spinner.DIALix.COM (root@spinner.DIALix.COM [192.203.228.67]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id IAA00102; Fri, 3 Jan 1997 08:20:46 -0800 (PST) Received: from spinner.DIALix.COM (peter@localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.8.4/8.8.4) with ESMTP id AAA25916; Sat, 4 Jan 1997 00:19:21 +0800 (WST) Message-Id: <199701031619.AAA25916@spinner.DIALix.COM> X-Mailer: exmh version 2.0beta 12/23/96 To: "Jordan K. Hubbard" cc: Paul Richards , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c In-reply-to: Your message of "Fri, 03 Jan 1997 08:03:34 PST." <23562.852307414@time.cdrom.com> Date: Sat, 04 Jan 1997 00:19:21 +0800 From: Peter Wemm Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk "Jordan K. Hubbard" wrote: > > These signals should all unlink LogName when syslogd dies. > > And it's undoubtedly some other signal, like SIGSEGV :) Hmm. Our console logger seems to not print messages on the console while /dev/klog is open, is that right? (This probably would prevent the "syslogd died signal 11 message on the console since it would be sent to syslogd's open file handle that had not yet closed on exit). I wonder if we should put in a defensive catcher for the common fatal signals (SEGV,BUS) that does a bare bones log and exit? > Jordan Cheers, -Peter From owner-cvs-usrsbin Fri Jan 3 09:06:47 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id JAA02674 for cvs-usrsbin-outgoing; Fri, 3 Jan 1997 09:06:47 -0800 (PST) Received: from pillar.elsevier.co.uk (root@pillar.elsevier.co.uk [193.131.222.35]) by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id JAA02536; Fri, 3 Jan 1997 09:03:46 -0800 (PST) Received: from snowdon.elsevier.co.uk (snowdon.elsevier.co.uk [193.131.197.164]) by pillar.elsevier.co.uk (8.8.3/8.8.3) with ESMTP id RAA26857; Fri, 3 Jan 1997 17:02:44 GMT Received: from cadair.elsevier.co.uk by snowdon.elsevier.co.uk with SMTP (PP); Fri, 3 Jan 1997 17:03:28 +0000 Received: from tees.elsevier.co.uk (tees.elsevier.co.uk [193.131.197.60]) by cadair.elsevier.co.uk (8.8.3/8.8.3) with ESMTP id RAA00563; Fri, 3 Jan 1997 17:03:24 GMT Received: (from dpr@localhost) by tees.elsevier.co.uk (8.8.3/8.8.3) id RAA02026; Fri, 3 Jan 1997 17:01:57 GMT To: Peter Wemm Cc: "Jordan K. Hubbard" , joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch), jkh@freefall.freebsd.org (Jordan K. Hubbard), CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c References: <199701031610.AAA25840@spinner.DIALix.COM> From: Paul Richards Date: 03 Jan 1997 17:01:56 +0000 In-Reply-To: Peter Wemm's message of Sat, 04 Jan 1997 00:10:17 +0800 Message-ID: <57ybeapu9n.fsf@tees.elsevier.co.uk> Lines: 33 X-Mailer: Gnus v5.3/Emacs 19.30 Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Peter Wemm writes: > I've sent mail on this off list, but for what it's worth, in /etc/rc we > have: > > rm -f /var/run/log > echo ' syslogd.'; syslogd > > Apart from the possibility of bugs in the unlink() code (Bruce has > commented on it), the change Jordan made should be about the same as > moving the rm -f into syslogd itself. It shouldn't make any difference.. > (But then again, I've had a rough few weeks, I am probably missing > something obvious again) See my other mail, it is dangerous for syslogd to simply do an unlink or even an `rm -f` since LogName can be passed from the command line and could be anything. The way it was before Jordan made his changes was correct in that it was safer than the previous behaviour of doing a blind unlink and yet still cleaned things up explicitly when appropriate. > I'm also not sure why it was possible for savecore to do a send() to the > /dev/log unix domain socket before anything had bound to it and started > listening for datagrams on it. Is this a special feature of AF_UNIX > sockets? Nor me. -- Paul Richards. Originative Solutions Ltd. (Netcraft Ltd. contractor) Elsevier Science TIS online journal project. Email: p.richards@elsevier.co.uk Phone: 0370 462071 (Mobile), +44 (0)1865 843155 From owner-cvs-usrsbin Fri Jan 3 12:19:54 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id MAA12403 for cvs-usrsbin-outgoing; Fri, 3 Jan 1997 12:19:54 -0800 (PST) Received: (from wollman@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id MAA12395; Fri, 3 Jan 1997 12:19:52 -0800 (PST) Date: Fri, 3 Jan 1997 12:19:52 -0800 (PST) From: Garrett Wollman Message-Id: <199701032019.MAA12395@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/mrouted defs.h src/usr.sbin/pppd sys-bsd.c src/usr.sbin/amd/fsinfo fsinfo.h src/usr.sbin/arp arp.c src/usr.sbin/ppp arp.c os.c src/usr.sbin/rarpd rarpd.c src/usr.sbin/slstat slstat.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk wollman 97/01/03 12:19:51 Modified: usr.sbin/amd/fsinfo fsinfo.h usr.sbin/arp arp.c usr.sbin/mrouted defs.h usr.sbin/ppp arp.c os.c usr.sbin/pppd sys-bsd.c usr.sbin/rarpd rarpd.c usr.sbin/slstat slstat.c Log: Update to match changes in . Revision Changes Path 1.3 +2 -2 src/usr.sbin/amd/fsinfo/fsinfo.h 1.7 +2 -1 src/usr.sbin/arp/arp.c 1.8 +4 -1 src/usr.sbin/mrouted/defs.h 1.6 +2 -1 src/usr.sbin/ppp/arp.c 1.9 +2 -1 src/usr.sbin/ppp/os.c 1.8 +2 -1 src/usr.sbin/pppd/sys-bsd.c 1.13 +2 -14 src/usr.sbin/rarpd/rarpd.c 1.9 +2 -1 src/usr.sbin/slstat/slstat.c From owner-cvs-usrsbin Sat Jan 4 08:12:10 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id IAA29686 for cvs-usrsbin-outgoing; Sat, 4 Jan 1997 08:12:10 -0800 (PST) Received: (from mckay@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id IAA29679; Sat, 4 Jan 1997 08:12:08 -0800 (PST) Date: Sat, 4 Jan 1997 08:12:08 -0800 (PST) From: Stephen McKay Message-Id: <199701041612.IAA29679@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/rndcontrol random.4 Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk mckay 97/01/04 08:12:07 Modified: usr.sbin/rndcontrol random.4 Log: Fix a couple of typos. Safe for 2.2. Revision Changes Path 1.3 +5 -5 src/usr.sbin/rndcontrol/random.4 From owner-cvs-usrsbin Sat Jan 4 20:05:32 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id UAA11046 for cvs-usrsbin-outgoing; Sat, 4 Jan 1997 20:05:32 -0800 (PST) Received: (from davidn@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id UAA11039; Sat, 4 Jan 1997 20:05:29 -0800 (PST) Date: Sat, 4 Jan 1997 20:05:29 -0800 (PST) From: David Nugent Message-Id: <199701050405.UAA11039@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/pw pw.conf.5 Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk davidn 97/01/04 20:05:28 Modified: usr.sbin/pw pw.conf.5 Log: Fix reference /etc/acct/pw.conf -> /etc/pw.conf. Pointed-Out-By: Peter Wemm. Revision Changes Path 1.2 +38 -10 src/usr.sbin/pw/pw.conf.5 From owner-cvs-usrsbin Sat Jan 4 20:06:48 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id UAA11117 for cvs-usrsbin-outgoing; Sat, 4 Jan 1997 20:06:48 -0800 (PST) Received: (from davidn@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id UAA11109; Sat, 4 Jan 1997 20:06:46 -0800 (PST) Date: Sat, 4 Jan 1997 20:06:46 -0800 (PST) From: David Nugent Message-Id: <199701050406.UAA11109@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/pw pw.conf.5 Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk davidn 97/01/04 20:06:45 Branch: usr.sbin/pw RELENG_2_2 Modified: usr.sbin/pw pw.conf.5 Log: Merge typo fix from -current. Revision Changes Path 1.1.1.1.2.3 +2 -2 src/usr.sbin/pw/pw.conf.5 From owner-cvs-usrsbin Sat Jan 4 20:54:26 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id UAA12244 for cvs-usrsbin-outgoing; Sat, 4 Jan 1997 20:54:26 -0800 (PST) Received: (from davidn@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id UAA12237; Sat, 4 Jan 1997 20:54:25 -0800 (PST) Date: Sat, 4 Jan 1997 20:54:25 -0800 (PST) From: David Nugent Message-Id: <199701050454.UAA12237@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/pw pwupd.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk davidn 97/01/04 20:54:25 Modified: usr.sbin/pw pwupd.c Log: Remove duplicated #include. Revision Changes Path 1.3 +1 -2 src/usr.sbin/pw/pwupd.c From owner-cvs-usrsbin Sat Jan 4 20:55:34 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id UAA12316 for cvs-usrsbin-outgoing; Sat, 4 Jan 1997 20:55:34 -0800 (PST) Received: (from davidn@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id UAA12309; Sat, 4 Jan 1997 20:55:33 -0800 (PST) Date: Sat, 4 Jan 1997 20:55:33 -0800 (PST) From: David Nugent Message-Id: <199701050455.UAA12309@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/pw pwupd.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk davidn 97/01/04 20:55:33 Branch: usr.sbin/pw RELENG_2_2 Modified: usr.sbin/pw pwupd.c Log: Merge from -current (fix dup #include). Revision Changes Path 1.1.1.1.2.3 +1 -2 src/usr.sbin/pw/pwupd.c From owner-cvs-usrsbin Sat Jan 4 23:15:41 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id XAA18101 for cvs-usrsbin-outgoing; Sat, 4 Jan 1997 23:15:41 -0800 (PST) Received: (from davidn@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id XAA18090; Sat, 4 Jan 1997 23:15:39 -0800 (PST) Date: Sat, 4 Jan 1997 23:15:39 -0800 (PST) From: David Nugent Message-Id: <199701050715.XAA18090@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/pw pw_nis.c Makefile pw.8 pw.c pw.conf.5 pw.h pw_conf.c pw_user.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk davidn 97/01/04 23:15:39 Modified: usr.sbin/pw Makefile pw.8 pw.c pw.conf.5 pw.h pw_conf.c pw_user.c Added: usr.sbin/pw pw_nis.c Log: Adds optional NIS passwd file updating and optionally rebuilding NIS maps. Suggested by: Peter Wemm Revision Changes Path 1.3 +2 -2 src/usr.sbin/pw/Makefile 1.6 +29 -3 src/usr.sbin/pw/pw.8 1.2 +95 -47 src/usr.sbin/pw/pw.c 1.3 +11 -2 src/usr.sbin/pw/pw.conf.5 1.4 +6 -1 src/usr.sbin/pw/pw.h 1.3 +13 -1 src/usr.sbin/pw/pw_conf.c 1.12 +25 -3 src/usr.sbin/pw/pw_user.c