From owner-cvs-usrsbin Sun Mar 9 04:11:44 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id EAA16668 for cvs-usrsbin-outgoing; Sun, 9 Mar 1997 04:11:44 -0800 (PST) Received: from sovcom.kiae.su (sovcom.kiae.su [193.125.152.1]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id EAA16663; Sun, 9 Mar 1997 04:11:39 -0800 (PST) Received: by sovcom.kiae.su id AA08107 (5.65.kiae-1 ); Sun, 9 Mar 1997 15:05:55 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Sun, 9 Mar 97 15:05:55 +0300 Received: (from ache@localhost) by nagual.ru (8.8.5/8.8.5) id OAA00815; Sun, 9 Mar 1997 14:56:08 +0300 (MSK) Date: Sun, 9 Mar 1997 14:56:04 +0300 (MSK) From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= To: Brian Somers Cc: CVS-committers@freebsd.org, cvs-all@freebsd.org, cvs-usrsbin@freebsd.org Subject: Re: cvs commit: src/usr.sbin/ppp timer.c In-Reply-To: <199703082058.UAA24419@awfulhak.demon.co.uk> Message-Id: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-usrsbin@freebsd.org X-Loop: FreeBSD.org Precedence: bulk On Sat, 8 Mar 1997, Brian Somers wrote: > I don't understand. The idea is that if an interrupt occurs (calling > the pending function), the select() is interrupted and the pending > interrupt routine is immediately called. There should be very little > latency.... unless there's some other tight loops in the code ? I don't > know of any. It seems that some other tight loops present... > You're forgetting about SIGHUP and SIGTERM. They call LogClose(), which > ends up in a call to mballoc() in LogFlush(). Needless to say, mballoc() > calls our friend malloc(). Also, TimerService calls logprintf() which > calls vlogprintf() which calls LogFlush()...... This signals can't be bug report reason, since only normal mode bug assumed in report, not termination bug. And in norman mode only SIGALRM can happens, other signals are impossible. > > I consider having malloc() problem after two days of running is lesser bug > > than having dead hang after 5minutes of running and carrier drop. > > Ah, but you're the first to complain of the "problem". Similar code was > released in 2.2-GAMMA and nobody complained (AFAIK). We have bad phone lines in Russia, so carrier drop is common situation here. As I hear it almost never occurse in USA. > Let's not jump to conclusions. I agree with the SIGSEGV stuff (if it > has to be trapped), and fork signals aren't broken. SIG_DFL & SIG_IGN > pass right through the pending code. As I say, SIGALRM is only one signal which can happen in normal running mode. I didn't see a reason to pend other signals (excepting maybe SIGTSTP. etc which I left pending). > > Proper fixing assumed not pending SIGALRM calls (true time is valuable > > thing) but making all timer code recursion-safe. > > The original problem wasn't *just* with recursive malloc()s in the Timer > code. 2.2-ALPHA (or was it GAMMA) went out with a pending SIGALRM, and > still exhibited the problem. You mean that signal pending not fix the problem? Why bug report stays closed in this case? > IMHO, "proper fixing" entails not allowing any malloc() calls to recurse. > AFAIK, POSIX doesn't say anything about malloc() needing to be re-entrant, > therefore it's up to the program not to re-enter. As a signal may occur > during malloc(), we must make sure that no handler that calls malloc() > may be caused until it's safe (ie via handle_signals()). Yes, proper fixing is not enabling malloc in signal handlers. But pending alarm ticks is not allowed in any case. They are alarm tics just because they don't want to be delayed. I.e. alarm signal handlred must be executed immediately but don't call malloc (you can pend malloc call, not signal handler itself). > You are not sure that all of the changes from pending_signal() to signal() > are changes to calls that use handlers that don't call malloc() (as I > pointed out above), so I will not agree with the changes. If you insist > on leaving the code there, you can deal with the re-opened recursive > malloc() pr. Yes, I re-open it. But from your words it happens even with pending signals or not? > Either way, I'd like to know where the code is when ppp loops. I've heard > that this does happen from time to time, but nobody's ever identified where > the code was at the time. I'd really appreciate if you could tell me > where so that I can scatter a few more calls to handle_signals(). If you > can reproduce the problem, could you remove the signal(SIGSEGV,...) call, > -11 it when it's hung, and ask the ensuing core where it was at ? TIA. I'll try to debug and tell exact place (it is a bit hard to debug daemon with unstable effect). Right now I can only say that problem disappearse when I remove signals pending. -- Andrey A. Chernov http://www.nagual.ru/~ache/ From owner-cvs-usrsbin Sun Mar 9 04:21:48 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id EAA17881 for cvs-usrsbin-outgoing; Sun, 9 Mar 1997 04:21:48 -0800 (PST) Received: (from wosch@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id EAA17873; Sun, 9 Mar 1997 04:21:47 -0800 (PST) Date: Sun, 9 Mar 1997 04:21:47 -0800 (PST) From: Wolfram Schneider Message-Id: <199703091221.EAA17873@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/adduser adduser.perl Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk wosch 97/03/09 04:21:46 Modified: usr.sbin/adduser adduser.perl Log: Support comments in password database (/etc/master.passwd). Comments in group database (/etc/group) are currently not supported - adduser silently delete blank lines and comments. Revision Changes Path 1.28 +9 -1 src/usr.sbin/adduser/adduser.perl From owner-cvs-usrsbin Sun Mar 9 12:04:01 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id MAA08014 for cvs-usrsbin-outgoing; Sun, 9 Mar 1997 12:04:01 -0800 (PST) Received: (from ache@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id MAA07995; Sun, 9 Mar 1997 12:03:57 -0800 (PST) Date: Sun, 9 Mar 1997 12:03:57 -0800 (PST) From: "Andrey A. Chernov" Message-Id: <199703092003.MAA07995@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/ppp Makefile chat.c main.c timer.c sig.c sig.h Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 97/03/09 12:03:56 Modified: usr.sbin/ppp Makefile chat.c main.c timer.c Removed: usr.sbin/ppp sig.c sig.h Log: I remove pending signals completely, they are not useless, they are dangerous! Signal handlers themself must be fixed to not call malloc, but no pended handlers, it will be correct fix. In finite case each signal handler can set some variable which will be analized later, but calling handler functions manually is too dangerous (f.e. signals not blocked while the handler or handlers switch executed in this case). Of course this code can be fixed instead of removing, but it not worth fixing in any case. Should go into 2.2 In addition sig.c code shows following dangerous fragments (there can be more, but I stop after two): This fragment if (fn == SIG_DFL || fn == SIG_IGN) { handler[sig-1] = (sig_type)0; <------------- here signal(sig,fn); } else { cause NULL pointer reference when signal comes "here", but more worse fragment is below: void handle_signals() { int sig; if (caused) for (sig=0; sig<__MAXSIG; sig++, caused>>=1) if (caused&1) (*handler[sig])(sig+1); } caused is bitmask which set corresponding bit on each signal coming. And now imagine, what happens when some signal comes (bit sets) while loop is executed (see caused>>=1 !!!) In this light carrier drop situation was (as gdb shows) 1. SIGSEGV in handle_signals because some junk called as *handler reference. 2. Since SIGSEGV was pended too (== never happens), it can cause various range of disasters. Revision Changes Path 1.15 +2 -2 src/usr.sbin/ppp/Makefile 1.20 +1 -2 src/usr.sbin/ppp/chat.c 1.36 +9 -14 src/usr.sbin/ppp/main.c 1.12 +1 -2 src/usr.sbin/ppp/timer.c From owner-cvs-usrsbin Sun Mar 9 12:09:25 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id MAA08287 for cvs-usrsbin-outgoing; Sun, 9 Mar 1997 12:09:25 -0800 (PST) Received: (from ache@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id MAA08279; Sun, 9 Mar 1997 12:09:22 -0800 (PST) Date: Sun, 9 Mar 1997 12:09:22 -0800 (PST) From: "Andrey A. Chernov" Message-Id: <199703092009.MAA08279@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/ppp cdefs.h chat.c timer.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 97/03/09 12:09:21 Modified: usr.sbin/ppp cdefs.h chat.c timer.c Log: cdefs cleanup Revision Changes Path 1.4 +2 -2 src/usr.sbin/ppp/cdefs.h 1.21 +1 -2 src/usr.sbin/ppp/chat.c 1.13 +1 -2 src/usr.sbin/ppp/timer.c From owner-cvs-usrsbin Sun Mar 9 22:21:05 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id WAA08026 for cvs-usrsbin-outgoing; Sun, 9 Mar 1997 22:21:05 -0800 (PST) Received: (from ache@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id WAA08019; Sun, 9 Mar 1997 22:21:04 -0800 (PST) Date: Sun, 9 Mar 1997 22:21:04 -0800 (PST) From: "Andrey A. Chernov" Message-Id: <199703100621.WAA08019@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/ppp command.c main.c modem.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 97/03/09 22:21:03 Modified: usr.sbin/ppp command.c main.c modem.c Log: Don't waste time scanning tun_in+10 descriptors, scan exactly what we need now. Don't assume that file descriptor can't be 0 (many places) Protect FD_* macros from being used with negative descriptors Shorten MS EXT show help to fit 80 cols Revision Changes Path 1.33 +2 -4 src/usr.sbin/ppp/command.c 1.37 +33 -22 src/usr.sbin/ppp/main.c 1.30 +10 -10 src/usr.sbin/ppp/modem.c From owner-cvs-usrsbin Sun Mar 9 22:55:02 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id WAA09684 for cvs-usrsbin-outgoing; Sun, 9 Mar 1997 22:55:02 -0800 (PST) Received: (from ache@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id WAA09674; Sun, 9 Mar 1997 22:55:00 -0800 (PST) Date: Sun, 9 Mar 1997 22:55:00 -0800 (PST) From: "Andrey A. Chernov" Message-Id: <199703100655.WAA09674@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/ppp modem.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 97/03/09 22:55:00 Modified: usr.sbin/ppp modem.c Log: Detect failure open condition for direct mode now Don't assume that modem descriptor must be >=3 in CloseModem, just assume it is any valid descriptor >=0 Revision Changes Path 1.31 +9 -3 src/usr.sbin/ppp/modem.c From owner-cvs-usrsbin Mon Mar 10 00:04:22 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id AAA02167 for cvs-usrsbin-outgoing; Mon, 10 Mar 1997 00:04:22 -0800 (PST) Received: (from ache@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id AAA02151; Mon, 10 Mar 1997 00:04:19 -0800 (PST) Date: Mon, 10 Mar 1997 00:04:19 -0800 (PST) From: "Andrey A. Chernov" Message-Id: <199703100804.AAA02151@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/ppp chap.c command.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 97/03/10 00:04:17 Modified: usr.sbin/ppp chap.c command.c Log: Do not re-initialize random numbers generator several times. Use ^ getpid() to produce better initial state. Revision Changes Path 1.11 +6 -2 src/usr.sbin/ppp/chap.c 1.34 +6 -2 src/usr.sbin/ppp/command.c From owner-cvs-usrsbin Mon Mar 10 12:35:49 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id MAA21640 for cvs-usrsbin-outgoing; Mon, 10 Mar 1997 12:35:49 -0800 (PST) Received: (from jkh@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id MAA21631; Mon, 10 Mar 1997 12:35:48 -0800 (PST) Date: Mon, 10 Mar 1997 12:35:48 -0800 (PST) From: "Jordan K. Hubbard" Message-Id: <199703102035.MAA21631@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/tzsetup tzsetup.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 97/03/10 12:35:47 Branch: usr.sbin/tzsetup RELENG_2_2 Modified: usr.sbin/tzsetup tzsetup.c Log: Merge rev 1.7 into 2.2. Revision Changes Path 1.2.2.3 +5 -1 src/usr.sbin/tzsetup/tzsetup.c From owner-cvs-usrsbin Mon Mar 10 12:56:39 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id MAA23104 for cvs-usrsbin-outgoing; Mon, 10 Mar 1997 12:56:39 -0800 (PST) Received: (from joerg@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id MAA23097; Mon, 10 Mar 1997 12:56:36 -0800 (PST) Date: Mon, 10 Mar 1997 12:56:36 -0800 (PST) From: Joerg Wunsch Message-Id: <199703102056.MAA23097@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/wormcontrol wormcontrol.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk joerg 97/03/10 12:56:35 Branch: usr.sbin/wormcontrol RELENG_2_2 Modified: usr.sbin/wormcontrol wormcontrol.c Log: YAMFC (rev 1.3: update to the new open() semantics) Revision Changes Path 1.1.1.1.2.1 +1 -1 src/usr.sbin/wormcontrol/wormcontrol.c From owner-cvs-usrsbin Tue Mar 11 02:52:26 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id CAA13334 for cvs-usrsbin-outgoing; Tue, 11 Mar 1997 02:52:26 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id CAA13327; Tue, 11 Mar 1997 02:52:24 -0800 (PST) Date: Tue, 11 Mar 1997 02:52:24 -0800 (PST) From: Peter Wemm Message-Id: <199703111052.CAA13327@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/sup/supfilesrv Makefile supfilesrv.c supservers.8 src/usr.sbin/sup/supscan Makefile supscan.c src/usr.sbin Makefile src/usr.sbin/sup Makefile Makefile.inc README.FreeBSD src/usr.sbin/sup/lib Makefile atoo.c c.h ci.c errmsg.c expand.c ffilecopy.c filecopy.c libc.h log.c netcryptvoid.c nxtarg.c path.c quit.c run.c salloc.c scan.c scm.c scmio.c skipto.c stree.c sup.h supmsg.c supmsg.h src/usr.sbin/sup/sup Makefile sup.1 supcdefs.h supcmain.c supcmeat.c supcmisc.c supcname.c supcparse.c supcvers.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/11 02:52:23 Modified: usr.sbin Makefile Removed: usr.sbin/sup Makefile Makefile.inc README.FreeBSD usr.sbin/sup/lib Makefile atoo.c c.h ci.c errmsg.c expand.c ffilecopy.c filecopy.c libc.h log.c netcryptvoid.c nxtarg.c path.c quit.c run.c salloc.c scan.c scm.c scmio.c skipto.c stree.c sup.h supmsg.c supmsg.h usr.sbin/sup/sup Makefile sup.1 supcdefs.h supcmain.c supcmeat.c supcmisc.c supcname.c supcparse.c supcvers.c usr.sbin/sup/supfilesrv Makefile supfilesrv.c supservers.8 usr.sbin/sup/supscan Makefile supscan.c Log: Kill sup from the main sources now that the ports version is updated. This puts it on the same footing as cvsup. It's been suggested on numerous occasions that I shouldn't have imported it in the first place, and now that sup has outlived it's usefulness..... Boom! Revision Changes Path 1.104 +2 -2 src/usr.sbin/Makefile From owner-cvs-usrsbin Tue Mar 11 04:58:54 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id EAA28816 for cvs-usrsbin-outgoing; Tue, 11 Mar 1997 04:58:54 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id EAA28807; Tue, 11 Mar 1997 04:58:51 -0800 (PST) Date: Tue, 11 Mar 1997 04:58:51 -0800 (PST) From: Peter Wemm Message-Id: <199703111258.EAA28807@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin - Imported sources Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/11 04:58:50 src/usr.sbin - Imported sources Update of /home/ncvs/src/usr.sbin In directory freefall.freebsd.org:/tmp/cvs-serv28729 Revision/Branch: 1.1.1 Log Message: Import some CSRG 4.4BSD-Lite2 components in order to fix the tree build. Status: Vendor Tag: CSRG Release Tags: bsd_44_lite_2 U src/usr.sbin/pstat/Makefile C src/usr.sbin/pstat/pstat.8 C src/usr.sbin/pstat/pstat.c U src/usr.sbin/kvm_mkdb/testdb.c U src/usr.sbin/kvm_mkdb/extern.h U src/usr.sbin/kvm_mkdb/kvm_mkdb.8 C src/usr.sbin/kvm_mkdb/kvm_mkdb.c U src/usr.sbin/kvm_mkdb/Makefile U src/usr.sbin/kvm_mkdb/nlist.c 3 conflicts created by this import. Use the following command to help the merge: cvs checkout -jCSRG:yesterday -jCSRG src/usr.sbin From owner-cvs-usrsbin Tue Mar 11 05:00:50 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id FAA29008 for cvs-usrsbin-outgoing; Tue, 11 Mar 1997 05:00:50 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id FAA28997; Tue, 11 Mar 1997 05:00:48 -0800 (PST) Date: Tue, 11 Mar 1997 05:00:48 -0800 (PST) From: Peter Wemm Message-Id: <199703111300.FAA28997@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/pstat pstat.8 pstat.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/11 05:00:47 Modified: usr.sbin/pstat pstat.8 pstat.c Log: Merge Lite2 changes Revision Changes Path 1.13 +3 -4 src/usr.sbin/pstat/pstat.8 1.26 +116 -148 src/usr.sbin/pstat/pstat.c From owner-cvs-usrsbin Tue Mar 11 05:01:45 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id FAA29100 for cvs-usrsbin-outgoing; Tue, 11 Mar 1997 05:01:45 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id FAA29093; Tue, 11 Mar 1997 05:01:43 -0800 (PST) Date: Tue, 11 Mar 1997 05:01:43 -0800 (PST) From: Peter Wemm Message-Id: <199703111301.FAA29093@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/kvm_mkdb kvm_mkdb.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/11 05:01:43 Modified: usr.sbin/kvm_mkdb kvm_mkdb.c Log: Merge from Lite2 (use special dbopen flags) Revision Changes Path 1.5 +12 -9 src/usr.sbin/kvm_mkdb/kvm_mkdb.c From owner-cvs-usrsbin Tue Mar 11 06:11:50 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA05265 for cvs-usrsbin-outgoing; Tue, 11 Mar 1997 06:11:50 -0800 (PST) Received: (from ache@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA05258; Tue, 11 Mar 1997 06:11:47 -0800 (PST) Date: Tue, 11 Mar 1997 06:11:47 -0800 (PST) From: "Andrey A. Chernov" Message-Id: <199703111411.GAA05258@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/pw pw_user.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 97/03/11 06:11:46 Modified: usr.sbin/pw pw_user.c Log: Fix srandom arg according to Lite2 Revision Changes Path 1.18 +3 -3 src/usr.sbin/pw/pw_user.c From owner-cvs-usrsbin Tue Mar 11 06:25:35 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA05929 for cvs-usrsbin-outgoing; Tue, 11 Mar 1997 06:25:35 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA05916; Tue, 11 Mar 1997 06:25:33 -0800 (PST) Date: Tue, 11 Mar 1997 06:25:33 -0800 (PST) From: Peter Wemm Message-Id: <199703111425.GAA05916@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/vidcontrol vidcontrol.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/11 06:25:32 Modified: usr.sbin/vidcontrol vidcontrol.c Log: Update to compile under Lite2 includes Revision Changes Path 1.17 +2 -1 src/usr.sbin/vidcontrol/vidcontrol.c From owner-cvs-usrsbin Tue Mar 11 06:26:55 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA05998 for cvs-usrsbin-outgoing; Tue, 11 Mar 1997 06:26:55 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA05991; Tue, 11 Mar 1997 06:26:53 -0800 (PST) Date: Tue, 11 Mar 1997 06:26:53 -0800 (PST) From: Peter Wemm Message-Id: <199703111426.GAA05991@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/vnconfig vnconfig.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/11 06:26:53 Modified: usr.sbin/vnconfig vnconfig.c Log: Update to compile under Lite2 fs include layout Revision Changes Path 1.4 +1 -0 src/usr.sbin/vnconfig/vnconfig.c From owner-cvs-usrsbin Tue Mar 11 07:51:40 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA13745 for cvs-usrsbin-outgoing; Tue, 11 Mar 1997 07:51:40 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA13735; Tue, 11 Mar 1997 07:51:38 -0800 (PST) Date: Tue, 11 Mar 1997 07:51:38 -0800 (PST) From: Peter Wemm Message-Id: <199703111551.HAA13735@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/amd/amd Makefile src/usr.sbin/amd/config misc-bsd44l.h os-bsd44.h Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/11 07:51:38 Modified: usr.sbin/amd/amd Makefile usr.sbin/amd/config os-bsd44.h Added: usr.sbin/amd/config misc-bsd44l.h Log: I feel sick. :-( There is some really, truely, shameful stuff in here to try and work around the nfsv3 headers in the post-lite2-kernel era. This program somehow manages to make just about every #include conflict with everything else. :-( Revision Changes Path 1.3 +1 -0 src/usr.sbin/amd/amd/Makefile 1.8 +47 -10 src/usr.sbin/amd/config/os-bsd44.h From owner-cvs-usrsbin Tue Mar 11 07:54:10 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA13953 for cvs-usrsbin-outgoing; Tue, 11 Mar 1997 07:54:10 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA13944; Tue, 11 Mar 1997 07:54:08 -0800 (PST) Date: Tue, 11 Mar 1997 07:54:08 -0800 (PST) From: Peter Wemm Message-Id: <199703111554.HAA13944@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/fdcontrol fdcontrol.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/11 07:54:08 Modified: usr.sbin/fdcontrol fdcontrol.c Log: Update to work under Lite2 includes Revision Changes Path 1.3 +1 -0 src/usr.sbin/fdcontrol/fdcontrol.c From owner-cvs-usrsbin Tue Mar 11 07:54:58 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA14033 for cvs-usrsbin-outgoing; Tue, 11 Mar 1997 07:54:58 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA14026; Tue, 11 Mar 1997 07:54:56 -0800 (PST) Date: Tue, 11 Mar 1997 07:54:56 -0800 (PST) From: Peter Wemm Message-Id: <199703111554.HAA14026@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/pcvt/mcon mcon.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/11 07:54:56 Modified: usr.sbin/pcvt/mcon mcon.c Log: Update to work under Lite2 includes Revision Changes Path 1.3 +1 -0 src/usr.sbin/pcvt/mcon/mcon.c From owner-cvs-usrsbin Tue Mar 11 07:55:33 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA14102 for cvs-usrsbin-outgoing; Tue, 11 Mar 1997 07:55:33 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA14095; Tue, 11 Mar 1997 07:55:31 -0800 (PST) Date: Tue, 11 Mar 1997 07:55:31 -0800 (PST) From: Peter Wemm Message-Id: <199703111555.HAA14095@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/qcamcontrol qcamcontrol.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/11 07:55:31 Modified: usr.sbin/qcamcontrol qcamcontrol.c Log: Update to work under Lite2 includes Revision Changes Path 1.4 +1 -0 src/usr.sbin/qcamcontrol/qcamcontrol.c From owner-cvs-usrsbin Tue Mar 11 07:56:13 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA14207 for cvs-usrsbin-outgoing; Tue, 11 Mar 1997 07:56:13 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA14196; Tue, 11 Mar 1997 07:56:10 -0800 (PST) Date: Tue, 11 Mar 1997 07:56:10 -0800 (PST) From: Peter Wemm Message-Id: <199703111556.HAA14196@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/rndcontrol rndcontrol.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/11 07:56:10 Modified: usr.sbin/rndcontrol rndcontrol.c Log: Update to work under Lite2 includes Revision Changes Path 1.7 +2 -1 src/usr.sbin/rndcontrol/rndcontrol.c From owner-cvs-usrsbin Tue Mar 11 07:56:50 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA14295 for cvs-usrsbin-outgoing; Tue, 11 Mar 1997 07:56:50 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA14286; Tue, 11 Mar 1997 07:56:49 -0800 (PST) Date: Tue, 11 Mar 1997 07:56:49 -0800 (PST) From: Peter Wemm Message-Id: <199703111556.HAA14286@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/rpc.ypxfrd ypxfrd_main.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/11 07:56:49 Modified: usr.sbin/rpc.ypxfrd ypxfrd_main.c Log: Update to work under Lite2 includes Revision Changes Path 1.4 +3 -2 src/usr.sbin/rpc.ypxfrd/ypxfrd_main.c From owner-cvs-usrsbin Tue Mar 11 07:57:47 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA14397 for cvs-usrsbin-outgoing; Tue, 11 Mar 1997 07:57:47 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id HAA14387; Tue, 11 Mar 1997 07:57:45 -0800 (PST) Date: Tue, 11 Mar 1997 07:57:45 -0800 (PST) From: Peter Wemm Message-Id: <199703111557.HAA14387@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/sgsc sgsc.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/11 07:57:45 Modified: usr.sbin/sgsc sgsc.c Log: Update to work under Lite2 includes Revision Changes Path 1.3 +1 -0 src/usr.sbin/sgsc/sgsc.c From owner-cvs-usrsbin Wed Mar 12 00:29:48 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id AAA25511 for cvs-usrsbin-outgoing; Wed, 12 Mar 1997 00:29:48 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id AAA25504; Wed, 12 Mar 1997 00:29:46 -0800 (PST) Date: Wed, 12 Mar 1997 00:29:46 -0800 (PST) From: Peter Wemm Message-Id: <199703120829.AAA25504@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/amd/config misc-bsd44l.h os-bsd44.h Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/12 00:29:45 Modified: usr.sbin/amd/config misc-bsd44l.h os-bsd44.h Log: Make amd actually work instead of just compiling. The new Lite2 code was not setting the version number in the nfs_args data to mount(2), so it was returning EFAULT. Perhaps the nfs_args version number was something we added at some point? Revision Changes Path 1.2 +0 -1 src/usr.sbin/amd/config/misc-bsd44l.h 1.9 +4 -2 src/usr.sbin/amd/config/os-bsd44.h From owner-cvs-usrsbin Wed Mar 12 20:21:57 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id UAA02760 for cvs-usrsbin-outgoing; Wed, 12 Mar 1997 20:21:57 -0800 (PST) Received: (from davidn@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id UAA02749; Wed, 12 Mar 1997 20:21:52 -0800 (PST) Date: Wed, 12 Mar 1997 20:21:52 -0800 (PST) From: David Nugent Message-Id: <199703130421.UAA02749@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/stallion/stlstats stlstats.8 Makefile stlstats.c src/usr.sbin/stallion/bootcode stl.4 stli.4 2681.sys.uu Makefile src/usr.sbin/stallion/stlload stlload.8 Makefile stlload.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk davidn 97/03/12 20:21:50 Modified: usr.sbin/stallion/bootcode 2681.sys.uu Makefile usr.sbin/stallion/stlload Makefile stlload.c usr.sbin/stallion/stlstats Makefile stlstats.c Added: usr.sbin/stallion/bootcode stl.4 stli.4 usr.sbin/stallion/stlload stlload.8 usr.sbin/stallion/stlstats stlstats.8 Log: Submitted by: Greg Ungerer Add manpages for stl, stli drivers. Add manpages for stlload, stlstats. Update stli bootcode. Update stlload, stlstats to revision 1.0.0 from author. Revision Changes Path 1.3 +595 -558 src/usr.sbin/stallion/bootcode/2681.sys.uu 1.6 +4 -2 src/usr.sbin/stallion/bootcode/Makefile 1.4 +2 -2 src/usr.sbin/stallion/stlload/Makefile 1.6 +2 -2 src/usr.sbin/stallion/stlload/stlload.c 1.4 +2 -2 src/usr.sbin/stallion/stlstats/Makefile 1.5 +2 -2 src/usr.sbin/stallion/stlstats/stlstats.c From owner-cvs-usrsbin Thu Mar 13 00:22:33 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id AAA13549 for cvs-usrsbin-outgoing; Thu, 13 Mar 1997 00:22:33 -0800 (PST) Received: (from davidn@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id AAA13542; Thu, 13 Mar 1997 00:22:30 -0800 (PST) Date: Thu, 13 Mar 1997 00:22:30 -0800 (PST) From: David Nugent Message-Id: <199703130822.AAA13542@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/stallion/bootcode stl.4 stli.4 src/usr.sbin/stallion/stlload stlload.8 src/usr.sbin/stallion/stlstats stlstats.8 Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk davidn 97/03/13 00:22:28 Modified: usr.sbin/stallion/bootcode stl.4 stli.4 usr.sbin/stallion/stlload stlload.8 usr.sbin/stallion/stlstats stlstats.8 Log: Fix file modes. (not MY umask, Peter - the originals were untarred like this :-)). Revision Changes Path 1.2 +0 -0 src/usr.sbin/stallion/bootcode/stl.4 1.2 +0 -0 src/usr.sbin/stallion/bootcode/stli.4 1.2 +0 -0 src/usr.sbin/stallion/stlload/stlload.8 1.2 +0 -0 src/usr.sbin/stallion/stlstats/stlstats.8 From owner-cvs-usrsbin Thu Mar 13 00:35:48 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id AAA14245 for cvs-usrsbin-outgoing; Thu, 13 Mar 1997 00:35:48 -0800 (PST) Received: (from roberto@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id AAA14237; Thu, 13 Mar 1997 00:35:47 -0800 (PST) Date: Thu, 13 Mar 1997 00:35:47 -0800 (PST) From: Ollivier Robert Message-Id: <199703130835.AAA14237@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/watch watch.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk roberto 97/03/13 00:35:46 Modified: usr.sbin/watch watch.c Log: 1. change tty handling from sgttyb to termios, 2. fix a potential buffer oflow, 3. makes watch(8) conform to sysexits(3). Not a strong 2.2 candidate even if it would be nice. Reviewed by: joerg, imp Revision Changes Path 1.12 +52 -40 src/usr.sbin/watch/watch.c From owner-cvs-usrsbin Thu Mar 13 04:45:42 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id EAA25480 for cvs-usrsbin-outgoing; Thu, 13 Mar 1997 04:45:42 -0800 (PST) Received: (from brian@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id EAA25468; Thu, 13 Mar 1997 04:45:40 -0800 (PST) Date: Thu, 13 Mar 1997 04:45:40 -0800 (PST) From: Brian Somers Message-Id: <199703131245.EAA25468@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/ppp sig.c sig.h Makefile chat.c main.c timer.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk brian 97/03/13 04:45:39 Modified: usr.sbin/ppp Makefile chat.c main.c timer.c Added: usr.sbin/ppp sig.c sig.h Log: Reviewed by: ache@freebsd.org These changes should fix the signal "problems" in ppp. The signal changes should really be put into 2.2 too ! The following patches should do it. There were some other changes made by Andrey recently that havn't been brought into 2.2, it may be worth doing them now. diff -r -c ppp/chat.c ppp.new/chat.c *** ppp/chat.c Sat Feb 22 17:59:06 1997 --- ppp.new/chat.c Thu Mar 13 12:37:50 1997 *************** *** 34,43 **** #include #include #include ! #include "sig.h" #include #include "timeout.h" #include "vars.h" #define IBSIZE 200 --- 34,44 ---- #include #include #include ! #include #include #include "timeout.h" #include "vars.h" + #include "sig.h" #define IBSIZE 200 *************** *** 402,411 **** pipe(fids); pid = fork(); if (pid == 0) { ! pending_signal(SIGINT, SIG_DFL); ! pending_signal(SIGQUIT, SIG_DFL); ! pending_signal(SIGTERM, SIG_DFL); ! pending_signal(SIGHUP, SIG_DFL); close(fids[0]); dup2(fids[1], 1); close(fids[1]); --- 403,414 ---- pipe(fids); pid = fork(); if (pid == 0) { ! TermTimerService(); ! signal(SIGINT, SIG_DFL); ! signal(SIGQUIT, SIG_DFL); ! signal(SIGTERM, SIG_DFL); ! signal(SIGHUP, SIG_DFL); ! signal(SIGALRM, SIG_DFL); close(fids[0]); dup2(fids[1], 1); close(fids[1]); diff -r -c ppp/main.c ppp.new/main.c *** ppp/main.c Sat Feb 22 17:59:08 1997 --- ppp.new/main.c Thu Mar 13 12:37:16 1997 *************** *** 28,34 **** #include #include #include ! #include "sig.h" #include #include #include --- 28,34 ---- #include #include #include ! #include #include #include #include *************** *** 49,54 **** --- 49,55 ---- #include "systems.h" #include "ip.h" #include "alias.h" + #include "sig.h" #define LAUTH_M1 "Warning: No password entry for this host in ppp.secret\n" #define LAUTH_M2 "Warning: All manipulation is allowed by anyone in the world\n" *************** *** 346,360 **** tcgetattr(0, &oldtio); /* Save original tty mode */ ! pending_signal(SIGHUP, Hangup); pending_signal(SIGTERM, CloseSession); pending_signal(SIGINT, CloseSession); pending_signal(SIGQUIT, CloseSession); #ifdef SIGSEGV ! pending_signal(SIGSEGV, Hangup); #endif #ifdef SIGPIPE ! pending_signal(SIGPIPE, Hangup); #endif #ifdef SIGALRM pending_signal(SIGALRM, SIG_IGN); --- 347,361 ---- tcgetattr(0, &oldtio); /* Save original tty mode */ ! signal(SIGHUP, Hangup); pending_signal(SIGTERM, CloseSession); pending_signal(SIGINT, CloseSession); pending_signal(SIGQUIT, CloseSession); #ifdef SIGSEGV ! signal(SIGSEGV, Hangup); #endif #ifdef SIGPIPE ! signal(SIGPIPE, Hangup); #endif #ifdef SIGALRM pending_signal(SIGALRM, SIG_IGN); diff -r -c ppp/sig.c ppp.new/sig.c *** ppp/sig.c Sat Feb 22 16:10:51 1997 --- ppp.new/sig.c Thu Mar 13 12:36:53 1997 *************** *** 32,52 **** * */ #include "sig.h" #include #include "mbuf.h" #include "log.h" ! #define __MAXSIG (32) /* Sizeof u_long: Make life convenient.... */ ! static u_long caused; /* A mask of pending signals */ ! static __sighandler_t *handler[ __MAXSIG ]; /* all start at SIG_DFL */ ! /* Record a signal in the "caused" mask */ static void signal_recorder(int sig) { ! if (sig > 0 && sig <= __MAXSIG) ! caused |= (1<<(sig-1)); } --- 32,52 ---- * */ + #include #include "sig.h" #include + #include #include "mbuf.h" #include "log.h" ! static caused[NSIG]; /* An array of pending signals */ ! static sig_type handler[NSIG]; /* all start at SIG_DFL */ ! /* Record a signal in the "caused" array */ static void signal_recorder(int sig) { ! caused[sig-1]++; } *************** *** 55,64 **** call in handle_signal() */ ! __sighandler_t *pending_signal(int sig,__sighandler_t *fn) { ! __sighandler_t *Result; ! if (sig <= 0 || sig > __MAXSIG) { /* Oops - we must be a bit out of date (too many sigs ?) */ logprintf("Eeek! %s:%s: I must be out of date!\n",__FILE__,__LINE__); return signal(sig,fn); --- 55,64 ---- call in handle_signal() */ ! sig_type pending_signal(int sig,sig_type fn) { ! sig_type Result; ! if (sig <= 0 || sig > NSIG) { /* Oops - we must be a bit out of date (too many sigs ?) */ logprintf("Eeek! %s:%s: I must be out of date!\n",__FILE__,__LINE__); return signal(sig,fn); *************** *** 66,78 **** Result = handler[sig-1]; if (fn == SIG_DFL || fn == SIG_IGN) { - handler[sig-1] = (__sighandler_t *)0; signal(sig,fn); } else { handler[sig-1] = fn; signal(sig,signal_recorder); } ! caused &= ~(1<<(sig-1)); return Result; } --- 66,78 ---- Result = handler[sig-1]; if (fn == SIG_DFL || fn == SIG_IGN) { signal(sig,fn); + handler[sig-1] = (sig_type)0; } else { handler[sig-1] = fn; signal(sig,signal_recorder); } ! caused[sig-1] = 0; return Result; } *************** *** 81,89 **** void handle_signals() { int sig; ! if (caused) ! for (sig=0; sig<__MAXSIG; sig++, caused>>=1) ! if (caused&1) (*handler[sig])(sig+1); } --- 81,95 ---- void handle_signals() { int sig; + int got; ! do { ! got = 0; ! for (sig = 0; sig < NSIG; sig++) ! if (caused[sig]) { ! caused[sig]--; ! got++; (*handler[sig])(sig+1); + } + } while(got); } diff -r -c ppp/sig.h ppp.new/sig.h *** ppp/sig.h Sun Feb 23 19:30:15 1997 --- ppp.new/sig.h Thu Mar 13 12:36:29 1997 *************** *** 32,41 **** * */ ! #include /* Call this instead of signal() */ ! extern __sighandler_t *pending_signal __P((int, __sighandler_t *)); /* Call this when you want things to *actually* happen */ extern void handle_signals __P((void)); --- 32,41 ---- * */ ! typedef void (*sig_type)(int); /* Call this instead of signal() */ ! extern sig_type pending_signal __P((int, sig_type)); /* Call this when you want things to *actually* happen */ extern void handle_signals __P((void)); diff -r -c ppp/timer.c ppp.new/timer.c *** ppp/timer.c Sat Feb 22 17:59:11 1997 --- ppp.new/timer.c Thu Mar 13 12:30:08 1997 *************** *** 25,34 **** #include #include #include "timeout.h" - #include "sig.h" #ifdef SIGALRM #include #endif void StopTimerNoBlock( struct pppTimer *); void ShowTimers(void); --- 25,34 ---- #include #include #include "timeout.h" #ifdef SIGALRM #include #endif + #include "sig.h" void StopTimerNoBlock( struct pppTimer *); void ShowTimers(void); Revision Changes Path 1.16 +2 -2 src/usr.sbin/ppp/Makefile 1.22 +4 -1 src/usr.sbin/ppp/chat.c 1.38 +17 -13 src/usr.sbin/ppp/main.c 1.14 +5 -8 src/usr.sbin/ppp/timer.c From owner-cvs-usrsbin Thu Mar 13 06:54:01 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA00817 for cvs-usrsbin-outgoing; Thu, 13 Mar 1997 06:54:01 -0800 (PST) Received: (from brian@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA00810; Thu, 13 Mar 1997 06:53:59 -0800 (PST) Date: Thu, 13 Mar 1997 06:53:59 -0800 (PST) From: Brian Somers Message-Id: <199703131453.GAA00810@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/ppp log.c log.h main.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk brian 97/03/13 06:53:58 Modified: usr.sbin/ppp log.c log.h main.c Log: Requested by: Harlan Stenn Accept SIGHUP as a "re-open logfile" signal. As ppp doesn't set it's serial line to it's controlling terminal, we can use HUP :) This is a candidate for 2.2. The log.[ch] changes won't conflict, but the main.c changes will. We just want to change the kill(...,SIGHUP) to a SIGTERM and change the signal(SIGHUP,Hangup) to a pending_signal(SIGHUP,LogReOpen). Revision Changes Path 1.8 +26 -1 src/usr.sbin/ppp/log.c 1.9 +2 -1 src/usr.sbin/ppp/log.h 1.39 +3 -3 src/usr.sbin/ppp/main.c From owner-cvs-usrsbin Thu Mar 13 10:56:21 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA14170 for cvs-usrsbin-outgoing; Thu, 13 Mar 1997 10:56:21 -0800 (PST) Received: (from bde@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id KAA14163; Thu, 13 Mar 1997 10:56:20 -0800 (PST) Date: Thu, 13 Mar 1997 10:56:20 -0800 (PST) From: Bruce Evans Message-Id: <199703131856.KAA14163@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/zic zic.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk bde 97/03/13 10:56:19 Modified: usr.sbin/zic zic.c Log: Remove old output file, if any, before creating the output file, in case the file is a stale link. Reviewed by: wollman Revision Changes Path 1.5 +11 -0 src/usr.sbin/zic/zic.c From owner-cvs-usrsbin Thu Mar 13 13:22:11 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id NAA20963 for cvs-usrsbin-outgoing; Thu, 13 Mar 1997 13:22:11 -0800 (PST) Received: (from brian@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id NAA20956; Thu, 13 Mar 1997 13:22:09 -0800 (PST) Date: Thu, 13 Mar 1997 13:22:09 -0800 (PST) From: Brian Somers Message-Id: <199703132122.NAA20956@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/ppp lcp.c main.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk brian 97/03/13 13:22:08 Modified: usr.sbin/ppp lcp.c main.c Log: Closes pr 2711 Fix -background option. Parent returns after the line is established (or not established). Definitely a candidate for 2.2 Revision Changes Path 1.13 +10 -1 src/usr.sbin/ppp/lcp.c 1.40 +25 -10 src/usr.sbin/ppp/main.c From owner-cvs-usrsbin Thu Mar 13 13:39:44 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id NAA22129 for cvs-usrsbin-outgoing; Thu, 13 Mar 1997 13:39:44 -0800 (PST) Received: (from brian@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id NAA22122; Thu, 13 Mar 1997 13:39:42 -0800 (PST) Date: Thu, 13 Mar 1997 13:39:42 -0800 (PST) From: Brian Somers Message-Id: <199703132139.NAA22122@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/ppp ppp.8 Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk brian 97/03/13 13:39:42 Modified: usr.sbin/ppp ppp.8 Log: Oops - forgot to document the new -HUP action. This should make 2.2 if the HUP stuff (earlier today) does. Revision Changes Path 1.26 +5 -2 src/usr.sbin/ppp/ppp.8 From owner-cvs-usrsbin Thu Mar 13 17:27:07 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id RAA03350 for cvs-usrsbin-outgoing; Thu, 13 Mar 1997 17:27:07 -0800 (PST) Received: (from joerg@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id RAA03343; Thu, 13 Mar 1997 17:27:05 -0800 (PST) Date: Thu, 13 Mar 1997 17:27:05 -0800 (PST) From: Joerg Wunsch Message-Id: <199703140127.RAA03343@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/syslogd syslogd.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk joerg 97/03/13 17:27:04 Modified: usr.sbin/syslogd syslogd.c Log: Save and restore the state of the variable Initialized inside die(). Otherwise, the shutdown message will print out with 15 NUL bytes in front, due to a missing timestamp. Revision Changes Path 1.21 +4 -1 src/usr.sbin/syslogd/syslogd.c From owner-cvs-usrsbin Thu Mar 13 17:35:24 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id RAA04220 for cvs-usrsbin-outgoing; Thu, 13 Mar 1997 17:35:24 -0800 (PST) Received: (from joerg@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id RAA04209; Thu, 13 Mar 1997 17:35:21 -0800 (PST) Date: Thu, 13 Mar 1997 17:35:21 -0800 (PST) From: Joerg Wunsch Message-Id: <199703140135.RAA04209@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/syslogd syslogd.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk joerg 97/03/13 17:35:20 Branch: usr.sbin/syslogd RELENG_2_2 Modified: usr.sbin/syslogd syslogd.c Log: YAMFC (rev 1.21) Revision Changes Path 1.12.2.5 +4 -1 src/usr.sbin/syslogd/syslogd.c From owner-cvs-usrsbin Thu Mar 13 18:35:49 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id SAA08160 for cvs-usrsbin-outgoing; Thu, 13 Mar 1997 18:35:49 -0800 (PST) Received: from awfulhak.demon.co.uk (awfulhak.demon.co.uk [158.152.17.1]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id SAA08097; Thu, 13 Mar 1997 18:34:47 -0800 (PST) Received: from awfulhak.demon.co.uk (localhost.lan.awfulhak.org [127.0.0.1]) by awfulhak.demon.co.uk (8.8.5/8.8.5) with ESMTP id CAA01446; Fri, 14 Mar 1997 02:25:42 GMT Message-Id: <199703140225.CAA01446@awfulhak.demon.co.uk> X-Mailer: exmh version 1.6.9 8/22/96 To: =?iso-8859-1?Q?S=F8ren?= Schmidt cc: brian@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/vidcontrol decode.h Makefile decode.c vidcontrol.1 vidcontrol.c In-reply-to: Your message of "Sat, 08 Mar 1997 16:16:12 +0100." <199703081516.QAA09032@ravenock.cybercity.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Date: Fri, 14 Mar 1997 02:25:41 +0000 From: Brian Somers Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by freefall.freebsd.org id SAB08149 Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > Other that that I guess we could use a way to switch screen other > that issueing the right esc sequence :). > > -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- > Søren Schmidt (sos@FreeBSD.org) FreeBSD Core Team > Even more code to hack -- will it ever end > .. > Oops, I just noticed that I didn't update the usage() message :( Would you like me to do the update ? -- Brian , Don't _EVER_ lose your sense of humour.... From owner-cvs-usrsbin Fri Mar 14 05:48:07 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id FAA19052 for cvs-usrsbin-outgoing; Fri, 14 Mar 1997 05:48:07 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id FAA19045; Fri, 14 Mar 1997 05:48:06 -0800 (PST) Date: Fri, 14 Mar 1997 05:48:06 -0800 (PST) From: Peter Wemm Message-Id: <199703141348.FAA19045@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/cron/cron do_command.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/14 05:48:05 Modified: usr.sbin/cron/cron do_command.c Log: For some reason, the old login class code didn't seem to be working here. I suspect it was because the child exec code's parent was doing the initial lookups, then forking, then doing other things (possibly trashing the static data in the getpw*() buffer), then attempting to dereference *pwd and *lc. Also, no error checking appeared to be done - I've allowed it to fall back to the old "become user" code on critical failure rather than risk running a user's cron jobs as root. Revision Changes Path 1.11 +24 -13 src/usr.sbin/cron/cron/do_command.c From owner-cvs-usrsbin Fri Mar 14 06:26:41 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA20788 for cvs-usrsbin-outgoing; Fri, 14 Mar 1997 06:26:41 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA20780; Fri, 14 Mar 1997 06:26:37 -0800 (PST) Date: Fri, 14 Mar 1997 06:26:37 -0800 (PST) From: Peter Wemm Message-Id: <199703141426.GAA20780@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/sendmail/src conf.h deliver.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/14 06:26:36 Modified: usr.sbin/sendmail/src conf.h deliver.c Log: Activate HASSETUSERCONTEXT to set resource limits while delivering to pipes in .forward files, but with a slight bugfix to the code. Revision Changes Path 1.15 +5 -1 src/usr.sbin/sendmail/src/conf.h 1.14 +1 -1 src/usr.sbin/sendmail/src/deliver.c From owner-cvs-usrsbin Fri Mar 14 06:45:35 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA21692 for cvs-usrsbin-outgoing; Fri, 14 Mar 1997 06:45:35 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA21685; Fri, 14 Mar 1997 06:45:33 -0800 (PST) Date: Fri, 14 Mar 1997 06:45:33 -0800 (PST) From: Peter Wemm Message-Id: <199703141445.GAA21685@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/cron/cron do_command.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/14 06:45:33 Modified: usr.sbin/cron/cron do_command.c Log: Tone down the paranoia a bit in from the previous commit. setusercontext() automatically Does The Right Thing when lc == NULL, which just happens to be what the extra code in cron was trying to do. Simplify. Revision Changes Path 1.12 +7 -11 src/usr.sbin/cron/cron/do_command.c From owner-cvs-usrsbin Fri Mar 14 06:49:17 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA21811 for cvs-usrsbin-outgoing; Fri, 14 Mar 1997 06:49:17 -0800 (PST) Received: from spinner.DIALix.COM (spinner.DIALix.COM [192.203.228.67]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id GAA21801; Fri, 14 Mar 1997 06:48:38 -0800 (PST) Received: from spinner.DIALix.COM (localhost.DIALix.oz.au [127.0.0.1]) by spinner.DIALix.COM (8.8.5/8.8.5) with ESMTP id WAA12467; Fri, 14 Mar 1997 22:48:21 +0800 (WST) Message-Id: <199703141448.WAA12467@spinner.DIALix.COM> X-Mailer: exmh version 2.0gamma 1/27/96 To: Peter Wemm cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/sendmail/src conf.h deliver.c In-reply-to: Your message of "Fri, 14 Mar 1997 06:26:37 PST." <199703141426.GAA20780@freefall.freebsd.org> Date: Fri, 14 Mar 1997 22:48:20 +0800 From: Peter Wemm Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Peter Wemm wrote: > peter 97/03/14 06:26:36 > > Modified: usr.sbin/sendmail/src conf.h deliver.c > Log: > Activate HASSETUSERCONTEXT to set resource limits while delivering > to pipes in .forward files, but with a slight bugfix to the code. Whimper.. I managed to loose the last 12 hours worth of mail again. :-( Sendmail had been started with a proc limit of 32 or 64 causing fork failures. This should fix it once and for all for those with a login.conf database active. Cheers, -Peter From owner-cvs-usrsbin Sat Mar 15 02:44:43 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id CAA15903 for cvs-usrsbin-outgoing; Sat, 15 Mar 1997 02:44:43 -0800 (PST) Received: (from joerg@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id CAA15894; Sat, 15 Mar 1997 02:44:40 -0800 (PST) Date: Sat, 15 Mar 1997 02:44:40 -0800 (PST) From: Joerg Wunsch Message-Id: <199703151044.CAA15894@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/ppp chat.c lcp.c log.c log.h main.c ppp.8 sig.c sig.h Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk joerg 97/03/15 02:44:38 Branch: usr.sbin/ppp RELENG_2_2 Modified: usr.sbin/ppp chat.c lcp.c log.c log.h main.c ppp.8 sig.c sig.h Log: 23:59's mega-merge for ppp(8). I've merged the three changes: re-open on HUP (+doc) Working -background option pending sig changes and enclosed patches to get from the current RELENG_2_2. The pending signal stuff is the most important, without it it's possible to corrupt the caused variable, resulting in a call to (*NULL)() :( (I'm not totally comfortable with the SIGHUP changes, but they are not very harmful either. -- Joerg) Submitted by: brian Revision Changes Path 1.11.2.5 +9 -6 src/usr.sbin/ppp/chat.c 1.10.2.1 +10 -1 src/usr.sbin/ppp/lcp.c 1.4.2.2 +26 -1 src/usr.sbin/ppp/log.c 1.6.2.1 +2 -1 src/usr.sbin/ppp/log.h 1.22.2.7 +31 -15 src/usr.sbin/ppp/main.c 1.19.2.3 +5 -2 src/usr.sbin/ppp/ppp.8 1.2.2.1 +21 -15 src/usr.sbin/ppp/sig.c 1.2.2.2 +3 -3 src/usr.sbin/ppp/sig.h From owner-cvs-usrsbin Sat Mar 15 02:49:04 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id CAA16191 for cvs-usrsbin-outgoing; Sat, 15 Mar 1997 02:49:04 -0800 (PST) Received: (from joerg@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id CAA16182; Sat, 15 Mar 1997 02:49:01 -0800 (PST) Date: Sat, 15 Mar 1997 02:49:01 -0800 (PST) From: Joerg Wunsch Message-Id: <199703151049.CAA16182@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/watch watch.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk joerg 97/03/15 02:49:00 Branch: usr.sbin/watch RELENG_2_2 Modified: usr.sbin/watch watch.c Log: YAMFC (rev 1.12: sgtty->termios, fix buffer overflow condition, use sysexits(3)) Revision Changes Path 1.8.2.4 +52 -40 src/usr.sbin/watch/watch.c From owner-cvs-usrsbin Sat Mar 15 13:23:43 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id NAA10773 for cvs-usrsbin-outgoing; Sat, 15 Mar 1997 13:23:43 -0800 (PST) Received: (from bde@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id NAA10763; Sat, 15 Mar 1997 13:23:41 -0800 (PST) Date: Sat, 15 Mar 1997 13:23:41 -0800 (PST) From: Bruce Evans Message-Id: <199703152123.NAA10763@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/pppstats pppstats.8 Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk bde 97/03/15 13:23:41 Branch: usr.sbin/pppstats RELENG_2_2 Modified: usr.sbin/pppstats pppstats.8 Log: Revert $FreeBSD$ to $Id$. Revision Changes Path 1.3.2.2 +1 -1 src/usr.sbin/pppstats/pppstats.8 From owner-cvs-usrsbin Sat Mar 15 23:12:23 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id XAA12710 for cvs-usrsbin-outgoing; Sat, 15 Mar 1997 23:12:23 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id XAA12702; Sat, 15 Mar 1997 23:12:22 -0800 (PST) Date: Sat, 15 Mar 1997 23:12:22 -0800 (PST) From: Mike Pritchard Message-Id: <199703160712.XAA12702@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/rpc.lockd rpc.lockd.8 src/usr.sbin/rpc.statd rpc.statd.8 Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk mpp 97/03/15 23:12:21 Modified: usr.sbin/rpc.lockd rpc.lockd.8 usr.sbin/rpc.statd rpc.statd.8 Log: Typo police. Partially obtained from: NetBSD PR# 3333 Revision Changes Path 1.5 +2 -2 src/usr.sbin/rpc.lockd/rpc.lockd.8 1.4 +4 -4 src/usr.sbin/rpc.statd/rpc.statd.8