From owner-cvs-usrsbin Sun Mar 30 04:12:29 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id EAA22001 for cvs-usrsbin-outgoing; Sun, 30 Mar 1997 04:12:29 -0800 (PST) Received: (from brian@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id EAA21994; Sun, 30 Mar 1997 04:12:26 -0800 (PST) Date: Sun, 30 Mar 1997 04:12:26 -0800 (PST) From: Brian Somers Message-Id: <199703301212.EAA21994@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib, cvs-usrbin, cvs-sbin, cvs-usrsbin Subject: cvs commit: src/sbin/slattach Makefile src/usr.bin/tip/tip Makefile src/usr.sbin/ppp Makefile src/lib/libutil uucplock.3 uucplock.c Makefile libutil.h src/sbin/startslip Makefile uucplock.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk brian 97/03/30 04:12:24 Modified: lib/libutil Makefile libutil.h sbin/slattach Makefile sbin/startslip Makefile usr.bin/tip/tip Makefile usr.sbin/ppp Makefile Added: lib/libutil uucplock.3 uucplock.c Removed: sbin/startslip uucplock.c Log: Move uucplock into libutil and create a manual page. Revision Changes Path 1.8 +4 -2 src/lib/libutil/Makefile 1.5 +3 -1 src/lib/libutil/libutil.h 1.7 +2 -4 src/sbin/slattach/Makefile 1.4 +2 -1 src/sbin/startslip/Makefile 1.7 +2 -4 src/usr.bin/tip/tip/Makefile 1.17 +2 -4 src/usr.sbin/ppp/Makefile From owner-cvs-usrsbin Sun Mar 30 13:30:06 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id NAA14004 for cvs-usrsbin-outgoing; Sun, 30 Mar 1997 13:30:06 -0800 (PST) Received: from sovcom.kiae.su (sovcom.kiae.su [193.125.152.1]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id NAA13963; Sun, 30 Mar 1997 13:29:59 -0800 (PST) Received: by sovcom.kiae.su id AA12768 (5.65.kiae-1 ); Mon, 31 Mar 1997 00:20:37 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Mon, 31 Mar 97 00:20:36 +0300 Received: (from ache@localhost) by nagual.ru (8.8.5/8.8.5) id BAA00348; Mon, 31 Mar 1997 01:18:17 +0400 (MSD) Date: Mon, 31 Mar 1997 01:18:09 +0400 (MSD) From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= To: Brian Somers Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/slattach Makefile src/usr.bin/tip/tip Makefile src/usr.sbin/ppp Makefile src/lib/libutil uucplock.3 uucplock.c Makefile libutil.h src/sbin/startslip Makefile uucplock.c In-Reply-To: <199703301212.EAA21994@freefall.freebsd.org> Message-Id: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Sun, 30 Mar 1997, Brian Somers wrote: > Added: lib/libutil uucplock.3 uucplock.c > Removed: sbin/startslip uucplock.c > Log: > Move uucplock into libutil and create a manual page. What you do with USE_PERROR define which switch uucplock error loging from perror to syslog? Startslip uses syslog and ppp not use it. It seems that you just broke ppp since you left USE_PERROR define in its Makefile which unused now. Moreover, having library function with syslog report is bad idea in any case. To fix it properly you need to change return from uucplock functions from int to char *, i.e. return NULL for no errors or static error string if error happens. Then you need to change upper level programs to pass this error string to perror/syslog/whatever. -- Andrey A. Chernov http://www.nagual.ru/~ache/ From owner-cvs-usrsbin Sun Mar 30 21:11:53 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id VAA17948 for cvs-usrsbin-outgoing; Sun, 30 Mar 1997 21:11:53 -0800 (PST) Received: (from imp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id VAA17941; Sun, 30 Mar 1997 21:11:50 -0800 (PST) Date: Sun, 30 Mar 1997 21:11:50 -0800 (PST) From: Warner Losh Message-Id: <199703310511.VAA17941@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/amd/amd get_args.c src/usr.sbin/amd/amq amq.c src/usr.sbin/amd/fsinfo fsinfo.c src/usr.sbin/amd/mk-amd-map mk-amd-map.c src/usr.sbin/config main.c src/usr.sbin/cron/cron cron.c src/usr.sbin/cron/crontab crontab.c src/usr.sbin/ctm/mkCTM mkctm.c src/usr.sbin/lpr/lpq lpq.c src/usr.sbin/lpr/lpr lpr.c src/usr.sbin/pcvt/demo playvt.c src/usr.sbin/pcvt/userkeys vt220keys.c src/usr.sbin/pkg_install/add main.c src/usr.sbin/pkg_install/delete main.c src/usr.sbin/rpc.yppasswdd yppasswdd_main.c src/usr.sbin/rpc.ypxfrd ypxfrd_main.c src/usr.sbin/ac ac.c src/usr.sbin/accton accton.c src/usr.sbin/apm apm.c src/usr.sbin/arp arp.c src/usr.sbin/bootparamd/bootparamd main.c src/usr.sbin/chown chown.c src/usr.sbin/chroot chroot.c src/usr.sbin/crunch/crunchide crunchide.c src/usr.sbin/dev_mkdb dev_mkdb.c src/usr.sbin/edquota edquota.c src/usr.sbin/fdcontrol fdcontrol.c src/usr.sbin/inetd inetd.c src/usr.sbin/iostat iostat.c src/usr.sbin/kgmon kgmon.c src/usr.sbin/kvm_mkdb kvm_mkdb.c src/usr.sbin/mkdosfs mkdosfs.c src/usr.sbin/moused moused.c src/usr.sbin/mtree mtree.c src/usr.sbin/newsyslog newsyslog.c src/usr.sbin/pciconf pciconf.c src/usr.sbin/pcvt/cursor cursor.c src/usr.sbin/pcvt/ispcvt ispcvt.c src/usr.sbin/pcvt/kcon kcon.c src/usr.sbin/pcvt/loadfont loadfont.c src/usr.sbin/pcvt/mcon mcon.c src/usr.sbin/pcvt/scon scon.c src/usr.sbin/pcvt/set2061 main.c src/usr.sbin/pkg_install/create main.c src/usr.sbin/pkg_install/info main.c src/usr.sbin/portmap portmap.c src/usr.sbin/pstat pstat.c src/usr.sbin/pwd_mkdb pwd_mkdb.c src/usr.sbin/qcamcontrol qcamcontrol.c src/usr.sbin/quotaon quotaon.c src/usr.sbin/rarpd rarpd.c src/usr.sbin/repquota repquota.c src/usr.sbin/rndcontrol rndcontrol.c src/usr.sbin/sendmail/contrib bitdomain.c src/usr.sbin/sendmail/mail.local mail.local.c src/usr.sbin/sendmail/mailstats mailstats.c src/usr.sbin/sendmail/makemap makemap.c src/usr.sbin/sendmail/praliases praliases.c src/usr.sbin/sendmail/rmail rmail.c src/usr.sbin/sysctl pathconf.c sysctl.c src/usr.sbin/syslogd syslog Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk imp 97/03/30 21:11:49 Modified: usr.sbin/ac ac.c usr.sbin/accton accton.c usr.sbin/amd/amd get_args.c usr.sbin/amd/amq amq.c usr.sbin/amd/fsinfo fsinfo.c usr.sbin/amd/mk-amd-map mk-amd-map.c usr.sbin/apm apm.c usr.sbin/arp arp.c usr.sbin/bootparamd/bootparamd main.c usr.sbin/chown chown.c usr.sbin/chroot chroot.c usr.sbin/config main.c usr.sbin/cron/cron cron.c usr.sbin/cron/crontab crontab.c usr.sbin/crunch/crunchide crunchide.c usr.sbin/ctm/mkCTM mkctm.c usr.sbin/dev_mkdb dev_mkdb.c usr.sbin/edquota edquota.c usr.sbin/fdcontrol fdcontrol.c usr.sbin/inetd inetd.c usr.sbin/iostat iostat.c usr.sbin/kgmon kgmon.c usr.sbin/kvm_mkdb kvm_mkdb.c usr.sbin/lpr/lpq lpq.c usr.sbin/lpr/lpr lpr.c usr.sbin/mkdosfs mkdosfs.c usr.sbin/moused moused.c usr.sbin/mtree mtree.c usr.sbin/newsyslog newsyslog.c usr.sbin/pciconf pciconf.c usr.sbin/pcvt/cursor cursor.c usr.sbin/pcvt/demo playvt.c usr.sbin/pcvt/ispcvt ispcvt.c usr.sbin/pcvt/kcon kcon.c usr.sbin/pcvt/loadfont loadfont.c usr.sbin/pcvt/mcon mcon.c usr.sbin/pcvt/scon scon.c usr.sbin/pcvt/set2061 main.c usr.sbin/pcvt/userkeys vt220keys.c usr.sbin/pkg_install/add main.c usr.sbin/pkg_install/create main.c usr.sbin/pkg_install/delete main.c usr.sbin/pkg_install/info main.c usr.sbin/portmap portmap.c usr.sbin/pstat pstat.c usr.sbin/pwd_mkdb pwd_mkdb.c usr.sbin/qcamcontrol qcamcontrol.c usr.sbin/quotaon quotaon.c usr.sbin/rarpd rarpd.c usr.sbin/repquota repquota.c usr.sbin/rndcontrol rndcontrol.c usr.sbin/rpc.yppasswdd yppasswdd_main.c usr.sbin/rpc.ypxfrd ypxfrd_main.c usr.sbin/sendmail/contrib bitdomain.c usr.sbin/sendmail/mail.local mail.local.c usr.sbin/sendmail/mailstats mailstats.c usr.sbin/sendmail/makemap makemap.c usr.sbin/sendmail/praliases praliases.c usr.sbin/sendmail/rmail rmail.c usr.sbin/sysctl pathconf.c sysctl.c usr.sbin/syslogd syslogd.c usr.sbin/tcpdump/tcpslice tcpslice.c usr.sbin/timed/timed timed.c usr.sbin/trpt trpt.c usr.sbin/vipw vipw.c usr.sbin/vnconfig vnconfig.c usr.sbin/watch watch.c usr.sbin/wormcontrol wormcontrol.c usr.sbin/yp_mkdb yp_mkdb.c usr.sbin/yppush yppush_main.c usr.sbin/ypserv yp_main.c usr.sbin/zic zic.c Log: compare return value from getopt against -1 rather than EOF, per the final posix standard on the topic. Revision Changes Path 1.7 +2 -2 src/usr.sbin/ac/ac.c 1.3 +1 -1 src/usr.sbin/accton/accton.c 1.4 +2 -2 src/usr.sbin/amd/amd/get_args.c 1.6 +3 -3 src/usr.sbin/amd/amq/amq.c 1.4 +2 -2 src/usr.sbin/amd/fsinfo/fsinfo.c 1.4 +3 -3 src/usr.sbin/amd/mk-amd-map/mk-amd-map.c 1.9 +1 -1 src/usr.sbin/apm/apm.c 1.10 +2 -2 src/usr.sbin/arp/arp.c 1.6 +2 -2 src/usr.sbin/bootparamd/bootparamd/main.c 1.5 +1 -1 src/usr.sbin/chown/chown.c 1.2 +1 -1 src/usr.sbin/chroot/chroot.c 1.17 +1 -1 src/usr.sbin/config/main.c 1.5 +2 -2 src/usr.sbin/cron/cron/cron.c 1.10 +2 -2 src/usr.sbin/cron/crontab/crontab.c 1.3 +1 -1 src/usr.sbin/crunch/crunchide/crunchide.c 1.8 +1 -1 src/usr.sbin/ctm/mkCTM/mkctm.c 1.2 +1 -1 src/usr.sbin/dev_mkdb/dev_mkdb.c 1.5 +1 -1 src/usr.sbin/edquota/edquota.c 1.4 +1 -1 src/usr.sbin/fdcontrol/fdcontrol.c 1.22 +2 -2 src/usr.sbin/inetd/inetd.c 1.7 +1 -1 src/usr.sbin/iostat/iostat.c 1.7 +1 -1 src/usr.sbin/kgmon/kgmon.c 1.6 +1 -1 src/usr.sbin/kvm_mkdb/kvm_mkdb.c 1.2 +55 -8 src/usr.sbin/lpr/lpq/lpq.c 1.14 +2 -2 src/usr.sbin/lpr/lpr/lpr.c 1.5 +2 -2 src/usr.sbin/mkdosfs/mkdosfs.c 1.9 +2 -2 src/usr.sbin/moused/moused.c 1.4 +1 -1 src/usr.sbin/mtree/mtree.c 1.10 +3 -3 src/usr.sbin/newsyslog/newsyslog.c 1.4 +1 -1 src/usr.sbin/pciconf/pciconf.c 1.5 +1 -1 src/usr.sbin/pcvt/cursor/cursor.c 1.3 +1 -1 src/usr.sbin/pcvt/demo/playvt.c 1.5 +1 -1 src/usr.sbin/pcvt/ispcvt/ispcvt.c 1.3 +1 -1 src/usr.sbin/pcvt/kcon/kcon.c 1.4 +1 -1 src/usr.sbin/pcvt/loadfont/loadfont.c 1.4 +1 -1 src/usr.sbin/pcvt/mcon/mcon.c 1.3 +1 -1 src/usr.sbin/pcvt/scon/scon.c 1.3 +1 -1 src/usr.sbin/pcvt/set2061/main.c 1.3 +1 -1 src/usr.sbin/pcvt/userkeys/vt220keys.c 1.14 +2 -2 src/usr.sbin/pkg_install/add/main.c 1.15 +2 -2 src/usr.sbin/pkg_install/create/main.c 1.9 +2 -2 src/usr.sbin/pkg_install/delete/main.c 1.13 +2 -2 src/usr.sbin/pkg_install/info/main.c 1.5 +1 -1 src/usr.sbin/portmap/portmap.c 1.29 +1 -1 src/usr.sbin/pstat/pstat.c 1.18 +1 -1 src/usr.sbin/pwd_mkdb/pwd_mkdb.c 1.5 +1 -1 src/usr.sbin/qcamcontrol/qcamcontrol.c 1.2 +1 -1 src/usr.sbin/quotaon/quotaon.c 1.16 +2 -2 src/usr.sbin/rarpd/rarpd.c 1.4 +1 -1 src/usr.sbin/repquota/repquota.c 1.8 +2 -2 src/usr.sbin/rndcontrol/rndcontrol.c 1.10 +3 -3 src/usr.sbin/rpc.yppasswdd/yppasswdd_main.c 1.5 +3 -3 src/usr.sbin/rpc.ypxfrd/ypxfrd_main.c 1.4 +1 -1 src/usr.sbin/sendmail/contrib/bitdomain.c 1.8 +2 -2 src/usr.sbin/sendmail/mail.local/mail.local.c 1.4 +1 -1 src/usr.sbin/sendmail/mailstats/mailstats.c 1.9 +1 -1 src/usr.sbin/sendmail/makemap/makemap.c 1.3 +1 -1 src/usr.sbin/sendmail/praliases/praliases.c 1.5 +2 -2 src/usr.sbin/sendmail/rmail/rmail.c 1.2 +1 -1 src/usr.sbin/sysctl/pathconf.c 1.13 +2 -2 src/usr.sbin/sysctl/sysctl.c 1.22 +2 -2 src/usr.sbin/syslogd/syslogd.c 1.4 +2 -2 src/usr.sbin/tcpdump/tcpslice/tcpslice.c 1.3 +2 -2 src/usr.sbin/timed/timed/timed.c 1.6 +1 -1 src/usr.sbin/trpt/trpt.c 1.4 +1 -1 src/usr.sbin/vipw/vipw.c 1.6 +1 -1 src/usr.sbin/vnconfig/vnconfig.c 1.14 +1 -1 src/usr.sbin/watch/watch.c 1.5 +2 -2 src/usr.sbin/wormcontrol/wormcontrol.c 1.7 +3 -3 src/usr.sbin/yp_mkdb/yp_mkdb.c 1.8 +3 -3 src/usr.sbin/yppush/yppush_main.c 1.15 +3 -3 src/usr.sbin/ypserv/yp_main.c 1.6 +1 -1 src/usr.sbin/zic/zic.c From owner-cvs-usrsbin Mon Mar 31 05:03:54 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id FAA16553 for cvs-usrsbin-outgoing; Mon, 31 Mar 1997 05:03:54 -0800 (PST) Received: (from peter@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id FAA16546; Mon, 31 Mar 1997 05:03:52 -0800 (PST) Date: Mon, 31 Mar 1997 05:03:52 -0800 (PST) From: Peter Wemm Message-Id: <199703311303.FAA16546@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/chown chgrp.1 chown.8 chown.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 97/03/31 05:03:51 Modified: usr.sbin/chown chgrp.1 chown.8 chown.c Log: Activate the -h flag which tells chown/chgrp to work on the symlink itself using lchown(). Most of the code was already here, the option was recognised but ignored for SYSV/POSIX.2(?) compatability. Revision Changes Path 1.3 +5 -12 src/usr.sbin/chown/chgrp.1 1.5 +8 -13 src/usr.sbin/chown/chown.8 1.6 +16 -13 src/usr.sbin/chown/chown.c From owner-cvs-usrsbin Mon Mar 31 05:37:57 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id FAA17838 for cvs-usrsbin-outgoing; Mon, 31 Mar 1997 05:37:57 -0800 (PST) Received: from awfulhak.demon.co.uk (awfulhak.demon.co.uk [158.152.17.1]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id FAA17810; Mon, 31 Mar 1997 05:37:34 -0800 (PST) Received: from awfulhak.demon.co.uk (localhost.lan.awfulhak.org [127.0.0.1]) by awfulhak.demon.co.uk (8.8.5/8.8.5) with ESMTP id OAA02346; Mon, 31 Mar 1997 14:37:00 +0100 (BST) Message-Id: <199703311337.OAA02346@awfulhak.demon.co.uk> X-Mailer: exmh version 1.6.9 8/22/96 To: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= cc: Brian Somers , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/slattach Makefile src/usr.bin/tip/tip Makefile src/usr.sbin/ppp Makefile src/lib/libutil uucplock.3 uucplock.c Makefile libutil.h src/sbin/startslip Makefile uucplock.c In-reply-to: Your message of "Mon, 31 Mar 1997 01:18:09 +0400." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 31 Mar 1997 14:36:59 +0100 From: Brian Somers Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > On Sun, 30 Mar 1997, Brian Somers wrote: > > > Added: lib/libutil uucplock.3 uucplock.c > > Removed: sbin/startslip uucplock.c > > Log: > > Move uucplock into libutil and create a manual page. > > What you do with USE_PERROR define which switch uucplock > error loging from perror to syslog? Startslip uses syslog > and ppp not use it. It seems that you just broke ppp since > you left USE_PERROR define in its Makefile which unused > now. Moreover, having library function with syslog report > is bad idea in any case. > > To fix it properly you need to change return from uucplock functions > from int to char *, i.e. return NULL for no errors or static error > string if error happens. Then you need to change upper level programs > to pass this error string to perror/syslog/whatever. > > -- > Andrey A. Chernov > > http://www.nagual.ru/~ache/ Oops, thanks. I'll do the char* thing. -- Brian , Don't _EVER_ lose your sense of humour.... From owner-cvs-usrsbin Mon Mar 31 06:28:20 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA19727 for cvs-usrsbin-outgoing; Mon, 31 Mar 1997 06:28:20 -0800 (PST) Received: from awfulhak.demon.co.uk (awfulhak.demon.co.uk [158.152.17.1]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id GAA19715; Mon, 31 Mar 1997 06:28:13 -0800 (PST) Received: from awfulhak.demon.co.uk (localhost.lan.awfulhak.org [127.0.0.1]) by awfulhak.demon.co.uk (8.8.5/8.8.5) with ESMTP id PAA04005; Mon, 31 Mar 1997 15:27:12 +0100 (BST) Message-Id: <199703311427.PAA04005@awfulhak.demon.co.uk> X-Mailer: exmh version 1.6.9 8/22/96 To: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= cc: Brian Somers , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/slattach Makefile src/usr.bin/tip/tip Makefile src/usr.sbin/ppp Makefile src/lib/libutil uucplock.3 uucplock.c Makefile libutil.h src/sbin/startslip Makefile uucplock.c In-reply-to: Your message of "Mon, 31 Mar 1997 01:18:09 +0400." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 31 Mar 1997 15:27:12 +0100 From: Brian Somers Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > On Sun, 30 Mar 1997, Brian Somers wrote: > > > Added: lib/libutil uucplock.3 uucplock.c > > Removed: sbin/startslip uucplock.c > > Log: > > Move uucplock into libutil and create a manual page. > > What you do with USE_PERROR define which switch uucplock > error loging from perror to syslog? Startslip uses syslog > and ppp not use it. It seems that you just broke ppp since > you left USE_PERROR define in its Makefile which unused > now. Moreover, having library function with syslog report > is bad idea in any case. > > To fix it properly you need to change return from uucplock functions > from int to char *, i.e. return NULL for no errors or static error > string if error happens. Then you need to change upper level programs > to pass this error string to perror/syslog/whatever. > > -- > Andrey A. Chernov > > http://www.nagual.ru/~ache/ On second thoughts, a return value of UU_LOCK_OPEN_ERR, UU_LOCK_READ_ERR, UU_LOCK_SEEK_ERR, UU_LOCK_WRITE_ERR, UU_LOCK_INUSE_ERR or UU_LOCK_OK (#define'd in libutil.h) with errno set to the error would be more appropriate. -- Brian , Don't _EVER_ lose your sense of humour.... From owner-cvs-usrsbin Mon Mar 31 08:56:48 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id IAA26949 for cvs-usrsbin-outgoing; Mon, 31 Mar 1997 08:56:48 -0800 (PST) Received: from sovcom.kiae.su (sovcom.kiae.su [193.125.152.1]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id IAA26880; Mon, 31 Mar 1997 08:55:11 -0800 (PST) Received: by sovcom.kiae.su id AA17785 (5.65.kiae-1 ); Mon, 31 Mar 1997 18:46:19 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Mon, 31 Mar 97 18:46:19 +0300 Received: (from ache@localhost) by nagual.ru (8.8.5/8.8.5) id TAA00626; Mon, 31 Mar 1997 19:45:40 +0400 (MSD) Date: Mon, 31 Mar 1997 19:45:38 +0400 (MSD) From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= To: Brian Somers Cc: Brian Somers , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/slattach Makefile src/usr.bin/tip/tip Makefile src/usr.sbin/ppp Makefile src/lib/libutil uucplock.3 uucplock.c Makefile libutil.h src/sbin/startslip Makefile uucplock.c In-Reply-To: <199703311427.PAA04005@awfulhak.demon.co.uk> Message-Id: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Mon, 31 Mar 1997, Brian Somers wrote: > On second thoughts, a return value of UU_LOCK_OPEN_ERR, > UU_LOCK_READ_ERR, UU_LOCK_SEEK_ERR, UU_LOCK_WRITE_ERR, > UU_LOCK_INUSE_ERR or UU_LOCK_OK (#define'd in libutil.h) > with errno set to the error would be more appropriate. Ok, but you need a wrapper which convert return error code to diagnostic string in any case. It can be done via something like uustrerror() or manually into each program. -- Andrey A. Chernov http://www.nagual.ru/~ache/ From owner-cvs-usrsbin Mon Mar 31 14:51:03 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id OAA15003 for cvs-usrsbin-outgoing; Mon, 31 Mar 1997 14:51:03 -0800 (PST) Received: (from brian@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id OAA14996; Mon, 31 Mar 1997 14:51:01 -0800 (PST) Date: Mon, 31 Mar 1997 14:51:01 -0800 (PST) From: Brian Somers Message-Id: <199703312251.OAA14996@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-lib, cvs-usrbin, cvs-sbin, cvs-usrsbin Subject: cvs commit: src/usr.bin/tip/tip Makefile hunt.c src/lib/libutil libutil.h uucplock.3 uucplock.c src/sbin/slattach slattach.c src/sbin/startslip startslip.c src/usr.sbin/ppp Makefile modem.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk brian 97/03/31 14:51:01 Modified: lib/libutil libutil.h uucplock.3 uucplock.c sbin/slattach slattach.c sbin/startslip startslip.c usr.bin/tip/tip Makefile hunt.c usr.sbin/ppp Makefile modem.c Log: Remove the syslog stuff, and allow various return values in uu_lock(). Add uu_lockerr() for turning the results of uu_lock into something printable. Remove bogus section in man page about race conditions allowing both processes to get the lock. Include libutil.h and use uu_lock() correctly where it should. Suggested by: ache@freebsd.org Revision Changes Path 1.6 +9 -1 src/lib/libutil/libutil.h 1.2 +77 -14 src/lib/libutil/uucplock.3 1.2 +59 -33 src/lib/libutil/uucplock.c 1.27 +10 -3 src/sbin/slattach/slattach.c 1.24 +6 -2 src/sbin/startslip/startslip.c 1.8 +0 -1 src/usr.bin/tip/tip/Makefile 1.2 +6 -1 src/usr.bin/tip/tip/hunt.c 1.18 +2 -2 src/usr.sbin/ppp/Makefile 1.32 +9 -4 src/usr.sbin/ppp/modem.c From owner-cvs-usrsbin Wed Apr 2 06:35:01 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA02332 for cvs-usrsbin-outgoing; Wed, 2 Apr 1997 06:35:01 -0800 (PST) Received: (from wosch@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA02323; Wed, 2 Apr 1997 06:34:59 -0800 (PST) Date: Wed, 2 Apr 1997 06:34:59 -0800 (PST) From: Wolfram Schneider Message-Id: <199704021434.GAA02323@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/adduser rmuser.perl Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk wosch 97/04/02 06:34:58 Modified: usr.sbin/adduser rmuser.perl Log: Variable name typo. Reviewed by: Guy Helmer Revision Changes Path 1.7 +2 -2 src/usr.sbin/adduser/rmuser.perl From owner-cvs-usrsbin Thu Apr 3 12:22:02 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id MAA13713 for cvs-usrsbin-outgoing; Thu, 3 Apr 1997 12:22:02 -0800 (PST) Received: from gvr.win.tue.nl (root@gvr.win.tue.nl [131.155.210.19]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id MAA13699; Thu, 3 Apr 1997 12:21:45 -0800 (PST) Received: (from guido@localhost) by gvr.win.tue.nl (8.8.5/8.8.2) id WAA12686; Thu, 3 Apr 1997 22:21:41 +0200 (MET DST) From: Guido van Rooij Message-Id: <199704032021.WAA12686@gvr.win.tue.nl> Subject: Re: cvs commit: src/usr.sbin/adduser rmuser.perl In-Reply-To: <199704021434.GAA02323@freefall.freebsd.org> from Wolfram Schneider at "Apr 2, 97 06:34:59 am" To: wosch@freefall.freebsd.org (Wolfram Schneider) Date: Thu, 3 Apr 1997 22:21:41 +0200 (MET DST) Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org X-Mailer: ELM [version 2.4ME+ PL28 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Wolfram Schneider wrote: > wosch 97/04/02 06:34:58 > > Modified: usr.sbin/adduser rmuser.perl > Log: > Variable name typo. Who is THE adduser specialist nowadays? -Guido From owner-cvs-usrsbin Thu Apr 3 16:49:40 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id QAA01136 for cvs-usrsbin-outgoing; Thu, 3 Apr 1997 16:49:40 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id QAA01127; Thu, 3 Apr 1997 16:49:38 -0800 (PST) Date: Thu, 3 Apr 1997 16:49:38 -0800 (PST) From: Mike Pritchard Message-Id: <199704040049.QAA01127@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/pwd_mkdb pwd_mkdb.8 Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk mpp 97/04/03 16:49:37 Modified: usr.sbin/pwd_mkdb pwd_mkdb.8 Log: Document the -u option. Forgotten by: guido Revision Changes Path 1.4 +6 -1 src/usr.sbin/pwd_mkdb/pwd_mkdb.8 From owner-cvs-usrsbin Thu Apr 3 16:50:48 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id QAA01322 for cvs-usrsbin-outgoing; Thu, 3 Apr 1997 16:50:48 -0800 (PST) Received: (from mpp@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id QAA01305; Thu, 3 Apr 1997 16:50:45 -0800 (PST) Date: Thu, 3 Apr 1997 16:50:45 -0800 (PST) From: Mike Pritchard Message-Id: <199704040050.QAA01305@freefall.freebsd.org> To: CVS-committers, cvs-all, cvs-usrsbin Subject: cvs commit: src/usr.sbin/pwd_mkdb pwd_mkdb.8 Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk mpp 97/04/03 16:50:44 Branch: usr.sbin/pwd_mkdb RELENG_2_2 Modified: usr.sbin/pwd_mkdb pwd_mkdb.8 Log: YAMFC: document the -u option. Revision Changes Path 1.3.2.1 +6 -1 src/usr.sbin/pwd_mkdb/pwd_mkdb.8