Date: Sun, 25 Jul 1999 00:30:44 -0700 (PDT) From: Matthew Dillon <dillon@apollo.backplane.com> To: "David E. Cross" <crossd@cs.rpi.edu> Cc: freebsd-hackers@FreeBSD.ORG, crossd@cs.rpi.edu Subject: Re: mbuf leak found... for real this time. Message-ID: <199907250730.AAA37426@apollo.backplane.com> References: <199907241935.PAA13884@cs.rpi.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
:> between NFSv2 and NFSv3.
:Yes, I concur with your patch whole-heartedly. Apparently last night I
:was too-tired, and not intoxicated enough to understand the nfs_serv.c code :)
:
:I alas will not be able to test it. The machine is up and stable with 3k
:mbufs in reserve.. maybe later :)
:
:As an aside, what about getting rid of that mbuf leak if a nfs-service
:routine returns with error!=0?
:
:--
:David Cross | email: crossd@cs.rpi.edu
Well, theoretically we just free the mbuf in the error case within
nfs_syscalls.c/nfssvc_nfsd(), around line 661 (STABLE), or 650 (CURRENT).
Realistically every single nfs server procedure would need to be audited
to make sure that a non-NULL *mreq is valid in all error cases - not something
I particularly want to do without commit privs from a crediting point of view.
-Matt
Matthew Dillon
<dillon@backplane.com>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199907250730.AAA37426>